On Mon, Feb 19, 2018 at 07:23:14PM +0900, Chanwoo Choi wrote:
> Dear Greg,
>
> This is extcon-fixes pull request for v4.16-rc3. I add detailed description of
> this pull request on below. Please pull extcon with following updates.
>
> Best Regards,
> Chanwoo Choi
>
> The following changes since
Manivannan,
On Sat, Feb 17, 2018 at 9:44 PM, Manivannan Sadhasivam
wrote:
> Add gpio driver for Actions Semi OWL family S900 SoC. Set of registers
> controlling the gpio shares the same register range with pinctrl block.
>
> GPIO registers are organized as 6 banks and each bank controls the
> max
On 19.02.2018 20:59, Dmitry Vyukov wrote:
On Sat, Feb 3, 2018 at 1:15 PM, Xin Long wrote:
On 1/30/18 1:57 PM, David Ahern wrote:
On 1/30/18 1:08 PM, Daniel Borkmann wrote:
On 01/30/2018 07:32 PM, Cong Wang wrote:
On Tue, Jan 30, 2018 at 4:09 AM, Dmitry Vyukov wrote:
Hello,
The following p
On Tue, Feb 20, 2018 at 12:53:26PM +0530, Ivid Suvarna wrote:
> Hi All,
>
> Facing below warning backtrace during resume from suspend to disk. I
> am using 4.1.15 freescale kernel.
4.1.15 is a kernel that is very old and obsolete (released almost 3
years ago, and tens of thousands of changes old.
Dear Manivannan,
On Sat, Feb 17, 2018 at 9:44 PM, Manivannan Sadhasivam
wrote:
> Add pinctrl driver for Actions Semi S900 SoC. The driver supports
> pinctrl, pinmux and pinconf functionalities through a range of registers
> common to both gpio driver and pinctrl driver.
>
> Pinmux functionality i
Hi Moritz,
On Fri, Feb 16, 2018 at 6:00 PM, Moritz Fischer wrote:
> Add support for the National Instruments XGE 1/10G network device.
>
> It uses the EEPROM on the board via NVMEM.
>
> Signed-off-by: Moritz Fischer
> --- /dev/null
> +++ b/drivers/net/ethernet/ni/nixge.c
> @@ -0,0 +1,1352 @@
On Mon, 19 Feb 2018, David Woodhouse wrote:
> Retpoline means the kernel is safe because it has no indirect branches.
> But firmware isn't, so use IBRS for firmware calls if it's available.
>
> Block preemption while IBRS is set, although in practice the call sites
> already had to be doing that.
On Sun, Feb 18, 2018 at 9:18 PM, Joe Perches wrote:
> On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote:
>> Hi Philippe,
>>
>> On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne
>> wrote:
>> > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda
>> > wrote:
>> > > Cc: Willy Tarreau
>> > >
Using just the leaf page table entry flags would cause a false warning
in case _PAGE_RW is clear or _PAGE_NX is set in a higher level entry.
Hand through both the current entry's flags as well as the accumulated
effective value (the latter as pgprotval_t instead of pgprot_t, as it's
not an actual e
... since u64 has a hidden header dependency that was not there before
using it (i.e. it breaks our VMM build). Also, __u64 is the right way to
expose the data type through UAPI.
Fixes: 93286261 ("x86/hyperv: Reenlightenment notifications support")
Signed-off-by: KarimAllah Ahmed
Cc: K. Y. Sriniv
On Tue, Feb 20, 2018 at 5:44 AM, Alexandre Courbot
wrote:
> Add a v4l2 request entity data structure that takes care of storing the
> request-related state of a V4L2 device ; in this case, its controls.
>
> Signed-off-by: Alexandre Courbot
> --- /dev/null
> +++ b/drivers/media/v4l2-core/v4l2-r
* Josh Poimboeuf wrote:
> > -.macro DO_SWITCH_TO_THREAD_STACK
> > +/* 8(%rsp): ~(interrupt number) */
> > +ENTRY(interrupt_helper)
>
> "interrupt_helper" is a bit vague, how about "interrupt_entry"? That
> better describes its purpose and also makes it more analagous to
> paranoid_entry() and
Matthew,
On Mon, Feb 19, 2018 at 8:45 PM, Matthew Wilcox wrote:
> From: Matthew Wilcox
>
> This first function in the XArray API brings with it a lot of support
> infrastructure. The advanced API is based around the xa_state which is
> a more capable version of the radix_tree_iter.
>
> As the t
Jerry,
On Sat, Feb 17, 2018 at 5:17 PM, Guenter Roeck wrote:
> On Thu, Feb 15, 2018 at 04:43:53PM -0700, Jerry Hoemann wrote:
>> Minor white space changes and some name clean up.
>>
>> Signed-off-by: Jerry Hoemann
>> ---
>> drivers/watchdog/hpwdt.c | 49
>> +++--
Hi Niklas
I had a look at this series that looks ok for me.
Acked-by: Giuseppe Cavallaro
On 2/19/2018 6:11 PM, Niklas Cassel wrote:
The DMA engine in dwmac4 can segment a large TSO packet to several
smaller packets of (max) size Maximum Segment Size (MSS).
The DMA engine fetches and saves th
Changbin, Steven,
On Sat, Feb 17, 2018 at 6:39 AM, wrote:
> From: Changbin Du
>
> This converts the plain text documentation to reStructuredText format and
> add it into Sphinx TOC tree. No essential content change.
>
> Cc: Steven Rostedt
> Signed-off-by: Changbin Du
> ---
> Documentation/tr
Dave,
On Fri, Feb 16, 2018 at 10:40 PM, Dave Gerlach wrote:
> Although similar to AM33XX, introduce a new low-level asm file for
> suspend containing new context save and restore paths for EMIF and l2
> cache disabling and enabling.
>
> Signed-off-by: Dave Gerlach
> ---
> arch/arm/mach-omap2/sl
> On Mon, Feb 19, 2018 at 01:28:32PM -0300, rodrigosiqueira wrote:
^^^
This looks good, but you need to fix your from email header.
regards,
dan carpenter
Hi All,
Facing below warning backtrace during resume from suspend to disk. I
am using 4.1.15 freescale kernel. After this warning there is a huge
time gap (nearly 10 sec) between Enabling non-boot cpus and CPU1 being
up. Any pointers on this would be helpful.
[ 545.227081] Hardware name: Freesca
Fix a coding style problem.
Signed-off-by: Quytelda Kahja
---
This is the patch without the unnecessary fixes for line length.
drivers/staging/media/bcm2048/radio-bcm2048.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/media/bcm2048
Good day dear, i hope this mail meets you well? my name is Jack, from the U.S.
I know this may seem inappropriate so i ask for your forgiveness but i wish to
get to know you better, if I may be so bold. I consider myself an easy-going
man, adventurous, honest and fun loving person but I am curre
Convert the unsafe macros into inline functions.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 975dbb
Convert the unsafe macro into an inline function.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index f554477fe6bc..74a08
Convert the unsafe macros into inline functions.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks7010_sdio.c | 46 ++--
1 file changed, 33 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging/ks7010/ks7010
On Tue, Feb 20, 2018 at 06:24:47AM +0100, Micha?? K??pie?? wrote:
> This patch series contains miscellaneous cleanups which I think are
> worth getting done before splitting fujitsu-laptop into two separate
> modules.
>
> Changes from v1:
>
> - [6/7] Rename BACKLIGHT_POWER to BACKLIGHT_PARAM_PO
When autoneg is off, the .check_for_link callback functions clear the
get_link_status flag and systematically return a "pseudo-error". This means
that the link is not detected as up until the next execution of the
e1000_watchdog_task() 2 seconds later.
Fixes: 19110cfbb34d ("e1000e: Separate signal
Different functions in the module use varying names (error, result,
status) for a local variable storing the return value of a function call
that has to be checked for errors. Use a common name (ret) for all
these local variables to improve code consistency. Merge integer
variable declarations in
Replace the last few lines of acpi_fujitsu_bl_add() with a simple return
in order to improve code readability without changing the logic.
As acpi_fujitsu_laptop_add() uses a managed memory allocation for
device-specific data, it is fine to just return immediately upon kfifo
allocation failure. Do
Do not include linux/slab.h as all module code now uses managed memory
allocations and thus neither k*alloc() nor kfree() is used.
Signed-off-by: Michał Kępień
---
drivers/platform/x86/fujitsu-laptop.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/fujitsu-laptop.c
b/dr
In order to improve code clarity, move declarations of variables that
are module parameters higher up and add a comment.
Signed-off-by: Michał Kępień
---
drivers/platform/x86/fujitsu-laptop.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/fujitsu-l
Align all constant values defined in the module to a common indentation.
Rename ACPI_FUJITSU_NOTIFY_CODE1 to ACPI_FUJITSU_NOTIFY_CODE as there is
only one ACPI notification code used throughout the driver. Define all
bitmasks using the BIT() macro. Clean up comments.
Signed-off-by: Michał Kępień
Only register input devices after the device-specific data structures
they access are fully initialized.
Signed-off-by: Michał Kępień
---
drivers/platform/x86/fujitsu-laptop.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/platform/x86/fujitsu-laptop
This patch series contains miscellaneous cleanups which I think are
worth getting done before splitting fujitsu-laptop into two separate
modules.
Changes from v1:
- [6/7] Rename BACKLIGHT_POWER to BACKLIGHT_PARAM_POWER.
- [6/7] Use BACKLIGHT_OFF instead of a numeric constant.
- [7/7] Incl
Use named constants instead of integers in call_fext_func() invocations
related to backlight power control in order to more clearly convey the
intent of each call.
Signed-off-by: Michał Kępień
---
drivers/platform/x86/fujitsu-laptop.c | 14 +++---
1 file changed, 11 insertions(+), 3 dele
Hi Jacopo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.16-rc2 next-20180220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com
Fixes: 42b7d5be5f1f ("media: i2c: ov772x: Support frame interval handling")
Signed-off-by: Fengguang Wu
---
ov772x.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
index eba71d97..0d8ce2a 100644
--- a/drivers/media/i
On 2018-01-20 12:05, Oza Pawandeep wrote:
This patch set brings in error handling support for DPC
The current implementation of AER and error message broadcasting to the
EP driver is tightly coupled and limited to AER service driver.
It is important to factor out broadcasting and other link hand
Juergen Gross:
> On 07/02/18 23:22, Simon Gaiser wrote:
>> Commit fd8aa9095a95 ("xen: optimize xenbus driver for multiple
>> concurrent xenstore accesses") made a subtle change to the semantic of
>> xenbus_dev_request_and_reply() and xenbus_transaction_end().
>>
>> Before on an error response to XS
(resending with correct word-wrap - sorry for the inconvenience)
Hi everyone,
And thanks for all the feedback on the previous version! I have tried to address
as much as possible, which results in (another) almost rewrite. But I think the
behavior and structure are converging to something satisfy
From: Hans Verkuil
Add the four core request functions:
v4l2_ctrl_request_init() initializes a new (empty) request.
v4l2_ctrl_request_clone() resets a request based on another request
(or clears it if that request is NULL).
v4l2_ctrl_request_get(): increase refcount
v4l2_ctrl_request_put(): decr
From: Hans Verkuil
Add a 'bool from_other_dev' argument: set to true if the two
handlers refer to different devices (e.g. it is true when
inheriting controls from a subdev into a main v4l2 bridge
driver).
This will be used later when implementing support for the
request API since we need to skip
The request API provides a way to group buffers and device parameters
into units of work to be queued and executed. This patch introduces the
UAPI and core framework.
This patch is based on the previous work by Laurent Pinchart. The core
has changed considerably, but the UAPI is mostly untouched.
From: Hans Verkuil
The v4l2_g/s_ext_ctrls functions now support control handlers that
represent requests.
Signed-off-by: Hans Verkuil
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-ctrls.c | 37 +---
1 file changed, 33 insertions(+), 4 deletions(-)
From: Hans Verkuil
The next patch needs the reference to a control instead of the
control itself, so change struct v4l2_ctrl_helper accordingly.
Signed-off-by: Hans Verkuil
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-ctrls.c | 18 +-
1 file changed, 9 ins
Only standard controls can be successfully cloned: handler_new_ref, used
by v4l2_ctrl_request_clone(), forcibly calls v4l2_ctrl_new_std() which
fails to find custom controls names, and we eventually hit the condition
that name == NULL in v4l2_ctrl_new().
This prevents us from using non-standard co
From: Hans Verkuil
Add a helper function that can set controls from a request.
Signed-off-by: Hans Verkuil
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-ctrls.c | 71
include/media/v4l2-ctrls.h | 2 +
2 files changed, 73 insertions(+
From: Hans Verkuil
When queuing buffers allow for passing the request that should
be associated with this buffer.
Signed-off-by: Hans Verkuil
[acour...@chromium.org: make request ID 32-bit]
Signed-off-by: Alexandre Courbot
---
drivers/media/common/videobuf2/videobuf2-v4l2.c | 2 +-
drivers/me
Allow drivers to assign a request entity to v4l2_fh. This will be useful
for request-aware ioctls to find out which request entity to use.
Signed-off-by: Alexandre Courbot
---
include/media/v4l2-fh.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/media/v4l2-fh.h b/include/media/v
Add a new VIDIOC_NEW_REQUEST ioctl, which allows to instanciate requests
on devices that support the request API. Requests created that way can
only control the device they originate from, making them suitable for
simple devices, but not complex pipelines.
Signed-off-by: Alexandre Courbot
---
Do
Make vb2 core aware of requests. Drivers can specify whether a given
queue accepts requests or not.
Signed-off-by: Alexandre Courbot
---
drivers/media/common/videobuf2/videobuf2-core.c | 3 +++
include/media/videobuf2-core.h | 4
2 files changed, 7 insertions(+)
diff --git
Allow to specify a request to be used with the S_EXT_CTRLS and
G_EXT_CTRLS operations.
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
include/uapi/linux/videodev2.h | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/v4l2
Read and use the request_fd field of struct v4l2_ext_controls to apply
VIDIOC_G_EXT_CTRLS or VIDIOC_S_EXT_CTRLS to a request when asked by
userspace.
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/omap3isp/ispvideo.c | 2 +-
drivers/media/v4l2-core/v4l2-ctrls.c | 98 +
Allow to use requests with the video capture device.
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/vivid/Kconfig | 1 +
drivers/media/platform/vivid/vivid-core.c | 63 ++-
drivers/media/platform/vivid/vivid-core.h | 3 +
.../media/platform/vivid/v
Add a new MEDIA_IOC_NEW_REQUEST ioctl, which can be used to instantiate
a request suitable to control the media device topology as well as the
parameters and buffer flow of its entities.
This is still very early work, and mainly here to demonstrate that it is
still possible to bind requests to med
Set the necessary ops for supporting requests in vim2m.
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/Kconfig | 1 +
drivers/media/platform/vim2m.c | 75 ++
2 files changed, 76 insertions(+)
diff --git a/drivers/media/platform/Kconfig b/drivers/med
Add a new vb2_qbuf_request() (a request-aware version of vb2_qbuf())
that request-aware drivers can call to queue a buffer into a request
instead of directly into the vb2 queue if relevent.
This function expects that drivers invoking it are using instances of
v4l2_request_entity and v4l2_request_e
Document the request API for V4L2 devices, and amend the documentation
of system calls influenced by it.
Signed-off-by: Alexandre Courbot
---
Documentation/media/uapi/v4l/buffer.rst | 9 +-
Documentation/media/uapi/v4l/common.rst | 1 +
Documentation/media/uapi/v4l/request-api.rs
Add generic support for requests to the mem2mem framework. This just
requires calling vb2_qbuf_request() instead of vb2_qbuf() in
v4l2_m2m_qbuf().
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-mem2mem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dri
Add a v4l2 request entity data structure that takes care of storing the
request-related state of a V4L2 device ; in this case, its controls.
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/Makefile | 1 +
drivers/media/v4l2-core/v4l2-request.c | 178 +
From: Hans Verkuil
Add a refcount and is_request bool to struct v4l2_ctrl_handler:
this is used to refcount a handler that represents a request.
Add a p_req field to struct v4l2_ctrl_ref that will store the
request value.
Signed-off-by: Hans Verkuil
Signed-off-by: Alexandre Courbot
---
drive
Hi everyone,
And thanks for all the feedback on the previous version! I have tried to
address as much as possible, which results in (another) almost rewrite. But I
think the behavior and structure are converging to something satisfying and
usable.
Besides the buffer queuing behavior that has b
Hi Abhishek,
On 2/19/2018 6:51 PM, Abhishek Sahu wrote:
> On 2018-02-16 13:14, Sricharan R wrote:
>> Hi Abhishek,
>>
>> On 2/3/2018 1:28 PM, Abhishek Sahu wrote:
>>> Following are the major issues in current driver code
>>>
>>> 1. The current driver simply assumes the transfer completion
>>> wh
Hi Jacopo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.16-rc2 next-20180220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com
Lustre networking driver. (Or so I was taught)
Regards,
Patrick
From: lustre-devel on behalf of
NeilBrown
Sent: Monday, February 19, 2018 8:23:37 PM
To: Oleg Drokin; James Simmons; Andreas Dilger; Greg Kroah-Hartman
Cc: lkml; lustre
Subject: [lustre-
From: Finn Thain
Date: Tue, 20 Feb 2018 11:42:26 +1100 (AEDT)
> If there was an unused variables I would happily remove that too but the
> 'version' string is not unused. The etherh.c and mac8390.c files both
> include "lib8390.c" and in there you'll find the 'version' string used in
> ethdev_
On Fri, Feb 16, 2018 at 12:03:11PM +, Mark Brown wrote:
> On Thu, Feb 15, 2018 at 05:52:20PM +, Charles Keepax wrote:
> > Since the handling for max_raw_read is now inside regmap_raw_read there
> > should be no need for client drivers to query as max_raw_read.
>
> No, they might need to kn
On 09/02/18 10:25, Joerg Roedel wrote:
> Hi,
>
> here is the second version of my PTI implementation for
> x86_32, based on tip/x86-pti-for-linus. It took a lot longer
> than I had hoped, but there have been a number of obstacles
> on the way. It also isn't the small patch-set anymore that v1
> wa
Greetings;
I'm Mr Juan Colombas from Lloyds banking Group United Kingdom. I want to invest
in your country with you. You can view my website and contact me for more
details
http://www.lloydsbankinggroup.com/our-group/directors/executive-directors/
Mr. Juan Colombas
Email:jcolomb...@gmail.c
Hi Jacopo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.16-rc2 next-20180220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci
On Mon, Feb 19, 2018 at 4:18 PM, Mylène Josserand
wrote:
> Add the support for A83T.
>
> A83T SoC has an additional register than A80 to handle CPU configurations:
> R_CPUS_CFG. Information about the register comes from Allwinner's BSP
> driver.
> An important difference is the Power Off Gating re
Hi Thomas,
On 2/19/2018 3:16 PM, Thomas Gleixner wrote:
> On Mon, 19 Feb 2018, Reinette Chatre wrote:
>> On 2/19/2018 12:57 PM, Thomas Gleixner wrote:
>>> On Tue, 13 Feb 2018, Reinette Chatre wrote:
>>>
System administrator creates/removes pseudo-locked regions by
creating/removing direc
On Sat, Feb 17, 2018 at 9:54 PM, Philipp Rossak wrote:
>
>
> On 17.02.2018 14:05, Chen-Yu Tsai wrote:
>>
>> When support for the A31/A31s CCU was first added, the clock ops for
>> the CLK_OUT_* clocks was set to the wrong type. The clocks are MP-type,
>> but the ops was set for div (M) clocks. Thi
On Mon, Feb 19, 2018 at 4:05 PM, Maxime Ripard
wrote:
> On Sat, Feb 17, 2018 at 01:01:12PM +0800, Chen-Yu Tsai wrote:
>> Various parts of the assembly code used in the multi-cluster SMP support
>> requires ARMv7-A. If the kernel config also has multi v6 support enabled,
>> Kbuild defaults to build
Hi Thomas,
On 2/19/2018 3:19 PM, Thomas Gleixner wrote:
> On Mon, 19 Feb 2018, Reinette Chatre wrote:
>> On 2/19/2018 1:19 PM, Thomas Gleixner wrote:
>>> On Tue, 13 Feb 2018, Reinette Chatre wrote:
>>>
After a pseudo-locked region is locked it needs to be associated with
the RDT domain r
The DCache clean & ICache invalidation requirements for instructions
to be data coherence are discoverable through new fields in CTR_EL0.
The following two control bits DIC and IDC were defined for this
purpose. No need to perform point of unification cache maintenance
operations from software on s
Hi, Andy,
Many thanks for the change. I am on Chinese New Year travel and slow
response. :-)
Thanks.
Shunyong.
On Fri, 2018-02-16 at 23:07 +0200, Andy Shevchenko wrote:
> From: Shunyong Yang
>
> Before crng is ready, output of "%p" composes of "(ptrval)" and
> left padding spaces for alignment
Hi, Jon,
On Mon, 2018-02-19 at 14:13 -0500, Jon Masters wrote:
> On 02/02/2018 07:12 AM, Wang, Dongsheng wrote:
> >
> > Hey, Hanjun,
> >
> > On 2018/2/2 19:54:24, "Hanjun Guo" wrote:
> >
> > >
> > > On 2018/2/2 18:25, Yang Shunyong wrote:
> > > >
> > > > Loading IORT table from initrd is use
Hi all,
Changes since 20180219:
The sound-asoc tree lost its build failures.
Non-merge commits (relative to Linus' tree): 2441
2914 files changed, 105361 insertions(+), 55486 deletions(-)
I have created to
On 02/19/2018 01:16 PM, Aishwarya Pant wrote:
Documentation has been compiled from git commit logs and descriptions in
Documentation/aoe/aoe.txt. This should be useful for scripting and
tracking changes in the ABI.
I don't see any problems with v3. Thank you.
--
Ed
ksnc_rx_iov_space is currently a union of two arrays,
one of 'struct kvec', the other of 'struct bio_vec'.
The 'struct bio_vec' option is never used. The
array of kvec is used to read in a packet header, or
to read data that needs to be skipped so as to synchronize
with a packet boundary.
In each
There is no "struct cfs_crypto_hash_desc" structure. There
are only pointers to this structure, which are cast back and
forth to struct ahash_request.
So discard cfs_crypto_hash_desc, and just use ahash_request directly.
Signed-off-by: NeilBrown
---
.../lustre/include/linux/libcfs/libcfs_crypto
1/ use list_for_each_entry_safe() instead of
list_for_each_safe() and similar.
2/ use list_first_entry() and list_last_entry() where appropriate.
3/ When removing everything from a list, use
while ((x = list_first_entry_or_null()) {
as it makes the intent clear
4/ No need to take a sp
Rather than open-coding a wait event loop twice,
use wait_event_cmd() to wait, dropping the spinlock
over schedule().
This does require duplicating part of the wait
condition, but that is just three tests on values that
are in registers or in cache, so the cost is small
and the increased readabilit
When fid fetches a new range from the server, it commits
to it (*output = *out) *before* performing sanity checks.
This looks backwards.
Don't commit to a value until it has been found to be sane.
Signed-off-by: NeilBrown
---
drivers/staging/lustre/lustre/fid/fid_request.c | 10 +-
1 f
There is only one place where this lock is held
while the task might sleep - in
ldebugfs_fid_space_seq_write()
while ldebugfs_fid_write_common() is called.
This call can easily be taken out of the locked region
by asking it to parse the user data into a local variable,
and then copying that vari
Possible the most interesting is the for-loop with
no body. I think it reads better as a while loop.
Signed-off-by: NeilBrown
---
.../lustre/lnet/klnds/socklnd/socklnd_lib.c|2 +-
.../staging/lustre/lnet/libcfs/linux/linux-cpu.c |2 +-
drivers/staging/lustre/lustre/include/obd
lcs_space can change while the lock is not held
if an RPC in underway. This can be detected by
seq->ls_update being set.
In this case, reading or writing the value should return
-EBUSY.
Also, the D_INFO CDEBUG() which reports the lcs_space being
updated never fires, as it tests the wrong value -
seq_fid_alloc_fini() is tiny and only called
from two places in the one function. We can move
both those calls earlier and merge them so only
one call is needed. At that point, there is no
value added by having a separate function.
Also instead of using ++ and -- on ->lcs_update to
toggle betwee
The only interesting difference between libcfs_kvzalloc()
and kvzalloc() is that the former appears to work
with GFP_NOFS, which the latter gives a WARN_ON_ONCE()
when that is attempted.
Each libcfs_kvzalloc() should really be analysed
and either converted to a kzalloc() call if the size is never
This library code is unnecessarily generic, but also
not generic enough. Library code that performs
allocations should always take a gfp_flags argument.
So discard the library and in the one file where it is used,
just use kzalloc or krealloc as needed.
In this context, it is clear that vmalloc i
cfs_block_sigsinv() and cfs_restore_sigs() are now
simple enough to inline them.
This means we can discard linux-prim.c
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 20 +-
drivers/staging/lustre/lnet/libcfs/Makefile|2 -
.../staging/lustre/l
Using vmalloc with GFP_NOFS is not supported as vmalloc
performs some internal allocations with GFP_KERNEL.
So in cases where the size passed to libcfs_kvzalloc()
is clearly at most 1 page, convert to kzalloc().
In cases where the call clearly doesn't hold any
filesystem locks, convert to GFP_KERN
cfs_block_sigs() is never used.
cfs_clear_sigpending() is never used.
cfs_block_allsigs() is no longer used.
So those three functions can go.
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/libcfs.h |3 -
.../staging/lustre/lnet/libcfs/linux/linux-prim.c | 41 -
The only functionality remaining here is
cfs_curproc_cap_pack(),
and it can be trivially implemented as an inline
in curproc.h.
So do that and remove the file.
Signed-off-by: NeilBrown
---
.../staging/lustre/include/linux/libcfs/curproc.h |6 +-
drivers/staging/lustre/lnet/libcfs/Makefile
This function is used precisely once, and is sufficiently
trivial that it may as well be open-coded.
Doing so helpfully highlights the similarity
between the new kvzalloc_node() call and the already existing
kzalloc_node() call in the same function.
Signed-off-by: NeilBrown
---
.../staging/lust
According to comment for set_current_blocked() in
kernel/signal.c, changing ->blocked directly is wrong.
sigprocmask() should be called instead.
So change cfs_block_sigsinv() and cfs_restore_sigs()
to use sigprocmask().
For consistency, change them to pass the sigset_t by reference
rather than by
Both places that cfs_block_allsigs() is used here,
the goal is to turn an interruptible wait into an
uninterruptible way.
So instead of blocking the signals, change TASK_INTERRUPTIBLE to
TASK_NOLOAD.
In each case, no other functions called while signals are blocked
will sleep - just the one that ha
Following are assorted patches which clean up parts of lustre.
One or two tiny buglets are fixed, but mostly the patches
just make the code more readable, often by removing distractions.
The first several patches remove content from libcfs, completely
removing 3 files.
There are some list_for_each
Lustre defines a few CFS_CAP_* macros which are exactly the
same as the corresponding CAP_* macro, with one exception.
CFS_CAP_SYS_BOOT is 23
CAP_SYS_BOOT is 22.
CFS_CAP_SYS_BOOT is only used through CFS_CAP_FS_MASK and
causes capability 23 (CAP_SYS_NICE) to be dropped in certain
circumstances.
I
Threads started by kthread_run() ignore all signals,
as kthreadd() calls ignore_signals(), and this is
inherited by all children.
So there is no need to call cfs_block_allsigs() in functions
that are only run from kthread_run().
Signed-off-by: NeilBrown
---
.../staging/lustre/lnet/klnds/o2iblnd/
1 - 100 of 877 matches
Mail list logo
