[PATCH] device_handler: remove VLAs

2018-03-09 Thread Stephen Kitt
In preparation to enabling -Wvla, remove VLAs and replace them with fixed-length arrays instead. scsi_dh_{alua,emc,rdac} use variable-length array declarations to store command blocks, with the appropriate size as determined by COMMAND_SIZE. This patch replaces these with fixed-sized arrays using

[PATCH] device_handler: remove VLAs

2018-03-09 Thread Stephen Kitt
In preparation to enabling -Wvla, remove VLAs and replace them with fixed-length arrays instead. scsi_dh_{alua,emc,rdac} use variable-length array declarations to store command blocks, with the appropriate size as determined by COMMAND_SIZE. This patch replaces these with fixed-sized arrays using

[PATCH] proc: do mmput ASAP for /proc/*/map_files

2018-03-09 Thread Alexey Dobriyan
mm_struct not needed while printing as all the data was already extracted. Signed-off-by: Alexey Dobriyan --- fs/proc/base.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -2214,6 +2214,7 @@

[PATCH v5 13/36] drm/bridge: analogix_dp: Ensure edp is disabled when shutting down the panel

2018-03-09 Thread Enric Balletbo i Serra
From: Lin Huang When panel is shut down, we should make sure edp can be disabled to avoid undefined behavior. Cc: Stéphane Marchesin Signed-off-by: Lin Huang Signed-off-by: zain wang Signed-off-by: Sean Paul

[PATCH v5 11/36] drm/bridge: analogix_dp: Wait for HPD signal before configuring link

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang According to DP spec v1.3 chap 3.5.1.2 Link Training, Link Policy Maker must first detect that the HPD signal is asserted high by the Downstream Device before establishing a link with it. Cc: Stéphane Marchesin Signed-off-by: zain wang

[PATCH v5 13/36] drm/bridge: analogix_dp: Ensure edp is disabled when shutting down the panel

2018-03-09 Thread Enric Balletbo i Serra
From: Lin Huang When panel is shut down, we should make sure edp can be disabled to avoid undefined behavior. Cc: Stéphane Marchesin Signed-off-by: Lin Huang Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda Signed-off-by: Enric

[PATCH v5 11/36] drm/bridge: analogix_dp: Wait for HPD signal before configuring link

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang According to DP spec v1.3 chap 3.5.1.2 Link Training, Link Policy Maker must first detect that the HPD signal is asserted high by the Downstream Device before establishing a link with it. Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by:

[PATCH] proc: do mmput ASAP for /proc/*/map_files

2018-03-09 Thread Alexey Dobriyan
mm_struct not needed while printing as all the data was already extracted. Signed-off-by: Alexey Dobriyan --- fs/proc/base.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -2214,6 +2214,7 @@ proc_map_files_readdir(struct file *file,

[PATCH v5 10/36] drm/bridge: analogix_dp: Retry bridge enable when it failed

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang When we enable bridge failed, we have to retry it, otherwise we would get the abnormal display. Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by:

[PATCH v5 10/36] drm/bridge: analogix_dp: Retry bridge enable when it failed

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang When we enable bridge failed, we have to retry it, otherwise we would get the abnormal display. Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda Signed-off-by: Enric Balletbo i Serra

[PATCH v5 16/36] drm/bridge: analogix_dp: Check dpcd write/read status

2018-03-09 Thread Enric Balletbo i Serra
From: Lin Huang We need to check the dpcd write/read return value to see whether the write/read was successful Cc: Kristian H. Kristensen Signed-off-by: Lin Huang Signed-off-by: zain wang Signed-off-by:

[PATCH v5 15/36] drm/bridge: analogix_dp: Fix incorrect usage of enhanced mode

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang Enhanced mode is required by the eDP 1.2 specification, and not doing it early could result in a period of time where we have a link transmitting idle packets without it. Since there is no reason to disable it, we just enable it at the beginning of link

[PATCH v5 16/36] drm/bridge: analogix_dp: Check dpcd write/read status

2018-03-09 Thread Enric Balletbo i Serra
From: Lin Huang We need to check the dpcd write/read return value to see whether the write/read was successful Cc: Kristian H. Kristensen Signed-off-by: Lin Huang Signed-off-by: zain wang Signed-off-by: Douglas Anderson Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by:

[PATCH v5 15/36] drm/bridge: analogix_dp: Fix incorrect usage of enhanced mode

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang Enhanced mode is required by the eDP 1.2 specification, and not doing it early could result in a period of time where we have a link transmitting idle packets without it. Since there is no reason to disable it, we just enable it at the beginning of link training and then keep it

[PATCH v5 18/36] drm/bridge: analogix_dp: Reset aux channel if an error occurred

2018-03-09 Thread Enric Balletbo i Serra
From: Lin Huang AUX errors are caused by many different reasons. We may not know what happened in aux channel on failure, so let's reset aux channel if some errors occurred. Cc: 征增 王 Cc: Douglas Anderson Signed-off-by: Lin Huang

[PATCH v5 18/36] drm/bridge: analogix_dp: Reset aux channel if an error occurred

2018-03-09 Thread Enric Balletbo i Serra
From: Lin Huang AUX errors are caused by many different reasons. We may not know what happened in aux channel on failure, so let's reset aux channel if some errors occurred. Cc: 征增 王 Cc: Douglas Anderson Signed-off-by: Lin Huang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande

[PATCH v5 17/36] drm/bridge: analogix_dp: Fix AUX_PD bit for Rockchip

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang There are some different bits between Rockchip and Exynos in register "AUX_PD". This patch fixes the incorrect operations about it. Cc: Douglas Anderson Signed-off-by: zain wang Signed-off-by: Sean Paul

[PATCH v5 17/36] drm/bridge: analogix_dp: Fix AUX_PD bit for Rockchip

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang There are some different bits between Rockchip and Exynos in register "AUX_PD". This patch fixes the incorrect operations about it. Cc: Douglas Anderson Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda

[PATCH v5 19/36] drm/rockchip: Restore psr->state when enable/disable psr failed

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang If we failed disable psr, it would hang the display until next psr cycle coming. So we should restore psr->state when it failed. Cc: Tomasz Figa Signed-off-by: zain wang Signed-off-by: Douglas Anderson

[PATCH v5 21/36] drm/bridge: analogix_dp: Fix timeout of video streamclk config

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang The STRM_VALID bit in register ANALOGIX_DP_SYS_CTL_3 may be unstable, so we may hit the error log "Timeout of video streamclk ok" since checked this unstable bit. In fact, we can go continue and the streamclk is ok if we wait enough time, it does no effect on

[PATCH v5 20/36] drm/bridge: analogix_dp: Don't use ANALOGIX_DP_PLL_CTL to control pll

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang There is no register named ANALOGIX_DP_PLL_CTL in Rockchip edp phy reg list. We should use BIT_4 in ANALOGIX_DP_PD to control the pll power instead of ANALOGIX_DP_PLL_CTL. Cc: Douglas Anderson Signed-off-by: zain wang

[PATCH] proc: faster /proc/cmdline

2018-03-09 Thread Alexey Dobriyan
Use seq_puts() and skip format string processing. Signed-off-by: Alexey Dobriyan --- fs/proc/cmdline.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/fs/proc/cmdline.c +++ b/fs/proc/cmdline.c @@ -6,7 +6,8 @@ static int cmdline_proc_show(struct

[PATCH v5 19/36] drm/rockchip: Restore psr->state when enable/disable psr failed

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang If we failed disable psr, it would hang the display until next psr cycle coming. So we should restore psr->state when it failed. Cc: Tomasz Figa Signed-off-by: zain wang Signed-off-by: Douglas Anderson Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Signed-off-by:

[PATCH v5 21/36] drm/bridge: analogix_dp: Fix timeout of video streamclk config

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang The STRM_VALID bit in register ANALOGIX_DP_SYS_CTL_3 may be unstable, so we may hit the error log "Timeout of video streamclk ok" since checked this unstable bit. In fact, we can go continue and the streamclk is ok if we wait enough time, it does no effect on display. Let's

[PATCH v5 20/36] drm/bridge: analogix_dp: Don't use ANALOGIX_DP_PLL_CTL to control pll

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang There is no register named ANALOGIX_DP_PLL_CTL in Rockchip edp phy reg list. We should use BIT_4 in ANALOGIX_DP_PD to control the pll power instead of ANALOGIX_DP_PLL_CTL. Cc: Douglas Anderson Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande

[PATCH] proc: faster /proc/cmdline

2018-03-09 Thread Alexey Dobriyan
Use seq_puts() and skip format string processing. Signed-off-by: Alexey Dobriyan --- fs/proc/cmdline.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/fs/proc/cmdline.c +++ b/fs/proc/cmdline.c @@ -6,7 +6,8 @@ static int cmdline_proc_show(struct seq_file *m, void *v) { -

[PATCH v5 23/36] drm/bridge: analogix_dp: Move fast link training detect to set_bridge

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang It's too early to detect fast link training, if other step after it failed, we will set fast_link flag to 1, and retry set_bridge again. In this case we will power down and power up panel power supply, and we will do fast link training since we have set

Re: Nokia N900: v4.16-rc4: oops in iio when grepping sysfs

2018-03-09 Thread Greg KH
On Fri, Mar 09, 2018 at 11:12:21PM +0100, Pavel Machek wrote: > Hi! > > Hmm. Looks like there's a lot of fun to be had with sysfs. > > Pavel > > > pavel@n900:~$ uname -a > Linux n900 4.16.0-rc4-59690-g7f84626-dirty #543 Thu Mar 8

Re: [PATCH] ipmi: Remove ACPI SPMI probing from the SSIF (I2C) driver

2018-03-09 Thread Jiandi An
On 03/08/2018 03:08 PM, miny...@acm.org wrote: From: Corey Minyard The IPMI spec states: The purpose of the SPMI Table is to provide a mechanism that can be used by the OSPM (an ACPI term for “OS Operating System-directed configuration and Power Management”

[PATCH v5 23/36] drm/bridge: analogix_dp: Move fast link training detect to set_bridge

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang It's too early to detect fast link training, if other step after it failed, we will set fast_link flag to 1, and retry set_bridge again. In this case we will power down and power up panel power supply, and we will do fast link training since we have set fast_link flag to 1. In

Re: Nokia N900: v4.16-rc4: oops in iio when grepping sysfs

2018-03-09 Thread Greg KH
On Fri, Mar 09, 2018 at 11:12:21PM +0100, Pavel Machek wrote: > Hi! > > Hmm. Looks like there's a lot of fun to be had with sysfs. > > Pavel > > > pavel@n900:~$ uname -a > Linux n900 4.16.0-rc4-59690-g7f84626-dirty #543 Thu Mar 8

Re: [PATCH] ipmi: Remove ACPI SPMI probing from the SSIF (I2C) driver

2018-03-09 Thread Jiandi An
On 03/08/2018 03:08 PM, miny...@acm.org wrote: From: Corey Minyard The IPMI spec states: The purpose of the SPMI Table is to provide a mechanism that can be used by the OSPM (an ACPI term for “OS Operating System-directed configuration and Power Management” essentially meaning an

[PATCH v5 28/36] drm/bridge: analogix_dp: Split the platform-specific poweron in two parts

2018-03-09 Thread Enric Balletbo i Serra
From: Douglas Anderson Some of the platform-specific stuff in rockchip_dp_poweron() needs to happen before the generic code. Some needs to happen after. Let's split the callback in two. Specifically we can't start doing PSR work until _after_ the whole controller is up,

[PATCH v5 28/36] drm/bridge: analogix_dp: Split the platform-specific poweron in two parts

2018-03-09 Thread Enric Balletbo i Serra
From: Douglas Anderson Some of the platform-specific stuff in rockchip_dp_poweron() needs to happen before the generic code. Some needs to happen after. Let's split the callback in two. Specifically we can't start doing PSR work until _after_ the whole controller is up, so don't set the

[PATCH v5 26/36] drm/bridge: analogix_dp: Properly disable aux chan retries on rockchip

2018-03-09 Thread Enric Balletbo i Serra
From: Douglas Anderson The comments in analogix_dp_init_aux() claim that we're disabling aux channel retries, but then right below it for Rockchip it sets them to 3. If we actually need 3 retries for Rockchip then we could adjust the comment, but it seems more likely that

[PATCH v5 26/36] drm/bridge: analogix_dp: Properly disable aux chan retries on rockchip

2018-03-09 Thread Enric Balletbo i Serra
From: Douglas Anderson The comments in analogix_dp_init_aux() claim that we're disabling aux channel retries, but then right below it for Rockchip it sets them to 3. If we actually need 3 retries for Rockchip then we could adjust the comment, but it seems more likely that we want the same retry

[PATCH v5 24/36] drm/bridge: analogix_dp: Reorder plat_data->power_off to happen sooner

2018-03-09 Thread Enric Balletbo i Serra
From: Douglas Anderson The current user of the analogix power_off is "analogix_dp-rockchip". That driver does this: - deactivate PSR - turn off a clock Both of these things (especially deactive PSR) should be done before we turn the PHY power off and turn off analog

[PATCH v5 24/36] drm/bridge: analogix_dp: Reorder plat_data->power_off to happen sooner

2018-03-09 Thread Enric Balletbo i Serra
From: Douglas Anderson The current user of the analogix power_off is "analogix_dp-rockchip". That driver does this: - deactivate PSR - turn off a clock Both of these things (especially deactive PSR) should be done before we turn the PHY power off and turn off analog power. Let's move the

[PATCH] proc: register filesystem last

2018-03-09 Thread Alexey Dobriyan
As soon as register_filesystem() exits, filesystem can be mounted. It is better to present fully operational /proc. Of course it doesn't matter because /proc is not modular but do it anyway. Drop error check, it should be handled by panicking. Signed-off-by: Alexey Dobriyan

[PATCH] proc: register filesystem last

2018-03-09 Thread Alexey Dobriyan
As soon as register_filesystem() exits, filesystem can be mounted. It is better to present fully operational /proc. Of course it doesn't matter because /proc is not modular but do it anyway. Drop error check, it should be handled by panicking. Signed-off-by: Alexey Dobriyan ---

Re: Warning from swake_up_all in 4.14.15-rt13 non-RT

2018-03-09 Thread Peter Zijlstra
On Fri, Mar 09, 2018 at 09:25:50PM +0100, Sebastian Andrzej Siewior wrote: > Is it just about the irqsave() usage or something else? I doubt it is > the list walk. It is still unbound if not called from irq-off region. The current list walk is preemptible. You put the entire iteration (of unbound

Re: Warning from swake_up_all in 4.14.15-rt13 non-RT

2018-03-09 Thread Peter Zijlstra
On Fri, Mar 09, 2018 at 09:25:50PM +0100, Sebastian Andrzej Siewior wrote: > Is it just about the irqsave() usage or something else? I doubt it is > the list walk. It is still unbound if not called from irq-off region. The current list walk is preemptible. You put the entire iteration (of unbound

[PATCH v5 27/36] drm/rockchip: pre dither down when output bpc is 8bit

2018-03-09 Thread Enric Balletbo i Serra
From: Mark Yao Some encoder have a crc verification check, crc check fail if input and output data is not equal. That means encoder input and output need use same color depth, vop can output 10bit data to encoder, but some panel only support 8bit depth, that would make

[PATCH v5 27/36] drm/rockchip: pre dither down when output bpc is 8bit

2018-03-09 Thread Enric Balletbo i Serra
From: Mark Yao Some encoder have a crc verification check, crc check fail if input and output data is not equal. That means encoder input and output need use same color depth, vop can output 10bit data to encoder, but some panel only support 8bit depth, that would make crc check die. So pre

[PATCH v5 29/36] drm/rockchip: analogix_dp: Do not call Analogix code before bind

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa Driver callbacks, such as system suspend or resume can be called any time, specifically they can be called before the component bind callback. Let's use dp->adp pointer as a safeguard and skip calling Analogix entry points if it is an ERR_PTR().

[PATCH v5 29/36] drm/rockchip: analogix_dp: Do not call Analogix code before bind

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa Driver callbacks, such as system suspend or resume can be called any time, specifically they can be called before the component bind callback. Let's use dp->adp pointer as a safeguard and skip calling Analogix entry points if it is an ERR_PTR(). Signed-off-by: Tomasz Figa

[PATCH v5 34/36] drm/rockchip: Disable PSR from reboot notifier

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa It looks like the driver subsystem detaches devices from power domains at shutdown without consent of the drivers. This means that we might have our power domain turned off behind our back and the only way to avoid problems is to stop doing any hardware

[PATCH v5 36/36] drm/rockchip: psr: Remove flush by CRTC

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa It is not used anymore after last changes and it was not even correct to begin with as it assumed a 1:1 relation between a CRTC and encoder, while in fact a CRTC can be attached to multiple encoders. Signed-off-by: Tomasz Figa

[PATCH v5 31/36] drm/rockchip: Cancel PSR enable work before changing the state

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa If we change the state first and reschedule later, we might have the work executed according to previous scheduled time and end up with PSR re-enabled instantly. Let's cancel the work before changing the state. While at it, consolidate psr_disable_handler()

[PATCH v5 34/36] drm/rockchip: Disable PSR from reboot notifier

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa It looks like the driver subsystem detaches devices from power domains at shutdown without consent of the drivers. This means that we might have our power domain turned off behind our back and the only way to avoid problems is to stop doing any hardware programming at some

[PATCH v5 36/36] drm/rockchip: psr: Remove flush by CRTC

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa It is not used anymore after last changes and it was not even correct to begin with as it assumed a 1:1 relation between a CRTC and encoder, while in fact a CRTC can be attached to multiple encoders. Signed-off-by: Tomasz Figa Signed-off-by: Thierry Escande Signed-off-by:

[PATCH v5 31/36] drm/rockchip: Cancel PSR enable work before changing the state

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa If we change the state first and reschedule later, we might have the work executed according to previous scheduled time and end up with PSR re-enabled instantly. Let's cancel the work before changing the state. While at it, consolidate psr_disable_handler() to just call

[PATCH v5 30/36] drm/rockchip: Disable PSR on input events

2018-03-09 Thread Enric Balletbo i Serra
From: "Kristian H. Kristensen" To improve PSR exit latency, we speculatively start exiting when we receive input events. Occasionally, this may lead to false positives, but most of the time we get a head start on coming out of PSR. Depending on how userspace takes to

[PATCH v5 32/36] drm/rockchip: psr: Avoid redundant calls to .set() callback

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa The first time after we call rockchip_drm_do_flush() after rockchip_drm_psr_register(), we go from PSR_DISABLE to PSR_FLUSH. The difference between PSR_DISABLE and PSR_FLUSH is whether or not we have a delayed work pending - PSR is off in either state.

[PATCH v5 30/36] drm/rockchip: Disable PSR on input events

2018-03-09 Thread Enric Balletbo i Serra
From: "Kristian H. Kristensen" To improve PSR exit latency, we speculatively start exiting when we receive input events. Occasionally, this may lead to false positives, but most of the time we get a head start on coming out of PSR. Depending on how userspace takes to produce a new frame in

[PATCH v5 32/36] drm/rockchip: psr: Avoid redundant calls to .set() callback

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa The first time after we call rockchip_drm_do_flush() after rockchip_drm_psr_register(), we go from PSR_DISABLE to PSR_FLUSH. The difference between PSR_DISABLE and PSR_FLUSH is whether or not we have a delayed work pending - PSR is off in either state. However psr_set_state()

[PATCH v5 33/36] drm/rockchip: psr: Sanitize semantics of allow/disallow API

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa Currently both rockchip_drm_psr_activate() and _deactivate() only set the boolean "active" flag without actually making sure that hardware state complies with it. Since we are going to extend the usage of this API to properly lock PSR for the duration of

[PATCH v5 33/36] drm/rockchip: psr: Sanitize semantics of allow/disallow API

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa Currently both rockchip_drm_psr_activate() and _deactivate() only set the boolean "active" flag without actually making sure that hardware state complies with it. Since we are going to extend the usage of this API to properly lock PSR for the duration of atomic commits, we

[PATCH v5 35/36] drm/rockchip: Disallow PSR for the whole atomic commit

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa Currently PSR flush is triggered from CRTC's .atomic_begin() callback, which is executed after modeset disables and enables and before plane updates are committed. Since PSR flush and re-enable can be triggered asynchronously by external sources (input

[PATCH v5 35/36] drm/rockchip: Disallow PSR for the whole atomic commit

2018-03-09 Thread Enric Balletbo i Serra
From: Tomasz Figa Currently PSR flush is triggered from CRTC's .atomic_begin() callback, which is executed after modeset disables and enables and before plane updates are committed. Since PSR flush and re-enable can be triggered asynchronously by external sources (input event, delayed work), it

[PATCH v5 14/36] drm/bridge: analogix_dp: Extend hpd check time to 100ms

2018-03-09 Thread Enric Balletbo i Serra
From: Lin Huang There was a 1ms delay to detect the hpd signal, which is too short to detect a short pulse. This patch extends this delay to 100ms. Cc: Stéphane Marchesin Cc: 征增 王 Signed-off-by: Lin Huang

[PATCH v5 25/36] drm/bridge: analogix_dp: Properly log AUX CH errors

2018-03-09 Thread Enric Balletbo i Serra
From: Douglas Anderson The code in analogix_dp_transfer() that was supposed to print out: AUX CH error happened Was actually dead code. That's because the previous check (whether the interrupt status indicated any errors) would have hit for all errors anyway. Let's

[PATCH v5 12/36] drm/bridge: analogix_dp: Set PD_INC_BG first when powering up edp phy

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang Following the correct power up sequence: dp_pd=ff => dp_pd=7f => wait 10us => dp_pd=00 Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry

[PATCH v5 25/36] drm/bridge: analogix_dp: Properly log AUX CH errors

2018-03-09 Thread Enric Balletbo i Serra
From: Douglas Anderson The code in analogix_dp_transfer() that was supposed to print out: AUX CH error happened Was actually dead code. That's because the previous check (whether the interrupt status indicated any errors) would have hit for all errors anyway. Let's combine the two error

[PATCH v5 12/36] drm/bridge: analogix_dp: Set PD_INC_BG first when powering up edp phy

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang Following the correct power up sequence: dp_pd=ff => dp_pd=7f => wait 10us => dp_pd=00 Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Signed-off-by: Enric Balletbo i Serra Tested-by: Marek Szyprowski ---

[PATCH v5 14/36] drm/bridge: analogix_dp: Extend hpd check time to 100ms

2018-03-09 Thread Enric Balletbo i Serra
From: Lin Huang There was a 1ms delay to detect the hpd signal, which is too short to detect a short pulse. This patch extends this delay to 100ms. Cc: Stéphane Marchesin Cc: 征增 王 Signed-off-by: Lin Huang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda

[PATCH v5 22/36] drm/bridge: analogix_dp: Fix incorrect operations with register ANALOGIX_DP_FUNC_EN_1

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang Register ANALOGIX_DP_FUNC_EN_1(offset 0x18), Rockchip is different to Exynos: on Exynos edp phy, BIT 7 MASTER_VID_FUNC_EN_N BIT 6 reserved BIT 5 SLAVE_VID_FUNC_EN_N on Rockchip edp phy, BIT 7 reserved BIT 6

[PATCH v5 22/36] drm/bridge: analogix_dp: Fix incorrect operations with register ANALOGIX_DP_FUNC_EN_1

2018-03-09 Thread Enric Balletbo i Serra
From: zain wang Register ANALOGIX_DP_FUNC_EN_1(offset 0x18), Rockchip is different to Exynos: on Exynos edp phy, BIT 7 MASTER_VID_FUNC_EN_N BIT 6 reserved BIT 5 SLAVE_VID_FUNC_EN_N on Rockchip edp phy, BIT 7 reserved BIT 6 RK_VID_CAP_FUNC_EN_N

[PATCH v5 08/36] drm/bridge: analogix_dp: Check AUX_EN status when doing AUX transfer

2018-03-09 Thread Enric Balletbo i Serra
From: Lin Huang We should check AUX_EN bit to confirm the AUX CH operation is completed. Cc: Stéphane Marchesin Signed-off-by: Lin Huang Signed-off-by: zain wang Signed-off-by: Sean Paul

[PATCH v5 08/36] drm/bridge: analogix_dp: Check AUX_EN status when doing AUX transfer

2018-03-09 Thread Enric Balletbo i Serra
From: Lin Huang We should check AUX_EN bit to confirm the AUX CH operation is completed. Cc: Stéphane Marchesin Signed-off-by: Lin Huang Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Signed-off-by: Enric Balletbo i Serra Tested-by: Marek Szyprowski ---

[PATCH v5 01/36] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2018-03-09 Thread Enric Balletbo i Serra
From: Yakir Yang Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR setting. Cc: 征增 王 Cc: Stéphane Marchesin

[PATCH v5 01/36] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2018-03-09 Thread Enric Balletbo i Serra
From: Yakir Yang Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR setting. Cc: 征增 王 Cc: Stéphane Marchesin Signed-off-by: Yakir Yang [seanpaul changed timeout loop to a readx poll]

Re: Nokia N900: refcount_t underflow, use after free

2018-03-09 Thread Pavel Machek
On Fri 2018-03-09 16:13:36, Suman Anna wrote: > On 03/09/2018 06:08 AM, Robin Murphy wrote: > > On 08/03/18 18:50, Pavel Machek wrote: > >> Hi! > >> > * Pavel Machek [180308 14:31]: > > Hi! > > > > I'm getting this warning... Has anyone seen/debugged that before? >

Re: Nokia N900: refcount_t underflow, use after free

2018-03-09 Thread Pavel Machek
On Fri 2018-03-09 16:13:36, Suman Anna wrote: > On 03/09/2018 06:08 AM, Robin Murphy wrote: > > On 08/03/18 18:50, Pavel Machek wrote: > >> Hi! > >> > * Pavel Machek [180308 14:31]: > > Hi! > > > > I'm getting this warning... Has anyone seen/debugged that before? > >

Re: [PATCH v4] cpuset: Enable cpuset controller in default hierarchy

2018-03-09 Thread Peter Zijlstra
On Fri, Mar 09, 2018 at 03:43:34PM -0500, Waiman Long wrote: > The isolcpus= parameter just reduce the cpus available to the rests of > the system. The cpuset controller does look at that value and make > adjustment accordingly, but it has no dependence on exclusive cpu/mem > features of cpuset.

Re: [PATCH v4] cpuset: Enable cpuset controller in default hierarchy

2018-03-09 Thread Peter Zijlstra
On Fri, Mar 09, 2018 at 03:43:34PM -0500, Waiman Long wrote: > The isolcpus= parameter just reduce the cpus available to the rests of > the system. The cpuset controller does look at that value and make > adjustment accordingly, but it has no dependence on exclusive cpu/mem > features of cpuset.

Re: [PATCH] bfa: remove VLA

2018-03-09 Thread Stephen Kitt
Hi, I sent this to the wrong maintainers, sorry — you’ll find the original patch on https://patchwork.kernel.org/patch/10269257/ Regards, Stephen On Thu, 8 Mar 2018 13:43:07 -0800, Kees Cook wrote: > On Thu, Mar 8, 2018 at 1:38 PM, Stephen Kitt wrote: >

Re: [PATCH] bfa: remove VLA

2018-03-09 Thread Stephen Kitt
Hi, I sent this to the wrong maintainers, sorry — you’ll find the original patch on https://patchwork.kernel.org/patch/10269257/ Regards, Stephen On Thu, 8 Mar 2018 13:43:07 -0800, Kees Cook wrote: > On Thu, Mar 8, 2018 at 1:38 PM, Stephen Kitt wrote: > > In preparation to enabling -Wvla,

Re: Nokia N900: refcount_t underflow, use after free

2018-03-09 Thread Suman Anna
On 03/09/2018 06:08 AM, Robin Murphy wrote: > On 08/03/18 18:50, Pavel Machek wrote: >> Hi! >> * Pavel Machek [180308 14:31]: > Hi! > > I'm getting this warning... Has anyone seen/debugged that before? > Unfortunately the backtrace does not seem to be too useful

Re: Nokia N900: refcount_t underflow, use after free

2018-03-09 Thread Suman Anna
On 03/09/2018 06:08 AM, Robin Murphy wrote: > On 08/03/18 18:50, Pavel Machek wrote: >> Hi! >> * Pavel Machek [180308 14:31]: > Hi! > > I'm getting this warning... Has anyone seen/debugged that before? > Unfortunately the backtrace does not seem to be too useful :-(.

[RFC 0/1] Loading optional firmware

2018-03-09 Thread Andres Rodriguez
Hi Everyone, Wanted to inquire your opinions about the following matter. We are experiencing some end user confusion regarding the following messages being printed to dmesg: [0.571324] amdgpu :01:00.0: Direct firmware load for amdgpu/polaris10_pfp_2.bin failed with error -2 [

[RFC 0/1] Loading optional firmware

2018-03-09 Thread Andres Rodriguez
Hi Everyone, Wanted to inquire your opinions about the following matter. We are experiencing some end user confusion regarding the following messages being printed to dmesg: [0.571324] amdgpu :01:00.0: Direct firmware load for amdgpu/polaris10_pfp_2.bin failed with error -2 [

[PATCH 1/1] firmware: add a function to load optional firmware

2018-03-09 Thread Andres Rodriguez
Currently the firmware loader only exposes one silent path for querying optional firmware, and that is request_firmware_direct(). This function also disables the usermodehelper fallback which might not always be the desired behaviour. This patch introduces request_firmware_optional(), which will

Re: [PATCH] net/9p: avoid -ERESTARTSYS leak to userspace

2018-03-09 Thread Andrew Morton
On Fri, 09 Mar 2018 21:41:38 +0100 Greg Kurz wrote: > If it was interrupted by a signal, the 9p client may need to send some > more requests to the server for cleanup before returning to userspace. > > To avoid such a last minute request to be interrupted right away, the >

[PATCH 1/1] firmware: add a function to load optional firmware

2018-03-09 Thread Andres Rodriguez
Currently the firmware loader only exposes one silent path for querying optional firmware, and that is request_firmware_direct(). This function also disables the usermodehelper fallback which might not always be the desired behaviour. This patch introduces request_firmware_optional(), which will

Re: [PATCH] net/9p: avoid -ERESTARTSYS leak to userspace

2018-03-09 Thread Andrew Morton
On Fri, 09 Mar 2018 21:41:38 +0100 Greg Kurz wrote: > If it was interrupted by a signal, the 9p client may need to send some > more requests to the server for cleanup before returning to userspace. > > To avoid such a last minute request to be interrupted right away, the > client memorizes if a

Nokia N900: v4.16-rc4: oops in iio when grepping sysfs

2018-03-09 Thread Pavel Machek
Hi! Hmm. Looks like there's a lot of fun to be had with sysfs. Pavel pavel@n900:~$ uname -a Linux n900 4.16.0-rc4-59690-g7f84626-dirty #543 Thu Mar 8 19:53:30 CET 2018 armv7l GNU/Linux [ 306.402496] bq2415x: command Timer reset

Nokia N900: v4.16-rc4: oops in iio when grepping sysfs

2018-03-09 Thread Pavel Machek
Hi! Hmm. Looks like there's a lot of fun to be had with sysfs. Pavel pavel@n900:~$ uname -a Linux n900 4.16.0-rc4-59690-g7f84626-dirty #543 Thu Mar 8 19:53:30 CET 2018 armv7l GNU/Linux [ 306.402496] bq2415x: command Timer reset

[v5 1/2] mm: disable interrupts while initializing deferred pages

2018-03-09 Thread Pavel Tatashin
Vlastimil Babka reported about a window issue during which when deferred pages are initialized, and the current version of on-demand initialization is finished, allocations may fail. While this is highly unlikely scenario, since this kind of allocation request must be large, and must come from

[v5 1/2] mm: disable interrupts while initializing deferred pages

2018-03-09 Thread Pavel Tatashin
Vlastimil Babka reported about a window issue during which when deferred pages are initialized, and the current version of on-demand initialization is finished, allocations may fail. While this is highly unlikely scenario, since this kind of allocation request must be large, and must come from

Re: KASAN: use-after-free Read in sctp_association_free (2)

2018-03-09 Thread Neil Horman
On Fri, Mar 09, 2018 at 12:59:06PM -0800, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > fd372a7a9e5e9d8011a0222d10edd3523abcd3b1 (Thu Mar 8 19:43:48 2018 +) > Merge tag 'mlx5-updates-2018-02-28-2' of >

[v5 0/2] initialize pages on demand during boot

2018-03-09 Thread Pavel Tatashin
Change log: v4 - v5 - Fix issue reported by Vlasimil Babka: > I've noticed that this function first disables the > on-demand initialization, and then runs the kthreads. > Doesn't that leave a window where allocations can fail? The > chances

[v5 0/2] initialize pages on demand during boot

2018-03-09 Thread Pavel Tatashin
Change log: v4 - v5 - Fix issue reported by Vlasimil Babka: > I've noticed that this function first disables the > on-demand initialization, and then runs the kthreads. > Doesn't that leave a window where allocations can fail? The > chances

Re: KASAN: use-after-free Read in sctp_association_free (2)

2018-03-09 Thread Neil Horman
On Fri, Mar 09, 2018 at 12:59:06PM -0800, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > fd372a7a9e5e9d8011a0222d10edd3523abcd3b1 (Thu Mar 8 19:43:48 2018 +) > Merge tag 'mlx5-updates-2018-02-28-2' of >

[v5 2/2] mm: initialize pages on demand during boot

2018-03-09 Thread Pavel Tatashin
Deferred page initialization allows the boot cpu to initialize a small subset of the system's pages early in boot, with other cpus doing the rest later on. It is, however, problematic to know how many pages the kernel needs during boot. Different modules and kernel parameters may change the

[v5 2/2] mm: initialize pages on demand during boot

2018-03-09 Thread Pavel Tatashin
Deferred page initialization allows the boot cpu to initialize a small subset of the system's pages early in boot, with other cpus doing the rest later on. It is, however, problematic to know how many pages the kernel needs during boot. Different modules and kernel parameters may change the

[PATCH 03/11] media: vsp1: Rename dl_child to dl_next

2018-03-09 Thread Kieran Bingham
Both vsp1_dl_list_commit() and __vsp1_dl_list_put() walk the display list chain referencing the nodes as children, when in reality they are siblings. Update the terminology to 'dl_next' to be consistent with the vsp1_video_pipeline_run() usage. Signed-off-by: Kieran Bingham

[PATCH 03/11] media: vsp1: Rename dl_child to dl_next

2018-03-09 Thread Kieran Bingham
Both vsp1_dl_list_commit() and __vsp1_dl_list_put() walk the display list chain referencing the nodes as children, when in reality they are siblings. Update the terminology to 'dl_next' to be consistent with the vsp1_video_pipeline_run() usage. Signed-off-by: Kieran Bingham ---

[PATCH 02/11] media: vsp1: use kernel __packed for structures

2018-03-09 Thread Kieran Bingham
The kernel provides a __packed definition to abstract away from the compiler specific attributes tag. Convert all packed structures in VSP1 to use it. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_dl.c | 6 +++--- 1 file changed, 3

[PATCH 02/11] media: vsp1: use kernel __packed for structures

2018-03-09 Thread Kieran Bingham
The kernel provides a __packed definition to abstract away from the compiler specific attributes tag. Convert all packed structures in VSP1 to use it. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_dl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

<    3   4   5   6   7   8   9   10   11   12   >