[PATCH 00/19] powerpc/ppc32: make W=1 compilation errors free

2018-03-22 Thread Mathieu Malaterre
Here is another batch for warnings treated as error on ppc32. Tested with: $ make ARCH=powerpc ppc32_defconfig $ make -j8 ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- W=1 Using: $ powerpc-linux-gnu-gcc --version powerpc-linux-gnu-gcc (Debian 6.3.0-18) 6.3.0 20170516 Mathieu Malaterre (19):

[PATCH 00/19] powerpc/ppc32: make W=1 compilation errors free

2018-03-22 Thread Mathieu Malaterre
Here is another batch for warnings treated as error on ppc32. Tested with: $ make ARCH=powerpc ppc32_defconfig $ make -j8 ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- W=1 Using: $ powerpc-linux-gnu-gcc --version powerpc-linux-gnu-gcc (Debian 6.3.0-18) 6.3.0 20170516 Mathieu Malaterre (19):

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

2018-03-22 Thread Joel Fernandes
On Thu, Mar 22, 2018 at 11:06 AM, Patrick Bellasi wrote: [..] >> > +static inline bool wake_energy(struct task_struct *p, int prev_cpu) >> > +{ >> > + struct sched_domain *sd; >> > + >> > + if (!static_branch_unlikely(_energy_present)) >> > +

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

2018-03-22 Thread Joel Fernandes
On Thu, Mar 22, 2018 at 11:06 AM, Patrick Bellasi wrote: [..] >> > +static inline bool wake_energy(struct task_struct *p, int prev_cpu) >> > +{ >> > + struct sched_domain *sd; >> > + >> > + if (!static_branch_unlikely(_energy_present)) >> > + return false; >> > + >> > +

Re: [PATCH] nfsd: use correct enum type in decode_cb_op_status

2018-03-22 Thread J. Bruce Fields
Applying, thanks!--b. On Mon, Mar 19, 2018 at 11:37:05PM +0100, Stefan Agner wrote: > Use enum nfs_cb_opnum4 in decode_cb_op_status. This fixes warnings > seen with clang: > fs/nfsd/nfs4callback.c:451:36: warning: implicit conversion from > enumeration type 'enum nfs_cb_opnum4' to

Re: [PATCH] nfsd: use correct enum type in decode_cb_op_status

2018-03-22 Thread J. Bruce Fields
Applying, thanks!--b. On Mon, Mar 19, 2018 at 11:37:05PM +0100, Stefan Agner wrote: > Use enum nfs_cb_opnum4 in decode_cb_op_status. This fixes warnings > seen with clang: > fs/nfsd/nfs4callback.c:451:36: warning: implicit conversion from > enumeration type 'enum nfs_cb_opnum4' to

Re: [PATCH v4 4/6] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-22 Thread Jason Gunthorpe
On Thu, Mar 22, 2018 at 07:44:51PM +, Casey Leedom wrote: > | From: Steve Wise > | Sent: Thursday, March 22, 2018 9:28 AM > | > | | From: Sinan Kaya > | | Date: Thursday, March 22, 2018 7:52 AM > | | > | | Isn't this a PowerPC problem? Why

Re: [PATCH v4 4/6] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-22 Thread Jason Gunthorpe
On Thu, Mar 22, 2018 at 07:44:51PM +, Casey Leedom wrote: > | From: Steve Wise > | Sent: Thursday, March 22, 2018 9:28 AM > | > | | From: Sinan Kaya > | | Date: Thursday, March 22, 2018 7:52 AM > | | > | | Isn't this a PowerPC problem? Why penalize other architectures? > | > | I worry it

Re: [PATCH v6 1/6] typec: tcpm: Add core support for sink side PPS

2018-03-22 Thread Guenter Roeck
On Thu, Mar 22, 2018 at 03:52:02PM +, Adam Thomson wrote: > This commit adds code to handle requesting of PPS APDOs. Switching > between standard PDOs and APDOs, and re-requesting an APDO to > modify operating voltage/current will be triggered by an > external call into TCPM. > >

Re: [PATCH v6 1/6] typec: tcpm: Add core support for sink side PPS

2018-03-22 Thread Guenter Roeck
On Thu, Mar 22, 2018 at 03:52:02PM +, Adam Thomson wrote: > This commit adds code to handle requesting of PPS APDOs. Switching > between standard PDOs and APDOs, and re-requesting an APDO to > modify operating voltage/current will be triggered by an > external call into TCPM. > >

Re: [PATCH] Documentation: Mention why %p prints ptrval

2018-03-22 Thread Tobin C . Harding
On Thu, Mar 22, 2018 at 03:53:36PM +1030, Joel Stanley wrote: > When debugging recent kernels, people will see '(ptrval)' but there > isn't much information as to what that means. Briefly describe why it's > there. > > Signed-off-by: Joel Stanley > --- >

Re: [PATCH] Documentation: Mention why %p prints ptrval

2018-03-22 Thread Tobin C . Harding
On Thu, Mar 22, 2018 at 03:53:36PM +1030, Joel Stanley wrote: > When debugging recent kernels, people will see '(ptrval)' but there > isn't much information as to what that means. Briefly describe why it's > there. > > Signed-off-by: Joel Stanley > --- >

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

2018-03-22 Thread Joel Fernandes
On Wed, Mar 21, 2018 at 8:35 AM, Patrick Bellasi wrote: > [...] > >> @@ -6555,6 +6613,14 @@ select_task_rq_fair(struct task_struct *p, int >> prev_cpu, int sd_flag, int wake_f >> break; >> } >> >> + /* >> + *

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

2018-03-22 Thread Joel Fernandes
On Wed, Mar 21, 2018 at 8:35 AM, Patrick Bellasi wrote: > [...] > >> @@ -6555,6 +6613,14 @@ select_task_rq_fair(struct task_struct *p, int >> prev_cpu, int sd_flag, int wake_f >> break; >> } >> >> + /* >> + * Energy-aware task

[PATCH] qed: Use true and false for boolean values

2018-03-22 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[PATCH] qed: Use true and false for boolean values

2018-03-22 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] mm, vmscan, tracing: Use pointer to reclaim_stat struct in trace event

2018-03-22 Thread David Rientjes
On Thu, 22 Mar 2018, Steven Rostedt wrote: > > The trace event trace_mm_vmscan_lru_shrink_inactive() currently has 12 > parameters! Seven of them are from the reclaim_stat structure. This > structure is currently local to mm/vmscan.c. By moving it to the global > vmstat.h header, we can also

Re: [PATCH] mm, vmscan, tracing: Use pointer to reclaim_stat struct in trace event

2018-03-22 Thread David Rientjes
On Thu, 22 Mar 2018, Steven Rostedt wrote: > > The trace event trace_mm_vmscan_lru_shrink_inactive() currently has 12 > parameters! Seven of them are from the reclaim_stat structure. This > structure is currently local to mm/vmscan.c. By moving it to the global > vmstat.h header, we can also

Re: [PATCH v2] vmw_balloon: fixing double free when batching mode is off

2018-03-22 Thread Nadav Amit
Oleksandr Natalenko wrote: > Hi. > > On Mon, Mar 19, 2018 at 7:52 PM, Nadav Amit wrote: >>> Oleksandr, if you can confirm that it fixes the bug you encountered, it >>> would be great. >>> >>> Greg, Arnd, on your free time, please let me know if there is

Re: [PATCH v2] vmw_balloon: fixing double free when batching mode is off

2018-03-22 Thread Nadav Amit
Oleksandr Natalenko wrote: > Hi. > > On Mon, Mar 19, 2018 at 7:52 PM, Nadav Amit wrote: >>> Oleksandr, if you can confirm that it fixes the bug you encountered, it >>> would be great. >>> >>> Greg, Arnd, on your free time, please let me know if there is any issue >>> with the patch, and

Re: [PATCH] floppy: Do not copy a kernel pointer to user memory in FDGETPRM ioctl

2018-03-22 Thread Brian Belleville
Hi, are there any comments on this patch or the issue I described? I have tested the FDGETPRM ioctl and confirmed that the struct it returns does contain a pointer to kernel data. I also have tested my patch, and with it applied the returned struct no longer contains a kernel pointer, but all

Re: [PATCH] floppy: Do not copy a kernel pointer to user memory in FDGETPRM ioctl

2018-03-22 Thread Brian Belleville
Hi, are there any comments on this patch or the issue I described? I have tested the FDGETPRM ioctl and confirmed that the struct it returns does contain a pointer to kernel data. I also have tested my patch, and with it applied the returned struct no longer contains a kernel pointer, but all

[PATCH 3/4] mm: Add free()

2018-03-22 Thread Matthew Wilcox
From: Matthew Wilcox free() can free many different kinds of memory. Signed-off-by: Matthew Wilcox --- include/linux/kernel.h | 2 ++ mm/util.c | 39 +++ 2 files changed, 41 insertions(+) diff

[PATCH 3/4] mm: Add free()

2018-03-22 Thread Matthew Wilcox
From: Matthew Wilcox free() can free many different kinds of memory. Signed-off-by: Matthew Wilcox --- include/linux/kernel.h | 2 ++ mm/util.c | 39 +++ 2 files changed, 41 insertions(+) diff --git a/include/linux/kernel.h

[PATCH] dpaa_eth: use true and false for boolean values

2018-03-22 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 1/4] decompression: Rename malloc and free

2018-03-22 Thread Matthew Wilcox
From: Matthew Wilcox Rename the trivial malloc and free implementations to tmalloc and tfree to avoid a namespace collision with an in-kernel free() function. Signed-off-by: Matthew Wilcox --- include/linux/decompress/mm.h | 10 ++ 1

[PATCH 1/4] decompression: Rename malloc and free

2018-03-22 Thread Matthew Wilcox
From: Matthew Wilcox Rename the trivial malloc and free implementations to tmalloc and tfree to avoid a namespace collision with an in-kernel free() function. Signed-off-by: Matthew Wilcox --- include/linux/decompress/mm.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[PATCH] dpaa_eth: use true and false for boolean values

2018-03-22 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/4] Add free() function

2018-03-22 Thread Matthew Wilcox
From: Matthew Wilcox Today, kfree_rcu() can only free objects allocated using kmalloc(). There have been attempts to extend that to kvfree(), but I think we should take it even further and allow freeing as many different objects as possible. It turns out many different

[PATCH 0/4] Add free() function

2018-03-22 Thread Matthew Wilcox
From: Matthew Wilcox Today, kfree_rcu() can only free objects allocated using kmalloc(). There have been attempts to extend that to kvfree(), but I think we should take it even further and allow freeing as many different objects as possible. It turns out many different kinds of memory

Re: [PATCH] nfit: skip region registration for incomplete control regions

2018-03-22 Thread Kani, Toshi
On Wed, 2018-03-21 at 21:42 -0700, Dan Williams wrote: > Per the ACPI specification the only functional purpose for a DIMM > Control Region to be mapped into the system physical address space, from > an OSPM perspective, is to support block-apertures. However, there are > some BIOSen that publish

[PATCH 2/4] Rename 'free' functions

2018-03-22 Thread Matthew Wilcox
From: Matthew Wilcox The names of these static functions collide with a kernel-wide 'free' function. Call them 'free_inst' instead. Signed-off-by: Matthew Wilcox --- crypto/lrw.c | 4 ++-- crypto/xts.c | 4 ++-- 2 files changed, 4

Re: [PATCH] nfit: skip region registration for incomplete control regions

2018-03-22 Thread Kani, Toshi
On Wed, 2018-03-21 at 21:42 -0700, Dan Williams wrote: > Per the ACPI specification the only functional purpose for a DIMM > Control Region to be mapped into the system physical address space, from > an OSPM perspective, is to support block-apertures. However, there are > some BIOSen that publish

[PATCH 2/4] Rename 'free' functions

2018-03-22 Thread Matthew Wilcox
From: Matthew Wilcox The names of these static functions collide with a kernel-wide 'free' function. Call them 'free_inst' instead. Signed-off-by: Matthew Wilcox --- crypto/lrw.c | 4 ++-- crypto/xts.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/crypto/lrw.c

[PATCH 4/4] rcu: Switch to using free() instead of kfree()

2018-03-22 Thread Matthew Wilcox
From: Matthew Wilcox Now we can free memory allocated with all kinds of functions that aren't kmalloc(). Signed-off-by: Matthew Wilcox --- include/linux/rcupdate.h | 40 +++- include/linux/rcutiny.h| 2

[PATCH 4/4] rcu: Switch to using free() instead of kfree()

2018-03-22 Thread Matthew Wilcox
From: Matthew Wilcox Now we can free memory allocated with all kinds of functions that aren't kmalloc(). Signed-off-by: Matthew Wilcox --- include/linux/rcupdate.h | 40 +++- include/linux/rcutiny.h| 2 +- include/linux/rcutree.h| 2 +-

git: cover letter and automatic Cc: [was Re: [PATCH 23/45] sched: add do_sched_yield() helper; remove in-kernel call to sched_yield()]

2018-03-22 Thread Xose Vazquez Perez
Linus Torvalds wrote: > On Thu, Mar 22, 2018 at 10:29 AM, Peter Zijlstra wrote: >> >> But why !? Either Cc me on more of the series such that the whole makes >> sense, or better yet, write a proper Changelog. > > This is a common issue. We should encourage people to always

git: cover letter and automatic Cc: [was Re: [PATCH 23/45] sched: add do_sched_yield() helper; remove in-kernel call to sched_yield()]

2018-03-22 Thread Xose Vazquez Perez
Linus Torvalds wrote: > On Thu, Mar 22, 2018 at 10:29 AM, Peter Zijlstra wrote: >> >> But why !? Either Cc me on more of the series such that the whole makes >> sense, or better yet, write a proper Changelog. > > This is a common issue. We should encourage people to always send at > least the

[PATCH] rtc: isl12022: use true and false for boolean values

2018-03-22 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/rtc/rtc-isl12022.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] rtc: isl12022: use true and false for boolean values

2018-03-22 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/rtc/rtc-isl12022.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-isl12022.c

Re: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

2018-03-22 Thread Maxime Chevallier
On Thu, 22 Mar 2018 15:43:08 -0400 (EDT), David Miller wrote : > From: Maxime Chevallier > Date: Thu, 22 Mar 2018 20:14:53 +0100 > > > Hello David, > > > > On Thu, 22 Mar 2018 14:47:09 -0400 (EDT), > > David Miller

Re: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

2018-03-22 Thread Maxime Chevallier
On Thu, 22 Mar 2018 15:43:08 -0400 (EDT), David Miller wrote : > From: Maxime Chevallier > Date: Thu, 22 Mar 2018 20:14:53 +0100 > > > Hello David, > > > > On Thu, 22 Mar 2018 14:47:09 -0400 (EDT), > > David Miller wrote : > > > >> From: Maxime Chevallier > >> Date: Wed, 21 Mar 2018

Re: [PATCH v4 4/6] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-22 Thread Casey Leedom
| From: Steve Wise | Sent: Thursday, March 22, 2018 9:28 AM | | | From: Sinan Kaya | | Date: Thursday, March 22, 2018 7:52 AM | | | | Isn't this a PowerPC problem? Why penalize other architectures? | | I worry it breaks PPC. And all other

Re: [PATCH v4 4/6] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-22 Thread Casey Leedom
| From: Steve Wise | Sent: Thursday, March 22, 2018 9:28 AM | | | From: Sinan Kaya | | Date: Thursday, March 22, 2018 7:52 AM | | | | Isn't this a PowerPC problem? Why penalize other architectures? | | I worry it breaks PPC. And all other architectures. Aparraently there isn't a formal API

Recent kernel change causing "rcu_sched detected stalls on CPUs/tasks"

2018-03-22 Thread Heiner Kallweit
Recently I started to get the following sporadic errors. Maybe related: When working with putty on the console then console frequently hangs for few seconds. linux-next from March 2nd still works fine. Platform is x86_64, Zotac CI-321 with Intel 2961Y. [ 9755.298719] INFO: rcu_sched detected

Recent kernel change causing "rcu_sched detected stalls on CPUs/tasks"

2018-03-22 Thread Heiner Kallweit
Recently I started to get the following sporadic errors. Maybe related: When working with putty on the console then console frequently hangs for few seconds. linux-next from March 2nd still works fine. Platform is x86_64, Zotac CI-321 with Intel 2961Y. [ 9755.298719] INFO: rcu_sched detected

Re: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

2018-03-22 Thread David Miller
From: Maxime Chevallier Date: Thu, 22 Mar 2018 20:14:53 +0100 > Hello David, > > On Thu, 22 Mar 2018 14:47:09 -0400 (EDT), > David Miller wrote : > >> From: Maxime Chevallier >> Date: Wed, 21 Mar 2018 16:14:00

Re: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

2018-03-22 Thread David Miller
From: Maxime Chevallier Date: Thu, 22 Mar 2018 20:14:53 +0100 > Hello David, > > On Thu, 22 Mar 2018 14:47:09 -0400 (EDT), > David Miller wrote : > >> From: Maxime Chevallier >> Date: Wed, 21 Mar 2018 16:14:00 +0100 >> >> In order to be an equivalent change you must bzero out this 'pe' >>

Re: [PATCH v3] irqchip/gic-v3: Ensure GICR_CTLR.EnableLPI=0 is observed before enabling

2018-03-22 Thread Shanker Donthineni
Hi Marc, On 03/22/2018 10:51 AM, Marc Zyngier wrote: > On 22/03/18 01:58, Shanker Donthineni wrote: >> The definition of the GICR_CTLR.RWP control bit was expanded to indicate >> status of changing GICR_CTLR.EnableLPI from 1 to 0 is being in progress >> or completed. Software must observe

Re: [PATCH v3] irqchip/gic-v3: Ensure GICR_CTLR.EnableLPI=0 is observed before enabling

2018-03-22 Thread Shanker Donthineni
Hi Marc, On 03/22/2018 10:51 AM, Marc Zyngier wrote: > On 22/03/18 01:58, Shanker Donthineni wrote: >> The definition of the GICR_CTLR.RWP control bit was expanded to indicate >> status of changing GICR_CTLR.EnableLPI from 1 to 0 is being in progress >> or completed. Software must observe

Re: [PATCH net-next 0/9] Add support of VF Reset to HNS3 VF driver

2018-03-22 Thread David Miller
From: Salil Mehta Date: Thu, 22 Mar 2018 14:28:51 + > This patch-set adds the support of VF reset to the existing VF driver. > VF Reset can be triggered due to TX watchdog firing as a result of TX > data-path not working. VF reset could also be a result of some

Re: [PATCH net-next 0/9] Add support of VF Reset to HNS3 VF driver

2018-03-22 Thread David Miller
From: Salil Mehta Date: Thu, 22 Mar 2018 14:28:51 + > This patch-set adds the support of VF reset to the existing VF driver. > VF Reset can be triggered due to TX watchdog firing as a result of TX > data-path not working. VF reset could also be a result of some internal > configuration

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-22 Thread Pavel Machek
Hi! > > user@devuan:/sys/devices/platform/4400.ocp/4a064000.usbhshost$ > > sudo lsusb > > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > > Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub > > user@devuan:/sys/devices/platform/4400.ocp/4a064000.usbhshost$ >

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-22 Thread Pavel Machek
Hi! > > user@devuan:/sys/devices/platform/4400.ocp/4a064000.usbhshost$ > > sudo lsusb > > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > > Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub > > user@devuan:/sys/devices/platform/4400.ocp/4a064000.usbhshost$ >

Re: [PATCH] caif_dev: use true and false for boolean values

2018-03-22 Thread Gustavo A. R. Silva
Hi all, I was just wondering about the status of this patch. Thanks! -- Gustavo On 03/05/2018 04:05 PM, Gustavo A. R. Silva wrote: Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva

Re: [PATCH] caif_dev: use true and false for boolean values

2018-03-22 Thread Gustavo A. R. Silva
Hi all, I was just wondering about the status of this patch. Thanks! -- Gustavo On 03/05/2018 04:05 PM, Gustavo A. R. Silva wrote: Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva

[PATCH] x86/efi: Free efi_pgd with free_pages()

2018-03-22 Thread Waiman Long
The efi_pgd is allocated as PGD_ALLOCATION_ORDER pages and so should also be freed as PGD_ALLOCATION_ORDER pages with free_pages(). Fixes: d9e9a6418065 ("x86/mm/pti: Allocate a separate user PGD") Signed-off-by: Waiman Long --- arch/x86/platform/efi/efi_64.c | 2 +- 1 file

[PATCH] x86/efi: Free efi_pgd with free_pages()

2018-03-22 Thread Waiman Long
The efi_pgd is allocated as PGD_ALLOCATION_ORDER pages and so should also be freed as PGD_ALLOCATION_ORDER pages with free_pages(). Fixes: d9e9a6418065 ("x86/mm/pti: Allocate a separate user PGD") Signed-off-by: Waiman Long --- arch/x86/platform/efi/efi_64.c | 2 +- 1 file changed, 1

Re: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

2018-03-22 Thread Maxime Chevallier
Hello David, On Thu, 22 Mar 2018 14:47:09 -0400 (EDT), David Miller wrote : > From: Maxime Chevallier > Date: Wed, 21 Mar 2018 16:14:00 +0100 > > > diff --git a/drivers/net/ethernet/marvell/mvpp2.c > > b/drivers/net/ethernet/marvell/mvpp2.c

Re: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

2018-03-22 Thread Maxime Chevallier
Hello David, On Thu, 22 Mar 2018 14:47:09 -0400 (EDT), David Miller wrote : > From: Maxime Chevallier > Date: Wed, 21 Mar 2018 16:14:00 +0100 > > > diff --git a/drivers/net/ethernet/marvell/mvpp2.c > > b/drivers/net/ethernet/marvell/mvpp2.c index > > 9bd35f2291d6..28e33e139178 100644 --- > >

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

2018-03-22 Thread Pavel Shilovsky
2018-03-21 22:12 GMT-07:00 Srivatsa S. Bhat : > On 3/21/18 7:02 PM, Steve French wrote: >> Found a patch which solves the dependency issue. In my testing (on >> 4.9, with Windows 2016, and also to Samba) as Pavel suggested this >> appears to fix the problem, but I will let

Re: [PATCH 4.13 28/43] SMB3: Validate negotiate request must always be signed

2018-03-22 Thread Pavel Shilovsky
2018-03-21 22:12 GMT-07:00 Srivatsa S. Bhat : > On 3/21/18 7:02 PM, Steve French wrote: >> Found a patch which solves the dependency issue. In my testing (on >> 4.9, with Windows 2016, and also to Samba) as Pavel suggested this >> appears to fix the problem, but I will let Srivatsa confirm that

[PATCH net-next,1/2] hv_netvsc: Fix the return status in RX path

2018-03-22 Thread Haiyang Zhang
From: Haiyang Zhang As defined in hyperv_net.h, the NVSP_STAT_SUCCESS is one not zero. Some functions returns 0 when it actually means NVSP_STAT_SUCCESS. This patch fixes them. In netvsc_receive(), it puts the last RNDIS packet's receive status for all packets in a

[PATCH net-next,1/2] hv_netvsc: Fix the return status in RX path

2018-03-22 Thread Haiyang Zhang
From: Haiyang Zhang As defined in hyperv_net.h, the NVSP_STAT_SUCCESS is one not zero. Some functions returns 0 when it actually means NVSP_STAT_SUCCESS. This patch fixes them. In netvsc_receive(), it puts the last RNDIS packet's receive status for all packets in a vmxferpage which may contain

[PATCH net-next,0/2] hv_netvsc: Fix/improve RX path error handling

2018-03-22 Thread Haiyang Zhang
From: Haiyang Zhang Fix the status code returned to the host. Also add range check for rx packet offset and length. Haiyang Zhang (2): hv_netvsc: Fix the return status in RX path hv_netvsc: Add range checking for rx packet offset and length

[PATCH net-next,2/2] hv_netvsc: Add range checking for rx packet offset and length

2018-03-22 Thread Haiyang Zhang
From: Haiyang Zhang This patch adds range checking for rx packet offset and length. It may only happen if there is a host side bug. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 1 + drivers/net/hyperv/netvsc.c | 17

[PATCH net-next,0/2] hv_netvsc: Fix/improve RX path error handling

2018-03-22 Thread Haiyang Zhang
From: Haiyang Zhang Fix the status code returned to the host. Also add range check for rx packet offset and length. Haiyang Zhang (2): hv_netvsc: Fix the return status in RX path hv_netvsc: Add range checking for rx packet offset and length drivers/net/hyperv/hyperv_net.h | 1 +

[PATCH net-next,2/2] hv_netvsc: Add range checking for rx packet offset and length

2018-03-22 Thread Haiyang Zhang
From: Haiyang Zhang This patch adds range checking for rx packet offset and length. It may only happen if there is a host side bug. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 1 + drivers/net/hyperv/netvsc.c | 17 +++-- 2 files changed, 16

[PATCH 4/4] Staging: iio: accel: adis16201: Move adis16201 driver out of staging

2018-03-22 Thread Himanshu Jha
Move adis16201 driver out of staging and merge into mainline IIO subsystem. Signed-off-by: Himanshu Jha --- drivers/iio/accel/Kconfig | 12 ++ drivers/iio/accel/Makefile| 1 + drivers/iio/accel/adis16201.c | 321

[PATCH 4/4] Staging: iio: accel: adis16201: Move adis16201 driver out of staging

2018-03-22 Thread Himanshu Jha
Move adis16201 driver out of staging and merge into mainline IIO subsystem. Signed-off-by: Himanshu Jha --- drivers/iio/accel/Kconfig | 12 ++ drivers/iio/accel/Makefile| 1 + drivers/iio/accel/adis16201.c | 321 ++

[PATCH 2/4] Staging: iio: accel: adis16201: Use GENMASK

2018-03-22 Thread Himanshu Jha
Use GENMASK to improve readability and remove the local variables used to store intermediate data. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff

[PATCH 2/4] Staging: iio: accel: adis16201: Use GENMASK

2018-03-22 Thread Himanshu Jha
Use GENMASK to improve readability and remove the local variables used to store intermediate data. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git

[PATCH 1/4] Staging: iio: accel: adis16201: Remove unused headers

2018-03-22 Thread Himanshu Jha
Remove few unused headers files since the adis core handles the buffer and sysfs support. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/iio/accel/adis16201.c

[PATCH 1/4] Staging: iio: accel: adis16201: Remove unused headers

2018-03-22 Thread Himanshu Jha
Remove few unused headers files since the adis core handles the buffer and sysfs support. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c

[PATCH 3/4] Staging: iio: accel: adis16201: Fix 80 character line limit

2018-03-22 Thread Himanshu Jha
Split the line over 80 characters limit to fix checkpatch warning. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/accel/adis16201.c

[PATCH 3/4] Staging: iio: accel: adis16201: Fix 80 character line limit

2018-03-22 Thread Himanshu Jha
Split the line over 80 characters limit to fix checkpatch warning. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c index

Re: [PATCH v2] cpuidle: poll_state: Add time limit to poll_idle()

2018-03-22 Thread Peter Zijlstra
On Thu, Mar 22, 2018 at 12:32:18PM -0400, Rik van Riel wrote: > On Wed, 2018-03-14 at 13:04 +0100, Peter Zijlstra wrote: > > > On x86 we don't have to use that time_check_counter thing, > > sched_clock() > > is really cheap, not sure if it makes sense on other platforms. > > Are you sure? I saw

Re: [PATCH v2] cpuidle: poll_state: Add time limit to poll_idle()

2018-03-22 Thread Peter Zijlstra
On Thu, Mar 22, 2018 at 12:32:18PM -0400, Rik van Riel wrote: > On Wed, 2018-03-14 at 13:04 +0100, Peter Zijlstra wrote: > > > On x86 we don't have to use that time_check_counter thing, > > sched_clock() > > is really cheap, not sure if it makes sense on other platforms. > > Are you sure? I saw

RE: [PATCH v2] cpuidle: poll_state: Add time limit to poll_idle()

2018-03-22 Thread Doug Smythies
On 2018.03.22 09:32 Rik van Riel wrote: > On Wed, 2018-03-14 at 13:04 +0100, Peter Zijlstra wrote: > >> On x86 we don't have to use that time_check_counter thing, >> sched_clock() >> is really cheap, not sure if it makes sense on other platforms. > > Are you sure? I saw a 5-10% increase in CPU

RE: [PATCH v2] cpuidle: poll_state: Add time limit to poll_idle()

2018-03-22 Thread Doug Smythies
On 2018.03.22 09:32 Rik van Riel wrote: > On Wed, 2018-03-14 at 13:04 +0100, Peter Zijlstra wrote: > >> On x86 we don't have to use that time_check_counter thing, >> sched_clock() >> is really cheap, not sure if it makes sense on other platforms. > > Are you sure? I saw a 5-10% increase in CPU

Re: [PATCH v4 4/6] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-22 Thread Sinan Kaya
On 3/22/2018 1:48 PM, Jason Gunthorpe wrote: >> AFAIS, even writeq won't compile on this arch. I started questioning this >> build test. > I have the same confusion. Did you figure out an explanation? I did a compile test without the relaxed change. It built just fine. CONFIG_64BIT is also not

Re: [PATCH v4 4/6] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-22 Thread Sinan Kaya
On 3/22/2018 1:48 PM, Jason Gunthorpe wrote: >> AFAIS, even writeq won't compile on this arch. I started questioning this >> build test. > I have the same confusion. Did you figure out an explanation? I did a compile test without the relaxed change. It built just fine. CONFIG_64BIT is also not

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-03-22 Thread Guenter Roeck
On Thu, Mar 22, 2018 at 06:52:51PM +0100, Greg Kroah-Hartman wrote: [ ... ] > > And that't the point to drive home here. If you stay away from updating > to stable patches, you have a huge boatload of KNOWN SECURITY HOLES in > your product. If you take them, you have the _possiblity_ of some

Re: [PATCH 4.4 095/108] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

2018-03-22 Thread Guenter Roeck
On Thu, Mar 22, 2018 at 06:52:51PM +0100, Greg Kroah-Hartman wrote: [ ... ] > > And that't the point to drive home here. If you stay away from updating > to stable patches, you have a huge boatload of KNOWN SECURITY HOLES in > your product. If you take them, you have the _possiblity_ of some

Re: Clang build of arm64 kernel fails

2018-03-22 Thread Matthias Kaehlcke
El Thu, Mar 01, 2018 at 10:31:02AM + Dave Martin ha dit: > On Thu, Mar 01, 2018 at 09:45:24AM +, Robin Murphy wrote: > > Hi Andrey, > > > > On 28/02/18 19:32, Andrey Konovalov wrote: > > >Hi Marc! > > > > > >I've tried to pull in new upstream commits and the kernel build > > >started

Re: Clang build of arm64 kernel fails

2018-03-22 Thread Matthias Kaehlcke
El Thu, Mar 01, 2018 at 10:31:02AM + Dave Martin ha dit: > On Thu, Mar 01, 2018 at 09:45:24AM +, Robin Murphy wrote: > > Hi Andrey, > > > > On 28/02/18 19:32, Andrey Konovalov wrote: > > >Hi Marc! > > > > > >I've tried to pull in new upstream commits and the kernel build > > >started

Re: [PATCH][next] gre: fix TUNNEL_SEQ bit check on sequence numbering

2018-03-22 Thread David Miller
From: Colin King Date: Wed, 21 Mar 2018 19:34:58 + > From: Colin Ian King > > The current logic of flags | TUNNEL_SEQ is always non-zero and hence > sequence numbers are always incremented no matter the setting of the > TUNNEL_SEQ bit.

Re: [PATCH][next] gre: fix TUNNEL_SEQ bit check on sequence numbering

2018-03-22 Thread David Miller
From: Colin King Date: Wed, 21 Mar 2018 19:34:58 + > From: Colin Ian King > > The current logic of flags | TUNNEL_SEQ is always non-zero and hence > sequence numbers are always incremented no matter the setting of the > TUNNEL_SEQ bit. Fix this by using & instead of |. > > Detected by

Re: [RFC PATCH v2 2/4] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-03-22 Thread Matthew Wilcox
On Thu, Mar 22, 2018 at 02:39:17PM -0400, Daniel Jordan wrote: > Shouldn't the anon column also contain lru? Probably; I didn't finish investigating everything. There should probably also be another column for swap pages. Maybe some other users use a significant amount of the struct page ... ?

Re: [RFC PATCH v2 2/4] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-03-22 Thread Matthew Wilcox
On Thu, Mar 22, 2018 at 02:39:17PM -0400, Daniel Jordan wrote: > Shouldn't the anon column also contain lru? Probably; I didn't finish investigating everything. There should probably also be another column for swap pages. Maybe some other users use a significant amount of the struct page ... ?

Re: [PATCH][next] net: mvpp2: use correct index on array mvpp2_pools

2018-03-22 Thread David Miller
From: Colin King Date: Wed, 21 Mar 2018 17:31:15 + > From: Colin Ian King > > Array mvpp2_pools is being indexed by long_log_pool, however this > looks like a cut-n-paste bug and in fact should be short_log_pool. > > Detected by

Re: [PATCH v4 4/6] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-22 Thread Jason Gunthorpe
On Thu, Mar 22, 2018 at 08:48:35AM -0400, ok...@codeaurora.org wrote: > On 2018-03-22 08:24, ok...@codeaurora.org wrote: > >On 2018-03-22 02:44, kbuild test robot wrote: > >>Hi Sinan, > >> > >>Thank you for the patch! Yet something to improve: > >> > >>[auto build test ERROR on linus/master] >

Re: [PATCH v4 4/6] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-22 Thread Jason Gunthorpe
On Thu, Mar 22, 2018 at 08:48:35AM -0400, ok...@codeaurora.org wrote: > On 2018-03-22 08:24, ok...@codeaurora.org wrote: > >On 2018-03-22 02:44, kbuild test robot wrote: > >>Hi Sinan, > >> > >>Thank you for the patch! Yet something to improve: > >> > >>[auto build test ERROR on linus/master] >

Re: [PATCH][next] net: mvpp2: use correct index on array mvpp2_pools

2018-03-22 Thread David Miller
From: Colin King Date: Wed, 21 Mar 2018 17:31:15 + > From: Colin Ian King > > Array mvpp2_pools is being indexed by long_log_pool, however this > looks like a cut-n-paste bug and in fact should be short_log_pool. > > Detected by CoverityScan, CID#1466113 ("Copy-paste error") > > Fixes:

Re: [RFC PATCH 1/8] mm: mmap: unmap large mapping by section

2018-03-22 Thread Matthew Wilcox
On Thu, Mar 22, 2018 at 10:34:08AM -0700, Yang Shi wrote: > On 3/21/18 10:29 AM, Matthew Wilcox wrote: > > Take the mmap_sem for write > > Find the VMA > >If the VMA is large(*) > > Mark the VMA as deleted > > Drop the mmap_sem > > zap all of the entries > > Take the

Re: [RFC PATCH 1/8] mm: mmap: unmap large mapping by section

2018-03-22 Thread Matthew Wilcox
On Thu, Mar 22, 2018 at 10:34:08AM -0700, Yang Shi wrote: > On 3/21/18 10:29 AM, Matthew Wilcox wrote: > > Take the mmap_sem for write > > Find the VMA > >If the VMA is large(*) > > Mark the VMA as deleted > > Drop the mmap_sem > > zap all of the entries > > Take the

Re: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

2018-03-22 Thread David Miller
From: Maxime Chevallier Date: Wed, 21 Mar 2018 16:14:00 +0100 > diff --git a/drivers/net/ethernet/marvell/mvpp2.c > b/drivers/net/ethernet/marvell/mvpp2.c > index 9bd35f2291d6..28e33e139178 100644 > --- a/drivers/net/ethernet/marvell/mvpp2.c > +++

Re: [PATCH net-next v2] net: mvpp2: Don't use dynamic allocs for local variables

2018-03-22 Thread David Miller
From: Maxime Chevallier Date: Wed, 21 Mar 2018 16:14:00 +0100 > diff --git a/drivers/net/ethernet/marvell/mvpp2.c > b/drivers/net/ethernet/marvell/mvpp2.c > index 9bd35f2291d6..28e33e139178 100644 > --- a/drivers/net/ethernet/marvell/mvpp2.c > +++ b/drivers/net/ethernet/marvell/mvpp2.c > @@

Re: [PATCH v4 4/6] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-22 Thread Jason Gunthorpe
On Thu, Mar 22, 2018 at 10:28:13AM -0400, Sinan Kaya wrote: >On 03/22/2018 08:48 AM, [1]ok...@codeaurora.org wrote: > > Jason, > Can you remove the writeq change if it is too late for me to fix? > This is an infrastructural issue on xtensa arch. > Probably, it won't get

Re: [PATCH v4 4/6] infiniband: cxgb4: Eliminate duplicate barriers on weakly-ordered archs

2018-03-22 Thread Jason Gunthorpe
On Thu, Mar 22, 2018 at 10:28:13AM -0400, Sinan Kaya wrote: >On 03/22/2018 08:48 AM, [1]ok...@codeaurora.org wrote: > > Jason, > Can you remove the writeq change if it is too late for me to fix? > This is an infrastructural issue on xtensa arch. > Probably, it won't get

<    1   2   3   4   5   6   7   8   9   10   >