Re: [PATCH 3/3] Storvsc: Select channel based on available percentage of ring buffer to write

Hi Long, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.16-rc6] [cannot apply to linus/master net-next/master net/master next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH 3/3] Storvsc: Select channel based on available percentage of ring buffer to write

Hi Long, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.16-rc6] [cannot apply to linus/master net-next/master net/master next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[REVIEW][PATCH 13/11] ipc/smack: Tidy up from the change in type of the ipc security hooks

Rename the variables shp, sma, msq to isp. As that is how the code already refers to those variables. Collapse smack_of_shm, smack_of_sem, and smack_of_msq into smack_of_ipc, as the three functions had become completely identical. Collapse smack_shm_alloc_security, smack_sem_alloc_security and

[REVIEW][PATCH 13/11] ipc/smack: Tidy up from the change in type of the ipc security hooks

Rename the variables shp, sma, msq to isp. As that is how the code already refers to those variables. Collapse smack_of_shm, smack_of_sem, and smack_of_msq into smack_of_ipc, as the three functions had become completely identical. Collapse smack_shm_alloc_security, smack_sem_alloc_security and

[REVIEW][PATCH 12/11] ipc: Directly call the security hook in ipc_ops.associate

After the last round of cleanups the shm, sem, and msg associate operations just became trivial wrappers around the appropriate security method. Simplify things further by just calling the security method directly. Signed-off-by: "Eric W. Biederman" --- ipc/msg.c | 10

[REVIEW][PATCH 12/11] ipc: Directly call the security hook in ipc_ops.associate

After the last round of cleanups the shm, sem, and msg associate operations just became trivial wrappers around the appropriate security method. Simplify things further by just calling the security method directly. Signed-off-by: "Eric W. Biederman" --- ipc/msg.c | 10 +- ipc/sem.c |

Re: [REVIEW][PATCH 03/11] msg/security: Pass kern_ipc_perm not msg_queue into the msg_queue security hooks

Casey Schaufler writes: > On 3/23/2018 12:16 PM, Eric W. Biederman wrote: >> All of the implementations of security hooks that take msg_queue only >> access q_perm the struct kern_ipc_perm member. This means the >> dependencies of the msg_queue security hooks can be

Re: [REVIEW][PATCH 03/11] msg/security: Pass kern_ipc_perm not msg_queue into the msg_queue security hooks

Casey Schaufler writes: > On 3/23/2018 12:16 PM, Eric W. Biederman wrote: >> All of the implementations of security hooks that take msg_queue only >> access q_perm the struct kern_ipc_perm member. This means the >> dependencies of the msg_queue security hooks can be simplified by >> passing the

Re: [PATCH]cgroup: __cpuset_node_allowed return bool

From 304cec1cc42255fbd9e231a810f4eea20ab74b90 Mon Sep 17 00:00:00 2001 From: John Zhao Date: Sat, 24 Mar 2018 13:01:32 +0800 Subject: [PATCH] cgroup: __cpuset_node_allowed return bool as a bool, __cpuset_node_allowed(...) return should be bool. Signed-off-by: John Zhao

Re: [PATCH]cgroup: __cpuset_node_allowed return bool

From 304cec1cc42255fbd9e231a810f4eea20ab74b90 Mon Sep 17 00:00:00 2001 From: John Zhao Date: Sat, 24 Mar 2018 13:01:32 +0800 Subject: [PATCH] cgroup: __cpuset_node_allowed return bool as a bool, __cpuset_node_allowed(...) return should be bool. Signed-off-by: John Zhao ---

[PATCH]cgroup: __cpuset_node_allowed return bool

as a bool, __cpuset_node_allowed(...) return should be bool. Signed-off-by: John Zhao --- kernel/cgroup/cpuset.c.orig 2018-03-24 12:39:27.854178608 +0800 +++ kernel/cgroup/cpuset.c 2018-03-24 12:40:51.020708670 +0800 @@ -2552,7 +2552,7 @@ static struct cpuset

[PATCH]cgroup: __cpuset_node_allowed return bool

as a bool, __cpuset_node_allowed(...) return should be bool. Signed-off-by: John Zhao --- kernel/cgroup/cpuset.c.orig 2018-03-24 12:39:27.854178608 +0800 +++ kernel/cgroup/cpuset.c 2018-03-24 12:40:51.020708670 +0800 @@ -2552,7 +2552,7 @@ static struct cpuset *nearest_hardwall_a bool

Re: [PATCH v2 0/2] Fix __earlycon_table stride... again

On Fri, Mar 23, 2018 at 7:34 AM Greg Kroah-Hartman < gre...@linuxfoundation.org> wrote: > On Tue, Mar 20, 2018 at 11:57:10AM -0600, Daniel Kurtz wrote: > > The __earlycon_table lives in a special "__earlycon_table" section. The > > contents of this table are added using some macros that deposit

Re: [PATCH v2 0/2] Fix __earlycon_table stride... again

On Fri, Mar 23, 2018 at 7:34 AM Greg Kroah-Hartman < gre...@linuxfoundation.org> wrote: > On Tue, Mar 20, 2018 at 11:57:10AM -0600, Daniel Kurtz wrote: > > The __earlycon_table lives in a special "__earlycon_table" section. The > > contents of this table are added using some macros that deposit

Re: [PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct

> So, introduce a new rwlock in mm_struct to protect the concurrent access > to arg_start|end and env_start|end. I don't think an rwlock makes much sense here. There is almost no concurrency on the read side, and an rwlock is more expensive than a spinlock. Just use a spinlock.

Re: [PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct

> So, introduce a new rwlock in mm_struct to protect the concurrent access > to arg_start|end and env_start|end. I don't think an rwlock makes much sense here. There is almost no concurrency on the read side, and an rwlock is more expensive than a spinlock. Just use a spinlock.

[PATCH 2/3] ieee80211: Replace bit shifts with the BIT() macro for measurement masks.

It is neater and more consistent with the rest of the document to use the BIT() macro from 'linux/bitops.h' to define the IEEE80211_SPCT_MSR_RPRT_MODE_* bitmasks. Signed-off-by: Quytelda Kahja --- include/linux/ieee80211.h | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 2/3] ieee80211: Replace bit shifts with the BIT() macro for measurement masks.

It is neater and more consistent with the rest of the document to use the BIT() macro from 'linux/bitops.h' to define the IEEE80211_SPCT_MSR_RPRT_MODE_* bitmasks. Signed-off-by: Quytelda Kahja --- include/linux/ieee80211.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 3/3] ieee80211: Replace bit shifts with the BIT() macro for 802.11g ERP IEs.

It is neater and more consistent with the rest of the document to use the BIT() macro from 'linux/bitops.h' to define the WLAN_ERP_* bitmasks. Signed-off-by: Quytelda Kahja --- include/linux/ieee80211.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 3/3] ieee80211: Replace bit shifts with the BIT() macro for 802.11g ERP IEs.

It is neater and more consistent with the rest of the document to use the BIT() macro from 'linux/bitops.h' to define the WLAN_ERP_* bitmasks. Signed-off-by: Quytelda Kahja --- include/linux/ieee80211.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 1/3] ieee80211: Replace bit shifts with the BIT() macro for WLAN_CAPABILITY_*.

It is neater and more consistent with the rest of the document to use the BIT() macro from 'linux/bitops.h' to define the WLAN_CAPABILITY_* bitmasks. In the case of WLAN_CAPABILITY_DMG_TYPE_{IBSS, PBSS, AP}, bitshifting integers by 0 does nothing, so there is no reason to do it in the code;

[PATCH 1/3] ieee80211: Replace bit shifts with the BIT() macro for WLAN_CAPABILITY_*.

It is neater and more consistent with the rest of the document to use the BIT() macro from 'linux/bitops.h' to define the WLAN_CAPABILITY_* bitmasks. In the case of WLAN_CAPABILITY_DMG_TYPE_{IBSS, PBSS, AP}, bitshifting integers by 0 does nothing, so there is no reason to do it in the code;

Re: [PATCH v6 6/6] bnxt_en: Eliminate duplicate barriers on weakly-ordered archs

On 3/23/2018 6:36 PM, Michael Chan wrote: >> + mmiowb(); > Sorry for the late review. mmiowb() is not required here because we > are in NAPI context, so only one CPU will be updating this doorbell. > > Other than that, it looks good. > OK, I'll fix this on the next version. --

Re: [PATCH v6 6/6] bnxt_en: Eliminate duplicate barriers on weakly-ordered archs

On 3/23/2018 6:36 PM, Michael Chan wrote: >> + mmiowb(); > Sorry for the late review. mmiowb() is not required here because we > are in NAPI context, so only one CPU will be updating this doorbell. > > Other than that, it looks good. > OK, I'll fix this on the next version. --

Re: [PATCH v3 01/11] PCI/P2PDMA: Support peer-to-peer memory

On Fri, Mar 23, 2018 at 03:59:14PM -0600, Logan Gunthorpe wrote: > On 23/03/18 03:50 PM, Bjorn Helgaas wrote: > > Popping way up the stack, my original point was that I'm trying to > > remove restrictions on what devices can participate in > > peer-to-peer DMA. I think it's fairly clear that in

Re: [PATCH v3 01/11] PCI/P2PDMA: Support peer-to-peer memory

On Fri, Mar 23, 2018 at 03:59:14PM -0600, Logan Gunthorpe wrote: > On 23/03/18 03:50 PM, Bjorn Helgaas wrote: > > Popping way up the stack, my original point was that I'm trying to > > remove restrictions on what devices can participate in > > peer-to-peer DMA. I think it's fairly clear that in

[PATCH net-next 1/5] net: hns3: fix for returning wrong value problem in hns3_get_rss_key_size

From: Fuyun Liang The return type of hns3_get_rss_key_size is u32. But a negative value is returned. This patch fixes it by replacing the negative value with zero. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li ---

[PATCH net-next 4/5] net: hns3: fix for not initializing VF rss_hash_key problem

From: Fuyun Liang Default rss_hash_key value should be given to all vports. But just the PF rss_hash_key has the default value here. This patch adds rss_hash_key Initialization for all vports. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li

[PATCH net-next 1/5] net: hns3: fix for returning wrong value problem in hns3_get_rss_key_size

From: Fuyun Liang The return type of hns3_get_rss_key_size is u32. But a negative value is returned. This patch fixes it by replacing the negative value with zero. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +- 1 file changed,

[PATCH net-next 4/5] net: hns3: fix for not initializing VF rss_hash_key problem

From: Fuyun Liang Default rss_hash_key value should be given to all vports. But just the PF rss_hash_key has the default value here. This patch adds rss_hash_key Initialization for all vports. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li ---

[PATCH net-next 5/5] net: hns3: never send command queue message to IMP when reset

IMP will not handle and command queue message any more when it is in core/global, driver should not send command queue message to IMP until reinitialize the NIC HW. This patch checks the status and avoid the message sent to IMP when reset. Signed-off-by: Peng Li ---

[PATCH net-next 5/5] net: hns3: never send command queue message to IMP when reset

IMP will not handle and command queue message any more when it is in core/global, driver should not send command queue message to IMP until reinitialize the NIC HW. This patch checks the status and avoid the message sent to IMP when reset. Signed-off-by: Peng Li ---

[PATCH net-next 3/5] net: hns3: fix for the wrong shift problem in hns3_set_txbd_baseinfo

From: Fuyun Liang Third parameter of hnae_set_field is shift, But a mask is given. This patch fixes it by replacing HNS3_TXD_BDTYPE_M with HNS3_TXD_BDTYPE_S. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li ---

[PATCH net-next 2/5] net: hns3: fix for returning wrong value problem in hns3_get_rss_indir_size

From: Fuyun Liang The return type of hns3_get_rss_indir_size is u32. But a negative value is returned. This patch fixes it by replacing the negative value with zero. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li ---

[PATCH net-next 3/5] net: hns3: fix for the wrong shift problem in hns3_set_txbd_baseinfo

From: Fuyun Liang Third parameter of hnae_set_field is shift, But a mask is given. This patch fixes it by replacing HNS3_TXD_BDTYPE_M with HNS3_TXD_BDTYPE_S. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- 1 file changed, 1

[PATCH net-next 2/5] net: hns3: fix for returning wrong value problem in hns3_get_rss_indir_size

From: Fuyun Liang The return type of hns3_get_rss_indir_size is u32. But a negative value is returned. This patch fixes it by replacing the negative value with zero. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +- 1 file

[PATCH net-next 0/5] fix some bugs for HNS3

This patchset fixes some bugs for HNS3 driver: [Patch 1/5 - 2/5] fix 2 return vlaue issues. [Patch 3/5 - 4/5] fix 2 comments reported by code review. [Ptach 5/5] avoid sending message to IMP because IMP will not handle any message when it is resetting. Fuyun Liang (4): net: hns3: fix for

[PATCH net-next 0/5] fix some bugs for HNS3

This patchset fixes some bugs for HNS3 driver: [Patch 1/5 - 2/5] fix 2 return vlaue issues. [Patch 3/5 - 4/5] fix 2 comments reported by code review. [Ptach 5/5] avoid sending message to IMP because IMP will not handle any message when it is resetting. Fuyun Liang (4): net: hns3: fix for

[PATCH 3/3] module: Support to disable validity enforcement in runtime

In order to disable the module validity enforcement, writing a PKCS#7 signature corresponding the signed content '0' is required. Given a simple way to archive this: $ echo -n 0 > no_sig_enforce $ openssl smime -sign -nocerts -noattr -binary \ -in no_sig_enforce -inkey \ -signer

[PATCH 3/3] module: Support to disable validity enforcement in runtime

In order to disable the module validity enforcement, writing a PKCS#7 signature corresponding the signed content '0' is required. Given a simple way to archive this: $ echo -n 0 > no_sig_enforce $ openssl smime -sign -nocerts -noattr -binary \ -in no_sig_enforce -inkey \ -signer

[PATCH 2/3] module: Create the entry point initialize_module()

This entry point currently includes the procfs initialization, and will include a securityfs initialization. Signed-off-by: Jia Zhang --- kernel/module.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/kernel/module.c

[PATCH 1/3] module: Do not access sig_enforce directly

Call is_module_sig_enforced() instead. Signed-off-by: Jia Zhang --- kernel/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/module.c b/kernel/module.c index ad2d420..003d0ab 100644 --- a/kernel/module.c +++ b/kernel/module.c @@

[PATCH 2/3] module: Create the entry point initialize_module()

This entry point currently includes the procfs initialization, and will include a securityfs initialization. Signed-off-by: Jia Zhang --- kernel/module.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/kernel/module.c b/kernel/module.c index 003d0ab..79825ea

[PATCH 1/3] module: Do not access sig_enforce directly

Call is_module_sig_enforced() instead. Signed-off-by: Jia Zhang --- kernel/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/module.c b/kernel/module.c index ad2d420..003d0ab 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -2789,7 +2789,7 @@ static int

[PATCH v3 0/3][RESEND] modsign enhancement

This patch series allows to disable module validity enforcement in runtime through the control switch located in securityfs. In order to keep /sys/module/module/parameters/sig_enforce simple, the disablement switch is located at /sys/kernel/security/modsign/disable_enforce. Assuming

[PATCH v3 0/3][RESEND] modsign enhancement

This patch series allows to disable module validity enforcement in runtime through the control switch located in securityfs. In order to keep /sys/module/module/parameters/sig_enforce simple, the disablement switch is located at /sys/kernel/security/modsign/disable_enforce. Assuming

Re: [PATCH v5 00/13] ARM: dts: ipq: updates to enable a few peripherals

On Fri, Mar 23, 2018 at 03:48:43PM +0530, Sricharan R wrote: > [v5] > * Fixed a minor comment that i missed earlier. I tried booting this series with qcom_defconfig on my custom, dk07-like board. It works! Thanks a bunch, Richard

Re: [PATCH v5 00/13] ARM: dts: ipq: updates to enable a few peripherals

On Fri, Mar 23, 2018 at 03:48:43PM +0530, Sricharan R wrote: > [v5] > * Fixed a minor comment that i missed earlier. I tried booting this series with qcom_defconfig on my custom, dk07-like board. It works! Thanks a bunch, Richard

Re: [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init()

On Fri, 2018-03-23 at 11:44 +0800, Ryder Lee wrote: > The error return value should be fixed as it may return EPROBE_DEFER. > > Cc: Rick Chang > Cc: Bin Liu > Signed-off-by: Ryder Lee > --- >  

Re: [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init()

On Fri, 2018-03-23 at 11:44 +0800, Ryder Lee wrote: > The error return value should be fixed as it may return EPROBE_DEFER. > > Cc: Rick Chang > Cc: Bin Liu > Signed-off-by: Ryder Lee > --- >  drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++-- >  1 file changed, 2 insertions(+), 2

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

On Thursday 22 Mar 2018 at 13:19:03 (-0700), Joel Fernandes wrote: > On Thu, Mar 22, 2018 at 11:06 AM, Patrick Bellasi > wrote: [...] > >> > @@ -6555,6 +6613,14 @@ select_task_rq_fair(struct task_struct *p, int > >> > prev_cpu, int sd_flag, int wake_f > >> >

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

On Thursday 22 Mar 2018 at 13:19:03 (-0700), Joel Fernandes wrote: > On Thu, Mar 22, 2018 at 11:06 AM, Patrick Bellasi > wrote: [...] > >> > @@ -6555,6 +6613,14 @@ select_task_rq_fair(struct task_struct *p, int > >> > prev_cpu, int sd_flag, int wake_f > >> > break; > >>

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

On Friday 23 Mar 2018 at 18:13:56 (-0700), Joel Fernandes wrote: > Hi Morten, > > On Fri, Mar 23, 2018 at 8:47 AM, Morten Rasmussen > wrote: > > On Thu, Mar 22, 2018 at 01:10:22PM -0700, Joel Fernandes wrote: [...] > > You mean if SD_BALANCE_WAKE isn't set on

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

On Friday 23 Mar 2018 at 18:13:56 (-0700), Joel Fernandes wrote: > Hi Morten, > > On Fri, Mar 23, 2018 at 8:47 AM, Morten Rasmussen > wrote: > > On Thu, Mar 22, 2018 at 01:10:22PM -0700, Joel Fernandes wrote: [...] > > You mean if SD_BALANCE_WAKE isn't set on sched_domains? > > Yes. > > >

Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

On Fri, Mar 23, 2018 at 06:08:07PM -0700, Andrew Chant wrote: > >> +"New USB device found, idVendor=%04x, idProduct=%04x, > >> bcdDevice=%04x\n", > > Can you please decode bcdDevice into a decimal string? > > > > lsusb -v does this (bcdDevice: 0.03 for example) and in my

Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

On Fri, Mar 23, 2018 at 06:08:07PM -0700, Andrew Chant wrote: > >> +"New USB device found, idVendor=%04x, idProduct=%04x, > >> bcdDevice=%04x\n", > > Can you please decode bcdDevice into a decimal string? > > > > lsusb -v does this (bcdDevice: 0.03 for example) and in my

[PATCH v2] USB: announce bcdDevice as well as idVendor, idProduct.

Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson Leung

[PATCH v2] USB: announce bcdDevice as well as idVendor, idProduct.

Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson Leung

Re: [PATCH] [RFC] drm: rcar-du: keep temporary dtb files around during build

Hi Geert, On 03/22/18 07:26, Geert Uytterhoeven wrote: > Hi Frank, > > On Fri, Mar 16, 2018 at 2:39 AM, wrote: >> On Thursday, March 15, 2018 8:37 AM, Arnd Bergmann [mailto:a...@arndb.de] >> wrote: >>> >>> The *.dtb and *.dtb.S files get removed by 'make' during the

Re: [PATCH] [RFC] drm: rcar-du: keep temporary dtb files around during build

Hi Geert, On 03/22/18 07:26, Geert Uytterhoeven wrote: > Hi Frank, > > On Fri, Mar 16, 2018 at 2:39 AM, wrote: >> On Thursday, March 15, 2018 8:37 AM, Arnd Bergmann [mailto:a...@arndb.de] >> wrote: >>> >>> The *.dtb and *.dtb.S files get removed by 'make' during the build >>> process, >>>

Re: [PATCH 01/10] .gitignore: move *.lex.c *.tab.[ch] patterns to the top-level .gitignore

On 03/23/18 06:04, Masahiro Yamada wrote: > These patterns are common to host programs that require lexer and parser. > Move them to the top .gitignore. > > Signed-off-by: Masahiro Yamada Acked-by: Frank Rowand -Frank > --- > >

Re: [PATCH 01/10] .gitignore: move *.lex.c *.tab.[ch] patterns to the top-level .gitignore

On 03/23/18 06:04, Masahiro Yamada wrote: > These patterns are common to host programs that require lexer and parser. > Move them to the top .gitignore. > > Signed-off-by: Masahiro Yamada Acked-by: Frank Rowand -Frank > --- > > .gitignore | 2 ++ > scripts/dtc/.gitignore

Re: [PATCH 10/10] kbuild: mark $(targets) as .SECONDARY and remove .PRECIOUS specifier

On 03/23/18 06:04, Masahiro Yamada wrote: > GNU Make automatically deletes intermediate files that are updated > in a chain of pattern rules. > > Example 1) %.dtb.o <- %.dtb.S <- %.dtb.S <- %.dts > Example 2) %.o <- %.c <- %.c_shipped > > A couple of makefiles mark such targets as .PRECIOUS to

Re: [PATCH 10/10] kbuild: mark $(targets) as .SECONDARY and remove .PRECIOUS specifier

On 03/23/18 06:04, Masahiro Yamada wrote: > GNU Make automatically deletes intermediate files that are updated > in a chain of pattern rules. > > Example 1) %.dtb.o <- %.dtb.S <- %.dtb.S <- %.dts > Example 2) %.o <- %.c <- %.c_shipped > > A couple of makefiles mark such targets as .PRECIOUS to

Re: [PATCH 05/10] kbuild: add %.dtb.S and %.dtb to 'targets' automatically

On 03/23/18 06:04, Masahiro Yamada wrote: > Another common pattern that consists of chained commands is to compile > a DTB as binary data into the kernel image or a module. It is used in > several places in the source tree. Let's support it in the build core. > > $(call if_changed,dt_S_dtb) is

Re: [PATCH 05/10] kbuild: add %.dtb.S and %.dtb to 'targets' automatically

On 03/23/18 06:04, Masahiro Yamada wrote: > Another common pattern that consists of chained commands is to compile > a DTB as binary data into the kernel image or a module. It is used in > several places in the source tree. Let's support it in the build core. > > $(call if_changed,dt_S_dtb) is

Re: [PATCH 04/10] kbuild: add %.lex.c and %.tab.[ch] to 'targets' automatically

On 03/23/18 06:04, Masahiro Yamada wrote: > Files generated by if_changed* must be added to 'targets' to include > *.cmd files. Otherwise, they would be regenerated every time. > > The build system automatically adds objects to 'targets' where > appropriate, such as obj-y, extra-y, etc. but does

Re: [PATCH 04/10] kbuild: add %.lex.c and %.tab.[ch] to 'targets' automatically

On 03/23/18 06:04, Masahiro Yamada wrote: > Files generated by if_changed* must be added to 'targets' to include > *.cmd files. Otherwise, they would be regenerated every time. > > The build system automatically adds objects to 'targets' where > appropriate, such as obj-y, extra-y, etc. but does

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

On Friday 23 Mar 2018 at 15:47:45 (+), Morten Rasmussen wrote: > On Thu, Mar 22, 2018 at 01:10:22PM -0700, Joel Fernandes wrote: > > On Wed, Mar 21, 2018 at 8:35 AM, Patrick Bellasi > > wrote: > > > [...] > > > > > >> @@ -6555,6 +6613,14 @@ select_task_rq_fair(struct

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

On Friday 23 Mar 2018 at 15:47:45 (+), Morten Rasmussen wrote: > On Thu, Mar 22, 2018 at 01:10:22PM -0700, Joel Fernandes wrote: > > On Wed, Mar 21, 2018 at 8:35 AM, Patrick Bellasi > > wrote: > > > [...] > > > > > >> @@ -6555,6 +6613,14 @@ select_task_rq_fair(struct task_struct *p, int > >

Re: rcu: Add might_sleep() check to synchronize_rcu()

On Fri, 23 Mar 2018 15:57:04 -0700 Joel Fernandes wrote: > > diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c > > index 194a7483bb93..857b494bee29 100644 > > --- a/net/l2tp/l2tp_core.c > > +++ b/net/l2tp/l2tp_core.c > > @@ -1677,6 +1677,8 @@ void

Re: rcu: Add might_sleep() check to synchronize_rcu()

On Fri, 23 Mar 2018 15:57:04 -0700 Joel Fernandes wrote: > > diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c > > index 194a7483bb93..857b494bee29 100644 > > --- a/net/l2tp/l2tp_core.c > > +++ b/net/l2tp/l2tp_core.c > > @@ -1677,6 +1677,8 @@ void __l2tp_session_unhash(struct l2tp_session

Re: [PATCH 02/10] kbuild: clean up *.lex.c and *.tab.[ch] patterns from top-level Makefile

On 03/23/18 06:04, Masahiro Yamada wrote: > Files suffixed by .lex.c, .tab.[ch] are generated lexers, parsers, > respectively. Clean them up globally from the top Makefile. > > Some of the final host programs they are linked into are needed for > building external modules, but those

Re: [PATCH 02/10] kbuild: clean up *.lex.c and *.tab.[ch] patterns from top-level Makefile

On 03/23/18 06:04, Masahiro Yamada wrote: > Files suffixed by .lex.c, .tab.[ch] are generated lexers, parsers, > respectively. Clean them up globally from the top Makefile. > > Some of the final host programs they are linked into are needed for > building external modules, but those

Re: ftrace on MIPS/ath79

On Fri, 23 Mar 2018 23:20:10 +0100 Matthias Schiffer wrote: > Hi, > I'm currently trying to debug a performance bottleneck on low-end ath79 > hardware running OpenWrt/LEDE, but it seems that ftrace is not working > correctly on these systems. I have tried this

Re: ftrace on MIPS/ath79

On Fri, 23 Mar 2018 23:20:10 +0100 Matthias Schiffer wrote: > Hi, > I'm currently trying to debug a performance bottleneck on low-end ath79 > hardware running OpenWrt/LEDE, but it seems that ftrace is not working > correctly on these systems. I have tried this with recent 4.4.y and 4.9.y > with

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

Hi Morten, On Fri, Mar 23, 2018 at 8:47 AM, Morten Rasmussen wrote: > On Thu, Mar 22, 2018 at 01:10:22PM -0700, Joel Fernandes wrote: >> On Wed, Mar 21, 2018 at 8:35 AM, Patrick Bellasi >> wrote: >> > [...] >> > >> >> @@ -6555,6 +6613,14 @@

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

Hi Morten, On Fri, Mar 23, 2018 at 8:47 AM, Morten Rasmussen wrote: > On Thu, Mar 22, 2018 at 01:10:22PM -0700, Joel Fernandes wrote: >> On Wed, Mar 21, 2018 at 8:35 AM, Patrick Bellasi >> wrote: >> > [...] >> > >> >> @@ -6555,6 +6613,14 @@ select_task_rq_fair(struct task_struct *p, int >> >>

Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

On Fri, Mar 23, 2018 at 5:48 PM, Andrew Chant wrote: > On Fri, Mar 23, 2018 at 5:33 PM, Benson Leung wrote: >> Print bcdDevice which is used by vendors to identify different versions >> of the same product (or different versions of firmware). >> >> Adding

Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

On Fri, Mar 23, 2018 at 5:48 PM, Andrew Chant wrote: > On Fri, Mar 23, 2018 at 5:33 PM, Benson Leung wrote: >> Print bcdDevice which is used by vendors to identify different versions >> of the same product (or different versions of firmware). >> >> Adding this to the logs will be useful for

Re: [PATCH v3 2/2] x86, cpuid: allow cpuid_read() to schedule

On 03/23/2018 03:17 PM, H. Peter Anvin wrote: > On 03/23/18 14:58, Eric Dumazet wrote: >> I noticed high latencies caused by a daemon periodically reading various >> MSR and cpuid on all cpus. KASAN kernels would see ~10ms latencies >> simply reading one cpuid. Even without KASAN, sending IPI to

Re: [PATCH v3 2/2] x86, cpuid: allow cpuid_read() to schedule

On 03/23/2018 03:17 PM, H. Peter Anvin wrote: > On 03/23/18 14:58, Eric Dumazet wrote: >> I noticed high latencies caused by a daemon periodically reading various >> MSR and cpuid on all cpus. KASAN kernels would see ~10ms latencies >> simply reading one cpuid. Even without KASAN, sending IPI to

Re: [PATCH 00/11] Use global pages with PTI

On Fri, Mar 23, 2018 at 5:46 PM, Linus Torvalds wrote: > > It is, of course, possible that I misunderstood what you actually > benchmarked. But I assume the above benchmark numbers are with the > whole "don't even do global entries if you have PCID". Oh, I went

Re: [PATCH 00/11] Use global pages with PTI

On Fri, Mar 23, 2018 at 5:46 PM, Linus Torvalds wrote: > > It is, of course, possible that I misunderstood what you actually > benchmarked. But I assume the above benchmark numbers are with the > whole "don't even do global entries if you have PCID". Oh, I went back and read your description,

Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

On Fri, Mar 23, 2018 at 5:33 PM, Benson Leung wrote: > Print bcdDevice which is used by vendors to identify different versions > of the same product (or different versions of firmware). > > Adding this to the logs will be useful for support purposes. > > Signed-off-by: Benson

Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

On Fri, Mar 23, 2018 at 5:33 PM, Benson Leung wrote: > Print bcdDevice which is used by vendors to identify different versions > of the same product (or different versions of firmware). > > Adding this to the logs will be useful for support purposes. > > Signed-off-by: Benson Leung > --- >

Re: [PATCH 00/11] Use global pages with PTI

On Fri, Mar 23, 2018 at 5:40 PM, Dave Hansen wrote: > > Well, rats. This somehow makes things slower with PCIDs on. .. what happens when you enable global pages with PCID? You disabled them explicitly because you thought they wouldn't matter.. Even with PCID, a

Re: [PATCH 00/11] Use global pages with PTI

On Fri, Mar 23, 2018 at 5:40 PM, Dave Hansen wrote: > > Well, rats. This somehow makes things slower with PCIDs on. .. what happens when you enable global pages with PCID? You disabled them explicitly because you thought they wouldn't matter.. Even with PCID, a global TLB entry for the shared

Re: [PATCH 00/11] Use global pages with PTI

On 03/23/2018 11:26 AM, Linus Torvalds wrote: > On Fri, Mar 23, 2018 at 10:44 AM, Dave Hansen > wrote: >> >> This adds one major change from the last version of the patch set >> (present in the last patch). It makes all kernel text global for non- >> PCID systems.

Re: [PATCH 00/11] Use global pages with PTI

On 03/23/2018 11:26 AM, Linus Torvalds wrote: > On Fri, Mar 23, 2018 at 10:44 AM, Dave Hansen > wrote: >> >> This adds one major change from the last version of the patch set >> (present in the last patch). It makes all kernel text global for non- >> PCID systems. This keeps kernel data

[PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct

mmap_sem is on the hot path of kernel, and it very contended, but it is abused too. It is used to protect arg_start|end and evn_start|end when reading /proc/$PID/cmdline and /proc/$PID/environ, but it doesn't make sense since those proc files just expect to read 4 values atomically and not related

[PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct

mmap_sem is on the hot path of kernel, and it very contended, but it is abused too. It is used to protect arg_start|end and evn_start|end when reading /proc/$PID/cmdline and /proc/$PID/environ, but it doesn't make sense since those proc files just expect to read 4 values atomically and not related

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

On Fri, Mar 23, 2018 at 9:00 AM, Morten Rasmussen wrote: > On Thu, Mar 22, 2018 at 09:27:43AM -0700, Joel Fernandes wrote: >> > >> > In case an energy model is available, waking tasks are re-routed into a >> > new energy-aware placement algorithm. The eligible CPUs to be

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

On Fri, Mar 23, 2018 at 9:00 AM, Morten Rasmussen wrote: > On Thu, Mar 22, 2018 at 09:27:43AM -0700, Joel Fernandes wrote: >> > >> > In case an energy model is available, waking tasks are re-routed into a >> > new energy-aware placement algorithm. The eligible CPUs to be used in the >> >

[PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Signed-off-by: Benson Leung --- drivers/usb/core/hub.c | 16 +--- 1

[PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Signed-off-by: Benson Leung --- drivers/usb/core/hub.c | 16 +--- 1 file changed, 9

[PATCH 0/4] tty/nozomi: general module cleanup

The nozomi module code has a fair amount of sections which could use a bit of improvement; both style and clarity could be improved while maintaining equivalent semantics. Cleanup messy portions of the module code while preserving existing behavior by: - Replacing constructs like `len__ >

[PATCH 0/4] tty/nozomi: general module cleanup

The nozomi module code has a fair amount of sections which could use a bit of improvement; both style and clarity could be improved while maintaining equivalent semantics. Cleanup messy portions of the module code while preserving existing behavior by: - Replacing constructs like `len__ >

[PATCH 3/4] tty/nozomi: improve code readability and style

Improve code clarity by renaming identifiers and reorganizing function control flow. Signed-off-by: Joey Pabalinas 1 file changed, 92 insertions(+), 91 deletions(-) 1 file changed, 76 insertions(+), 90 deletions(-) diff --git a/drivers/tty/nozomi.c

[PATCH 2/4] tty/nozomi: fix inconsistent indentation

Correct misaligned indentation and remove extraneous spaces. Signed-off-by: Joey Pabalinas 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index f26bf1d1e9ee0e74eb..0fcb4db721d2a42f08 100644 ---

  1   2   3   4   5   6   7   8   9   10   >