RE: [EXT] [PATCH net-next v2 0/2] phylink: API changes

Hi Florian Please keep CC Yelena Krivosheev for changes withdrivers/net/ethernet/marvell/mvneta.c Thanks Yan Markman Tel. 05-44732819 -Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Thursday, March 29, 2018 1:44 AM To:

RE: [EXT] [PATCH net-next v2 0/2] phylink: API changes

Hi Florian Please keep CC Yelena Krivosheev for changes withdrivers/net/ethernet/marvell/mvneta.c Thanks Yan Markman Tel. 05-44732819 -Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Thursday, March 29, 2018 1:44 AM To:

RE: [EXT] [PATCH net-next v2 1/2] net: phy: phylink: Provide PHY interface to mac_link_{up,down}

Hi Florian Please keep CC Yelena Krivosheev for changes withdrivers/net/ethernet/marvell/mvneta.c Thanks Yan Markman Tel. 05-44732819 -Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Thursday, March 29, 2018 1:44 AM To:

RE: [EXT] [PATCH net-next v2 1/2] net: phy: phylink: Provide PHY interface to mac_link_{up,down}

Hi Florian Please keep CC Yelena Krivosheev for changes withdrivers/net/ethernet/marvell/mvneta.c Thanks Yan Markman Tel. 05-44732819 -Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Thursday, March 29, 2018 1:44 AM To:

[PATCH 3/9] staging: ks7010: Reorder ks_wlan_netdev_ops members.

Reorder the members of 'ks_wlan_netdev_ops' to reflect the order of their counterparts in the kernel's 'struct net_device_ops'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

[PATCH 3/9] staging: ks7010: Reorder ks_wlan_netdev_ops members.

Reorder the members of 'ks_wlan_netdev_ops' to reflect the order of their counterparts in the kernel's 'struct net_device_ops'. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH 4/9] staging: ks7010: Rename ks_wlan_set_multicast_list()

All of the net_device_ops callbacks are named after their counterparts in the kernel's 'struct net_device_ops', except ks_wlan_set_multicast_list(). Rename it to ks_wlan_set_rx_mode() for greater consistency. Signed-off-by: Quytelda Kahja ---

[PATCH 2/9] staging: ks7010: Remove unecessary cast.

The driver casts '_wlan_handler_def' to 'struct iw_handler_def *', but it is already of that type. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v3 1/2] of_net: Implement of_get_nvmem_mac_address helper

On 28-03-18 00:50, Florian Fainelli wrote: On 03/27/2018 02:52 AM, Mike Looijmans wrote: It's common practice to store MAC addresses for network interfaces into nvmem devices. However the code to actually do this in the kernel lacks, so this patch adds of_get_nvmem_mac_address() for drivers to

[PATCH 1/9] staging: ks7010: Replace manual array copy with ether_addr_copy().

Copying the dummy HW address into the struct net_device doesn't need to be done byte by byte; use ether_addr_copy() instead. Additionally, dev->dev_addr is not eight bytes long. ether_setup() sets the dev->addr_len to ETH_ALEN (defined as 6) in the net core code. Signed-off-by: Quytelda Kahja

[PATCH 4/9] staging: ks7010: Rename ks_wlan_set_multicast_list()

All of the net_device_ops callbacks are named after their counterparts in the kernel's 'struct net_device_ops', except ks_wlan_set_multicast_list(). Rename it to ks_wlan_set_rx_mode() for greater consistency. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 6 +++--- 1

[PATCH 2/9] staging: ks7010: Remove unecessary cast.

The driver casts '_wlan_handler_def' to 'struct iw_handler_def *', but it is already of that type. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c

Re: [PATCH v3 1/2] of_net: Implement of_get_nvmem_mac_address helper

On 28-03-18 00:50, Florian Fainelli wrote: On 03/27/2018 02:52 AM, Mike Looijmans wrote: It's common practice to store MAC addresses for network interfaces into nvmem devices. However the code to actually do this in the kernel lacks, so this patch adds of_get_nvmem_mac_address() for drivers to

[PATCH 1/9] staging: ks7010: Replace manual array copy with ether_addr_copy().

Copying the dummy HW address into the struct net_device doesn't need to be done byte by byte; use ether_addr_copy() instead. Additionally, dev->dev_addr is not eight bytes long. ether_setup() sets the dev->addr_len to ETH_ALEN (defined as 6) in the net core code. Signed-off-by: Quytelda Kahja

[PATCH 7/9] staging: ks7010: Remove trailing "_t" from all structure names.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Remove the "_t" suffix from every structure defined in this driver. Signed-off-by: Quytelda Kahja ---

[PATCH 7/9] staging: ks7010: Remove trailing "_t" from all structure names.

The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Remove the "_t" suffix from every structure defined in this driver. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks7010_sdio.c | 2 +-

[PATCH 9/9] staging: ks7010: Remove extra blank line between functions.

Remove an extra blank line indicated by checkpatch. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks7010_sdio.c | 3 ++- drivers/staging/ks7010/ks_hostif.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 8/9] staging: ks7010: Remove 'eth_addr' field from 'struct ks_wlan_private'.

The ethernet address of the network device is already stored in the 'dev_addr' field of 'struct net_device'. Since 'struct ks_wlan_private' keeps a pointer to the driver's 'struct net_device', there is no reason to duplicate this information in 'struct ks_wlan_private'. Signed-off-by: Quytelda

[PATCH 6/9] staging: ks7010: Remove unused member 'reg_net' from 'ks_wlan_private'.

'reg_net' is never used in this driver. Signed-off-by: Quytelda Kahja x --- drivers/staging/ks7010/ks_wlan.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 846bb1041850..1b7036c32d1c 100644 ---

[PATCH 8/9] staging: ks7010: Remove 'eth_addr' field from 'struct ks_wlan_private'.

The ethernet address of the network device is already stored in the 'dev_addr' field of 'struct net_device'. Since 'struct ks_wlan_private' keeps a pointer to the driver's 'struct net_device', there is no reason to duplicate this information in 'struct ks_wlan_private'. Signed-off-by: Quytelda

[PATCH 6/9] staging: ks7010: Remove unused member 'reg_net' from 'ks_wlan_private'.

'reg_net' is never used in this driver. Signed-off-by: Quytelda Kahja x --- drivers/staging/ks7010/ks_wlan.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 846bb1041850..1b7036c32d1c 100644 ---

[PATCH 9/9] staging: ks7010: Remove extra blank line between functions.

Remove an extra blank line indicated by checkpatch. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks7010_sdio.c | 3 ++- drivers/staging/ks7010/ks_hostif.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c

[PATCH 5/9] staging: ks7010: Change mac_address_valid to a bool instead of int.

'mac_address_valid' is only ever assigned 0 or 1, so it makes more sense to use a bool type for this variable. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- drivers/staging/ks7010/ks_wlan.h | 2 +- drivers/staging/ks7010/ks_wlan_net.c

[PATCH 5/9] staging: ks7010: Change mac_address_valid to a bool instead of int.

'mac_address_valid' is only ever assigned 0 or 1, so it makes more sense to use a bool type for this variable. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- drivers/staging/ks7010/ks_wlan.h | 2 +- drivers/staging/ks7010/ks_wlan_net.c | 4 ++-- 3 files

Re: [PATCH 2/2] rhashtable: improve rhashtable_walk stability when stop/start used.

On Thu, Mar 29, 2018 at 12:19:10PM +1100, NeilBrown wrote: > When a walk of an rhashtable is interrupted with rhastable_walk_stop() > and then rhashtable_walk_start(), the location to restart from is based > on a 'skip' count in the current hash chain, and this can be incorrect > if insertions or

Re: [PATCH 2/2] rhashtable: improve rhashtable_walk stability when stop/start used.

On Thu, Mar 29, 2018 at 12:19:10PM +1100, NeilBrown wrote: > When a walk of an rhashtable is interrupted with rhastable_walk_stop() > and then rhashtable_walk_start(), the location to restart from is based > on a 'skip' count in the current hash chain, and this can be incorrect > if insertions or

[RFC PATCH] sdhci: arasan: Add runtime PM support

From: Manish Narani This patch adds runtime PM support in Arasan SD driver. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 83 +- 1 file changed, 81 insertions(+), 2 deletions(-) diff --git

[RFC PATCH] sdhci: arasan: Add runtime PM support

From: Manish Narani This patch adds runtime PM support in Arasan SD driver. Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 83 +- 1 file changed, 81 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c

Re: [PATCH 1/2] rhashtable: fix insertion of in rhltable when duplicate found.

On Thu, Mar 29, 2018 at 12:19:09PM +1100, NeilBrown wrote: > When rhltable_insert() finds an entry with the same key, > it splices the new entry at the start of a list of entries with the > same key. > It stores the address of the new object in *pprev, but in general this > is *not* the location

Re: [PATCH 1/2] rhashtable: fix insertion of in rhltable when duplicate found.

On Thu, Mar 29, 2018 at 12:19:09PM +1100, NeilBrown wrote: > When rhltable_insert() finds an entry with the same key, > it splices the new entry at the start of a list of entries with the > same key. > It stores the address of the new object in *pprev, but in general this > is *not* the location

[PATCH v2] media: i2c: wm9090: replace codec to component

From: Kuninori Morimoto Now we can replace Codec to Component. Let's do it. Note: xxx_codec_xxx() -> xxx_component_xxx() .idle_bias_off = 0 -> .idle_bias_on = 1 .ignore_pmdown_time = 0 -> .use_pmdown_time = 1

[PATCH v2] media: i2c: wm9090: replace codec to component

From: Kuninori Morimoto Now we can replace Codec to Component. Let's do it. Note: xxx_codec_xxx() -> xxx_component_xxx() .idle_bias_off = 0 -> .idle_bias_on = 1 .ignore_pmdown_time = 0 -> .use_pmdown_time = 1 -

Re: [PATCH v2] pcm_native: Remove VLA usage

On Thu, 29 Mar 2018 00:24:00 +0200, Kyle Spiers wrote: > > As part of the effort to remove VLAs from the kernel[1], this changes > the allocation of the rstamps array from being on the stack to being > kcalloc()ed. This also allows for the removal of the explicit zeroing > loop. > >

Re: [PATCH v2] pcm_native: Remove VLA usage

On Thu, 29 Mar 2018 00:24:00 +0200, Kyle Spiers wrote: > > As part of the effort to remove VLAs from the kernel[1], this changes > the allocation of the rstamps array from being on the stack to being > kcalloc()ed. This also allows for the removal of the explicit zeroing > loop. > >

Re: [PATCH] media: i2c: wm9090: replace codec to component

Hi Thank you for this report. I will post v2 patch, soon kbuild test robot wrote: > > [1 ] > Hi Kuninori, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linuxtv-media/master] > [also build test ERROR on next-20180328] >

Re: [PATCH] media: i2c: wm9090: replace codec to component

Hi Thank you for this report. I will post v2 patch, soon kbuild test robot wrote: > > [1 ] > Hi Kuninori, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linuxtv-media/master] > [also build test ERROR on next-20180328] >

Re: [PATCHv2 08/14] mm/page_ext: Drop definition of unused PAGE_EXT_DEBUG_POISON

On 3/28/2018 10:25 PM, Kirill A. Shutemov wrote: > After bd33ef368135 ("mm: enable page poisoning early at boot") > PAGE_EXT_DEBUG_POISON is not longer used. Remove it. > > Signed-off-by: Kirill A. Shutemov > Cc: Vinayak Menon > --- >

Re: [PATCHv2 08/14] mm/page_ext: Drop definition of unused PAGE_EXT_DEBUG_POISON

On 3/28/2018 10:25 PM, Kirill A. Shutemov wrote: > After bd33ef368135 ("mm: enable page poisoning early at boot") > PAGE_EXT_DEBUG_POISON is not longer used. Remove it. > > Signed-off-by: Kirill A. Shutemov > Cc: Vinayak Menon > --- > include/linux/page_ext.h | 11 --- > 1 file changed,

Re: [PATCH] serial: 8250: omap: Provide ability to enable/disable UART as wakeup source

On Thursday 29 March 2018 04:00 AM, Tony Lindgren wrote: > * Vignesh R [180327 12:03]: >> Enable/Clear module level UART wakeup in UART_OMAP_WER register based on >> return value of device_may_wakeup() in .suspend(). This allows >> userspace to use sysfs to control the ability

Re: [PATCH] serial: 8250: omap: Provide ability to enable/disable UART as wakeup source

On Thursday 29 March 2018 04:00 AM, Tony Lindgren wrote: > * Vignesh R [180327 12:03]: >> Enable/Clear module level UART wakeup in UART_OMAP_WER register based on >> return value of device_may_wakeup() in .suspend(). This allows >> userspace to use sysfs to control the ability of UART to wakeup

[PATCH v4 1/2] of_net: Implement of_get_nvmem_mac_address helper

It's common practice to store MAC addresses for network interfaces into nvmem devices. However the code to actually do this in the kernel lacks, so this patch adds of_get_nvmem_mac_address() for drivers to obtain the address from an nvmem cell provider. This is particulary useful on devices where

[PATCH v4 1/2] of_net: Implement of_get_nvmem_mac_address helper

It's common practice to store MAC addresses for network interfaces into nvmem devices. However the code to actually do this in the kernel lacks, so this patch adds of_get_nvmem_mac_address() for drivers to obtain the address from an nvmem cell provider. This is particulary useful on devices where

[PATCH v4 2/2] net: macb: Try to retrieve MAC addess from nvmem provider

Call of_get_nvmem_mac_address() to fetch the MAC address from an nvmem cell, if one is provided in the device tree. This allows the address to be stored in an I2C EEPROM device for example. Signed-off-by: Mike Looijmans Acked-by: Nicolas Ferre

[PATCH v4 2/2] net: macb: Try to retrieve MAC addess from nvmem provider

Call of_get_nvmem_mac_address() to fetch the MAC address from an nvmem cell, if one is provided in the device tree. This allows the address to be stored in an I2C EEPROM device for example. Signed-off-by: Mike Looijmans Acked-by: Nicolas Ferre --- drivers/net/ethernet/cadence/macb_main.c | 12

[PATCH v4 0/2] of_net: Implement of_get_nvmem_mac_address helper

Posted this as a small set now, with an (optional) second patch that shows how the changes work and what I've used to test the code on a Topic Miami board. I've taken the liberty to add appropriate "Acked" and "Review" tags. v4: Replaced "6" with ETH_ALEN v3: Add patch that implements mac in

[PATCH v4 0/2] of_net: Implement of_get_nvmem_mac_address helper

Posted this as a small set now, with an (optional) second patch that shows how the changes work and what I've used to test the code on a Topic Miami board. I've taken the liberty to add appropriate "Acked" and "Review" tags. v4: Replaced "6" with ETH_ALEN v3: Add patch that implements mac in

Re: [PATCH 5/6] rhashtable: support guaranteed successful insertion.

On Thu, Mar 29, 2018 at 08:26:21AM +1100, NeilBrown wrote: > > I say "astronomically unlikely", you say "probability .. is extremely > low". I think we are in agreement here. > > The point remains that if an error *can* be returned then I have to > write code to handle it and test that code.

Re: [PATCH 5/6] rhashtable: support guaranteed successful insertion.

On Thu, Mar 29, 2018 at 08:26:21AM +1100, NeilBrown wrote: > > I say "astronomically unlikely", you say "probability .. is extremely > low". I think we are in agreement here. > > The point remains that if an error *can* be returned then I have to > write code to handle it and test that code.

Re: linux-next: manual merge of the kvm-arm tree with the arm64 tree

Hi all, On Wed, 28 Mar 2018 16:05:41 +1100 Stephen Rothwell wrote: > > Today's linux-next merge of the kvm-arm tree got a conflict in: > > arch/arm64/kernel/cpufeature.c > > between commits: > > 143ba05d867a ("arm64: capabilities: Prepare for fine grained

Re: linux-next: manual merge of the kvm-arm tree with the arm64 tree

Hi all, On Wed, 28 Mar 2018 16:05:41 +1100 Stephen Rothwell wrote: > > Today's linux-next merge of the kvm-arm tree got a conflict in: > > arch/arm64/kernel/cpufeature.c > > between commits: > > 143ba05d867a ("arm64: capabilities: Prepare for fine grained capabilities") > 12eb369125ab

Re: General protection fault with use_blk_mq=1.

> Il giorno 29 mar 2018, alle ore 05:22, Jens Axboe ha > scritto: > > On 3/28/18 9:13 PM, Zephaniah E. Loss-Cutler-Hull wrote: >> On 03/28/2018 06:02 PM, Jens Axboe wrote: >>> On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote: I am not subscribed to any of the

Re: General protection fault with use_blk_mq=1.

> Il giorno 29 mar 2018, alle ore 05:22, Jens Axboe ha > scritto: > > On 3/28/18 9:13 PM, Zephaniah E. Loss-Cutler-Hull wrote: >> On 03/28/2018 06:02 PM, Jens Axboe wrote: >>> On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote: I am not subscribed to any of the lists on the To list

linux-next: manual merge of the kvm tree with the kvm-fixes tree

Hi all, Today's linux-next merge of the kvm tree got a conflict in: arch/x86/kvm/vmx.c between commit: 9d1887ef3252 ("KVM: nVMX: sync vmcs02 segment regs prior to vmx_set_cr0") from the kvm-fixes tree and commit: 2bb8cafea80b ("KVM: vVMX: signal failure for nested VMEntry if

linux-next: manual merge of the kvm tree with the kvm-fixes tree

Hi all, Today's linux-next merge of the kvm tree got a conflict in: arch/x86/kvm/vmx.c between commit: 9d1887ef3252 ("KVM: nVMX: sync vmcs02 segment regs prior to vmx_set_cr0") from the kvm-fixes tree and commit: 2bb8cafea80b ("KVM: vVMX: signal failure for nested VMEntry if

Re: kernel BUG at lib/string.c:LINE! (3)

syzbot has found reproducer for the following crash on upstream commit a2601d78b77aacc5dd790f488188f9556f4a9eb2 (Wed Mar 28 23:54:03 2018 +) Merge tag 'powerpc-4.16-6' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux syzbot dashboard link:

Re: kernel BUG at lib/string.c:LINE! (3)

syzbot has found reproducer for the following crash on upstream commit a2601d78b77aacc5dd790f488188f9556f4a9eb2 (Wed Mar 28 23:54:03 2018 +) Merge tag 'powerpc-4.16-6' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux syzbot dashboard link:

linux-next: manual merge of the kvm tree with the kvm-fixes tree

Hi all, Today's linux-next merge of the kvm tree got conflicts in: arch/x86/kernel/kvm.c between commit: 17a1079d9c63 ("KVM: x86: Fix pv tlb flush dependencies") from the kvm-fixes tree and commit: 6beacf74c257 ("KVM: X86: Don't use PV TLB flush with dedicated physical CPUs") from the

linux-next: manual merge of the kvm tree with the kvm-fixes tree

Hi all, Today's linux-next merge of the kvm tree got conflicts in: arch/x86/kernel/kvm.c between commit: 17a1079d9c63 ("KVM: x86: Fix pv tlb flush dependencies") from the kvm-fixes tree and commit: 6beacf74c257 ("KVM: X86: Don't use PV TLB flush with dedicated physical CPUs") from the

Re: [PATCH v4 2/8] openrisc: Set CONFIG_MULTI_IRQ_HANDLER

On Tue, Mar 27, 2018 at 09:19:05AM -0700, Palmer Dabbelt wrote: > arm has an optional MULTI_IRQ_HANDLER, which openrisc copied but didn't > make optional. I'm converting this to generic code, but in order to > ensure everything stays bisectable I want this defined on openrisc for > now. This

Re: [PATCH v4 2/8] openrisc: Set CONFIG_MULTI_IRQ_HANDLER

On Tue, Mar 27, 2018 at 09:19:05AM -0700, Palmer Dabbelt wrote: > arm has an optional MULTI_IRQ_HANDLER, which openrisc copied but didn't > make optional. I'm converting this to generic code, but in order to > ensure everything stays bisectable I want this defined on openrisc for > now. This

Re: General protection fault with use_blk_mq=1.

> Il giorno 29 mar 2018, alle ore 03:02, Jens Axboe ha > scritto: > > On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote: >> I am not subscribed to any of the lists on the To list here, please CC >> me on any replies. >> >> I am encountering a fairly consistent crash

Re: General protection fault with use_blk_mq=1.

> Il giorno 29 mar 2018, alle ore 03:02, Jens Axboe ha > scritto: > > On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote: >> I am not subscribed to any of the lists on the To list here, please CC >> me on any replies. >> >> I am encountering a fairly consistent crash anywhere from 15

Re: [PATCH RFC tools/memory-model] Add s390.{cfg,cat}

On Wed, Mar 28, 2018 at 02:04:07PM -0400, Alan Stern wrote: > On Wed, 28 Mar 2018, Paul E. McKenney wrote: > > > On Wed, Mar 28, 2018 at 11:01:25AM -0400, Alan Stern wrote: > > > On Wed, 28 Mar 2018, Paul E. McKenney wrote: > > > > > > > Hello! > > > > > > > > The prototype patch shown below

Re: [PATCH RFC tools/memory-model] Add s390.{cfg,cat}

On Wed, Mar 28, 2018 at 07:51:36PM +0200, Peter Zijlstra wrote: > On Wed, Mar 28, 2018 at 11:01:25AM -0400, Alan Stern wrote: > > I don't quite see the point of this. You're not suggesting that we > > have one Linux Kernel Memory Consistency Model for s390 and another > > one for all the other

Re: [PATCH RFC tools/memory-model] Add s390.{cfg,cat}

On Wed, Mar 28, 2018 at 02:04:07PM -0400, Alan Stern wrote: > On Wed, 28 Mar 2018, Paul E. McKenney wrote: > > > On Wed, Mar 28, 2018 at 11:01:25AM -0400, Alan Stern wrote: > > > On Wed, 28 Mar 2018, Paul E. McKenney wrote: > > > > > > > Hello! > > > > > > > > The prototype patch shown below

Re: [PATCH RFC tools/memory-model] Add s390.{cfg,cat}

On Wed, Mar 28, 2018 at 07:51:36PM +0200, Peter Zijlstra wrote: > On Wed, Mar 28, 2018 at 11:01:25AM -0400, Alan Stern wrote: > > I don't quite see the point of this. You're not suggesting that we > > have one Linux Kernel Memory Consistency Model for s390 and another > > one for all the other

Re: [PATCH][next] wil6210: fix potential null dereference of ndev before null check

me...@codeaurora.org writes: > On 2018-03-28 20:40, Colin King wrote: >> From: Colin Ian King >> >> The pointer ndev is being dereferenced before it is being null checked, >> hence there is a potential null pointer deference. Fix this by only >> dereferencing ndev after

Re: [PATCH][next] wil6210: fix potential null dereference of ndev before null check

me...@codeaurora.org writes: > On 2018-03-28 20:40, Colin King wrote: >> From: Colin Ian King >> >> The pointer ndev is being dereferenced before it is being null checked, >> hence there is a potential null pointer deference. Fix this by only >> dereferencing ndev after it has been null checked

Re: [PATCH 2/2] usb: dwc3: add clock and resets

2018-03-19 7:37 GMT+09:00 Masahiro Yamada : > Hi Rob, > > 2018-03-18 21:52 GMT+09:00 Rob Herring : >> On Thu, Mar 15, 2018 at 08:39:58PM +0900, Masahiro Yamada wrote: >>> dwc3-of-simple.c only handles arbitrary number of clocks and resets. >>> They

Re: [PATCH 2/2] usb: dwc3: add clock and resets

2018-03-19 7:37 GMT+09:00 Masahiro Yamada : > Hi Rob, > > 2018-03-18 21:52 GMT+09:00 Rob Herring : >> On Thu, Mar 15, 2018 at 08:39:58PM +0900, Masahiro Yamada wrote: >>> dwc3-of-simple.c only handles arbitrary number of clocks and resets. >>> They are both generic enough to be put into the dwc3

[PATCH 0/3] mfd: axp20x: driver cleanup

Hi Lee, Here are some cleanup patches for the axp20x mfd driver. Patch 1 const-ifies all the struct mfd_cell and struct resource instances found throughout the driver. Not sure why they weren't set to const before. Patch 2 replaces all the openly declared interrupt resources with nice to read

[PATCH 0/3] mfd: axp20x: driver cleanup

Hi Lee, Here are some cleanup patches for the axp20x mfd driver. Patch 1 const-ifies all the struct mfd_cell and struct resource instances found throughout the driver. Not sure why they weren't set to const before. Patch 2 replaces all the openly declared interrupt resources with nice to read

[PATCH 1/3] mfd: axp20x: Const-ify struct mfd_cell and struct resource

The axp20x driver has lots of mfd_cell and resource structs. These can all be const-ified. Signed-off-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 44 ++-- include/linux/mfd/axp20x.h | 2 +- 2 files changed, 23 insertions(+), 23

[PATCH 2/3] mfd: axp20x: Use DEFINE_RES_IRQ to declare resources for mfd_cells

Previously we were open coding the interrupts for the various mfd cells. This made the code somewhat long due to pretty-formatting. This patch convert those into one-line declarations with DEFINE_RES_IRQ, making the code shorter and easier to read. Signed-off-by: Chen-Yu Tsai ---

[PATCH 1/3] mfd: axp20x: Const-ify struct mfd_cell and struct resource

The axp20x driver has lots of mfd_cell and resource structs. These can all be const-ified. Signed-off-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 44 ++-- include/linux/mfd/axp20x.h | 2 +- 2 files changed, 23 insertions(+), 23 deletions(-) diff

[PATCH 2/3] mfd: axp20x: Use DEFINE_RES_IRQ to declare resources for mfd_cells

Previously we were open coding the interrupts for the various mfd cells. This made the code somewhat long due to pretty-formatting. This patch convert those into one-line declarations with DEFINE_RES_IRQ, making the code shorter and easier to read. Signed-off-by: Chen-Yu Tsai ---

[PATCH 3/3] mfd: axp20x: Correct AXP806 POK interrupt prefix

When AXP806 support was added, POK was incorrectly expanded to PWROK. However, the datasheet lists them as POK[LSNP], which is the same as on the AXP288. Furthermore, the registers associated with POK functions are the same as the PEK on the other AXP PMICs. This suggests that "POK" means "Power

[PATCH 3/3] mfd: axp20x: Correct AXP806 POK interrupt prefix

When AXP806 support was added, POK was incorrectly expanded to PWROK. However, the datasheet lists them as POK[LSNP], which is the same as on the AXP288. Furthermore, the registers associated with POK functions are the same as the PEK on the other AXP PMICs. This suggests that "POK" means "Power

[PATCH 17/17] staging: lustre: remove cruft from libcfs/linux/libcfs.h

These defines are unused or nearly unused, and do not help at all. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/curproc.h |2 -- .../lustre/include/linux/libcfs/linux/libcfs.h | 17 -

[PATCH 14/17] staging: lustre: discard cfs_duration_sec()

cfs_duration_sec() simply divides by HZ. It is mostly used to report durations in debug messages. Remove and just use X/HZ. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/linux/linux-time.h |5 - .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c|2 +-

[PATCH 17/17] staging: lustre: remove cruft from libcfs/linux/libcfs.h

These defines are unused or nearly unused, and do not help at all. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/curproc.h |2 -- .../lustre/include/linux/libcfs/linux/libcfs.h | 17 - drivers/staging/lustre/lnet/libcfs/tracefile.c |2 +-

[PATCH 14/17] staging: lustre: discard cfs_duration_sec()

cfs_duration_sec() simply divides by HZ. It is mostly used to report durations in debug messages. Remove and just use X/HZ. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/linux/linux-time.h |5 - .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c|2 +-

[PATCH 13/17] staging: lustre: libcfs: remove cfs_timeout_cap()

This wrapper is only used once, so open-code it as max(). This allows us to remove the libcfs_time.h include file. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |1 .../lustre/include/linux/libcfs/libcfs_time.h | 50

[PATCH 16/17] staging: lustre: discard linux-time.h

Very little is left in linux-time.h. Move CFS_TICK to libcfs.h discard the test. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |5 ++ .../lustre/include/linux/libcfs/linux/libcfs.h |1

[PATCH 15/17] staging: lustre: discard cfs_time_before_64()

cfs_time_before_64 is the same as time_before64() similarly cfs_time_beforeq_64() matsches time_before_eq64() So just use the standard interfaces. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/linux/linux-time.h | 14 --

[PATCH 16/17] staging: lustre: discard linux-time.h

Very little is left in linux-time.h. Move CFS_TICK to libcfs.h discard the test. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |5 ++ .../lustre/include/linux/libcfs/linux/libcfs.h |1 .../lustre/include/linux/libcfs/linux/linux-time.h | 66

[PATCH 15/17] staging: lustre: discard cfs_time_before_64()

cfs_time_before_64 is the same as time_before64() similarly cfs_time_beforeq_64() matsches time_before_eq64() So just use the standard interfaces. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/linux/linux-time.h | 14 --

[PATCH 13/17] staging: lustre: libcfs: remove cfs_timeout_cap()

This wrapper is only used once, so open-code it as max(). This allows us to remove the libcfs_time.h include file. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |1 .../lustre/include/linux/libcfs/libcfs_time.h | 50

[PATCH 07/17] staging: lustre: ldlm: free resource when ldlm_lock_create() fails.

ldlm_lock_create() gets a resource, but don't put it on all failure paths. It should. Signed-off-by: NeilBrown --- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH 08/17] staging: lustre: add container_of_safe()

Luster has a container_of0() function which is similar to container_of() but passes an IS_ERR_OR_NULL() pointer through unchanged. This could be generally useful: bcache at last has a similar function. Naming is hard, but the precedent set by hlist_entry_safe() suggests a _safe suffix might be

[PATCH 06/17] staging: lustre: tidy up ldlm_resource_putref()

1/ the return value of ldlm_resource_putref() is never used, so change it to return 'void'. 2/ Move all of the code to run on the last putref to __ldlm_resource_putref_final(). This means a lock is taken in one function and dropped in another, but that isn't too uncommon, and will

[PATCH 07/17] staging: lustre: ldlm: free resource when ldlm_lock_create() fails.

ldlm_lock_create() gets a resource, but don't put it on all failure paths. It should. Signed-off-by: NeilBrown --- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c

[PATCH 08/17] staging: lustre: add container_of_safe()

Luster has a container_of0() function which is similar to container_of() but passes an IS_ERR_OR_NULL() pointer through unchanged. This could be generally useful: bcache at last has a similar function. Naming is hard, but the precedent set by hlist_entry_safe() suggests a _safe suffix might be

[PATCH 06/17] staging: lustre: tidy up ldlm_resource_putref()

1/ the return value of ldlm_resource_putref() is never used, so change it to return 'void'. 2/ Move all of the code to run on the last putref to __ldlm_resource_putref_final(). This means a lock is taken in one function and dropped in another, but that isn't too uncommon, and will

[PATCH 11/17] staging: lustre: libcfs: discard cfs_time_shift().

This function simply multiplies by HZ and adds jiffies. This is simple enough to be opencoded, and doing so makes the code easier to read. Same for cfs_time_shift_64() Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_time.h |5

[PATCH 12/17] staging: lustre: libcfs: discard cfs_time_after()

cfs_time_after() behaves exactly like time_after() similarly cfs_time_aftereq() matches time_after_eq() so discard the cfs versions. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_time.h | 14 - .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c

[PATCH 11/17] staging: lustre: libcfs: discard cfs_time_shift().

This function simply multiplies by HZ and adds jiffies. This is simple enough to be opencoded, and doing so makes the code easier to read. Same for cfs_time_shift_64() Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_time.h |5

[PATCH 12/17] staging: lustre: libcfs: discard cfs_time_after()

cfs_time_after() behaves exactly like time_after() similarly cfs_time_aftereq() matches time_after_eq() so discard the cfs versions. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_time.h | 14 - .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c|4 +--

[PATCH 09/17] staging: lustre: cfs_time_current() -> jiffies.

Discard cfs_time_current() and cfs_time_current64() and use jiffies and get_jiffies_64() like the rest of the kernel. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_time.h |2 - .../lustre/include/linux/libcfs/linux/linux-time.h |9

[PATCH 10/17] staging: lustre: libcfs: discard cfs_time_add/sub

cfs_time_add adds its arguments. cfs_time_sub subtracts finds the difference. Discard these and use '+' and '-' directly. This change highlighted a type error. The structure field cr_queued_time was used to store jiffies, but was declared as time_t (meant for seconds). So the time is changed to

  1   2   3   4   5   6   7   8   9   10   >