[PATCH 4.9 16/28] net/iucv: Free memory obtained by kzalloc

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Arvind Yadav [ Upstream commit fa6a91e9b907231d2e38ea5ed89c537b3525df3d ] Free memory by calling put_device(), if afiucv_iucv_init is not successful.

[PATCH 4.9 16/28] net/iucv: Free memory obtained by kzalloc

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Arvind Yadav [ Upstream commit fa6a91e9b907231d2e38ea5ed89c537b3525df3d ] Free memory by calling put_device(), if afiucv_iucv_init is not successful. Signed-off-by: Arvind Yadav

Re: [PATCH v5 0/9] ipc: Clamp *mni to the real IPCMNI limit & increase that limit

2018-03-29 Thread Luis R. Rodriguez
Andrew, please drop these patches until further notice. I would recommend we avoid merging these patches until we get proper Acked-by for the entire set. Waiman has a bit more work to do and even after the 5th iteration this is not right yet. Luis

Re: [PATCH v5 0/9] ipc: Clamp *mni to the real IPCMNI limit & increase that limit

2018-03-29 Thread Luis R. Rodriguez
Andrew, please drop these patches until further notice. I would recommend we avoid merging these patches until we get proper Acked-by for the entire set. Waiman has a bit more work to do and even after the 5th iteration this is not right yet. Luis

[PATCH 4.9 17/28] netlink: avoid a double skb free in genlmsg_mcast()

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Nicolas Dichtel [ Upstream commit 02a2385f37a7c6594c9d89b64c4a1451276f08eb ] nlmsg_multicast() consumes always the skb, thus the original skb must be freed only

[PATCH 4.9 17/28] netlink: avoid a double skb free in genlmsg_mcast()

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Nicolas Dichtel [ Upstream commit 02a2385f37a7c6594c9d89b64c4a1451276f08eb ] nlmsg_multicast() consumes always the skb, thus the original skb must be freed only when this function is called

[PATCH 4.9 18/28] net: Only honor ifindex in IP_PKTINFO if non-0

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: David Ahern [ Upstream commit 2cbb4ea7de167b02ffa63e9cdfdb07a7e7094615 ] Only allow ifindex from IP_PKTINFO to override SO_BINDTODEVICE settings if the index is actually

[PATCH 4.9 18/28] net: Only honor ifindex in IP_PKTINFO if non-0

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: David Ahern [ Upstream commit 2cbb4ea7de167b02ffa63e9cdfdb07a7e7094615 ] Only allow ifindex from IP_PKTINFO to override SO_BINDTODEVICE settings if the index is actually set in the message.

[PATCH 4.9 20/28] team: Fix double free in error path

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Arkadi Sharshevsky [ Upstream commit cbcc607e18422555db569b593608aec26111cb0b ] The __send_and_alloc_skb() receives a skb ptr as a parameter but in case it fails the skb

[PATCH 4.9 20/28] team: Fix double free in error path

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Arkadi Sharshevsky [ Upstream commit cbcc607e18422555db569b593608aec26111cb0b ] The __send_and_alloc_skb() receives a skb ptr as a parameter but in case it fails the skb is not valid: - Send

[PATCH 4.9 22/28] s390/qeth: free netdevice when removing a card

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 6be687395b3124f002a653c1a50b3260222b3cd7 ] On removal, a qeth card's netdevice is currently not properly freed because the call

[PATCH 4.9 22/28] s390/qeth: free netdevice when removing a card

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 6be687395b3124f002a653c1a50b3260222b3cd7 ] On removal, a qeth card's netdevice is currently not properly freed because the call chain looks as follows:

[PATCH 4.9 23/28] s390/qeth: when thread completes, wake up all waiters

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 1063e432bb45be209427ed3f1ca3908e4aa3c7d7 ] qeth_wait_for_threads() is potentially called by multiple users, make sure to notify all

[PATCH 4.9 23/28] s390/qeth: when thread completes, wake up all waiters

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 1063e432bb45be209427ed3f1ca3908e4aa3c7d7 ] qeth_wait_for_threads() is potentially called by multiple users, make sure to notify all of them after

[PATCH 4.9 27/28] kcm: lock lower socket in kcm_attach

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Tom Herbert [ Upstream commit 2cc683e88c0c993ac3721d9b702cb0630abe2879 ] Need to lock lower socket in order to provide mutual exclusion with kcm_unattach. v2: Add

Re: [PATCH] xfs: always free inline data before resetting inode fork during ifree

2018-03-29 Thread Josef Bacik
On Thu, Mar 29, 2018 at 06:12:23PM +, Luis R. Rodriguez wrote: > On Thu, Mar 29, 2018 at 10:05:35AM +1100, Dave Chinner wrote: > > On Wed, Mar 28, 2018 at 07:30:06PM +, Sasha Levin wrote: > > > > > > This is actually something I want maintainers to dictate. What sort of > > > testing

[PATCH 4.9 27/28] kcm: lock lower socket in kcm_attach

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Tom Herbert [ Upstream commit 2cc683e88c0c993ac3721d9b702cb0630abe2879 ] Need to lock lower socket in order to provide mutual exclusion with kcm_unattach. v2: Add Reported-by for syzbot

Re: [PATCH] xfs: always free inline data before resetting inode fork during ifree

2018-03-29 Thread Josef Bacik
On Thu, Mar 29, 2018 at 06:12:23PM +, Luis R. Rodriguez wrote: > On Thu, Mar 29, 2018 at 10:05:35AM +1100, Dave Chinner wrote: > > On Wed, Mar 28, 2018 at 07:30:06PM +, Sasha Levin wrote: > > > > > > This is actually something I want maintainers to dictate. What sort of > > > testing

[PATCH 4.9 26/28] net: systemport: Rewrite __bcm_sysport_tx_reclaim()

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Florian Fainelli [ Upstream commit 484d802d0f2f29c335563fcac2a8facf174a1bbc ] There is no need for complex checking between the last consumed index and current consumed

[PATCH 4.9 25/28] s390/qeth: on channel error, reject further cmd requests

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit a6c3d93963e4b333c764fde69802c3ea9eaa9d5c ] When the IRQ handler determines that one of the cmd IO channels has failed and schedules

[PATCH 4.9 26/28] net: systemport: Rewrite __bcm_sysport_tx_reclaim()

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Florian Fainelli [ Upstream commit 484d802d0f2f29c335563fcac2a8facf174a1bbc ] There is no need for complex checking between the last consumed index and current consumed index, a simple

[PATCH 4.9 25/28] s390/qeth: on channel error, reject further cmd requests

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit a6c3d93963e4b333c764fde69802c3ea9eaa9d5c ] When the IRQ handler determines that one of the cmd IO channels has failed and schedules recovery, block any

[PATCH 4.9 04/28] ppp: avoid loop in xmit recursion detection code

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Guillaume Nault [ Upstream commit 6d066734e9f09cdea4a3b9cb76136db3f29cfb02 ] We already detect situations where a PPP channel sends packets back to its upper PPP device.

[PATCH 4.9 04/28] ppp: avoid loop in xmit recursion detection code

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Guillaume Nault [ Upstream commit 6d066734e9f09cdea4a3b9cb76136db3f29cfb02 ] We already detect situations where a PPP channel sends packets back to its upper PPP device. While this is enough

Re: [PATCH v5 2/9] proc/sysctl: Provide additional ctl_table.flags checks

2018-03-29 Thread Luis R. Rodriguez
On Mon, Mar 19, 2018 at 11:35:19AM -0400, Waiman Long wrote: > On 03/16/2018 08:54 PM, Luis R. Rodriguez wrote: > > On Fri, Mar 16, 2018 at 02:13:43PM -0400, Waiman Long wrote: > >> Checking code is added to provide the following additional > >> ctl_table.flags checks: > >> > >> 1) No unknown

Re: [PATCH v5 2/9] proc/sysctl: Provide additional ctl_table.flags checks

2018-03-29 Thread Luis R. Rodriguez
On Mon, Mar 19, 2018 at 11:35:19AM -0400, Waiman Long wrote: > On 03/16/2018 08:54 PM, Luis R. Rodriguez wrote: > > On Fri, Mar 16, 2018 at 02:13:43PM -0400, Waiman Long wrote: > >> Checking code is added to provide the following additional > >> ctl_table.flags checks: > >> > >> 1) No unknown

[PATCH 4.9 28/28] net: hns: Fix a skb used after free bug

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Yunsheng Lin commit 27463ad99f738ed93c7c8b3e2e5bc8c4853a2ff2 upstream. skb maybe freed in hns_nic_net_xmit_hw() and return NETDEV_TX_OK, which cause hns_nic_net_xmit to

[PATCH 4.9 28/28] net: hns: Fix a skb used after free bug

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Yunsheng Lin commit 27463ad99f738ed93c7c8b3e2e5bc8c4853a2ff2 upstream. skb maybe freed in hns_nic_net_xmit_hw() and return NETDEV_TX_OK, which cause hns_nic_net_xmit to use a freed skb. BUG:

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-29 Thread Christian König
Am 29.03.2018 um 18:25 schrieb Logan Gunthorpe: On 29/03/18 10:10 AM, Christian König wrote: Why not? I mean the dma_map_resource() function is for P2P while other dma_map_* functions are only for system memory. Oh, hmm, I wasn't aware dma_map_resource was exclusively for mapping P2P. Though

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-29 Thread Christian König
Am 29.03.2018 um 18:25 schrieb Logan Gunthorpe: On 29/03/18 10:10 AM, Christian König wrote: Why not? I mean the dma_map_resource() function is for P2P while other dma_map_* functions are only for system memory. Oh, hmm, I wasn't aware dma_map_resource was exclusively for mapping P2P. Though

Re: [PATCH 4/4] nvmet-fc: Use new SGL alloc/free helper for requests

2018-03-29 Thread Christoph Hellwig
On Thu, Mar 29, 2018 at 11:02:10AM -0600, Logan Gunthorpe wrote: > Per the bug in the previous patch, I don't think that was ever a valid > assumption. It doesn't have anything to do with the sgl_alloc change > either. The dma_map interface is allowed to merge SGLs and that's why it > can return

Re: [PATCH 4/4] nvmet-fc: Use new SGL alloc/free helper for requests

2018-03-29 Thread Christoph Hellwig
On Thu, Mar 29, 2018 at 11:02:10AM -0600, Logan Gunthorpe wrote: > Per the bug in the previous patch, I don't think that was ever a valid > assumption. It doesn't have anything to do with the sgl_alloc change > either. The dma_map interface is allowed to merge SGLs and that's why it > can return

Re: [PATCH v5 1/9] sysctl: Add flags to support min/max range clamping

2018-03-29 Thread Luis R. Rodriguez
On Mon, Mar 19, 2018 at 11:39:19AM -0400, Waiman Long wrote: > On 03/16/2018 09:10 PM, Luis R. Rodriguez wrote: > > On Fri, Mar 16, 2018 at 02:13:42PM -0400, Waiman Long wrote: > >> When the CTL_FLAGS_CLAMP_RANGE flag is set in the ctl_table > >> entry, any update from the userspace will be

Re: [PATCH v5 1/9] sysctl: Add flags to support min/max range clamping

2018-03-29 Thread Luis R. Rodriguez
On Mon, Mar 19, 2018 at 11:39:19AM -0400, Waiman Long wrote: > On 03/16/2018 09:10 PM, Luis R. Rodriguez wrote: > > On Fri, Mar 16, 2018 at 02:13:42PM -0400, Waiman Long wrote: > >> When the CTL_FLAGS_CLAMP_RANGE flag is set in the ctl_table > >> entry, any update from the userspace will be

[PATCH 4.9 07/28] ieee802154: 6lowpan: fix possible NULL deref in lowpan_device_event()

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit ca0edb131bdf1e6beaeb2b8289fd6b374b74147d ] A tun device type can trivially be set to arbitrary value using TUNSETLINK ioctl(). Therefore,

[PATCH 4.9 07/28] ieee802154: 6lowpan: fix possible NULL deref in lowpan_device_event()

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit ca0edb131bdf1e6beaeb2b8289fd6b374b74147d ] A tun device type can trivially be set to arbitrary value using TUNSETLINK ioctl(). Therefore, lowpan_device_event()

[PATCH 4.9 00/28] 4.9.92-stable review

2018-03-29 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.92 release. There are 28 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat Mar 31 17:57:18 UTC 2018. Anything

[PATCH 4.9 00/28] 4.9.92-stable review

2018-03-29 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.92 release. There are 28 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat Mar 31 17:57:18 UTC 2018. Anything

[PATCH 4.9 09/28] net: Fix hlist corruptions in inet_evict_bucket()

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Kirill Tkhai [ Upstream commit a560002437d3646dafccecb1bf32d1685112ddda ] inet_evict_bucket() iterates global list, and several tasks may call it in parallel. All of

[PATCH 4.9 09/28] net: Fix hlist corruptions in inet_evict_bucket()

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Kirill Tkhai [ Upstream commit a560002437d3646dafccecb1bf32d1685112ddda ] inet_evict_bucket() iterates global list, and several tasks may call it in parallel. All of them hash the same

[PATCH 4.4 01/20] scsi: sg: dont return bogus Sg_requests

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Johannes Thumshirn commit 48ae8484e9fc324b4968d33c585e54bc98e44d61 upstream. If the list search in sg_get_rq_mark() fails to find a valid request, we return a bogus

[PATCH 4.4 01/20] scsi: sg: dont return bogus Sg_requests

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Johannes Thumshirn commit 48ae8484e9fc324b4968d33c585e54bc98e44d61 upstream. If the list search in sg_get_rq_mark() fails to find a valid request, we return a bogus element. This then can

[PATCH 4.9 08/28] net: use skb_to_full_sk() in skb_update_prio()

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit 4dcb31d4649df36297296b819437709f5407059c ] Andrei Vagin reported a KASAN: slab-out-of-bounds error in skb_update_prio() Since SYNACK might

[PATCH 4.9 08/28] net: use skb_to_full_sk() in skb_update_prio()

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit 4dcb31d4649df36297296b819437709f5407059c ] Andrei Vagin reported a KASAN: slab-out-of-bounds error in skb_update_prio() Since SYNACK might be attached to a

[PATCH 4.4 11/20] net: Only honor ifindex in IP_PKTINFO if non-0

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: David Ahern [ Upstream commit 2cbb4ea7de167b02ffa63e9cdfdb07a7e7094615 ] Only allow ifindex from IP_PKTINFO to override SO_BINDTODEVICE settings if the index is actually

[PATCH 4.4 11/20] net: Only honor ifindex in IP_PKTINFO if non-0

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: David Ahern [ Upstream commit 2cbb4ea7de167b02ffa63e9cdfdb07a7e7094615 ] Only allow ifindex from IP_PKTINFO to override SO_BINDTODEVICE settings if the index is actually set in the message.

[PATCH 4.4 12/20] skbuff: Fix not waking applications when errors are enqueued

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Vinicius Costa Gomes [ Upstream commit 6e5d58fdc9bedd0255a8781b258f10bbdc63e975 ] When errors are enqueued to the error queue via sock_queue_err_skb() function, it

[PATCH 4.4 12/20] skbuff: Fix not waking applications when errors are enqueued

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Vinicius Costa Gomes [ Upstream commit 6e5d58fdc9bedd0255a8781b258f10bbdc63e975 ] When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the

[PATCH 4.4 03/20] net: Fix hlist corruptions in inet_evict_bucket()

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Kirill Tkhai [ Upstream commit a560002437d3646dafccecb1bf32d1685112ddda ] inet_evict_bucket() iterates global list, and several tasks may call it in parallel. All of

[PATCH 4.4 03/20] net: Fix hlist corruptions in inet_evict_bucket()

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Kirill Tkhai [ Upstream commit a560002437d3646dafccecb1bf32d1685112ddda ] inet_evict_bucket() iterates global list, and several tasks may call it in parallel. All of them hash the same

Re: [RFC][PATCH] ipc: Remove IPCMNI

2018-03-29 Thread Manfred Spraul
Hello Mathew, On 03/29/2018 12:56 PM, Matthew Wilcox wrote: On Thu, Mar 29, 2018 at 10:47:45AM +0200, Manfred Spraul wrote: This can be implemented trivially with the current code using idr_alloc_cyclic. Is there a performance impact? Right now, the idr tree is only large if there are lots of

Re: [RFC][PATCH] ipc: Remove IPCMNI

2018-03-29 Thread Manfred Spraul
Hello Mathew, On 03/29/2018 12:56 PM, Matthew Wilcox wrote: On Thu, Mar 29, 2018 at 10:47:45AM +0200, Manfred Spraul wrote: This can be implemented trivially with the current code using idr_alloc_cyclic. Is there a performance impact? Right now, the idr tree is only large if there are lots of

Re: [PATCH] xfs: always free inline data before resetting inode fork during ifree

2018-03-29 Thread Luis R. Rodriguez
On Thu, Mar 29, 2018 at 10:05:35AM +1100, Dave Chinner wrote: > On Wed, Mar 28, 2018 at 07:30:06PM +, Sasha Levin wrote: > > > > This is actually something I want maintainers to dictate. What sort of > > testing would make the XFS folks happy here? Right now I'm doing > > "./check 'xfs/*'"

Re: [PATCH] xfs: always free inline data before resetting inode fork during ifree

2018-03-29 Thread Luis R. Rodriguez
On Thu, Mar 29, 2018 at 10:05:35AM +1100, Dave Chinner wrote: > On Wed, Mar 28, 2018 at 07:30:06PM +, Sasha Levin wrote: > > > > This is actually something I want maintainers to dictate. What sort of > > testing would make the XFS folks happy here? Right now I'm doing > > "./check 'xfs/*'"

[PATCH 4.4 05/20] ipv6: fix access to non-linear packet in ndisc_fill_redirect_hdr_option()

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Lorenzo Bianconi [ Upstream commit 9f62c15f28b0d1d746734666d88a79f08ba1e43e ] Fix the following slab-out-of-bounds kasan report in ndisc_fill_redirect_hdr_option

[PATCH 4.4 05/20] ipv6: fix access to non-linear packet in ndisc_fill_redirect_hdr_option()

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Lorenzo Bianconi [ Upstream commit 9f62c15f28b0d1d746734666d88a79f08ba1e43e ] Fix the following slab-out-of-bounds kasan report in ndisc_fill_redirect_hdr_option when the incoming ipv6 packet

[PATCH 4.4 07/20] net: ethernet: arc: Fix a potential memory leak if an optional regulator is deferred

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Christophe JAILLET [ Upstream commit 00777fac28ba3e126b9e63e789a613e8bd2cab25 ] If the optional regulator is deferred, we must release some resources. They will

[PATCH 4.4 07/20] net: ethernet: arc: Fix a potential memory leak if an optional regulator is deferred

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Christophe JAILLET [ Upstream commit 00777fac28ba3e126b9e63e789a613e8bd2cab25 ] If the optional regulator is deferred, we must release some resources. They will be re-allocated when the probe

Re: [RFC PATCH for 4.17 02/21] rseq: Introduce restartable sequences system call (v12)

2018-03-29 Thread Steven Rostedt
On Thu, 29 Mar 2018 14:02:33 -0400 (EDT) Mathieu Desnoyers wrote: > Currently, anyone using ptrace on a process has pretty much given up all > hopes of performance. Processes will use rseq to gain performance, not the > opposite, so this deterioration will be

Re: [RFC PATCH for 4.17 02/21] rseq: Introduce restartable sequences system call (v12)

2018-03-29 Thread Steven Rostedt
On Thu, 29 Mar 2018 14:02:33 -0400 (EDT) Mathieu Desnoyers wrote: > Currently, anyone using ptrace on a process has pretty much given up all > hopes of performance. Processes will use rseq to gain performance, not the > opposite, so this deterioration will be unwelcome. The ptrace path has

[PATCH 4.4 00/20] 4.4.126-stable review

2018-03-29 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.4.126 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat Mar 31 17:57:30 UTC 2018. Anything

[PATCH 4.4 00/20] 4.4.126-stable review

2018-03-29 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.4.126 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat Mar 31 17:57:30 UTC 2018. Anything

[PATCH 4.4 15/20] s390/qeth: when thread completes, wake up all waiters

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 1063e432bb45be209427ed3f1ca3908e4aa3c7d7 ] qeth_wait_for_threads() is potentially called by multiple users, make sure to notify all

[PATCH 4.4 15/20] s390/qeth: when thread completes, wake up all waiters

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 1063e432bb45be209427ed3f1ca3908e4aa3c7d7 ] qeth_wait_for_threads() is potentially called by multiple users, make sure to notify all of them after

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-29 Thread Nasser
On Thu, Mar 29, 2018 at 12:02:40PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 29 Mar 2018 19:04:35 +0430 > Nasser escreveu: > > > On Tue, Mar 27, 2018 at 02:59:21AM +0430, Nasser wrote: > > Hi Mauro, > > > > Thank you for taking time to review my patch. > > > > May

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-29 Thread Nasser
On Thu, Mar 29, 2018 at 12:02:40PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 29 Mar 2018 19:04:35 +0430 > Nasser escreveu: > > > On Tue, Mar 27, 2018 at 02:59:21AM +0430, Nasser wrote: > > Hi Mauro, > > > > Thank you for taking time to review my patch. > > > > May be I should rephrase the

[PATCH 4.4 09/20] net/iucv: Free memory obtained by kzalloc

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Arvind Yadav [ Upstream commit fa6a91e9b907231d2e38ea5ed89c537b3525df3d ] Free memory by calling put_device(), if afiucv_iucv_init is not successful.

[PATCH 4.4 09/20] net/iucv: Free memory obtained by kzalloc

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Arvind Yadav [ Upstream commit fa6a91e9b907231d2e38ea5ed89c537b3525df3d ] Free memory by calling put_device(), if afiucv_iucv_init is not successful. Signed-off-by: Arvind Yadav

[PATCH 4.4 14/20] s390/qeth: free netdevice when removing a card

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 6be687395b3124f002a653c1a50b3260222b3cd7 ] On removal, a qeth card's netdevice is currently not properly freed because the call

[PATCH 4.4 14/20] s390/qeth: free netdevice when removing a card

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 6be687395b3124f002a653c1a50b3260222b3cd7 ] On removal, a qeth card's netdevice is currently not properly freed because the call chain looks as follows:

[PATCH 4.4 17/20] s390/qeth: on channel error, reject further cmd requests

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit a6c3d93963e4b333c764fde69802c3ea9eaa9d5c ] When the IRQ handler determines that one of the cmd IO channels has failed and schedules

[PATCH 4.4 17/20] s390/qeth: on channel error, reject further cmd requests

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit a6c3d93963e4b333c764fde69802c3ea9eaa9d5c ] When the IRQ handler determines that one of the cmd IO channels has failed and schedules recovery, block any

[PATCH 4.4 16/20] s390/qeth: lock read device while queueing next buffer

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 17bf8c9b3d499d5168537c98b61eb7a1fcbca6c2 ] For calling ccw_device_start(), issue_next_read() needs to hold the device's ccwlock.

[PATCH 4.4 16/20] s390/qeth: lock read device while queueing next buffer

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 17bf8c9b3d499d5168537c98b61eb7a1fcbca6c2 ] For calling ccw_device_start(), issue_next_read() needs to hold the device's ccwlock. This is satisfied for the

Re: [PATCH v7 05/14] ext4, dax: introduce ext4_dax_aops

2018-03-29 Thread Christoph Hellwig
On Thu, Mar 29, 2018 at 05:40:35PM +0200, Jan Kara wrote: > So ext4_direct_IO() for IS_DAX() files will just bail out. So could you > just provide ext4_dax_direct_IO() which will bail out and use it here? With > a similar comment as in xfs_vm_direct_IO() that open still needs this > method set...

Re: [PATCH 10/10] softirq: Remove __ARCH_SET_SOFTIRQ_PENDING

2018-03-29 Thread Peter Zijlstra
On Thu, Mar 29, 2018 at 04:53:43PM +0200, Martin Schwidefsky wrote: > The lowcore optimization for softirq_pending field is not really needed, > just nice to have. But if there is a strong reason to make a common > definition for it we can certainly do that. A slightly related question; would it

Re: [PATCH v7 05/14] ext4, dax: introduce ext4_dax_aops

2018-03-29 Thread Christoph Hellwig
On Thu, Mar 29, 2018 at 05:40:35PM +0200, Jan Kara wrote: > So ext4_direct_IO() for IS_DAX() files will just bail out. So could you > just provide ext4_dax_direct_IO() which will bail out and use it here? With > a similar comment as in xfs_vm_direct_IO() that open still needs this > method set...

Re: [PATCH 10/10] softirq: Remove __ARCH_SET_SOFTIRQ_PENDING

2018-03-29 Thread Peter Zijlstra
On Thu, Mar 29, 2018 at 04:53:43PM +0200, Martin Schwidefsky wrote: > The lowcore optimization for softirq_pending field is not really needed, > just nice to have. But if there is a strong reason to make a common > definition for it we can certainly do that. A slightly related question; would it

[PATCH 4.4 19/20] net: fec: Fix unbalanced PM runtime calls

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Florian Fainelli [ Upstream commit a069215cf5985f3aa1bba550264907d6bd05c5f7 ] When unbinding/removing the driver, we will run into the following warnings: [

[PATCH 4.4 19/20] net: fec: Fix unbalanced PM runtime calls

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Florian Fainelli [ Upstream commit a069215cf5985f3aa1bba550264907d6bd05c5f7 ] When unbinding/removing the driver, we will run into the following warnings: [ 259.655198] fec

[PATCH 4.4 13/20] team: Fix double free in error path

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Arkadi Sharshevsky [ Upstream commit cbcc607e18422555db569b593608aec26111cb0b ] The __send_and_alloc_skb() receives a skb ptr as a parameter but in case it fails the skb

[PATCH 4.4 13/20] team: Fix double free in error path

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Arkadi Sharshevsky [ Upstream commit cbcc607e18422555db569b593608aec26111cb0b ] The __send_and_alloc_skb() receives a skb ptr as a parameter but in case it fails the skb is not valid: - Send

[PATCH 4.4 18/20] ieee802154: 6lowpan: fix possible NULL deref in lowpan_device_event()

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit ca0edb131bdf1e6beaeb2b8289fd6b374b74147d ] A tun device type can trivially be set to arbitrary value using TUNSETLINK ioctl(). Therefore,

[PATCH 4.4 18/20] ieee802154: 6lowpan: fix possible NULL deref in lowpan_device_event()

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit ca0edb131bdf1e6beaeb2b8289fd6b374b74147d ] A tun device type can trivially be set to arbitrary value using TUNSETLINK ioctl(). Therefore, lowpan_device_event()

[PATCH 4.4 20/20] net: systemport: Rewrite __bcm_sysport_tx_reclaim()

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Florian Fainelli [ Upstream commit 484d802d0f2f29c335563fcac2a8facf174a1bbc ] There is no need for complex checking between the last consumed index and current consumed

[PATCH 4.4 20/20] net: systemport: Rewrite __bcm_sysport_tx_reclaim()

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Florian Fainelli [ Upstream commit 484d802d0f2f29c335563fcac2a8facf174a1bbc ] There is no need for complex checking between the last consumed index and current consumed index, a simple

[PATCH 4.4 02/20] genirq: Track whether the trigger type has been set

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Marc Zyngier commit 4f8413a3a799c958f7a10a6310a451e6b8aef5ad upstream. When requesting a shared interrupt, we assume that the firmware support code (DT or ACPI) has

Re: [PATCH 07/30] aio: add delayed cancel support

2018-03-29 Thread Christoph Hellwig
On Thu, Mar 29, 2018 at 03:25:06PM +0100, Al Viro wrote: > OK. Let's leave that alone for now. Re deferred cancels - AFAICS, we *must* > remove the sucker from ctx->active_reqs before dropping ->ctx_lock. > > As it is, you are creating a io_cancel()/io_cancel() race leading to double > fput().

Re: [PATCH 07/30] aio: add delayed cancel support

2018-03-29 Thread Christoph Hellwig
On Thu, Mar 29, 2018 at 03:25:06PM +0100, Al Viro wrote: > OK. Let's leave that alone for now. Re deferred cancels - AFAICS, we *must* > remove the sucker from ctx->active_reqs before dropping ->ctx_lock. > > As it is, you are creating a io_cancel()/io_cancel() race leading to double > fput().

[PATCH 4.4 02/20] genirq: Track whether the trigger type has been set

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Marc Zyngier commit 4f8413a3a799c958f7a10a6310a451e6b8aef5ad upstream. When requesting a shared interrupt, we assume that the firmware support code (DT or ACPI) has called

[PATCH 4.4 04/20] dccp: check sk for closed state in dccp_sendmsg()

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Alexey Kodanev [ Upstream commit 67f93df79aeefc3add4e4b31a752600f834236e2 ] dccp_disconnect() sets 'dp->dccps_hc_tx_ccid' tx handler to NULL, therefore if DCCP

[PATCH 4.4 04/20] dccp: check sk for closed state in dccp_sendmsg()

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Alexey Kodanev [ Upstream commit 67f93df79aeefc3add4e4b31a752600f834236e2 ] dccp_disconnect() sets 'dp->dccps_hc_tx_ccid' tx handler to NULL, therefore if DCCP socket is disconnected and

[PATCH 4.4 06/20] l2tp: do not accept arbitrary sockets

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit 17cfe79a65f98abe535261856c5aef14f306dff7 ] syzkaller found an issue caused by lack of sufficient checks in l2tp_tunnel_create() RAW

[PATCH 4.4 06/20] l2tp: do not accept arbitrary sockets

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit 17cfe79a65f98abe535261856c5aef14f306dff7 ] syzkaller found an issue caused by lack of sufficient checks in l2tp_tunnel_create() RAW sockets can not be

[PATCH 4.4 10/20] netlink: avoid a double skb free in genlmsg_mcast()

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Nicolas Dichtel [ Upstream commit 02a2385f37a7c6594c9d89b64c4a1451276f08eb ] nlmsg_multicast() consumes always the skb, thus the original skb must be freed only

[PATCH 4.4 10/20] netlink: avoid a double skb free in genlmsg_mcast()

2018-03-29 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Nicolas Dichtel [ Upstream commit 02a2385f37a7c6594c9d89b64c4a1451276f08eb ] nlmsg_multicast() consumes always the skb, thus the original skb must be freed only when this function is called

[PATCH 4.9 06/28] sch_netem: fix skb leak in netem_enqueue()

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Alexey Kodanev [ Upstream commit 35d889d10b649fda66121891ec05eca88150059d ] When we exceed current packets limit and we have more than one segment in the list

[PATCH 4.9 06/28] sch_netem: fix skb leak in netem_enqueue()

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Alexey Kodanev [ Upstream commit 35d889d10b649fda66121891ec05eca88150059d ] When we exceed current packets limit and we have more than one segment in the list returned by skb_gso_segment(),

[PATCH 4.9 05/28] rhashtable: Fix rhlist duplicates insertion

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Paul Blakey [ Upstream commit d3dcf8eb615537526bd42ff27a081d46d337816e ] When inserting duplicate objects (those with the same key), current rhlist implementation messes

[PATCH 4.9 05/28] rhashtable: Fix rhlist duplicates insertion

2018-03-29 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Paul Blakey [ Upstream commit d3dcf8eb615537526bd42ff27a081d46d337816e ] When inserting duplicate objects (those with the same key), current rhlist implementation messes up the chain pointers

<    3   4   5   6   7   8   9   10   11   12   >