On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote:
> This macro, provided in 'linux/kernel.h', will calculate the size
> more succinctly than a division operation.
It's nice that you send patches, but please try to send a
cover letter with your patch series.
Also, 75 patches is quite a lot
'struct hostif_data_indication_t' is not used in this driver. Remove
'struct hostif_data_indication_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_h
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_data_request_t' with 'struct
hostif_data_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hos
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct wpa_suite_t' with 'struct wpa_suite'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 fi
This macro, provided in 'linux/kernel.h', will calculate the size
more succinctly than a division operation.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c
b/d
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct rsn_mode_t' with 'struct rsn_mode'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_mib_value_t' with 'struct
hostif_mib_value'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h
'struct hostif_mib_get_confirm_t' is not used in this driver. Remove
'struct hostif_mib_get_confirm_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_ho
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct pmk_cache_t' with 'struct pmk_cache'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_mib_get_request_t' with 'struct
hostif_mib_get_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_mib_set_request_t' with 'struct
hostif_mib_set_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct channel_list_t' with 'struct channel_list'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 8
'struct hostif_power_mgmt_confirm_t' is not used in this driver. Remove
'struct hostif_power_mgmt_confirm_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/
'struct hostif_start_confirm_t' is not used in this driver. Remove 'struct
hostif_start_confirm_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_hostif.
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_start_request_t' with 'struct
hostif_start_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_h
'struct hostif_mib_set_confirm_t' is not used in this driver. Remove
'struct hostif_mib_set_confirm_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_ho
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct rate_set8_t' with 'struct rate_set8'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 6 +++---
1
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_power_mgmt_request_t' with 'struct
hostif_power_mgmt_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/k
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct fh_parms_t' with 'struct fh_parms'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1 file
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct ibss_parms_t' with 'struct ibss_parms'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct ssid_t' with 'struct ssid'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 10 +-
1 file
'struct rsn_t' is not used in this driver. Remove 'struct rsn_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_hostif.h
index a3c686c1289c..091bc82a99c4
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct erp_params_t' with 'struct erp_params'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct rate_set16_t' with 'struct rate_set16'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1
'struct hostif_stop_confirm_t' is not used in this driver. Remove 'struct
hostif_stop_confirm_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_hostif.h
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct cf_parms_t' with 'struct cf_parms'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1 file
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct ds_parms_t' with 'struct ds_parms'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
1 file
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_request_t' with 'struct hostif_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2
'struct hostif_connect_indication_t' is not used in this driver. Remove
'struct hostif_connect_indication_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/
'struct hostif_ps_adhoc_set_confirm_t' is not used in this driver. Remove
'struct hostif_ps_adhoc_set_confirm_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_ps_adhoc_set_request_t' with 'struct
hostif_ps_adhoc_set_request'.
Signed-off-by: Quytelda Kahja
---
drivers/stagi
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_infrastructure_set_request_t' with
'struct hostif_infrastructure_set_request'.
Signed-off-by: Quytelda Kahja
---
d
'struct hostif_infrastructure_set_confirm_t' is not used in this driver.
Remove 'struct hostif_infrastructure_set_confirm_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_adhoc_set_request_t' with 'struct
hostif_adhoc_set_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_stop_request_t' with 'struct
hostif_stop_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks7010
'struct hostif_adhoc_set_confirm_t' is not used in this driver. Remove
'struct hostif_adhoc_set_confirm_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct association_response_t' with 'struct
association_response'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_h
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_adhoc_set2_request_t' with 'struct
hostif_adhoc_set2_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/k
'struct hostif_associate_indication_t' is not used in this driver. Remove
'struct hostif_associate_indication_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct ap_info_t' with 'struct ap_info'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 8
driv
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct association_request_t' with 'struct
association_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hos
'struct last_associate_t' is not used in this driver. Remove 'struct
last_associate_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_hostif.h
index ce9f
On Thu, 29 Mar 2018, Varsha Rao wrote:
> On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote:
> >
> > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote:
> > > This patch fixes the clang warning of extraneous parentheses, with the
> > > following coccinelle script.
> > >
> > > @@
> > > identifier i;
On Fri, 30 Mar 2018, Joe Perches wrote:
> On Thu, 2018-03-29 at 21:03 +0530, Varsha Rao wrote:
> > On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote:
> > >
> > > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote:
> > > > This patch fixes the clang warning of extraneous parentheses, with the
> > >
On Fri, 30 Mar 2018 16:12:23 -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Acked-by: Jakub Kicinski
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_bss_scan_request_t' with 'struct
hostif_bss_scan_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks701
On Fri, Mar 30, 2018 at 2:39 PM, Casey Schaufler wrote:
> On 3/29/2018 7:33 PM, Sargun Dhillon wrote:
>> On Thu, Mar 29, 2018 at 02:37:10PM -0700, Casey Schaufler wrote:
>>> On 3/29/2018 2:14 PM, Sargun Dhillon wrote:
This patch introduces a mechanism to add mutable hooks and immutable
h
'struct hostif_bss_scan_confirm_t' is not used in this driver. Remove
'struct hostif_bss_scan_confirm_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_phy_information_request_t' with 'struct
hostif_phy_information_request'.
Signed-off-by: Quytelda Kahja
---
drivers
'struct hostif_mic_failure_confirm_t' is not used in this driver. Remove
'struct hostif_mic_failure_confirm_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks701
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct wps_ie_t' with 'struct wps_ie'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 file chang
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_mic_failure_request_t' with 'struct
hostif_mic_failure_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostif_sleep_request_t' with 'struct
hostif_sleep_request'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_h
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct hostt_t' with 'struct hostt'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 file changed
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct rsn_ie_t' with 'struct rsn_ie'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 6 +++---
1 file cha
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct local_ap_t' with 'struct local_ap'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 10 +
'struct hostif_sleep_confirm_t' is not used in this driver. Remove 'struct
hostif_sleep_confirm_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_hostif.
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct local_aplist_t' with 'struct local_aplist'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct power_save_status_t' with 'struct
power_save_status'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct local_gain_t' with 'struct local_gain'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 fi
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct wpa_key_t' with 'struct wpa_key'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
drivers/
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct scan_ext_t' with 'struct scan_ext'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 file c
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct local_eeprom_sum_t' with 'struct
local_eeprom_sum'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h |
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct michael_mic_t' with 'struct michael_mic'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++-
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct pmk_list_t' with 'struct pmk_list'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 file c
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct sleep_status_t' with 'struct sleep_status'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct wpa_status_t' with 'struct wpa_status'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 fi
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct wps_status_t' with 'struct wps_status'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 4 ++--
1 fi
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct mic_failure_t' with 'struct mic_failure'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
dr
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct pmk_t' with 'struct pmk'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
drivers/staging/
All of the net_device_ops callbacks are named after their counterparts
in the kernel's 'struct net_device_ops', except
ks_wlan_set_multicast_list(). Rename it to ks_wlan_set_rx_mode() for
greater consistency.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.c | 6 +++---
1 f
Setting a dummy address during the driver probe is not necessary.
The dev_addr field is already zeroed out from alloc_etherdev().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c
The 'device_open_status' member of 'struct ks_wlan_private' is only
ever set to zero or one, so it makes more sense for it to be a bool
instead of an int.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan.h | 2 +-
drivers/staging/ks7010/ks_wlan_net.c | 5 ++---
2 files change
Remove an extra blank line indicated by checkpatch.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks7010_sdio.c | 3 ++-
drivers/staging/ks7010/ks_hostif.c | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging/k
The casts used when initializing members of this data structure mirror
the types the variables already have. Remove the casts.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_wlan_net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ks7010/
Copying the dummy HW address into the struct net_device doesn't need
to be done byte by byte; use ether_addr_copy() instead.
Additionally, dev->dev_addr is not eight bytes long.
ether_setup() sets the dev->addr_len to ETH_ALEN (defined as 6)
in the net core code.
Signed-off-by: Quytelda Kahja
---
ether_addr_copy() is the function for copying a hardware address,
so replace the manual memcpy() operation with ether_addr_copy().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_ho
ether_addr_equal() is the function for comparing HW addresses,
so remove the manual memcmp operation and replace it with
ether_addr_equals().
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/stagi
The "_t" suffix is not needed for structure names in this driver, and is a
reflection of an older typedef system that is no longer in place. Replace
all occurences of 'struct link_ap_info_t' with 'struct link_ap_info'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
'struct hostif_phy_information_confirm_t' is not used in this driver.
Remove 'struct hostif_phy_information_confirm_t'.
Signed-off-by: Quytelda Kahja
---
drivers/staging/ks7010/ks_hostif.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/driv
On Fri, Mar 30, 2018 at 8:07 PM, Steven Rostedt wrote:
> On Fri, 30 Mar 2018 19:18:57 -0700
> Matthew Wilcox wrote:
>
>> Again though, this is the same pattern as vmalloc. There are any number
>> of places where userspace can cause an arbitrarily large vmalloc to be
>> attempted (grep for kvmall
* Dave Hansen wrote:
> On 03/30/2018 01:32 PM, Thomas Gleixner wrote:
> > On Fri, 30 Mar 2018, Dave Hansen wrote:
> >
> >> On 03/30/2018 05:17 AM, Ingo Molnar wrote:
> >>> BTW., the expectation on !PCID Intel hardware would be for global pages
> >>> to help
> >>> even more than the 0.6% and 1
* Kees Cook wrote:
> On Mon, Mar 26, 2018 at 10:47 PM, Ingo Molnar wrote:
> >
> > * Kees Cook wrote:
> >
> >> In the effort to remove all VLAs from the kernel[1], it is desirable to
> >> build with -Wvla. However, this warning is overly pessimistic, in that
> >> it is only happy with stack arr
On Sat, Mar 31, 2018 at 11:20:22AM +0900, Masahiro Yamada wrote:
> 2018-03-31 7:21 GMT+09:00 Andrei Vagin :
> > On Fri, Mar 30, 2018 at 10:40:22AM -0700, Andrei Vagin wrote:
> >> On Fri, Mar 23, 2018 at 10:04:32PM +0900, Masahiro Yamada wrote:
> >> > Now that the kernel build supports flex and biso
On Mon, Mar 26, 2018 at 10:47 PM, Ingo Molnar wrote:
>
> * Kees Cook wrote:
>
>> In the effort to remove all VLAs from the kernel[1], it is desirable to
>> build with -Wvla. However, this warning is overly pessimistic, in that
>> it is only happy with stack array sizes that are declared as consta
Hi Ilia,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on clk/clk-next]
[also build test ERROR on v4.16-rc7 next-20180329]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/com
Julia Lawall writes:
> On Fri, 30 Mar 2018, Nicolai Stange wrote:
>
>> Julia Lawall writes:
>>
>> > On Thu, 29 Mar 2018, Fabio Estevam wrote:
>> >
>> >> Hi Julia,
>> >>
>> >> On Thu, Mar 29, 2018 at 4:12 PM, Julia Lawall
>> >> wrote:
>> >> > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIM
Block device inodes never have S_DAX set, so kill the check for DAX and
diversion to dax_writeback_mapping_range().
Cc: Jeff Moyer
Cc: Ross Zwisler
Cc: Matthew Wilcox
Cc: Dave Chinner
Reviewed-by: Christoph Hellwig
Reviewed-by: Jan Kara
Signed-off-by: Dan Williams
---
fs/block_dev.c |5
In preparation for the dax implementation to start associating dax pages
to inodes via page->mapping, we need to provide a 'struct
address_space_operations' instance for dax. Otherwise, direct-I/O
triggers incorrect page cache assumptions and warnings.
Cc: "Theodore Ts'o"
Cc: Andreas Dilger
Cc:
In preparation for the dax implementation to start associating dax pages
to inodes via page->mapping, we need to provide a 'struct
address_space_operations' instance for dax. Otherwise, direct-I/O
triggers incorrect page cache assumptions and warnings like the
following:
WARNING: CPU: 27 PID: 178
In preparation for the dax implementation to start associating dax pages
to inodes via page->mapping, we need to provide a 'struct
address_space_operations' instance for dax. Otherwise, direct-I/O
triggers incorrect page cache assumptions and warnings.
Cc: Jan Kara
Reported-by: kbuild test robot
In support of allowing device-mapper to compile out idle/dead code when
there are no dax providers in the system, introduce the DAX_DRIVER
symbol. This is selected by all leaf drivers that device-mapper might be
layered on top. This allows device-mapper to conditionally 'select DAX'
only when a pro
In order to resolve collisions between filesystem operations and DMA to
DAX mapped pages we need a callback when DMA completes. With a callback
we can hold off filesystem operations while DMA is in-flight and then
resume those operations when the last put_page() occurs on a DMA page.
Recall that t
Background:
get_user_pages() in the filesystem pins file backed memory pages for
access by devices performing dma. However, it only pins the memory pages
not the page-to-file offset association. If a file is truncated the
pages are mapped out of the file and dma may continue indefinitely into
a pa
In preparation for adding coordination between extent unmap operations
and busy dax-pages, update xfs_break_layouts() to permit it to be called
with the mmap lock held. This lock scheme will be required for
coordinating the break of 'dax layouts' (non-idle dax (ZONE_DEVICE)
pages mapped into the fi
The devm_memremap_pages() facility is tightly integrated with the
kernel's memory hotplug functionality. It injects an altmap argument
deep into the architecture specific vmemmap implementation to allow
allocating from specific reserved pages, and it has Linux specific
assumptions about page struct
When xfs is operating as the back-end of a pNFS block server, it
prevents collisions between local and remote operations by requiring a
lease to be held for remotely accessed blocks. Local filesystem
operations break those leases before writing or mutating the extent map
of the file.
A similar mec
Currently, kernel/memremap.c contains generic code for supporting
memremap() (CONFIG_HAS_IOMEM) and devm_memremap_pages()
(CONFIG_ZONE_DEVICE). This causes ongoing build maintenance problems as
additions to memremap.c, especially for the ZONE_DEVICE case, need to be
careful about being placed in if
xfs_break_dax_layouts(), similar to xfs_break_leased_layouts(), scans
for busy / pinned dax pages and waits for those pages to go idle before
any potential extent unmap operation.
dax_layout_busy_page() handles synchronizing against new page-busy
events (get_user_pages). It invalidates all mapping
In preparation for allowing filesystems to augment the dev_pagemap
associated with a dax_device, add an ->fs_claim() callback. The
->fs_claim() callback is leveraged by the device-mapper dax
implementation to iterate all member devices in the map and repeat the
claim operation across the array.
In
1 - 100 of 712 matches
Mail list logo
