Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-04 Thread Robert Jarzmik
Arnd Bergmann writes: > I'm still unable to follow through that code, but I understand now that > the device you pass to dma_request_slave_channel() is not the one > we'd like it to be here. > > Where exactly does that call to dma_request_chan() happen? Is this > the one in dmaengine_pcm_new()? C

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-04 Thread Arnd Bergmann
On Thu, Apr 5, 2018 at 8:29 AM, Ulf Hansson wrote: > On 4 April 2018 at 21:56, Boris Brezillon wrote: >> On Wed, 04 Apr 2018 21:49:26 +0200 >> Robert Jarzmik wrote: >> >>> Ulf Hansson writes: >>> >>> > On 2 April 2018 at 16:26, Robert Jarzmik wrote: >>> >> Hi, >>> >> >>> >> This serie is aimed

Re: sched_rt_period_timer causing large latencies

2018-04-04 Thread Mike Galbraith
On Thu, 2018-04-05 at 09:11 +1000, Nicholas Piggin wrote: > Hi, > > I'm seeing some pretty big latencies on a ~idle system when a CPU wakes > out of a nohz idle. Looks like it's due to the taking a lot of remote > locks and cache lines. irqoff trace: > > latency: 407 us, #608/608, CPU#3 | (M:serv

Re: [PATCH v5 1/3] regulator: axp20x: add drivevbus support for axp803

2018-04-04 Thread Maxime Ripard
On Thu, Apr 05, 2018 at 12:11:39PM +0530, Jagan Teki wrote: > On Tue, Mar 27, 2018 at 11:01 AM, Jagan Teki > wrote: > > Like axp221, axp223, axp813 the axp803 is also supporting external > > regulator to drive the OTG VBus through N_VBUSEN PMIC pin. > > > > Add support for it. > > > > Signed-off

Re: [PATCH v5 1/3] regulator: axp20x: add drivevbus support for axp803

2018-04-04 Thread Jagan Teki
On Tue, Mar 27, 2018 at 11:01 AM, Jagan Teki wrote: > Like axp221, axp223, axp813 the axp803 is also supporting external > regulator to drive the OTG VBus through N_VBUSEN PMIC pin. > > Add support for it. > > Signed-off-by: Jagan Teki > Reviewed-by: Rob Herring > Reviewed-by: Chen-Yu Tsai > -

Re: WARNING: kobject bug in sysfs_warn_dup

2018-04-04 Thread Greg KH
On Wed, Apr 04, 2018 at 07:02:01PM -0700, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 3e968c9f1401088abc9a19ae6ff571644d37a355 (Wed Apr 4 21:19:24 2018 +) > Merge tag 'ext4_for_linus' of > git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 > syzbot dash

Re: [GIT PULL] USB/PHY driver patches for 4.17-rc1

2018-04-04 Thread Kees Cook
On Wed, Apr 4, 2018 at 3:31 AM, Greg KH wrote: > Lars-Peter Clausen (2): > usb: gadget: ffs: Execute copy_to_user() with USER_DS set https://git.kernel.org/linus/4058ebf33cb0be88ca516f968eda24ab7b6b93e4 Isn't there a better way to do this without the set_fs() usage? We've been try to elimi

linux-next: manual merge of the akpm tree with the nvdimm tree

2018-04-04 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm tree got a conflict in: fs/dax.c between commit: fab6964f22b9 ("mm, fs, dax: handle layout changes to pinned dax mappings") which was removed from the nvdimm tree today and patch: "page cache: use xa_lock" from the akpm tree. I fixed it

[PATCH v2] perf/x86/intel: move regs->flags EXACT bit init

2018-04-04 Thread Stephane Eranian
This patch removes a redundant store on regs->flags introduced by commit: 71eb9ee9596d ("perf/x86/intel: Fix linear IP of PEBS real_ip on Haswell and later CPUs") We were clearing the PERF_EFLAGS_EXACT but it was overwritten by regs->flags = pebs->flags later on. The PERF_EFLAGS_EXACT is a soft

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-04 Thread Ulf Hansson
On 4 April 2018 at 21:56, Boris Brezillon wrote: > On Wed, 04 Apr 2018 21:49:26 +0200 > Robert Jarzmik wrote: > >> Ulf Hansson writes: >> >> > On 2 April 2018 at 16:26, Robert Jarzmik wrote: >> >> Hi, >> >> >> >> This serie is aimed at removing the dmaengine slave compat use, and >> >> transfe

Re: [PATCH 6/7] perf auxtrace: Make auxtrace_queues__add_buffer() allocate struct buffer

2018-04-04 Thread Adrian Hunter
On 07/03/18 16:11, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 07, 2018 at 10:06:50AM +0200, Adrian Hunter escreveu: >> On 06/03/18 22:25, Arnaldo Carvalho de Melo wrote: >>> Em Tue, Mar 06, 2018 at 11:13:17AM +0200, Adrian Hunter escreveu: In preparation for supporting AUX area sampling buf

Re: [PATCH] drm/sched: Extend the documentation.

2018-04-04 Thread Daniel Vetter
On Thu, Apr 5, 2018 at 12:32 AM, Eric Anholt wrote: > These comments answer all the questions I had for myself when > implementing a driver using the GPU scheduler. > > Signed-off-by: Eric Anholt Pulling all these comments into the generated kerneldoc would be awesome, maybe as a new "GPU Schedu

Re: [RFC PATCH 1/1 v2] vmscan: Support multiple kswapd threads per node

2018-04-04 Thread Michal Hocko
On Wed 04-04-18 21:49:54, Buddy Lumpkin wrote: > v2: > - Make update_kswapd_threads_node less racy > - Handle locking for case where CONFIG_MEMORY_HOTPLUG=n Please do not repost with such a small changes. It is much more important to sort out the big picture first and only then deal with minor imp

Re: [PATCH v2 03/19] powerpc: Mark variables as unused

2018-04-04 Thread Michael Ellerman
LEROY Christophe writes: > Mathieu Malaterre a écrit : > >> Add gcc attribute unused for two variables. Fix warnings treated as errors >> with W=1: >> >> arch/powerpc/kernel/prom_init.c:1388:8: error: variable ‘path’ set >> but not used [-Werror=unused-but-set-variable] >> >> Suggested-by: C

Re: [PATCH] kvm: Add emulation for movups/movupd

2018-04-04 Thread Paolo Bonzini
On 04/04/2018 19:35, Stefan Fritsch wrote: > On Wednesday, 4 April 2018 19:24:20 CEST Paolo Bonzini wrote: >> On 04/04/2018 19:10, Konrad Rzeszutek Wilk wrote: >>> Should there be a corresponding test-case? >> >> Good point! Stefan, could you write one? > > Is there infrastructure for such tests?

Re: [PATCH 2/2] efi: Add embedded peripheral firmware support

2018-04-04 Thread Lukas Wunner
On Wed, Apr 04, 2018 at 01:18:36PM -0400, Peter Jones wrote: > > On Tue, Apr 03, 2018 at 08:07:11PM +0200, Lukas Wunner wrote: > > > * Add the EFI Firmware Volume Protocol to include/linux/efi.h: > > > > > > https://www.intel.com/content/dam/doc/reference-guide/efi-firmware-file-volume-specifica

Re: [PATCH] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-04 Thread Michal Hocko
On Thu 05-04-18 00:29:06, Cyrill Gorcunov wrote: > On Wed, Apr 04, 2018 at 01:53:08PM -0700, Randy Dunlap wrote: [...] > > Yeah, that one's wrong also. :) > > So, maybe just get rid of any warning message at all? or simply do pr_warn("PR_SET_MM_MAP has been removed. Use instead\n"); --

Re: [PATCH 1/3] kbuild: Support HOSTLDFLAGS

2018-04-04 Thread Masahiro Yamada
2018-03-29 9:48 GMT+09:00 Laura Abbott : > > In addition to HOSTCFLAGS, there's HOSTLDFLAGS. Ensure these get passed to > calls to build host binaries. > > Signed-off-by: Laura Abbott > --- > scripts/Makefile.host | 6 +++--- > tools/build/Makefile.build | 2 +- > 2 files changed, 4 insertio

Re: [PATCH v2 2/2] perf: riscv: Add Document for Future Porting Guide

2018-04-04 Thread Alan Kao
Hi Alex, On Tue, Apr 03, 2018 at 07:08:43PM -0700, Alex Solomatnikov wrote: > Doc fixes: > > Thanks for these fixes. I'll edit this patch and send a v3 once I am done with the PMU patch. I suppose a "Reviewed-by: Alex Solomatnikov" appending at the end of the commit will be great, right? Alan

Re: [PATCH 0/2] perf: riscv: Preliminary Perf Event Support on RISC-V

2018-04-04 Thread Alan Kao
On Tue, Apr 03, 2018 at 03:45:17PM -0700, Palmer Dabbelt wrote: > On Tue, 03 Apr 2018 07:29:02 PDT (-0700), alan...@andestech.com wrote: > >On Mon, Apr 02, 2018 at 08:15:44PM -0700, Palmer Dabbelt wrote: > >>On Mon, 02 Apr 2018 05:31:22 PDT (-0700), alan...@andestech.com wrote: > >>>This implements

Re: [PATCH 3/3] kbuild: Allow passing additional HOSTCFLAGS and HOSTLDFLAGS

2018-04-04 Thread Masahiro Yamada
2018-03-29 9:48 GMT+09:00 Laura Abbott : > > Similar to AFLAGS_KBUILD, there may be uses (e.g. hardening) for passing in > additional flags to host programs. Allow these to be passed in from the > environment. > > Signed-off-by: Laura Abbott > --- > Documentation/kbuild/kbuild.txt | 9 + >

Re: [PATCH V2 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

2018-04-04 Thread Viresh Kumar
On 04-04-18, 10:50, Daniel Lezcano wrote: > Mmh, that sounds very complex. May be it is simpler to count the number > of cluster and initialize the idle_cdev for each cluster and then go for > this loop with the cluster cpumask. Maybe not sure. I have had such code in the past and it was quite str

Re: [PATCH v15 0/9] Add io{read|write}64 to io-64-atomic headers

2018-04-04 Thread Michael Ellerman
Logan Gunthorpe writes: > On 4/4/2018 4:38 AM, Michael Ellerman wrote: ... >> eg. It looks like I could take the two powerpc patches on their own for >> 4.17, and then the rest could go via other trees? > > Yup! If you can take the powerpc patches I can keep trying to get the > rest in. They are

Re: [PATCH 2/3] objtool: Support HOSTCFLAGS and HOSTLDFLAGS

2018-04-04 Thread Masahiro Yamada
2018-03-29 9:48 GMT+09:00 Laura Abbott : > It may be useful to compile host programs with different flags (e.g. > hardening). Ensure that objtool picks up the appropriate flags. > > Signed-off-by: Laura Abbott > --- I saw some similar patches before. I thought they are fixing this way https://p

[PATCH] uapi: fix linux/kfd_ioctl.h userspace compilation errors

2018-04-04 Thread Dmitry V. Levin
Consistently use types provided by via to fix the following linux/kfd_ioctl.h userspace compilation errors: /usr/include/linux/kfd_ioctl.h:266:2: error: unknown type name 'uint64_t' uint64_t tba_addr; /* to KFD */ /usr/include/linux/kfd_ioctl.h:267:2: error: unknown type name 'uint64_t' uin

[PATCH] uapi: fix asm/bootparam.h userspace compilation errors

2018-04-04 Thread Dmitry V. Levin
Consistently use types provided by to fix the following asm/bootparam.h userspace compilation errors: /usr/include/asm/bootparam.h:140:2: error: unknown type name 'u16' u16 version; /usr/include/asm/bootparam.h:141:2: error: unknown type name 'u16' u16 compatible_version; /usr/include/asm/boo

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

2018-04-04 Thread Stuart Yoder
On Wed, Apr 4, 2018 at 7:42 AM, Andrew Lunn wrote: >> I hear you. It is more complicated this way...having all these individual >> objects vs just a single "bundle" of them that represents a NIC. But, that's >> the way the DPAA2 hardware is, and we're implementing kernel support for >> the hardw

Re: [RFC PATCH 1/1] vmscan: Support multiple kswapd threads per node

2018-04-04 Thread Buddy Lumpkin
> On Apr 3, 2018, at 2:12 PM, Matthew Wilcox wrote: > > On Tue, Apr 03, 2018 at 01:49:25PM -0700, Buddy Lumpkin wrote: >>> Yes, very much this. If you have a single-threaded workload which is >>> using the entirety of memory and would like to use even more, then it >>> makes sense to use as man

Re: [PATCH v1] kernel/trace:check the val against the available mem

2018-04-04 Thread Joel Fernandes
On Wed, Apr 4, 2018 at 7:58 PM, Matthew Wilcox wrote: > On Wed, Apr 04, 2018 at 11:47:30AM -0400, Steven Rostedt wrote: >> I originally was going to remove the RETRY_MAYFAIL, but adding this >> check (at the end of the loop though) appears to have OOM consistently >> kill this task. >> >> I still

KASAN: use-after-free Read in ntfs_read_locked_inode

2018-04-04 Thread syzbot
Hello, syzbot hit the following crash on upstream commit 3e968c9f1401088abc9a19ae6ff571644d37a355 (Wed Apr 4 21:19:24 2018 +) Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=19b469021157c

Re: [PATCH] f2fs: enlarge block plug coverage

2018-04-04 Thread Jaegeuk Kim
On 04/04, Chao Yu wrote: > This patch enlarges block plug coverage in __issue_discard_cmd, in > order to collect more pending bios before issuing them, to avoid > being disturbed by previous discard I/O in IO aware discard mode. Hmm, then we need to wait for huge discard IO for over 10 secs, which

Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

2018-04-04 Thread Masami Hiramatsu
On Wed, 04 Apr 2018 10:17:03 -0500 Tom Zanussi wrote: > Hi Masami, > > On Wed, 2018-04-04 at 21:33 +0900, Masami Hiramatsu wrote: > > Hi Tom, > > > > On Mon, 02 Apr 2018 12:09:33 -0500 > > Tom Zanussi wrote: > > > > > after: > > > > > > # echo 'wakeup_latency u64 lat; pid_t pid' >> > > >

Re: [PATCH] f2fs: fix to show encrypt flag in FS_IOC_GETFLAGS

2018-04-04 Thread Jaegeuk Kim
On 04/03, Chao Yu wrote: > On 2018/4/3 4:21, Jaegeuk Kim wrote: > > On 04/02, Chao Yu wrote: > >> This patch fixes to show encrypt flag in FS_IOC_GETFLAGS like ext4 does. > > > > Actually, we have to show internal flags owned by f2fs, not generic ones. > > We may need to define all of them separat

[GIT PULL] f2fs update for 4.17-rc1

2018-04-04 Thread Jaegeuk Kim
Hi Linus, Could you please consider this pull request? Thanks, The following changes since commit 3664ce2d930983966d2aac0e167f1332988c4e25: Merge tag 'powerpc-4.16-4' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux (2018-02-24 16:05:50 -0800) are available in the Git reposit

Re: WARNING in up_write

2018-04-04 Thread Matthew Wilcox
On Wed, Apr 04, 2018 at 11:22:00PM -0400, Theodore Y. Ts'o wrote: > On Wed, Apr 04, 2018 at 12:35:04PM -0700, Matthew Wilcox wrote: > > On Wed, Apr 04, 2018 at 09:24:05PM +0200, Dmitry Vyukov wrote: > > > On Tue, Apr 3, 2018 at 4:01 AM, syzbot > > > wrote: > > > > DEBUG_LOCKS_WARN_ON(sem->owner !=

Re: WARNING in up_write

2018-04-04 Thread Theodore Y. Ts'o
On Wed, Apr 04, 2018 at 12:35:04PM -0700, Matthew Wilcox wrote: > On Wed, Apr 04, 2018 at 09:24:05PM +0200, Dmitry Vyukov wrote: > > On Tue, Apr 3, 2018 at 4:01 AM, syzbot > > wrote: > > > DEBUG_LOCKS_WARN_ON(sem->owner != get_current()) > > > WARNING: CPU: 1 PID: 4441 at kernel/locking/rwsem.c:13

Re: [PATCH] locking/rwsem: Add up_write_non_owner() for percpu_up_write()

2018-04-04 Thread Theodore Y. Ts'o
On Wed, Apr 04, 2018 at 10:37:26AM -0400, Waiman Long wrote: > The commit 8c5db92a705d ("locking/rwsem: Add DEBUG_RWSEMS to look for > lock/unlock mismatches") causes a warning in ext4 fstests due to the > fact that the freeze and thaw ioctls, by design, are run in different > processes. While tru

Re: [PATCH v1] kernel/trace:check the val against the available mem

2018-04-04 Thread Matthew Wilcox
On Wed, Apr 04, 2018 at 11:47:30AM -0400, Steven Rostedt wrote: > I originally was going to remove the RETRY_MAYFAIL, but adding this > check (at the end of the loop though) appears to have OOM consistently > kill this task. > > I still like to keep RETRY_MAYFAIL, because it wont trigger OOM if >

Re: [PATCH] gup: return -EFAULT on access_ok failure

2018-04-04 Thread Linus Torvalds
On Wed, Apr 4, 2018 at 6:53 PM, Michael S. Tsirkin wrote: > > Any feedback on this? As this fixes a bug in vhost, I'll merge > through the vhost tree unless someone objects. NAK. __get_user_pages_fast() returns the number of pages it gets. It has never returned an error code, and all the other

Re: An actual suggestion (Re: [GIT PULL] Kernel lockdown for secure boot)

2018-04-04 Thread joeyli
Hi David, On Wed, Apr 04, 2018 at 05:17:24PM +0100, David Howells wrote: > Andy Lutomirski wrote: > > > Since this thread has devolved horribly, I'm going to propose a solution. > > > > 1. Split the "lockdown" state into three levels: (please don't > > bikeshed about the names right now.) > >

Re: [PATCH] mmc: dw_mmc-k3: Fix DDR52 mode by setting required clock divisor

2018-04-04 Thread zhangfei
+ Hisilicon colleague On 2018年04月05日 08:51, Shawn Lin wrote: [+ Zhangfei Gao who added support for hi6220] On 2018/4/4 23:31, Ryan Grachek wrote: On Tue, Apr 3, 2018 at 6:31 AM, Shawn Lin > wrote:     On 2018/3/30 2:24, oscardagrach wrote:     Need at least

Re: [rtlwifi-btcoex] Suspicious code in halbtc8821a1ant driver

2018-04-04 Thread Pkshih
On Thu, 2018-04-05 at 01:25 +, Gustavo A. R. Silva wrote: > Hi all, > > While doing some static analysis I came across the following piece of code at > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1581: > > 1581 static void btc8821a1ant_act_bt_sco_hid_only_busy(struct btc_

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-04 Thread Randy Dunlap
On 04/04/2018 06:48 PM, Jeff Mahoney wrote: > On 4/4/18 9:45 PM, Andrew Morton wrote: >> On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap wrote: >> >>> From: Randy Dunlap >>> >>> If the reiserfs mount option's journal name contains a '%' character, >>> it can lead to a WARN_ONCE() in lib/vsprintf.c

RE: [PATCH v30 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-04-04 Thread Wang, Wei W
On Thursday, April 5, 2018 9:12 AM, Michael S. Tsirkin wrote: > On Thu, Apr 05, 2018 at 12:30:27AM +, Wang, Wei W wrote: > > On Wednesday, April 4, 2018 10:08 PM, Michael S. Tsirkin wrote: > > > On Wed, Apr 04, 2018 at 10:07:51AM +0800, Wei Wang wrote: > > > > On 04/04/2018 02:47 AM, Michael S.

WARNING: kobject bug in sysfs_warn_dup

2018-04-04 Thread syzbot
Hello, syzbot hit the following crash on upstream commit 3e968c9f1401088abc9a19ae6ff571644d37a355 (Wed Apr 4 21:19:24 2018 +) Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=ff87a28e665c1

general protection fault in mount_fs

2018-04-04 Thread syzbot
Hello, syzbot hit the following crash on upstream commit 3e968c9f1401088abc9a19ae6ff571644d37a355 (Wed Apr 4 21:19:24 2018 +) Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=01ffaf5d9568d

Re: [GIT PULL] Staging/IIO driver changes for 4.17-rc1

2018-04-04 Thread Linus Torvalds
On Wed, Apr 4, 2018 at 3:32 AM, Greg KH wrote: > > It is a lot, over 500 changes, but not huge by previous kernel release > standards. We deleted more lines than we added again (27k added vs. 91k > remvoed), thanks to finally being able to delete the IRDA drivers and > networking code. Hmm. The

Re: [PATCH] gup: return -EFAULT on access_ok failure

2018-04-04 Thread Michael S. Tsirkin
On Fri, Mar 30, 2018 at 08:37:45PM +0300, Michael S. Tsirkin wrote: > get_user_pages_fast is supposed to be a faster drop-in equivalent of > get_user_pages. As such, callers expect it to return a negative return > code when passed an invalid address, and never expect it to > return 0 when passed a

[PULL] fwcfg, vhost: features and fixes

2018-04-04 Thread Michael S. Tsirkin
The following changes since commit 0c8efd610b58cb23cefdfa12015799079aef94ae: Linux 4.16-rc5 (2018-03-11 17:25:09 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to dc32bb678e103afbcfa4d8144

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-04 Thread Jeff Mahoney
On 4/4/18 9:45 PM, Andrew Morton wrote: > On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap wrote: > >> From: Randy Dunlap >> >> If the reiserfs mount option's journal name contains a '%' character, >> it can lead to a WARN_ONCE() in lib/vsprintf.c::format_decode(), >> saying: "Please remove unsupp

Re: An actual suggestion (Re: [GIT PULL] Kernel lockdown for secure boot)

2018-04-04 Thread joeyli
On Wed, Apr 04, 2018 at 11:19:27PM +0100, David Howells wrote: > Jann Horn wrote: > > > > Uh, no. bpf, for example, can be used to modify kernel memory. > > > > I'm pretty sure bpf isn't supposed to be able to modify arbitrary > > kernel memory. AFAIU if you can use BPF to write to arbitrary ke

[rtlwifi-btcoex] Suspicious code in halbtc8821a1ant driver

2018-04-04 Thread Gustavo A. R. Silva
Hi all, While doing some static analysis I came across the following piece of code at drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1581: 1581 static void btc8821a1ant_act_bt_sco_hid_only_busy(struct btc_coexist *btcoexist, 1582

Re: An actual suggestion (Re: [GIT PULL] Kernel lockdown for secure boot)

2018-04-04 Thread joeyli
Hi Andy, On Wed, Apr 04, 2018 at 07:49:12AM -0700, Andy Lutomirski wrote: > Since this thread has devolved horribly, I'm going to propose a solution. ... > 6. There's a way to *decrease* the lockdown level below the configured > value. (This ability itself may be gated by a config option.) > Choi

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-04 Thread Andrew Morton
On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap wrote: > From: Randy Dunlap > > If the reiserfs mount option's journal name contains a '%' character, > it can lead to a WARN_ONCE() in lib/vsprintf.c::format_decode(), > saying: "Please remove unsupported %/ in format string." > That's OK until pa

Re: linux-next: manual merge of the net-next tree with the pci tree

2018-04-04 Thread Stephen Rothwell
Hi all, On Tue, 3 Apr 2018 13:14:54 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c > > between commit: > > 2907938d2375 ("net/mlx5e: Use pcie_bandwidth_available() to compute > bandw

Re: [PATCH] soc: bcm: raspberrypi-power: Fix use of __packed

2018-04-04 Thread Sasha Levin
Hi Florian Fainelli. [This is an automated email] This commit has been processed because it contains a "Fixes:" tag. fixing commit: a09cd356586d ARM: bcm2835: add rpi power domain driver. The bot has also determined it's probably a bug fixing patch. (score: 35.5765) The bot has tested the follo

Re: [PATCH] resource: Fix integer overflow at reallocation

2018-04-04 Thread Sasha Levin
Hi Takashi Iwai. [This is an automated email] This commit has been processed because it contains a "Fixes:" tag. fixing commit: 23c570a67448 resource: ability to resize an allocated resource. The bot has also determined it's probably a bug fixing patch. (score: 99.2157) The bot has tested the f

Re: [PATCH net] netns: filter uevents correctly

2018-04-04 Thread Christian Brauner
On Wed, Apr 04, 2018 at 05:38:02PM -0500, Eric W. Biederman wrote: > Christian Brauner writes: > > > On Wed, Apr 04, 2018 at 09:48:57PM +0200, Christian Brauner wrote: > >> commit 07e98962fa77 ("kobject: Send hotplug events in all network > >> namespaces") > >> > >> enabled sending hotplug even

Re: [PATCH] drm/vc4: Fix memory leak during BO teardown

2018-04-04 Thread Sasha Levin
Hi Daniel J Blueman. [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has also determined it's probably a bug fixing patch. (score: 85.0720) The bot has tested the foll

Re: [PATCH] Input: synaptics-rmi4 - Fix an unchecked out of memory error path

2018-04-04 Thread Sasha Levin
Hi Christophe JAILLET. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 7.5278) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Build OK! v

Re: [PATCH 02/45] Fix exception_enter() return value

2018-04-04 Thread Sasha Levin
Hi David Howells. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 5.5190) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Build OK! v4.14.

Re: [GIT PULL] Kernel lockdown for secure boot

2018-04-04 Thread Peter Dolding
On Thu, Apr 5, 2018 at 2:26 AM, Matthew Garrett wrote: > On Tue, Apr 3, 2018 at 11:56 PM Peter Dolding wrote: >> On Wed, Apr 4, 2018 at 11:13 AM, Matthew Garrett wrote: > >> > There are four cases: >> > >> > Verified Boot off, lockdown off: Status quo in distro and mainline > kernels >> > Verifi

Re: [PATCH] ARM64: dts: meson-axg: enable the eMMC controller

2018-04-04 Thread Yixun Lan
Hi Kevin On 04/04/2018 02:26 AM, kbuild test robot wrote: > Hi Nan, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on next-20180403] > [cannot apply to robh/for-next v4.16 v4.16-rc7 v4.16-rc6 v4.16] > [if your patch is applied to the wrong git tree, please drop

[PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

2018-04-04 Thread Randy Dunlap
From: Randy Dunlap If the reiserfs mount option's journal name contains a '%' character, it can lead to a WARN_ONCE() in lib/vsprintf.c::format_decode(), saying: "Please remove unsupported %/ in format string." That's OK until panic_on_warn is set, at which point it's dead, Jim. To placate this

Re: [PATCH] uts_namespace: Move boot_id in uts namespace

2018-04-04 Thread Marian Marinov
On 04/05/2018 03:35 AM, Eric W. Biederman wrote: > Marian Marinov writes: > >> On 04/04/2018 07:02 PM, Eric W. Biederman wrote: >>> Angel Shtilianov writes: >>> Currently the same boot_id is reported for all containers running on a host node, including the host node itself. Even after

Re: [PATCH v30 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-04-04 Thread Michael S. Tsirkin
On Thu, Apr 05, 2018 at 12:30:27AM +, Wang, Wei W wrote: > On Wednesday, April 4, 2018 10:08 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 04, 2018 at 10:07:51AM +0800, Wei Wang wrote: > > > On 04/04/2018 02:47 AM, Michael S. Tsirkin wrote: > > > > On Wed, Apr 04, 2018 at 12:10:03AM +0800, Wei

Re: [PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-04-04 Thread Rob Herring
On Wed, Apr 4, 2018 at 5:35 PM, Jan Kiszka wrote: > Hi Frank, > > On 2018-03-04 01:17, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> Move duplicating and unflattening of an overlay flattened devicetree >> (FDT) into the overlay application code. To accomplish this, >> of_overlay_appl

Re: [PATCH] mmc: dw_mmc-k3: Fix DDR52 mode by setting required clock divisor

2018-04-04 Thread Shawn Lin
[+ Zhangfei Gao who added support for hi6220] On 2018/4/4 23:31, Ryan Grachek wrote: On Tue, Apr 3, 2018 at 6:31 AM, Shawn Lin > wrote: On 2018/3/30 2:24, oscardagrach wrote: Need at least one line commit body. Signed-off-by: oscardagrach mailt

Re: rcu_process_callbacks irqsoff latency caused by taking spinlock with irqs disabled

2018-04-04 Thread Nicholas Piggin
On Wed, 4 Apr 2018 17:13:58 -0700 "Paul E. McKenney" wrote: > On Thu, Apr 05, 2018 at 09:34:14AM +1000, Nicholas Piggin wrote: > > Hi Paul, > > > > Just looking at latencies, and RCU showed up as one of the maximums. > > This is a 2 socket system with (176 CPU threads). Just doing a > > `make -j

Re: 4.15.14 crash with iscsi target and dvd

2018-04-04 Thread Wakko Warner
Bart Van Assche wrote: > On Sun, 2018-04-01 at 14:27 -0400, Wakko Warner wrote: > > Wakko Warner wrote: > > > Wakko Warner wrote: > > > > I tested 4.14.32 last night with the same oops. 4.9.91 works fine. > > > > From the initiator, if I do cat /dev/sr1 > /dev/null it works. If I > > > > mount >

Re: linux-next: manual merge of the sparc-next tree with the arm64 tree

2018-04-04 Thread Stephen Rothwell
Hi all, On Wed, 21 Mar 2018 10:34:08 +1100 Stephen Rothwell wrote: > > Today's linux-next merge of the sparc-next tree got a conflict in: > > arch/x86/kernel/signal_compat.c > > between commit: > > 266da65e9156 ("signal: Add FPE_FLTUNK si_code for undiagnosable fp > exceptions") > > fro

Re: [PATCH] uts_namespace: Move boot_id in uts namespace

2018-04-04 Thread Eric W. Biederman
Marian Marinov writes: > On 04/04/2018 07:02 PM, Eric W. Biederman wrote: >> Angel Shtilianov writes: >> >>> Currently the same boot_id is reported for all containers running >>> on a host node, including the host node itself. Even after restarting >>> a container it will still have the same pe

RE: [PATCH v30 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-04-04 Thread Wang, Wei W
On Wednesday, April 4, 2018 10:08 PM, Michael S. Tsirkin wrote: > On Wed, Apr 04, 2018 at 10:07:51AM +0800, Wei Wang wrote: > > On 04/04/2018 02:47 AM, Michael S. Tsirkin wrote: > > > On Wed, Apr 04, 2018 at 12:10:03AM +0800, Wei Wang wrote: > > > > +static int add_one_sg(struct virtqueue *vq, unsi

Re: [PATCH 2/2] efi: Add embedded peripheral firmware support

2018-04-04 Thread Ard Biesheuvel
On 4 April 2018 at 22:25, Hans de Goede wrote: > HI, > > > On 04-04-18 19:18, Peter Jones wrote: >> >> On Tue, Apr 03, 2018 at 06:58:48PM +, Luis R. Rodriguez wrote: >>> >>> On Tue, Apr 03, 2018 at 08:07:11PM +0200, Lukas Wunner wrote: On Tue, Apr 03, 2018 at 10:33:25AM +0200, Hans d

Re: An actual suggestion (Re: [GIT PULL] Kernel lockdown for secure boot)

2018-04-04 Thread Matthew Garrett
On Wed, Apr 4, 2018 at 4:25 PM James Morris wrote: > It's surely reasonable to allow an already secure-booted system to be > debugged without needing to be rebooted. alt-sysrq-x from a physical console will do that.

Re: [GIT PULL] Kernel lockdown for secure boot

2018-04-04 Thread Matthew Garrett
On Wed, Apr 4, 2018 at 5:05 PM Peter Dolding wrote: > > If you don't have secure boot then an attacker with root can modify your > > bootloader or kernel, and on next boot lockdown can be silently disabled. > Stop being narrow minded you don't need secure boot to protect > bootloader or kernel t

Re: [GIT PULL] x86/build changes for v4.17

2018-04-04 Thread Kees Cook
On Wed, Apr 4, 2018 at 5:05 PM, Linus Torvalds wrote: > On Wed, Apr 4, 2018 at 4:31 PM, Matthias Kaehlcke wrote: >> >> From some experiments it looks like clang, in difference to gcc, does >> not treat constant values passed as parameters to inline function as >> constants. > > Yeah, I think gcc

Re: [PATCH v5 2/3] lib: Rename compiler intrinsic selects to GENERIC_LIB_*

2018-04-04 Thread Palmer Dabbelt
On Wed, 04 Apr 2018 15:02:58 PDT (-0700), jho...@kernel.org wrote: On Tue, Apr 03, 2018 at 03:39:34PM -0700, Palmer Dabbelt wrote: Sorry, I'm not sure if this is the right patch -- someone suggested acking this, but it's already Review-By me and if I understand correctly it's going through your

Re: rcu_process_callbacks irqsoff latency caused by taking spinlock with irqs disabled

2018-04-04 Thread Paul E. McKenney
On Thu, Apr 05, 2018 at 09:34:14AM +1000, Nicholas Piggin wrote: > Hi Paul, > > Just looking at latencies, and RCU showed up as one of the maximums. > This is a 2 socket system with (176 CPU threads). Just doing a > `make -j 352` kernel build. Got a max latency of 3ms. I don't think > that's anyth

[PATCH] brcm80211: brcmsmac: phy_lcn: remove duplicate code

2018-04-04 Thread Gustavo A. R. Silva
Remove and refactor some code in order to avoid having identical code for different branches. Notice that this piece of code hasn't been modified since 2011. Addresses-Coverity-ID: 1226756 ("Identical code for different branches") Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/broa

[RFC 1/3] drm: Add DAMAGE_CLIPS property to plane

2018-04-04 Thread Deepak Rawat
From: Lukasz Spintzyk Optional plane property to mark damaged regions on the plane in framebuffer coordinates of the framebuffer attached to the plane. The layout of blob data is simply an array of drm_mode_rect with maximum array size limited by DRM_MODE_FB_DIRTY_MAX_CLIPS. Unlike plane src coo

Re: [PATCH v2 2/2] io: prevent compiler reordering on the default readX() implementation

2018-04-04 Thread Sinan Kaya
On 4/4/2018 3:50 PM, Arnd Bergmann wrote: > On Wed, Apr 4, 2018 at 7:48 PM, Sinan Kaya wrote: >> On 4/4/2018 11:55 AM, Arnd Bergmann wrote: >>> Yes, exactly, plus the same for write and in/out of course. >> >> I was looking at this... >> >> inb() and outb() seem to be calling writeb(). It gets the

[RFC 2/3] drm: Add helper iterator functions to iterate over plane damage.

2018-04-04 Thread Deepak Rawat
With damage property in drm_plane_state, this patch adds helper iterator to traverse the damage clips. Iterator will return the damage rectangles in framebuffer, plane or crtc coordinates as need by driver implementation. Signed-off-by: Deepak Rawat --- drivers/gpu/drm/drm_atomic_helper.c | 122

[RFC 3/3] drm: Add helper to validate damage during modeset_check

2018-04-04 Thread Deepak Rawat
This patch adds a helper which should be called by driver which enable damage (by calling drm_plane_enable_damage_clips) from atomic_check hook. This helper for now set the damage to NULL for the planes on crtc which need full modeset. The driver also need to check for other crtc properties which

[RFC 0/3] drm: page-flip with damage

2018-04-04 Thread Deepak Rawat
Hi All, This is extension to Lukasz Spintzyk earlier draft of damage interface for drm. Bascially a new plane property is added called "DAMAGE_CLIPS" which is simply an array of drm_rect (exported to userspace as drm_mode_rect). The clips represents damage in framebuffer coordinate of attached fb

Re: [GIT PULL] x86/build changes for v4.17

2018-04-04 Thread Linus Torvalds
On Wed, Apr 4, 2018 at 4:31 PM, Matthias Kaehlcke wrote: > > From some experiments it looks like clang, in difference to gcc, does > not treat constant values passed as parameters to inline function as > constants. Yeah, I think gcc used to have those semantics a long time ago too. Many of our _

Re: [GIT PULL] Kernel lockdown for secure boot

2018-04-04 Thread Peter Dolding
> If you don't have secure boot then an attacker with root can modify your > bootloader or kernel, and on next boot lockdown can be silently disabled. Stop being narrow minded you don't need secure boot to protect bootloader or kernel the classic is only boot from read only media. Another is netw

Re: [PATCH v5 2/2] KVM: X86: Add Force Emulation Prefix for "emulate the next instruction"

2018-04-04 Thread Wanpeng Li
2018-04-05 1:09 GMT+08:00 Paolo Bonzini : > On 04/04/2018 15:35, Wanpeng Li wrote: >> 2018-04-04 19:59 GMT+08:00 David Hildenbrand : >>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 1eb495e..a55ecef 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -

Re: [PATCH] [RFC][WIP] namespace.c: Allow some unprivileged proc mounts when not fully visible

2018-04-04 Thread Eric W. Biederman
Alexey Dobriyan writes: >> The only option I have seen proposed that might qualify as something >> general purpose and simple is a new filesystem that is just the process >> directories of proc. > > While "mount -t pid" and "mount -t sysctl" are decades overdue, I don't > think they cover everyth

[PATCH v3 4/5] io: change outX() to have their own IO barrier overrides

2018-04-04 Thread Sinan Kaya
Open code writeX() inside outX() so that outX() variants have their own overrideable Port IO barrier combinations as __io_pbw() and __io_paw() for actions to be taken before port IO and after port IO write. Signed-off-by: Sinan Kaya --- include/asm-generic/io.h | 12 +--- 1 file changed,

Re: [PATCH] ring-buffer: Add set/clear_current_oom_origin() during allocations

2018-04-04 Thread Joel Fernandes
Hi Steve, On Wed, Apr 4, 2018 at 9:18 AM, Joel Fernandes wrote: > On Wed, Apr 4, 2018 at 9:13 AM, Steven Rostedt wrote: > [..] >>> >>> Also, I agree with the new patch and its nice idea to do that. >> >> Thanks, want to give it a test too? With the latest tree and the below diff, I can still OO

[PATCH v3 2/5] io: define stronger ordering for the default readX() implementation

2018-04-04 Thread Sinan Kaya
The default implementation of mapping readX() to __raw_readX() is wrong. readX() has stronger ordering semantics. Compiler is allowed to reorder __raw_readX() against the memory accesses following register read. Use the previously defined __io_ar() and __io_br() macros to harden code generation ac

[PATCH v3 1/5] io: define several IO & PIO barrier types for the asm-generic version

2018-04-04 Thread Sinan Kaya
Getting ready to harden readX()/writeX() and inX()/outX() semantics for the generic implementation. Defining two set of macros as __io_br() and __io_ar() to indicate actions to be taken before and after MMIO read. Defining two set of macros as __io_bw() and __io_aw() to indicate actions to be tak

[PATCH v3 5/5] io: change inX() to have their own IO barrier overrides

2018-04-04 Thread Sinan Kaya
Open code readX() inside inX() so that inX() variants have their own overrideable Port IO barrier combinations as __io_pbr() and __io_par() for actions to be taken before port IO and after port IO read. Signed-off-by: Sinan Kaya --- include/asm-generic/io.h | 21 ++--- 1 file cha

[PATCH v3 3/5] io: define stronger ordering for the default writeX() implementation

2018-04-04 Thread Sinan Kaya
The default implementation of mapping writeX() to __raw_writeX() is wrong. writeX() has stronger ordering semantics. Compiler is allowed to reorder memory writes against __raw_writeX(). Use the previously defined __io_aw() and __io_bw() macros to harden code generation according to architecture su

Re: [PATCH v4 5/9] vsprintf: Factor out %p[iI] handler as ip_addr_string()

2018-04-04 Thread Sergey Senozhatsky
On (04/04/18 10:58), Petr Mladek wrote: > > Also it is better to warn about unknown specifier instead of falling > back to the %p behavior. It will help people to understand what is > going wrong. They expect the IP address and not a pointer anyway > in this situation. > May be. If one sees a has

[GIT PULL] first round of SCSI updates for the 4.16+ merge window

2018-04-04 Thread James Bottomley
This is mostly updates of the usual drivers: arcmsr, qla2xx, lpfc, ufs, mpt3sas, hisi_sas. In addition we have removed several really old drivers: sym53c416, NCR53c406a, fdomain, fdomain_cs and removed the old scsi_module.c initialization from all remaining drivers. Plus an assortment of bug fixe

Re: [PATCH] uts_namespace: Move boot_id in uts namespace

2018-04-04 Thread Marian Marinov
On 04/04/2018 07:02 PM, Eric W. Biederman wrote: > Angel Shtilianov writes: > >> Currently the same boot_id is reported for all containers running >> on a host node, including the host node itself. Even after restarting >> a container it will still have the same persistent boot_id. >> >> This can

Re: [PATCH v4 7/9] vsprintf: Factor out %pO handler as kobject_string()

2018-04-04 Thread Sergey Senozhatsky
On (04/05/18 08:35), Sergey Senozhatsky wrote: > > Was this your intention? > Ah, it was. You mentioned it in the commit message : In fact, this avoids leaking the address when invalid %pO format : specifier is used. The old code fallen back to printing the : non-hashed value. Is it so? The de

[PATCH] [RESEND] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-04 Thread Lyude Paul
As it turns out, the aux block being off was not the real problem here, as transition from D3 to D0 is mandated by the DP spec to take a maximum of 1ms, whereas we're allowed a 100ms timeframe to respond to ESI irqs. The real problem here is a bit more subtle. When doing a modeset where the proble

  1   2   3   4   5   6   7   8   9   10   >