Re: [PATCH] dp83640: Ensure against premature access to PHY registers after reset

David Miller writes: > From: Andrew Lunn > Date: Fri, 6 Apr 2018 16:14:10 +0200 > >> On Fri, Apr 06, 2018 at 04:05:40PM +0200, Esben Haabendal wrote: >>> From: Esben Haabendal >>> >>> Signed-off-by: Esben Haabendal >>> ---

Re: [PATCH] dp83640: Ensure against premature access to PHY registers after reset

David Miller writes: > From: Andrew Lunn > Date: Fri, 6 Apr 2018 16:14:10 +0200 > >> On Fri, Apr 06, 2018 at 04:05:40PM +0200, Esben Haabendal wrote: >>> From: Esben Haabendal >>> >>> Signed-off-by: Esben Haabendal >>> --- >>> drivers/net/phy/dp83640.c | 17 + >>> 1 file

[tip:perf/urgent] perf annotate browser: Fixup vertical line separating metrics from instructions

Commit-ID: e726c8511c052ba40dc943517b54011e42c2dfa3 Gitweb: https://git.kernel.org/tip/e726c8511c052ba40dc943517b54011e42c2dfa3 Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 5 Apr 2018 11:35:32 -0300 Committer: Arnaldo Carvalho de Melo CommitDate:

[tip:perf/urgent] perf annotate browser: Fixup vertical line separating metrics from instructions

Commit-ID: e726c8511c052ba40dc943517b54011e42c2dfa3 Gitweb: https://git.kernel.org/tip/e726c8511c052ba40dc943517b54011e42c2dfa3 Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 5 Apr 2018 11:35:32 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 5 Apr 2018 11:50:44 -0300

[tip:perf/urgent] perf ui browser: Fixup cleaning unused lines at the bottom

Commit-ID: caf61de356189f0925b23c3922bd16b53bb7c768 Gitweb: https://git.kernel.org/tip/caf61de356189f0925b23c3922bd16b53bb7c768 Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 5 Apr 2018 11:43:38 -0300 Committer: Arnaldo Carvalho de Melo CommitDate:

[tip:perf/urgent] perf ui browser: Fixup cleaning unused lines at the bottom

Commit-ID: caf61de356189f0925b23c3922bd16b53bb7c768 Gitweb: https://git.kernel.org/tip/caf61de356189f0925b23c3922bd16b53bb7c768 Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 5 Apr 2018 11:43:38 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 5 Apr 2018 11:51:28 -0300

[tip:perf/urgent] perf annotate: Show group details on the title line

Commit-ID: c0459a092509f9c2ff91cc070cd2645d38e7cf7b Gitweb: https://git.kernel.org/tip/c0459a092509f9c2ff91cc070cd2645d38e7cf7b Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 5 Apr 2018 11:13:24 -0300 Committer: Arnaldo Carvalho de Melo CommitDate:

[tip:perf/urgent] perf annotate: Show group details on the title line

Commit-ID: c0459a092509f9c2ff91cc070cd2645d38e7cf7b Gitweb: https://git.kernel.org/tip/c0459a092509f9c2ff91cc070cd2645d38e7cf7b Author: Arnaldo Carvalho de Melo AuthorDate: Thu, 5 Apr 2018 11:13:24 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 5 Apr 2018 11:18:39 -0300

[tip:perf/urgent] perf auxtrace: Make auxtrace_queues__add_buffer() allocate struct buffer

Commit-ID: 0d75f123a6dcdacb3550b0c3c44a283f7259289e Gitweb: https://git.kernel.org/tip/0d75f123a6dcdacb3550b0c3c44a283f7259289e Author: Adrian Hunter AuthorDate: Tue, 6 Mar 2018 11:13:17 +0200 Committer: Arnaldo Carvalho de Melo CommitDate:

[tip:perf/urgent] perf auxtrace: Make auxtrace_queues__add_buffer() allocate struct buffer

Commit-ID: 0d75f123a6dcdacb3550b0c3c44a283f7259289e Gitweb: https://git.kernel.org/tip/0d75f123a6dcdacb3550b0c3c44a283f7259289e Author: Adrian Hunter AuthorDate: Tue, 6 Mar 2018 11:13:17 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 5 Apr 2018 11:03:33 -0300 perf

Re: [PATCH 0/8] use struct pt_regs based syscall calling for x86-64

* Dominik Brodowski wrote: > > I.e. I'd generate the names like this: > > > > __{x64,x32,ia32}[_compat]_sys_waittid() > > > > The fully consistent nomenclature would be someting like this: > > > > 8105f1e0 tkernel_waitid# common C

Re: [PATCH 0/8] use struct pt_regs based syscall calling for x86-64

* Dominik Brodowski wrote: > > I.e. I'd generate the names like this: > > > > __{x64,x32,ia32}[_compat]_sys_waittid() > > > > The fully consistent nomenclature would be someting like this: > > > > 8105f1e0 tkernel_waitid# common C function (64-bit > > kargs) > >

[PATCH][next] crypto: chtls: remove redundant assignment to cdev->ports

From: Colin Ian King There is a double assignment to cdev->ports, the first is redundant as it is over-written so remove it. Detected by CoverityScan, CID#1467432 ("Unused value") Signed-off-by: Colin Ian King ---

[PATCH][next] crypto: chtls: remove redundant assignment to cdev->ports

From: Colin Ian King There is a double assignment to cdev->ports, the first is redundant as it is over-written so remove it. Detected by CoverityScan, CID#1467432 ("Unused value") Signed-off-by: Colin Ian King --- drivers/crypto/chelsio/chtls/chtls_main.c | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

On 4/5/18 5:04 AM, Rasmus Villemoes wrote: > On 2018-04-05 03:45, Andrew Morton wrote: >> On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap wrote: >> >>> From: Randy Dunlap >>> >>> If the reiserfs mount option's journal name contains a '%' character,

Re: [PATCH?] reiserfs: prevent panic: don't allow %-char in journal dev. name

On 4/5/18 5:04 AM, Rasmus Villemoes wrote: > On 2018-04-05 03:45, Andrew Morton wrote: >> On Wed, 4 Apr 2018 18:25:16 -0700 Randy Dunlap wrote: >> >>> From: Randy Dunlap >>> >>> If the reiserfs mount option's journal name contains a '%' character, >>> it can lead to a WARN_ONCE() in

Re: [PATCH 3/9] kbuild: Do not pass arguments to link-vmlinux.sh

On Fri, Apr 06, 2018 at 09:59:59AM +0900, Masahiro Yamada wrote: > 2018-04-06 3:59 GMT+09:00 Jiri Olsa : > > On Fri, Apr 06, 2018 at 12:50:00AM +0900, Masahiro Yamada wrote: > >> 2018-04-06 0:16 GMT+09:00 Jiri Olsa : > >> > There's no need to pass LD* arguments

Re: [PATCH 3/9] kbuild: Do not pass arguments to link-vmlinux.sh

On Fri, Apr 06, 2018 at 09:59:59AM +0900, Masahiro Yamada wrote: > 2018-04-06 3:59 GMT+09:00 Jiri Olsa : > > On Fri, Apr 06, 2018 at 12:50:00AM +0900, Masahiro Yamada wrote: > >> 2018-04-06 0:16 GMT+09:00 Jiri Olsa : > >> > There's no need to pass LD* arguments to link-vmlinux.sh, > >> > because

uvcvideo stopped working in 4.16

Since the 4.16 kernel my uvcvideo webcam on Thinkpad X1 Carbon (5th gen) stopped working with gst-launch-1.0, kamoso (kde webcam app), Firefox and Chromium on sites like appear.in, talky.io, Google Hangouts and meet.jit.si. It works fine in 4.15 The camera is: Bus 001 Device 004: ID 04f2:b5ce

uvcvideo stopped working in 4.16

Since the 4.16 kernel my uvcvideo webcam on Thinkpad X1 Carbon (5th gen) stopped working with gst-launch-1.0, kamoso (kde webcam app), Firefox and Chromium on sites like appear.in, talky.io, Google Hangouts and meet.jit.si. It works fine in 4.15 The camera is: Bus 001 Device 004: ID 04f2:b5ce

Re: [PATCH 1/5] arm64: entry: isb in el1_irq

On Fri, Apr 06, 2018 at 11:02:56AM +0100, James Morse wrote: > Hi Yury, > > An ISB at the beginning of the vectors? This is odd, taking an IRQ to get in > here would be a context-synchronization-event too, so the ISB is superfluous. > > The ARM-ARM has a list of 'Context-Synchronization event's

Re: [PATCH 1/5] arm64: entry: isb in el1_irq

On Fri, Apr 06, 2018 at 11:02:56AM +0100, James Morse wrote: > Hi Yury, > > An ISB at the beginning of the vectors? This is odd, taking an IRQ to get in > here would be a context-synchronization-event too, so the ISB is superfluous. > > The ARM-ARM has a list of 'Context-Synchronization event's

Re: KASAN: alloca-out-of-bounds Read in unwind_next_frame

On Fri, Apr 06, 2018 at 05:40:01PM +0200, Dmitry Vyukov wrote: > > So at first glance it seemed like a race condition. However, the > > unwinder was only trying to dereference the frame pointer (RBP: > > 8801b05e67f8), which should have never been poisoned in the first > > place. > > > > So

Re: KASAN: alloca-out-of-bounds Read in unwind_next_frame

On Fri, Apr 06, 2018 at 05:40:01PM +0200, Dmitry Vyukov wrote: > > So at first glance it seemed like a race condition. However, the > > unwinder was only trying to dereference the frame pointer (RBP: > > 8801b05e67f8), which should have never been poisoned in the first > > place. > > > > So

Re: [PATCH] swap: divide-by-zero when zero length swap file on ssd

[adding linux-mm and akpm] On 04/06/2018 07:11 AM, Tom Abraham wrote: > > > Calling swapon() on a zero length swap file on SSD can lead to a > > divide-by-zero.

Re: [PATCH] swap: divide-by-zero when zero length swap file on ssd

[adding linux-mm and akpm] On 04/06/2018 07:11 AM, Tom Abraham wrote: > > > Calling swapon() on a zero length swap file on SSD can lead to a > > divide-by-zero.

Re: [PATCH net-next] netns: filter uevents correctly

Christian Brauner writes: >> At a practical level there should be no receivers. Plus performance >> issues. At least my memory is that any unprivileged user on the system >> is allowed to listen to those events. > > Any unprivileged user is allowed to listen to

Re: [PATCH net-next] netns: filter uevents correctly

Christian Brauner writes: >> At a practical level there should be no receivers. Plus performance >> issues. At least my memory is that any unprivileged user on the system >> is allowed to listen to those events. > > Any unprivileged user is allowed to listen to uevents if they have >

Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

Hi Masami, On Fri, 2018-04-06 at 10:53 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Thu, 05 Apr 2018 18:34:13 -0500 > Tom Zanussi wrote: > > > Hi Masami, > > > > On Thu, 2018-04-05 at 12:50 +0900, Masami Hiramatsu wrote: > > > > [...] > > > > > Can you print

Re: [PATCH 3/4] tracing: Add action comparisons when testing matching hist triggers

Hi Masami, On Fri, 2018-04-06 at 10:53 +0900, Masami Hiramatsu wrote: > Hi Tom, > > On Thu, 05 Apr 2018 18:34:13 -0500 > Tom Zanussi wrote: > > > Hi Masami, > > > > On Thu, 2018-04-05 at 12:50 +0900, Masami Hiramatsu wrote: > > > > [...] > > > > > Can you print out the error with which

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott wrote: > Today's kernel oopsed on s390. Bisect points to: > 3c8ba0d61d04 ("kernel.h: Retain constant expression output for max()/min()") > > [1.898277] dasd-eckd 0.0.3304: DASD with 4 KB/block, 21636720 KB total > size,

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott wrote: > Today's kernel oopsed on s390. Bisect points to: > 3c8ba0d61d04 ("kernel.h: Retain constant expression output for max()/min()") > > [1.898277] dasd-eckd 0.0.3304: DASD with 4 KB/block, 21636720 KB total > size, 48 KB/track, compatible

Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC

Quoting Sekhar Nori (2018-04-06 02:37:03) > > Can you please check that and confirm there is no issue with genpd and > using CLK_OF_DECLARE() to initialize clocks? > > Unless you report an issue back, or Mike and Stephen have ideas about > how to handle the dependency between PSC/PLL derived

Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC

Quoting Sekhar Nori (2018-04-06 02:37:03) > > Can you please check that and confirm there is no issue with genpd and > using CLK_OF_DECLARE() to initialize clocks? > > Unless you report an issue back, or Mike and Stephen have ideas about > how to handle the dependency between PSC/PLL derived

Re: AMD graphics performance regression in 4.15 and later

Hi Christian, On 04/09/2018 07:48 AM, Christian König wrote: > Am 06.04.2018 um 17:30 schrieb Jean-Marc Valin: >> Hi Christian, >> >> Is there a way to turn off these huge pages at boot-time/run-time? > > Only at compile time by not setting CONFIG_TRANSPARENT_HUGEPAGE. Any reason why echo never

Re: AMD graphics performance regression in 4.15 and later

Hi Christian, On 04/09/2018 07:48 AM, Christian König wrote: > Am 06.04.2018 um 17:30 schrieb Jean-Marc Valin: >> Hi Christian, >> >> Is there a way to turn off these huge pages at boot-time/run-time? > > Only at compile time by not setting CONFIG_TRANSPARENT_HUGEPAGE. Any reason why echo never

Re: [PATCH 3/3] clk: qcom: gdsc: Add support to poll CFG register to check GDSC state

Quoting Taniya Das (2018-04-02 03:45:45) > diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c > index e89584e..e0c83ba 100644 > --- a/drivers/clk/qcom/gdsc.c > +++ b/drivers/clk/qcom/gdsc.c > @@ -83,6 +88,38 @@ static int gdsc_poll_status(struct gdsc *sc, unsigned int > reg, bool en)

Re: [PATCH 3/3] clk: qcom: gdsc: Add support to poll CFG register to check GDSC state

Quoting Taniya Das (2018-04-02 03:45:45) > diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c > index e89584e..e0c83ba 100644 > --- a/drivers/clk/qcom/gdsc.c > +++ b/drivers/clk/qcom/gdsc.c > @@ -83,6 +88,38 @@ static int gdsc_poll_status(struct gdsc *sc, unsigned int > reg, bool en)

Re: [PATCH] arm: kgdb: fix NUMREGBYTES so that gdb_regs[] is the correct size

On Fri, 6 Apr 2018 14:49:22 +0100 Daniel Thompson wrote: > On 06/04/18 14:25, Daniel Thompson wrote: > > On Thu, Apr 05, 2018 at 04:09:16PM -0400, David Rivshin wrote: > >> From: David Rivshin > >> > >> NUMREGBYTES (which is used as the size

Re: [PATCH] arm: kgdb: fix NUMREGBYTES so that gdb_regs[] is the correct size

On Fri, 6 Apr 2018 14:49:22 +0100 Daniel Thompson wrote: > On 06/04/18 14:25, Daniel Thompson wrote: > > On Thu, Apr 05, 2018 at 04:09:16PM -0400, David Rivshin wrote: > >> From: David Rivshin > >> > >> NUMREGBYTES (which is used as the size for gdb_regs[]) is incorrectly based > >> on

Re: [PATCH v3 3/4] mm: treat memory.low value inclusive

On Fri, Apr 06, 2018 at 01:21:38PM +0100, Roman Gushchin wrote: > Updated version below. > > -- > > From 466c35c36cae392cfee5e54a2884792972e789ee Mon Sep 17 00:00:00 2001 > From: Roman Gushchin > Date: Thu, 5 Apr 2018 19:31:35 +0100 > Subject: [PATCH v4 3/4] mm: treat memory.low

Re: [PATCH v3 3/4] mm: treat memory.low value inclusive

On Fri, Apr 06, 2018 at 01:21:38PM +0100, Roman Gushchin wrote: > Updated version below. > > -- > > From 466c35c36cae392cfee5e54a2884792972e789ee Mon Sep 17 00:00:00 2001 > From: Roman Gushchin > Date: Thu, 5 Apr 2018 19:31:35 +0100 > Subject: [PATCH v4 3/4] mm: treat memory.low value inclusive

Re: [PATCH] mm-vmscan-dont-mess-with-pgdat-flags-in-memcg-reclaim-v2-fix

On Fri, Apr 06, 2018 at 04:52:15PM +0300, Andrey Ryabinin wrote: > On 04/06/2018 05:13 AM, Shakeel Butt wrote: > > Question: Should this 'flags' be per-node? Is it ok for a congested > > memcg to call wait_iff_congested for all nodes? > > Indeed, congestion state should be pre-node. If memcg on

Re: [PATCH] mm-vmscan-dont-mess-with-pgdat-flags-in-memcg-reclaim-v2-fix

On Fri, Apr 06, 2018 at 04:52:15PM +0300, Andrey Ryabinin wrote: > On 04/06/2018 05:13 AM, Shakeel Butt wrote: > > Question: Should this 'flags' be per-node? Is it ok for a congested > > memcg to call wait_iff_congested for all nodes? > > Indeed, congestion state should be pre-node. If memcg on

Re: [PATCH v4 0/1] Safe LSM (un)loading, and immutable hooks

On 4/5/2018 9:12 PM, Peter Dolding wrote: > On Fri, Apr 6, 2018 at 11:31 AM, Sargun Dhillon wrote: >> >> On Thu, Apr 5, 2018 at 9:29 AM, Casey Schaufler >> wrote: >>> On 4/5/2018 3:31 AM, Peter Dolding wrote: On Thu, Apr 5, 2018 at 7:55 PM, Igor

Re: [PATCH v4 0/1] Safe LSM (un)loading, and immutable hooks

On 4/5/2018 9:12 PM, Peter Dolding wrote: > On Fri, Apr 6, 2018 at 11:31 AM, Sargun Dhillon wrote: >> >> On Thu, Apr 5, 2018 at 9:29 AM, Casey Schaufler >> wrote: >>> On 4/5/2018 3:31 AM, Peter Dolding wrote: On Thu, Apr 5, 2018 at 7:55 PM, Igor Stoppa wrote: > On 01/04/18 08:41,

Re: [PATCH] drivers/memory: can't open emif-asm-offsets.s for writing

On 4/6/2018 6:00 AM, Anders Roxell wrote: Build failes due to that the directory isn't created before we execute the build rule. cc1: fatal error: can’t open ‘drivers/memory/emif-asm-offsets.s’ for writing: No such file or directory compilation terminated.

Re: [PATCH] drivers/memory: can't open emif-asm-offsets.s for writing

On 4/6/2018 6:00 AM, Anders Roxell wrote: Build failes due to that the directory isn't created before we execute the build rule. cc1: fatal error: can’t open ‘drivers/memory/emif-asm-offsets.s’ for writing: No such file or directory compilation terminated.

RE: [PATCH 1/5] powerpc/embedded6xx: Remove C2K board support

Acked-by: Remi Machet -Original Message- From: Mark Greer Sent: Thursday, April 5, 2018 9:17 PM To: Benjamin Herrenschmidt ; Paul Mackerras ; Michael Ellerman Cc: Remi Machet

RE: [PATCH 1/5] powerpc/embedded6xx: Remove C2K board support

Acked-by: Remi Machet -Original Message- From: Mark Greer Sent: Thursday, April 5, 2018 9:17 PM To: Benjamin Herrenschmidt ; Paul Mackerras ; Michael Ellerman Cc: Remi Machet ; Dale Farnsworth ; linuxppc-...@lists.ozlabs.org; linux-kernel@vger.kernel.org; Mark Greer Subject: [PATCH

Re: [PATCH] kvm: x86: fix a prototype warning

On 06/04/2018 23:47, Peng Hao wrote: > warning: no previous prototype for ‘vmx_enable_tdp’ > > Signed-off-by: Peng Hao > --- > arch/x86/kvm/vmx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index

Re: [PATCH] kvm: x86: fix a prototype warning

On 06/04/2018 23:47, Peng Hao wrote: > warning: no previous prototype for ‘vmx_enable_tdp’ > > Signed-off-by: Peng Hao > --- > arch/x86/kvm/vmx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index f0fd50b..86681bc 100644 >

Re: [PATCH v2 3/4] mm/vmscan: Don't change pgdat state on base of a single LRU list state.

On Fri, Mar 23, 2018 at 06:20:28PM +0300, Andrey Ryabinin wrote: > We have separate LRU list for each memory cgroup. Memory reclaim iterates > over cgroups and calls shrink_inactive_list() every inactive LRU list. > Based on the state of a single LRU shrink_inactive_list() may flag > the whole

Re: [PATCH v2 3/4] mm/vmscan: Don't change pgdat state on base of a single LRU list state.

On Fri, Mar 23, 2018 at 06:20:28PM +0300, Andrey Ryabinin wrote: > We have separate LRU list for each memory cgroup. Memory reclaim iterates > over cgroups and calls shrink_inactive_list() every inactive LRU list. > Based on the state of a single LRU shrink_inactive_list() may flag > the whole

Re: [PATCH 4.4 00/72] 4.4.127-stable review

On Fri, Apr 06, 2018 at 03:23:01PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.127 release. > There are 72 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.4 00/72] 4.4.127-stable review

On Fri, Apr 06, 2018 at 03:23:01PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.127 release. > There are 72 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: sched_rt_period_timer causing large latencies

On Thu, Apr 05, 2018 at 08:08:59PM +1000, Nicholas Piggin wrote: > On Thu, 05 Apr 2018 10:40:20 +0200 > Mike Galbraith wrote: > > > On Thu, 2018-04-05 at 10:27 +0200, Peter Zijlstra wrote: > > > On Thu, Apr 05, 2018 at 09:11:38AM +1000, Nicholas Piggin wrote: > > > > Hi, > > > >

Re: sched_rt_period_timer causing large latencies

On Thu, Apr 05, 2018 at 08:08:59PM +1000, Nicholas Piggin wrote: > On Thu, 05 Apr 2018 10:40:20 +0200 > Mike Galbraith wrote: > > > On Thu, 2018-04-05 at 10:27 +0200, Peter Zijlstra wrote: > > > On Thu, Apr 05, 2018 at 09:11:38AM +1000, Nicholas Piggin wrote: > > > > Hi, > > > > > > > > I'm

[PATCH] tpm: st33zp24: remove redundant null check on chip

From: Colin Ian King Currently chip is being dereferenced by the call to dev_get_drvdata before it is being null checked, however, chip can never be null, so this check is misleading and redundant. Remove it. Detected by CoverityScan, CID#1357806 ("Dereference before

[PATCH] tpm: st33zp24: remove redundant null check on chip

From: Colin Ian King Currently chip is being dereferenced by the call to dev_get_drvdata before it is being null checked, however, chip can never be null, so this check is misleading and redundant. Remove it. Detected by CoverityScan, CID#1357806 ("Dereference before null check")

Re: [PATCH v2 2/2] mailbox: add STMicroelectronics STM32 IPCC driver

On Fri, Apr 6, 2018 at 8:35 PM, Fabien DESSENNE wrote: > > On 06/04/18 14:56, Jassi Brar wrote: >> On Fri, Apr 6, 2018 at 5:59 PM, Fabien DESSENNE >> wrote: >>> Hi >>> >>> >>> On 05/04/18 11:38, Jassi Brar wrote: On Mon, Mar 12, 2018 at 4:28

Re: [PATCH v2 2/2] mailbox: add STMicroelectronics STM32 IPCC driver

On Fri, Apr 6, 2018 at 8:35 PM, Fabien DESSENNE wrote: > > On 06/04/18 14:56, Jassi Brar wrote: >> On Fri, Apr 6, 2018 at 5:59 PM, Fabien DESSENNE >> wrote: >>> Hi >>> >>> >>> On 05/04/18 11:38, Jassi Brar wrote: On Mon, Mar 12, 2018 at 4:28 PM, Fabien Dessenne wrote:

Re: [PATCH 1/1] arm64: To remove initrd reserved area entry from memblock

On 04/05/2018 09:53 PM, CHANDAN VN wrote: INITRD reserved area entry is not removed from memblock even though initrd reserved area is freed. After freeing the memory it is released from memblock. The same can be checked from /sys/kernel/debug/memblock/reserved. The patch makes sure that the

Re: [PATCH 1/1] arm64: To remove initrd reserved area entry from memblock

On 04/05/2018 09:53 PM, CHANDAN VN wrote: INITRD reserved area entry is not removed from memblock even though initrd reserved area is freed. After freeing the memory it is released from memblock. The same can be checked from /sys/kernel/debug/memblock/reserved. The patch makes sure that the

Re: [patch] mm: memcg: make sure memory.events is uptodate when waking pollers fix

On Fri 06-04-18 11:54:41, Johannes Weiner wrote: > On Fri, Apr 06, 2018 at 02:53:30PM +1000, Stephen Rothwell wrote: > > Hi Andrew, > > > > After merging the akpm-current tree, today's linux-next build (x86_64 > > allmodconfig) produced this warning: > > > > mm/memcontrol.c: In function

Re: [patch] mm: memcg: make sure memory.events is uptodate when waking pollers fix

On Fri 06-04-18 11:54:41, Johannes Weiner wrote: > On Fri, Apr 06, 2018 at 02:53:30PM +1000, Stephen Rothwell wrote: > > Hi Andrew, > > > > After merging the akpm-current tree, today's linux-next build (x86_64 > > allmodconfig) produced this warning: > > > > mm/memcontrol.c: In function

Re: WARNING: bad unlock balance in xfs_iunlock

On Fri, Apr 06, 2018 at 07:38:44AM +1000, Dave Chinner wrote: > On Thu, Apr 05, 2018 at 08:54:50PM +0200, Dmitry Vyukov wrote: > > On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: > > > On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: > > >> Hello, > > >> > > >>

Re: WARNING: bad unlock balance in xfs_iunlock

On Fri, Apr 06, 2018 at 07:38:44AM +1000, Dave Chinner wrote: > On Thu, Apr 05, 2018 at 08:54:50PM +0200, Dmitry Vyukov wrote: > > On Tue, Apr 3, 2018 at 6:38 AM, Dave Chinner wrote: > > > On Mon, Apr 02, 2018 at 07:01:02PM -0700, syzbot wrote: > > >> Hello, > > >> > > >> syzbot hit the following

Re: [PATCH v2 2/4] mm/vmscan: remove redundant current_may_throttle() check

On Fri, Mar 23, 2018 at 06:20:27PM +0300, Andrey Ryabinin wrote: > Only kswapd can have non-zero nr_immediate, and current_may_throttle() is > always true for kswapd (PF_LESS_THROTTLE bit is never set) thus it's > enough to check stat.nr_immediate only. > > Signed-off-by: Andrey Ryabinin

Re: [PATCH v2 2/4] mm/vmscan: remove redundant current_may_throttle() check

On Fri, Mar 23, 2018 at 06:20:27PM +0300, Andrey Ryabinin wrote: > Only kswapd can have non-zero nr_immediate, and current_may_throttle() is > always true for kswapd (PF_LESS_THROTTLE bit is never set) thus it's > enough to check stat.nr_immediate only. > > Signed-off-by: Andrey Ryabinin >

Re: [PATCH v3 04/13] ARM: dts: ipq4019: Update ipq4019-dk01.1 board data

On 2018-04-06 20:43, Richard Cochran wrote: On Fri, Apr 06, 2018 at 06:35:49PM +0530, sricha...@codeaurora.org wrote: I tried booting mainline built with qcom_defconfig on ap148 and did boot. Not sure if your bootloader's bootarg is this, 'console=ttyMSM0,115200n8' ? Yes, I think so.

Re: [PATCH v3 04/13] ARM: dts: ipq4019: Update ipq4019-dk01.1 board data

On 2018-04-06 20:43, Richard Cochran wrote: On Fri, Apr 06, 2018 at 06:35:49PM +0530, sricha...@codeaurora.org wrote: I tried booting mainline built with qcom_defconfig on ap148 and did boot. Not sure if your bootloader's bootarg is this, 'console=ttyMSM0,115200n8' ? Yes, I think so.

Re: [PATCH net-next] netns: filter uevents correctly

On Fri, Apr 06, 2018 at 09:45:41AM -0500, Eric W. Biederman wrote: > Christian Brauner writes: > > > On Thu, Apr 05, 2018 at 10:59:49PM -0500, Eric W. Biederman wrote: > >> Christian Brauner writes: > >> > >> > On Thu, Apr 05,

Re: [PATCH net-next] netns: filter uevents correctly

On Fri, Apr 06, 2018 at 09:45:41AM -0500, Eric W. Biederman wrote: > Christian Brauner writes: > > > On Thu, Apr 05, 2018 at 10:59:49PM -0500, Eric W. Biederman wrote: > >> Christian Brauner writes: > >> > >> > On Thu, Apr 05, 2018 at 05:26:59PM +0300, Kirill Tkhai wrote: > >> >> On 05.04.2018

Re: [PATCH] soc: bcm: raspberrypi-power: Fix use of __packed

On Sun, 1 Apr 2018 09:42:25 -0700, Florian Fainelli wrote: > Commit a09cd356586d ("ARM: bcm2835: add rpi power domain driver") > attempted to annotate the structure rpi_power_domain_packet with > __packed but introduced a typo and made it named __packet instead. Just >

Re: [PATCH v2 1/4] mm/vmscan: Update stale comments

On Fri, Mar 23, 2018 at 06:20:26PM +0300, Andrey Ryabinin wrote: > Update some comments that become stale since transiton from per-zone > to per-node reclaim. > > Signed-off-by: Andrey Ryabinin > Acked-by: Michal Hocko Acked-by: Johannes Weiner

Re: [PATCH] soc: bcm: raspberrypi-power: Fix use of __packed

On Sun, 1 Apr 2018 09:42:25 -0700, Florian Fainelli wrote: > Commit a09cd356586d ("ARM: bcm2835: add rpi power domain driver") > attempted to annotate the structure rpi_power_domain_packet with > __packed but introduced a typo and made it named __packet instead. Just > drop the annotation since

Re: [PATCH v2 1/4] mm/vmscan: Update stale comments

On Fri, Mar 23, 2018 at 06:20:26PM +0300, Andrey Ryabinin wrote: > Update some comments that become stale since transiton from per-zone > to per-node reclaim. > > Signed-off-by: Andrey Ryabinin > Acked-by: Michal Hocko Acked-by: Johannes Weiner

Re: [PATCH] tpm: st33zp24: check if chip is null before dereferencing

On Fri, Apr 06, 2018 at 05:05:41PM +0100, Colin King wrote: > From: Colin Ian King > > Currently chip is being dereferenced by the call to dev_get_drvdata > before it is being null checked, hence we have a potential null > pointer dereference bug. Fix this by only

Re: [PATCH] tpm: st33zp24: check if chip is null before dereferencing

On Fri, Apr 06, 2018 at 05:05:41PM +0100, Colin King wrote: > From: Colin Ian King > > Currently chip is being dereferenced by the call to dev_get_drvdata > before it is being null checked, hence we have a potential null > pointer dereference bug. Fix this by only dereferencing it after the >

[GIT PULL] Please pull RDMA subsystem changes

Hi Linus, Here are the RDMA patches for for 4.17. This cycle we have some interesting conflicts, a syzkaller related bug fix in rc clashed very badly with the Mellanox shared pull request. Doug made the resolution in the RDMA tree for-next tree and DaveM refered to it when he pulled in the same

[GIT PULL] Please pull RDMA subsystem changes

Hi Linus, Here are the RDMA patches for for 4.17. This cycle we have some interesting conflicts, a syzkaller related bug fix in rc clashed very badly with the Mellanox shared pull request. Doug made the resolution in the RDMA tree for-next tree and DaveM refered to it when he pulled in the same

Re: [PATCH v3] staging: greybus: Fix warning to limit chars per line

On Fri, Apr 06, 2018 at 04:39:22PM +0530, Gaurav Dhingra wrote: > Wrap comment to fix warning "prefer a maximum 75 chars per line" > > Signed-off-by: Gaurav Dhingra > --- > Changes in v2: > - use correct format for multiline comment > Changes in v3: > -

Re: [PATCH v3] staging: greybus: Fix warning to limit chars per line

On Fri, Apr 06, 2018 at 04:39:22PM +0530, Gaurav Dhingra wrote: > Wrap comment to fix warning "prefer a maximum 75 chars per line" > > Signed-off-by: Gaurav Dhingra > --- > Changes in v2: > - use correct format for multiline comment > Changes in v3: > - include commit log > --- >

[PATCH] tpm: st33zp24: check if chip is null before dereferencing

From: Colin Ian King Currently chip is being dereferenced by the call to dev_get_drvdata before it is being null checked, hence we have a potential null pointer dereference bug. Fix this by only dereferencing it after the null check. Detected by CoverityScan,

[PATCH] tpm: st33zp24: check if chip is null before dereferencing

From: Colin Ian King Currently chip is being dereferenced by the call to dev_get_drvdata before it is being null checked, hence we have a potential null pointer dereference bug. Fix this by only dereferencing it after the null check. Detected by CoverityScan, CID#1357806 ("Dereference before

Re: Problem with commit 31e77c93e432 "sched/fair: Update blocked load when newly idle"

Hi Heiner, On 30 March 2018 at 10:37, Heiner Kallweit wrote: > Am 30.03.2018 um 08:50 schrieb Vincent Guittot: >> On 29 March 2018 at 19:40, Heiner Kallweit wrote: >>> Am 29.03.2018 um 09:41 schrieb Vincent Guittot: >> I'm finally not so

Re: Problem with commit 31e77c93e432 "sched/fair: Update blocked load when newly idle"

Hi Heiner, On 30 March 2018 at 10:37, Heiner Kallweit wrote: > Am 30.03.2018 um 08:50 schrieb Vincent Guittot: >> On 29 March 2018 at 19:40, Heiner Kallweit wrote: >>> Am 29.03.2018 um 09:41 schrieb Vincent Guittot: >> I'm finally not so sure that i have the right set up to reproduce

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

On Fri, Apr 06, 2018 at 10:52:17AM +0530, Viresh Kumar wrote: > On Fri, Apr 6, 2018 at 3:49 AM, Mark Greer wrote: > > On Wed, Apr 04, 2018 at 12:02:46AM +0530, Gaurav Dhingra wrote: > >> Wrap comment to fix warning "prefer a maximum 75 chars per line" > >> > >>

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

On Fri, Apr 06, 2018 at 10:52:17AM +0530, Viresh Kumar wrote: > On Fri, Apr 6, 2018 at 3:49 AM, Mark Greer wrote: > > On Wed, Apr 04, 2018 at 12:02:46AM +0530, Gaurav Dhingra wrote: > >> Wrap comment to fix warning "prefer a maximum 75 chars per line" > >> > >> Signed-off-by: Gaurav Dhingra > >>

Re: INFO: task hung in lo_ioctl

On Fri, Apr 06, 2018 at 05:43:43PM +0200, Peter Zijlstra wrote: > On Fri, Apr 06, 2018 at 10:55:03PM +0900, Tetsuo Handa wrote: > > Peter Zijlstra wrote: > > > On Fri, Apr 06, 2018 at 09:04:18PM +0900, Tetsuo Handa wrote: > > > > + /* Temporary hack for handling lock imbalance. */ > > > > +

Re: INFO: task hung in lo_ioctl

On Fri, Apr 06, 2018 at 05:43:43PM +0200, Peter Zijlstra wrote: > On Fri, Apr 06, 2018 at 10:55:03PM +0900, Tetsuo Handa wrote: > > Peter Zijlstra wrote: > > > On Fri, Apr 06, 2018 at 09:04:18PM +0900, Tetsuo Handa wrote: > > > > + /* Temporary hack for handling lock imbalance. */ > > > > +

Re: [4.9, 137/145] spi: bcm-qspi: shut up warning about cfi header inclusion

On 04/06/2018 12:22 AM, Arnd Bergmann wrote: > On Fri, Apr 6, 2018 at 9:09 AM, gre...@linuxfoundation.org > wrote: >> On Tue, Apr 03, 2018 at 10:46:07AM -0700, Florian Fainelli wrote: >>> On 02/23/2018 10:27 AM, gre...@linuxfoundation.org wrote: 4.9-stable

Re: [4.9, 137/145] spi: bcm-qspi: shut up warning about cfi header inclusion

On 04/06/2018 12:22 AM, Arnd Bergmann wrote: > On Fri, Apr 6, 2018 at 9:09 AM, gre...@linuxfoundation.org > wrote: >> On Tue, Apr 03, 2018 at 10:46:07AM -0700, Florian Fainelli wrote: >>> On 02/23/2018 10:27 AM, gre...@linuxfoundation.org wrote: 4.9-stable review patch. If anyone has any

Re: [PATCH v3 0/4] backlight: pwm_bl: support linear interpolation and brightness to human eye

On Tue, Mar 20, 2018 at 01:13:20PM +0100, Enric Balletbo Serra wrote: > Hi Daniel, > > > 2018-03-20 12:22 GMT+01:00 Daniel Thompson : > > On Mon, Mar 19, 2018 at 05:04:31PM +0100, Enric Balletbo Serra wrote: > >> Hi Daniel, > >> > >> Gentle ping for this series, there

Re: [PATCH v3 3/6] spi: sun6i: restrict transfer length in PIO-mode

On 04/06/2018 10:34 AM, Maxime Ripard wrote: On Thu, Apr 05, 2018 at 04:44:16PM +0300, Sergey Suloev wrote: On 04/05/2018 04:17 PM, Mark Brown wrote: On Thu, Apr 05, 2018 at 12:59:35PM +0300, Sergey Suloev wrote: On 04/05/2018 12:19 PM, Maxime Ripard wrote: The point of that patch was

Re: [PATCH v3 0/4] backlight: pwm_bl: support linear interpolation and brightness to human eye

On Tue, Mar 20, 2018 at 01:13:20PM +0100, Enric Balletbo Serra wrote: > Hi Daniel, > > > 2018-03-20 12:22 GMT+01:00 Daniel Thompson : > > On Mon, Mar 19, 2018 at 05:04:31PM +0100, Enric Balletbo Serra wrote: > >> Hi Daniel, > >> > >> Gentle ping for this series, there is any possibility you have

Re: [PATCH v3 3/6] spi: sun6i: restrict transfer length in PIO-mode

On 04/06/2018 10:34 AM, Maxime Ripard wrote: On Thu, Apr 05, 2018 at 04:44:16PM +0300, Sergey Suloev wrote: On 04/05/2018 04:17 PM, Mark Brown wrote: On Thu, Apr 05, 2018 at 12:59:35PM +0300, Sergey Suloev wrote: On 04/05/2018 12:19 PM, Maxime Ripard wrote: The point of that patch was

Re: INFO: task hung in __blkdev_get

On 4/6/18 4:12 AM, Tetsuo Handa wrote: > > > The reason of q->mq_freeze_depth == 1 turned out that loop_set_status() > forgot to call blk_mq_unfreeze_queue() at error paths for > info->lo_encrypt_type != NULL case. Thanks for finding this, applied. --

Re: INFO: task hung in __blkdev_get

On 4/6/18 4:12 AM, Tetsuo Handa wrote: > > > The reason of q->mq_freeze_depth == 1 turned out that loop_set_status() > forgot to call blk_mq_unfreeze_queue() at error paths for > info->lo_encrypt_type != NULL case. Thanks for finding this, applied. --

<    1   2   3   4   5   6   7   8   9   10   >