Re: [PATCH 06/10] Generic radix trees

2018-05-18 Thread Kent Overstreet
On Fri, May 18, 2018 at 09:02:03AM -0700, Christoph Hellwig wrote: > Completely lacks any explanation, including why this should be > in lib/. Also should come in the same series with actual users > of the infrastructure. Also in the cover letter... * Generic radix trees This is a very

Re: [PATCH 06/10] Generic radix trees

2018-05-18 Thread Kent Overstreet
On Fri, May 18, 2018 at 09:02:03AM -0700, Christoph Hellwig wrote: > Completely lacks any explanation, including why this should be > in lib/. Also should come in the same series with actual users > of the infrastructure. Also in the cover letter... * Generic radix trees This is a very

Re: [PATCH] PM / devfreq: Remove redundant frequency adjustment from governors

2018-05-18 Thread Matthias Kaehlcke
On Fri, May 18, 2018 at 08:15:55AM +0900, Chanwoo Choi wrote: > Hi, > > On 2018년 05월 18일 00:47, Matthias Kaehlcke wrote: > > Hi, > > > > On Thu, May 17, 2018 at 10:44:08AM +0900, Chanwoo Choi wrote: > >> Hi, > >> > >> On 2018년 05월 17일 06:10, Matthias Kaehlcke wrote: > >>> The performance,

Re: [PATCH] PM / devfreq: Remove redundant frequency adjustment from governors

2018-05-18 Thread Matthias Kaehlcke
On Fri, May 18, 2018 at 08:15:55AM +0900, Chanwoo Choi wrote: > Hi, > > On 2018년 05월 18일 00:47, Matthias Kaehlcke wrote: > > Hi, > > > > On Thu, May 17, 2018 at 10:44:08AM +0900, Chanwoo Choi wrote: > >> Hi, > >> > >> On 2018년 05월 17일 06:10, Matthias Kaehlcke wrote: > >>> The performance,

Re: [PATCH 10/10] Dynamic fault injection

2018-05-18 Thread Kent Overstreet
On Fri, May 18, 2018 at 09:02:45AM -0700, Christoph Hellwig wrote: > On Fri, May 18, 2018 at 03:49:18AM -0400, Kent Overstreet wrote: > > Signed-off-by: Kent Overstreet > > Completely lacks any explanation or argument why it would be useful. It's in the cover

Re: [PATCH 10/10] Dynamic fault injection

2018-05-18 Thread Kent Overstreet
On Fri, May 18, 2018 at 09:02:45AM -0700, Christoph Hellwig wrote: > On Fri, May 18, 2018 at 03:49:18AM -0400, Kent Overstreet wrote: > > Signed-off-by: Kent Overstreet > > Completely lacks any explanation or argument why it would be useful. It's in the cover letter... * Dynamic fault

Re: [PATCH 02/10] block: Convert bio_set to mempool_init()

2018-05-18 Thread Kent Overstreet
On Fri, May 18, 2018 at 09:20:28AM -0700, Christoph Hellwig wrote: > On Tue, May 08, 2018 at 09:33:50PM -0400, Kent Overstreet wrote: > > Minor performance improvement by getting rid of pointer indirections > > from allocation/freeing fastpaths. > > Can you please also send a long conversion for

Re: [PATCH 02/10] block: Convert bio_set to mempool_init()

2018-05-18 Thread Kent Overstreet
On Fri, May 18, 2018 at 09:20:28AM -0700, Christoph Hellwig wrote: > On Tue, May 08, 2018 at 09:33:50PM -0400, Kent Overstreet wrote: > > Minor performance improvement by getting rid of pointer indirections > > from allocation/freeing fastpaths. > > Can you please also send a long conversion for

Re: [PATCH v2] x86/asm: Pad assembly functions with INT3 instructions

2018-05-18 Thread Alexey Dobriyan
On Fri, May 18, 2018 at 08:02:24AM -0500, Josh Poimboeuf wrote: > On Fri, May 18, 2018 at 09:36:44AM +0200, Ingo Molnar wrote: > > > > * Alexey Dobriyan wrote: > > > > > Use INT3 instead of NOP. All that padding between functions is > > > an illegal area, no legitimate code

Re: [PATCH v2] x86/asm: Pad assembly functions with INT3 instructions

2018-05-18 Thread Alexey Dobriyan
On Fri, May 18, 2018 at 08:02:24AM -0500, Josh Poimboeuf wrote: > On Fri, May 18, 2018 at 09:36:44AM +0200, Ingo Molnar wrote: > > > > * Alexey Dobriyan wrote: > > > > > Use INT3 instead of NOP. All that padding between functions is > > > an illegal area, no legitimate code should jump into it.

Re: [PATCH] arm64: kvm: use -fno-jump-tables with clang

2018-05-18 Thread Marc Zyngier
On 18/05/18 18:02, Sami Tolvanen wrote: > Starting with LLVM r308050, clang generates a jump table with EL1 > virtual addresses in __init_stage2_translation, which results in a > kernel panic when booting at EL2: > > Kernel panic - not syncing: HYP panic: > PS:83c9 PC:089e6fd8

Re: [PATCH] arm64: kvm: use -fno-jump-tables with clang

2018-05-18 Thread Marc Zyngier
On 18/05/18 18:02, Sami Tolvanen wrote: > Starting with LLVM r308050, clang generates a jump table with EL1 > virtual addresses in __init_stage2_translation, which results in a > kernel panic when booting at EL2: > > Kernel panic - not syncing: HYP panic: > PS:83c9 PC:089e6fd8

Re: [PATCH v3] vfio/mdev: Check globally for duplicate devices

2018-05-18 Thread Alex Williamson
On Fri, 18 May 2018 12:34:03 +0530 Kirti Wankhede wrote: > On 5/18/2018 3:07 AM, Alex Williamson wrote: > > On Fri, 18 May 2018 01:56:50 +0530 > > Kirti Wankhede wrote: > > > >> On 5/17/2018 9:50 PM, Alex Williamson wrote: > >>> On Thu, 17 May

Re: [PATCH v3] vfio/mdev: Check globally for duplicate devices

2018-05-18 Thread Alex Williamson
On Fri, 18 May 2018 12:34:03 +0530 Kirti Wankhede wrote: > On 5/18/2018 3:07 AM, Alex Williamson wrote: > > On Fri, 18 May 2018 01:56:50 +0530 > > Kirti Wankhede wrote: > > > >> On 5/17/2018 9:50 PM, Alex Williamson wrote: > >>> On Thu, 17 May 2018 21:25:22 +0530 > >>> Kirti Wankhede

Re: [RFC PATCH net-next] tcp: tcp_rack_reo_wnd() can be static

2018-05-18 Thread David Miller
From: kbuild test robot Date: Fri, 18 May 2018 13:14:23 +0800 > Fixes: 20b654dfe1be ("tcp: support DUPACK threshold in RACK") > Signed-off-by: kbuild test robot Looks good, applied, thanks!

Re: [RFC PATCH net-next] tcp: tcp_rack_reo_wnd() can be static

2018-05-18 Thread David Miller
From: kbuild test robot Date: Fri, 18 May 2018 13:14:23 +0800 > Fixes: 20b654dfe1be ("tcp: support DUPACK threshold in RACK") > Signed-off-by: kbuild test robot Looks good, applied, thanks!

Re: [PATCH 02/20] dma-mapping: provide a generic dma-noncoherent implementation

2018-05-18 Thread Vineet Gupta
On 05/18/2018 06:23 AM, h...@lst.de wrote: Fri, May 18, 2018 at 01:03:46PM +, Alexey Brodkin wrote: Note mmc_get_dma_dir() is just "data->flags & MMC_DATA_WRITE ? DMA_TO_DEVICE : DMA_FROM_DEVICE". I.e. if we're preparing for sending data dma_noncoherent_map_sg() will have DMA_TO_DEVICE

Re: [PATCH 02/20] dma-mapping: provide a generic dma-noncoherent implementation

2018-05-18 Thread Vineet Gupta
On 05/18/2018 06:23 AM, h...@lst.de wrote: Fri, May 18, 2018 at 01:03:46PM +, Alexey Brodkin wrote: Note mmc_get_dma_dir() is just "data->flags & MMC_DATA_WRITE ? DMA_TO_DEVICE : DMA_FROM_DEVICE". I.e. if we're preparing for sending data dma_noncoherent_map_sg() will have DMA_TO_DEVICE

Re: [PATCH 2/6] x86: bug: prevent gcc distortions

2018-05-18 Thread Nadav Amit
Linus Torvalds wrote: > On Fri, May 18, 2018 at 12:59 AM Peter Zijlstra > wrote: > >> This is an awesome hack, but is there really nothing we can do to make >> it more readable? Esp, that global asm doing the macro definition is a >> pain to

Re: [PATCH 2/6] x86: bug: prevent gcc distortions

2018-05-18 Thread Nadav Amit
Linus Torvalds wrote: > On Fri, May 18, 2018 at 12:59 AM Peter Zijlstra > wrote: > >> This is an awesome hack, but is there really nothing we can do to make >> it more readable? Esp, that global asm doing the macro definition is a >> pain to read. > > I actually find that macro to be *more*

dma_sync_*_for_cpu and direction=TO_DEVICE (was Re: [PATCH 02/20] dma-mapping: provide a generic dma-noncoherent implementation)

2018-05-18 Thread Vineet Gupta
On 05/18/2018 06:11 AM, Alexey Brodkin wrote: void arch_sync_dma_for_device(struct device *dev, phys_addr_t paddr, size_t size, enum dma_data_direction dir) { + if (dir != DMA_TO_DEVICE){ + dump_stack(); + printk(" *** %s@%d: DMA direction

dma_sync_*_for_cpu and direction=TO_DEVICE (was Re: [PATCH 02/20] dma-mapping: provide a generic dma-noncoherent implementation)

2018-05-18 Thread Vineet Gupta
On 05/18/2018 06:11 AM, Alexey Brodkin wrote: void arch_sync_dma_for_device(struct device *dev, phys_addr_t paddr, size_t size, enum dma_data_direction dir) { + if (dir != DMA_TO_DEVICE){ + dump_stack(); + printk(" *** %s@%d: DMA direction

Re: [PATCH] kvm: rename HINTS_DEDICATED to KVM_HINTS_REALTIME

2018-05-18 Thread Paolo Bonzini
On 18/05/2018 19:13, Eduardo Habkost wrote: >> As much as we'd like to be helpful and validate input, you need a real >> time host too. I'm not sure how we'd find out - I suggest we do not >> bother for now. > I'm worried that people will start enabling the flag in all kinds > of scenarios where

Re: [PATCH] kvm: rename HINTS_DEDICATED to KVM_HINTS_REALTIME

2018-05-18 Thread Paolo Bonzini
On 18/05/2018 19:13, Eduardo Habkost wrote: >> As much as we'd like to be helpful and validate input, you need a real >> time host too. I'm not sure how we'd find out - I suggest we do not >> bother for now. > I'm worried that people will start enabling the flag in all kinds > of scenarios where

Re: [PATCH] kvm: rename HINTS_DEDICATED to KVM_HINTS_REALTIME

2018-05-18 Thread Paolo Bonzini
On 18/05/2018 18:04, Eduardo Habkost wrote: >> Without mlock you should always use pv spinlocks. >> >> Otherwise you risk blocking on a lock taken by >> a VCPU that is in turn blocked on IO, where the IO >> is not completing because CPU is being used up >> spinning. > > So the stronger guarantee

Re: [PATCH] kvm: rename HINTS_DEDICATED to KVM_HINTS_REALTIME

2018-05-18 Thread Paolo Bonzini
On 18/05/2018 18:04, Eduardo Habkost wrote: >> Without mlock you should always use pv spinlocks. >> >> Otherwise you risk blocking on a lock taken by >> a VCPU that is in turn blocked on IO, where the IO >> is not completing because CPU is being used up >> spinning. > > So the stronger guarantee

Re: [PATCH v2 3/9] security: define security_kernel_read_blob() wrapper

2018-05-18 Thread James Morris
On Thu, 17 May 2018, Eric W. Biederman wrote: > Nacked-by: "Eric W. Biederman" > > Nack on this sharing nonsense. These two interfaces do not share any > code in their implementations other than the if statement to distinguish > between the two cases. Hmm, it's not even

Re: [PATCH v2 3/9] security: define security_kernel_read_blob() wrapper

2018-05-18 Thread James Morris
On Thu, 17 May 2018, Eric W. Biederman wrote: > Nacked-by: "Eric W. Biederman" > > Nack on this sharing nonsense. These two interfaces do not share any > code in their implementations other than the if statement to distinguish > between the two cases. Hmm, it's not even doing that. There's

Re: [PATCH] kvm: rename HINTS_DEDICATED to KVM_HINTS_REALTIME

2018-05-18 Thread Eduardo Habkost
On Fri, May 18, 2018 at 08:01:49PM +0300, Michael S. Tsirkin wrote: > On Fri, May 18, 2018 at 01:04:31PM -0300, Eduardo Habkost wrote: > > CCing qemu-devel, as I'm now discussing userspace. > > > > On Thu, May 17, 2018 at 10:55:33PM +0300, Michael S. Tsirkin wrote: > > > On Thu, May 17, 2018 at

Re: [PATCH] kvm: rename HINTS_DEDICATED to KVM_HINTS_REALTIME

2018-05-18 Thread Eduardo Habkost
On Fri, May 18, 2018 at 08:01:49PM +0300, Michael S. Tsirkin wrote: > On Fri, May 18, 2018 at 01:04:31PM -0300, Eduardo Habkost wrote: > > CCing qemu-devel, as I'm now discussing userspace. > > > > On Thu, May 17, 2018 at 10:55:33PM +0300, Michael S. Tsirkin wrote: > > > On Thu, May 17, 2018 at

Re: WARNING in ip_recv_error

2018-05-18 Thread Willem de Bruijn
On Fri, May 18, 2018 at 11:44 AM, David Miller wrote: > From: Eric Dumazet > Date: Fri, 18 May 2018 08:30:43 -0700 > >> We probably need to revert Willem patch >> (7ce875e5ecb8562fd44040f69bda96c999e38bbc) > > Is it really valid to reach ip_recv_err

Re: WARNING in ip_recv_error

2018-05-18 Thread Willem de Bruijn
On Fri, May 18, 2018 at 11:44 AM, David Miller wrote: > From: Eric Dumazet > Date: Fri, 18 May 2018 08:30:43 -0700 > >> We probably need to revert Willem patch >> (7ce875e5ecb8562fd44040f69bda96c999e38bbc) > > Is it really valid to reach ip_recv_err with an ipv6 socket? I guess the issue is

Re: Should new code have forward declarations of static functions or not?

2018-05-18 Thread Christoph Hellwig
On Fri, May 18, 2018 at 12:44:31PM -0400, Simon Que wrote: > Is it preferred to have forward declarations of static funcs, or to omit > them altogether? There are cases where you need them. But in general if you do not absolutely need them try to avoid them.

Re: Should new code have forward declarations of static functions or not?

2018-05-18 Thread Christoph Hellwig
On Fri, May 18, 2018 at 12:44:31PM -0400, Simon Que wrote: > Is it preferred to have forward declarations of static funcs, or to omit > them altogether? There are cases where you need them. But in general if you do not absolutely need them try to avoid them.

Re: [PATCH] arm64: dts: specify 1.8V EMMC capabilities for bcm958742k

2018-05-18 Thread Florian Fainelli
On Fri, 18 May 2018 08:21:20 -0700, Scott Branden wrote: > Specify 1.8V EMMC capabilities for bcm958742k board to indicate support > for UHS mode. > > Fixes: d4b4aba6be8a ("arm64: dts: Initial DTS files for Broadcom Stingray > SOC") > Signed-off-by: Scott Branden

Re: [PATCH] arm64: dts: specify 1.8V EMMC capabilities for bcm958742k

2018-05-18 Thread Florian Fainelli
On Fri, 18 May 2018 08:21:20 -0700, Scott Branden wrote: > Specify 1.8V EMMC capabilities for bcm958742k board to indicate support > for UHS mode. > > Fixes: d4b4aba6be8a ("arm64: dts: Initial DTS files for Broadcom Stingray > SOC") > Signed-off-by: Scott Branden > --- Applied to

[PATCH] arm64: kvm: use -fno-jump-tables with clang

2018-05-18 Thread Sami Tolvanen
Starting with LLVM r308050, clang generates a jump table with EL1 virtual addresses in __init_stage2_translation, which results in a kernel panic when booting at EL2: Kernel panic - not syncing: HYP panic: PS:83c9 PC:089e6fd8 ESR:8604 FAR:089e6fd8

[PATCH] arm64: kvm: use -fno-jump-tables with clang

2018-05-18 Thread Sami Tolvanen
Starting with LLVM r308050, clang generates a jump table with EL1 virtual addresses in __init_stage2_translation, which results in a kernel panic when booting at EL2: Kernel panic - not syncing: HYP panic: PS:83c9 PC:089e6fd8 ESR:8604 FAR:089e6fd8

Re: [PATCH] audit: add containerid support for IMA-audit

2018-05-18 Thread Richard Guy Briggs
On 2018-05-18 12:49, Stefan Berger wrote: > On 05/18/2018 11:45 AM, Richard Guy Briggs wrote: > > On 2018-05-18 07:49, Stefan Berger wrote: > > > On 05/17/2018 05:30 PM, Richard Guy Briggs wrote: > > > > On 2018-05-17 10:18, Stefan Berger wrote: > > > > > On 03/08/2018 06:21 AM, Richard Guy Briggs

Re: [PATCH] audit: add containerid support for IMA-audit

2018-05-18 Thread Richard Guy Briggs
On 2018-05-18 12:49, Stefan Berger wrote: > On 05/18/2018 11:45 AM, Richard Guy Briggs wrote: > > On 2018-05-18 07:49, Stefan Berger wrote: > > > On 05/17/2018 05:30 PM, Richard Guy Briggs wrote: > > > > On 2018-05-17 10:18, Stefan Berger wrote: > > > > > On 03/08/2018 06:21 AM, Richard Guy Briggs

Re: [PATCH] kvm: rename HINTS_DEDICATED to KVM_HINTS_REALTIME

2018-05-18 Thread Michael S. Tsirkin
On Fri, May 18, 2018 at 01:04:31PM -0300, Eduardo Habkost wrote: > CCing qemu-devel, as I'm now discussing userspace. > > On Thu, May 17, 2018 at 10:55:33PM +0300, Michael S. Tsirkin wrote: > > On Thu, May 17, 2018 at 03:46:58PM -0300, Eduardo Habkost wrote: > > > On Thu, May 17, 2018 at

Re: [PATCH] kvm: rename HINTS_DEDICATED to KVM_HINTS_REALTIME

2018-05-18 Thread Michael S. Tsirkin
On Fri, May 18, 2018 at 01:04:31PM -0300, Eduardo Habkost wrote: > CCing qemu-devel, as I'm now discussing userspace. > > On Thu, May 17, 2018 at 10:55:33PM +0300, Michael S. Tsirkin wrote: > > On Thu, May 17, 2018 at 03:46:58PM -0300, Eduardo Habkost wrote: > > > On Thu, May 17, 2018 at

Re: [PATCH] PM / devfreq: Add support for QCOM devfreq FW

2018-05-18 Thread kbuild test robot
-ci/linux/commits/Saravana-Kannan/PM-devfreq-Add-support-for-QCOM-devfreq-FW/20180518-230524 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O

Re: [PATCH] PM / devfreq: Add support for QCOM devfreq FW

2018-05-18 Thread kbuild test robot
-ci/linux/commits/Saravana-Kannan/PM-devfreq-Add-support-for-QCOM-devfreq-FW/20180518-230524 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O

Re: [PATCH] locking/rwsem: simplify the is-owner-spinnable checks

2018-05-18 Thread Waiman Long
On 05/18/2018 12:55 PM, Oleg Nesterov wrote: > Add the trivial owner_on_cpu() helper for rwsem_can_spin_on_owner() and > rwsem_spin_on_owner(), it also allows to make rwsem_can_spin_on_owner() > a bit more clear. > > Signed-off-by: Oleg Nesterov > --- >

Re: [PATCH] locking/rwsem: simplify the is-owner-spinnable checks

2018-05-18 Thread Waiman Long
On 05/18/2018 12:55 PM, Oleg Nesterov wrote: > Add the trivial owner_on_cpu() helper for rwsem_can_spin_on_owner() and > rwsem_spin_on_owner(), it also allows to make rwsem_can_spin_on_owner() > a bit more clear. > > Signed-off-by: Oleg Nesterov > --- > kernel/locking/rwsem-xadd.c | 25

Re: [PATCH 2/2] kselftests: ftrace: Add tests for the preemptoff and irqsoff tracers

2018-05-18 Thread Joel Fernandes
On Sat, May 19, 2018 at 12:32:41AM +0900, Masami Hiramatsu wrote: > Hi Joel, > > 55ty jmnOn Thu, 17 May 2018 18:54:21 -0700 > "Joel Fernandes (Google)" wrote: > > > Here we add unit tests for the preemptoff and irqsoff tracer by using a > > kernel module introduced

Re: [PATCH 2/2] kselftests: ftrace: Add tests for the preemptoff and irqsoff tracers

2018-05-18 Thread Joel Fernandes
On Sat, May 19, 2018 at 12:32:41AM +0900, Masami Hiramatsu wrote: > Hi Joel, > > 55ty jmnOn Thu, 17 May 2018 18:54:21 -0700 > "Joel Fernandes (Google)" wrote: > > > Here we add unit tests for the preemptoff and irqsoff tracer by using a > > kernel module introduced previously to trigger atomic

[PATCH v11 02/27] clk: davinci: da850-pll: change PLL0 to CLK_OF_DECLARE

2018-05-18 Thread David Lechner
PLL0 on davinci/da850-type device needs to be registered early in boot because it is needed for clocksource/clockevent. Change the driver to use CLK_OF_DECLARE for this special case. Reviewed-by: Sekhar Nori Signed-off-by: David Lechner --- v11 changes: -

[PATCH v11 03/27] clk: davinci: psc: allow for dev == NULL

2018-05-18 Thread David Lechner
On some davinci SoCs, we need to register the PSC clocks during early boot because they are needed for clocksource/clockevent. These changes allow for dev == NULL because in this case, we won't have a platform device for the clocks. Some function declarations are moved to a public header files so

[PATCH v11 02/27] clk: davinci: da850-pll: change PLL0 to CLK_OF_DECLARE

2018-05-18 Thread David Lechner
PLL0 on davinci/da850-type device needs to be registered early in boot because it is needed for clocksource/clockevent. Change the driver to use CLK_OF_DECLARE for this special case. Reviewed-by: Sekhar Nori Signed-off-by: David Lechner --- v11 changes: - none v10 changes: - removed duplicate

[PATCH v11 03/27] clk: davinci: psc: allow for dev == NULL

2018-05-18 Thread David Lechner
On some davinci SoCs, we need to register the PSC clocks during early boot because they are needed for clocksource/clockevent. These changes allow for dev == NULL because in this case, we won't have a platform device for the clocks. Some function declarations are moved to a public header files so

[PATCH v11 05/27] ARM: davinci: da830: add new clock init using common clock framework

2018-05-18 Thread David Lechner
This adds the new board-specific clock init in mach-davinci/da830.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Also clean up the #includes since we are adding some here. Reviewed-by: Sekhar Nori

[PATCH v11 05/27] ARM: davinci: da830: add new clock init using common clock framework

2018-05-18 Thread David Lechner
This adds the new board-specific clock init in mach-davinci/da830.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Also clean up the #includes since we are adding some here. Reviewed-by: Sekhar Nori

[PATCH v11 04/27] ARM: davinci: pass clock as parameter to davinci_timer_init()

2018-05-18 Thread David Lechner
This changes davinci_timer_init() so that we pass the clock as a parameter instead of using clk_get(). This is done in preparation for converting to the common clock framework. It removes the requirement that we have to have a clock with con_id of "timer0", which will be good for DT bindings

[PATCH v11 04/27] ARM: davinci: pass clock as parameter to davinci_timer_init()

2018-05-18 Thread David Lechner
This changes davinci_timer_init() so that we pass the clock as a parameter instead of using clk_get(). This is done in preparation for converting to the common clock framework. It removes the requirement that we have to have a clock with con_id of "timer0", which will be good for DT bindings

[PATCH v11 00/27] ARM: davinci: convert to common clock framework​

2018-05-18 Thread David Lechner
This series converts mach-davinci to use the common clock framework. The series works like this, the first 3 patches fix some issues with the clock drivers that have already been accepted into the mainline kernel. Then, starting with "ARM: davinci: pass clock as parameter to

[PATCH v11 00/27] ARM: davinci: convert to common clock framework​

2018-05-18 Thread David Lechner
This series converts mach-davinci to use the common clock framework. The series works like this, the first 3 patches fix some issues with the clock drivers that have already been accepted into the mainline kernel. Then, starting with "ARM: davinci: pass clock as parameter to

[PATCH v11 06/27] ARM: davinci: da850: add new clock init using common clock framework

2018-05-18 Thread David Lechner
This adds the new board-specific clock init in mach-davinci/da850.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Also clean up the #includes since we are adding some here. Some CFGCHIP macros were

[PATCH v11 06/27] ARM: davinci: da850: add new clock init using common clock framework

2018-05-18 Thread David Lechner
This adds the new board-specific clock init in mach-davinci/da850.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Also clean up the #includes since we are adding some here. Some CFGCHIP macros were

[PATCH v11 08/27] ARM: davinci: dm365: add new clock init using common clock framework

2018-05-18 Thread David Lechner
This adds the new board-specific clock init in mach-davinci/dm365.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Also clean up the #includes since we are adding some here. Signed-off-by: David Lechner

[PATCH v11 08/27] ARM: davinci: dm365: add new clock init using common clock framework

2018-05-18 Thread David Lechner
This adds the new board-specific clock init in mach-davinci/dm365.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Also clean up the #includes since we are adding some here. Signed-off-by: David Lechner

[PATCH v11 07/27] ARM: davinci: dm355: add new clock init using common clock framework

2018-05-18 Thread David Lechner
This adds the new board-specific clock init in mach-davinci/dm355.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Also clean up the #includes since we are adding some here. Signed-off-by: David Lechner

[PATCH v11 07/27] ARM: davinci: dm355: add new clock init using common clock framework

2018-05-18 Thread David Lechner
This adds the new board-specific clock init in mach-davinci/dm355.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Also clean up the #includes since we are adding some here. Signed-off-by: David Lechner

[PATCH v11 09/27] ARM: davinci: dm644x: add new clock init using common clock framework

2018-05-18 Thread David Lechner
This adds the new board-specific clock init in mach-davinci/dm644x.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Also clean up the #includes since we are adding some here. Signed-off-by: David Lechner

[PATCH v11 09/27] ARM: davinci: dm644x: add new clock init using common clock framework

2018-05-18 Thread David Lechner
This adds the new board-specific clock init in mach-davinci/dm644x.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Also clean up the #includes since we are adding some here. Signed-off-by: David Lechner

Re: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()

2018-05-18 Thread Linus Torvalds
On Fri, May 18, 2018 at 6:07 AM Roman Pen wrote: > Function is going to be used in transport over RDMA module > in subsequent patches. Does this really merit its own helper macro in a generic header? It honestly smells more like "just have an inline helper

Re: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()

2018-05-18 Thread Linus Torvalds
On Fri, May 18, 2018 at 6:07 AM Roman Pen wrote: > Function is going to be used in transport over RDMA module > in subsequent patches. Does this really merit its own helper macro in a generic header? It honestly smells more like "just have an inline helper function that is specific to rdma" to

Re: [PATCH 1/2] mfd: stm32-timers: fix pwm-stm32 linker issue with COMPILE_TEST

2018-05-18 Thread Randy Dunlap
On 05/18/2018 08:24 AM, Fabrice Gasnier wrote: > This is seen when COMPILE_TEST=y and MFD_STM32_TIMERS=n. > drivers/pwm/pwm-stm32.o: In function 'stm32_pwm_raw_capture': > pwm-stm32.c:... undefined reference to 'stm32_timers_dma_burst_read' > Fixes: 0c6609805b63 ("mfd: stm32-timers: Add support

Re: [PATCH 1/2] mfd: stm32-timers: fix pwm-stm32 linker issue with COMPILE_TEST

2018-05-18 Thread Randy Dunlap
On 05/18/2018 08:24 AM, Fabrice Gasnier wrote: > This is seen when COMPILE_TEST=y and MFD_STM32_TIMERS=n. > drivers/pwm/pwm-stm32.o: In function 'stm32_pwm_raw_capture': > pwm-stm32.c:... undefined reference to 'stm32_timers_dma_burst_read' > Fixes: 0c6609805b63 ("mfd: stm32-timers: Add support

[PATCH v11 16/27] ARM: davinci: da830: Remove legacy clock init

2018-05-18 Thread David Lechner
This removes the unused legacy clock init code from arch/arm/mach-davinci/da830.c. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori --- v11 changes: - none v10 changes: - none v9 changes: - rebased v8 changes: - none v7 changes: - rebased - add

[PATCH v11 16/27] ARM: davinci: da830: Remove legacy clock init

2018-05-18 Thread David Lechner
This removes the unused legacy clock init code from arch/arm/mach-davinci/da830.c. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori --- v11 changes: - none v10 changes: - none v9 changes: - rebased v8 changes: - none v7 changes: - rebased - add davinci prefix to commit message v6

Re: [PATCH 2/2] pwm: stm32: initialize raw local variables

2018-05-18 Thread Randy Dunlap
On 05/18/2018 08:24 AM, Fabrice Gasnier wrote: > This removes build warning when COMPILE_TEST=y and MFD_STM32_TIMERS=n > in drivers/pwm/pwm-stm32.c. In function 'stm32_pwm_capture' 'raw_prd' and > 'raw_dty' may be used uninitialized in this function > [-Wmaybe-uninitialized] > > Signed-off-by:

Re: [PATCH 2/2] pwm: stm32: initialize raw local variables

2018-05-18 Thread Randy Dunlap
On 05/18/2018 08:24 AM, Fabrice Gasnier wrote: > This removes build warning when COMPILE_TEST=y and MFD_STM32_TIMERS=n > in drivers/pwm/pwm-stm32.c. In function 'stm32_pwm_capture' 'raw_prd' and > 'raw_dty' may be used uninitialized in this function > [-Wmaybe-uninitialized] > > Signed-off-by:

[PATCH] locking/rwsem: simplify the is-owner-spinnable checks

2018-05-18 Thread Oleg Nesterov
Add the trivial owner_on_cpu() helper for rwsem_can_spin_on_owner() and rwsem_spin_on_owner(), it also allows to make rwsem_can_spin_on_owner() a bit more clear. Signed-off-by: Oleg Nesterov --- kernel/locking/rwsem-xadd.c | 25 + 1 file changed, 13

[PATCH v11 15/27] ARM: davinci: switch to common clock framework

2018-05-18 Thread David Lechner
This switches ARCH_DAVINCI to use the common clock framework. The legacy clock code in arch/arm/mach-davinci/ is no longer used. New drivers in drivers/clk/davinci/ are used instead. A few macros had to be moved to prevent compilation errors. Signed-off-by: David Lechner

[PATCH] locking/rwsem: simplify the is-owner-spinnable checks

2018-05-18 Thread Oleg Nesterov
Add the trivial owner_on_cpu() helper for rwsem_can_spin_on_owner() and rwsem_spin_on_owner(), it also allows to make rwsem_can_spin_on_owner() a bit more clear. Signed-off-by: Oleg Nesterov --- kernel/locking/rwsem-xadd.c | 25 + 1 file changed, 13 insertions(+), 12

[PATCH v11 15/27] ARM: davinci: switch to common clock framework

2018-05-18 Thread David Lechner
This switches ARCH_DAVINCI to use the common clock framework. The legacy clock code in arch/arm/mach-davinci/ is no longer used. New drivers in drivers/clk/davinci/ are used instead. A few macros had to be moved to prevent compilation errors. Signed-off-by: David Lechner --- v11 changes: -

[PATCH v11 12/27] ARM: davinci: da8xx: add new sata_refclk init using common clock framework

2018-05-18 Thread David Lechner
This adds the new SATA REFCLK clock init in mach-davinci/devices-da8xx.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Also, the #includes are sorted since we are adding some here. Signed-off-by: David

[PATCH v11 11/27] ARM: davinci: da8xx: add new USB PHY clock init using common clock framework

2018-05-18 Thread David Lechner
This adds the new USB PHY clock init in mach-davinci/usb-da8xx.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Signed-off-by: David Lechner --- v11 changes: - none v10 changes: -

[PATCH v11 12/27] ARM: davinci: da8xx: add new sata_refclk init using common clock framework

2018-05-18 Thread David Lechner
This adds the new SATA REFCLK clock init in mach-davinci/devices-da8xx.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Also, the #includes are sorted since we are adding some here. Signed-off-by: David

[PATCH v11 11/27] ARM: davinci: da8xx: add new USB PHY clock init using common clock framework

2018-05-18 Thread David Lechner
This adds the new USB PHY clock init in mach-davinci/usb-da8xx.c using the new common clock framework drivers. The #ifdefs are needed to prevent compile errors until the entire ARCH_DAVINCI is converted. Signed-off-by: David Lechner --- v11 changes: - none v10 changes: - none v9 changes: -

[PATCH v11 13/27] ARM: davinci: remove CONFIG_DAVINCI_RESET_CLOCKS

2018-05-18 Thread David Lechner
The common clock framework will take care of disabling unused clocks when we switch from the legacy davinci clocks and having this enabled will cause compile errors after we switch, so remove it now. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori ---

[PATCH v11 14/27] ARM: davinci_all_defconfig: remove CONFIG_DAVINCI_RESET_CLOCKS

2018-05-18 Thread David Lechner
This removes CONFIG_DAVINCI_RESET_CLOCKS. The option has been removed from the kernel. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori --- v11 changes: - none v10 changes: - none v9 changes: - none v8 changes: - none v7 changes: - none v6

[PATCH v11 13/27] ARM: davinci: remove CONFIG_DAVINCI_RESET_CLOCKS

2018-05-18 Thread David Lechner
The common clock framework will take care of disabling unused clocks when we switch from the legacy davinci clocks and having this enabled will cause compile errors after we switch, so remove it now. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori --- v11 changes: - none v10 changes: -

[PATCH v11 14/27] ARM: davinci_all_defconfig: remove CONFIG_DAVINCI_RESET_CLOCKS

2018-05-18 Thread David Lechner
This removes CONFIG_DAVINCI_RESET_CLOCKS. The option has been removed from the kernel. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori --- v11 changes: - none v10 changes: - none v9 changes: - none v8 changes: - none v7 changes: - none v6 changes: - none

[PATCH v11 19/27] ARM: davinci: dm365: Remove legacy clock init

2018-05-18 Thread David Lechner
This removes the unused legacy clock init code from arch/arm/mach-davinci/dm365.c. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori --- v11 changes: - none v10 changes: - none v9 changes: - rebased v8 changes: - none v7 changes: - rebased - add

[PATCH v11 19/27] ARM: davinci: dm365: Remove legacy clock init

2018-05-18 Thread David Lechner
This removes the unused legacy clock init code from arch/arm/mach-davinci/dm365.c. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori --- v11 changes: - none v10 changes: - none v9 changes: - rebased v8 changes: - none v7 changes: - rebased - add davinci prefix to commit message v6

Re: [RFC PATCH 07/11] ext4: have sync_fs op report writeback errors when passed a since pointer

2018-05-18 Thread Jeff Layton
On Fri, 2018-05-18 at 08:22 -0700, Matthew Wilcox wrote: > On Fri, May 18, 2018 at 08:34:11AM -0400, Jeff Layton wrote: > > From: Jeff Layton > > > > When ext4_sync_fs gets a non-NULL since pointer, use it to report > > errors vs. the errseq_t in the super_block. This allows

Re: [PATCH v4 1/2] dt-bindings: input: Add Add Spreadtrum SC27xx vibrator documentation

2018-05-18 Thread Rob Herring
On Thu, May 10, 2018 at 01:08:33PM +0800, Baolin Wang wrote: > From: Xiaotong Lu > > This patch adds the binding documentation for Spreadtrum SC27xx series > vibrator device. > > Signed-off-by: Xiaotong Lu > Signed-off-by: Baolin Wang

Re: [RFC PATCH 07/11] ext4: have sync_fs op report writeback errors when passed a since pointer

2018-05-18 Thread Jeff Layton
On Fri, 2018-05-18 at 08:22 -0700, Matthew Wilcox wrote: > On Fri, May 18, 2018 at 08:34:11AM -0400, Jeff Layton wrote: > > From: Jeff Layton > > > > When ext4_sync_fs gets a non-NULL since pointer, use it to report > > errors vs. the errseq_t in the super_block. This allows us to > > properly

Re: [PATCH v4 1/2] dt-bindings: input: Add Add Spreadtrum SC27xx vibrator documentation

2018-05-18 Thread Rob Herring
On Thu, May 10, 2018 at 01:08:33PM +0800, Baolin Wang wrote: > From: Xiaotong Lu > > This patch adds the binding documentation for Spreadtrum SC27xx series > vibrator device. > > Signed-off-by: Xiaotong Lu > Signed-off-by: Baolin Wang > --- > Changes since v3: > - Change compatible string to

[PATCH v11 17/27] ARM: davinci: da850: Remove legacy clock init

2018-05-18 Thread David Lechner
This removes the unused legacy clock init code from arch/arm/mach-davinci/da850.c. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori --- v11 changes: - none v10 changes: - none v9 changes: - rebased v8 changes: - none v7 changes: - rebased - add

[PATCH v11 17/27] ARM: davinci: da850: Remove legacy clock init

2018-05-18 Thread David Lechner
This removes the unused legacy clock init code from arch/arm/mach-davinci/da850.c. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori --- v11 changes: - none v10 changes: - none v9 changes: - rebased v8 changes: - none v7 changes: - rebased - add davinci prefix to commit message v6

[PATCH v11 18/27] ARM: davinci: dm355: Remove legacy clock init

2018-05-18 Thread David Lechner
This removes the unused legacy clock init code from arch/arm/mach-davinci/dm355.c. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori --- v11 changes: - none v10 changes: - none v9 changes: - rebased v8 changes: - none v7 changes: - rebased - add

[PATCH v11 18/27] ARM: davinci: dm355: Remove legacy clock init

2018-05-18 Thread David Lechner
This removes the unused legacy clock init code from arch/arm/mach-davinci/dm355.c. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori --- v11 changes: - none v10 changes: - none v9 changes: - rebased v8 changes: - none v7 changes: - rebased - add davinci prefix to commit message v6

[PATCH v11 23/27] ARM: davinci: remove legacy clocks

2018-05-18 Thread David Lechner
This removes the unused legacy clock code from arch/arm/mach-davinci/. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori --- v11 changes: - none v10 changes: - none v9 changes: - none v8 changes: - none v7 changes: - rebased - add davinci prefix to

[PATCH v11 23/27] ARM: davinci: remove legacy clocks

2018-05-18 Thread David Lechner
This removes the unused legacy clock code from arch/arm/mach-davinci/. Signed-off-by: David Lechner Reviewed-by: Sekhar Nori --- v11 changes: - none v10 changes: - none v9 changes: - none v8 changes: - none v7 changes: - rebased - add davinci prefix to commit message v6 changes: - rebased

[PATCH v11 24/27] dt-bindings: timer: new bindings for TI DaVinci timer

2018-05-18 Thread David Lechner
This adds new device tree bindings for the timer IP block of TI DaVinci-like SoCs. Reviewed-by: Rob Herring Signed-off-by: David Lechner --- v11 changes: - remove trailing whitespace v10 changes: - changed compatible to "ti,da830-timer" - added

[PATCH v11 24/27] dt-bindings: timer: new bindings for TI DaVinci timer

2018-05-18 Thread David Lechner
This adds new device tree bindings for the timer IP block of TI DaVinci-like SoCs. Reviewed-by: Rob Herring Signed-off-by: David Lechner --- v11 changes: - remove trailing whitespace v10 changes: - changed compatible to "ti,da830-timer" - added interrupts and interrupt-names properties -

<    2   3   4   5   6   7   8   9   10   11   >