[PATCH v3] isdn: eicon: fix a missing-check bug

2018-05-20 Thread Wenwen Wang
In divasmain.c, the function divas_write() firstly invokes the function diva_xdi_open_adapter() to open the adapter that matches with the adapter number provided by the user, and then invokes the function diva_xdi_write() to perform the write operation using the matched adapter. The two functions d

Re: [next-20180517][ppc] watchdog: CPU 88 self-detected hard LOCKUP @ update_cfs_group+0x30/0x150

2018-05-20 Thread Nicholas Piggin
Ah, it's POWER8. I'm betting we have a bug with nohz timer offloading somewhere. I *think* we may have seen similar on P9 as well, but that may be related to problems with stop states. Can you reproduce it easily? I'm thinking maybe adding some tracepoints that track decrementer settings and int

Re: [PATCH v2] isdn: eicon: fix a missing-check bug

2018-05-20 Thread Wenwen Wang
On Sun, May 20, 2018 at 5:37 PM, David Miller wrote: > From: Wenwen Wang > Date: Fri, 18 May 2018 16:33:47 -0500 > >> In divasmain.c, the function divas_write() firstly invokes the function >> diva_xdi_open_adapter() to open the adapter that matches with the adapter >> number provided by the user

Re: [PATCH 5/6] mtd: rawnand: ams-delta: use GPIO lookup table

2018-05-20 Thread Andy Shevchenko
On Sun, May 20, 2018 at 8:25 PM, Miquel Raynal wrote: > On Sun, 20 May 2018 19:17:04 +0300, Andy Shevchenko > wrote: > Do we actually have the possibility to rename this gpio? I guess no > since it would break DT backward compatibility. No we don't. > Otherwise it would have > been more descri

Re: [PATCH v4 07/31] kconfig: add built-in function support

2018-05-20 Thread Masahiro Yamada
Hi Sam, 2018-05-21 15:16 GMT+09:00 Sam Ravnborg : > Hi Masahiro > >> >> + char *(*func)(int argc, char *argv[], int old_argc, char >> >> *old_argv[]); >> >> +}; >> > If a typedef was provided for the function then ... >> >> >> Yes, I can do this, >> but I may rather consider to simplify the

Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

2018-05-20 Thread Randy Dunlap
On 05/20/2018 09:58 PM, Masahiro Yamada wrote: > 2018-05-21 13:51 GMT+09:00 Randy Dunlap : >> On 05/20/2018 09:48 PM, Masahiro Yamada wrote: >>> 2018-05-21 8:41 GMT+09:00 Randy Dunlap : On 05/20/2018 01:16 AM, Masahiro Yamada wrote: > Building nconf requires ncurses, but its presence is no

Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-20 Thread Randy Dunlap
On 05/20/2018 10:48 PM, Joel Fernandes wrote: > --8<-- > > From 1c1f8ce04bca656a3c07e555048545d4a59e44cf Mon Sep 17 00:00:00 2001 > From: Joel Fernandes > Date: Sun, 20 May 2018 19:37:18 -0700 > Subject: [PATCH v3.5] rcu: Add comment documenting how rcu_seq_snap works > > rcu_se

Re: [PATCH] Revert "mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE"

2018-05-20 Thread Joonsoo Kim
On Sat, May 19, 2018 at 05:46:32PM +0300, Ville Syrjälä wrote: > On Fri, May 18, 2018 at 01:01:04PM +0900, Joonsoo Kim wrote: > > On Thu, May 17, 2018 at 10:53:32AM -0700, Laura Abbott wrote: > > > On 05/17/2018 10:08 AM, Michal Hocko wrote: > > > >On Thu 17-05-18 18:49:47, Michal Hocko wrote: > >

Re: [PATCH v4 07/31] kconfig: add built-in function support

2018-05-20 Thread Sam Ravnborg
Hi Masahiro > >> + char *(*func)(int argc, char *argv[], int old_argc, char > >> *old_argv[]); > >> +}; > > If a typedef was provided for the function then ... > > > Yes, I can do this, > but I may rather consider to simplify the code. Simplify is better. > > Will the following be equal:

[next-20180517][ppc] watchdog: CPU 88 self-detected hard LOCKUP @ update_cfs_group+0x30/0x150

2018-05-20 Thread Abdul Haleem
Greeting's Offlate we are seeing hard hard lockup trace messages on our powerpc bare-metal machine for both linux-next and mainline kernel Machine Type: Power 8 Bare-metal (minsky) kernel: 4.17.0-rc5-next-20180517 gcc: 4.8.5 config: attached test: the exact scenario which is triggering these trac

Re: WARNING in ext4_set_page_dirty

2018-05-20 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:771c577c23ba Linux 4.17-rc6 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=108c9f3780 kernel config: https://syzkaller.appspot.com/x/.config?x=982e2df1b9e60b02 dashboard link: https:

Re: [PATCH v2 0/2] Add support for QCOM cpufreq FW driver

2018-05-20 Thread Viresh Kumar
On 19-05-18, 23:04, Taniya Das wrote: > [v2] >* Address comments given in v0 series. That's not how you do it. You need to explain every change in enough detail here so that the reviewers don't need to go to their previous emails to see what changed. > [v1] > * Fixed compilation reporte

RE: [PATCH] kernfs: fix dentry unexpected skip

2018-05-20 Thread Hatayama, Daisuke
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Hatayama, Daisuke > Sent: Saturday, May 19, 2018 12:43 AM > To: 'gre...@linuxfoundation.org' > Cc: Okajima, Toshiyuki/岡嶋 寿行 ; > linux-kernel@vger.kernel.org; 'ebied.

Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-20 Thread Joel Fernandes
On Sun, May 20, 2018 at 09:50:25PM -0700, Randy Dunlap wrote: > On 05/20/2018 09:42 PM, Joel Fernandes wrote: > > rcu_seq_snap may be tricky to decipher. Lets document how it works with > > an example to make it easier. > > > > Signed-off-by: Joel Fernandes (Google) > > --- > > kernel/rcu/rcu.h

[PATCH RESEND] platform/chrome: cros_ec_lpc: Add support for newer Google devices using custom coreboot firmware or stock SeaBIOS.

2018-05-20 Thread Vittorio Gambaletta (VittGam)
Custom coreboot firmware does not contain "Google_*" as BIOS version string; also, booting through stock SeaBIOS will present an empty BIOS version string to Linux. So the generic match at the top would not work. A previous patch added the "GOOGLE" match for DMI system vendor, but newer machines s

Re: [PATCH v2 07/11] cpufreq: tegra20: Remove unnecessary parentheses

2018-05-20 Thread Viresh Kumar
On 18-05-18, 23:06, Dmitry Osipenko wrote: > Remove unnecessary parentheses as suggested by the checkpatch script. > > Signed-off-by: Dmitry Osipenko > --- > drivers/cpufreq/tegra20-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/tegra20-cpufre

Re: [Xen-devel][RFC 2/3] xen/grant-table: Extend API to work with DMA buffers

2018-05-20 Thread Oleksandr Andrushchenko
On 05/19/2018 01:19 AM, Boris Ostrovsky wrote: On 05/17/2018 04:26 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Signed-off-by: Oleksandr Andrushchenko --- drivers/xen/grant-table.c | 49 +++ include/xen/grant_table.h | 7 ++ 2 f

Re: [PATCH v2 03/11] cpufreq: tegra20: Clean up included headers

2018-05-20 Thread Viresh Kumar
On 18-05-18, 23:06, Dmitry Osipenko wrote: > Remove unused/unneeded headers and sort them in the alphabet order. > > Signed-off-by: Dmitry Osipenko > Acked-by: Thierry Reding > --- > drivers/cpufreq/tegra20-cpufreq.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff

Re: [Xen-devel] [RFC 1/3] xen/balloon: Allow allocating DMA buffers

2018-05-20 Thread Oleksandr Andrushchenko
On 05/19/2018 01:04 AM, Boris Ostrovsky wrote: On 05/17/2018 04:26 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko A commit message would be useful. Sure, v1 will have it Signed-off-by: Oleksandr Andrushchenko for (i = 0; i < nr_pages; i++) { - pag

Re: [PATCH v4 05/31] kconfig: remove string expansion for mainmenu after yyparse()

2018-05-20 Thread Masahiro Yamada
2018-05-20 23:39 GMT+09:00 Sam Ravnborg : >> @@ -544,10 +530,10 @@ void conf_parse(const char *name) >> if (!modules_sym) >> modules_sym = sym_find( "n" ); >> >> - tmp = rootmenu.prompt->text; >> - rootmenu.prompt->text = _(rootmenu.prompt->text); >> - rootmenu.prom

Re: [PATCH v4 07/31] kconfig: add built-in function support

2018-05-20 Thread Masahiro Yamada
Sam, 2018-05-20 23:50 GMT+09:00 Sam Ravnborg : > On Thu, May 17, 2018 at 03:16:46PM +0900, Masahiro Yamada wrote: >> This commit adds a new concept 'function' to do more text processing >> in Kconfig. >> >> A function call looks like this: >> >> $(function,arg1,arg2,arg3,...) >> >> This commit a

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

2018-05-20 Thread Viresh Kumar
On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > From: "Joel Fernandes (Google)" > > Currently there is a chance of a schedutil cpufreq update request to be > dropped if there is a pending update request. This pending request can > be delayed if there is a scheduling delay of the irq_work an

Re: [PATCH] cpufreq: Add Kryo CPU scaling driver

2018-05-20 Thread Viresh Kumar
More comments after Russell's reply. On 19-05-18, 14:35, Ilia Lin wrote: > +static int __init qcom_cpufreq_kryo_driver_init(void) > +{ > + struct device *cpu_dev_silver, *cpu_dev_gold; > + struct opp_table *opp_silver, *opp_gold; > + enum _msm8996_version msm8996_version; > + struc

Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

2018-05-20 Thread Masahiro Yamada
2018-05-21 13:51 GMT+09:00 Randy Dunlap : > On 05/20/2018 09:48 PM, Masahiro Yamada wrote: >> 2018-05-21 8:41 GMT+09:00 Randy Dunlap : >>> On 05/20/2018 01:16 AM, Masahiro Yamada wrote: Building nconf requires ncurses, but its presence is not checked. Check and configure necessary package

Re: [PATCH v2] gpu: drm: udl: Adding new typedef vm_fault_t

2018-05-20 Thread Souptick Joarder
On Thu, May 10, 2018 at 7:18 PM, Souptick Joarder wrote: > On Wed, Apr 25, 2018 at 10:29 AM, Souptick Joarder > wrote: >> Use new return type vm_fault_t for fault and huge_fault >> handler. For now, this is just documenting that the >> function returns a VM_FAULT value rather than an errno. >> O

Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

2018-05-20 Thread Randy Dunlap
On 05/20/2018 09:48 PM, Masahiro Yamada wrote: > 2018-05-21 8:41 GMT+09:00 Randy Dunlap : >> On 05/20/2018 01:16 AM, Masahiro Yamada wrote: >>> Building nconf requires ncurses, but its presence is not checked. >>> Check and configure necessary packages by a shell script like the >>> other GUI front

Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-20 Thread Randy Dunlap
On 05/20/2018 09:42 PM, Joel Fernandes wrote: > rcu_seq_snap may be tricky to decipher. Lets document how it works with > an example to make it easier. > > Signed-off-by: Joel Fernandes (Google) > --- > kernel/rcu/rcu.h | 33 - > 1 file changed, 32 insertions(+),

Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

2018-05-20 Thread Masahiro Yamada
2018-05-21 8:41 GMT+09:00 Randy Dunlap : > On 05/20/2018 01:16 AM, Masahiro Yamada wrote: >> Building nconf requires ncurses, but its presence is not checked. >> Check and configure necessary packages by a shell script like the >> other GUI frontends. >> >> Signed-off-by: Masahiro Yamada >> --- >>

Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-20 Thread Viresh Kumar
On 19-05-18, 14:45, ilia...@codeaurora.org wrote: > Hi Viresh, > > If I send patches in reply, it will produce new patches, instead of answers > in the thread. Please find below the file dump. There is one email from you which appears to be just fine and appears to be in reply to this thread only

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

2018-05-20 Thread Masahiro Yamada
Hi. 2018-05-21 0:46 GMT+09:00 Ulf Magnusson : > s/environments/environment variables/ Will fix. > >> +* They will be written out to include/config/auto.conf.cmd >> +*/ >> + env_add(name, value); >> + >> + return xstrdup(value); >> +} >> + >> +void env_write_dep(FI

[PATCH 07/30] staging: lustre: simplify capability dropping.

2018-05-20 Thread NeilBrown
Lustre has a 'squash credentials' concept similar to the "anon_uid" for nfsd. When accessing a file with squashed credentials, we need to also drop capabilities. Linux has cap_drop_fs_set() and cap_drop_nfsd_set(). Rather than taking a completely different approach, this patch changes lustre to u

Re: [PATCH v2 0/4] fixes, cleanups for rcu/dev

2018-05-20 Thread Joel Fernandes
On Sun, May 20, 2018 at 09:32:47PM -0700, Joel Fernandes wrote: > Hi Paul, > > Here are some patches reworked with a few comments on few of the patches > from previous series: https://lkml.org/lkml/2018/5/13/296 > > 4/4 is a new addition which fixes a potential issue. > > Let me know what you th

[PATCH v3 0/4] fixes, cleanups for rcu/dev

2018-05-20 Thread Joel Fernandes
Hi Paul, Here are some patches reworked with a few comments on few of the patches from previous series: https://lkml.org/lkml/2018/5/13/296 4/4 is a new addition which fixes a potential issue. Please disregard the v2, and consider this v3 instead, since that v2 was a pure patch generation mess.

[PATCH v3 3/4] rcu: Use better variable names in funnel locking loop

2018-05-20 Thread Joel Fernandes
The funnel locking loop in rcu_start_this_gp uses rcu_root as a temporary variable while walking the combining tree. This causes a tiresome exercise of a code reader reminding themselves that rcu_root may not be root. Lets just call it rnp, and rename other variables as well to be more appropriate.

[PATCH v3 2/4] rcu: Cleanup the variables used to request a new grace period

2018-05-20 Thread Joel Fernandes
The 'c' variable was used previously to store the grace period that is being requested. However it is not very meaningful since the gp_seq conversions. This patch replaces it with gp_seq_req indicating that this is the grace period that was requested. Also updating tracing with the new name. Previ

[PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-20 Thread Joel Fernandes
rcu_seq_snap may be tricky to decipher. Lets document how it works with an example to make it easier. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/rcu.h | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/rcu.h b/kernel/rcu/rc

[PATCH v3 4/4] rcu: Unlock non-start node only after accessing its gp_seq_needed

2018-05-20 Thread Joel Fernandes
We acquire gp_seq_needed locklessly. To be safe, lets do the unlocking after the access. Signed-off-by: Joel Fernandes --- kernel/rcu/tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 879c67a31116..efbd21b2a1a6 100644 --- a

[PATCH 26/30] staging: lustre: remove libcfs_all from ptlrpc

2018-05-20 Thread NeilBrown
Some files didn't need it at all, others just needed one or two includes. Signed-off-by: NeilBrown --- drivers/staging/lustre/lustre/ptlrpc/errno.c |1 - drivers/staging/lustre/lustre/ptlrpc/events.c |2 +- drivers/staging/lustre/lustre/ptlrpc/llog_client.c |2 -- drivers/

[PATCH 27/30] staging: lustre: remove libcfs_all.h from fid, fld, obdclass

2018-05-20 Thread NeilBrown
None of these files seem to nee libcfs_all.h Signed-off-by: NeilBrown --- drivers/staging/lustre/lustre/fid/fid_lib.c|1 - drivers/staging/lustre/lustre/fid/fid_request.c|1 - drivers/staging/lustre/lustre/fid/lproc_fid.c |1 - drivers/staging/lustre/lustre/fld/fld_c

[PATCH 30/30] staging: lustre: remove libcfs_all.h

2018-05-20 Thread NeilBrown
In the remaining files that include libcfs_all.h, replace it with other include files as necessary, then remove libcfs_all.h Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_all.h | 88 drivers/staging/lustre/lnet/libcfs/debug.c |5 + d

[PATCH 24/30] staging: lustre: remove libcfs_all.h from lustre/include/*.h

2018-05-20 Thread NeilBrown
Instead of the catch-all libcfs_all.h, just include the files actually needed in different places. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_crypto.h|3 +++ .../staging/lustre/lustre/include/lprocfs_status.h |2 +- drivers/staging/lustre/lustre/include/lu_ob

[PATCH 25/30] staging: lustre: remove libcfs_all.h from remaining .h files.

2018-05-20 Thread NeilBrown
Now no *.h files include libcfs_all.h - only *.c files. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_hash.h |3 +++ drivers/staging/lustre/lustre/fid/fid_internal.h |1 - drivers/staging/lustre/lustre/fld/fld_internal.h |1 - drivers/staging/lustre/lus

[PATCH 23/30] staging: lustre: remove libcfs_all.h from includes lustre/lnet

2018-05-20 Thread NeilBrown
Some of these include files didn't need to include libcfs_all.h. A couple did so replace with just the base include files needed. Signed-off-by: NeilBrown --- drivers/staging/lustre/lnet/libcfs/tracefile.h |8 +++- drivers/staging/lustre/lnet/selftest/conrpc.h |1 - drivers/stagi

[PATCH 29/30] staging: lustre: move all libcfs_all includes except in lustre/lnet/libcfs/

2018-05-20 Thread NeilBrown
Again, most of these are not needed. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_string.h|2 ++ drivers/staging/lustre/lnet/lnet/lib-socket.c |1 - drivers/staging/lustre/lnet/lnet/nidstrings.c |5 - drivers/staging/lustre/lnet/lnet/router_pr

[PATCH 28/30] staging: lustre: remove remaining libcfs_all.h includes from lustre/lustre

2018-05-20 Thread NeilBrown
Most of these aren't needed, a few can be simplified. Signed-off-by: NeilBrown --- .../staging/lustre/lustre/include/lustre_intent.h |2 ++ drivers/staging/lustre/lustre/ldlm/l_lock.c|1 - drivers/staging/lustre/lustre/ldlm/ldlm_extent.c |1 - drivers/staging/lustre/lustre

[PATCH 18/30] staging: lustre: replace memory_presure funcitons by standard interfaces.

2018-05-20 Thread NeilBrown
Use memalloc_noreclaim_save() and memalloc_noreclaim_restore(), and for testing, just directly test the flag in current->flags Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_prim.h | 31 .../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 11 ++

[PATCH 21/30] staging: lustre: don't include libcfs.h in lnet/lib-lnet.h

2018-05-20 Thread NeilBrown
We want to be more focused in what is included where. So we remove libcfs.h from where it isn't needed. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_debug.h |1 + .../lustre/include/linux/libcfs/libcfs_fail.h |3 +++ .../staging/lustre/include/linux/lnet/l

[PATCH 19/30] staging: lustre: discard libcfs_prim.h

2018-05-20 Thread NeilBrown
This file no longer contains enough content to justify a separate file. So merge with libcfs.h. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h | 12 - .../lustre/include/linux/libcfs/libcfs_prim.h | 51 2 files changed, 11 inser

[PATCH 22/30] staging: lustre: remove libcfs_all.h includes from lnet/klnd

2018-05-20 Thread NeilBrown
Other smaller include files are sufficient. Signed-off-by: NeilBrown --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h|1 - .../staging/lustre/lnet/klnds/socklnd/socklnd.h|1 - .../lustre/lnet/klnds/socklnd/socklnd_lib.c|1 + 3 files changed, 1 insertion(+), 2 delet

[PATCH 16/30] staging: lustre: move lnet_debug_log_upcall declaration to tracefile.h

2018-05-20 Thread NeilBrown
Both files that use this variable include tracefile.h, and it seems a more suitable home for the declaration. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |5 - drivers/staging/lustre/lnet/libcfs/tracefile.h |5 + 2 files changed, 5 insertio

[PATCH 17/30] staging: lustre: move RESV_PORT definitions to lnet/lib-lnet.h

2018-05-20 Thread NeilBrown
These are network related on only used in lnet, so move to lib-lnet.h Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |4 .../staging/lustre/include/linux/lnet/lib-lnet.h |4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH 15/30] staging: lustre: make lnet_debugfs_symlink_def local to libcfs/modules.c

2018-05-20 Thread NeilBrown
This type is only used in libcfs/module.c, so make it local to there. If any other module ever wanted to add its own symlinks, it would probably be easiest to export lnet_debugfs_root and just call debugfs_create_symlink as required. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/

[PATCH 20/30] staging: lustre: start moving includes out of libcfs.h

2018-05-20 Thread NeilBrown
Lots of places include libcfs.h, and it includes lots of other include files. Many of these aren't needed in many places. It is tidier and better documentation to just include what is needed. So remove all the includes from libcfs.h and create libcfs_all.h which contains them. Then change every

[PATCH 14/30] staging: lustre: clean up __LIBCFS_H macro

2018-05-20 Thread NeilBrown
There is some confusion with names here - make it all uniform. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs.h b/drivers/staging/lustre/

[PATCH 13/30] staging: lustre: replace libcfs_register_ioctl with a blocking notifier_chain

2018-05-20 Thread NeilBrown
libcfs allows other modules to register handlers for ioctls. The implementation it uses for this is nearly identical to a blocking notifier chain, so change to use that. The biggest difference is that the return value from notifier has a defined format, where libcfs_register_ioctl uses -EINVAL to

[PATCH 12/30] staging: lustre: discard cfs_block_sigsinv()

2018-05-20 Thread NeilBrown
cfs_block_sigsinv() and cfs_restore_sigs() are simple wrappers which save a couple of line of code and hurt readability for people not familiar with them. They aren't used often enough to be worthwhile, so discard them and open-code the functionality. The sigorsets() call isn't needed as or-ing wi

[PATCH 10/30] staging: lustre: discard CFS_TICK

2018-05-20 Thread NeilBrown
This undocumented macro seems to represent "a small amount of time". Sometimes it is used as-is, some times it is multiplied by 5 for no obvious reason. It does not appear that there is any connection between the different places it is used - they all just want a short period for different purposes

[PATCH 11/30] staging: lustre: move LERRCHKSUM() to libcfs_debug.h

2018-05-20 Thread NeilBrown
This macro is only used for debug messages, so use it to the debug code. Also improve the documentation slightly. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |7 --- .../lustre/include/linux/libcfs/libcfs_debug.h |7 +++ 2 files changed, 7

[PATCH 08/30] staging: lustre: discard cfs_cap_t, use kernel_cap_t

2018-05-20 Thread NeilBrown
lustre only sends 32bits of capabilities in on-the-wire RPC calls. It current strips off higher bits and uses a 32bit cfs_cap_t throughout. Though there is a small memory cost, it is cleaner to use kernel_cap_t throughout and only truncate when marshalling data for RPC calls. So this patch replace

[PATCH 09/30] staging: lustre: discard LOWEST_BIT_SET()

2018-05-20 Thread NeilBrown
This macro is only used once to test if a value is a power of two. So use is_power_of_2() instead and discard the macro. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |2 -- drivers/staging/lustre/lnet/lnet/lib-eq.c |2 +- 2 files changed, 1 in

[PATCH 06/30] staging: lustre: remove current_pid() and current_comm()

2018-05-20 Thread NeilBrown
Just use current->pid and current->comm directly, instead of having wrappers. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/curproc.h |4 drivers/staging/lustre/lnet/libcfs/debug.c |2 +- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c |2 +- .

[PATCH 03/30] staging: lustre: move files out of lustre/lnet/libcfs/linux/

2018-05-20 Thread NeilBrown
There is no longer any value in having this separate subdirectory, so promote the files in it. Also tidy the Makefile a little to use the common "*-obj-y" macro name. This will allow individual files to be conditionally compiled. Signed-off-by: NeilBrown --- drivers/staging/lustre/lnet/libcfs/M

[PATCH 05/30] staging: lustre: remove conditional compilation from libcfs_cpu.c

2018-05-20 Thread NeilBrown
libcfs_cpu.c manages CPU partitions. In the !CONFIG_SMP case, most of this disappears and 'static inline's from libcfs_cpu.h are used. However we still allocate a 'struct cfs_cpt_table' and keep some dummy data in it. This is a bit pointless. This patch removes all the !CONFIG_SMP code from libc

[PATCH 00/30] staging: lustre: tidy up - module init and includes

2018-05-20 Thread NeilBrown
This series addresses two particular issues, and includes a bunch of related tidy-ups as well. 1/ there were a few reports of lustre crashing because a char-special couldn't be registered. We fixed the char-special registration so it won't fail, but the crash it still bad. The root cause is th

[PATCH 04/30] staging: lustre: rename cfs_cpt_table to cfs_cpt_tab

2018-05-20 Thread NeilBrown
The variable "cfs_cpt_table" has the same name as the structure "struct cfs_cpt_table". This makes it hard to use #define to make one disappear on a uni-processor build, but keep the other. So rename the variable to cfs_cpt_tab. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs

[PATCH 02/30] staging: lustre: refactor libcfs initialization.

2018-05-20 Thread NeilBrown
Many lustre modules depend on libcfs having initialized properly, but do not explicit check that it did. When lustre is built as discrete modules, this does not cause a problem because if the libcfs module fails initialization, the other modules don't even get loaded. When lustre is compiled into

[PATCH 01/30] staging: lustre: osc: tidy up osc_init()

2018-05-20 Thread NeilBrown
A module_init() function that registers the services of the module should do that last, after all other initialization has succeeded. This patch moves the class_register_type() call to the end and ensures everything else that might have been set up, is cleaned up on error. Signed-off-by: NeilBrown

[PATCH v2 4/4] rcu: Use better variable names in funnel locking loop

2018-05-20 Thread Joel Fernandes
The funnel locking loop in rcu_start_this_gp uses rcu_root as a temporary variable while walking the combining tree. This causes a tiresome exercise of a code reader reminding themselves that rcu_root may not be root. Lets just call it rnp, and rename other variables as well to be more appropriate.

[PATCH v2 2/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-20 Thread Joel Fernandes
rcu_seq_snap may be tricky to decipher. Lets document how it works with an example to make it easier. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/rcu.h | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/rcu.h b/kernel/rcu/rc

[PATCH v2 1/4] rcu: Speed up calling of RCU tasks callbacks

2018-05-20 Thread Joel Fernandes
From: "Joel Fernandes (Google)" RCU tasks callbacks can take atleast 1 second before the callbacks are executed. This happens even if the hold-out tasks enter their quiescent states quickly. I noticed this when I was testing trampoline callback execution. To test the trampoline freeing, I wrote

[PATCH v2 0/4] fixes, cleanups for rcu/dev

2018-05-20 Thread Joel Fernandes
Hi Paul, Here are some patches reworked with a few comments on few of the patches from previous series: https://lkml.org/lkml/2018/5/13/296 4/4 is a new addition which fixes a potential issue. Let me know what you think, thanks! Joel Fernandes (4): rcu: Add comment documenting how rcu_seq_sna

Re: [PATCH] clk: aspeed: Add 24MHz fixed clock

2018-05-20 Thread Joel Stanley
On 18 May 2018 at 18:27, Lei YU wrote: > Add a 24MHz fixed clock. > This clock will be used for certain devices, e.g. pwm. > > Signed-off-by: Lei YU Reviewed-by: Joel Stanley Cheers, Joel > --- > drivers/clk/clk-aspeed.c | 9 - > include/dt-bindings/clock/aspeed-cloc

[PATCH v2 3/4] rcu: Cleanup the variables used to request a new grace period

2018-05-20 Thread Joel Fernandes
The 'c' variable was used previously to store the grace period that is being requested. However it is not very meaningful since the gp_seq conversions. This patch replaces it with gp_seq_req indicating that this is the grace period that was requested. Also updating tracing with the new name. Previ

Re: [BUG] 4.17-rcX delays during boot and memory mapping errors

2018-05-20 Thread Bob Tracy
On Fri, May 18, 2018 at 07:32:59PM -0500, Bob Tracy wrote: > Every one of the 4.17-rcX series has hung during boot at the point where > "acpid" starts up. Beginning with -rc5, the boot actually proceeds to > completion after an "uncomfortably" long delay. > > Attempting to run the X11 server resu

[REPOST PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS

2018-05-20 Thread Ian Kent
Setting AUTOFS_FS and AUTOFS4_FS to y or m results in a compile failure. It isn't possible to unset one if the other is set because it introduces a circular dependency. But adding "depends on AUTOFS_FS = n" will make autofs4 appear under the autofs entry which should call attention to it. It als

[PATCH 2/3] powerpc/sstep: Fix kernel crash if VSX is not present

2018-05-20 Thread Ravi Bangoria
emulate_step() is not checking runtime VSX feature flag before emulating an instruction. This is causing kernel crash when kernel is compiled with CONFIG_VSX=y but running on a machine where VSX is not supported or disabled. Ex, while running emulate_step tests on P6 machine: Oops: Exception in

[PATCH 1/3] powerpc/sstep: Introduce GETTYPE macro

2018-05-20 Thread Ravi Bangoria
Replace 'op->type & INSTR_TYPE_MASK' expression with GETTYPE(op->type) macro. Signed-off-by: Ravi Bangoria --- arch/powerpc/include/asm/sstep.h | 2 ++ arch/powerpc/kernel/align.c | 2 +- arch/powerpc/lib/sstep.c | 6 +++--- 3 files changed, 6 insertions(+), 4 deletions(-) diff --g

[PATCH 0/3] powerpc/sstep: Fix kernel crash if VSX is not present

2018-05-20 Thread Ravi Bangoria
This is a next version to RFC patch: https://lkml.org/lkml/2018/5/16/36 kbuild test robot reported the following build failure with RFC. error: unused variable 'type' [-Werror=unused-variable] int type; ^~~~ I've fixed it along with following changes. 1st patch introduces a n

[PATCH 3/3] powerpc/sstep: Fix emulate_step test if VSX not present

2018-05-20 Thread Ravi Bangoria
emulate_step() tests are failing if VSX is not supported or disabled. emulate_step_test: lxvd2x : FAIL emulate_step_test: stxvd2x: FAIL If !CPU_FTR_VSX, emulate_step() failure is expected and testcase should PASS with a valid justification. After patch: emulate_step_test: l

Re: [PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS

2018-05-20 Thread Ian Kent
On 21/05/18 10:08, Randy Dunlap wrote: > On 05/20/2018 06:04 PM, Ian Kent wrote: >> Setting AUTOFS_FS and AUTOFS4_FS to y or m results in a compile >> failure. >> >> It isn't possible to unset one if the other is set because it >> introduces a circular dependency. >> >> But adding "depends on AUTOF

Re: [PATCH 05/12] bcache: convert to bioset_init()/mempool_init()

2018-05-20 Thread Coly Li
On 2018/5/21 6:25 AM, Kent Overstreet wrote: > Signed-off-by: Kent Overstreet Hi Kent, This change looks good to me, Reviewed-by: Coly Li Thanks. Coly Li > --- > drivers/md/bcache/bcache.h | 10 +- > drivers/md/bcache/bset.c| 13 - > drivers/md/bcache/bset.h|

[PATCH net-next] net: ethernet: Sort Kconfig sourcing alphabetically

2018-05-20 Thread Florian Fainelli
A number of entries were not alphabetically sorted, remedy that. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/Kconfig | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig index 54d71e1c48d5..a

[PATCH net-next] net: phy: phylink: Don't release NULL GPIO

2018-05-20 Thread Florian Fainelli
If CONFIG_GPIOLIB is disabled, gpiod_put() becomes a stub that produces a warning, this helped identify that we could be attempting to release a NULL pl->link_gpio GPIO descriptor, so guard against that. Fixes: daab3349ad1a ("net: phy: phylink: Release link GPIO") Signed-off-by: Florian Fainelli

Re: [PATCH v2 3/7] memcg: use compound_order rather than hpage_nr_pages

2018-05-20 Thread TSUKADA Koutaro
On 2018/05/19 2:51, Punit Agrawal wrote: Punit Agrawal writes: Tsukada-san, I am not familiar with memcg so can't comment about whether the patchset is the right way to solve the problem outlined in the cover letter but had a couple of comments about this patch. TSUKADA Koutaro writes: Th

Re: [ANNOUNCE] Kconfiglib menuconfig implementation

2018-05-20 Thread Randy Dunlap
On 05/20/2018 08:33 PM, Ulf Magnusson wrote: > On Mon, May 21, 2018 at 4:45 AM, Randy Dunlap wrote: >> On 05/19/2018 09:47 PM, Ulf Magnusson wrote: >>> On Sun, May 20, 2018 at 6:03 AM, Randy Dunlap wrote: On 05/19/2018 08:45 PM, Randy Dunlap wrote: > On 05/08/2018 09:59 AM, Ulf Magnusson

Re: [PATCH 0/2] support kdump for AMD secure memory encryption(sme)

2018-05-20 Thread lijiang
在 2018年05月17日 21:45, lijiang 写道: > 在 2018年05月15日 21:31, Tom Lendacky 写道: >> On 5/14/2018 8:51 PM, Lianbo Jiang wrote: >>> It is convenient to remap the old memory encrypted to the second kernel by >>> calling ioremap_encrypted(). >>> >>> When sme enabled on AMD server, we also need to support kdump

Re: [ANNOUNCE] Kconfiglib menuconfig implementation

2018-05-20 Thread Ulf Magnusson
On Mon, May 21, 2018 at 4:45 AM, Randy Dunlap wrote: > On 05/19/2018 09:47 PM, Ulf Magnusson wrote: >> On Sun, May 20, 2018 at 6:03 AM, Randy Dunlap wrote: >>> On 05/19/2018 08:45 PM, Randy Dunlap wrote: On 05/08/2018 09:59 AM, Ulf Magnusson wrote: > Hello, > > I've added increme

Re: [PATCH v2] Revert "alx: remove WoL support"

2018-05-20 Thread David Miller
From: AceLan Kao Date: Mon, 21 May 2018 11:14:00 +0800 > We are willing to fix the issue, but we don't have a machine to > reproduce it, and the WoL feature has been removed 5 years ago, it's > hard to find those buggy machines. Have you bothered to ask the person who did the revert? > WoL is a

Re: [linux-next PATCH 0/4] Enable network driver on K2G ICE and GP EVMs

2018-05-20 Thread santosh.shilim...@oracle.com
On 5/11/18 12:29 PM, Murali Karicheri wrote: Now that NetCP driver patches for K2G SoC is merged to linux-next master this series add patches to enable network driver on K2G ICE and GP EVMs. Thanks Applied the patches on top of latest linux-next master, built kernel and booted up on both EVMs.

Re: [PATCH v5 04/28] fpga: mgr: add compat_id support

2018-05-20 Thread Wu Hao
On Mon, May 07, 2018 at 04:09:06PM -0500, Alan Tull wrote: > On Tue, May 1, 2018 at 9:50 PM, Wu Hao wrote: > > Hi Hao, > > Looks good! > > > This patch introduces compat_id support to fpga manager, it adds > > a fpga_compat_id pointer to fpga manager data structure to allow > > fpga manager dri

Re: [PATCH v2] Revert "alx: remove WoL support"

2018-05-20 Thread AceLan Kao
Hi David, We are willing to fix the issue, but we don't have a machine to reproduce it, and the WoL feature has been removed 5 years ago, it's hard to find those buggy machines. WoL is a feature that is only used by a very small group of people, and the wake up issue looks like only happens on so

Re: [ANNOUNCE] Kconfiglib menuconfig implementation

2018-05-20 Thread Randy Dunlap
On 05/19/2018 09:47 PM, Ulf Magnusson wrote: > On Sun, May 20, 2018 at 6:03 AM, Randy Dunlap wrote: >> On 05/19/2018 08:45 PM, Randy Dunlap wrote: >>> On 05/08/2018 09:59 AM, Ulf Magnusson wrote: Hello, I've added incremental search for jumping directly to a symbol now. Regular

[PATCH v3] KVM: arm/arm64: add WARN_ON if size is not PAGE_SIZE aligned in unmap_stage2_range

2018-05-20 Thread Jia He
There is a panic in armv8a server(QDF2400) under memory pressure tests (start 20 guests and run memhog in the host). -begin [35380.800950] BUG: Bad page state in process qemu-kvm pfn:dd0b6 [35380.805825] page:7fe003742d80 count:-

Re: [PATCH v2] rcu: Speed up calling of RCU tasks callbacks

2018-05-20 Thread Paul E. McKenney
On Sun, May 20, 2018 at 05:43:24PM -0700, Joel Fernandes wrote: > From: "Joel Fernandes (Google)" > > RCU tasks callbacks can take atleast 1 second before the callbacks are > executed. This happens even if the hold-out tasks enter their quiescent states > quickly. I noticed this when I was testin

[PATCH] kdump: add default crashkernel reserve kernel config options

2018-05-20 Thread Dave Young
This is a rework of the crashkernel=auto patches back to 2009 although I'm not sure if below is the last version of the old effort: https://lkml.org/lkml/2009/8/12/61 https://lwn.net/Articles/345344/ I changed the original design, instead of adding the auto reserve logic in code, in this patch jus

Re: [PATCH] ext4: report delalloc reserve as non-free in statfs mangled by project quota

2018-05-20 Thread Theodore Y. Ts'o
On Fri, Feb 02, 2018 at 01:40:05PM +0300, Konstantin Khlebnikov wrote: > This reserved space isn't committed yet but cannot be used for allocations. > For userspace it has no difference from used space. XFS already does this. > > Signed-off-by: Konstantin Khlebnikov > Fixes: 689c958cbe6b ("ext4:

Re: [PATCH] ext4: Remove unnecessary NULL checks in ext4.

2018-05-20 Thread Theodore Y. Ts'o
On Tue, Feb 06, 2018 at 07:15:30PM +0800, Sean Fu wrote: > NULL check is done in kmem_cache_destroy. So remove NULL checks in ext4. > > Signed-off-by: Sean Fu Thanks, applied. I clarified the patch summary to be: ext4: remove NULL check before calling kmem_cache_destroy()

Re: [PATCH] mtd: mtdoops: optionally dump boottime

2018-05-20 Thread Stefan Schaeckeler
Hello Richard and others, > I get the use-case, but why is this only for mtdoops? Powerpc's nvram module also stores oops messages and does so by adding an additional timestamp, as well (search for kmsg_dump_get_buffer() in arch/powerpc/kernel/nvram_64.c). This timestamp is the number of seconds

Re: [PATCH] jbd2: remove the conditional test

2018-05-20 Thread Theodore Y. Ts'o
On Mon, Feb 05, 2018 at 10:24:39PM +0800, Wang Long wrote: > kmem_cache_destroy already handles null pointers, so we can remove the > conditional test entirely. > > This patch also set NULL after the kmem_cache_destroy in function > jbd2_journal_destroy_handle_cache. > > Signed-off-by: Wang Long

[PATCH v4] Print the memcg's name when system-wide OOM happened

2018-05-20 Thread ufo19890607
From: yuzhoujian The dump_header does not print the memcg's name when the system oom happened. So users cannot locate the certain container which contains the task that has been killed by the oom killer. System oom report will print the memcg's name after this patch, so users can get the memcg's

  1   2   3   4   >