Re: [Xen-devel][RFC 3/3] xen/gntdev: Add support for Linux dma buffers

On 05/22/2018 12:31 AM, Dongwon Kim wrote: Still need more time to review the whole code changes Take your time, I just wanted to make sure that all interested parties are in the discussion, so we all finally have what we all want, not a thing covering only my use-cases but I noticed one

Re: [Xen-devel][RFC 3/3] xen/gntdev: Add support for Linux dma buffers

On 05/22/2018 12:31 AM, Dongwon Kim wrote: Still need more time to review the whole code changes Take your time, I just wanted to make sure that all interested parties are in the discussion, so we all finally have what we all want, not a thing covering only my use-cases but I noticed one

Re: [Xen-devel] [RFC 1/3] xen/balloon: Allow allocating DMA buffers

On 05/21/2018 11:36 PM, Boris Ostrovsky wrote: On 05/21/2018 03:13 PM, Oleksandr Andrushchenko wrote: On 05/21/2018 09:53 PM, Boris Ostrovsky wrote: On 05/21/2018 01:32 PM, Oleksandr Andrushchenko wrote: On 05/21/2018 07:35 PM, Boris Ostrovsky wrote: On 05/21/2018 01:40 AM, Oleksandr

Re: [Xen-devel] [RFC 1/3] xen/balloon: Allow allocating DMA buffers

On 05/21/2018 11:36 PM, Boris Ostrovsky wrote: On 05/21/2018 03:13 PM, Oleksandr Andrushchenko wrote: On 05/21/2018 09:53 PM, Boris Ostrovsky wrote: On 05/21/2018 01:32 PM, Oleksandr Andrushchenko wrote: On 05/21/2018 07:35 PM, Boris Ostrovsky wrote: On 05/21/2018 01:40 AM, Oleksandr

Re: [PATCH net-next 6/7] net: dsa: qca8k: Replace GPL boilerplate by SPDX

On 21.5.2018 17:20, Florian Fainelli wrote: On 05/21/2018 06:28 AM, Michal Vokáč wrote: Signed-off-by: Michal Vokáč Reviewed-by: Florian Fainelli I don't know if we need all people who contributed to that driver to agree on that, this is not a

Re: [PATCH net-next 6/7] net: dsa: qca8k: Replace GPL boilerplate by SPDX

On 21.5.2018 17:20, Florian Fainelli wrote: On 05/21/2018 06:28 AM, Michal Vokáč wrote: Signed-off-by: Michal Vokáč Reviewed-by: Florian Fainelli I don't know if we need all people who contributed to that driver to agree on that, this is not a license change, so it should be okay I

Re: [PATCH net-next 7/7] net: dsa: qca8k: Remove rudundant parentheses

On 21.5.2018 17:21, Florian Fainelli wrote: On 05/21/2018 06:28 AM, Michal Vokáč wrote: Fix warning reported by checkpatch. Nit in the subject: should be redundant, with that: Reviewed-by: Florian Fainelli Thanks, I will fix it. Michal

Re: [PATCH net-next 7/7] net: dsa: qca8k: Remove rudundant parentheses

On 21.5.2018 17:21, Florian Fainelli wrote: On 05/21/2018 06:28 AM, Michal Vokáč wrote: Fix warning reported by checkpatch. Nit in the subject: should be redundant, with that: Reviewed-by: Florian Fainelli Thanks, I will fix it. Michal

Re: [PATCH v4 00/31] kconfig: move compiler capability tests to Kconfig

Hi reviewers, 2018-05-17 23:22 GMT+09:00 Masahiro Yamada : > 2018-05-17 16:51 GMT+09:00 Nicholas Piggin : >> On Thu, 17 May 2018 15:16:39 +0900 >> Masahiro Yamada wrote: >> >>> [Introduction] >>> >>> The motivation

Re: [PATCH v4 00/31] kconfig: move compiler capability tests to Kconfig

Hi reviewers, 2018-05-17 23:22 GMT+09:00 Masahiro Yamada : > 2018-05-17 16:51 GMT+09:00 Nicholas Piggin : >> On Thu, 17 May 2018 15:16:39 +0900 >> Masahiro Yamada wrote: >> >>> [Introduction] >>> >>> The motivation of this work is to move the compiler option tests to >>> Kconfig from Makefile.

[PATCH v2] powerpc/32: Implement csum_ipv6_magic in assembly

The generic csum_ipv6_magic() generates a pretty bad result : 0: 81 23 00 00 lwz r9,0(r3) 4: 81 03 00 04 lwz r8,4(r3) 8: 7c e7 4a 14 add r7,r7,r9 c: 7d 29 38 10 subfc r9,r9,r7 10: 7d 4a 51 10 subfe r10,r10,r10 14: 7d 27 42

[PATCH v2] powerpc/32: Implement csum_ipv6_magic in assembly

The generic csum_ipv6_magic() generates a pretty bad result : 0: 81 23 00 00 lwz r9,0(r3) 4: 81 03 00 04 lwz r8,4(r3) 8: 7c e7 4a 14 add r7,r7,r9 c: 7d 29 38 10 subfc r9,r9,r7 10: 7d 4a 51 10 subfe r10,r10,r10 14: 7d 27 42

[PATCH 4.16 031/110] i2c: designware: fix poll-after-enable regression

4.16-stable review patch. If anyone has any objections, please let me know. -- From: Alexander Monakov commit 06cb616b1bca7080824acfedb3d4c898e7a64836 upstream. Not all revisions of DW I2C controller implement the enable status register. On platforms where

[PATCH 4.16 031/110] i2c: designware: fix poll-after-enable regression

4.16-stable review patch. If anyone has any objections, please let me know. -- From: Alexander Monakov commit 06cb616b1bca7080824acfedb3d4c898e7a64836 upstream. Not all revisions of DW I2C controller implement the enable status register. On platforms where that's the case

[PATCH 4.14 21/95] i2c: designware: fix poll-after-enable regression

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Alexander Monakov commit 06cb616b1bca7080824acfedb3d4c898e7a64836 upstream. Not all revisions of DW I2C controller implement the enable status register. On platforms where

[PATCH 4.14 21/95] i2c: designware: fix poll-after-enable regression

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Alexander Monakov commit 06cb616b1bca7080824acfedb3d4c898e7a64836 upstream. Not all revisions of DW I2C controller implement the enable status register. On platforms where that's the case

[PATCH 4.9 17/87] i2c: designware: fix poll-after-enable regression

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Alexander Monakov commit 06cb616b1bca7080824acfedb3d4c898e7a64836 upstream. Not all revisions of DW I2C controller implement the enable status register. On platforms where

[PATCH 4.9 17/87] i2c: designware: fix poll-after-enable regression

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Alexander Monakov commit 06cb616b1bca7080824acfedb3d4c898e7a64836 upstream. Not all revisions of DW I2C controller implement the enable status register. On platforms where that's the case

Re: [PATCH net-next 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth

On 21.5.2018 17:19, Florian Fainelli wrote: On 05/21/2018 06:28 AM, Michal Vokáč wrote: By default autonegotiation is enabled to configure MAC on all ports. For the CPU port autonegotiation can not be used so we need to set some sensible defaults manually. This patch forces the default

Re: [PATCH net-next 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth

On 21.5.2018 17:19, Florian Fainelli wrote: On 05/21/2018 06:28 AM, Michal Vokáč wrote: By default autonegotiation is enabled to configure MAC on all ports. For the CPU port autonegotiation can not be used so we need to set some sensible defaults manually. This patch forces the default

Re: [PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port

On 21.5.2018 17:17, Florian Fainelli wrote: On 05/21/2018 06:28 AM, Michal Vokáč wrote: When a port is brought up/down do not enable/disable only the TXMAC but the RXMAC as well. This is essential for the CPU port to work. Signed-off-by: Michal Vokáč Reviewed-by:

Re: [PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port

On 21.5.2018 17:17, Florian Fainelli wrote: On 05/21/2018 06:28 AM, Michal Vokáč wrote: When a port is brought up/down do not enable/disable only the TXMAC but the RXMAC as well. This is essential for the CPU port to work. Signed-off-by: Michal Vokáč Reviewed-by: Florian Fainelli Should

Re: [PATCH v3 4/6] ALSA: xen-front: Implement handling of shared buffers

On 05/21/2018 11:26 PM, Takashi Iwai wrote: On Thu, 17 May 2018 08:26:16 +0200, Takashi Iwai wrote: On Tue, 15 May 2018 08:02:08 +0200, Oleksandr Andrushchenko wrote: On 05/15/2018 09:01 AM, Takashi Iwai wrote: On Tue, 15 May 2018 07:46:38 +0200, Oleksandr Andrushchenko wrote: On 05/14/2018

Re: [PATCH v3 4/6] ALSA: xen-front: Implement handling of shared buffers

On 05/21/2018 11:26 PM, Takashi Iwai wrote: On Thu, 17 May 2018 08:26:16 +0200, Takashi Iwai wrote: On Tue, 15 May 2018 08:02:08 +0200, Oleksandr Andrushchenko wrote: On 05/15/2018 09:01 AM, Takashi Iwai wrote: On Tue, 15 May 2018 07:46:38 +0200, Oleksandr Andrushchenko wrote: On 05/14/2018

[lkp-robot] [tty] b6da31b2c0: WARNING:possible_circular_locking_dependency_detected

FYI, we noticed the following commit (built with gcc-6): commit: b6da31b2c07c46f2dcad1d86caa835227a16d9ff ("tty: Fix data race in tty_insert_flip_string_fixed_flag") https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master in testcase: boot on test machine: qemu-system-x86_64

[lkp-robot] [tty] b6da31b2c0: WARNING:possible_circular_locking_dependency_detected

FYI, we noticed the following commit (built with gcc-6): commit: b6da31b2c07c46f2dcad1d86caa835227a16d9ff ("tty: Fix data race in tty_insert_flip_string_fixed_flag") https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master in testcase: boot on test machine: qemu-system-x86_64

Re: [PATCH net-next 1/7] net: dsa: qca8k: Add QCA8334 binding documentation

On 21.5.2018 16:47, Andrew Lunn wrote: On Mon, May 21, 2018 at 03:28:07PM +0200, Michal Vokáč wrote: Signed-off-by: Michal Vokáč Hi Michal It would be good to document that fixed-link can be used. OK, I will document that and add a commit message as well as you

Re: [PATCH net-next 1/7] net: dsa: qca8k: Add QCA8334 binding documentation

On 21.5.2018 16:47, Andrew Lunn wrote: On Mon, May 21, 2018 at 03:28:07PM +0200, Michal Vokáč wrote: Signed-off-by: Michal Vokáč Hi Michal It would be good to document that fixed-link can be used. OK, I will document that and add a commit message as well as you mentioned before. Thanks,

set_fs(KERNEL_DS) vs iovec

Hi guys ! I was helping with a small driver when I stumbled upon a comment from a reviwer pointing to an old lwn article talking about deprecating set_fs due to security concerns: https://lwn.net/Articles/722267/ Now, this is a very simple driver running on a small/slow ARM SoC, which reads

set_fs(KERNEL_DS) vs iovec

Hi guys ! I was helping with a small driver when I stumbled upon a comment from a reviwer pointing to an old lwn article talking about deprecating set_fs due to security concerns: https://lwn.net/Articles/722267/ Now, this is a very simple driver running on a small/slow ARM SoC, which reads

Re: [RFC PATCH] mtd: spi-nor: add support to non-uniform SPI NOR flash memories

Hi, Marek, On 05/21/2018 07:59 PM, Marek Vasut wrote: On 05/21/2018 06:42 PM, Tudor Ambarus wrote: Hi, Marek, [...] This is a transitional patch: non-uniform erase maps will be used later when initialized based on the SFDP data. What about non-SFDP non-linear flashes ? Non-SFDP

Re: [RFC PATCH] mtd: spi-nor: add support to non-uniform SPI NOR flash memories

Hi, Marek, On 05/21/2018 07:59 PM, Marek Vasut wrote: On 05/21/2018 06:42 PM, Tudor Ambarus wrote: Hi, Marek, [...] This is a transitional patch: non-uniform erase maps will be used later when initialized based on the SFDP data. What about non-SFDP non-linear flashes ? Non-SFDP

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Tue, May 22, 2018 at 6:50 AM, Ulf Magnusson wrote: > On Tue, May 22, 2018 at 5:11 AM, Masahiro Yamada > wrote: >> 2018-05-22 0:10 GMT+09:00 Ulf Magnusson : >>> On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Tue, May 22, 2018 at 6:50 AM, Ulf Magnusson wrote: > On Tue, May 22, 2018 at 5:11 AM, Masahiro Yamada > wrote: >> 2018-05-22 0:10 GMT+09:00 Ulf Magnusson : >>> On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson wrote: On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson wrote: > On Sun, May

Re: Tasks RCU vs Preempt RCU

(Resending because my previous mail client terribly wrapped things..) On Mon, May 21, 2018 at 09:59:51PM -0400, Steven Rostedt wrote: [...] > > > > Just thinking out loud and probably some food for thought.. > > > > The rcu_read_lock/unlock primitive are extrememly fast, so I don't > >

Re: Tasks RCU vs Preempt RCU

(Resending because my previous mail client terribly wrapped things..) On Mon, May 21, 2018 at 09:59:51PM -0400, Steven Rostedt wrote: [...] > > > > Just thinking out loud and probably some food for thought.. > > > > The rcu_read_lock/unlock primitive are extrememly fast, so I don't > >

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Tue, May 22, 2018 at 5:11 AM, Masahiro Yamada wrote: > 2018-05-22 0:10 GMT+09:00 Ulf Magnusson : >> On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson wrote: >>> On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson

Re: [PATCH v4 07/31] kconfig: add built-in function support

On Tue, May 22, 2018 at 5:11 AM, Masahiro Yamada wrote: > 2018-05-22 0:10 GMT+09:00 Ulf Magnusson : >> On Mon, May 21, 2018 at 4:32 PM, Ulf Magnusson wrote: >>> On Mon, May 21, 2018 at 4:23 PM, Ulf Magnusson wrote: On Sun, May 20, 2018 at 4:50 PM, Sam Ravnborg wrote: > Will the

Re: [PATCH v3 4/4] rcu: Unlock non-start node only after accessing its gp_seq_needed

On Mon, May 21, 2018 at 09:16:51PM -0700, Paul E. McKenney wrote: > On Mon, May 21, 2018 at 05:28:23PM -0700, Paul E. McKenney wrote: > > On Mon, May 21, 2018 at 05:07:34PM -0700, Joel Fernandes wrote: > > > On Mon, May 21, 2018 at 04:25:38PM -0700, Paul E. McKenney wrote: > > > > On Sun, May 20,

Re: [PATCH v3 4/4] rcu: Unlock non-start node only after accessing its gp_seq_needed

On Mon, May 21, 2018 at 09:16:51PM -0700, Paul E. McKenney wrote: > On Mon, May 21, 2018 at 05:28:23PM -0700, Paul E. McKenney wrote: > > On Mon, May 21, 2018 at 05:07:34PM -0700, Joel Fernandes wrote: > > > On Mon, May 21, 2018 at 04:25:38PM -0700, Paul E. McKenney wrote: > > > > On Sun, May 20,

Re: Tasks RCU vs Preempt RCU

On Mon, May 21, 2018 at 6:59 PM Steven Rostedt wrote: [...] > > > > Just thinking out loud and probably some food for thought.. > > > > The rcu_read_lock/unlock primitive are extrememly fast, so I don't personally > > think there's a time hit. > > > > Could we get around the

Re: Tasks RCU vs Preempt RCU

On Mon, May 21, 2018 at 6:59 PM Steven Rostedt wrote: [...] > > > > Just thinking out loud and probably some food for thought.. > > > > The rcu_read_lock/unlock primitive are extrememly fast, so I don't personally > > think there's a time hit. > > > > Could we get around the trampoline code ==

Re: [PATCH 1/2] powerpc: Detect the presence of big-core with interleaved threads

Hello Michael, On Fri, May 18, 2018 at 11:21:22PM +1000, Michael Ellerman wrote: > "Gautham R. Shenoy" writes: > > > diff --git a/arch/powerpc/kernel/setup-common.c > > b/arch/powerpc/kernel/setup-common.c > > index 0af5c11..884dff2 100644 > > ---

Re: [PATCH v5 3/8] remoteproc: Move proxy unvote to handover irq handler

On Mon 21 May 10:27 PDT 2018, Sibi Sankar wrote: > Introduce interrupt handler for smp2p ready interrupt to > handle start completion. Move the proxy votes for clocks > and regulators to the handover interrupt context. > > Signed-off-by: Sibi Sankar I added the

Re: [PATCH 1/2] powerpc: Detect the presence of big-core with interleaved threads

Hello Michael, On Fri, May 18, 2018 at 11:21:22PM +1000, Michael Ellerman wrote: > "Gautham R. Shenoy" writes: > > > diff --git a/arch/powerpc/kernel/setup-common.c > > b/arch/powerpc/kernel/setup-common.c > > index 0af5c11..884dff2 100644 > > --- a/arch/powerpc/kernel/setup-common.c > > +++

Re: [PATCH v5 3/8] remoteproc: Move proxy unvote to handover irq handler

On Mon 21 May 10:27 PDT 2018, Sibi Sankar wrote: > Introduce interrupt handler for smp2p ready interrupt to > handle start completion. Move the proxy votes for clocks > and regulators to the handover interrupt context. > > Signed-off-by: Sibi Sankar I added the "synchronization logic" of patch

Re: [PATCH 1/2] powerpc: Detect the presence of big-core with interleaved threads

Hello Michael, On Fri, May 18, 2018 at 11:14:04PM +1000, Michael Ellerman wrote: > Gautham R Shenoy writes: > ... > >> > @@ -565,7 +615,16 @@ void __init smp_setup_cpu_maps(void) > >> > vdso_data->processorCount = num_present_cpus(); > >> > #endif /*

Re: [PATCH 1/2] powerpc: Detect the presence of big-core with interleaved threads

Hello Michael, On Fri, May 18, 2018 at 11:14:04PM +1000, Michael Ellerman wrote: > Gautham R Shenoy writes: > ... > >> > @@ -565,7 +615,16 @@ void __init smp_setup_cpu_maps(void) > >> > vdso_data->processorCount = num_present_cpus(); > >> > #endif /* CONFIG_PPC64 */ > >> > > >> > -

[PATCH] fs/affs: fix potential memory leak in option parsing

When specifying option 'prefix' multiple times, current option parsing will cause memory leak. Hence, call kfree for previous one in this case. Signed-off-by: Chengguang Xu --- fs/affs/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/affs/super.c b/fs/affs/super.c

[PATCH] fs/affs: fix potential memory leak in option parsing

When specifying option 'prefix' multiple times, current option parsing will cause memory leak. Hence, call kfree for previous one in this case. Signed-off-by: Chengguang Xu --- fs/affs/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/affs/super.c b/fs/affs/super.c index

[PATCH RFC 3/3] scsi: ufs: Add sysfs support for ufs provision

Add sysfs support to trigger ufs provisioning at runtime. Usage : echo > /sys/bus/platform/devices/1d84000.ufshcd/ufs_provision To check provisioning status: cat /sys/bus/platform/devices/1d84000.ufshc/ufs_provision 1 -> Success (Reboot device to check updated provisioning) Signed-off-by: Sayali

[PATCH RFC 3/3] scsi: ufs: Add sysfs support for ufs provision

Add sysfs support to trigger ufs provisioning at runtime. Usage : echo > /sys/bus/platform/devices/1d84000.ufshcd/ufs_provision To check provisioning status: cat /sys/bus/platform/devices/1d84000.ufshc/ufs_provision 1 -> Success (Reboot device to check updated provisioning) Signed-off-by: Sayali

[PATCH RFC 2/3] scsi: ufs: Add ufs provisioning support

A new api ufshcd_do_config_device() is added in driver to suppoet UFS provisioning at runtime. Sysfs support is added to trigger provisioning. Device configuration descriptors or parameters are parsed from vendor specific provisioning data and passed via sysfs at runtime to provision ufs device.

[PATCH RFC 1/3] scsi: ufs: set the device reference clock setting

From: Subhash Jadavani UFS host supplies the reference clock to UFS device and UFS device specification allows host to provide one of the 4 frequencies (19.2 MHz, 26 MHz, 38.4 MHz, 52 MHz) for reference clock. Host should set the device reference clock frequency setting

[PATCH RFC 2/3] scsi: ufs: Add ufs provisioning support

A new api ufshcd_do_config_device() is added in driver to suppoet UFS provisioning at runtime. Sysfs support is added to trigger provisioning. Device configuration descriptors or parameters are parsed from vendor specific provisioning data and passed via sysfs at runtime to provision ufs device.

[PATCH RFC 1/3] scsi: ufs: set the device reference clock setting

From: Subhash Jadavani UFS host supplies the reference clock to UFS device and UFS device specification allows host to provide one of the 4 frequencies (19.2 MHz, 26 MHz, 38.4 MHz, 52 MHz) for reference clock. Host should set the device reference clock frequency setting in the device based on

Re: [PATCH v3 4/4] rcu: Unlock non-start node only after accessing its gp_seq_needed

On Mon, May 21, 2018 at 05:28:23PM -0700, Paul E. McKenney wrote: > On Mon, May 21, 2018 at 05:07:34PM -0700, Joel Fernandes wrote: > > On Mon, May 21, 2018 at 04:25:38PM -0700, Paul E. McKenney wrote: > > > On Sun, May 20, 2018 at 09:42:20PM -0700, Joel Fernandes wrote: > > > > We acquire

Re: [PATCH v3 4/4] rcu: Unlock non-start node only after accessing its gp_seq_needed

On Mon, May 21, 2018 at 05:28:23PM -0700, Paul E. McKenney wrote: > On Mon, May 21, 2018 at 05:07:34PM -0700, Joel Fernandes wrote: > > On Mon, May 21, 2018 at 04:25:38PM -0700, Paul E. McKenney wrote: > > > On Sun, May 20, 2018 at 09:42:20PM -0700, Joel Fernandes wrote: > > > > We acquire

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On 2018年05月22日 11:46, Michael S. Tsirkin wrote: On Tue, May 22, 2018 at 11:22:11AM +0800, Jason Wang wrote: On 2018年05月22日 06:08, Michael S. Tsirkin wrote: On Mon, May 21, 2018 at 11:47:42AM -0400, David Miller wrote: From: Jason Wang Date: Fri, 18 May 2018 21:00:43

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On 2018年05月22日 11:46, Michael S. Tsirkin wrote: On Tue, May 22, 2018 at 11:22:11AM +0800, Jason Wang wrote: On 2018年05月22日 06:08, Michael S. Tsirkin wrote: On Mon, May 21, 2018 at 11:47:42AM -0400, David Miller wrote: From: Jason Wang Date: Fri, 18 May 2018 21:00:43 +0800 We return -EIO

[PATCH v4 2/2] xen/PVH: Make GDT selectors PVH-specific

We don't need to share PVH GDT layout with other GDTs, especially since we now have a PVH-speciific entry (for stack canary segment). Define PVH's own selectors. (As a side effect of this change we are also fixing improper reference to __KERNEL_CS) Signed-off-by: Boris Ostrovsky

Re: KASAN: use-after-free Read in vhost_chr_write_iter

On Tue, May 22, 2018 at 11:50:29AM +0800, Jason Wang wrote: > > > On 2018年05月21日 22:42, Michael S. Tsirkin wrote: > > On Mon, May 21, 2018 at 10:38:10AM +0800, Jason Wang wrote: > > > On 2018年05月18日 17:24, Jason Wang wrote: > > > > On 2018年05月17日 21:45, DaeRyong Jeong wrote: > > > > > We report

[PATCH v4 2/2] xen/PVH: Make GDT selectors PVH-specific

We don't need to share PVH GDT layout with other GDTs, especially since we now have a PVH-speciific entry (for stack canary segment). Define PVH's own selectors. (As a side effect of this change we are also fixing improper reference to __KERNEL_CS) Signed-off-by: Boris Ostrovsky ---

Re: KASAN: use-after-free Read in vhost_chr_write_iter

On Tue, May 22, 2018 at 11:50:29AM +0800, Jason Wang wrote: > > > On 2018年05月21日 22:42, Michael S. Tsirkin wrote: > > On Mon, May 21, 2018 at 10:38:10AM +0800, Jason Wang wrote: > > > On 2018年05月18日 17:24, Jason Wang wrote: > > > > On 2018年05月17日 21:45, DaeRyong Jeong wrote: > > > > > We report

[PATCH v4 0/2] PVH GDT fixes

Fix stack canary handling (in the first patch) and re-index PVH GDT to make it explicit that the GDT PVH-specific v4: * Load %gs after base address is calculated * Increase stack canary segment size to 48 bytes for long mode. Boris Ostrovsky (2): xen/PVH: Set up GS segment for stack canary

[PATCH v4 1/2] xen/PVH: Set up GS segment for stack canary

We are making calls to C code (e.g. xen_prepare_pvh()) which may use stack canary (stored in GS segment). Signed-off-by: Boris Ostrovsky --- arch/x86/xen/xen-pvh.S | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git

[PATCH v4 1/2] xen/PVH: Set up GS segment for stack canary

We are making calls to C code (e.g. xen_prepare_pvh()) which may use stack canary (stored in GS segment). Signed-off-by: Boris Ostrovsky --- arch/x86/xen/xen-pvh.S | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/arch/x86/xen/xen-pvh.S

[PATCH v4 0/2] PVH GDT fixes

Fix stack canary handling (in the first patch) and re-index PVH GDT to make it explicit that the GDT PVH-specific v4: * Load %gs after base address is calculated * Increase stack canary segment size to 48 bytes for long mode. Boris Ostrovsky (2): xen/PVH: Set up GS segment for stack canary

Re: KASAN: use-after-free Read in vhost_chr_write_iter

On 2018年05月21日 22:42, Michael S. Tsirkin wrote: On Mon, May 21, 2018 at 10:38:10AM +0800, Jason Wang wrote: On 2018年05月18日 17:24, Jason Wang wrote: On 2018年05月17日 21:45, DaeRyong Jeong wrote: We report the crash: KASAN: use-after-free Read in vhost_chr_write_iter This crash has been found

Re: KASAN: use-after-free Read in vhost_chr_write_iter

On 2018年05月21日 22:42, Michael S. Tsirkin wrote: On Mon, May 21, 2018 at 10:38:10AM +0800, Jason Wang wrote: On 2018年05月18日 17:24, Jason Wang wrote: On 2018年05月17日 21:45, DaeRyong Jeong wrote: We report the crash: KASAN: use-after-free Read in vhost_chr_write_iter This crash has been found

Re: [PATCH] [RFC] bcachefs: SIX locks (shared/intent/exclusive)

On Mon, May 21, 2018 at 08:04:16PM -0700, Matthew Wilcox wrote: > On Mon, May 21, 2018 at 10:19:51PM -0400, Kent Overstreet wrote: > > New lock for bcachefs, like read/write locks but with a third state, > > intent. > > > > Intent locks conflict with each other, but not with read locks; taking a

Re: [PATCH] [RFC] bcachefs: SIX locks (shared/intent/exclusive)

On Mon, May 21, 2018 at 08:04:16PM -0700, Matthew Wilcox wrote: > On Mon, May 21, 2018 at 10:19:51PM -0400, Kent Overstreet wrote: > > New lock for bcachefs, like read/write locks but with a third state, > > intent. > > > > Intent locks conflict with each other, but not with read locks; taking a

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On Tue, May 22, 2018 at 11:22:11AM +0800, Jason Wang wrote: > > > On 2018年05月22日 06:08, Michael S. Tsirkin wrote: > > On Mon, May 21, 2018 at 11:47:42AM -0400, David Miller wrote: > > > From: Jason Wang > > > Date: Fri, 18 May 2018 21:00:43 +0800 > > > > > > > We return

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On Tue, May 22, 2018 at 11:22:11AM +0800, Jason Wang wrote: > > > On 2018年05月22日 06:08, Michael S. Tsirkin wrote: > > On Mon, May 21, 2018 at 11:47:42AM -0400, David Miller wrote: > > > From: Jason Wang > > > Date: Fri, 18 May 2018 21:00:43 +0800 > > > > > > > We return -EIO on device down but

[PATCH net V2 2/4] virtio-net: correctly transmit XDP buff after linearizing

We should not go for the error path after successfully transmitting a XDP buffer after linearizing. Since the error path may try to pop and drop next packet and increase the drop counters. Fixing this by simply drop the refcnt of original page and go for xmit path. Fixes: 72979a6c3590

[PATCH] perf annotate: Show group event string for stdio

When we enable the group, for tui/stdio2, the output first line includes the group event string. While for stdio, it will show only one event. For example, perf record -e cycles,branches ./div perf annotate --group --stdio Percent | Source code & Disassembly of div for cycles (44407

[PATCH] perf annotate: Show group event string for stdio

When we enable the group, for tui/stdio2, the output first line includes the group event string. While for stdio, it will show only one event. For example, perf record -e cycles,branches ./div perf annotate --group --stdio Percent | Source code & Disassembly of div for cycles (44407

[PATCH net V2 2/4] virtio-net: correctly transmit XDP buff after linearizing

We should not go for the error path after successfully transmitting a XDP buffer after linearizing. Since the error path may try to pop and drop next packet and increase the drop counters. Fixing this by simply drop the refcnt of original page and go for xmit path. Fixes: 72979a6c3590

[PATCH net V2 4/4] virtio-net: fix leaking page for gso packet during mergeable XDP

We need to drop refcnt to xdp_page if we see a gso packet. Otherwise it will be leaked. Fixing this by moving the check of gso packet above the linearizing logic. While at it, remove useless comment as well. Cc: John Fastabend Fixes: 72979a6c3590 ("virtio_net: xdp, add

[PATCH net V2 4/4] virtio-net: fix leaking page for gso packet during mergeable XDP

We need to drop refcnt to xdp_page if we see a gso packet. Otherwise it will be leaked. Fixing this by moving the check of gso packet above the linearizing logic. While at it, remove useless comment as well. Cc: John Fastabend Fixes: 72979a6c3590 ("virtio_net: xdp, add slowpath case for non

[PATCH net V2 3/4] virtio-net: correctly check num_buf during err path

If we successfully linearize the packet, num_buf will be set to zero which may confuse error handling path which assumes num_buf is at least 1 and this can lead the code tries to pop the descriptor of next buffer. Fixing this by checking num_buf against 1 before decreasing. Fixes: 4941d472bf95

[PATCH net V2 3/4] virtio-net: correctly check num_buf during err path

If we successfully linearize the packet, num_buf will be set to zero which may confuse error handling path which assumes num_buf is at least 1 and this can lead the code tries to pop the descriptor of next buffer. Fixing this by checking num_buf against 1 before decreasing. Fixes: 4941d472bf95

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On Tue, May 22, 2018 at 11:22:11AM +0800, Jason Wang wrote: > > > On 2018年05月22日 06:08, Michael S. Tsirkin wrote: > > On Mon, May 21, 2018 at 11:47:42AM -0400, David Miller wrote: > > > From: Jason Wang > > > Date: Fri, 18 May 2018 21:00:43 +0800 > > > > > > > We return

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

On Tue, May 22, 2018 at 11:22:11AM +0800, Jason Wang wrote: > > > On 2018年05月22日 06:08, Michael S. Tsirkin wrote: > > On Mon, May 21, 2018 at 11:47:42AM -0400, David Miller wrote: > > > From: Jason Wang > > > Date: Fri, 18 May 2018 21:00:43 +0800 > > > > > > > We return -EIO on device down but

[PATCH net V2 1/4] virtio-net: correctly redirect linearized packet

After a linearized packet was redirected by XDP, we should not go for the err path which will try to pop buffers for the next packet and increase the drop counter. Fixing this by just drop the page refcnt for the original page. Fixes: 186b3c998c50 ("virtio-net: support XDP_REDIRECT") Reported-by:

[PATCH net V2 0/4] Fix several issues of virtio-net mergeable XDP

Hi: Please review the patches that tries to fix sevreal issues of virtio-net mergeable XDP. Changes from V1: - check against 1 before decreasing instead of resetting to 1 - typoe fixes Jason Wang (4): virtio-net: correctly redirect linearized packet virtio-net: correctly transmit XDP buff

[PATCH net V2 0/4] Fix several issues of virtio-net mergeable XDP

Hi: Please review the patches that tries to fix sevreal issues of virtio-net mergeable XDP. Changes from V1: - check against 1 before decreasing instead of resetting to 1 - typoe fixes Jason Wang (4): virtio-net: correctly redirect linearized packet virtio-net: correctly transmit XDP buff

[PATCH net V2 1/4] virtio-net: correctly redirect linearized packet

After a linearized packet was redirected by XDP, we should not go for the err path which will try to pop buffers for the next packet and increase the drop counter. Fixing this by just drop the page refcnt for the original page. Fixes: 186b3c998c50 ("virtio-net: support XDP_REDIRECT") Reported-by:

Re: [PATCH 12/33] clk: bcm2835: use match_string() helper

Hi Andy, On 2018/5/22 5:50, Andy Shevchenko wrote: > On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie wrote: >> match_string() returns the index of an array for a matching string, >> which can be used intead of open coded variant. >> >> Cc: Michael Turquette

Re: [PATCH 12/33] clk: bcm2835: use match_string() helper

Hi Andy, On 2018/5/22 5:50, Andy Shevchenko wrote: > On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie wrote: >> match_string() returns the index of an array for a matching string, >> which can be used intead of open coded variant. >> >> Cc: Michael Turquette >> Cc: Stephen Boyd >> Cc: Eric Anholt

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 21-05-18, 20:56, Frank Mori Hess wrote: > On Mon, May 21, 2018 at 5:16 AM, Vinod Koul wrote: > >> > >> I understand the residue can't be read after terminate, that's why > >> reading the residue is step 2 in pause/residue/terminate. My question > >> was whether the

Re: Revert "dmaengine: pl330: add DMA_PAUSE feature"

On 21-05-18, 20:56, Frank Mori Hess wrote: > On Mon, May 21, 2018 at 5:16 AM, Vinod Koul wrote: > >> > >> I understand the residue can't be read after terminate, that's why > >> reading the residue is step 2 in pause/residue/terminate. My question > >> was whether the entire sequence

Re: [PATCH net 4/4] virito-net: fix leaking page for gso packet during mergeable XDP

On 2018年05月21日 23:01, Michael S. Tsirkin wrote: On Mon, May 21, 2018 at 04:35:06PM +0800, Jason Wang wrote: We need to drop refcnt to xdp_page if we see a gso packet. Otherwise it will be leaked. Fixing this by moving the check of gso packet above the linearizing logic. Cc: John Fastabend

Re: [PATCH net 4/4] virito-net: fix leaking page for gso packet during mergeable XDP

On 2018年05月21日 23:01, Michael S. Tsirkin wrote: On Mon, May 21, 2018 at 04:35:06PM +0800, Jason Wang wrote: We need to drop refcnt to xdp_page if we see a gso packet. Otherwise it will be leaked. Fixing this by moving the check of gso packet above the linearizing logic. Cc: John Fastabend

Re: [PATCH net 3/4] virtio-net: reset num_buf to 1 after linearizing packet

On 2018年05月21日 22:59, Michael S. Tsirkin wrote: On Mon, May 21, 2018 at 04:35:05PM +0800, Jason Wang wrote: If we successfully linearize the packets, num_buf were set to zero which was wrong since we now have only 1 buffer to be used for e.g in the error path of receive_mergeable(). Zero

Re: [PATCH net 3/4] virtio-net: reset num_buf to 1 after linearizing packet

On 2018年05月21日 22:59, Michael S. Tsirkin wrote: On Mon, May 21, 2018 at 04:35:05PM +0800, Jason Wang wrote: If we successfully linearize the packets, num_buf were set to zero which was wrong since we now have only 1 buffer to be used for e.g in the error path of receive_mergeable(). Zero

[PATCH] scripts/kconfig/confdata.c: Fix script/checkpatch.pl coding style issues.

Hi. I fixed the coding style issus in scripts/kconfig/confdata.c to not get errors at least. Signed-off-by: user1 --- scripts/kconfig/confdata.c | 110 - 1 file changed, 60 insertions(+), 50 deletions(-) diff --git

[PATCH] scripts/kconfig/confdata.c: Fix script/checkpatch.pl coding style issues.

Hi. I fixed the coding style issus in scripts/kconfig/confdata.c to not get errors at least. Signed-off-by: user1 --- scripts/kconfig/confdata.c | 110 - 1 file changed, 60 insertions(+), 50 deletions(-) diff --git a/scripts/kconfig/confdata.c

Re: [PATCH 07/33] iwlwifi: mvm: use match_string() helper

Hi Andy, On 2018/5/22 5:43, Andy Shevchenko wrote: > On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie wrote: >> match_string() returns the index of an array for a matching string, >> which can be used intead of open coded variant. > >> int ret, bt_force_ant_mode; >>

Re: [PATCH 07/33] iwlwifi: mvm: use match_string() helper

Hi Andy, On 2018/5/22 5:43, Andy Shevchenko wrote: > On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie wrote: >> match_string() returns the index of an array for a matching string, >> which can be used intead of open coded variant. > >> int ret, bt_force_ant_mode; >> >> - for

  1   2   3   4   5   6   7   8   9   10   >