[PATCH] staging: rtl8712: Adjust if statements to reduce indentation level

2018-06-15 Thread JoonHwan.Kim
Merge two condition of if statements in r8712_surveydone_event_callback() Signed-off-by: Joonhwan Kim --- drivers/staging/rtl8712/rtl871x_mlme.c | 51 +- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c

[PATCH] staging: rtl8712: Adjust if statements to reduce indentation level

2018-06-15 Thread JoonHwan.Kim
Merge two condition of if statements in r8712_surveydone_event_callback() Signed-off-by: Joonhwan Kim --- drivers/staging/rtl8712/rtl871x_mlme.c | 51 +- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c

Re: OpenAFS module libafs.ko uses GPL-only symbol '__put_devmap_managed_page'

2018-06-15 Thread John Hubbard
On 06/15/2018 10:22 PM, Dan Williams wrote: > On Fri, Jun 15, 2018 at 9:43 PM, John Hubbard wrote: >> On 06/13/2018 12:51 PM, Dan Williams wrote: >>> [ adding Andrew, Christoph, and linux-mm ] >>> >>> On Wed, Jun 13, 2018 at 12:33 PM, Joe Gorse wrote: [snip] P.S. The build failure, for

Re: OpenAFS module libafs.ko uses GPL-only symbol '__put_devmap_managed_page'

2018-06-15 Thread John Hubbard
On 06/15/2018 10:22 PM, Dan Williams wrote: > On Fri, Jun 15, 2018 at 9:43 PM, John Hubbard wrote: >> On 06/13/2018 12:51 PM, Dan Williams wrote: >>> [ adding Andrew, Christoph, and linux-mm ] >>> >>> On Wed, Jun 13, 2018 at 12:33 PM, Joe Gorse wrote: [snip] P.S. The build failure, for

Re: OpenAFS module libafs.ko uses GPL-only symbol '__put_devmap_managed_page'

2018-06-15 Thread Dan Williams
On Fri, Jun 15, 2018 at 9:43 PM, John Hubbard wrote: > On 06/13/2018 12:51 PM, Dan Williams wrote: >> [ adding Andrew, Christoph, and linux-mm ] >> >> On Wed, Jun 13, 2018 at 12:33 PM, Joe Gorse wrote: >>> Greetings, >>> >>> Please CC answers & comments to this email. Thanks! =) >>> >>> Our

Re: OpenAFS module libafs.ko uses GPL-only symbol '__put_devmap_managed_page'

2018-06-15 Thread Dan Williams
On Fri, Jun 15, 2018 at 9:43 PM, John Hubbard wrote: > On 06/13/2018 12:51 PM, Dan Williams wrote: >> [ adding Andrew, Christoph, and linux-mm ] >> >> On Wed, Jun 13, 2018 at 12:33 PM, Joe Gorse wrote: >>> Greetings, >>> >>> Please CC answers & comments to this email. Thanks! =) >>> >>> Our

Re: [RFC PATCH 5/5] fsi/scom: Major overhaul

2018-06-15 Thread Joel Stanley
On 12 June 2018 at 14:49, Benjamin Herrenschmidt wrote: > This was too hard to split ... this adds a number of features > to the SCOM user interface: > > - Support for indirect SCOMs > > - read()/write() interface now handle errors and retries > > - New ioctl() "raw" interface for use by

Re: [RFC PATCH 5/5] fsi/scom: Major overhaul

2018-06-15 Thread Joel Stanley
On 12 June 2018 at 14:49, Benjamin Herrenschmidt wrote: > This was too hard to split ... this adds a number of features > to the SCOM user interface: > > - Support for indirect SCOMs > > - read()/write() interface now handle errors and retries > > - New ioctl() "raw" interface for use by

Re: OpenAFS module libafs.ko uses GPL-only symbol '__put_devmap_managed_page'

2018-06-15 Thread John Hubbard
On 06/13/2018 12:51 PM, Dan Williams wrote: > [ adding Andrew, Christoph, and linux-mm ] > > On Wed, Jun 13, 2018 at 12:33 PM, Joe Gorse wrote: >> Greetings, >> >> Please CC answers & comments to this email. Thanks! =) >> >> Our build is breaking as of >> commit

Re: OpenAFS module libafs.ko uses GPL-only symbol '__put_devmap_managed_page'

2018-06-15 Thread John Hubbard
On 06/13/2018 12:51 PM, Dan Williams wrote: > [ adding Andrew, Christoph, and linux-mm ] > > On Wed, Jun 13, 2018 at 12:33 PM, Joe Gorse wrote: >> Greetings, >> >> Please CC answers & comments to this email. Thanks! =) >> >> Our build is breaking as of >> commit

Re: [PATCH 1/2] staging: rtl8192e: remove brace for single statement

2018-06-15 Thread 김현일
Thanks greg. Let me check and send again regards Hyunil Kim On Fri, Jun 15, 2018 at 8:08 PM, Greg KH wrote: > On Sat, Jun 09, 2018 at 03:05:56PM +0900, thtlwlsmsgk...@gmail.com wrote: >> * fix checkpatch.pl warning: >> WARNING: braces { are not necessary for single statement blocks >> >>

Re: [PATCH 1/2] staging: rtl8192e: remove brace for single statement

2018-06-15 Thread 김현일
Thanks greg. Let me check and send again regards Hyunil Kim On Fri, Jun 15, 2018 at 8:08 PM, Greg KH wrote: > On Sat, Jun 09, 2018 at 03:05:56PM +0900, thtlwlsmsgk...@gmail.com wrote: >> * fix checkpatch.pl warning: >> WARNING: braces { are not necessary for single statement blocks >> >>

Re: [PATCH 2/2] staging: rtl8192e: fix line over 80 characters

2018-06-15 Thread 김현일
Hi Joe. Thanks to your notice. i will check again. Regards, Hyunil Kim. On Sat, Jun 9, 2018 at 3:45 PM, Joe Perches wrote: > On Sat, 2018-06-09 at 15:07 +0900, thtlwlsmsgk...@gmail.com wrote: >> *fix checkpatch.pl warnings: >> WARNING: line over 80 characters > > Consider using a temporary

Re: [PATCH 2/2] staging: rtl8192e: fix line over 80 characters

2018-06-15 Thread 김현일
Hi Joe. Thanks to your notice. i will check again. Regards, Hyunil Kim. On Sat, Jun 9, 2018 at 3:45 PM, Joe Perches wrote: > On Sat, 2018-06-09 at 15:07 +0900, thtlwlsmsgk...@gmail.com wrote: >> *fix checkpatch.pl warnings: >> WARNING: line over 80 characters > > Consider using a temporary

Re: [PATCH 1/2] staging: mt7621-spi: change indentation from space to tab

2018-06-15 Thread 김준환
Hi greg, I didn't noticed that. :( Thank you for your attention! Sincerely, JoonHwan 2018-06-15 20:02 GMT+09:00 Greg KH : > On Sat, Jun 09, 2018 at 03:03:27PM +0900, JoonHwan.Kim wrote: >> * fix checkpatch.pl error: >> ERROR: code indent should use tabs where possible >> >> Signed-off-by:

Re: [PATCH 1/2] staging: mt7621-spi: change indentation from space to tab

2018-06-15 Thread 김준환
Hi greg, I didn't noticed that. :( Thank you for your attention! Sincerely, JoonHwan 2018-06-15 20:02 GMT+09:00 Greg KH : > On Sat, Jun 09, 2018 at 03:03:27PM +0900, JoonHwan.Kim wrote: >> * fix checkpatch.pl error: >> ERROR: code indent should use tabs where possible >> >> Signed-off-by:

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-15 Thread kbuild test robot
Hi Matthias, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kvm/linux-next] [also build test WARNING on v4.17 next-20180615] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-15 Thread kbuild test robot
Hi Matthias, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kvm/linux-next] [also build test WARNING on v4.17 next-20180615] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH v2] nds32: Fix build error caused by configuration flag rename

2018-06-15 Thread Greentime Hu
James Hogan 於 2018年6月15日 週五 下午8:34寫道: > > On Fri, Jun 15, 2018 at 02:12:58PM +0800, Greentime Hu wrote: > > Thank you James and Guenter. > > Should I pick it in my tree? It will be ok to put in your tree. :) > > > > Acked-by: Greentime Hu > > I think your tree makes most sense for this patch,

Re: [PATCH v2] nds32: Fix build error caused by configuration flag rename

2018-06-15 Thread Greentime Hu
James Hogan 於 2018年6月15日 週五 下午8:34寫道: > > On Fri, Jun 15, 2018 at 02:12:58PM +0800, Greentime Hu wrote: > > Thank you James and Guenter. > > Should I pick it in my tree? It will be ok to put in your tree. :) > > > > Acked-by: Greentime Hu > > I think your tree makes most sense for this patch,

[CFT][PATCH] proc: Simplify and fix proc by removing the kernel mount

2018-06-15 Thread Eric W. Biederman
Today there are three users of proc_mnt. - The legacy sysctl system call implementation. - The uml mconsole driver. - The process cleanup function proc_flush_task. The first two are slow path and for the sysctl code there is even a case for removing it. A new wrapper file_open_proc to mount

[CFT][PATCH] proc: Simplify and fix proc by removing the kernel mount

2018-06-15 Thread Eric W. Biederman
Today there are three users of proc_mnt. - The legacy sysctl system call implementation. - The uml mconsole driver. - The process cleanup function proc_flush_task. The first two are slow path and for the sysctl code there is even a case for removing it. A new wrapper file_open_proc to mount

[RFC PATCH 4/8] cpuidle: Set up maximum umwait time and umwait states

2018-06-15 Thread Fenghua Yu
UMWAIT or TPAUSE called by user process makes processor to reside in a light-weight power/performance optimized state (C0.1 state) or an improved power/performance optimized state (C0.2 state). IA32_UMAIT_CONTROL MSR register control allows OS to set maximum umwait time and disable C0.2 on the

[RFC PATCH 4/8] cpuidle: Set up maximum umwait time and umwait states

2018-06-15 Thread Fenghua Yu
UMWAIT or TPAUSE called by user process makes processor to reside in a light-weight power/performance optimized state (C0.1 state) or an improved power/performance optimized state (C0.2 state). IA32_UMAIT_CONTROL MSR register control allows OS to set maximum umwait time and disable C0.2 on the

[RFC PATCH 7/8] x86/lib_user_wait.h: Add APIs for user wait instructions

2018-06-15 Thread Fenghua Yu
A few new user wait instructions UMONITOR, UMWAIT, and TPAUSE are published in the latest Intel Instruction Set Extensions document. Define the APIs for user or kernel to use the instructions. If feature enabled GCC is available in the future, implementation of the APIs will be changed to call

[RFC PATCH 8/8] selftests/x86: Self test for the APIs in lib_direct_store.h and lib_user_wait.h

2018-06-15 Thread Fenghua Yu
The self test checks APIs defined in arch/x86/include/uapi/asm/ lib_direct_store.h and arch/x86/include/uapi/asm/lib_user_wait.h Limited by testing environment, this test suit only tests simple cases. More test cases may be added later. Signed-off-by: Fenghua Yu ---

[RFC PATCH 8/8] selftests/x86: Self test for the APIs in lib_direct_store.h and lib_user_wait.h

2018-06-15 Thread Fenghua Yu
The self test checks APIs defined in arch/x86/include/uapi/asm/ lib_direct_store.h and arch/x86/include/uapi/asm/lib_user_wait.h Limited by testing environment, this test suit only tests simple cases. More test cases may be added later. Signed-off-by: Fenghua Yu ---

[RFC PATCH 7/8] x86/lib_user_wait.h: Add APIs for user wait instructions

2018-06-15 Thread Fenghua Yu
A few new user wait instructions UMONITOR, UMWAIT, and TPAUSE are published in the latest Intel Instruction Set Extensions document. Define the APIs for user or kernel to use the instructions. If feature enabled GCC is available in the future, implementation of the APIs will be changed to call

[RFC PATCH 6/8] x86/lib_direct_store.h: Add APIs for direct store instructions

2018-06-15 Thread Fenghua Yu
Direct store instructions MOVDIRI and MOVDIR64B are published in the latest Intel Instruction Set Extensions document. Define the APIs for user or kernel to use the instructions. If feature enabled GCC is available in the future, implementation of the APIs will be changed to call the intrinsic

[RFC PATCH 5/8] x86/umwait.c: Add sysfs interface to show tsc_khz

2018-06-15 Thread Fenghua Yu
User wait process or any other process wants to know tsc frequency to convert seconds to tsc ticks. Kernel already gets tsc freqency in kernel internal variable tsc_khz. The sysfs interface /sys/devices/system/cpu/ user_mwait/tsc_khz exposes the internal variable tsc_khz in decimal to user.

[RFC PATCH 3/8] x86/cpufeatures: Enumerate UMONITOR, UMWAIT, and TPAUSE instructions

2018-06-15 Thread Fenghua Yu
UMONITOR, UMWAIT, and TPAUSE are a set of user wait instructions. UMONITOR arms address monitoring hardware using an address. A store to an address within the specified address range triggers the monitoring hardware to wake up the processor waiting in umwait. UMWAIT instructs the processor to

[RFC PATCH 0/8] x86: Enable a few new instructions

2018-06-15 Thread Fenghua Yu
A few new instructions including direct stores (movdiri and movdir64b) and user wait (umwait, umonitor, and tpause) and IA32_MWAIT_CONTROL MSR to control umwait/umonitor/tpause behaviors will be available in Tremont and other future x86 processors. This patch set enumerates the instructions, adds

[RFC PATCH 6/8] x86/lib_direct_store.h: Add APIs for direct store instructions

2018-06-15 Thread Fenghua Yu
Direct store instructions MOVDIRI and MOVDIR64B are published in the latest Intel Instruction Set Extensions document. Define the APIs for user or kernel to use the instructions. If feature enabled GCC is available in the future, implementation of the APIs will be changed to call the intrinsic

[RFC PATCH 5/8] x86/umwait.c: Add sysfs interface to show tsc_khz

2018-06-15 Thread Fenghua Yu
User wait process or any other process wants to know tsc frequency to convert seconds to tsc ticks. Kernel already gets tsc freqency in kernel internal variable tsc_khz. The sysfs interface /sys/devices/system/cpu/ user_mwait/tsc_khz exposes the internal variable tsc_khz in decimal to user.

[RFC PATCH 3/8] x86/cpufeatures: Enumerate UMONITOR, UMWAIT, and TPAUSE instructions

2018-06-15 Thread Fenghua Yu
UMONITOR, UMWAIT, and TPAUSE are a set of user wait instructions. UMONITOR arms address monitoring hardware using an address. A store to an address within the specified address range triggers the monitoring hardware to wake up the processor waiting in umwait. UMWAIT instructs the processor to

[RFC PATCH 0/8] x86: Enable a few new instructions

2018-06-15 Thread Fenghua Yu
A few new instructions including direct stores (movdiri and movdir64b) and user wait (umwait, umonitor, and tpause) and IA32_MWAIT_CONTROL MSR to control umwait/umonitor/tpause behaviors will be available in Tremont and other future x86 processors. This patch set enumerates the instructions, adds

[RFC PATCH 1/8] x86/cpufeatures: Enumerate MOVDIRI instruction

2018-06-15 Thread Fenghua Yu
MOVDIRI moves doubleword or quadword from register to memory through direct store which is implemented by using write combining (WC) for writing data directly into memory without caching the data. Availability of the MOVDIRI instruction is indicated by the presence of the CPUID feature flag

[RFC PATCH 2/8] x86/cpufeatures: Enumerate MOVDIR64B instruction

2018-06-15 Thread Fenghua Yu
MOVDIR64B moves 64-bytes as direct-store with 64-bytes write atomicity. Direct store is implemented by using write combining (WC) for writing data directly into memory without caching the data. Availability of the MOVDIR64B instruction is indicated by the presence of the CPUID feature flag

[RFC PATCH 1/8] x86/cpufeatures: Enumerate MOVDIRI instruction

2018-06-15 Thread Fenghua Yu
MOVDIRI moves doubleword or quadword from register to memory through direct store which is implemented by using write combining (WC) for writing data directly into memory without caching the data. Availability of the MOVDIRI instruction is indicated by the presence of the CPUID feature flag

[RFC PATCH 2/8] x86/cpufeatures: Enumerate MOVDIR64B instruction

2018-06-15 Thread Fenghua Yu
MOVDIR64B moves 64-bytes as direct-store with 64-bytes write atomicity. Direct store is implemented by using write combining (WC) for writing data directly into memory without caching the data. Availability of the MOVDIR64B instruction is indicated by the presence of the CPUID feature flag

Re: [PATCH 01/11] staging: lustre: simplify use of interval-tree.

2018-06-15 Thread James Simmons
> Lustre has a private interval-tree implementation. This > implementation (inexplicably) refuses to insert an interval if an > identical interval already exists. It is OK with all sorts of > overlapping intervals, but identical intervals are rejected. I talked to Oleg about this since this

Re: [PATCH 01/11] staging: lustre: simplify use of interval-tree.

2018-06-15 Thread James Simmons
> Lustre has a private interval-tree implementation. This > implementation (inexplicably) refuses to insert an interval if an > identical interval already exists. It is OK with all sorts of > overlapping intervals, but identical intervals are rejected. I talked to Oleg about this since this

[git pull] vfs.git afs stuff from dhowells (mostly procfs followups)

2018-06-15 Thread Al Viro
Assorted AFS stuff - ended up in vfs.git since most of that consists of David's AFS-related followups to Christoph's procfs series. The following changes since commit 96362fb474bad694812c18cbc9943fe0f7e2ce31: isdn/gigaset: add back gigaset_procinfo assignment (2018-05-17 19:59:55

[git pull] vfs.git afs stuff from dhowells (mostly procfs followups)

2018-06-15 Thread Al Viro
Assorted AFS stuff - ended up in vfs.git since most of that consists of David's AFS-related followups to Christoph's procfs series. The following changes since commit 96362fb474bad694812c18cbc9943fe0f7e2ce31: isdn/gigaset: add back gigaset_procinfo assignment (2018-05-17 19:59:55

[git pull] vfs.git - misc compat stuff

2018-06-15 Thread Al Viro
Some biarch patches - getting rid of assorted compat_alloc_user_space() (mis)uses. Not much in that area this cycle... The following changes since commit 4faa99965e027cc057c5145ce45fa772caa04e8d: fix io_destroy()/aio_complete() race (2018-05-23 22:53:22 -0400) are available in the

Re: [PATCH] mm: skip invalid pages block at a time in zero_resv_unresv

2018-06-15 Thread Pavel Tatashin
On Fri, Jun 15, 2018 at 5:48 PM Andrew Morton wrote: > > On Fri, 15 Jun 2018 11:57:33 -0400 Pavel Tatashin > wrote: > > > The role of zero_resv_unavail() is to make sure that every struct page that > > is allocated but is not backed by memory that is accessible by kernel is > > zeroed and not

[git pull] vfs.git - misc compat stuff

2018-06-15 Thread Al Viro
Some biarch patches - getting rid of assorted compat_alloc_user_space() (mis)uses. Not much in that area this cycle... The following changes since commit 4faa99965e027cc057c5145ce45fa772caa04e8d: fix io_destroy()/aio_complete() race (2018-05-23 22:53:22 -0400) are available in the

Re: [PATCH] mm: skip invalid pages block at a time in zero_resv_unresv

2018-06-15 Thread Pavel Tatashin
On Fri, Jun 15, 2018 at 5:48 PM Andrew Morton wrote: > > On Fri, 15 Jun 2018 11:57:33 -0400 Pavel Tatashin > wrote: > > > The role of zero_resv_unavail() is to make sure that every struct page that > > is allocated but is not backed by memory that is accessible by kernel is > > zeroed and not

[git pull] vfs.git - more aio followups

2018-06-15 Thread Al Viro
Assorted AIO followups and fixes. The following changes since commit 9a6d9a62e0fd4b9927c3124db0f25fc6b4fb6576: fs: aio ioprio use ioprio_check_cap ret val (2018-06-04 14:20:39 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git

[git pull] vfs.git - more aio followups

2018-06-15 Thread Al Viro
Assorted AIO followups and fixes. The following changes since commit 9a6d9a62e0fd4b9927c3124db0f25fc6b4fb6576: fs: aio ioprio use ioprio_check_cap ret val (2018-06-04 14:20:39 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git

[PATCH v4] staging: rtl8192u: add error handling for usb_alloc_urb

2018-06-15 Thread Zhouyang Jia
When usb_alloc_urb fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling usb_alloc_urb. Signed-off-by: Zhouyang Jia --- v1->v2: - Fix memory leak. v2->v3: - Release memory in error path. v3->v4: - Use kcalloc instead of

[PATCH v4] staging: rtl8192u: add error handling for usb_alloc_urb

2018-06-15 Thread Zhouyang Jia
When usb_alloc_urb fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling usb_alloc_urb. Signed-off-by: Zhouyang Jia --- v1->v2: - Fix memory leak. v2->v3: - Release memory in error path. v3->v4: - Use kcalloc instead of

[PATCH] sysfs: Fix internal_create_group() for named group updates

2018-06-15 Thread Rajat Jain
There are a couple of problems with named group updates in the code today: * sysfs_update_group() will always fail for a named group, because internal_create_group() will try to create a new sysfs directory unconditionally, which will ofcourse fail with -EEXIST. * We can leak the kernfs_node

[PATCH] sysfs: Fix internal_create_group() for named group updates

2018-06-15 Thread Rajat Jain
There are a couple of problems with named group updates in the code today: * sysfs_update_group() will always fail for a named group, because internal_create_group() will try to create a new sysfs directory unconditionally, which will ofcourse fail with -EEXIST. * We can leak the kernfs_node

Re: [PATCH v1 1/2] perf/core: Use sysctl to turn on/off dropping leaked kernel samples

2018-06-15 Thread Linus Torvalds
On Fri, Jun 15, 2018 at 8:36 PM Mark Rutland wrote: > > At least for sampling the GPRs, we could do something like below > unconditionally, which seems sufficient for my test cases. Ack. The PEBS case may need checking, but maybe PEBS doesn't even have this issue? Linus

Re: [PATCH v1 1/2] perf/core: Use sysctl to turn on/off dropping leaked kernel samples

2018-06-15 Thread Linus Torvalds
On Fri, Jun 15, 2018 at 8:36 PM Mark Rutland wrote: > > At least for sampling the GPRs, we could do something like below > unconditionally, which seems sufficient for my test cases. Ack. The PEBS case may need checking, but maybe PEBS doesn't even have this issue? Linus

Re: [PATCH v1 0/2] perf: Drop leaked kernel samples

2018-06-15 Thread Jin, Yao
On 6/16/2018 8:56 AM, Kyle Huey wrote: On Fri, Jun 15, 2018 at 5:50 PM, Jin, Yao wrote: Hi All, This patch raised many questions, I was prepared. :) I'd like to try another proposal that it adds a special flag in the returned perf_sample_data to indicate the perf binary that this sample

Re: [PATCH v1 0/2] perf: Drop leaked kernel samples

2018-06-15 Thread Jin, Yao
On 6/16/2018 8:56 AM, Kyle Huey wrote: On Fri, Jun 15, 2018 at 5:50 PM, Jin, Yao wrote: Hi All, This patch raised many questions, I was prepared. :) I'd like to try another proposal that it adds a special flag in the returned perf_sample_data to indicate the perf binary that this sample

Re: [PATCH v1 0/2] perf: Drop leaked kernel samples

2018-06-15 Thread Kyle Huey
On Fri, Jun 15, 2018 at 5:50 PM, Jin, Yao wrote: > Hi All, > > This patch raised many questions, I was prepared. :) > > I'd like to try another proposal that it adds a special flag in the returned > perf_sample_data to indicate the perf binary that this sample is a leaked > sample. > > For

Re: [PATCH v1 0/2] perf: Drop leaked kernel samples

2018-06-15 Thread Kyle Huey
On Fri, Jun 15, 2018 at 5:50 PM, Jin, Yao wrote: > Hi All, > > This patch raised many questions, I was prepared. :) > > I'd like to try another proposal that it adds a special flag in the returned > perf_sample_data to indicate the perf binary that this sample is a leaked > sample. > > For

Re: [PATCH v1 0/2] perf: Drop leaked kernel samples

2018-06-15 Thread Jin, Yao
Hi All, This patch raised many questions, I was prepared. :) I'd like to try another proposal that it adds a special flag in the returned perf_sample_data to indicate the perf binary that this sample is a leaked sample. For example, create a new PERF_SAMPLE_RETURN_LEAKAGE in

Re: [PATCH v1 0/2] perf: Drop leaked kernel samples

2018-06-15 Thread Jin, Yao
Hi All, This patch raised many questions, I was prepared. :) I'd like to try another proposal that it adds a special flag in the returned perf_sample_data to indicate the perf binary that this sample is a leaked sample. For example, create a new PERF_SAMPLE_RETURN_LEAKAGE in

Re: [PATCH] mm/memblock: add missing include

2018-06-15 Thread Luck, Tony
This both compiles and boots on ia64. Builds OK on x86_64 with an Enterprise OS .config that includes: CONFIG_HAVE_MEMBLOCK=y CONFIG_NO_BOOTMEM=y -Tony diff --git a/mm/memblock.c b/mm/memblock.c index cc16d70b8333..0a54d488f767 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1225,6

Re: [PATCH] mm/memblock: add missing include

2018-06-15 Thread Luck, Tony
This both compiles and boots on ia64. Builds OK on x86_64 with an Enterprise OS .config that includes: CONFIG_HAVE_MEMBLOCK=y CONFIG_NO_BOOTMEM=y -Tony diff --git a/mm/memblock.c b/mm/memblock.c index cc16d70b8333..0a54d488f767 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1225,6

Re: [PATCH v3] staging: rtl8192u: add error handling for usb_alloc_urb

2018-06-15 Thread Kees Cook
On Fri, Jun 15, 2018 at 10:28 AM, Zhouyang Jia wrote: > When usb_alloc_urb fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling usb_alloc_urb. > > Signed-off-by: Zhouyang Jia > --- > v1->v2: > - Fix memory leak. > v2->v3: >

Re: [PATCH v3] staging: rtl8192u: add error handling for usb_alloc_urb

2018-06-15 Thread Kees Cook
On Fri, Jun 15, 2018 at 10:28 AM, Zhouyang Jia wrote: > When usb_alloc_urb fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling usb_alloc_urb. > > Signed-off-by: Zhouyang Jia > --- > v1->v2: > - Fix memory leak. > v2->v3: >

Re: [patch] mm, oom: fix unnecessary killing of additional processes

2018-06-15 Thread David Rientjes
On Fri, 15 Jun 2018, Michal Hocko wrote: > > Signed-off-by: David Rientjes > > Nacked-by: Michal Hocko > as already explained elsewhere in this email thread. > I don't find this to be surprising, but I'm not sure that it actually matters if you won't fix a regression that you introduced.

Re: [patch] mm, oom: fix unnecessary killing of additional processes

2018-06-15 Thread David Rientjes
On Fri, 15 Jun 2018, Michal Hocko wrote: > > Signed-off-by: David Rientjes > > Nacked-by: Michal Hocko > as already explained elsewhere in this email thread. > I don't find this to be surprising, but I'm not sure that it actually matters if you won't fix a regression that you introduced.

Re: [PATCH] slub: fix failure when we delete and create a slab cache

2018-06-15 Thread Andrew Morton
On Fri, 15 Jun 2018 18:25:29 -0400 (EDT) Mikulas Patocka wrote: > In the kernel 4.17 I removed some code from dm-bufio that did slab cache > merging (21bb13276768) - both slab and slub support merging caches with > identical attributes, so dm-bufio now just calls kmem_cache_create and > relies

Re: [PATCH] slub: fix failure when we delete and create a slab cache

2018-06-15 Thread Andrew Morton
On Fri, 15 Jun 2018 18:25:29 -0400 (EDT) Mikulas Patocka wrote: > In the kernel 4.17 I removed some code from dm-bufio that did slab cache > merging (21bb13276768) - both slab and slub support merging caches with > identical attributes, so dm-bufio now just calls kmem_cache_create and > relies

[RFC v6 1/1] mconf: global i-search in menu structure

2018-06-15 Thread Dirk Gouders
This patch implements an i-search navigation concept for mconf based on an idea of Sam Ravnborg: * mconf now distinguishes if the focus is on the menu items or the buttons below it. * At startup focus is on the menu items and printable characters (details see below) entered are used to form

[RFC v6 1/1] mconf: global i-search in menu structure

2018-06-15 Thread Dirk Gouders
This patch implements an i-search navigation concept for mconf based on an idea of Sam Ravnborg: * mconf now distinguishes if the focus is on the menu items or the buttons below it. * At startup focus is on the menu items and printable characters (details see below) entered are used to form

[RFC v6 0/1] mconf: global i-search in menu structure

2018-06-15 Thread Dirk Gouders
Hello, version 6 of this RFC was mainly influenced by a discussion with Randy Dunlap about a patch for i-search in nconf. In that discussion I stated that it would be a lot of work to implement a global i-search but while thinking about that statement afterwards, I realized that most of the

[RFC v6 0/1] mconf: global i-search in menu structure

2018-06-15 Thread Dirk Gouders
Hello, version 6 of this RFC was mainly influenced by a discussion with Randy Dunlap about a patch for i-search in nconf. In that discussion I stated that it would be a lot of work to implement a global i-search but while thinking about that statement afterwards, I realized that most of the

[PATCH] slub: fix failure when we delete and create a slab cache

2018-06-15 Thread Mikulas Patocka
In the kernel 4.17 I removed some code from dm-bufio that did slab cache merging (21bb13276768) - both slab and slub support merging caches with identical attributes, so dm-bufio now just calls kmem_cache_create and relies on implicit merging. This uncovered a bug in the slub subsystem - if we

Re: [PATCH] mm/memblock: add missing include

2018-06-15 Thread Tony Luck
On Fri, Jun 15, 2018 at 12:17 PM, Andrew Morton wrote: > Huh. How did that ever work. I guess it's either this: > > --- a/mm/Makefile~a > +++ a/mm/Makefile > @@ -45,6 +45,7 @@ obj-y += init-mm.o > > ifdef CONFIG_NO_BOOTMEM > obj-y += nobootmem.o > +

Re: [PATCH] mm/memblock: add missing include

2018-06-15 Thread Tony Luck
On Fri, Jun 15, 2018 at 12:17 PM, Andrew Morton wrote: > Huh. How did that ever work. I guess it's either this: > > --- a/mm/Makefile~a > +++ a/mm/Makefile > @@ -45,6 +45,7 @@ obj-y += init-mm.o > > ifdef CONFIG_NO_BOOTMEM > obj-y += nobootmem.o > +

[PATCH] slub: fix failure when we delete and create a slab cache

2018-06-15 Thread Mikulas Patocka
In the kernel 4.17 I removed some code from dm-bufio that did slab cache merging (21bb13276768) - both slab and slub support merging caches with identical attributes, so dm-bufio now just calls kmem_cache_create and relies on implicit merging. This uncovered a bug in the slub subsystem - if we

[PATCH] ASoC: tegra: fix device_node refcounting

2018-06-15 Thread Alexey Khoroshilov
tegra_rt5677_probe() gets a couple of device nodes with of_parse_phandle(), but there is no release of them. The patch adds the release to tegra_rt5677_remove() and to error handling paths in the probe. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey

[PATCH] ASoC: tegra: fix device_node refcounting

2018-06-15 Thread Alexey Khoroshilov
tegra_rt5677_probe() gets a couple of device nodes with of_parse_phandle(), but there is no release of them. The patch adds the release to tegra_rt5677_remove() and to error handling paths in the probe. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey

[PATCH] configfs: Use kvasprintf() instead of open-coding it

2018-06-15 Thread Bart Van Assche
Signed-off-by: Bart Van Assche --- fs/configfs/item.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/fs/configfs/item.c b/fs/configfs/item.c index 88f266efc09b..99d491cd01f9 100644 --- a/fs/configfs/item.c +++ b/fs/configfs/item.c @@ -64,7 +64,6 @@

[PATCH] configfs: Use kvasprintf() instead of open-coding it

2018-06-15 Thread Bart Van Assche
Signed-off-by: Bart Van Assche --- fs/configfs/item.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/fs/configfs/item.c b/fs/configfs/item.c index 88f266efc09b..99d491cd01f9 100644 --- a/fs/configfs/item.c +++ b/fs/configfs/item.c @@ -64,7 +64,6 @@

Re: [PATCH v6 2/4] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-06-15 Thread Rob Herring
On Fri, Jun 15, 2018 at 7:30 AM, Matti Vaittinen wrote: > Document devicetree bindings for ROHM BD71837 PMIC MFD. > > Signed-off-by: Matti Vaittinen > --- > .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 67 > ++ > 1 file changed, 67 insertions(+) > create mode

Re: [PATCH v6 2/4] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-06-15 Thread Rob Herring
On Fri, Jun 15, 2018 at 7:30 AM, Matti Vaittinen wrote: > Document devicetree bindings for ROHM BD71837 PMIC MFD. > > Signed-off-by: Matti Vaittinen > --- > .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 67 > ++ > 1 file changed, 67 insertions(+) > create mode

Re: [RFC PATCH 3/6] serial: 8250_omap: Add support for AM654 UART controller

2018-06-15 Thread Rob Herring
On Fri, Jun 15, 2018 at 11:17 AM, Sekhar Nori wrote: > Hi Rob, > > On Wednesday 13 June 2018 02:36 AM, Rob Herring wrote: >> On Tue, Jun 05, 2018 at 01:01:22AM -0500, Nishanth Menon wrote: >>> AM654 uses a UART controller that is compatible (partially) with >>> existing 8250 UART, however, has a

Re: [RFC PATCH 3/6] serial: 8250_omap: Add support for AM654 UART controller

2018-06-15 Thread Rob Herring
On Fri, Jun 15, 2018 at 11:17 AM, Sekhar Nori wrote: > Hi Rob, > > On Wednesday 13 June 2018 02:36 AM, Rob Herring wrote: >> On Tue, Jun 05, 2018 at 01:01:22AM -0500, Nishanth Menon wrote: >>> AM654 uses a UART controller that is compatible (partially) with >>> existing 8250 UART, however, has a

[PATCH] uio: ensure class is registered before devices

2018-06-15 Thread Alexandre Belloni
When both uio and the uio drivers are built in the kernel, it is possible for a driver to register devices before the uio class is registered. This may result in a NULL pointer dereference later on in get_device_parent() when accessing the class glue_dirs spinlock. The trace looks like that:

[PATCH] uio: ensure class is registered before devices

2018-06-15 Thread Alexandre Belloni
When both uio and the uio drivers are built in the kernel, it is possible for a driver to register devices before the uio class is registered. This may result in a NULL pointer dereference later on in get_device_parent() when accessing the class glue_dirs spinlock. The trace looks like that:

Re: [PATCH] mm: skip invalid pages block at a time in zero_resv_unresv

2018-06-15 Thread Andrew Morton
On Fri, 15 Jun 2018 11:57:33 -0400 Pavel Tatashin wrote: > The role of zero_resv_unavail() is to make sure that every struct page that > is allocated but is not backed by memory that is accessible by kernel is > zeroed and not in some uninitialized state. > > Since struct pages are allocated

Re: [PATCH] mm: skip invalid pages block at a time in zero_resv_unresv

2018-06-15 Thread Andrew Morton
On Fri, 15 Jun 2018 11:57:33 -0400 Pavel Tatashin wrote: > The role of zero_resv_unavail() is to make sure that every struct page that > is allocated but is not backed by memory that is accessible by kernel is > zeroed and not in some uninitialized state. > > Since struct pages are allocated

Re: [PATCH v3 6/7] soc: qcom: Add RPMh Power domain driver

2018-06-15 Thread David Collins
Hello Ulf, On 06/15/2018 02:25 AM, Ulf Hansson wrote: > On 14 June 2018 at 20:17, David Collins wrote: >> On 06/13/2018 11:54 PM, Rajendra Nayak wrote: >>> On 06/14/2018 06:02 AM, David Collins wrote: On 06/11/2018 09:40 PM, Rajendra Nayak wrote: >> ... > +static int

Re: [PATCH v3 6/7] soc: qcom: Add RPMh Power domain driver

2018-06-15 Thread David Collins
Hello Ulf, On 06/15/2018 02:25 AM, Ulf Hansson wrote: > On 14 June 2018 at 20:17, David Collins wrote: >> On 06/13/2018 11:54 PM, Rajendra Nayak wrote: >>> On 06/14/2018 06:02 AM, David Collins wrote: On 06/11/2018 09:40 PM, Rajendra Nayak wrote: >> ... > +static int

[PATCH v3 1/1] shiftfs: uid/gid shifting bind mount

2018-06-15 Thread James Bottomley
This allows any subtree to be uid/gid shifted and bound elsewhere. It does this by operating simlarly to overlayfs. Its primary use is for shifting the underlying uids of filesystems used to support unpriviliged (uid shifted) containers. The usual use case here is that the container is

[PATCH v3 1/1] shiftfs: uid/gid shifting bind mount

2018-06-15 Thread James Bottomley
This allows any subtree to be uid/gid shifted and bound elsewhere. It does this by operating simlarly to overlayfs. Its primary use is for shifting the underlying uids of filesystems used to support unpriviliged (uid shifted) containers. The usual use case here is that the container is

[PATCH v3 0/1] shiftfs: uid/gid shifting filesystem

2018-06-15 Thread James Bottomley
This is a repost of the v2 patch updated for the d_real changes For those who want to test it out, there's a git tree here git://git.kernel.org/pub/scm/linux/kernel/git/jejb/binfmt_misc.git on the shiftfs-v3 branch v2: This is a rewrite of the original shiftfs code to make use of super block

[PATCH v3 0/1] shiftfs: uid/gid shifting filesystem

2018-06-15 Thread James Bottomley
This is a repost of the v2 patch updated for the d_real changes For those who want to test it out, there's a git tree here git://git.kernel.org/pub/scm/linux/kernel/git/jejb/binfmt_misc.git on the shiftfs-v3 branch v2: This is a rewrite of the original shiftfs code to make use of super block

Re: [PATCH v3 01/12] PM / devfreq: Init user limits from OPP limits, not viceversa

2018-06-15 Thread Matthias Kaehlcke
On Fri, Jun 15, 2018 at 02:06:21PM -0700, Brian Norris wrote: > Hi, > > On Thu, Jun 14, 2018 at 12:47:01PM -0700, Matthias Kaehlcke wrote: > > Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding > > the devfreq device") introduced the initialization of the user > > limits

Re: [PATCH v3 01/12] PM / devfreq: Init user limits from OPP limits, not viceversa

2018-06-15 Thread Matthias Kaehlcke
On Fri, Jun 15, 2018 at 02:06:21PM -0700, Brian Norris wrote: > Hi, > > On Thu, Jun 14, 2018 at 12:47:01PM -0700, Matthias Kaehlcke wrote: > > Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding > > the devfreq device") introduced the initialization of the user > > limits

clang: objtool: native_machine_emergency_restart() falls through to next function

2018-06-15 Thread Matthias Kaehlcke
Hi Josh, with your work on objtool and the upcoming implementation of -fno-delete-null-pointer-checks (https://reviews.llvm.org/D47894, https://reviews.llvm.org/D47895) in clang most objtool warnings for clang builds will be fixed. However even with -fno-delete-null-pointer-checks we currently

clang: objtool: native_machine_emergency_restart() falls through to next function

2018-06-15 Thread Matthias Kaehlcke
Hi Josh, with your work on objtool and the upcoming implementation of -fno-delete-null-pointer-checks (https://reviews.llvm.org/D47894, https://reviews.llvm.org/D47895) in clang most objtool warnings for clang builds will be fixed. However even with -fno-delete-null-pointer-checks we currently

  1   2   3   4   5   6   7   8   >