Re: [PATCH v2] IB/mlx5: fix uaccess beyond "count" in debugfs read/write handlers

2018-07-07 Thread Leon Romanovsky
On Fri, Jul 06, 2018 at 10:48:03PM +0200, Jann Horn wrote: > In general, accessing userspace memory beyond the length of the supplied > buffer in VFS read/write handlers can lead to both kernel memory corruption > (via kernel_read()/kernel_write(), which can e.g. be triggered via > sys_splice()) an

[PATCH] Fix the oldconfig target rule

2018-07-07 Thread Bernd Edlinger
The next make after an oldconfig reads in the outdated include/config/auto.conf which can kill the make before it is able to call the syncconfig target. $ make defconfig *** Default configuration is based on 'x86_64_defconfig' $ make scripts/kconfig/conf --syncconfig Kconfig Makefile:936: *** "Ca

Re: [PATCH 16/25] ubifs: authenticate replayed journal

2018-07-07 Thread kbuild test robot
Hi Sascha, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.18-rc3 next-20180706] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[GIT PULL] ext4 fixes for 4.18

2018-07-07 Thread Theodore Y. Ts'o
The following changes since commit 4f2f76f751433908364ccff82f437a57d0e6e9b7: ext4: fix fencepost error in check for inode count overflow during resize (2018-05-25 12:51:25 -0400) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git tags/ext4_

[GIT PULL] PCI fixes for v4.18

2018-07-07 Thread Bjorn Helgaas
PCI fixes: - Fix a use-after-free in the endpoint code (Dan Carpenter) - Stop defaulting CONFIG_PCIE_DW_PLAT_HOST to yes (Geert Uytterhoeven) - Fix an nfp regression caused by a change in how we limit the number of VFs we can enable (Jakub Kicinski) - Fix failure path cleanup iss

Re: [PATCH 14/25] ubifs: Add authentication nodes to journal

2018-07-07 Thread kbuild test robot
Hi Sascha, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.18-rc3 next-20180706] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH 1/1] Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic

2018-07-07 Thread kys
From: Sunil Muthuswamy In the VM mode on Hyper-V, currently, when the kernel panics, an error code and few register values are populated in an MSR and the Hypervisor notified. This information is collected on the host. The amount of information currently collected is found to be limited and not v

Re: [PATCH 6/7] treewide: Rename HOST_LOADLIBES to KBUILD_HOSTLDLIBS

2018-07-07 Thread Masahiro Yamada
2018-07-07 10:07 GMT+09:00 Laura Abbott : > In preparation for enabling command line LDLIBS, re-name HOST_LOADLIBES to > KBUILD_HOSTLDLIBS as the internal use only flags. This should not have any > visible effects. > > Signed-off-by: Laura Abbott > --- > Makefile | 4 ++-- > samples

Re: [PATCH 7/7] Kbuild: Use HOST*FLAGS options from the command line

2018-07-07 Thread Masahiro Yamada
2018-07-07 10:07 GMT+09:00 Laura Abbott : > Now that we have the rename in place, reuse the HOST*FLAGS options as > something that can be set from the command line and included with the > rest of the flags. > > Signed-off-by: Laura Abbott > --- > Makefile | 9 + > 1 file changed, 5 insert

Re: [PATCH 4/7] treewide: Rename HOSTCXXFLAGS to KBUILD_HOSTCXXFLAGS

2018-07-07 Thread Masahiro Yamada
2018-07-07 10:07 GMT+09:00 Laura Abbott : > > In preparation for enabling command line CXXFLAGS, re-name HOSTCXXFLAGS to > KBUILD_HOSTCXXFLAGS as the internal use only flags. This should not have any > visible effects. > > Signed-off-by: Laura Abbott > --- > Makefile | 4 ++-- > s

Re: [PATCH 3/7] treewide: Rename HOSTCFLAGS -> KBUILD_HOSTCFLAGS

2018-07-07 Thread Masahiro Yamada
2018-07-07 10:07 GMT+09:00 Laura Abbott : > In preparation for enabling command line CFLAGS, re-name HOSTCFLAGS to > KBUILD_HOSTCFLAGS as the internal use only flags. This should not have any > visible effects. > > Signed-off-by: Laura Abbott > --- > Makefile | 4 ++-- > arch/a

Re: kconfig usage in automatic kernel test

2018-07-07 Thread Masahiro Yamada
2018-07-06 17:49 GMT+09:00 Cao jin : > Masahiro-san, > > I am writing some utility for internal kdump test with latest kernel, > my purpose is to test the new introduced kernel feature. For automatical > test, I see several config target could help, like olddefconfig, all*config. > > But for my p

Re: [PATCH v6 0/5] mm/sparse: Optimize memmap allocation during sparse_init()

2018-07-07 Thread Baoquan He
Hi Andrew, Could you pick this series into mm tree so that it can catch 4.18? Thanks Baoquan On 06/28/18 at 02:28pm, Baoquan He wrote: > This is v6 post. > > In sparse_init(), two temporary pointer arrays, usemap_map and map_map > are allocated with the size of NR_MEM_SECTIONS. They are used to

Re: [PATCH resend] scripts: teach extract-vmlinux about LZ4 and ZSTD

2018-07-07 Thread Masahiro Yamada
2018-07-07 9:15 GMT+09:00 Adam Borowski : > Note that the LZ4 signature is different than that of modern LZ4 as we > use the "legacy" format which suffers from some downsides like inability > to disable compression. > > Signed-off-by: Adam Borowski > --- > The first time this was sent I managed to

kernel BUG at fs/super.c:LINE!

2018-07-07 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:526674536360 Add linux-next specific files for 20180706 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1443b16840 kernel config: https://syzkaller.appspot.com/x/.config?x=c8d1cfc0cb798e48 dashb

Re: [PATCH V2 11/19] csky: Atomic operations

2018-07-07 Thread Guo Ren
On Sat, Jul 07, 2018 at 10:10:24PM +0200, Andrea Parri wrote: > On Sat, Jul 07, 2018 at 04:08:47PM +0800, Guo Ren wrote: > > On Fri, Jul 06, 2018 at 02:17:16PM +0200, Peter Zijlstra wrote: > > > CPU0CPU1 > > > > WRITE_ONCE(x, 1)WRITE_ONCE(y, 1) > > r0 = xch

Re: KASAN: use-after-free Read in iput

2018-07-07 Thread Eric Biggers
On Tue, Apr 17, 2018 at 06:02:02PM -0700, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > a27fc14219f2e3c4a46ba9177b04d9b52c875532 (Mon Apr 16 21:07:39 2018 +) > Merge branch 'parisc-4.17-3' of > git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux >

Re: [PATCH V2 11/19] csky: Atomic operations

2018-07-07 Thread Guo Ren
On Sat, Jul 07, 2018 at 09:54:37PM +0200, Andrea Parri wrote: > Hi Guo, > > On Sat, Jul 07, 2018 at 03:42:10PM +0800, Guo Ren wrote: > > On Fri, Jul 06, 2018 at 01:56:14PM +0200, Peter Zijlstra wrote: > > > CPU0CPU1 > > > > > > r1 = READ_ONCE(x); WRITE_ONCE(y, 1); > >

[PATCH v3] driver core: add a debugfs entry to show deferred devices

2018-07-07 Thread Javier Martinez Canillas
With Device Trees (DT), the dependencies of the devices are defined in the DT, then the drivers parse that information to lookup the needed resources that have as dependencies. Since drivers and devices are registered in a non-deterministic way, it is possible that a device that is a dependency ha

Re: [PATCH v2] driver core: add a debugfs entry to show deferred devices

2018-07-07 Thread Javier Martinez Canillas
Hi Greg, On 07/07/2018 05:59 PM, Greg Kroah-Hartman wrote: > On Thu, Jun 28, 2018 at 12:06:56AM +0200, Javier Martinez Canillas wrote: >> With Device Trees (DT), the dependencies of the devices are defined in the >> DT, then the drivers parse that information to lookup the needed resources >> that

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-07 Thread Srinivas Pandruvada
On Sat, 2018-07-07 at 19:24 +0300, Andy Shevchenko wrote: > On Sat, Jul 7, 2018 at 6:48 AM, wrote: > > > I strongly advocate for vendors to have more control over their > > > drivers, > > > but this scenario really frustrates me. I don't think I can > > > justify this > > > to Linus as a fix. But

Re: [PATCH -mm -v4 03/21] mm, THP, swap: Support PMD swap mapping in swap_duplicate()

2018-07-07 Thread Dan Williams
On Thu, Jun 21, 2018 at 8:55 PM Huang, Ying wrote: > > From: Huang Ying > > To support to swapin the THP as a whole, we need to create PMD swap > mapping during swapout, and maintain PMD swap mapping count. This > patch implements the support to increase the PMD swap mapping > count (for swapout

[no subject]

2018-07-07 Thread Venkat Subbiah
hi Linux https://goo.gl/MD9TK5 Venkat Subbiah

Re: [PATCH 4.17 00/46] 4.17.5-stable review

2018-07-07 Thread Guenter Roeck
On Fri, Jul 06, 2018 at 07:46:21AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.17.5 release. > There are 46 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know.

Re: [PATCH 4.14 00/61] 4.14.54-stable review

2018-07-07 Thread Guenter Roeck
On Fri, Jul 06, 2018 at 07:46:24AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.54 release. > There are 61 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH 5/7] proc/kcore: clean up ELF header generation

2018-07-07 Thread Omar Sandoval
rong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Omar-Sandoval/proc-kcore-improvements/20180707-052548 > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig >

Re: [PATCH] watchdog: stm32: replace "%p" with "%pK"

2018-07-07 Thread Guenter Roeck
On Fri, Jul 06, 2018 at 03:08:08PM +0200, Benjamin Gaignard wrote: > The format specifier "%p" can leak kernel addresses. > Use "%pK" instead. > The pointer has zero value either way. If the clock has a name, it might make sense to display it. Otherwise just drop the pointer. Guenter > Signed-of

Re: [PATCH 1/7] mm: allocate mm_cpumask dynamically based on nr_cpu_ids

2018-07-07 Thread Rik van Riel
I. On Sat, 2018-07-07 at 10:23 +0200, Mike Galbraith wrote: > On Fri, 2018-07-06 at 17:56 -0400, Rik van Riel wrote: > > The mm_struct always contains a cpumask bitmap, regardless of > > CONFIG_CPUMASK_OFFSTACK. That means the first step can be to > > simplify things, and simply have one bitmask

Re: [PATCH 5/7] x86,tlb: only send page table free TLB flush to lazy TLB CPUs

2018-07-07 Thread Rik van Riel
On Sat, 2018-07-07 at 14:26 +0200, Mike Galbraith wrote: > On Fri, 2018-06-29 at 10:29 -0400, Rik van Riel wrote: > > diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c > > index e59214ec52b1..c4073367219d 100644 > > --- a/arch/x86/mm/tlb.c > > +++ b/arch/x86/mm/tlb.c > > @@ -718,14 +718,47 @@ void

Re: [PATCH] watchdog: add module parameter "force_no_reboot" for iTCO

2018-07-07 Thread Guenter Roeck
On Fri, Jul 06, 2018 at 06:25:17AM +, Tian, Baofeng wrote: > Hi, Roeck > > This is an interface from android, with this interface, android can avoid > reboot if user want to make it. > the watchdog use space daemon you mentioned is always there in android, and > if remove/disable this daemon

[PATCH] arm: perf: prevent unbind/bind via sysfs

2018-07-07 Thread Stefan Agner
Unbinding and rebinding the ARM PMU driver via sysfs leads to a warning followed by more errors: WARNING: CPU: 0 PID: 217 at kernel/irq/chip.c:1034 irq_modify_status+0x150/0x16c .. genirq: Flags mismatch irq 19. 00010c04 (arm-pmu) vs. 00010c04 (arm-pmu) hw perfevents: unable to request IRQ

Re: [PATCH 5/5] thunderbolt: Add support for runtime PM

2018-07-07 Thread Lukas Wunner
On Mon, Jun 18, 2018 at 02:07:31PM +0300, Mika Westerberg wrote: > Implement this using standard Linux runtime PM APIs so that when all the > children devices are runtime suspended, the Thunderbolt host controller > PCI device is runtime suspended as well. The ICM firmware then starts > powering do

Re: [PATCH -mm -v4 02/21] mm, THP, swap: Make CONFIG_THP_SWAP depends on CONFIG_SWAP

2018-07-07 Thread Dan Williams
On Thu, Jun 21, 2018 at 8:55 PM Huang, Ying wrote: > > From: Huang Ying > > It's unreasonable to optimize swapping for THP without basic swapping > support. And this will cause build errors when THP_SWAP functions are > defined in swapfile.c and called elsewhere. > > The comments are fixed too t

Re: [PATCH -mm -v4 01/21] mm, THP, swap: Enable PMD swap operations for CONFIG_THP_SWAP

2018-07-07 Thread Dan Williams
On Thu, Jun 21, 2018 at 8:55 PM Huang, Ying wrote: > > From: Huang Ying > > Previously, the PMD swap operations are only enabled for > CONFIG_ARCH_ENABLE_THP_MIGRATION. Because they are only used by the > THP migration support. We will support PMD swap mapping to the huge > swap cluster and swa

[PATCH char-misc-testing] headers: fix build error in arch/arm/plat-samsung/adc.c, add

2018-07-07 Thread Randy Dunlap
From: Randy Dunlap arch/arm/plat-samsung/adc.c needs to #include explicitly since that header file was removed from (it wasn't needed there). Reported-by: kbuild test robot Signed-off-by: Randy Dunlap --- arch/arm/plat-samsung/adc.c |1 + 1 file changed, 1 insertion(+) --- linux-next-2

[PATCH] reiserfs: fix buffer overflow with long warning messages

2018-07-07 Thread Eric Biggers
From: Eric Biggers ReiserFS prepares log messages into a 1024-byte buffer with no bounds checks. Long messages, such as the "unknown mount option" warning when userspace passes a crafted mount options string, overflow this buffer. This causes KASAN to report a global-out-of-bounds write. Fix it

Re: [PATCH V2 11/19] csky: Atomic operations

2018-07-07 Thread Andrea Parri
On Sat, Jul 07, 2018 at 04:08:47PM +0800, Guo Ren wrote: > On Fri, Jul 06, 2018 at 02:17:16PM +0200, Peter Zijlstra wrote: > CPU0CPU1 > > WRITE_ONCE(x, 1)WRITE_ONCE(y, 1) > r0 = xchg(&y, 2)r1 = xchg(&x, 2) > > must not allow: r0==0 && r1==0 >

[PATCH v1] samples: fix compilatin of mpssd

2018-07-07 Thread Constantine Shulyupin
Errors: In file included from /usr/include/x86_64-linux-gnu/sys/types.h:194:0, from /usr/include/stdlib.h:394, from mpssd.c:23: mpssd.c:93:10: error: initializer element is not constant .num = htole16(MIC_VRING_ENTRIES), mpssd.c:610:10: warning: implicit decla

Re: [PATCH V2 11/19] csky: Atomic operations

2018-07-07 Thread Andrea Parri
Hi Guo, On Sat, Jul 07, 2018 at 03:42:10PM +0800, Guo Ren wrote: > On Fri, Jul 06, 2018 at 01:56:14PM +0200, Peter Zijlstra wrote: > > CPU0CPU1 > > > > r1 = READ_ONCE(x); WRITE_ONCE(y, 1); > > r2 = xchg(&y, 2); smp_store_release(&x, 1); > > > > must not

[PATCH v2 1/2] ARM: dts: pxa: add pincontrol helpers

2018-07-07 Thread Robert Jarzmik
Add 3 helpers so that pincontrol definitions for pxa25x and pxa27x are easier, and can be easily converted from old mfp mach-pxa code to devicetree. An example of such conversion would be : static unsigned long mioa701_pin_config[] = { GPIO32_MMC_CLK, GPIO92_MMC_DAT_0, GPIO

[PATCH v2 2/2] ARM: dts: pxa: add mioa701 board description

2018-07-07 Thread Robert Jarzmik
Add device-tree description of the Mitac MIO A701 board. This is aimed at replacing mioa701.c board file, and once stabilized, the leftover, such as the suspend resume mechanics will rely on a new IPL, and not the legacy Windows CE one. Signed-off-by: Robert Jarzmik --- Since v1: fix lcd_supply a

[PATCH] slimbus: stream: Fix htmldocs warnings

2018-07-07 Thread Srinivas Kandagatla
This patch fixes below warning during building htmldoc: slimbus.h:352: warning: Function parameter or member 'name' not described in 'slim_stream_runtime' This patch also removes documentation for state variable in struct slim_stream_runtime which was redundant and removed. Reported-by: kbuild t

Re: [PATCH v4 1/2] clk: pxa: export 32kHz PLL

2018-07-07 Thread Robert Jarzmik
Stephen Boyd writes: > Quoting Robert Jarzmik (2018-07-04 22:34:10) >> Robert Jarzmik writes: >> >> > This clock is especially used by the RTC driver, so export it so that >> > devicetree users can use it. >> > >> > Signed-off-by: Robert Jarzmik >> > --- >> > Since v2: fix missing parenthesis

Re: [PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-07-07 Thread Mattia Dongili
On Fri, Jul 06, 2018 at 04:24:27PM -0700, Darren Hart wrote: > On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > > Signed-off-by: Gustavo A. R. Silva > > -

Re: [PATCH] ARM: dts: exynos: add max77693 irq configuration for midas

2018-07-07 Thread Krzysztof Kozlowski
On 7 July 2018 at 19:08, Simon Shields wrote: > On Sat, Jul 07, 2018 at 05:34:08PM +0200, Krzysztof Kozlowski wrote: >> On 7 July 2018 at 16:45, Simon Shields wrote: >> > Currently, we assume that the bootloader has correctly configured >> > the interrupt pin for max77693. This might not actually

Re: [PATCH v2] iio: chemical: bme680: Add Bosch BME680 sensor support

2018-07-07 Thread Jonathan Cameron
On Fri, 6 Jul 2018 13:20:16 +0530 Himanshu Jha wrote: > Bosch BME680 is a 4-in-1 sensor with temperature, pressure, humidity > and gas sensing capability. It supports both I2C and SPI communication > protocol for effective data communication. > > The device supports two modes: > > 1. Sleep mod

[PATCHv3] Fix range checks in kernfs_get_target_path

2018-07-07 Thread Bernd Edlinger
The terminating NUL byte is only there because the buffer is allocated with kzalloc(PAGE_SIZE, GFP_KERNEL), but since the range-check is off-by-one, and PAGE_SIZE==PATH_MAX, the returned string may not be zero-terminated if it is exactly PATH_MAX characters long. Furthermore also the initial loop

[PATCH] iio: sca3000: Fix missing return in switch

2018-07-07 Thread Gustavo A. R. Silva
The IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY case is missing a return and will fall through to the default case and errorenously return -EINVAL. Fix this by adding in missing *return ret*. Fixes: 626f971b5b07 ("staging:iio:accel:sca3000 Add write support to the low pass filter control") Repor

Re: [RFC PATCH 2/2] mm/pmem: Add memblock based e820 platform driver

2018-07-07 Thread Dan Williams
On Sat, Jul 7, 2018 at 12:15 AM, Oliver wrote: > On Sat, Jul 7, 2018 at 5:38 AM, Dan Williams wrote: >> On Fri, Jul 6, 2018 at 1:29 AM, Aneesh Kumar K.V >> wrote: >>> This patch steal system RAM and use that to emulate pmem device using the >>> e820 platform driver. >>> >>> This adds a new kerne

Re: [PATCH] iio: sca3000: Mark expected switch fall-through

2018-07-07 Thread Gustavo A. R. Silva
Hi Jonathan, On 07/07/2018 12:03 PM, Jonathan Cameron wrote: > On Tue, 3 Jul 2018 14:39:34 -0500 > "Gustavo A. R. Silva" wrote: > >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Signed-off-by: Gustavo A. R. Silva > > Look

Re: [PATCH v5 1/2] iio: dac: Add AD5758 support

2018-07-07 Thread Jonathan Cameron
On Wed, 4 Jul 2018 17:32:03 +0300 Stefan Popa wrote: > The AD5758 is a single channel DAC with 16-bit precision which uses the > SPI interface that operates at clock rates up to 50MHz. > > The output can be configured as voltage or current and is available on a > single terminal. > > Datasheet:

Re: [PATCH v5 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC

2018-07-07 Thread Jonathan Cameron
On Thu, 5 Jul 2018 15:18:58 -0600 Rob Herring wrote: > On Wed, Jul 04, 2018 at 05:32:53PM +0300, Stefan Popa wrote: > > Signed-off-by: Stefan Popa > > --- > > Changes in v5: > > - used a dac@0 as a more generic node name instead of ad5758@0. > > Changes in v4: > > - Nothing changed, just

Re: [PATCH] ARM: dts: exynos: add max77693 irq configuration for midas

2018-07-07 Thread Simon Shields
On Sat, Jul 07, 2018 at 05:34:08PM +0200, Krzysztof Kozlowski wrote: > On 7 July 2018 at 16:45, Simon Shields wrote: > > Currently, we assume that the bootloader has correctly configured > > the interrupt pin for max77693. This might not actually be the case - > > so it's better to configure it ex

Re: [PATCH v2 2/2] iio: light: Add device tree binding for vishay vcnl4035

2018-07-07 Thread Parthiban Nallathambi
Hi Rob, On 07/06/2018 10:34 PM, Rob Herring wrote: > On Fri, Jun 29, 2018 at 05:38:02PM +0200, Parthiban Nallathambi wrote: >> Adding device tree binding for vcnl4035 and vendor >> prefix for Vishay Intertechnology >> >> Signed-off-by: Parthiban Nallathambi >> --- >> .../devicetree/bindings/iio/

[tip:x86/urgent] x86/mtrr: Don't copy out-of-bounds data in mtrr_write

2018-07-07 Thread tip-bot for Jann Horn
Commit-ID: 15279df6f26cf2013d713904b4a0c957ae8abb96 Gitweb: https://git.kernel.org/tip/15279df6f26cf2013d713904b4a0c957ae8abb96 Author: Jann Horn AuthorDate: Fri, 6 Jul 2018 23:50:03 +0200 Committer: Thomas Gleixner CommitDate: Sat, 7 Jul 2018 18:58:41 +0200 x86/mtrr: Don't copy out-of

Re: [PATCH] iio: mma8452: Mark expected switch fall-through

2018-07-07 Thread Jonathan Cameron
On Tue, 3 Jul 2018 14:44:36 -0500 "Gustavo A. R. Silva" wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Warning level 2 was used in this case: -Wimplicit-fallthrough=2 > > Signed-off-by: Gustavo A. R. Silva Applied to

Re: [PATCH] iio: sca3000: Mark expected switch fall-through

2018-07-07 Thread Jonathan Cameron
On Tue, 3 Jul 2018 14:39:34 -0500 "Gustavo A. R. Silva" wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Looks like a bug to me not an unmarked fall through. Should be return ret; Do

Re: [PATCH] iio:imu:adis: Mark expected switch fall-throughs

2018-07-07 Thread Jonathan Cameron
On Tue, 3 Jul 2018 14:35:50 -0500 "Gustavo A. R. Silva" wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied to the togreg branch of iio.git and pushed out as testing for the autobu

Re: [PATCH] ARM: imx: fix i.MX6SLL build

2018-07-07 Thread kbuild test robot
/0day-ci/linux/commits/Arnd-Bergmann/ARM-imx-fix-i-MX6SLL-build/20180707-012834 base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next config: arm-arm67 (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https

Re: [PATCH 1/2] drivers: core: Don't try to use a dead glue_dir

2018-07-07 Thread Greg Kroah-Hartman
On Fri, Jun 29, 2018 at 12:21:51PM +1000, Benjamin Herrenschmidt wrote: > Under some circumstances (such as when using kobject debugging) > a gluedir whose kref is 0 might remain in the class kset for > a long time. The reason is that we don't actively remove glue > dirs when they become empty, but

Re: [PATCH 1/2] drivers: core: Don't try to use a dead glue_dir

2018-07-07 Thread Greg Kroah-Hartman
On Sat, Jun 30, 2018 at 12:45:21PM -0700, Linus Torvalds wrote: > On Thu, Jun 28, 2018 at 7:21 PM Benjamin Herrenschmidt > wrote: > > > > Under some circumstances (such as when using kobject debugging) > > a gluedir whose kref is 0 might remain in the class kset for > > a long time. The reason is

Re: KASAN: slab-out-of-bounds Read in shrink_slab

2018-07-07 Thread Dmitry Vyukov
On Sat, Jul 7, 2018 at 9:16 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:526674536360 Add linux-next specific files for 20180706 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=17d8816240 > kernel config: http

Re: [PATCH] iio: dac: remove redundant pointer chip_info and spi_dev_id

2018-07-07 Thread Jonathan Cameron
On Mon, 2 Jul 2018 11:13:59 +0100 Colin King wrote: > From: Colin Ian King > > Pointers chip_info and spi_dev_id are being assigned but are never used > hence they are redundant and can be removed. > > Cleans up clang warning: > warning: variable 'chip_info' set but not used [-Wunused-but-set

Re: KASAN: stack-out-of-bounds Read in rb_erase (3)

2018-07-07 Thread Dmitry Vyukov
On Sat, Jul 7, 2018 at 5:09 PM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:29119529d8de Merge tag 'for-linus-20180706' of git://git.k.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=16e2550c40 > kernel config: h

Re: [PATCH] iio: dac: remove redundant variable 'shift'

2018-07-07 Thread Jonathan Cameron
On Mon, 2 Jul 2018 12:43:20 +0200 Sean Nyekjær wrote: > On 2018-07-02 12:24, Colin King wrote: > > From: Colin Ian King > > > > Variable shift is being assigned but is never used hence it is > > redundant and can be removed. > > > > Cleans up two clang warnings: > > warning: variable ‘shift’ s

Re: [PATCH v4 2/2] IIO: st_accel_i2c.c: Use probe_new() instead of probe()

2018-07-07 Thread Jonathan Cameron
On Tue, 3 Jul 2018 08:06:57 +0200 Nikolaus Voss wrote: > struct i2c_device_id argument of probe() is not used, so use probe_new() > instead. > > Reviewed-by: Andy Shevchenko > Signed-off-by: Nikolaus Voss Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders t

Re: [PATCH v4 1/2] IIO: st_accel_i2c.c: Simplify access to driver data

2018-07-07 Thread Jonathan Cameron
On Tue, 3 Jul 2018 07:41:00 +0200 Nikolaus Voss wrote: > Use device_get_match_data API to simplify access to driver data. > Let acpi_device_id table entries point to the same driver data as > of_device_id table entries and uniquify access to driver data by using > device_get_match_data API. Remov

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-07 Thread Andy Shevchenko
On Sat, Jul 7, 2018 at 6:48 AM, wrote: >>I strongly advocate for vendors to have more control over their drivers, >>but this scenario really frustrates me. I don't think I can justify this >>to Linus as a fix. But before we just say "no" (because hey, I want >>these fixes available as early as po

Re: [PATCH 1/2] iio: light: Add support for vishay vcnl4035

2018-07-07 Thread Jonathan Cameron
On Tue, 3 Jul 2018 15:35:05 +0200 Parthiban Nallathambi wrote: > Hello Jonathan, Hi Parthiban, Comments inline. ... > >> +static irqreturn_t vcnl4035_drdy_irq_handler(int irq, void *private) > >> +{ > >> + struct iio_dev *indio_dev = private; > >> + struct vcnl4035_data *data = iio_priv(indio_

Re: [PATCH] platform/x86: sony-laptop: Mark expected switch fall-through

2018-07-07 Thread Andy Shevchenko
On Sat, Jul 7, 2018 at 2:24 AM, Darren Hart wrote: > return AE_CTRL_TERMINATE; > > Is unreachable as there are no "break" statements in the switch, and the > default > falls through to return AE_OK. Something doesn't seem right here. Darren, I didn't look at the code in question, though

Re: [PATCH v2] driver core: add a debugfs entry to show deferred devices

2018-07-07 Thread Greg Kroah-Hartman
On Thu, Jun 28, 2018 at 12:06:56AM +0200, Javier Martinez Canillas wrote: > With Device Trees (DT), the dependencies of the devices are defined in the > DT, then the drivers parse that information to lookup the needed resources > that have as dependencies. > > Since drivers and devices are registe

Re: [PATCH 5/5] thunderbolt: Add support for runtime PM

2018-07-07 Thread Mika Westerberg
On Sat, Jul 07, 2018 at 04:43:48PM +0200, Lukas Wunner wrote: > On Sat, Jul 07, 2018 at 05:25:53PM +0300, Mika Westerberg wrote: > > On Sat, Jul 07, 2018 at 03:38:15PM +0200, Lukas Wunner wrote: > > > You're setting pm_runtime_no_callbacks() on the domain. A side effect of > > > setting this flag

Re: [PATCH v3 treewide] headers: separate linux/mod_devicetable.h from linux/platform_device.h

2018-07-07 Thread Greg Kroah-Hartman
On Tue, Jun 19, 2018 at 10:47:28PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > At over 4000 #includes, is the 9th most > #included header file in the Linux kernel. It does not need > , so drop that header and explicitly add > to source files that need it. > >4146 #include > > Af

Re: [PATCH] ARM: dts: exynos: add max77693 irq configuration for midas

2018-07-07 Thread Krzysztof Kozlowski
On 7 July 2018 at 16:45, Simon Shields wrote: > Currently, we assume that the bootloader has correctly configured > the interrupt pin for max77693. This might not actually be the case - > so it's better to configure it explicitly. > > Signed-off-by: Simon Shields > --- > arch/arm/boot/dts/exynos

Re: [PATCH] mei: bus: type promotion bug in mei_nfc_if_version()

2018-07-07 Thread Greg Kroah-Hartman
On Wed, Jul 04, 2018 at 12:34:49PM +0300, Dan Carpenter wrote: > We accidentally removed the check for negative returns without > considering the issue of type promotion. The "if_version_length" > variable is type size_t so if __mei_cl_recv() returns a negative then > "bytes_recv" is type promoted

Re: mm,tlb: revert 4647706ebeee?

2018-07-07 Thread Nicholas Piggin
On Fri, 06 Jul 2018 13:03:55 -0400 Rik van Riel wrote: > Hello, > > It looks like last summer, there were 2 sets of patches > in flight to fix the issue of simultaneous mprotect/madvise > calls unmapping PTEs, and some pages not being flushed from > the TLB before returning to userspace. > > Mi

[PATCH] acpi/button.c: fix defined but not used warning

2018-07-07 Thread Randy Dunlap
From: Randy Dunlap Fix a build warning in the ACPI button driver when CONFIG_PROC_FS is not enabled by marking the unused function as __maybe_unused. ../drivers/acpi/button.c:252:12: warning: 'acpi_button_state_seq_show' defined but not used [-Wunused-function] Signed-off-by: Randy Dunlap Cc:

Re: [PATCH v7 01/10] counter: Introduce the Generic Counter interface

2018-07-07 Thread Greg KH
On Thu, Jun 21, 2018 at 05:07:08PM -0400, William Breathitt Gray wrote: > This patch introduces the Generic Counter interface for supporting > counter devices. > > In the context of the Generic Counter interface, a counter is defined as > a device that reports one or more "counts" based on the sta

KASAN: stack-out-of-bounds Read in rb_erase (3)

2018-07-07 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:29119529d8de Merge tag 'for-linus-20180706' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16e2550c40 kernel config: https://syzkaller.appspot.com/x/.config?x=2ca6c7a31d407f86 da

Re: [RFC PATCH for 4.18 3/5] rseq: uapi: declare rseq_cs field as union, update includes

2018-07-07 Thread Russell King - ARM Linux
On Fri, Jul 06, 2018 at 12:56:58PM -0700, Linus Torvalds wrote: > On Fri, Jul 6, 2018 at 12:38 PM Mathieu Desnoyers > wrote: > > > > Should I change all 4 bytes __get_user()/__put_user() in kernel/rseq.c > > for get_user()/put_user() to ensure consistency ? > > Probably. > > *If* this actually t

Re: [GIT PULL v2] FSI updates for 4.17

2018-07-07 Thread Greg Kroah-Hartman
On Tue, Jun 12, 2018 at 08:54:39PM +1000, Benjamin Herrenschmidt wrote: > Hi Greg ! > > There are a first round of updates of the FSI stack, aiming at > reducing/removing > he gap with the OpenBMC tree and a first step in getting dependent drivers > upstream. > > These changes significantly impr

Re: [PATCH v2 0/7] tracing: Hist trigger snapshot and onchange additions

2018-07-07 Thread Masami Hiramatsu
Hi Tom, On Mon, 2 Jul 2018 15:22:19 -0500 Tom Zanussi wrote: > From: Tom Zanussi > > Hi, > > This is v2 of the hist trigger snapshot and onchange additions > patchset. It adds a couple fixes to problems flagged by the kbuild > test robot, but is otherwise the same as v1. > > Changes since

[PATCH 03/12] staging:rtl8192u: Remove blank lines before '}' and after '{' characters

2018-07-07 Thread John Whitmore
Coding style change to simply remove the unrequired spaces before a closing brace or before an opening brace. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 44 ++- 1 file changed, 13 insertions(+), 31 deletions(-) diff --git a/drivers/staging/r

[PATCH 04/12] staging:rtl8192u: Add spaces required around operators - Coding Style

2018-07-07 Thread John Whitmore
Added the spaces, required by coding style, around the various operators. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 124 +- 1 file changed, 62 insertions(+), 62 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.

[PATCH 06/12] staging:rtl8192u: rename HT_EXTCHNL_OFFSET -> enum ht_extension_chan_width

2018-07-07 Thread John Whitmore
remove the typedef of enumerated type HT_EXTCHNL_OFFSET and replace it with 'enum ht_extension_chan_offset' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211.h| 4 ++-- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 2 +- drivers/staging/rtl81

[PATCH 08/12] staging:rtl8192u: Remove prohibited spaces - Coding Style

2018-07-07 Thread John Whitmore
Simple removal of spaces prohibited by the coding standard. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/sta

[PATCH 09/12] staging:rtl8192u: Move trailing conditional statement to the following line

2018-07-07 Thread John Whitmore
Coding standard requires that the conditional statement is not on the same line as the 'if' or 'else' but on the following line. Statements moved accordingly. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 25 +-- 1 file changed, 17 insertions(+)

[PATCH 10/12] staging:rtl8192u: Remove unnecessary parentheses - Coding Style

2018-07-07 Thread John Whitmore
checkpatch.pl flags unnecessary parentheses so removed from code. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/

[PATCH 05/12] staging:rtl8192u: Correct indentation and spacing for braces of code blocks

2018-07-07 Thread John Whitmore
Simple style change to fix the indentaiton and spacing of the braces around multi ling code blocks. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 250 -- 1 file changed, 105 insertions(+), 145 deletions(-) diff --git a/drivers/staging/rtl8192u/

[PATCH 11/12] staging:rtl8192u: Correct indentation of ieee80211_softmac_new_net()

2018-07-07 Thread John Whitmore
Coding style change to correct the indentation of the function ieee80211_softmac_new_net() Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 101 +- 1 file changed, 50 insertions(+), 51 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/i

[PATCH 12/12] staging:rtl8192u: Correction of indentation issues - Coding Style

2018-07-07 Thread John Whitmore
Simple changes to correct indentation issues. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 24 +-- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192

[PATCH 07/12] staging:rtl8192u: Correct spacing before and after parenthesis - Style

2018-07-07 Thread John Whitmore
Corrected coding style issues aroung opening and closed parenthesis. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 78 +-- 1 file changed, 36 insertions(+), 42 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/

[PATCH 01/12] staging:rtl8192u: rename HT_CHANNEL_WIDTH -> enum ht_channel_width

2018-07-07 Thread John Whitmore
remove the typedef HT_CHANNEL_WIDTH and replace with 'enum ht_channel_width' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211.h| 4 ++-- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 4 ++-- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h

[PATCH 02/12] staging:rtl8192u: Add space required before '(' - Style

2018-07-07 Thread John Whitmore
Simple addition of the coding style required space before '('. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/ieee80211_softmac.c| 174 +- 1 file changed, 86 insertions(+), 88 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/driver

Re: [PATCHv2] Fix range checks in kernfs_get_target_path

2018-07-07 Thread Greg Kroah-Hartman
On Sat, Jul 07, 2018 at 02:34:05PM +, Bernd Edlinger wrote: > On 07/07/18 16:01, Greg Kroah-Hartman wrote: > > On Sat, Jul 07, 2018 at 09:41:03AM +, Bernd Edlinger wrote: > >> The strncpy causes a warning [-Wstringop-truncation] here, > >> which indicates that it never appends a NUL byte to

Re: [PATCH 4.17 00/46] 4.17.5-stable review

2018-07-07 Thread Greg Kroah-Hartman
On Fri, Jul 06, 2018 at 11:51:24AM -0600, Dan Rue wrote: > On Fri, Jul 06, 2018 at 07:46:21AM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.17.5 release. > > There are 46 patches in this series, all will be posted as a response > > to this one. If anyo

[PATCH] ARM: dts: exynos: add max77693 irq configuration for midas

2018-07-07 Thread Simon Shields
Currently, we assume that the bootloader has correctly configured the interrupt pin for max77693. This might not actually be the case - so it's better to configure it explicitly. Signed-off-by: Simon Shields --- arch/arm/boot/dts/exynos4412-midas.dtsi | 9 + 1 file changed, 9 insertions(

Re: [PATCH 5/5] thunderbolt: Add support for runtime PM

2018-07-07 Thread Lukas Wunner
On Sat, Jul 07, 2018 at 05:25:53PM +0300, Mika Westerberg wrote: > On Sat, Jul 07, 2018 at 03:38:15PM +0200, Lukas Wunner wrote: > > You're setting pm_runtime_no_callbacks() on the domain. A side effect of > > setting this flag is that whenever the domain's device is runtime resumed, > > it's pare

Re: [PATCH] staging: rtl8188eu: replace while with shorter for loop

2018-07-07 Thread Greg KH
On Sat, Jul 07, 2018 at 01:22:50PM +0200, Michael Straube wrote: > Simplify rtw_get_rateset_len() by replacing the while loop > with a shorter for loop. Also replace tabs with spaces in > the definition line. Normally I will insist that this be two separate patches, as you are doing two different

Re: [PATCHv2] Fix range checks in kernfs_get_target_path

2018-07-07 Thread Bernd Edlinger
On 07/07/18 16:01, Greg Kroah-Hartman wrote: > On Sat, Jul 07, 2018 at 09:41:03AM +, Bernd Edlinger wrote: >> The strncpy causes a warning [-Wstringop-truncation] here, >> which indicates that it never appends a NUL byte to the path. >> The NUL byte is only there because the buffer is allocated

  1   2   >