Re: [PATCH] sched/cputime: Ensure correct utime and stime proportion

Hi Peter, On 7/5/18 9:21 PM, Xunlei Pang wrote: > On 7/5/18 6:46 PM, Peter Zijlstra wrote: >> On Wed, Jun 27, 2018 at 08:22:42PM +0800, Xunlei Pang wrote: >>> tick-based whole utime is utime_0, tick-based whole stime >>> is stime_0, scheduler time is rtime_0. >> >>> For a long time, the process

Re: [PATCH] sched/cputime: Ensure correct utime and stime proportion

Hi Peter, On 7/5/18 9:21 PM, Xunlei Pang wrote: > On 7/5/18 6:46 PM, Peter Zijlstra wrote: >> On Wed, Jun 27, 2018 at 08:22:42PM +0800, Xunlei Pang wrote: >>> tick-based whole utime is utime_0, tick-based whole stime >>> is stime_0, scheduler time is rtime_0. >> >>> For a long time, the process

KASAN: use-after-free Write in _free_event

Hello, syzbot found the following crash on: HEAD commit:b2d44d145d2a Merge tag '4.18-rc3-smb3fixes' of git://git.s.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=178cf50c40 kernel config: https://syzkaller.appspot.com/x/.config?x=2ca6c7a31d407f86

KASAN: use-after-free Write in _free_event

Hello, syzbot found the following crash on: HEAD commit:b2d44d145d2a Merge tag '4.18-rc3-smb3fixes' of git://git.s.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=178cf50c40 kernel config: https://syzkaller.appspot.com/x/.config?x=2ca6c7a31d407f86

kernel BUG at mm/memory.c:LINE!

Hello, syzbot found the following crash on: HEAD commit:b2d44d145d2a Merge tag '4.18-rc3-smb3fixes' of git://git.s.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11d0774840 kernel config: https://syzkaller.appspot.com/x/.config?x=2ca6c7a31d407f86

kernel BUG at mm/memory.c:LINE!

Hello, syzbot found the following crash on: HEAD commit:b2d44d145d2a Merge tag '4.18-rc3-smb3fixes' of git://git.s.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11d0774840 kernel config: https://syzkaller.appspot.com/x/.config?x=2ca6c7a31d407f86

Re: general protection fault in scheduler_tick

On Mon, Jul 9, 2018 at 5:09 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:526674536360 Add linux-next specific files for 20180706 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=17f6396840 > kernel config:

Re: [RESEND PATCH v2] devres: Really align data field to unsigned long long

On Mon, Jul 09, 2018 at 07:44:44AM +0300, Alexey Brodkin wrote: > Depending on ABI "long long" type of a particular 32-bit CPU > might be aligned by either word (32-bits) or double word (64-bits). > Make sure "data" is really 64-bit aligned for any 32-bit CPU. > > At least for 32-bit ARC cores

Re: general protection fault in scheduler_tick

On Mon, Jul 9, 2018 at 5:09 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:526674536360 Add linux-next specific files for 20180706 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=17f6396840 > kernel config:

Re: [RESEND PATCH v2] devres: Really align data field to unsigned long long

On Mon, Jul 09, 2018 at 07:44:44AM +0300, Alexey Brodkin wrote: > Depending on ABI "long long" type of a particular 32-bit CPU > might be aligned by either word (32-bits) or double word (64-bits). > Make sure "data" is really 64-bit aligned for any 32-bit CPU. > > At least for 32-bit ARC cores

Re: KASAN: stack-out-of-bounds Read in add_wait_queue

On Mon, Jul 9, 2018 at 5:09 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:ca04b3cca11a Merge tag 'armsoc-fixes' of git://git.kernel... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=123180c840 > kernel config:

Re: KASAN: stack-out-of-bounds Read in add_wait_queue

On Mon, Jul 9, 2018 at 5:09 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:ca04b3cca11a Merge tag 'armsoc-fixes' of git://git.kernel... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=123180c840 > kernel config:

Re: KASAN: stack-out-of-bounds Read in account_system_index_time

On Mon, Jul 9, 2018 at 5:09 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:ca04b3cca11a Merge tag 'armsoc-fixes' of git://git.kernel... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=11f1e96840 > kernel config:

Re: KASAN: stack-out-of-bounds Read in account_system_index_time

On Mon, Jul 9, 2018 at 5:09 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:ca04b3cca11a Merge tag 'armsoc-fixes' of git://git.kernel... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=11f1e96840 > kernel config:

Re: [PATCH -mm -v4 01/21] mm, THP, swap: Enable PMD swap operations for CONFIG_THP_SWAP

Dan Williams writes: > On Thu, Jun 21, 2018 at 8:55 PM Huang, Ying wrote: >> >> From: Huang Ying >> >> Previously, the PMD swap operations are only enabled for >> CONFIG_ARCH_ENABLE_THP_MIGRATION. Because they are only used by the >> THP migration support. We will support PMD swap mapping to

Re: [PATCH -mm -v4 01/21] mm, THP, swap: Enable PMD swap operations for CONFIG_THP_SWAP

Dan Williams writes: > On Thu, Jun 21, 2018 at 8:55 PM Huang, Ying wrote: >> >> From: Huang Ying >> >> Previously, the PMD swap operations are only enabled for >> CONFIG_ARCH_ENABLE_THP_MIGRATION. Because they are only used by the >> THP migration support. We will support PMD swap mapping to

Re: [RFC PATCH] watchdog: sp805: Add clock-frequency property

Hi Guenter, Thank you for the clarification.. Please find my comments. On Sun, Jul 8, 2018 at 11:36 PM, Guenter Roeck wrote: > On 07/06/2018 01:18 AM, Srinath Mannam wrote: >> >> Hi Guenter, >> >> Thank you very much for your feedback. Please find my comments. >> >> On Thu, Jul 5, 2018 at 8:58

Re: [RFC PATCH] watchdog: sp805: Add clock-frequency property

Hi Guenter, Thank you for the clarification.. Please find my comments. On Sun, Jul 8, 2018 at 11:36 PM, Guenter Roeck wrote: > On 07/06/2018 01:18 AM, Srinath Mannam wrote: >> >> Hi Guenter, >> >> Thank you very much for your feedback. Please find my comments. >> >> On Thu, Jul 5, 2018 at 8:58

Re: [PATCH 3/4] dt-bindings: clock: Introduce QCOM Graphics clock bindings

Quoting Amit Nischal (2018-06-06 04:41:47) > diff --git a/Documentation/devicetree/bindings/clock/qcom,gpucc.txt > b/Documentation/devicetree/bindings/clock/qcom,gpucc.txt > new file mode 100644 > index 000..e311219 > --- /dev/null > +++

Re: [PATCH 3/4] dt-bindings: clock: Introduce QCOM Graphics clock bindings

Quoting Amit Nischal (2018-06-06 04:41:47) > diff --git a/Documentation/devicetree/bindings/clock/qcom,gpucc.txt > b/Documentation/devicetree/bindings/clock/qcom,gpucc.txt > new file mode 100644 > index 000..e311219 > --- /dev/null > +++

Re: [PATCH 1/4] clk: qcom: gdsc: Add support to enable/disable the clocks with GDSC

Quoting Amit Nischal (2018-06-06 04:41:45) > For some of the GDSCs, there is a requirement to enable/disable the > few clocks before turning on/off the gdsc power domain. Add support Why is there a requirement? Do the clks need to be in hw control mode or they can't be turned off when the GDSC is

Re: [PATCH 1/4] clk: qcom: gdsc: Add support to enable/disable the clocks with GDSC

Quoting Amit Nischal (2018-06-06 04:41:45) > For some of the GDSCs, there is a requirement to enable/disable the > few clocks before turning on/off the gdsc power domain. Add support Why is there a requirement? Do the clks need to be in hw control mode or they can't be turned off when the GDSC is

Re: [PATCH v9 05/10] firmware: xilinx: Add clock APIs

Quoting Jolly Shah (2018-06-20 10:40:30) > diff --git a/drivers/firmware/xilinx/zynqmp.c > b/drivers/firmware/xilinx/zynqmp.c > index 86d9bb8..c764d6e 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -269,14 +269,196 @@ static int zynqmp_pm_ioctl(u32

Re: [PATCH v9 05/10] firmware: xilinx: Add clock APIs

Quoting Jolly Shah (2018-06-20 10:40:30) > diff --git a/drivers/firmware/xilinx/zynqmp.c > b/drivers/firmware/xilinx/zynqmp.c > index 86d9bb8..c764d6e 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -269,14 +269,196 @@ static int zynqmp_pm_ioctl(u32

Re: [PATCH v9 07/10] firmware: xilinx: Add debugfs for IOCTL API

Quoting Jolly Shah (2018-06-20 10:40:32) > From: Rajan Vaja > > Add debugfs file to set/get IOCTL using debugfs interface. IOCTLs and debugfs aren't the same thing. Why are the two being mixed together? Is some sort of userspace ABI being created here to control clks with usermode drivers?

Re: [PATCH v9 07/10] firmware: xilinx: Add debugfs for IOCTL API

Quoting Jolly Shah (2018-06-20 10:40:32) > From: Rajan Vaja > > Add debugfs file to set/get IOCTL using debugfs interface. IOCTLs and debugfs aren't the same thing. Why are the two being mixed together? Is some sort of userspace ABI being created here to control clks with usermode drivers?

Re: [PATCH v9 09/10] dt-bindings: clock: Add bindings for ZynqMP clock driver

Quoting Jolly Shah (2018-06-20 10:40:34) > From: Rajan Vaja > > Add documentation to describe Xilinx ZynqMP clock driver > bindings. > > Signed-off-by: Rajan Vaja > Signed-off-by: Jolly Shah > Reviewed-by: Rob Herring > --- Reviewed-by: Stephen Boyd

Re: [PATCH v9 09/10] dt-bindings: clock: Add bindings for ZynqMP clock driver

Quoting Jolly Shah (2018-06-20 10:40:34) > From: Rajan Vaja > > Add documentation to describe Xilinx ZynqMP clock driver > bindings. > > Signed-off-by: Rajan Vaja > Signed-off-by: Jolly Shah > Reviewed-by: Rob Herring > --- Reviewed-by: Stephen Boyd

Re: [PATCH v9 10/10] drivers: clk: Add ZynqMP clock driver

Quoting Jolly Shah (2018-06-20 10:40:35) > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 98ce9fc..a2ebcf7 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -252,6 +252,7 @@ source "drivers/clk/sprd/Kconfig" > source "drivers/clk/sunxi-ng/Kconfig" > source

Re: [PATCH v9 10/10] drivers: clk: Add ZynqMP clock driver

Quoting Jolly Shah (2018-06-20 10:40:35) > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 98ce9fc..a2ebcf7 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -252,6 +252,7 @@ source "drivers/clk/sprd/Kconfig" > source "drivers/clk/sunxi-ng/Kconfig" > source

Re: [PATCH 2/4] phy: socionext: add USB3 PHY driver for UniPhier SoC

Hi, On Friday 29 June 2018 02:08 PM, Kunihiko Hayashi wrote: > Add a driver for PHY interface built into USB3 controller > implemented in UniPhier SoCs. > This driver supports High-Speed PHY and Super-Speed PHY. > > Signed-off-by: Kunihiko Hayashi > Signed-off-by: Motoya Tanigawa >

Re: [PATCH 2/4] phy: socionext: add USB3 PHY driver for UniPhier SoC

Hi, On Friday 29 June 2018 02:08 PM, Kunihiko Hayashi wrote: > Add a driver for PHY interface built into USB3 controller > implemented in UniPhier SoCs. > This driver supports High-Speed PHY and Super-Speed PHY. > > Signed-off-by: Kunihiko Hayashi > Signed-off-by: Motoya Tanigawa >

Re: [RFC PATCH 2/2] mm/pmem: Add memblock based e820 platform driver

On 07/07/2018 11:06 PM, Dan Williams wrote: On Sat, Jul 7, 2018 at 12:15 AM, Oliver wrote: On Sat, Jul 7, 2018 at 5:38 AM, Dan Williams wrote: On Fri, Jul 6, 2018 at 1:29 AM, Aneesh Kumar K.V wrote: This patch steal system RAM and use that to emulate pmem device using the e820 platform

Re: [RFC PATCH 2/2] mm/pmem: Add memblock based e820 platform driver

On 07/07/2018 11:06 PM, Dan Williams wrote: On Sat, Jul 7, 2018 at 12:15 AM, Oliver wrote: On Sat, Jul 7, 2018 at 5:38 AM, Dan Williams wrote: On Fri, Jul 6, 2018 at 1:29 AM, Aneesh Kumar K.V wrote: This patch steal system RAM and use that to emulate pmem device using the e820 platform

Re: [RFC PATCH 2/2] mm/pmem: Add memblock based e820 platform driver

On 07/07/2018 01:20 PM, Oliver wrote: On Fri, Jul 6, 2018 at 6:29 PM, Aneesh Kumar K.V wrote: This patch steal system RAM and use that to emulate pmem device using the e820 platform driver. This adds a new kernel command line 'pmemmap' which takes the format to allocate memory early in the

Re: [RFC PATCH 2/2] mm/pmem: Add memblock based e820 platform driver

On 07/07/2018 01:20 PM, Oliver wrote: On Fri, Jul 6, 2018 at 6:29 PM, Aneesh Kumar K.V wrote: This patch steal system RAM and use that to emulate pmem device using the e820 platform driver. This adds a new kernel command line 'pmemmap' which takes the format to allocate memory early in the

[RFC][PATCH 05/27] introduce FMODE_OPENED

From: Al Viro basically, "is that instance set up enough for regular fput(), or do we want put_filp() for that one". Signed-off-by: Al Viro --- arch/ia64/kernel/perfmon.c | 1 + drivers/misc/cxl/api.c | 2 +- fs/aio.c | 3 ++- fs/anon_inodes.c | 2 +-

[RFC][PATCH 05/27] introduce FMODE_OPENED

From: Al Viro basically, "is that instance set up enough for regular fput(), or do we want put_filp() for that one". Signed-off-by: Al Viro --- arch/ia64/kernel/perfmon.c | 1 + drivers/misc/cxl/api.c | 2 +- fs/aio.c | 3 ++- fs/anon_inodes.c | 2 +-

[RFC][PATCH 07/27] lift fput() on late failures into path_openat()

From: Al Viro Signed-off-by: Al Viro --- fs/namei.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index a58e00076ba1..36c2fa804e26 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3409,8 +3409,6 @@ static int

[RFC][PATCH 07/27] lift fput() on late failures into path_openat()

From: Al Viro Signed-off-by: Al Viro --- fs/namei.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index a58e00076ba1..36c2fa804e26 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3409,8 +3409,6 @@ static int

[RFC][PATCH 09/27] now we can fold open_check_o_direct() into do_dentry_open()

From: Al Viro Signed-off-by: Al Viro --- fs/internal.h | 1 - fs/namei.c| 7 +-- fs/open.c | 27 +-- 3 files changed, 10 insertions(+), 25 deletions(-) diff --git a/fs/internal.h b/fs/internal.h index 5645b4ebf494..08ac9cdee1b4 100644 --- a/fs/internal.h

[RFC][PATCH 09/27] now we can fold open_check_o_direct() into do_dentry_open()

From: Al Viro Signed-off-by: Al Viro --- fs/internal.h | 1 - fs/namei.c| 7 +-- fs/open.c | 27 +-- 3 files changed, 10 insertions(+), 25 deletions(-) diff --git a/fs/internal.h b/fs/internal.h index 5645b4ebf494..08ac9cdee1b4 100644 --- a/fs/internal.h

[RFC][PATCH 08/27] switch all remaining checks for FILE_OPENED to FMODE_OPENED

From: Al Viro ... and don't bother with setting FILE_OPENED at all. Signed-off-by: Al Viro --- fs/namei.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 36c2fa804e26..b324f59f8209 100644 --- a/fs/namei.c +++ b/fs/namei.c @@

[RFC][PATCH 08/27] switch all remaining checks for FILE_OPENED to FMODE_OPENED

From: Al Viro ... and don't bother with setting FILE_OPENED at all. Signed-off-by: Al Viro --- fs/namei.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 36c2fa804e26..b324f59f8209 100644 --- a/fs/namei.c +++ b/fs/namei.c @@

[RFC][PATCH 06/27] get rid of 'opened' argument of finish_open()

From: Al Viro We only deal with opened & FILE_OPENED in it and it's parallel to file->f_mode & FMODE_OPENED. So let the callers deal with the latter instead. Most of the call chains go through fs/namei.c:atomic_open() and do not look at FILE_OPENED between the return from finish_open() and

[RFC][PATCH 06/27] get rid of 'opened' argument of finish_open()

From: Al Viro We only deal with opened & FILE_OPENED in it and it's parallel to file->f_mode & FMODE_OPENED. So let the callers deal with the latter instead. Most of the call chains go through fs/namei.c:atomic_open() and do not look at FILE_OPENED between the return from finish_open() and

[RFC][PATCH 11/27] IMA: don't propagate opened through the entire thing

From: Al Viro just check ->f_mode in ima_appraise_measurement() Signed-off-by: Al Viro --- fs/namei.c| 3 +-- fs/nfsd/vfs.c | 2 +- include/linux/ima.h | 4 ++-- security/integrity/ima/ima.h | 4 ++--

[RFC][PATCH 12/27] Preparation to killing ->atomic_open() 'opened' argument.

From: Al Viro __gfs2_lookup(), gfs2_create_inode(), nfs_finish_open() and fuse_create_open() don't need 'opened' anymore. Get rid of that argument in those. Signed-off-by: Al Viro --- fs/fuse/dir.c | 4 ++-- fs/gfs2/inode.c | 19 +-- fs/nfs/dir.c| 5 ++--- 3 files

[RFC][PATCH 11/27] IMA: don't propagate opened through the entire thing

From: Al Viro just check ->f_mode in ima_appraise_measurement() Signed-off-by: Al Viro --- fs/namei.c| 3 +-- fs/nfsd/vfs.c | 2 +- include/linux/ima.h | 4 ++-- security/integrity/ima/ima.h | 4 ++--

[RFC][PATCH 12/27] Preparation to killing ->atomic_open() 'opened' argument.

From: Al Viro __gfs2_lookup(), gfs2_create_inode(), nfs_finish_open() and fuse_create_open() don't need 'opened' anymore. Get rid of that argument in those. Signed-off-by: Al Viro --- fs/fuse/dir.c | 4 ++-- fs/gfs2/inode.c | 19 +-- fs/nfs/dir.c| 5 ++--- 3 files

[RFC][PATCH 10/27] introduce FMODE_CREATED and switch to it

From: Al Viro Parallel to FILE_CREATED, goes into ->f_mode instead of *opened. NFS is a bit of a wart here - it doesn't have file at the point where FILE_CREATED used to be set, so we need to propagate it there (for now). IMA is another one (here and everywhere)... Note that this needs

[RFC][PATCH 10/27] introduce FMODE_CREATED and switch to it

From: Al Viro Parallel to FILE_CREATED, goes into ->f_mode instead of *opened. NFS is a bit of a wart here - it doesn't have file at the point where FILE_CREATED used to be set, so we need to propagate it there (for now). IMA is another one (here and everywhere)... Note that this needs

[RFC][PATCH 15/27] kill FILE_{CREATED,OPENED}

From: Al Viro no users left Signed-off-by: Al Viro --- include/linux/fs.h | 4 1 file changed, 4 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 80fec0332fdd..b3240025ce1a 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2434,10 +2434,6 @@ extern

[RFC][PATCH 13/27] get rid of 'opened' argument of ->atomic_open()

From: Al Viro not used anymore Signed-off-by: Al Viro --- fs/9p/vfs_inode.c | 3 +-- fs/9p/vfs_inode_dotl.c | 3 +-- fs/bad_inode.c | 2 +- fs/ceph/file.c | 3 +-- fs/ceph/super.h| 3 +-- fs/cifs/cifsfs.h | 3 +-- fs/cifs/dir.c | 3 +--

[RFC][PATCH 18/27] ... and switch shmem_file_setup() to alloc_file_pseudo()

From: Al Viro Signed-off-by: Al Viro --- mm/shmem.c | 39 --- 1 file changed, 8 insertions(+), 31 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 0aa290f849ee..fd21df189f32 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -3896,18 +3896,11 @@

[RFC][PATCH 16/27] new wrapper: alloc_file_pseudo()

From: Al Viro takes inode, vfsmount, name, mode and file_operations and either returns a new struct file (in which case inode reference we held is consumed) or returns ERR_PTR(), in which case no refcounts are altered. converted aio_private_file() and sock_alloc_file() to it Signed-off-by: Al

[RFC][PATCH 15/27] kill FILE_{CREATED,OPENED}

From: Al Viro no users left Signed-off-by: Al Viro --- include/linux/fs.h | 4 1 file changed, 4 deletions(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 80fec0332fdd..b3240025ce1a 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2434,10 +2434,6 @@ extern

[RFC][PATCH 13/27] get rid of 'opened' argument of ->atomic_open()

From: Al Viro not used anymore Signed-off-by: Al Viro --- fs/9p/vfs_inode.c | 3 +-- fs/9p/vfs_inode_dotl.c | 3 +-- fs/bad_inode.c | 2 +- fs/ceph/file.c | 3 +-- fs/ceph/super.h| 3 +-- fs/cifs/cifsfs.h | 3 +-- fs/cifs/dir.c | 3 +--

[RFC][PATCH 18/27] ... and switch shmem_file_setup() to alloc_file_pseudo()

From: Al Viro Signed-off-by: Al Viro --- mm/shmem.c | 39 --- 1 file changed, 8 insertions(+), 31 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 0aa290f849ee..fd21df189f32 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -3896,18 +3896,11 @@

[RFC][PATCH 16/27] new wrapper: alloc_file_pseudo()

From: Al Viro takes inode, vfsmount, name, mode and file_operations and either returns a new struct file (in which case inode reference we held is consumed) or returns ERR_PTR(), in which case no refcounts are altered. converted aio_private_file() and sock_alloc_file() to it Signed-off-by: Al

[RFC][PATCH 14/27] get rid of 'opened' in path_openat() and the helpers downstream

From: Al Viro unused now Signed-off-by: Al Viro --- fs/namei.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 7270cac785b0..5d7aa567c958 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3036,8 +3036,7 @@ static int

[RFC][PATCH 14/27] get rid of 'opened' in path_openat() and the helpers downstream

From: Al Viro unused now Signed-off-by: Al Viro --- fs/namei.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 7270cac785b0..5d7aa567c958 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3036,8 +3036,7 @@ static int

[RFC][PATCH 17/27] __shmem_file_setup(): reorder allocations

From: Al Viro grab inode and reserve memory first. Signed-off-by: Al Viro --- mm/shmem.c | 43 --- 1 file changed, 20 insertions(+), 23 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index a76adc3802d1..0aa290f849ee 100644 --- a/mm/shmem.c +++

[RFC][PATCH 01/27] drm_mode_create_lease_ioctl(): fix open-coded filp_clone_open()

From: Al Viro Failure of ->open() should *not* be followed by fput(). Fixed by using filp_clone_open(), which gets the cleanups right. Signed-off-by: Al Viro --- drivers/gpu/drm/drm_lease.c | 16 +--- fs/internal.h | 1 - include/linux/fs.h | 1 + 3 files

[RFC][PATCH 20/27] ocxlflash_getfile(): switch to alloc_file_pseudo()

From: Al Viro Signed-off-by: Al Viro --- drivers/scsi/cxlflash/ocxl_hw.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/drivers/scsi/cxlflash/ocxl_hw.c b/drivers/scsi/cxlflash/ocxl_hw.c index 497a68389461..6d0632174ec6 100644 ---

[RFC][PATCH 17/27] __shmem_file_setup(): reorder allocations

From: Al Viro grab inode and reserve memory first. Signed-off-by: Al Viro --- mm/shmem.c | 43 --- 1 file changed, 20 insertions(+), 23 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index a76adc3802d1..0aa290f849ee 100644 --- a/mm/shmem.c +++

[RFC][PATCH 01/27] drm_mode_create_lease_ioctl(): fix open-coded filp_clone_open()

From: Al Viro Failure of ->open() should *not* be followed by fput(). Fixed by using filp_clone_open(), which gets the cleanups right. Signed-off-by: Al Viro --- drivers/gpu/drm/drm_lease.c | 16 +--- fs/internal.h | 1 - include/linux/fs.h | 1 + 3 files

[RFC][PATCH 20/27] ocxlflash_getfile(): switch to alloc_file_pseudo()

From: Al Viro Signed-off-by: Al Viro --- drivers/scsi/cxlflash/ocxl_hw.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/drivers/scsi/cxlflash/ocxl_hw.c b/drivers/scsi/cxlflash/ocxl_hw.c index 497a68389461..6d0632174ec6 100644 ---

[RFC][PATCH 26/27] make alloc_file() static

From: Al Viro Signed-off-by: Al Viro --- fs/file_table.c | 3 +-- include/linux/file.h | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/file_table.c b/fs/file_table.c index fb7c3b007630..ffb0036a24f6 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -155,7

[RFC][PATCH 19/27] cxl_getfile(): switch to alloc_file_pseudo()

From: Al Viro Signed-off-by: Al Viro --- drivers/misc/cxl/api.c | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c index 146a12fe6cb8..e0b9c00aecde 100644 --- a/drivers/misc/cxl/api.c +++

[RFC][PATCH 19/27] cxl_getfile(): switch to alloc_file_pseudo()

From: Al Viro Signed-off-by: Al Viro --- drivers/misc/cxl/api.c | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c index 146a12fe6cb8..e0b9c00aecde 100644 --- a/drivers/misc/cxl/api.c +++

[RFC][PATCH 26/27] make alloc_file() static

From: Al Viro Signed-off-by: Al Viro --- fs/file_table.c | 3 +-- include/linux/file.h | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/file_table.c b/fs/file_table.c index fb7c3b007630..ffb0036a24f6 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -155,7

[RFC][PATCH 25/27] do_shmat(): grab shp->shm_file earlier, switch to alloc_file_clone()

From: Al Viro Signed-off-by: Al Viro --- ipc/shm.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/ipc/shm.c b/ipc/shm.c index e37931121070..0cebcf74b669 100644 --- a/ipc/shm.c +++ b/ipc/shm.c @@ -1354,14 +1354,13 @@ long

[RFC][PATCH 25/27] do_shmat(): grab shp->shm_file earlier, switch to alloc_file_clone()

From: Al Viro Signed-off-by: Al Viro --- ipc/shm.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/ipc/shm.c b/ipc/shm.c index e37931121070..0cebcf74b669 100644 --- a/ipc/shm.c +++ b/ipc/shm.c @@ -1354,14 +1354,13 @@ long

[RFC][PATCH 22/27] anon_inode_getfile(): switch to alloc_file_pseudo()

From: Al Viro Signed-off-by: Al Viro --- fs/anon_inodes.c | 29 ++--- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c index bf952939a1d3..7e13edd23db1 100644 --- a/fs/anon_inodes.c +++ b/fs/anon_inodes.c @@ -71,8 +71,6

[RFC][PATCH 22/27] anon_inode_getfile(): switch to alloc_file_pseudo()

From: Al Viro Signed-off-by: Al Viro --- fs/anon_inodes.c | 29 ++--- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c index bf952939a1d3..7e13edd23db1 100644 --- a/fs/anon_inodes.c +++ b/fs/anon_inodes.c @@ -71,8 +71,6

[RFC][PATCH 23/27] create_pipe_files(): switch the first allocation to alloc_file_pseudo()

From: Al Viro Signed-off-by: Al Viro --- fs/pipe.c | 41 ++--- 1 file changed, 10 insertions(+), 31 deletions(-) diff --git a/fs/pipe.c b/fs/pipe.c index 4d62c935f675..312af057f03a 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -744,56 +744,35 @@ static struct

[RFC][PATCH 24/27] new helper: alloc_file_clone()

From: Al Viro alloc_file_clone(old_file, mode, ops): create a new struct file with ->f_path equal to that of old_file. pipe converted. Signed-off-by: Al Viro --- fs/file_table.c | 11 +++ fs/pipe.c| 5 + include/linux/file.h | 2 ++ 3 files changed, 14

[RFC][PATCH 23/27] create_pipe_files(): switch the first allocation to alloc_file_pseudo()

From: Al Viro Signed-off-by: Al Viro --- fs/pipe.c | 41 ++--- 1 file changed, 10 insertions(+), 31 deletions(-) diff --git a/fs/pipe.c b/fs/pipe.c index 4d62c935f675..312af057f03a 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -744,56 +744,35 @@ static struct

[RFC][PATCH 24/27] new helper: alloc_file_clone()

From: Al Viro alloc_file_clone(old_file, mode, ops): create a new struct file with ->f_path equal to that of old_file. pipe converted. Signed-off-by: Al Viro --- fs/file_table.c | 11 +++ fs/pipe.c| 5 + include/linux/file.h | 2 ++ 3 files changed, 14

[RFC][PATCH 03/27] ocxlflash_getfile(): fix double-iput() on alloc_file() failures

From: Al Viro Cc: sta...@kernel.org Signed-off-by: Al Viro --- drivers/scsi/cxlflash/ocxl_hw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/cxlflash/ocxl_hw.c b/drivers/scsi/cxlflash/ocxl_hw.c index 0a95b5f25380..497a68389461 100644 ---

[RFC][PATCH 04/27] make sure do_dentry_open() won't return positive as an error

From: Al Viro An ->open() instances really, really should not be doing that. There's a lot of places e.g. around atomic_open() that could be confused by that, so let's catch that early. Signed-off-by: Al Viro --- fs/open.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/open.c

[RFC][PATCH 21/27] hugetlb_file_setup(): switch to alloc_file_pseudo()

From: Al Viro Signed-off-by: Al Viro --- fs/hugetlbfs/inode.c | 55 1 file changed, 17 insertions(+), 38 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index e0b8cc89169c..86ffe04f73d6 100644 ---

[RFC][PATCH 03/27] ocxlflash_getfile(): fix double-iput() on alloc_file() failures

From: Al Viro Cc: sta...@kernel.org Signed-off-by: Al Viro --- drivers/scsi/cxlflash/ocxl_hw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/cxlflash/ocxl_hw.c b/drivers/scsi/cxlflash/ocxl_hw.c index 0a95b5f25380..497a68389461 100644 ---

[RFC][PATCH 04/27] make sure do_dentry_open() won't return positive as an error

From: Al Viro An ->open() instances really, really should not be doing that. There's a lot of places e.g. around atomic_open() that could be confused by that, so let's catch that early. Signed-off-by: Al Viro --- fs/open.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/open.c

[RFC][PATCH 21/27] hugetlb_file_setup(): switch to alloc_file_pseudo()

From: Al Viro Signed-off-by: Al Viro --- fs/hugetlbfs/inode.c | 55 1 file changed, 17 insertions(+), 38 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index e0b8cc89169c..86ffe04f73d6 100644 ---

[RFC][PATCH 02/27] cxl_getfile(): fix double-iput() on alloc_file() failures

From: Al Viro Doing iput() after path_put() is wrong. Cc: sta...@kernel.org Signed-off-by: Al Viro --- drivers/misc/cxl/api.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c index 753b1a698fc4..6b16946f9b05 100644 ---

[RFC][PATCH 27/27] turn filp_clone_open() into inline wrapper for dentry_open()

From: Al Viro it's exactly the same thing as dentry_open(>f_path, file->f_flags, file->f_cred) ... and rename it to file_clone_open(), while we are at it. 'filp' naming convention is bogus; sure, it's "file pointer", but we generally don't do that kind of Hungarian notation. Some of the

[RFC][PATCH 02/27] cxl_getfile(): fix double-iput() on alloc_file() failures

From: Al Viro Doing iput() after path_put() is wrong. Cc: sta...@kernel.org Signed-off-by: Al Viro --- drivers/misc/cxl/api.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c index 753b1a698fc4..6b16946f9b05 100644 ---

[RFC][PATCH 27/27] turn filp_clone_open() into inline wrapper for dentry_open()

From: Al Viro it's exactly the same thing as dentry_open(>f_path, file->f_flags, file->f_cred) ... and rename it to file_clone_open(), while we are at it. 'filp' naming convention is bogus; sure, it's "file pointer", but we generally don't do that kind of Hungarian notation. Some of the

[RFC][PATCHES] open()-related cleanups

This is an update of open()-related work last posted a month ago. Series lives in vfs.git#work.open (and its beginning is in #fixes). Individual patches are in followups, shortlog (with outlines) follows: 1) some prep fixes: * drm_lease.c uses alloc_file() for no good reason -

[RFC][PATCHES] open()-related cleanups

This is an update of open()-related work last posted a month ago. Series lives in vfs.git#work.open (and its beginning is in #fixes). Individual patches are in followups, shortlog (with outlines) follows: 1) some prep fixes: * drm_lease.c uses alloc_file() for no good reason -

[RESEND PATCH v2] devres: Really align data field to unsigned long long

Depending on ABI "long long" type of a particular 32-bit CPU might be aligned by either word (32-bits) or double word (64-bits). Make sure "data" is really 64-bit aligned for any 32-bit CPU. At least for 32-bit ARC cores ABI requires "long long" types to be aligned by normal 32-bit word. This

[RESEND PATCH v2] devres: Really align data field to unsigned long long

Depending on ABI "long long" type of a particular 32-bit CPU might be aligned by either word (32-bits) or double word (64-bits). Make sure "data" is really 64-bit aligned for any 32-bit CPU. At least for 32-bit ARC cores ABI requires "long long" types to be aligned by normal 32-bit word. This

Re: [linux-sunxi] Re: [PATCH v2 7/9] phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC

在 2018-07-09一的 10:01 +0530，'Kishon Vijay Abraham I' via linux-sunxi写道： > Hi, > > On Friday 06 July 2018 09:08 PM, Icenowy Zheng wrote: > > Allwinner H6 SoC contains a USB3 PHY (with USB2 DP/DM lines also > > controlled). > > > > Add a driver for it. > > > > The register operations in this

Re: [linux-sunxi] Re: [PATCH v2 7/9] phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC

在 2018-07-09一的 10:01 +0530，'Kishon Vijay Abraham I' via linux-sunxi写道： > Hi, > > On Friday 06 July 2018 09:08 PM, Icenowy Zheng wrote: > > Allwinner H6 SoC contains a USB3 PHY (with USB2 DP/DM lines also > > controlled). > > > > Add a driver for it. > > > > The register operations in this

JÓ HÍREK

Kedves Kedvezményezettem, Biztos vagyok benne, hogy ez a levél meglepetésként fog megjelenni, mivel még soha nem találkoztunk, és akkor is megkérdeznéd, hogy miért döntöttem úgy, hogy választottam Önt a világ számos internethasználója között. Pontosan, nem tudom megmondani, hogy miért

RE: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

> -Original Message- > From: Srinivas Pandruvada [mailto:srinivas.pandruv...@linux.intel.com] > Sent: Saturday, July 7, 2018 8:44 AM > To: Darren Hart; Andy Shevchenko > Cc: Limonciello, Mario; Alex Hung; Andy Shevchenko; Platform Driver; Linux > Kernel > Mailing List; Rafael J. Wysocki >

JÓ HÍREK

Kedves Kedvezményezettem, Biztos vagyok benne, hogy ez a levél meglepetésként fog megjelenni, mivel még soha nem találkoztunk, és akkor is megkérdeznéd, hogy miért döntöttem úgy, hogy választottam Önt a világ számos internethasználója között. Pontosan, nem tudom megmondani, hogy miért

RE: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

> -Original Message- > From: Srinivas Pandruvada [mailto:srinivas.pandruv...@linux.intel.com] > Sent: Saturday, July 7, 2018 8:44 AM > To: Darren Hart; Andy Shevchenko > Cc: Limonciello, Mario; Alex Hung; Andy Shevchenko; Platform Driver; Linux > Kernel > Mailing List; Rafael J. Wysocki >

  1   2   3   4   5   6   >