[PATCH] staging: comedi: comedi_internal.h: Avoid '(' at the end of line

2018-07-14 Thread Nishad Kamdar
Bring function argument 'struct comedi_subdevice *s' to the previous line to avoid ending the line with open parenthesis. Issue found by checkpatch. Signed-off-by: Nishad Kamdar --- drivers/staging/comedi/comedi_internal.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dri

Re: [PATCH] thunderbolt: remove redundant variable 'approved'

2018-07-14 Thread Mika Westerberg
On Fri, Jul 13, 2018 at 09:57:25AM +0100, Colin King wrote: > From: Colin Ian King > > Variable 'approved' is being assigned but is never used hence it is > redundant and can be removed. > > Cleans up clang warning: > warning: variable 'approved' set but not used [-Wunused-but-set-variable] > >

Re: [PATCH] mm: avoid bothering interrupted task when charge memcg in softirq

2018-07-14 Thread Shakeel Butt
On Sat, Jul 14, 2018 at 10:26 PM Yafang Shao wrote: > > On Sun, Jul 15, 2018 at 12:25 PM, Shakeel Butt wrote: > > On Sat, Jul 14, 2018 at 7:10 PM Yafang Shao wrote: > >> > >> On Sat, Jul 14, 2018 at 11:38 PM, Shakeel Butt wrote: > >> > On Sat, Jul 14, 2018 at 1:32 AM Yafang Shao wrote: > >> >>

Re: [PATCH] IB/mlx5: avoid binding a new mpi unit to the same devices repeatedly

2018-07-14 Thread Leon Romanovsky
On Sat, Jul 14, 2018 at 06:57:01PM +0300, Or Gerlitz wrote: > On Sat, Jul 14, 2018 at 2:50 AM, Qing Huang wrote: > > When a CX5 device is configured in dual-port RoCE mode, after creating > > many VFs against port 1, creating the same number of VFs against port 2 > > will flood kernel/syslog with

[GIT PULL] ARM: SoC fixes

2018-07-14 Thread Olof Johansson
Hi Linus, The following changes since commit f0463f3619fd10e0cbaa5195bf2bc264a77a586d: Merge tag 'omap-for-v4.18/fixes-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap into fixes (2018-07-05 14:59:20 -0700) are available in the git repository at: git://git.kernel

Re: [Ksummit-discuss] bug-introducing patches

2018-07-14 Thread Willy Tarreau
On Sat, Jul 14, 2018 at 11:09:13PM +0200, Pavel Machek wrote: > > For anyone interested in making sure that obscure (whatever that means) > > drivers are tested for stable releases, but does not want to spend time on > > it, > > all I can recommend is to implement qemu support for it and let me kn

Re: [PATCH v5 6/7] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-07-14 Thread Sean Wang
On Sat, 2018-07-14 at 18:32 +0200, Marcel Holtmann wrote: > Hi Sean, > > > This adds a driver to run on the top of btuart driver for the MediaTek > > serial protocol based on running H:4, which can enable the built-in > > Bluetooth device inside MT7622 SoC. > > > > Signed-off-by: Sean Wang > > -

Re: [PATCH] mm: avoid bothering interrupted task when charge memcg in softirq

2018-07-14 Thread Yafang Shao
On Sun, Jul 15, 2018 at 12:25 PM, Shakeel Butt wrote: > On Sat, Jul 14, 2018 at 7:10 PM Yafang Shao wrote: >> >> On Sat, Jul 14, 2018 at 11:38 PM, Shakeel Butt wrote: >> > On Sat, Jul 14, 2018 at 1:32 AM Yafang Shao wrote: >> >> >> >> try_charge maybe executed in packet receive path, which is i

Re: [PATCH v5 1/7] dt-bindings: net: bluetooth: Add mediatek-bluetooth

2018-07-14 Thread Sean Wang
On Sat, 2018-07-14 at 18:26 +0200, Marcel Holtmann wrote: > Hi Sean, > > > Add binding document for a SoC built-in device using MediaTek protocol. > > Which could be found on MT7622 SoC or other similar MediaTek SoCs. > > > > Signed-off-by: Sean Wang > > Reviewed-by: Rob Herring > > --- > > ...

Re: [PATCH] mm: avoid bothering interrupted task when charge memcg in softirq

2018-07-14 Thread Shakeel Butt
On Sat, Jul 14, 2018 at 7:10 PM Yafang Shao wrote: > > On Sat, Jul 14, 2018 at 11:38 PM, Shakeel Butt wrote: > > On Sat, Jul 14, 2018 at 1:32 AM Yafang Shao wrote: > >> > >> try_charge maybe executed in packet receive path, which is in interrupt > >> context. > >> In this situation, the 'current

Re: [PATCH] kernel.h: Avoid that sparse complains about using sizeof(void)

2018-07-14 Thread Bart Van Assche
On Sat, 2018-07-14 at 18:59 -0700, Linus Torvalds wrote: > On Sat, Jul 14, 2018 at 6:57 PM Linus Torvalds > wrote: > > Honestly, I'd like to just encourage people to get the sparse update > > from Luc Van Oostenryck instead. > > > > For a while there it looked like Chris Li would just pull from

[PATCH] arm64: cpuinfo: Include cleartext implementer and part strings

2018-07-14 Thread Olof Johansson
There's some use in printing out what the implementer and part numbers decode to for cases where they're known. I filled in the table based on public information; mostly from ARM TRMs and other tools (and some of the SSBD tables in the kernel, etc). Apple IDs came from https://github.com/apple/da

Re: [PATCH] kernel.h: Avoid that sparse complains about using sizeof(void)

2018-07-14 Thread Bart Van Assche
On Sat, 2018-07-14 at 18:59 -0700, Linus Torvalds wrote: > On Sat, Jul 14, 2018 at 6:57 PM Linus Torvalds > wrote: > > > > Honestly, I'd like to just encourage people to get the sparse update > > from Luc Van Oostenryck instead. > > > > For a while there it looked like Chris Li would just pull f

[PATCH] x86/boot: Fix if_changed build flip/flop

2018-07-14 Thread Kees Cook
The if_changed kbuild function can only be used once per target. If not it will effectively always trigger, flipping back and forth between the two commands getting recorded. Instead, merge the two commands into a single function to get stable build artifacts (i.e. .vmlinux.cmd). Reported-by: Dirk

Re: [PATCH] mm: avoid bothering interrupted task when charge memcg in softirq

2018-07-14 Thread Yafang Shao
On Sun, Jul 15, 2018 at 10:10 AM, Yafang Shao wrote: > On Sat, Jul 14, 2018 at 11:38 PM, Shakeel Butt wrote: >> On Sat, Jul 14, 2018 at 1:32 AM Yafang Shao wrote: >>> >>> try_charge maybe executed in packet receive path, which is in interrupt >>> context. >>> In this situation, the 'current' is

Re: [PATCH 1/1] f2fs: checkpoint disabling

2018-07-14 Thread Jaegeuk Kim
On 07/11, Daniel Rosenberg wrote: > This adds a lightweight non-persistent snapshotting scheme to f2fs. > > To use, mount with the option checkpoint=disable, and to return to > normal operation, remount with checkpoint=enable. If the filesystem > is shut down before remounting with checkpoint=enab

Re: [PATCH] mm: avoid bothering interrupted task when charge memcg in softirq

2018-07-14 Thread Yafang Shao
On Sat, Jul 14, 2018 at 11:38 PM, Shakeel Butt wrote: > On Sat, Jul 14, 2018 at 1:32 AM Yafang Shao wrote: >> >> try_charge maybe executed in packet receive path, which is in interrupt >> context. >> In this situation, the 'current' is the interrupted task, which may has >> no relation to the rx

Re: [PATCH v7] add param that allows bootline control of hardened usercopy

2018-07-14 Thread Kees Cook
On Wed, Jul 4, 2018 at 10:47 AM, Vlastimil Babka wrote: > On 07/04/2018 06:52 PM, Kees Cook wrote: >> This produces less efficient code in the general case, and I'd like to >> keep the general case (hardening enabled) as fast as possible. > > How specifically is the code less efficient? It should

Re: [PATCH] kernel.h: Avoid that sparse complains about using sizeof(void)

2018-07-14 Thread Linus Torvalds
Oh, and I meant to cc Luc on that email, but then forgot. So here he is cc'd now. Linus On Sat, Jul 14, 2018 at 6:57 PM Linus Torvalds wrote: > > Honestly, I'd like to just encourage people to get the sparse update > from Luc Van Oostenryck instead. > > For a while there it looked l

Re: [PATCH] kernel.h: Avoid that sparse complains about using sizeof(void)

2018-07-14 Thread Linus Torvalds
On Sat, Jul 14, 2018 at 6:49 PM Kees Cook wrote: > > I'm fine with this; it'll only activate for sparse. I'd like to get > Linus's eyes on it, though, since this macro caused us SO much pain > that I'm nervous to change it without some greater level of review. :) Honestly, I'd like to just encour

Re: [PATCH] kernel.h: Avoid that sparse complains about using sizeof(void)

2018-07-14 Thread Kees Cook
On Thu, Jul 5, 2018 at 9:17 AM, Bart Van Assche wrote: > The macro __is_constexpr() causes sparse to report the following: > > warning: expression using sizeof(void) > > Avoid this by using __builtin_constant_p() instead. > > Fixes: 3c8ba0d61d04 ("kernel.h: Retain constant expression output fo

Re: [PATCH v13 2/2] Add oom victim's memcg to the oom context information

2018-07-14 Thread 禹舟键
Hi David Could I use use plain old %d? Just like this, pr_cont(",task=%s,pid=%d,uid=%d\n", p->comm, p->pid, from_kuid(&init_user_ns, task_uid(p))); Thanks

[PATCH] RISC-V: Don't increment sepc after breakpoint.

2018-07-14 Thread Jim Wilson
Adding 4 to sepc is pointless, and is wrong if we executed a 2-byte compressed breakpoint. This plus a corresponding gdb patch allows compressed breakpoints to work in gdb. Gdb maintainers have already agreed that this is the right approach. Signed-off-by: Jim Wilson --- arch/riscv/kernel/trap

Re: [PATCH] base: core: Remove WARN_ON from link dependencies check

2018-07-14 Thread Mark Brown
On Thu, Jul 12, 2018 at 10:06:23AM +0200, Benjamin Gaignard wrote: > In some cases the link between between customer and supplier > already exist. Do not warn about already existing dependencies > because device_link_add() take care of this case. Reviwed-by: Mark Brown signature.asc Description

Applied "ASoC: allow soc-core to pick up name prefixes from component nodes" to the asoc tree

2018-07-14 Thread Mark Brown
The patch ASoC: allow soc-core to pick up name prefixes from component nodes has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next

Applied "ASoC: trace: remove snd_soc_codec" to the asoc tree

2018-07-14 Thread Mark Brown
The patch ASoC: trace: remove snd_soc_codec has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus durin

Applied "ASoC: add DT documentation for the sound-name-prefix property" to the asoc tree

2018-07-14 Thread Mark Brown
The patch ASoC: add DT documentation for the sound-name-prefix property has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 ho

Re: [PATCH] regulator: core: fix _regulator_do_disable return value

2018-07-14 Thread Mark Brown
On Fri, Jul 13, 2018 at 05:48:54PM +0200, Marco Felsch wrote: > On 18-07-13 14:07, Mark Brown wrote: > > This is fine - consumers shouldn't expect that a disable will cause > > anything to actually get powered off, constraints or other consumers > > might mean that the disable doesn't actually hap

Re: [PATCH v2 1/3] dt-bindings: pfuze100: add optional disable switch-regulators binding

2018-07-14 Thread Mark Brown
On Fri, Jul 13, 2018 at 02:50:01PM +0200, Marco Felsch wrote: > +Optional properties: > +- fsl,pfuze-support-disable: Boolean, if present disable all unused switch > + regulators to save power consumption. Attention, till 4.18 these regulators The property name sounds like it affects all the reg

[PATCH] ACPI: battery: remove redundant old_present check on insertion

2018-07-14 Thread Lucas Magasweran
From: Lucas Rangit Magasweran On removal battery_present changes from 1 to 0 after calling acpi_battery_get_statu() and battery->update_time is set to 0 before returning. On insertion battery_present changes from 0 to 1 after calling acpi_battery_get_status() and acpi_battery_get_info() is calle

Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

2018-07-14 Thread Pavel Machek
On Sun 2018-07-15 00:29:25, Pavel Machek wrote: > On Sun 2018-07-15 00:02:57, Jacek Anaszewski wrote: > > Hi Pavel, > > > > On 07/14/2018 11:20 PM, Pavel Machek wrote: > > >Hi! > > > > > >>>It also drew my attention to the issue of desired pattern sysfs > > >>>interface semantics on uninitialized

[PATCH] ACPI: battery: use cache_time as cache "enabled"

2018-07-14 Thread Lucas Magasweran
From: Lucas Rangit Magasweran When battery state is not cached the module parameter cache_time is 0 and battery->update_time starts at 0. However, it set to jiffies in each call to acpi_battery_get_state() and should not be used to determine if a cache time is used. Using battery->update_time ca

[PATCH 2/2] staging: olpc_dcon: add missing identifier names

2018-07-14 Thread Cristian Kubis
Add missing function argument identifier names as suggested by checkpatch.pl. Signed-off-by: Cristian Kubis --- drivers/staging/olpc_dcon/olpc_dcon.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_

[PATCH 1/2] staging: olpc_dcon: prefer 'help' in KConfig

2018-07-14 Thread Cristian Kubis
Fix for a style warning reported by checkpatch.pl in KConfig suggesting to use 'help' instead of '---help---'. Signed-off-by: Cristian Kubis --- drivers/staging/olpc_dcon/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/olpc_dcon/Kconfig b/driver

[PATCH 0/2] staging: olpc_dcon: fix style warnings

2018-07-14 Thread Cristian Kubis
Series of patches fixing two different kinds of style warnings in olpc_dcon as reported by checkpatch.pl. Cristian Kubis (2): staging: olpc_dcon: prefer 'help' in KConfig staging: olpc_dcon: add missing identifier names drivers/staging/olpc_dcon/Kconfig | 6 +++--- drivers/staging/olpc_d

Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

2018-07-14 Thread Pavel Machek
On Sun 2018-07-15 00:02:57, Jacek Anaszewski wrote: > Hi Pavel, > > On 07/14/2018 11:20 PM, Pavel Machek wrote: > >Hi! > > > >>>It also drew my attention to the issue of desired pattern sysfs > >>>interface semantics on uninitialized pattern. In your implementation > >>>user seems to be unable to

Re: [PATCH v9 1/5] clocksource/drivers/timer-mediatek: Add system timer bindings

2018-07-14 Thread Daniel Lezcano
On 06/07/2018 01:11, Stanley Chu wrote: > This patch adds bindings of new "System Timer" on Mediatek SoCs. > > Remove RTC clock in the same time because it is not used by > both "General Purpose Timer" and "System Timer" now. > > Signed-off-by: Stanley Chu > --- I have applied the series for 4.

Re: [GIT PULL 3/3] ARM: defconfig: Pull for v4.19

2018-07-14 Thread Olof Johansson
On Thu, Jul 12, 2018 at 06:46:39PM +0200, Krzysztof Kozlowski wrote: > Hi, > > Rebased on v4.18-rc2. > > Best regards, > Krzysztof > > > The following changes since commit 7daf201d7fe8334e2d2364d4e8ed3394ec9af819: > > Linux 4.18-rc2 (2018-06-24 20:54:29 +0800) > > are available in the git r

Re: [GIT PULL 1/3] ARM: dts: exynos: Pull for v4.19

2018-07-14 Thread Olof Johansson
On Thu, Jul 12, 2018 at 06:46:40PM +0200, Krzysztof Kozlowski wrote: > Hi, > > Rebased on v4.18-rc2. > > Best regards, > Krzysztof > > > The following changes since commit 7daf201d7fe8334e2d2364d4e8ed3394ec9af819: > > Linux 4.18-rc2 (2018-06-24 20:54:29 +0800) > > are available in the git r

Re: [GIT PULL 2/3] arm64: dts: exynos: Pull for v4.19

2018-07-14 Thread Olof Johansson
On Thu, Jul 12, 2018 at 06:46:41PM +0200, Krzysztof Kozlowski wrote: > Hi, > > Rebased on v4.18-rc2. > > Best regards, > Krzysztof > > > The following changes since commit 7daf201d7fe8334e2d2364d4e8ed3394ec9af819: > > Linux 4.18-rc2 (2018-06-24 20:54:29 +0800) > > are available in the git r

Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

2018-07-14 Thread Jacek Anaszewski
Hi Pavel, On 07/14/2018 11:20 PM, Pavel Machek wrote: Hi! It also drew my attention to the issue of desired pattern sysfs interface semantics on uninitialized pattern. In your implementation user seems to be unable to determine if the pattern is activated or not. We should define the semantics

Re: [PATCH] vme: ca91cx42: remove redundant variable i

2018-07-14 Thread Martyn Welch
On Sat, Jul 14, 2018 at 05:33:32PM +0100, Colin King wrote: > From: Colin Ian King > > Variable i is being assigned but is never used hence it is redundant > and can be removed. > > Cleans up clang warning: > warning: variable 'i' set but not used [-Wunused-but-set-variable] > > Signed-off-by:

Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface

2018-07-14 Thread Pavel Machek
Hi! > > It also drew my attention to the issue of desired pattern sysfs > > interface semantics on uninitialized pattern. In your implementation > > user seems to be unable to determine if the pattern is activated > > or not. We should define the semantics for this use case and > > describe it in

Re: [Ksummit-discuss] bug-introducing patches

2018-07-14 Thread Pavel Machek
Hi! > >Well, 0day, kernelci etc... is nice... until the change is in the > >driver. Most of the kernel are drivers, remember? > > > >I don't know. I'd say that if patch is important enough for -stable, > >there should be someone testing it. For core kernel changes, that can > >be 0day bot, but for

[GIT PULL] RTC fixes for 4.18

2018-07-14 Thread Alexandre Belloni
Hi Linus, Here are two fixes for 4.18. The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git tags/rtc-4.18-2 for you

Re: [Ksummit-discuss] bug-introducing patches

2018-07-14 Thread Guenter Roeck
On 07/14/2018 12:47 PM, Pavel Machek wrote: Hi! The way I see it, if a commit can get one or two tested-by, it's a good alternative to a week in -next. Agreed. Even their own actually. And I'm not kidding. Those who run large amounts of tests on certain patches could really mention is in test

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Cyrill Gorcunov
On Sat, Jul 14, 2018 at 02:39:24PM -0500, Eric W. Biederman wrote: > Josh Triplett writes: > > > On Sat, Jul 14, 2018 at 02:04:46PM -0500, Eric W. Biederman wrote: > >> For a config option that no one has come forward with an actual real > >> world use case for disabling, that cost seems much too

Re: [PATCH 2/2] ARM: dts: pxa: add mioa701 board description

2018-07-14 Thread Robert Jarzmik
Rob Herring writes: Hi Rob, >> + /* compatible = "mitac,mioa701"; */ >> + compatible = "marvell,pxa270"; > > Why the comment? Leftover, I'll remove it. >> + pstore_region:region@0xa200 { > > Drop the 0x Done. >> + compatible =

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Josh Triplett
On Sat, Jul 14, 2018 at 02:39:24PM -0500, Eric W. Biederman wrote: > Josh Triplett writes: > > > On Sat, Jul 14, 2018 at 02:04:46PM -0500, Eric W. Biederman wrote: > >> For a config option that no one has come forward with an actual real > >> world use case for disabling, that cost seems much too

[PATCH] x86/events/intel/ds: Fix bts_interrupt_threshold alignment

2018-07-14 Thread Hugh Dickins
Markus reported that BTS is sporadically missing the tail of the trace in the perf_event data buffer: [decode error (1): instruction overflow] shown in GDB; and bisected it to the conversion of debug_store to PTI. A little "optimization" crept into alloc_bts_buffer(), which mistakenly placed bts_i

Re: [PATCH 1/2] mux:adgs1408/1409: New driver for Analog Devices ADGS1408/1409 mux …

2018-07-14 Thread Peter Rosin
On 2018-07-14 16:02, Lars-Peter Clausen wrote: > On 07/14/2018 02:04 PM, Peter Rosin wrote: > [...] >>> +static int adgs140x_spi_reg_write(struct spi_device *spi, >>> + u8 reg_addr, u8 reg_data) >>> +{ >>> + u8 tx_buf[2]; >>> + >>> + tx_buf[0] = reg_addr; >>> + tx_bu

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Josh Triplett
On Sat, Jul 14, 2018 at 02:04:46PM -0500, Eric W. Biederman wrote: > For a config option that no one has come forward with an actual real > world use case for disabling, that cost seems much too high. The real-world use case is precisely as stated: code size, both storage and RAM. I regularly enc

Re: [Ksummit-discuss] bug-introducing patches

2018-07-14 Thread Pavel Machek
Hi! > >>>The way I see it, if a commit can get one or two tested-by, it's a good > >>>alternative to a week in -next. > >> > >>Agreed. Even their own actually. And I'm not kidding. Those who run large > >>amounts of tests on certain patches could really mention is in tested-by, > >>as opposed to t

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Eric W. Biederman
Josh Triplett writes: > On Sat, Jul 14, 2018 at 02:04:46PM -0500, Eric W. Biederman wrote: >> For a config option that no one has come forward with an actual real >> world use case for disabling, that cost seems much too high. > > The real-world use case is precisely as stated: code size, both st

Re: [PATCH 12/18] staging: gasket: annotate ioctl arg with __user

2018-07-14 Thread Todd Poynor
>> I think I'm following >> http://www.kroah.com/log/linux/linux-staging-update.html, >> but if I'm off in the weeds do clue me in, thanks. > > That's something I wrote 9 years ago :) Still the top search result for how to work in staging, suggest an update. :)

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-14 Thread Eric W. Biederman
Kees Cook writes: > On Fri, Jul 13, 2018 at 1:55 PM, Andrew Morton > wrote: >> On Thu, 12 Jul 2018 11:33:33 -0500 ebied...@xmission.com (Eric W. Biederman) >> wrote: >>> What is the value of disabling this functionality ever? >>> >>> Is there any reason why we don't just delete CONFIG_CHECKPOIN

Re: [PATCH v5 0/6] fs/dcache: Track & limit # of negative dentries

2018-07-14 Thread Linus Torvalds
On Sat, Jul 14, 2018 at 11:36 AM Al Viro wrote: > > OK, this > /* > * No ordinary (disk based) filesystem counts links as inodes; > * but each new link needs a new dentry, pinning lowmem, and > * tmpfs dentries cannot be pruned until they are unlinked. >

Re: [Ksummit-discuss] bug-introducing patches

2018-07-14 Thread Guenter Roeck
On 07/14/2018 10:38 AM, Pavel Machek wrote: Hi! The way I see it, if a commit can get one or two tested-by, it's a good alternative to a week in -next. Agreed. Even their own actually. And I'm not kidding. Those who run large amounts of tests on certain patches could really mention is in test

Re: [PATCH v5 0/6] fs/dcache: Track & limit # of negative dentries

2018-07-14 Thread Al Viro
On Sat, Jul 14, 2018 at 07:34:45PM +0100, Al Viro wrote: > On Sat, Jul 14, 2018 at 11:00:32AM -0700, Linus Torvalds wrote: > > On Sat, Jul 14, 2018 at 10:35 AM Pavel Machek wrote: > > > > > > Could we allocate -ve entries from separate slab? > > > > No, because negative dentrires don't stay negat

Re: [PATCH v5 0/6] fs/dcache: Track & limit # of negative dentries

2018-07-14 Thread Al Viro
On Sat, Jul 14, 2018 at 11:00:32AM -0700, Linus Torvalds wrote: > On Sat, Jul 14, 2018 at 10:35 AM Pavel Machek wrote: > > > > Could we allocate -ve entries from separate slab? > > No, because negative dentrires don't stay negative. > > Every single positive dentry starts out as a negative dentr

Re: [PATCH v5 0/6] fs/dcache: Track & limit # of negative dentries

2018-07-14 Thread Linus Torvalds
On Sat, Jul 14, 2018 at 10:35 AM Pavel Machek wrote: > > Could we allocate -ve entries from separate slab? No, because negative dentrires don't stay negative. Every single positive dentry starts out as a negative dentry that is passed in to "lookup()" to maybe be made positive. And most of the

[PATCH 1/2] staging:r8188eu: Use lib80211 to encrypt (TKIP) tx frames

2018-07-14 Thread Ivan Safonov
Put data to skb, decrypt with lib80211_crypt_tkip, and place back to tx buffer. MIC calculation will be replaced later. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_security.c | 419 +- 1 file changed, 77 insertions(+), 342 deletions(-) diff --git

[PATCH 2/2] staging:r8188eu: Use lib80211 to encrypt (CCMP) tx frames

2018-07-14 Thread Ivan Safonov
Put data to skb, decrypt with lib80211_crypt_ccmp, and place back to tx buffer. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_security.c | 778 +++--- 1 file changed, 72 insertions(+), 706 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_secu

Re: bug-introducing patches

2018-07-14 Thread Pavel Machek
Hi! > > The way I see it, if a commit can get one or two tested-by, it's a good > > alternative to a week in -next. > > Agreed. Even their own actually. And I'm not kidding. Those who run large > amounts of tests on certain patches could really mention is in tested-by, > as opposed to the most co

Re: [PATCH v5 0/6] fs/dcache: Track & limit # of negative dentries

2018-07-14 Thread Pavel Machek
> > Yes, "should be". I could understand that the presence of huge > > nunmbers of -ve dentries could result in undesirable reclaim of > > pagecache, etc. Triggering oom-killings is very bad, and presumably > > has the same cause. > > > > Before we go and add a large amount of code to do the shr

Re: [PATCH v5 5/7] Bluetooth: Extend btuart driver for join more vendor devices

2018-07-14 Thread Marcel Holtmann
Hi Sean, > Adding an independent btuart.h header allows these essential definitions > can be reused in vendor driver. Also, struct btuart_vnd is extended with > additional callbacks such as .init initializing vendor data, .shtudown, > .recv and .send supporting SoC specific framing for that btuart

Re: [PATCH v5 4/7] Bluetooth: Add new quirk for non-persistent setup settings

2018-07-14 Thread Marcel Holtmann
Hi Sean, > Add a new quirk HCI_QUIRK_NON_PERSISTENT_SETUP allowing that a quirk that > runs setup() after every open() and not just after the first open(). > > Signed-off-by: Sean Wang > --- > include/net/bluetooth/hci.h | 9 + > net/bluetooth/hci_core.c| 3 ++- > 2 files changed, 11 i

[PATCH] vme: ca91cx42: remove redundant variable i

2018-07-14 Thread Colin King
From: Colin Ian King Variable i is being assigned but is never used hence it is redundant and can be removed. Cleans up clang warning: warning: variable 'i' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King --- drivers/vme/bridges/vme_ca91cx42.c | 2 -- 1 file changed

Re: [PATCH v5 6/7] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-07-14 Thread Marcel Holtmann
Hi Sean, > This adds a driver to run on the top of btuart driver for the MediaTek > serial protocol based on running H:4, which can enable the built-in > Bluetooth device inside MT7622 SoC. > > Signed-off-by: Sean Wang > --- > drivers/bluetooth/Kconfig | 11 ++ > drivers/bluetooth/Makefile

Re: [PATCH v5 2/7] serdev: add dev_pm_domain_attach|detach()

2018-07-14 Thread Marcel Holtmann
Hi Sean, > In order to open up the required power gate before any operation can be > effectively performed over the serial bus between CPU and serdev, it's > clearly essential to add common attach functions for PM domains to serdev > at the probe phase. > > Similarly, the relevant dettach functio

Re: [PATCH v5 1/7] dt-bindings: net: bluetooth: Add mediatek-bluetooth

2018-07-14 Thread Marcel Holtmann
Hi Sean, > Add binding document for a SoC built-in device using MediaTek protocol. > Which could be found on MT7622 SoC or other similar MediaTek SoCs. > > Signed-off-by: Sean Wang > Reviewed-by: Rob Herring > --- > .../devicetree/bindings/net/mediatek-bluetooth.txt | 35 ++

[PATCH] keys: trusted: remove redundant variable keyhndl

2018-07-14 Thread Colin King
From: Colin Ian King Variable keyhndl is being assigned but is never used hence it is redundant and can be removed. Cleans up clang warning: warning: variable 'keyhndl' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King --- security/keys/trusted.c | 2 -- 1 file change

Re: [PATCH] rtc: jz4740: Add support for the JZ4725B, JZ4760, JZ4770

2018-07-14 Thread Alexandre Belloni
On 14/07/2018 15:50:08+0200, Paul Cercueil wrote: > > > > This would avoid that change (and the test would preferably be > > > > (rtc->type == ID_JZ4780)) > > > > > > That branch should be taken if the SoC is JZ4760, JZ4770 or JZ4780. > > > It should not be taken if the SoC is JZ4740 or JZ4725

[PATCH] apparmor: remove redundant pointer 'info'

2018-07-14 Thread Colin King
From: Colin Ian King Pointer 'info' is being assigned but is never used hence it is redundant and can be removed. Cleans up clang warning: warning: variable 'info' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King --- security/apparmor/domain.c | 6 +- 1 file chan

Re: [PATCH] gpio: mxc: add power management support

2018-07-14 Thread Fabio Estevam
Hi Anson, On Fri, Jul 13, 2018 at 10:53 PM, Anson Huang wrote: > Here are the details, i.MX7D LPSR mode and i.MX8QM/8QXP etc.' suspend/resume > may cause GPIO bank lose power, so need to save/restore, for other i.MX SoCs, > although no need to do save/restore, but doing it is NOT harmful, so do

[PATCH] mm/hmm.c: remove redundant variables align_start and align_end

2018-07-14 Thread Colin King
From: Colin Ian King Variables align_start and align_end are being assigned but are never used hence they are redundant and can be removed. Cleans up clang warnings: warning: variable 'align_start' set but not used [-Wunused-but-set-variable] warning: variable 'align_size' set but not used [-Wun

Re: [PATCH V2] ARM: dts: imx6sl-evk: add missing GPIO iomux setting

2018-07-14 Thread Fabio Estevam
Hi Anson, On Fri, Jul 13, 2018 at 10:53 PM, Anson Huang wrote: > On i.MX6SL EVK board, the MX6SL_PAD_KEY_ROW5 pin is > used as lcd 3v3 regulator control pin, need to make > sure MX6SL_PAD_KEY_ROW5 is muxed as GPIO function > for controlling lcd 3v3 regulator. > > Signed-off-by: Anson Huang Look

Re: [PATCH] IB/mlx5: avoid binding a new mpi unit to the same devices repeatedly

2018-07-14 Thread Or Gerlitz
On Sat, Jul 14, 2018 at 2:50 AM, Qing Huang wrote: > When a CX5 device is configured in dual-port RoCE mode, after creating > many VFs against port 1, creating the same number of VFs against port 2 > will flood kernel/syslog with something like > "mlx5_*:mlx5_ib_bind_slave_port:4266:(pid 5269): po

[PATCH] staging: comedi: comedi_fops: Shift assignment operator '=' to previous line

2018-07-14 Thread Nishad Kamdar
Shift '=' assignment operator to the end of previous line to conform to preferred kernel style line wrapping. Issue reported by checkpatch CHECK. Signed-off-by: Nishad Kamdar --- drivers/staging/comedi/comedi_fops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/

Re: [PATCH] mm: avoid bothering interrupted task when charge memcg in softirq

2018-07-14 Thread Shakeel Butt
On Sat, Jul 14, 2018 at 1:32 AM Yafang Shao wrote: > > try_charge maybe executed in packet receive path, which is in interrupt > context. > In this situation, the 'current' is the interrupted task, which may has > no relation to the rx softirq, So it is nonsense to use 'current'. > Have you actua

[PATCH v2 2/2] pinctrl: meson-g12a: add pinctrl driver support

2018-07-14 Thread Yixun Lan
Add the pinctrl driver for Meson-G12A SoC which share the similar IP as the previous Meson-AXG SoC. Starting from Meson-AXG SoC, the pinctrl controller block use 4 continues register bits to specific the pin mux function, while comparing to old generation SoC which using variable length register b

[PATCH v2 0/2] pinctrl: meson-g12a: add pinctrl driver support

2018-07-14 Thread Yixun Lan
This patch series try to add pinctrl driver support for the Meson-G12A SoC. Changes since v1 at [1] - add Martin's Ack, Xingyu's Signed-off - squash patch 1,2 (documentation & header file) - explain pinctrl IP - notice GPIOE located in AO bank [1] https://lkml.kernel.org/r/20180704224511.2935

Re: [PATCH 3/3] pinctrl: meson-g12a: add pinctrl driver support

2018-07-14 Thread Martin Blumenstingl
Hi Yixun, On Wed, Jul 4, 2018 at 4:50 PM Yixun Lan wrote: > > Add the pinctrl driver for Meson-G12A SoC which share the similar IP as > the previous Meson-AXG SoC. my understanding is that: - AXG and G12A use the same mechanism (register layout) to configure the pin controller - however, the pin

[PATCH v2 1/2] documentation: pinctrl: Add compatibles for Amlogic Meson G12A pin controllers

2018-07-14 Thread Yixun Lan
Add new compatible name for Amlogic's Meson-G12A pin controllers, add a dt-binding header file which document the detail pin names. Acked-by: Martin Blumenstingl Signed-off-by: Xingyu Chen Signed-off-by: Yixun Lan --- .../bindings/pinctrl/meson,pinctrl.txt| 2 + include/dt-bindings/g

REGRESSION: [RESEND PATCH v3 1/4] backlight: pwm_bl: linear interpolation between brightness-levels

2018-07-14 Thread Marcel Ziswiler
On Mon, 2018-04-09 at 10:33 +0200, Enric Balletbo i Serra wrote: > Setting num-interpolated-steps in the dts will allow you to have > linear > interpolation between values of brightness-levels. This way a high > resolution pwm duty cycle can be used without having to list out > every > possible val

Re: [PATCH 2/3] dt-bindings: pinctrl: meson-g12a: document pin name

2018-07-14 Thread Yixun Lan
HI Martin thanks for the comments On 07/14/2018 10:47 PM, Martin Blumenstingl wrote: > Hi Yixun, > > On Wed, Jul 4, 2018 at 4:49 PM Yixun Lan wrote: >> >> Document the pins for Amlogic's Meson-G12A SoC. > I suggest to combine patch 1 (adding the compatible string) and 2 (this one) > > as dis

Re: [PATCH 2/3] dt-bindings: pinctrl: meson-g12a: document pin name

2018-07-14 Thread Martin Blumenstingl
Hi Yixun, On Wed, Jul 4, 2018 at 4:49 PM Yixun Lan wrote: > > Document the pins for Amlogic's Meson-G12A SoC. I suggest to combine patch 1 (adding the compatible string) and 2 (this one) as discussed in the cover letter: it would be great if you could add a comment (at least to the commit messag

Re: [PATCH 0/3] pinctrl: meson-g12a: add pinctrl driver support

2018-07-14 Thread Yixun Lan
Hi Martin see my comments On 07/14/2018 10:36 PM, Martin Blumenstingl wrote: > On Tue, Jul 10, 2018 at 12:07 AM Martin Blumenstingl > wrote: >> >> Hi Linus, >> >> On Mon, Jul 9, 2018 at 3:35 PM Linus Walleij >> wrote: >>> >>> On Wed, Jul 4, 2018 at 4:48 PM Yixun Lan wrote: This patc

Re: [PATCH 1/3] soc: amlogic: Add Meson GX Clock Measure driver

2018-07-14 Thread Martin Blumenstingl
Hi Neil, On Wed, Jul 11, 2018 at 10:37 AM Neil Armstrong wrote: > > On 09/07/2018 23:41, Kevin Hilman wrote: > > Martin Blumenstingl writes: > > > >> Hi Neil, > >> > >> On Wed, Jul 4, 2018 at 10:41 AM Neil Armstrong > >> wrote: > >>> > >>> Hi Martin, > >>> > >>> On 03/07/2018 21:18, Martin Blu

Re: [PATCH 0/3] pinctrl: meson-g12a: add pinctrl driver support

2018-07-14 Thread Martin Blumenstingl
On Tue, Jul 10, 2018 at 12:07 AM Martin Blumenstingl wrote: > > Hi Linus, > > On Mon, Jul 9, 2018 at 3:35 PM Linus Walleij wrote: > > > > On Wed, Jul 4, 2018 at 4:48 PM Yixun Lan wrote: > > > > > > This patch series try to add pinctrl driver support for > > > the Meson-G12A SoC. > > > > > > > >

Re: [PATCH 10/39] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack

2018-07-14 Thread Andy Lutomirski
> On Jul 14, 2018, at 1:01 AM, Joerg Roedel wrote: > > On Fri, Jul 13, 2018 at 11:26:54PM -0700, Andy Lutomirski wrote: >>> So based on that, I did the above because the entry-stack is a per-cpu >>> data structure and I am not sure that we always return from the exception >>> on the same CPU w

Re: [PATCH v10 2/3] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-07-14 Thread Mathieu Desnoyers
- On Jul 13, 2018, at 5:55 PM, Joel Fernandes, Google j...@joelfernandes.org wrote: > From: "Joel Fernandes (Google)" > > In recent tests with IRQ on/off tracepoints, a large performance > overhead ~10% is noticed when running hackbench. This is root caused to > calls to rcu_irq_enter_irqso

Re: [PATCH 1/3] dt-bindings: clk: g12a: New binding for Meson-G12A SoC

2018-07-14 Thread Martin Blumenstingl
On Wed, Jul 11, 2018 at 3:06 PM Jian Hu wrote: > > > > On 2018/7/10 17:29, Jerome Brunet wrote: > > On Mon, 2018-07-09 at 19:12 +0800, Jian Hu wrote: > >> Add new binding for Meson-G12A SoC Everything-Else part > > > > nitpick: I would prefer if the words 'clock' and 'controller' was somewhere >

Re: [PATCH 1/2] mux:adgs1408/1409: New driver for Analog Devices ADGS1408/1409 mux …

2018-07-14 Thread Lars-Peter Clausen
On 07/14/2018 02:04 PM, Peter Rosin wrote: [...] >> +static int adgs140x_spi_reg_write(struct spi_device *spi, >> +u8 reg_addr, u8 reg_data) >> +{ >> +u8 tx_buf[2]; >> + >> +tx_buf[0] = reg_addr; >> +tx_buf[1] = reg_data; >> + >> +return spi_write_then_re

Re: [PATCH] rtc: jz4740: Add support for the JZ4725B, JZ4760, JZ4770

2018-07-14 Thread Paul Cercueil
Le sam. 14 juil. 2018 à 15:32, Alexandre Belloni a écrit : On 14/07/2018 15:25:33+0200, Paul Cercueil wrote: Hi Alexandre, Le sam. 14 juil. 2018 à 15:19, Alexandre Belloni a écrit : > Hello, > > On 13/07/2018 17:14:24+0200, Paul Cercueil wrote: > > The RTC in the JZ4725B works jus

Re: [PATCH] rtc: jz4740: Add support for the JZ4725B, JZ4760, JZ4770

2018-07-14 Thread Alexandre Belloni
On 14/07/2018 15:25:33+0200, Paul Cercueil wrote: > Hi Alexandre, > > Le sam. 14 juil. 2018 à 15:19, Alexandre Belloni > a écrit : > > Hello, > > > > On 13/07/2018 17:14:24+0200, Paul Cercueil wrote: > > > The RTC in the JZ4725B works just like the one in the JZ4740. > > > > > > The RTC in th

Re: [PATCH] rtc: jz4740: Add support for the JZ4725B, JZ4760, JZ4770

2018-07-14 Thread Paul Cercueil
Hi Alexandre, Le sam. 14 juil. 2018 à 15:19, Alexandre Belloni a écrit : Hello, On 13/07/2018 17:14:24+0200, Paul Cercueil wrote: The RTC in the JZ4725B works just like the one in the JZ4740. The RTC in the JZ4760 and JZ4770 work just like the one in the JZ4780. Signed-off-by: Paul Ce

Re: [PATCH] Input: synaptics - Lenovo ThinkPad T25 and T480 devices should use RMI

2018-07-14 Thread kitsunyan
Hi, Teika. (Yes, you are right.) I should've worried about real name earlier since I already sent the patch from pseudonym. I don't mind if the patch will be authored by maintainer, replacing my sign with "reported-by". (Hope it's possible.) Regards, kitsunyan On 14/07/18 09:35, Teika Kazura w

Re: [PATCH] rtc: jz4740: Add support for the JZ4725B, JZ4760, JZ4770

2018-07-14 Thread Alexandre Belloni
Hello, On 13/07/2018 17:14:24+0200, Paul Cercueil wrote: > The RTC in the JZ4725B works just like the one in the JZ4740. > > The RTC in the JZ4760 and JZ4770 work just like the one in the JZ4780. > > Signed-off-by: Paul Cercueil > --- > Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.

[tip:core/urgent] objtool: Use '.strtab' if '.shstrtab' doesn't exist, to support ORC tables on Clang

2018-07-14 Thread tip-bot for Simon Ser
Commit-ID: 6d77d3b43ad84a48b502f02dc618e7c36737bdfe Gitweb: https://git.kernel.org/tip/6d77d3b43ad84a48b502f02dc618e7c36737bdfe Author: Simon Ser AuthorDate: Mon, 9 Jul 2018 11:17:22 -0500 Committer: Ingo Molnar CommitDate: Sat, 14 Jul 2018 14:59:42 +0200 objtool: Use '.strtab' if '.sh

  1   2   >