Re: [PATCH v4 4/4] x86/boot/KASLR: Limit kaslr to choosing the immovable memory

2018-08-01 Thread Dou Liyang
Hi Fan, At 07/23/2018 05:29 PM, Chao Fan wrote: If 'CONFIG_MEMORY_HOTREMOVE' specified and the account of immovable memory regions is not zero. Calculate the intersection between memory regions from e820/efi memory table and immovable memory regions. Or go on the old code. Rename

Re: [PATCH v4 4/4] x86/boot/KASLR: Limit kaslr to choosing the immovable memory

2018-08-01 Thread Dou Liyang
Hi Fan, At 07/23/2018 05:29 PM, Chao Fan wrote: If 'CONFIG_MEMORY_HOTREMOVE' specified and the account of immovable memory regions is not zero. Calculate the intersection between memory regions from e820/efi memory table and immovable memory regions. Or go on the old code. Rename

[PATCH v3 4/4] Add an option to support no-FPU systems

2018-08-01 Thread Alan Kao
FP codes have been separated from common part in previous patches. This patch add the CONFIG_FPU option and some stubs to support no-FPU systems. Signed-off-by: Alan Kao Cc: Greentime Hu Cc: Vincent Chen Cc: Zong Li Cc: Nick Hu --- arch/riscv/Kconfig | 9 +

[PATCH v3 1/4] Extract FPU context operations from entry.S

2018-08-01 Thread Alan Kao
We move __fstate_save and __fstate_restore to a new source file, fpu.S. Signed-off-by: Alan Kao Cc: Greentime Hu Cc: Vincent Chen Cc: Zong Li Cc: Nick Hu --- arch/riscv/kernel/Makefile | 1 + arch/riscv/kernel/entry.S | 87 -- arch/riscv/kernel/fpu.S| 105

[PATCH v3 4/4] Add an option to support no-FPU systems

2018-08-01 Thread Alan Kao
FP codes have been separated from common part in previous patches. This patch add the CONFIG_FPU option and some stubs to support no-FPU systems. Signed-off-by: Alan Kao Cc: Greentime Hu Cc: Vincent Chen Cc: Zong Li Cc: Nick Hu --- arch/riscv/Kconfig | 9 +

[PATCH v3 1/4] Extract FPU context operations from entry.S

2018-08-01 Thread Alan Kao
We move __fstate_save and __fstate_restore to a new source file, fpu.S. Signed-off-by: Alan Kao Cc: Greentime Hu Cc: Vincent Chen Cc: Zong Li Cc: Nick Hu --- arch/riscv/kernel/Makefile | 1 + arch/riscv/kernel/entry.S | 87 -- arch/riscv/kernel/fpu.S| 105

[PATCH v3 3/4] Cleanup ISA string setting

2018-08-01 Thread Alan Kao
The reason that we cannot follow the review's suggestion in https://lkml.org/lkml/2018/6/21/39 is because using "+=" as the connector in Makefile introduces blanks bewteen the left-hand side alphabets. Note: (Assume that atomic and compressed is on) Before this patch, assembler was always given

[PATCH v3 0/4] riscv: Add support to no-FPU systems

2018-08-01 Thread Alan Kao
This patchset adds an option, CONFIG_FPU, to enable/disable floating- point procedures. Changes in v3: - Refactor the whole patch into independent ones. Changes in v2: - Various code cleanups and style fixes. Alan Kao (4): Extract FPU context operations from entry.S Refactor FPU codes in

[PATCH v3 2/4] Refactor FPU codes in signal setup/return procedures

2018-08-01 Thread Alan Kao
Signed-off-by: Alan Kao Cc: Greentime Hu Cc: Vincent Chen Cc: Zong Li Cc: Nick Hu --- arch/riscv/kernel/signal.c | 68 +++--- 1 file changed, 41 insertions(+), 27 deletions(-) diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c index

[PATCH v3 3/4] Cleanup ISA string setting

2018-08-01 Thread Alan Kao
The reason that we cannot follow the review's suggestion in https://lkml.org/lkml/2018/6/21/39 is because using "+=" as the connector in Makefile introduces blanks bewteen the left-hand side alphabets. Note: (Assume that atomic and compressed is on) Before this patch, assembler was always given

[PATCH v3 0/4] riscv: Add support to no-FPU systems

2018-08-01 Thread Alan Kao
This patchset adds an option, CONFIG_FPU, to enable/disable floating- point procedures. Changes in v3: - Refactor the whole patch into independent ones. Changes in v2: - Various code cleanups and style fixes. Alan Kao (4): Extract FPU context operations from entry.S Refactor FPU codes in

[PATCH v3 2/4] Refactor FPU codes in signal setup/return procedures

2018-08-01 Thread Alan Kao
Signed-off-by: Alan Kao Cc: Greentime Hu Cc: Vincent Chen Cc: Zong Li Cc: Nick Hu --- arch/riscv/kernel/signal.c | 68 +++--- 1 file changed, 41 insertions(+), 27 deletions(-) diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c index

Re: [PATCH -next] ALSA: usb-audio: Fix invalid use of sizeof in parse_uac_endpoint_attributes()

2018-08-01 Thread Takashi Iwai
On Thu, 02 Aug 2018 06:31:02 +0200, Wei Yongjun wrote: > > sizeof() when applied to a pointer typed expression gives the > size of the pointer, not that of the pointed data. > > Fixes: 7edf3b5e6a45 ("ALSA: usb-audio: AudioStreaming Power Domain parsing") > Signed-off-by: Wei Yongjun Applied,

Re: [PATCH -next] ALSA: usb-audio: Fix invalid use of sizeof in parse_uac_endpoint_attributes()

2018-08-01 Thread Takashi Iwai
On Thu, 02 Aug 2018 06:31:02 +0200, Wei Yongjun wrote: > > sizeof() when applied to a pointer typed expression gives the > size of the pointer, not that of the pointed data. > > Fixes: 7edf3b5e6a45 ("ALSA: usb-audio: AudioStreaming Power Domain parsing") > Signed-off-by: Wei Yongjun Applied,

[PATCH v2] timers: Clear must_forward_clk inside base lock

2018-08-01 Thread Gaurav Kohli
Timer wheel base->must_forward_clock is indicating that the base clock might be stale due to a long idle sleep. The forwarding of base clock takes place in softirq of timer or when a timer is enqueued to base which is idle. While migrate timer from remote CPU to the new base which is idle, then

[PATCH v2] timers: Clear must_forward_clk inside base lock

2018-08-01 Thread Gaurav Kohli
Timer wheel base->must_forward_clock is indicating that the base clock might be stale due to a long idle sleep. The forwarding of base clock takes place in softirq of timer or when a timer is enqueued to base which is idle. While migrate timer from remote CPU to the new base which is idle, then

Re: Zram writeback feature unstable with heavy swap utilization - BUG: Bad page state in process...

2018-08-01 Thread Minchan Kim
On Mon, Jul 30, 2018 at 08:09:33AM +0200, Tino Lehnig wrote: > On 07/28/2018 12:58 AM, Minchan Kim wrote: > > I made a mistake on previous patch. > > Could you test this patches? > > Thanks! Looking good so far! No errors whatsoever with the new patch. I will > let my test workload running for

Re: Zram writeback feature unstable with heavy swap utilization - BUG: Bad page state in process...

2018-08-01 Thread Minchan Kim
On Mon, Jul 30, 2018 at 08:09:33AM +0200, Tino Lehnig wrote: > On 07/28/2018 12:58 AM, Minchan Kim wrote: > > I made a mistake on previous patch. > > Could you test this patches? > > Thanks! Looking good so far! No errors whatsoever with the new patch. I will > let my test workload running for

[PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-01 Thread Minchan Kim
If zram supports writeback feature, it's no more syncrhonous device beause zram does synchronous IO opeation for incompressible page. Do not pretend to be syncrhonous IO device. It makes system very sluggish as waiting IO completion from upper layer. Furthermore, it makes user-after-free problem

[PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-01 Thread Minchan Kim
If zram supports writeback feature, it's no more syncrhonous device beause zram does synchronous IO opeation for incompressible page. Do not pretend to be syncrhonous IO device. It makes system very sluggish as waiting IO completion from upper layer. Furthermore, it makes user-after-free problem

Re: [V9fs-developer] [PATCH v2 2/2] net/9p: add a per-client fcall kmem_cache

2018-08-01 Thread Dominique Martinet
Dominique Martinet wrote on Thu, Aug 02, 2018: > [...] > + clnt->fcall_cache = kmem_cache_create("9p-fcall-cache", clnt->msize, > + 0, 0, NULL); Well, my gut feeling that I'd need a v3 was right, after a bit more time testing (slightly different

Re: [V9fs-developer] [PATCH v2 2/2] net/9p: add a per-client fcall kmem_cache

2018-08-01 Thread Dominique Martinet
Dominique Martinet wrote on Thu, Aug 02, 2018: > [...] > + clnt->fcall_cache = kmem_cache_create("9p-fcall-cache", clnt->msize, > + 0, 0, NULL); Well, my gut feeling that I'd need a v3 was right, after a bit more time testing (slightly different

[PATCH] spi: uniphier: remove unnecessary include headers

2018-08-01 Thread Keiji Hayashibara
This commit removed include headers of linux/of.h and linux/of_platform.h, because they are not used. Signed-off-by: Keiji Hayashibara --- drivers/spi/spi-uniphier.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi-uniphier.c b/drivers/spi/spi-uniphier.c index

[PATCH] spi: uniphier: remove unnecessary include headers

2018-08-01 Thread Keiji Hayashibara
This commit removed include headers of linux/of.h and linux/of_platform.h, because they are not used. Signed-off-by: Keiji Hayashibara --- drivers/spi/spi-uniphier.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi-uniphier.c b/drivers/spi/spi-uniphier.c index

[PATCH -next] ALSA: usb-audio: Fix invalid use of sizeof in parse_uac_endpoint_attributes()

2018-08-01 Thread Wei Yongjun
sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data. Fixes: 7edf3b5e6a45 ("ALSA: usb-audio: AudioStreaming Power Domain parsing") Signed-off-by: Wei Yongjun --- sound/usb/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH -next] ALSA: usb-audio: Fix invalid use of sizeof in parse_uac_endpoint_attributes()

2018-08-01 Thread Wei Yongjun
sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data. Fixes: 7edf3b5e6a45 ("ALSA: usb-audio: AudioStreaming Power Domain parsing") Signed-off-by: Wei Yongjun --- sound/usb/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] Improve code readability

2018-08-01 Thread Theodore Y. Ts'o
On Tue, Jul 31, 2018 at 02:15:15PM +0800, Liu Song wrote: > Merge the duplicated complex conditions to improve code readability. > > Signed-off-by: Liu Song > Reviewed-by: Jiang Biao Thanks, applied. - Ted

Re: [PATCH] Improve code readability

2018-08-01 Thread Theodore Y. Ts'o
On Tue, Jul 31, 2018 at 02:15:15PM +0800, Liu Song wrote: > Merge the duplicated complex conditions to improve code readability. > > Signed-off-by: Liu Song > Reviewed-by: Jiang Biao Thanks, applied. - Ted

Re: [PATCH v2] ext4: mballoc: Fix spectre gadget in ext4_mb_regular_allocator

2018-08-01 Thread Theodore Y. Ts'o
On Mon, Jul 30, 2018 at 06:07:47PM +, Jeremy Cline wrote: > 'ac->ac_g_ex.fe_len' is a user-controlled value which is used in the > derivation of 'ac->ac_2order'. 'ac->ac_2order', in turn, is used to > index arrays which makes it a potential spectre gadget. Fix this by > sanitizing the value

Re: [PATCH v2] ext4: mballoc: Fix spectre gadget in ext4_mb_regular_allocator

2018-08-01 Thread Theodore Y. Ts'o
On Mon, Jul 30, 2018 at 06:07:47PM +, Jeremy Cline wrote: > 'ac->ac_g_ex.fe_len' is a user-controlled value which is used in the > derivation of 'ac->ac_2order'. 'ac->ac_2order', in turn, is used to > index arrays which makes it a potential spectre gadget. Fix this by > sanitizing the value

linux-next: build warning after merge of the sound-asoc tree

2018-08-01 Thread Stephen Rothwell
Hi all, After merging the sound-asoc tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: unmet direct dependencies detected for SND_SOC_QDSP6 Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && QCOM_APR [=n] && HAS_DMA [=y] Selected by [m]: -

linux-next: build warning after merge of the sound-asoc tree

2018-08-01 Thread Stephen Rothwell
Hi all, After merging the sound-asoc tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: unmet direct dependencies detected for SND_SOC_QDSP6 Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && QCOM_APR [=n] && HAS_DMA [=y] Selected by [m]: -

Re: [PATCH] fs/binfmt_elf: remove the same condition check

2018-08-01 Thread zhong jiang
On 2018/8/2 11:04, Al Viro wrote: > On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote: >> dump_align is used to double check in a expression. It is redundant. >> so just remove one of them. > > What makes you think that it is redundant? > I am sorry for that. Maybe I miss something.

Re: [PATCH] fs/binfmt_elf: remove the same condition check

2018-08-01 Thread zhong jiang
On 2018/8/2 11:04, Al Viro wrote: > On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote: >> dump_align is used to double check in a expression. It is redundant. >> so just remove one of them. > > What makes you think that it is redundant? > I am sorry for that. Maybe I miss something.

Re: [PATCH v4 3/4] x86/boot/KASLR: Walk srat tables to filter immovable memory

2018-08-01 Thread Chao Fan
On Thu, Aug 02, 2018 at 11:47:13AM +0800, Dou Liyang wrote: >Hi Fan, > >At 07/23/2018 05:29 PM, Chao Fan wrote: >> If 'CONFIG_MEMORY_HOTREMOVE' specified, walk the acpi srat memory >> tables, store the immovable memory regions, so that kaslr can get >> the information abouth where can be selected

Re: [PATCH v4 3/4] x86/boot/KASLR: Walk srat tables to filter immovable memory

2018-08-01 Thread Chao Fan
On Thu, Aug 02, 2018 at 11:47:13AM +0800, Dou Liyang wrote: >Hi Fan, > >At 07/23/2018 05:29 PM, Chao Fan wrote: >> If 'CONFIG_MEMORY_HOTREMOVE' specified, walk the acpi srat memory >> tables, store the immovable memory regions, so that kaslr can get >> the information abouth where can be selected

Re: [PATCH v4 3/4] x86/boot/KASLR: Walk srat tables to filter immovable memory

2018-08-01 Thread Dou Liyang
Hi Fan, At 07/23/2018 05:29 PM, Chao Fan wrote: If 'CONFIG_MEMORY_HOTREMOVE' specified, walk the acpi srat memory tables, store the immovable memory regions, so that kaslr can get the information abouth where can be selected or not. If 'CONFIG_MEMORY_HOTREMOVE' not specified, go on the old

Re: [PATCH v4 3/4] x86/boot/KASLR: Walk srat tables to filter immovable memory

2018-08-01 Thread Dou Liyang
Hi Fan, At 07/23/2018 05:29 PM, Chao Fan wrote: If 'CONFIG_MEMORY_HOTREMOVE' specified, walk the acpi srat memory tables, store the immovable memory regions, so that kaslr can get the information abouth where can be selected or not. If 'CONFIG_MEMORY_HOTREMOVE' not specified, go on the old

Re: [PATCH] staging: mt29f_spinand: fix memory leak while programming pages

2018-08-01 Thread Jheng-Jhong Wu
Dear Dan, I know what you wrote, but before the spinand device is removed and freed memory automatically, programming pages may do many many times. Assume we erase and rewrite a large part of the flash, then spinand_program_page() might exhaust memory if memory is not large enough. In fact, OOM

Re: [PATCH] staging: mt29f_spinand: fix memory leak while programming pages

2018-08-01 Thread Jheng-Jhong Wu
Dear Dan, I know what you wrote, but before the spinand device is removed and freed memory automatically, programming pages may do many many times. Assume we erase and rewrite a large part of the flash, then spinand_program_page() might exhaust memory if memory is not large enough. In fact, OOM

Re: [PATCH] fs/binfmt_elf: remove the same condition check

2018-08-01 Thread zhong jiang
On 2018/8/2 10:34, Matthew Wilcox wrote: > On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote: >> dump_align is used to double check in a expression. It is redundant. >> so just remove one of them. > You're wrong. Functions in C can have side-effects (and this one does). > > Ok, I miss

Re: [PATCH] fs/binfmt_elf: remove the same condition check

2018-08-01 Thread zhong jiang
On 2018/8/2 10:34, Matthew Wilcox wrote: > On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote: >> dump_align is used to double check in a expression. It is redundant. >> so just remove one of them. > You're wrong. Functions in C can have side-effects (and this one does). > > Ok, I miss

Re: [PATCH] sched/deadline: Fix switched_from_dl

2018-08-01 Thread Steven Rostedt
On Wed, 11 Jul 2018 09:29:48 +0200 Juri Lelli wrote: > Mark noticed that syzkaller is able to reliably trigger the following > > dl_rq->running_bw > dl_rq->this_bw > WARNING: CPU: 1 PID: 153 at kernel/sched/deadline.c:124 > switched_from_dl+0x454/0x608 > Kernel panic - not syncing:

Re: [PATCH] sched/deadline: Fix switched_from_dl

2018-08-01 Thread Steven Rostedt
On Wed, 11 Jul 2018 09:29:48 +0200 Juri Lelli wrote: > Mark noticed that syzkaller is able to reliably trigger the following > > dl_rq->running_bw > dl_rq->this_bw > WARNING: CPU: 1 PID: 153 at kernel/sched/deadline.c:124 > switched_from_dl+0x454/0x608 > Kernel panic - not syncing:

Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Rafael David Tinoco
On Wed, Aug 01, 2018 at 05:34:08PM +0100, Al Viro wrote: > On Wed, Aug 01, 2018 at 07:19:35PM +0300, Kirill Tkhai wrote: > > On 01.08.2018 19:16, Al Viro wrote: > > > On Wed, Aug 01, 2018 at 05:11:51PM +0100, Al Viro wrote: > > >> On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote: > >

Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Rafael David Tinoco
On Wed, Aug 01, 2018 at 05:34:08PM +0100, Al Viro wrote: > On Wed, Aug 01, 2018 at 07:19:35PM +0300, Kirill Tkhai wrote: > > On 01.08.2018 19:16, Al Viro wrote: > > > On Wed, Aug 01, 2018 at 05:11:51PM +0100, Al Viro wrote: > > >> On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote: > >

[PATCH 1/3] Drivers: hv: vmbus: Reset the channel callback in vmbus_onoffer_rescind()

2018-08-01 Thread kys
From: Dexuan Cui Before setting channel->rescind in vmbus_rescind_cleanup(), we should make sure the channel callback won't run any more, otherwise a high-level driver like pci_hyperv, which may be infinitely waiting for the host VSP's response and notices the channel has been rescinded, can't

[PATCH 3/3] Drivers: hv: vmbus: Cleanup synic memory free path

2018-08-01 Thread kys
From: Michael Kelley clk_evt memory is not being freed when the synic is shutdown or when there is an allocation error. Add the appropriate kfree() call, along with a comment to clarify how the memory gets freed after an allocation error. Make the free path consistent by removing checks for

[PATCH 2/3] Drivers: hv: vmbus: Remove use of slow_virt_to_phys()

2018-08-01 Thread kys
From: Michael Kelley slow_virt_to_phys() is only implemented for arch/x86. Remove its use in arch independent Hyper-V drivers, and replace with test for vmalloc() address followed by appropriate v-to-p function. This follows the typical pattern of other drivers and avoids the need to implement

[PATCH 3/3] Drivers: hv: vmbus: Cleanup synic memory free path

2018-08-01 Thread kys
From: Michael Kelley clk_evt memory is not being freed when the synic is shutdown or when there is an allocation error. Add the appropriate kfree() call, along with a comment to clarify how the memory gets freed after an allocation error. Make the free path consistent by removing checks for

[PATCH 2/3] Drivers: hv: vmbus: Remove use of slow_virt_to_phys()

2018-08-01 Thread kys
From: Michael Kelley slow_virt_to_phys() is only implemented for arch/x86. Remove its use in arch independent Hyper-V drivers, and replace with test for vmalloc() address followed by appropriate v-to-p function. This follows the typical pattern of other drivers and avoids the need to implement

[PATCH 1/3] Drivers: hv: vmbus: Reset the channel callback in vmbus_onoffer_rescind()

2018-08-01 Thread kys
From: Dexuan Cui Before setting channel->rescind in vmbus_rescind_cleanup(), we should make sure the channel callback won't run any more, otherwise a high-level driver like pci_hyperv, which may be infinitely waiting for the host VSP's response and notices the channel has been rescinded, can't

[PATCH 0/3] Drivers: hv: vmbus: Miscellaneous fixes

2018-08-01 Thread kys
From: "K. Y. Srinivasan" Miscellaneous fixes. Dexuan Cui (1): Drivers: hv: vmbus: Reset the channel callback in vmbus_onoffer_rescind() Michael Kelley (2): Drivers: hv: vmbus: Remove use of slow_virt_to_phys() Drivers: hv: vmbus: Cleanup synic memory free path drivers/hv/channel.c

[PATCH 0/3] Drivers: hv: vmbus: Miscellaneous fixes

2018-08-01 Thread kys
From: "K. Y. Srinivasan" Miscellaneous fixes. Dexuan Cui (1): Drivers: hv: vmbus: Reset the channel callback in vmbus_onoffer_rescind() Michael Kelley (2): Drivers: hv: vmbus: Remove use of slow_virt_to_phys() Drivers: hv: vmbus: Cleanup synic memory free path drivers/hv/channel.c

Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

2018-08-01 Thread Al Viro
On Thu, Aug 02, 2018 at 10:04:34AM +0800, zhong jiang wrote: > It is unncessary to use double test for a expression. so just > remove one of them. ... except when something in that expression might have side effects, that is.

Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

2018-08-01 Thread Al Viro
On Thu, Aug 02, 2018 at 10:04:34AM +0800, zhong jiang wrote: > It is unncessary to use double test for a expression. so just > remove one of them. ... except when something in that expression might have side effects, that is.

Re: [PATCH] fs/binfmt_elf: remove the same condition check

2018-08-01 Thread Al Viro
On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote: > dump_align is used to double check in a expression. It is redundant. > so just remove one of them. What makes you think that it is redundant? > Signed-off-by: zhong jiang > --- > fs/binfmt_elf.c | 2 +- > 1 file changed, 1

Re: [PATCH] fs/binfmt_elf: remove the same condition check

2018-08-01 Thread Al Viro
On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote: > dump_align is used to double check in a expression. It is redundant. > so just remove one of them. What makes you think that it is redundant? > Signed-off-by: zhong jiang > --- > fs/binfmt_elf.c | 2 +- > 1 file changed, 1

[PATCH v2 1/2] net/9p: embed fcall in req to round down buffer allocs

2018-08-01 Thread Dominique Martinet
From: Dominique Martinet 'msize' is often a power of two, or at least page-aligned, so avoiding an overhead of two dozen bytes for each allocation will help the allocator do its work and reduce memory fragmentation. Suggested-by: Matthew Wilcox Signed-off-by: Dominique Martinet Cc: Matthew

[PATCH v2 1/2] net/9p: embed fcall in req to round down buffer allocs

2018-08-01 Thread Dominique Martinet
From: Dominique Martinet 'msize' is often a power of two, or at least page-aligned, so avoiding an overhead of two dozen bytes for each allocation will help the allocator do its work and reduce memory fragmentation. Suggested-by: Matthew Wilcox Signed-off-by: Dominique Martinet Cc: Matthew

Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

2018-08-01 Thread zhong jiang
plese ingore it. On 2018/8/2 10:04, zhong jiang wrote: > It is unncessary to use double test for a expression. so just > remove one of them. > > Signed-off-by: zhong jiang > --- > fs/binfmt_elf_fdpic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

2018-08-01 Thread zhong jiang
plese ingore it. On 2018/8/2 10:04, zhong jiang wrote: > It is unncessary to use double test for a expression. so just > remove one of them. > > Signed-off-by: zhong jiang > --- > fs/binfmt_elf_fdpic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH V2] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-08-01 Thread Steven Rostedt
On Mon, 16 Jul 2018 13:45:21 +0300 Kirill Tkhai wrote: > > --- a/kernel/sched/deadline.c > > +++ b/kernel/sched/deadline.c > > @@ -2090,8 +2090,16 @@ static int push_dl_task(struct rq *rq) > > sub_rq_bw(_task->dl, >dl); > > set_task_cpu(next_task, later_rq->cpu); > >

Re: [PATCH V2] sched/deadline: Update rq_clock of later_rq when pushing a task

2018-08-01 Thread Steven Rostedt
On Mon, 16 Jul 2018 13:45:21 +0300 Kirill Tkhai wrote: > > --- a/kernel/sched/deadline.c > > +++ b/kernel/sched/deadline.c > > @@ -2090,8 +2090,16 @@ static int push_dl_task(struct rq *rq) > > sub_rq_bw(_task->dl, >dl); > > set_task_cpu(next_task, later_rq->cpu); > >

[PATCH v2 2/2] net/9p: add a per-client fcall kmem_cache

2018-08-01 Thread Dominique Martinet
From: Dominique Martinet Having a specific cache for the fcall allocations helps speed up allocations a bit, especially in case of non-"round" msizes. The caches will automatically be merged if there are multiple caches of items with the same size so we do not need to try to share a cache

[PATCH v2 2/2] net/9p: add a per-client fcall kmem_cache

2018-08-01 Thread Dominique Martinet
From: Dominique Martinet Having a specific cache for the fcall allocations helps speed up allocations a bit, especially in case of non-"round" msizes. The caches will automatically be merged if there are multiple caches of items with the same size so we do not need to try to share a cache

Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Rafael David Tinoco
On Wed, Aug 01, 2018 at 05:27:39PM +0100, Al Viro wrote: > On Wed, Aug 01, 2018 at 05:16:48PM +0100, Al Viro wrote: > > On Wed, Aug 01, 2018 at 05:11:51PM +0100, Al Viro wrote: > > > On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote: > > > > #git status > > > > HEAD detached at

Re: Commit "new primitive: discard_new_inode()" introduces a problem

2018-08-01 Thread Rafael David Tinoco
On Wed, Aug 01, 2018 at 05:27:39PM +0100, Al Viro wrote: > On Wed, Aug 01, 2018 at 05:16:48PM +0100, Al Viro wrote: > > On Wed, Aug 01, 2018 at 05:11:51PM +0100, Al Viro wrote: > > > On Wed, Aug 01, 2018 at 06:43:56PM +0300, Kirill Tkhai wrote: > > > > #git status > > > > HEAD detached at

Re: [PATCH] fs/binfmt_elf: remove the same condition check

2018-08-01 Thread Matthew Wilcox
On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote: > dump_align is used to double check in a expression. It is redundant. > so just remove one of them. You're wrong. Functions in C can have side-effects (and this one does).

Re: [PATCH] fs/binfmt_elf: remove the same condition check

2018-08-01 Thread Matthew Wilcox
On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote: > dump_align is used to double check in a expression. It is redundant. > so just remove one of them. You're wrong. Functions in C can have side-effects (and this one does).

Re: Remounting filesystem read-only

2018-08-01 Thread Sodagudi Prasad
On 2018-07-28 00:47, Darrick J. Wong wrote: On Fri, Jul 27, 2018 at 08:18:23PM -0400, Theodore Y. Ts'o wrote: On Fri, Jul 27, 2018 at 01:34:31PM -0700, Sodagudi Prasad wrote: > > The error should be pretty clear: "Inode table for bg 0 marked as > > needing zeroing". That should never happen. >

Re: Remounting filesystem read-only

2018-08-01 Thread Sodagudi Prasad
On 2018-07-28 00:47, Darrick J. Wong wrote: On Fri, Jul 27, 2018 at 08:18:23PM -0400, Theodore Y. Ts'o wrote: On Fri, Jul 27, 2018 at 01:34:31PM -0700, Sodagudi Prasad wrote: > > The error should be pretty clear: "Inode table for bg 0 marked as > > needing zeroing". That should never happen. >

[PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

2018-08-01 Thread zhong jiang
It is unncessary to use double test for a expression. so just remove one of them. Signed-off-by: zhong jiang --- fs/binfmt_elf_fdpic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c index b53bb37..5162372 100644 ---

[PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

2018-08-01 Thread zhong jiang
It is unncessary to use double test for a expression. so just remove one of them. Signed-off-by: zhong jiang --- fs/binfmt_elf_fdpic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c index b53bb37..5162372 100644 ---

Spende von $ 4,800,000.00!

2018-08-01 Thread Gloria Adelaida Elias Mejia
Hallo, Sie haben eine Spende von $ 4,800,000.00, ich habe die America Lotterie im Wert von $ 40 Millionen gewonnen und ich gebe einen Teil davon an fünf glückliche Menschen und Wohltätigkeitseinrichtungen zum Gedenken an meine verstorbene Frau, die an Krebs starb. Spendenreferenznummer: BBIB /

Spende von $ 4,800,000.00!

2018-08-01 Thread Gloria Adelaida Elias Mejia
Hallo, Sie haben eine Spende von $ 4,800,000.00, ich habe die America Lotterie im Wert von $ 40 Millionen gewonnen und ich gebe einen Teil davon an fünf glückliche Menschen und Wohltätigkeitseinrichtungen zum Gedenken an meine verstorbene Frau, die an Krebs starb. Spendenreferenznummer: BBIB /

[PATCH] fs/binfmt_elf: remove the same condition check

2018-08-01 Thread zhong jiang
dump_align is used to double check in a expression. It is redundant. so just remove one of them. Signed-off-by: zhong jiang --- fs/binfmt_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index efae2fb..b6c5b02 100644 ---

[PATCH] fs/binfmt_elf: remove the same condition check

2018-08-01 Thread zhong jiang
dump_align is used to double check in a expression. It is redundant. so just remove one of them. Signed-off-by: zhong jiang --- fs/binfmt_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index efae2fb..b6c5b02 100644 ---

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-01 Thread Lina Iyer
On Wed, Aug 01 2018 at 16:38 -0600, Bjorn Andersson wrote: On Wed 01 Aug 12:45 PDT 2018, Lina Iyer wrote: Thanks for the feedback, Marc. On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier wrote: > On Wed, 01 Aug 2018 03:00:18 +0100, > Lina Iyer wrote: [..] > Why isn't that the case? And if

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-01 Thread Lina Iyer
On Wed, Aug 01 2018 at 16:38 -0600, Bjorn Andersson wrote: On Wed 01 Aug 12:45 PDT 2018, Lina Iyer wrote: Thanks for the feedback, Marc. On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier wrote: > On Wed, 01 Aug 2018 03:00:18 +0100, > Lina Iyer wrote: [..] > Why isn't that the case? And if

Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-08-01 Thread Ricardo Neri
On Wed, Aug 01, 2018 at 04:09:59PM +0100, Julien Thierry wrote: > >>+static bool irq_supports_nmi(struct irq_desc *desc) > >>+{ > >>+ struct irq_data *d = irq_desc_get_irq_data(desc); > >>+ > >>+#ifdef CONFIG_IRQ_DOMAIN_HIERARCHY > >>+ /* Only IRQs directly managed by the root irqchip can be

Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-08-01 Thread Ricardo Neri
On Wed, Aug 01, 2018 at 04:09:59PM +0100, Julien Thierry wrote: > >>+static bool irq_supports_nmi(struct irq_desc *desc) > >>+{ > >>+ struct irq_data *d = irq_desc_get_irq_data(desc); > >>+ > >>+#ifdef CONFIG_IRQ_DOMAIN_HIERARCHY > >>+ /* Only IRQs directly managed by the root irqchip can be

Re: [PATCH] staging: mt29f_spinand: fix memory leak while programming pages

2018-08-01 Thread Jheng-Jhong Wu
Dear Dan Carpenter, I know what you wrote, but before device is removed and freed memory automatically, programming pages may do many many times. Assume we erase and rewrite a large part of the flash, then spinand_program_page() might exhaust memory

Re: [PATCH] staging: mt29f_spinand: fix memory leak while programming pages

2018-08-01 Thread Jheng-Jhong Wu
Dear Dan Carpenter, I know what you wrote, but before device is removed and freed memory automatically, programming pages may do many many times. Assume we erase and rewrite a large part of the flash, then spinand_program_page() might exhaust memory

Re: [PATCH v2] net/9p/trans_virtio.c: add null terminal for mount tag

2018-08-01 Thread piaojun
Hi Dominique, On 2018/8/2 9:54, Dominique Martinet wrote: > piaojun wrote on Thu, Aug 02, 2018: >> chan->tag is Non-null terminated which will result in printing messy code >> when debugging code. So we should add '\0' for tag to make the code more >> convenient and robust. In addition, I drop

Re: [PATCH v2] net/9p/trans_virtio.c: add null terminal for mount tag

2018-08-01 Thread piaojun
Hi Dominique, On 2018/8/2 9:54, Dominique Martinet wrote: > piaojun wrote on Thu, Aug 02, 2018: >> chan->tag is Non-null terminated which will result in printing messy code >> when debugging code. So we should add '\0' for tag to make the code more >> convenient and robust. In addition, I drop

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-01 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi wrote: >> On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote: >>> On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote: On Thu, Jul 12, 2018 at

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-01 Thread Chanwoo Choi
Hi Matthias, On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote: > Hi Chanwoo, > > On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi wrote: >> On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote: >>> On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote: On Thu, Jul 12, 2018 at

Re: [PATCH v2] net/9p/trans_virtio.c: add null terminal for mount tag

2018-08-01 Thread Dominique Martinet
piaojun wrote on Thu, Aug 02, 2018: > chan->tag is Non-null terminated which will result in printing messy code > when debugging code. So we should add '\0' for tag to make the code more > convenient and robust. In addition, I drop char->tag_len to simplify the > code. Some new lines in commit

Re: [PATCH v2] net/9p/trans_virtio.c: add null terminal for mount tag

2018-08-01 Thread Dominique Martinet
piaojun wrote on Thu, Aug 02, 2018: > chan->tag is Non-null terminated which will result in printing messy code > when debugging code. So we should add '\0' for tag to make the code more > convenient and robust. In addition, I drop char->tag_len to simplify the > code. Some new lines in commit

[PATCH v2] net/9p/trans_virtio.c: add null terminal for mount tag

2018-08-01 Thread piaojun
chan->tag is Non-null terminated which will result in printing messy code when debugging code. So we should add '\0' for tag to make the code more convenient and robust. In addition, I drop char->tag_len to simplify the code. Signed-off-by: Jun Piao --- net/9p/trans_virtio.c | 15

[PATCH v2] net/9p/trans_virtio.c: add null terminal for mount tag

2018-08-01 Thread piaojun
chan->tag is Non-null terminated which will result in printing messy code when debugging code. So we should add '\0' for tag to make the code more convenient and robust. In addition, I drop char->tag_len to simplify the code. Signed-off-by: Jun Piao --- net/9p/trans_virtio.c | 15

[PATCH v4] perf/x86/intel: Add support for MISPREDICT bit on Knights Landing cpus

2018-08-01 Thread Jacek Tomaka
From: Jacek Tomaka Problem: perf did not show branch predicted/mispredicted bit in brstack. Output of perf -F brstack for profile collected Before: 0x4fdbcd/0x4fdc03/-/-/-/0 0x45f4c1/0x4fdba0/-/-/-/0 0x45f544/0x45f4bb/-/-/-/0 0x45f555/0x45f53c/-/-/-/0 0x7f66901cc24b/0x45f555/-/-/-/0

[PATCH v4] perf/x86/intel: Add support for MISPREDICT bit on Knights Landing cpus

2018-08-01 Thread Jacek Tomaka
From: Jacek Tomaka Problem: perf did not show branch predicted/mispredicted bit in brstack. Output of perf -F brstack for profile collected Before: 0x4fdbcd/0x4fdc03/-/-/-/0 0x45f4c1/0x4fdba0/-/-/-/0 0x45f544/0x45f4bb/-/-/-/0 0x45f555/0x45f53c/-/-/-/0 0x7f66901cc24b/0x45f555/-/-/-/0

cpu stopper threads and setaffinity leads to deadlock

2018-08-01 Thread Sodagudi Prasad
Hi Peter and Tglx, We are observing another deadlock issue due to commit 0b26351b91(stop_machine, sched: Fix migrate_swap() vs. active_balance() deadlock), even after taking the following fix https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1740526.html on the Linux-4.14.56

cpu stopper threads and setaffinity leads to deadlock

2018-08-01 Thread Sodagudi Prasad
Hi Peter and Tglx, We are observing another deadlock issue due to commit 0b26351b91(stop_machine, sched: Fix migrate_swap() vs. active_balance() deadlock), even after taking the following fix https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1740526.html on the Linux-4.14.56

Re: [PATCH] RISC-V: Add the directive for alignment of stvec's value

2018-08-01 Thread Zong Li
Palmer Dabbelt 於 2018年8月2日 週四 上午8:38寫道: > > On Wed, 20 Jun 2018 18:40:07 PDT (-0700), z...@andestech.com wrote: > > The stvec's value must be 4 byte alignment by specification definition. > > This directive avoids to stvec be set the non-alignment value by the > > following code in head.S > > > >

Re: [PATCH] RISC-V: Add the directive for alignment of stvec's value

2018-08-01 Thread Zong Li
Palmer Dabbelt 於 2018年8月2日 週四 上午8:38寫道: > > On Wed, 20 Jun 2018 18:40:07 PDT (-0700), z...@andestech.com wrote: > > The stvec's value must be 4 byte alignment by specification definition. > > This directive avoids to stvec be set the non-alignment value by the > > following code in head.S > > > >

Re: [PATCH] net/9p/trans_virtio.c: add a terminal char for mount tag

2018-08-01 Thread piaojun
Hi Dominique and Greg, Thanks for your reviewing, and I will try to simplify other related code according your suggestions in patch v2. Thanks, Jun On 2018/8/1 20:09, Dominique Martinet wrote: > Greg Kurz wrote on Wed, Aug 01, 2018: >> So this patch basically turns chan->tag into a nul

Re: [PATCH v4 0/4] x86/boot/KASLR: Parse ACPI table and limit kaslr in immovable memory.

2018-08-01 Thread Chao Fan
Hi, Sorry for disturbance, no reply for a week, any comments? Thanks, Chao Fan On Mon, Jul 23, 2018 at 05:29:04PM +0800, Chao Fan wrote: >***Background: >People reported that kaslr may randomly chooses some positions >which are located in movable memory regions. This will break memory >hotplug

  1   2   3   4   5   6   7   8   9   10   >