Re: [PATCH] mailbox: add MODULE_LICENSE() for mtk-cmdq-mailbox.c

2018-08-07 Thread Randy Dunlap
Dunlap > Cc: Jassi Brar > Cc: > Cc: CK Hu > Cc: Houlong Wei > --- > drivers/mailbox/mtk-cmdq-mailbox.c |2 ++ > 1 file changed, 2 insertions(+) > > --- linux-next-20180807.orig/drivers/mailbox/mtk-cmdq-mailbox.c > +++ linux-next-20180807/drivers/mailbox/mtk-c

Re: [PATCH] mailbox: add MODULE_LICENSE() for mtk-cmdq-mailbox.c

2018-08-07 Thread Randy Dunlap
Dunlap > Cc: Jassi Brar > Cc: > Cc: CK Hu > Cc: Houlong Wei > --- > drivers/mailbox/mtk-cmdq-mailbox.c |2 ++ > 1 file changed, 2 insertions(+) > > --- linux-next-20180807.orig/drivers/mailbox/mtk-cmdq-mailbox.c > +++ linux-next-20180807/drivers/mailbox/mtk-c

[PATCH] mailbox: add MODULE_LICENSE() for mtk-cmdq-mailbox.c

2018-08-07 Thread Randy Dunlap
changed, 2 insertions(+) --- linux-next-20180807.orig/drivers/mailbox/mtk-cmdq-mailbox.c +++ linux-next-20180807/drivers/mailbox/mtk-cmdq-mailbox.c @@ -567,3 +567,5 @@ static void __exit cmdq_drv_exit(void) subsys_initcall(cmdq_drv_init); module_exit(cmdq_drv_exit); + +MODULE_LICENSE("GPL v2");

[PATCH] mailbox: add MODULE_LICENSE() for mtk-cmdq-mailbox.c

2018-08-07 Thread Randy Dunlap
changed, 2 insertions(+) --- linux-next-20180807.orig/drivers/mailbox/mtk-cmdq-mailbox.c +++ linux-next-20180807/drivers/mailbox/mtk-cmdq-mailbox.c @@ -567,3 +567,5 @@ static void __exit cmdq_drv_exit(void) subsys_initcall(cmdq_drv_init); module_exit(cmdq_drv_exit); + +MODULE_LICENSE("GPL v2");

Re: framebuffer corruption due to overlapping stp instructions on arm64

2018-08-07 Thread Marcin Wojtas
Ard, Mikulas, pon., 6 sie 2018 o 22:11 Ard Biesheuvel napisał(a): > > On 6 August 2018 at 21:54, Mikulas Patocka wrote: > > > > > > On Mon, 6 Aug 2018, Ard Biesheuvel wrote: > > > >> On 6 August 2018 at 19:09, Mikulas Patocka wrote: > >> > > >> > > >> > On Mon, 6 Aug 2018, Ard Biesheuvel

Re: [PATCH v3 1/2] PM / devfreq: Generic CPU frequency to device frequency mapping governor

2018-08-07 Thread Rob Herring
On Wed, Aug 01, 2018 at 05:57:41PM -0700, Saravana Kannan wrote: > Many CPU architectures have caches that can scale independent of the CPUs. > Frequency scaling of the caches is necessary to make sure the cache is not > a performance bottleneck that leads to poor performance and power. The same >

Re: framebuffer corruption due to overlapping stp instructions on arm64

2018-08-07 Thread Marcin Wojtas
Ard, Mikulas, pon., 6 sie 2018 o 22:11 Ard Biesheuvel napisał(a): > > On 6 August 2018 at 21:54, Mikulas Patocka wrote: > > > > > > On Mon, 6 Aug 2018, Ard Biesheuvel wrote: > > > >> On 6 August 2018 at 19:09, Mikulas Patocka wrote: > >> > > >> > > >> > On Mon, 6 Aug 2018, Ard Biesheuvel

Re: [PATCH v3 1/2] PM / devfreq: Generic CPU frequency to device frequency mapping governor

2018-08-07 Thread Rob Herring
On Wed, Aug 01, 2018 at 05:57:41PM -0700, Saravana Kannan wrote: > Many CPU architectures have caches that can scale independent of the CPUs. > Frequency scaling of the caches is necessary to make sure the cache is not > a performance bottleneck that leads to poor performance and power. The same >

Re: [PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of_match

2018-08-07 Thread Guenter Roeck
On Tue, Aug 7, 2018 at 9:22 AM Matthias Kaehlcke wrote: > > The initializer of rt5677_of_match contains a bogus device id > (enum type) for the 'type' field (char []). Remove it. > > Signed-off-by: Matthias Kaehlcke > --- > sound/soc/codecs/rt5677.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of_match

2018-08-07 Thread Guenter Roeck
On Tue, Aug 7, 2018 at 9:22 AM Matthias Kaehlcke wrote: > > The initializer of rt5677_of_match contains a bogus device id > (enum type) for the 'type' field (char []). Remove it. > > Signed-off-by: Matthias Kaehlcke > --- > sound/soc/codecs/rt5677.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of_match

2018-08-07 Thread Matthias Kaehlcke
The initializer of rt5677_of_match contains a bogus device id (enum type) for the 'type' field (char []). Remove it. Signed-off-by: Matthias Kaehlcke --- sound/soc/codecs/rt5677.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5677.c

[PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of_match

2018-08-07 Thread Matthias Kaehlcke
The initializer of rt5677_of_match contains a bogus device id (enum type) for the 'type' field (char []). Remove it. Signed-off-by: Matthias Kaehlcke --- sound/soc/codecs/rt5677.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5677.c

[PATCH] extcon: maxim: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-max14577.c | 24 +++- drivers/extcon/extcon-max77693.c | 22 ++ drivers/extcon/extcon-max77843.c | 19 +++

[PATCH] extcon: maxim: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/extcon/extcon-max14577.c | 24 +++- drivers/extcon/extcon-max77693.c | 22 ++ drivers/extcon/extcon-max77843.c | 19 +++

[PATCH] power: supply: maxim: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/max14577_charger.c | 22 ++ drivers/power/supply/max17040_battery.c | 18 +++--- drivers/power/supply/max17042_battery.c | 32

[PATCH] power: supply: maxim: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/max14577_charger.c | 22 ++ drivers/power/supply/max17040_battery.c | 18 +++--- drivers/power/supply/max17042_battery.c | 32

[PATCH 1/2] rtc: maxim: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/rtc/rtc-max77686.c | 20 +++- drivers/rtc/rtc-max8997.c | 20 +++- drivers/rtc/rtc-max8998.c | 20 +++- 3 files changed, 21

[PATCH 2/2] rtc: s5m: Add SPDX license identifier

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0+ license statement with SPDX license identifier. Signed-off-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s5m.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index

[PATCH 1/2] rtc: maxim: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/rtc/rtc-max77686.c | 20 +++- drivers/rtc/rtc-max8997.c | 20 +++- drivers/rtc/rtc-max8998.c | 20 +++- 3 files changed, 21

[PATCH 2/2] rtc: s5m: Add SPDX license identifier

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0+ license statement with SPDX license identifier. Signed-off-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s5m.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index

[PATCH 1/2] regulator: maxim: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/regulator/max14577-regulator.c | 22 + drivers/regulator/max77686-regulator.c | 32 +++-

[PATCH 1/2] regulator: maxim: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/regulator/max14577-regulator.c | 22 + drivers/regulator/max77686-regulator.c | 32 +++-

[PATCH 2/2] regulator: samsung: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/regulator/s2mpa01.c | 14 -- drivers/regulator/s2mps11.c | 21 - drivers/regulator/s5m8767.c | 16 3 files changed, 12

[PATCH 2/2] regulator: samsung: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/regulator/s2mpa01.c | 14 -- drivers/regulator/s2mps11.c | 21 - drivers/regulator/s5m8767.c | 16 3 files changed, 12

[PATCH 1/3] clk: max77686: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/clk-max77686.c | 27 ++- include/dt-bindings/clock/maxim,max77686.h | 5 + include/dt-bindings/clock/maxim,max77802.h | 5

[PATCH 3/3] clk: s2mps11: Use existing defines from bindings for clock IDs

2018-08-07 Thread Krzysztof Kozlowski
The clock IDs must match between DeviceTree bindings and the driver. There is already a header file used by DeviceTree sources so include it in the driver to remove duplicated symbols. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/clk-s2mps11.c | 7 +-- 1 file changed, 1 insertion(+),

[PATCH 1/3] clk: max77686: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/clk-max77686.c | 27 ++- include/dt-bindings/clock/maxim,max77686.h | 5 + include/dt-bindings/clock/maxim,max77802.h | 5

[PATCH 3/3] clk: s2mps11: Use existing defines from bindings for clock IDs

2018-08-07 Thread Krzysztof Kozlowski
The clock IDs must match between DeviceTree bindings and the driver. There is already a header file used by DeviceTree sources so include it in the driver to remove duplicated symbols. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/clk-s2mps11.c | 7 +-- 1 file changed, 1 insertion(+),

[PATCH 2/3] clk: s2mps11,s3c64xx: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/clk-s2mps11.c | 21 + include/dt-bindings/clock/samsung,s2mps11.h | 5 +

[PATCH 2/3] clk: s2mps11,s3c64xx: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/clk-s2mps11.c | 21 + include/dt-bindings/clock/samsung,s2mps11.h | 5 +

[PATCH 2/4] mfd: maxim: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/max14577.c | 28 +--- drivers/mfd/max77686.c | 32 +--- drivers/mfd/max77693.c |

[PATCH 2/4] mfd: maxim: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/max14577.c | 28 +--- drivers/mfd/max77686.c | 32 +--- drivers/mfd/max77693.c |

[PATCH 4/4] mfd: sec-core: Allow building as module

2018-08-07 Thread Krzysztof Kozlowski
The main MFD driver for Samsung PMICs (S2MPSXX, S5M876X) used with Exynos SoCs can be compiled and used as a module. The dependent clock, regulator and RTC drivers already can be built as a module. Building entire set of drivers as modules might require using initial ramdisk and can make booting

[PATCH 1/4] mfd: sec-core: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/sec-core.c | 16 drivers/mfd/sec-irq.c | 16 include/linux/mfd/samsung/core.h| 11 ++-

[PATCH 3/4] mfd: sec-core: Fix indentation of Kconfig description

2018-08-07 Thread Krzysztof Kozlowski
The indentation should be a tab followed by two spaces. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index f3fa516011ec..5810e6ff81f7 100644 ---

[PATCH 4/4] mfd: sec-core: Allow building as module

2018-08-07 Thread Krzysztof Kozlowski
The main MFD driver for Samsung PMICs (S2MPSXX, S5M876X) used with Exynos SoCs can be compiled and used as a module. The dependent clock, regulator and RTC drivers already can be built as a module. Building entire set of drivers as modules might require using initial ramdisk and can make booting

[PATCH 1/4] mfd: sec-core: Add SPDX license identifiers

2018-08-07 Thread Krzysztof Kozlowski
Replace GPL v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/sec-core.c | 16 drivers/mfd/sec-irq.c | 16 include/linux/mfd/samsung/core.h| 11 ++-

[PATCH 3/4] mfd: sec-core: Fix indentation of Kconfig description

2018-08-07 Thread Krzysztof Kozlowski
The indentation should be a tab followed by two spaces. Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index f3fa516011ec..5810e6ff81f7 100644 ---

[PATCH v2 2/2] leds: lm3697: Introduce the lm3697 driver

2018-08-07 Thread Dan Murphy
Introduce the lm3697 LED driver for backlighting and display. Datasheet location: http://www.ti.com/lit/ds/symlink/lm3697.pdf Signed-off-by: Dan Murphy --- v2 - Removed unneed 'of' calls in dt_parse, fixed comment, fixed checkpatch error, and change led registration -

[PATCH v2 2/2] leds: lm3697: Introduce the lm3697 driver

2018-08-07 Thread Dan Murphy
Introduce the lm3697 LED driver for backlighting and display. Datasheet location: http://www.ti.com/lit/ds/symlink/lm3697.pdf Signed-off-by: Dan Murphy --- v2 - Removed unneed 'of' calls in dt_parse, fixed comment, fixed checkpatch error, and change led registration -

[PATCH v2 1/2] dt: bindings: lm3697: Add bindings for lm3697 driver

2018-08-07 Thread Dan Murphy
Add the device tree bindings for the lm3697 led driver for backlighting and display. Signed-off-by: Dan Murphy --- v2 - Fixed subject and patch commit message - https://lore.kernel.org/patchwork/patch/971326/ .../devicetree/bindings/leds/leds-lm3697.txt | 64 +++ 1 file

[PATCH v2 1/2] dt: bindings: lm3697: Add bindings for lm3697 driver

2018-08-07 Thread Dan Murphy
Add the device tree bindings for the lm3697 led driver for backlighting and display. Signed-off-by: Dan Murphy --- v2 - Fixed subject and patch commit message - https://lore.kernel.org/patchwork/patch/971326/ .../devicetree/bindings/leds/leds-lm3697.txt | 64 +++ 1 file

Re: [PATCH 4/4] aio: allow direct aio poll comletions for keyed wakeups

2018-08-07 Thread Andrew Morton
On Tue, 7 Aug 2018 09:25:55 +0200 Christoph Hellwig wrote: > On Mon, Aug 06, 2018 at 03:27:05PM -0700, Andrew Morton wrote: > > On Mon, 6 Aug 2018 10:30:58 +0200 Christoph Hellwig wrote: > > > > > If we get a keyed wakeup for a aio poll waitqueue and wake can acquire the > > > ctx_lock

Re: [PATCH 4/4] aio: allow direct aio poll comletions for keyed wakeups

2018-08-07 Thread Andrew Morton
On Tue, 7 Aug 2018 09:25:55 +0200 Christoph Hellwig wrote: > On Mon, Aug 06, 2018 at 03:27:05PM -0700, Andrew Morton wrote: > > On Mon, 6 Aug 2018 10:30:58 +0200 Christoph Hellwig wrote: > > > > > If we get a keyed wakeup for a aio poll waitqueue and wake can acquire the > > > ctx_lock

[PATCH 2/3] sched/fair: trigger asym_packing during idle load balance

2018-08-07 Thread Vincent Guittot
newly idle load balance is not always triggered when a cpu becomes idle. This prevent the scheduler to get a chance to migrate task for asym packing. Enable active migration because of asym packing during idle load balance too. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 2 +- 1

[PATCH 2/3] sched/fair: trigger asym_packing during idle load balance

2018-08-07 Thread Vincent Guittot
newly idle load balance is not always triggered when a cpu becomes idle. This prevent the scheduler to get a chance to migrate task for asym packing. Enable active migration because of asym packing during idle load balance too. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 2 +- 1

Re: [PATCH 2/4] xen/blkfront: cleanup stale persistent grants

2018-08-07 Thread Juergen Gross
On 07/08/18 16:14, Roger Pau Monné wrote: > On Tue, Aug 07, 2018 at 08:31:31AM +0200, Juergen Gross wrote: >> On 06/08/18 18:16, Roger Pau Monné wrote: >>> On Mon, Aug 06, 2018 at 01:34:01PM +0200, Juergen Gross wrote: Add a periodic cleanup function to remove old persistent grants which

[PATCH 1/3] sched/fair: fix rounding issue for asym packing

2018-08-07 Thread Vincent Guittot
When check_asym_packing() is triggered, the imbalance is set to : busiest_stat.avg_load * busiest_stat.group_capacity / SCHED_CAPACITY_SCALE busiest_stat.avg_load also comes from a division and the final rounding can make imbalance slightly lower than the weighted load of the cfs_rq. But this is

[PATCH 3/3] sched/fair: fix unnecessary increase of balance interval

2018-08-07 Thread Vincent Guittot
In case of active balance, we increase the balance interval to cover pinned tasks cases not covered by all_pinned logic. Neverthless, the active migration triggered by asym packing should be treated as the normal unbalanced case and reset the interval to default value otherwise active migration

[PATCH 1/3] sched/fair: fix rounding issue for asym packing

2018-08-07 Thread Vincent Guittot
When check_asym_packing() is triggered, the imbalance is set to : busiest_stat.avg_load * busiest_stat.group_capacity / SCHED_CAPACITY_SCALE busiest_stat.avg_load also comes from a division and the final rounding can make imbalance slightly lower than the weighted load of the cfs_rq. But this is

[PATCH 3/3] sched/fair: fix unnecessary increase of balance interval

2018-08-07 Thread Vincent Guittot
In case of active balance, we increase the balance interval to cover pinned tasks cases not covered by all_pinned logic. Neverthless, the active migration triggered by asym packing should be treated as the normal unbalanced case and reset the interval to default value otherwise active migration

Re: [PATCH 2/4] xen/blkfront: cleanup stale persistent grants

2018-08-07 Thread Juergen Gross
On 07/08/18 16:14, Roger Pau Monné wrote: > On Tue, Aug 07, 2018 at 08:31:31AM +0200, Juergen Gross wrote: >> On 06/08/18 18:16, Roger Pau Monné wrote: >>> On Mon, Aug 06, 2018 at 01:34:01PM +0200, Juergen Gross wrote: Add a periodic cleanup function to remove old persistent grants which

[PATCH 0/3] sched/fair: some fixes for asym_packing

2018-08-07 Thread Vincent Guittot
During the review of misfit task patchset, Morten and Valentin raised some problems with the use of SD_ASYM_PACKING flag on asymetric system like hikey960 arm64 big/LITTLE platform. The study of the use cases has shown some problems that can happen for every systems that use the flag. The 3

[PATCH 0/3] sched/fair: some fixes for asym_packing

2018-08-07 Thread Vincent Guittot
During the review of misfit task patchset, Morten and Valentin raised some problems with the use of SD_ASYM_PACKING flag on asymetric system like hikey960 arm64 big/LITTLE platform. The study of the use cases has shown some problems that can happen for every systems that use the flag. The 3

Re: [PATCH v7 2/3] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-08-07 Thread Marcel Holtmann
Hi Sean, this is even more hackish since the __hci_cmd_sync_ev command is really meant to get a cmd status first before waiting for that event. >>> >>> Understood. >>> >>> I've stopped the hack in v8. could we merge v8 first ? and then I will a >>> fix up with

Re: [PATCH v7 2/3] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-08-07 Thread Marcel Holtmann
Hi Sean, this is even more hackish since the __hci_cmd_sync_ev command is really meant to get a cmd status first before waiting for that event. >>> >>> Understood. >>> >>> I've stopped the hack in v8. could we merge v8 first ? and then I will a >>> fix up with

Re: [PATCH 1/4] watchdog: hpwdt: Initialize pretimeout from module parameter.

2018-08-07 Thread Jerry Hoemann
On Sat, Aug 04, 2018 at 06:08:17PM -0700, Guenter Roeck wrote: > On 08/02/2018 02:15 PM, Jerry Hoemann wrote: > > When the pretimeout is specified as a module parameter, the > > value should be reflected in hpwdt_dev.pretimeout. The default > > (on) case is correct. But, when disabling

Re: [PATCH 1/4] watchdog: hpwdt: Initialize pretimeout from module parameter.

2018-08-07 Thread Jerry Hoemann
On Sat, Aug 04, 2018 at 06:08:17PM -0700, Guenter Roeck wrote: > On 08/02/2018 02:15 PM, Jerry Hoemann wrote: > > When the pretimeout is specified as a module parameter, the > > value should be reflected in hpwdt_dev.pretimeout. The default > > (on) case is correct. But, when disabling

[PATCH RFC 10/10] fs: Use unregister_shrinker_delayed_{initiate, finalize} for super_block shrinker

2018-08-07 Thread Kirill Tkhai
Previous patches made all the data, which is touched from super_cache_count(), destroyed from destroy_super_work(): s_dentry_lru, s_inode_lru and super_block::s_fs_info. super_cache_scan() can't be called after SB_ACTIVE is cleared in generic_shutdown_super(). So, it safe to move heavy

[PATCH RFC 09/10] shmem: Implement shmem_destroy_super()

2018-08-07 Thread Kirill Tkhai
Similar to xfs_fs_destroy_super() implement the method for shmem. shmem_unused_huge_count() just touches sb->s_fs_info. After such the later freeing it will be safe for unregister_shrinker() splitting (which is made in next patch). Signed-off-by: Kirill Tkhai --- mm/shmem.c |8 1

[PATCH RFC 10/10] fs: Use unregister_shrinker_delayed_{initiate, finalize} for super_block shrinker

2018-08-07 Thread Kirill Tkhai
Previous patches made all the data, which is touched from super_cache_count(), destroyed from destroy_super_work(): s_dentry_lru, s_inode_lru and super_block::s_fs_info. super_cache_scan() can't be called after SB_ACTIVE is cleared in generic_shutdown_super(). So, it safe to move heavy

[PATCH RFC 09/10] shmem: Implement shmem_destroy_super()

2018-08-07 Thread Kirill Tkhai
Similar to xfs_fs_destroy_super() implement the method for shmem. shmem_unused_huge_count() just touches sb->s_fs_info. After such the later freeing it will be safe for unregister_shrinker() splitting (which is made in next patch). Signed-off-by: Kirill Tkhai --- mm/shmem.c |8 1

[PATCH RFC 08/10] xfs: Introduce xfs_fs_destroy_super()

2018-08-07 Thread Kirill Tkhai
xfs_fs_nr_cached_objects() touches sb->s_fs_info, and this patch makes it to be destructed later. After this patch xfs_fs_nr_cached_objects() is safe for splitting unregister_shrinker(): mp->m_perag_tree is stable till destroy_super_work(), while iteration over it is already RCU-protected by

[PATCH RFC 08/10] xfs: Introduce xfs_fs_destroy_super()

2018-08-07 Thread Kirill Tkhai
xfs_fs_nr_cached_objects() touches sb->s_fs_info, and this patch makes it to be destructed later. After this patch xfs_fs_nr_cached_objects() is safe for splitting unregister_shrinker(): mp->m_perag_tree is stable till destroy_super_work(), while iteration over it is already RCU-protected by

[PATCH RFC 07/10] fs: Introduce struct super_operations::destroy_super() callback.

2018-08-07 Thread Kirill Tkhai
The patch introduces a new callback, which will be called asynchronous from delayed work. This will allows to make ::nr_cached_objects() safe to be called on destroying superblock in next patches, and to split unregister_shrinker() into two primitives. Signed-off-by: Kirill Tkhai ---

[PATCH RFC 07/10] fs: Introduce struct super_operations::destroy_super() callback.

2018-08-07 Thread Kirill Tkhai
The patch introduces a new callback, which will be called asynchronous from delayed work. This will allows to make ::nr_cached_objects() safe to be called on destroying superblock in next patches, and to split unregister_shrinker() into two primitives. Signed-off-by: Kirill Tkhai ---

[PATCH RFC 06/10] fs: Shrink only (SB_ACTIVE|SB_BORN) superblocks in super_cache_scan()

2018-08-07 Thread Kirill Tkhai
This patch prepares superblock shrinker for delayed unregistering. It makes super_cache_scan() avoid shrinking of not active superblocks. SB_ACTIVE is used as such the indicator. In case of superblock is not active, super_cache_scan() just exits with SHRINK_STOP as result. Note, that SB_ACTIVE is

[PATCH RFC 05/10] fs: Move list_lru_destroy() to destroy_super_work()

2018-08-07 Thread Kirill Tkhai
The patch makes s_dentry_lru and s_inode_lru be destroyed later from the workqueue. This is preparation to split unregister_shrinker(super_block::s_shrink) in two stages, and to call finalize stage from destroy_super_work(). Note, that generic filesystem shrinker unregistration is safe to be

[PATCH RFC 06/10] fs: Shrink only (SB_ACTIVE|SB_BORN) superblocks in super_cache_scan()

2018-08-07 Thread Kirill Tkhai
This patch prepares superblock shrinker for delayed unregistering. It makes super_cache_scan() avoid shrinking of not active superblocks. SB_ACTIVE is used as such the indicator. In case of superblock is not active, super_cache_scan() just exits with SHRINK_STOP as result. Note, that SB_ACTIVE is

[PATCH RFC 05/10] fs: Move list_lru_destroy() to destroy_super_work()

2018-08-07 Thread Kirill Tkhai
The patch makes s_dentry_lru and s_inode_lru be destroyed later from the workqueue. This is preparation to split unregister_shrinker(super_block::s_shrink) in two stages, and to call finalize stage from destroy_super_work(). Note, that generic filesystem shrinker unregistration is safe to be

[PATCH RFC 03/10] mm: Convert shrinker_rwsem to mutex

2018-08-07 Thread Kirill Tkhai
There are no readers, so rwsem is not need anymore. Signed-off-by: Kirill Tkhai --- mm/vmscan.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 9dda903a1406..2dc274a385b9 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@

[PATCH RFC 04/10] mm: Split unregister_shrinker()

2018-08-07 Thread Kirill Tkhai
This and the next patches in this series aim to make time effect of synchronize_srcu() invisible for user. The patch splits unregister_shrinker() in two functions: unregister_shrinker_delayed_initiate() unregister_shrinker_delayed_finalize() and shrinker users may make the second

[PATCH RFC 04/10] mm: Split unregister_shrinker()

2018-08-07 Thread Kirill Tkhai
This and the next patches in this series aim to make time effect of synchronize_srcu() invisible for user. The patch splits unregister_shrinker() in two functions: unregister_shrinker_delayed_initiate() unregister_shrinker_delayed_finalize() and shrinker users may make the second

[PATCH RFC 03/10] mm: Convert shrinker_rwsem to mutex

2018-08-07 Thread Kirill Tkhai
There are no readers, so rwsem is not need anymore. Signed-off-by: Kirill Tkhai --- mm/vmscan.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 9dda903a1406..2dc274a385b9 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@

[PATCH RFC 02/10] mm: Make shrink_slab() lockless

2018-08-07 Thread Kirill Tkhai
The patch makes shrinker list and shrinker_idr SRCU-safe for readers. This requires synchronize_srcu() on finalize stage unregistering stage, which waits till all parallel shrink_slab() are finished Note, that patch removes rwsem_is_contended() checks from the code, and this does not result in

[PATCH RFC 02/10] mm: Make shrink_slab() lockless

2018-08-07 Thread Kirill Tkhai
The patch makes shrinker list and shrinker_idr SRCU-safe for readers. This requires synchronize_srcu() on finalize stage unregistering stage, which waits till all parallel shrink_slab() are finished Note, that patch removes rwsem_is_contended() checks from the code, and this does not result in

[PATCH RFC 01/10] rcu: Make CONFIG_SRCU unconditionally enabled

2018-08-07 Thread Kirill Tkhai
This patch kills all CONFIG_SRCU defines and the code under !CONFIG_SRCU. Signed-off-by: Kirill Tkhai --- drivers/base/core.c| 42 include/linux/device.h |2 - include/linux/rcutiny.h

[PATCH RFC 01/10] rcu: Make CONFIG_SRCU unconditionally enabled

2018-08-07 Thread Kirill Tkhai
This patch kills all CONFIG_SRCU defines and the code under !CONFIG_SRCU. Signed-off-by: Kirill Tkhai --- drivers/base/core.c| 42 include/linux/device.h |2 - include/linux/rcutiny.h

[PATCH RFC 00/10] Introduce lockless shrink_slab()

2018-08-07 Thread Kirill Tkhai
After bitmaps of not-empty memcg shrinkers were implemented (see "[PATCH v9 00/17] Improve shrink_slab() scalability..." series, which is already in mm tree), all the evil in perf trace has moved from shrink_slab() to down_read_trylock(). As reported by Shakeel Butt: > I created 255 memcgs,

[PATCH RFC 00/10] Introduce lockless shrink_slab()

2018-08-07 Thread Kirill Tkhai
After bitmaps of not-empty memcg shrinkers were implemented (see "[PATCH v9 00/17] Improve shrink_slab() scalability..." series, which is already in mm tree), all the evil in perf trace has moved from shrink_slab() to down_read_trylock(). As reported by Shakeel Butt: > I created 255 memcgs,

Re: xfs: cancel dfops on xfs_defer_finish() error

2018-08-07 Thread Brian Foster
On Tue, Aug 07, 2018 at 08:26:44AM -0700, Darrick J. Wong wrote: > On Tue, Aug 07, 2018 at 11:18:36AM -0400, Brian Foster wrote: > > On Tue, Aug 07, 2018 at 08:10:29AM -0700, Darrick J. Wong wrote: > > > On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > > > > On Tue, Aug 07, 2018 at

Re: xfs: cancel dfops on xfs_defer_finish() error

2018-08-07 Thread Brian Foster
On Tue, Aug 07, 2018 at 08:26:44AM -0700, Darrick J. Wong wrote: > On Tue, Aug 07, 2018 at 11:18:36AM -0400, Brian Foster wrote: > > On Tue, Aug 07, 2018 at 08:10:29AM -0700, Darrick J. Wong wrote: > > > On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > > > > On Tue, Aug 07, 2018 at

Re: [PATCH 3/3] perf/x86/intel: Add quirk for Goldmont Plus

2018-08-07 Thread Liang, Kan
On 8/6/2018 2:39 PM, Peter Zijlstra wrote: On Mon, Aug 06, 2018 at 10:23:43AM -0700, kan.li...@linux.intel.com wrote: +static bool intel_glk_counter_freezing_broken(int cpu) case INTEL_FAM6_ATOM_GEMINI_LAKE: + x86_add_quirk(intel_counter_freezing_quirk); We really

Re: [PATCH 3/3] perf/x86/intel: Add quirk for Goldmont Plus

2018-08-07 Thread Liang, Kan
On 8/6/2018 2:39 PM, Peter Zijlstra wrote: On Mon, Aug 06, 2018 at 10:23:43AM -0700, kan.li...@linux.intel.com wrote: +static bool intel_glk_counter_freezing_broken(int cpu) case INTEL_FAM6_ATOM_GEMINI_LAKE: + x86_add_quirk(intel_counter_freezing_quirk); We really

Re: [PATCH 2/3] x86, perf: Add a separate Arch Perfmon v4 PMI handler

2018-08-07 Thread Liang, Kan
On 8/6/2018 2:35 PM, Peter Zijlstra wrote: On Mon, Aug 06, 2018 at 10:23:42AM -0700, kan.li...@linux.intel.com wrote: @@ -2044,6 +2056,14 @@ static void intel_pmu_disable_event(struct perf_event *event) if (unlikely(event->attr.precise_ip))

Re: [PATCH 2/3] x86, perf: Add a separate Arch Perfmon v4 PMI handler

2018-08-07 Thread Liang, Kan
On 8/6/2018 2:35 PM, Peter Zijlstra wrote: On Mon, Aug 06, 2018 at 10:23:42AM -0700, kan.li...@linux.intel.com wrote: @@ -2044,6 +2056,14 @@ static void intel_pmu_disable_event(struct perf_event *event) if (unlikely(event->attr.precise_ip))

Re: [PATCH 1/3] perf/x86/intel: Factor out common code of PMI handler

2018-08-07 Thread Liang, Kan
On 8/6/2018 2:20 PM, Peter Zijlstra wrote: On Mon, Aug 06, 2018 at 10:23:41AM -0700, kan.li...@linux.intel.com wrote: + if (++loops > 100) { + static bool warned; + + if (!warned) { + WARN(1, "perfevents: irq loop stuck!\n"); +

Re: [PATCH 1/3] perf/x86/intel: Factor out common code of PMI handler

2018-08-07 Thread Liang, Kan
On 8/6/2018 2:20 PM, Peter Zijlstra wrote: On Mon, Aug 06, 2018 at 10:23:41AM -0700, kan.li...@linux.intel.com wrote: + if (++loops > 100) { + static bool warned; + + if (!warned) { + WARN(1, "perfevents: irq loop stuck!\n"); +

Re: [RFC PATCH 2/3] mm/memory_hotplug: Create __shrink_pages and move it to offline_pages

2018-08-07 Thread David Hildenbrand
On 07.08.2018 17:19, Jerome Glisse wrote: > On Tue, Aug 07, 2018 at 04:54:57PM +0200, David Hildenbrand wrote: >> On 07.08.2018 15:52, Jerome Glisse wrote: >>> On Tue, Aug 07, 2018 at 03:37:56PM +0200, osalva...@techadventures.net >>> wrote: From: Oscar Salvador >>> >>> [...] >>> diff

Re: [RFC PATCH 2/3] mm/memory_hotplug: Create __shrink_pages and move it to offline_pages

2018-08-07 Thread David Hildenbrand
On 07.08.2018 17:19, Jerome Glisse wrote: > On Tue, Aug 07, 2018 at 04:54:57PM +0200, David Hildenbrand wrote: >> On 07.08.2018 15:52, Jerome Glisse wrote: >>> On Tue, Aug 07, 2018 at 03:37:56PM +0200, osalva...@techadventures.net >>> wrote: From: Oscar Salvador >>> >>> [...] >>> diff

Re: xfs: cancel dfops on xfs_defer_finish() error

2018-08-07 Thread Darrick J. Wong
On Tue, Aug 07, 2018 at 11:18:36AM -0400, Brian Foster wrote: > On Tue, Aug 07, 2018 at 08:10:29AM -0700, Darrick J. Wong wrote: > > On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > > > On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King wrote: > > > > Hi, > > > > > > > >

Re: xfs: cancel dfops on xfs_defer_finish() error

2018-08-07 Thread Darrick J. Wong
On Tue, Aug 07, 2018 at 11:18:36AM -0400, Brian Foster wrote: > On Tue, Aug 07, 2018 at 08:10:29AM -0700, Darrick J. Wong wrote: > > On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > > > On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King wrote: > > > > Hi, > > > > > > > >

Re: [PATCH v12 3/3] tracing: Centralize preemptirq tracepoints and unify their usage

2018-08-07 Thread Joel Fernandes
On August 7, 2018 11:09:06 AM EDT, Steven Rostedt wrote: >On Tue, 07 Aug 2018 10:48:05 -0400 >Joel Fernandes wrote: > >> >You mean if someone add a tracepoint callback to the irq disable >> >tracepoint, and did a lockdep assert to make sure interrupts are >> >disabled? >> >> Yes that's

Re: [PATCH v12 3/3] tracing: Centralize preemptirq tracepoints and unify their usage

2018-08-07 Thread Joel Fernandes
On August 7, 2018 11:09:06 AM EDT, Steven Rostedt wrote: >On Tue, 07 Aug 2018 10:48:05 -0400 >Joel Fernandes wrote: > >> >You mean if someone add a tracepoint callback to the irq disable >> >tracepoint, and did a lockdep assert to make sure interrupts are >> >disabled? >> >> Yes that's

Re: [PATCH] proc: add percpu populated pages count to meminfo

2018-08-07 Thread Dennis Zhou
Hi Tejun, On Tue, Aug 07, 2018 at 08:11:46AM -0700, Tejun Heo wrote: > Hello, > > On Tue, Aug 07, 2018 at 02:12:06PM +, Christopher Lameter wrote: > > > @@ -121,6 +122,7 @@ static int meminfo_proc_show(struct seq_file *m, void > > > *v) > > > (unsigned long)VMALLOC_TOTAL >>

Re: [PATCH] proc: add percpu populated pages count to meminfo

2018-08-07 Thread Dennis Zhou
Hi Tejun, On Tue, Aug 07, 2018 at 08:11:46AM -0700, Tejun Heo wrote: > Hello, > > On Tue, Aug 07, 2018 at 02:12:06PM +, Christopher Lameter wrote: > > > @@ -121,6 +122,7 @@ static int meminfo_proc_show(struct seq_file *m, void > > > *v) > > > (unsigned long)VMALLOC_TOTAL >>

Re: [PATCH] proc: add percpu populated pages count to meminfo

2018-08-07 Thread Dennis Zhou
Hi Christopher, On Tue, Aug 07, 2018 at 02:12:06PM +, Christopher Lameter wrote: > On Mon, 6 Aug 2018, Dennis Zhou wrote: > > show_val_kb(m, "VmallocUsed:", 0ul); > > show_val_kb(m, "VmallocChunk: ", 0ul); > > + show_val_kb(m, "PercpuPopulated:", pcpu_nr_populated_pages()); >

Re: [PATCH] proc: add percpu populated pages count to meminfo

2018-08-07 Thread Dennis Zhou
Hi Christopher, On Tue, Aug 07, 2018 at 02:12:06PM +, Christopher Lameter wrote: > On Mon, 6 Aug 2018, Dennis Zhou wrote: > > show_val_kb(m, "VmallocUsed:", 0ul); > > show_val_kb(m, "VmallocChunk: ", 0ul); > > + show_val_kb(m, "PercpuPopulated:", pcpu_nr_populated_pages()); >

Re: [RFC PATCH 2/3] mm/memory_hotplug: Create __shrink_pages and move it to offline_pages

2018-08-07 Thread Jerome Glisse
On Tue, Aug 07, 2018 at 04:54:57PM +0200, David Hildenbrand wrote: > On 07.08.2018 15:52, Jerome Glisse wrote: > > On Tue, Aug 07, 2018 at 03:37:56PM +0200, osalva...@techadventures.net > > wrote: > >> From: Oscar Salvador > > > > [...] > > > >> diff --git a/mm/memory_hotplug.c

Re: [RFC PATCH 2/3] mm/memory_hotplug: Create __shrink_pages and move it to offline_pages

2018-08-07 Thread Jerome Glisse
On Tue, Aug 07, 2018 at 04:54:57PM +0200, David Hildenbrand wrote: > On 07.08.2018 15:52, Jerome Glisse wrote: > > On Tue, Aug 07, 2018 at 03:37:56PM +0200, osalva...@techadventures.net > > wrote: > >> From: Oscar Salvador > > > > [...] > > > >> diff --git a/mm/memory_hotplug.c

<    4   5   6   7   8   9   10   11   12   13   >