Re: [PATCH v7 02/10] Makefile: Prepare for using macros for inline asm

2018-08-09 Thread Masahiro Yamada
Hi Nadav, 2018-08-10 5:15 GMT+09:00 Nadav Amit : > Using macros for inline assembly improves both readability and > compilation decisions that are distorted by big assembly blocks that use > alternative sections. Compile macros.S and use it to assemble all C > files. Currently, only x86 will use

Re: [PATCH v7 02/10] Makefile: Prepare for using macros for inline asm

2018-08-09 Thread Masahiro Yamada
Hi Nadav, 2018-08-10 5:15 GMT+09:00 Nadav Amit : > Using macros for inline assembly improves both readability and > compilation decisions that are distorted by big assembly blocks that use > alternative sections. Compile macros.S and use it to assemble all C > files. Currently, only x86 will use

[PATCH] zsmalloc: fix linking bug in init_zspage

2018-08-09 Thread zhouxianrong
From: zhouxianrong The last partial object in last subpage of zspage should not be linked in allocation list. Otherwise it could trigger BUG_ON explicitly at function zs_map_object. But it happened rarely. Signed-off-by: zhouxianrong --- mm/zsmalloc.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH] zsmalloc: fix linking bug in init_zspage

2018-08-09 Thread zhouxianrong
From: zhouxianrong The last partial object in last subpage of zspage should not be linked in allocation list. Otherwise it could trigger BUG_ON explicitly at function zs_map_object. But it happened rarely. Signed-off-by: zhouxianrong --- mm/zsmalloc.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v3 2/2] net/9p: add a per-client fcall kmem_cache

2018-08-09 Thread piaojun
Hi Dominique, Could you help paste the test result of before-after-applied this patch in comment? And please see my comments below. On 2018/8/9 22:33, Dominique Martinet wrote: > From: Dominique Martinet > > Having a specific cache for the fcall allocations helps speed up > allocations a bit,

Re: [PATCH v3 2/2] net/9p: add a per-client fcall kmem_cache

2018-08-09 Thread piaojun
Hi Dominique, Could you help paste the test result of before-after-applied this patch in comment? And please see my comments below. On 2018/8/9 22:33, Dominique Martinet wrote: > From: Dominique Martinet > > Having a specific cache for the fcall allocations helps speed up > allocations a bit,

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-09 Thread Andrew Morton
On Thu, 9 Aug 2018 12:54:09 +1000 Rashmica Gupta wrote: > When hot-removing memory release_mem_region_adjustable() splits > iomem resources if they are not the exact size of the memory being > hot-deleted. Adding this memory back to the kernel adds a new > resource. > > Eg a node has memory

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-09 Thread Andrew Morton
On Thu, 9 Aug 2018 12:54:09 +1000 Rashmica Gupta wrote: > When hot-removing memory release_mem_region_adjustable() splits > iomem resources if they are not the exact size of the memory being > hot-deleted. Adding this memory back to the kernel adds a new > resource. > > Eg a node has memory

Re: [PATCH] checkpatch: DT bindings should be a separate patch

2018-08-09 Thread Joe Perches
On Thu, 2018-08-09 at 14:50 -0600, Rob Herring wrote: > Devicetree bindings should be their own patch as documented in > Documentation/devicetree/bindings/submitting-patches.txt section I.1. > This is because bindings are logically independent from a driver > implementation, they have a different

Re: [PATCH] checkpatch: DT bindings should be a separate patch

2018-08-09 Thread Joe Perches
On Thu, 2018-08-09 at 14:50 -0600, Rob Herring wrote: > Devicetree bindings should be their own patch as documented in > Documentation/devicetree/bindings/submitting-patches.txt section I.1. > This is because bindings are logically independent from a driver > implementation, they have a different

Re: [PATCH 0/4] locks: avoid thundering-herd wake-ups

2018-08-09 Thread J. Bruce Fields
On Fri, Aug 10, 2018 at 09:56:07AM +1000, NeilBrown wrote: > On Thu, Aug 09 2018, J. Bruce Fields wrote: > > If we only cared about the former, and only in simple cases, we could > > walk the entire list and skip waking up only the locks that conflict > > with the first one we wake. We wouldn't

Re: [PATCH 0/4] locks: avoid thundering-herd wake-ups

2018-08-09 Thread J. Bruce Fields
On Fri, Aug 10, 2018 at 09:56:07AM +1000, NeilBrown wrote: > On Thu, Aug 09 2018, J. Bruce Fields wrote: > > If we only cared about the former, and only in simple cases, we could > > walk the entire list and skip waking up only the locks that conflict > > with the first one we wake. We wouldn't

Re: [PATCH v2 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h

2018-08-09 Thread Palmer Dabbelt
On Thu, 09 Aug 2018 14:24:22 PDT (-0700), li...@roeck-us.net wrote: On Thu, Aug 09, 2018 at 01:25:24PM -0700, Palmer Dabbelt wrote: This file is expected to be included multiple times in the same file in order to allow the __SYSCALL macro to generate system call tables. With a global include

Re: [PATCH v2 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h

2018-08-09 Thread Palmer Dabbelt
On Thu, 09 Aug 2018 14:24:22 PDT (-0700), li...@roeck-us.net wrote: On Thu, Aug 09, 2018 at 01:25:24PM -0700, Palmer Dabbelt wrote: This file is expected to be included multiple times in the same file in order to allow the __SYSCALL macro to generate system call tables. With a global include

Re: [PATCH 3/5] fs/locks: change all *_conflict() functions to return a new enum.

2018-08-09 Thread J. Bruce Fields
On Fri, Aug 10, 2018 at 09:40:35AM +1000, NeilBrown wrote: > caller_fl is first and sys_fl is second. > > if sys_fl, the second, is a read lock, and caller_fl, the first, is a > write lock, they clearly conflict but any other lock that conflict > with caller_fl (The write lock) would *not*

Re: [PATCH 3/5] fs/locks: change all *_conflict() functions to return a new enum.

2018-08-09 Thread J. Bruce Fields
On Fri, Aug 10, 2018 at 09:40:35AM +1000, NeilBrown wrote: > caller_fl is first and sys_fl is second. > > if sys_fl, the second, is a read lock, and caller_fl, the first, is a > write lock, they clearly conflict but any other lock that conflict > with caller_fl (The write lock) would *not*

Re: [PATCH] checkpatch: DT bindings should be a separate patch

2018-08-09 Thread Andrew Morton
On Thu, 9 Aug 2018 14:50:32 -0600 Rob Herring wrote: > Devicetree bindings should be their own patch as documented in > Documentation/devicetree/bindings/submitting-patches.txt section I.1. > This is because bindings are logically independent from a driver > implementation, they have a

Re: [PATCH] checkpatch: DT bindings should be a separate patch

2018-08-09 Thread Andrew Morton
On Thu, 9 Aug 2018 14:50:32 -0600 Rob Herring wrote: > Devicetree bindings should be their own patch as documented in > Documentation/devicetree/bindings/submitting-patches.txt section I.1. > This is because bindings are logically independent from a driver > implementation, they have a

Re: [PATCH v3 1/2] net/9p: embed fcall in req to round down buffer allocs

2018-08-09 Thread piaojun
LGTM On 2018/8/9 22:33, Dominique Martinet wrote: > From: Dominique Martinet > > 'msize' is often a power of two, or at least page-aligned, so avoiding > an overhead of two dozen bytes for each allocation will help the > allocator do its work and reduce memory fragmentation. > > Suggested-by:

Re: [PATCH v3 1/2] net/9p: embed fcall in req to round down buffer allocs

2018-08-09 Thread piaojun
LGTM On 2018/8/9 22:33, Dominique Martinet wrote: > From: Dominique Martinet > > 'msize' is often a power of two, or at least page-aligned, so avoiding > an overhead of two dozen bytes for each allocation will help the > allocator do its work and reduce memory fragmentation. > > Suggested-by:

Re: FW: [PATCH v2] RISC-V: Add the directive for alignment of stvec's value

2018-08-09 Thread Zong Li
> Subject: [PATCH v2] RISC-V: Add the directive for alignment of stvec's value > > The stvec's value must be 4 byte alignment by specification definition. > These directives avoid to stvec be set the non-alignment value. > > Signed-off-by: Zong Li > --- > arch/riscv/kernel/head.S | 2 ++ > 1

Re: FW: [PATCH v2] RISC-V: Add the directive for alignment of stvec's value

2018-08-09 Thread Zong Li
> Subject: [PATCH v2] RISC-V: Add the directive for alignment of stvec's value > > The stvec's value must be 4 byte alignment by specification definition. > These directives avoid to stvec be set the non-alignment value. > > Signed-off-by: Zong Li > --- > arch/riscv/kernel/head.S | 2 ++ > 1

Re: [PATCH 5/5] fs/locks: create a tree of dependent requests.

2018-08-09 Thread J. Bruce Fields
On Fri, Aug 10, 2018 at 08:19:26AM +1000, NeilBrown wrote: > On Thu, Aug 09 2018, J. Bruce Fields wrote: > > I think you could simplify the code a lot by maintaining the tree so > > that it always satisfies the condition that waiters are always strictly > > "weaker" than their descendents, so that

Re: [PATCH 5/5] fs/locks: create a tree of dependent requests.

2018-08-09 Thread J. Bruce Fields
On Fri, Aug 10, 2018 at 08:19:26AM +1000, NeilBrown wrote: > On Thu, Aug 09 2018, J. Bruce Fields wrote: > > I think you could simplify the code a lot by maintaining the tree so > > that it always satisfies the condition that waiters are always strictly > > "weaker" than their descendents, so that

Re: [PATCH] module: Add the print format of Elf_Addr for 32/64-bit compatibly

2018-08-09 Thread Zong Li
Zong Li 於 2018年7月17日 週二 上午11:06寫道: > > Use a similar way like fixed width integer types in inttypes.h. > > For the ELF, the Elf32_Addr is int type and Elf64_Addr is long long > type. It is opposite to definition of inttypes.h, so the Elf_Addr cannot > re-use the header. > > In many architectures,

Re: [PATCH] module: Add the print format of Elf_Addr for 32/64-bit compatibly

2018-08-09 Thread Zong Li
Zong Li 於 2018年7月17日 週二 上午11:06寫道: > > Use a similar way like fixed width integer types in inttypes.h. > > For the ELF, the Elf32_Addr is int type and Elf64_Addr is long long > type. It is opposite to definition of inttypes.h, so the Elf_Addr cannot > re-use the header. > > In many architectures,

Re: [PATCH v4 0/4] seccomp trap to userspace

2018-08-09 Thread Dinesh Subhraveti
On Mon, Aug 6, 2018 at 7:44 PM Tycho Andersen wrote: > > Hi all, > > Dinesh Subhraveti has claimed that some part of this series might be > patented. While he has not furnished me with anything to confirm this > claim, I'll put this series on hold. For the sake of everyone's clarity, there is no

Re: [PATCH v4 0/4] seccomp trap to userspace

2018-08-09 Thread Dinesh Subhraveti
On Mon, Aug 6, 2018 at 7:44 PM Tycho Andersen wrote: > > Hi all, > > Dinesh Subhraveti has claimed that some part of this series might be > patented. While he has not furnished me with anything to confirm this > claim, I'll put this series on hold. For the sake of everyone's clarity, there is no

Re: [PATCH 0/5 - V2] locks: avoid thundering-herd wake-ups

2018-08-09 Thread J. Bruce Fields
On Fri, Aug 10, 2018 at 08:12:43AM +1000, NeilBrown wrote: > On Thu, Aug 09 2018, J. Bruce Fields wrote: > > > I think there's also a problem with multiple tasks sharing the same > > lock owner. > > > > So, all locks are exclusive locks for the same range. We have four > > tasks. Tasks 1 and 4

Re: [PATCH 0/5 - V2] locks: avoid thundering-herd wake-ups

2018-08-09 Thread J. Bruce Fields
On Fri, Aug 10, 2018 at 08:12:43AM +1000, NeilBrown wrote: > On Thu, Aug 09 2018, J. Bruce Fields wrote: > > > I think there's also a problem with multiple tasks sharing the same > > lock owner. > > > > So, all locks are exclusive locks for the same range. We have four > > tasks. Tasks 1 and 4

Re: [PATCH 1/2] PCI/ACPI: correct error message for ASPM disabling

2018-08-09 Thread Joe Perches
On Thu, 2018-08-09 at 18:46 +, Sinan Kaya wrote: > If _OSC execution fails today for platforms without an _OSC > entry, code is printing a misleading message saying disabling > ASPM as follows: > > acpi PNP0A03:00: _OSC failed (AE_NOT_FOUND); disabling ASPM > > We need to ensure that

Re: [PATCH 1/2] PCI/ACPI: correct error message for ASPM disabling

2018-08-09 Thread Joe Perches
On Thu, 2018-08-09 at 18:46 +, Sinan Kaya wrote: > If _OSC execution fails today for platforms without an _OSC > entry, code is printing a misleading message saying disabling > ASPM as follows: > > acpi PNP0A03:00: _OSC failed (AE_NOT_FOUND); disabling ASPM > > We need to ensure that

Re: [RFC PATCH v2 1/4] dt-bindings: misc: Add bindings for misc. BMC control fields

2018-08-09 Thread Kun Yi
Andrew, Benjamin, Rob, Thanks for bringing up the set of patches and a great discussion. After going through the thread I figured that I'd like to share a few things we needed to hack when programming several BMC boards: - Debug UART enable/mux - Disable GPIO D/E passthrough (I think this is

Re: [RFC PATCH v2 1/4] dt-bindings: misc: Add bindings for misc. BMC control fields

2018-08-09 Thread Kun Yi
Andrew, Benjamin, Rob, Thanks for bringing up the set of patches and a great discussion. After going through the thread I figured that I'd like to share a few things we needed to hack when programming several BMC boards: - Debug UART enable/mux - Disable GPIO D/E passthrough (I think this is

[PATCH] hid: microsoft: Add rumble support for Xbox One S controller

2018-08-09 Thread Andrey Smirnov
Add HID quirk driver for Xbox One S controller over bluetooth. This driver only adds support for rumble. Standard controller functionality is exposed by default HID driver. Cc: Dmitry Torokhov Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Cc:

[PATCH] hid: microsoft: Add rumble support for Xbox One S controller

2018-08-09 Thread Andrey Smirnov
Add HID quirk driver for Xbox One S controller over bluetooth. This driver only adds support for rumble. Standard controller functionality is exposed by default HID driver. Cc: Dmitry Torokhov Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Cc:

Re: [PATCH 4/4] HID: multitouch: remove unneeded else conditional cases

2018-08-09 Thread Joey Pabalinas
On Tue, Jul 03, 2018 at 10:17:58AM +0200, Benjamin Tissoires wrote: > This one looks good. > Reviewed-by: Benjamin Tissoires > > Just FYI, I sent out a big refactor of the hid-multitouch code. Jiri > should be still reviewing it, so I am not so sure who will have to > rebase which series on top

Re: [PATCH 4/4] HID: multitouch: remove unneeded else conditional cases

2018-08-09 Thread Joey Pabalinas
On Tue, Jul 03, 2018 at 10:17:58AM +0200, Benjamin Tissoires wrote: > This one looks good. > Reviewed-by: Benjamin Tissoires > > Just FYI, I sent out a big refactor of the hid-multitouch code. Jiri > should be still reviewing it, so I am not so sure who will have to > rebase which series on top

Re: [PATCH 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

2018-08-09 Thread Joey Pabalinas
On Tue, Jul 03, 2018 at 09:53:19AM +0200, Benjamin Tissoires wrote: > NACK on this. > If the Surface has a buggy firmware, we should handle it as a special > case, not as a common failure. > Also, I am not sure this quirk is compatible with Win 8 specification. > Last, we now have a timeout for

Re: [PATCH 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

2018-08-09 Thread Joey Pabalinas
On Tue, Jul 03, 2018 at 09:53:19AM +0200, Benjamin Tissoires wrote: > NACK on this. > If the Surface has a buggy firmware, we should handle it as a special > case, not as a common failure. > Also, I am not sure this quirk is compatible with Win 8 specification. > Last, we now have a timeout for

Re: [PATCH 0/4] locks: avoid thundering-herd wake-ups

2018-08-09 Thread NeilBrown
On Thu, Aug 09 2018, J. Bruce Fields wrote: > On Wed, Aug 08, 2018 at 06:50:06PM -0400, Jeff Layton wrote: >> That seems like a legit problem. >> >> One possible fix might be to have the waiter on (1,2) walk down the >> entire subtree and wake up any waiter that is waiting on a lock that >>

Re: [PATCH 0/4] locks: avoid thundering-herd wake-ups

2018-08-09 Thread NeilBrown
On Thu, Aug 09 2018, J. Bruce Fields wrote: > On Wed, Aug 08, 2018 at 06:50:06PM -0400, Jeff Layton wrote: >> That seems like a legit problem. >> >> One possible fix might be to have the waiter on (1,2) walk down the >> entire subtree and wake up any waiter that is waiting on a lock that >>

Re: [PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access

2018-08-09 Thread Julius Werner
Actually, looking at what IO_STRICT_DEVMEM really does, would it really prevent userspace accesses to these areas? Because it seems that it only prevents accesses to areas marked as IORESOURCE_BUSY, and while I can't fully follow how the kernel assigns that, comments suggest that this is only set

Re: [PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access

2018-08-09 Thread Julius Werner
Actually, looking at what IO_STRICT_DEVMEM really does, would it really prevent userspace accesses to these areas? Because it seems that it only prevents accesses to areas marked as IORESOURCE_BUSY, and while I can't fully follow how the kernel assigns that, comments suggest that this is only set

Re: [PATCH v3 6/7] firmware: coreboot: Only populate devices in coreboot_table_init()

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 14:02:53) > On Thu, Aug 9, 2018 at 10:17 AM Stephen Boyd wrote: > > @@ -162,26 +143,37 @@ static int coreboot_table_probe(struct > > platform_device *pdev) > > if (!res->start || !len) > > return -EINVAL; > > > > + /* Map and check

Re: [PATCH v3 6/7] firmware: coreboot: Only populate devices in coreboot_table_init()

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 14:02:53) > On Thu, Aug 9, 2018 at 10:17 AM Stephen Boyd wrote: > > @@ -162,26 +143,37 @@ static int coreboot_table_probe(struct > > platform_device *pdev) > > if (!res->start || !len) > > return -EINVAL; > > > > + /* Map and check

Re: [PATCH 3/5] fs/locks: change all *_conflict() functions to return a new enum.

2018-08-09 Thread NeilBrown
On Thu, Aug 09 2018, J. Bruce Fields wrote: > On Thu, Aug 09, 2018 at 12:04:41PM +1000, NeilBrown wrote: >> In a future patch we will need to differentiate between conflicts that >> are "transitive" and those that aren't. >> A "transitive" conflict is defined as one where any lock that >>

Re: [PATCH 3/5] fs/locks: change all *_conflict() functions to return a new enum.

2018-08-09 Thread NeilBrown
On Thu, Aug 09 2018, J. Bruce Fields wrote: > On Thu, Aug 09, 2018 at 12:04:41PM +1000, NeilBrown wrote: >> In a future patch we will need to differentiate between conflicts that >> are "transitive" and those that aren't. >> A "transitive" conflict is defined as one where any lock that >>

[PATCH RESEND 4/4] HID: multitouch: remove unneeded else conditional cases

2018-08-09 Thread Joey Pabalinas
Elide lone `else` cases and replace `else if` clauses with plain `if` conditionals when they occur immediately after return statements. Signed-off-by: Joey Pabalinas 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index

[PATCH RESEND 4/4] HID: multitouch: remove unneeded else conditional cases

2018-08-09 Thread Joey Pabalinas
Elide lone `else` cases and replace `else if` clauses with plain `if` conditionals when they occur immediately after return statements. Signed-off-by: Joey Pabalinas 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index

[PATCH RESEND 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

2018-08-09 Thread Joey Pabalinas
The firmware found in the touch screen of the Surface Pro 3 is slightly buggy and occasionally doesn't send lift off reports for contacts; add MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed reports. Signed-off-by: Joey Pabalinas 1 file changed, 2 insertions(+), 1

[PATCH RESEND 3/4] HID: multitouch: drop reports containing invalid values

2018-08-09 Thread Joey Pabalinas
Avoid processing reports containing invalid values to reduce multitouch input stutter. Signed-off-by: Joey Pabalinas 1 file changed, 9 insertions(+) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index c0654db0b736543ca0..08b50e5908cecdda66 100644 ---

[PATCH RESEND 0/4] reduce Surface Pro 3 multitouch jitter

2018-08-09 Thread Joey Pabalinas
The Surface Pro 3 firmware doesn't reliably send contact lift off reports nor handle invalid report values gracefully. To reduce touchscreen input jitter: - add MT_QUIRK_NOT_SEEN_MEANS_UP to the MT_CLS_WIN_8 - drop invalid report values Patches have been tested on my personal Surface Pro 3

[PATCH RESEND 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol

2018-08-09 Thread Joey Pabalinas
The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial protocol, so avoid setting `td->serial_maybe = true;` in order to avoid an unnecessary mt_post_parse_default_settings() call Signed-off-by: Joey Pabalinas 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH RESEND 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

2018-08-09 Thread Joey Pabalinas
The firmware found in the touch screen of the Surface Pro 3 is slightly buggy and occasionally doesn't send lift off reports for contacts; add MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed reports. Signed-off-by: Joey Pabalinas 1 file changed, 2 insertions(+), 1

[PATCH RESEND 3/4] HID: multitouch: drop reports containing invalid values

2018-08-09 Thread Joey Pabalinas
Avoid processing reports containing invalid values to reduce multitouch input stutter. Signed-off-by: Joey Pabalinas 1 file changed, 9 insertions(+) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index c0654db0b736543ca0..08b50e5908cecdda66 100644 ---

[PATCH RESEND 0/4] reduce Surface Pro 3 multitouch jitter

2018-08-09 Thread Joey Pabalinas
The Surface Pro 3 firmware doesn't reliably send contact lift off reports nor handle invalid report values gracefully. To reduce touchscreen input jitter: - add MT_QUIRK_NOT_SEEN_MEANS_UP to the MT_CLS_WIN_8 - drop invalid report values Patches have been tested on my personal Surface Pro 3

[PATCH RESEND 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol

2018-08-09 Thread Joey Pabalinas
The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial protocol, so avoid setting `td->serial_maybe = true;` in order to avoid an unnecessary mt_post_parse_default_settings() call Signed-off-by: Joey Pabalinas 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 1/1] staging: fbtft: Removes ";" from very used macro definition.

2018-08-09 Thread Leonardo Brás
All usages of this macro append the ";" at the end of line. It is not recommended nor necessary to append a ";" at the end of this macro definition. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/1] staging: fbtft: Removes ";" from very used macro definition.

2018-08-09 Thread Leonardo Brás
All usages of this macro append the ";" at the end of line. It is not recommended nor necessary to append a ";" at the end of this macro definition. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access

2018-08-09 Thread Julius Werner
> Furthermore, I see that my system RAM excludes this coreboot table so it > doesn't fall into the bucket that CONFIG_STRICT_DEVMEM would find. Yes, that is intentional. We don't want the kernel to try to use that memory for anything else (since we want those tables to survive), so we mark them

Re: [PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access

2018-08-09 Thread Julius Werner
> Furthermore, I see that my system RAM excludes this coreboot table so it > doesn't fall into the bucket that CONFIG_STRICT_DEVMEM would find. Yes, that is intentional. We don't want the kernel to try to use that memory for anything else (since we want those tables to survive), so we mark them

[RFC v7 PATCH 4/4] mm: unmap special vmas with regular do_munmap()

2018-08-09 Thread Yang Shi
Unmapping vmas, which have VM_HUGETLB | VM_PFNMAP flag set or have uprobes set, need get done with write mmap_sem held since they may update vm_flags. So, it might be not safe enough to deal with these kind of special mappings with read mmap_sem. Deal with such mappings with regular do_munmap()

[RFC v7 PATCH 4/4] mm: unmap special vmas with regular do_munmap()

2018-08-09 Thread Yang Shi
Unmapping vmas, which have VM_HUGETLB | VM_PFNMAP flag set or have uprobes set, need get done with write mmap_sem held since they may update vm_flags. So, it might be not safe enough to deal with these kind of special mappings with read mmap_sem. Deal with such mappings with regular do_munmap()

[RFC v7 PATCH 0/4] mm: zap pages with read mmap_sem in munmap for large mapping

2018-08-09 Thread Yang Shi
Background: Recently, when we ran some vm scalability tests on machines with large memory, we ran into a couple of mmap_sem scalability issues when unmapping large memory space, please refer to https://lkml.org/lkml/2017/12/14/733 and https://lkml.org/lkml/2018/2/20/576. History: Then akpm

[RFC v7 PATCH 1/4] mm: refactor do_munmap() to extract the common part

2018-08-09 Thread Yang Shi
Introduces three new helper functions: * addr_ok() * munmap_lookup_vma() * munlock_vmas() They will be used by do_munmap() and the new do_munmap with zapping large mapping early in the later patch. There is no functional change, just code refactor. Reviewed-by: Laurent Dufour

[RFC v7 PATCH 3/4] uprobes: make vma_has_uprobes non-static

2018-08-09 Thread Yang Shi
vma_has_uprobes() will be used in the following patch to check if a vma could be unmapped with holding read mmap_sem, but it is static. So, make it non-static to use outside uprobe. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Jiri Olsa Cc:

[RFC v7 PATCH 0/4] mm: zap pages with read mmap_sem in munmap for large mapping

2018-08-09 Thread Yang Shi
Background: Recently, when we ran some vm scalability tests on machines with large memory, we ran into a couple of mmap_sem scalability issues when unmapping large memory space, please refer to https://lkml.org/lkml/2017/12/14/733 and https://lkml.org/lkml/2018/2/20/576. History: Then akpm

[RFC v7 PATCH 1/4] mm: refactor do_munmap() to extract the common part

2018-08-09 Thread Yang Shi
Introduces three new helper functions: * addr_ok() * munmap_lookup_vma() * munlock_vmas() They will be used by do_munmap() and the new do_munmap with zapping large mapping early in the later patch. There is no functional change, just code refactor. Reviewed-by: Laurent Dufour

[RFC v7 PATCH 3/4] uprobes: make vma_has_uprobes non-static

2018-08-09 Thread Yang Shi
vma_has_uprobes() will be used in the following patch to check if a vma could be unmapped with holding read mmap_sem, but it is static. So, make it non-static to use outside uprobe. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Jiri Olsa Cc:

[RFC v7 PATCH 2/4] mm: mmap: zap pages with read mmap_sem in munmap

2018-08-09 Thread Yang Shi
When running some mmap/munmap scalability tests with large memory (i.e. > 300GB), the below hung task issue may happen occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 "echo 0 >

[RFC v7 PATCH 2/4] mm: mmap: zap pages with read mmap_sem in munmap

2018-08-09 Thread Yang Shi
When running some mmap/munmap scalability tests with large memory (i.e. > 300GB), the below hung task issue may happen occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 "echo 0 >

Re: [PATCH v3 3/7] firmware: coreboot: Make bus registration symmetric

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 11:10:42) > > @@ -138,8 +136,10 @@ int coreboot_table_init(struct device *dev, void > > __iomem *ptr) > > ptr_entry += entry.size; > > } > > > > - if (ret) > > + if (ret) { > > + bus_unregister(_bus_type); > >

Re: [PATCH v3 3/7] firmware: coreboot: Make bus registration symmetric

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 11:10:42) > > @@ -138,8 +136,10 @@ int coreboot_table_init(struct device *dev, void > > __iomem *ptr) > > ptr_entry += entry.size; > > } > > > > - if (ret) > > + if (ret) { > > + bus_unregister(_bus_type); > >

[PATCH 2/2] staging: fbtft: Adds space around "/"

2018-08-09 Thread Leonardo Brás
Kernel coding style recommends a space char around "/". Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 798a8fe98e95..25302ffc4000 100644 ---

[PATCH 2/2] staging: fbtft: Adds space around "/"

2018-08-09 Thread Leonardo Brás
Kernel coding style recommends a space char around "/". Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 798a8fe98e95..25302ffc4000 100644 ---

[PATCH 1/2] staging: fbtft: Moves ";" from macro definition to macro usage.

2018-08-09 Thread Leonardo Brás
This makes the macro usage more like a function declaration. Also, ending a macro definition with ";" is not recommended by checkpatch.pl. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-bus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 1/2] staging: fbtft: Moves ";" from macro definition to macro usage.

2018-08-09 Thread Leonardo Brás
This makes the macro usage more like a function declaration. Also, ending a macro definition with ";" is not recommended by checkpatch.pl. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-bus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 5/5] fs/locks: create a tree of dependent requests.

2018-08-09 Thread NeilBrown
On Thu, Aug 09 2018, Jeff Layton wrote: > On Thu, 2018-08-09 at 12:04 +1000, NeilBrown wrote: >> When we find an existing lock which conflicts with a request, >> and the request wants to wait, we currently add the request >> to a list. When the lock is removed, the whole list is woken. >> This

Re: [PATCH 5/5] fs/locks: create a tree of dependent requests.

2018-08-09 Thread NeilBrown
On Thu, Aug 09 2018, Jeff Layton wrote: > On Thu, 2018-08-09 at 12:04 +1000, NeilBrown wrote: >> When we find an existing lock which conflicts with a request, >> and the request wants to wait, we currently add the request >> to a list. When the lock is removed, the whole list is woken. >> This

Re: [PATCH v3 2/7] firmware: coreboot: Unmap ioregion on failure

2018-08-09 Thread Stephen Boyd
Quoting Brian Norris (2018-08-09 12:52:13) > Hi, > > On Thu, Aug 09, 2018 at 12:40:31PM -0700, Stephen Boyd wrote: > > Quoting Brian Norris (2018-08-09 10:49:38) > > > On Thu, Aug 09, 2018 at 10:17:17AM -0700, Stephen Boyd wrote: > > > > Both callers of coreboot_table_init() ioremap the pointer

Re: [PATCH v3 2/7] firmware: coreboot: Unmap ioregion on failure

2018-08-09 Thread Stephen Boyd
Quoting Brian Norris (2018-08-09 12:52:13) > Hi, > > On Thu, Aug 09, 2018 at 12:40:31PM -0700, Stephen Boyd wrote: > > Quoting Brian Norris (2018-08-09 10:49:38) > > > On Thu, Aug 09, 2018 at 10:17:17AM -0700, Stephen Boyd wrote: > > > > Both callers of coreboot_table_init() ioremap the pointer

Bank transactions report

2018-08-09 Thread BMC
CONGRATULATIONS 2018 BMC Q-DRAFT CONSULT AWARDEES THE NASSCOM SERVICE BMC Q-DRAFT CONSULT PROGRAM RECOGNIZES THE TOP INDIVIDUAL CONTRIBUTORS IN SURVEY SERVICE ONLINE COMMUNITY. THE NASSCOM BMC Q-DRAFT CONSULT ARE WELL KNOWN BY THE WORLDS COLLECTIVE COMMUNITY FOR THEIR PRODUCT EXPERTISE AND

Bank transactions report

2018-08-09 Thread BMC
CONGRATULATIONS 2018 BMC Q-DRAFT CONSULT AWARDEES THE NASSCOM SERVICE BMC Q-DRAFT CONSULT PROGRAM RECOGNIZES THE TOP INDIVIDUAL CONTRIBUTORS IN SURVEY SERVICE ONLINE COMMUNITY. THE NASSCOM BMC Q-DRAFT CONSULT ARE WELL KNOWN BY THE WORLDS COLLECTIVE COMMUNITY FOR THEIR PRODUCT EXPERTISE AND

Re: [PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 14:07:31) > On Thu, Aug 9, 2018 at 10:17 AM Stephen Boyd wrote: > > > > Call request_mem_region() on the entire coreboot table to make sure > > other devices don't attempt to map the coreboot table in their drivers. > > If drivers need that support, it would be

Re: [PATCH v8 0/4] Add parameter for disabling ACS redirection for P2P

2018-08-09 Thread Bjorn Helgaas
On Mon, Jul 30, 2018 at 10:18:36AM -0600, Logan Gunthorpe wrote: > Changes since v6: > * Fixed order of operations for device specific disable function as > noticed by Alex > * Rebased onto v4.18-rc5 (no conflicts) > > Changes since v5: > * Add a quirk to handle the Intel SPT PCH case (as

Re: [PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 14:07:31) > On Thu, Aug 9, 2018 at 10:17 AM Stephen Boyd wrote: > > > > Call request_mem_region() on the entire coreboot table to make sure > > other devices don't attempt to map the coreboot table in their drivers. > > If drivers need that support, it would be

Re: [PATCH v8 0/4] Add parameter for disabling ACS redirection for P2P

2018-08-09 Thread Bjorn Helgaas
On Mon, Jul 30, 2018 at 10:18:36AM -0600, Logan Gunthorpe wrote: > Changes since v6: > * Fixed order of operations for device specific disable function as > noticed by Alex > * Rebased onto v4.18-rc5 (no conflicts) > > Changes since v5: > * Add a quirk to handle the Intel SPT PCH case (as

[PATCH v3 1/2] RISC-V: Define sys_riscv_flush_icache when SMP=n

2018-08-09 Thread Palmer Dabbelt
This would be necessary to make non-SMP builds work, but there is another error in the implementation of our syscall linkage that actually just causes sys_riscv_flush_icache to never build. I've build tested this on allnoconfig and allnoconfig+SMP=y, as well as defconfig like normal. CC:

[PATCH v3 2/3] staging: fbtft: Replaces (1 << n) for macro BIT(n) - Style

2018-08-09 Thread Leonardo Brás
Use of default macro BIT(n) instead of (1 << n). Helps readability. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h

[PATCH v3 3/3] staging: fbtft: Corrects long index line - Style

2018-08-09 Thread Leonardo Brás
Reduces the index size to keep the code more readable. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-sysfs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index

[PATCH v3 1/2] RISC-V: Define sys_riscv_flush_icache when SMP=n

2018-08-09 Thread Palmer Dabbelt
This would be necessary to make non-SMP builds work, but there is another error in the implementation of our syscall linkage that actually just causes sys_riscv_flush_icache to never build. I've build tested this on allnoconfig and allnoconfig+SMP=y, as well as defconfig like normal. CC:

[PATCH v3 2/3] staging: fbtft: Replaces (1 << n) for macro BIT(n) - Style

2018-08-09 Thread Leonardo Brás
Use of default macro BIT(n) instead of (1 << n). Helps readability. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/fbtft/fbtft.h

[PATCH v3 3/3] staging: fbtft: Corrects long index line - Style

2018-08-09 Thread Leonardo Brás
Reduces the index size to keep the code more readable. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-sysfs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index

[PATCH v3 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h

2018-08-09 Thread Palmer Dabbelt
This file is expected to be included multiple times in the same file in order to allow the __SYSCALL macro to generate system call tables. With a global include guard we end up missing __NR_riscv_flush_icache in the syscall table, which results in icache flushes that escape the vDSO call to not

[PATCH v3 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h

2018-08-09 Thread Palmer Dabbelt
This file is expected to be included multiple times in the same file in order to allow the __SYSCALL macro to generate system call tables. With a global include guard we end up missing __NR_riscv_flush_icache in the syscall table, which results in icache flushes that escape the vDSO call to not

RISC-V: Don't use a global include guard for uapi/asm/syscalls.

2018-08-09 Thread Palmer Dabbelt
It turns out that we weren't actually hooking sys_riscv_flush_icache into the syscall table, which results in any flush_icache() call that escapes the vDSO to silently do nothing. Changes since v2: * sys_riscv_flush_icache actually flushes the icache when SMP=n. Thanks to Andrew for pointing

RISC-V: Don't use a global include guard for uapi/asm/syscalls.

2018-08-09 Thread Palmer Dabbelt
It turns out that we weren't actually hooking sys_riscv_flush_icache into the syscall table, which results in any flush_icache() call that escapes the vDSO to silently do nothing. Changes since v2: * sys_riscv_flush_icache actually flushes the icache when SMP=n. Thanks to Andrew for pointing

[PATCH v3 0/3] Style changes

2018-08-09 Thread Leonardo Brás
Some style changes to help readability. Leonardo Brás (3): staging: fbtft: Includes description to mutex and spinlock - Style staging: fbtft: Replaces (1 << n) for macro BIT(n) - Style staging: fbtft: Corrects long index line - Style drivers/staging/fbtft/fbtft-sysfs.c | 5 ++-

[PATCH v3 0/3] Style changes

2018-08-09 Thread Leonardo Brás
Some style changes to help readability. Leonardo Brás (3): staging: fbtft: Includes description to mutex and spinlock - Style staging: fbtft: Replaces (1 << n) for macro BIT(n) - Style staging: fbtft: Corrects long index line - Style drivers/staging/fbtft/fbtft-sysfs.c | 5 ++-

<    1   2   3   4   5   6   7   8   9   10   >