RE: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-08-20 Thread Naga Sureshkumar Relli
Hi Boris, > -Original Message- > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > Sent: Monday, August 20, 2018 6:03 PM > To: Naga Sureshkumar Relli > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > computersforpe...@gmail.com; marek.va...@gmail.com;

RE: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-08-20 Thread Naga Sureshkumar Relli
Hi Boris, > -Original Message- > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > Sent: Monday, August 20, 2018 6:03 PM > To: Naga Sureshkumar Relli > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > computersforpe...@gmail.com; marek.va...@gmail.com;

Re: Enumeration issue with QCA9005 AR9462

2018-08-20 Thread Lukas Wunner
On Mon, Aug 20, 2018 at 06:06:24PM -0500, Bjorn Helgaas wrote: > mmyan...@gmail.com reported a problem [1]: on v4.17, a QCA9005 AR9462 > wifi device was present at boot, but disappeared after suspend/resume. > > He also tested a recent kernel (5c60a7389d79, from Thu Aug 16), > where the

Re: Enumeration issue with QCA9005 AR9462

2018-08-20 Thread Lukas Wunner
On Mon, Aug 20, 2018 at 06:06:24PM -0500, Bjorn Helgaas wrote: > mmyan...@gmail.com reported a problem [1]: on v4.17, a QCA9005 AR9462 > wifi device was present at boot, but disappeared after suspend/resume. > > He also tested a recent kernel (5c60a7389d79, from Thu Aug 16), > where the

Re: [PATCH] scripts/dtc: consolidate include path options in Makefile

2018-08-20 Thread Frank Rowand
On 08/20/18 19:08, Masahiro Yamada wrote: > Hi Frank, > > 2018-08-21 10:31 GMT+09:00 Frank Rowand : >> On 08/20/18 14:32, Rob Herring wrote: >>> On Mon, Aug 20, 2018 at 1:55 PM Frank Rowand wrote: On 07/03/18 18:59, Masahiro Yamada wrote: > It is tedious to specify extra compiler

Re: [PATCH] scripts/dtc: consolidate include path options in Makefile

2018-08-20 Thread Frank Rowand
On 08/20/18 19:08, Masahiro Yamada wrote: > Hi Frank, > > 2018-08-21 10:31 GMT+09:00 Frank Rowand : >> On 08/20/18 14:32, Rob Herring wrote: >>> On Mon, Aug 20, 2018 at 1:55 PM Frank Rowand wrote: On 07/03/18 18:59, Masahiro Yamada wrote: > It is tedious to specify extra compiler

Re: [PATCH] PCI: dwc: fix scheduling while atomic issues

2018-08-20 Thread kbuild test robot
Hi Jisheng, I love your patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on v4.18 next-20180820] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH] PCI: dwc: fix scheduling while atomic issues

2018-08-20 Thread kbuild test robot
Hi Jisheng, I love your patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on v4.18 next-20180820] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH v9 0/4] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-20 Thread Ravi Bangoria
Hi Song, > However, if I start a.out AFTER enabling the uprobe, there is something wrong: > > root@virt-test:~# ~/a.out > 11 > semaphore 0 <<< this should be non-zero, as the uprobe is already > enabled Ok. I'm able to reproduce this. Digging deeper. Ravi

Re: [PATCH v9 0/4] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-20 Thread Ravi Bangoria
Hi Song, > However, if I start a.out AFTER enabling the uprobe, there is something wrong: > > root@virt-test:~# ~/a.out > 11 > semaphore 0 <<< this should be non-zero, as the uprobe is already > enabled Ok. I'm able to reproduce this. Digging deeper. Ravi

Re: [PATCH] staging: android: ion: check for kref overflow

2018-08-20 Thread Greg Kroah-Hartman
On Mon, Aug 20, 2018 at 06:30:57PM -0700, Daniel Rosenberg wrote: > Userspace can cause the kref to handles to increment > arbitrarily high. Ensure it does not overflow. > > Signed-off-by: Daniel Rosenberg > --- > > This patch is against 4.4. It does not apply to master due to a large > rework

Re: [PATCH] staging: android: ion: check for kref overflow

2018-08-20 Thread Greg Kroah-Hartman
On Mon, Aug 20, 2018 at 06:30:57PM -0700, Daniel Rosenberg wrote: > Userspace can cause the kref to handles to increment > arbitrarily high. Ensure it does not overflow. > > Signed-off-by: Daniel Rosenberg > --- > > This patch is against 4.4. It does not apply to master due to a large > rework

Re: [PATCH RFC] mm: don't miss the last page because of round-off error

2018-08-20 Thread Konstantin Khlebnikov
On Sat, Aug 18, 2018 at 4:22 AM, Matthew Wilcox wrote: > On Fri, Aug 17, 2018 at 04:18:34PM -0700, Roman Gushchin wrote: >> - scan = div64_u64(scan * fraction[file], >> - denominator); >> + if (scan > 1) >> +

Re: [PATCH RFC] mm: don't miss the last page because of round-off error

2018-08-20 Thread Konstantin Khlebnikov
On Sat, Aug 18, 2018 at 4:22 AM, Matthew Wilcox wrote: > On Fri, Aug 17, 2018 at 04:18:34PM -0700, Roman Gushchin wrote: >> - scan = div64_u64(scan * fraction[file], >> - denominator); >> + if (scan > 1) >> +

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-20 Thread NeilBrown
On Thu, Aug 16 2018, NeilBrown wrote: > On Wed, Aug 15 2018, Jeff Layton wrote: > >> On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: >>> Hi, >>> >>> Bisect pointed commit ce3147990450a68b3f549088b30f087742a08b5d >>> ("fs/locks: allow a lock request to block other requests.") to

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-20 Thread NeilBrown
On Thu, Aug 16 2018, NeilBrown wrote: > On Wed, Aug 15 2018, Jeff Layton wrote: > >> On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: >>> Hi, >>> >>> Bisect pointed commit ce3147990450a68b3f549088b30f087742a08b5d >>> ("fs/locks: allow a lock request to block other requests.") to

Re: [PATCH] kobject: Access kobject name with caution if state is not initialized

2018-08-20 Thread Srikar Dronamraju
* Greg Kroah-Hartman [2018-08-20 21:22:47]: > On Mon, Aug 20, 2018 at 10:39:47PM +0530, Srikar Dronamraju wrote: > > A stupid module test like > > https://github.com/srikard/tests/blob/master/modules/kobject_test.c > > can panic the system. > > Lots of stupid modules can do dumb things. Just

Re: [PATCH] kobject: Access kobject name with caution if state is not initialized

2018-08-20 Thread Srikar Dronamraju
* Greg Kroah-Hartman [2018-08-20 21:22:47]: > On Mon, Aug 20, 2018 at 10:39:47PM +0530, Srikar Dronamraju wrote: > > A stupid module test like > > https://github.com/srikard/tests/blob/master/modules/kobject_test.c > > can panic the system. > > Lots of stupid modules can do dumb things. Just

Re: [PATCH v9 0/4] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-20 Thread Song Liu
On Mon, Aug 20, 2018 at 9:42 PM, Ravi Bangoria wrote: > Hi Song, > >> root@virt-test:~# ~/a.out >> 11 >> semaphore 0 >> semaphore 0 >> semaphore 2 <<< when the uprobe is enabled > > Yes, this happens when multiple vmas points to the same file portion. > Can you check /proc/`pgrep

Re: [PATCH v9 0/4] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-20 Thread Song Liu
On Mon, Aug 20, 2018 at 9:42 PM, Ravi Bangoria wrote: > Hi Song, > >> root@virt-test:~# ~/a.out >> 11 >> semaphore 0 >> semaphore 0 >> semaphore 2 <<< when the uprobe is enabled > > Yes, this happens when multiple vmas points to the same file portion. > Can you check /proc/`pgrep

Re: [PATCH v9 0/4] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-20 Thread Ravi Bangoria
Hi Song, > root@virt-test:~# ~/a.out > 11 > semaphore 0 > semaphore 0 > semaphore 2 <<< when the uprobe is enabled Yes, this happens when multiple vmas points to the same file portion. Can you check /proc/`pgrep a.out`/maps. Logic is simple. If we are going to patch an instruction,

Re: [PATCH v9 0/4] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-20 Thread Ravi Bangoria
Hi Song, > root@virt-test:~# ~/a.out > 11 > semaphore 0 > semaphore 0 > semaphore 2 <<< when the uprobe is enabled Yes, this happens when multiple vmas points to the same file portion. Can you check /proc/`pgrep a.out`/maps. Logic is simple. If we are going to patch an instruction,

Re: linux-next: Signed-off-by missing for commit in the cifs tree

2018-08-20 Thread Steve French
fixed On Mon, Aug 20, 2018 at 11:18 PM Stephen Rothwell wrote: > > Hi all, > > Commit > > eacb610d8fc4 ("cifs: create a define for how many iovs we need for an > SMB2_open()") > > is missing a Signed-off-by from its committer. > > -- > Cheers, > Stephen Rothwell -- Thanks, Steve

Re: linux-next: Signed-off-by missing for commit in the cifs tree

2018-08-20 Thread Steve French
fixed On Mon, Aug 20, 2018 at 11:18 PM Stephen Rothwell wrote: > > Hi all, > > Commit > > eacb610d8fc4 ("cifs: create a define for how many iovs we need for an > SMB2_open()") > > is missing a Signed-off-by from its committer. > > -- > Cheers, > Stephen Rothwell -- Thanks, Steve

linux-next: Signed-off-by missing for commit in the cifs tree

2018-08-20 Thread Stephen Rothwell
Hi all, Commit eacb610d8fc4 ("cifs: create a define for how many iovs we need for an SMB2_open()") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpol1tOxkm1O.pgp Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the cifs tree

2018-08-20 Thread Stephen Rothwell
Hi all, Commit eacb610d8fc4 ("cifs: create a define for how many iovs we need for an SMB2_open()") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpol1tOxkm1O.pgp Description: OpenPGP digital signature

linux-next: Tree for Aug 21

2018-08-20 Thread Stephen Rothwell
Hi all, Please do not add any v4.20 material to your linux-next included branches until after v4.19-rc1 has been released. Changes since 20180820: The xarray tree gained a conflict against the nvdimm tree. Non-merge commits (relative to Linus' tree): 2411 2504 files changed, 95839 insertions

linux-next: Tree for Aug 21

2018-08-20 Thread Stephen Rothwell
Hi all, Please do not add any v4.20 material to your linux-next included branches until after v4.19-rc1 has been released. Changes since 20180820: The xarray tree gained a conflict against the nvdimm tree. Non-merge commits (relative to Linus' tree): 2411 2504 files changed, 95839 insertions

Re: [Skiboot] [PATCH] opal/hmi: Wakeup the cpu before reading core_fir

2018-08-20 Thread Nicholas Piggin
On Mon, 20 Aug 2018 19:36:05 +0530 Vaibhav Jain wrote: > When stop state 5 is enabled, reading the core_fir during an HMI can > result in a xscom read error with xscom_read() returning the > OPAL_XSCOM_PARTIAL_GOOD error code and core_fir value of all FFs. At > present this return error code is

Re: [Skiboot] [PATCH] opal/hmi: Wakeup the cpu before reading core_fir

2018-08-20 Thread Nicholas Piggin
On Mon, 20 Aug 2018 19:36:05 +0530 Vaibhav Jain wrote: > When stop state 5 is enabled, reading the core_fir during an HMI can > result in a xscom read error with xscom_read() returning the > OPAL_XSCOM_PARTIAL_GOOD error code and core_fir value of all FFs. At > present this return error code is

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-20 Thread Liang Yang
Hi Boris, On 8/17/2018 9:56 PM, Boris Brezillon wrote: On Fri, 17 Aug 2018 21:03:59 +0800 Liang Yang wrote: Hi Boris, On 2018/8/2 5:50, Boris Brezillon wrote: Hi Yixun, On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: I haven't finished reviewing the driver yet (I'll try to do that

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-20 Thread Liang Yang
Hi Boris, On 8/17/2018 9:56 PM, Boris Brezillon wrote: On Fri, 17 Aug 2018 21:03:59 +0800 Liang Yang wrote: Hi Boris, On 2018/8/2 5:50, Boris Brezillon wrote: Hi Yixun, On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: I haven't finished reviewing the driver yet (I'll try to do that

[PATCH] ubifs: remove unnecessary check in ubifs_log_start_commit

2018-08-20 Thread Liu Song
The value of c->lhead_offs cannot exceed max_len which much smaller than c->leb_size. So the check will never be true. Just remove it. Signed-off-by: Liu Song Reviewed-by: Jiang Biao --- fs/ubifs/log.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/ubifs/log.c b/fs/ubifs/log.c index

[PATCH] ubifs: remove unnecessary check in ubifs_log_start_commit

2018-08-20 Thread Liu Song
The value of c->lhead_offs cannot exceed max_len which much smaller than c->leb_size. So the check will never be true. Just remove it. Signed-off-by: Liu Song Reviewed-by: Jiang Biao --- fs/ubifs/log.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/ubifs/log.c b/fs/ubifs/log.c index

Re: [PATCH v9 1/2] kbuild: Allow arch-specific asm/compiler.h

2018-08-20 Thread Masahiro Yamada
Hi Paul, The code diff looks good to me. Reviewed-by: Masahiro Yamada Just comments in the commit description. See below. 2018-08-21 7:36 GMT+09:00 Paul Burton : > We have a need to override the definition of > barrier_before_unreachable() for MIPS, which means we either need to add >

Re: [PATCH v9 1/2] kbuild: Allow arch-specific asm/compiler.h

2018-08-20 Thread Masahiro Yamada
Hi Paul, The code diff looks good to me. Reviewed-by: Masahiro Yamada Just comments in the commit description. See below. 2018-08-21 7:36 GMT+09:00 Paul Burton : > We have a need to override the definition of > barrier_before_unreachable() for MIPS, which means we either need to add >

[PATCH] PCI: dwc: fix scheduling while atomic issues

2018-08-20 Thread Jisheng Zhang
When programming inbound/outbound atu, we call usleep_range() after each checking PCIE_ATU_ENABLE bit. Unfortunately, the atu programming can be called in atomic context: inbound atu programming could be called through pci_epc_write_header() =>dw_pcie_ep_write_header()

[PATCH] PCI: dwc: fix scheduling while atomic issues

2018-08-20 Thread Jisheng Zhang
When programming inbound/outbound atu, we call usleep_range() after each checking PCIE_ATU_ENABLE bit. Unfortunately, the atu programming can be called in atomic context: inbound atu programming could be called through pci_epc_write_header() =>dw_pcie_ep_write_header()

Re: [PATCH v4 3/5] Cleanup ISA string setting

2018-08-20 Thread Alan Kao
On Mon, Aug 20, 2018 at 03:22:55PM -0700, Palmer Dabbelt wrote: > On Tue, 07 Aug 2018 20:24:43 PDT (-0700), alan...@andestech.com wrote: > >Just a side note: (Assume that atomic and compressed is on) > > > >Before this patch, assembler was always given the riscv64imafdc > >MARCH string because

Re: [PATCH v4 3/5] Cleanup ISA string setting

2018-08-20 Thread Alan Kao
On Mon, Aug 20, 2018 at 03:22:55PM -0700, Palmer Dabbelt wrote: > On Tue, 07 Aug 2018 20:24:43 PDT (-0700), alan...@andestech.com wrote: > >Just a side note: (Assume that atomic and compressed is on) > > > >Before this patch, assembler was always given the riscv64imafdc > >MARCH string because

Re: [PATCH] scripts/dtc: consolidate include path options in Makefile

2018-08-20 Thread Masahiro Yamada
Hi Frank, 2018-08-21 10:31 GMT+09:00 Frank Rowand : > On 08/20/18 14:32, Rob Herring wrote: >> On Mon, Aug 20, 2018 at 1:55 PM Frank Rowand wrote: >>> >>> On 07/03/18 18:59, Masahiro Yamada wrote: It is tedious to specify extra compiler options for every file. HOST_EXTRACFLAGS is

Re: [PATCH] scripts/dtc: consolidate include path options in Makefile

2018-08-20 Thread Masahiro Yamada
Hi Frank, 2018-08-21 10:31 GMT+09:00 Frank Rowand : > On 08/20/18 14:32, Rob Herring wrote: >> On Mon, Aug 20, 2018 at 1:55 PM Frank Rowand wrote: >>> >>> On 07/03/18 18:59, Masahiro Yamada wrote: It is tedious to specify extra compiler options for every file. HOST_EXTRACFLAGS is

Re: [PATCH] nios2: kconfig: remove duplicate DEBUG_STACK_USAGE symbol defintions

2018-08-20 Thread Ley Foon Tan
On Tue, 2018-08-21 at 01:15 +0900, Masahiro Yamada wrote: > 2018-08-16 16:05 GMT+09:00 Tobias Klauser : > > > > DEBUG_STACK_USAGE is already defined in lib/Kconfig.debug > > > > Signed-off-by: Tobias Klauser > > Reviewed-by: Masahiro Yamada > Acked-by: Ley Foon Tan > > > > > --- > >  

Re: [PATCH] nios2: kconfig: remove duplicate DEBUG_STACK_USAGE symbol defintions

2018-08-20 Thread Ley Foon Tan
On Tue, 2018-08-21 at 01:15 +0900, Masahiro Yamada wrote: > 2018-08-16 16:05 GMT+09:00 Tobias Klauser : > > > > DEBUG_STACK_USAGE is already defined in lib/Kconfig.debug > > > > Signed-off-by: Tobias Klauser > > Reviewed-by: Masahiro Yamada > Acked-by: Ley Foon Tan > > > > > --- > >  

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-20 Thread Wolfram Sang
Linus, > Wolfram, should I just take that patch as-is and get rid of the > deprecated atach_adapter thing, or will you send me a pull request? I'll send you a pull request. Thanks, Wolfram signature.asc Description: PGP signature

Re: [PATCH v2] i2c: Remove '-Wno-deprecated-declarations' compiler warning

2018-08-20 Thread Wolfram Sang
Linus, > Wolfram, should I just take that patch as-is and get rid of the > deprecated atach_adapter thing, or will you send me a pull request? I'll send you a pull request. Thanks, Wolfram signature.asc Description: PGP signature

Re: [PATCH] locking: Remove an insn from spin and write locks

2018-08-20 Thread Will Deacon
On Mon, Aug 20, 2018 at 09:26:39AM -0700, Matthew Wilcox wrote: > On Mon, Aug 20, 2018 at 05:56:50PM +0200, Peter Zijlstra wrote: > > Yeah, _acquire should be retained; sorry about loosing that. I'm neck > > deep into tlb invalidate stuff and wrote this without much thinking > > involved. > > NP.

Re: [PATCH] locking: Remove an insn from spin and write locks

2018-08-20 Thread Will Deacon
On Mon, Aug 20, 2018 at 09:26:39AM -0700, Matthew Wilcox wrote: > On Mon, Aug 20, 2018 at 05:56:50PM +0200, Peter Zijlstra wrote: > > Yeah, _acquire should be retained; sorry about loosing that. I'm neck > > deep into tlb invalidate stuff and wrote this without much thinking > > involved. > > NP.

linux-next: manual merge of the xarray tree with the nvdimm tree

2018-08-20 Thread Stephen Rothwell
Hi Matthew, Today's linux-next merge of the xarray tree got a conflict in: mm/memory-failure.c between commit: 6100e34b2526 ("mm, memory_failure: Teach memory_failure() about dev_pagemap pages") from the nvdimm tree and commit: 0c2b437d7e2b ("mm, memory_failure: Teach memory_failure()

linux-next: manual merge of the xarray tree with the nvdimm tree

2018-08-20 Thread Stephen Rothwell
Hi Matthew, Today's linux-next merge of the xarray tree got a conflict in: mm/memory-failure.c between commit: 6100e34b2526 ("mm, memory_failure: Teach memory_failure() about dev_pagemap pages") from the nvdimm tree and commit: 0c2b437d7e2b ("mm, memory_failure: Teach memory_failure()

[PATCH] staging: rtl8188eu: Fix spelling mistake

2018-08-20 Thread Bhaskar Singh
This patch fix spelling mistakes in TODO. Signed-off-by: Bhaskar Singh --- drivers/staging/rtl8188eu/TODO | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/TODO b/drivers/staging/rtl8188eu/TODO index 7581e25f231d..5faa0a9bba25 100644 ---

[PATCH] staging: rtl8188eu: Fix spelling mistake

2018-08-20 Thread Bhaskar Singh
This patch fix spelling mistakes in TODO. Signed-off-by: Bhaskar Singh --- drivers/staging/rtl8188eu/TODO | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/TODO b/drivers/staging/rtl8188eu/TODO index 7581e25f231d..5faa0a9bba25 100644 ---

[PATCH v2] staging: rtl8188eu: Removed code valid for 5GHz

2018-08-20 Thread Bhaskar Singh
This patch removes support for channels > 14. That is from the TODO which says: -find and remove remaining code valid only for 5HGz. Most of obvious ones have been removed, but things like channel > 14 still exist. Signed-off-by: Bhaskar Singh --- Changes in v2: - Make

[PATCH v2] staging: rtl8188eu: Removed code valid for 5GHz

2018-08-20 Thread Bhaskar Singh
This patch removes support for channels > 14. That is from the TODO which says: -find and remove remaining code valid only for 5HGz. Most of obvious ones have been removed, but things like channel > 14 still exist. Signed-off-by: Bhaskar Singh --- Changes in v2: - Make

[PATCH] staging: android: ion: check for kref overflow

2018-08-20 Thread Daniel Rosenberg
Userspace can cause the kref to handles to increment arbitrarily high. Ensure it does not overflow. Signed-off-by: Daniel Rosenberg --- This patch is against 4.4. It does not apply to master due to a large rework of ion in 4.12 which removed the affected functions altogther. It applies from

[PATCH] staging: android: ion: check for kref overflow

2018-08-20 Thread Daniel Rosenberg
Userspace can cause the kref to handles to increment arbitrarily high. Ensure it does not overflow. Signed-off-by: Daniel Rosenberg --- This patch is against 4.4. It does not apply to master due to a large rework of ion in 4.12 which removed the affected functions altogther. It applies from

Re: [PATCH] scripts/dtc: consolidate include path options in Makefile

2018-08-20 Thread Frank Rowand
On 08/20/18 14:32, Rob Herring wrote: > On Mon, Aug 20, 2018 at 1:55 PM Frank Rowand wrote: >> >> On 07/03/18 18:59, Masahiro Yamada wrote: >>> It is tedious to specify extra compiler options for every file. >>> HOST_EXTRACFLAGS is useful to add options to all files in a >>> directory. >>> >>>

Re: [PATCH] scripts/dtc: consolidate include path options in Makefile

2018-08-20 Thread Frank Rowand
On 08/20/18 14:32, Rob Herring wrote: > On Mon, Aug 20, 2018 at 1:55 PM Frank Rowand wrote: >> >> On 07/03/18 18:59, Masahiro Yamada wrote: >>> It is tedious to specify extra compiler options for every file. >>> HOST_EXTRACFLAGS is useful to add options to all files in a >>> directory. >>> >>>

[PATCH] ufs: remove set but not used variable 'usb3'

2018-08-20 Thread Yue Haibing
Fixes gcc '-Wunused-but-set-variable' warning: fs/ufs/super.c: In function 'ufs_statfs': fs/ufs/super.c:1409:32: warning: variable 'usb3' set but not used [-Wunused-but-set-variable] struct ufs_super_block_third *usb3; ^ Signed-off-by: Yue Haibing ---

[PATCH] ufs: remove set but not used variable 'usb3'

2018-08-20 Thread Yue Haibing
Fixes gcc '-Wunused-but-set-variable' warning: fs/ufs/super.c: In function 'ufs_statfs': fs/ufs/super.c:1409:32: warning: variable 'usb3' set but not used [-Wunused-but-set-variable] struct ufs_super_block_third *usb3; ^ Signed-off-by: Yue Haibing ---

[PATCH v3 4/5] x86/mm: optimize static_protection() by using overlap()

2018-08-20 Thread Bin Yang
When changing a 4K page attr inside the large page range, try_preserve_large_page() will call static_protections() to check all 4K pages inside the large page range. In the worst case, when changing a 4K page attr inside 1G large page range, static_protections() will be called for 262144 times

[PATCH v3 4/5] x86/mm: optimize static_protection() by using overlap()

2018-08-20 Thread Bin Yang
When changing a 4K page attr inside the large page range, try_preserve_large_page() will call static_protections() to check all 4K pages inside the large page range. In the worst case, when changing a 4K page attr inside 1G large page range, static_protections() will be called for 262144 times

[PATCH v3 2/5] x86/mm: avoid static_protection() checking if not whole large page attr change

2018-08-20 Thread Bin Yang
The range check whether the address is aligned to the large page and covers the full large page (1G or 2M) is obvious to do _before_ static_protection() check, because if the requested range does not fit and has a different pgprot_val() then it will decide to split after the check anyway. The

[PATCH v3 3/5] x86/mm: add help function to check specific protection flags in range

2018-08-20 Thread Bin Yang
Introduce the needs_static_protections() helper to check specific protection flags in range. It calls static_protection() to check whether any part of the address/len range is forced to change from 'prot'. Suggested-by: Dave Hansen Signed-off-by: Bin Yang --- arch/x86/mm/pageattr.c | 36

[PATCH v3 2/5] x86/mm: avoid static_protection() checking if not whole large page attr change

2018-08-20 Thread Bin Yang
The range check whether the address is aligned to the large page and covers the full large page (1G or 2M) is obvious to do _before_ static_protection() check, because if the requested range does not fit and has a different pgprot_val() then it will decide to split after the check anyway. The

[PATCH v3 3/5] x86/mm: add help function to check specific protection flags in range

2018-08-20 Thread Bin Yang
Introduce the needs_static_protections() helper to check specific protection flags in range. It calls static_protection() to check whether any part of the address/len range is forced to change from 'prot'. Suggested-by: Dave Hansen Signed-off-by: Bin Yang --- arch/x86/mm/pageattr.c | 36

[PATCH v3 1/5] x86/mm: avoid redundant checking if pgprot has no change

2018-08-20 Thread Bin Yang
In try_preserve_large_page(), the check for pgprot_val(new_prot) == pgprot_val(old_port) can definitely be done at first to avoid redundant checking. The approach and some of the comments came from Thomas Gleixner's email example for how to do this Suggested-by: Thomas Gleixner Signed-off-by:

[PATCH v3 0/5] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-08-20 Thread Bin Yang
One problem is found when optimizing the x86 kernel boot time, that sometimes the free_initmem() will take about 600ms, which is way too much for fast boot. When changing a 4K page attr inside the large page range, __change_page_attr() will call try_preserve_large_page() to decide to split the

[PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-08-20 Thread Bin Yang
If there is a large page which contains an area which requires a different mapping that the one which the large page provides, then something went wrong _before_ this code is called. Here we can catch a case where the existing mapping is wrong already. Inspired-by: Thomas Gleixner

[PATCH v3 1/5] x86/mm: avoid redundant checking if pgprot has no change

2018-08-20 Thread Bin Yang
In try_preserve_large_page(), the check for pgprot_val(new_prot) == pgprot_val(old_port) can definitely be done at first to avoid redundant checking. The approach and some of the comments came from Thomas Gleixner's email example for how to do this Suggested-by: Thomas Gleixner Signed-off-by:

[PATCH v3 0/5] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-08-20 Thread Bin Yang
One problem is found when optimizing the x86 kernel boot time, that sometimes the free_initmem() will take about 600ms, which is way too much for fast boot. When changing a 4K page attr inside the large page range, __change_page_attr() will call try_preserve_large_page() to decide to split the

[PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping

2018-08-20 Thread Bin Yang
If there is a large page which contains an area which requires a different mapping that the one which the large page provides, then something went wrong _before_ this code is called. Here we can catch a case where the existing mapping is wrong already. Inspired-by: Thomas Gleixner

[PATCH v2] staging: rtl8188eu: Removed a function and coded inline

2018-08-20 Thread Bhaskar Singh
This patch removed function named rtw_malloc2d. I removed this function because this function is used exactly once and function call have some overhead also. Maybe this will improve code runtime slightly. Signed-off-by: Bhaskar Singh --- Changes in v2: - Incorporated comments from Dan

[PATCH v2] staging: rtl8188eu: Removed a function and coded inline

2018-08-20 Thread Bhaskar Singh
This patch removed function named rtw_malloc2d. I removed this function because this function is used exactly once and function call have some overhead also. Maybe this will improve code runtime slightly. Signed-off-by: Bhaskar Singh --- Changes in v2: - Incorporated comments from Dan

[PATCH v2] mtd/ubi: Make sure to read volume record from LEB 0 or LEB 1

2018-08-20 Thread Liu Song
Even though we protect on-flash data by CRC checksums, we still don't trust the media. If lnum is not 0 or 1, access exceed array boundary can lead to bad situation. Signed-off-by: Liu Song Reviewed-by: Jiang Biao --- v2: fix the name in *From*. drivers/mtd/ubi/vtbl.c | 4 1 file

[PATCH v2] mtd/ubi: Make sure to read volume record from LEB 0 or LEB 1

2018-08-20 Thread Liu Song
Even though we protect on-flash data by CRC checksums, we still don't trust the media. If lnum is not 0 or 1, access exceed array boundary can lead to bad situation. Signed-off-by: Liu Song Reviewed-by: Jiang Biao --- v2: fix the name in *From*. drivers/mtd/ubi/vtbl.c | 4 1 file

Re: [PATCH] sched/fair: vruntime should normalize when switching from fair

2018-08-20 Thread Miguel de Dios
On 08/17/2018 11:27 AM, Steve Muckle wrote: From: John Dias When rt_mutex_setprio changes a task's scheduling class to RT, we're seeing cases where the task's vruntime is not updated correctly upon return to the fair class. Specifically, the following is being observed: - task is deactivated

Re: [PATCH] sched/fair: vruntime should normalize when switching from fair

2018-08-20 Thread Miguel de Dios
On 08/17/2018 11:27 AM, Steve Muckle wrote: From: John Dias When rt_mutex_setprio changes a task's scheduling class to RT, we're seeing cases where the task's vruntime is not updated correctly upon return to the fair class. Specifically, the following is being observed: - task is deactivated

Re: [GIT PULL] RTC for 4.19

2018-08-20 Thread Alexandre Belloni
On 20/08/2018 16:34:18-0700, Linus Torvalds wrote: > On Mon, Aug 20, 2018 at 2:22 PM Alexandre Belloni > wrote: > > > > Subsystem: > > - struct rtc_task removal along with rtc_irq_register/rtc_irq_unregister > > You can still find stale mentions of it by grepping for it: > > * @task:

Re: [GIT PULL] RTC for 4.19

2018-08-20 Thread Alexandre Belloni
On 20/08/2018 16:34:18-0700, Linus Torvalds wrote: > On Mon, Aug 20, 2018 at 2:22 PM Alexandre Belloni > wrote: > > > > Subsystem: > > - struct rtc_task removal along with rtc_irq_register/rtc_irq_unregister > > You can still find stale mentions of it by grepping for it: > > * @task:

Re: Redoing eXclusive Page Frame Ownership (XPFO) with isolated CPUs in mind (for KVM to isolate its guests per CPU)

2018-08-20 Thread Linus Torvalds
On Mon, Aug 20, 2018 at 4:27 PM Dave Hansen wrote: > > You're right that we could have a full physmap that we switch to for > kmap()-like access to user pages. But, the real problem is > transitioning pages from kernel to user usage since it requires shooting > down the old kernel mappings for

Re: Redoing eXclusive Page Frame Ownership (XPFO) with isolated CPUs in mind (for KVM to isolate its guests per CPU)

2018-08-20 Thread Linus Torvalds
On Mon, Aug 20, 2018 at 4:27 PM Dave Hansen wrote: > > You're right that we could have a full physmap that we switch to for > kmap()-like access to user pages. But, the real problem is > transitioning pages from kernel to user usage since it requires shooting > down the old kernel mappings for

Re: [GIT PULL] RTC for 4.19

2018-08-20 Thread Linus Torvalds
On Mon, Aug 20, 2018 at 2:22 PM Alexandre Belloni wrote: > > Subsystem: > - struct rtc_task removal along with rtc_irq_register/rtc_irq_unregister You can still find stale mentions of it by grepping for it: * @task: currently registered with rtc_irq_register() which should presumably be

Re: [GIT PULL] RTC for 4.19

2018-08-20 Thread Linus Torvalds
On Mon, Aug 20, 2018 at 2:22 PM Alexandre Belloni wrote: > > Subsystem: > - struct rtc_task removal along with rtc_irq_register/rtc_irq_unregister You can still find stale mentions of it by grepping for it: * @task: currently registered with rtc_irq_register() which should presumably be

Re: [PATCH v3 1/2] RISC-V: Define sys_riscv_flush_icache when SMP=n

2018-08-20 Thread Palmer Dabbelt
On Tue, 14 Aug 2018 06:39:23 PDT (-0700), Christoph Hellwig wrote: SYSCALL_DEFINE3(riscv_flush_icache, uintptr_t, start, uintptr_t, end, uintptr_t, flags) { +#ifdef CONFIG_SMP struct mm_struct *mm = current->mm; bool local = (flags & SYS_RISCV_FLUSH_ICACHE_LOCAL) != 0;

Re: [PATCH v3 1/2] RISC-V: Define sys_riscv_flush_icache when SMP=n

2018-08-20 Thread Palmer Dabbelt
On Tue, 14 Aug 2018 06:39:23 PDT (-0700), Christoph Hellwig wrote: SYSCALL_DEFINE3(riscv_flush_icache, uintptr_t, start, uintptr_t, end, uintptr_t, flags) { +#ifdef CONFIG_SMP struct mm_struct *mm = current->mm; bool local = (flags & SYS_RISCV_FLUSH_ICACHE_LOCAL) != 0;

Re: [PATCH v3 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h

2018-08-20 Thread Palmer Dabbelt
On Tue, 14 Aug 2018 06:40:27 PDT (-0700), Christoph Hellwig wrote: index 818655b0d535..690beb002d1d 100644 --- a/arch/riscv/include/uapi/asm/syscalls.h +++ b/arch/riscv/include/uapi/asm/syscalls.h @@ -1,10 +1,13 @@ -/* SPDX-License-Identifier: GPL-2.0 */ +// SPDX-License-Identifier: GPL-2.0 /*

Re: [PATCH v3 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h

2018-08-20 Thread Palmer Dabbelt
On Tue, 14 Aug 2018 06:40:27 PDT (-0700), Christoph Hellwig wrote: index 818655b0d535..690beb002d1d 100644 --- a/arch/riscv/include/uapi/asm/syscalls.h +++ b/arch/riscv/include/uapi/asm/syscalls.h @@ -1,10 +1,13 @@ -/* SPDX-License-Identifier: GPL-2.0 */ +// SPDX-License-Identifier: GPL-2.0 /*

Re: Redoing eXclusive Page Frame Ownership (XPFO) with isolated CPUs in mind (for KVM to isolate its guests per CPU)

2018-08-20 Thread Dave Hansen
On 08/20/2018 04:14 PM, David Woodhouse wrote: > If you need the physmap, then rather than manually mapping with 4KiB > pages, you just switch. Having first ensured that no malicious guest or > userspace is running on a sibling, of course. The problem is determining when "you need the physmap".

Re: Redoing eXclusive Page Frame Ownership (XPFO) with isolated CPUs in mind (for KVM to isolate its guests per CPU)

2018-08-20 Thread Dave Hansen
On 08/20/2018 04:14 PM, David Woodhouse wrote: > If you need the physmap, then rather than manually mapping with 4KiB > pages, you just switch. Having first ensured that no malicious guest or > userspace is running on a sibling, of course. The problem is determining when "you need the physmap".

Re: [PATCH RESEND v1 1/5] dt-bindings: pinctrl: add wakeup capable GPIOs for SDM845

2018-08-20 Thread Bjorn Andersson
On Fri 17 Aug 12:10 PDT 2018, Lina Iyer wrote: > diff --git > a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt > b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt [..] > @@ -155,11 +166,52 @@ Example: > tlmm: pinctrl@340 { > compatible

Re: [PATCH RESEND v1 1/5] dt-bindings: pinctrl: add wakeup capable GPIOs for SDM845

2018-08-20 Thread Bjorn Andersson
On Fri 17 Aug 12:10 PDT 2018, Lina Iyer wrote: > diff --git > a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt > b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt [..] > @@ -155,11 +166,52 @@ Example: > tlmm: pinctrl@340 { > compatible

Re: Redoing eXclusive Page Frame Ownership (XPFO) with isolated CPUs in mind (for KVM to isolate its guests per CPU)

2018-08-20 Thread David Woodhouse
On Mon, 2018-08-20 at 15:59 -0700, Dave Hansen wrote: > On 08/20/2018 03:35 PM, Tycho Andersen wrote: > > Since meltdown hit, I haven't worked seriously on understand and > > implementing his suggestions, in part because it wasn't clear to me > > what pieces of the infrastructure we might be

Re: Redoing eXclusive Page Frame Ownership (XPFO) with isolated CPUs in mind (for KVM to isolate its guests per CPU)

2018-08-20 Thread David Woodhouse
On Mon, 2018-08-20 at 15:59 -0700, Dave Hansen wrote: > On 08/20/2018 03:35 PM, Tycho Andersen wrote: > > Since meltdown hit, I haven't worked seriously on understand and > > implementing his suggestions, in part because it wasn't clear to me > > what pieces of the infrastructure we might be

Re: [PATCH] dt-bindings: riscv,cpu-intc: Cleanups from a missed review

2018-08-20 Thread Atish Patra
On 8/20/18 4:01 PM, Palmer Dabbelt wrote: I managed to miss one of Rob's code reviews on the mailing list . The patch has already been merged, so I'm submitting a fixup. Sorry! Fixes: b67bc7cb4088 ("dt-bindings:

Re: [PATCH] dt-bindings: riscv,cpu-intc: Cleanups from a missed review

2018-08-20 Thread Atish Patra
On 8/20/18 4:01 PM, Palmer Dabbelt wrote: I managed to miss one of Rob's code reviews on the mailing list . The patch has already been merged, so I'm submitting a fixup. Sorry! Fixes: b67bc7cb4088 ("dt-bindings:

Enumeration issue with QCA9005 AR9462

2018-08-20 Thread Bjorn Helgaas
mmyan...@gmail.com reported a problem [1]: on v4.17, a QCA9005 AR9462 wifi device was present at boot, but disappeared after suspend/resume. He/she also tested a recent kernel (5c60a7389d79, from Thu Aug 16), where the suspend/resume problem doesn't seem to happen, but the wifi device isn't

Enumeration issue with QCA9005 AR9462

2018-08-20 Thread Bjorn Helgaas
mmyan...@gmail.com reported a problem [1]: on v4.17, a QCA9005 AR9462 wifi device was present at boot, but disappeared after suspend/resume. He/she also tested a recent kernel (5c60a7389d79, from Thu Aug 16), where the suspend/resume problem doesn't seem to happen, but the wifi device isn't

[PATCH] x86/mm: Simplify p[g4um]d_page() macros

2018-08-20 Thread Andi Kleen
From: Tom Lendacky [backport of fd7e315988b78 from mainline for stable to fix stable crashes suggested by Michael Hocko. Should be applied to 4.9 and 4.4.] Create a pgd_pfn() macro similar to the p[4um]d_pfn() macros and then use the p[g4um]d_pfn() macros in the p[g4um]d_page() macros instead

[PATCH] x86/mm: Simplify p[g4um]d_page() macros

2018-08-20 Thread Andi Kleen
From: Tom Lendacky [backport of fd7e315988b78 from mainline for stable to fix stable crashes suggested by Michael Hocko. Should be applied to 4.9 and 4.4.] Create a pgd_pfn() macro similar to the p[4um]d_pfn() macros and then use the p[g4um]d_pfn() macros in the p[g4um]d_page() macros instead

  1   2   3   4   5   6   7   8   9   >