[PATCH v2 1/3] dt-bindings: iio: vadc: Fix documentation of 'reg'

2018-09-06 Thread Matthias Kaehlcke
The documentation of Qualcomm's SPMI PMIC voltage ADC claims that the 'reg' property consists of two values, the SPMI address and the length of the controller's registers. However the SPMI bus to which it is added specifies "#size-cells = <0>;". Remove the controller register length from the

[PATCH v2 0/3] arm64: dts: qcom: pm8998: Add ADC node and die temperature channel

2018-09-06 Thread Matthias Kaehlcke
This series adds the DT node for the QCOM SPMI PMIC5 ADC and a channel for the die temperature. The die temperature is going to be used by the temperature alarm driver (https://lore.kernel.org/patchwork/project/lkml/list/?series=361416). My understanding is that some of the ADC channels are/can

[PATCH v2 2/3] arm64: dts: qcom: pm8998: Add adc node

2018-09-06 Thread Matthias Kaehlcke
This adds the adc node to pm8998 based on the examples in the bindings. It also fixes the order of the included headers. Signed-off-by: Matthias Kaehlcke -- Changes in v2: - removed io-channel-ranges attribute --- arch/arm64/boot/dts/qcom/pm8998.dtsi | 12 +++- 1 file changed, 11

[PATCH v2 2/3] arm64: dts: qcom: pm8998: Add adc node

2018-09-06 Thread Matthias Kaehlcke
This adds the adc node to pm8998 based on the examples in the bindings. It also fixes the order of the included headers. Signed-off-by: Matthias Kaehlcke -- Changes in v2: - removed io-channel-ranges attribute --- arch/arm64/boot/dts/qcom/pm8998.dtsi | 12 +++- 1 file changed, 11

[PATCH v2 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC

2018-09-06 Thread Matthias Kaehlcke
Add a channel node for the die temperature to the ADC. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson Signed-off-by: Matthias Kaehlcke -- Changes in v2: - none --- arch/arm64/boot/dts/qcom/pm8998.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v2 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC

2018-09-06 Thread Matthias Kaehlcke
Add a channel node for the die temperature to the ADC. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson Signed-off-by: Matthias Kaehlcke -- Changes in v2: - none --- arch/arm64/boot/dts/qcom/pm8998.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH 1/3] of/fdt: Scan the root node properties earlier

2018-09-06 Thread Frank Rowand
Hi Rob, On 09/05/18 14:31, Rob Herring wrote: > On Wed, Sep 5, 2018 at 4:10 PM Frank Rowand wrote: >> >> On 09/05/18 13:06, Rob Herring wrote: >>> On Wed, Sep 5, 2018 at 1:19 PM Frank Rowand wrote: On 09/05/18 04:51, Rob Herring wrote: > On Tue, Sep 4, 2018 at 8:49 PM Frank Rowand

Re: [PATCH 1/3] of/fdt: Scan the root node properties earlier

2018-09-06 Thread Frank Rowand
Hi Rob, On 09/05/18 14:31, Rob Herring wrote: > On Wed, Sep 5, 2018 at 4:10 PM Frank Rowand wrote: >> >> On 09/05/18 13:06, Rob Herring wrote: >>> On Wed, Sep 5, 2018 at 1:19 PM Frank Rowand wrote: On 09/05/18 04:51, Rob Herring wrote: > On Tue, Sep 4, 2018 at 8:49 PM Frank Rowand

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Nadav Amit
at 1:25 PM, Peter Zijlstra wrote: > On Thu, Sep 06, 2018 at 07:58:40PM +, Nadav Amit wrote: >>> With that CR3 trickery, we can rid ourselves of the text_mutex >>> requirement, since concurrent text_poke is 'safe'. That would clean up >>> the kgdb code quite a bit. >> >> I don’t know. I’m

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Nadav Amit
at 1:25 PM, Peter Zijlstra wrote: > On Thu, Sep 06, 2018 at 07:58:40PM +, Nadav Amit wrote: >>> With that CR3 trickery, we can rid ourselves of the text_mutex >>> requirement, since concurrent text_poke is 'safe'. That would clean up >>> the kgdb code quite a bit. >> >> I don’t know. I’m

Re: [PATCH -next 0/2] fs/epoll: loosen irq safety when possible

2018-09-06 Thread Davidlohr Bueso
On Thu, 06 Sep 2018, Peter Zijlstra wrote: On Fri, Jul 20, 2018 at 01:05:59PM -0700, Davidlohr Bueso wrote: On Fri, 20 Jul 2018, Andrew Morton wrote: >I'm surprised. Is spin_lock_irqsave() significantly more expensive >than spin_lock_irq()? Relative to all the other stuff those functions

Re: [PATCH -next 0/2] fs/epoll: loosen irq safety when possible

2018-09-06 Thread Davidlohr Bueso
On Thu, 06 Sep 2018, Peter Zijlstra wrote: On Fri, Jul 20, 2018 at 01:05:59PM -0700, Davidlohr Bueso wrote: On Fri, 20 Jul 2018, Andrew Morton wrote: >I'm surprised. Is spin_lock_irqsave() significantly more expensive >than spin_lock_irq()? Relative to all the other stuff those functions

Re: [PATCH 2/2] mtd: nand: esmt: retrieve ecc requirements from 5th id byte

2018-09-06 Thread Miquel Raynal
Hi Marcel, Boris Brezillon wrote on Thu, 6 Sep 2018 22:44:22 +0200: > On Thu, 6 Sep 2018 10:49:22 +0200 > Marcel Ziswiler wrote: > > > From: Marcel Ziswiler > > > > This patch enables support to read the ECC level from the NAND flash > > using ESMT SLC NAND ID byte 5 information as

Re: [PATCH 2/2] mtd: nand: esmt: retrieve ecc requirements from 5th id byte

2018-09-06 Thread Miquel Raynal
Hi Marcel, Boris Brezillon wrote on Thu, 6 Sep 2018 22:44:22 +0200: > On Thu, 6 Sep 2018 10:49:22 +0200 > Marcel Ziswiler wrote: > > > From: Marcel Ziswiler > > > > This patch enables support to read the ECC level from the NAND flash > > using ESMT SLC NAND ID byte 5 information as

Re: [PATCH 2/2] mtd: nand: esmt: retrieve ecc requirements from 5th id byte

2018-09-06 Thread Boris Brezillon
On Thu, 6 Sep 2018 10:49:22 +0200 Marcel Ziswiler wrote: > From: Marcel Ziswiler > > This patch enables support to read the ECC level from the NAND flash > using ESMT SLC NAND ID byte 5 information as documented e.g. in the > following data sheet: > >

Re: [PATCH 2/2] mtd: nand: esmt: retrieve ecc requirements from 5th id byte

2018-09-06 Thread Boris Brezillon
On Thu, 6 Sep 2018 10:49:22 +0200 Marcel Ziswiler wrote: > From: Marcel Ziswiler > > This patch enables support to read the ECC level from the NAND flash > using ESMT SLC NAND ID byte 5 information as documented e.g. in the > following data sheet: > >

Re: [PATCH 1/2] mtd: nand: reorder nand manufacturer ids

2018-09-06 Thread Boris Brezillon
On Thu, 6 Sep 2018 10:49:21 +0200 Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Reorder NAND manufacturer ids for clarity. > > Signed-off-by: Marcel Ziswiler > > --- > > drivers/mtd/nand/raw/nand_ids.c | 20 ++-- > include/linux/mtd/rawnand.h | 8 > 2

Re: [PATCH 1/2] mtd: nand: reorder nand manufacturer ids

2018-09-06 Thread Boris Brezillon
On Thu, 6 Sep 2018 10:49:21 +0200 Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Reorder NAND manufacturer ids for clarity. > > Signed-off-by: Marcel Ziswiler > > --- > > drivers/mtd/nand/raw/nand_ids.c | 20 ++-- > include/linux/mtd/rawnand.h | 8 > 2

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Sean Christopherson
On Thu, Sep 06, 2018 at 03:20:46PM -0500, Brijesh Singh wrote: > > > On 09/06/2018 02:47 PM, Sean Christopherson wrote: > ... > > >> > >>Yes, the auxiliary array will dumped into the regular .bss when > >>CONFIG_AMD_MEM_ENCRYPT=n. Typically it will be few k, I am not > >>sure if its worth

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Sean Christopherson
On Thu, Sep 06, 2018 at 03:20:46PM -0500, Brijesh Singh wrote: > > > On 09/06/2018 02:47 PM, Sean Christopherson wrote: > ... > > >> > >>Yes, the auxiliary array will dumped into the regular .bss when > >>CONFIG_AMD_MEM_ENCRYPT=n. Typically it will be few k, I am not > >>sure if its worth

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Reinette Chatre
On 9/6/2018 1:29 PM, Peter Zijlstra wrote: > On Thu, Sep 06, 2018 at 01:05:05PM -0700, Reinette Chatre wrote: >> When I separate the above into the two functions it just becomes either: >>rdpmcl(l2_hit_pmcnum, l2_hits_after); >>rdpmcl(l2_miss_pmcnum,

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Reinette Chatre
On 9/6/2018 1:29 PM, Peter Zijlstra wrote: > On Thu, Sep 06, 2018 at 01:05:05PM -0700, Reinette Chatre wrote: >> When I separate the above into the two functions it just becomes either: >>rdpmcl(l2_hit_pmcnum, l2_hits_after); >>rdpmcl(l2_miss_pmcnum,

Re: [PATCH 2/3] arm64: dts: qcom: pm8998: Add adc node

2018-09-06 Thread Matthias Kaehlcke
On Thu, Sep 06, 2018 at 11:34:32AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Aug 27, 2018 at 10:10 AM, Matthias Kaehlcke wrote: > > On Fri, Aug 10, 2018 at 05:09:17PM -0700, Doug Anderson wrote: > >> Hi, > >> > >> On Wed, Aug 8, 2018 at 12:13 PM, Matthias Kaehlcke > >> wrote: > >> > This

Re: [PATCH 2/3] arm64: dts: qcom: pm8998: Add adc node

2018-09-06 Thread Matthias Kaehlcke
On Thu, Sep 06, 2018 at 11:34:32AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Aug 27, 2018 at 10:10 AM, Matthias Kaehlcke wrote: > > On Fri, Aug 10, 2018 at 05:09:17PM -0700, Doug Anderson wrote: > >> Hi, > >> > >> On Wed, Aug 8, 2018 at 12:13 PM, Matthias Kaehlcke > >> wrote: > >> > This

[PATCH v2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-06 Thread Cedric Roux
The mini2440 computer uses "active high" to signal that the "write protect" of the inserted MMC is set. The current code uses the opposite, leading to a wrong detection of write protection. The solution is simply to use ".wprotect_invert = 1" in the description of the MMC. Signed-off-by: Cedric

[PATCH v2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

2018-09-06 Thread Cedric Roux
The mini2440 computer uses "active high" to signal that the "write protect" of the inserted MMC is set. The current code uses the opposite, leading to a wrong detection of write protection. The solution is simply to use ".wprotect_invert = 1" in the description of the MMC. Signed-off-by: Cedric

Re: [PATCH v1] x86/intel_rdt: Switch to bitmap_zalloc()

2018-09-06 Thread Fenghua Yu
On Thu, Aug 30, 2018 at 02:50:39PM +0300, Andy Shevchenko wrote: > Switch to bitmap_zalloc() to show clearly what we are allocating. > Besides that it returns pointer of bitmap type instead of opaque void *. > > Signed-off-by: Andy Shevchenko > --- > arch/x86/kernel/cpu/intel_rdt.c | 10

Re: [PATCH] seccomp: remove unnecessary unlikely()

2018-09-06 Thread James Morris
On Wed, 5 Sep 2018, Igor Stoppa wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to wrap it > into another. > > Signed-off-by: Igor Stoppa > Acked-by: Kees Cook > Cc: linux-security-mod...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Applied to

Re: [PATCH v1] x86/intel_rdt: Switch to bitmap_zalloc()

2018-09-06 Thread Fenghua Yu
On Thu, Aug 30, 2018 at 02:50:39PM +0300, Andy Shevchenko wrote: > Switch to bitmap_zalloc() to show clearly what we are allocating. > Besides that it returns pointer of bitmap type instead of opaque void *. > > Signed-off-by: Andy Shevchenko > --- > arch/x86/kernel/cpu/intel_rdt.c | 10

Re: [PATCH] seccomp: remove unnecessary unlikely()

2018-09-06 Thread James Morris
On Wed, 5 Sep 2018, Igor Stoppa wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to wrap it > into another. > > Signed-off-by: Igor Stoppa > Acked-by: Kees Cook > Cc: linux-security-mod...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Applied to

Re: [RFC PATCH 1/2] mm: move tlb_table_flush to tlb_flush_mmu_free

2018-09-06 Thread Rik van Riel
On Thu, 2018-08-23 at 18:47 +1000, Nicholas Piggin wrote: > There is no need to call this from tlb_flush_mmu_tlbonly, it > logically belongs with tlb_flush_mmu_free. This allows some > code consolidation with a subsequent fix. > > Signed-off-by: Nicholas Piggin Reviewed-by: Rik van Riel This

Re: [RFC PATCH 1/2] mm: move tlb_table_flush to tlb_flush_mmu_free

2018-09-06 Thread Rik van Riel
On Thu, 2018-08-23 at 18:47 +1000, Nicholas Piggin wrote: > There is no need to call this from tlb_flush_mmu_tlbonly, it > logically belongs with tlb_flush_mmu_free. This allows some > code consolidation with a subsequent fix. > > Signed-off-by: Nicholas Piggin Reviewed-by: Rik van Riel This

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 01:05:05PM -0700, Reinette Chatre wrote: > When I separate the above into the two functions it just becomes either: >rdpmcl(l2_hit_pmcnum, l2_hits_after); >rdpmcl(l2_miss_pmcnum, l2_miss_after); > or: >

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 01:05:05PM -0700, Reinette Chatre wrote: > When I separate the above into the two functions it just becomes either: >rdpmcl(l2_hit_pmcnum, l2_hits_after); >rdpmcl(l2_miss_pmcnum, l2_miss_after); > or: >

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-09-06 Thread Andi Kleen
> And what about populate_pud? > set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, >canon_pgprot(pud_pgprot; > > start += PUD_SIZE; > cpa->pfn += PUD_SIZE; Yes you're right. That case needs to be fixed too. Are

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-09-06 Thread Andi Kleen
> And what about populate_pud? > set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, >canon_pgprot(pud_pgprot; > > start += PUD_SIZE; > cpa->pfn += PUD_SIZE; Yes you're right. That case needs to be fixed too. Are

Re: [PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 01:12:14PM -0700, Nadav Amit wrote: > at 12:57 PM, Peter Zijlstra wrote: > > > On Sun, Sep 02, 2018 at 11:14:50AM -0700, Nadav Amit wrote: > >> When page-table entries are set, the compiler might optimize their > >> assignment by using multiple instructions to set the

Re: [PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 01:12:14PM -0700, Nadav Amit wrote: > at 12:57 PM, Peter Zijlstra wrote: > > > On Sun, Sep 02, 2018 at 11:14:50AM -0700, Nadav Amit wrote: > >> When page-table entries are set, the compiler might optimize their > >> assignment by using multiple instructions to set the

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 07:58:40PM +, Nadav Amit wrote: > > With that CR3 trickery, we can rid ourselves of the text_mutex > > requirement, since concurrent text_poke is 'safe'. That would clean up > > the kgdb code quite a bit. > > I don’t know. I’m somewhat worried with multiple mechanisms

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 07:58:40PM +, Nadav Amit wrote: > > With that CR3 trickery, we can rid ourselves of the text_mutex > > requirement, since concurrent text_poke is 'safe'. That would clean up > > the kgdb code quite a bit. > > I don’t know. I’m somewhat worried with multiple mechanisms

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Brijesh Singh
On 09/06/2018 02:47 PM, Sean Christopherson wrote: ... Yes, the auxiliary array will dumped into the regular .bss when CONFIG_AMD_MEM_ENCRYPT=n. Typically it will be few k, I am not sure if its worth complicating the code to save those extra memory. Most of the distro's have

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Brijesh Singh
On 09/06/2018 02:47 PM, Sean Christopherson wrote: ... Yes, the auxiliary array will dumped into the regular .bss when CONFIG_AMD_MEM_ENCRYPT=n. Typically it will be few k, I am not sure if its worth complicating the code to save those extra memory. Most of the distro's have

Re: [PATCH] arm64: dts: qcom: sdm845-mtp: pm8998 and pmi8998 regulators

2018-09-06 Thread Doug Anderson
Hi, On Thu, Sep 6, 2018 at 1:12 PM, Bjorn Andersson wrote: >> * Seems to have a few rails named differently LDO22 is named >> "vreg_l22a_2p95" in your DTS but "vreg_l22a_2p85" in mine as one >> example. The schematics I have (from Dec 5, 2017) show it as 2p85. >> > > Looks like a typo on my

Re: [PATCH] arm64: dts: qcom: sdm845-mtp: pm8998 and pmi8998 regulators

2018-09-06 Thread Doug Anderson
Hi, On Thu, Sep 6, 2018 at 1:12 PM, Bjorn Andersson wrote: >> * Seems to have a few rails named differently LDO22 is named >> "vreg_l22a_2p95" in your DTS but "vreg_l22a_2p85" in mine as one >> example. The schematics I have (from Dec 5, 2017) show it as 2p85. >> > > Looks like a typo on my

[PATCH] locking/rwsem: Make owner store task pointer of last owning reader

2018-09-06 Thread Waiman Long
Currently, when a reader acquires a lock, it only sets the RWSEM_READER_OWNED bit in the owner field. The other bits are simply not used. When debugging hanging cases involving rwsems and readers, the owner value does not provide much useful information at all. This patch modifies the current

[PATCH] locking/rwsem: Make owner store task pointer of last owning reader

2018-09-06 Thread Waiman Long
Currently, when a reader acquires a lock, it only sets the RWSEM_READER_OWNED bit in the owner field. The other bits are simply not used. When debugging hanging cases involving rwsems and readers, the owner value does not provide much useful information at all. This patch modifies the current

Re: [PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-06 Thread Jacek Anaszewski
Hi Baolin, Thank you for the patch. I really appreciate your effort. I see one more thing I forgot to mention in the previous review. Please take a look at my comment to pattern_set(). On 09/06/2018 04:37 AM, Baolin Wang wrote: > This patch implements the 'pattern_set'and 'pattern_clear' >

Re: [PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-06 Thread Jacek Anaszewski
Hi Baolin, Thank you for the patch. I really appreciate your effort. I see one more thing I forgot to mention in the previous review. Please take a look at my comment to pattern_set(). On 09/06/2018 04:37 AM, Baolin Wang wrote: > This patch implements the 'pattern_set'and 'pattern_clear' >

Re: [PATCH 1/2] mtd: nand: reorder nand manufacturer ids

2018-09-06 Thread Miquel Raynal
Hi Marcel, Marcel Ziswiler wrote on Thu, 6 Sep 2018 10:49:21 +0200: > From: Marcel Ziswiler > > Reorder NAND manufacturer ids for clarity. > > Signed-off-by: Marcel Ziswiler > > --- Both patches applied to nand/next with subject prefix s/nand:/rawnand:/ as well as upper-case:

Re: [PATCH 1/2] mtd: nand: reorder nand manufacturer ids

2018-09-06 Thread Miquel Raynal
Hi Marcel, Marcel Ziswiler wrote on Thu, 6 Sep 2018 10:49:21 +0200: > From: Marcel Ziswiler > > Reorder NAND manufacturer ids for clarity. > > Signed-off-by: Marcel Ziswiler > > --- Both patches applied to nand/next with subject prefix s/nand:/rawnand:/ as well as upper-case:

Re: [PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-06 Thread Nadav Amit
at 12:57 PM, Peter Zijlstra wrote: > On Sun, Sep 02, 2018 at 11:14:50AM -0700, Nadav Amit wrote: >> When page-table entries are set, the compiler might optimize their >> assignment by using multiple instructions to set the PTE. This might >> turn into a security hazard if the user somehow

Re: [PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-06 Thread Nadav Amit
at 12:57 PM, Peter Zijlstra wrote: > On Sun, Sep 02, 2018 at 11:14:50AM -0700, Nadav Amit wrote: >> When page-table entries are set, the compiler might optimize their >> assignment by using multiple instructions to set the PTE. This might >> turn into a security hazard if the user somehow

Re: [PATCH] arm64: dts: qcom: sdm845-mtp: pm8998 and pmi8998 regulators

2018-09-06 Thread Bjorn Andersson
On Thu 06 Sep 10:52 PDT 2018, Doug Anderson wrote: > Bjorn, > > On Sat, Sep 1, 2018 at 3:19 PM, Bjorn Andersson > wrote: > > Add regulator definitions for pm8998 and pmi8998 regulators on the MTP. > > > > Signed-off-by: Bjorn Andersson > > --- > > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 216

Re: [PATCH] arm64: dts: qcom: sdm845-mtp: pm8998 and pmi8998 regulators

2018-09-06 Thread Bjorn Andersson
On Thu 06 Sep 10:52 PDT 2018, Doug Anderson wrote: > Bjorn, > > On Sat, Sep 1, 2018 at 3:19 PM, Bjorn Andersson > wrote: > > Add regulator definitions for pm8998 and pmi8998 regulators on the MTP. > > > > Signed-off-by: Bjorn Andersson > > --- > > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 216

RE: [PATCH v3] ata: Disable AHCI ALPM feature for Ampere Computing eMAG SATA

2018-09-06 Thread Suman Tripathi
Hi Hans, With regards, Suman -Original Message- From: Hans de Goede Sent: Thursday, September 6, 2018 1:06 PM To: Suman Tripathi ; ax...@kernel.dk; t...@kernel.org; linux-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; j...@perches.com;

RE: [PATCH v3] ata: Disable AHCI ALPM feature for Ampere Computing eMAG SATA

2018-09-06 Thread Suman Tripathi
Hi Hans, With regards, Suman -Original Message- From: Hans de Goede Sent: Thursday, September 6, 2018 1:06 PM To: Suman Tripathi ; ax...@kernel.dk; t...@kernel.org; linux-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; j...@perches.com;

Re: [PATCH v3] ata: Disable AHCI ALPM feature for Ampere Computing eMAG SATA

2018-09-06 Thread Hans de Goede
Hi, On 06-09-18 20:05, Suman Tripathi wrote: Due to hardware errata, Ampere Computing eMAG SATA can't support AHCI ALPM feature. This patch disables the AHCI ALPM feature for eMAG SATA. Signed-off-by: Suman Trpathi Signed-off-by: Rameshwar Prasad Sahu Sorry, but the patch is still coming

Re: [PATCH v3] ata: Disable AHCI ALPM feature for Ampere Computing eMAG SATA

2018-09-06 Thread Hans de Goede
Hi, On 06-09-18 20:05, Suman Tripathi wrote: Due to hardware errata, Ampere Computing eMAG SATA can't support AHCI ALPM feature. This patch disables the AHCI ALPM feature for eMAG SATA. Signed-off-by: Suman Trpathi Signed-off-by: Rameshwar Prasad Sahu Sorry, but the patch is still coming

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Reinette Chatre
Hi Peter, On 9/6/2018 12:44 PM, Peter Zijlstra wrote: > On Thu, Sep 06, 2018 at 12:21:59PM -0700, Reinette Chatre wrote: >> If you do have suggestions on how I can improve the implementation while >> maintaining (or improving) the accuracy of the measurements I would >> greatly appreciate it. >

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Reinette Chatre
Hi Peter, On 9/6/2018 12:44 PM, Peter Zijlstra wrote: > On Thu, Sep 06, 2018 at 12:21:59PM -0700, Reinette Chatre wrote: >> If you do have suggestions on how I can improve the implementation while >> maintaining (or improving) the accuracy of the measurements I would >> greatly appreciate it. >

Re: [PATCH v2 7/9] net: stmmac: dwmac-sun8i: fix OF child-node lookup

2018-09-06 Thread Corentin Labbe
On Mon, Aug 27, 2018 at 10:21:51AM +0200, Johan Hovold wrote: > Use the new of_get_compatible_child() helper to lookup the mdio-internal > child node instead of using of_find_compatible_node(), which searches > the entire tree from a given start node and thus can return an unrelated > (i.e.

Re: [PATCH v2 7/9] net: stmmac: dwmac-sun8i: fix OF child-node lookup

2018-09-06 Thread Corentin Labbe
On Mon, Aug 27, 2018 at 10:21:51AM +0200, Johan Hovold wrote: > Use the new of_get_compatible_child() helper to lookup the mdio-internal > child node instead of using of_find_compatible_node(), which searches > the entire tree from a given start node and thus can return an unrelated > (i.e.

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Nadav Amit
at 12:53 PM, Peter Zijlstra wrote: > On Thu, Sep 06, 2018 at 07:42:14PM +, Nadav Amit wrote: >> at 12:40 PM, Peter Zijlstra wrote: >> >>> On Sun, Sep 02, 2018 at 10:32:19AM -0700, Nadav Amit wrote: text_mutex is expected to be held before text_poke() is called, but we cannot add

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Nadav Amit
at 12:53 PM, Peter Zijlstra wrote: > On Thu, Sep 06, 2018 at 07:42:14PM +, Nadav Amit wrote: >> at 12:40 PM, Peter Zijlstra wrote: >> >>> On Sun, Sep 02, 2018 at 10:32:19AM -0700, Nadav Amit wrote: text_mutex is expected to be held before text_poke() is called, but we cannot add

Re: [PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-06 Thread Peter Zijlstra
On Sun, Sep 02, 2018 at 11:14:50AM -0700, Nadav Amit wrote: > When page-table entries are set, the compiler might optimize their > assignment by using multiple instructions to set the PTE. This might > turn into a security hazard if the user somehow manages to use the > interim PTE. L1TF does not

Re: [PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-06 Thread Peter Zijlstra
On Sun, Sep 02, 2018 at 11:14:50AM -0700, Nadav Amit wrote: > When page-table entries are set, the compiler might optimize their > assignment by using multiple instructions to set the PTE. This might > turn into a security hazard if the user somehow manages to use the > interim PTE. L1TF does not

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 07:42:14PM +, Nadav Amit wrote: > at 12:40 PM, Peter Zijlstra wrote: > > > On Sun, Sep 02, 2018 at 10:32:19AM -0700, Nadav Amit wrote: > >> text_mutex is expected to be held before text_poke() is called, but we > >> cannot add a lockdep assertion since kgdb does not

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 07:42:14PM +, Nadav Amit wrote: > at 12:40 PM, Peter Zijlstra wrote: > > > On Sun, Sep 02, 2018 at 10:32:19AM -0700, Nadav Amit wrote: > >> text_mutex is expected to be held before text_poke() is called, but we > >> cannot add a lockdep assertion since kgdb does not

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Brijesh Singh
On 09/06/2018 02:24 PM, Brijesh Singh wrote: ... Again we have to consider the bare metal scenario while doing this. The aux array you proposed will be added in decrypted section only when CONFIG_AMD_MEM_ENCRYPT=y.  If CONFIG_AMD_MEM_ENCRYPT=n then nothng gets put in .data.decrypted

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Brijesh Singh
On 09/06/2018 02:24 PM, Brijesh Singh wrote: ... Again we have to consider the bare metal scenario while doing this. The aux array you proposed will be added in decrypted section only when CONFIG_AMD_MEM_ENCRYPT=y.  If CONFIG_AMD_MEM_ENCRYPT=n then nothng gets put in .data.decrypted

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Sean Christopherson
On Thu, Sep 06, 2018 at 02:24:32PM -0500, Brijesh Singh wrote: > > > On 09/06/2018 01:47 PM, Sean Christopherson wrote: > >On Thu, Sep 06, 2018 at 01:37:50PM -0500, Brijesh Singh wrote: > >> > >> > >>On 09/06/2018 09:18 AM, Sean Christopherson wrote: > >> > >> > > > >So are we going

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Sean Christopherson
On Thu, Sep 06, 2018 at 02:24:32PM -0500, Brijesh Singh wrote: > > > On 09/06/2018 01:47 PM, Sean Christopherson wrote: > >On Thu, Sep 06, 2018 at 01:37:50PM -0500, Brijesh Singh wrote: > >> > >> > >>On 09/06/2018 09:18 AM, Sean Christopherson wrote: > >> > >> > > > >So are we going

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 12:21:59PM -0700, Reinette Chatre wrote: > If you do have suggestions on how I can improve the implementation while > maintaining (or improving) the accuracy of the measurements I would > greatly appreciate it. You can reduce the code duplication by using __always_inline

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 12:21:59PM -0700, Reinette Chatre wrote: > If you do have suggestions on how I can improve the implementation while > maintaining (or improving) the accuracy of the measurements I would > greatly appreciate it. You can reduce the code duplication by using __always_inline

Re: Widespread crashes in next-20180906

2018-09-06 Thread Theodore Y. Ts'o
arm64? Because KernelCI is seeing build failures in arm64 > defconfig for next-20180906 > Clearly it's a module build problem for sunxi but I'm not sure who to > CC about this. > > https://kernelci.org/build/next/branch/master/kernel/next-20180906/ > https://storage.kernelci.org/

Re: Widespread crashes in next-20180906

2018-09-06 Thread Theodore Y. Ts'o
arm64? Because KernelCI is seeing build failures in arm64 > defconfig for next-20180906 > Clearly it's a module build problem for sunxi but I'm not sure who to > CC about this. > > https://kernelci.org/build/next/branch/master/kernel/next-20180906/ > https://storage.kernelci.org/

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Nadav Amit
at 12:40 PM, Peter Zijlstra wrote: > On Sun, Sep 02, 2018 at 10:32:19AM -0700, Nadav Amit wrote: >> text_mutex is expected to be held before text_poke() is called, but we >> cannot add a lockdep assertion since kgdb does not take it, and instead >> *supposedly* ensures the lock is not taken and

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Nadav Amit
at 12:40 PM, Peter Zijlstra wrote: > On Sun, Sep 02, 2018 at 10:32:19AM -0700, Nadav Amit wrote: >> text_mutex is expected to be held before text_poke() is called, but we >> cannot add a lockdep assertion since kgdb does not take it, and instead >> *supposedly* ensures the lock is not taken and

Re: possible deadlock in ext4_evict_inode

2018-09-06 Thread Dmitry Vyukov
On Thu, Sep 6, 2018 at 9:38 PM, Theodore Y. Ts'o wrote: > On Thu, Sep 06, 2018 at 09:41:04AM -0700, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:b36fdc6853a3 Merge tag 'gpio-v4.19-2' of git://git.kernel... >> git tree: upstream >> console output:

Re: possible deadlock in ext4_evict_inode

2018-09-06 Thread Dmitry Vyukov
On Thu, Sep 6, 2018 at 9:38 PM, Theodore Y. Ts'o wrote: > On Thu, Sep 06, 2018 at 09:41:04AM -0700, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:b36fdc6853a3 Merge tag 'gpio-v4.19-2' of git://git.kernel... >> git tree: upstream >> console output:

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Peter Zijlstra
On Sun, Sep 02, 2018 at 10:32:19AM -0700, Nadav Amit wrote: > text_mutex is expected to be held before text_poke() is called, but we > cannot add a lockdep assertion since kgdb does not take it, and instead > *supposedly* ensures the lock is not taken and will not be acquired by > any other core

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Peter Zijlstra
On Sun, Sep 02, 2018 at 10:32:19AM -0700, Nadav Amit wrote: > text_mutex is expected to be held before text_poke() is called, but we > cannot add a lockdep assertion since kgdb does not take it, and instead > *supposedly* ensures the lock is not taken and will not be acquired by > any other core

Re: possible deadlock in ext4_evict_inode

2018-09-06 Thread Theodore Y. Ts'o
On Thu, Sep 06, 2018 at 09:41:04AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:b36fdc6853a3 Merge tag 'gpio-v4.19-2' of git://git.kernel... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1716bc9e40 >

Re: possible deadlock in ext4_evict_inode

2018-09-06 Thread Theodore Y. Ts'o
On Thu, Sep 06, 2018 at 09:41:04AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:b36fdc6853a3 Merge tag 'gpio-v4.19-2' of git://git.kernel... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1716bc9e40 >

Re: [PATCH RT 00/22] Linux 4.14.63-rt41-rc1

2018-09-06 Thread Sebastian Andrzej Siewior
On 2018-09-06 12:43:49 [-0400], Steven Rostedt wrote: > > Your tree (v4.14.63) has > > 80d20d35af1ed ("nohz: Fix local_timer_softirq_pending()") > > 0a0e0829f9901 ("nohz: Fix missing tick reprogram when interrupting an > > inline softirq") > > > > which means that the patch

Re: [PATCH RT 00/22] Linux 4.14.63-rt41-rc1

2018-09-06 Thread Sebastian Andrzej Siewior
On 2018-09-06 12:43:49 [-0400], Steven Rostedt wrote: > > Your tree (v4.14.63) has > > 80d20d35af1ed ("nohz: Fix local_timer_softirq_pending()") > > 0a0e0829f9901 ("nohz: Fix missing tick reprogram when interrupting an > > inline softirq") > > > > which means that the patch

Re: [PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 10:21:38AM -0700, Dave Hansen wrote: > There's probably a massive number of things that would break if we > assumed sane 64-bit writes can be observed piecemeal. Do assume, it has been observed. WRITE_ONCE()/READ_ONCE() are _required_ if you cannot have load/store tearing.

Re: [PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 10:21:38AM -0700, Dave Hansen wrote: > There's probably a massive number of things that would break if we > assumed sane 64-bit writes can be observed piecemeal. Do assume, it has been observed. WRITE_ONCE()/READ_ONCE() are _required_ if you cannot have load/store tearing.

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Brijesh Singh
On 09/06/2018 01:47 PM, Sean Christopherson wrote: On Thu, Sep 06, 2018 at 01:37:50PM -0500, Brijesh Singh wrote: On 09/06/2018 09:18 AM, Sean Christopherson wrote: So are we going to be defining a decrypted section for every piece of machinery now? That's a bit too much in my

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Brijesh Singh
On 09/06/2018 01:47 PM, Sean Christopherson wrote: On Thu, Sep 06, 2018 at 01:37:50PM -0500, Brijesh Singh wrote: On 09/06/2018 09:18 AM, Sean Christopherson wrote: So are we going to be defining a decrypted section for every piece of machinery now? That's a bit too much in my

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Reinette Chatre
Hi Peter, On 9/6/2018 7:15 AM, Peter Zijlstra wrote: > On Thu, Aug 16, 2018 at 01:16:08PM -0700, Reinette Chatre wrote: >> +l2_miss_event = perf_event_create_kernel_counter(_miss_attr, >> + plr->cpu, >> +

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Reinette Chatre
Hi Peter, On 9/6/2018 7:15 AM, Peter Zijlstra wrote: > On Thu, Aug 16, 2018 at 01:16:08PM -0700, Reinette Chatre wrote: >> +l2_miss_event = perf_event_create_kernel_counter(_miss_attr, >> + plr->cpu, >> +

Re: Widespread crashes in next-20180906

2018-09-06 Thread Matt Hart
; >> total: 134 pass: 133 fail: 1 >> >> Do you build arm64? Because KernelCI is seeing build failures in arm64 >> defconfig for next-20180906 >> Clearly it's a module build problem for sunxi but I'm not sure who to >> CC about this. >> > I do, b

Re: Widespread crashes in next-20180906

2018-09-06 Thread Matt Hart
; >> total: 134 pass: 133 fail: 1 >> >> Do you build arm64? Because KernelCI is seeing build failures in arm64 >> defconfig for next-20180906 >> Clearly it's a module build problem for sunxi but I'm not sure who to >> CC about this. >> > I do, b

Re: [PATCH v2 0/6] x86/alternatives: text_poke() fixes

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 06:38:30PM +, Nadav Amit wrote: > Note that patch 1/6 is still needed to fix false lockdep shoutouts due to a > recent patch. For some reason I do not appear to have 1/6 in my inbox. Let me dig through lkml.

Re: [PATCH v2 0/6] x86/alternatives: text_poke() fixes

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 06:38:30PM +, Nadav Amit wrote: > Note that patch 1/6 is still needed to fix false lockdep shoutouts due to a > recent patch. For some reason I do not appear to have 1/6 in my inbox. Let me dig through lkml.

Re: [PATCH -next 0/2] fs/epoll: loosen irq safety when possible

2018-09-06 Thread Peter Zijlstra
On Fri, Jul 20, 2018 at 01:05:59PM -0700, Davidlohr Bueso wrote: > On Fri, 20 Jul 2018, Andrew Morton wrote: > >I'm surprised. Is spin_lock_irqsave() significantly more expensive > >than spin_lock_irq()? Relative to all the other stuff those functions > >are doing? If so, how come? Some

Re: [PATCH -next 0/2] fs/epoll: loosen irq safety when possible

2018-09-06 Thread Peter Zijlstra
On Fri, Jul 20, 2018 at 01:05:59PM -0700, Davidlohr Bueso wrote: > On Fri, 20 Jul 2018, Andrew Morton wrote: > >I'm surprised. Is spin_lock_irqsave() significantly more expensive > >than spin_lock_irq()? Relative to all the other stuff those functions > >are doing? If so, how come? Some

Re: [PATCH] pci: fix pci.c kernel-doc parameter warning

2018-09-06 Thread Bjorn Helgaas
On Sun, Sep 02, 2018 at 07:32:50PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix kernel-doc warning: > > ../drivers/pci/pci.c:218: warning: Excess function parameter 'p' description > in 'pci_dev_str_match_path' > > Signed-off-by: Randy Dunlap > Cc: Bjorn Helgaas > Cc:

Re: [PATCH] pci: fix pci.c kernel-doc parameter warning

2018-09-06 Thread Bjorn Helgaas
On Sun, Sep 02, 2018 at 07:32:50PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix kernel-doc warning: > > ../drivers/pci/pci.c:218: warning: Excess function parameter 'p' description > in 'pci_dev_str_match_path' > > Signed-off-by: Randy Dunlap > Cc: Bjorn Helgaas > Cc:

<    3   4   5   6   7   8   9   10   11   12   >