Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-21 Thread Tony Krowiak
On 09/12/2018 03:43 PM, Tony Krowiak wrote: From: Tony Krowiak Implements the open callback on the mediated matrix device. The function registers a group notifier to receive notification of the VFIO_GROUP_NOTIFY_SET_KVM event. When notified, the vfio_ap device driver will get access to the gues

[PATCH] rtc: lib: correct documentation typo

2018-09-21 Thread Alexandre Belloni
rtc_time64_to_tm has not been called rtc_time_to_tm64 Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-lib.c b/drivers/rtc/rtc-lib.c index 4a3c0f3aab14..ef160da84220 100644 --- a/drivers/rtc/rtc-lib.c +

Re: possible deadlock in __do_page_fault

2018-09-21 Thread Andrew Morton
On Thu, 20 Sep 2018 19:33:15 -0400 Joel Fernandes wrote: > On Thu, Sep 20, 2018 at 5:12 PM Todd Kjos wrote: > > > > +Joel Fernandes > > > > On Thu, Sep 20, 2018 at 2:11 PM Andrew Morton > > wrote: > > > > > > > > > Thanks. Let's cc the ashmem folks. > > > > > This should be fixed by https:/

Re: Code of Conduct: Let's revamp it.

2018-09-21 Thread Joey Pabalinas
On Fri, Sep 21, 2018 at 07:15:45PM -0400, Theodore Y. Ts'o wrote: > People can decide who they want to respond to, but I'm going to gently > suggest that before people think about responding to a particular > e-mail, that they do a quick check using "git log --author=xy...@example.com" > then decid

Re: [PATCH v10 03/26] KVM: s390: refactor crypto initialization

2018-09-21 Thread Tony Krowiak
On 09/12/2018 03:42 PM, Tony Krowiak wrote: From: Tony Krowiak This patch refactors the code that initializes and sets up the crypto configuration for a guest. The following changes are implemented via this patch: 1. Prior to the introduction of AP device virtualization, it was not necessa

Re: Code of Conduct: Let's revamp it.

2018-09-21 Thread Theodore Y. Ts'o
People can decide who they want to respond to, but I'm going to gently suggest that before people think about responding to a particular e-mail, that they do a quick check using "git log --author=xy...@example.com" then decide how much someone appears to be a member of the community before deciding

linux-next: Signed-off-by missing for commit in the mali-dp tree

2018-09-21 Thread Stephen Rothwell
Hi Liviu, Commit fd75f5726f65 ("drm/mali-dp: Implement plane alpha and pixel blend on malidp") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgphJe0NQyFY4.pgp Description: OpenPGP digital signature

[PATCH] selftests: watchdog: Add gettimeout and get|set pretimeout

2018-09-21 Thread Jerry Hoemann
Add command line arguments to call ioctl WDIOC_GETTIMEOUT, WDIOC_GETPRETIMEOUT and WDIOC_SETPRETIMEOUT. Signed-off-by: Jerry Hoemann --- tools/testing/selftests/watchdog/watchdog-test.c | 30 +++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/tools/testing/sel

Re: [PATCH v4] selftests: membarrier: reorganized test for LTS supportability

2018-09-21 Thread Shuah Khan
On 09/03/2018 01:04 PM, Rafael David Tinoco wrote: > This commit re-organizes membarrier test, solving issues when testing > LTS kernels. Now, the code: > > - always run the same amount of tests (even on older kernels). > - allows each test to succeed, fail or be skipped independently. > - allo

Re: [PATCH 0/8] x86/mm/cpa: Further optimizations

2018-09-21 Thread Dave Hansen
BTW, on all of these: Reviewed-by: Dave Hansen

[PATCH 0/8] x86/mm/cpa: Further optimizations

2018-09-21 Thread Dave Hansen
On 09/19/2018 01:50 AM, Peter Zijlstra wrote: > Dave, can you have a wee look at the Atom errata thing; this does grow the > amount of code between the page-table update and the TLB flush a bit, but all > that PTI crud we did a while back already made it a non-trivial amount of > code. Oh, were y

Re: [PATCH v3] membarrier_test: work in progress

2018-09-21 Thread Shuah Khan
Hi Rafael, Thanks for the patch. Comments below. On 09/02/2018 08:12 PM, Rafael David Tinoco wrote: > Shuah, > > This is a draft only. I will remove summary from the top, run checkers, > etc. Im thinking in replacing membarrier_test entirely with this code > (compatible to existing one). Right n

Re: [PATCH v3] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Jae Hyun Yoo
On 9/21/2018 3:34 PM, Brendan Higgins wrote: @@ -142,7 +142,8 @@ struct aspeed_i2c_bus { /* Synchronizes I/O mem access to base. */ spinlock_t lock; struct completion cmd_complete; - u32 (*get_clk_reg_val

[PATCHv3 6/6] mm/gup: Cache dev_pagemap while pinning pages

2018-09-21 Thread Keith Busch
Pinning pages from ZONE_DEVICE memory needs to check the backing device's live-ness, which is tracked in the device's dev_pagemap metadata. This metadata is stored in a radix tree and looking it up adds measurable software overhead. This patch avoids repeating this relatively costly operation when

[PATCHv3 0/6] mm: faster get user pages

2018-09-21 Thread Keith Busch
Changes since v2: Combine only the output parameters in a struct that need tracking, and squash to just one final kernel patch. Fixed compile bugs for all configs Keith Busch (6): mm/gup_benchmark: Time put_page mm/gup_benchmark: Add additional pinning methods tools/gup_benchmark: Fi

[PATCHv3 2/6] mm/gup_benchmark: Add additional pinning methods

2018-09-21 Thread Keith Busch
This patch provides new gup benchmark ioctl commands to run different user page pinning methods, get_user_pages_longterm and get_user_pages, in addition to the existing get_user_pages_fast. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch --- mm/gup_benchmark.c

[PATCHv3 4/6] tools/gup_benchmark: Allow user specified file

2018-09-21 Thread Keith Busch
The gup benchmark by default maps anonymous memory. This patch allows a user to specify a file to map, providing a means to test various file backings, like device and filesystem DAX. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch --- tools/testing/selftests/v

[PATCHv3 3/6] tools/gup_benchmark: Fix 'write' flag usage

2018-09-21 Thread Keith Busch
If the '-w' parameter was provided, the benchmark would exit due to a mssing 'break'. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch --- tools/testing/selftests/vm/gup_benchmark.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/vm/g

[PATCHv3 5/6] tools/gup_benchmark: Add parameter for hugetlb

2018-09-21 Thread Keith Busch
Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: Keith Busch --- tools/testing/selftests/vm/gup_benchmark.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/vm/gup_benchmark.c b/tools/testing/selftests/vm/gup_benchmark.c index

[PATCHv3 1/6] mm/gup_benchmark: Time put_page

2018-09-21 Thread Keith Busch
We'd like to measure time to unpin user pages, so this adds a second benchmark timer on put_page, separate from get_page. Adding the field will breaks this ioctl ABI, but should be okay since this an in-tree kernel selftest. Cc: Kirill Shutemov Cc: Dave Hansen Cc: Dan Williams Signed-off-by: K

[PATCH v3] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
The function that computes clock parameters from divisors did not respect the maximum size of the bitfields that the parameters were written to. This fixes the bug. This bug can be reproduced with (and this fix verified with) the test at: https://kunit-review.googlesource.com/c/linux/+/1035/ Disc

Re: [PATCH v2] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
On Fri, Sep 21, 2018 at 3:26 PM Jae Hyun Yoo wrote: > > > > + if (base_clk_divisor > ASPEED_I2CD_TIME_BASE_DIVISOR_MASK) { > > + base_clk_divisor = ASPEED_I2CD_TIME_BASE_DIVISOR_MASK; > > + clk_low = clk_high_low_mask; > > + clk_high = clk_high_low_mask; >

Re: [PATCH V3 (resend) 4/7] CIFS: Add support for direct I/O write

2018-09-21 Thread Pavel Shilovsky
чт, 20 сент. 2018 г. в 14:22, Long Li : > > From: Long Li > > With direct I/O write, user supplied buffers are pinned to the memory and data > are transferred directly from user buffers to the transport layer. > > Change in v3: add support for kernel AIO > > Signed-off-by: Long Li > --- > fs/cif

Re: [PATCH] ARM: dts: Add support for Liebherr's BK4 device (vf610 based)

2018-09-21 Thread Stefan Agner
On 21.09.2018 08:27, Lukasz Majewski wrote: > This commit adds DTS support for BK4 device from Liebherr. It > uses vf610 SoC from NXP. > > Signed-off-by: Lukasz Majewski > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/vf610-bk4.dts | 504 > ++

Re: [PATCH v5 0/6] Move swapper_pg_dir to rodata section.

2018-09-21 Thread James Morse
Hi Jun, On 09/17/2018 05:43 AM, Jun Yao wrote: Version 5 changes: 1. Correct spelling and indentation errors[1]. 2. Update init_mm.pgd by assembly[2]. 3. Simplify set_p?d() by introducing set_swapper_pgd()[3]. 4. Reduce unnecessary tlbi for every write to swapper_

Re: [PATCH v2] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Jae Hyun Yoo
Hi, On 9/21/2018 3:10 PM, Brendan Higgins wrote: The function that computes clock parameters from divisors did not respect the maximum size of the bitfields that the parameters were written to. This fixes the bug. This bug can be reproduced with (and this fix verified with) the test at: https:/

Re: [PATCH V3 (resend) 3/7] CIFS: Add support for direct I/O read

2018-09-21 Thread Pavel Shilovsky
чт, 20 сент. 2018 г. в 14:22, Long Li : > > From: Long Li > > With direct I/O read, we transfer the data directly from transport layer to > the user data buffer. > > Change in v3: add support for kernel AIO > > Signed-off-by: Long Li > --- > fs/cifs/cifsfs.h | 1 + > fs/cifs/cifsglob.h | 5

Re: [PATCH] i2c: aspeed: fixed invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
On Fri, Sep 21, 2018 at 10:46 AM Jae Hyun Yoo wrote: > > Hi Brendan, > > nit: > Title in imperative mood. I'd put 'fix' instead of 'fixed'. > > > One minor issue is, 'base_clk_divisor' instead of 'base_clk' could avoid > misreading on this code. > > With that, it looks nice to me. Thanks! > > Rev

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: > On 09/21/2018 11:17 PM, Pavel Machek wrote: > > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > >> Hi Baolin, > >> > >> On 09/21/2018 05:31 AM, Baolin Wang wrote: > >>> Hi Jacek and Pavel, > >>> > >>> On 11 September 2018 at 10:47, Baolin

Re: Linux 4.19-rc4 released, an apology, and a maintainership note

2018-09-21 Thread Michael Woods
Hi Pavel, and how about if we viewed the new Code of Conduct as about the same thing as BitKeeper was for the development process? You should view the Code of Conduct for what it is, as I referenced previously with real world examples, the evidence shows that it is just a ploy to take control

[PATCH] staging: rtlwifi: Use proper enumerated types for Wi-Fi only interface

2018-09-21 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another. drivers/staging/rtlwifi/btcoexist/halbtcoutsrc.c:1264:34: warning: implicit conversion from enumeration type 'enum btc_chip_interface' to different enumeration type 'enum wifionly_chip_interface' [-Wenum-conversion]

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Jacek Anaszewski
On 09/21/2018 11:17 PM, Pavel Machek wrote: > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: >> Hi Baolin, >> >> On 09/21/2018 05:31 AM, Baolin Wang wrote: >>> Hi Jacek and Pavel, >>> >>> On 11 September 2018 at 10:47, Baolin Wang wrote: This patch adds one new led trigger that LED devic

[PATCH v2] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
The function that computes clock parameters from divisors did not respect the maximum size of the bitfields that the parameters were written to. This fixes the bug. This bug can be reproduced with (and this fix verified with) the test at: https://kunit-review.googlesource.com/c/linux/+/1035/ Disc

Re: [PATCH v6 4/5] seccomp: add support for passing fds via USER_NOTIF

2018-09-21 Thread Tycho Andersen
On Fri, Sep 21, 2018 at 11:27:59AM -0700, Andy Lutomirski wrote: > On Fri, Sep 21, 2018 at 6:39 AM Tycho Andersen wrote: > > > > On Thu, Sep 20, 2018 at 07:18:45PM -0700, Andy Lutomirski wrote: > > > > > > I think we just want the operation to cover all the cases. Let PUT_FD > > > take a source f

[PATCH] clk: tegra: Return the exact clock rate from clk_round_rate

2018-09-21 Thread ryang
The current behavior is that clk_round_rate would return the same clock rate passed to it for valid PLL configurations. This change will return the exact rate the PLL will provide in accordance with clk API. Signed-off-by: ryang --- drivers/clk/tegra/clk-pll.c | 7 ++- 1 file changed, 6 inse

[PATCH] clk: tegra: Fix an infinite loop when clock rate is zero

2018-09-21 Thread ryang
Calling clk_set_rate or clk_round_rate will lock up the kernel when the rate is zero. This avoids the infinite loop and uses a slightly more optimized p divider calculation. Signed-off-by: ryang --- drivers/clk/tegra/clk-pll.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --gi

Re: [PATCH] ARM: BCM63XX: Fix incorrect interrupt specifiers

2018-09-21 Thread Florian Fainelli
On Wed, 19 Sep 2018 17:14:01 -0700, Florian Fainelli wrote: > A number of our interrupts were incorrectly specified, fix both the PPI > and SPI interrupts to be correct. > > Fixes: b5762cacc411 ("ARM: bcm63138: add NAND DT support") > Fixes: 46d4bca0445a ("ARM: BCM63XX: add BCM63138 minimal Devi

[PATCH] iio: adc: imx25-gcq: Fix leak of device_node in mx25_gcq_setup_cfgs()

2018-09-21 Thread Alexey Khoroshilov
Leaving for_each_child_of_node loop we should release child device node, if it is not stored for future use. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/iio/adc/fsl-imx25-gcq.c | 6 ++ 1 file changed, 6 insertions(+) diff --g

Re: [PATCH v2, RESEND 2/3] tpm: modify tpm_pcr_read() definition to pass TPM hash algorithms

2018-09-21 Thread Jarkko Sakkinen
On Fri, Sep 21, 2018 at 12:24:15PM +0200, Roberto Sassu wrote: > On 9/17/2018 11:38 AM, Roberto Sassu wrote: > > Currently the TPM driver allows other kernel subsystems to read only the > > SHA1 PCR bank. This patch modifies the parameters of tpm_pcr_read() and > > tpm2_pcr_read() to pass an array

Re: [PATCH v2 2/2] x86/cpu: Change query logic so cpuid is enabled before testing

2018-09-21 Thread Andy Lutomirski
On Fri, Sep 21, 2018 at 2:21 PM Matthew Whitehead wrote: > > Presently we check for cpuid to be enabled first. If it is not already > enabled, then we next call identify_cpu_without_cpuid() and clear > X86_FEATURE_CPUID. > > Unfortunately, identify_cpu_without_cpuid() is the function where cpuid >

Re: [PATCH 2/8] x86/mm/cpa: Move flush_tlb_all()

2018-09-21 Thread Dave Hansen
On 09/19/2018 01:50 AM, Peter Zijlstra wrote: > @@ -1528,28 +1538,8 @@ static int __change_page_attr(struct cpa >* We have to split the large page: >*/ > err = split_large_page(cpa, kpte, address); > - if (!err) { ... > - flush_tlb_all(); > + if (!err) >

Re: [PATCH v3 00/28] selftests/ftrace: Improve ftracetest with coverage check

2018-09-21 Thread Shuah Khan
Hi Masami, On 08/30/2018 08:12 AM, Masami Hiramatsu wrote: > Hi, > > Here is the 3rd version of the series for improving ftracetest > testcase using gcov/lcov. In this version I just fixed some > reported issues and dropped some tests which is not needed. > I also dropped a testcase for blktrace

[PATCH v2 1/2] x86/cpu: Use correct macros for Cyrix calls

2018-09-21 Thread Matthew Whitehead
There are comments in processor-cyrix.h advising you to _not_ make calls using the deprecated macros in this style: setCx86_old(CX86_CCR4, getCx86_old(CX86_CCR4) | 0x80); This is because it expands the macro into a non-functioning calling sequence. The calling order must be: outb(CX86_CCR2,

[PATCH v2 2/2] x86/cpu: Change query logic so cpuid is enabled before testing

2018-09-21 Thread Matthew Whitehead
Presently we check for cpuid to be enabled first. If it is not already enabled, then we next call identify_cpu_without_cpuid() and clear X86_FEATURE_CPUID. Unfortunately, identify_cpu_without_cpuid() is the function where cpuid becomes _enabled_ on Cyrix 6x86/6x86L cpus. So we must reverse the cal

[PATCH v2 0/2] x86/cpu: Enable cpuid on Cyrix 6x86/6x86L processors

2018-09-21 Thread Matthew Whitehead
On power up, the cpuid instruction is disabled on Cyrix 6x86 and 6x86L processors and needs to be enabled. This patchset enables it. Matthew Whitehead (2): x86/cpu: Use correct macros for Cyrix calls x86/cpu: Change query logic so cpuid is enabled before testing arch/x86/kernel/cpu/common.c

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware p

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware p

Re: [PATCHv3 5/7] ARM: dts: exynos5422: use wp-gpio method to detect sd-card

2018-09-21 Thread Krzysztof Kozlowski
On Fri, Sep 21, 2018 at 06:01:07PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On Fri, 21 Sep 2018 at 16:42, Krzysztof Kozlowski wrote: > > > > On Thu, 20 Sep 2018 at 19:59, Anand Moon wrote: > > > > > > add the Write Protect GPIO property for sdcard, to fix > > > the warning message during boo

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware p

[PATCH] ARM: dts: exynos: Add CD and WP pins to Odroid XU SD card

2018-09-21 Thread Krzysztof Kozlowski
Defining card-detect and write-protect GPIO pins in Odroid XU SD Card does not change anything from functional point of view - dw-mmc driver was reading the state from registers. Adding cd-gpios and wp-gpios properties changes only internal driver behavior to access the pins directly. Add them to

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Jacek Anaszewski
Hi Baolin, On 09/21/2018 05:31 AM, Baolin Wang wrote: > Hi Jacek and Pavel, > > On 11 September 2018 at 10:47, Baolin Wang wrote: >> This patch adds one new led trigger that LED device can configure >> the software or hardware pattern and trigger it. >> >> Consumers can write 'pattern' file to e

[PATCH] watchdog/hpwdt: Disable PreTimeout when Timeout is smaller

2018-09-21 Thread Jerry Hoemann
During module install, disable pretimeout if the requested timeout value is not greater than the minimal pretimeout value that is supported by hardware. This makes the module load handling of pretimeout consistent with the ioctl handling of pretimeout. Signed-off-by: Jerry Hoemann --- drivers/w

Re: [PATCH v6 4/5] seccomp: add support for passing fds via USER_NOTIF

2018-09-21 Thread Jann Horn
On Fri, Sep 21, 2018 at 3:39 PM Tycho Andersen wrote: > On Thu, Sep 20, 2018 at 07:18:45PM -0700, Andy Lutomirski wrote: > > On Thu, Sep 20, 2018 at 4:42 PM Tycho Andersen wrote: > > > On Wed, Sep 19, 2018 at 12:58:20PM -0700, Andy Lutomirski wrote: > > > > On Wed, Sep 19, 2018 at 7:38 AM, Tycho

Re: [PATCH 3/5] spi: pxa2xx: use an enum for type

2018-09-21 Thread Robert Jarzmik
Lubomir Rintel writes: > That seems to be the correct type. Okay, but what happens here when adev_id->driver_data is a value out of enum range ? Does the following assignment make sense ? > + type = (enum pxa_ssp_type)adev_id->driver_data; As a side note, could you join for the next

Re: [PATCH] media: cx18: Don't check for address of video_dev

2018-09-21 Thread Nick Desaulniers
On Fri, Sep 21, 2018 at 1:03 PM Nathan Chancellor wrote: > > Clang warns that the address of a pointer will always evaluated as true > in a boolean context. > > drivers/media/pci/cx18/cx18-driver.c:1255:23: warning: address of > 'cx->streams[i].video_dev' will always evaluate to 'true' > [-Wpointe

Re: [patch V3 11/11] x86/mm/cpa: Avoid the 4k pages check completely

2018-09-21 Thread Dave Hansen
On 09/17/2018 07:29 AM, Thomas Gleixner wrote: > + * There used to be a 4k wise evaluation trying really hard to > + * preserve the large pages, but experimentation has shown, that this > + * does not help at all. There might be corner cases which would > + * preserve one large

Re: [patch V3 10/11] x86/mm/cpa: Do the range check early

2018-09-21 Thread Dave Hansen
On 09/17/2018 07:29 AM, Thomas Gleixner wrote: > To avoid excessive 4k wise checks in the common case do a quick check first > whether the requested new page protections conflict with a static > protection area in the large page. If there is no conflict then the > decision whether to preserve or to

[PATCH] scheduler: conditional statement cleanup

2018-09-21 Thread PierceGriffiths
From: Pierce Griffiths *Condense ssequential if statements into a single if statement when they share an outcome *Eliminate a jump instruction by replacing a goto with a return *Eliminate an unnecessary local variable *Replace "if(function or boolean expression) return true else return false" wit

Re: [patch V3 09/11] x86/mm/cpa: Optimize same protection check

2018-09-21 Thread Dave Hansen
On 09/17/2018 07:29 AM, Thomas Gleixner wrote: > When the existing mapping is correct and the new requested page protections > are the same as the existing ones, then further checks can be omitted and the > large page can be preserved. The slow path 4k wise check will not come up with > a different

Re: [PATCH V2 3/3] mmc: sdhci-msm: Use internal voltage control

2018-09-21 Thread Evan Green
On Wed, Sep 19, 2018 at 11:24 PM Veerabhadrarao Badiganti wrote: > > From: Vijay Viswanath > > Some sdhci-msm controllers require that voltage switching be done after > the HW is ready for it. The HW informs its readiness through power irq. > The voltage switching should happen only then. > > Use

Re: [PATCH V2 1/3] mmc: sdhci: Allow platform controlled voltage switching

2018-09-21 Thread Evan Green
On Wed, Sep 19, 2018 at 11:24 PM Veerabhadrarao Badiganti wrote: > > From: Vijay Viswanath > > Some controllers can have internal mechanism to inform the SW that it > is ready for voltage switching. For such controllers, changing voltage > before the HW is ready can result in various issues. > >

Re: [PATCH V2 2/3] dt-bindings: mmc: sdhci-msm: Add entries for passing load values

2018-09-21 Thread Evan Green
On Fri, Sep 21, 2018 at 3:32 AM Veerabhadrarao Badiganti wrote: > > Hi Evan, > > > On 9/21/2018 5:45 AM, Evan Green wrote: > > On Wed, Sep 19, 2018 at 11:24 PM Veerabhadrarao Badiganti > > wrote: > >> From: Vijay Viswanath > >> > >> The load a particular sdhc controller should request from a reg

Re: [patch V3 08/11] x86/mm/cpa: Add sanity check for existing mappings

2018-09-21 Thread Dave Hansen
On 09/17/2018 07:29 AM, Thomas Gleixner wrote: > + /* > + * If this is splitting a PMD, fix it up. PUD splits cannot be > + * fixed trivially as that would require to rescan the newly > + * installed PMD mappings after returning from split_large_page() > + * so an eventual f

[PATCH 00/10] GICv3 support for kexec/kdump on EFI systems

2018-09-21 Thread Marc Zyngier
The GICv3 architecture has the remarkable feature that once LPI tables have been assigned to redistributors and that LPI delivery is enabled, there is no guarantee that LPIs can be turned off (and most implementations do not allow it), nor can it be reprogrammed to use other tables. This is a bit

[PATCH 02/10] irqchip/gic-v3-its: Consolidate LPI_PENDBASE_SZ usage

2018-09-21 Thread Marc Zyngier
LPI_PENDING_SZ is always used in conjunction with a max(). Let's factor this in the definition of the macro, and simplify the rest of the code. Signed-off-by: Marc Zyngier --- drivers/irqchip/irq-gic-v3-its.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/driver

Re: [patch V3 07/11] x86/mm/cpa: Avoid static protection checks on unmap

2018-09-21 Thread Dave Hansen
On 09/17/2018 07:29 AM, Thomas Gleixner wrote: > If the new pgprot has the PRESENT bit cleared, then conflicts vs. RW/NX are > completely irrelevant. Reviewed-by: Dave Hansen

[PATCH 07/10] irqchip/gic-v3-its: Use pre-programmed redistributor tables with kdump kernels

2018-09-21 Thread Marc Zyngier
If using a kdump kernel, and that we cannot disable LPIs to install our own tables, let's switch to using the already allocated tables. This means that we'll change some of the initial kernel's memory, but at least we'll be able to have LPIs in this secondary kernel. Signed-off-by: Marc Zyngier

[PATCH 05/10] irqchip/gic-v3-its: Keep track of property table's PA and VA

2018-09-21 Thread Marc Zyngier
We're currently only tracking the page allocated to contain the property table by its struct page. In the future, it is going to be convenient to track both PA and VA for that page instead. Let's do that. Signed-off-by: Marc Zyngier --- drivers/irqchip/irq-gic-v3-its.c | 23 +--

[PATCH 04/10] irqchip/gic-v3-its: Move pending table allocation to init time

2018-09-21 Thread Marc Zyngier
Pending tables for the redistributors are currently allocated one at a time as each CPU boots. This is causing some grief for Linux/RT (allocation from within a CPU hotplug notifier is frown upon). Let's more this allocation to take place at init time, when we only have a single CPU. It means we'r

[PATCH 09/10] irqchip/gic-v3-its: Register LPI tables with EFI config table

2018-09-21 Thread Marc Zyngier
Upon enabling a redistributor, let's register the allocated tables with the EFI table that tracks the memory reservations. Signed-off-by: Marc Zyngier --- drivers/irqchip/irq-gic-v3-its.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers

[PATCH 03/10] irqchip/gic-v3-its: Split property table clearing from allocation

2018-09-21 Thread Marc Zyngier
As we're going to reuse some pre-allocated memory for the property table, split out the zeroing of that table into a separate function for later use. Signed-off-by: Marc Zyngier --- drivers/irqchip/irq-gic-v3-its.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --

Re: [PATCH v6 03/13] PCI/P2PDMA: Add PCI p2pmem DMA mappings to adjust the bus offset

2018-09-21 Thread Bjorn Helgaas
On Fri, Sep 21, 2018 at 12:13:21PM -0600, Logan Gunthorpe wrote: > On 2018-09-21 10:48 AM, Bjorn Helgaas wrote: > >> I think the use of "map" in this context is slightly confusing because the > >> general expectation is that map/unmap must be balanced. > > Yeah, Jason said the same thing, but havi

[PATCH 08/10] irqchip/gic-v3-its: Check that all RDs have the same property table

2018-09-21 Thread Marc Zyngier
If booting with LPIs enabled, all the redistributors must have the exact same property table. No ifs, no buts. Signed-off-by: Marc Zyngier --- drivers/irqchip/irq-gic-v3-its.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-

[PATCH 10/10] irqchip/gic-v3-its: Allow use of LPI tables in reserved memory

2018-09-21 Thread Marc Zyngier
If the LPI tables have been reserved with the EFI reservation mechanism, we assume that these tables are safe to use even when we find the redistributors to have LPIs enabled at boot time, meaning that kexec can now work with GICv3. You're welcome. Signed-off-by: Marc Zyngier --- drivers/irqchi

[PATCH 01/10] irqchip/gic-v3-its: Change initialization ordering for LPIs

2018-09-21 Thread Marc Zyngier
We currently initialize the LPIs (and the ITS) fairly early, even before the SMP support and the CPU interface. This is a bit odd (as LPIs are not exactly crutial for the early boot process), and is going to cause issues when reorganizing the probing code. Let's move this initialization later. Si

[PATCH 06/10] irqchip/gic-v3-its: Allow use of pre-programmed LPI tables

2018-09-21 Thread Marc Zyngier
In order to cope with kexec and GICv3, let's try and spot when we're booting with LPIs already enabled, and the tables already programmed into the redistributors. This code is currently guarded by a predicate that is always false, meaning this is not functionnal just yet. Signed-off-by: Marc Zyng

Re: [patch V3 06/11] x86/mm/cpa: Add large page preservation statistics

2018-09-21 Thread Dave Hansen
On 09/17/2018 07:29 AM, Thomas Gleixner wrote: > The large page preservation mechanism is just magic and provides no > information at all. Add optional statistic output in debugfs so the magic can > be evaluated. Defaults is off. > > Output: > > 1G pages checked:2 > 1G pages

Re: [PATCH] drivers: mailbox: Make ti-msgmr driver depend on ARCH_K3

2018-09-21 Thread Nishanth Menon
On 00:53-20180828, Nishanth Menon wrote: > ti-msgmr driver can support K3 platforms as well. > > Signed-off-by: Nishanth Menon Jassi, I am assuming as usual, you'd pick it up in v4.19-rc8 or nearabouts.. Just checking to make sure you have no objections. Regards, Nishanth Menon

[PATCH] staging: vc04_services: Remove unused vchiq_genversion script

2018-09-21 Thread Tuomas Tynkkynen
As far as I can tell, this has never been used. Signed-off-by: Tuomas Tynkkynen --- .../interface/vchiq_arm/vchiq_genversion | 88 -- 1 file changed, 88 deletions(-) delete mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_genversion diff --git

Re: [PATCH] clk: keystone: Enable TISCI clocks if K3_ARCH

2018-09-21 Thread Nishanth Menon
gt; > Acked-by: Santosh Shilimkar Since it is almost a month.. Gentle poke? I am not sure when clk gets picked up.. but checked clk-next (7be9338d38a6 Merge branch 'clk-mvebu-periph-pm' into clk-next) and linux-next ( next-20180921 ) and did'nt see the patch.. -- Regards, Nishanth Menon

Re: [PATCH v4 3/5] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-09-21 Thread Pasha Tatashin
On 9/20/18 6:29 PM, Alexander Duyck wrote: > The ZONE_DEVICE pages were being initialized in two locations. One was with > the memory_hotplug lock held and another was outside of that lock. The > problem with this is that it was nearly doubling the memory initialization > time. Instead of doing t

Re: [PATCH 0/5] VFS: Introduce filesystem information query syscall [ver #12]

2018-09-21 Thread Rasmus Villemoes
On 2018-09-21 18:37, David Howells wrote: > > arch/x86/entry/syscalls/syscall_32.tbl |1 > arch/x86/entry/syscalls/syscall_64.tbl |1 > fs/afs/internal.h |1 > fs/afs/super.c | 168 + > fs/hugetlbfs/inode.c |

Re: [PATCHv2 6/7] mm/gup: Combine parameters into struct

2018-09-21 Thread Dan Williams
On Fri, Sep 21, 2018 at 12:45 PM Dan Williams wrote: > > On Thu, Sep 20, 2018 at 1:03 PM Keith Busch wrote: > > > > This will make it easier to add new parameters that we may wish to > > thread through these function calls. > > > > Cc: Kirill Shutemov > > Cc: Dave Hansen > > Cc: Dan Williams >

Re: [PATCHv2 6/7] mm/gup: Combine parameters into struct

2018-09-21 Thread Dan Williams
On Thu, Sep 20, 2018 at 1:03 PM Keith Busch wrote: > > This will make it easier to add new parameters that we may wish to > thread through these function calls. > > Cc: Kirill Shutemov > Cc: Dave Hansen > Cc: Dan Williams > Signed-off-by: Keith Busch > --- > include/linux/huge_mm.h | 12 +--

Re: [RFC PATCH 36/40] arm64: dts: k3-am6: Add "socionext,synquacer-pre-its" property to gic_its

2018-09-21 Thread Nishanth Menon
On 10:21-20180921, Kishon Vijay Abraham I wrote: > GIC_ITS used in AM65x platform has the same configuration as that of > GIC_ITS used in Socionext SoCs. Add "socionext,synquacer-pre-its" > property to get PCI MSI working. > > Signed-off-by: Kishon Vijay Abraham I > -

Re: [PATCH v3 2/2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-09-21 Thread Sibi Sankar
Hi Rohit, On 2018-09-03 17:22, Rohit kumar wrote: This adds Non PAS ADSP PIL driver for Qualcomm Technologies Inc SoCs. Added initial support for SDM845 with ADSP bootup and shutdown operation handled from Application Processor SubSystem(APSS). Signed-off-by: Rohit kumar --- + sel

Re: [PATCH v4 1/5] mm: Provide kernel parameter to allow disabling page init poisoning

2018-09-21 Thread Logan Gunthorpe
On 2018-09-21 1:04 PM, Pasha Tatashin wrote: > >> +pr_err("vm_debug option '%c' unknown. skipped\n", >> + *str); >> +} >> + >> +str++; >> +} >> +out: >> +if (page_init_poisoning && !__page_init_poisoning) >> +

Re: BUG: Bad page map (3)

2018-09-21 Thread Yağmur Oymak
Hello, I see that syzbot found the following crash. syzbot wrote: > BUG: Bad page map in process syz-executor3 pte:8901f947 > pmd:18d73f067 > addr:6b20cb06 vm_flags:180400fb anon_vma: (null) > mapping:7878cb6c index:b7 > file:kcov fault: (null) mmap:kcov_

[PATCH v2] tools/lib/traceevent: Replace str_error_r() with an open coded implementation

2018-09-21 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" While working on having PowerTop use libtracevent as a shared object library, Tzvetomir hit "str_error_r not defined". This was added by commit c3cec9e68f12d ("tools lib traceevent: Use str_error_r()") because strerror_r() has two definitions, where one is GNU spec

Re: [PATCH 0/3] mm: Randomize free memory

2018-09-21 Thread Kees Cook
On Mon, Sep 17, 2018 at 4:12 PM, Andrew Morton wrote: > On Sat, 15 Sep 2018 09:23:02 -0700 Dan Williams > wrote: > >> Data exfiltration attacks via speculative execution and >> return-oriented-programming attacks rely on the ability to infer the >> location of sensitive data objects. The kernel

Re: [PATCH v2 2/2] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

2018-09-21 Thread kbuild test robot
Hi Yi, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v6 0/4] KASLR feature to randomize each loadable module

2018-09-21 Thread Kees Cook
On Thu, Sep 13, 2018 at 2:31 PM, Rick Edgecombe wrote: > This is V6 of the "KASLR feature to randomize each loadable module" patchset. > The purpose is to increase the randomization and also to make the modules > randomized in relation to each other instead of just the base, so that if one > modul

Re: [PATCH v6 2/4] x86/modules: Increase randomization for modules

2018-09-21 Thread Kees Cook
On Thu, Sep 13, 2018 at 2:31 PM, Rick Edgecombe wrote: > This changes the behavior of the KASLR logic for allocating memory for the > text > sections of loadable modules. It randomizes the location of each module text > section with about 17 bits of entropy in typical use. This is enabled on > X

[PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for QCS404

2018-09-21 Thread Vinod Koul
From: Shefali Jain Add the clocks supported in global clock controller which clock the peripherals like BLSPs, SDCC, USB, MDSS etc. Register all the clocks to the clock framework for the clients to be able to request for them. Signed-off-by: Shefali Jain Signed-off-by: Taniya Das Co-developed-

[PATCH 1/2] clk: qcom: Export clk_alpha_pll_configure()

2018-09-21 Thread Vinod Koul
From: Bjorn Andersson This is used by the QCS404 GCC driver, export it to allow that driver to be compiled as a module.. Signed-off-by: Bjorn Andersson Signed-off-by: Vinod Koul --- drivers/clk/qcom/clk-alpha-pll.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/qcom/clk-alpha

Re: [PATCH v6 3/4] vmalloc: Add debugfs modfraginfo

2018-09-21 Thread Kees Cook
On Thu, Sep 13, 2018 at 2:31 PM, Rick Edgecombe wrote: > Add debugfs file "modfraginfo" for providing info on module space > fragmentation. > This can be used for determining if loadable module randomization is causing > any > problems for extreme module loading situations, like huge numbers of

Re: [PATCH v3 1/7] regulator/mfd: Support ROHM BD71847 power management IC

2018-09-21 Thread Lee Jones
On Fri, 21 Sep 2018, Mark Brown wrote: > On Fri, Sep 21, 2018 at 11:02:41AM -0700, Lee Jones wrote: > > On Fri, 21 Sep 2018, Mark Brown wrote: > > > > This looks OK to me - Lee, the patch is almost entirely a regulator one, > > > are you OK with me applying it? > > > The diff in rohm-bd718x7.h d

[PATCH] tools/lib/traceevent: Replace str_error_r() with an open coded implementation

2018-09-21 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" While working on having PowerTop use libtracevent as a shared object library, Tzvetomir hit "str_error_r not defined". This was added by commit c3cec9e68f12d ("tools lib traceevent: Use str_error_r()") because strerror_r() has two definitions, where one is GNU spec

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Mark Brown
On Fri, Sep 21, 2018 at 11:40:24AM -0700, Stephen Boyd wrote: > It seems that everybody has misunderstood my email. Let me try to > clarify. > I'm not saying to replace the sdm845 qspi compatible with a generic one. > I'm recommending that a generic one is added in addition to the SoC > specific

Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

2018-09-21 Thread Doug Anderson
Stephen On Fri, Sep 21, 2018 at 11:40 AM Stephen Boyd wrote: > > Quoting Doug Anderson (2018-09-21 10:40:14) > > Hi, > > > > On Fri, Sep 21, 2018 at 10:31 AM Stephen Boyd wrote: > > > > > > Quoting Ryan Case (2018-09-20 15:40:54) > > > > diff --git > > > > a/Documentation/devicetree/bindings/spi

<    1   2   3   4   5   6   7   >