[PATCH v3] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Gustavo A. R. Silva
There is a potential execution path in which variable *resp_buftype* is passed as an argument to function free_rsp_buf(), in which it is used in a comparison without being properly initialized previously. Fix this by initializing variable *resp_buftype* to CIFS_NO_BUFFER in order to avoid

[PATCH v3] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Gustavo A. R. Silva
There is a potential execution path in which variable *resp_buftype* is passed as an argument to function free_rsp_buf(), in which it is used in a comparison without being properly initialized previously. Fix this by initializing variable *resp_buftype* to CIFS_NO_BUFFER in order to avoid

Re: [PATCH v2 01/11] arch/x86: Start renaming the rdt files to more generic names

2018-10-09 Thread Reinette Chatre
Hi Babu, On 10/9/2018 2:17 PM, Moger, Babu wrote: > On 10/09/2018 11:39 AM, Reinette Chatre wrote: >> Hi Babu, >> >> On 10/5/2018 1:55 PM, Moger, Babu wrote: >>> New generation of AMD processors start support RDT(or QOS) features. >>> With more than one vendors supporting these features, it seems

Re: [PATCH v2 01/11] arch/x86: Start renaming the rdt files to more generic names

2018-10-09 Thread Reinette Chatre
Hi Babu, On 10/9/2018 2:17 PM, Moger, Babu wrote: > On 10/09/2018 11:39 AM, Reinette Chatre wrote: >> Hi Babu, >> >> On 10/5/2018 1:55 PM, Moger, Babu wrote: >>> New generation of AMD processors start support RDT(or QOS) features. >>> With more than one vendors supporting these features, it seems

USLUGI REPETITORA

2018-10-09 Thread Repetitor
USLUGI REPETITORA 1-7 klass. Nizkie ceni 12:55:46 AM

USLUGI REPETITORA

2018-10-09 Thread Repetitor
USLUGI REPETITORA 1-7 klass. Nizkie ceni 12:55:46 AM

Re: [PATCH v2] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Gustavo A. R. Silva
Hey Ronnie, On 10/9/18 11:47 PM, Ronnie Sahlberg wrote: > Good catch, but I think it should be : > > int resp_buftype = CIFS_NO_BUFFER; > Oh okay. I'll send v3 shortly. Thanks for the feedback. -- Gustavo

Re: [PATCH v2] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Gustavo A. R. Silva
Hey Ronnie, On 10/9/18 11:47 PM, Ronnie Sahlberg wrote: > Good catch, but I think it should be : > > int resp_buftype = CIFS_NO_BUFFER; > Oh okay. I'll send v3 shortly. Thanks for the feedback. -- Gustavo

[PATCH v2 2/2] cpufreq: intel_pstate: Add base_frequency attribute

2018-10-09 Thread Srinivas Pandruvada
Present base_frequency to user space via cpufreq sysfs when HWP is in use. This HWP base frequency is read from HWP Capabilities MSR, if platform doesn't have ACPI _CPC object. On most of the HWP platforms the _CPC object will point to the HWP Capabilities MSR using address space id as

[PATCH v2 1/2] ACPI / CPPC: Add support for guaranteed performance

2018-10-09 Thread Srinivas Pandruvada
The Continuous Performance Control Package can have guaranteed performance field. Add support to read guaranteed performance. Signed-off-by: Srinivas Pandruvada --- drivers/acpi/cppc_acpi.c | 8 ++-- include/acpi/cppc_acpi.h | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff

Re: [PATCH v2] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Ronnie Sahlberg
Good catch, but I think it should be : int resp_buftype = CIFS_NO_BUFFER; - Original Message - From: "Gustavo A. R. Silva" To: "Steve French" , "Ronnie Sahlberg" Cc: linux-c...@vger.kernel.org, samba-techni...@lists.samba.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva"

[PATCH v2 2/2] cpufreq: intel_pstate: Add base_frequency attribute

2018-10-09 Thread Srinivas Pandruvada
Present base_frequency to user space via cpufreq sysfs when HWP is in use. This HWP base frequency is read from HWP Capabilities MSR, if platform doesn't have ACPI _CPC object. On most of the HWP platforms the _CPC object will point to the HWP Capabilities MSR using address space id as

[PATCH v2 1/2] ACPI / CPPC: Add support for guaranteed performance

2018-10-09 Thread Srinivas Pandruvada
The Continuous Performance Control Package can have guaranteed performance field. Add support to read guaranteed performance. Signed-off-by: Srinivas Pandruvada --- drivers/acpi/cppc_acpi.c | 8 ++-- include/acpi/cppc_acpi.h | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff

Re: [PATCH v2] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Ronnie Sahlberg
Good catch, but I think it should be : int resp_buftype = CIFS_NO_BUFFER; - Original Message - From: "Gustavo A. R. Silva" To: "Steve French" , "Ronnie Sahlberg" Cc: linux-c...@vger.kernel.org, samba-techni...@lists.samba.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva"

[PATCH v2 0/2] cpufreq: intel_pstate: Base frequency attribute

2018-10-09 Thread Srinivas Pandruvada
This series presents base frequency to cpufreq sysfs when intel_pstate is in use in HWP mode. Changes: v2 - Removed guaranteed attribute addition to acpi_cppc sysfs - Using the cppc_acpi interface to get base frequency and present Srinivas Pandruvada (2): ACPI / CPPC: Add support for

[PATCH v2 0/2] cpufreq: intel_pstate: Base frequency attribute

2018-10-09 Thread Srinivas Pandruvada
This series presents base frequency to cpufreq sysfs when intel_pstate is in use in HWP mode. Changes: v2 - Removed guaranteed attribute addition to acpi_cppc sysfs - Using the cppc_acpi interface to get base frequency and present Srinivas Pandruvada (2): ACPI / CPPC: Add support for

Re: [PATCH v3 8/8] watchdog: stpmic1: add stpmic1 watchdog driver

2018-10-09 Thread Guenter Roeck
On Tue, Oct 09, 2018 at 08:47:26AM +0800, kbuild test robot wrote: > Hi pascal, > > Thank you for the patch! Perhaps something to improve: > [ ... ] > 42 > 43static int pmic_wdt_stop(struct watchdog_device *wdd) > 44{ > 45struct

Re: [PATCH v3 8/8] watchdog: stpmic1: add stpmic1 watchdog driver

2018-10-09 Thread Guenter Roeck
On Tue, Oct 09, 2018 at 08:47:26AM +0800, kbuild test robot wrote: > Hi pascal, > > Thank you for the patch! Perhaps something to improve: > [ ... ] > 42 > 43static int pmic_wdt_stop(struct watchdog_device *wdd) > 44{ > 45struct

Re: perf report segfault

2018-10-09 Thread Jiri Olsa
On Tue, Oct 09, 2018 at 03:18:12PM -0500, Anthony LaTorre wrote: > Ok, I can reliably reproduce it by profiling the following program: > > #include > > int main(int argc, char **argv) > { > int i; > double sum; > > while (1) { > sum += exp(++i); > } > > return 0; >

Re: perf report segfault

2018-10-09 Thread Jiri Olsa
On Tue, Oct 09, 2018 at 03:18:12PM -0500, Anthony LaTorre wrote: > Ok, I can reliably reproduce it by profiling the following program: > > #include > > int main(int argc, char **argv) > { > int i; > double sum; > > while (1) { > sum += exp(++i); > } > > return 0; >

Re: R8169: Network lockups in 4.18.{8,9,10} (and 4.19 dev)

2018-10-09 Thread Heiner Kallweit
On 09.10.2018 16:40, Chris Clayton wrote: > Thanks to Maciej and Heiner for their replies. > > On 09/10/2018 13:32, Maciej S. Szmigiero wrote: >> On 07.10.2018 21:36, Chris Clayton wrote: >>> Hi again, >>> >>> I didn't think there was anything in 4.19-rc7 to fix this regression, but >>> tried it

[tip:x86/mm 3/4] htmldocs: kernel/resource.c:338: warning: Function parameter or member 'start' not described in 'find_next_iomem_res'

2018-10-09 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/mm head: b69c2e20f6e4046da84ce5b33ba1ef89cb087b40 commit: 010a93bf97c72f43aac664d0a685942f83d1a103 [3/4] resource: Fix find_next_iomem_res() iteration issue reproduce: make htmldocs All warnings (new ones prefixed by >>):

Re: R8169: Network lockups in 4.18.{8,9,10} (and 4.19 dev)

2018-10-09 Thread Heiner Kallweit
On 09.10.2018 16:40, Chris Clayton wrote: > Thanks to Maciej and Heiner for their replies. > > On 09/10/2018 13:32, Maciej S. Szmigiero wrote: >> On 07.10.2018 21:36, Chris Clayton wrote: >>> Hi again, >>> >>> I didn't think there was anything in 4.19-rc7 to fix this regression, but >>> tried it

[tip:x86/mm 3/4] htmldocs: kernel/resource.c:338: warning: Function parameter or member 'start' not described in 'find_next_iomem_res'

2018-10-09 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/mm head: b69c2e20f6e4046da84ce5b33ba1ef89cb087b40 commit: 010a93bf97c72f43aac664d0a685942f83d1a103 [3/4] resource: Fix find_next_iomem_res() iteration issue reproduce: make htmldocs All warnings (new ones prefixed by >>):

Re: [PATCH] mm: Speed up mremap on large regions

2018-10-09 Thread Andrew Morton
On Tue, 9 Oct 2018 13:14:00 -0700 "Joel Fernandes (Google)" wrote: > Android needs to mremap large regions of memory during memory management > related operations. The mremap system call can be really slow if THP is > not enabled. The bottleneck is move_page_tables, which is copying each > pte

Re: [PATCH] mm: Speed up mremap on large regions

2018-10-09 Thread Andrew Morton
On Tue, 9 Oct 2018 13:14:00 -0700 "Joel Fernandes (Google)" wrote: > Android needs to mremap large regions of memory during memory management > related operations. The mremap system call can be really slow if THP is > not enabled. The bottleneck is move_page_tables, which is copying each > pte

Re: perf report segfault

2018-10-09 Thread Jiri Olsa
On Tue, Oct 09, 2018 at 01:54:48PM -0500, Anthony LaTorre wrote: > Can you reproduce the segfault from the perf.data file I provided? nope, but if it's dwarf callchain related I'd need perf archive output to reproduce.. please run: --- $ perf record ... $ perf archive Now please run: $

Re: perf report segfault

2018-10-09 Thread Jiri Olsa
On Tue, Oct 09, 2018 at 01:54:48PM -0500, Anthony LaTorre wrote: > Can you reproduce the segfault from the perf.data file I provided? nope, but if it's dwarf callchain related I'd need perf archive output to reproduce.. please run: --- $ perf record ... $ perf archive Now please run: $

[PATCH] ARM: dts: rv1108-evb: enable eMMC support

2018-10-09 Thread Otavio Salvador
Enable eMMC support for rv1108 evaluation board. Signed-off-by: Otavio Salvador --- arch/arm/boot/dts/rv1108-evb.dts | 8 arch/arm/boot/dts/rv1108.dtsi| 29 + 2 files changed, 37 insertions(+) diff --git a/arch/arm/boot/dts/rv1108-evb.dts

[PATCH] ARM: dts: rv1108-evb: enable eMMC support

2018-10-09 Thread Otavio Salvador
Enable eMMC support for rv1108 evaluation board. Signed-off-by: Otavio Salvador --- arch/arm/boot/dts/rv1108-evb.dts | 8 arch/arm/boot/dts/rv1108.dtsi| 29 + 2 files changed, 37 insertions(+) diff --git a/arch/arm/boot/dts/rv1108-evb.dts

Re: [RFC PATCH] kernel/panic: Filter out a potential trailing newline

2018-10-09 Thread Steven Rostedt
On Tue, 9 Oct 2018 22:50:19 +0200 Borislav Petkov wrote: > From: Borislav Petkov > > If a call to panic() terminates the string with a \n, the result puts > the closing brace ']---' on a newline because panic() itself adds \n > too. > > Now, if one goes and removes the newline chars from all

Re: [RFC PATCH] kernel/panic: Filter out a potential trailing newline

2018-10-09 Thread Steven Rostedt
On Tue, 9 Oct 2018 22:50:19 +0200 Borislav Petkov wrote: > From: Borislav Petkov > > If a call to panic() terminates the string with a \n, the result puts > the closing brace ']---' on a newline because panic() itself adds \n > too. > > Now, if one goes and removes the newline chars from all

Re: [RFC] perf tools: Wrong filter_band* values in json calculation"

2018-10-09 Thread Andi Kleen
On Tue, Oct 09, 2018 at 12:01:44PM +0200, Jiri Olsa wrote: > On Wed, Oct 03, 2018 at 07:45:50AM -0700, Andi Kleen wrote: > > > note there's couple of changes that actually changed > > > the number completely, like: > > > > > > -"Filter": "edge=1,filter_band2=4000", > > > +

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-09 Thread Dan Williams
On Tue, Oct 9, 2018 at 1:34 PM Alexander Duyck wrote: > > On 10/9/2018 11:04 AM, Dan Williams wrote: > > On Tue, Oct 9, 2018 at 3:21 AM Yi Zhang wrote: [..] > > That comment is incorrect, device-pages are never onlined. So I think > > we can just skip that call to __SetPageReserved() unless the

Re: [RFC] perf tools: Wrong filter_band* values in json calculation"

2018-10-09 Thread Andi Kleen
On Tue, Oct 09, 2018 at 12:01:44PM +0200, Jiri Olsa wrote: > On Wed, Oct 03, 2018 at 07:45:50AM -0700, Andi Kleen wrote: > > > note there's couple of changes that actually changed > > > the number completely, like: > > > > > > -"Filter": "edge=1,filter_band2=4000", > > > +

Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap

2018-10-09 Thread Dan Williams
On Tue, Oct 9, 2018 at 1:34 PM Alexander Duyck wrote: > > On 10/9/2018 11:04 AM, Dan Williams wrote: > > On Tue, Oct 9, 2018 at 3:21 AM Yi Zhang wrote: [..] > > That comment is incorrect, device-pages are never onlined. So I think > > we can just skip that call to __SetPageReserved() unless the

Re: [PATCH] printk: inject caller information into the body of message

2018-10-09 Thread Tetsuo Handa
On 2018/10/09 23:52, Petr Mladek wrote: > On Tue 2018-10-09 05:48:33, Tetsuo Handa wrote: >> On 2018/10/09 1:03, Petr Mladek wrote: >>> On Mon 2018-10-08 19:31:58, Tetsuo Handa wrote: A structure named "struct printk_buffer" is introduced for buffering up to LOG_LINE_MAX bytes of

Re: [PATCH] printk: inject caller information into the body of message

2018-10-09 Thread Tetsuo Handa
On 2018/10/09 23:52, Petr Mladek wrote: > On Tue 2018-10-09 05:48:33, Tetsuo Handa wrote: >> On 2018/10/09 1:03, Petr Mladek wrote: >>> On Mon 2018-10-08 19:31:58, Tetsuo Handa wrote: A structure named "struct printk_buffer" is introduced for buffering up to LOG_LINE_MAX bytes of

Re: [PATCH V5 3/3] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

2018-10-09 Thread Doug Anderson
Hi, On Tue, Oct 9, 2018 at 12:45 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2018-10-09 10:48:55) > > > > Ah, you're suggesting separating the platform_get_irq() and the > > request_irq() so that we call platform_get_irq() as the first thing in > > the function but don't do the

Re: [PATCH V5 3/3] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

2018-10-09 Thread Doug Anderson
Hi, On Tue, Oct 9, 2018 at 12:45 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2018-10-09 10:48:55) > > > > Ah, you're suggesting separating the platform_get_irq() and the > > request_irq() so that we call platform_get_irq() as the first thing in > > the function but don't do the

Re: [PATCH v2 01/11] arch/x86: Start renaming the rdt files to more generic names

2018-10-09 Thread Moger, Babu
Hi Reinette, On 10/09/2018 11:39 AM, Reinette Chatre wrote: > Hi Babu, > > On 10/5/2018 1:55 PM, Moger, Babu wrote: >> New generation of AMD processors start support RDT(or QOS) features. >> With more than one vendors supporting these features, it seems more >> appropriate to rename these files.

Re: [PATCH v2 01/11] arch/x86: Start renaming the rdt files to more generic names

2018-10-09 Thread Moger, Babu
Hi Reinette, On 10/09/2018 11:39 AM, Reinette Chatre wrote: > Hi Babu, > > On 10/5/2018 1:55 PM, Moger, Babu wrote: >> New generation of AMD processors start support RDT(or QOS) features. >> With more than one vendors supporting these features, it seems more >> appropriate to rename these files.

Re: [RFC PATCH] kernel/panic: Filter out a potential trailing newline

2018-10-09 Thread Kees Cook
On Tue, Oct 9, 2018 at 1:50 PM, Borislav Petkov wrote: > From: Borislav Petkov > > If a call to panic() terminates the string with a \n, the result puts > the closing brace ']---' on a newline because panic() itself adds \n > too. > > Now, if one goes and removes the newline chars from all

Re: [RFC PATCH] kernel/panic: Filter out a potential trailing newline

2018-10-09 Thread Kees Cook
On Tue, Oct 9, 2018 at 1:50 PM, Borislav Petkov wrote: > From: Borislav Petkov > > If a call to panic() terminates the string with a \n, the result puts > the closing brace ']---' on a newline because panic() itself adds \n > too. > > Now, if one goes and removes the newline chars from all

Re: [PATCH 4.18 000/168] 4.18.13-stable review

2018-10-09 Thread Guenter Roeck
On Mon, Oct 08, 2018 at 08:29:40PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.18.13 release. > There are 168 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.18 000/168] 4.18.13-stable review

2018-10-09 Thread Guenter Roeck
On Mon, Oct 08, 2018 at 08:29:40PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.18.13 release. > There are 168 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.14 00/94] 4.14.75-stable review

2018-10-09 Thread Guenter Roeck
On Mon, Oct 08, 2018 at 08:30:41PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.75 release. > There are 94 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.14 00/94] 4.14.75-stable review

2018-10-09 Thread Guenter Roeck
On Mon, Oct 08, 2018 at 08:30:41PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.75 release. > There are 94 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.9 00/59] 4.9.132-stable review

2018-10-09 Thread Guenter Roeck
On Mon, Oct 08, 2018 at 08:31:07PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.132 release. > There are 59 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.9 00/59] 4.9.132-stable review

2018-10-09 Thread Guenter Roeck
On Mon, Oct 08, 2018 at 08:31:07PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.132 release. > There are 59 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.4 000/113] 4.4.160-stable review

2018-10-09 Thread Guenter Roeck
On Mon, Oct 08, 2018 at 08:30:01PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.160 release. > There are 113 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.4 000/113] 4.4.160-stable review

2018-10-09 Thread Guenter Roeck
On Mon, Oct 08, 2018 at 08:30:01PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.160 release. > There are 113 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

livelock with hrtimer cpu_base->lock

2018-10-09 Thread Sodagudi Prasad
Hi Will, This is regarding - thread "try to fix contention between expire_timers and try_to_del_timer_sync". https://lkml.org/lkml/2017/7/28/172 I think this live lockup issue was discussed earlier but the final set of changes were not concluded. I would like to check whether you have new

livelock with hrtimer cpu_base->lock

2018-10-09 Thread Sodagudi Prasad
Hi Will, This is regarding - thread "try to fix contention between expire_timers and try_to_del_timer_sync". https://lkml.org/lkml/2017/7/28/172 I think this live lockup issue was discussed earlier but the final set of changes were not concluded. I would like to check whether you have new

Re: [PATCH v6] clk: qcom: Add lpass clock controller driver for SDM845

2018-10-09 Thread Stephen Boyd
Quoting Taniya Das (2018-10-09 10:26:38) > Hello Stephen, > > On 10/8/2018 8:14 AM, Stephen Boyd wrote: > > Quoting Taniya Das (2018-10-04 05:02:26) > >> Add support for the lpass clock controller found on SDM845 based devices. > >> This would allow lpass peripheral loader drivers to control the

Re: [PATCH v6] clk: qcom: Add lpass clock controller driver for SDM845

2018-10-09 Thread Stephen Boyd
Quoting Taniya Das (2018-10-09 10:26:38) > Hello Stephen, > > On 10/8/2018 8:14 AM, Stephen Boyd wrote: > > Quoting Taniya Das (2018-10-04 05:02:26) > >> Add support for the lpass clock controller found on SDM845 based devices. > >> This would allow lpass peripheral loader drivers to control the

[RFC PATCH] kernel/panic: Filter out a potential trailing newline

2018-10-09 Thread Borislav Petkov
From: Borislav Petkov If a call to panic() terminates the string with a \n, the result puts the closing brace ']---' on a newline because panic() itself adds \n too. Now, if one goes and removes the newline chars from all panic() invocations - and the stats right now look like this: ~300 calls

[RFC PATCH] kernel/panic: Filter out a potential trailing newline

2018-10-09 Thread Borislav Petkov
From: Borislav Petkov If a call to panic() terminates the string with a \n, the result puts the closing brace ']---' on a newline because panic() itself adds \n too. Now, if one goes and removes the newline chars from all panic() invocations - and the stats right now look like this: ~300 calls

Re: [PATCH v1 1/2] clk: qcom: rcg2: Add support for display port clock ops

2018-10-09 Thread Stephen Boyd
Quoting Taniya Das (2018-10-09 06:57:46) > diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c > index 6e3bd19..ca6142f 100644 > --- a/drivers/clk/qcom/clk-rcg2.c > +++ b/drivers/clk/qcom/clk-rcg2.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include Can you

Re: [PATCH v1 1/2] clk: qcom: rcg2: Add support for display port clock ops

2018-10-09 Thread Stephen Boyd
Quoting Taniya Das (2018-10-09 06:57:46) > diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c > index 6e3bd19..ca6142f 100644 > --- a/drivers/clk/qcom/clk-rcg2.c > +++ b/drivers/clk/qcom/clk-rcg2.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include Can you

Re: [PATCH v2 07/11] arch/x86: Initialize the resource functions that are different

2018-10-09 Thread Moger, Babu
On 10/09/2018 12:18 PM, Reinette Chatre wrote: > Hi Babu, > > On 10/5/2018 1:55 PM, Moger, Babu wrote: >> diff --git a/arch/x86/kernel/cpu/rdt_ctrlmondata.c >> b/arch/x86/kernel/cpu/rdt_ctrlmondata.c >> index 812cc5c5e39e..ee3e8389d8d2 100644 >> --- a/arch/x86/kernel/cpu/rdt_ctrlmondata.c >>

Re: [PATCH v2 07/11] arch/x86: Initialize the resource functions that are different

2018-10-09 Thread Moger, Babu
On 10/09/2018 12:18 PM, Reinette Chatre wrote: > Hi Babu, > > On 10/5/2018 1:55 PM, Moger, Babu wrote: >> diff --git a/arch/x86/kernel/cpu/rdt_ctrlmondata.c >> b/arch/x86/kernel/cpu/rdt_ctrlmondata.c >> index 812cc5c5e39e..ee3e8389d8d2 100644 >> --- a/arch/x86/kernel/cpu/rdt_ctrlmondata.c >>

Re: [RESEND][PATCH] ACPI / CPPC: Add support for guaranteed performance

2018-10-09 Thread Srinivas Pandruvada
On Tue, 2018-10-09 at 09:35 +0200, Rafael J. Wysocki wrote: > On Mon, Oct 8, 2018 at 6:55 PM Srinivas Pandruvada > wrote: > > > > The Continuous Performance Control Package can have guaranteed > > performance > > field. Add support to read guaranteed performance. > > The spec says that it is

Re: [RESEND][PATCH] ACPI / CPPC: Add support for guaranteed performance

2018-10-09 Thread Srinivas Pandruvada
On Tue, 2018-10-09 at 09:35 +0200, Rafael J. Wysocki wrote: > On Mon, Oct 8, 2018 at 6:55 PM Srinivas Pandruvada > wrote: > > > > The Continuous Performance Control Package can have guaranteed > > performance > > field. Add support to read guaranteed performance. > > The spec says that it is

[PATCH v2] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Gustavo A. R. Silva
There is a potential execution path in which variable *resp_buftype* is passed as an argument to function free_rsp_buf(), in which it is used in a comparison without being properly initialized previously. Fix this by initializing variable *resp_buftype* to -1 in order to avoid unpredictable or

[PATCH v2] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Gustavo A. R. Silva
There is a potential execution path in which variable *resp_buftype* is passed as an argument to function free_rsp_buf(), in which it is used in a comparison without being properly initialized previously. Fix this by initializing variable *resp_buftype* to -1 in order to avoid unpredictable or

Re: R8169: Network lockups in 4.18.{8,9,10} (and 4.19 dev)

2018-10-09 Thread Heiner Kallweit
On 09.10.2018 16:40, Chris Clayton wrote: > Thanks to Maciej and Heiner for their replies. > > On 09/10/2018 13:32, Maciej S. Szmigiero wrote: >> On 07.10.2018 21:36, Chris Clayton wrote: >>> Hi again, >>> >>> I didn't think there was anything in 4.19-rc7 to fix this regression, but >>> tried it

Re: R8169: Network lockups in 4.18.{8,9,10} (and 4.19 dev)

2018-10-09 Thread Heiner Kallweit
On 09.10.2018 16:40, Chris Clayton wrote: > Thanks to Maciej and Heiner for their replies. > > On 09/10/2018 13:32, Maciej S. Szmigiero wrote: >> On 07.10.2018 21:36, Chris Clayton wrote: >>> Hi again, >>> >>> I didn't think there was anything in 4.19-rc7 to fix this regression, but >>> tried it

Re: [PATCH v1 2/2] clk: qcom : dispcc: Add support for display port clocks

2018-10-09 Thread Stephen Boyd
Quoting Taniya Das (2018-10-09 06:57:47) > diff --git a/drivers/clk/qcom/dispcc-sdm845.c > b/drivers/clk/qcom/dispcc-sdm845.c > index 0cc4909..6d3136a 100644 > --- a/drivers/clk/qcom/dispcc-sdm845.c > +++ b/drivers/clk/qcom/dispcc-sdm845.c > @@ -128,6 +144,100 @@ enum { > }, > }; > >

Re: [PATCH v1 2/2] clk: qcom : dispcc: Add support for display port clocks

2018-10-09 Thread Stephen Boyd
Quoting Taniya Das (2018-10-09 06:57:47) > diff --git a/drivers/clk/qcom/dispcc-sdm845.c > b/drivers/clk/qcom/dispcc-sdm845.c > index 0cc4909..6d3136a 100644 > --- a/drivers/clk/qcom/dispcc-sdm845.c > +++ b/drivers/clk/qcom/dispcc-sdm845.c > @@ -128,6 +144,100 @@ enum { > }, > }; > >

Re: perf report segfault

2018-10-09 Thread Anthony LaTorre
Ok, I can reliably reproduce it by profiling the following program: #include int main(int argc, char **argv) { int i; double sum; while (1) { sum += exp(++i); } return 0; } compiled with: $ cc -o test test.c -lm with the following command: $ perf record -F 99

Re: perf report segfault

2018-10-09 Thread Anthony LaTorre
Ok, I can reliably reproduce it by profiling the following program: #include int main(int argc, char **argv) { int i; double sum; while (1) { sum += exp(++i); } return 0; } compiled with: $ cc -o test test.c -lm with the following command: $ perf record -F 99

You must not Ignore

2018-10-09 Thread wayne
Foremost, we introduce this commission, The INTERPOL. We fight global crime including internet fraud and money laundering. Our commission has rounded-up well over 27,000 fraudsters and we are still battling these nefarious individuals. We are aware that quite a lot of people have been conned

You must not Ignore

2018-10-09 Thread wayne
Foremost, we introduce this commission, The INTERPOL. We fight global crime including internet fraud and money laundering. Our commission has rounded-up well over 27,000 fraudsters and we are still battling these nefarious individuals. We are aware that quite a lot of people have been conned

[PATCH] mm: Speed up mremap on large regions

2018-10-09 Thread Joel Fernandes (Google)
Android needs to mremap large regions of memory during memory management related operations. The mremap system call can be really slow if THP is not enabled. The bottleneck is move_page_tables, which is copying each pte at a time, and can be really slow across a large map. Turning on THP may not

[PATCH] mm: Speed up mremap on large regions

2018-10-09 Thread Joel Fernandes (Google)
Android needs to mremap large regions of memory during memory management related operations. The mremap system call can be really slow if THP is not enabled. The bottleneck is move_page_tables, which is copying each pte at a time, and can be really slow across a large map. Turning on THP may not

Re: [PATCH] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Gustavo A. R. Silva
On 10/9/18 10:07 PM, Gustavo A. R. Silva wrote: > There is a potential execution path in which variable *resp_buftype* > is passed as an argument to function free_rsp_buf(), in which is used > without being properly initialized previously. > > Fix this by initializing variable *resp_buftype*

Re: [PATCH] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Gustavo A. R. Silva
On 10/9/18 10:07 PM, Gustavo A. R. Silva wrote: > There is a potential execution path in which variable *resp_buftype* > is passed as an argument to function free_rsp_buf(), in which is used > without being properly initialized previously. > > Fix this by initializing variable *resp_buftype*

[PATCH] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Gustavo A. R. Silva
There is a potential execution path in which variable *resp_buftype* is passed as an argument to function free_rsp_buf(), in which is used without being properly initialized previously. Fix this by initializing variable *resp_buftype* to -1 in order to avoid unpredictable or unintended results.

[PATCH] smb2: fix uninitialized variable bug in smb2_ioctl_query_info

2018-10-09 Thread Gustavo A. R. Silva
There is a potential execution path in which variable *resp_buftype* is passed as an argument to function free_rsp_buf(), in which is used without being properly initialized previously. Fix this by initializing variable *resp_buftype* to -1 in order to avoid unpredictable or unintended results.

Re: Insanely high baud rates

2018-10-09 Thread H. Peter Anvin
On 10/09/18 12:51, Willy Tarreau wrote: > On Tue, Oct 09, 2018 at 12:19:04PM -0700, H. Peter Anvin wrote: >> [Resending to a wider audience] >> >> In trying to get the termios2 interface actually implemented in glibc, >> the question came up if we will ever care about baud rates in excess of >> 4

Re: Insanely high baud rates

2018-10-09 Thread H. Peter Anvin
On 10/09/18 12:51, Willy Tarreau wrote: > On Tue, Oct 09, 2018 at 12:19:04PM -0700, H. Peter Anvin wrote: >> [Resending to a wider audience] >> >> In trying to get the termios2 interface actually implemented in glibc, >> the question came up if we will ever care about baud rates in excess of >> 4

Re: [PATCH] PCI/portdrv: Enable error reporting on managed ports

2018-10-09 Thread Derrick, Jonathan
Hi Bjorn, On Tue, 2018-10-09 at 12:56 -0500, Bjorn Helgaas wrote: > On Tue, Sep 04, 2018 at 12:33:09PM -0600, Jon Derrick wrote: > > During probe, the port driver will disable error reporting and > > assumes > > it will be enabled later by the AER driver's pci_walk_bus() > > sequence. > > This

Re: [PATCH] PCI/portdrv: Enable error reporting on managed ports

2018-10-09 Thread Derrick, Jonathan
Hi Bjorn, On Tue, 2018-10-09 at 12:56 -0500, Bjorn Helgaas wrote: > On Tue, Sep 04, 2018 at 12:33:09PM -0600, Jon Derrick wrote: > > During probe, the port driver will disable error reporting and > > assumes > > it will be enabled later by the AER driver's pci_walk_bus() > > sequence. > > This

Re: Insanely high baud rates

2018-10-09 Thread Willy Tarreau
On Tue, Oct 09, 2018 at 12:19:04PM -0700, H. Peter Anvin wrote: > [Resending to a wider audience] > > In trying to get the termios2 interface actually implemented in glibc, > the question came up if we will ever care about baud rates in excess of > 4 Gbps, even in the relatively remote future. >

Re: Insanely high baud rates

2018-10-09 Thread Willy Tarreau
On Tue, Oct 09, 2018 at 12:19:04PM -0700, H. Peter Anvin wrote: > [Resending to a wider audience] > > In trying to get the termios2 interface actually implemented in glibc, > the question came up if we will ever care about baud rates in excess of > 4 Gbps, even in the relatively remote future. >

Re: [PATCH V5 3/3] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

2018-10-09 Thread Stephen Boyd
Quoting Doug Anderson (2018-10-09 10:48:55) > > Ah, you're suggesting separating the platform_get_irq() and the > request_irq() so that we call platform_get_irq() as the first thing in > the function but don't do the request_irq() until later. Yeah, that > could be done and I guess if you feel

Re: [PATCH V5 3/3] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

2018-10-09 Thread Stephen Boyd
Quoting Doug Anderson (2018-10-09 10:48:55) > > Ah, you're suggesting separating the platform_get_irq() and the > request_irq() so that we call platform_get_irq() as the first thing in > the function but don't do the request_irq() until later. Yeah, that > could be done and I guess if you feel

Re: [Ksummit-discuss] [PATCH 1/2] code-of-conduct: Fix the ambiguity about collecting email addresses

2018-10-09 Thread James Bottomley
On Tue, 2018-10-09 at 22:38 +0300, Laurent Pinchart wrote: > Hi Josh, > > On Tuesday, 9 October 2018 21:56:23 EEST Josh Triplett wrote: > > On Tue, Oct 09, 2018 at 08:29:24PM +0200, Rainer Fiebig wrote: > > > Am Montag, 8. Oktober 2018, 08:20:44 schrieb Josh Triplett: > > > > On Sat, Oct 06, 2018

Re: [Ksummit-discuss] [PATCH 1/2] code-of-conduct: Fix the ambiguity about collecting email addresses

2018-10-09 Thread James Bottomley
On Tue, 2018-10-09 at 22:38 +0300, Laurent Pinchart wrote: > Hi Josh, > > On Tuesday, 9 October 2018 21:56:23 EEST Josh Triplett wrote: > > On Tue, Oct 09, 2018 at 08:29:24PM +0200, Rainer Fiebig wrote: > > > Am Montag, 8. Oktober 2018, 08:20:44 schrieb Josh Triplett: > > > > On Sat, Oct 06, 2018

[PATCH net-next 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init

2018-10-09 Thread Gustavo A. R. Silva
In case memory resources for *fw* were successfully allocated, release them before return. Addresses-Coverity-ID: 1473968 ("Resource leak") Fixes: 00d70d8e0e78 ("net: phy: mscc: add support for VSC8574 PHY") Signed-off-by: Gustavo A. R. Silva --- drivers/net/phy/mscc.c | 4 ++-- 1 file changed,

[PATCH net-next 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init

2018-10-09 Thread Gustavo A. R. Silva
In case memory resources for *fw* were successfully allocated, release them before return. Addresses-Coverity-ID: 1473968 ("Resource leak") Fixes: 00d70d8e0e78 ("net: phy: mscc: add support for VSC8574 PHY") Signed-off-by: Gustavo A. R. Silva --- drivers/net/phy/mscc.c | 4 ++-- 1 file changed,

Re: [Ksummit-discuss] [PATCH 1/2] code-of-conduct: Fix the ambiguity about collecting email addresses

2018-10-09 Thread Laurent Pinchart
Hi Josh, On Tuesday, 9 October 2018 21:56:23 EEST Josh Triplett wrote: > On Tue, Oct 09, 2018 at 08:29:24PM +0200, Rainer Fiebig wrote: > > Am Montag, 8. Oktober 2018, 08:20:44 schrieb Josh Triplett: > >> On Sat, Oct 06, 2018 at 02:36:39PM -0700, James Bottomley wrote: > >>> The current code of

[PATCH net-next 1/2] net: phy: mscc: fix signedness bug in vsc85xx_downshift_get

2018-10-09 Thread Gustavo A. R. Silva
Currently, the error handling for the call to function phy_read_paged() doesn't work because *reg_val* is of type u16 (16 bits, unsigned), which makes it impossible for it to hold a value less than 0. Fix this by changing the type of variable *reg_val* to int. Addresses-Coverity-ID: 1473970

Re: [Ksummit-discuss] [PATCH 1/2] code-of-conduct: Fix the ambiguity about collecting email addresses

2018-10-09 Thread Laurent Pinchart
Hi Josh, On Tuesday, 9 October 2018 21:56:23 EEST Josh Triplett wrote: > On Tue, Oct 09, 2018 at 08:29:24PM +0200, Rainer Fiebig wrote: > > Am Montag, 8. Oktober 2018, 08:20:44 schrieb Josh Triplett: > >> On Sat, Oct 06, 2018 at 02:36:39PM -0700, James Bottomley wrote: > >>> The current code of

[PATCH net-next 1/2] net: phy: mscc: fix signedness bug in vsc85xx_downshift_get

2018-10-09 Thread Gustavo A. R. Silva
Currently, the error handling for the call to function phy_read_paged() doesn't work because *reg_val* is of type u16 (16 bits, unsigned), which makes it impossible for it to hold a value less than 0. Fix this by changing the type of variable *reg_val* to int. Addresses-Coverity-ID: 1473970

[PATCH net-next 0/2] fix signedness bug and memory leak in mscc driver

2018-10-09 Thread Gustavo A. R. Silva
This patchset aims to fix a signedness bug in function vsc85xx_downshift_get() and a memory leak in function vsc8574_config_pre_init(). Thanks Gustavo A. R. Silva (2): net: phy: mscc: fix signedness bug in vsc85xx_downshift_get net: phy: mscc: fix memory leak in vsc8574_config_pre_init

[PATCH net-next 0/2] fix signedness bug and memory leak in mscc driver

2018-10-09 Thread Gustavo A. R. Silva
This patchset aims to fix a signedness bug in function vsc85xx_downshift_get() and a memory leak in function vsc8574_config_pre_init(). Thanks Gustavo A. R. Silva (2): net: phy: mscc: fix signedness bug in vsc85xx_downshift_get net: phy: mscc: fix memory leak in vsc8574_config_pre_init

Re: [PATCH v5] perf record: encode -k clockid frequency into Perf trace

2018-10-09 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 09, 2018 at 05:36:24PM +0300, Alexey Budankov escreveu: > > Store -k clockid frequency into Perf trace to enable timestamps > derived metrics conversion into wall clock time on reporting stage. > > Below is the example of perf report output: Applied, building, lets see this time.

Re: [PATCH v5] perf record: encode -k clockid frequency into Perf trace

2018-10-09 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 09, 2018 at 05:36:24PM +0300, Alexey Budankov escreveu: > > Store -k clockid frequency into Perf trace to enable timestamps > derived metrics conversion into wall clock time on reporting stage. > > Below is the example of perf report output: Applied, building, lets see this time.

<    1   2   3   4   5   6   7   8   9   10   >