[PATCH] fs: fix lost error code in dio_complete

2018-10-30 Thread Maximilian Heyne
commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the generic_write_sync prototype") reworked callers of generic_write_sync(), and ended up dropping the error return for the directio path. Prior to that commit, in dio_complete(), an error would be bubbled up the stack, but after that

[PATCH v2 08/11] ext4: lost brelse in ext4_orphan_add()

2018-10-30 Thread Vasily Averin
iloc.bh os taken in ext4_reserve_inode_write(). If (dirty == true) it is released in ext4_mark_iloc_dirty(), however it is not released in (dirty == false) case. Fixes d745a8c20c1f ("ext4: reduce contention on s_orphan_lock") however iloc.bh count balance was broken earlier by Fixes 6e3617e579e0

[PATCH v2 10/11] ext4: remove useless brelse call in ext4_xattr_inode_update_ref()

2018-10-30 Thread Vasily Averin
brelse(iloc.bh) is useless here, it is always called with iloc.bh = NULL Fixes dec214d00e0d ("ext4: xattr inode deduplication") # 4.13 cc: Tahsin Erdogan Signed-off-by: Vasily Averin --- fs/ext4/xattr.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/ext4/xattr.c

[PATCH v2 11/11] ext4: access to uninitialized bh fields in ext4_xattr_set_handle()

2018-10-30 Thread Vasily Averin
On-stack initialization does not guarantee zeroying of unintialized fields. So is.iloc.bh and bs.bh can be contain garbage of old stack conent. Errors in the beginning of ext4_xattr_set_handle() function lead to jump to "cleanup:" label where brelse(is.iloc.bh) and brelse(bs.bh) can access

[PATCH] fs: fix lost error code in dio_complete

2018-10-30 Thread Maximilian Heyne
commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the generic_write_sync prototype") reworked callers of generic_write_sync(), and ended up dropping the error return for the directio path. Prior to that commit, in dio_complete(), an error would be bubbled up the stack, but after that

[PATCH v2 08/11] ext4: lost brelse in ext4_orphan_add()

2018-10-30 Thread Vasily Averin
iloc.bh os taken in ext4_reserve_inode_write(). If (dirty == true) it is released in ext4_mark_iloc_dirty(), however it is not released in (dirty == false) case. Fixes d745a8c20c1f ("ext4: reduce contention on s_orphan_lock") however iloc.bh count balance was broken earlier by Fixes 6e3617e579e0

[PATCH v2 09/11] ext4: iloc.bh cleanup in add_new_gdb()

2018-10-30 Thread Vasily Averin
iloc.bh was taken in ext4_reserve_inode_write() and released in ext4_mark_iloc_dirty(). It should not be released 2nd time in rollback after failed ext4_handle_dirty_metadata(gdb_bh) Fixes b40971426a83 ("ext4: add error checking to calls to ...") # 2.6.38 Signed-off-by: Vasily Averin ---

[PATCH v2 09/11] ext4: iloc.bh cleanup in add_new_gdb()

2018-10-30 Thread Vasily Averin
iloc.bh was taken in ext4_reserve_inode_write() and released in ext4_mark_iloc_dirty(). It should not be released 2nd time in rollback after failed ext4_handle_dirty_metadata(gdb_bh) Fixes b40971426a83 ("ext4: add error checking to calls to ...") # 2.6.38 Signed-off-by: Vasily Averin ---

[PATCH v2 07/11] ext4: lost put_bh in ext4_mark_iloc_dirty()

2018-10-30 Thread Vasily Averin
ext4_mark_iloc_dirty() callers expect that it releases iloc->bh even if it returns an error. Fixes 0db1ff222d40 ("ext4: add shutdown bit and check for it") # 4.11 Signed-off-by: Vasily Averin --- fs/ext4/inode.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v2 03/11] ext4 resize: brelse() cleanup in add_new_gdb_meta_bg()

2018-10-30 Thread Vasily Averin
gdb_bh must be released in case of errors before update of s_group_desc but it must not be released after update of group descriptors because in this case bh can be used later. Fixes 01f795f9e0d6 ("ext4: add online resizing support for meta_bg ...") # 3.7 Signed-off-by: Vasily Averin ---

[PATCH v2 07/11] ext4: lost put_bh in ext4_mark_iloc_dirty()

2018-10-30 Thread Vasily Averin
ext4_mark_iloc_dirty() callers expect that it releases iloc->bh even if it returns an error. Fixes 0db1ff222d40 ("ext4: add shutdown bit and check for it") # 4.11 Signed-off-by: Vasily Averin --- fs/ext4/inode.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v2 03/11] ext4 resize: brelse() cleanup in add_new_gdb_meta_bg()

2018-10-30 Thread Vasily Averin
gdb_bh must be released in case of errors before update of s_group_desc but it must not be released after update of group descriptors because in this case bh can be used later. Fixes 01f795f9e0d6 ("ext4: add online resizing support for meta_bg ...") # 3.7 Signed-off-by: Vasily Averin ---

[PATCH v2 05/11] ext4 resize: lost rollback in ext4_resize_fs()

2018-10-30 Thread Vasily Averin
Fixes 117fff10d7f1 ("ext4: grow the s_flex_groups array as needed ...") # 3.7 Signed-off-by: Vasily Averin --- fs/ext4/resize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 3df326ee6d50..5fee65afd58b 100644 --- a/fs/ext4/resize.c

[PATCH v2 04/11] ext4 resize: lost brelse() in update_backups()

2018-10-30 Thread Vasily Averin
bh was not released after error in ext4_journal_get_write_access() Fixes ac27a0ec112a ("ext4: initial copy of files from ext3") # 2.6.19 Signed-off-by: Vasily Averin --- fs/ext4/resize.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c

[PATCH v2 06/11] ext4 resize: lost resize_inode cleanup before retry in ext4_resize_fs()

2018-10-30 Thread Vasily Averin
Fixes 1c6bd7173d66 ("ext4: convert file system to meta_bg if needed ...") # 3.7 Signed-off-by: Vasily Averin --- fs/ext4/resize.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 5fee65afd58b..85158e9de7c2 100644 --- a/fs/ext4/resize.c +++

[PATCH v2 02/11] ext4 resize: missing brelse() after errors in set_flexbg_block_bitmap()

2018-10-30 Thread Vasily Averin
Fixes 33afdcc5402d ("ext4: add a function which sets up group blocks ...") # 3.3 Signed-off-by: Vasily Averin --- fs/ext4/resize.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index c3fa30878ca8..0a4dc6217e78 100644 ---

[PATCH v2 01/11] ext4 resise: extra brelse in setup_new_flex_group_blocks()

2018-10-30 Thread Vasily Averin
currently bh is set to NULL only during first iteration of for cycle, then this pointer is not cleared after end of using. Therefore rollback after errors can lead to extra brelse(bh) call, decrements bh counter and later trigger an unexpected warning in __brelse() Patch moves brelse() calls in

[PATCH v2 02/11] ext4 resize: missing brelse() after errors in set_flexbg_block_bitmap()

2018-10-30 Thread Vasily Averin
Fixes 33afdcc5402d ("ext4: add a function which sets up group blocks ...") # 3.3 Signed-off-by: Vasily Averin --- fs/ext4/resize.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index c3fa30878ca8..0a4dc6217e78 100644 ---

[PATCH v2 01/11] ext4 resise: extra brelse in setup_new_flex_group_blocks()

2018-10-30 Thread Vasily Averin
currently bh is set to NULL only during first iteration of for cycle, then this pointer is not cleared after end of using. Therefore rollback after errors can lead to extra brelse(bh) call, decrements bh counter and later trigger an unexpected warning in __brelse() Patch moves brelse() calls in

[PATCH v2 05/11] ext4 resize: lost rollback in ext4_resize_fs()

2018-10-30 Thread Vasily Averin
Fixes 117fff10d7f1 ("ext4: grow the s_flex_groups array as needed ...") # 3.7 Signed-off-by: Vasily Averin --- fs/ext4/resize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 3df326ee6d50..5fee65afd58b 100644 --- a/fs/ext4/resize.c

[PATCH v2 04/11] ext4 resize: lost brelse() in update_backups()

2018-10-30 Thread Vasily Averin
bh was not released after error in ext4_journal_get_write_access() Fixes ac27a0ec112a ("ext4: initial copy of files from ext3") # 2.6.19 Signed-off-by: Vasily Averin --- fs/ext4/resize.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c

[PATCH v2 06/11] ext4 resize: lost resize_inode cleanup before retry in ext4_resize_fs()

2018-10-30 Thread Vasily Averin
Fixes 1c6bd7173d66 ("ext4: convert file system to meta_bg if needed ...") # 3.7 Signed-off-by: Vasily Averin --- fs/ext4/resize.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 5fee65afd58b..85158e9de7c2 100644 --- a/fs/ext4/resize.c +++

[PATCH v2 00/11] ext4: number of long lived errors

2018-10-30 Thread Vasily Averin
Last week I've investigated the reason of ext4 resize troubles on RHEL6 and RHEL7 based OpenVZ kernels. Failed resize generated lot of "access beyond end of device" messages followed by warning in __brelse. EXT4-fs (dm-3): resizing filesystem from 2620416 to 4096256 blocks attempt to access

[PATCH v2 00/11] ext4: number of long lived errors

2018-10-30 Thread Vasily Averin
Last week I've investigated the reason of ext4 resize troubles on RHEL6 and RHEL7 based OpenVZ kernels. Failed resize generated lot of "access beyond end of device" messages followed by warning in __brelse. EXT4-fs (dm-3): resizing filesystem from 2620416 to 4096256 blocks attempt to access

Re: [PATCH RFC v2 1/1] hugetlbfs: use i_mmap_rwsem for pmd sharing and truncate/fault sync

2018-10-30 Thread Mike Kravetz
On 10/25/18 5:42 PM, Naoya Horiguchi wrote: > Hi Mike, > > On Tue, Oct 23, 2018 at 09:50:53PM -0700, Mike Kravetz wrote: >> Now, anopther task truncates the hugetlbfs file. As part of truncation, >> it unmaps everyone who has the file mapped. If a task has a shared pmd >> in this range,

Re: [PATCH RFC v2 1/1] hugetlbfs: use i_mmap_rwsem for pmd sharing and truncate/fault sync

2018-10-30 Thread Mike Kravetz
On 10/25/18 5:42 PM, Naoya Horiguchi wrote: > Hi Mike, > > On Tue, Oct 23, 2018 at 09:50:53PM -0700, Mike Kravetz wrote: >> Now, anopther task truncates the hugetlbfs file. As part of truncation, >> it unmaps everyone who has the file mapped. If a task has a shared pmd >> in this range,

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Tycho Andersen
On Tue, Oct 30, 2018 at 02:49:21PM -0700, Kees Cook wrote: > On Mon, Oct 29, 2018 at 3:40 PM, Tycho Andersen wrote: > > * switch to a flags based future-proofing mechanism for struct > > seccomp_notif and seccomp_notif_resp, thus avoiding version issues > > with structure length

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Tycho Andersen
On Tue, Oct 30, 2018 at 02:49:21PM -0700, Kees Cook wrote: > On Mon, Oct 29, 2018 at 3:40 PM, Tycho Andersen wrote: > > * switch to a flags based future-proofing mechanism for struct > > seccomp_notif and seccomp_notif_resp, thus avoiding version issues > > with structure length

RE: [Patch v4 13/18] security: Update security level of a process when modifying its dumpability

2018-10-30 Thread Schaufler, Casey
> -Original Message- > From: Tim Chen [mailto:tim.c.c...@linux.intel.com] > Sent: Tuesday, October 30, 2018 2:31 PM > To: Schaufler, Casey ; Jiri Kosina > ; Thomas Gleixner > Cc: Tom Lendacky ; Ingo Molnar > ; Peter Zijlstra ; Josh Poimboeuf > ; Andrea Arcangeli ; David > Woodhouse ; Andi

RE: [Patch v4 13/18] security: Update security level of a process when modifying its dumpability

2018-10-30 Thread Schaufler, Casey
> -Original Message- > From: Tim Chen [mailto:tim.c.c...@linux.intel.com] > Sent: Tuesday, October 30, 2018 2:31 PM > To: Schaufler, Casey ; Jiri Kosina > ; Thomas Gleixner > Cc: Tom Lendacky ; Ingo Molnar > ; Peter Zijlstra ; Josh Poimboeuf > ; Andrea Arcangeli ; David > Woodhouse ; Andi

Re: [PATCH v4] pstore: Avoid duplicate call of persistent_ram_zap()

2018-10-30 Thread Kees Cook
On Tue, Oct 30, 2018 at 2:38 PM, Joel Fernandes wrote: > On Tue, Oct 30, 2018 at 03:52:34PM +0800, Peng Wang wrote: >> When initialing prz with invalid data in buffer(no PERSISTENT_RAM_SIG), >> function call path is like this: >> >> ramoops_init_prz -> >> | >> |-> persistent_ram_new ->

Re: [PATCH v4] pstore: Avoid duplicate call of persistent_ram_zap()

2018-10-30 Thread Kees Cook
On Tue, Oct 30, 2018 at 2:38 PM, Joel Fernandes wrote: > On Tue, Oct 30, 2018 at 03:52:34PM +0800, Peng Wang wrote: >> When initialing prz with invalid data in buffer(no PERSISTENT_RAM_SIG), >> function call path is like this: >> >> ramoops_init_prz -> >> | >> |-> persistent_ram_new ->

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Kees Cook
On Mon, Oct 29, 2018 at 3:40 PM, Tycho Andersen wrote: > * switch to a flags based future-proofing mechanism for struct > seccomp_notif and seccomp_notif_resp, thus avoiding version issues > with structure length (Kees) [...] > > +struct seccomp_notif { > + __u64 id; > +

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Kees Cook
On Mon, Oct 29, 2018 at 3:40 PM, Tycho Andersen wrote: > * switch to a flags based future-proofing mechanism for struct > seccomp_notif and seccomp_notif_resp, thus avoiding version issues > with structure length (Kees) [...] > > +struct seccomp_notif { > + __u64 id; > +

Re: [PATCH V2 2/2] Documentation: can: flexcan: Add stop mode property to device tree

2018-10-30 Thread Rob Herring
On Fri, 26 Oct 2018 09:00:40 +, Joakim Zhang wrote: > From: Dong Aisheng > > The FlexCAN controller can parse the stop mode property to enable CAN > self wakeup feature. > > Signed-off-by: Dong Aisheng > Signed-off-by: Joakim Zhang > --- >

Re: [PATCH V2 2/2] Documentation: can: flexcan: Add stop mode property to device tree

2018-10-30 Thread Rob Herring
On Fri, 26 Oct 2018 09:00:40 +, Joakim Zhang wrote: > From: Dong Aisheng > > The FlexCAN controller can parse the stop mode property to enable CAN > self wakeup feature. > > Signed-off-by: Dong Aisheng > Signed-off-by: Joakim Zhang > --- >

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-30 Thread Tobias Thomer
I've tested v7 on a Yoga 530 and it seems to work (sometimes for hours) but it randomly dies with a i2c read timeout [ 9562.237020] i2c_amd_plat_mp2 AMDI0011:00: i2c read timed out and reloading/removing of the module results in this: [ 9703.591021] pcie_mp2_amd :03:00.7: length 0 in event

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-30 Thread Tobias Thomer
I've tested v7 on a Yoga 530 and it seems to work (sometimes for hours) but it randomly dies with a i2c read timeout [ 9562.237020] i2c_amd_plat_mp2 AMDI0011:00: i2c read timed out and reloading/removing of the module results in this: [ 9703.591021] pcie_mp2_amd :03:00.7: length 0 in event

Re: [PATCH v2 2/2] spi: uniphier: re-add addressing properties

2018-10-30 Thread Rob Herring
On Fri, 26 Oct 2018 14:58:45 +0900, Keiji Hayashibara wrote: > In commit 7662d1dc17d4 ("spi: uniphier: fix incorrect property items") > addressing properties of #address-cells and #size-cells were removed. > Since it is not necessary to remove them, they are back again. > > Signed-off-by: Keiji

Re: [PATCH v2 2/2] spi: uniphier: re-add addressing properties

2018-10-30 Thread Rob Herring
On Fri, 26 Oct 2018 14:58:45 +0900, Keiji Hayashibara wrote: > In commit 7662d1dc17d4 ("spi: uniphier: fix incorrect property items") > addressing properties of #address-cells and #size-cells were removed. > Since it is not necessary to remove them, they are back again. > > Signed-off-by: Keiji

Re: [RFC PATCH] Implement /proc/pid/kill

2018-10-30 Thread Joel Fernandes
On Wed, Oct 31, 2018 at 07:45:01AM +1100, Aleksa Sarai wrote: [...] > > > (Unfortunately > > > there are lots of things that make it a bit difficult to use /proc/$pid > > > exclusively for introspection of a process -- especially in the context > > > of containers.) > > > > Tons of things

Re: [RFC PATCH] Implement /proc/pid/kill

2018-10-30 Thread Joel Fernandes
On Wed, Oct 31, 2018 at 07:45:01AM +1100, Aleksa Sarai wrote: [...] > > > (Unfortunately > > > there are lots of things that make it a bit difficult to use /proc/$pid > > > exclusively for introspection of a process -- especially in the context > > > of containers.) > > > > Tons of things

Re: [PATCH v4] pstore: Avoid duplicate call of persistent_ram_zap()

2018-10-30 Thread Joel Fernandes
On Tue, Oct 30, 2018 at 03:52:34PM +0800, Peng Wang wrote: > When initialing prz with invalid data in buffer(no PERSISTENT_RAM_SIG), > function call path is like this: > > ramoops_init_prz -> > | > |-> persistent_ram_new -> persistent_ram_post_init -> persistent_ram_zap > | > |->

Re: [PATCH v4] pstore: Avoid duplicate call of persistent_ram_zap()

2018-10-30 Thread Joel Fernandes
On Tue, Oct 30, 2018 at 03:52:34PM +0800, Peng Wang wrote: > When initialing prz with invalid data in buffer(no PERSISTENT_RAM_SIG), > function call path is like this: > > ramoops_init_prz -> > | > |-> persistent_ram_new -> persistent_ram_post_init -> persistent_ram_zap > | > |->

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Kees Cook
On Tue, Oct 30, 2018 at 8:54 AM, Tycho Andersen wrote: > On Tue, Oct 30, 2018 at 04:02:54PM +0100, Oleg Nesterov wrote: >> On 10/29, Tycho Andersen wrote: >> > >> > +static long seccomp_notify_recv(struct seccomp_filter *filter, >> > + void __user *buf) >> > +{ >> > +

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Kees Cook
On Tue, Oct 30, 2018 at 8:54 AM, Tycho Andersen wrote: > On Tue, Oct 30, 2018 at 04:02:54PM +0100, Oleg Nesterov wrote: >> On 10/29, Tycho Andersen wrote: >> > >> > +static long seccomp_notify_recv(struct seccomp_filter *filter, >> > + void __user *buf) >> > +{ >> > +

Re: [Patch v4 16/18] x86/speculation: Enable STIBP to protect security sensitive tasks

2018-10-30 Thread Tim Chen
On 10/30/2018 02:07 PM, Schaufler, Casey wrote: >> -Original Message- >> From: Tim Chen [mailto:tim.c.c...@linux.intel.com] >> Sent: Tuesday, October 30, 2018 11:49 AM >> To: Jiri Kosina ; Thomas Gleixner >> Cc: Tim Chen ; Tom Lendacky >> ; Ingo Molnar ; Peter >> Zijlstra ; Josh Poimboeuf

Re: [Patch v4 16/18] x86/speculation: Enable STIBP to protect security sensitive tasks

2018-10-30 Thread Tim Chen
On 10/30/2018 02:07 PM, Schaufler, Casey wrote: >> -Original Message- >> From: Tim Chen [mailto:tim.c.c...@linux.intel.com] >> Sent: Tuesday, October 30, 2018 11:49 AM >> To: Jiri Kosina ; Thomas Gleixner >> Cc: Tim Chen ; Tom Lendacky >> ; Ingo Molnar ; Peter >> Zijlstra ; Josh Poimboeuf

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Kees Cook
On Tue, Oct 30, 2018 at 10:21 AM, Tycho Andersen wrote: > On Tue, Oct 30, 2018 at 05:39:26PM +0100, Oleg Nesterov wrote: >> On 10/30, Oleg Nesterov wrote: >> > >> > On 10/30, Tycho Andersen wrote: >> > > >> > > @@ -828,6 +823,11 @@ static int __seccomp_filter(int this_syscall, const >> > >

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Kees Cook
On Tue, Oct 30, 2018 at 10:21 AM, Tycho Andersen wrote: > On Tue, Oct 30, 2018 at 05:39:26PM +0100, Oleg Nesterov wrote: >> On 10/30, Oleg Nesterov wrote: >> > >> > On 10/30, Tycho Andersen wrote: >> > > >> > > @@ -828,6 +823,11 @@ static int __seccomp_filter(int this_syscall, const >> > >

Re: [Patch v4 13/18] security: Update security level of a process when modifying its dumpability

2018-10-30 Thread Tim Chen
On 10/30/2018 01:57 PM, Schaufler, Casey wrote: > > This isn't an LSM hook and hence does not belong in this file. > arch_set_security() isn't descriptive, and is in fact a bad choice > as task_struct has a field "security". This function has nothing > to do with the task->security field, which

Re: [Patch v4 13/18] security: Update security level of a process when modifying its dumpability

2018-10-30 Thread Tim Chen
On 10/30/2018 01:57 PM, Schaufler, Casey wrote: > > This isn't an LSM hook and hence does not belong in this file. > arch_set_security() isn't descriptive, and is in fact a bad choice > as task_struct has a field "security". This function has nothing > to do with the task->security field, which

Re: [PATCH] x86/fsgsbase/64: Fix the base write helper functions

2018-10-30 Thread Andy Lutomirski
On Tue, Oct 30, 2018 at 10:28 AM Chang S. Bae wrote: > > Factor out the code to change index from x86_fsbase_write_cpu() and > x86_gsbase_write_cpu_inactive(). Now the code is located in > do_arch_prctl_64(). > > @@ -359,9 +351,7 @@ unsigned long x86_fsbase_read_task(struct task_struct > *task)

Re: [PATCH] x86/fsgsbase/64: Fix the base write helper functions

2018-10-30 Thread Andy Lutomirski
On Tue, Oct 30, 2018 at 10:28 AM Chang S. Bae wrote: > > Factor out the code to change index from x86_fsbase_write_cpu() and > x86_gsbase_write_cpu_inactive(). Now the code is located in > do_arch_prctl_64(). > > @@ -359,9 +351,7 @@ unsigned long x86_fsbase_read_task(struct task_struct > *task)

Re: [PATCH v4] pstore: Avoid duplicate call of persistent_ram_zap()

2018-10-30 Thread Kees Cook
On Tue, Oct 30, 2018 at 12:52 AM, Peng Wang wrote: > When initialing prz with invalid data in buffer(no PERSISTENT_RAM_SIG), > function call path is like this: > > ramoops_init_prz -> > | > |-> persistent_ram_new -> persistent_ram_post_init -> persistent_ram_zap > | > |-> persistent_ram_zap > >

Re: [PATCH v4] pstore: Avoid duplicate call of persistent_ram_zap()

2018-10-30 Thread Kees Cook
On Tue, Oct 30, 2018 at 12:52 AM, Peng Wang wrote: > When initialing prz with invalid data in buffer(no PERSISTENT_RAM_SIG), > function call path is like this: > > ramoops_init_prz -> > | > |-> persistent_ram_new -> persistent_ram_post_init -> persistent_ram_zap > | > |-> persistent_ram_zap > >

[PATCH i2c-next v9 1/5] dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional

2018-10-30 Thread Jae Hyun Yoo
This commit adds 'bus-timeout-ms' and '#retries' properties as common optional properties that can be used for setting 'timeout' and 'retries' values of 'struct i2c_adapter'. With this patch, the bus timeout value and the master transfer retries count can be set through these properties at the

[PATCH i2c-next v9 0/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-30 Thread Jae Hyun Yoo
In multi-master environment, this driver's master cannot know exactly when a peer master sends data to this driver's slave so a case can be happened that this master tries to send data through the master_xfer function but slave data from peer master is still being processed by this driver. To

[PATCH i2c-next v9 1/5] dt-bindings: i2c: Add 'bus-timeout-ms' and '#retries' properties as common optional

2018-10-30 Thread Jae Hyun Yoo
This commit adds 'bus-timeout-ms' and '#retries' properties as common optional properties that can be used for setting 'timeout' and 'retries' values of 'struct i2c_adapter'. With this patch, the bus timeout value and the master transfer retries count can be set through these properties at the

[PATCH i2c-next v9 0/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-30 Thread Jae Hyun Yoo
In multi-master environment, this driver's master cannot know exactly when a peer master sends data to this driver's slave so a case can be happened that this master tries to send data through the master_xfer function but slave data from peer master is still being processed by this driver. To

[PATCH i2c-next v9 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-30 Thread Jae Hyun Yoo
In multi-master environment, this driver's master cannot know exactly when a peer master sends data to this driver's slave so a case can be happened that this master tries to send data through the master_xfer function but slave data from peer master is still being processed by this driver. To

[PATCH i2c-next v9 2/5] i2c: core: Add support reading of 'bus-timeout-ms' and '#retries' properties

2018-10-30 Thread Jae Hyun Yoo
This commit adds support for 'bus-timeout-ms' and '#retries' properties to set 'timeout' and 'retries' values in 'struct i2c_adapter' in case an adapter node has the properties. Still the values can be set by I2C_TIMEOUT and I2C_RETRIES ioctls on cdev at runtime too. These properties may not be

[PATCH i2c-next v9 4/5] i2c: aspeed: Remove hard-coded bus timeout value setting

2018-10-30 Thread Jae Hyun Yoo
This commit removes hard-coded bus timeout value setting so that it can be set by i2c-core-base. Signed-off-by: Jae Hyun Yoo Reviewed-by: Joel Stanley Reviewed-by: Brendan Higgins --- drivers/i2c/busses/i2c-aspeed.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH i2c-next v9 3/5] dt-bindings: i2c: aspeed: Add 'bus-timeout-ms' property as an optional property

2018-10-30 Thread Jae Hyun Yoo
This commit adds 'bus-timeout-ms' property as an optional property which can be used for setting the bus timeout value of an adapter. With this patch, the bus timeout value can be set through this property at the probing time of this module. Still the bus timeout value can be set by an I2C_TIMEOUT

[PATCH i2c-next v9 5/5] i2c: aspeed: Add bus idle waiting logic for multi-master use cases

2018-10-30 Thread Jae Hyun Yoo
In multi-master environment, this driver's master cannot know exactly when a peer master sends data to this driver's slave so a case can be happened that this master tries to send data through the master_xfer function but slave data from peer master is still being processed by this driver. To

[PATCH i2c-next v9 2/5] i2c: core: Add support reading of 'bus-timeout-ms' and '#retries' properties

2018-10-30 Thread Jae Hyun Yoo
This commit adds support for 'bus-timeout-ms' and '#retries' properties to set 'timeout' and 'retries' values in 'struct i2c_adapter' in case an adapter node has the properties. Still the values can be set by I2C_TIMEOUT and I2C_RETRIES ioctls on cdev at runtime too. These properties may not be

[PATCH i2c-next v9 4/5] i2c: aspeed: Remove hard-coded bus timeout value setting

2018-10-30 Thread Jae Hyun Yoo
This commit removes hard-coded bus timeout value setting so that it can be set by i2c-core-base. Signed-off-by: Jae Hyun Yoo Reviewed-by: Joel Stanley Reviewed-by: Brendan Higgins --- drivers/i2c/busses/i2c-aspeed.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH i2c-next v9 3/5] dt-bindings: i2c: aspeed: Add 'bus-timeout-ms' property as an optional property

2018-10-30 Thread Jae Hyun Yoo
This commit adds 'bus-timeout-ms' property as an optional property which can be used for setting the bus timeout value of an adapter. With this patch, the bus timeout value can be set through this property at the probing time of this module. Still the bus timeout value can be set by an I2C_TIMEOUT

RE: [Patch v4 16/18] x86/speculation: Enable STIBP to protect security sensitive tasks

2018-10-30 Thread Schaufler, Casey
> -Original Message- > From: Tim Chen [mailto:tim.c.c...@linux.intel.com] > Sent: Tuesday, October 30, 2018 11:49 AM > To: Jiri Kosina ; Thomas Gleixner > Cc: Tim Chen ; Tom Lendacky > ; Ingo Molnar ; Peter > Zijlstra ; Josh Poimboeuf ; > Andrea Arcangeli ; David Woodhouse > ; Andi Kleen

RE: [Patch v4 16/18] x86/speculation: Enable STIBP to protect security sensitive tasks

2018-10-30 Thread Schaufler, Casey
> -Original Message- > From: Tim Chen [mailto:tim.c.c...@linux.intel.com] > Sent: Tuesday, October 30, 2018 11:49 AM > To: Jiri Kosina ; Thomas Gleixner > Cc: Tim Chen ; Tom Lendacky > ; Ingo Molnar ; Peter > Zijlstra ; Josh Poimboeuf ; > Andrea Arcangeli ; David Woodhouse > ; Andi Kleen

RE: [Patch v4 13/18] security: Update security level of a process when modifying its dumpability

2018-10-30 Thread Schaufler, Casey
> -Original Message- > From: Tim Chen [mailto:tim.c.c...@linux.intel.com] > Sent: Tuesday, October 30, 2018 11:49 AM > To: Jiri Kosina ; Thomas Gleixner > Cc: Tim Chen ; Tom Lendacky > ; Ingo Molnar ; Peter > Zijlstra ; Josh Poimboeuf ; > Andrea Arcangeli ; David Woodhouse > ; Andi Kleen

RE: [Patch v4 13/18] security: Update security level of a process when modifying its dumpability

2018-10-30 Thread Schaufler, Casey
> -Original Message- > From: Tim Chen [mailto:tim.c.c...@linux.intel.com] > Sent: Tuesday, October 30, 2018 11:49 AM > To: Jiri Kosina ; Thomas Gleixner > Cc: Tim Chen ; Tom Lendacky > ; Ingo Molnar ; Peter > Zijlstra ; Josh Poimboeuf ; > Andrea Arcangeli ; David Woodhouse > ; Andi Kleen

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-30 Thread Bjorn Helgaas
[+cc Rafael, Len, linux-acpi] On Sat, Oct 27, 2018 at 12:09:10PM -0300, Elie Morisse wrote: > This contains two drivers: > * i2c-amd-plat-mp2: platform driver managing an i2c adapter (one of > the two busses of the MP2) and routing any i2c read/write command to > the PCI driver. > *

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-30 Thread Bjorn Helgaas
[+cc Rafael, Len, linux-acpi] On Sat, Oct 27, 2018 at 12:09:10PM -0300, Elie Morisse wrote: > This contains two drivers: > * i2c-amd-plat-mp2: platform driver managing an i2c adapter (one of > the two busses of the MP2) and routing any i2c read/write command to > the PCI driver. > *

Re: [PATCH v3 3/3] dt-bindings: iio: adc: Add docs for ad7124

2018-10-30 Thread Rob Herring
On Mon, Oct 29, 2018 at 06:39:30PM +0200, Stefan Popa wrote: > Add support for Analog Devices AD7124 4-channels and 8-channels ADC. > > Signed-off-by: Stefan Popa > --- > Changes in v2: > - Nothing changed. > Changes in v3: > - Removed the "adi,channels" property. > - Used the

Re: [PATCH v3 3/3] dt-bindings: iio: adc: Add docs for ad7124

2018-10-30 Thread Rob Herring
On Mon, Oct 29, 2018 at 06:39:30PM +0200, Stefan Popa wrote: > Add support for Analog Devices AD7124 4-channels and 8-channels ADC. > > Signed-off-by: Stefan Popa > --- > Changes in v2: > - Nothing changed. > Changes in v3: > - Removed the "adi,channels" property. > - Used the

[GIT PULL] VFIO updates for v4.20-rc1

2018-10-30 Thread Alex Williamson
Hi Linus, The following changes since commit 6bf4ca7fbc85d80446ac01c0d1d77db4d91a6d84: Linux 4.19-rc5 (2018-09-23 19:15:18 +0200) are available in the Git repository at: git://github.com/awilliam/linux-vfio.git tags/vfio-v4.20-rc1.v2 for you to fetch changes up to

[GIT PULL] VFIO updates for v4.20-rc1

2018-10-30 Thread Alex Williamson
Hi Linus, The following changes since commit 6bf4ca7fbc85d80446ac01c0d1d77db4d91a6d84: Linux 4.19-rc5 (2018-09-23 19:15:18 +0200) are available in the Git repository at: git://github.com/awilliam/linux-vfio.git tags/vfio-v4.20-rc1.v2 for you to fetch changes up to

Re: [RFC PATCH] Implement /proc/pid/kill

2018-10-30 Thread Aleksa Sarai
On 2018-10-30, Daniel Colascione wrote: > >> Add a simple proc-based kill interface. To use /proc/pid/kill, just > >> write the signal number in base-10 ASCII to the kill file of the > >> process to be killed: for example, 'echo 9 > /proc/$$/kill'. > >> > >> Semantically, /proc/pid/kill works

Re: [RFC PATCH] Implement /proc/pid/kill

2018-10-30 Thread Aleksa Sarai
On 2018-10-30, Daniel Colascione wrote: > >> Add a simple proc-based kill interface. To use /proc/pid/kill, just > >> write the signal number in base-10 ASCII to the kill file of the > >> process to be killed: for example, 'echo 9 > /proc/$$/kill'. > >> > >> Semantically, /proc/pid/kill works

Re: [PATCH] perf util: take pgoff into account when reporting elf to libdwfl

2018-10-30 Thread Milian Wolff
On Montag, 29. Oktober 2018 18:40:14 CET Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 29, 2018 at 04:26:27PM +0100, Milian Wolff escreveu: > > On Monday, October 29, 2018 3:16:44 PM CET Milian Wolff wrote: > > > Libdwfl parses an ELF file itself and creates mappings for the > > > individual

Re: [PATCH] perf util: take pgoff into account when reporting elf to libdwfl

2018-10-30 Thread Milian Wolff
On Montag, 29. Oktober 2018 18:40:14 CET Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 29, 2018 at 04:26:27PM +0100, Milian Wolff escreveu: > > On Monday, October 29, 2018 3:16:44 PM CET Milian Wolff wrote: > > > Libdwfl parses an ELF file itself and creates mappings for the > > > individual

Re: [PATCH] arm64: dts: rockchip: Use default brightness table for gru.

2018-10-30 Thread Heiko Stuebner
Am Dienstag, 16. Oktober 2018, 16:13:04 CET schrieb Enric Balletbo i Serra: > After commit 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED > linearly to human eye") the pwm_bl driver is able to calculate a default > brightness table. The calculated table for this PWM will have more >

Re: [PATCH] arm64: dts: rockchip: Use default brightness table for gru.

2018-10-30 Thread Heiko Stuebner
Am Dienstag, 16. Oktober 2018, 16:13:04 CET schrieb Enric Balletbo i Serra: > After commit 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED > linearly to human eye") the pwm_bl driver is able to calculate a default > brightness table. The calculated table for this PWM will have more >

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-30 Thread Shayenne Moura
On 10/30, Julia Lawall wrote: > > On Tue, 30 Oct 2018, Shayenne Moura wrote: > > > Hi, > > > > > On Sun, 28 Oct 2018, Himanshu Jha wrote: > > > > > > > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > > > > > The "possible alignement issues" in CHECK report is difficult to > >

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-30 Thread Shayenne Moura
On 10/30, Julia Lawall wrote: > > On Tue, 30 Oct 2018, Shayenne Moura wrote: > > > Hi, > > > > > On Sun, 28 Oct 2018, Himanshu Jha wrote: > > > > > > > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > > > > > The "possible alignement issues" in CHECK report is difficult to > >

[PATCH v1 1/2] bus: mc-bus: Add support for mapping shareable portals

2018-10-30 Thread Roy Pledge
Starting with v5 of NXP QBMan devices the hardware supports using regular cacheable/shareable memory as the backing store for the portals. This patch adds support for the new portal mode by switching to use the DPRC get object region v2 command which returns both a base address and offset for the

[PATCH v1 0/2] soc: fsl: dpio: Add support for memory backed QBMan portals

2018-10-30 Thread Roy Pledge
This patch series adds support for QBMan memory backed portals which is avaialble in devices containing QBMan verion 5.0 and above (for example NXP's LX2160A SoC). Memory backed portals can be mapped as normal cacheable/shareable memory which allows the portals to migrate between cores without

[PATCH v1 1/2] bus: mc-bus: Add support for mapping shareable portals

2018-10-30 Thread Roy Pledge
Starting with v5 of NXP QBMan devices the hardware supports using regular cacheable/shareable memory as the backing store for the portals. This patch adds support for the new portal mode by switching to use the DPRC get object region v2 command which returns both a base address and offset for the

[PATCH v1 0/2] soc: fsl: dpio: Add support for memory backed QBMan portals

2018-10-30 Thread Roy Pledge
This patch series adds support for QBMan memory backed portals which is avaialble in devices containing QBMan verion 5.0 and above (for example NXP's LX2160A SoC). Memory backed portals can be mapped as normal cacheable/shareable memory which allows the portals to migrate between cores without

[PATCH v1 2/2] soc: fsl: dpio: Add support for memory backed QBMan portals

2018-10-30 Thread Roy Pledge
NXP devices with QBMan version 5 and above can enable software portals that are memory backed. This allows the portal to be mapped as cacheable/sharable (same as all normal memory) so that portals can freely migrate between cores and clusters in the SoC. The driver will enable this mode by default

[PATCH v1 2/2] soc: fsl: dpio: Add support for memory backed QBMan portals

2018-10-30 Thread Roy Pledge
NXP devices with QBMan version 5 and above can enable software portals that are memory backed. This allows the portal to be mapped as cacheable/sharable (same as all normal memory) so that portals can freely migrate between cores and clusters in the SoC. The driver will enable this mode by default

[PATCH v2] kernel/SRCU: Fix ctags

2018-10-30 Thread Sam Protsenko
ctags indexing ("make tags" command) throws this warning: ctags: Warning: include/linux/notifier.h:125: null expansion of name pattern "\1" This is the result of DEFINE_PER_CPU() macro expansion. Fix that by getting rid of line break. Similar fix was already done in commit 25528213fe9f

[PATCH v2] kernel/SRCU: Fix ctags

2018-10-30 Thread Sam Protsenko
ctags indexing ("make tags" command) throws this warning: ctags: Warning: include/linux/notifier.h:125: null expansion of name pattern "\1" This is the result of DEFINE_PER_CPU() macro expansion. Fix that by getting rid of line break. Similar fix was already done in commit 25528213fe9f

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-30 Thread Julia Lawall
On Tue, 30 Oct 2018, Shayenne Moura wrote: > Hi, > > > On Sun, 28 Oct 2018, Himanshu Jha wrote: > > > > > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > > > > The "possible alignement issues" in CHECK report is difficult to > > > > > figure > > > > > out by just doing a

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-30 Thread Julia Lawall
On Tue, 30 Oct 2018, Shayenne Moura wrote: > Hi, > > > On Sun, 28 Oct 2018, Himanshu Jha wrote: > > > > > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > > > > The "possible alignement issues" in CHECK report is difficult to > > > > > figure > > > > > out by just doing a

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-30 Thread Shayenne Moura
Hi, > On Sun, 28 Oct 2018, Himanshu Jha wrote: > > > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > > > The "possible alignement issues" in CHECK report is difficult to figure > > > > out by just doing a glance analysis. :) > > > > > > > > Linus also suggested to use bool as

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-30 Thread Shayenne Moura
Hi, > On Sun, 28 Oct 2018, Himanshu Jha wrote: > > > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > > > The "possible alignement issues" in CHECK report is difficult to figure > > > > out by just doing a glance analysis. :) > > > > > > > > Linus also suggested to use bool as

Re: [GIT PULL] nfsd changes for 4.20

2018-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2018 at 12:55 PM Linus Torvalds wrote: > > Pulled, Oh, I take that back. Semantic conflict with locking name change (recv_lock -> queue_lock) and new code in net/sunrpc/xprtrdma/svc_rdma_backchannel.c exposed by my build test. And looking around, it was reported in

Re: [GIT PULL] nfsd changes for 4.20

2018-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2018 at 12:55 PM Linus Torvalds wrote: > > Pulled, Oh, I take that back. Semantic conflict with locking name change (recv_lock -> queue_lock) and new code in net/sunrpc/xprtrdma/svc_rdma_backchannel.c exposed by my build test. And looking around, it was reported in

<    1   2   3   4   5   6   7   8   9   10   >