Enabling -Wvla found another variable-length array with randconfig
testing:
drivers/mtd/maps/sa1100-flash.c: In function 'sa1100_setup_mtd':
drivers/mtd/maps/sa1100-flash.c:224:10: error: ISO C90 forbids variable length
array 'cdev' [-Werror=vla]
Dynamically allocate the cdev array passed to mtd
Hi Ard,
On Sun, Nov 4, 2018 at 5:15 AM Ard Biesheuvel wrote:
>
> This reverts commit 80463f1b7bf9f822fd3495139bcf3ef254fdca10, because
> it breaks the bindeb-pkg build target in the following way:
>
> ...
> LD [M] sound/soc/rockchip/snd-soc-rk3399-gru-sound.ko
> LD [M] sound/soc/rock
Hi Zhenzhong,
On Fri, Nov 2, 2018 at 8:26 PM Zhenzhong Duan wrote:
>
> Running 'make O=/build/kernel binrpm-pkg' failed with below two errors.
>
> Makefile:600: include/config/auto.conf: No such file or directory
>
> + cp make -C /mnt/root/kernel O=/build/kernel image_name make -f
> /mnt/root/ker
Ard Biesheuvel reports bindeb-pkg with O= option is broken in the
following way:
...
LD [M] sound/soc/rockchip/snd-soc-rk3399-gru-sound.ko
LD [M] sound/soc/rockchip/snd-soc-rockchip-pcm.ko
LD [M] sound/soc/rockchip/snd-soc-rockchip-rt5645.ko
LD [M] sound/soc/rockchip/snd-soc-
Zhenzhong Duan reported that running 'make O=/build/kernel binrpm-pkg'
failed with the following errors:
Running 'make O=/build/kernel binrpm-pkg' failed with below two errors.
Makefile:600: include/config/auto.conf: No such file or directory
+ cp make -C /mnt/root/kernel O=/build/kernel i
Dear Friend,
I know that this mail will come to you as a surprise as we have never
met before, but need not to worry as I am contacting you independently
of my investigation and no one is informed of this communication.
I need your urgent assistance in transferring the sum of $11.3million
immedia
This patch adds the Spreadtrum SC27XX serial PMICs fuel gauge support,
which is used to calculate the battery capacity.
Original-by: Yuanjiang Yu
Signed-off-by: Baolin Wang
Acked-by: Linus Walleij
---
Changes from v6:
- Use DIV_ROUND_CLOSEST macro to simplify code.
Changes from v5:
- Save th
The internal resistance of a battery is not a constant in its life cycle,
this varies over the age of the battery or temperature and so on. But we
just want use one constant battery internal resistance to estimate the
battery capacity. Thus this patch introduces one property to present
the battery
Add one field for 'struct power_supply_battery_info' to present the battery
factory internal resistance.
Signed-off-by: Baolin Wang
Reviewed-by: Linus Walleij
---
Changes from v6:
- None.
Changes from v5:
- None.
Changes from v4:
- None.
Changes from v3:
- New patch in v3, which splits co
We have introduced some battery properties to present the OCV table
temperatures and OCV capacity table values. Thus this patch add OCV
temperature and OCV table for battery information, as well as providing
some helper functions to use the OCV capacity table for users.
Signed-off-by: Baolin Wang
This patch adds the binding documentation for Spreadtrum SC27XX series PMICs
fuel gauge unit device, which is used to calculate the battery capacity.
Signed-off-by: Baolin Wang
Reviewed-by: Linus Walleij
Reviewed-by: Rob Herring
---
Changes from v6:
- None.
Changes from v5:
- None.
Changes
Some battery driver will use the open circuit voltage (OCV) value to look
up the corresponding battery capacity percent in one certain degree Celsius.
Thus this patch provides some battery properties to present the OCV table
temperatures and OCV capacity table values.
Suggested-by: Sebastian Reich
On 11/3/18 2:34 AM, Greg Kroah-Hartman wrote:
4.18-stable review patch. If anyone has any objections, please let me know.
This patch has a problem. I am working on a fix for that. Please
do not include it in the stable release. Thanks.
--
[ Upstream commit 9a4890bd6d632
One cause of decoding errors is un-synchronized side-band data. Timestamps
are needed to debug such cases. TSC packet timestamps are logged. Log also
MTC and CYC timestamps.
Signed-off-by: Adrian Hunter
---
tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 4
1 file changed, 4 insertion
More event information is useful for debugging, especially MMAP events.
Signed-off-by: Adrian Hunter
---
tools/perf/util/intel-pt-decoder/intel-pt-log.c | 5 +
tools/perf/util/intel-pt-decoder/intel-pt-log.h | 1 +
tools/perf/util/intel-pt.c | 16 +---
3 fi
When multiple domains per device has been enabled by the
device driver, the device will tag the default PASID for
the domain to all DMA traffics out of the subset of this
device; and the IOMMU should translate the DMA requests
in PASID granularity.
This extends the intel_iommu_attach/detach_device
Hi
Here is a couple of small patches to add more information to the Intel PT
debug log.
Adrian Hunter (2):
perf intel-pt: Add more event information to debug log
perf intel-pt: Add MTC and CYC timestamps to debug log
tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 4
to
On 10/18/18 3:19 AM, Jan Kara wrote:
> On Thu 11-10-18 20:53:34, John Hubbard wrote:
>> On 10/11/18 6:23 PM, John Hubbard wrote:
>>> On 10/11/18 6:20 AM, Jason Gunthorpe wrote:
On Thu, Oct 11, 2018 at 10:49:29AM +0200, Jan Kara wrote:
[...]
> Well, put_page() cannot assert page is not dma-pinn
On 10/22/18 12:43 PM, Jason Gunthorpe wrote:
> On Thu, Oct 11, 2018 at 06:23:24PM -0700, John Hubbard wrote:
>> On 10/11/18 6:20 AM, Jason Gunthorpe wrote:
>>> On Thu, Oct 11, 2018 at 10:49:29AM +0200, Jan Kara wrote:
>>>
> This is a real worry. If someone uses a mistaken put_page() then how
>
On 10/13/18 9:47 AM, Christoph Hellwig wrote:
> On Sat, Oct 13, 2018 at 12:34:12AM -0700, John Hubbard wrote:
>> In patch 6/6, pin_page_for_dma(), which is called at the end of
>> get_user_pages(),
>> unceremoniously rips the pages out of the LRU, as a prerequisite to using
>> either of the page->
On Mon, Nov 05, 2018 at 02:58:07PM +0800, Vincent Chen wrote:
> Many thanks for kinds of comments. I quickly synthesize the comments and
> list them as below.
> 1. The kernel image shall include all vendor-specific code.
I fundamentally disagree with this… and think it should be the contrary.
1.
FYI, we noticed the following commit (built with gcc-6):
commit: 0e9446c35a80931044b6d8d2d74a9cabd248539f ("xarray: Add range store
functionality")
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
in testcase: trinity
with following parameters:
runtime: 300s
test-
On Fri, Nov 02, 2018 at 01:48:57AM +0800, Karsten Merker wrote:
> On Wed, Oct 31, 2018 at 10:27:05AM -0700, Palmer Dabbelt wrote:
> > On Wed, 31 Oct 2018 04:16:10 PDT (-0700), a...@brainfault.org wrote:
> > > On Wed, Oct 31, 2018 at 4:06 PM Vincent Chen
> > > wrote:
> > > >
> > > > RISC-V perm
On 18-11-01 08:59:08, Waiman Long wrote:
> On 10/31/2018 11:20 PM, Yi Sun wrote:
> > On 18-10-31 18:15:39, Peter Zijlstra wrote:
> >> On Wed, Oct 31, 2018 at 11:07:22AM -0400, Waiman Long wrote:
> >>> On 10/31/2018 10:10 AM, Peter Zijlstra wrote:
> On Wed, Oct 31, 2018 at 09:54:17AM +0800, Yi
On Sun 04-11-18 07:44:56, Yangtao Li wrote:
> WARN_ON() already contains an unlikely(), so it's not necessary to use
> unlikely.
We should just get rid of this ugliness altogether. It no longer serves
its purpose. This is a historical artifact from 2005 where do_brk
was called outside of the core
Steve Kemp wrote:
> This is an interesting idea, and an evolution since the initial
> approach which was submitted based upon xattr attributes. I still
> find the idea of using attributes simpler to manage though, since
> they're easy to add, and audit for.
>
> I suspect the biggest objection
Greetings Thomas,
On 11/04/2018 11:05 PM, Thomas Gleixner wrote:
> Eial,
>
> On Thu, 1 Nov 2018, Eial Czerwacki wrote:
>
>> Subject: x86/build: Build VSMP support only if CONFIG_PCI is selected
>
> That's not what the patch does, right?
>
you are correct, I'll resend it with a more appropriate
We will need these going forward in hotpath, i.e. from within
dev_pm_genpd_set_performance_state().
Lets fetch and save them while the OPP tables are added.
Signed-off-by: Viresh Kumar
---
drivers/base/power/domain.c | 23 +--
include/linux/pm_domain.h | 2 ++
2 files cha
Quoting Amit Nischal (2018-08-12 23:33:07)
> +
> +static int gpu_cc_sdm845_probe(struct platform_device *pdev)
> +{
> + struct regmap *regmap;
> + unsigned int value, mask;
> + int ret;
> +
> + regmap = qcom_cc_map(pdev, &gpu_cc_sdm845_desc);
> + if (IS_ERR(regmap))
>
Hi,
This series adds performance state propagation support in genpd core.
The propagation happens from the sub-domains to their masters. More
details can be found in the individual commit logs.
This is tested on hikey960 by faking power domains in such a way that
the CPU devices have two power do
Introduce a new helper dev_pm_opp_xlate_performance_state() which will
be used to translate from pstate of a device to another one.
Initially this will be used by genpd to find pstate of a master domain
using its sub-domain's pstate.
Signed-off-by: Viresh Kumar
---
drivers/opp/core.c | 49 +
This commit updates genpd core to start propagating performance state
updates to master domains that have their set_performance_state()
callback set.
A genpd handles two type of performance states now. The first one is the
performance state requirement put on the genpd by the devices and
sub-domai
Separate out _genpd_set_performance_state() and
_genpd_reeval_performance_state() from
dev_pm_genpd_set_performance_state() to handle performance state update
related stuff. This will be used by a later commit.
Signed-off-by: Viresh Kumar
---
drivers/base/power/domain.c | 104 +++
Quoting Amit Nischal (2018-08-12 23:33:04)
> For some of the GDSCs, there is a requirement to enable/disable the
> few clocks before turning on/off the gdsc power domain. Add support
> for the same by specifying a list of clk_hw pointers per gdsc and
> enable/disable them along with power domain on
On Mon, Nov 5, 2018 at 4:18 AM Jiri Olsa wrote:
>
> On Sat, Nov 03, 2018 at 06:36:21PM +0900, Xin Long wrote:
> > On Fri, Nov 2, 2018 at 7:26 PM Jiri Olsa wrote:
> > >
> > > On Fri, Nov 02, 2018 at 03:36:13PM +0900, Xin Long wrote:
> > > > On upstream kernel(4.19) or RHEL-8 kernel(4.18.0):
> > >
Hi Matias,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 651022382c7f8da46cb4872a545ee1da6d097d2a
commit: 73569e11032fc5a9b314b6351632cfca7793afd5 lightnvm: remove dependencies
on BLK_DEV_NVME and PCI
date: 4 we
Commit-ID: b068621a53f92f42400581d69ad0e84c56620b0a
Gitweb: https://git.kernel.org/tip/b068621a53f92f42400581d69ad0e84c56620b0a
Author: Randy Dunlap
AuthorDate: Sun, 4 Nov 2018 14:03:56 -0800
Committer: Ingo Molnar
CommitDate: Mon, 5 Nov 2018 07:05:45 +0100
Documentation/x86: Fix typo
On Mon, Nov 05, 2018 at 07:59:13AM +0300, Vasily Averin wrote:
>
>
> On 11/5/18 3:50 AM, Huang, Ying wrote:
> > Vasily Averin writes:
> >
> >> commit a2468cc9bfdf ("swap: choose swap device according to numa node")
> >> increased size of swap_info_struct up to 44 Kbytes, now it requires
> >> 4t
Commit-ID: f75d651587f719a813ebbbfeee570e6570731d55
Gitweb: https://git.kernel.org/tip/f75d651587f719a813ebbbfeee570e6570731d55
Author: Randy Dunlap
AuthorDate: Sun, 4 Nov 2018 18:40:14 -0800
Committer: Ingo Molnar
CommitDate: Mon, 5 Nov 2018 07:05:04 +0100
resource/docs: Fix new kerne
On Sun, Nov 04, 2018 at 01:28:06PM -0800, Guenter Roeck wrote:
> __node_distance is used by nvme, resulting in:
>
> ERROR: "__node_distance" [drivers/nvme/host/nvme-core.ko] undefined!
>
> when trying to build nvme as module.
>
> Fixes: f333444708f8 ("nvme: take node locality into account when s
On Sun, 4 Nov 2018 13:28:06 -0800
Guenter Roeck wrote:
> __node_distance is used by nvme, resulting in:
>
> ERROR: "__node_distance" [drivers/nvme/host/nvme-core.ko] undefined!
>
> when trying to build nvme as module.
>
> Fixes: f333444708f8 ("nvme: take node locality into account when select
Commit-ID: e1ff516a56ad56c476b47795d3811eef79d25fbe
Gitweb: https://git.kernel.org/tip/e1ff516a56ad56c476b47795d3811eef79d25fbe
Author: Yi Wang
AuthorDate: Mon, 5 Nov 2018 08:50:13 +0800
Committer: Ingo Molnar
CommitDate: Mon, 5 Nov 2018 07:03:59 +0100
sched/fair: Fix a comment in task
Hi all,
Commit
bf4d4ba7d970 ("cifs: update internal module version number for cifs.ko")
is missing a Signed-off-by from its author and committer.
--
Cheers,
Stephen Rothwell
pgpwC0LnYhEkJ.pgp
Description: OpenPGP digital signature
Hi all,
Changes since 20181102:
Non-merge commits (relative to Linus' tree): 418
585 files changed, 22874 insertions(+), 5819 deletions(-)
I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/k
On Sat, Nov 3, 2018 at 6:22 PM Jonathan Cameron
wrote:
>
> On Wed, 31 Oct 2018 10:29:59 +0800
> Chen-Yu Tsai wrote:
>
> > On Mon, Oct 29, 2018 at 9:10 PM Quentin Schulz
> > wrote:
> > >
> > > Hi Jonathan,
> > >
> > > On Sun, Oct 28, 2018 at 03:40:11PM +, Jonathan Cameron wrote:
> > > > On We
Hi Matthew,
On Sun, Nov 4, 2018 at 2:06 PM Mike Rapoport wrote:
>
> On Sat, Nov 03, 2018 at 05:02:36AM -0700, Matthew Wilcox wrote:
> > On Sat, Nov 03, 2018 at 10:35:04AM +0530, Souptick Joarder wrote:
> > > Page fault handlers are supposed to return VM_FAULT codes,
> > > but some drivers/file sy
On 11/5/18 8:10 AM, kernel test robot wrote:
> FYI, we noticed the following commit (built with gcc-7):
>
> commit: 1ee5ee5ec39e53af9bcd215f4d127b21d579f700 ("[PATCH 3/7] ext4 resize:
> missing brelse() in case success in add_new_gdb()")
yes, you're right, this patch was wrong and it was dropped
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 651022382c7f8da46cb4872a545ee1da6d097d2a
commit: 2ce7135adc9ad081aa3c49744144376ac74fea60 psi: cgroup support
date: 9 days ago
config: x86_64-randconfig-s1-11051307 (attached as .config)
compiler: gcc-6 (De
On 11/5/18 3:57 AM, Huang, Ying wrote:
> Vasily Averin writes:
>
>> Currently newly allocated swap_info_struct can be quickly freed.
>> This patch avoid uneccessary high-order page allocation and helps
>> to decrease the memory pressure.
>
> I think swapon/swapoff are rare operations, so it will
Vasily Averin writes:
> On 11/5/18 3:50 AM, Huang, Ying wrote:
>> Vasily Averin writes:
>>
>>> commit a2468cc9bfdf ("swap: choose swap device according to numa node")
>>> increased size of swap_info_struct up to 44 Kbytes, now it requires
>>> 4th order page.
>>
>> Why swap_info_struct could be
On Sun, Nov 4, 2018 at 9:11 PM Andy Lutomirski wrote:
>
> On Fri, Nov 2, 2018 at 3:28 PM Dave Hansen wrote:
> >
> > On 11/2/18 12:50 PM, Waiman Long wrote:
> > > On 11/02/2018 03:44 PM, Dave Hansen wrote:
> > >> On 11/2/18 12:40 PM, Waiman Long wrote:
> > >>> The 64k+ limit check is kind of arbit
On Fri, Nov 2, 2018 at 3:28 PM Dave Hansen wrote:
>
> On 11/2/18 12:50 PM, Waiman Long wrote:
> > On 11/02/2018 03:44 PM, Dave Hansen wrote:
> >> On 11/2/18 12:40 PM, Waiman Long wrote:
> >>> The 64k+ limit check is kind of arbitrary. So the check is now removed
> >>> to just let expand_stack() de
On Nov 4, 2018, at 9:41 AM, Vasily Averin wrote:
>
> update_ind/bind/tind_extent_page() differs by one variable and can be
> replaced by unified function. These functions are called by similar way
> and their caller function can be simplified too.
The patch looks quite reasonable, though I'd sug
On 11/5/18 3:50 AM, Huang, Ying wrote:
> Vasily Averin writes:
>
>> commit a2468cc9bfdf ("swap: choose swap device according to numa node")
>> increased size of swap_info_struct up to 44 Kbytes, now it requires
>> 4th order page.
>
> Why swap_info_struct could be so large? Because MAX_NUMNOD
On Sat, Nov 03, 2018 at 04:38:16PM -0700, Joel Fernandes (Google) wrote:
> In later patches we will need to map types to names, so create a table
> for that which can also be used and reused in different parts of old and
> new code. Also use it to save the type in the PRZ which will be useful
> in
On Sun, Nov 04, 2018 at 07:43:30PM -0800, Paul E. McKenney wrote:
[...]
> > > > > > > > Also about GP memory ordering and RCU-tree-locking, I think you
> > > > > > > > mentioned to
> > > > > > > > me that the RCU reader-sections are virtually extended both
> > > > > > > > forward and
> > > > > >
Hi Kees,
On Fri, Nov 02, 2018 at 01:00:08PM -0700, Kees Cook wrote:
[..]
> >> This corruption was visible with "ramoops.mem_size=204800 ramoops.ecc=1".
> >> Any stored crashes would not be uncompressable (producing a pstorefs
> >> "dmesg-*.enc.z" file), and triggering errors at boot:
> >>
> >>
Hi,
On 05/11/18 8:46 AM, Chunyan Zhang wrote:
> sdhci-omap can support both external dma controllers via dmaengine
> framework as well as ADMA in which the controller acts as DMA master.
>
> Signed-off-by: Chunyan Zhang
> ---
> drivers/mmc/host/sdhci-omap.c | 7 +++
> 1 file changed, 7 inse
Fix an issue with the 32-bit range error path in `rtc_hctosys' where no
error code is set and consequently the successful preceding call result
from `rtc_read_time' is propagated to `rtc_hctosys_ret'. This in turn
makes any subsequent call to `hctosys_show' incorrectly report in sysfs
that the
On Sat, Nov 03, 2018 at 08:49:56PM -0700, Joel Fernandes wrote:
> On Sat, Nov 03, 2018 at 04:22:59PM -0700, Paul E. McKenney wrote:
> > On Fri, Nov 02, 2018 at 10:12:26PM -0700, Joel Fernandes wrote:
> > > On Thu, Nov 01, 2018 at 09:13:07AM -0700, Paul E. McKenney wrote:
> > > > On Wed, Oct 31, 201
Some standard SD host controller can support both external dma
controllers as well as ADMA in which the controller acts as
DMA master.
Currently the generic SDHCI code supports ADMA/SDMA integrated into
the host controller but does not have any support for external DMA
controllers implemented usin
sdhci-omap can support both external dma controllers via dmaengine
framework as well as ADMA in which the controller acts as DMA master.
Signed-off-by: Chunyan Zhang
---
drivers/mmc/host/sdhci-omap.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/mmc/host/sdhci-omap.c b/drive
sdhci-omap can support both external dma controllers via dmaengine
framework as well as ADMA in which the controller acts as DMA master.
Signed-off-by: Chunyan Zhang
---
Documentation/devicetree/bindings/mmc/sdhci-omap.txt | 7 +++
1 file changed, 7 insertions(+)
diff --git a/Documentation/
Add the HXT vendor ID to pci_ids.h and use it in quirks. As the
design of HXT SD4800 ACS feature is the same as QCOM QDF2xxx,
pci_quirk_qcom_rp_acs() is reused for SD4800 quirk.
Cc: Joey Zheng
Signed-off-by: Shunyong Yang
---
drivers/pci/quirks.c| 2 ++
include/linux/pci_ids.h | 2 ++
2 fil
Currently the generic SDHCI code in the Linux kernel supports the SD
standard DMA integrated into the host controller but does not have any
support for external DMA controllers implemented using dmaengine meaning
that custom code is needed for any systems that use a generic DMA
controller with SDHC
Do "make defconfig" on x86-64, fire up menuconfig and select the frame pointer
uwinder (under kernel hacking -> choose unwinder) and:
$ make
Makefile:966: *** "Cannot generate ORC metadata for CONFIG_UNWINDER_ORC=y,
please install libelf-dev, libelf-devel or elfutils-libelf-devel". Stop.
Confirm
On Mon, Nov 5, 2018 at 9:54 AM Changbin Du wrote:
>
> On Sun, Nov 04, 2018 at 11:43:44AM +0900, Masahiro Yamada wrote:
> > On Sat, Nov 3, 2018 at 12:55 AM Arnd Bergmann wrote:
> > >
> > > On 11/2/18, Masahiro Yamada wrote:
> > > > On Thu, Nov 1, 2018 at 11:32 PM Changbin Du
> > > > wrote:
> >
I, Mikhail Fridman have selected you specifically as one of my beneficiaries
for my Charitable Donation of $5 Million Dollars,
Check the link below for confirmation:
https://www.rt.com/business/343781-mikhail-fridman-will-charity/
I await your earliest response for further directives.
Best Reg
Add basic options for Clang such as --target, --prefix, --gcc-toolchain,
-no-integrated-as to a single variable CLANG_FLAGS.
Signed-off-by: Masahiro Yamada
---
Makefile | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/Makefile b/Makefile
index 93315eb..58c838a 1
From: Randy Dunlap
Fix kernel-doc warnings in kernel/resource.c.
The first group of warnings is caused by a "/**" kernel-doc notation
marker but the function comments are not in kernel-doc format.
Also add another error return value here.
../kernel/resource.c:337: warning: Function parameter or
From: Randy Dunlap
Remove kernel-doc notation for a deleted function parameter to prevent
a kernel-doc warning:
../drivers/mtd/nand/raw/nand_base.c:603: warning: Excess function parameter
'mtd' description in 'panic_nand_wait'
Fixes: f1d46942e823 ("mtd: rawnand: Pass a nand_chip object to
chi
commit 92aa39e9dc77 upstream.
The per-CPU rcu_dynticks.rcu_urgent_qs variable communicates an urgent
need for an RCU quiescent state from the force-quiescent-state processing
within the grace-period kthread to context switches and to cond_resched().
Unfortunately, such urgent needs are not communi
On 05-11-18, 00:59, Anson Huang wrote:
> Add return value check for voltage scale when ARM clock
> rate change fail.
>
> Signed-off-by: Anson Huang
> ---
> drivers/cpufreq/imx6q-cpufreq.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/imx6q-cpufre
On Fri, Aug 31, 2018 at 03:53:18PM +0800, Anson Huang wrote:
> i.MX6 SoCs has MMDC clock gates in CCM CCGR, add
> clock property for MMDC driver's clock operation.
>
> Signed-off-by: Anson Huang
Applied, thanks.
On Mon, Oct 08, 2018 at 03:28:01PM +, Leonard Crestez wrote:
> Bindings for "fixed-regulator" only explicitly support "gpio" property,
> not "gpios". Fix by correcting the property name.
>
> The enet PHYs on imx6sx-sdb needs to be explicitly reset after a power
> cycle, this can be handled by
> >> If you "have to enable or disable anything" it means you have to
> >> override the default. But the default in this patches is "no change
> >> compared to before the patches", leaving tracing of both host and
> >> guest entirely to the host, so I don't understand your remark. What
> >> workf
On Thu, 2018-10-18 at 14:46 -0500, Wenwen Wang wrote:
> In _scif_prog_signal(), a DMA pool is allocated if the MIC Coprocessor is
> not X100, i.e., the boolean variable 'x100' is false. This DMA pool will be
> freed eventually through the callback function scif_prog_signal_cb() with
> the parameter
Hi Greg, Jiri,
I'd like to bring up a question about multiplexing /dev/console to
all specified console= devices on the kernel command line rather than just
the last entry. In my personal experience using linux systems and also in
my experience dealing with users of various server images (Fedora
Encapsulate power gating and locality functionality to tpm_chip_start()
and tpm_chip_stop() in order to clean up the branching mess in
tpm_transmit().
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-chip.c | 110 +++
drivers/char/tpm/tpm-interface.c | 87
Remove @flags from tpm_transmit() API. It is no longer used for
anything.
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-chip.c | 32 ++---
drivers/char/tpm/tpm-dev-common.c | 2 +-
drivers/char/tpm/tpm-interface.c | 18
drivers/char/tpm/tpm-sysfs.c
Call tpm_chip_start() and tpm_chip_stop() in
* tpm_try_get_ops() and tpm_put_ops()
* tpm_chip_register()
* tpm2_del_space()
And remove these calls from tpm_transmit(). The core reason for this
change is that in tpm_vtpm_proxy a locality change requires a virtual
TPM command (a command made up jus
Use tpm_try_get_ops() in tpm-sysfs.c so that we can consider moving
other decorations (locking, localities, power management for example)
inside it. This direction can be of course taken only after other call
sites for tpm_transmit() have been treated in the same way.
Signed-off-by: Jarkko Sakkine
Added locking as part of tpm_try_get_ops() and tpm_put_ops() as they are
anyway used in most of the call sites except in tpmrm_release() where we
take the locks manually.
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-chip.c | 2 ++
drivers/char/tpm/tpm-dev-common.c | 4 +---
dr
Move tpm_validate_command() to tpm2-space.c and make it part of the
tpm2_prepare_space() flow. Make cc resolution as part of the TPM space
functionality in order to detach it from rest of the tpm_transmit()
flow.
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-interface.c | 72 +++---
Encapsulate tpm_transmit() call pattern to tpm_dev_transmit() because it
is identically used from two places. Use unlocked version of
tpm_transmit() so that we are able to move the calls to
tpm2_prepare_space() and tpm2_commit_space() later on to this new
function.
Signed-off-by: Jarkko Sakkinen
Prepare and commit TPM space before and after calling tpm_transmit()
instead of doing that inside tpm_transmit(). After this change we can
remove TPM_TRANSMIT_NESTED flag from tpm2_prepare_space() and
tpm2_commit_space() and replace it with TPM_TRANSMIT_UNLOCKED.
Signed-off-by: Jarkko Sakkinen
--
Do not print partial list of PCRs when tpm1_pcr_read() fails but instead
return 0 from pcrs_show(). This is consistent behavior with other sysfs
functions.
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-sysfs.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/dr
Move locking, locality handling and power management to tpm_transmit()
in order to simplify the flow.
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-interface.c | 90 ++--
1 file changed, 39 insertions(+), 51 deletions(-)
diff --git a/drivers/char/tpm/tpm-in
Instead of accessing fields of the command header through offsets to
the raw buffer, it is a better idea to use the header struct pointer
that is already used elsewhere in the function.
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-interface.c | 4 ++--
1 file changed, 2 insertions(+),
Always call tpm2_flush_space() on failure in tpm_try_transmit() so that
the volatile memory of the TPM gets cleared. If /dev/tpm0 does not have
sufficient permissions (usually it has), this could leak to the leakage
of TPM objects. Through /dev/tpmrm0 this issue does not raise new
security concerns
Return zero when tpm_buf_init() fails as we do for other functions in
tpm-sysfs.c.
Fixes: da379f3c1db0c ("tpm: migrate pubek_show to struct tpm_buf")
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm-sysfs.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/c
The error logging for tpm2_commit_space() is in a wrong place. This
commit moves it inside that function.
Signed-off-by: Jarkko Sakkinen
---
drivers/char/tpm/tpm2-space.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/char/tpm/tpm2-space.c b/drivers/char/tpm
[was Detach TPM space code out of the tpm_transmit() flow but the scope
expanded a bit.]
Make the changes necessary to detach TPM space code and TPM activation
code out of the tpm_transmit() flow because of both of these can cause
nested tpm_transmit() calls. The nesteds calls make the whole flow
Since we pass an initialized struct tpm_buf instance in every call site
now, it is cleaner to pass that directly to the tpm_transmit_cmd() as
the TPM command/response buffer.
Fine-tune a little bit tpm_transmit() and tpm_transmit_cmd() comments
while doing this.
Signed-off-by: Jarkko Sakkinen
--
- spaces before tabs,
- spaces at the end of lines,
- multiple blank lines,
- blank lines before EXPORT_SYMBOL,
can all go.
Signed-off-by: NeilBrown
---
fs/locks.c | 33 -
1 file changed, 12 insertions(+), 21 deletions(-)
diff --git a/fs/locks.c b/fs/locks.
posix_unblock_lock() is not specific to posix locks, and behaves
nearly identically to locks_delete_block() - the former returning a
status while the later doesn't.
So discard posix_unblock_lock() and use locks_delete_block() instead,
after giving that function an appropriate return value.
Signed
Now that requests can block other requests, we
need to be careful to always clean up those blocked
requests.
Any time that we wait for a request, we might have
other requests attached, and when we stop waiting,
we must clean them up.
If the lock was granted, the requests might have been
moved to th
Both locks_remove_posix() and locks_remove_flock() use a
struct file_lock without calling locks_init_lock() on it.
This means the various list_heads are not initialized, which
will become a problem with a later patch.
So change them both to initialize properly. For flock locks,
this involves usin
Currently, a lock can block pending requests, but all pending
requests are equal. If lots of pending requests are
mutually exclusive, this means they will all be woken up
and all but one will fail. This can hurt performance.
So we will allow pending requests to block other requests.
Only the fir
posix_locks_conflict() and flock_locks_conflict() both return int.
leases_conflict() returns bool.
This inconsistency will cause problems for the next patch if not
fixed.
So change posix_locks_conflict() and flock_locks_conflict() to return
bool.
Also change the locks_conflict() helper.
And conv
1 - 100 of 430 matches
Mail list logo
