Re: [PATCH] staging: mt7621-pinctrl: fix uninitialized variable ngroups

2018-11-10 Thread Sergio Paracuellos
On Sat, Nov 10, 2018 at 11:28:06PM +, Colin King wrote: > From: Colin Ian King > > Currently the for_each_node_with_property loop us incrementing variable > ngroups however it was not initialized and hence will contain garbage. > Fix this by initializing ngroups to zero. > > Detected with st

[PATCH] ftrace: remove KASAN poison in ftrace_ops_test()

2018-11-10 Thread Zhizhou Zhang
ftrace_ops_test() passed local varible parameter to hash_contains_ip(), which could result KASAN stack-out-of-bounds warning. Signed-off-by: Zhizhou Zhang --- kernel/trace/ftrace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index f536f60..

Re: Official Linux system wrapper library?

2018-11-10 Thread Michael Kerrisk (man-pages)
[adding in glibc folk for comment] On 11/10/18 7:52 PM, Daniel Colascione wrote: > Now that glibc is basically not adding any new system call wrappers, > how about publishing an "official" system call glue library as part of > the kernel distribution, along with the uapi headers? I don't think > i

Re: [PATCH] pinctrl: qcom: ssbi-gpio: fix gpio-hog related boot issues

2018-11-10 Thread Bjorn Andersson
On Sat 10 Nov 17:34 PST 2018, Brian Masney wrote: > When attempting to setup up a gpio hog, device probing will repeatedly > fail with -EPROBE_DEFERED errors. It is caused by a circular dependency > between the gpio and pinctrl frameworks. If the gpio-ranges property is > present in device tree, t

[PATCH v4 00/10] x86/alternative: text_poke() fixes

2018-11-10 Thread Nadav Amit
This patch-set addresses some issues that might affect the security and the correctness of code patching. The main issue that the patches deal with is the fact that the fixmap PTEs that are used for patching are available for access from other cores and might be exploited. They are not even flushe

[PATCH v4 01/10] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-11-10 Thread Nadav Amit
text_mutex is currently expected to be held before text_poke() is called, but we kgdb does not take the mutex, and instead *supposedly* ensures the lock is not taken and will not be acquired by any other core while text_poke() is running. The reason for the "supposedly" comment is that it is not e

[PATCH v4 02/10] x86/jump_label: Use text_poke_early() during early init

2018-11-10 Thread Nadav Amit
There is no apparent reason not to use text_poke_early() while we are during early-init and we do not patch code that might be on the stack (i.e., we'll return to the middle of the patched code). This appears to be the case of jump-labels, so do so. This is required for the next patches that would

[PATCH v4 04/10] fork: provide a function for copying init_mm

2018-11-10 Thread Nadav Amit
Provide a function for copying init_mm. This function will be later used for setting a temporary mm. Cc: Andy Lutomirski Cc: Kees Cook Cc: Peter Zijlstra Cc: Dave Hansen Reviewed-by: Masami Hiramatsu Tested-by: Masami Hiramatsu Signed-off-by: Nadav Amit --- include/linux/sched/task.h | 1

[PATCH v4 07/10] x86/kgdb: avoid redundant comparison of code

2018-11-10 Thread Nadav Amit
text_poke() already ensures that the written value is the correct one and fails if that is not the case. There is no need for an additional comparison. Remove it. Signed-off-by: Nadav Amit --- arch/x86/kernel/kgdb.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/arch/x86/kernel/k

[PATCH v4 03/10] x86/mm: temporary mm struct

2018-11-10 Thread Nadav Amit
From: Andy Lutomirski Sometimes we want to set a temporary page-table entries (PTEs) in one of the cores, without allowing other cores to use - even speculatively - these mappings. There are two benefits for doing so: (1) Security: if sensitive PTEs are set, temporary mm prevents their use in ot

[PATCH v4 05/10] x86/alternative: initializing temporary mm for patching

2018-11-10 Thread Nadav Amit
To prevent improper use of the PTEs that are used for text patching, we want to use a temporary mm struct. We initailize it by copying the init mm. The address that will be used for patching is taken from the lower area that is usually used for the task memory. Doing so prevents the need to freque

[PATCH v4 08/10] x86: avoid W^X being broken during modules loading

2018-11-10 Thread Nadav Amit
When modules and BPF filters are loaded, there is a time window in which some memory is both writable and executable. An attacker that has already found another vulnerability (e.g., a dangling pointer) might be able to exploit this behavior to overwrite kernel code. This patch prevents having writa

[PATCH v4 06/10] x86/alternative: use temporary mm for text poking

2018-11-10 Thread Nadav Amit
text_poke() can potentially compromise the security as it sets temporary PTEs in the fixmap. These PTEs might be used to rewrite the kernel code from other cores accidentally or maliciously, if an attacker gains the ability to write onto kernel memory. Moreover, since remote TLBs are not flushed a

[PATCH v4 10/10] x86/alternative: remove the return value of text_poke_*()

2018-11-10 Thread Nadav Amit
The return value of text_poke_early() and text_poke_bp() is useless. Remove it. Cc: Andy Lutomirski Cc: Kees Cook Cc: Peter Zijlstra Cc: Dave Hansen Cc: Masami Hiramatsu Signed-off-by: Nadav Amit --- arch/x86/include/asm/text-patching.h | 4 ++-- arch/x86/kernel/alternative.c| 11 +

[PATCH v4 09/10] x86/jump-label: remove support for custom poker

2018-11-10 Thread Nadav Amit
There are only two types of poking: early and breakpoint based. The use of a function pointer to perform poking complicates the code and is probably inefficient due to the use of indirect branches. Cc: Andy Lutomirski Cc: Kees Cook Cc: Peter Zijlstra Cc: Dave Hansen Cc: Masami Hiramatsu Signe

Re: [PATCH 3.16 000/410] 3.16.57-rc1 review

2018-11-10 Thread Guenter Roeck
On Sun, Nov 11, 2018 at 12:09:03AM +, Ben Hutchings wrote: > On Sat, 2018-06-16 at 22:18 +0100, Ben Hutchings wrote: > > On Fri, 2018-06-08 at 07:14 -0700, Guenter Roeck wrote: > > > On Thu, Jun 07, 2018 at 03:05:20PM +0100, Ben Hutchings wrote: > > > > This is the start of the stable review cy

[PATCH] staging: greybus: arche-apb-ctrl.c: Switch to the gpio descriptor interface

2018-11-10 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface. Signed-off-by: Nishad Kamdar --- drivers/staging/greybus/arche-apb-ctrl.c | 158 ++- 1 file changed, 65 insertions(+), 93 deletions(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/dri

[PATCH v2 1/2] perf cs-etm: Set branch instruction flags in packet

2018-11-10 Thread Leo Yan
The perf sample data contains flags to indicate the hardware trace data is belonging to which type branch instruction, thus this can be used to print out the human readable string. Arm CoreSight ETM sample data is missed to set flags and it is always set to zeros, this results in perf tool skips t

[PATCH v2 0/2] perf cs-etm: Add support for sample flags

2018-11-10 Thread Leo Yan
This patch seris adds support for sample flags so can facilitate perf to print sample flags for branch instruction. The patch 0001 is to set branch instruction flags in packet, this patch has the core code in this series to set flags according to the decoding element type, and also based on the el

[PATCH v2 2/2] perf cs-etm: Add support sample flags

2018-11-10 Thread Leo Yan
We have prepared the flags in the packet structure, so need to copy the related value into sample structure thus perf tool can facilitate sample flags. The PREV_PACKET contains the branch instruction flags and PACKET actually contains the flags for next branch instruction. So this patch is to set

[PATCH v1 2/5] perf cs-etm: Avoid stale branch samples when flush packet

2018-11-10 Thread Leo Yan
At the end of trace buffer handling, function cs_etm__flush() is invoked to flush any remaining branch stack entries. As a side effect, it also generates branch sample, because the 'etmq->packet' doesn't contains any new coming packet but point to one stale packet after packets swapping, so it wro

[PATCH v1 5/5] perf cs-etm: Track exception number

2018-11-10 Thread Leo Yan
When an exception packet comes, it contains the info for exception number; the exception number indicates the exception types, so from it we can know if the exception is taken for interrupt, system call or other traps, etc. But because the exception return packet cannot delivery exception number c

[PATCH v1 4/5] perf cs-etm: Generate branch sample for exception packet

2018-11-10 Thread Leo Yan
The exception packet appears as one element with 'elem_type' == OCSD_GEN_TRC_ELEM_EXCEPTION or OCSD_GEN_TRC_ELEM_EXCEPTION_RET, which present for exception entry and exit respectively. The decoder set packet fields 'packet->exc' and 'packet->exc_ret' to indicate the exception packets; but exceptio

[PATCH v1 1/5] perf cs-etm: Correct packets swapping in cs_etm__flush()

2018-11-10 Thread Leo Yan
The structure cs_etm_queue uses 'prev_packet' to point to previous packet, this can be used to combine with new coming packet to generate samples. In function cs_etm__flush() it swaps packets only when the flag 'etm->synth_opts.last_branch' is true, this means that it will not swap packets if with

[PATCH v1 3/5] perf cs-etm: Support for NO_SYNC packet

2018-11-10 Thread Leo Yan
As described in OpenCSD (CoreSight decoder lib), in the decoding stream it includes one trace element with type OCSD_GEN_TRC_ELEM_NO_SYNC; the element indicates 'either at start of decode, or after overflow / bad packet', we should take it as a signal for the tracing off and this will cause tracing

[PATCH v1 0/5] perf cs-etm: Correct packets handling

2018-11-10 Thread Leo Yan
perf cs-etm module converts decoder elements to packets and then we have more context crossing packets to generate synthenize samples, finally perf tool can faciliate samples for statistics and report the results. This patch series is to address several issues found related with packets handling a

Re: [PATCH v2] scripts/kconfig/merge_config: don't redefine 'y' to 'm'

2018-11-10 Thread Masahiro Yamada
On Fri, Nov 9, 2018 at 4:45 AM Anders Roxell wrote: > > In today's merge_config.sh the order of the config fragment files dictates > the output of a config option. With this approach we will get different > .config files depending on the order of the config fragment files. > > So doing something l

crashkernel=512M is no longer working on this aarch64 server

2018-11-10 Thread Qian Cai
It was broken somewhere between b00d209241ff and 3541833fd1f2. [0.00] cannot allocate crashkernel (size:0x2000) Where a good one looks like this, [0.00] crashkernel reserved: 0x0860 - 0x2860 (512 MB) Some commits look more suspicious than others.

[PATCH] arm64: disable KASAN for save_trace()

2018-11-10 Thread Zhizhou Zhang
save_trace() which is called from walk_stackframe() always try to read/write caller's stack. This results KASAN stack-out-of-bounds warning. So mute it. Signed-off-by: Zhizhou Zhang --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/

Re: dyntick-idle CPU and node's qsmask

2018-11-10 Thread Paul E. McKenney
On Sat, Nov 10, 2018 at 07:09:25PM -0800, Joel Fernandes wrote: > On Sat, Nov 10, 2018 at 03:04:36PM -0800, Paul E. McKenney wrote: > > On Sat, Nov 10, 2018 at 01:46:59PM -0800, Joel Fernandes wrote: > > > Hi Paul and everyone, > > > > > > I was tracing/studying the RCU code today in paul/dev bran

RE,

2018-11-10 Thread Miss Juliet Muhammad
I have a deal for you, in your region.

RE: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

2018-11-10 Thread Dexuan Cui
> From: gre...@linuxfoundation.org > Sent: Thursday, November 1, 2018 21:54 > To: Dexuan Cui > Cc: Michael Kelley ; KY Srinivasan > ; linux-kernel@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; Stephen Hemminger ; > vkuznets ; Sasha Lev

RE,

2018-11-10 Thread Miss Juliet Muhammad
I have a deal for you, in your region.

Re: [PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd

2018-11-10 Thread Joel Fernandes
On Sat, Nov 10, 2018 at 07:40:10PM -0800, Andy Lutomirski wrote: > > > > On Nov 10, 2018, at 6:38 PM, Joel Fernandes wrote: > > > >> On Sat, Nov 10, 2018 at 02:18:23PM -0800, Andy Lutomirski wrote: > >> > On Nov 10, 2018, at 2:09 PM, Joel Fernandes > wrote: > > > On Sat,

Re: [PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd

2018-11-10 Thread Andy Lutomirski
> On Nov 10, 2018, at 6:38 PM, Joel Fernandes wrote: > >> On Sat, Nov 10, 2018 at 02:18:23PM -0800, Andy Lutomirski wrote: >> On Nov 10, 2018, at 2:09 PM, Joel Fernandes wrote: > On Sat, Nov 10, 2018 at 11:11:27AM -0800, Daniel Colascione wrote: >> On Sat, Nov 10, 2018 at

Re: [PATCH for-stable] dmaengine: stm32-dma: fix incomplete configuration in cyclic mode

2018-11-10 Thread Greg KH
On Tue, Oct 16, 2018 at 05:00:03PM -0700, Joel Fernandes (Google) wrote: > From: Pierre Yves MORDRET > > commit e57cb3b3f10d005410f09d4598cc6d62b833f2b0 upstream. > > When in cyclic mode, the configuration is updated after having started the > DMA hardware (STM32_DMA_SCR_EN) leading to incomplet

Re: dyntick-idle CPU and node's qsmask

2018-11-10 Thread Joel Fernandes
On Sat, Nov 10, 2018 at 03:04:36PM -0800, Paul E. McKenney wrote: > On Sat, Nov 10, 2018 at 01:46:59PM -0800, Joel Fernandes wrote: > > Hi Paul and everyone, > > > > I was tracing/studying the RCU code today in paul/dev branch and noticed > > that > > for dyntick-idle CPUs, the RCU GP thread is c

sound/pci/hda/patch_ca0132.c:7650:20: error: implicit declaration of function 'pci_iomap'; did you mean 'pcim_iomap'?

2018-11-10 Thread kbuild test robot
Hi Rakesh, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e255aee5b66ce4af025e6f77122114c01303b861 commit: 6bae5ea9498926440ffc883f3dbceb0adc65e492 ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers da

Re: PEBS level 2/3 breaks dwarf unwinding! [WAS: Re: Broken dwarf unwinding - wrong stack pointer register value?]

2018-11-10 Thread Travis Downs
On Sat, Nov 10, 2018 at 8:07 PM Andi Kleen wrote: > > On Sat, Nov 10, 2018 at 04:42:48PM -0500, Travis Downs wrote: > > I guess this problem doesn't occur for LBR unwinding since the LBR > > records are captured at the same > > moment in time as the PEBS record, so reflect the correct branch > > s

Re: [PATCH] proc: fix and merge proc-self-map-file tests

2018-11-10 Thread Rafael David Tinoco
On Sat, Nov 10, 2018, at 4:49 PM, Alexey Dobriyan wrote: > On Sat, Nov 10, 2018 at 03:56:03PM -0200, Rafael David Tinoco wrote: > > On Sat, Nov 10, 2018, at 3:47 PM, Alexey Dobriyan wrote: > > > On Fri, Nov 09, 2018 at 09:30:36AM -0200, Rafael David Tinoco wrote: > > > > Merge proc-self-map-files t

Re: [PATCH] proc: fixup map_files test on arm

2018-11-10 Thread Rafael David Tinoco
Including Shuah and kselftest list... On Sat, Nov 10, 2018, at 4:49 PM, Alexey Dobriyan wrote: > https://bugs.linaro.org/show_bug.cgi?id=3782 > > Turns out arm doesn't allow to map address 0, so try minimum virtual > address instead. > > Reported-by: Rafael David Tinoco > Signed-off-by: Alexey

Re: [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree

2018-11-10 Thread Sebastian Reichel
Hi, On Sun, Nov 11, 2018 at 12:20:34AM +0100, Andreas Kemnade wrote: > This is a first try to be able to use h4 devices specified in > the devicetree, so you do not need to call hciattach and > it can be automatically probed. > > Of course, proper devicetree bindings documentation is > missing. A

Re: [PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd

2018-11-10 Thread Joel Fernandes
On Sat, Nov 10, 2018 at 02:18:23PM -0800, Andy Lutomirski wrote: > > > On Nov 10, 2018, at 2:09 PM, Joel Fernandes wrote: > > > >> On Sat, Nov 10, 2018 at 11:11:27AM -0800, Daniel Colascione wrote: > >>> On Sat, Nov 10, 2018 at 10:45 AM, Daniel Colascione > >>> wrote: > On Sat, Nov 10, 20

Can I Trust You?

2018-11-10 Thread Abel Brent
Dear friend, I am Abel Brent, a NATO soldier serving in Afghanistan. I and my Comrades, we are seeking your assistance to help us receive/invest our funds in your country in any lucrative business. Please if this proposal is acceptable by you, kindly respond back to me for more details. Thank

Re: [PATCH] clk: qcom: gcc: Fix board clock node name

2018-11-10 Thread Taniya Das
Hello Vinod, On 11/9/2018 3:20 PM, Vinod Koul wrote: Device tree node name are not supposed to have "_" in them so fix the node name use of xo_board to xo-board Fixes: 652f1813c113 ("clk: qcom: gcc: Add global clock controller driver for QCS404") Signed-off-by: Vinod Koul --- Steve: RobH poi

WARNING in ovl_instantiate

2018-11-10 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:442b8cea2477 Add linux-next specific files for 20181109 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=169a6fbd40 kernel config: https://syzkaller.appspot.com/x/.config?x=2f72bdb11df9fbe8 dashb

Re: stable/linux-3.16.y build: 178 builds: 1 failed, 177 passed, 2 errors, 57 warnings (v3.16.52)

2018-11-10 Thread Ben Hutchings
On Sat, 2018-01-13 at 19:51 +0100, Manfred Spraul wrote: > Hi Arnd, > > On 01/03/2018 12:15 AM, Arnd Bergmann wrote: > > > 2 ipc/sem.c:377:6: warning: '___p1' may be used uninitialized in this > > > function [-Wmaybe-uninitialized] > > This code was last touched in 3.16 by the backport of commit

[PATCH] pinctrl: qcom: ssbi-gpio: fix gpio-hog related boot issues

2018-11-10 Thread Brian Masney
When attempting to setup up a gpio hog, device probing will repeatedly fail with -EPROBE_DEFERED errors. It is caused by a circular dependency between the gpio and pinctrl frameworks. If the gpio-ranges property is present in device tree, then the gpio framework will handle the gpio pin registratio

Re: [RFC PATCH 07/12] locking/lockdep: Add support for nested terminal locks

2018-11-10 Thread Peter Zijlstra
On Sat, Nov 10, 2018 at 07:30:54PM -0500, Waiman Long wrote: > On 11/10/2018 09:20 AM, Peter Zijlstra wrote: > > On Thu, Nov 08, 2018 at 03:34:23PM -0500, Waiman Long wrote: > >> There are use cases where we want to allow 2-level nesting of one > >> terminal lock underneath another one. So the term

Re: Patch to consider for stable 3.18, 4.4 and 4.9

2018-11-10 Thread Ben Hutchings
On Mon, 2018-03-05 at 20:43 +, Tomasz Kramkowski wrote: > In September last year, Ben Hutchings submitted commit [9547837bdccb] > for 3.16.48-rc1 and I informed him that it would be useless without > [3f3752705dbd] (and that maybe [c3883fe06488] would be useful as well). > Ben dropped the patch

Re: [RFC PATCH 01/12] locking/lockdep: Rework lockdep_set_novalidate_class()

2018-11-10 Thread Peter Zijlstra
On Sat, Nov 10, 2018 at 07:26:51PM -0500, Waiman Long wrote: > On 11/10/2018 09:14 AM, Peter Zijlstra wrote: > > On Thu, Nov 08, 2018 at 03:34:17PM -0500, Waiman Long wrote: > >> The current lockdep_set_novalidate_class() implementation is like > >> a hack. It assigns a special class key for that l

[PATCH] xfs: Remove noinline from #define STATIC

2018-11-10 Thread Joe Perches
Reduce total object size quite a bit (~32KB) and presumably improve performance at the same time. Total object size old vs new (x86-64 defconfig with xfs) text data bss dec hex filename - 959351 165573 632 1125556 112cb4 (TOTALS) (old) + 924683 16566

Re: PEBS level 2/3 breaks dwarf unwinding! [WAS: Re: Broken dwarf unwinding - wrong stack pointer register value?]

2018-11-10 Thread Andi Kleen
On Sat, Nov 10, 2018 at 04:42:48PM -0500, Travis Downs wrote: > I guess this problem doesn't occur for LBR unwinding since the LBR > records are captured at the same > moment in time as the PEBS record, so reflect the correct branch > sequence. Actually it happens with LBRs too, but it always give

Re: [PATCH] Fix coding style issue in xfs_acl.c and xfs_aops.c

2018-11-10 Thread Joe Perches
On Sun, 2018-11-11 at 08:36 +0800, hmsjwzb wrote: > Possible unwrapped commit description (prefer a maximum 75 chars per line) This commit message makes no sense. Do say what you do to the code in the commit description. > Signed-off-by: hmsjwzb > --- > fs/xfs/xfs_acl.c | 4 +-- > fs/xfs/xf

[PATCH] Fix coding style issue in xfs_acl.c and xfs_aops.c

2018-11-10 Thread hmsjwzb
Possible unwrapped commit description (prefer a maximum 75 chars per line) Signed-off-by: hmsjwzb --- fs/xfs/xfs_acl.c | 4 +-- fs/xfs/xfs_aops.c | 73 --- 2 files changed, 39 insertions(+), 38 deletions(-) diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs

Re: [PATCH] x86/mm/pat: Fix missing preemption disable for __native_flush_tlb()

2018-11-10 Thread Dan Williams
[ added Kirill ] On Sat, Nov 10, 2018 at 4:19 PM Andy Lutomirski wrote: > > On Nov 10, 2018, at 3:57 PM, Dan Williams wrote: > > > >> On Fri, Nov 9, 2018 at 4:22 PM Andy Lutomirski wrote: > >> > >> > >> > >>> On Nov 9, 2018, at 4:05 PM, Dan Williams wrote: > >>> > >>> Commit f77084d96355 "x86/

Re: [RFC PATCH 07/12] locking/lockdep: Add support for nested terminal locks

2018-11-10 Thread Waiman Long
On 11/10/2018 09:20 AM, Peter Zijlstra wrote: > On Thu, Nov 08, 2018 at 03:34:23PM -0500, Waiman Long wrote: >> There are use cases where we want to allow 2-level nesting of one >> terminal lock underneath another one. So the terminal lock type is now >> extended to support a new nested terminal lo

Re: [RFC PATCH 02/12] locking/lockdep: Add a new terminal lock type

2018-11-10 Thread Waiman Long
On 11/10/2018 09:17 AM, Peter Zijlstra wrote: > On Thu, Nov 08, 2018 at 03:34:18PM -0500, Waiman Long wrote: >> A terminal lock is a lock where further locking or unlocking on another >> lock is not allowed. IOW, no forward dependency is permitted. >> >> With such a restriction in place, we don't r

Re: [RFC PATCH 01/12] locking/lockdep: Rework lockdep_set_novalidate_class()

2018-11-10 Thread Waiman Long
On 11/10/2018 09:14 AM, Peter Zijlstra wrote: > On Thu, Nov 08, 2018 at 03:34:17PM -0500, Waiman Long wrote: >> The current lockdep_set_novalidate_class() implementation is like >> a hack. It assigns a special class key for that lock and calls >> lockdep_init_map() twice. > Ideally it would go away

Re: [PATCH] x86/mm/pat: Fix missing preemption disable for __native_flush_tlb()

2018-11-10 Thread Andy Lutomirski
> On Nov 10, 2018, at 3:57 PM, Dan Williams wrote: > >> On Fri, Nov 9, 2018 at 4:22 PM Andy Lutomirski wrote: >> >> >> >>> On Nov 9, 2018, at 4:05 PM, Dan Williams wrote: >>> >>> Commit f77084d96355 "x86/mm/pat: Disable preemption around >>> __flush_tlb_all()" addressed a case where __flu

Re: [PATCH 3.16 000/410] 3.16.57-rc1 review

2018-11-10 Thread Ben Hutchings
On Sat, 2018-06-16 at 22:18 +0100, Ben Hutchings wrote: > On Fri, 2018-06-08 at 07:14 -0700, Guenter Roeck wrote: > > On Thu, Jun 07, 2018 at 03:05:20PM +0100, Ben Hutchings wrote: > > > This is the start of the stable review cycle for the 3.16.57 release. > > > There are 410 patches in this series

Re: [PATCH] x86/mm/pat: Fix missing preemption disable for __native_flush_tlb()

2018-11-10 Thread Dan Williams
On Fri, Nov 9, 2018 at 4:22 PM Andy Lutomirski wrote: > > > > > On Nov 9, 2018, at 4:05 PM, Dan Williams wrote: > > > > Commit f77084d96355 "x86/mm/pat: Disable preemption around > > __flush_tlb_all()" addressed a case where __flush_tlb_all() is called > > without preemption being disabled. It al

SPENDE MAVIS WANCZYK

2018-11-10 Thread info
Sehr geehrter Herr/Frau, Wir freuen uns, Ihnen mitzuteilen, dass Sie ausgewählt wurden, um die Summe zu erhalten €2,000,000.00 Euro aus Mitteln der Mavis Wanczyk Hilfe. Mein Name ist Mavis Wanczyk der Gewinner des 758,7 Millionen US-Dollar in der Power Ball Lotterie Jackpot als der größte Preis

Re: [RFC PATCH 00/12] locking/lockdep: Add a new class of terminal locks

2018-11-10 Thread Waiman Long
On 11/10/2018 09:10 AM, Peter Zijlstra wrote: > On Fri, Nov 09, 2018 at 09:04:12AM +0100, Ingo Molnar wrote: >> BTW., if you are interested in more radical approaches to optimize >> lockdep, we could also add a static checker via objtool driven call graph >> analysis, and mark those locks termina

Re: [PATCH 1/1] stackleak: Disable ftrace for stackleak.c

2018-11-10 Thread Steven Rostedt
On Sun, 11 Nov 2018 01:05:30 +0300 Alexander Popov wrote: > The stackleak_erase() function is called on the trampoline stack at the > end of syscall. This stack is not big enough for ftrace operations, > e.g. it can be overflowed if we enable kprobe_events for stackleak_erase(). Is the issue wit

[PATCH] staging: mt7621-pinctrl: fix uninitialized variable ngroups

2018-11-10 Thread Colin King
From: Colin Ian King Currently the for_each_node_with_property loop us incrementing variable ngroups however it was not initialized and hence will contain garbage. Fix this by initializing ngroups to zero. Detected with static analysis with cppcheck: drivers/staging/mt7621-pinctrl/pinctrl-rt288

Re: [PATCH RFC 0/3] Static calls

2018-11-10 Thread Peter Zijlstra
On Fri, Nov 09, 2018 at 02:50:27PM +0100, Ard Biesheuvel wrote: > On 9 November 2018 at 08:28, Ingo Molnar wrote: > >> - I'm not sure about the objtool approach. Objtool is (currently) > >> x86-64 only, which means we have to use the "unoptimized" version > >> everywhere else. I may experime

[PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree

2018-11-10 Thread Andreas Kemnade
This is a first try to be able to use h4 devices specified in the devicetree, so you do not need to call hciattach and it can be automatically probed. Of course, proper devicetree bindings documentation is missing. And also you would extend that by regulator/ enable gpio settings. But before proc

Re: dyntick-idle CPU and node's qsmask

2018-11-10 Thread Paul E. McKenney
On Sat, Nov 10, 2018 at 01:46:59PM -0800, Joel Fernandes wrote: > Hi Paul and everyone, > > I was tracing/studying the RCU code today in paul/dev branch and noticed that > for dyntick-idle CPUs, the RCU GP thread is clearing the rnp->qsmask > corresponding to the leaf node for the idle CPU, and re

[PATCH] vfio/pci: fix ptr_ret.cocci warnings

2018-11-10 Thread kbuild test robot
From: kbuild test robot drivers/vfio/pci/vfio_pci.c:1396:8-14: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 25e57457f6f2 ("vfio/pci: Parallelize device open and release") CC: Alex Will

Re: [PATCH] vfio/pci: Parallelize device open and release

2018-11-10 Thread kbuild test robot
Hi Alex, I love your patch! Perhaps something to improve: [auto build test WARNING on vfio/next] [also build test WARNING on v4.20-rc1 next-20181109] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/comm

Re: [RFC PATCH 01/12] locking/lockdep: Rework lockdep_set_novalidate_class()

2018-11-10 Thread Peter Zijlstra
On Thu, Nov 08, 2018 at 03:34:17PM -0500, Waiman Long wrote: > The current lockdep_set_novalidate_class() implementation is like > a hack. It assigns a special class key for that lock and calls > lockdep_init_map() twice. Ideally it would go away.. it is not thing that should be used. > This patc

Re: [RFC PATCH 07/12] locking/lockdep: Add support for nested terminal locks

2018-11-10 Thread Peter Zijlstra
On Thu, Nov 08, 2018 at 03:34:23PM -0500, Waiman Long wrote: > There are use cases where we want to allow 2-level nesting of one > terminal lock underneath another one. So the terminal lock type is now > extended to support a new nested terminal lock where it can allow the > acquisition of another

Re: [RFC PATCH 02/12] locking/lockdep: Add a new terminal lock type

2018-11-10 Thread Peter Zijlstra
On Thu, Nov 08, 2018 at 03:34:18PM -0500, Waiman Long wrote: > A terminal lock is a lock where further locking or unlocking on another > lock is not allowed. IOW, no forward dependency is permitted. > > With such a restriction in place, we don't really need to do a full > validation of the lock ch

Re: [RFC PATCH 00/12] locking/lockdep: Add a new class of terminal locks

2018-11-10 Thread Peter Zijlstra
On Fri, Nov 09, 2018 at 09:04:12AM +0100, Ingo Molnar wrote: > BTW., if you are interested in more radical approaches to optimize > lockdep, we could also add a static checker via objtool driven call graph > analysis, and mark those locks terminal that we can prove are terminal. > > This would r

Re: [PATCH 1/2] locking/lockdep: Add support for dynamic depmaps and keys

2018-11-10 Thread Peter Zijlstra
On Fri, Nov 09, 2018 at 03:46:44PM -0800, Bart Van Assche wrote: > The lock validator forces to categorize multiple instances of a lock object > as the same lock class because it requires that struct lockdep_map and struct > lock_class_key instances are static objects. This can result in false > po

Re: [PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd

2018-11-10 Thread Andy Lutomirski
> On Nov 10, 2018, at 2:09 PM, Joel Fernandes wrote: > >> On Sat, Nov 10, 2018 at 11:11:27AM -0800, Daniel Colascione wrote: >>> On Sat, Nov 10, 2018 at 10:45 AM, Daniel Colascione >>> wrote: On Sat, Nov 10, 2018 at 10:24 AM, Joel Fernandes wrote: Thanks Andy for your thought

Re: [PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd

2018-11-10 Thread Joel Fernandes
On Sat, Nov 10, 2018 at 11:11:27AM -0800, Daniel Colascione wrote: > On Sat, Nov 10, 2018 at 10:45 AM, Daniel Colascione wrote: > > On Sat, Nov 10, 2018 at 10:24 AM, Joel Fernandes > > wrote: > >> Thanks Andy for your thoughts, my comments below: > [snip] > >> I don't see it as warty, different

[PATCH] MIPS: OCTEON: cavium_octeon_defconfig: re-enable OCTEON USB driver

2018-11-10 Thread Aaro Koskinen
Re-enable OCTEON USB driver which is needed on older hardware (e.g. EdgeRouter Lite) for mass storage etc. This got accidentally deleted when config options were changed for OCTEON2/3 USB. Fixes: f922bc0ad08b ("MIPS: Octeon: cavium_octeon_defconfig: Enable more drivers") Signed-off-by: Aaro Koski

[PATCH 1/1] stackleak: Disable ftrace for stackleak.c

2018-11-10 Thread Alexander Popov
The stackleak_erase() function is called on the trampoline stack at the end of syscall. This stack is not big enough for ftrace operations, e.g. it can be overflowed if we enable kprobe_events for stackleak_erase(). Let's disable ftrace for stackleak.c to avoid such situations. Reported-by: kerne

Re: [PATCH v9 02/10] Makefile: Prepare for using macros for inline asm

2018-11-10 Thread Nadav Amit
From: Nadav Amit Sent: November 8, 2018 at 8:18:23 PM GMT > To: Logan Gunthorpe , h...@zytor.com , > Ingo Molnar > Cc: LKML , X86 ML , Sam > Ravnborg , Michal Marek , Thomas > Gleixner , Linux Kbuild mailing list > , Stephen Bates > Subject: Re: [PATCH v9 02/10] Makefile: Prepare for using ma

RE: [PATCH] cpuidle: poll_state: Revise loop termination condition

2018-11-10 Thread Doug Smythies
On 2018.10.02 14:51 Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > If need_resched() returns "false", breaking out of the loop in > poll_idle() will cause a new idle state to be selected, so in fact > usually it doesn't make sense to spin in it longer than the target > residency of the se

dyntick-idle CPU and node's qsmask

2018-11-10 Thread Joel Fernandes
Hi Paul and everyone, I was tracing/studying the RCU code today in paul/dev branch and noticed that for dyntick-idle CPUs, the RCU GP thread is clearing the rnp->qsmask corresponding to the leaf node for the idle CPU, and reporting a QS on their behalf. rcu_sched-10[003]40.008039: rcu_fqs

RE: [RFC/RFT][PATCH v3] cpuidle: New timer events oriented governor for tickless systems

2018-11-10 Thread Doug Smythies
On 2018.11.07 09:04 Doug Smythies wrote: > The Phoronix dbench test was run under the option to run all > the tests, instead of just one number of clients. This was done > with a reference/baseline kernel of 4.20-rc1, and also with this > TEO version 3 patch. The tests were also repeated with trac

Re: PEBS level 2/3 breaks dwarf unwinding! [WAS: Re: Broken dwarf unwinding - wrong stack pointer register value?]

2018-11-10 Thread Travis Downs
On Mon, Nov 5, 2018 at 7:11 PM Andi Kleen wrote: > Milian is right. > > There is a execution window from PEBS capturing registers to actually > triggering > the PMU, and if there is stack manipulation in that window > the PEBS state might be out of sync with the real stack. This explains some we

Re: [PATCH 12/16] x86/microcode/AMD: Fix container size's type

2018-11-10 Thread kbuild test robot
Hi Borislav, I love your patch! Perhaps something to improve: [auto build test WARNING on tip/x86/core] [also build test WARNING on v4.20-rc1 next-20181109] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/lin

[PATCH v2 0/3] mach-omap2: handle autoidle denial

2018-11-10 Thread Andreas Kemnade
On the gta04 with a dm3730 omap_hdq does not work properly when the device enters lower power states. Idling uart1 and 2 is enough to show up that problem, if there are no other things enabled. Further research reveals that hdq iclk must not be turned off during transfers, also according to the TRM

[PATCH v2 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that

2018-11-10 Thread Andreas Kemnade
Deny autoidle for hwmods with the OCPIF_SWSUP_IDLE flag, that makes hwmods working properly which cannot handle autoidle properly in lower power states. Affected is e. g. the omap_hdq. Since an ick might have mulitple users, autoidle is disabled when an individual user requires that rather than in

[PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops

2018-11-10 Thread Andreas Kemnade
Code might use autoidle api with clocks not being omap2 clocks, so check if clock type is not basic Signed-off-by: Andreas Kemnade --- New in v2 --- drivers/clk/ti/autoidle.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/clk/ti/autoidle.c b/drivers/clk

[PATCH v2 1/3] clk: ti: add a usecount for autoidle

2018-11-10 Thread Andreas Kemnade
Multiple users might deny autoidle on a clock. So we should have some counting here, also according to the comment in _setup_iclk_autoidle(). Also setting autoidle regs is not atomic, so there is another reason for locking. Signed-off-by: Andreas Kemnade --- Changes since v1: - use spinlocks ins

[PATCH 2/2] rtc: nvmem: remove nvmem from struct rtc_device

2018-11-10 Thread Alexandre Belloni
Using devm_nvmem_register allows to avoid tracking the nvmem pointer in the rtc_device structure. This ultimately allows to register multiple nvmem devices from an RTC driver. Signed-off-by: Alexandre Belloni --- drivers/rtc/nvmem.c | 24 ++-- include/linux/rtc.h | 1 - 2 fi

[PATCH 1/2] rtc: nvmem: use devm_nvmem_register()

2018-11-10 Thread Alexandre Belloni
Use the resource managed variant of nvmem_register(). Signed-off-by: Alexandre Belloni --- drivers/rtc/nvmem.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/rtc/nvmem.c b/drivers/rtc/nvmem.c index 36ab183c42f1..2a7220d8b02d 100644 --- a/drivers/rtc/nvmem.c +++

[PATCH] rtc: class: remove devm_rtc_device_unregister

2018-11-10 Thread Alexandre Belloni
devm_rtc_device_unregister is not used by any driver and should not be used by any new driver. Signed-off-by: Alexandre Belloni --- drivers/rtc/class.c | 26 -- include/linux/rtc.h | 2 -- 2 files changed, 28 deletions(-) diff --git a/drivers/rtc/class.c b/drivers/rtc/c

Re: A different PD controller firmware problem?

2018-11-10 Thread Theodore Y. Ts'o
On Thu, Nov 08, 2018 at 04:15:40PM -0500, Theodore Y. Ts'o wrote: > On Thu, Nov 08, 2018 at 06:00:59PM +, mario.limoncie...@dell.com wrote: > > > Sortly after 12:30am US/Eastern, I got a low power warning on my > > > system, and the battery power had dropped below 10%. Apparently the > > > lap

Re: [PATCH] scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks

2018-11-10 Thread Genki Sky
Hi Andreas, On Sat, 10 Nov 2018 11:42:11 +0100, Andreas Schwab wrote: > On Nov 10 2018, Genki Sky wrote: > > On Fri, 9 Nov 2018 10:34:37 -0800, Brian Norris > > wrote: > >> + git_status="$(git --no-optional-locks status -uno --porcelain > >> 2>/dev/null)" > >> + if [ $? -eq

Re: Official Linux system wrapper library?

2018-11-10 Thread Vlastimil Babka
On 11/10/18 8:20 PM, Greg KH wrote: > On Sat, Nov 10, 2018 at 10:52:06AM -0800, Daniel Colascione wrote: >> Now that glibc is basically not adding any new system call wrappers, > > Why are they not doing that anymore? FYI just noticed there's a topic relevant to this in LPC Toolchain MC: https:/

Re: [PATCH v3 resend 1/2] mm: Add an F_SEAL_FUTURE_WRITE seal to memfd

2018-11-10 Thread Andy Lutomirski
> On Nov 10, 2018, at 11:11 AM, Daniel Colascione wrote: > >> On Sat, Nov 10, 2018 at 10:45 AM, Daniel Colascione >> wrote: >>> On Sat, Nov 10, 2018 at 10:24 AM, Joel Fernandes >>> wrote: >>> Thanks Andy for your thoughts, my comments below: > [snip] >>> I don't see it as warty, different s

Re: [git pull] drm fixes for 4.20-rc2

2018-11-10 Thread pr-tracker-bot
The pull request you sent on Sun, 11 Nov 2018 04:43:57 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2018-11-11 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/20ef6d06ef9a31a33516637a80521b9fc7f1f849 Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [GIT PULL] clk fixes for v4.20-rc1

2018-11-10 Thread pr-tracker-bot
The pull request you sent on Sat, 10 Nov 2018 10:04:23 -0800: > https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git > tags/clk-fixes-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a1aa42f1d8c00a0767afee28d17caafd2a4dd8ff Thank you! -- Deet-doot-

Re: [GIT PULL] TTY/Serial fixes for 4.20-rc2

2018-11-10 Thread pr-tracker-bot
The pull request you sent on Sat, 10 Nov 2018 10:57:08 -0800: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tags/tty-4.20-rc2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e255aee5b66ce4af025e6f77122114c01303b861 Thank you! -- Deet-doot-dot, I am a

  1   2   3   >