Re: [PATCH v3 3/3] thermal: tegra: parse sensor id before sensor register

2018-11-29 Thread Wei Ni
On 30/11/2018 1:13 AM, Thierry Reding wrote: > On Thu, Nov 29, 2018 at 01:55:02PM +0800, Wei Ni wrote: >> On 28/11/2018 6:25 PM, Thierry Reding wrote: >>> On Wed, Nov 28, 2018 at 01:44:37PM +0800, Wei Ni wrote: > [...] + bool ret = false; + struct of_phandle_args sensor_specs;

RE: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-29 Thread Ryan Lee
>-Original Message- >From: Grant Grundler >Sent: Wednesday, November 28, 2018 5:56 PM >To: Ryan Lee >Cc: broo...@kernel.org; Liam Girdwood ; >pe...@perex.cz; ti...@suse.com; Grant Grundler >; Kuninori Morimoto >; Benson Leung >; alsa-de...@alsa-project.org; LKML ker...@vger.kernel.org>;

Re: [PATCH v3 3/3] thermal: tegra: parse sensor id before sensor register

2018-11-29 Thread Wei Ni
On 30/11/2018 1:13 AM, Thierry Reding wrote: > On Thu, Nov 29, 2018 at 01:55:02PM +0800, Wei Ni wrote: >> On 28/11/2018 6:25 PM, Thierry Reding wrote: >>> On Wed, Nov 28, 2018 at 01:44:37PM +0800, Wei Ni wrote: > [...] + bool ret = false; + struct of_phandle_args sensor_specs;

RE: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-29 Thread Ryan Lee
>-Original Message- >From: Grant Grundler >Sent: Wednesday, November 28, 2018 5:56 PM >To: Ryan Lee >Cc: broo...@kernel.org; Liam Girdwood ; >pe...@perex.cz; ti...@suse.com; Grant Grundler >; Kuninori Morimoto >; Benson Leung >; alsa-de...@alsa-project.org; LKML ker...@vger.kernel.org>;

Re: [PATCH] thermal: tegra: add get_trend ops

2018-11-29 Thread Wei Ni
On 30/11/2018 1:01 AM, Eduardo Valentin wrote: > On Wed, Nov 21, 2018 at 02:36:10PM +0800, Wei Ni wrote: >> >> >> On 20/11/2018 11:38 PM, Thierry Reding wrote: >>> On Tue, Nov 20, 2018 at 05:11:17PM +0800, Wei Ni wrote: Add support for get_trend ops that allows soctherm sensors to be

Re: [PATCH] thermal: tegra: add get_trend ops

2018-11-29 Thread Wei Ni
On 30/11/2018 1:01 AM, Eduardo Valentin wrote: > On Wed, Nov 21, 2018 at 02:36:10PM +0800, Wei Ni wrote: >> >> >> On 20/11/2018 11:38 PM, Thierry Reding wrote: >>> On Tue, Nov 20, 2018 at 05:11:17PM +0800, Wei Ni wrote: Add support for get_trend ops that allows soctherm sensors to be

Re: [PATCH v2] lzo: fix ip overrun during compress.

2018-11-29 Thread Yueyi Li
Hi Dave, On 2018/11/30 0:49, Dave Rodgman wrote: > On 28/11/2018 1:52 pm, David Sterba wrote: > >> The fix is adding a few branches to code that's supposed to be as fast >> as possible. The branches would be evaluated all the time while >> protecting against one signle bad page address. This

Re: [PATCH v2] lzo: fix ip overrun during compress.

2018-11-29 Thread Yueyi Li
Hi Dave, On 2018/11/30 0:49, Dave Rodgman wrote: > On 28/11/2018 1:52 pm, David Sterba wrote: > >> The fix is adding a few branches to code that's supposed to be as fast >> as possible. The branches would be evaluated all the time while >> protecting against one signle bad page address. This

Re: [PATCH 7/7] lib/lzo: separate lzo-rle from lzo

2018-11-29 Thread Sergey Senozhatsky
On (11/29/18 10:21), Dave Rodgman wrote: > > [..] > >> +++ b/drivers/block/zram/zcomp.c > >> @@ -20,6 +20,7 @@ > >> > >> static const char * const backends[] = { > >>"lzo", > >> + "lzo-rle", > >> #if IS_ENABLED(CONFIG_CRYPTO_LZ4) > >>"lz4", > >> #endif > > > > [..] > > > >> +++

Re: [PATCH 7/7] lib/lzo: separate lzo-rle from lzo

2018-11-29 Thread Sergey Senozhatsky
On (11/29/18 10:21), Dave Rodgman wrote: > > [..] > >> +++ b/drivers/block/zram/zcomp.c > >> @@ -20,6 +20,7 @@ > >> > >> static const char * const backends[] = { > >>"lzo", > >> + "lzo-rle", > >> #if IS_ENABLED(CONFIG_CRYPTO_LZ4) > >>"lz4", > >> #endif > > > > [..] > > > >> +++

Re: [PATCH v2 0/6] RFC: gup+dma: tracking dma-pinned pages

2018-11-29 Thread John Hubbard
On 11/29/18 6:30 PM, Tom Talpey wrote: > On 11/29/2018 9:21 PM, John Hubbard wrote: >> On 11/29/18 6:18 PM, Tom Talpey wrote: >>> On 11/29/2018 8:39 PM, John Hubbard wrote: On 11/28/18 5:59 AM, Tom Talpey wrote: > On 11/27/2018 9:52 PM, John Hubbard wrote: >> On 11/27/18 5:21 PM, Tom

Re: [PATCH v4 3/3] thermal: tegra: parse sensor id before sensor register

2018-11-29 Thread Wei Ni
On 30/11/2018 12:46 AM, Eduardo Valentin wrote: > On Thu, Nov 29, 2018 at 06:09:43PM +0800, Wei Ni wrote: >> Since different platforms may not support all 4 >> sensors, so the sensor registration may be failed. >> Add codes to parse dt to find sensor id which >> need to be registered. So that

Re: [PATCH v2 0/6] RFC: gup+dma: tracking dma-pinned pages

2018-11-29 Thread John Hubbard
On 11/29/18 6:30 PM, Tom Talpey wrote: > On 11/29/2018 9:21 PM, John Hubbard wrote: >> On 11/29/18 6:18 PM, Tom Talpey wrote: >>> On 11/29/2018 8:39 PM, John Hubbard wrote: On 11/28/18 5:59 AM, Tom Talpey wrote: > On 11/27/2018 9:52 PM, John Hubbard wrote: >> On 11/27/18 5:21 PM, Tom

Re: [PATCH v4 3/3] thermal: tegra: parse sensor id before sensor register

2018-11-29 Thread Wei Ni
On 30/11/2018 12:46 AM, Eduardo Valentin wrote: > On Thu, Nov 29, 2018 at 06:09:43PM +0800, Wei Ni wrote: >> Since different platforms may not support all 4 >> sensors, so the sensor registration may be failed. >> Add codes to parse dt to find sensor id which >> need to be registered. So that

> [PATCH] Security: Handle hidepid option correctly

2018-11-29 Thread 程洋
Here is an article illustrates the details. https://medium.com/@topjohnwu/from-anime-game-to-android-system-security-vulnerability-9b955a182f20 And There is a similar fix on kernel-4.4:

> [PATCH] Security: Handle hidepid option correctly

2018-11-29 Thread 程洋
Here is an article illustrates the details. https://medium.com/@topjohnwu/from-anime-game-to-android-system-security-vulnerability-9b955a182f20 And There is a similar fix on kernel-4.4:

Re: [PATCH v4 1/3] thermal: tegra: remove unnecessary warnings

2018-11-29 Thread Wei Ni
On 30/11/2018 12:39 AM, Eduardo Valentin wrote: > Hey, > > On Thu, Nov 29, 2018 at 06:09:41PM +0800, Wei Ni wrote: >> Convert warnings to info as not all platforms may >> have all the thresholds and sensors enabled. >> >> Signed-off-by: Wei Ni >> --- >> drivers/thermal/tegra/soctherm.c | 6

Re: [PATCH v4 1/3] thermal: tegra: remove unnecessary warnings

2018-11-29 Thread Wei Ni
On 30/11/2018 12:39 AM, Eduardo Valentin wrote: > Hey, > > On Thu, Nov 29, 2018 at 06:09:41PM +0800, Wei Ni wrote: >> Convert warnings to info as not all platforms may >> have all the thresholds and sensors enabled. >> >> Signed-off-by: Wei Ni >> --- >> drivers/thermal/tegra/soctherm.c | 6

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Chao Fan
>> + >> +/* acpitb.c */ >> +#define BOOT_STRING >> +extern int kstrtoull(const char *s, unsigned int base, unsigned long long >> *res); >> diff --git a/lib/kstrtox.c b/lib/kstrtox.c >> index 1006bf70bf74..a0ac1b2257b8 100644 >> --- a/lib/kstrtox.c >> +++ b/lib/kstrtox.c >> @@ -126,6 +126,9 @@ int

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Chao Fan
>> + >> +/* acpitb.c */ >> +#define BOOT_STRING >> +extern int kstrtoull(const char *s, unsigned int base, unsigned long long >> *res); >> diff --git a/lib/kstrtox.c b/lib/kstrtox.c >> index 1006bf70bf74..a0ac1b2257b8 100644 >> --- a/lib/kstrtox.c >> +++ b/lib/kstrtox.c >> @@ -126,6 +126,9 @@ int

Re: [PATCH v2] signal: add procfd_signal() syscall

2018-11-29 Thread Aleksa Sarai
On 2018-11-29, Arnd Bergmann wrote: > waitid() probably remains on my plate anyway, and I hope understand > where we're at with it. Having a way to wait on a processfd is something we'll eventually need, though the semantics of zombies might get a little bit hairy. I propose we work through that

Re: [PATCH v2] signal: add procfd_signal() syscall

2018-11-29 Thread Aleksa Sarai
On 2018-11-29, Arnd Bergmann wrote: > waitid() probably remains on my plate anyway, and I hope understand > where we're at with it. Having a way to wait on a processfd is something we'll eventually need, though the semantics of zombies might get a little bit hairy. I propose we work through that

Re: [PATCH 1/2] selftests: firmware: remove use of non-standard diff -Z option

2018-11-29 Thread Luis Chamberlain
On Mon, Nov 26, 2018 at 09:12:15PM -0600, Dan Rue wrote: > diff -Z is used to trim the trailing whitespace when comparing the > loaded firmware file with the source firmware file. However, per the > comment in the source code, -Z should not be necessary. In testing, the > input and output files

Re: [PATCH 1/2] selftests: firmware: remove use of non-standard diff -Z option

2018-11-29 Thread Luis Chamberlain
On Mon, Nov 26, 2018 at 09:12:15PM -0600, Dan Rue wrote: > diff -Z is used to trim the trailing whitespace when comparing the > loaded firmware file with the source firmware file. However, per the > comment in the source code, -Z should not be necessary. In testing, the > input and output files

Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure

2018-11-29 Thread Andy Gross
On Fri, Nov 30, 2018 at 01:12:01PM +1100, Stephen Rothwell wrote: > Hi Andy, > > On Thu, 29 Nov 2018 16:42:34 -0600 Andy Gross wrote: > > > > On Thu, Nov 29, 2018 at 04:36:00PM -0600, Andy Gross wrote: > > > On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wrote: > > > > We need to check

Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure

2018-11-29 Thread Andy Gross
On Fri, Nov 30, 2018 at 01:12:01PM +1100, Stephen Rothwell wrote: > Hi Andy, > > On Thu, 29 Nov 2018 16:42:34 -0600 Andy Gross wrote: > > > > On Thu, Nov 29, 2018 at 04:36:00PM -0600, Andy Gross wrote: > > > On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wrote: > > > > We need to check

Re: [PATCH v6 08/10] x86: avoid W^X being broken during modules loading

2018-11-29 Thread Masami Hiramatsu
On Wed, 28 Nov 2018 18:59:30 + Nadav Amit wrote: > > On Nov 20, 2018, at 12:35 PM, Nadav Amit wrote: > > > > When modules and BPF filters are loaded, there is a time window in > > which some memory is both writable and executable. An attacker that has > > already found another

Re: [PATCH v6 08/10] x86: avoid W^X being broken during modules loading

2018-11-29 Thread Masami Hiramatsu
On Wed, 28 Nov 2018 18:59:30 + Nadav Amit wrote: > > On Nov 20, 2018, at 12:35 PM, Nadav Amit wrote: > > > > When modules and BPF filters are loaded, there is a time window in > > which some memory is both writable and executable. An attacker that has > > already found another

Re: [PATCH 2/2] selftests: firmware: add CONFIG_FW_LOADER_USER_HELPER_FALLBACK to config

2018-11-29 Thread Luis Chamberlain
On Mon, Nov 26, 2018 at 09:12:16PM -0600, Dan Rue wrote: > CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y is required for fw_fallback.sh. > Without it, fw_fallback.sh fails with 'usermode helper disabled so > ignoring test'. Enable the config in selftest so that it gets built by > default. > >

Re: [PATCH 2/2] selftests: firmware: add CONFIG_FW_LOADER_USER_HELPER_FALLBACK to config

2018-11-29 Thread Luis Chamberlain
On Mon, Nov 26, 2018 at 09:12:16PM -0600, Dan Rue wrote: > CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y is required for fw_fallback.sh. > Without it, fw_fallback.sh fails with 'usermode helper disabled so > ignoring test'. Enable the config in selftest so that it gets built by > default. > >

Re: [PATCH v2] PCI: mediatek: Use devm_of_pci_get_host_bridge_resources() to parse DT

2018-11-29 Thread Honghui Zhang
On Thu, 2018-11-29 at 11:33 +, Lorenzo Pieralisi wrote: > On Thu, Nov 08, 2018 at 10:56:55AM +0800, honghui.zh...@mediatek.com wrote: > > From: Honghui Zhang > > > > Use the devm_of_pci_get_host_bridge_resources() API in place of the PCI OF > > DT parser. > > > > Signed-off-by: Honghui

Re: [PATCH v2] PCI: mediatek: Use devm_of_pci_get_host_bridge_resources() to parse DT

2018-11-29 Thread Honghui Zhang
On Thu, 2018-11-29 at 11:33 +, Lorenzo Pieralisi wrote: > On Thu, Nov 08, 2018 at 10:56:55AM +0800, honghui.zh...@mediatek.com wrote: > > From: Honghui Zhang > > > > Use the devm_of_pci_get_host_bridge_resources() API in place of the PCI OF > > DT parser. > > > > Signed-off-by: Honghui

Re: [PATCH v2 0/6] RFC: gup+dma: tracking dma-pinned pages

2018-11-29 Thread Tom Talpey
On 11/29/2018 9:21 PM, John Hubbard wrote: On 11/29/18 6:18 PM, Tom Talpey wrote: On 11/29/2018 8:39 PM, John Hubbard wrote: On 11/28/18 5:59 AM, Tom Talpey wrote: On 11/27/2018 9:52 PM, John Hubbard wrote: On 11/27/18 5:21 PM, Tom Talpey wrote: On 11/21/2018 5:06 PM, John Hubbard wrote:

Re: [PATCH v2 0/6] RFC: gup+dma: tracking dma-pinned pages

2018-11-29 Thread Tom Talpey
On 11/29/2018 9:21 PM, John Hubbard wrote: On 11/29/18 6:18 PM, Tom Talpey wrote: On 11/29/2018 8:39 PM, John Hubbard wrote: On 11/28/18 5:59 AM, Tom Talpey wrote: On 11/27/2018 9:52 PM, John Hubbard wrote: On 11/27/18 5:21 PM, Tom Talpey wrote: On 11/21/2018 5:06 PM, John Hubbard wrote:

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Chao Fan
On Thu, Nov 29, 2018 at 11:20:13AM -0500, Masayoshi Mizuma wrote: >On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: >> To fix the conflict between KASLR and memory-hotremove, memory >> information in SRAT table is necessary. >> >> ACPI SRAT (System/Static Resource Affinity Table) can

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Chao Fan
On Thu, Nov 29, 2018 at 11:20:13AM -0500, Masayoshi Mizuma wrote: >On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: >> To fix the conflict between KASLR and memory-hotremove, memory >> information in SRAT table is necessary. >> >> ACPI SRAT (System/Static Resource Affinity Table) can

Re: [PATCH] printk: don't unconditionally shortcut print_time()

2018-11-29 Thread Tetsuo Handa
Petr Mladek wrote: > See syslog_print_all() and kmsg_dump_get_buffer(). They > start with calling msg_print_text() many times to calculate > how many messages fit into the given buffer. Then they > blindly copy the messages into the buffer. > > Now, the buffer might overflow if the size is

Re: [PATCH] printk: don't unconditionally shortcut print_time()

2018-11-29 Thread Tetsuo Handa
Petr Mladek wrote: > See syslog_print_all() and kmsg_dump_get_buffer(). They > start with calling msg_print_text() many times to calculate > how many messages fit into the given buffer. Then they > blindly copy the messages into the buffer. > > Now, the buffer might overflow if the size is

Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure

2018-11-29 Thread Stephen Rothwell
Hi Andy, On Thu, 29 Nov 2018 16:42:34 -0600 Andy Gross wrote: > > On Thu, Nov 29, 2018 at 04:36:00PM -0600, Andy Gross wrote: > > On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wrote: > > > We need to check the call to cmd_db_read_aux_data() for the error case, > > > so that we don't

Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure

2018-11-29 Thread Stephen Rothwell
Hi Andy, On Thu, 29 Nov 2018 16:42:34 -0600 Andy Gross wrote: > > On Thu, Nov 29, 2018 at 04:36:00PM -0600, Andy Gross wrote: > > On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wrote: > > > We need to check the call to cmd_db_read_aux_data() for the error case, > > > so that we don't

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-29 Thread Masami Hiramatsu
On Thu, 29 Nov 2018 11:46:52 -0500 Steven Rostedt wrote: > On Thu, 29 Nov 2018 23:29:27 +0900 > Masami Hiramatsu wrote: > > > > One way to solve this is to also have a counter array that gets updated > > > every time the index array gets updated. And save the counter to the > > > shadow stack

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-29 Thread Masami Hiramatsu
On Thu, 29 Nov 2018 11:46:52 -0500 Steven Rostedt wrote: > On Thu, 29 Nov 2018 23:29:27 +0900 > Masami Hiramatsu wrote: > > > > One way to solve this is to also have a counter array that gets updated > > > every time the index array gets updated. And save the counter to the > > > shadow stack

Re: [PATCH v2 0/6] RFC: gup+dma: tracking dma-pinned pages

2018-11-29 Thread Tom Talpey
On 11/29/2018 8:39 PM, John Hubbard wrote: On 11/28/18 5:59 AM, Tom Talpey wrote: On 11/27/2018 9:52 PM, John Hubbard wrote: On 11/27/18 5:21 PM, Tom Talpey wrote: On 11/21/2018 5:06 PM, John Hubbard wrote: On 11/21/18 8:49 AM, Tom Talpey wrote: On 11/21/2018 1:09 AM, John Hubbard wrote:

Re: [PATCH v2 0/6] RFC: gup+dma: tracking dma-pinned pages

2018-11-29 Thread Tom Talpey
On 11/29/2018 8:39 PM, John Hubbard wrote: On 11/28/18 5:59 AM, Tom Talpey wrote: On 11/27/2018 9:52 PM, John Hubbard wrote: On 11/27/18 5:21 PM, Tom Talpey wrote: On 11/21/2018 5:06 PM, John Hubbard wrote: On 11/21/18 8:49 AM, Tom Talpey wrote: On 11/21/2018 1:09 AM, John Hubbard wrote:

Re: [PATCH v2 0/6] RFC: gup+dma: tracking dma-pinned pages

2018-11-29 Thread John Hubbard
On 11/29/18 6:18 PM, Tom Talpey wrote: > On 11/29/2018 8:39 PM, John Hubbard wrote: >> On 11/28/18 5:59 AM, Tom Talpey wrote: >>> On 11/27/2018 9:52 PM, John Hubbard wrote: On 11/27/18 5:21 PM, Tom Talpey wrote: > On 11/21/2018 5:06 PM, John Hubbard wrote: >> On 11/21/18 8:49 AM, Tom

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-29 Thread Wang, Dongsheng
On 2018/11/30 10:04, Wang, Dongsheng wrote: > On 2018/11/30 5:22, Kees Cook wrote: >> On Tue, Nov 27, 2018 at 8:38 PM Wang, Dongsheng >> wrote: >>> Hello Kees, >>> >>> On 2018/11/28 6:38, Kees Cook wrote: On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng wrote: > When select

Re: [PATCH v2 0/6] RFC: gup+dma: tracking dma-pinned pages

2018-11-29 Thread John Hubbard
On 11/29/18 6:18 PM, Tom Talpey wrote: > On 11/29/2018 8:39 PM, John Hubbard wrote: >> On 11/28/18 5:59 AM, Tom Talpey wrote: >>> On 11/27/2018 9:52 PM, John Hubbard wrote: On 11/27/18 5:21 PM, Tom Talpey wrote: > On 11/21/2018 5:06 PM, John Hubbard wrote: >> On 11/21/18 8:49 AM, Tom

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-29 Thread Wang, Dongsheng
On 2018/11/30 10:04, Wang, Dongsheng wrote: > On 2018/11/30 5:22, Kees Cook wrote: >> On Tue, Nov 27, 2018 at 8:38 PM Wang, Dongsheng >> wrote: >>> Hello Kees, >>> >>> On 2018/11/28 6:38, Kees Cook wrote: On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng wrote: > When select

Re: [PATCH 2/8] pstore: Do not use crash buffer for decompression

2018-11-29 Thread Joel Fernandes
On Thu, Nov 29, 2018 at 02:06:39PM -0800, Kees Cook wrote: > On Tue, Nov 13, 2018 at 11:56 PM Kees Cook wrote: > > On Fri, Nov 2, 2018 at 1:24 PM, Joel Fernandes > > wrote: > > > On Thu, Nov 01, 2018 at 04:51:54PM -0700, Kees Cook wrote: > > >> + workspace = kmalloc(unzipped_len +

Re: [PATCH 2/8] pstore: Do not use crash buffer for decompression

2018-11-29 Thread Joel Fernandes
On Thu, Nov 29, 2018 at 02:06:39PM -0800, Kees Cook wrote: > On Tue, Nov 13, 2018 at 11:56 PM Kees Cook wrote: > > On Fri, Nov 2, 2018 at 1:24 PM, Joel Fernandes > > wrote: > > > On Thu, Nov 01, 2018 at 04:51:54PM -0700, Kees Cook wrote: > > >> + workspace = kmalloc(unzipped_len +

Re: [PATCH v3] tty: serial: qcom_geni_serial: Fix softlock

2018-11-29 Thread Doug Anderson
Hi, On Thu, Nov 29, 2018 at 6:19 PM Ryan Case wrote: > > Transfers were being divided into device FIFO sized (64 byte max) > operations which would poll for completion within a spin_lock_irqsave / > spin_unlock_irqrestore block. This both made things slow by waiting for > the FIFO to completely

Re: [PATCH v3] tty: serial: qcom_geni_serial: Fix softlock

2018-11-29 Thread Doug Anderson
Hi, On Thu, Nov 29, 2018 at 6:19 PM Ryan Case wrote: > > Transfers were being divided into device FIFO sized (64 byte max) > operations which would poll for completion within a spin_lock_irqsave / > spin_unlock_irqrestore block. This both made things slow by waiting for > the FIFO to completely

[PATCH v3] tty: serial: qcom_geni_serial: Fix softlock

2018-11-29 Thread Ryan Case
Transfers were being divided into device FIFO sized (64 byte max) operations which would poll for completion within a spin_lock_irqsave / spin_unlock_irqrestore block. This both made things slow by waiting for the FIFO to completely drain before adding further data and would also result in

[PATCH v3] tty: serial: qcom_geni_serial: Fix softlock

2018-11-29 Thread Ryan Case
Transfers were being divided into device FIFO sized (64 byte max) operations which would poll for completion within a spin_lock_irqsave / spin_unlock_irqrestore block. This both made things slow by waiting for the FIFO to completely drain before adding further data and would also result in

Re: [PATCH] clk: imx: Use do_div in SCCG due to 64-bit divisor

2018-11-29 Thread Stephen Rothwell
Hi Abel, On Thu, 29 Nov 2018 23:50:22 + Abel Vesa wrote: > > --- a/drivers/clk/imx/clk-frac-pll.c > +++ b/drivers/clk/imx/clk-frac-pll.c > @@ -116,12 +116,13 @@ static long clk_pll_round_rate(struct clk_hw *hw, > unsigned long rate, > unsigned long *prate) > {

Re: [PATCH] clk: imx: Use do_div in SCCG due to 64-bit divisor

2018-11-29 Thread Stephen Rothwell
Hi Abel, On Thu, 29 Nov 2018 23:50:22 + Abel Vesa wrote: > > --- a/drivers/clk/imx/clk-frac-pll.c > +++ b/drivers/clk/imx/clk-frac-pll.c > @@ -116,12 +116,13 @@ static long clk_pll_round_rate(struct clk_hw *hw, > unsigned long rate, > unsigned long *prate) > {

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-29 Thread Wang, Dongsheng
On 2018/11/30 5:22, Kees Cook wrote: > On Tue, Nov 27, 2018 at 8:38 PM Wang, Dongsheng > wrote: >> Hello Kees, >> >> On 2018/11/28 6:38, Kees Cook wrote: >>> On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng >>> wrote: When select ARCH_TASK_STRUCT_ON_STACK the first of thread_info variable

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-29 Thread Wang, Dongsheng
On 2018/11/30 5:22, Kees Cook wrote: > On Tue, Nov 27, 2018 at 8:38 PM Wang, Dongsheng > wrote: >> Hello Kees, >> >> On 2018/11/28 6:38, Kees Cook wrote: >>> On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng >>> wrote: When select ARCH_TASK_STRUCT_ON_STACK the first of thread_info variable

Re: [PATCH v2 3/4] irqchip: sifive-plic: Differentiate between PLIC handler and context

2018-11-29 Thread Atish Patra
On 11/27/18 2:04 AM, Anup Patel wrote: We explicitly differentiate between PLIC handler and context because PLIC context is for given mode of HART whereas PLIC handler is per-CPU software construct meant for handling interrupts from a particular PLIC context. Signed-off-by: Anup Patel ---

Re: [PATCH v2 3/4] irqchip: sifive-plic: Differentiate between PLIC handler and context

2018-11-29 Thread Atish Patra
On 11/27/18 2:04 AM, Anup Patel wrote: We explicitly differentiate between PLIC handler and context because PLIC context is for given mode of HART whereas PLIC handler is per-CPU software construct meant for handling interrupts from a particular PLIC context. Signed-off-by: Anup Patel ---

Re: [PATCH] nvme-rdma: complete requests from ->timeout

2018-11-29 Thread Jaesoo Lee
Not the queue, but the RDMA connections. Let me describe the scenario. 1. connected nvme-rdma target with 500 namespaces : this will make the nvme_remove_namespaces() took a long time to complete and open the window vulnerable to this bug 2. host will take below code path for

Re: [PATCH] nvme-rdma: complete requests from ->timeout

2018-11-29 Thread Jaesoo Lee
Not the queue, but the RDMA connections. Let me describe the scenario. 1. connected nvme-rdma target with 500 namespaces : this will make the nvme_remove_namespaces() took a long time to complete and open the window vulnerable to this bug 2. host will take below code path for

Re: [PATCH v2] tty: serial: qcom_geni_serial: Fix softlock

2018-11-29 Thread Ryan Case
On Thu, Nov 29, 2018 at 2:12 PM Doug Anderson wrote: > > Hi, > > On Wed, Nov 28, 2018 at 3:55 PM Ryan Case wrote: > > @@ -465,9 +470,19 @@ static void qcom_geni_serial_console_write(struct > > console *co, const char *s, > > } > > writel_relaxed(M_CMD_CANCEL_EN,

Re: [PATCH v2] tty: serial: qcom_geni_serial: Fix softlock

2018-11-29 Thread Ryan Case
On Thu, Nov 29, 2018 at 2:12 PM Doug Anderson wrote: > > Hi, > > On Wed, Nov 28, 2018 at 3:55 PM Ryan Case wrote: > > @@ -465,9 +470,19 @@ static void qcom_geni_serial_console_write(struct > > console *co, const char *s, > > } > > writel_relaxed(M_CMD_CANCEL_EN,

Re: [PATCH anybus v4 6/7] dt-bindings: anybuss-host: document devicetree binding

2018-11-29 Thread Rob Herring
On Thu, Nov 29, 2018 at 2:59 PM Sven Van Asbroeck wrote: > > Rob, > > Eliminating the 'compatible' property for the anybus gives me an interesting > devicetree problem. > > The imx-weim code naively loops through all subnodes, applying timing settings > to the CS in the first reg entry. > In the

Re: [PATCH anybus v4 6/7] dt-bindings: anybuss-host: document devicetree binding

2018-11-29 Thread Rob Herring
On Thu, Nov 29, 2018 at 2:59 PM Sven Van Asbroeck wrote: > > Rob, > > Eliminating the 'compatible' property for the anybus gives me an interesting > devicetree problem. > > The imx-weim code naively loops through all subnodes, applying timing settings > to the CS in the first reg entry. > In the

Re: [PATCH v2 2/4] irqchip: sifive-plic: More flexible plic_irq_toggle()

2018-11-29 Thread Atish Patra
On 11/27/18 2:03 AM, Anup Patel wrote: We make plic_irq_toggle() more generic so that we can enable/disable hwirq for given cpumask. This generic plic_irq_toggle() will be eventually used to implement set_affinity for PLIC driver. Signed-off-by: Anup Patel ---

Re: [PATCH v2 2/4] irqchip: sifive-plic: More flexible plic_irq_toggle()

2018-11-29 Thread Atish Patra
On 11/27/18 2:03 AM, Anup Patel wrote: We make plic_irq_toggle() more generic so that we can enable/disable hwirq for given cpumask. This generic plic_irq_toggle() will be eventually used to implement set_affinity for PLIC driver. Signed-off-by: Anup Patel ---

Re: [PATCH v2 0/6] RFC: gup+dma: tracking dma-pinned pages

2018-11-29 Thread John Hubbard
On 11/28/18 5:59 AM, Tom Talpey wrote: > On 11/27/2018 9:52 PM, John Hubbard wrote: >> On 11/27/18 5:21 PM, Tom Talpey wrote: >>> On 11/21/2018 5:06 PM, John Hubbard wrote: On 11/21/18 8:49 AM, Tom Talpey wrote: > On 11/21/2018 1:09 AM, John Hubbard wrote: >> On 11/19/18 10:57 AM, Tom

Re: [PATCH v2 0/6] RFC: gup+dma: tracking dma-pinned pages

2018-11-29 Thread John Hubbard
On 11/28/18 5:59 AM, Tom Talpey wrote: > On 11/27/2018 9:52 PM, John Hubbard wrote: >> On 11/27/18 5:21 PM, Tom Talpey wrote: >>> On 11/21/2018 5:06 PM, John Hubbard wrote: On 11/21/18 8:49 AM, Tom Talpey wrote: > On 11/21/2018 1:09 AM, John Hubbard wrote: >> On 11/19/18 10:57 AM, Tom

Re: linux-next: manual merge of the selinux tree with the vfs tree

2018-11-29 Thread Al Viro
On Fri, Nov 30, 2018 at 01:27:07AM +, Al Viro wrote: > And then there's sb_mount, with 3 instances and arseloads of > races in 2 out of 3. PS: the 3rd one (in selinux) is, AFAICS, TOCTOU-free, because it ignores everything except the mountpoint, which is already looked up by the caller. No

Re: linux-next: manual merge of the selinux tree with the vfs tree

2018-11-29 Thread Al Viro
On Fri, Nov 30, 2018 at 01:27:07AM +, Al Viro wrote: > And then there's sb_mount, with 3 instances and arseloads of > races in 2 out of 3. PS: the 3rd one (in selinux) is, AFAICS, TOCTOU-free, because it ignores everything except the mountpoint, which is already looked up by the caller. No

Re: [PATCH] nvme-rdma: complete requests from ->timeout

2018-11-29 Thread Sagi Grimberg
This does not hold at least for NVMe RDMA host driver. An example scenario is when the RDMA connection is gone while the controller is being deleted. In this case, the nvmf_reg_write32() for sending shutdown admin command by the delete_work could be hung forever if the command is not completed

Re: [PATCH] nvme-rdma: complete requests from ->timeout

2018-11-29 Thread Sagi Grimberg
This does not hold at least for NVMe RDMA host driver. An example scenario is when the RDMA connection is gone while the controller is being deleted. In this case, the nvmf_reg_write32() for sending shutdown admin command by the delete_work could be hung forever if the command is not completed

Re: linux-next: manual merge of the selinux tree with the vfs tree

2018-11-29 Thread Al Viro
On Thu, Nov 29, 2018 at 04:57:20PM -0800, Casey Schaufler wrote: > > Question: what *should* happen if we try to cross into a submount and find > > that the thing on the other side is already mounted elsewhere, with > > incompatible > > LSM options? Ditto for referrals, with an extra twist -

Re: linux-next: manual merge of the selinux tree with the vfs tree

2018-11-29 Thread Al Viro
On Thu, Nov 29, 2018 at 04:57:20PM -0800, Casey Schaufler wrote: > > Question: what *should* happen if we try to cross into a submount and find > > that the thing on the other side is already mounted elsewhere, with > > incompatible > > LSM options? Ditto for referrals, with an extra twist -

Re: [PATCH 2/5 v7] regulator: fixed/gpio: Pull inversion/OD into gpiolib

2018-11-29 Thread Janusz Krzysztofik
Hi Linus, On Monday, November 19, 2018 8:11:23 AM CET Linus Walleij wrote: > This pushes the handling of inversion semantics and open drain > settings to the GPIO descriptor and gpiolib. All affected board > files are also augmented. > > This is especially nice since we don't have to have any >

Re: [PATCH 2/5 v7] regulator: fixed/gpio: Pull inversion/OD into gpiolib

2018-11-29 Thread Janusz Krzysztofik
Hi Linus, On Monday, November 19, 2018 8:11:23 AM CET Linus Walleij wrote: > This pushes the handling of inversion semantics and open drain > settings to the GPIO descriptor and gpiolib. All affected board > files are also augmented. > > This is especially nice since we don't have to have any >

Re: [PATCH v12 4/5] x86/boot: Parse SRAT table from RSDP and store immovable memory

2018-11-29 Thread Chao Fan
On Thu, Nov 29, 2018 at 12:55:21PM -0500, Masayoshi Mizuma wrote: >On Thu, Nov 29, 2018 at 04:16:30PM +0800, Chao Fan wrote: >> To fix the conflict between KASLR and memory-hotremove, SRAT table >> should be parsed by RSDP pointer, then find the immovable >> memory regions and store them in an

Re: [PATCH v12 4/5] x86/boot: Parse SRAT table from RSDP and store immovable memory

2018-11-29 Thread Chao Fan
On Thu, Nov 29, 2018 at 12:55:21PM -0500, Masayoshi Mizuma wrote: >On Thu, Nov 29, 2018 at 04:16:30PM +0800, Chao Fan wrote: >> To fix the conflict between KASLR and memory-hotremove, SRAT table >> should be parsed by RSDP pointer, then find the immovable >> memory regions and store them in an

[PATCH] coresight: cpu-debug: Support for CA73 CPUs

2018-11-29 Thread Leo Yan
This patch is to add the AMBA device ID for CA73 CPU, so that CPU debug module can be initialized successfully when a SoC contain CA73 CPUs. This patch has been verified on 96boards Hikey960. Signed-off-by: Leo Yan --- drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 1 file changed,

[PATCH] coresight: cpu-debug: Support for CA73 CPUs

2018-11-29 Thread Leo Yan
This patch is to add the AMBA device ID for CA73 CPU, so that CPU debug module can be initialized successfully when a SoC contain CA73 CPUs. This patch has been verified on 96boards Hikey960. Signed-off-by: Leo Yan --- drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 1 file changed,

RE: [PATCH V4 2/4] thermal: imx_sc: add i.MX system controller thermal support

2018-11-29 Thread Anson Huang
Hi, Eduardo Best Regards! Anson Huang > -Original Message- > From: Eduardo Valentin [mailto:edubez...@gmail.com] > Sent: 2018年11月30日 0:49 > To: Anson Huang > Cc: rui.zh...@intel.com; daniel.lezc...@linaro.org; robh...@kernel.org; > mark.rutl...@arm.com; catalin.mari...@arm.com;

RE: [PATCH V4 2/4] thermal: imx_sc: add i.MX system controller thermal support

2018-11-29 Thread Anson Huang
Hi, Eduardo Best Regards! Anson Huang > -Original Message- > From: Eduardo Valentin [mailto:edubez...@gmail.com] > Sent: 2018年11月30日 0:49 > To: Anson Huang > Cc: rui.zh...@intel.com; daniel.lezc...@linaro.org; robh...@kernel.org; > mark.rutl...@arm.com; catalin.mari...@arm.com;

Re: [PATCH v12 0/5] x86/boot/KASLR: Parse ACPI table and limit KASLR to choosing immovable memory

2018-11-29 Thread Chao Fan
On Thu, Nov 29, 2018 at 12:32:46PM -0500, Masayoshi Mizuma wrote: >Hi Chao, > >Thank you for your continued working. Thanks for your test. > >Could you please build your patches before sending? Sorry for the mistake, I build it with the whole patches. I found there are some problems with the

Re: [PATCH v12 0/5] x86/boot/KASLR: Parse ACPI table and limit KASLR to choosing immovable memory

2018-11-29 Thread Chao Fan
On Thu, Nov 29, 2018 at 12:32:46PM -0500, Masayoshi Mizuma wrote: >Hi Chao, > >Thank you for your continued working. Thanks for your test. > >Could you please build your patches before sending? Sorry for the mistake, I build it with the whole patches. I found there are some problems with the

Re: [PATCH v2 1/3] mmc: sdhci: add support for using external DMA devices

2018-11-29 Thread Shawn Lin
On 2018/11/29 17:59, Chunyan Zhang wrote: Hi Adrian, On Thu, 29 Nov 2018 at 15:36, Adrian Hunter wrote: On 29/11/18 8:22 AM, Chunyan Zhang wrote: On Tue, 20 Nov 2018 at 21:41, Adrian Hunter wrote: On 12/11/18 9:26 AM, Chunyan Zhang wrote: Some standard SD host controllers can support

Re: [PATCH v2 1/3] mmc: sdhci: add support for using external DMA devices

2018-11-29 Thread Shawn Lin
On 2018/11/29 17:59, Chunyan Zhang wrote: Hi Adrian, On Thu, 29 Nov 2018 at 15:36, Adrian Hunter wrote: On 29/11/18 8:22 AM, Chunyan Zhang wrote: On Tue, 20 Nov 2018 at 21:41, Adrian Hunter wrote: On 12/11/18 9:26 AM, Chunyan Zhang wrote: Some standard SD host controllers can support

RE: [PATCH V4 4/4] ARM64: dts: imx: add i.MX8QXP thermal support

2018-11-29 Thread Anson Huang
Hi, Eduardo Best Regards! Anson Huang > -Original Message- > From: Eduardo Valentin [mailto:edubez...@gmail.com] > Sent: 2018年11月30日 0:51 > To: Anson Huang > Cc: rui.zh...@intel.com; daniel.lezc...@linaro.org; robh...@kernel.org; > mark.rutl...@arm.com; catalin.mari...@arm.com;

RE: [PATCH V4 4/4] ARM64: dts: imx: add i.MX8QXP thermal support

2018-11-29 Thread Anson Huang
Hi, Eduardo Best Regards! Anson Huang > -Original Message- > From: Eduardo Valentin [mailto:edubez...@gmail.com] > Sent: 2018年11月30日 0:51 > To: Anson Huang > Cc: rui.zh...@intel.com; daniel.lezc...@linaro.org; robh...@kernel.org; > mark.rutl...@arm.com; catalin.mari...@arm.com;

Re: [PATCH] fs: Make /proc/sys inodes be owned by global root.

2018-11-29 Thread Luis Chamberlain
On Mon, Nov 26, 2018 at 11:29:40PM -0600, Eric W. Biederman wrote: > Luis Chamberlain writes: > > Thanks for the description of how to run into the issue described but > > is there also a practical use case today where this is happening? I ask > > as it would be good to know the severity of the

Re: [PATCH - resend*2] VFS: use synchronize_rcu_expedited() in namespace_unlock()

2018-11-29 Thread NeilBrown
On Thu, Nov 29 2018, Al Viro wrote: > On Fri, Nov 30, 2018 at 10:33:18AM +1100, NeilBrown wrote: >> >> The synchronize_rcu() in namespace_unlock() is called every time >> a filesystem is unmounted. If a great many filesystems are mounted, >> this can cause a noticable slow-down in, for example,

Re: [PATCH - resend*2] VFS: use synchronize_rcu_expedited() in namespace_unlock()

2018-11-29 Thread NeilBrown
On Thu, Nov 29 2018, Al Viro wrote: > On Fri, Nov 30, 2018 at 10:33:18AM +1100, NeilBrown wrote: >> >> The synchronize_rcu() in namespace_unlock() is called every time >> a filesystem is unmounted. If a great many filesystems are mounted, >> this can cause a noticable slow-down in, for example,

Re: [PATCH] fs: Make /proc/sys inodes be owned by global root.

2018-11-29 Thread Luis Chamberlain
On Mon, Nov 26, 2018 at 11:29:40PM -0600, Eric W. Biederman wrote: > Luis Chamberlain writes: > > Thanks for the description of how to run into the issue described but > > is there also a practical use case today where this is happening? I ask > > as it would be good to know the severity of the

Re: [PATCH 1/4] of/device: Add a way to probe drivers by match data

2018-11-29 Thread Rob Herring
On Thu, Nov 29, 2018 at 6:28 PM Stephen Boyd wrote: > > Quoting Stephen Boyd (2018-11-07 10:37:31) > > appropriate structure with to_platform_device() or to_i2c_client()? > > > > So the example would become > > > > struct of_driver_probe_func { > > int (*probe)(struct device *dev); > >

Re: [PATCH 1/4] of/device: Add a way to probe drivers by match data

2018-11-29 Thread Rob Herring
On Thu, Nov 29, 2018 at 6:28 PM Stephen Boyd wrote: > > Quoting Stephen Boyd (2018-11-07 10:37:31) > > appropriate structure with to_platform_device() or to_i2c_client()? > > > > So the example would become > > > > struct of_driver_probe_func { > > int (*probe)(struct device *dev); > >

Re: linux-next: manual merge of the selinux tree with the vfs tree

2018-11-29 Thread Casey Schaufler
On 11/29/2018 3:51 PM, Al Viro wrote: I've added linux-security-module to the CC list. > On Thu, Nov 29, 2018 at 05:23:24PM -0500, Paul Moore wrote: > >>> OK, I will verify that the SELinux submount fix rebased on top of >>> vfs/work.mount in the way I suggested above passes the same testing >>>

Re: linux-next: manual merge of the selinux tree with the vfs tree

2018-11-29 Thread Casey Schaufler
On 11/29/2018 3:51 PM, Al Viro wrote: I've added linux-security-module to the CC list. > On Thu, Nov 29, 2018 at 05:23:24PM -0500, Paul Moore wrote: > >>> OK, I will verify that the SELinux submount fix rebased on top of >>> vfs/work.mount in the way I suggested above passes the same testing >>>

Re: [PATCH] ARM: multi_v7_defconfig: switch CONFIG_PWM_MESON to built-in

2018-11-29 Thread Kevin Hilman
Martin Blumenstingl writes: > Hi Kevin, > > On Fri, Nov 30, 2018 at 12:28 AM Kevin Hilman wrote: >> >> Martin Blumenstingl writes: >> >> > Hi Kevin, >> > >> > On Thu, Nov 29, 2018 at 1:30 AM Kevin Hilman wrote: >> >> >> >> Martin Blumenstingl writes: >> >> >> >> > Some Meson8b boards

Re: [PATCH] ARM: multi_v7_defconfig: switch CONFIG_PWM_MESON to built-in

2018-11-29 Thread Kevin Hilman
Martin Blumenstingl writes: > Hi Kevin, > > On Fri, Nov 30, 2018 at 12:28 AM Kevin Hilman wrote: >> >> Martin Blumenstingl writes: >> >> > Hi Kevin, >> > >> > On Thu, Nov 29, 2018 at 1:30 AM Kevin Hilman wrote: >> >> >> >> Martin Blumenstingl writes: >> >> >> >> > Some Meson8b boards

<    1   2   3   4   5   6   7   8   9   10   >