Re: [RFC] regmap-irq: add "main register" and level-irq support

2018-12-05 Thread Mark Brown
On Wed, Dec 05, 2018 at 10:22:51AM +0200, Matti Vaittinen wrote: > On Tue, Dec 04, 2018 at 05:21:37PM +, Mark Brown wrote: > > On Fri, Nov 30, 2018 at 10:59:08AM +0200, Matti Vaittinen wrote: > > This sounds exactly like the wm831x which uses cascaded irqchips for > > this, though not

Re: [PATCH v6 00/14] block: always associate blkg and refcount cleanup

2018-12-05 Thread Jens Axboe
On 12/5/18 10:10 AM, Dennis Zhou wrote: > Hi everyone, > > This is a minor update addressing the feedback from Mike and Josef. > > v6: > 0005: Address Mike's feedback for the flush bio comment. > 0006: Add a WARN_ONCE() for blkg fallback suggested by Josef. Thanks Dennis, applied for 4.21. --

Re: [RFC] regmap-irq: add "main register" and level-irq support

2018-12-05 Thread Mark Brown
On Wed, Dec 05, 2018 at 10:22:51AM +0200, Matti Vaittinen wrote: > On Tue, Dec 04, 2018 at 05:21:37PM +, Mark Brown wrote: > > On Fri, Nov 30, 2018 at 10:59:08AM +0200, Matti Vaittinen wrote: > > This sounds exactly like the wm831x which uses cascaded irqchips for > > this, though not

Re: [PATCH v6 00/14] block: always associate blkg and refcount cleanup

2018-12-05 Thread Jens Axboe
On 12/5/18 10:10 AM, Dennis Zhou wrote: > Hi everyone, > > This is a minor update addressing the feedback from Mike and Josef. > > v6: > 0005: Address Mike's feedback for the flush bio comment. > 0006: Add a WARN_ONCE() for blkg fallback suggested by Josef. Thanks Dennis, applied for 4.21. --

[driver-core PATCH v8 0/9] Add NUMA aware async_schedule calls

2018-12-05 Thread Alexander Duyck
This patch set provides functionality that will help to improve the locality of the async_schedule calls used to provide deferred initialization. This patch set originally started out focused on just the one call to async_schedule_domain in the nvdimm tree that was being used to defer the

Re: [PATCH v6 07/10] clk: rk808: use managed version of of_provider registration

2018-12-05 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-04 03:38:03) > Simplify clean-up for rk808 by using managed version of of_provider > registration. > > Signed-off-by: Matti Vaittinen > --- Applied to clk-next

[driver-core PATCH v8 0/9] Add NUMA aware async_schedule calls

2018-12-05 Thread Alexander Duyck
This patch set provides functionality that will help to improve the locality of the async_schedule calls used to provide deferred initialization. This patch set originally started out focused on just the one call to async_schedule_domain in the nvdimm tree that was being used to defer the

Re: [PATCH v6 07/10] clk: rk808: use managed version of of_provider registration

2018-12-05 Thread Stephen Boyd
Quoting Matti Vaittinen (2018-12-04 03:38:03) > Simplify clean-up for rk808 by using managed version of of_provider > registration. > > Signed-off-by: Matti Vaittinen > --- Applied to clk-next

[driver-core PATCH v8 1/9] driver core: Move async_synchronize_full call

2018-12-05 Thread Alexander Duyck
Move the async_synchronize_full call out of __device_release_driver and into driver_detach. The idea behind this is that the async_synchronize_full call will only guarantee that any existing async operations are flushed. This doesn't do anything to guarantee that a hotplug event that may occur

[driver-core PATCH v8 8/9] PM core: Use new async_schedule_dev command

2018-12-05 Thread Alexander Duyck
Use the device specific version of the async_schedule commands to defer various tasks related to power management. By doing this we should see a slight improvement in performance as any device that is sensitive to latency/locality in the setup will now be initializing on the node closest to the

[driver-core PATCH v8 1/9] driver core: Move async_synchronize_full call

2018-12-05 Thread Alexander Duyck
Move the async_synchronize_full call out of __device_release_driver and into driver_detach. The idea behind this is that the async_synchronize_full call will only guarantee that any existing async operations are flushed. This doesn't do anything to guarantee that a hotplug event that may occur

[driver-core PATCH v8 8/9] PM core: Use new async_schedule_dev command

2018-12-05 Thread Alexander Duyck
Use the device specific version of the async_schedule commands to defer various tasks related to power management. By doing this we should see a slight improvement in performance as any device that is sensitive to latency/locality in the setup will now be initializing on the node closest to the

Re: [PATCH v3 5/5] clk: samsung: exynos5433: add imem clocks

2018-12-05 Thread Sylwester Nawrocki
On 12/5/18 17:08, Stephen Boyd wrote: > Quoting Sylwester Nawrocki (2018-12-05 02:57:32) >> On 12/4/18 19:40, Stephen Boyd wrote: >>> Quoting Kamil Konieczny (2018-12-04 08:52:48) + +static const unsigned long imem_clk_regs[] __initconst = { [...] +}; + +static const

Re: [PATCH v3 5/5] clk: samsung: exynos5433: add imem clocks

2018-12-05 Thread Sylwester Nawrocki
On 12/5/18 17:08, Stephen Boyd wrote: > Quoting Sylwester Nawrocki (2018-12-05 02:57:32) >> On 12/4/18 19:40, Stephen Boyd wrote: >>> Quoting Kamil Konieczny (2018-12-04 08:52:48) + +static const unsigned long imem_clk_regs[] __initconst = { [...] +}; + +static const

Re: [PATCH -next] coresight: stm: remove set but not used variable 'res_size'

2018-12-05 Thread Mathieu Poirier
On Sat, 1 Dec 2018 at 01:31, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/hwtracing/coresight/coresight-stm.c: In function 'stm_probe': > drivers/hwtracing/coresight/coresight-stm.c:796:9: warning: > variable 'res_size' set but not used

Re: [RFC PATCH v4 1/5] glibc: Perform rseq(2) registration at nptl init and thread creation

2018-12-05 Thread Mathieu Desnoyers
- On Nov 26, 2018, at 12:07 PM, Rich Felker dal...@libc.org wrote: > On Mon, Nov 26, 2018 at 11:30:51AM -0500, Mathieu Desnoyers wrote: >> - On Nov 26, 2018, at 10:51 AM, Mathieu Desnoyers >> mathieu.desnoy...@efficios.com wrote: >> >> > - On Nov 26, 2018, at 3:28 AM, Florian

Re: [RFC PATCH v4 1/5] glibc: Perform rseq(2) registration at nptl init and thread creation

2018-12-05 Thread Mathieu Desnoyers
- On Nov 26, 2018, at 12:07 PM, Rich Felker dal...@libc.org wrote: > On Mon, Nov 26, 2018 at 11:30:51AM -0500, Mathieu Desnoyers wrote: >> - On Nov 26, 2018, at 10:51 AM, Mathieu Desnoyers >> mathieu.desnoy...@efficios.com wrote: >> >> > - On Nov 26, 2018, at 3:28 AM, Florian

Re: [PATCH -next] coresight: stm: remove set but not used variable 'res_size'

2018-12-05 Thread Mathieu Poirier
On Sat, 1 Dec 2018 at 01:31, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/hwtracing/coresight/coresight-stm.c: In function 'stm_probe': > drivers/hwtracing/coresight/coresight-stm.c:796:9: warning: > variable 'res_size' set but not used

Re: [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API header file

2018-12-05 Thread Jiri Olsa
On Wed, Dec 05, 2018 at 12:03:34PM -0500, Steven Rostedt wrote: > On Wed, 5 Dec 2018 13:25:17 +0100 > Jiri Olsa wrote: > > > On Tue, Dec 04, 2018 at 02:41:45PM -0500, Steven Rostedt wrote: > > > On Tue, 4 Dec 2018 16:47:39 +0900 > > > Namhyung Kim wrote: > > > > > > > > > > > @@ -302,6

Re: [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API header file

2018-12-05 Thread Jiri Olsa
On Wed, Dec 05, 2018 at 12:03:34PM -0500, Steven Rostedt wrote: > On Wed, 5 Dec 2018 13:25:17 +0100 > Jiri Olsa wrote: > > > On Tue, Dec 04, 2018 at 02:41:45PM -0500, Steven Rostedt wrote: > > > On Tue, 4 Dec 2018 16:47:39 +0900 > > > Namhyung Kim wrote: > > > > > > > > > > > @@ -302,6

Re: [PATCH] Revert "clk: fix __clk_init_parent() for single parent clocks"

2018-12-05 Thread Jerome Brunet
On Tue, 2018-12-04 at 23:54 -0800, Stephen Boyd wrote: > Quoting Jerome Brunet (2018-12-04 11:51:17) > > On Tue, 2018-12-04 at 10:05 -0800, Stephen Boyd wrote: > > > Quoting Jerome Brunet (2018-12-04 08:32:57) > > > > This reverts commit 2430a94d1e719b7b4af2a65b781a4c036eb22e64. > > > > > > > >

Re: [PATCH] Revert "clk: fix __clk_init_parent() for single parent clocks"

2018-12-05 Thread Jerome Brunet
On Tue, 2018-12-04 at 23:54 -0800, Stephen Boyd wrote: > Quoting Jerome Brunet (2018-12-04 11:51:17) > > On Tue, 2018-12-04 at 10:05 -0800, Stephen Boyd wrote: > > > Quoting Jerome Brunet (2018-12-04 08:32:57) > > > > This reverts commit 2430a94d1e719b7b4af2a65b781a4c036eb22e64. > > > > > > > >

[PATCH v1] perf record: fix memory leak on AIO objects deallocation

2018-12-05 Thread Alexey Budankov
Sending a part which was missed between v12 and v13 of the patch set introducing AIO trace streaming for perf record mode. The part is essential to avoid memory leakage during deallocation of AIO related trace data buffers. It is applied on top of acme perf/core repo. Signed-off-by: Alexey

[PATCH v1] perf record: fix memory leak on AIO objects deallocation

2018-12-05 Thread Alexey Budankov
Sending a part which was missed between v12 and v13 of the patch set introducing AIO trace streaming for perf record mode. The part is essential to avoid memory leakage during deallocation of AIO related trace data buffers. It is applied on top of acme perf/core repo. Signed-off-by: Alexey

Re: [PATCH 4/5] ARC: perf: fix description comment

2018-12-05 Thread Vineet Gupta
On 12/5/18 9:06 AM, Eugeniy Paltsev wrote: > Fix description comment as this code doesn't belong only to > ARC700 anymore. > > Also while I'm at it, use SPDX License Identifier. > > Signed-off-by: Eugeniy Paltsev Maybe squash this into trivial cleanups 1/5 ? Acked-by: Vineet Gupta Thx,

Re: [PATCH 4/5] ARC: perf: fix description comment

2018-12-05 Thread Vineet Gupta
On 12/5/18 9:06 AM, Eugeniy Paltsev wrote: > Fix description comment as this code doesn't belong only to > ARC700 anymore. > > Also while I'm at it, use SPDX License Identifier. > > Signed-off-by: Eugeniy Paltsev Maybe squash this into trivial cleanups 1/5 ? Acked-by: Vineet Gupta Thx,

Re: [PATCH v2 1/7] arm64: capabilities: Merge entries for ARM64_WORKAROUND_CLEAN_CACHE

2018-12-05 Thread Suzuki K Poulose
On 05/12/2018 15:02, Will Deacon wrote: On Fri, Nov 30, 2018 at 05:18:00PM +, Suzuki K Poulose wrote: We have two entries for ARM64_WORKAROUND_CLEAN_CACHE capability : 1) ARM Errata 826319, 827319, 824069, 819472 on A53 r0p[012] 2) ARM Errata 819472 on A53 r0p[01] Both have the same

Re: [PATCH v2 1/7] arm64: capabilities: Merge entries for ARM64_WORKAROUND_CLEAN_CACHE

2018-12-05 Thread Suzuki K Poulose
On 05/12/2018 15:02, Will Deacon wrote: On Fri, Nov 30, 2018 at 05:18:00PM +, Suzuki K Poulose wrote: We have two entries for ARM64_WORKAROUND_CLEAN_CACHE capability : 1) ARM Errata 826319, 827319, 824069, 819472 on A53 r0p[012] 2) ARM Errata 819472 on A53 r0p[01] Both have the same

Re: [PATCH] x86/kernel: Fix more -Wmissing-prototypes warnings

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 05:25:26PM +0100, Ingo Molnar wrote: > Also, preferably the prototype should be eliminated via proper ordering > of functions from lower level to higher levels. Well, that trampoline_handler() is special as we call it from inline asm and I see Masami has marked it

Re: [PATCH] x86/kernel: Fix more -Wmissing-prototypes warnings

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 05:25:26PM +0100, Ingo Molnar wrote: > Also, preferably the prototype should be eliminated via proper ordering > of functions from lower level to higher levels. Well, that trampoline_handler() is special as we call it from inline asm and I see Masami has marked it

Re: edac driver injection of uncorrected errors & utils

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 10:37:52AM -0600, Tracy Smith wrote: > This was very helpful. I'm glad. Can you do me a favor pls and not top-post when replying on a mailing list? Thx. > Tracing through the code, it doesn't do a panic > before Linux crashes from multi-bit errors because as York has >

Re: edac driver injection of uncorrected errors & utils

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 10:37:52AM -0600, Tracy Smith wrote: > This was very helpful. I'm glad. Can you do me a favor pls and not top-post when replying on a mailing list? Thx. > Tracing through the code, it doesn't do a panic > before Linux crashes from multi-bit errors because as York has >

Re: perf: perf_fuzzer triggers GPF in perf_prepare_sample

2018-12-05 Thread Vince Weaver
On Wed, 5 Dec 2018, Jiri Olsa wrote: > On Wed, Dec 05, 2018 at 01:45:38PM +0100, Jiri Olsa wrote: > > On Tue, Dec 04, 2018 at 10:54:55AM -0500, Vince Weaver wrote: > > > Hello, > > > > > > I was able to trigger another oops with the perf_fuzzer with current git. > > > > > > This is 4.20-rc5

Re: perf: perf_fuzzer triggers GPF in perf_prepare_sample

2018-12-05 Thread Vince Weaver
On Wed, 5 Dec 2018, Jiri Olsa wrote: > On Wed, Dec 05, 2018 at 01:45:38PM +0100, Jiri Olsa wrote: > > On Tue, Dec 04, 2018 at 10:54:55AM -0500, Vince Weaver wrote: > > > Hello, > > > > > > I was able to trigger another oops with the perf_fuzzer with current git. > > > > > > This is 4.20-rc5

[PATCH 12/14] blkcg: remove bio_disassociate_task()

2018-12-05 Thread Dennis Zhou
Now that a bio only holds a blkg reference, so clean up is simply putting back that reference. Remove bio_disassociate_task() as it just calls bio_disassociate_blkg() and call the latter directly. Signed-off-by: Dennis Zhou Acked-by: Tejun Heo Reviewed-by: Josef Bacik --- block/bio.c

[PATCH 12/14] blkcg: remove bio_disassociate_task()

2018-12-05 Thread Dennis Zhou
Now that a bio only holds a blkg reference, so clean up is simply putting back that reference. Remove bio_disassociate_task() as it just calls bio_disassociate_blkg() and call the latter directly. Signed-off-by: Dennis Zhou Acked-by: Tejun Heo Reviewed-by: Josef Bacik --- block/bio.c

Re: [PATCH] perf, tools: Support srccode output

2018-12-05 Thread Jiri Olsa
On Wed, Dec 05, 2018 at 01:54:30PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 05, 2018 at 01:28:38PM +0100, Jiri Olsa escreveu: > > On Mon, Dec 03, 2018 at 04:18:48PM -0800, Andi Kleen wrote: > > > From: Andi Kleen > > > > > > When looking at PT or brstackinsn traces with perf script >

Re: [PATCH] perf, tools: Support srccode output

2018-12-05 Thread Jiri Olsa
On Wed, Dec 05, 2018 at 01:54:30PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 05, 2018 at 01:28:38PM +0100, Jiri Olsa escreveu: > > On Mon, Dec 03, 2018 at 04:18:48PM -0800, Andi Kleen wrote: > > > From: Andi Kleen > > > > > > When looking at PT or brstackinsn traces with perf script >

[PATCH 01/12] staging: rtl8188eu: refactor cckrates_included()

2018-12-05 Thread Michael Straube
Refactor cckrates_included() to improve readability and slightly reduce object file size. Also change the return type to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 9 + drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +- 2 files

[PATCH 06/12] staging: rtl8188eu: cleanup block comment in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Cleanup a block comment to clear a checkpatch warning. WARNING: Block comments use * on subsequent lines Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 01/12] staging: rtl8188eu: refactor cckrates_included()

2018-12-05 Thread Michael Straube
Refactor cckrates_included() to improve readability and slightly reduce object file size. Also change the return type to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 9 + drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +- 2 files

[PATCH 06/12] staging: rtl8188eu: cleanup block comment in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Cleanup a block comment to clear a checkpatch warning. WARNING: Block comments use * on subsequent lines Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] clk: rockchip: add clock gate of ACODEC for rk3328

2018-12-05 Thread Heiko Stuebner
Am 5. Dezember 2018 15:18:40 MEZ schrieb kbuild test robot : >Hi Katsuhiro, > >Thank you for the patch! Yet something to improve: > >[auto build test ERROR on rockchip/for-next] >[also build test ERROR on v4.20-rc5] >[cannot apply to next-20181204] >[if your patch is applied to the wrong git

Re: [PATCH] clk: rockchip: add clock gate of ACODEC for rk3328

2018-12-05 Thread Heiko Stuebner
Am 5. Dezember 2018 15:18:40 MEZ schrieb kbuild test robot : >Hi Katsuhiro, > >Thank you for the patch! Yet something to improve: > >[auto build test ERROR on rockchip/for-next] >[also build test ERROR on v4.20-rc5] >[cannot apply to next-20181204] >[if your patch is applied to the wrong git

[PATCH 05/12] staging: rtl8188eu: cleanup declarations in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Replace tabs with spaces and/or remove spaces in declarations to cleanup whitespace. Remove unused/commented declarations. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 175 +- 1 file changed, 86 insertions(+), 89 deletions(-) diff --git

[PATCH 05/12] staging: rtl8188eu: cleanup declarations in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Replace tabs with spaces and/or remove spaces in declarations to cleanup whitespace. Remove unused/commented declarations. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 175 +- 1 file changed, 86 insertions(+), 89 deletions(-) diff --git

[PATCH 07/12] staging: rtl8188eu: cleanup long lines in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Cleanup some lines over 80 characters by adding appropriate line breaks and removing commented code. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 07/12] staging: rtl8188eu: cleanup long lines in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Cleanup some lines over 80 characters by adding appropriate line breaks and removing commented code. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 11/12] staging: rtl8188eu: rename struct field Wifi_Error_Status

2018-12-05 Thread Michael Straube
Rename struct field Wifi_Error_Status to avoid CamelCase. Wifi_Error_Status -> wifi_error_status Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_sreset.c | 4 ++-- drivers/staging/rtl8188eu/include/rtw_sreset.h | 2 +-

[PATCH 11/12] staging: rtl8188eu: rename struct field Wifi_Error_Status

2018-12-05 Thread Michael Straube
Rename struct field Wifi_Error_Status to avoid CamelCase. Wifi_Error_Status -> wifi_error_status Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_sreset.c | 4 ++-- drivers/staging/rtl8188eu/include/rtw_sreset.h | 2 +-

[PATCH 04/12] staging: rtl8188eu: remove unnecessary parentheses in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Remove unnecessary parentheses reported by checkpatch. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 64 +-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c

[PATCH 04/12] staging: rtl8188eu: remove unnecessary parentheses in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Remove unnecessary parentheses reported by checkpatch. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 64 +-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c

[PATCH 08/12] staging: rtl8188eu: add spaces around operators in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Add spaces around '+', '-', '&' and '>>' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 21 +++ 1 file changed, 12 insertions(+), 9 deletions(-) diff --git

[PATCH 12/12] staging: rtl8188eu: remove unused code in rtw_cmd.c

2018-12-05 Thread Michael Straube
Remove unused/commented code in rtw_cmd.c. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c index

Re: [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API header file

2018-12-05 Thread Steven Rostedt
On Wed, 5 Dec 2018 13:25:17 +0100 Jiri Olsa wrote: > On Tue, Dec 04, 2018 at 02:41:45PM -0500, Steven Rostedt wrote: > > On Tue, 4 Dec 2018 16:47:39 +0900 > > Namhyung Kim wrote: > > > > > > > > @@ -302,6 +302,7 @@ install_headers: > > > > $(call QUIET_INSTALL, headers) \ > > > >

[PATCH 03/12] staging: rtl8188eu: simplify array initializations

2018-12-05 Thread Michael Straube
Simplfy initialization of arrays with zero only values to improve readability and save a line. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 08/12] staging: rtl8188eu: add spaces around operators in rtw_wlan_util.c

2018-12-05 Thread Michael Straube
Add spaces around '+', '-', '&' and '>>' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 21 +++ 1 file changed, 12 insertions(+), 9 deletions(-) diff --git

[PATCH 12/12] staging: rtl8188eu: remove unused code in rtw_cmd.c

2018-12-05 Thread Michael Straube
Remove unused/commented code in rtw_cmd.c. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c index

Re: [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API header file

2018-12-05 Thread Steven Rostedt
On Wed, 5 Dec 2018 13:25:17 +0100 Jiri Olsa wrote: > On Tue, Dec 04, 2018 at 02:41:45PM -0500, Steven Rostedt wrote: > > On Tue, 4 Dec 2018 16:47:39 +0900 > > Namhyung Kim wrote: > > > > > > > > @@ -302,6 +302,7 @@ install_headers: > > > > $(call QUIET_INSTALL, headers) \ > > > >

[PATCH 03/12] staging: rtl8188eu: simplify array initializations

2018-12-05 Thread Michael Straube
Simplfy initialization of arrays with zero only values to improve readability and save a line. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 10/12] staging: rtl8188eu: correct indentation in update_wireless_mode()

2018-12-05 Thread Michael Straube
Correct indentation in update_wireless_mode() to clear a checkpatch warning. WARNING: Statements should start on a tabstop Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 10/12] staging: rtl8188eu: correct indentation in update_wireless_mode()

2018-12-05 Thread Michael Straube
Correct indentation in update_wireless_mode() to clear a checkpatch warning. WARNING: Statements should start on a tabstop Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 09/12] staging: rtl8188eu: write out multiplying in wifirate2_ratetbl_inx()

2018-12-05 Thread Michael Straube
Write out multiplying in wifirate2_ratetbl_inx() to improve readabilitiy and clear checkpatch issues with missing spaces around '*' operator. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 22 +-- 1 file changed, 11 insertions(+), 11

[PATCH 09/12] staging: rtl8188eu: write out multiplying in wifirate2_ratetbl_inx()

2018-12-05 Thread Michael Straube
Write out multiplying in wifirate2_ratetbl_inx() to improve readabilitiy and clear checkpatch issues with missing spaces around '*' operator. Signed-off-by: Michael Straube --- .../staging/rtl8188eu/core/rtw_wlan_util.c| 22 +-- 1 file changed, 11 insertions(+), 11

[PATCH 02/12] staging: rtl8188eu: refactor cckratesonly_included()

2018-12-05 Thread Michael Straube
Refactor cckratesonly_included() to improve readability and slightly reduce object file size. Also change the return type to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 10 +- drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +- 2

[PATCH 02/12] staging: rtl8188eu: refactor cckratesonly_included()

2018-12-05 Thread Michael Straube
Refactor cckratesonly_included() to improve readability and slightly reduce object file size. Also change the return type to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 10 +- drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 +- 2

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 05:30:37PM +0100, Ingo Molnar wrote: > Would it make sense to organize it a bit more and separate out vendor > specific functionality: > > mce/cpu/intel.c > mce/cpu/intel-p5.c > mce/cpu/amd.c > mce/cpu/winchip.c That's too fine-grained IMO and look at the path

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Borislav Petkov
On Wed, Dec 05, 2018 at 05:30:37PM +0100, Ingo Molnar wrote: > Would it make sense to organize it a bit more and separate out vendor > specific functionality: > > mce/cpu/intel.c > mce/cpu/intel-p5.c > mce/cpu/amd.c > mce/cpu/winchip.c That's too fine-grained IMO and look at the path

Re: [PATCH v11 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-05 Thread Stephen Boyd
Quoting Viresh Kumar (2018-12-04 22:16:00) > On 05-12-18, 09:07, Taniya Das wrote: > > Hello Stephen, Viresh > > > > Thanks for the code and suggestions. > > > > Having a NR_DOMAINS '2' makes the driver not scalable for re-use. > > Sure, I didn't like it either and that wasn't really what I was

Re: [PATCH v11 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-12-05 Thread Stephen Boyd
Quoting Viresh Kumar (2018-12-04 22:16:00) > On 05-12-18, 09:07, Taniya Das wrote: > > Hello Stephen, Viresh > > > > Thanks for the code and suggestions. > > > > Having a NR_DOMAINS '2' makes the driver not scalable for re-use. > > Sure, I didn't like it either and that wasn't really what I was

Re: [RFC PATCH] hwpoison, memory_hotplug: allow hwpoisoned pages to be offlined

2018-12-05 Thread Michal Hocko
On Wed 05-12-18 13:29:18, Michal Hocko wrote: [...] > After some more thinking I am not really sure the above reasoning is > still true with the current upstream kernel. Maybe I just managed to > confuse myself so please hold off on this patch for now. Testing by > Oscar has shown this patch is

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Luck, Tony
On Wed, Dec 05, 2018 at 03:13:23PM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > Rename the containing folder to "mce" which is the most widespread name. > Drop the "mce[-_]" filename prefix of some compilation units (while > others don't have it). > > This unifies the file naming

Re: [RFC PATCH] hwpoison, memory_hotplug: allow hwpoisoned pages to be offlined

2018-12-05 Thread Michal Hocko
On Wed 05-12-18 13:29:18, Michal Hocko wrote: [...] > After some more thinking I am not really sure the above reasoning is > still true with the current upstream kernel. Maybe I just managed to > confuse myself so please hold off on this patch for now. Testing by > Oscar has shown this patch is

Re: [PATCH] x86/mce: Streamline MCE subsystem's naming

2018-12-05 Thread Luck, Tony
On Wed, Dec 05, 2018 at 03:13:23PM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > Rename the containing folder to "mce" which is the most widespread name. > Drop the "mce[-_]" filename prefix of some compilation units (while > others don't have it). > > This unifies the file naming

Re: [PATCH v6 10/24] arm64: irqflags: Use ICC_PMR_EL1 for interrupt masking

2018-12-05 Thread Julien Thierry
On 04/12/18 17:36, Catalin Marinas wrote: > On Mon, Nov 12, 2018 at 11:57:01AM +, Julien Thierry wrote: >> diff --git a/arch/arm64/include/asm/irqflags.h >> b/arch/arm64/include/asm/irqflags.h >> index 24692ed..e0a32e4 100644 >> --- a/arch/arm64/include/asm/irqflags.h >> +++

Re: [PATCH v6 10/24] arm64: irqflags: Use ICC_PMR_EL1 for interrupt masking

2018-12-05 Thread Julien Thierry
On 04/12/18 17:36, Catalin Marinas wrote: > On Mon, Nov 12, 2018 at 11:57:01AM +, Julien Thierry wrote: >> diff --git a/arch/arm64/include/asm/irqflags.h >> b/arch/arm64/include/asm/irqflags.h >> index 24692ed..e0a32e4 100644 >> --- a/arch/arm64/include/asm/irqflags.h >> +++

Re: [PATCH] perf, tools: Support srccode output

2018-12-05 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 05, 2018 at 01:28:38PM +0100, Jiri Olsa escreveu: > On Mon, Dec 03, 2018 at 04:18:48PM -0800, Andi Kleen wrote: > > From: Andi Kleen > > > > When looking at PT or brstackinsn traces with perf script > > it can be very useful to see the source code. This adds a simple > > facility to

Re: [PATCH] perf, tools: Support srccode output

2018-12-05 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 05, 2018 at 01:28:38PM +0100, Jiri Olsa escreveu: > On Mon, Dec 03, 2018 at 04:18:48PM -0800, Andi Kleen wrote: > > From: Andi Kleen > > > > When looking at PT or brstackinsn traces with perf script > > it can be very useful to see the source code. This adds a simple > > facility to

Re: [PATCH] auxdisplay: charlcd: fix x/y command parsing

2018-12-05 Thread Miguel Ojeda
Hi Mans, [CC'ing a few people involved previously on this] On Wed, Dec 5, 2018 at 2:53 PM Mans Rullgard wrote: > > Commit b34050fadb86 ("auxdisplay: charlcd: Fix and clean up handling of > x/y commands") fixed some problems by rewriting the parsing code, > but also broke things further by

Re: [PATCH] auxdisplay: charlcd: fix x/y command parsing

2018-12-05 Thread Miguel Ojeda
Hi Mans, [CC'ing a few people involved previously on this] On Wed, Dec 5, 2018 at 2:53 PM Mans Rullgard wrote: > > Commit b34050fadb86 ("auxdisplay: charlcd: Fix and clean up handling of > x/y commands") fixed some problems by rewriting the parsing code, > but also broke things further by

[GIT PULL] x86: remove Intel MPX

2018-12-05 Thread Dave Hansen
Hi x86 maintainers, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/daveh/x86-mpx.git mpx-remove There is only one commit, removing the Intel MPX implementation from the tree. The benefits of keeping the feature in the tree are not worth the ongoing maintenance cost.

[GIT PULL] x86: remove Intel MPX

2018-12-05 Thread Dave Hansen
Hi x86 maintainers, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/daveh/x86-mpx.git mpx-remove There is only one commit, removing the Intel MPX implementation from the tree. The benefits of keeping the feature in the tree are not worth the ongoing maintenance cost.

Re: [PATCH 4.19 000/139] 4.19.7-stable review

2018-12-05 Thread Rafael David Tinoco
On 12/4/18 8:48 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.7 release. > There are 139 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

Re: [PATCH 4.19 000/139] 4.19.7-stable review

2018-12-05 Thread Rafael David Tinoco
On 12/4/18 8:48 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.7 release. > There are 139 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

Re: [PATCH 0/7] microblaze: fix various problems in building boot images

2018-12-05 Thread Michal Simek
On 03. 12. 18 8:50, Masahiro Yamada wrote: > This patch set fixes various issues in microblaze Makefiles. > > BTW, "simpleImage." works like a phony target to generate the > following four images, where the first three are just aliases. > > - arch/microblaze/boot/simpleImage.: >

Re: [PATCH 0/7] microblaze: fix various problems in building boot images

2018-12-05 Thread Michal Simek
On 03. 12. 18 8:50, Masahiro Yamada wrote: > This patch set fixes various issues in microblaze Makefiles. > > BTW, "simpleImage." works like a phony target to generate the > following four images, where the first three are just aliases. > > - arch/microblaze/boot/simpleImage.: >

Re: [PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-12-05 Thread Lukasz Majewski
Hi Fabio, > Hi Lukasz, > > On Mon, Dec 3, 2018 at 7:33 AM Lukasz Majewski wrote: > > > > > + 72xx165@0 { > > > > > > Please use a generic name for the node. > > > > This is a bit tricky. > > What about using 'gpio@0' like described in >

Re: [PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-12-05 Thread Lukasz Majewski
Hi Fabio, > Hi Lukasz, > > On Mon, Dec 3, 2018 at 7:33 AM Lukasz Majewski wrote: > > > > > + 72xx165@0 { > > > > > > Please use a generic name for the node. > > > > This is a bit tricky. > > What about using 'gpio@0' like described in >

Re: [PATCH 4.14 121/146] x86/fpu: Disable bottom halves while loading FPU registers

2018-12-05 Thread Jari Ruusu
Greg Kroah-Hartman wrote: > commit 68239654acafe6aad5a3c1dc7237e60accfebc03 upstream. > > The sequence > > fpu->initialized = 1; /* step A */ > preempt_disable();/* step B */ > fpu__restore(fpu); > preempt_enable(); > > in __fpu__restore_sig() is racy in regard to a

Re: perf: perf_fuzzer triggers GPF in perf_prepare_sample

2018-12-05 Thread Jiri Olsa
On Wed, Dec 05, 2018 at 01:45:38PM +0100, Jiri Olsa wrote: > On Tue, Dec 04, 2018 at 10:54:55AM -0500, Vince Weaver wrote: > > Hello, > > > > I was able to trigger another oops with the perf_fuzzer with current git. > > > > This is 4.20-rc5 after the fix for the very similar oops I previously >

Re: [PATCH 4.14 121/146] x86/fpu: Disable bottom halves while loading FPU registers

2018-12-05 Thread Jari Ruusu
Greg Kroah-Hartman wrote: > commit 68239654acafe6aad5a3c1dc7237e60accfebc03 upstream. > > The sequence > > fpu->initialized = 1; /* step A */ > preempt_disable();/* step B */ > fpu__restore(fpu); > preempt_enable(); > > in __fpu__restore_sig() is racy in regard to a

Re: perf: perf_fuzzer triggers GPF in perf_prepare_sample

2018-12-05 Thread Jiri Olsa
On Wed, Dec 05, 2018 at 01:45:38PM +0100, Jiri Olsa wrote: > On Tue, Dec 04, 2018 at 10:54:55AM -0500, Vince Weaver wrote: > > Hello, > > > > I was able to trigger another oops with the perf_fuzzer with current git. > > > > This is 4.20-rc5 after the fix for the very similar oops I previously >

Re: [RFC PATCH 1/1] epoll: use rwlock in order to reduce ep_poll_callback() contention

2018-12-05 Thread Jason Baron
On 12/5/18 6:16 AM, Roman Penyaev wrote: > On 2018-12-04 18:23, Jason Baron wrote: >> On 12/3/18 6:02 AM, Roman Penyaev wrote: > > [...] > >>> >>> ep_set_busy_poll_napi_id(epi); >>> >>> @@ -1156,8 +1187,8 @@ static int ep_poll_callback(wait_queue_entry_t *wait, >>> unsigned mode, int

Re: [RFC PATCH 1/1] epoll: use rwlock in order to reduce ep_poll_callback() contention

2018-12-05 Thread Jason Baron
On 12/5/18 6:16 AM, Roman Penyaev wrote: > On 2018-12-04 18:23, Jason Baron wrote: >> On 12/3/18 6:02 AM, Roman Penyaev wrote: > > [...] > >>> >>> ep_set_busy_poll_napi_id(epi); >>> >>> @@ -1156,8 +1187,8 @@ static int ep_poll_callback(wait_queue_entry_t *wait, >>> unsigned mode, int

[PATCH] x86/fault: Print "SUPERVISOR" and "READ" when decoding #PF oops

2018-12-05 Thread Sean Christopherson
...instead of manually handling the case where error_code=0, e.g. to display "[SUPERVISOR] [READ]" instead of "normal kernel read fault". This makes the zero case consistent with all other messages and also provides additional information for other error code combinations, e.g. error_code==1 will

[PATCH] x86/fault: Print "SUPERVISOR" and "READ" when decoding #PF oops

2018-12-05 Thread Sean Christopherson
...instead of manually handling the case where error_code=0, e.g. to display "[SUPERVISOR] [READ]" instead of "normal kernel read fault". This makes the zero case consistent with all other messages and also provides additional information for other error code combinations, e.g. error_code==1 will

Re: edac driver injection of uncorrected errors & utils

2018-12-05 Thread Tracy Smith
This was very helpful. Tracing through the code, it doesn't do a panic before Linux crashes from multi-bit errors because as York has indicated, this type of memory controller doesn't limit the number of errors. I do have a general question about single bit errors. The EDAC driver corrects

Re: edac driver injection of uncorrected errors & utils

2018-12-05 Thread Tracy Smith
This was very helpful. Tracing through the code, it doesn't do a panic before Linux crashes from multi-bit errors because as York has indicated, this type of memory controller doesn't limit the number of errors. I do have a general question about single bit errors. The EDAC driver corrects

Re: [PATCH 1/2] ARM: Remove '-p' from LDFLAGS

2018-12-05 Thread Nicolas Pitre
On Tue, 4 Dec 2018, Nathan Chancellor wrote: > This option is not supported by lld: > > ld.lld: error: unknown argument: -p > > This has been a no-op in binutils since 2004 (see commit dea514f51da1 in > that tree). Given that the lowest officially supported of binutils for > the kernel is

Re: [PATCH 1/2] ARM: Remove '-p' from LDFLAGS

2018-12-05 Thread Nicolas Pitre
On Tue, 4 Dec 2018, Nathan Chancellor wrote: > This option is not supported by lld: > > ld.lld: error: unknown argument: -p > > This has been a no-op in binutils since 2004 (see commit dea514f51da1 in > that tree). Given that the lowest officially supported of binutils for > the kernel is

<    6   7   8   9   10   11   12   13   14   15   >