Re: Process for severe early stable bugs?

2018-12-07 Thread Willy Tarreau
Hi Laura, On Fri, Dec 07, 2018 at 04:33:10PM -0800, Laura Abbott wrote: > The latest file system corruption issue (Nominally fixed by > ffe81d45322c ("blk-mq: fix corruption with direct issue") later > fixed by c616cbee97ae ("blk-mq: punt failed direct issue to dispatch > list")) brought a lot of

Re: Process for severe early stable bugs?

2018-12-07 Thread Willy Tarreau
Hi Laura, On Fri, Dec 07, 2018 at 04:33:10PM -0800, Laura Abbott wrote: > The latest file system corruption issue (Nominally fixed by > ffe81d45322c ("blk-mq: fix corruption with direct issue") later > fixed by c616cbee97ae ("blk-mq: punt failed direct issue to dispatch > list")) brought a lot of

Re: [PATCH] leds: tlc591xx: fix device_node_continue.cocci warnings (fwd)

2018-12-07 Thread Julia Lawall
On Fri, 7 Dec 2018, Jacek Anaszewski wrote: > Hi Julia, > > Thank you for the patch, but it doesn't apply to LED tree. > > The patch causing the problem is out-of-LED-tree. OK, I guess that the patch is in a TI-specific tree, given the name. Thanks for looking into it. julia > > Best

Re: [PATCH] leds: tlc591xx: fix device_node_continue.cocci warnings (fwd)

2018-12-07 Thread Julia Lawall
On Fri, 7 Dec 2018, Jacek Anaszewski wrote: > Hi Julia, > > Thank you for the patch, but it doesn't apply to LED tree. > > The patch causing the problem is out-of-LED-tree. OK, I guess that the patch is in a TI-specific tree, given the name. Thanks for looking into it. julia > > Best

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-07 Thread Dan Williams
On Fri, Dec 7, 2018 at 4:53 PM John Hubbard wrote: > > On 12/7/18 11:16 AM, Jerome Glisse wrote: > > On Thu, Dec 06, 2018 at 06:45:49PM -0800, John Hubbard wrote: [..] > I see. OK, HMM has done an efficient job of mopping up unused fields, and now > we are > completely out of space. At this

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-07 Thread Dan Williams
On Fri, Dec 7, 2018 at 4:53 PM John Hubbard wrote: > > On 12/7/18 11:16 AM, Jerome Glisse wrote: > > On Thu, Dec 06, 2018 at 06:45:49PM -0800, John Hubbard wrote: [..] > I see. OK, HMM has done an efficient job of mopping up unused fields, and now > we are > completely out of space. At this

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Andrea Righi
On Sat, Dec 08, 2018 at 12:48:59PM +0900, Masami Hiramatsu wrote: > On Fri, 7 Dec 2018 18:58:05 +0100 > Andrea Righi wrote: > > > On Sat, Dec 08, 2018 at 01:01:20AM +0900, Masami Hiramatsu wrote: > > > Hi Andrea and Ingo, > > > > > > Here is the patch what I meant. I just ran it on qemu-x86,

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Andrea Righi
On Sat, Dec 08, 2018 at 12:48:59PM +0900, Masami Hiramatsu wrote: > On Fri, 7 Dec 2018 18:58:05 +0100 > Andrea Righi wrote: > > > On Sat, Dec 08, 2018 at 01:01:20AM +0900, Masami Hiramatsu wrote: > > > Hi Andrea and Ingo, > > > > > > Here is the patch what I meant. I just ran it on qemu-x86,

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Andrea Righi
On Sat, Dec 08, 2018 at 12:42:10PM +0900, Masami Hiramatsu wrote: > On Fri, 7 Dec 2018 18:00:26 +0100 > Andrea Righi wrote: > > > On Sat, Dec 08, 2018 at 01:01:20AM +0900, Masami Hiramatsu wrote: > > > Hi Andrea and Ingo, > > > > > > Here is the patch what I meant. I just ran it on qemu-x86,

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Andrea Righi
On Sat, Dec 08, 2018 at 12:42:10PM +0900, Masami Hiramatsu wrote: > On Fri, 7 Dec 2018 18:00:26 +0100 > Andrea Righi wrote: > > > On Sat, Dec 08, 2018 at 01:01:20AM +0900, Masami Hiramatsu wrote: > > > Hi Andrea and Ingo, > > > > > > Here is the patch what I meant. I just ran it on qemu-x86,

[PATCH] ARC: Remove 0x prefix from unit-address of node names

2018-12-07 Thread Alexey Brodkin
Done automatically with help of: --->8 sed -i 's/@0x/@/g' arch/arc/boot/dts/*.dts* --->8 Inspired by [1] and the like. [1] http://kisskb.ellerman.id.au/kisskb/buildresult/13612017/ Signed-off-by: Alexey

Re: [PATCH 1/5] kconfig: remove unneeded setsym label in conf_read_simple()

2018-12-07 Thread Masahiro Yamada
On Fri, Nov 30, 2018 at 6:17 PM Masahiro Yamada wrote: > > The two 'goto setsym' statements are reachable only when sym == NULL. > > The code below the 'setsym:' label does nothing when sym == NULL > since there is just one if-block guarded by 'if (sym && ...)'. > > Hence, 'goto setsym' can be

Re: [PATCH 1/5] kconfig: remove unneeded setsym label in conf_read_simple()

2018-12-07 Thread Masahiro Yamada
On Fri, Nov 30, 2018 at 6:17 PM Masahiro Yamada wrote: > > The two 'goto setsym' statements are reachable only when sym == NULL. > > The code below the 'setsym:' label does nothing when sym == NULL > since there is just one if-block guarded by 'if (sym && ...)'. > > Hence, 'goto setsym' can be

Re: [PATCH] kbuild: move .SECONDARY special target to Kbuild.include

2018-12-07 Thread Masahiro Yamada
On Sat, Dec 1, 2018 at 9:29 AM Masahiro Yamada wrote: > > In commit 54a702f70589 ("kbuild: mark $(targets) as .SECONDARY and > remove .PRECIOUS markers"), I missed one important feature of the > .SECONDARY target: > > .SECONDARY with no prerequisites causes all targets to be treated >as

Re: [PATCH 6/7] microblaze: fix race condition in building boot images

2018-12-07 Thread Masahiro Yamada
On Thu, Dec 6, 2018 at 1:32 AM Michal Simek wrote: > > On 03. 12. 18 8:50, Masahiro Yamada wrote: > > I fixed a race condition in the parallel building of ARM in commit > > 3939f3345050 ("ARM: 8418/1: add boot image dependencies to not > > generate invalid images"). > > > > I see the same problem

Re: [PATCH 6/7] microblaze: fix race condition in building boot images

2018-12-07 Thread Masahiro Yamada
On Thu, Dec 6, 2018 at 1:32 AM Michal Simek wrote: > > On 03. 12. 18 8:50, Masahiro Yamada wrote: > > I fixed a race condition in the parallel building of ARM in commit > > 3939f3345050 ("ARM: 8418/1: add boot image dependencies to not > > generate invalid images"). > > > > I see the same problem

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-07 Thread ayman . bagabas
On Fri, 2018-12-07 at 00:52 -0500, ayman.baga...@gmail.com wrote: On Mon, 2018-12-03 at 21:17 +0200, Andy Shevchenko wrote: > On Mon, Dec 3, 2018 at 9:04 PM Takashi Iwai wrote: > > On Mon, 03 Dec 2018 19:53:39 +0100, > > Ayman Bagabas wrote: > > > + if (code == 0x80) { > > > +

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-07 Thread ayman . bagabas
On Fri, 2018-12-07 at 00:52 -0500, ayman.baga...@gmail.com wrote: On Mon, 2018-12-03 at 21:17 +0200, Andy Shevchenko wrote: > On Mon, Dec 3, 2018 at 9:04 PM Takashi Iwai wrote: > > On Mon, 03 Dec 2018 19:53:39 +0100, > > Ayman Bagabas wrote: > > > + if (code == 0x80) { > > > +

Re: [PATCH 1/2] um: remove -fno-unit-at-a-time workaround for pre-4.0 GCC

2018-12-07 Thread Masahiro Yamada
x86 maintainers, Ping. On Tue, Nov 13, 2018 at 6:48 PM Richard Weinberger wrote: > > Am Montag, 12. November 2018, 03:35:19 CET schrieb Masahiro Yamada: > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > bumped the minimum GCC version to 4.6 for all architectures.

Re: [PATCH 2/2] x86, powerpc: remove -funit-at-a-time compiler option entirely

2018-12-07 Thread Masahiro Yamada
x86 maintainers, Ping. On Mon, Nov 12, 2018 at 8:23 PM Michael Ellerman wrote: > > Masahiro Yamada writes: > > > GCC 4.6 manual says: > > > > -funit-at-a-time > > This option is left for compatibility reasons. -funit-at-a-time has > > no effect, while -fno-unit-at-a-time implies

[RFC PATCH] hwmon/k10temp: Add Hygon Dhyana support

2018-12-07 Thread Pu Wen
Add support for Hygon Dhyana family 18h processor for k10temp to get the temperature. As Hygon Dhyana shares the same function interface with AMD family 17h, so add Hygon PCI Vendor ID and reuse the code path of AMD. Signed-off-by: Pu Wen --- drivers/hwmon/k10temp.c | 3 ++- 1 file changed, 2

Re: [PATCH] nvme-rdma: complete requests from ->timeout

2018-12-07 Thread Jaesoo Lee
Now, I see that my patch is not safe and can cause double completions. However, I am having a hard time finding out a good solution to barrier the racing completions. Could you suggest where the fix should go and what should it look like? We can provide more details on reproducing this issue if

Re: [PATCH] nvme-rdma: complete requests from ->timeout

2018-12-07 Thread Jaesoo Lee
Now, I see that my patch is not safe and can cause double completions. However, I am having a hard time finding out a good solution to barrier the racing completions. Could you suggest where the fix should go and what should it look like? We can provide more details on reproducing this issue if

Re: [PATCH 0/7] microblaze: fix various problems in building boot images

2018-12-07 Thread Masahiro Yamada
On Sat, Dec 8, 2018 at 12:20 AM Michal Simek wrote: > > On 07. 12. 18 14:29, Michal Simek wrote: > > On 07. 12. 18 12:29, Masahiro Yamada wrote: > >> On Thu, Dec 6, 2018 at 11:55 PM Michal Simek wrote: > >>> > >>> On 03. 12. 18 8:50, Masahiro Yamada wrote: > This patch set fixes various

Re: [PATCH 0/7] microblaze: fix various problems in building boot images

2018-12-07 Thread Masahiro Yamada
On Sat, Dec 8, 2018 at 12:20 AM Michal Simek wrote: > > On 07. 12. 18 14:29, Michal Simek wrote: > > On 07. 12. 18 12:29, Masahiro Yamada wrote: > >> On Thu, Dec 6, 2018 at 11:55 PM Michal Simek wrote: > >>> > >>> On 03. 12. 18 8:50, Masahiro Yamada wrote: > This patch set fixes various

Re: [PATCH] x86/kernel: Fix more -Wmissing-prototypes warnings

2018-12-07 Thread Masami Hiramatsu
On Fri, 7 Dec 2018 20:48:47 +0100 Borislav Petkov wrote: > On Fri, Dec 07, 2018 at 11:42:10PM +0900, Masami Hiramatsu wrote: > > Hmm, I just thought that the symbol only referred from inline asm should > > be visible. But if it is OK for any version of supported gcc and clang, > > I'm good to

Re: [PATCH] x86/kernel: Fix more -Wmissing-prototypes warnings

2018-12-07 Thread Masami Hiramatsu
On Fri, 7 Dec 2018 20:48:47 +0100 Borislav Petkov wrote: > On Fri, Dec 07, 2018 at 11:42:10PM +0900, Masami Hiramatsu wrote: > > Hmm, I just thought that the symbol only referred from inline asm should > > be visible. But if it is OK for any version of supported gcc and clang, > > I'm good to

RE: [PATCH V3 1/4] spi: lpspi: Replace all "master" with "controller"

2018-12-07 Thread Clark Wang
Hi Joe, This patch series adds slave mode for lpspi controller. So this driver can support both master and slave mode for lpspi controller after apply this patch series. Currently, both master mode and slave mode share the code in this driver. Therefore, using spi_master to represent the

RE: [PATCH V3 1/4] spi: lpspi: Replace all "master" with "controller"

2018-12-07 Thread Clark Wang
Hi Joe, This patch series adds slave mode for lpspi controller. So this driver can support both master and slave mode for lpspi controller after apply this patch series. Currently, both master mode and slave mode share the code in this driver. Therefore, using spi_master to represent the

[PATCH v5 0/1] signaling processes through pidfds

2018-12-07 Thread Christian Brauner
Hey everyone, This is v5 of this patchset. v5 does not introduce any functional changes since none were requested or required in the thread. Instead, it focusses on updated documentation making it very clear what the intentions are how to extend this syscall. Eric, I dragged Serge into this and

[PATCH v5 1/1] signal: add pidfd_send_signal() syscall

2018-12-07 Thread Christian Brauner
The kill() syscall operates on process identifiers (pid). After a process has exited its pid can be reused by another process. If a caller sends a signal to a reused pid it will end up signaling the wrong process. This issue has often surfaced and there has been a push to address this problem [1].

[PATCH v5 0/1] signaling processes through pidfds

2018-12-07 Thread Christian Brauner
Hey everyone, This is v5 of this patchset. v5 does not introduce any functional changes since none were requested or required in the thread. Instead, it focusses on updated documentation making it very clear what the intentions are how to extend this syscall. Eric, I dragged Serge into this and

[PATCH v5 1/1] signal: add pidfd_send_signal() syscall

2018-12-07 Thread Christian Brauner
The kill() syscall operates on process identifiers (pid). After a process has exited its pid can be reused by another process. If a caller sends a signal to a reused pid it will end up signaling the wrong process. This issue has often surfaced and there has been a push to address this problem [1].

arch/x86/include/asm/cmpxchg.h:245:2: error: 'asm' operand has impossible constraints

2018-12-07 Thread kbuild test robot
Hi Juergen, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5f179793f0a73965681db6a3203fa1baabd9b3c3 commit: 6da63eb241a05b0e676d68975e793c0521387141 x86/paravirt: Move the pv_irq_ops under the PARAVIRT_XXL

arch/x86/include/asm/cmpxchg.h:245:2: error: 'asm' operand has impossible constraints

2018-12-07 Thread kbuild test robot
Hi Juergen, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5f179793f0a73965681db6a3203fa1baabd9b3c3 commit: 6da63eb241a05b0e676d68975e793c0521387141 x86/paravirt: Move the pv_irq_ops under the PARAVIRT_XXL

Re: [PATCH 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD

2018-12-07 Thread Vignesh R
On 07/12/18 2:12 PM, Faiz Abbas wrote: > There are two MMC host controller instances present on the TI's > Am654 SOCs. Add device tree nodes for the same. > > Signed-off-by: Faiz Abbas > --- > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 28 > 1 file changed, 28

Re: [PATCH 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD

2018-12-07 Thread Vignesh R
On 07/12/18 2:12 PM, Faiz Abbas wrote: > There are two MMC host controller instances present on the TI's > Am654 SOCs. Add device tree nodes for the same. > > Signed-off-by: Faiz Abbas > --- > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 28 > 1 file changed, 28

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-07 Thread Matthew Wilcox
On Fri, Dec 07, 2018 at 04:52:42PM -0800, John Hubbard wrote: > I see. OK, HMM has done an efficient job of mopping up unused fields, and now > we are > completely out of space. At this point, after thinking about it carefully, it > seems clear > that it's time for a single, new field: Sorry

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-07 Thread Matthew Wilcox
On Fri, Dec 07, 2018 at 04:52:42PM -0800, John Hubbard wrote: > I see. OK, HMM has done an efficient job of mopping up unused fields, and now > we are > completely out of space. At this point, after thinking about it carefully, it > seems clear > that it's time for a single, new field: Sorry

Re: [PATCH V3 1/4] spi: lpspi: Replace all "master" with "controller"

2018-12-07 Thread Joe Perches
On Fri, 2018-12-07 at 02:50 +, Clark Wang wrote: > In order to enable the slave mode and make the code more readable, > replace all related structure names and object names which is > named "master" with "controller". In what sense does this make the code more readable?

Re: [PATCH V3 1/4] spi: lpspi: Replace all "master" with "controller"

2018-12-07 Thread Joe Perches
On Fri, 2018-12-07 at 02:50 +, Clark Wang wrote: > In order to enable the slave mode and make the code more readable, > replace all related structure names and object names which is > named "master" with "controller". In what sense does this make the code more readable?

[GIT PULL] Qualcomm ARM64 DT updates for 4.21 - Part 2

2018-12-07 Thread Andy Gross
The following changes since commit 70827d9f6bc4f481fafe790dd6654ba568526768: arm64: dts: qcom: msm8998: Fix compatible of scm node (2018-11-30 07:59:02 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-arm64-for-4.21-2

[GIT PULL] Qualcomm Driver updates for 4.21 - Part 2

2018-12-07 Thread Andy Gross
The following changes since commit b601f73130a375c912d9f2ec93c5f3cea5d6a3da: drm: msm: Check cmd_db_read_aux_data() for failure (2018-11-29 17:41:53 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-drivers-for-4.21-2

[GIT PULL] Qualcomm ARM64 DT updates for 4.21 - Part 2

2018-12-07 Thread Andy Gross
The following changes since commit 70827d9f6bc4f481fafe790dd6654ba568526768: arm64: dts: qcom: msm8998: Fix compatible of scm node (2018-11-30 07:59:02 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-arm64-for-4.21-2

[GIT PULL] Qualcomm Driver updates for 4.21 - Part 2

2018-12-07 Thread Andy Gross
The following changes since commit b601f73130a375c912d9f2ec93c5f3cea5d6a3da: drm: msm: Check cmd_db_read_aux_data() for failure (2018-11-29 17:41:53 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-drivers-for-4.21-2

Re: [PATCH v2 01/34] kbuild: Add support for DT binding schema checks

2018-12-07 Thread Masahiro Yamada
Hi Rob, On Tue, Dec 4, 2018 at 6:32 AM Rob Herring wrote: > > This adds the build infrastructure for checking DT binding schema > documents and validating dts files using the binding schema. > > Check DT binding schema documents: > make dt_binding_check > > Build dts files and check using DT

Re: [RFC PATCH RESEND] x86/cpu: Avoid endless loop to get the number of cache leaves

2018-12-07 Thread Pu Wen
On 2018/12/6 18:37, Borislav Petkov wrote: > Did you not see my reply to this last time? > > https://lkml.kernel.org/r/20181115172155.gb25...@zn.tnic I'm sorry that there is something wrong with my mail filter. So I was not notified about your reply for many days. :) I just found your reply and

Re: [RFC PATCH RESEND] x86/cpu: Avoid endless loop to get the number of cache leaves

2018-12-07 Thread Pu Wen
On 2018/12/6 18:37, Borislav Petkov wrote: > Did you not see my reply to this last time? > > https://lkml.kernel.org/r/20181115172155.gb25...@zn.tnic I'm sorry that there is something wrong with my mail filter. So I was not notified about your reply for many days. :) I just found your reply and

Re: [RFC PATCH RESEND] x86/cpu: Avoid endless loop to get the number of cache leaves

2018-12-07 Thread Pu Wen
On 2018/12/6 18:37, Borislav Petkov wrote: Did you not see my reply to this last time? https://lkml.kernel.org/r/20181115172155.gb25...@zn.tnic I'm sorry that there is something wrong with my mail filter. So I was not notified about your reply for many days. :) I just found your reply and

Re: [RFC PATCH RESEND] x86/cpu: Avoid endless loop to get the number of cache leaves

2018-12-07 Thread Pu Wen
On 2018/12/6 18:37, Borislav Petkov wrote: Did you not see my reply to this last time? https://lkml.kernel.org/r/20181115172155.gb25...@zn.tnic I'm sorry that there is something wrong with my mail filter. So I was not notified about your reply for many days. :) I just found your reply and

Re: [PATCH v6 2/5] phy: qcom-qmp: Utilize fully-specified DT registers

2018-12-07 Thread Kishon Vijay Abraham I
Hi, On 07/12/18 2:16 PM, Vivek Gautam wrote: > On Fri, Dec 7, 2018 at 5:06 AM Evan Green wrote: >> >> Utilize the newly fixed up DT bindings to get the tx2 and rx2 register >> regions for the second lane of dual-lane PHYs. Before this change, >> the driver was simply using lane one's register

Re: [PATCH v6 2/5] phy: qcom-qmp: Utilize fully-specified DT registers

2018-12-07 Thread Kishon Vijay Abraham I
Hi, On 07/12/18 2:16 PM, Vivek Gautam wrote: > On Fri, Dec 7, 2018 at 5:06 AM Evan Green wrote: >> >> Utilize the newly fixed up DT bindings to get the tx2 and rx2 register >> regions for the second lane of dual-lane PHYs. Before this change, >> the driver was simply using lane one's register

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Masami Hiramatsu
On Fri, 7 Dec 2018 18:58:05 +0100 Andrea Righi wrote: > On Sat, Dec 08, 2018 at 01:01:20AM +0900, Masami Hiramatsu wrote: > > Hi Andrea and Ingo, > > > > Here is the patch what I meant. I just ran it on qemu-x86, and seemed > > working. > > After introducing this patch, I will start adding >

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Masami Hiramatsu
On Fri, 7 Dec 2018 18:58:05 +0100 Andrea Righi wrote: > On Sat, Dec 08, 2018 at 01:01:20AM +0900, Masami Hiramatsu wrote: > > Hi Andrea and Ingo, > > > > Here is the patch what I meant. I just ran it on qemu-x86, and seemed > > working. > > After introducing this patch, I will start adding >

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Masami Hiramatsu
On Fri, 7 Dec 2018 18:00:26 +0100 Andrea Righi wrote: > On Sat, Dec 08, 2018 at 01:01:20AM +0900, Masami Hiramatsu wrote: > > Hi Andrea and Ingo, > > > > Here is the patch what I meant. I just ran it on qemu-x86, and seemed > > working. > > After introducing this patch, I will start adding >

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Masami Hiramatsu
On Fri, 7 Dec 2018 18:00:26 +0100 Andrea Righi wrote: > On Sat, Dec 08, 2018 at 01:01:20AM +0900, Masami Hiramatsu wrote: > > Hi Andrea and Ingo, > > > > Here is the patch what I meant. I just ran it on qemu-x86, and seemed > > working. > > After introducing this patch, I will start adding >

Re: [PATCH bpf-next 2/3] bpf: add bpffs pretty print for cgroup local storage maps

2018-12-07 Thread Yonghong Song
On 12/7/18 4:53 PM, Roman Gushchin wrote: > Implement bpffs pretty printing for cgroup local storage maps > (both shared and per-cpu). > Output example (captured for tools/testing/selftests/bpf/netcnt_prog.c): > > Shared: >$ cat /sys/fs/bpf/map_2 ># WARNING!! The output is for debug

Re: [PATCH v4 4/5] ARM: dts: imx5: add gpu nodes

2018-12-07 Thread Shawn Guo
On Tue, Dec 04, 2018 at 10:17:00AM -0500, Jonathan Marek wrote: > This adds the gpu nodes for the adreno 200 GPU on iMX51 and iMX53, now > supported by the freedreno driver. > > The compatible for the iMX51 uses a patchid of 1, which is used by drm/msm > driver to identify the smaller 128KiB GMEM

Re: [RFC][PATCHv2 3/4] serial: introduce uart_port locking helpers

2018-12-07 Thread Sergey Senozhatsky
On (10/16/18 14:04), Sergey Senozhatsky wrote: [..] > - The first entry point is console ->write() callback, which we call > from printk(). A possible deadlock scenario there is: > > CPU0 > > spin_lock_irqsave(>lock, flags) << deadlock > serial_foo_write() >

Re: [RFC][PATCHv2 3/4] serial: introduce uart_port locking helpers

2018-12-07 Thread Sergey Senozhatsky
On (10/16/18 14:04), Sergey Senozhatsky wrote: [..] > - The first entry point is console ->write() callback, which we call > from printk(). A possible deadlock scenario there is: > > CPU0 > > spin_lock_irqsave(>lock, flags) << deadlock > serial_foo_write() >

Re: [PATCH] scsi: Use of_node_name_eq for node name comparisons

2018-12-07 Thread Martin K. Petersen
Rob, > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. Applied to 4.21/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

[PATCH] checkstack.pl: dynamic stack growth for aarch64

2018-12-07 Thread Qian Cai
This is to track dynamic amount of stack growth for aarch64, so it is possible to print out offensive functions that may consume too much stack. For example, 0x284d1270 try_to_unmap_one [vmlinux]: Dynamic (0xcf0) 0x28538358 migrate_page_move_mapping [vmlinux]: Dynamic

[PATCH] checkstack.pl: dynamic stack growth for aarch64

2018-12-07 Thread Qian Cai
This is to track dynamic amount of stack growth for aarch64, so it is possible to print out offensive functions that may consume too much stack. For example, 0x284d1270 try_to_unmap_one [vmlinux]: Dynamic (0xcf0) 0x28538358 migrate_page_move_mapping [vmlinux]: Dynamic

Re: [PATCH] x86/cpu: Avoid endless loop to get the number of cache leaves

2018-12-07 Thread Pu Wen
Sorry for the late reply :) On 2018/11/16 1:22, Borislav Petkov wrote: >> @@ -640,7 +641,7 @@ static int find_num_cache_leaves(struct cpuinfo_x86 *c) >> /* Do cpuid(op) loop to find out num_cache_leaves */ >> cpuid_count(op, i, , , , ); >> cache_eax.full =

Re: [PATCH] x86/cpu: Avoid endless loop to get the number of cache leaves

2018-12-07 Thread Pu Wen
Sorry for the late reply :) On 2018/11/16 1:22, Borislav Petkov wrote: >> @@ -640,7 +641,7 @@ static int find_num_cache_leaves(struct cpuinfo_x86 *c) >> /* Do cpuid(op) loop to find out num_cache_leaves */ >> cpuid_count(op, i, , , , ); >> cache_eax.full =

Re: [PATCH] scsi: qla2xxx: NULL check before some freeing functions is not needed.

2018-12-07 Thread Martin K. Petersen
Thomas, > NULL check before some freeing functions is not needed. Applied to 4.21/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qedf: NULL check before some freeing functions is not needed.

2018-12-07 Thread Martin K. Petersen
Thomas, > NULL check before some freeing functions is not needed. Applied to 4.21/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: megaraid_sas: NULL check before some freeing functions is not needed.

2018-12-07 Thread Martin K. Petersen
Thomas, > NULL check before some freeing functions is not needed. Applied to 4.21/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] pseries/hotplug: Add more delay in pseries_cpu_die while waiting for rtas-stop

2018-12-07 Thread Thiago Jung Bauermann
Gautham R Shenoy writes: > On Fri, Dec 07, 2018 at 04:13:11PM +0530, Gautham R Shenoy wrote: >> Sure. I will test the patch and report back. > > I added the following debug patch on top of your patch, and after an > hour's run, the system crashed. Appending the log at the end. Thank you very

Re: [PATCH 01/41] scsi: BusLogic: mark expected switch fall-through

2018-12-07 Thread Martin K. Petersen
Gustavo A., > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. Applied to 4.21/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc

2018-12-07 Thread Martin K. Petersen
Sabyasachi, > Replaced vmalloc + memset with vzalloc Applied to 4.21/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-07 Thread Jerome Glisse
On Fri, Dec 07, 2018 at 04:52:42PM -0800, John Hubbard wrote: > On 12/7/18 11:16 AM, Jerome Glisse wrote: > > On Thu, Dec 06, 2018 at 06:45:49PM -0800, John Hubbard wrote: > >> On 12/4/18 5:57 PM, John Hubbard wrote: > >>> On 12/4/18 5:44 PM, Jerome Glisse wrote: > On Tue, Dec 04, 2018 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-07 Thread Jerome Glisse
On Fri, Dec 07, 2018 at 04:52:42PM -0800, John Hubbard wrote: > On 12/7/18 11:16 AM, Jerome Glisse wrote: > > On Thu, Dec 06, 2018 at 06:45:49PM -0800, John Hubbard wrote: > >> On 12/4/18 5:57 PM, John Hubbard wrote: > >>> On 12/4/18 5:44 PM, Jerome Glisse wrote: > On Tue, Dec 04, 2018 at

[PATCH] selftests/vm/gup_benchmark.c: match gup struct to kernel

2018-12-07 Thread Alison Schofield
An expansion field was added to the kernel copy of this structure for future use. See mm/gup_benchmark.c. Add the same expansion field here, so that the IOCTL command decodes correctly. Otherwise, it fails with EINVAL. Signed-off-by: Alison Schofield ---

Re: [PATCH] nvme-rdma: complete requests from ->timeout

2018-12-07 Thread Keith Busch
On Fri, Dec 07, 2018 at 12:05:37PM -0800, Sagi Grimberg wrote: > > > Could you please take a look at this bug and code review? > > > > We are seeing more instances of this bug and found that reconnect_work > > could hang as well, as can be seen from below stacktrace. > > > > Workqueue:

[PATCH] selftests/vm/gup_benchmark.c: match gup struct to kernel

2018-12-07 Thread Alison Schofield
An expansion field was added to the kernel copy of this structure for future use. See mm/gup_benchmark.c. Add the same expansion field here, so that the IOCTL command decodes correctly. Otherwise, it fails with EINVAL. Signed-off-by: Alison Schofield ---

Re: [PATCH] nvme-rdma: complete requests from ->timeout

2018-12-07 Thread Keith Busch
On Fri, Dec 07, 2018 at 12:05:37PM -0800, Sagi Grimberg wrote: > > > Could you please take a look at this bug and code review? > > > > We are seeing more instances of this bug and found that reconnect_work > > could hang as well, as can be seen from below stacktrace. > > > > Workqueue:

Re: [PATCH v2 18/34] dt-bindings: arm: Convert FSL board/soc bindings to json-schema

2018-12-07 Thread Shawn Guo
On Thu, Dec 06, 2018 at 05:33:13PM -0600, Rob Herring wrote: > On Wed, Dec 5, 2018 at 8:32 PM Shawn Guo wrote: > > > > On Mon, Dec 03, 2018 at 03:32:07PM -0600, Rob Herring wrote: > > > Convert Freescale SoC bindings to DT schema format using json-schema. > > > > > > Cc: Shawn Guo > > > Cc: Mark

Query about platform device registration

2018-12-07 Thread Vakul Garg
Hi I am registering a device using platform_device_register_full(). In the above-mentioned api argument - 'struct platform_device_info', I set the parent device pointer, set_dma_mask from parent device etc. The parent device is created by declaration in device tree and the relevant node has

Query about platform device registration

2018-12-07 Thread Vakul Garg
Hi I am registering a device using platform_device_register_full(). In the above-mentioned api argument - 'struct platform_device_info', I set the parent device pointer, set_dma_mask from parent device etc. The parent device is created by declaration in device tree and the relevant node has

[PATCH v3 2/2] USB: quirks: Disable LPM for Logitech UVC devices

2018-12-07 Thread Kyle Williams
From: Kyle Williams Description: Some USB device / host controller combinations seem to have problems with Link Power management. In particular it is described that the combination of certain Logitech uvc devices and other powered media devices such causes 'not enough bandwidth for new device

[PATCH v3 0/2] Disable LPM by matching interface

2018-12-07 Thread Kyle Williams
Changes in v3: - seperated work to allow matched interfaces to use the USB_QUIRK_NO_LPM quirk to affect a broader range of devices instead of setting each device individually Kyle Williams (2): USB: quirks: Check device interface LPM capability USB: quirks: Disable LPM for Logitech UVC

[PATCH v3 1/2] USB: quirks: Check device interface LPM capability

2018-12-07 Thread Kyle Williams
From: Kyle Williams Description: enable the ability to disable LPM for all devices matched by interface information Signed-off-by: Kyle Williams --- drivers/usb/core/hub.c | 87 +++--- 1 file changed, 48 insertions(+), 39 deletions(-) diff --git

Re: [PATCH 1/1] virtio: remove deprecated VIRTIO_PCI_CONFIG()

2018-12-07 Thread Dongli Zhang
On 12/08/2018 02:01 AM, Michael S. Tsirkin wrote: > On Fri, Dec 07, 2018 at 03:34:41PM +0800, Dongli Zhang wrote: >> VIRTIO_PCI_CONFIG() is deprecated. Use VIRTIO_PCI_CONFIG_OFF() instead. >> >> Signed-off-by: Dongli Zhang >> --- >> drivers/virtio/virtio_pci_legacy.c | 6 -- >>

[PATCH bpf-next 2/3] bpf: add bpffs pretty print for cgroup local storage maps

2018-12-07 Thread Roman Gushchin
Implement bpffs pretty printing for cgroup local storage maps (both shared and per-cpu). Output example (captured for tools/testing/selftests/bpf/netcnt_prog.c): Shared: $ cat /sys/fs/bpf/map_2 # WARNING!! The output is for debug purpose only # WARNING!! The output format will change

[PATCH bpf-next 1/3] bpf: pass struct btf pointer to the map_check_btf() callback

2018-12-07 Thread Roman Gushchin
If key_type or value_type are of non-trivial data types (e.g. structure or typedef), it's not possible to check them without the additional information, which can't be obtained without a pointer to the btf structure. So, let's pass btf pointer to the map_check_btf() callbacks. Signed-off-by:

[PATCH bpf-next 3/3] selftests/bpf: add btf annotations for cgroup_local_storage maps

2018-12-07 Thread Roman Gushchin
Add btf annotations to cgroup local storage maps (per-cpu and shared) in the network packet counting example. Signed-off-by: Roman Gushchin Cc: Alexei Starovoitov Cc: Daniel Borkmann --- tools/testing/selftests/bpf/netcnt_prog.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-07 Thread John Hubbard
On 12/7/18 11:16 AM, Jerome Glisse wrote: > On Thu, Dec 06, 2018 at 06:45:49PM -0800, John Hubbard wrote: >> On 12/4/18 5:57 PM, John Hubbard wrote: >>> On 12/4/18 5:44 PM, Jerome Glisse wrote: On Tue, Dec 04, 2018 at 05:15:19PM -0800, Matthew Wilcox wrote: > On Tue, Dec 04, 2018 at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-07 Thread John Hubbard
On 12/7/18 11:16 AM, Jerome Glisse wrote: > On Thu, Dec 06, 2018 at 06:45:49PM -0800, John Hubbard wrote: >> On 12/4/18 5:57 PM, John Hubbard wrote: >>> On 12/4/18 5:44 PM, Jerome Glisse wrote: On Tue, Dec 04, 2018 at 05:15:19PM -0800, Matthew Wilcox wrote: > On Tue, Dec 04, 2018 at

Re: [PATCH] Fix sync. in blkdev_write_iter() acessing i_flags

2018-12-07 Thread Al Viro
On Fri, Dec 07, 2018 at 08:49:16PM +0100, Alexander Lochmann wrote: > > _What_ SUID bit? We are talking about a write to block device, for fsck > > sake... > > > That's the way I understood Jan's explanation: > " > Thinking more about this I'm not sure if this is actually the right > solution.

Re: [PATCH] Fix sync. in blkdev_write_iter() acessing i_flags

2018-12-07 Thread Al Viro
On Fri, Dec 07, 2018 at 08:49:16PM +0100, Alexander Lochmann wrote: > > _What_ SUID bit? We are talking about a write to block device, for fsck > > sake... > > > That's the way I understood Jan's explanation: > " > Thinking more about this I'm not sure if this is actually the right > solution.

[PATCH v2] USB: quirks: disable LPM for Logitech UVC devices

2018-12-07 Thread Kyle Williams
From: Kyle Williams Description: Some USB device / host controller combinations seem to have problems with Link Power management. In particular it is described that the combination of certain Logitech uvc devices and other powered media devices such causes 'not enough bandwidth for new device

Re: Recommended driver for current AMD processors

2018-12-07 Thread Ken Moffat
Hi Paul, On Fri, 7 Dec 2018 at 15:32, Paul Menzel wrote: > > Dear Linux folks, > > > What driver is recommended for current AMD Ryzen based processors > like *AMD Ryzen 5 PRO 1500 Quad-Core Processor* or *AMD EPYC 7601 > 32-Core Processor*? > > Only from the acpi-cpufreq Kconfig description, I

Re: Recommended driver for current AMD processors

2018-12-07 Thread Ken Moffat
Hi Paul, On Fri, 7 Dec 2018 at 15:32, Paul Menzel wrote: > > Dear Linux folks, > > > What driver is recommended for current AMD Ryzen based processors > like *AMD Ryzen 5 PRO 1500 Quad-Core Processor* or *AMD EPYC 7601 > 32-Core Processor*? > > Only from the acpi-cpufreq Kconfig description, I

Should this_cpu_read() be volatile?

2018-12-07 Thread Nadav Amit
[Resend, changing title & adding lkml and some others ] On Dec 7, 2018, at 3:12 PM, Nadav Amit wrote: [ We can start a new thread, since I have the tendency to hijack threads. ] > On Dec 7, 2018, at 12:45 AM, Peter Zijlstra wrote: > > On Thu, Dec 06, 2018 at 09:26:24AM -0800, Nadav Amit

Should this_cpu_read() be volatile?

2018-12-07 Thread Nadav Amit
[Resend, changing title & adding lkml and some others ] On Dec 7, 2018, at 3:12 PM, Nadav Amit wrote: [ We can start a new thread, since I have the tendency to hijack threads. ] > On Dec 7, 2018, at 12:45 AM, Peter Zijlstra wrote: > > On Thu, Dec 06, 2018 at 09:26:24AM -0800, Nadav Amit

Process for severe early stable bugs?

2018-12-07 Thread Laura Abbott
The latest file system corruption issue (Nominally fixed by ffe81d45322c ("blk-mq: fix corruption with direct issue") later fixed by c616cbee97ae ("blk-mq: punt failed direct issue to dispatch list")) brought a lot of rightfully concerned users asking about release schedules. 4.18 went EOL on Nov

Process for severe early stable bugs?

2018-12-07 Thread Laura Abbott
The latest file system corruption issue (Nominally fixed by ffe81d45322c ("blk-mq: fix corruption with direct issue") later fixed by c616cbee97ae ("blk-mq: punt failed direct issue to dispatch list")) brought a lot of rightfully concerned users asking about release schedules. 4.18 went EOL on Nov

Re: [PATCH] /proc/kpagecount: return 0 for special pages that are never mapped

2018-12-07 Thread Andrew Morton
On Wed, 5 Dec 2018 22:07:37 -0800 Anthony Yznaga wrote: > Would you like me to submit a revised patch?  An -mm tree diff? Either is OK. I usually turn replacemensts into deltas so we can see what changed.

Re: [PATCH] /proc/kpagecount: return 0 for special pages that are never mapped

2018-12-07 Thread Andrew Morton
On Wed, 5 Dec 2018 22:07:37 -0800 Anthony Yznaga wrote: > Would you like me to submit a revised patch?  An -mm tree diff? Either is OK. I usually turn replacemensts into deltas so we can see what changed.

  1   2   3   4   5   6   7   8   9   10   >