Re: powerpc: build virtex dtb

2019-01-23 Thread Michael Ellerman
On Tue, 2019-01-08 at 12:52:50 UTC, Corentin Labbe wrote: > I wanted to test the virtex440-ml507 qemu machine and found that the dtb > for it was not builded. > All powerpc DTB are only built when CONFIG_OF_ALL_DTBS is set which depend on > COMPILE_TEST. > > This patchs adds build of virtex dtbs

Re: powerpc: use a CONSOLE_LOGLEVEL_DEBUG macro

2019-01-23 Thread Michael Ellerman
On Mon, 2019-01-07 at 09:57:20 UTC, Sergey Senozhatsky wrote: > Use a CONSOLE_LOGLEVEL_DEBUG macro for console_loglevel rather > than a naked number. > > Signed-off-by: Sergey Senozhatsky Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/fae1383b38a105a0454acab19b094c51 cheers

Re: powerpc/spufs: use struct_size() in kmalloc()

2019-01-23 Thread Michael Ellerman
On Tue, 2019-01-08 at 18:37:20 UTC, "Gustavo A. R. Silva" wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct foo

Re: [v2 PATCH] rhashtable: Still do rehash when we get EEXIST

2019-01-23 Thread Josh Elsasser
On Jan 23, 2019, at 7:08 PM, Herbert Xu wrote: > Thanks for catching this! > > Although I think we should fix this in a different way. The problem > here is that the shrink cannot proceed because there was a previous > rehash that is still incomplete. We should wait for its completion > and

Re: powerpc/irq: drop arch_early_irq_init()

2019-01-23 Thread Michael Ellerman
On Tue, 2019-01-08 at 11:37:19 UTC, Christophe Leroy wrote: > arch_early_irq_init() does nothing different than > the weak arch_early_irq_init() in kernel/softirq.c > > Fixes: 089fb442f301 ("powerpc: Use ARCH_IRQ_INIT_FLAGS") > Cc: Thomas Gleixner > Signed-off-by: Christophe Leroy > Acked-by:

Re: [1/2] powerpc: wii.dts: Add interrupt-related properties to GPIO node

2019-01-23 Thread Michael Ellerman
On Sat, 2019-01-12 at 16:21:23 UTC, =?utf-8?q?Jonathan_Neusch=C3=A4fer?= wrote: > The Hollywood GPIO controller is connected to the Hollywood PIC () > at IRQs 10 and 11; IRQ 10 for GPIO lines that are configured for access > by the PPC, 11 for GPIO lines that are configured for access by the >

[PATCH v3 2/2] dt-bindings: interrupt-controller: loongson ls1x intc

2019-01-23 Thread Jiaxun Yang
Dt-bindings doc about Loongson-1 interrupt controller Signed-off-by: Jiaxun Yang --- .../loongson,ls1x-intc.txt| 24 +++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt diff

[PATCH v3 1/2] irqchip: Add driver for Loongson-1 interrupt controller

2019-01-23 Thread Jiaxun Yang
This controller appeared on Loongson-1 family MCUs including Loongson-1B and Loongson-1C. Signed-off-by: Jiaxun Yang --- drivers/irqchip/Kconfig| 9 ++ drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-ls1x.c | 176 + 3 files changed, 186

irqchip: Add driver for Loongson-1 intc v3

2019-01-23 Thread Jiaxun Yang
v1->v2: Fix SPDX-License-Identifier v2->v3: Rework according suggestions from Marc Zyngier, Thanks.

Re: [PATCH] iommu/amd: Fix IOMMU page flush when detach all devices from a domain

2019-01-23 Thread Suthikulpanit, Suravee
Joerg, On 1/23/19 2:56 PM, j...@8bytes.org wrote: > Hi Suravee, > > On Tue, Jan 22, 2019 at 03:53:18PM +, Suthikulpanit, Suravee wrote: >> Thanks for the detail. Alright then, let's just go with the version you >> sent on 1/16/19. Do you want me to resend V3 with that changes, or >> would

Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-23 Thread Marek Vasut
On 1/24/19 3:23 AM, masonccy...@mxic.com.tw wrote: > Hi Marek, Hi, >> "Marek Vasut" >> 2019/01/24 上午 09:54 >> >> >> > +#define RPC_CMNCR      0x   // R/W >> >> Is there any reason for using those horrible C++ comments ? > > By Mark's comments for the SPDX header needs to be C++ style and >

Re: [PATCH V2 rdma-next 2/3] RDMA/hns: Fix the chip hanging caused by sending mailbox during reset

2019-01-23 Thread Wei Hu (Xavier)
On 2019/1/24 6:40, Jason Gunthorpe wrote: > On Sat, Jan 19, 2019 at 11:36:06AM +0800, Wei Hu (Xavier) wrote: > >> +static int hns_roce_v2_cmd_hw_resetting(struct hns_roce_dev *hr_dev, >> +unsigned long instance_stage, >> +

Re: [PATCH -next] usb: host: drop pointless static qualifier

2019-01-23 Thread YueHaibing
On 2019/1/24 0:09, Alan Stern wrote: > On Wed, 23 Jan 2019, YueHaibing wrote: > >> There is no need to have the 'dummy_mask' variable static since new >> value always be assigned before use it. >> >> Signed-off-by: YueHaibing >> --- >> drivers/usb/host/ehci-ps3.c | 2 +- >>

[v2 PATCH] rhashtable: Still do rehash when we get EEXIST

2019-01-23 Thread Herbert Xu
On Wed, Jan 23, 2019 at 01:17:58PM -0800, Josh Elsasser wrote: > When running workloads with large bursts of fragmented packets, we've seen > a few machines stuck returning -EEXIST from rht_shrink() and endlessly > rescheduling their hash table's deferred work, pegging a CPU core. > > Root cause

Re: [PATCH v2 1/3] tracing: uprobes: Re-enable $comm support for uprobe events

2019-01-23 Thread Masami Hiramatsu
On Wed, 23 Jan 2019 21:09:56 -0500 Steven Rostedt wrote: > On Thu, 24 Jan 2019 10:43:22 +0900 > Masami Hiramatsu wrote: > > > > > kernel/trace/trace_uprobe.c | 15 +-- > > > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > > > > > diff --git

[PATCH v7 6/6] usb: gadget: uvc: allow ioctl to send response in status stage

2019-01-23 Thread Paul Elder
We now have a mechanism to signal the UDC driver to reply to a control OUT request with STALL or ACK, and we have packaged the setup stage data and the data stage data of a control OUT request into a single UVC_EVENT_DATA for userspace to consume. After telling the UDC to delay the status stage,

[PATCH v7 3/6] usb: gadget: uvc: package setup and data for control OUT requests

2019-01-23 Thread Paul Elder
Since "usb: gadget: uvc: enqueue uvc_request_data in setup handler for control OUT requests" it is no longer necessary for userspace to call ioctl UVCIOC_SEND_RESPONSE in response to receiving a UVC_EVENT_SETUP from the uvc function driver for a control OUT request. This change means that for

[PATCH v7 5/6] usb: musb: gadget: implement optional explicit status stage

2019-01-23 Thread Paul Elder
Implement the mechanism for optional explicit status stage for the MUSB driver. This allows a function driver to specify what to reply for the status stage. The functionality for an implicit status stage is retained. Signed-off-by: Paul Elder v1 Reviewed-by: Laurent Pinchart v1 Acked-by: Bin

[PATCH v7 1/6] usb: uvc: include videodev2.h in g_uvc.h

2019-01-23 Thread Paul Elder
V4L2_EVENT_PRIVATE_START is used in g_uvc.h but is defined in videodev2.h, which is not included and causes a compiler warning: linux/usb/g_uvc.h:15:28: error: ‘V4L2_EVENT_PRIVATE_START’ undeclared here (not in a function) #define UVC_EVENT_FIRST (V4L2_EVENT_PRIVATE_START + 0) Include

[PATCH v7 0/6] usb: gadget: add mechanism to asynchronously validate data stage of ctrl OUT request

2019-01-23 Thread Paul Elder
This patch series adds a mechanism to allow asynchronously validating the data stage of a control OUT request, and for stalling or suceeding the request accordingly. This mechanism is implemented for MUSB, and is used by UVC. At the same time, UVC packages the setup stage and data stage data

[PATCH v7 4/6] usb: gadget: add mechanism to specify an explicit status stage

2019-01-23 Thread Paul Elder
A usb gadget function driver may or may not want to delay the status stage of a control OUT request. An instance where it might want to is to asynchronously validate the data of a class-specific request. A function driver that wants an explicit status stage should set the newly added

[PATCH v7 2/6] usb: gadget: uvc: enqueue usb request in setup handler for control OUT

2019-01-23 Thread Paul Elder
Currently, for uvc class-specific control IN and OUT requests, in the setup handler a UVC_EVENT_SETUP with the setup control is enqueued to userspace. In response to this, the uvc function driver expects userspace to call ioctl UVCIOC_SEND_RESPONSE containing uvc request data. In the case of

[PATCH 2/2] proc: code cleanup for proc_setup_thread_self()

2019-01-23 Thread Chengguang Xu
Remove unnecessary ERR_PTR()/PTR_ERR() cast in proc_setup_thread_self(). Signed-off-by: Chengguang Xu --- fs/proc/thread_self.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/proc/thread_self.c b/fs/proc/thread_self.c index b905010ca9eb..f61ae53533f5

[PATCH 1/2] proc: code cleanup for proc_setup_self()

2019-01-23 Thread Chengguang Xu
Remove unnecessary ERR_PTR()/PTR_ERR() cast in proc_setup_self(). Signed-off-by: Chengguang Xu --- fs/proc/self.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/proc/self.c b/fs/proc/self.c index 127265e5c55f..57c0a1047250 100644 --- a/fs/proc/self.c +++

devicetree: media: Documentation of Bt.656 Bus DT bindings

2019-01-23 Thread Ken Sloat
There are a number of v4l2 subdevices in the kernel that support a Bt.656 bus also known as "embedded sync." Previously in older versions of the kernel (and in the current 4.14 LTS kernel), the standard way to enable this in device tree on a parallel bus was to simply omit all hysync and vsync

Re: [PATCH] tipc: remove dead code in struct tipc_topsrv

2019-01-23 Thread Ying Xue
On 1/24/19 10:06 AM, Zhaolong Zhang wrote: > max_rcvbuf_size is no longer used since commit "414574a0af36". > > Signed-off-by: Zhaolong Zhang Acked-by: Ying Xue > --- > net/tipc/topsrv.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/net/tipc/topsrv.c b/net/tipc/topsrv.c > index

Re: [PATCH v5 4/6] usb: gadget: add mechanism to specify an explicit status stage

2019-01-23 Thread Paul Elder
On Wed, Jan 23, 2019 at 04:10:12PM -0500, Alan Stern wrote: > On Mon, 14 Jan 2019, Paul Elder wrote: > > > On Fri, Jan 11, 2019 at 10:50:11AM -0500, Alan Stern wrote: > > > On Fri, 11 Jan 2019, Paul Elder wrote: > > > > > > > On Wed, Jan 09, 2019 at 02:06:31PM -0500, Alan Stern wrote: > > > > >

RE: [PATCH V1] i2c: tegra: Add DMA Support

2019-01-23 Thread Sowjanya Komatineni
> > This patch adds DMA support for Tegra I2C. > > In the subject: "Support" -> "support". And in the commit description perhaps > add some more details about why this is useful, maybe accompany with some > performance numbers (if > you can come up with any) or describe why there's a >

[PATCH ghak103 V1] audit: add support for fcaps v3

2019-01-23 Thread Richard Guy Briggs
V3 namespaced file capabilities were introduced in commit 8db6c34f1dbc ("Introduce v3 namespaced file capabilities") Add support for these by adding the "frootid" field to the existing fcaps fields in the NAME and BPRM_FCAPS records. Please see github issue

[PATCH 1/1] iommu/vt-d: Leave scalable mode default off

2019-01-23 Thread Lu Baolu
Commit 765b6a98c1de3 ("iommu/vt-d: Enumerate the scalable mode capability") enables VT-d scalable mode if hardware advertises the capability. As we will bring up different features and use cases to upstream in different patch series, it will leave some intermediate kernel versions which support

Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-23 Thread Guo Ren
On Wed, Jan 23, 2019 at 06:00:35PM -0800, Palmer Dabbelt wrote: > On Tue, 15 Jan 2019 17:07:38 PST (-0800), guo...@kernel.org wrote: > >Hi Christoph, > > > >I use PFN_DOWN() every where as possible and seems it's a habit > >problem. So let risc-v maintainer to choose "PFN_DOW()" or > >">>

Re: [RFC] Provide in-kernel headers for making it easy to extend the kernel

2019-01-23 Thread Joel Fernandes
On Wed, Jan 23, 2019 at 02:37:47PM -0800, Daniel Colascione wrote: > On Wed, Jan 23, 2019 at 1:29 PM Karim Yaghmour > wrote: [...] > > Personally I advocated a more aggressive approach with Joel in private: > > just put the darn headers straight into the kernel image, it's the > > *only* artifact

linux-next: manual merge of the spi tree with the mips tree

2019-01-23 Thread Stephen Rothwell
Hi Mark, Today's linux-next merge of the spi tree got a conflict in: arch/mips/ath79/dev-spi.h between commit: 85b9686dae30 ("MIPS: ath79: drop platform device registration code") from the mips tree and commit: b172fd0c8980 ("spi: ath79: Enable support for compile test") from the spi

Re: [PATCH 2/2] debugfs: return error values, not NULL

2019-01-23 Thread Masami Hiramatsu
On Wed, 23 Jan 2019 11:28:14 +0100 Greg Kroah-Hartman wrote: > When an error happens, debugfs should return an error pointer value, not > NULL. This will prevent the totally theoretical error where a debugfs > call fails due to lack of memory, returning NULL, and that dentry value > is then

Re: [PATCH] netfilter: nat: Update comment of get_unique_tuple

2019-01-23 Thread YueHaibing
ping... On 2019/1/10 21:06, YueHaibing wrote: > Replace outdated __ip_conntrack_confirm in comment. > > Signed-off-by: YueHaibing > --- > net/netfilter/nf_nat_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/netfilter/nf_nat_core.c

Re: [PATCH v2] x86/gart/kcore: Exclude GART aperture from kcore

2019-01-23 Thread Baoquan He
On 01/23/19 at 10:50pm, Kairui Song wrote: > > > int fix_aperture __initdata = 1; > > > > > > -#ifdef CONFIG_PROC_VMCORE > > > +#if defined(CONFIG_PROC_VMCORE) || defined(CONFIG_PROC_KCORE) > > > /* > > > * If the first kernel maps the aperture over e820 RAM, the kdump kernel > > > will > > >

[PATCH] tipc: remove dead code in struct tipc_topsrv

2019-01-23 Thread Zhaolong Zhang
max_rcvbuf_size is no longer used since commit "414574a0af36". Signed-off-by: Zhaolong Zhang --- net/tipc/topsrv.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/tipc/topsrv.c b/net/tipc/topsrv.c index efb16f6..4b1c083 100644 --- a/net/tipc/topsrv.c +++ b/net/tipc/topsrv.c @@ -60,7

Re: [PATCH v2 1/3] tracing: uprobes: Re-enable $comm support for uprobe events

2019-01-23 Thread Steven Rostedt
On Thu, 24 Jan 2019 10:43:22 +0900 Masami Hiramatsu wrote: > > > kernel/trace/trace_uprobe.c | 15 +-- > > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > > > index 3a1d5ab6b4ba..b07e498ccbc6

Re: [PATCH V2] drivers: extcon: Add support for ptn5150

2019-01-23 Thread Chanwoo Choi
Hi Vijai, Looks good to me. But, there are minor modification by myself as following: After fixed them, applied it to extcon-next. Thanks. - PTN5150A -> PTN5150 because this patch usually used the 'ptn5150' word without 'A'. - Modify the patch subject to keep the same format of extcon drivers

Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-23 Thread Palmer Dabbelt
On Tue, 15 Jan 2019 17:07:38 PST (-0800), guo...@kernel.org wrote: Hi Christoph, I use PFN_DOWN() every where as possible and seems it's a habit problem. So let risc-v maintainer to choose "PFN_DOW()" or ">> PAGE_SHIFT". Also the same with "end_of_DRAM & max_low_pfn". PFN_DOWN makes sense to

Re: [PATCH v7 2/2] dt-bindings: spi: Document Renesas R-Car Gen3 RPC-IF controller bindings

2019-01-23 Thread Marek Vasut
On 1/23/19 8:09 AM, Mason Yang wrote: > Document the bindings used by the Renesas R-Car Gen3 RPC-IF controller. > > Signed-off-by: Mason Yang > --- > .../devicetree/bindings/spi/spi-renesas-rpc.txt| 46 > ++ > 1 file changed, 46 insertions(+) > create mode 100644

Re: [PATCH RFC] iw_cxgb4: drop check - dead code

2019-01-23 Thread Nicholas Mc Guire
On Wed, Jan 23, 2019 at 12:45:11PM -0600, Steve Wise wrote: > > > On 1/23/2019 12:30 PM, Jason Gunthorpe wrote: > > On Sun, Jan 20, 2019 at 02:27:13AM +0100, Nicholas Mc Guire wrote: > >> The kmalloc is called with | __GFP_NOFAIL so there is no point in > >> checking the return value - it

Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-23 Thread Marek Vasut
On 1/23/19 8:09 AM, Mason Yang wrote: > Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. > > Signed-off-by: Mason Yang > Signed-off-by: Sergei Shtylyov [...] > +#define RPC_CMNCR0x // R/W Is there any reason for using those horrible C++ comments ? [...] >

Re: possible deadlock in __do_page_fault

2019-01-23 Thread Tetsuo Handa
Joel Fernandes wrote: > > Anyway, I need your checks regarding whether this approach is waiting for > > completion at all locations which need to wait for completion. > > I think you are waiting in unwanted locations. The only location you need to > wait in is ashmem_pin_unpin. > > So, to my

[PATCH V4] livepatch: non static warnings fix

2019-01-23 Thread Nicholas Mc Guire
rmmod livepatch-shadow-mod and dmesg output compared to previous run. Patch is against 5.0-rc3 (localversion-next is next-20190123) samples/livepatch/livepatch-shadow-fix1.c | 4 ++-- samples/livepatch/livepatch-shadow-fix2.c | 4 ++-- samples/livepatch/livepatch-shadow-mod.c | 11 ++- 3

[PATCH] mm: Proportional memory.{low,min} reclaim

2019-01-23 Thread Chris Down
cgroup v2 introduces two memory protection thresholds: memory.low (best-effort) and memory.min (hard protection). While they generally do what they say on the tin, there is a limitation in their implementation that makes them difficult to use effectively: that cliff behaviour often manifests when

Re: [PATCH v2 1/3] tracing: uprobes: Re-enable $comm support for uprobe events

2019-01-23 Thread Masami Hiramatsu
On Wed, 23 Jan 2019 03:40:05 -0500 Steven Rostedt wrote: > On Fri, 18 Jan 2019 13:44:25 +0900 > Masami Hiramatsu wrote: > > > Since commit 533059281ee5 ("tracing: probeevent: Introduce new > > argument fetching code") dropped the $comm support from uprobe > > events, this re-enables it. > > >

[RESEND PATCH] char/rtc: fix object reference leaks in rtc_init

2019-01-23 Thread Wen Yang
The device node iterators perform an of_node_get on each iteration, so a jump out of the loop requires an of_node_put. The of_find_device_by_node() takes a reference to the underlying device structure, we also should release that reference. This patch fixes those 2 issues. Fixes: 75081322c

Re: [PATCH v9 0/4] Media Device Allocator API

2019-01-23 Thread shuah
On 1/21/19 7:46 AM, Hans Verkuil wrote: Hi Shuah, On 12/18/2018 06:59 PM, sh...@kernel.org wrote: From: Shuah Khan Media Device Allocator API to allows multiple drivers share a media device. This API solves a very common use-case for media devices where one physical device (an USB stick)

Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support

2019-01-23 Thread Evan Green
On Mon, Jan 21, 2019 at 10:34 PM Alok Chauhan wrote: > > Get the interconnect paths for SPI based Serial Engine device > and vote accordingly based on maximum supported SPI frequency. > > Signed-off-by: Alok Chauhan > --- > drivers/spi/spi-geni-qcom.c | 20 +++- > 1 file

Re: [PATCH 3/6] i2c: i2c-qcom-geni: Add interconnect support

2019-01-23 Thread Evan Green
On Mon, Jan 21, 2019 at 10:34 PM Alok Chauhan wrote: > > Get the interconnect paths for I2C based Serial Engine device > and vote accordingly based on maximum supported I2C frequency. > > Signed-off-by: Alok Chauhan > --- > drivers/i2c/busses/i2c-qcom-geni.c | 13 + > 1 file

Re: [PATCH 1/6] dt-bindings: soc: qcom: Add interconnect binding for GENI QUP

2019-01-23 Thread Evan Green
On Mon, Jan 21, 2019 at 10:34 PM Alok Chauhan wrote: > > Add documentation for the interconnect and interconnect-names bindings > for the GENI QUP as detailed by bindings/interconnect/interconnect.txt. > > Signed-off-by: Alok Chauhan > --- >

Re: [RFC PATCH] kvm: x86/vmx: Use kzalloc for cached_vmcs12

2019-01-23 Thread Paolo Bonzini
On 23/01/19 19:33, Tom Roeder wrote: > > Even in vmx_set_nested_state, there are about 30 lines of code in > between enter_vmx_operation and copy_from_user, and there are a couple > of cases that cause vmx_set_nested_state to return with an error. So if > we want to fix this by handling all the

Re: [RFC PATCH] kvm: x86/vmx: Use kzalloc for cached_vmcs12

2019-01-23 Thread Paolo Bonzini
On 23/01/19 19:25, Tom Roeder wrote: > On Tue, Jan 15, 2019 at 11:15:51AM +0100, Paolo Bonzini wrote: >> On 15/01/19 03:43, Sean Christopherson wrote: - vmx->nested.cached_vmcs12 = kmalloc(VMCS12_SIZE, GFP_KERNEL); + vmx->nested.cached_vmcs12 = kzalloc(VMCS12_SIZE, GFP_KERNEL);

Re: [PATCH v13 00/10] powerpc: Switch to CONFIG_THREAD_INFO_IN_TASK

2019-01-23 Thread Michael Ellerman
Christophe Leroy writes: > Le 19/01/2019 à 11:23, Michael Ellerman a écrit : >> Christophe Leroy writes: >> >>> The purpose of this serie is to activate CONFIG_THREAD_INFO_IN_TASK which >>> moves the thread_info into task_struct. >>> >>> Moving thread_info into task_struct has the following

Re: [PATCH v13 00/10] powerpc: Switch to CONFIG_THREAD_INFO_IN_TASK

2019-01-23 Thread Michael Ellerman
Christophe Leroy writes: > Le 12/01/2019 à 10:55, Christophe Leroy a écrit : >> The purpose of this serie is to activate CONFIG_THREAD_INFO_IN_TASK which >> moves the thread_info into task_struct. >> >> Moving thread_info into task_struct has the following advantages: >> - It protects

Re: [PATCH 1/2] mm: Rename ambiguously named memory.stat counters and functions

2019-01-23 Thread Chris Down
Roman Gushchin writes: I'd personally go with memcg_vmstat_percpu. Not insisting, but you end up using both vmstat and vmstats, which isn't very consistent. Yeah, we also have similar naming in accumulated_vmstats. Hmm, let me think about this a bit and get back to you tomorrow. The main bit

Re: [PATCH 00/15] Habana Labs kernel driver

2019-01-23 Thread Andrew Donnellan
On 24/1/19 8:52 am, Olof Johansson wrote: But, I think the largest question I have (for a broader audience) is: I predict that we will see a handful of these kind of devices over the upcoming future -- definitely from ML accelerators but maybe also for other kinds of processing, where there's a

Re: [PATCH 2/2] mm: Consider subtrees in memory.events

2019-01-23 Thread Chris Down
Roman Gushchin writes: On Wed, Jan 23, 2019 at 05:31:44PM -0500, Chris Down wrote: memory.stat and other files already consider subtrees in their output, and we should too in order to not present an inconsistent interface. The current situation is fairly confusing, because people interacting

Re: [PATCH net-next 03/10] net: macsec: move some definitions in a dedicated header

2019-01-23 Thread David Miller
From: Florian Fainelli Date: Wed, 23 Jan 2019 12:11:37 -0800 > On 1/23/19 7:56 AM, Antoine Tenart wrote: >> This patch moves some structure, type and identifier definitions into a >> MACsec specific header. This patch does not modify how the MACsec code >> is running and only move things around.

[PATCH 4/6] perf script python: remove explicit shebang from tests/attr.c

2019-01-23 Thread Tony Jones
tests/attr.c invokes attr.py via an explicit invocation of Python ($PYTHON) so there is therefore no need for an explicit shebang. Also most distros follow pep-0394 which recommends that /usr/bin/python refer only to v2 and so may not exist on the system (if PYTHON=python3). Signed-off-By: Tony

[PATCH 6/6] perf script python: add Python3 support to tests/attr.py

2019-01-23 Thread Tony Jones
Support both Python 2 and Python 3 in tests/attr.py The use of "except as" syntax implies the minimum supported Python2 version is now v2.6 Signed-off-By: Tony Jones Cc: Jiri Olsa --- tools/perf/tests/attr.py | 32 +++- 1 file changed, 19 insertions(+), 13

[PATCH 3/6] perf script python: remove explicit shebang from setup.py

2019-01-23 Thread Tony Jones
Makefile.perf invokes setup.py via an explicit invocation of python (PYTHON_WORD) so there is therefore no need for an explicit shebang. Also most distros follow pep-0394 which recommends that /usr/bin/python refer only to v2 and so may not exist on the system (if PYTHON=python3). Signed-off-By:

[PATCH 5/6] perf script python: remove explicit shebang from Python scripts

2019-01-23 Thread Tony Jones
The scripts in scripts/python are intended to be run from 'perf script' and the Python version used is dictated by how perf was built (PYTHON=). Also most distros follow pep-0394 which recommends that /usr/bin/python refer to Python2 and so may not exist on the system (if PYTHON=python3). -

[PATCH 1/6] perf script python: Add trace_context extension module to sys,modules

2019-01-23 Thread Tony Jones
In Python3, the result of PyModule_Create (called from scripts/python/Perf-Trace-Util/Context.c) is not automatically added to sys.modules. See: https://bugs.python.org/issue4592 Below is the observed behavior without the fix: # ldd /usr/bin/perf | grep -i python libpython3.6m.so.1.0

[PATCH 0/6] Fix issues with Python3 scripting

2019-01-23 Thread Tony Jones
Seeteena posted, earlier this week, some patches to add Python3 support to scripts/python/*.py. Unfortunately there were some issues with these patches (such as: https://lkml.org/lkml/2019/1/17/351) Since I already had a tested set of patches in openSUSE:Factory and SLE15-SP1 and was about to

[PATCH 2/6] perf script python: Use PyBytes for attr in trace-event-python

2019-01-23 Thread Tony Jones
With Python3. PyUnicode_FromStringAndSize is unsafe to call on attr and will return NULL. Use _PyBytes_FromStringAndSize (as with raw_buf). Below is the observed behavior without the fix. Note it is first necessary to apply the prior fix (Add trace_context extension module to sys,modules): #

Re: [PATCH] RISC-V: Add _TIF_NEED_RESCHED check for kernel thread when CONFIG_PREEMPT=y

2019-01-23 Thread Vincent Chen
On Wed, Jan 23, 2019 at 02:58:51AM +0800, Palmer Dabbelt wrote: > On Wed, 02 Jan 2019 21:45:55 PST (-0800), li...@roeck-us.net wrote: > > On Thu, Jan 03, 2019 at 11:32:33AM +0800, Vincent Chen wrote: > >> The cond_resched() can be used to yield the CPU resource if > >> CONFIG_PREEMPT is not

Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-23 Thread Dominique Martinet
Linus Torvalds wrote on Thu, Jan 24, 2019: > I've reverted the 'let's try to just remove the code' part in my tree. > But I didn't apply the two other patches yet. Any final comments > before that should happen? I mentionned when sending the updated version that just checking file permission

Re: [PATCH 2/2] mm: Consider subtrees in memory.events

2019-01-23 Thread Roman Gushchin
On Wed, Jan 23, 2019 at 05:31:44PM -0500, Chris Down wrote: > memory.stat and other files already consider subtrees in their output, > and we should too in order to not present an inconsistent interface. > > The current situation is fairly confusing, because people interacting > with cgroups

Re: [v2 PATCH] mm: ksm: do not block on page lock when searching stable tree

2019-01-23 Thread John Hubbard
On 1/23/19 3:52 PM, Yang Shi wrote: > ksmd need search stable tree to look for the suitable KSM page, but the > KSM page might be locked for a while due to i.e. KSM page rmap walk. > Basically it is not a big deal since commit 2c653d0ee2ae > ("ksm: introduce ksm_max_page_sharing per page

Re: [PATCH v6 0/8] perf cs-etm: Add support for sample flags

2019-01-23 Thread Mathieu Poirier
On Fri, 18 Jan 2019 at 18:44, Leo Yan wrote: > > This patch seris adds support for sample flags so can facilitate perf > to print sample flags for branch instruction. > > Patch 0001 is used to save last branch information in packet structure, > this includes instruction type, subtype and

Re: [PATCH V3] livepatch: non static warnings fix

2019-01-23 Thread Nicholas Mc Guire
On Wed, Jan 23, 2019 at 03:30:57PM +0100, Miroslav Benes wrote: > Hi, > > On Wed, 23 Jan 2019, Nicholas Mc Guire wrote: > > > Sparse reported warnings about non-static symbols. For the variables > > a simple static attribute is fine - for the functions referenced by > > livepatch via klp_func

Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-23 Thread Linus Torvalds
On Thu, Jan 24, 2019 at 12:12 PM Jiri Kosina wrote: > > > > > I think the "test vm_file" thing may be unnecessary, because a > > non-anonymous mapping should always have a file pointer and an inode. > > But I could imagine some odd case (vdso mapping, anyone?) that > > doesn't have a vm_file,

Re: Regression in Linux next with SPI pump changes

2019-01-23 Thread Tony Lindgren
* Tony Lindgren [190123 21:57]: > Hi all, > > Commit 412e60373245 ("spi: core: avoid waking pump thread from spi_sync > instead run teardown delayed") caused a PM regression in Linux next > where a SPI device (drivers/spi/spi-omap2-mcspi.c) no longer idles > for PM runtime. > > Looks like this

Re: [PATCH v4 0/9] mmu notifier provide context informations

2019-01-23 Thread Dan Williams
On Wed, Jan 23, 2019 at 3:05 PM Jerome Glisse wrote: > > On Wed, Jan 23, 2019 at 02:54:40PM -0800, Dan Williams wrote: > > On Wed, Jan 23, 2019 at 2:23 PM wrote: > > > > > > From: Jérôme Glisse > > > > > > Hi Andrew, i see that you still have my event patch in you queue [1]. > > > This patchset

Re: [PATCH 1/2] mm: Rename ambiguously named memory.stat counters and functions

2019-01-23 Thread Roman Gushchin
On Wed, Jan 23, 2019 at 05:30:49PM -0500, Chris Down wrote: > I spent literally an hour trying to work out why an earlier version of > my memory.events aggregation code doesn't work properly, only to find > out I was calling memcg->events instead of memcg->memory_events, which > is fairly

Re: [PATCH] tty/serial: use uart_console_write in the RISC-V SBL early console

2019-01-23 Thread Palmer Dabbelt
On Fri, 11 Jan 2019 03:13:30 PST (-0800), a...@brainfault.org wrote: On Thu, Jan 10, 2019 at 10:41 PM Andreas Schwab wrote: This enables proper NLCR processing. Suggested-by: Anup Patel Signed-off-by: Andreas Schwab --- drivers/tty/serial/earlycon-riscv-sbi.c | 13 - 1 file

[v2 PATCH] mm: ksm: do not block on page lock when searching stable tree

2019-01-23 Thread Yang Shi
ksmd need search stable tree to look for the suitable KSM page, but the KSM page might be locked for a while due to i.e. KSM page rmap walk. Basically it is not a big deal since commit 2c653d0ee2ae ("ksm: introduce ksm_max_page_sharing per page deduplication limit"), since max_page_sharing limits

Re: [PATCH 00/15] Habana Labs kernel driver

2019-01-23 Thread Jerome Glisse
On Wed, Jan 23, 2019 at 03:40:25PM -0800, Olof Johansson wrote: > On Wed, Jan 23, 2019 at 3:20 PM Jerome Glisse wrote: > > > > On Wed, Jan 23, 2019 at 03:04:33PM -0800, Olof Johansson wrote: > > > On Wed, Jan 23, 2019 at 2:45 PM Dave Airlie wrote: > > > > > > > > On Thu, 24 Jan 2019 at 08:32,

linux-next: build warning after merge of the pm tree

2019-01-23 Thread Stephen Rothwell
Hi Rafael, After merging the pm tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/acpi/acpi_dbg.c: In function 'acpi_aml_init': drivers/acpi/acpi_dbg.c:774:1: warning: label 'err_exit' defined but not used [-Wunused-label] err_exit: ^~~~ Introduced by

Re: [PATCH v6 5/8] perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata

2019-01-23 Thread Leo Yan
On Wed, Jan 23, 2019 at 02:13:00PM -0700, Mathieu Poirier wrote: > On Sat, Jan 19, 2019 at 09:43:44AM +0800, Leo Yan wrote: > > If packet processing wants to know the packet is bound with which ETM > > version, it needs to access metadata to decide that based on metadata > > magic number; but we

Re: [Xen-devel] [RFC] virtio_ring: check dma_mem for xen_domain

2019-01-23 Thread Stefano Stabellini
On Wed, 23 Jan 2019, h...@infradead.org wrote: > On Wed, Jan 23, 2019 at 01:04:33PM -0800, Stefano Stabellini wrote: > > If vring_use_dma_api is actually supposed to return true when > > dma_dev->dma_mem is set, then both Peng's patch and the patch I wrote > > are not fixing the real issue here. >

Re: [PATCH 00/15] Habana Labs kernel driver

2019-01-23 Thread Olof Johansson
On Wed, Jan 23, 2019 at 3:35 PM Oded Gabbay wrote: > > On Thu, Jan 24, 2019 at 1:20 AM Jerome Glisse wrote: > > > > On Wed, Jan 23, 2019 at 03:04:33PM -0800, Olof Johansson wrote: > > > On Wed, Jan 23, 2019 at 2:45 PM Dave Airlie wrote: > > > > > > > > On Thu, 24 Jan 2019 at 08:32, Oded Gabbay

Re: [PATCH 00/15] Habana Labs kernel driver

2019-01-23 Thread Olof Johansson
On Wed, Jan 23, 2019 at 3:20 PM Jerome Glisse wrote: > > On Wed, Jan 23, 2019 at 03:04:33PM -0800, Olof Johansson wrote: > > On Wed, Jan 23, 2019 at 2:45 PM Dave Airlie wrote: > > > > > > On Thu, 24 Jan 2019 at 08:32, Oded Gabbay wrote: > > > > > > > > On Thu, Jan 24, 2019 at 12:02 AM Dave

Re: [PATCH v6 8/8] perf cs-etm: Set sample flags for exception return packet

2019-01-23 Thread Leo Yan
Hi Mathieu, On Wed, Jan 23, 2019 at 02:51:14PM -0700, Mathieu Poirier wrote: > On Sat, Jan 19, 2019 at 09:43:47AM +0800, Leo Yan wrote: > > When return from exception, we need to distinguish if it's system call > > return or for other type exceptions for setting sample flags. Due to > > the

Re: [PATCH v3 1/2] mm, oom: fix use-after-free in oom_kill_process

2019-01-23 Thread Tetsuo Handa
Shakeel Butt wrote: > > How should we proceed with this patch? > > > > We do want to backport this patch to stable kernels. However shouldn't > we wait for this patch to be applied to Linus's tree first. > But since Andrew Morton seems to be offline since Jan 11, we don't know when this patch

Re: [PATCH 00/15] Habana Labs kernel driver

2019-01-23 Thread Oded Gabbay
On Thu, Jan 24, 2019 at 1:20 AM Jerome Glisse wrote: > > On Wed, Jan 23, 2019 at 03:04:33PM -0800, Olof Johansson wrote: > > On Wed, Jan 23, 2019 at 2:45 PM Dave Airlie wrote: > > > > > > On Thu, 24 Jan 2019 at 08:32, Oded Gabbay wrote: > > > > > > > > On Thu, Jan 24, 2019 at 12:02 AM Dave

Re: tsc: Fast TSC calibration failed with sever AMD Ryzen processor (2200G, 2400G, Ryzen 7 1700)

2019-01-23 Thread Lendacky, Thomas
On 1/23/19 6:56 AM, Paul Menzel wrote: > Dear Tom, > > > On 01/22/19 21:24, Lendacky, Thomas wrote: >> On 1/22/19 10:53 AM, Paul Menzel wrote: >>> [Adding Tom to CC] > >>> On 01/14/19 11:09, Paul Menzel wrote: >>> On 01/11/19 21:43, Thomas Gleixner wrote: > On Mon, 7 Jan 2019,

Re: [PATCH v3 03/10] arm64: dts: sdm845: Introduce ADSP and CDSP PAS nodes

2019-01-23 Thread Doug Anderson
Hi, On Tue, Jan 22, 2019 at 5:09 PM Bjorn Andersson wrote: > > On Tue 22 Jan 16:40 PST 2019, Doug Anderson wrote: > > > Hi, > > > > On Tue, Jan 22, 2019 at 4:26 PM Bjorn Andersson > > wrote: > > > > > + clocks = <_board>; > > > > > + clock-names = "xo"; > > > > > > >

Re: [PATCH 00/15] Habana Labs kernel driver

2019-01-23 Thread Oded Gabbay
On Thu, Jan 24, 2019 at 1:04 AM Olof Johansson wrote: > > On Wed, Jan 23, 2019 at 2:45 PM Dave Airlie wrote: > > > > On Thu, 24 Jan 2019 at 08:32, Oded Gabbay wrote: > > > > > > On Thu, Jan 24, 2019 at 12:02 AM Dave Airlie wrote: > > > > > > > > Adding Daniel as well. > > > > > > > > Dave. > >

Re: [PATCH 00/15] Habana Labs kernel driver

2019-01-23 Thread Jerome Glisse
On Wed, Jan 23, 2019 at 03:04:33PM -0800, Olof Johansson wrote: > On Wed, Jan 23, 2019 at 2:45 PM Dave Airlie wrote: > > > > On Thu, 24 Jan 2019 at 08:32, Oded Gabbay wrote: > > > > > > On Thu, Jan 24, 2019 at 12:02 AM Dave Airlie wrote: > > > > > > > > Adding Daniel as well. > > > > > > > >

Re: [PATCH 00/15] Habana Labs kernel driver

2019-01-23 Thread Olof Johansson
On Wed, Jan 23, 2019 at 2:41 PM Oded Gabbay wrote: > > On Wed, Jan 23, 2019 at 11:52 PM Olof Johansson wrote: > > > > Hi, > > > > On Tue, Jan 22, 2019 at 4:01 PM Oded Gabbay wrote: > > > > > > Hello, > > > > > > For those who don't know me, my name is Oded Gabbay (Kernel Maintainer > > > for

Re: [PATCH v3 1/2] mm, oom: fix use-after-free in oom_kill_process

2019-01-23 Thread Shakeel Butt
On Wed, Jan 23, 2019 at 2:57 PM Sasha Levin wrote: > > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 6b0c81b3be11 mm, oom: reduce dependency on tasklist_lock. > > The bot has tested the following trees: v4.20.3,

Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-23 Thread Jiri Kosina
On Thu, 24 Jan 2019, Linus Torvalds wrote: > Side note: the inode_permission() addition to can_do_mincore() in that > patch 0002, seems to be questionable. We do > > +static inline bool can_do_mincore(struct vm_area_struct *vma) > +{ > + return vma_is_anonymous(vma) > + ||

[PATCH] perf tools api fs: make xxx__mountpoint() more scalable

2019-01-23 Thread Stephane Eranian
The xxx_mountpoint() interface provided by fs.c finds mount points for common pseudo filesystems. The first time xxx_mountpoint() is invoked, it scans the mount table (/proc/mounts) looking for a match. If found, it is cached. The price to scan /proc/mounts is paid once if the mount is found.

Re: [PATCH v13 00/10] powerpc: Switch to CONFIG_THREAD_INFO_IN_TASK

2019-01-23 Thread Michael Ellerman
LEROY Christophe writes: > Michael Ellerman a écrit : > >> Christophe Leroy writes: >> >>> The purpose of this serie is to activate CONFIG_THREAD_INFO_IN_TASK which >>> moves the thread_info into task_struct. >>> >>> Moving thread_info into task_struct has the following advantages: >>> - It

Re: [PATCH kernel] vfio-pci/nvlink2: Fix ancient gcc warnings

2019-01-23 Thread Michael Ellerman
Geert Uytterhoeven writes: > Hi Alex, > > On Wed, Jan 23, 2019 at 5:30 AM Alex Williamson > wrote: >> The below patch comes about from the build regressions and improvements >> list you've sent out, but something doesn't add up that we'd be testing >> with an old compiler where initialization

[PATCH 2/2] ARM: dts: aspeed: Add uarts for SoL in Facebook

2019-01-23 Thread Vijay Khemka
Added uart2 and uart3 in Facebook Tiogapass for routing serial input from Host to BMC for SoL via LPC. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook

2019-01-23 Thread Vijay Khemka
Added lpc control for enabling lpc clock, peci for cpu sensors and lpc snoop devices to Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 14 ++ 1 file changed, 14 insertions(+) diff --git

<    1   2   3   4   5   6   7   8   9   10   >