Re: [PATCH] Input: mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
On 2/11/19 4:48 PM, Dmitry Torokhov wrote: > On Mon, Feb 11, 2019 at 04:25:55PM -0600, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warning: >> >>

[PATCH] mfd: mxs-lradc: Mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/mfd/mxs-lradc.c: In function ‘mxs_lradc_probe’: drivers/mfd/mxs-lradc.c:179:7: warning: this statement may fall through

Re: [PATCH] Input: mark expected switch fall-through

2019-02-11 Thread Dmitry Torokhov
On Mon, Feb 11, 2019 at 04:25:55PM -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/input/joystick/db9.c: In function

Re: [PATCH v2 05/20] x86/alternative: initializing temporary mm for patching

2019-02-11 Thread Andy Lutomirski
On Mon, Feb 11, 2019 at 11:18 AM Nadav Amit wrote: > > > On Feb 11, 2019, at 11:07 AM, Andy Lutomirski wrote: > > > > I'm certainly amenable to other solutions, but this one does seem the > > least messy. I looked at my old patch, and it doesn't do what you > > want. I'd suggest you just add a

[PATCH v2] Input: apanel - switch to using brightness_set_blocking()

2019-02-11 Thread Dmitry Torokhov
Now that LEDs core allows "blocking" flavor of "set brightness" method we can use it and get rid of private work item. As a bonus, we are no longer forgetting to cancel it when we unbind the driver. Signed-off-by: Dmitry Torokhov --- v2: get rid of led_bits member (Sven)

[PATCH 5/5] kvm/book3s: use pinned_vm instead of locked_vm to account pinned pages

2019-02-11 Thread Daniel Jordan
Memory used for TCE tables in kvm_vm_ioctl_create_spapr_tce is currently accounted to locked_vm because it stays resident and its allocation is directly triggered from userspace as explained in f8626985c7c2 ("KVM: PPC: Account TCE-containing pages in locked_vm"). However, since the memory comes

[PATCH 3/5] fpga/dlf/afu: use pinned_vm instead of locked_vm to account pinned pages

2019-02-11 Thread Daniel Jordan
Beginning with bc3e53f682d9 ("mm: distinguish between mlocked and pinned pages"), locked and pinned pages are accounted separately. The FPGA AFU driver accounts pinned pages to locked_vm; use pinned_vm instead. pinned_vm recently became atomic and so no longer relies on mmap_sem held as writer:

[PATCH 0/5] use pinned_vm instead of locked_vm to account pinned pages

2019-02-11 Thread Daniel Jordan
Hi, This series converts users that account pinned pages with locked_vm to account with pinned_vm instead, pinned_vm being the correct counter to use. It's based on a similar patch I posted recently[0]. The patches are based on rdma/for-next to build on Davidlohr Bueso's recent conversion of

[PATCH 4/5] powerpc/mmu: use pinned_vm instead of locked_vm to account pinned pages

2019-02-11 Thread Daniel Jordan
Beginning with bc3e53f682d9 ("mm: distinguish between mlocked and pinned pages"), locked and pinned pages are accounted separately. The IOMMU MMU helpers on powerpc account pinned pages to locked_vm; use pinned_vm instead. pinned_vm recently became atomic and so no longer relies on mmap_sem held

[PATCH 1/5] vfio/type1: use pinned_vm instead of locked_vm to account pinned pages

2019-02-11 Thread Daniel Jordan
Beginning with bc3e53f682d9 ("mm: distinguish between mlocked and pinned pages"), locked and pinned pages are accounted separately. Type1 accounts pinned pages to locked_vm; use pinned_vm instead. pinned_vm recently became atomic and so no longer relies on mmap_sem held as writer: delete.

[PATCH 2/5] vfio/spapr_tce: use pinned_vm instead of locked_vm to account pinned pages

2019-02-11 Thread Daniel Jordan
Beginning with bc3e53f682d9 ("mm: distinguish between mlocked and pinned pages"), locked and pinned pages are accounted separately. The SPAPR TCE VFIO IOMMU driver accounts pinned pages to locked_vm; use pinned_vm instead. pinned_vm recently became atomic and so no longer relies on mmap_sem held

[PATCH] scsi: mptfusion: mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/message/fusion/mptbase.c: In function ‘mptbase_reply’: drivers/message/fusion/mptbase.c:643:6: warning: this statement may fall through

[PATCH] isdn_v110: mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/isdn/i4l/isdn_v110.c: In function ‘EncodeMatrix’: drivers/isdn/i4l/isdn_v110.c:353:7: warning: this statement may fall through

Re: [PATCH 1/2] PM-runtime: Take suppliers into account in __pm_runtime_set_status()

2019-02-11 Thread Rafael J. Wysocki
On Mon, Feb 11, 2019 at 2:28 PM Ulf Hansson wrote: > > On Thu, 7 Feb 2019 at 19:46, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > If the target device has any suppliers, as reflected by device links > > to them, __pm_runtime_set_status() does not take them into account, > >

RE: [PATCH 0/3] Add gup fast + longterm and use it in HFI1

2019-02-11 Thread Weiny, Ira
> On Mon, Feb 11, 2019 at 01:42:57PM -0800, Ira Weiny wrote: > > On Mon, Feb 11, 2019 at 01:47:10PM -0700, Jason Gunthorpe wrote: > > > On Mon, Feb 11, 2019 at 12:34:17PM -0800, Davidlohr Bueso wrote: > > > > On Mon, 11 Feb 2019, ira.we...@intel.com wrote: > > > > > Ira Weiny (3): > > > > >

[PATCH] docs: kernel-doc: typo "if ... if" -> "if ... is"

2019-02-11 Thread frowand . list
From: Frank Rowand "If no *function* if specified" should instead be "If no *function* is specified". Reported-by: Matthew Wilcox Signed-off-by: Frank Rowand --- Documentation/doc-guide/kernel-doc.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers

2019-02-11 Thread Alexandre Oliva
On Feb 11, 2019, Tom Li wrote: > What is the current link to your repository? git://dev.lemote.com/linux-loongson-community.git I use a different git URL to push stuff, so I wouldn't have noticed if the above was gone, but I've just tried to git clone form the above and it seems to remain

[PATCH] isdn: i4l: isdn_tty: Mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/isdn/i4l/isdn_tty.c: In function ‘isdn_tty_edit_at’: drivers/isdn/i4l/isdn_tty.c:3644:18: warning: this statement may fall through

Re: [PATCH 2/5] genirq/affinity: allow driver to setup managed IRQ's affinity

2019-02-11 Thread Thomas Gleixner
Ming, On Mon, 11 Feb 2019, Bjorn Helgaas wrote: > On Mon, Feb 11, 2019 at 11:54:00AM +0800, Ming Lei wrote: > > On Sun, Feb 10, 2019 at 05:30:41PM +0100, Thomas Gleixner wrote: > > > On Fri, 25 Jan 2019, Ming Lei wrote: > > > > > > > This patch introduces callback of .setup_affinity into

Re: [PATCH][next] RDMA/bnxt_re: fix or'ing of data into an uninitialized struct member

2019-02-11 Thread Jason Gunthorpe
On Mon, Feb 11, 2019 at 01:34:15PM +, Colin King wrote: > From: Colin Ian King > > The struct member comp_mask has not been initialized however a bit > pattern is being bitwise or'd into the member and hence other bit > fields in comp_mask may contain any garbage from the stack. Fix this >

Re: [RFC PATCH] docs/memory-barriers.txt: Rewrite "KERNEL I/O BARRIER EFFECTS" section

2019-02-11 Thread Linus Torvalds
On Mon, Feb 11, 2019 at 9:30 AM Will Deacon wrote: > > + > + 1. All readX() and writeX() accesses to the same peripheral are ordered > +with respect to each other. For example, this ensures that MMIO > register > + writes by the CPU to a particular device will arrive in program

[PATCH] ser_gigaset: mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/isdn/gigaset/ser-gigaset.c: In function ‘gigaset_tty_ioctl’: drivers/isdn/gigaset/ser-gigaset.c:627:3: warning: this statement may fall

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-11 Thread John Hubbard
On 2/11/19 2:12 PM, Jason Gunthorpe wrote: > On Mon, Feb 11, 2019 at 01:22:11PM -0800, John Hubbard wrote: > >> The only way that breaks is if longterm pins imply an irreversible action, >> such >> as blocking and waiting in a way that you can't back out of or get >> interrupted >> out of. And

Re: [PATCH v2 0/9] gpio: mockup: improve the user-space testing interface

2019-02-11 Thread Marc Zyngier
On Wed, 6 Feb 2019 11:23:46 +0100 Bartosz Golaszewski wrote: > wt., 29 sty 2019 o 09:44 Bartosz Golaszewski napisał(a): > > > > From: Bartosz Golaszewski > > > > This series aims at reworking the gpio-mockup debugfs interface. The > > reason for that is the fact that certain known problems

DMCA takedown request to GitHub regarding: GPC-Slots2

2019-02-11 Thread Mikee USA
**Please provide a detailed description of the original copyrighted work that has allegedly been infringed. If possible, include a URL to where it is posted online.** GPC-Slots 2 is a text-mode casino game I created. It includes 5 slot machines, 3 table games (Sic Bo, Craps, and 2 variations

Re: [PATCH v6 5/8] soc: qcom: Add AOSS QMP communication driver

2019-02-11 Thread Doug Anderson
Hi, On Tue, Feb 5, 2019 at 9:13 PM Bjorn Andersson wrote: > + if (of_property_read_bool(pdev->dev.of_node, "#power-domain-cells")) { > + qmp->pd_pdev = platform_device_register_data(>dev, > +"aoss_qmp_pd", > +

Re: [PATCH 1/3] iio: light: Add driver for ap3216c

2019-02-11 Thread Sven Van Asbroeck
On Mon, Feb 11, 2019 at 4:27 PM Jonathan Cameron wrote: > > Agreed. Or potentially just use regmap_bulk_read and rely on > the regmap internal locking to do it for you. Neat solution. But it may only work correctly iff regmap_bulk_read() reads the low address first. I'm not sure if this

Re: [Qemu-devel] security implications of caching with virtio pmem (was Re: [PATCH v3 0/5] kvm "virtio pmem" device)

2019-02-11 Thread Dave Chinner
On Mon, Feb 11, 2019 at 02:29:46AM -0500, Pankaj Gupta wrote: > Hello Dave, > Are we okay with this? Sure. I'm not sure I agree with all the analysis presented, but, well, I haven't looked any deeper because I'm tired of being shouted at and being called argumentative for daring to ask hard

Re: [PATCH v2 1/9] irq/irq_sim: don't share the irq_chip structure between simulators

2019-02-11 Thread Marc Zyngier
On Tue, 29 Jan 2019 09:44:03 +0100 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We want to support multiple instances of irq_sim. Make struct irq_chip > part of the irq_sim structure. Why? There is nothing dynamic in an irqchip structure. It is all code that is set in stone for

Re: [PATCH v2] lib/scatterlist: Provide a DMA page iterator

2019-02-11 Thread Jason Gunthorpe
On Thu, Feb 07, 2019 at 10:26:52PM +, Jason Gunthorpe wrote: > Commit 2db76d7c3c6d ("lib/scatterlist: sg_page_iter: support sg lists w/o > backing pages") introduced the sg_page_iter_dma_address() function without > providing a way to use it in the general case. If the sg_dma_len() is not >

Re: [PATCH v2 2/9] irq/irq_sim: use irq domain

2019-02-11 Thread Marc Zyngier
On Tue, 29 Jan 2019 09:44:04 +0100 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Delegate the offset to virq number mapping to the provided framework > instead of handling it locally. Use the legacy domain as we want to > preallocate the irq descriptors. Why? > > Signed-off-by:

[PATCH] Input: mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/input/joystick/db9.c: In function ‘db9_saturn_read_packet’: drivers/input/joystick/db9.c:256:6: warning: this statement may fall through

Re: [PATCH 0/3] Add gup fast + longterm and use it in HFI1

2019-02-11 Thread Jason Gunthorpe
On Mon, Feb 11, 2019 at 09:14:56PM +, Weiny, Ira wrote: > > > > On Mon, Feb 11, 2019 at 12:16:40PM -0800, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > NOTE: This series depends on my clean up patch to remove the write > > > parameter from gup_fast_permitted()[1] > > > > > >

Re: [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.

2019-02-11 Thread Palmer Dabbelt
On Mon, 11 Feb 2019 14:13:25 PST (-0800), marc.zyng...@arm.com wrote: On Mon, 11 Feb 2019 12:03:30 -0800 Atish Patra wrote: On 2/11/19 11:02 AM, Palmer Dabbelt wrote: > On Fri, 08 Feb 2019 20:26:07 PST (-0800), david.abdurachma...@gmail.com wrote: >> On Sat, Feb 9, 2019 at 12:03 AM Atish

[PATCH] iio: mma8452: mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/iio/accel/mma8452.c: In function ‘mma8452_probe’: drivers/iio/accel/mma8452.c:1581:6: warning: this statement may fall through

Re: [PATCH 2/2] ARM: dts: imx7: add DMA properties for ECSPI

2019-02-11 Thread Trent Piepho
On Mon, 2019-02-11 at 19:34 -0200, Fabio Estevam wrote: > Hi Trent, > > On Mon, Feb 11, 2019 at 6:44 PM Trent Piepho wrote: > > > I've had more time to test. > > > > Without DMA, I can reload my FPGA hundreds of times and get days of > > uptime using linux-next. > > > > With DMA, loading is

Re: [PATCH 0/3] Add gup fast + longterm and use it in HFI1

2019-02-11 Thread Jason Gunthorpe
On Mon, Feb 11, 2019 at 01:42:57PM -0800, Ira Weiny wrote: > On Mon, Feb 11, 2019 at 01:47:10PM -0700, Jason Gunthorpe wrote: > > On Mon, Feb 11, 2019 at 12:34:17PM -0800, Davidlohr Bueso wrote: > > > On Mon, 11 Feb 2019, ira.we...@intel.com wrote: > > > > Ira Weiny (3): > > > > mm/gup: Change

[PATCH] ide: mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/ide/ide-floppy.c: In function ‘ide_floppy_get_capacity’: drivers/ide/ide-floppy.c:424:7: warning: this statement may fall through

linux-next: Fixes tag needs some work in the net-next tree

2019-02-11 Thread Stephen Rothwell
Hi all, In commit cbd72b485214 ("net: dsa: microchip: add switch offload forwarding support") Fixes tag Fixes: c2e866911e254067 ("microchip: break KSZ9477 DSA driver into two files") has these problem(s): - Subject does not match target commit subject Just use git log -1

Re: [PATCH] Input: qt2160 - remove redundant spinlock

2019-02-11 Thread Dmitry Torokhov
On Sun, Feb 10, 2019 at 09:32:22PM -0500, thesve...@gmail.com wrote: > From: Sven Van Asbroeck > > Remove a spinlock which prevents schedule_delayed_work() and > mod_delayed_work() from executing concurrently. > > This was required back when mod_delayed_work() did not exist, > and had to be

Re: [PATCH v6 6/8] soc: qcom: Add AOSS QMP genpd provider

2019-02-11 Thread Doug Anderson
Hi, On Tue, Feb 5, 2019 at 9:13 PM Bjorn Andersson wrote: > +static int qmp_pd_image_toggle(struct qmp_pd *res, bool enable) > +{ > + char buf[AOSS_QMP_PD_MSG_LEN]; > + > + memset(buf, 0, sizeof(buf)); Personally I find it safer/cleaner to do something like: char

[PATCH] i3c: master: dw-i3c-master: mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/i3c/master/dw-i3c-master.c: In function ‘dw_i3c_master_bus_init’: drivers/i3c/master/dw-i3c-master.c:603:6: warning: this statement may

Re: [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.

2019-02-11 Thread Marc Zyngier
On Mon, 11 Feb 2019 12:03:30 -0800 Atish Patra wrote: > On 2/11/19 11:02 AM, Palmer Dabbelt wrote: > > On Fri, 08 Feb 2019 20:26:07 PST (-0800), david.abdurachma...@gmail.com > > wrote: > >> On Sat, Feb 9, 2019 at 12:03 AM Atish Patra wrote: > >>> > >>> On 2/8/19 1:11 AM, Christoph Hellwig

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-11 Thread Jason Gunthorpe
On Mon, Feb 11, 2019 at 01:22:11PM -0800, John Hubbard wrote: > The only way that breaks is if longterm pins imply an irreversible action, > such > as blocking and waiting in a way that you can't back out of or get interrupted > out of. And the design doesn't seem to be going in that direction,

Re: [PATCH] uprobes: convert uprobe.ref to refcount_t

2019-02-11 Thread Steven Rostedt
On Mon, 11 Feb 2019 13:49:27 -0800 Kees Cook wrote: > On Mon, Feb 11, 2019 at 12:28 PM Steven Rostedt wrote: > > > > On Mon, 11 Feb 2019 15:27:25 -0500 > > Steven Rostedt wrote: > > > > > On Mon, 11 Feb 2019 12:21:32 -0800 > > > Kees Cook wrote: > > > > > > > > > Looks good to me. > > > >

Re: [PATCH v2] dt-bindings: input: ti-tsc-adc: Add new compatible for AM654 SoCs

2019-02-11 Thread Dmitry Torokhov
Hi Vignesh, On Mon, Feb 11, 2019 at 11:10:59AM +0530, Vignesh R wrote: > Hi Dmitry, > > On 08/01/19 10:56 AM, Vignesh R wrote: > > AM654 SoCs has ADC IP which is similar to AM335x, but without the > > touchscreen part. Add new compatible to handle AM654 SoCs. Also, it > > seems that existing

[PATCH] hwmon: (f71882fg) Mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/hwmon/f71882fg.c: In function ‘f71882fg_probe’: drivers/hwmon/f71882fg.c:2457:33: warning: this statement may fall through

Re: [PATCH 2/3] mm/gup: Introduce get_user_pages_fast_longterm()

2019-02-11 Thread Jason Gunthorpe
On Mon, Feb 11, 2019 at 01:52:38PM -0800, Ira Weiny wrote: > On Mon, Feb 11, 2019 at 01:39:12PM -0800, John Hubbard wrote: > > On 2/11/19 1:26 PM, Ira Weiny wrote: > > > On Mon, Feb 11, 2019 at 01:13:56PM -0800, John Hubbard wrote: > > >> On 2/11/19 12:39 PM, Jason Gunthorpe wrote: > > >>> On Mon,

Re: [PATCH] slub: remove an unused addr argument

2019-02-11 Thread David Rientjes
On Mon, 11 Feb 2019, Qian Cai wrote: > "addr" function argument is not used in alloc_consistency_checks() at > all, so remove it. > > Fixes: becfda68abca ("slub: convert SLAB_DEBUG_FREE to > SLAB_CONSISTENCY_CHECKS") > Signed-off-by: Qian Cai Acked-by: David Rientjes

[PATCH] HID: wacom: Mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/hid/wacom_wac.c: In function ‘wacom_setup_pen_input_capabilities’: drivers/hid/wacom_wac.c:3506:3: warning: this statement may fall through

Re: [GIT PULL] Thermal-SoC management fixes for v5.0-rc6

2019-02-11 Thread Linus Torvalds
On Mon, Feb 11, 2019 at 12:16 PM Konstantin Ryabitsev wrote: > > Okay, so I need guidance on the proper behaviour here. As this request > didn't use the magic wording for the commit-id (as generated by > git-request-pull), we ended up trying to look up the remote. The remote > specified was: > >

WARNING in vkms_vblank_simulate

2019-02-11 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:d4104460aec1 Add linux-next specific files for 20190211 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=10e74624c0 kernel config: https://syzkaller.appspot.com/x/.config?x=c8a112d3b0d6719b

KMSAN: uninit-value in capi_write

2019-02-11 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:11587f6ee534 kmsan: remove pr_err git tree: kmsan console output: https://syzkaller.appspot.com/x/log.txt?x=120bd84f40 kernel config: https://syzkaller.appspot.com/x/.config?x=c8a62a4eb8ea3e9f dashboard link:

linux-next: manual merge of the tegra tree with the imx-mxs tree

2019-02-11 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tegra tree got a conflict in: arch/arm64/configs/defconfig between commit: 28cfe2434529 ("arm64: defconfig: Enable PFUZE100 regulator") from the imx-mxs tree and commit: 2b5d2c92c29d ("arm64: defconfig: Enable MAX8973 regulator") from the tegra

Re: [PATCH 2/3] mm/gup: Introduce get_user_pages_fast_longterm()

2019-02-11 Thread John Hubbard
On 2/11/19 1:52 PM, Ira Weiny wrote: > On Mon, Feb 11, 2019 at 01:39:12PM -0800, John Hubbard wrote: >> On 2/11/19 1:26 PM, Ira Weiny wrote: >>> On Mon, Feb 11, 2019 at 01:13:56PM -0800, John Hubbard wrote: On 2/11/19 12:39 PM, Jason Gunthorpe wrote: > On Mon, Feb 11, 2019 at 12:16:42PM

[PATCH 2/5] kasan, kmemleak: pass tagged pointers to kmemleak

2019-02-11 Thread Andrey Konovalov
Right now we call kmemleak hooks before assigning tags to pointers in KASAN hooks. As a result, when an objects gets allocated, kmemleak sees a differently tagged pointer, compared to the one it sees when the object gets freed. Fix it by calling KASAN hooks before kmemleak's ones. Reported-by:

[PATCH 5/5] kasan, slub: fix conflicts with CONFIG_SLAB_FREELIST_HARDENED

2019-02-11 Thread Andrey Konovalov
CONFIG_SLAB_FREELIST_HARDENED hashes freelist pointer with the address of the object where the pointer gets stored. With tag based KASAN we don't account for that when building freelist, as we call set_freepointer() with the first argument untagged. This patch changes the code to properly

[PATCH 3/5] kmemleak: account for tagged pointers when calculating pointer range

2019-02-11 Thread Andrey Konovalov
kmemleak keeps two global variables, min_addr and max_addr, which store the range of valid (encountered by kmemleak) pointer values, which it later uses to speed up pointer lookup when scanning blocks. With tagged pointers this range will get bigger than it needs to be. This patch makes kmemleak

[PATCH 4/5] kasan, slub: move kasan_poison_slab hook before page_address

2019-02-11 Thread Andrey Konovalov
With tag based KASAN page_address() looks at the page flags to see whether the resulting pointer needs to have a tag set. Since we don't want to set a tag when page_address() is called on SLAB pages, we call page_kasan_tag_reset() in kasan_poison_slab(). However in allocate_slab() page_address()

[PATCH 1/5] kasan: fix assigning tags twice

2019-02-11 Thread Andrey Konovalov
When an object is kmalloc()'ed, two hooks are called: kasan_slab_alloc() and kasan_kmalloc(). Right now we assign a tag twice, once in each of the hooks. Fix it by assigning a tag only in the former hook. Signed-off-by: Andrey Konovalov --- mm/kasan/common.c | 29 +

[PATCH 0/5] kasan: more tag based mode fixes

2019-02-11 Thread Andrey Konovalov
Andrey Konovalov (5): kasan: fix assigning tags twice kasan, kmemleak: pass tagged pointers to kmemleak kmemleak: account for tagged pointers when calculating pointer range kasan, slub: move kasan_poison_slab hook before page_address kasan, slub: fix conflicts with

[PATCH] HID: roccat: Mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/hid/hid-roccat-kone.c: In function ‘kone_keep_values_up_to_date’: drivers/hid/hid-roccat-kone.c:784:20: warning: this statement may fall

[PATCH v2 2/2] iommu/vt-d: Enable PASID only if device expects PASID in PRG Response.

2019-02-11 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan In Intel IOMMU, if the Page Request Queue (PRQ) is full, it will automatically respond to the device with a success message as a keep alive. And when sending the success message, IOMMU will include PASID in the Response Message when the Page Request has a PASID

KMSAN: uninit-value in hsr_register_frame_in

2019-02-11 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:fa1981bee40f kmsan: fix defconfig build git tree: kmsan console output: https://syzkaller.appspot.com/x/log.txt?x=12c53624c0 kernel config: https://syzkaller.appspot.com/x/.config?x=52c9737ec5618f82 dashboard link:

Re: [PATCH 2/3] mm/gup: Introduce get_user_pages_fast_longterm()

2019-02-11 Thread Ira Weiny
On Mon, Feb 11, 2019 at 01:39:12PM -0800, John Hubbard wrote: > On 2/11/19 1:26 PM, Ira Weiny wrote: > > On Mon, Feb 11, 2019 at 01:13:56PM -0800, John Hubbard wrote: > >> On 2/11/19 12:39 PM, Jason Gunthorpe wrote: > >>> On Mon, Feb 11, 2019 at 12:16:42PM -0800, ira.we...@intel.com wrote: >

[PATCH v2 0/2] Add PGR response PASID requirement check in Intel IOMMU.

2019-02-11 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Intel IOMMU responds automatically when receiving page-requests from a PCIe endpoint and the page-request queue is full and it cannot accept any more page-requests. When it auto-responds to page-requests with a success to the endpoint, it automatically responds

[PATCH v2 1/2] PCI/ATS: Add pci_prg_resp_pasid_required() interface.

2019-02-11 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Return the PRG Response PASID Required bit in the Page Request Status Register. As per PCIe spec r4.0, sec 10.5.2.3, if this bit is Set then the device expects a PASID TLP Prefix on PRG Response Messages when the corresponding Page Requests had a PASID TLP

Re: [PATCH] uprobes: convert uprobe.ref to refcount_t

2019-02-11 Thread Kees Cook
On Mon, Feb 11, 2019 at 12:28 PM Steven Rostedt wrote: > > On Mon, 11 Feb 2019 15:27:25 -0500 > Steven Rostedt wrote: > > > On Mon, 11 Feb 2019 12:21:32 -0800 > > Kees Cook wrote: > > > > > > > Looks good to me. > > > > > > > > > > Reviewed-by: Srikar Dronamraju > > > > > > > > Thank you very

Re: [PATCH v2 0/2] Add page alignment check in Intel IOMMU.

2019-02-11 Thread sathyanarayanan kuppuswamy
On 2/11/19 1:43 PM, sathyanarayanan.kuppusw...@linux.intel.com wrote: From: Kuppuswamy Sathyanarayanan As per Intel vt-d specification, Rev 3.0 (section 7.5.1.1, title "Page Request Descriptor"), Intel IOMMU Page Request Descriptor only provides bits[63:12] of the page address. Hence its

Re: [PATCH] staging: iio: ad5933: move out of staging

2019-02-11 Thread Marcelo Schmitt
On 02/11, Jonathan Cameron wrote: > On Mon, 11 Feb 2019 13:43:11 -0200 > Marcelo Schmitt wrote: > > > Move ad5933 impedance-analyzer driver from staging to mainline. > > > > The ad5933 is a high precision impedance converter system > > solution that combines an on-board frequency generator with

[PATCH v2 2/2] iommu/vt-d: Enable ATS only if the device uses page aligned address.

2019-02-11 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan As per Intel vt-d specification, Rev 3.0 (section 7.5.1.1, title "Page Request Descriptor"), Intel IOMMU page request descriptor only uses bits[63:12] of the page address. Hence Intel IOMMU driver would only permit devices that advertise they would only send page

[PATCH v2 1/2] PCI/ATS: Add pci_ats_page_aligned() interface

2019-02-11 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Return the Page Aligned Request bit in the ATS Capability Register. As per PCIe spec r4.0, sec 10.5.1.2, If Page Aligned Request bit is set, then it indicates the Untranslated Addresses generated by the device are alwayis always aligned to a 4096 byte boundary.

[PATCH v2 0/2] Add page alignment check in Intel IOMMU.

2019-02-11 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan As per Intel vt-d specification, Rev 3.0 (section 7.5.1.1, title "Page Request Descriptor"), Intel IOMMU page request descriptor only uses bits[63:12] of the Page Address. Hence its required to enforce that the device will only send page request with page-aligned

Re: [PATCH 2/3] mm/gup: Introduce get_user_pages_fast_longterm()

2019-02-11 Thread Dan Williams
On Mon, Feb 11, 2019 at 1:39 PM John Hubbard wrote: > > On 2/11/19 1:26 PM, Ira Weiny wrote: > > On Mon, Feb 11, 2019 at 01:13:56PM -0800, John Hubbard wrote: > >> On 2/11/19 12:39 PM, Jason Gunthorpe wrote: > >>> On Mon, Feb 11, 2019 at 12:16:42PM -0800, ira.we...@intel.com wrote: > From:

[PATCH v2 0/2] Add page alignment check in Intel IOMMU.

2019-02-11 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan As per Intel vt-d specification, Rev 3.0 (section 7.5.1.1, title "Page Request Descriptor"), Intel IOMMU Page Request Descriptor only provides bits[63:12] of the page address. Hence its required to enforce that the device will only send page request with

Re: [PATCH v2] i2c: core-smbus: don't trace smbus_reply data on errors

2019-02-11 Thread John Sperbeck
On Mon, Feb 11, 2019 at 6:24 AM Steven Rostedt wrote: > > On Sun, 10 Feb 2019 19:40:21 -0800 > John Sperbeck wrote: > > > If an smbus transfer fails, there's no guarantee that the output > > buffer was written. So, avoid trying to show the output buffer when > > tracing after an error. This

Re: [PATCH 0/3] Add gup fast + longterm and use it in HFI1

2019-02-11 Thread Ira Weiny
On Mon, Feb 11, 2019 at 01:47:10PM -0700, Jason Gunthorpe wrote: > On Mon, Feb 11, 2019 at 12:34:17PM -0800, Davidlohr Bueso wrote: > > On Mon, 11 Feb 2019, ira.we...@intel.com wrote: > > > Ira Weiny (3): > > > mm/gup: Change "write" parameter to flags > > > mm/gup: Introduce

Re: [PATCH v2 1/2] drivers: devfreq: change devfreq workqueue mechanism

2019-02-11 Thread Matthias Kaehlcke
Hi Lukasz, On Mon, Feb 11, 2019 at 04:30:04PM +0100, Lukasz Luba wrote: > There is no need for creating another workqueue in the system, > the existing one should meet the requirements. > This patch removes devfreq's custom workqueue and uses system one. > It switches from queue_delayed_work() to

Re: + sysctl-return-einval-if-val-violates-minmax.patch added to -mm tree

2019-02-11 Thread Luis Chamberlain
On Mon, Feb 11, 2019 at 10:32:50PM +0100, Christian Brauner wrote: > On Mon, Feb 11, 2019 at 01:25:23PM -0800, Luis Chamberlain wrote: > > On Mon, Feb 11, 2019 at 10:19:19PM +0100, Christian Brauner wrote: > > > On Tue, Feb 12, 2019 at 12:17:16AM +0300, Alexey Dobriyan wrote: > > > > On Mon, Feb

Re: [PATCH net-next v4 0/9] net: Remove switchdev_ops

2019-02-11 Thread Ido Schimmel
On Mon, Feb 11, 2019 at 12:16:57PM -0800, David Miller wrote: > From: Florian Fainelli > Date: Mon, 11 Feb 2019 11:09:52 -0800 > > > David, I would like to get Ido's feedback on this to make sure I did not > > miss something, thank you! > > Ok, Ido please look at this when you can. Will review

Re: [PATCH v2] selftests: kmod: worked on errors which breaks the overall execution of the test script. i have manually edited for v2 of the patch by changing the date and also commit log.

2019-02-11 Thread Luis Chamberlain
Your subject is too long. On Fri, Feb 01, 2019 at 12:01:09AM +0530, Jeffrin Jose T wrote: > The kmod.sh script breaks because an array is passed as input > instead of a single element input.This patch takes elements > one at a time and passed as input to the condition statement > which in turn

Re: [PATCH 2/3] mm/gup: Introduce get_user_pages_fast_longterm()

2019-02-11 Thread John Hubbard
On 2/11/19 1:26 PM, Ira Weiny wrote: > On Mon, Feb 11, 2019 at 01:13:56PM -0800, John Hubbard wrote: >> On 2/11/19 12:39 PM, Jason Gunthorpe wrote: >>> On Mon, Feb 11, 2019 at 12:16:42PM -0800, ira.we...@intel.com wrote: From: Ira Weiny >> [...] >> It seems to me that the longterm vs.

Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-11 Thread Mark Cave-Ayland
On 11/02/2019 00:30, Benjamin Herrenschmidt wrote: > On Fri, 2019-02-08 at 14:51 +, Mark Cave-Ayland wrote: >> >> Indeed, but there are still some questions to be asked here: >> >> 1) Why were these bits removed from the original bitmask in the first place >> without >> it being documented

Re: [PATCH 2/2] PCI: imx6: limit DBI register length

2019-02-11 Thread Bjorn Helgaas
On Wed, Feb 06, 2019 at 10:57:32AM +0100, Stefan Agner wrote: > Define the length of the DBI registers. This makes sure that > the kernel does not access registers beyond that point, avoiding > the following abort on a i.MX 6Quad: > # cat

Re: [PATCH 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs

2019-02-11 Thread Jacek Anaszewski
Hi Yauhen, Thank you for the patch. Please find few comments in the code. On 2/9/19 11:12 PM, Yauhen Kharuzhy wrote: Add support for LEDs connected to the Intel Cherry Trail Whiskey Cove PMIC. Charger and general-purpose leds are supported. Hardware blinking is implemented, breathing is not.

Re: [PATCH v2 2/2] drivers: devfreq: change deferred work into delayed

2019-02-11 Thread Matthias Kaehlcke
Hi Lukasz, On Mon, Feb 11, 2019 at 04:30:05PM +0100, Lukasz Luba wrote: > This patch changes deferred work to delayed work, which is now not missed > when timer is put on CPU that entered idle state. > The devfreq framework governor was not called, thus changing the device's > frequency did not

Re: [PATCH v3] cpufreq: intel_pstate: Reporting reasons why driver prematurely exit

2019-02-11 Thread Erwan Velu
I understand your concern but I'd like to defend my use case ;) I was in a case where I didn't noticed that intel_pstate did engaged after a kernel upgrade while it didn't before. But there strictly no information message why the driver took the decision not to load (aka considering there is

Re: [PATCH 2/2] ARM: dts: imx7: add DMA properties for ECSPI

2019-02-11 Thread Fabio Estevam
Hi Trent, On Mon, Feb 11, 2019 at 6:44 PM Trent Piepho wrote: > I've had more time to test. > > Without DMA, I can reload my FPGA hundreds of times and get days of > uptime using linux-next. > > With DMA, loading is unreliable. The higher the SPI speed, the less > reliable it is.

Re: [RFC PATCH v2] blkcg: prevent priority inversion problem during sync()

2019-02-11 Thread Josef Bacik
On Mon, Feb 11, 2019 at 09:40:29PM +0100, Andrea Righi wrote: > On Mon, Feb 11, 2019 at 10:39:34AM -0500, Josef Bacik wrote: > > On Sat, Feb 09, 2019 at 03:07:49PM +0100, Andrea Righi wrote: > > > This is an attempt to mitigate the priority inversion problem of a > > > high-priority blkcg issuing

Re: + sysctl-return-einval-if-val-violates-minmax.patch added to -mm tree

2019-02-11 Thread Christian Brauner
On Mon, Feb 11, 2019 at 01:25:23PM -0800, Luis Chamberlain wrote: > On Mon, Feb 11, 2019 at 10:19:19PM +0100, Christian Brauner wrote: > > On Tue, Feb 12, 2019 at 12:17:16AM +0300, Alexey Dobriyan wrote: > > > On Mon, Feb 11, 2019 at 01:06:32PM -0800, a...@linux-foundation.org wrote: > > > > > >

Re: [PATCH v6 4/7] cgroup: cgroup v2 freezer

2019-02-11 Thread Roman Gushchin
On Wed, Jan 30, 2019 at 05:52:01PM +0100, Oleg Nesterov wrote: > Hi Roman, > > On 01/28, Roman Gushchin wrote: > > > > Yes, I think you're right: cgroup_exit() should check CGRP_FREEZE bit, > > not CGRP_FROZEN. Like cgroup_post_fork() does (a one-liner change below). Hi Oleg! Sorry for the late

Re: [PATCH 0/3] Add gup fast + longterm and use it in HFI1

2019-02-11 Thread Ira Weiny
On Mon, Feb 11, 2019 at 12:34:17PM -0800, Davidlohr Bueso wrote: > On Mon, 11 Feb 2019, ira.we...@intel.com wrote: > > Ira Weiny (3): > > mm/gup: Change "write" parameter to flags > > mm/gup: Introduce get_user_pages_fast_longterm() > > IB/HFI1: Use new get_user_pages_fast_longterm() > > Out

Re: [PATCH 1/3] iio: light: Add driver for ap3216c

2019-02-11 Thread Jonathan Cameron
On Mon, 11 Feb 2019 14:09:12 -0500 Sven Van Asbroeck wrote: > Hi Robert, > > On Sun, Feb 10, 2019 at 3:39 PM Robert Eshleman > wrote: > > > > This patch adds support for the ap3216c ambient light and proximity > > sensor. > > Comments below. > Follow up inline... Mostly looks good to me,

Re: [PATCH v4 13/16] block: sed-opal: check size of shadow mbr

2019-02-11 Thread Derrick, Jonathan
On Sun, 2019-02-10 at 21:05 +0100, David Kozub wrote: > On Fri, 8 Feb 2019, Derrick, Jonathan wrote: > > > On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote: > > > From: Jonas Rabenstein > > > > > > Check whether the shadow mbr does fit in the provided space on > > > the > > > target. Also a

Re: [PATCH 2/3] mm/gup: Introduce get_user_pages_fast_longterm()

2019-02-11 Thread Ira Weiny
On Mon, Feb 11, 2019 at 01:13:56PM -0800, John Hubbard wrote: > On 2/11/19 12:39 PM, Jason Gunthorpe wrote: > > On Mon, Feb 11, 2019 at 12:16:42PM -0800, ira.we...@intel.com wrote: > >> From: Ira Weiny > [...] > >> +static inline int get_user_pages_fast_longterm(unsigned long start, int > >>

Re: + sysctl-return-einval-if-val-violates-minmax.patch added to -mm tree

2019-02-11 Thread Luis Chamberlain
On Mon, Feb 11, 2019 at 10:19:19PM +0100, Christian Brauner wrote: > On Tue, Feb 12, 2019 at 12:17:16AM +0300, Alexey Dobriyan wrote: > > On Mon, Feb 11, 2019 at 01:06:32PM -0800, a...@linux-foundation.org wrote: > > > > > @@ -2848,8 +2848,10 @@ static int __do_proc_doulongvec_minmax(v > > > > >

Re: [PATCH v3] cpufreq: intel_pstate: Reporting reasons why driver prematurely exit

2019-02-11 Thread Srinivas Pandruvada
On Mon, 2019-02-11 at 10:31 +0100, Erwan Velu wrote: > The init code path have several execeptions where the module can > decide not to load. > As CONFIG_X86_INTEL_PSTATE is generally set to Y, the return code is > not reachable. > The initialisation code is neither verbose of the reason why it

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-11 Thread John Hubbard
On 2/11/19 10:19 AM, Ira Weiny wrote: > On Mon, Feb 11, 2019 at 11:06:54AM -0700, Jason Gunthorpe wrote: >> On Mon, Feb 11, 2019 at 09:22:58AM -0800, Dan Williams wrote: [...] > John's patches will indicate to the FS that the page is gup pinned. But they > will not indicate longterm vs not

Re: [PATCH 0/2] Intel Cherry Trail Whiskey Cove LEDs support

2019-02-11 Thread Jacek Anaszewski
On 2/11/19 2:05 PM, Pavel Machek wrote: On Mon 2019-02-11 13:59:51, Andy Shevchenko wrote: On Sun, Feb 10, 2019 at 01:12:12AM +0300, Yauhen Kharuzhy wrote: This patch series introduces new driver for controlling LEDs connected to Intel Cherry Trail Whiskey Cove PMIC (general-purpose LED and

Re: + sysctl-return-einval-if-val-violates-minmax.patch added to -mm tree

2019-02-11 Thread Christian Brauner
On Tue, Feb 12, 2019 at 12:17:16AM +0300, Alexey Dobriyan wrote: > On Mon, Feb 11, 2019 at 01:06:32PM -0800, a...@linux-foundation.org wrote: > > > @@ -2848,8 +2848,10 @@ static int __do_proc_doulongvec_minmax(v > > > - if ((min && val < *min) || (max && val > *max)) > > -

<    1   2   3   4   5   6   7   8   9   10   >