Re: [RFC][Patch v8 0/7] KVM: Guest Free Page Hinting

2019-02-19 Thread David Hildenbrand
Also one reason why I am not a fan of working with anything less than PMD order is because there have been issues in the past with false memory leaks being created when hints were provided on THP pages that essentially fragmented them. I guess hugepaged went through and >>>

Re: [PATCH][next] usb: typec: mux: remove redundant check on variable match

2019-02-19 Thread Heikki Krogerus
On Tue, Feb 19, 2019 at 01:43:33PM +, Colin King wrote: > From: Colin Ian King > > All the code paths that lead to the return statement are where > match is always true, hence the check to see if it is true is > redundant and can be removed. > > Detected by CoverityScan, CID#14769672 ("Logic

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

2019-02-19 Thread Matthew Wilcox
On Tue, Feb 19, 2019 at 02:20:26PM +0100, Jan Kara wrote: > Thanks for information. Yeah, that makes somewhat more sense. Can you ever > see the failure if you disable CONFIG_TRANSPARENT_HUGEPAGE? Because your > findings still seem to indicate that there' some problem with page > migration and Alph

Re: [RFC][Patch v8 0/7] KVM: Guest Free Page Hinting

2019-02-19 Thread David Hildenbrand
On 19.02.19 15:40, Michael S. Tsirkin wrote: > On Tue, Feb 19, 2019 at 09:06:01AM +0100, David Hildenbrand wrote: >> On 19.02.19 00:47, Alexander Duyck wrote: >>> On Mon, Feb 18, 2019 at 9:42 AM David Hildenbrand wrote: On 18.02.19 18:31, Alexander Duyck wrote: > On Mon, Feb 18, 2019

[PATCH -next] scsi: hisi_sas: remove duplicated code

2019-02-19 Thread YueHaibing
move some functions to hisi_sas_main.c, which can eliminate redundant code. Signed-off-by: YueHaibing --- drivers/scsi/hisi_sas/hisi_sas.h | 6 ++ drivers/scsi/hisi_sas/hisi_sas_main.c | 37 + drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 38 ---

Re: linux-next: build failure after merge of the asm-generic tree

2019-02-19 Thread Arnd Bergmann
On Tue, Feb 19, 2019 at 12:19 PM Hugo Lefeuvre wrote: > > > I'm not sending a pull request for this if it breaks any architectures, > > so I think we need to fix them all, and I suppose we also have to > > change all architectures in the same patch that changes the architecture > > independent dec

Re: [PATCH][next][V2] block: don't dereference a potential null bio pointer until is has been null checked

2019-02-19 Thread Dan Carpenter
On Tue, Feb 19, 2019 at 02:37:02PM +, Colin King wrote: > From: Colin Ian King > > The bio pointer is being null checked hence it can be potentially null, > however earlier it is being derefefenced on the assignment of front_seg_size. > Avoid the dereference issue by only assigning front_seg_

Re: [RFC][Patch v8 0/7] KVM: Guest Free Page Hinting

2019-02-19 Thread Michael S. Tsirkin
On Tue, Feb 19, 2019 at 09:06:01AM +0100, David Hildenbrand wrote: > On 19.02.19 00:47, Alexander Duyck wrote: > > On Mon, Feb 18, 2019 at 9:42 AM David Hildenbrand wrote: > >> > >> On 18.02.19 18:31, Alexander Duyck wrote: > >>> On Mon, Feb 18, 2019 at 8:59 AM David Hildenbrand > >>> wrote: > >

[PATCH][next][V2] block: don't dereference a potential null bio pointer until is has been null checked

2019-02-19 Thread Colin King
From: Colin Ian King The bio pointer is being null checked hence it can be potentially null, however earlier it is being derefefenced on the assignment of front_seg_size. Avoid the dereference issue by only assigning front_seg_size after bios has been null sanity checked. Fixes: dcebd755926b ("b

Re: [PATCHv3 0/4] perf tools: Assorted fixes

2019-02-19 Thread Namhyung Kim
Hi Jirka, On Tue, Feb 19, 2019 at 6:58 PM Jiri Olsa wrote: > > hi, > sending assorted general fixes that queued > up in my other branches. > > v3 changes: > - fix for fixes found by Namhyung > - new patch to use sysfs__mountpoint > > v2 changes: > - renamed the interface to struct cpu_topol

[PATCH][next] block: don't dereference a potential null bio pointer until is has been null checked

2019-02-19 Thread Colin King
From: Colin Ian King The bio pointer is being null checked hence it can be potentially null, however earlier it is being derefefenced on the assignment of front_seg_size. Avoid the dereference issue by only assigning front_seg_size after bios has been null sanity checked. Fixes: dcebd755926b ("

Re: [PATCH] cpuset: remove unused task_has_mempolicy()

2019-02-19 Thread Tejun Heo
On Mon, Feb 18, 2019 at 03:28:11PM +0900, Masahiro Yamada wrote: > This is a remnant of commit 5f155f27cb7f ("mm, cpuset: always use > seqlock when changing task's nodemask"). > > Signed-off-by: Masahiro Yamada Applied to cgroup/for-5.0. Thanks. -- tejun

Re: [PATCH v2 01/10] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY

2019-02-19 Thread Rob Herring
On Mon, Feb 18, 2019 at 9:03 PM Chunfeng Yun wrote: > > Hi, > On Tue, 2019-02-19 at 09:50 +0800, Chen Yu wrote: > > Hi, > > > > On 2019/2/19 4:18, Rob Herring wrote: > > > On Mon, Feb 18, 2019 at 07:23:01PM +0800, Yu Chen wrote: > > >> This patch adds binding documentation for supporting the hi366

Re: [PATCH v3 perf,bpf 05/11] perf, bpf: save bpf_prog_info in a rbtree in perf_env

2019-02-19 Thread Song Liu
> On Feb 19, 2019, at 12:51 AM, Jiri Olsa wrote: > > On Tue, Feb 19, 2019 at 05:52:20AM +, Song Liu wrote: >> >> >>> On Feb 17, 2019, at 3:05 PM, Jiri Olsa wrote: >>> >>> On Fri, Feb 15, 2019 at 01:53:48PM -0800, Song Liu wrote: >>> >>> SNIP >>> info_linear = bpf_program__get

[PATCH][next] ptp_qoriq: don't pass a large struct by value but instead pass it by reference

2019-02-19 Thread Colin King
From: Colin Ian King Passing the struct ptp_clock_info caps by parameter is passing over 130 bytes of data by value on the stack. Optimize this by passing it by reference instead. Also shinks the object code size: Before: textdata bss dec hex filename 125962160 64

Re: [RFC][Patch v8 0/7] KVM: Guest Free Page Hinting

2019-02-19 Thread David Hildenbrand
On 19.02.19 15:17, Nitesh Narayan Lal wrote: > On 2/19/19 8:03 AM, David Hildenbrand wrote: >> There are two main ways to avoid allocation: >> 1. do not add extra data on top of each chunk passed > If I am not wrong then this is close to what we have right now. Yes, minus the kthre

Re: [PATCH bpf-next v2] bpf: bpftool, fix documentation for attach types

2019-02-19 Thread Quentin Monnet
2019-02-19 15:13 UTC+0100 ~ Alban Crequy > From: Alban Crequy > > bpftool has support for attach types "stream_verdict" and > "stream_parser" but the documentation was referring to them as > "skb_verdict" and "skb_parse". The inconsistency comes from commit > b7d3826c2ed6 ("bpf: bpftool, add sup

Re: [RFC][Patch v8 0/7] KVM: Guest Free Page Hinting

2019-02-19 Thread Nitesh Narayan Lal
On 2/19/19 8:03 AM, David Hildenbrand wrote: > There are two main ways to avoid allocation: > 1. do not add extra data on top of each chunk passed If I am not wrong then this is close to what we have right now. >>> Yes, minus the kthread(s) and eventually with some sort of memory >>> a

Re: [PATCH][udf-next] udf: don't call mark_buffer_dirty on a null bh pointer

2019-02-19 Thread Steve Magnani
On 2/19/19 8:02 AM, Jan Kara wrote: On Tue 19-02-19 11:44:03, Colin King wrote: From: Colin Ian King There is a null check on the pointer bh to avoid a null pointer dereference on bh->b_data however later bh is passed to mark_buffer_dirty that can also cause a null pointer dereference on bh.

Re: [PATCH v6 8/9] vsprintf: Prevent crash when dereferencing invalid pointers

2019-02-19 Thread Sergey Senozhatsky
On (02/19/19 15:49), Andy Shevchenko wrote: > > On (02/19/19 13:02), Andy Shevchenko wrote: > > [..] > > > And if it's not? You will get in either case incomplete information, > > > but at least with "(e" (or even "(") you might get a clue that it > > > errornous conditions. > > > > The thing I'm

[PATCH v3] f2fs: rebuild nat_bits during umount

2019-02-19 Thread Chao Yu
From: Chao Yu If all free_nat_bitmap are available, we can rebuild nat_bits from free_nat_bitmap entirely during umount, let's make another chance to reenable nat_bits for image. Signed-off-by: Chao Yu --- v3: - fix to remove nat journal during umount. fs/f2fs/checkpoint.c | 23 +

[PATCH 2/2] ASoC: adau1977: Add support for setting MICBIAS via DT

2019-02-19 Thread Bogdan Togorean
If platform_data is NULL add reading of optional adi,micbias property from DT. If adi,micbias is not set keep the default value for micbias. Signed-off-by: Bogdan Togorean --- sound/soc/codecs/adau1977.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/c

[PATCH 0/2] ASoC: adau1977: Add support for micbias in DT

2019-02-19 Thread Bogdan Togorean
Currently micbias voltage is set based on platform_data. If driver is instantiated using DT only default voltage for micbias is possible. This patch adds the possibility to specify an optional DT property to configure the output voltage for micbias. Bogdan Togorean (2): ASoC: adau1977: Add MIC

[PATCH bpf-next v2] bpf: bpftool, fix documentation for attach types

2019-02-19 Thread Alban Crequy
From: Alban Crequy bpftool has support for attach types "stream_verdict" and "stream_parser" but the documentation was referring to them as "skb_verdict" and "skb_parse". The inconsistency comes from commit b7d3826c2ed6 ("bpf: bpftool, add support for attaching programs to maps"). This patch cha

[PATCH 1/2] ASoC: adau1977: Add MICBIAS example in DT bindings

2019-02-19 Thread Bogdan Togorean
Add MICBIAS property to the optional devicetree bindings. Signed-off-by: Bogdan Togorean --- Documentation/devicetree/bindings/sound/adi,adau1977.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/adi,adau1977.txt b/Documentation/devicetree/bi

[PATCH 1/2] arm64: dts: rockchip: replace GPIO number into macro for rk3399

2019-02-19 Thread Katsuhiro Suzuki
This patch just replace some absolute GPIO numbers of I2C, I2S, UART, SPDIF, SPI and so on for rk3399 devicetree into RK_PXn macro for more readability. Signed-off-by: Katsuhiro Suzuki --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 236 +++ 1 file changed, 118 insertions(+),

[PATCH 2/2] arm64: dts: rockchip: fix cts, rts pin assign of UART3 for rk3399

2019-02-19 Thread Katsuhiro Suzuki
This patch fixes pin assign of cts and rts signal of UART3. Currently GPIO3_C2 and C3 pins are assigned but TRM says that GPIO3_C0 and C1 are correct. Refer: RK3399 TRM v1.4 - Table 19-1 UART Interface Description Signed-off-by: Katsuhiro Suzuki --- arch/arm64/boot/dts/rockchip/rk3399.dtsi |

RE: [PATCH 1/2] regulator: da9062: Select maximum current in specific range for set_current_limit

2019-02-19 Thread Steve Twiss
Hi Axel, On 19 February 2019 13:31, Axel Lin wrote: > To: Mark Brown > Subject: [PATCH 1/2] regulator: da9062: Select maximum current in specific > range for set_current_limit > > Selecting the minimal value is only true for voltage regulators. > For current regulators the maximum in the given

[PATCH][next] soc: fsl: dpio: fix memory leak of a struct qbman on error exit path

2019-02-19 Thread Colin King
From: Colin Ian King Currently the error check for a null reg leaks a struct qbman that was allocated earlier. Fix this by kfree'ing p on the error exit path. Signed-off-by: Colin Ian King --- drivers/soc/fsl/dpio/qbman-portal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/f

Re: [PATCH] perf: fix documentation of the Flags section in perf.data

2019-02-19 Thread Jiri Olsa
On Mon, Feb 18, 2019 at 03:18:46PM +0100, Jonas Rabenstein wrote: > According to the current documentation the flags section is placed after > the file header itself but the code assumes to find the flags section > after the data section. This change updates the documentation to that > assumption.

Re: [PATCH] perf: fix HEADER_CMDLINE description in perf.data documentation

2019-02-19 Thread Jiri Olsa
On Mon, Feb 18, 2019 at 03:02:03PM +0100, Jonas Rabenstein wrote: > The content of this feature header is a perf_header_string_list of > the argument vector and not a perf_header_string of the commandline. missing your Signed-off-by Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/Documen

Re: [PATCH][udf-next] udf: don't call mark_buffer_dirty on a null bh pointer

2019-02-19 Thread Jan Kara
On Tue 19-02-19 11:44:03, Colin King wrote: > From: Colin Ian King > > There is a null check on the pointer bh to avoid a null pointer dereference > on bh->b_data however later bh is passed to mark_buffer_dirty that can also > cause a null pointer dereference on bh. Avoid this potential null poi

Re: [RFC PATCH v1 09/25] printk: remove exclusive console hack

2019-02-19 Thread Petr Mladek
On Tue 2019-02-12 15:29:47, John Ogness wrote: > In order to support printing the printk log history when new > consoles are registered, a global exclusive_console variable is > temporarily set. This only works because printk runs with > preemption disabled. > > When console printing is moved to a

Re: [PATCH] perf report: Don't shadow inlined symbol with different addr range

2019-02-19 Thread Jiri Olsa
On Tue, Feb 19, 2019 at 09:05:31PM +0800, He Kuang wrote: > We can't assume inlined symbols with the same name are equal, because > their address range may be different. This will cause the symbols with > different addresses be shadowed when adding to the hist entry, and lead > to ERANGE error when

RE: [PATCH 2/2] regulator: da9063: Select maximum current in specific range for set_current_limit

2019-02-19 Thread Steve Twiss
On 19 February 2019 13:31, Axel Lin wrote: > To: Mark Brown > Subject: [PATCH 2/2] regulator: da9063: Select maximum current in specific > range for set_current_limit > > Selecting the minimal value is only true for voltage regulators. > For current regulators the maximum in the given range sho

[PATCH][next] vhost: only return early if ret indicates an error or no iovecs have been processed

2019-02-19 Thread Colin King
From: Colin Ian King Currently the loop that calls log_write_hva on each iovec is never executed because of an incorrect error check on the return from the call to translate_desc. The check should be checking for a -ve error return and because it makes no sense to iterate over zero items, the ch

Re: [RFC PATCH v1 08/25] printk: add ring buffer and kthread

2019-02-19 Thread Petr Mladek
On Tue 2019-02-12 15:29:46, John Ogness wrote: > The printk ring buffer provides an NMI-safe interface for writing > messages to a ring buffer. Using such a buffer for alleviates printk > callers from the current burdens of disabled preemption while calling > the console drivers (and possibly print

Re: huge fsync latencies for a small file on ext4

2019-02-19 Thread Jan Kara
Hi! On Tue 19-02-19 15:50:23, stumm...@codeaurora.org wrote: > I am observing huge fsync latencies for a small file under the below test > scenario - > > process A - > Issue async write of 4GB using dd command (say large_file) on /data mounted > with ext4: > dd if=/dev/zero of=/data/testfile bs=1

Re: [PATCH v2 0/2] Fix crash in cper_estatus_check()

2019-02-19 Thread Borislav Petkov
On Tue, Feb 19, 2019 at 11:00:49AM +0100, Rafael J. Wysocki wrote: > Boris, any comments here? For both: Acked-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH v6 8/9] vsprintf: Prevent crash when dereferencing invalid pointers

2019-02-19 Thread Andy Shevchenko
On Tue, Feb 19, 2019 at 09:51:15PM +0900, Sergey Senozhatsky wrote: > On (02/19/19 13:02), Andy Shevchenko wrote: > [..] > > And if it's not? You will get in either case incomplete information, > > but at least with "(e" (or even "(") you might get a clue that it > > errornous conditions. > > The

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

2019-02-19 Thread Meelis Roos
Thanks for information. Yeah, that makes somewhat more sense. Can you ever see the failure if you disable CONFIG_TRANSPARENT_HUGEPAGE? HAVE_ARCH_TRANSPARENT_HUGEPAGE [=n] Seems there is no THP on alpha. Because your findings still seem to indicate that there' some problem with page migration a

Re: [PATCH] bpf: bpftool, fix documentation for attach types

2019-02-19 Thread Alban Crequy
On Mon, Feb 11, 2019 at 2:26 PM Quentin Monnet wrote: > > 2019-02-11 13:54 UTC+0100 ~ Alban Crequy > > From: Alban Crequy > > > > bpftool has support for attach types "stream_verdict" and > > "stream_parser" but the documentation was referring to them with > > "skb_verdict" and "skb_parse". The

Re: [RFC PATCH] docs/memory-barriers.txt: Rewrite "KERNEL I/O BARRIER EFFECTS" section

2019-02-19 Thread Arnd Bergmann
On Tue, Feb 19, 2019 at 2:20 PM Will Deacon wrote: > On Tue, Feb 19, 2019 at 02:01:50PM +0100, Arnd Bergmann wrote: > > On Tue, Feb 19, 2019 at 12:36 PM Will Deacon wrote: > > > On Tue, Feb 19, 2019 at 12:31:50PM +0100, Arnd Bergmann wrote: > > > > On Tue, Feb 19, 2019 at 11:27 AM Thomas Petazzon

[PATCH][next] usb: typec: mux: remove redundant check on variable match

2019-02-19 Thread Colin King
From: Colin Ian King All the code paths that lead to the return statement are where match is always true, hence the check to see if it is true is redundant and can be removed. Detected by CoverityScan, CID#14769672 ("Logically dead code") Signed-off-by: Colin Ian King --- drivers/usb/typec/mu

Re: [PATCH] usb: core: skip interfaces disabled in devicetree

2019-02-19 Thread Greg Kroah-Hartman
On Tue, Feb 19, 2019 at 01:24:51PM +, Måns Rullgård wrote: > Greg Kroah-Hartman writes: > > > On Sat, Feb 16, 2019 at 05:04:52PM +, Mans Rullgard wrote: > >> If an interface has an associated devicetree node with status disabled, > >> do not register the device. This is useful for boards

Re: [PATCH v6 06/18] asm-generic/tlb: Conditionally provide tlb_migrate_finish()

2019-02-19 Thread Peter Zijlstra
On Tue, Feb 19, 2019 at 12:47:38PM +, Will Deacon wrote: > Fine for now, but I agree that we should drop the hook altogether. AFAICT, > this only exists to help an ia64 optimisation which looks suspicious to > me since it uses: > > mm == current->active_mm && atomic_read(&mm->mm_users) ==

Re: [PATCH v5 1/7] irq/irq_sim: add irq_set_type() callback

2019-02-19 Thread Marc Zyngier
On Tue, 19 Feb 2019 14:20:03 +0100 Bartosz Golaszewski wrote: > wt., 19 lut 2019 o 13:25 Marc Zyngier napisał(a): > > > > On Mon, 18 Feb 2019 17:41:32 +0100 > > Bartosz Golaszewski wrote: > > > > > From: Bartosz Golaszewski > > > > > > Implement the irq_set_type() callback and call irqd_set_

Re: [PATCH 2/2] extcon intel-cht-wc: Enable external charger

2019-02-19 Thread Hans de Goede
Hi, On 18-02-19 16:07, Yauhen Kharuzhy wrote: пн, 18 февр. 2019 г. в 12:24, Hans de Goede : So, I propose: 1) save initial value of CHGDIS register for restoring it at driver remove (because the extcon-intel-cht-wc driver restores HW control in cht_wc_extcon_remove()). 2) at driver start, e

[PATCH] ARM: dts: imx6dl-yapp4: Use rgmii-id phy mode on the cpu port

2019-02-19 Thread Michal Vokáč
The PHY must add delays to both Tx and Rx clock on the cpu port to work propperly. It worked with the rgmii mode before beacause the qca8k driver (incorrecly) enabled delays in that mode. Signed-off-by: Michal Vokáč --- This imx6dl-yapp4 platform is currently waiting in linux-next. Commit 5ecdd

[PATCH 2/2] regulator: da9063: Select maximum current in specific range for set_current_limit

2019-02-19 Thread Axel Lin
Selecting the minimal value is only true for voltage regulators. For current regulators the maximum in the given range should be selected instead. Signed-off-by: Axel Lin --- drivers/regulator/da9063-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulato

[PATCH 1/2] regulator: da9062: Select maximum current in specific range for set_current_limit

2019-02-19 Thread Axel Lin
Selecting the minimal value is only true for voltage regulators. For current regulators the maximum in the given range should be selected instead. Signed-off-by: Axel Lin --- drivers/regulator/da9062-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulato

Re: [PATCH v2 3/8] dt-bindings: sdhci-omap: Add properties for using external dma

2019-02-19 Thread Faiz Abbas
Hi Rob, On 19/02/19 1:42 AM, Rob Herring wrote: > On Mon, Feb 18, 2019 at 07:11:32PM +0530, Faiz Abbas wrote: >> Hi Tony, >> >> On 16/02/19 1:37 AM, Tony Lindgren wrote: >>> * Faiz Abbas [190215 19:18]: From: Chunyan Zhang sdhci-omap can support both external dma controller via dm

Re: [PATCH v3 5/6] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2019-02-19 Thread Wolfram Sang
> > > Maybe you think that MT8183 SoC only has the I3C controllers. Actually, > > > there are I2C and I3C controllers on MT8183 SoC. We will remove > > > "mediatek,share-i3c" for I2C controller driver, so these patches are > > > just to support the I2C controllers on MT8183 SoC. For the I3C > > >

Re: [PATCH v2 4/4] phy: ti: Add a new SERDES driver for TI's AM654x SoC

2019-02-19 Thread Roger Quadros
Kishon, On 06/02/2019 13:07, Kishon Vijay Abraham I wrote: > Add a new SERDES driver for TI's AM654x SoC which configures > the SERDES only for PCIe. Support fo USB3 will be added later. > > SERDES in am654x has three input clocks (left input, externel reference > clock and right input) and two o

Re: [PATCH] usb: core: skip interfaces disabled in devicetree

2019-02-19 Thread Måns Rullgård
Greg Kroah-Hartman writes: > On Sat, Feb 16, 2019 at 05:04:52PM +, Mans Rullgard wrote: >> If an interface has an associated devicetree node with status disabled, >> do not register the device. This is useful for boards with a built-in >> multifunction USB device where some functions are bro

Re: [PATCH v4 5/6] usb:cdns3 Add Cadence USB3 DRD Driver

2019-02-19 Thread Greg KH
On Thu, Feb 14, 2019 at 07:45:13PM +, Pawel Laszczak wrote: > This patch introduce new Cadence USBSS DRD driver to linux kernel. Nit, "Linux" :) > The Cadence USBSS DRD Driver is a highly configurable IP Core whichi "whichi"? > can be instantiated as Dual-Role Device (DRD), Peripheral Only

RE: [PATCH] dt-bindings: imx: update scu resource id headfile

2019-02-19 Thread Anson Huang
Hi, Marco Best Regards! Anson Huang > -Original Message- > From: Marco Felsch [mailto:m.fel...@pengutronix.de] > Sent: 2019年2月19日 20:52 > To: Anson Huang > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; > s.ha...@pengutronix.de; ker...@pengutronix.de; feste...@gmail.c

Re: [RFC PATCH] docs/memory-barriers.txt: Rewrite "KERNEL I/O BARRIER EFFECTS" section

2019-02-19 Thread Will Deacon
On Tue, Feb 19, 2019 at 02:01:50PM +0100, Arnd Bergmann wrote: > On Tue, Feb 19, 2019 at 12:36 PM Will Deacon wrote: > > On Tue, Feb 19, 2019 at 12:31:50PM +0100, Arnd Bergmann wrote: > > > On Tue, Feb 19, 2019 at 11:27 AM Thomas Petazzoni > > > wrote: > > > > > > I think an example of this would

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

2019-02-19 Thread Jan Kara
On Tue 19-02-19 14:17:09, Meelis Roos wrote: > > > > > The result of the bisection is > > > > > [88dbcbb3a4847f5e6dfeae952d3105497700c128] blkdev: avoid migration > > > > > stalls for blkdev pages > > > > > > > > > > Is that result relevant for the problem or should I continue > > > > > bisectin

Re: [RFC] pinctrl/amd: Clear interrupt enable bits on probe

2019-02-19 Thread Hans de Goede
Hi, On 19-02-19 11:59, Leonard Crestez wrote: My Acer Nitro 5 AN515-42 laptop with a Ryzen 2700U hangs on boot because of spurious interrupts from pinctrl-amd. This seems to happen because the touchpad interrupt is enabled on boot in "level" mode and there is no way to clear it until a touchpad

Re: [PATCH v5 1/7] irq/irq_sim: add irq_set_type() callback

2019-02-19 Thread Bartosz Golaszewski
wt., 19 lut 2019 o 13:25 Marc Zyngier napisał(a): > > On Mon, 18 Feb 2019 17:41:32 +0100 > Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > Implement the irq_set_type() callback and call irqd_set_trigger_type() > > internally so that users interested in the configured trigger t

Re: [PATCH] HID: roccat: Mark expected switch fall-through

2019-02-19 Thread Jiri Kosina
On Mon, 11 Feb 2019, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/hid/hid-roccat-kone.c: In function ‘kone_keep_values_up_to_date’: > drivers/hid

Re: [PATCH v3 5/6] dt-bindings: i2c: Add Mediatek MT8183 i2c binding

2019-02-19 Thread Qii Wang
On Sat, 2019-02-16 at 13:29 +0100, Wolfram Sang wrote: > > Maybe you think that MT8183 SoC only has the I3C controllers. Actually, > > there are I2C and I3C controllers on MT8183 SoC. We will remove > > "mediatek,share-i3c" for I2C controller driver, so these patches are > > just to support the I2C

Re: [PATCH v4 2/6] usb:common Separated decoding functions from dwc3 driver.

2019-02-19 Thread Greg KH
On Thu, Feb 14, 2019 at 07:45:10PM +, Pawel Laszczak wrote: > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver > to driver/usb/common/debug.c file. These moved functions include: > dwc3_decode_get_status > dwc3_decode_set_clear_feature > dwc3_decode_set_addres

Re: [PATCH] usb: core: skip interfaces disabled in devicetree

2019-02-19 Thread Greg Kroah-Hartman
On Sat, Feb 16, 2019 at 05:04:52PM +, Mans Rullgard wrote: > If an interface has an associated devicetree node with status disabled, > do not register the device. This is useful for boards with a built-in > multifunction USB device where some functions are broken or otherwise > undesired. > >

Re: [RFC PATCH net-next v3 04/21] ethtool: helper functions for netlink interface

2019-02-19 Thread Michal Kubecek
On Mon, Feb 18, 2019 at 12:15:17PM -0800, Jakub Kicinski wrote: > On Mon, 18 Feb 2019 19:21:44 +0100 (CET), Michal Kubecek wrote: > > +/* create skb for a reply and fill device identification > > + * payload: payload length (without netlink and genetlink header) > > + * dev: device the reply is

[PATCH] perf report: Don't shadow inlined symbol with different addr range

2019-02-19 Thread He Kuang
We can't assume inlined symbols with the same name are equal, because their address range may be different. This will cause the symbols with different addresses be shadowed when adding to the hist entry, and lead to ERANGE error when checking the symbol address during sample parse, the addr should

Re: Linux-next 20190218: am57xx-evm: mmc1: ADMA error

2019-02-19 Thread Faiz Abbas
Hi Naresh, On 18/02/19 6:57 PM, Naresh Kamboju wrote: > Do you see this error on am57xx-evm running Linux next 20190218 ? > I have tested on multiple devices and found this error. > Please find the full boot log [1]. > Am i missing any pre required configs [2] ? > > [5.620263] mmc1: ADMA erro

Re: [RFC][Patch v8 0/7] KVM: Guest Free Page Hinting

2019-02-19 Thread David Hildenbrand
There are two main ways to avoid allocation: 1. do not add extra data on top of each chunk passed >>> If I am not wrong then this is close to what we have right now. >> Yes, minus the kthread(s) and eventually with some sort of memory >> allocation for the request. Once you're asynchronou

[PATCH v2 2/4] ARM: dts: exynos: Add high speed I2C ports for exynos5260

2019-02-19 Thread Stuart Menefy
From: Stuart Menefy Most of the work to support the high speed I2C ports on the Exynos 5260 was added in commit 218e1496135e ("i2c: exynos5: add support for HSI2C on Exynos5260 SoC") and the pinctrl nodes have always been available. All that is missing to get them working is the additon of the DT

[PATCH v2 4/4] ARM: dts: exynos: Fix interrupt for shared EINTs on Exynos5260

2019-02-19 Thread Stuart Menefy
From: Stuart Menefy Fix the interrupt information for the GPIO lines with a shared EINT interrupt. Signed-off-by: Stuart Menefy --- arch/arm/boot/dts/exynos5260.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5260.dtsi b/arch/arm/boot/dts/exyno

[PATCH v2 3/4] ARM: dts: exynos: Add interrupts for dedicated EINTs on Exynos5260

2019-02-19 Thread Stuart Menefy
From: Stuart Menefy Add the missing interrupt information for the GPIO lines with dedicated EINT interrupts. Signed-off-by: Stuart Menefy --- arch/arm/boot/dts/exynos5260-pinctrl.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/exynos5260-pinctrl.dts

[PATCH] ARM: dts: rockchip: remove disable-wp from rv1108-elgin-r1 emmc node

2019-02-19 Thread Johan Jonker
The mmc.txt didn't explicitly say disable-wp is for SD card slot only, but that is what it was designed for in the first place. Remove all disable-wp from emmc or sdio controllers. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rv1108-elgin-r1.dts | 1 - 1 file changed, 1 deletion(-) diff --

[PATCH v2 0/4] Devicetree updates for Exynos 5260

2019-02-19 Thread Stuart Menefy
These four patches are stand alone updates for the Exynos 5260 device tree, which do not depend on any other code changes. They either fix issues or add functionality which is already available on other Exynos devices. They were previously posted as version 1 of the larger patch series "Resuscitate

[PATCH v2 1/4] ARM: dts: exynos: Use bustop PLL as the source for MMC clocks on Exynos5260

2019-02-19 Thread Stuart Menefy
From: Stuart Menefy By default the MMC clock will be derived from mediatop PLL, which usually runs at 666MHz. However as most SD and MMC clocks are multiples or fractions of 100MHz, it makes more sense to use the bustop PLL which runs at 800MHz. This matches the behaviour of the Samsung vendor su

Re: [RFC PATCH] docs/memory-barriers.txt: Rewrite "KERNEL I/O BARRIER EFFECTS" section

2019-02-19 Thread Arnd Bergmann
On Tue, Feb 19, 2019 at 12:36 PM Will Deacon wrote: > On Tue, Feb 19, 2019 at 12:31:50PM +0100, Arnd Bergmann wrote: > > On Tue, Feb 19, 2019 at 11:27 AM Thomas Petazzoni > > wrote: > > > > I think an example of this would be a driver using outb() to disable > > an interrupt, and then relying on

Re: [RFC PATCH 01/31] mm: migrate: Add exchange_pages to exchange two lists of pages.

2019-02-19 Thread Matthew Wilcox
On Tue, Feb 19, 2019 at 01:12:07PM +0530, Anshuman Khandual wrote: > But the location of this temp page matters as well because you would like to > saturate the inter node interface. It needs to be either of the nodes where > the source or destination page belongs. Any other node would generate two

Re: [RFC][Patch v8 0/7] KVM: Guest Free Page Hinting

2019-02-19 Thread Nitesh Narayan Lal
On 2/18/19 9:46 PM, Andrea Arcangeli wrote: > Hello, > > On Mon, Feb 18, 2019 at 03:47:22PM -0800, Alexander Duyck wrote: >> essentially fragmented them. I guess hugepaged went through and >> started trying to reassemble the huge pages and as a result there have >> been apps that ended up consumin

Re: [PATCH] dt-bindings: imx: update scu resource id headfile

2019-02-19 Thread Marco Felsch
Hi Anson, On 19-02-19 09:01, Anson Huang wrote: > Update i.MX SCU resource ID table according to latest > system controller firmware. will this happen every time the scu firmware gets a update? Regards, Marco > Signed-off-by: Anson Huang > --- > include/dt-bindings/firmware/imx/rsrc.h | 39 >

[PATCH] misc: rtsx: Enable OCP for rts522a rts524a rts525a rts5260

2019-02-19 Thread ricky_wu
From: RickyWu this enables and adds OCP function for Realtek A series cardreader chips and fixes some OCP flow in rts5260.c Signed-off-by: RickyWu --- drivers/misc/cardreader/rts5227.c | 64 +++--- drivers/misc/cardreader/rts5249.c | 32 +-- drivers/misc/cardreader/rts5260.c |

Re: [PATCH v6 8/9] vsprintf: Prevent crash when dereferencing invalid pointers

2019-02-19 Thread Sergey Senozhatsky
On (02/19/19 13:02), Andy Shevchenko wrote: [..] > And if it's not? You will get in either case incomplete information, > but at least with "(e" (or even "(") you might get a clue that it > errornous conditions. The thing I'm signaling here is that in some cases we still can crash the kernel; with

Re: [PATCH v2 15/20] vmalloc: New flags for safe vfree on special perms

2019-02-19 Thread Borislav Petkov
On Mon, Jan 28, 2019 at 04:34:17PM -0800, Rick Edgecombe wrote: > This adds a new flags VM_HAS_SPECIAL_PERMS, for enabling vfree operations s/This adds/add/ - you get the idea. :) s/flags/flag/ > to immediately clear executable TLB entries to freed pages, and handle > freeing memory with special

Re: [PATCH v6 13/18] asm-generic/tlb: Introduce HAVE_MMU_GATHER_NO_GATHER

2019-02-19 Thread Will Deacon
On Tue, Feb 19, 2019 at 11:32:01AM +0100, Peter Zijlstra wrote: > Add the Kconfig option HAVE_MMU_GATHER_NO_GATHER to the generic > mmu_gather code. If the option is set the mmu_gather will not > track individual pages for delayed page free anymore. A platform > that enables the option needs to pro

Re: [RFC][Patch v8 0/7] KVM: Guest Free Page Hinting

2019-02-19 Thread Nitesh Narayan Lal
On 2/18/19 4:04 PM, David Hildenbrand wrote: > On 18.02.19 21:40, Nitesh Narayan Lal wrote: >> On 2/18/19 3:31 PM, Michael S. Tsirkin wrote: >>> On Mon, Feb 18, 2019 at 09:04:57PM +0100, David Hildenbrand wrote: > So I'm fine with a simple implementation but the interface needs to

Re: [PATCH] sched/x86: Save [ER]FLAGS on context switch

2019-02-19 Thread Will Deacon
On Tue, Feb 19, 2019 at 10:04:09AM +0100, Peter Zijlstra wrote: > On Mon, Feb 18, 2019 at 02:30:21PM -0800, H. Peter Anvin wrote: > > On 2/16/19 2:30 AM, Peter Zijlstra wrote: > > > On Fri, Feb 15, 2019 at 08:06:56PM -0800, h...@zytor.com wrote: > > >> This implies we invoke schedule -- a restricte

Re: [PATCH v6 05/18] asm-generic/tlb: Provide generic tlb_flush() based on flush_tlb_mm()

2019-02-19 Thread Will Deacon
On Tue, Feb 19, 2019 at 11:31:53AM +0100, Peter Zijlstra wrote: > When an architecture does not have (an efficient) flush_tlb_range(), > but instead always uses full TLB invalidates, the current generic > tlb_flush() is sub-optimal, for it will generate extra flushes in > order to keep the range sm

Re: [PATCH 4.20 00/92] 4.20.11-stable review

2019-02-19 Thread Greg Kroah-Hartman
On Tue, Feb 19, 2019 at 11:18:30AM +0530, Naresh Kamboju wrote: > On Mon, 18 Feb 2019 at 19:15, Greg Kroah-Hartman > wrote: > > > > This is the start of the stable review cycle for the 4.20.11 release. > > There are 92 patches in this series, all will be posted as a response > > to this one. If a

Re: [PATCH v6 14/18] s390/tlb: convert to generic mmu_gather

2019-02-19 Thread Will Deacon
On Tue, Feb 19, 2019 at 11:32:02AM +0100, Peter Zijlstra wrote: > > Cc: heiko.carst...@de.ibm.com > Cc: npig...@gmail.com > Cc: a...@linux-foundation.org > Cc: aneesh.ku...@linux.vnet.ibm.com > Cc: will.dea...@arm.com > Cc: Linus Torvalds > Cc: li...@armlinux.org.uk > Signed-off-by: Martin Schwid

Re: [PATCH v6 06/18] asm-generic/tlb: Conditionally provide tlb_migrate_finish()

2019-02-19 Thread Will Deacon
On Tue, Feb 19, 2019 at 11:31:54AM +0100, Peter Zijlstra wrote: > Needed for ia64 -- alternatively we drop the entire hook. > > Cc: Will Deacon > Cc: "Aneesh Kumar K.V" > Cc: Andrew Morton > Cc: Nick Piggin > Signed-off-by: Peter Zijlstra (Intel) > --- > include/asm-generic/tlb.h |2 ++ >

Re: [PATCH v6 09/18] ia64/tlb: Conver to generic mmu_gather

2019-02-19 Thread Will Deacon
On Tue, Feb 19, 2019 at 11:31:57AM +0100, Peter Zijlstra wrote: > Generic mmu_gather provides everything ia64 needs (range tracking). > > Cc: Will Deacon > Cc: "Aneesh Kumar K.V" > Cc: Andrew Morton > Cc: Nick Piggin > Cc: Tony Luck > Signed-off-by: Peter Zijlstra (Intel) > --- > arch/ia64/

Re: [PATCH 4.14 00/62] 4.14.102-stable review

2019-02-19 Thread Greg Kroah-Hartman
On Tue, Feb 19, 2019 at 09:32:25AM +, Jon Hunter wrote: > > On 18/02/2019 13:43, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.102 release. > > There are 62 patches in this series, all will be posted as a response > > to this one. If anyone has any is

Re: [PATCH 0/2] "pcie_aux" clock for i.MX8MQ

2019-02-19 Thread Lucas Stach
Hi Lorenzo, Am Dienstag, den 19.02.2019, 12:42 + schrieb Lorenzo Pieralisi: > On Mon, Feb 11, 2019 at 05:51:06PM -0800, Andrey Smirnov wrote: > > Lorenzo: > > > > This small series adds code to control "pcie_aux" clock. This is an > > oversight from original submission [pcie-imx8mq-v7], which

Re: [PATCH 0/2] "pcie_aux" clock for i.MX8MQ

2019-02-19 Thread Lorenzo Pieralisi
On Mon, Feb 11, 2019 at 05:51:06PM -0800, Andrey Smirnov wrote: > Lorenzo: > > This small series adds code to control "pcie_aux" clock. This is an > oversight from original submission [pcie-imx8mq-v7], which was only > discovered once I submitted an RFC for corresponding DT changes going > via i.M

Re: [PATCH] tty: not call tty close in fallback

2019-02-19 Thread Greg KH
On Mon, Jan 14, 2019 at 02:56:01PM +0800, yes wrote: > From: Li RongQing > > when fail to open tty, tty is not in open status and not need > to call close > > Signed-off-by: Li RongQing > --- > drivers/tty/serdev/serdev-ttyport.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >

Re: [PATCH 0/2] eeprom: at24: new property

2019-02-19 Thread Greg Kroah-Hartman
On Tue, Feb 12, 2019 at 03:12:05PM +0100, Bartosz Golaszewski wrote: > wt., 5 lut 2019 o 15:00 Bartosz Golaszewski napisał(a): > > > > From: Bartosz Golaszewski > > > > Microchip 24aa02t EEPROM is compatible with Atmel 24c02 except that > > it's visible on 8 i2c slave addresses. We already suppor

Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2019-02-19 Thread Oleg Nesterov
On 02/18, Guenter Roeck wrote: > > Unfortunately, this patch causes one of my qemu emulations to crash. > The crash is not always seen, but at least with every other boot attempt. Hmm. I can't imagine how this change can cause the null-ptr-deref in blk_mq_run_hw_queue(). > Reverting the patch fix

Re: [RFC PATCH net-next v3 00/21] ethtool netlink interface, part 1

2019-02-19 Thread Jiri Pirko
Tue, Feb 19, 2019 at 12:57:27PM CET, mkube...@suse.cz wrote: >On Tue, Feb 19, 2019 at 11:35:08AM +0100, Jiri Pirko wrote: >> >- some features provided by ethtool would rather belong to devlink (and >> > some are already superseded by devlink); however, only few drivers >> > provide devlink interf

Re: [PULL] topic/mei-hdcp

2019-02-19 Thread Greg KH
On Tue, Feb 19, 2019 at 08:55:27AM +0100, Daniel Vetter wrote: > Hi all, > > topic/mei-hdcp-2019-02-19: > Prep patches + headers for the mei-hdcp/i915 component interfaces > > Also contains the prep work in the component helpers plus adjustements > for the snd-hda/i915 component interface. > > P

[PATCH] mm: migrate: add missing flush_dcache_page for non-mapped page migrate

2019-02-19 Thread Lars Persson
Our MIPS 1004Kc SoCs were seeing random userspace crashes with SIGILL and SIGSEGV that could not be traced back to a userspace code bug. They had all the magic signs of an I/D cache coherency issue. Now recently we noticed that the /proc/sys/vm/compact_memory interface was quite efficient at provo

Re: [PATCH v5 1/7] irq/irq_sim: add irq_set_type() callback

2019-02-19 Thread Marc Zyngier
On Mon, 18 Feb 2019 17:41:32 +0100 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Implement the irq_set_type() callback and call irqd_set_trigger_type() > internally so that users interested in the configured trigger type can > later retrieve it using irqd_get_trigger_type(). > > S

<    3   4   5   6   7   8   9   10   11   >