Re: [PATCH -next] crypto: marvell - Remove set but not used variable 'ivsize'

2019-02-27 Thread Herbert Xu
On Mon, Feb 18, 2019 at 08:59:47AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/crypto/marvell/cipher.c: In function 'mv_cesa_skcipher_dma_req_init': > drivers/crypto/marvell/cipher.c:325:15: warning: > variable 'ivsize' set but not used

RE: [PATCH V7 1/2] arm64: dts: freescale: imx8qxp: add cpu opp table

2019-02-27 Thread Anson Huang
Hi, Shawn Best Regards! Anson Huang > -Original Message- > From: Shawn Guo [mailto:shawn...@kernel.org] > Sent: 2019年2月28日 11:19 > To: Anson Huang > Cc: robh...@kernel.org; mark.rutl...@arm.com; s.ha...@pengutronix.de; > ker...@pengutronix.de; feste...@gmail.com;

RE: [PATCH V3 2/4] watchdog: imx_sc: Add i.MX system controller watchdog support

2019-02-27 Thread Anson Huang
Hi, Guenter Best Regards! Anson Huang > -Original Message- > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter > Roeck > Sent: 2019年2月27日 6:39 > To: Anson Huang > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; > s.ha...@pengutronix.de;

Re: [RFC PATCH 1/4] X.509: Parse public key parameters from x509 for akcipher

2019-02-27 Thread Herbert Xu
On Sun, Feb 24, 2019 at 09:48:40AM +0300, Vitaly Chikunov wrote: > > If we pass SubjectPublicKeyInfo into set_pub_key itself (making > set_params not needed) we will break ABI and compatibility with RSA > drivers, because whole SubjectPublicKeyInfo is not expected by the This compatibility does

Re: [PATCH v3 5/5] tracing/probe: Support user-space dereference

2019-02-27 Thread Masami Hiramatsu
On Wed, 27 Feb 2019 21:42:45 -0500 Steven Rostedt wrote: > On Wed, 27 Feb 2019 23:44:42 +0900 > Masami Hiramatsu wrote: > > > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c > > index a7012de37a00..0efef172db17 100644 > > --- a/kernel/trace/trace_probe.c > > +++

Re: [PATCH 0/3] RPMPD for QCS404

2019-02-27 Thread Sibi Sankar
On 2019-02-25 18:18, Rajendra Nayak wrote: On 2/21/2019 12:14 PM, Bjorn Andersson wrote: Reworkd the macros of the rpmpd driver and add qcs404 power domains, then add this to the dts. For the entire series, Reviewed-by: Rajendra Nayak I'll post v2 of this series with support for msm8998

Re: [PATCH v2] cifs: use correct format characters

2019-02-27 Thread Steve French
merged into cifs-2.6.git for-next On Wed, Feb 27, 2019 at 4:27 PM Louis Taylor wrote: > > When compiling with -Wformat, clang emits the following warnings: > > fs/cifs/smb1ops.c:312:20: warning: format specifies type 'unsigned > short' but the argument has type 'unsigned int' [-Wformat] >

[GIT] Crypto Fixes for 5.0

2019-02-27 Thread Herbert Xu
Hi Linus: This push fixes a compiler warning introduced by a previous fix, as well as two crash bugs on ARM. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus Ard Biesheuvel (2): crypto: sha256/arm - fix crash bug in Thumb2 build crypto:

Re: [PATCH] powernv: powercap: Add hard minimum powercap

2019-02-27 Thread Shilpasri G Bhat
Hi, On 02/28/2019 10:14 AM, Daniel Axtens wrote: > Shilpasri G Bhat writes: > >> In POWER9, OCC(On-Chip-Controller) provides for hard and soft system >> powercapping range. The hard powercap range is guaranteed while soft >> powercap may or may not be asserted due to various power-thermal >>

Re: [PATCH net-next] net: hns: use struct_size() in devm_kzalloc()

2019-02-27 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 25 Feb 2019 18:27:57 -0600 > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct

[PATCH] soc: qcom: cmd-db: Fix an error code in cmd_db_dev_probe()

2019-02-27 Thread Dan Carpenter
The memremap() function doesn't return error pointers, it returns NULL. This code is returning "ret = PTR_ERR(NULL);" which is success, but it should return -ENOMEM. Fixes: 312416d9171a ("drivers: qcom: add command DB driver") Signed-off-by: Dan Carpenter --- drivers/soc/qcom/cmd-db.c | 4 ++--

Re: Request for suggestion on net device re-naming/re-ordering based on DT alias

2019-02-27 Thread Harini Katakam
On Thu, Feb 28, 2019 at 12:10 AM Stephen Hemminger wrote: > > On Wed, 27 Feb 2019 17:24:03 +0530 > Harini Katakam wrote: > > > Device naming is a hard problem, and there is no perfect solution. > > Device tree should be providing hints to userspace policy for naming, not > trying to do it in

Re: [PATCH v6 8/8] arm64: dts: qcom: sdm845: Add Q6V5 MSS node

2019-02-27 Thread Sibi Sankar
Hey Doug, On 2019-02-28 02:33, Doug Anderson wrote: Hi, On Tue, Feb 26, 2019 at 3:54 PM Doug Anderson wrote: Hi, On Tue, Feb 5, 2019 at 9:13 PM Bjorn Andersson wrote: > > From: Sibi Sankar > > This patch adds Q6V5 MSS remoteproc node for SDM845 SoCs. > > Signed-off-by: Sibi Sankar >

Re: [PATCH net-next 0/2] net: phy: marvell10g: Clean .get_features by using C45 helpers

2019-02-27 Thread David Miller
From: Maxime Chevallier Date: Mon, 25 Feb 2019 17:14:05 +0100 > Recent work on C45 helpers by Heiner made the > genphy_c45_pma_read_abilities function generic enough to use as a > default .get_featutes implementation. > > This series removes the remaining redundant code in >

Re: [PATCH v5 04/10] crypto: akcipher - new verify API for public key algorithms

2019-02-27 Thread Vitaly Chikunov
On Wed, Feb 27, 2019 at 06:28:37PM -0500, Mimi Zohar wrote: > > On Sun, 2019-02-24 at 09:08 +0300, Vitaly Chikunov wrote: > > Previous akcipher .verify() just `decrypts' (using RSA encrypt which is > > using public key) signature to uncover message hash, which was then > > compared in upper level

Re: [RFC v9 5/5] Documentation: pstore/blk: create document for pstore_blk

2019-02-27 Thread Randy Dunlap
On 2/19/19 3:52 AM, liaoweixiong wrote: > The document, at Documentation/admin-guide/pstore-block.rst, > tells user how to use pstore_blk and the attentions about panic > read/write > > Signed-off-by: liaoweixiong > --- > Documentation/admin-guide/pstore-block.rst | 233 >

[PATCH][v2] time: Introduce jiffies64_to_msecs()

2019-02-27 Thread Li RongQing
there is a similar helper in net/netfilter/nf_tables_api.c, this maybe become a common request someday, so move it to time.c Signed-off-by: Zhang Yu Signed-off-by: Li RongQing --- v1-->v2: using jiffies64_to_msecs in nf_tables_api.c include/linux/jiffies.h | 1 + kernel/time/time.c

[PATCH v5 perf,bpf 02/15] bpf: libbpf: introduce bpf_program__get_prog_info_linear()

2019-02-27 Thread Song Liu
Currently, bpf_prog_info includes 9 arrays. The user has the option to fetch any combination of these arrays. However, this requires a lot of handling of these arrays. This work becomes more tricky when we need to store bpf_prog_info to a file, because these arrays are allocated independently.

[PATCH v5 perf,bpf 01/15] perf, bpf: consider events with attr.bpf_event as side-band events

2019-02-27 Thread Song Liu
Events with bpf_event should be considered as side-band event, as they carry information about BPF programs. Fixes: 6ee52e2a3fe4 ("perf, bpf: Introduce PERF_RECORD_BPF_EVENT") Signed-off-by: Song Liu --- kernel/events/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v5 perf,bpf 05/15] perf: change prototype of perf_event__synthesize_bpf_events()

2019-02-27 Thread Song Liu
This patch changes the arguments of perf_event__synthesize_bpf_events() to include perf_session* instead of perf_tool*. perf_session will be used in the next patch. Signed-off-by: Song Liu --- tools/perf/builtin-record.c | 2 +- tools/perf/builtin-top.c| 2 +- tools/perf/util/bpf-event.c |

[PATCH v5 perf,bpf 00/15] perf annotation of BPF programs

2019-02-27 Thread Song Liu
Changes v4 to v5: 1. Rebase to latest bpf-next; 2. Add dependency of 94816add0005 from Arnaldo's tree; 3. More details in change logs; 4. Add perf_env__init() to init bpf related lock and rbtrees; 5. Small clean ups. Changes v3 to v4: 1. Incorporate feedbacks from Jiri and Namhyung; 2. Fixed

[PATCH v5 perf,bpf 09/15] perf, bpf: save btf information as headers to perf.data

2019-02-27 Thread Song Liu
This patch enables perf-record to save btf information as headers to perf.data A new header type HEADER_BPF_BTF is introduced for this data. Signed-off-by: Song Liu --- tools/perf/util/header.c | 108 ++- tools/perf/util/header.h | 1 + 2 files changed, 108

[PATCH v5 perf,bpf 08/15] perf, bpf: save btf in a rbtree in perf_env

2019-02-27 Thread Song Liu
btf contains information necessary to annotate bpf programs. This patch saves btf for bpf programs loaded in the system. Signed-off-by: Song Liu --- tools/perf/util/bpf-event.c | 24 ++ tools/perf/util/bpf-event.h | 7 tools/perf/util/env.c | 65

[PATCH v5 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data

2019-02-27 Thread Song Liu
This patch enables perf-record to save bpf_prog_info information as headers to perf.data. A new header type HEADER_BPF_PROG_INFO is introduced for this data. Signed-off-by: Song Liu --- tools/perf/util/header.c | 143 ++- tools/perf/util/header.h | 1 + 2

[PATCH v5 perf,bpf 06/15] perf, bpf: save bpf_prog_info in a rbtree in perf_env

2019-02-27 Thread Song Liu
bpf_prog_info contains information necessary to annotate bpf programs. This patch saves bpf_prog_info for bpf programs loaded in the system. Some big picture of the next few patches: To fully annotate BPF programs with source code mapping, 4 different information are needed: 1)

[PATCH v5 perf,bpf 14/15] perf: introduce side band thread

2019-02-27 Thread Song Liu
This patch introduces side band thread that captures extended information for events like PERF_RECORD_BPF_EVENT. This new thread uses its own evlist that uses ring buffer with very low watermark for lower latency. In the next patch, we uses this thread to handle PERF_RECORD_BPF_EVENT.

[PATCH v5 perf,bpf 12/15] perf, bpf: enable annotation of bpf program

2019-02-27 Thread Song Liu
This patch enables the annotation of bpf program. A new dso type DSO_BINARY_TYPE__BPF_PROG_INFO is introduced to for BPF programs. In symbol__disassemble(), DSO_BINARY_TYPE__BPF_PROG_INFO dso calls into a new function symbol__disassemble_bpf(), where annotation line information is filled based

[PATCH v5 perf,bpf 15/15] perf, bpf: save bpf_prog_info and btf of short living bpf programs

2019-02-27 Thread Song Liu
To fully annotate BPF programs with source code mapping, 4 different information are needed: 1) PERF_RECORD_KSYMBOL 2) PERF_RECORD_BPF_EVENT 3) bpf_prog_info 4) btf This patch handles 3) and 4) for short living BPF programs. For timely process of these information, a dedicated

[PATCH v5 perf,bpf 11/15] perf: add -lopcodes to feature-libbfd

2019-02-27 Thread Song Liu
Both libbfd and libopcodes are distributed with binutil-dev/devel. When libbfd presents, it is OK to assume libopcodes also presents. This has been a safe assumption for bpftool. This patch adds -lopcodes to perf/Makefile.config. libopcodes will be used in the next commit for bpf annotation.

[PATCH v5 perf,bpf 13/15] perf, bpf: process PERF_BPF_EVENT_PROG_LOAD for annotation

2019-02-27 Thread Song Liu
This patch adds processing of PERF_BPF_EVENT_PROG_LOAD, which sets proper DSO type/id/etc of memory regions mapped to BPF programs to DSO_BINARY_TYPE__BPF_PROG_INFO Signed-off-by: Song Liu --- tools/perf/util/bpf-event.c | 53 + 1 file changed, 53

[PATCH v5 perf,bpf 03/15] bpf: bpftool: use bpf_program__get_prog_info_linear() in prog.c:do_dump()

2019-02-27 Thread Song Liu
This patches uses bpf_program__get_prog_info_linear() to simplify the logic in prog.c do_dump(). Cc: Daniel Borkmann Cc: Alexei Starovoitov Signed-off-by: Song Liu --- tools/bpf/bpftool/prog.c | 266 +-- 1 file changed, 59 insertions(+), 207 deletions(-)

[PATCH v5 perf,bpf 10/15] perf-top: add option --no-bpf-event

2019-02-27 Thread Song Liu
bpf events should be tracked by default for perf-top. This patch makes it on by default, and adds option to disable bpf events. Signed-off-by: Song Liu --- tools/perf/builtin-top.c | 3 +++ tools/perf/util/top.h| 1 + 2 files changed, 4 insertions(+) diff --git a/tools/perf/builtin-top.c

[PATCH v5 perf,bpf 04/15] perf, bpf: synthesize bpf events with bpf_program__get_prog_info_linear()

2019-02-27 Thread Song Liu
With bpf_program__get_prog_info_linear, we can simplify the logic that synthesizes bpf events. This patch doesn't change the behavior of the code. Signed-off-by: Song Liu --- tools/perf/util/bpf-event.c | 118 1 file changed, 40 insertions(+), 78

Re: [PATCH 4/5] ocxl: Remove superfluous 'extern' from headers

2019-02-27 Thread Andrew Donnellan
On 27/2/19 3:57 pm, Alastair D'Silva wrote: From: Alastair D'Silva The 'extern' keyword adds no value here. Signed-off-by: Alastair D'Silva Acked-by: Andrew Donnellan --- drivers/misc/ocxl/ocxl_internal.h | 54 +++ include/misc/ocxl.h | 36

Re: [PATCH 3/5] ocxl: read_pasid never returns an error, so make it void

2019-02-27 Thread Andrew Donnellan
On 27/2/19 3:57 pm, Alastair D'Silva wrote: From: Alastair D'Silva No need for a return value in read_pasid as it only returns 0. Signed-off-by: Alastair D'Silva Reviewed-by: Greg Kurz Acked-by: Andrew Donnellan --- drivers/misc/ocxl/config.c | 9 ++--- 1 file changed, 2

Re: [PATCH 2/5] ocxl: Clean up printf formats

2019-02-27 Thread Andrew Donnellan
On 27/2/19 3:57 pm, Alastair D'Silva wrote: From: Alastair D'Silva Use %# instead of using a literal '0x' Signed-off-by: Alastair D'Silva Not hugely fussed either way, but today I learned about %#... Acked-by: Andrew Donnellan --- drivers/misc/ocxl/config.c | 6 +++---

linux-next: manual merge of the staging tree with the net-next tree

2019-02-27 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the staging tree got a conflict in: drivers/staging/fsl-dpaa2/ethsw/ethsw.c between commit: 570b68c8ddde ("staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_SET") from the net-next tree and commit: 11f27765f611 ("staging: fsl-dpaa2: ethsw: Add

[LKP] [rcu] 7e28c5af4e: will-it-scale.per_process_ops 84.7% improvement

2019-02-27 Thread kernel test robot
Greeting, FYI, we noticed a 84.7% improvement of will-it-scale.per_process_ops due to commit: commit: 7e28c5af4ef6b539334aa5de40feca0c041c94df ("rcu: Eliminate ->rcu_qs_ctr from the rcu_dynticks structure") https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master in testcase:

Re: [PATCH] powernv: powercap: Add hard minimum powercap

2019-02-27 Thread Daniel Axtens
Shilpasri G Bhat writes: > In POWER9, OCC(On-Chip-Controller) provides for hard and soft system > powercapping range. The hard powercap range is guaranteed while soft > powercap may or may not be asserted due to various power-thermal > reasons based on system configuration and workloads. This

Re: [PATCH] printk: Ratelimit messages printed by console drivers

2019-02-27 Thread Sergey Senozhatsky
On (02/26/19 19:24), Tetsuo Handa wrote: > Does memory allocation by network stack / driver while trying to emit > the messages include __GFP_DIRECT_RECLAIM flag (e.g. GFP_KERNEL) ? > Commit 400e22499dd92613821 handles only memory allocations with > __GFP_DIRECT_RECLAIM flag. If memory allocation

Re: [PATCH net-next 4/6] ethernet: eth: add default vid len for all ehternet kind devices

2019-02-27 Thread Florian Fainelli
On 2/26/2019 10:45 AM, Ivan Khoronzhuk wrote: > IVDF - individual virtual device filtering. Allows to set per vlan > l2 address filters on end real network device (for unicast and for > multicast) and drop redundant not expected packet income. > > If CONFIG_VLAN_8021Q_IVDF is enabled the

Re: [PATCH v2] posix-cpu-timers: Avoid undefined behaviour in timespec64_to_ns()

2019-02-27 Thread Deepa Dinamani
On Tue, Feb 26, 2019 at 11:52 PM Xiongfeng Wang wrote: > > When I ran Syzkaller testsuite, I got the following call trace. > > UBSAN: Undefined behaviour in ./include/linux/time64.h:120:27 > signed integer overflow:

Re: [PATCH net-next 1/6] net: core: dev_addr_lists: add VID to device address

2019-02-27 Thread Florian Fainelli
On 2/26/2019 10:45 AM, Ivan Khoronzhuk wrote: > Despite this is supposed to be used for Ethernet VLANs, not Ethernet > addresses with space for VID also can reuse this, so VID is considered > as virtual ID extension, not belonging strictly to Ethernet VLAN VIDs, > and overall change can be named

Re: [RFC v4 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-02-27 Thread Brendan Higgins
On Fri, Feb 22, 2019 at 12:53 PM Thiago Jung Bauermann wrote: > > > Frank Rowand writes: > > > On 2/19/19 10:34 PM, Brendan Higgins wrote: > >> On Mon, Feb 18, 2019 at 12:02 PM Frank Rowand > >> wrote: > >> > >>> I have not read through the patches in any detail. I have read some of > >>>

Re: [PATCH net-next 5/6] net: ethernet: ti: cpsw: update mc filtering to use IVDF

2019-02-27 Thread Florian Fainelli
On 2/26/2019 10:45 AM, Ivan Khoronzhuk wrote: > The cpsw can filter multicast addresses only per vlan. Thus if mcast > address is set for one of them or only for real device it must be > added for every created vlan consuming ALE table w/o reason. In order to > simplify dispatching vlan

Re: [RFC v4 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-02-27 Thread Brendan Higgins
On Tue, Feb 19, 2019 at 10:46 PM Frank Rowand wrote: > > On 2/19/19 10:34 PM, Brendan Higgins wrote: > > On Mon, Feb 18, 2019 at 12:02 PM Frank Rowand > > wrote: > > > >> I have not read through the patches in any detail. I have read some of > >> the code to try to understand the patches to

Re: [PATCH net-next 3/6] net: 8021q: vlan_dev: add vid tag for vlan device own address

2019-02-27 Thread Florian Fainelli
On 2/26/2019 10:45 AM, Ivan Khoronzhuk wrote: > The vlan device address is held separately from uc/mc lists and > handled differently. The vlan dev address is bound with real device > address only if it's inherited from init, in all other cases it's > separate address entry in uc list. With vid

Re: [PATCH] xfrm: policy: Fix possible user after free in __xfrm_policy_unlink

2019-02-27 Thread Herbert Xu
On Thu, Feb 28, 2019 at 11:16:23AM +0800, Yue Haibing wrote: > > diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c > index 8d1a898..b27eb742 100644 > --- a/net/xfrm/xfrm_policy.c > +++ b/net/xfrm/xfrm_policy.c > @@ -316,6 +316,8 @@ static void xfrm_policy_timer(struct timer_list *t) >

[PATCH V3] cpufreq: kryo: Release OPP tables on module removal

2019-02-27 Thread Viresh Kumar
Commit 5ad7346b4ae2 ("cpufreq: kryo: Add module remove and exit") made it possible to build the kryo cpufreq driver as a module, but it failed to release all the resources, i.e. OPP tables, when the module is unloaded. This patch fixes it by releasing the OPP tables, by calling

Re: [PATCH net-next 2/6] net: 8021q: vlan_dev: add vid tag to addresses of uc and mc lists

2019-02-27 Thread Florian Fainelli
On 2/26/2019 10:45 AM, Ivan Khoronzhuk wrote: > Update vlan mc and uc addresses with VID tag while propagating > addresses to lower devices, do this only if address is not synced. > It allows at end driver level to distinguish addresses belonging > to vlan devices. > > Signed-off-by: Ivan

Re: [PATCH v2 6/8] modpost: Add modinfo flag to livepatch modules

2019-02-27 Thread Josh Poimboeuf
On Wed, Feb 20, 2019 at 04:50:08PM +0100, Miroslav Benes wrote: > Adding CCs... Where was this posted? I don't see it on lkml. It would be good to be able to see the whole series for review. > > On Wed, 30 Jan 2019, Joao Moreira wrote: > > > From: Miroslav Benes > > > > Currently,

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-02-27 Thread Brendan Higgins
On Wed, Feb 20, 2019 at 12:45 PM Frank Rowand wrote: > > On 2/18/19 2:25 PM, Frank Rowand wrote: > > On 2/15/19 2:56 AM, Brendan Higgins wrote: > >> On Thu, Feb 14, 2019 at 6:05 PM Frank Rowand > >> wrote: > >>> > >>> On 2/14/19 4:56 PM, Brendan Higgins wrote: > On Thu, Feb 14, 2019 at

Re: [PATCH v3] f2fs: rebuild nat_bits during umount

2019-02-27 Thread Chao Yu
Ping, Could you please try this new version? On 2019/2/17 6:26, Chao Yu wrote: > From: Chao Yu > > If all free_nat_bitmap are available, we can rebuild nat_bits from > free_nat_bitmap entirely during umount, let's make another chance > to reenable nat_bits for image. > > Signed-off-by: Chao

Re: [PATCH v4] f2fs: add bio cache for IPU

2019-02-27 Thread Chao Yu
Ping, On 2019/2/19 16:15, Chao Yu wrote: > SQLite in Wal mode may trigger sequential IPU write in db-wal file, after > commit d1b3e72d5490 ("f2fs: submit bio of in-place-update pages"), we > lost the chance of merging page in inner managed bio cache, result in > submitting more small-sized IO. >

RE: [PATCH] can: flexcan: add TX support for variable payload size

2019-02-27 Thread Joakim Zhang
> -Original Message- > From: Marc Kleine-Budde > Sent: 2019年2月27日 22:03 > To: Joakim Zhang ; linux-...@vger.kernel.org > Cc: w...@grandegger.com; net...@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH] can: flexcan: add TX support for variable payload

Re: [PATCH] acpi_pm: Reduce PMTMR counter read contention

2019-02-27 Thread Zhenzhong Duan
On 2019/2/18 11:48, Zhenzhong Duan wrote: On 2019/2/11 5:08, Thomas Gleixner wrote: On Sat, 2 Feb 2019, Zhenzhong Duan wrote: On 2019/1/31 22:26, Thomas Gleixner wrote: I'm not against the change per se, but I really want to understand why we need all the complexity for something which

Re: [LKP] [page cache] eb797a8ee0: vm-scalability.throughput -16.5% regression

2019-02-27 Thread Huang, Ying
Waiman Long writes: > On 02/27/2019 08:18 PM, Huang, Ying wrote: >> Waiman Long writes: >> >>> On 02/26/2019 12:30 PM, Linus Torvalds wrote: On Tue, Feb 26, 2019 at 12:17 AM Huang, Ying wrote: > As for fixing. Should we care about the cache line alignment of struct > inode? Or

Re: [PATCH V7 1/2] arm64: dts: freescale: imx8qxp: add cpu opp table

2019-02-27 Thread Shawn Guo
On Tue, Feb 26, 2019 at 05:17:31AM +, Anson Huang wrote: > Add i.MX8QXP CPU opp table to support cpufreq. > > Signed-off-by: Anson Huang > Acked-by: Viresh Kumar Prefix 'arm64: dts: imx8qxp: ' would already be clear enough. I dropped 'freescale' from there and applied patch. > --- > No

[PATCH] xfrm: policy: Fix possible user after free in __xfrm_policy_unlink

2019-02-27 Thread Yue Haibing
From: YueHaibing UBSAN report this: UBSAN: Undefined behaviour in net/xfrm/xfrm_policy.c:1289:24 index 6 is out of range for type 'unsigned int [6]' CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.4.162-514.55.6.9.x86_64+ #13 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS

Re: [PATCH] tools lib traceevent: Fix buffer overflow in arg_eval

2019-02-27 Thread Steven Rostedt
On Wed, 27 Feb 2019 17:55:32 -0800 Tony Jones wrote: > Fix buffer overflow observed when running perf test. > > The overflow is when trying to evaluate "1ULL << (64 - 1)" which > is resulting in -9223372036854775808 which overflows the 20 character > buffer. > > If is possible this bug has

RE: [PATCH V2 2/3] ARM: dts: imx7ulp: add mmdc support

2019-02-27 Thread Anson Huang
Hi, Fabio Best Regards! Anson Huang > -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: 2019年2月28日 9:57 > To: Anson Huang > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; > s.ha...@pengutronix.de; ker...@pengutronix.de; >

(no subject)

2019-02-27 Thread Alfred Chow
-- Good Day, I am Mr. Alfred Cheuk Yu Chow, the Director for Credit & Marketing Chong Hing Bank, Hong Kong, Chong Hing Bank Centre, 24 Des Voeux Road Central, Hong Kong. I have a business proposal of $38,980,369.00. All confirmable documents to back up the claims will be made available

[PATCH v6 3/3] dt-bindings: PCI: altera: Add altr,pcie-root-port-2.0

2019-02-27 Thread Ley Foon Tan
Add support for altr,pcie-root-port-2.0. Signed-off-by: Ley Foon Tan Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/pci/altera-pcie.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pci/altera-pcie.txt

[PATCH v6 2/3] PCI: altera: Enable driver on ARM64

2019-02-27 Thread Ley Foon Tan
Enable PCIE_ALTERA on ARM64 platform. Signed-off-by: Ley Foon Tan --- drivers/pci/controller/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig index 6671946dbf66..6012f3059acd 100644 ---

[PATCH v6 1/3] PCI: altera: Add Stratix 10 PCIe support

2019-02-27 Thread Ley Foon Tan
Add PCIe Root Port support for Stratix 10 device. Main differences compare with PCIe Root Port IP on Cyclone V and Arria 10 devices: - HIP interface to access Root Port configuration register. - TLP programming flow: - One REG0 register - Don't need to check alignment Signed-off-by: Ley

[PATCH v6 0/3] Add Stratix 10 PCIe Root Port support

2019-02-27 Thread Ley Foon Tan
Add PCIe Root Port support for Stratix 10 device and also update device tree binding documentation. v5 -> v6: - - Move udelay to SOP polling - Move count checking to for loop condition - Change dw[count++] to dw[0] for first DW v4 -> v5: - - Add struct altera_pcie_ops - Add count

Re: [PATCH v2] MIPS: fix memory setup for platforms with PHYS_OFFSET != 0

2019-02-27 Thread Paul Burton
Hello, Thomas Bogendoerfer wrote: > For platforms, which use a PHYS_OFFSET != 0, symbol _end also > contains that offset. So when calling memblock_reserve() for > reserving kernel the size argument needs to be adjusted. > > Fixes: bcec54bf3118 ("mips: switch to NO_BOOTMEM") > Acked-by: Mike

[PATCH V3 2/3] ARM: dts: imx7ulp: add mmdc support

2019-02-27 Thread Anson Huang
i.MX7ULP has a MMDC module to control DDR, it reuses i.MX6Q's MMDC module, add support for it. Signed-off-by: Anson Huang --- Changes since V2: - remove mmdc label. --- arch/arm/boot/dts/imx7ulp.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH V3 1/3] dt-bindings: memory-controllers: freescale: add MMDC binding doc

2019-02-27 Thread Anson Huang
Freescale MMDC (Multi Mode DDR Controller) driver is supported since i.MX6Q, but not yet documented, this patch adds binding doc for MMDC module driver. Signed-off-by: Anson Huang --- No changes since V2. --- .../bindings/memory-controllers/fsl/mmdc.txt | 31 ++ 1 file

[PATCH V3 3/3] ARM: dts: imx: make MMDC node name generic

2019-02-27 Thread Anson Huang
Node name should be generic, so use "memory-controller" instead of "mmdc" for MMDC node name, also remove "mmdc" label for platforms with single MMDC node. Signed-off-by: Anson Huang --- Changes since V2: - remove "mmdc" label for single MMDC node. --- arch/arm/boot/dts/imx6qdl.dtsi | 4

Re: [PATCH -next] drm/amdgpu: remove set but not used variable 'vbi_time_out'

2019-02-27 Thread Alex Deucher
Applied. thanks! On Tue, Feb 26, 2019 at 12:36 AM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/amd/amdgpu/si_dpm.c: In function 'si_program_response_times': > drivers/gpu/drm/amd/amdgpu/si_dpm.c:4101:29: warning: > variable 'backbias_response_time'

Re: [PATCH v2 23/26] userfaultfd: wp: don't wake up when doing write protect

2019-02-27 Thread Peter Xu
On Tue, Feb 26, 2019 at 10:00:29AM +0200, Mike Rapoport wrote: > On Tue, Feb 26, 2019 at 03:41:17PM +0800, Peter Xu wrote: > > On Tue, Feb 26, 2019 at 09:29:33AM +0200, Mike Rapoport wrote: > > > On Tue, Feb 26, 2019 at 02:24:52PM +0800, Peter Xu wrote: > > > > On Mon, Feb 25, 2019 at 11:09:35PM

Re: [PATCH -next] drm/amdgpu: remove set but not used variables 'vm, bo'

2019-02-27 Thread Alex Deucher
Applied. thanks! On Wed, Feb 20, 2019 at 3:05 AM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: In function > 'update_gpuvm_pte': > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:840:20: warning: > variable 'bo' set

Re: [PATCH v3 5/5] tracing/probe: Support user-space dereference

2019-02-27 Thread Steven Rostedt
On Wed, 27 Feb 2019 23:44:42 +0900 Masami Hiramatsu wrote: > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c > index a7012de37a00..0efef172db17 100644 > --- a/kernel/trace/trace_probe.c > +++ b/kernel/trace/trace_probe.c > @@ -239,6 +239,7 @@ parse_probe_arg(char *arg, const

Re: [PATCH -next] drm/ttm: remove set but not used variable 'bdev'

2019-02-27 Thread Alex Deucher
Applied. Thanks! On Tue, Feb 19, 2019 at 3:22 AM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/ttm/ttm_execbuf_util.c: In function > 'ttm_eu_fence_buffer_objects': > drivers/gpu/drm/ttm/ttm_execbuf_util.c:191:24: warning: > variable 'bdev' set but

Re: [LKP] [page cache] eb797a8ee0: vm-scalability.throughput -16.5% regression

2019-02-27 Thread Waiman Long
On 02/27/2019 08:18 PM, Huang, Ying wrote: > Waiman Long writes: > >> On 02/26/2019 12:30 PM, Linus Torvalds wrote: >>> On Tue, Feb 26, 2019 at 12:17 AM Huang, Ying wrote: As for fixing. Should we care about the cache line alignment of struct inode? Or its size is considered more

[PATCH v4 2/2] PCI: hv: Refactor hv_irq_unmask() to use cpumask_to_vpset()

2019-02-27 Thread Maya Nakamura
Remove the duplicate implementation of cpumask_to_vpset() and use the shared implementation. Export hv_max_vp_index, which is required by cpumask_to_vpset(). Apply changes to hv_irq_unmask() based on feedback. Based on Vitaly's finding, use GFP_ATOMIC instead of GFP_KERNEL for

Re: [PATCH v4 07/10] dt-bindings: serial: Add Milbeaut serial driver description

2019-02-27 Thread Sugaya, Taichi
Hi, On 2019/02/28 0:04, Greg Kroah-Hartman wrote: On Wed, Feb 27, 2019 at 01:53:30PM +0900, Sugaya Taichi wrote: Add DT bindings document for Milbeaut serial driver. Signed-off-by: Sugaya Taichi Reviewed-by: Rob Herring --- .../devicetree/bindings/serial/milbeaut-uart.txt| 21

[PATCH v4 1/2] PCI: hv: Replace hv_vp_set with hv_vpset

2019-02-27 Thread Maya Nakamura
Remove a duplicate definition of VP set (hv_vp_set) and use the common definition (hv_vpset) that is used in other places. Change the order of the members in struct hv_pcibus_device so that the declaration of retarget_msi_interrupt_params is the last member. Struct hv_vpset, which contains a

[PATCH] powerpc: fix "sz" set but not used

2019-02-27 Thread Qian Cai
arch/powerpc/mm/hugetlbpage-hash64.c: In function '__hash_page_huge': arch/powerpc/mm/hugetlbpage-hash64.c:29:28: warning: variable 'sz' set but not used [-Wunused-but-set-variable] Signed-off-by: Qian Cai --- arch/powerpc/mm/hugetlbpage-hash64.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2019-02-27 Thread Alex Deucher
Applied. Sorry for the delay. Alex On Fri, Feb 22, 2019 at 10:36 AM Nathan Chancellor wrote: > > On Mon, Dec 10, 2018 at 04:42:01PM -0700, Nathan Chancellor wrote: > > Clang warns when an expression that equals zero is used as a null > > pointer constant (in lieu of NULL): > > > >

Re: [PATCH 0/4] mwifiex PCI/wake-up interrupt fixes

2019-02-27 Thread Brian Norris
Hi Rafael, On Wed, Feb 27, 2019 at 3:04 PM Rafael J. Wysocki wrote: > On Wed, Feb 27, 2019 at 9:58 PM Brian Norris wrote: > > On Wed, Feb 27, 2019 at 11:16:12AM +0100, Ard Biesheuvel wrote: > > > So I'd argue that we should add an optional 'wake-gpio' DT property > > > instead to the generic

Re: [PATCH v4 03/10] dt-bindings: Add documentation for Milbeaut SoCs

2019-02-27 Thread Sugaya, Taichi
Hi, On 2019/02/27 23:47, Rob Herring wrote: On Tue, Feb 26, 2019 at 10:51 PM Sugaya Taichi wrote: This adds a DT binding documentation for the M10V and its evaluation board. Signed-off-by: Sugaya Taichi --- .../bindings/arm/socionext/milbeaut.yaml | 22 ++

[PATCH v4 0/2] PCI: hv: Refactor hv_irq_unmask() to use hv_vpset and cpumask_to_vpset()

2019-02-27 Thread Maya Nakamura
This patchset removes a duplicate definition of VP set (hv_vp_set) and uses the common definition (hv_vpset) that is used in other places. It changes the order of the members in struct hv_pcibus_device due to flexible array in hv_vpset. It also removes the duplicate implementation of

Re: [PATCH v3 5/5] tracing/probe: Support user-space dereference

2019-02-27 Thread Steven Rostedt
On Wed, 27 Feb 2019 23:44:42 +0900 Masami Hiramatsu wrote: > > +.. _user_mem_access: > +User Memory Access > +-- > +Kprobe events supports user-space memory access. For that purpose, you can > use > +either user-space dereference syntax or 'ustring' type. > + > +user-space

[PATCH v2] appletalk: Fix use-after-free in atalk_proc_exit

2019-02-27 Thread Yue Haibing
From: YueHaibing KASAN report this: BUG: KASAN: use-after-free in pde_subdir_find+0x12d/0x150 fs/proc/generic.c:71 Read of size 8 at addr 8881f41fe5b0 by task syz-executor.0/2806 CPU: 0 PID: 2806 Comm: syz-executor.0 Not tainted 5.0.0-rc7+ #45 Hardware name: QEMU Standard PC (i440FX +

Re: [PATCH v3 4/5] tracing/probe: Add ustring type for user-space string

2019-02-27 Thread Steven Rostedt
On Wed, 27 Feb 2019 23:44:13 +0900 Masami Hiramatsu wrote: > Add "ustring" type for fetching user-space string from kprobe event. > User can specify ustring type at uprobe event, and it is same as > "string" for uprobe. > > Note that probe-event provides this option but it doesn't choose the >

Re: [PATCH v3 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-02-27 Thread Masahiro Yamada
Hi Joel, On Thu, Feb 28, 2019 at 4:40 AM Joel Fernandes (Google) wrote: > > Introduce in-kernel headers and other artifacts which are made available > as an archive through proc (/proc/kheaders.tar.xz file). This archive makes > it possible to build kernel modules, run eBPF programs, and other

Re: linux-next: build failure after merge of the bpf-next tree

2019-02-27 Thread Alexei Starovoitov
On Wed, Feb 27, 2019 at 5:31 PM Stephen Rothwell wrote: > > Hi all, > > After merging the bpf-next tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > kernel/sysctl.c:1238:13: error: 'sysctl_bpf_stats_enabled' undeclared here > (not in a function); did you mean

[PATCH 07/12] percpu: add block level scan_hint

2019-02-27 Thread Dennis Zhou
Fragmentation can cause both blocks and chunks to have an early first_firee bit available, but only able to satisfy allocations much later on. This patch introduces a scan_hint to help mitigate some unnecessary scanning. The scan_hint remembers the largest area prior to the contig_hint. If the

[PATCH 11/12] percpu: convert chunk hints to be based on pcpu_block_md

2019-02-27 Thread Dennis Zhou
As mentioned in the last patch, a chunk's hints are no different than a block just responsible for more bits. This converts chunk level hints to use a pcpu_block_md to maintain them. This lets us reuse the same hint helper functions as a block. The left_free and right_free are unused by the

[PATCH 04/12] percpu: manage chunks based on contig_bits instead of free_bytes

2019-02-27 Thread Dennis Zhou
When a chunk becomes fragmented, it can end up having a large number of small allocation areas free. The free_bytes sorting of chunks leads to unnecessary checking of chunks that cannot satisfy the allocation. Switch to contig_bits sorting to prevent scanning chunks that may not be able to service

[PATCH 12/12] percpu: use chunk scan_hint to skip some scanning

2019-02-27 Thread Dennis Zhou
Just like blocks, chunks now maintain a scan_hint. This can be used to skip some scanning by promoting the scan_hint to be the contig_hint. The chunk's scan_hint is primarily updated on the backside and relies on full scanning when a block becomes free or the free region spans across blocks.

[PATCH 06/12] percpu: set PCPU_BITMAP_BLOCK_SIZE to PAGE_SIZE

2019-02-27 Thread Dennis Zhou
Previously, block size was flexible based on the constraint that the GCD(PCPU_BITMAP_BLOCK_SIZE, PAGE_SIZE) > 1. However, this carried the overhead that keeping a floating number of populated free pages required scanning over the free regions of a chunk. Setting the block size to be fixed at

[PATCH 09/12] percpu: use block scan_hint to only scan forward

2019-02-27 Thread Dennis Zhou
Blocks now remember the latest scan_hint. This can be used on the allocation path as when a contig_hint is broken, we can promote the scan_hint to the contig_hint and scan forward from there. This works because pcpu_block_refresh_hint() is only called on the allocation path while block free

[PATCH 10/12] percpu: make pcpu_block_md generic

2019-02-27 Thread Dennis Zhou
In reality, a chunk is just a block covering a larger number of bits. The hints themselves are one in the same. Rather than maintaining the hints separately, first introduce nr_bits to genericize pcpu_block_update() to correctly maintain block->right_free. The next patch will convert chunk hints

[PATCH 02/12] percpu: do not search past bitmap when allocating an area

2019-02-27 Thread Dennis Zhou
pcpu_find_block_fit() guarantees that a fit is found within PCPU_BITMAP_BLOCK_BITS. Iteration is used to determine the first fit as it compares against the block's contig_hint. This can lead to incorrectly scanning past the end of the bitmap. The behavior was okay given the check after for bit_off

[PATCH 08/12] percpu: remember largest area skipped during allocation

2019-02-27 Thread Dennis Zhou
Percpu allocations attempt to do first fit by scanning forward from the first_free of a block. However, fragmentation from allocation requests can cause holes not seen by block hint update functions. To address this, create a local version of bitmap_find_next_zero_area_off() that remembers the

[PATCH 05/12] percpu: relegate chunks unusable when failing small allocations

2019-02-27 Thread Dennis Zhou
In certain cases, requestors of percpu memory may want specific alignments. However, it is possible to end up in situations where the contig_hint matches, but the alignment does not. This causes excess scanning of chunks that will fail. To prevent this, if a small allocation fails (< 32B), the

[PATCH 03/12] percpu: introduce helper to determine if two regions overlap

2019-02-27 Thread Dennis Zhou
While block hints were always accurate, it's possible when spanning across blocks that we miss updating the chunk's contig_hint. Rather than rely on correctness of the boundaries of hints, do a full overlap comparison. Signed-off-by: Dennis Zhou --- mm/percpu.c | 31

<    1   2   3   4   5   6   7   8   9   >