Re: [PATCH] fs: use KERNEL_DS instead of get_ds()

2019-03-04 Thread Linus Torvalds
On Fri, Mar 1, 2019 at 7:40 PM Al Viro wrote: > > No objections, but that kind of stuff might be better done in a different > way: ask Linus to run this Your script is disgusting, and I will not quote it for posterity for that reason. I will just say that git has a "path exclusion" thing that you

Re: [PATCH 0/3] riscv: Fix debug instruction check and support trap-based WARN()

2019-03-04 Thread Vincent Chen
On Tue, Mar 05, 2019 at 04:35:08AM +0800, Palmer Dabbelt wrote: > On Thu, 28 Feb 2019 02:31:28 PST (-0800), vince...@andestech.com wrote: > > The handler for the debug exception will call is_valid_bugaddr(bugaddr) to > > check if the instruction in bugaddr is a real debug instruction. However, > >

Re: [PATCH 01/20] asm-generic/mmiowb: Add generic implementation of mmiowb() tracking

2019-03-04 Thread Nicholas Piggin
Michael Ellerman's on March 4, 2019 11:01 am: > Nicholas Piggin writes: >> Michael Ellerman's on March 3, 2019 7:26 pm: >>> Nicholas Piggin writes: > ... what was broken about the powerpc one, which is basically: static inline void mmiowb_set_pending(void) { struct mmi

Re: [PATCH 01/20] asm-generic/mmiowb: Add generic implementation of mmiowb() tracking

2019-03-04 Thread Nicholas Piggin
Linus Torvalds's on March 4, 2019 4:48 am: > On Sun, Mar 3, 2019 at 2:05 AM Nicholas Piggin wrote: >> >> Why even bother with it at all, "internal" or not? Just get rid of >> mmiowb, the concept is obsolete. > > It *is* gone, for chrissake! Only the name remains as an internal > detail of "this

Re: [PATCH 01/20] asm-generic/mmiowb: Add generic implementation of mmiowb() tracking

2019-03-04 Thread Linus Torvalds
On Mon, Mar 4, 2019 at 2:24 AM Michael Ellerman wrote: > > Without wading into the rest of the discussion, this does raise an > interesting point, ie. what about eg. rwlock's? > > They're basically equivalent to spinlocks, and so could reasonably be > expected to have the same behaviour. > > But w

Re: [PATCH 2/3] x86: apuv2: fix input dependencies

2019-03-04 Thread Enrico Weigelt, metux IT consult
On 04.03.19 21:19, Arnd Bergmann wrote: > This could be fixed using either a dependency or a 'select' statement. > I'm chosen 'depends on' here since it is simpler has a lower risk of > introducing circular dependencies. I'd rather prefer using 'select'. Otherwise the driver won't appear at all

Re: [PATCH v3] x86/boot: clean up headers

2019-03-04 Thread Nick Desaulniers
On Mon, Mar 4, 2019 at 4:12 PM Nick Desaulniers wrote: > > The inclusion of was causing issue as the definition of > __arch_hweight64 from arch/x86/include/asm/arch_hweight.h eventually gets > included. The definition is problematic when compiled with -m16 (all code > in arch/x86/boot/ is) as the

[PATCH] Bluetooth: mediatek: Fixed incorrect type in assignment

2019-03-04 Thread sean.wang
From: Sean Wang Fixed warning: incorrect type in assignment reported by kbuild test robot. The detailed warning is shown as below. make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' All warnings (new ones prefixed by >>): btmtkuart.c:671:18: sparse:warning:

Re: [PATCH v4 00/17] x86/split_lock: Enable #AC exception for split locked accesses

2019-03-04 Thread Fenghua Yu
On Mon, Mar 04, 2019 at 04:55:05PM -0500, Konrad Rzeszutek Wilk wrote: > > This capability may also find usage in cloud. A user process with split > > lock running in one guest can block other cores from accessing shared > > memory during its split locked memory access. That may cause overall > > s

[PATCH v3] x86/boot: clean up headers

2019-03-04 Thread Nick Desaulniers
The inclusion of was causing issue as the definition of __arch_hweight64 from arch/x86/include/asm/arch_hweight.h eventually gets included. The definition is problematic when compiled with -m16 (all code in arch/x86/boot/ is) as the "D" inline assembly constraint is rejected by both compilers when

Re: [PATCH] arm64: dts: rockchip: enable hdmi audio out for rk3399-rockpro64

2019-03-04 Thread Heiko Stuebner
Am Mittwoch, 20. Februar 2019, 16:12:26 CET schrieb Katsuhiro Suzuki: > The rockpro64 has hdmi support. So this patch enables hdmi audio > feature that is defined in rk3399 devicetree. > > Signed-off-by: Katsuhiro Suzuki applied for 5.2 Thanks Heiko

Re: [RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes

2019-03-04 Thread Linus Torvalds
On Mon, Mar 4, 2019 at 4:04 PM Linus Torvalds wrote: > > Of course, if it turns out that this breaks something that assumes > that splice blocks purely based on the SPLICE_F_NONBLOCK flag, we'll > have to revert it. Looking at the history of splice, it does look like > it has always ignored O_NONB

RE: [PATCH] media: staging/intel-ipu3: mark PM function as __maybe_unused

2019-03-04 Thread Cao, Bingbu
Hi, Bergmann, Thanks for your patch. Reviewed-by: Cao, Bingbu __ BRs, Cao, Bingbu > -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Tuesday, March 5, 2019 4:29 AM > To: Sakari Ailus ; Mauro Carvalho Chehab > ; Greg Kroah-Hartman > Cc: Ar

Re: [PATCH] arm64: dts: rockchip: Add support for the Orange Pi RK3399 board.

2019-03-04 Thread Heiko Stuebner
Am Freitag, 22. Februar 2019, 19:44:19 CET schrieb Alexis Ballier: > This adds basic support for the Orange Pi RK3399 board. > What works: > - SD card / emmc. > - Debug UART > - Ethernet > - USB: Type C, internal USB3 for SATA, 4 USB 2.0 ports > - Sensors: All of them but the Hall sensor. > - Butto

Re: [PATCH 3/3] x86: apuv2: select LEDS_CLASS

2019-03-04 Thread Randy Dunlap
On 3/4/19 4:03 PM, Enrico Weigelt, metux IT consult wrote: > On 04.03.19 21:19, Arnd Bergmann wrote: >> LEDS_GPIO can only be selected when LEDS_CLASS is already enabled: >> >> WARNING: unmet direct dependencies detected for LEDS_GPIO >> Depends on [m]: NEW_LEDS [=y] && LEDS_CLASS [=m] && (GPIOLI

Re: [PATCH v4] mm/hugetlb: Fix unsigned overflow in __nr_hugepages_store_common()

2019-03-04 Thread Naoya Horiguchi
On Tue, Feb 26, 2019 at 04:03:23PM -0800, Mike Kravetz wrote: > On 2/26/19 2:36 PM, Andrew Morton wrote: ... > >> > >> + } else { > >>/* > >> - * per node hstate attribute: adjust count to global, > >> - * but restrict alloc/free to the specified node. > >> +

Re: [PATCH 1/3] x86: apuv2: remove unused variable

2019-03-04 Thread Enrico Weigelt, metux IT consult
On 04.03.19 21:19, Arnd Bergmann wrote: > diff --git a/drivers/platform/x86/pcengines-apuv2.c > b/drivers/platform/x86/pcengines-apuv2.c > index dcb084f6b892..c1ca931e1fab 100644 > --- a/drivers/platform/x86/pcengines-apuv2.c > +++ b/drivers/platform/x86/pcengines-apuv2.c > @@ -208,7 +208,6 @@ st

Re: [RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes

2019-03-04 Thread Linus Torvalds
On Mon, Mar 4, 2019 at 7:58 AM Steven Rostedt wrote: > > I'm still just hearing crickets about this? Should I just send this > directly to Linus or Andrew? I'll take it. It looks sane. Of course, if it turns out that this breaks something that assumes that splice blocks purely based on the SPLIC

Re: [PATCH 3/3] x86: apuv2: select LEDS_CLASS

2019-03-04 Thread Enrico Weigelt, metux IT consult
On 04.03.19 21:19, Arnd Bergmann wrote: > LEDS_GPIO can only be selected when LEDS_CLASS is already enabled: > > WARNING: unmet direct dependencies detected for LEDS_GPIO > Depends on [m]: NEW_LEDS [=y] && LEDS_CLASS [=m] && (GPIOLIB [=y] || > COMPILE_TEST [=y]) > Selected by [y]: > - PCENG

[GIT PULL 2/2] bcm2835-drivers-next-2019-03-04

2019-03-04 Thread Eric Anholt
The following changes since commit e1dc2b2e1bef7237fd8fc055fe1ec2a6ff001f91: ARM: bcm283x: Switch V3D over to using the PM driver instead of firmware. (2019-02-01 10:34:32 +0100) are available in the Git repository at: git://github.com/anholt/linux tags/bcm2835-drivers-next-2019-03-04 for

Re: [PATCH 2/2] tracing: Use strncpy instead of memcpy for string keys in hist triggers

2019-03-04 Thread Tom Zanussi
On Mon, 2019-03-04 at 18:45 -0500, Steven Rostedt wrote: > On Mon, 04 Mar 2019 16:31:40 -0600 > Tom Zanussi wrote: > > > > Hmm, I don't think it's really necessary - it's not used in a key > > > so > > > don't care about anything after the null, and TASK_COMM_LEN is > > > used > > > in > > > the

[GIT PULL 1/2] bcm2835-dt-next-2019-03-04

2019-03-04 Thread Eric Anholt
Hi Florian, The following changes since commit ab1b4ef966af90ad79fa3c4c124e47915cddde10: ARM: dts: bcm2835-rpi-zero-w: Drop unnecessary pinctrl (2019-02-01 11:56:32 +0100) are available in the Git repository at: git://github.com/anholt/linux tags/bcm2835-dt-next-2019-03-04 for you to fetc

Re: [PATCH v5 07/10] perf record: implement -z,--compression_level=n option and compression

2019-03-04 Thread Andi Kleen
On Fri, Mar 01, 2019 at 06:58:32PM +0300, Alexey Budankov wrote: Could do this as a follow up patch, but at some point the new records need to be documented in Documentation/perf.data-file-format.txt -Andi

Re: [PATCH resend] thermal: bcm2835: Fix crash in bcm2835_thermal_debugfs

2019-03-04 Thread Eric Anholt
Phil Elwell writes: > "cat /sys/kernel/debug/bcm2835_thermal/regset" causes a NULL pointer > dereference in bcm2835_thermal_debugfs. The driver makes use of the > implementation details of the thermal framework to retrieve a pointer > to its private data from a struct thermal_zone_device, and get

Re: [PATCH 1/2] PCI: Prevent 64-bit resources from being counted in 32-bit bridge region

2019-03-04 Thread Logan Gunthorpe
On 2019-03-04 12:21 p.m., Logan Gunthorpe wrote: > The system we hit this bug on is quite large and complex with multiple > layers of switches though I suspect I might have seen it on a completely > different system but never had time to dig into it. I guess I could try > to find a case in which

Re: [PATCH] Revert "swiotlb: remove SWIOTLB_MAP_ERROR"

2019-03-04 Thread Robin Murphy
Hi Arnd, On 2019-03-04 7:59 pm, Arnd Bergmann wrote: This reverts commit b907e20508d0 ("swiotlb: remove SWIOTLB_MAP_ERROR"), which introduced an overflow warning in configurations that have a larger dma_addr_t than phys_addr_t: In file included from include/linux/dma-direct.h:5,

Re: [PATCH v2] platform/chrome: Add Wilco EC Event Handling

2019-03-04 Thread Nick Crews
Hi Enric, On Tue, Feb 26, 2019 at 8:04 AM Enric Balletbo Serra wrote: > > Hi Nick, > > Missatge de Nick Crews del dia dl., 25 de febr. > 2019 a les 20:13: > > > > This patch is meant to be applied on top of the current > > for-next top of tree in the chrome/platform repo, at > > https://git.kern

Re: [PATCH v3 04/12] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc

2019-03-04 Thread kbuild test robot
Hi Yu, Thank you for the patch! Yet something to improve: [auto build test ERROR on balbi-usb/next] [also build test ERROR on v5.0 next-20190304] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH 09/14] nds32: define syscall_get_arch()

2019-03-04 Thread Vincent Chen
Dmitry V. Levin 於 2019年2月27日 週三 下午11:30寫道: > > syscall_get_arch() is required to be implemented on all architectures > in addition to already implemented syscall_get_nr(), > syscall_get_arguments(), syscall_get_error(), and > syscall_get_return_value() functions in order to extend the generic > p

Re: [PATCH] nfsd: fix memory corruption caused by readdir

2019-03-04 Thread NeilBrown
On Mon, Mar 04 2019, J. Bruce Fields wrote: > On Mon, Mar 04, 2019 at 02:08:22PM +1100, NeilBrown wrote: >> (Note that the commit hash in the Fixes tag is from the 'history' >> tree - this bug predates git). >> Fixes: eb229d253e6c ("[PATCH] kNFSd: fix two xdr-encode bugs for readdirplus >> reply

Re: [PATCH 2/2] tracing: Use strncpy instead of memcpy for string keys in hist triggers

2019-03-04 Thread Steven Rostedt
On Mon, 04 Mar 2019 16:31:40 -0600 Tom Zanussi wrote: > > Hmm, I don't think it's really necessary - it's not used in a key so > > don't care about anything after the null, and TASK_COMM_LEN is used > > in > > the memcpy. > > Never mind, yeah, it would make sense to do this, will create anothe

[PATCH] Fix speakers on Acer Predator Helios 500 Ryzen laptops

2019-03-04 Thread Bernhard Rosenkraenzer
On an Acer Predator Helios 500 (Ryzen version), the laptop's speakers don't work out of the box. The problem can be worked around with hdajackretask, remapping the "Black Headphone, Right side" pin (0x21) to the Internal speaker. This patch adds a quirk to change this mapping by default. Signed-

Re: [PATCH] net: ethernet: Fix phy_set_max_speed by checking for NULL

2019-03-04 Thread Florian Fainelli
On 3/4/19 3:36 PM, Aditya Pakki wrote: > phy_device can be a NULL pointer which is further dereferenced > downstream in phy_set_max_speed. This patch avoids such a scenario. > > Signed-off-by: Aditya Pakki > --- > drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 ++ > 1 file changed, 2 insertion

[RFC PATCH v3 2/5] tracing: Save the last hist command's associated event name

2019-03-04 Thread Tom Zanussi
From: Tom Zanussi In preparation for making use of the new trace error log, save the subsystem and event name associated with the last hist command - it will be passed as the location param in the event_log_err() calls. Signed-off-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 33 +

[RFC PATCH v3 3/5] tracing: Use tracing error_log with hist triggers

2019-03-04 Thread Tom Zanussi
From: Tom Zanussi Replace hist_err() and hist_err_event() with tracing_log_err() from the new tracing error_log mechanism. Also add a couple related helper functions and remove most of the old hist_err()-related code. With this change, users no longer read the hist files for hist trigger error

[RFC PATCH v3 5/5] tracing: Use tracing error_log with trace event filters

2019-03-04 Thread Tom Zanussi
From: Tom Zanussi Use tracing_log_err() from the new tracing error_log mechanism to send filter parse errors to tracing/error_log. With this change, users will be able to see filter errors by looking at tracing/error_log. The same errors will also be available in the filter file, as expected.

[RFC PATCH v3 0/5] tracing: common error_log for ftrace

2019-03-04 Thread Tom Zanussi
From: Tom Zanussi Hi, This is v3 of the frace error_log RFC patchset, which is the same as the previous version but adds the numbering Masami suggested before each item in the log. Masami also said he was going to take over the kprobe events patch, but I left it in for now for completeness as i

[RFC PATCH v3 1/5] tracing: Add tracing error log

2019-03-04 Thread Tom Zanussi
From: Tom Zanussi Introduce a new ftrace file, tracing/error_log, for ftrace commands to log errors. This is useful for allowing more complex commands such as hist trigger and kprobe_event commands to point out specifically where something may have gone wrong without forcing them to resort to mo

[PATCH] net: ethernet: Fix phy_set_max_speed by checking for NULL

2019-03-04 Thread Aditya Pakki
phy_device can be a NULL pointer which is further dereferenced downstream in phy_set_max_speed. This patch avoids such a scenario. Signed-off-by: Aditya Pakki --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/broadcom/gene

[RFC PATCH v3 4/5] tracing: Use tracing error_log with kprobe events (incomplete)

2019-03-04 Thread Tom Zanussi
From: Tom Zanussi Here are a few examples of replacing kprobe_events error handling with tracing_log_err() from the new tracing error_log mechanism. Only a few example errors are converted, and even these are incomplete, since I didn't know where to get the current command and used a dummy strin

Re: [PATCH v2] RDMA/umem: minor bug fix and cleanup in error handling paths

2019-03-04 Thread John Hubbard
On 3/4/19 3:11 PM, John Hubbard wrote: > On 3/3/19 8:55 AM, Ira Weiny wrote: >> On Sun, Mar 03, 2019 at 11:52:41AM +0200, Artemy Kovalyov wrote: >>> >>> >>> On 02/03/2019 21:44, Ira Weiny wrote: On Sat, Mar 02, 2019 at 12:24:35PM -0800, john.hubb...@gmail.com wrote: > From: John Hubba

Re: [PATCH 01/20] docs/zh_CN: add disclaimer file

2019-03-04 Thread Li Yang
On Mon, Mar 4, 2019 at 1:22 PM Leo Li wrote: > > > > > -Original Message- > > From: Alex Shi > > Sent: Monday, March 4, 2019 1:58 AM > > To: Leo Li > > Cc: Coly Li ; Federico Vaga ; > > Fengguang Wu ; Li Zefan > > ; Shawn Guo ; > > cor...@lwn.net; harryxi...@gmail.com; linux-...@vger.ker

[PATCH] drivers: clk: zynqmp: Allow zero divisor value

2019-03-04 Thread Jolly Shah
From: Rajan Vaja Zero divider is valid and default for some of ZynqMP clocks. Allow zero divisor when CLK_DIVIDER_ALLOW_ZERO for the clock is set. Signed-off-by: Rajan Vaja Signed-off-by: Jolly Shah --- drivers/clk/zynqmp/divider.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/dr

Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd gpio pull

2019-03-04 Thread Eric Anholt
Stefan Wahren writes: > Hi, > > since this patch change only one board, the subject could be more specific: > > ARM: dts: bcm2835-rpi-b-rev2: Fix hdmi hpd gpio pull > >> Helen Koike hat am 4. März 2019 um 22:48 >> geschrieben: >> >> >> Raspberry pi board model B revison 2 have the hot plug de

Re: [PATCH v2] drm/vgem: fix use-after-free when drm_gem_handle_create() fails

2019-03-04 Thread Rodrigo Siqueira
On 02/26, Eric Biggers wrote: > From: Eric Biggers > > If drm_gem_handle_create() fails in vgem_gem_create(), then the > drm_vgem_gem_object is freed twice: once when the reference is dropped > by drm_gem_object_put_unlocked(), and again by __vgem_gem_destroy(). > > This was hit by syzkaller usi

Re: [PATCH] drm/vkms: fix use-after-free when drm_gem_handle_create() fails

2019-03-04 Thread Rodrigo Siqueira
On 02/28, Dmitry Vyukov wrote: > On Thu, Feb 28, 2019 at 12:12 AM Rodrigo Siqueira > wrote: > > > > On 02/26, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > If drm_gem_handle_create() fails in vkms_gem_create(), then the > > > vkms_gem_object is freed twice: once when the reference is d

[PATCH] drivers: clk: Update clock driver to handle clock attribute

2019-03-04 Thread Jolly Shah
From: Rajan Vaja Versal EEMI APIs uses clock device ID which is combination of class, subclass, type and clock index (e.g. 0x8104006 in which 0-13 bits are for index(6 in given example), 14-19 bits are for clock type (i.e pll, out or ref, 1 in given example), 20-25 bits are for subclass which is

[PATCH] drivers: Defer probe if firmware is not ready

2019-03-04 Thread Jolly Shah
From: Rajan Vaja Driver needs ZynqMP firmware interface to call EEMI APIs. In case firmware is not ready, dependent drivers should wait until the firmware is ready. Signed-off-by: Rajan Vaja Signed-off-by: Jolly Shah --- Documentation/xilinx/eemi.txt | 4 ++-- drivers/clk/zynqmp/clk

Re: [PATCH] tty/sysrq: Convert show_lock to raw_spinlock_t

2019-03-04 Thread Steven Rostedt
On Mon, 4 Mar 2019 22:25:41 + Julien Grall wrote: > Hello Sebastian, > > On 04/03/2019 22:01, Sebastian Andrzej Siewior wrote: > > On 2019-03-04 17:21:57 [+], Julien Grall wrote: > >> (CC correctly linux-rt-users) > >> > >> On 04/03/2019 17:20, Julien Grall wrote: > >>> At the moment

Re: 5.0.0-rc8-next-20190301+: kernel bug at fs/inode.c:513

2019-03-04 Thread Pavel Machek
Hi! > (Adding linux-mm and moving linux-ext4 and linux-kernel to the bcc > list...) Umm. So I ... bcc them too? > On Mon, Mar 04, 2019 at 05:02:55PM +0100, Pavel Machek wrote: > > > > This happened on trying to sync filesystems with unison: > > > > Any ideas? > > > > Should I be forcing fsck

Re: [PATCH v2] RDMA/umem: minor bug fix and cleanup in error handling paths

2019-03-04 Thread John Hubbard
On 3/3/19 8:55 AM, Ira Weiny wrote: > On Sun, Mar 03, 2019 at 11:52:41AM +0200, Artemy Kovalyov wrote: >> >> >> On 02/03/2019 21:44, Ira Weiny wrote: >>> >>> On Sat, Mar 02, 2019 at 12:24:35PM -0800, john.hubb...@gmail.com wrote: From: John Hubbard ... 3. Dead code removal: the

[PATCH] ata: dwc_460ex: Avoid potential NULL pointer dereference

2019-03-04 Thread Aditya Pakki
dma_async_tx_descriptor can contain a NULL variable and using it in dmaengine_submit without checking can crash the process. This patch avoids such a scenario. Signed-off-by: Aditya Pakki --- drivers/ata/sata_dwc_460ex.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/d

Re: [RFT][PATCH 0/2] cpufreq: intel_pstate: Handle _PPC updates on global turbo disable/enable

2019-03-04 Thread Srinivas Pandruvada
On Mon, 2019-03-04 at 22:57 +0100, Rafael J. Wysocki wrote: > On Mon, Mar 4, 2019 at 7:06 PM Srinivas Pandruvada > wrote: > > > > [...] > > > > There are other methods like PL1 budget limit for such cases. > > > > FW > > > > can > > > > just change the config TDP level. > > > > > > OK, but that

[PATCH RESEND] tty: vt.c: Fix TIOCL_BLANKSCREEN console blanking if blankinterval == 0

2019-03-04 Thread Yifeng Li
Previously, in the userspace, it was possible to use the "setterm" command from util-linux to blank the VT console by default, using the following command. According to the man page, > The force option keeps the screen blank even if a key is pressed. It was implemented by calling TIOCL_BLANKSCRE

Re: x86 VM Boot hang with latest linux-next

2019-03-04 Thread Mike Snitzer
On Sun, Mar 03 2019 at 12:06pm -0500, Alexander Duyck wrote: > Thanks. The behavior of it has me wondering if we are looking at > something like an uninitialized data issue or something like that > since as I mentioned I don't see this occur on every boot, just on > most of them. So every now and

Re: [RFC v4 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-03-04 Thread Brendan Higgins
On Thu, Feb 14, 2019 at 1:38 PM Brendan Higgins wrote: > > This patch set proposes KUnit, a lightweight unit testing and mocking > framework for the Linux kernel. > > ## More information on KUnit > > There is a bunch of documentation near the end of this patch set that > describes how to use KU

[PATCH] ALSA: usx2y: Fix potential NULL pointer dereference

2019-03-04 Thread Aditya Pakki
usb_alloc_urb can fail due to kmalloc failure and push the error upstream. Further this can cause a NULL pointer dereference in init_pipe_urbs. This patch avoids such a scenario. Signed-off-by: Aditya Pakki --- sound/usb/usx2y/usb_stream.c | 5 + 1 file changed, 5 insertions(+) diff --gi

Re: [PATCH] selftests/bpf: Add arm target register definitions

2019-03-04 Thread Song Liu
On Mon, Mar 4, 2019 at 12:50 PM Adrian Ratiu wrote: > > eBPF "restricted C" code can be compiled with LLVM/clang using target > triplets like armv7l-unknown-linux-gnueabihf and loaded/run with small > cross-compiled gobpf/elf [1] programs without requiring a full BCC > port which is also undesirab

Re: [PATCH] drm/amdgpu: fix typing in amdgpu_virt_ops::trans_msg

2019-03-04 Thread Luc Van Oostenryck
On Mon, Mar 04, 2019 at 02:10:00PM +0100, Luc Van Oostenryck wrote: > The method in struct amdgpu_virt_ops::trans_msg() is defined as > using an 'u32' for its 2nd argument (the request) but the actual > implementation()s and calls use an 'enum idh_request' for it. > > Fix this by using 'enum idh_r

[PATCH 2/2] watchdog: orion_wdt: use timer1 as a pretimeout

2019-03-04 Thread Chris Packham
The orion watchdog can either reset the CPU or generate an interrupt. The interrupt would be useful for debugging as it provides panic() output about the watchdog expiry, however if the interrupt is used the watchdog can't reset the CPU in the event of being stuck in a loop with interrupts disabled

[PATCH 1/2] watchdog: orion_wdt: remove orion_wdt_set_timeout

2019-03-04 Thread Chris Packham
The watchdog core will do the same thing if no set_timeout is supplied so we can safely remove orion_wdt_set_timeout. Signed-off-by: Chris Packham --- drivers/watchdog/orion_wdt.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_wdt

[PATCH 0/2] watchdog: orion_wdt: add pretimeout support

2019-03-04 Thread Chris Packham
This is a follow up from https://lore.kernel.org/lkml/20190227230707.ga28...@roeck-us.net/ It appears that the kernel has only ever used timer0 on the orion/kirkwood/armada platforms so timer1 appears to be spare on all of these. Armada-XP and Armada-385 also have timers 2 and 3 which could be us

Re: [PATCH v2] x86/boot: clean up headers

2019-03-04 Thread Stephen Rothwell
Hi Nick, On Mon, 4 Mar 2019 09:50:16 -0800 Nick Desaulniers wrote: > > Changes V1 -> V2: > * Add Reviewed, Tested, Suggested tags. > * Drop linux/types.h; it's included in linux/limits.h. > > My original intention was to unsort the headers (sorted in V1), but if > we drop the out of place linu

MFD/Platform drivers for Yeeloong laptop submitted, please review

2019-03-04 Thread Tom Li
Hello, Paul & Jones. I've submitted the first series of patches [0] for the platform drivers on Lemote Yeeloong MIPS laptop to the mailing list, this series is required before the following mainlining can be proceed. The first patch of this series is a MFD driver, which is needed to be reviewed b

[PATCH] md: Fix failed allocation of md_register_thread

2019-03-04 Thread Aditya Pakki
mddev->sync_thread can be set to NULL on kzalloc failure downstream. The patch checks for such a scenario and frees allocated resources. Signed-off-by: Aditya Pakki --- drivers/md/raid10.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index abb5d

Re: [RFC PATCH v2 0/7] i2c: core: introduce atomic transfers

2019-03-04 Thread Wolfram Sang
Hi Peda, > The way I read this series, you are not giving atomic transfers priority. The You are reading correctly. I could have made more clear that the issue pointed out by Russell is not handled by this series but discussion about it is welcome / needed to decide if we can take this series as

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-04 Thread Dietmar Eggemann
On 3/1/19 5:08 PM, Joel Fernandes (Google) wrote: Introduce in-kernel headers and other artifacts which are made available as an archive through proc (/proc/kheaders.tar.xz file). This archive makes it possible to build kernel modules, run eBPF programs, and other tracing programs that need to ex

Re: [PATCH v3 1/4] drm: rockchip: introduce rk3066 hdmi

2019-03-04 Thread Johan Jonker
Thanks for the useful review comments. With regard to the bugs something between rc1 and rc8 results in a freeze on poweroff. Power domain doesn't seem to turn off the vop and hdmi in rc8. For testing only. Forgot to ask rob+dt the prefered document name for "rockchip,rk3066-hdmi" Please advise i

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-03-04 Thread Brendan Higgins
On Thu, Feb 28, 2019 at 10:02 AM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-02-28 01:03:24) > > On Tue, Feb 26, 2019 at 12:35 PM Stephen Boyd wrote: > > > > > > when they need to abort and then the test runner would detect that error > > > via the return value from the 'run test' funct

Re: [PATCH 01/15] ARM: actions: fix a leaked reference by addingmissing of_node_put

2019-03-04 Thread Linus Walleij
On Mon, Mar 4, 2019 at 3:48 PM Manivannan Sadhasivam wrote: > On Mon, Mar 04, 2019 at 01:29:33PM +0100, Linus Walleij wrote: > > On Fri, Mar 1, 2019 at 4:55 PM Manivannan Sadhasivam > > wrote: > > > Hi Wen, > > > > > > On Fri, Mar 01, 2019 at 04:56:42PM +0800, Wen Yang wrote: > > > > The call to

Re: 5.0.0-rc8-next-20190301+: kernel bug at fs/inode.c:513

2019-03-04 Thread Theodore Y. Ts'o
(Adding linux-mm and moving linux-ext4 and linux-kernel to the bcc list...) On Mon, Mar 04, 2019 at 05:02:55PM +0100, Pavel Machek wrote: > > This happened on trying to sync filesystems with unison: > > Any ideas? > > Should I be forcing fsck soon? >

Re: [PATCH] ARCv2: Add explcit unaligned access support (and ability to disable too)

2019-03-04 Thread Vineet Gupta
On 2/28/19 11:24 AM, Vineet Gupta wrote: > On 2/28/19 10:59 AM, Guenter Roeck wrote: >>> Once the patch hits mainline you could use that. In the mean time I'll back >>> out >>> the "detector" as it might trip other people too. >>> >> Can you possibly use $(cc-option,-mno-unaligned-access), or woul

Re: [PATCH 2/2] tracing: Use strncpy instead of memcpy for string keys in hist triggers

2019-03-04 Thread Tom Zanussi
Hi Steve, On Mon, 2019-03-04 at 16:22 -0600, Tom Zanussi wrote: > Hi Steve, > > On Mon, 2019-03-04 at 16:56 -0500, Steven Rostedt wrote: > > On Mon, 4 Mar 2019 16:50:00 -0500 > > Steven Rostedt wrote: > > > > > > +++ b/kernel/trace/trace_events_hist.c > > > > @@ -4695,9 +4695,10 @@ static inlin

[PATCH v2 7/7] MAINTAINERS: add myself as a maintainer of MIPS/Loongson2 platform code.

2019-03-04 Thread Yifeng Li
I've introduced platform code for Lemote Yeeloong computers and modified power management-related files. Add myself as a maintainer of these code. Signed-off-by: Yifeng Li --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 208f19801a23..a

[PATCH v2 6/7] mips: loongson64: Support System Control Interrupts for Lemote Yeeloong.

2019-03-04 Thread Yifeng Li
The hardware design of Yeeloong laptops is similar to OLPC: low-level hardware events are processed by the ENE KB3310B Embedded Controller, which is connected to the AMD CS5536 southbridge through a GPIO port. When a hardware event occurs, such as a short-circuit on the USB port, removing the powe

[PATCH v2 2/7] mips: loongson64: select MFD_YEELOONG_KB3310B for LEMOTE_MACH2F.

2019-03-04 Thread Yifeng Li
To ease the support of platform drivers on Lemote Yeeloong laptop, code for accessing the embedded controller has been separated from arch/mips, as a MFD driver. Since the board files here still need to access the EC directly to handle reboot/shutdown and interrupts, we make MFD_YEELOONG_KB3310B as

[PATCH v2 4/7] mips: loongson64: remove yeeloong_report_lid_status from pm.c

2019-03-04 Thread Yifeng Li
There is some complicated logic in lemote-2f/pm.c. During wakeup, it creates a delayed_work to execute a callback to the function yeeloong_report_lid_status(). It's only purpose is to report the current status of the laptop lid switch, and this callback function wan not implemented in the mainline

[PATCH v2 3/7] mips: loongson64: remove ec_kb3310b.c, use MFD driver.

2019-03-04 Thread Yifeng Li
We have already converted the supporting code for ENE KB3310B embedded controller as a separate MFD driver, and select it as a dependency of LEMOTE_MACH2F. This commit removes the original implementation of ec_kb3310b.c, and converts all EC operations to use the utility function provided by the ye

[PATCH v2 1/7] mfd: yeeloong_kb3310b: support KB3310B EC for Lemote Yeeloong laptops.

2019-03-04 Thread Yifeng Li
Lemote Yeeloong is a laptop powered by Loongson 2F MIPS processor, primarily a demo platform for hobbyists and developers. It uses an ENE KB3310B Embedded Controller with customized firmware to implement hardware and power management. A monolithic platform driver code for those functionality has e

[PATCH v2 5/7] mips: loongson64: register per-board platform drivers for lemote-2f

2019-03-04 Thread Yifeng Li
Currently, common/platform.c registers the Loongson 2F cpufreq driver during boot time for all boards. To support platform drivers for Lemote Yeeloong laptops, we need to register more drivers. First, we add support for per-board platform drivers. Just like how IRQ, DMA, or reset logic is implemen

[PATCH v2 0/7] Preliminary Platform Driver Support for Lemote Yeeloong Laptops

2019-03-04 Thread Yifeng Li
v2: - Fix the missing io.h header for the MFD driver. - Use SIMPLE_DEV_PM_OPS instead of the inappropriate .suspend/resume in the SCI driver. Lemote Yeeloong is a laptop powered by Loongson 2F MIPS processor, primarily a demo platform for hobbyists and developers. It uses an ENE KB3310B Embe

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-03-04 Thread Brendan Higgins
On Thu, Feb 28, 2019 at 5:55 AM Dan Carpenter wrote: > > On Thu, Feb 28, 2019 at 01:03:24AM -0800, Brendan Higgins wrote: > > you could do: > > > > if (IS_ERR_OR_NULL(ptr)) { > > KUNIT_FAIL(test, "ptr is an errno or null: %ld", ptr); > > return; > > } > > It's best to not mix error

Re: [PATCH] tty/sysrq: Convert show_lock to raw_spinlock_t

2019-03-04 Thread Julien Grall
Hello Sebastian, On 04/03/2019 22:01, Sebastian Andrzej Siewior wrote: > On 2019-03-04 17:21:57 [+], Julien Grall wrote: >> (CC correctly linux-rt-users) >> >> On 04/03/2019 17:20, Julien Grall wrote: >>> At the moment show_lock is implemented using spin_lock_t and called from >>> an interrupt

Re: [PATCH 2/2] tracing: Use strncpy instead of memcpy for string keys in hist triggers

2019-03-04 Thread Tom Zanussi
Hi Steve, On Mon, 2019-03-04 at 16:56 -0500, Steven Rostedt wrote: > On Mon, 4 Mar 2019 16:50:00 -0500 > Steven Rostedt wrote: > > > > +++ b/kernel/trace/trace_events_hist.c > > > @@ -4695,9 +4695,10 @@ static inline void add_to_key(char > > > *compound_key, void *key, > > > /* ensure

kernel BUG at include/linux/mm.h:LINE! (5)

2019-03-04 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:9e9322e5d28e selftest/net: Remove duplicate header git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1351623320 kernel config: https://syzkaller.appspot.com/x/.config?x=47f2db597668ac40 dashboard li

Re: [PULL REQUEST] Lock down patches

2019-03-04 Thread Matthew Garrett
Hi James, Based on feedback, I'm going to make a couple of small changes to this patchset and then resend.

Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd gpio pull

2019-03-04 Thread Stefan Wahren
Hi, since this patch change only one board, the subject could be more specific: ARM: dts: bcm2835-rpi-b-rev2: Fix hdmi hpd gpio pull > Helen Koike hat am 4. März 2019 um 22:48 > geschrieben: > > > Raspberry pi board model B revison 2 have the hot plug detector gpio > active high (and not low

[PATCH 1/2] tracing: Fix event filters and triggers to handle negative numbers

2019-03-04 Thread Steven Rostedt
From: Pavel Tikhomirov Then tracing syscall exit event it is extremely useful to filter exit codes equal to some negative value, to react only to required errors. But negative numbers does not work: [root@snorch sys_exit_read]# echo "ret == -1" > filter bash: echo: write error: Invalid argument

[PATCH 2/2] tracing/kprobes: Use probe_kernel_read instead of probe_mem_read

2019-03-04 Thread Steven Rostedt
From: Masami Hiramatsu Use probe_kernel_read() instead of probe_mem_read() because probe_mem_read() is a kind of wrapper for switching memory read function between uprobes and kprobes. Link: http://lkml.kernel.org/r/20190222011643.3e19ade84a3db3e835186...@kernel.org Signed-off-by: Masami Hiram

[PATCH 0/2] [GIT PULL] tracing: Simple fix and clean up for 5.0

2019-03-04 Thread Steven Rostedt
Linus, This is a "pre-pull". It's only one small fix and one small clean up. I'm testing a few small patches for my real pull request which will come at a later time. The second patch depends on your tree anyway so I included it along with the urgent fix. A small fix Pavel sent me back in augus

Re: [PATCH 01/20] docs/zh_CN: add disclaimer file

2019-03-04 Thread Li Yang
On Sun, Mar 3, 2019 at 10:03 PM Alex Shi wrote: > > This a disclaimer file which will be included in Chinese files > as header. To reduce the same common contents copy. It is great for reducing the duplication. But since this is in the translation folder, probably it will be even better to inclu

Re: [PATCH v4 11/17] x86/clearcpuid: Clear CPUID bit in CPUID faulting

2019-03-04 Thread kbuild test robot
Hi Peter, I love your patch! Perhaps something to improve: [auto build test WARNING on kvm/linux-next] [also build test WARNING on v5.0 next-20190304] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH] tty/sysrq: Convert show_lock to raw_spinlock_t

2019-03-04 Thread Sebastian Andrzej Siewior
On 2019-03-04 17:21:57 [+], Julien Grall wrote: > (CC correctly linux-rt-users) > > On 04/03/2019 17:20, Julien Grall wrote: > > At the moment show_lock is implemented using spin_lock_t and called from > > an interrupt context on Arm64. The following backtrace was triggered by: > > > > 42sh#

Re: [PATCH] Revert "swiotlb: remove SWIOTLB_MAP_ERROR"

2019-03-04 Thread Konrad Rzeszutek Wilk
On Mon, Mar 04, 2019 at 08:59:03PM +0100, Arnd Bergmann wrote: > This reverts commit b907e20508d0 ("swiotlb: remove SWIOTLB_MAP_ERROR"), which > introduced an overflow warning in configurations that have a larger > dma_addr_t than phys_addr_t: > > In file included from include/linux/dma-direct.h:5

[PATCH] mips: loongson64: lemote-2f: Add IRQF_NO_SUSPEND to "cascade" irqaction.

2019-03-04 Thread Yifeng Li
Timekeeping IRQs from CS5536 MFGPT are routed to i8259, which then triggers the "cascade" IRQ on MIPS CPU. Without IRQF_NO_SUSPEND in cascade_irqaction, MFGPT interrupts will be masked in suspend mode, and the machine would be unable to resume once suspended. Previously, MIPS IRQs were not disable

Re: [RFT][PATCH 0/2] cpufreq: intel_pstate: Handle _PPC updates on global turbo disable/enable

2019-03-04 Thread Rafael J. Wysocki
On Mon, Mar 4, 2019 at 7:06 PM Srinivas Pandruvada wrote: > > [...] > > > There are other methods like PL1 budget limit for such cases. FW > > > can > > > just change the config TDP level. > > > > OK, but that would be done without notification I suppose? > > There is a notification via processor

Re: [PATCH 2/2] tracing: Use strncpy instead of memcpy for string keys in hist triggers

2019-03-04 Thread Steven Rostedt
On Mon, 4 Mar 2019 16:50:00 -0500 Steven Rostedt wrote: > > +++ b/kernel/trace/trace_events_hist.c > > @@ -4695,9 +4695,10 @@ static inline void add_to_key(char *compound_key, > > void *key, > > /* ensure NULL-termination */ > > if (size > key_field->size - 1) > >

Re: [PATCH v4 00/17] x86/split_lock: Enable #AC exception for split locked accesses

2019-03-04 Thread Konrad Rzeszutek Wilk
> This capability may also find usage in cloud. A user process with split > lock running in one guest can block other cores from accessing shared > memory during its split locked memory access. That may cause overall > system performance degradation. "shared memory" ? As in memory shared between t

Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts

2019-03-04 Thread Helen Koike
On 3/4/19 5:27 PM, Eric Anholt wrote: > Helen Koike writes: > >> Hello, >> >> I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4 >> driver, the HDMI wans't being detected. >> >> So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it >> works correctly. I can

Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts

2019-03-04 Thread Helen Koike
On 3/4/19 5:15 PM, Stefan Wahren wrote: > Hi Helen, > >> Helen Koike hat am 4. März 2019 um 19:54 >> geschrieben: >> >> >> Hello, >> >> I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4 >> driver, the HDMI wans't being detected. >> >> So I changed the hpd-gpios from ACTI

<    1   2   3   4   5   6   7   8   9   10   >