[PATCH v3 3/4] perf script python: add Python3 support to export-to-sqlite.py

2019-03-08 Thread Tony Jones
Support both Python2 and Python3 in the export-to-sqlite.py script The use of 'from __future__' implies the minimum supported Python2 version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Adrian Hunter --- tools/perf/scripts/python/export-to-sqlite.py | 23

[PATCH v3 1/4] perf script python: add Python3 support to exported-sql-viewer.py

2019-03-08 Thread Tony Jones
Support both Python2 and Python3 in the exported-sql-viewer.py script. The use of 'from __future__' implies the minimum supported Python2 version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Adrian Hunter --- tools/perf/scripts/python/exported-sql-viewer.py | 42

[PATCH v3 0/4] perf script python: add Python3 support

2019-03-08 Thread Tony Jones
This is v3 of my version of the patchset. The exporter and viewer changes were all in one patch for V2. For V3 I split them into 3 patches for the reasons below. Patch#1 adds Python3 support to exported-sql-viewer Patch#2 adds Python3 support to export-to-postgresql Patch#3 adds Python3

Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers

2019-03-08 Thread Maciej W. Rozycki
On Thu, 7 Mar 2019, Alexandre Oliva wrote: > > Does your platform use `war_io_reorder_wmb'? > > Err... I'm not sure I understand your question. > > It uses it in __BUILD_IOPORT_SINGLE within the expanded out function, > given !barrier, but you already knew that. > > Did you mean to ask what

Re: [PATCH] xfs: clean up xfs_dir2_leafn_add

2019-03-08 Thread Nathan Chancellor
On Fri, Mar 08, 2019 at 03:11:14PM -0800, Darrick J. Wong wrote: > On Fri, Mar 08, 2019 at 10:42:59AM -0800, Nick Desaulniers wrote: > > On Fri, Mar 8, 2019 at 10:38 AM Darrick J. Wong > > wrote: > > > > > > On Fri, Mar 08, 2019 at 10:12:33AM -0800, Nick Desaulniers wrote: > > > > On Fri, Mar 8,

Re: [PATCH 03/27] Enforce module signatures if the kernel is locked down

2019-03-08 Thread Matthew Garrett
On Fri, Mar 8, 2019 at 3:00 PM James Morris wrote: > > On Wed, 6 Mar 2019, Matthew Garrett wrote: > > > From: David Howells > > > > If the kernel is locked down, require that all modules have valid > > signatures that we can verify. > > Perhaps note that this won't cover the case where folk are

Re: [PATCH] net: ethernet: sun: Zero initialize class in default case in niu_add_ethtool_tcam_entry

2019-03-08 Thread David Miller
From: Nathan Chancellor Date: Thu, 7 Mar 2019 16:29:33 -0700 > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/net/ethernet/sun/niu.c:7466:5: warning: variable 'class' is used > uninitialized whenever switch default is taken > [-Wsometimes-uninitialized] > > The default

Re: [PATCH 0/2] Make ipmr queue length configurable

2019-03-08 Thread David Miller
From: Brodie Greenfield Date: Thu, 7 Mar 2019 17:57:27 +1300 > We want to have some more space in our queue for processing incoming > multicast packets, so we can process more of them without dropping > them prematurely. It is useful to be able to increase this limit on > higher-spec platforms

Re: FS-Cache: Duplicate cookie detected

2019-03-08 Thread Christian Kujau
On Fri, 8 Mar 2019, Christian Kujau wrote: > Running Linux v5.0 with this patch applied does indeed still produce the > "Duplicate cookie detected" messages, but I only ever see wrq=0 when > running nfstest_cache: > >https://paste.fedoraproject.org/paste/dkav0FQzYZxE9-V7GphjAQ And again

Re: [PATCH v4 0/1] mm: introduce put_user_page*(), placeholder versions

2019-03-08 Thread John Hubbard
On 3/8/19 1:36 PM, john.hubb...@gmail.com wrote: > From: John Hubbard > > Hi Andrew and all, > > Can we please apply this (destined for 5.2) once the time is right? > (I see that -mm just got merged into the main tree today.) > > We seem to have pretty solid consensus on the concept and

Re: [PATCH] vhost: silence an unused-variable warning

2019-03-08 Thread David Miller
From: Arnd Bergmann Date: Wed, 6 Mar 2019 12:05:49 +0100 > On some architectures, the MMU can be disabled, leading to access_ok() > becoming an empty macro that does not evaluate its size argument, > which in turn produces an unused-variable warning: > > drivers/vhost/vhost.c:1191:9: error:

Re: [PATCH v2] vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock

2019-03-08 Thread David Miller
From: Adalbert Lazăr Date: Wed, 6 Mar 2019 12:13:53 +0200 > Previous to commit 22b5c0b63f32 ("vsock/virtio: fix kernel panic > after device hot-unplug"), vsock_core_init() was called from > virtio_vsock_probe(). Now, virtio_transport_reset_no_sock() can be called > before vsock_core_init() has

Re: FS-Cache: Duplicate cookie detected

2019-03-08 Thread Christian Kujau
On Fri, 8 Mar 2019, David Howells wrote: > See the attached for a patch that helps with certain kinds of collision, > though I can't see that it should help with what you're seeing since the > RELINQUISHED flag isn't set on the old cookie (fl=222, but 0x10 isn't in > there). You can monitor the

Re: [PATCH v4 2/2] drm/v3d: Add support for V3D v4.2.

2019-03-08 Thread Eric Anholt
Dave Emett writes: > On Fri, 8 Mar 2019 at 17:43, Eric Anholt wrote: >> >> No compatible string for it yet, just the version-dependent changes. >> They've now tied the hub and the core interrupt lines into a single >> interrupt line coming out of the block. It also turns out I made a >>

Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-03-08 Thread Christopher Heiny
On Wed, 2019-02-20 at 17:41 +0100, Aaron Ma wrote: > CAUTION: Email originated externally, do not click links or open > attachments unless you recognize the sender and know the content is > safe. > > > rmi4 got spam data after S3 resume on some ThinkPads. > Then TrackPoint lost when be detected

Re: [PATCH] xfs: clean up xfs_dir2_leafn_add

2019-03-08 Thread Darrick J. Wong
On Fri, Mar 08, 2019 at 10:42:59AM -0800, Nick Desaulniers wrote: > On Fri, Mar 8, 2019 at 10:38 AM Darrick J. Wong > wrote: > > > > On Fri, Mar 08, 2019 at 10:12:33AM -0800, Nick Desaulniers wrote: > > > On Fri, Mar 8, 2019 at 8:13 AM Darrick J. Wong > > > wrote: > > > > > > > > From: Darrick

Re: [PATCH 2/2] hugetlb: use same fault hash key for shared and private mappings

2019-03-08 Thread Mike Kravetz
On 3/8/19 2:48 PM, Mike Kravetz wrote: > mm/hugetlb.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 64ef640126cd..0527732c71f0 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3904,13 +3904,8 @@ u32

Re: [PATCH 03/27] Enforce module signatures if the kernel is locked down

2019-03-08 Thread James Morris
On Wed, 6 Mar 2019, Matthew Garrett wrote: > From: David Howells > > If the kernel is locked down, require that all modules have valid > signatures that we can verify. Perhaps note that this won't cover the case where folk are using DM-Verity with a signed root hash for verifying kernel

[GIT PULL] security: tpm subsystem updates for v5.1

2019-03-08 Thread James Morris
Please pull these updates from Jarkko Sakkinen: " Clean up the transmission flow == Cleaned up the whole transmission flow. Locking of the chip is now done in the level of tpm_try_get_ops() and tpm_put_ops() instead taking the chip lock inside tpm_transmit(). The

[PATCH 1/2] huegtlbfs: on restore reserve error path retain subpool reservation

2019-03-08 Thread Mike Kravetz
When a huge page is allocated, PagePrivate() is set if the allocation consumed a reservation. When freeing a huge page, PagePrivate is checked. If set, it indicates the reservation should be restored. PagePrivate being set at free huge page time mostly happens on error paths. When huge page

[PATCH 0/2] A couple hugetlbfs fixes

2019-03-08 Thread Mike Kravetz
I stumbled on these two hugetlbfs issues while looking at other things: - The 'restore reserve' functionality at page free time should not be adjusting subpool counts. - A BUG can be triggered (not easily) due to temporarily mapping a page before doing a COW. Both are described in detail in

Re: [PATCH 0/5] x86/percpu semantics and fixes

2019-03-08 Thread Peter Zijlstra
On Fri, Mar 08, 2019 at 07:35:17PM +, Nadav Amit wrote: > Nice script! Find a new one; this one is fast enough to run a symbol diff on vmlinux.o compare.sh Description: Bourne shell script

[PATCH 2/2] hugetlb: use same fault hash key for shared and private mappings

2019-03-08 Thread Mike Kravetz
hugetlb uses a fault mutex hash table to prevent page faults of the same pages concurrently. The key for shared and private mappings is different. Shared keys off address_space and file index. Private keys off mm and virtual address. Consider a private mappings of a populated hugetlbfs file.

Re: [PATCH] vxlan: do not need BH again in vxlan_cleanup()

2019-03-08 Thread David Miller
From: Litao Jiao Date: Wed, 6 Mar 2019 12:01:48 +0800 > vxlan_cleanup() is a timer callback, it is already > and only running in BH context. > > Signed-off-by: Litao Jiao Agree with your analysis, applied, thanks.

[PATCH] mm/compaction: fix an undefined behaviour

2019-03-08 Thread Qian Cai
In a low-memory situation, cc->fast_search_fail can keep increasing as it is unable to find an available page to isolate in fast_isolate_freepages(). As the result, it could trigger an error below, so just compare with the maximum bits can be shifted first. UBSAN: Undefined behaviour in

Re: [PATCH v2] iio: proximity: as3935: fix use-after-free on device remove

2019-03-08 Thread Sven Van Asbroeck
On Fri, Mar 8, 2019 at 5:33 PM Tomasz Duszynski wrote: > > > So perhaps that change deserves a separate patch because it smells like > a code cleanup. Not really. This patch fixes the order in which resources are torn down on release(). You do this by fixing the order by which devm-resources are

[PATCH v5] Drivers: hv: vmbus: Expose monitor data only when monitor pages are used

2019-03-08 Thread Kimberly Brown
There are two methods for signaling the host: the monitor page mechanism and hypercalls. The monitor page mechanism is used by performance critical channels (storage, networking, etc.) because it provides improved throughput. However, latency is increased. Monitor pages are allocated to these

[GIT PULL] security: integrity subsystem updates for v5.1

2019-03-08 Thread James Morris
Please pull these changes from Mimi Zohar: "Linux 5.0 introduced the platform keyring to allow verifying the IMA kexec kernel image signature using the pre-boot keys.  This pull request similarly makes keys on the platform keyring accessible for verifying the PE kernel image

Re: [PATCH V2 net] net: hns3: add dma_rmb() for rx description

2019-03-08 Thread David Miller
From: Huazhong Tan Date: Wed, 6 Mar 2019 11:26:37 +0800 > From: Jian Shen > > HW can not guarantee complete write desc->rx.size, even though > HNS3_RXD_VLD_B has been set. Driver needs to add dma_rmb() > instruction to make sure desc->rx.size is always valid. > > Fixes: e55970950556 ("net:

Re: [PATCH v4 6/7] s390: ap: Cleanup on removing the AP device

2019-03-08 Thread Tony Krowiak
On 2/22/19 10:29 AM, Pierre Morel wrote: When the device is remove, we must make sure to clear the interruption and reset the AP device. We also need to clear the CRYCB of the guest. Signed-off-by: Pierre Morel --- drivers/s390/crypto/vfio_ap_drv.c | 35

Re: [PATCH] kbuild: Speed up install, modules_install and kernelrelease

2019-03-08 Thread Doug Anderson
Hi, On Fri, Mar 8, 2019 at 2:29 PM Guenter Roeck wrote: > > On Fri, Mar 8, 2019 at 1:25 PM Douglas Anderson wrote: > > > > As per the description of the old commit 3298b690b21c ("kbuild: Add a > > cache for generated variables"), calling the C compiler lots of times > > during the parsing stage

Re: [PATCH v2] iio: proximity: as3935: fix use-after-free on device remove

2019-03-08 Thread Tomasz Duszynski
On Fri, Mar 08, 2019 at 03:42:04PM -0500, Sven Van Asbroeck wrote: > On Fri, Mar 8, 2019 at 3:30 PM Tomasz Duszynski wrote: > > > > > @@ -368,7 +376,6 @@ static int as3935_probe(struct spi_device *spi) > > > > > > spi_set_drvdata(spi, indio_dev); > > > mutex_init(>lock); > > > -

Re: [RFC net-next v1 1/3] vfio/mdev: Inherit dma masks of parent device

2019-03-08 Thread Alex Williamson
On Fri, 8 Mar 2019 16:07:54 -0600 Parav Pandit wrote: > Inherit dma mask of parent device in child mdev devices, so that > protocol stack can use right dma mask while doing dma mappings. > > Signed-off-by: Parav Pandit > --- > drivers/vfio/mdev/mdev_core.c | 4 > 1 file changed, 4

Re: [PATCH v3 6/9] drivers: pinctrl: msm: setup GPIO irqchip hierarchy

2019-03-08 Thread Lina Iyer
On Thu, Mar 07 2019 at 17:59 -0700, Stephen Boyd wrote: Quoting Lina Iyer (2019-02-22 14:18:47) diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c index ee8119879c4c..83053b45982e 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.c +++

Re: [PATCH] kbuild: Speed up install, modules_install and kernelrelease

2019-03-08 Thread Guenter Roeck
On Fri, Mar 8, 2019 at 1:25 PM Douglas Anderson wrote: > > As per the description of the old commit 3298b690b21c ("kbuild: Add a > cache for generated variables"), calling the C compiler lots of times > during the parsing stage of the Makefile can be a little slow. If you > happen to have a C

Re: [PATCH 16/20] objtool: Rewrite alt->skip_orig

2019-03-08 Thread Josh Poimboeuf
On Fri, Mar 08, 2019 at 10:34:18PM +0100, Peter Zijlstra wrote: > On Fri, Mar 08, 2019 at 02:15:56PM -0600, Josh Poimboeuf wrote: > > On Thu, Mar 07, 2019 at 12:45:27PM +0100, Peter Zijlstra wrote: > > > Really skip the original instruction flow, instead of letting it > > > continue with NOPs. > >

Re: [PATCH 1/3] dt-bindings: Add doc for the ingenic-drm driver

2019-03-08 Thread Linus Walleij
On Fri, Mar 1, 2019 at 11:41 PM Paul Cercueil wrote: > I also have a board with a "smart" panel (ili9331) > that needs a special configuration in the IP. There is nothing in > the drm_panel interface that tells me what mode I should use for what > panel... Is the ILI9331 anything similar to

Re: [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-03-08 Thread Pavel Machek
Hi! > > This patch is meant to be applied on top of the for-next > > branch of the platform/chrome repository, as it uses some of > > the code staged there. > > > > The EC is in charge of controlling the keyboard backlight on > > the Wilco platform. We expose a standard LED class device at > >

[RFC net-next v1 1/3] vfio/mdev: Inherit dma masks of parent device

2019-03-08 Thread Parav Pandit
Inherit dma mask of parent device in child mdev devices, so that protocol stack can use right dma mask while doing dma mappings. Signed-off-by: Parav Pandit --- drivers/vfio/mdev/mdev_core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/vfio/mdev/mdev_core.c

[RFC net-next v1 2/3] net/mlx5: Add mdev sub device life cycle command support

2019-03-08 Thread Parav Pandit
Implement mdev hooks to to create mediated devices using mdev driver. Actual mlx5_core driver in the host is expected to bind to these devices using standard device driver model. mdev devices are created using sysfs file as below example. $ uuidgen 49d0e9ac-61b8-4c91-957e-6f6dbc42557d $ echo

[RFC net-next v1 3/3] net/mlx5: Add mdev driver to bind to mdev devices

2019-03-08 Thread Parav Pandit
Add a mdev driver to probe the mdev devices and create fake netdevice for it. Similar to pci driver, when new mdev are created/removed or when user triggers binding a mdev to mlx5_core driver by writing mdev device id to /sys/bus/mdev/drivers/mlx5_core/bind,unbind files, mlx5_core driver's

[RFC net-next v1 0/3] Support mlx5 mediated devices in host

2019-03-08 Thread Parav Pandit
Use case: - A user wants to create/delete hardware linked sub devices without using SR-IOV. These devices for a pci device can be netdev (optional rdma device) or other devices. Such sub devices share some of the PCI device resources and also have their own dedicated resources. A user

[PATCH v5 2/2] iio: adc: ti-ads7950: add GPIO support

2019-03-08 Thread justinpopo6
From: Justin Chen The ADS79XX has GPIO pins that can be used. Add support for the GPIO pins using the GPIO chip framework. Signed-off-by: Justin Chen Reviewed-by: Linus Walleij --- drivers/iio/adc/ti-ads7950.c | 200 +-- 1 file changed, 194

[PATCH v5 0/2] iio: adc: ads7950: add gpio support

2019-03-08 Thread justinpopo6
From: Justin Chen v5 Fixed ordering of how things are initalized. Fixed incomplete cleanup on error. Fixed double mutex_unlock. v4 Split patch into two commits. Refractored code to capture the state of the adc instead of only the GPIOs. Added comments to clarify the intend of the code. Fix

[PATCH v5 1/2] iio: adc: ti-ads7950: Fix improper use of mlock

2019-03-08 Thread justinpopo6
From: Justin Chen Indio->mlock is used for protecting the different iio device modes. It is currently not being used in this way. Replace the lock with an internal lock specifically used for protecting the SPI transfer buffer. Signed-off-by: Justin Chen --- drivers/iio/adc/ti-ads7950.c | 19

Re: [PATCH] Bluetooth: hci_qca: Add helper function to get the chip family

2019-03-08 Thread Matthias Kaehlcke
On Fri, Mar 08, 2019 at 10:51:30AM -0800, Matthias Kaehlcke wrote: > Many functions obtain a 'struct qca_serdev' only to read the btsoc_type > field. Add a helper function that encapsulates this. > > This also fixes crashes observed on platforms with ROME controllers > that are instantiated

Re: [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-03-08 Thread Dmitry Torokhov
On Fri, Mar 8, 2019 at 12:41 PM Nick Crews wrote: > > This patch is meant to be applied on top of the for-next > branch of the platform/chrome repository, as it uses some of > the code staged there. > > The EC is in charge of controlling the keyboard backlight on > the Wilco platform. We expose a

Re: Debian build polishing

2019-03-08 Thread Theodore Ts'o
On Fri, Mar 08, 2019 at 10:10:19PM +0100, Enrico Weigelt, metux IT consult wrote: > > So I really hope your patches don't break this. > > It shouldn't (at least I dont intend to). Haven't tried where exactly > the generated debian/rules file lands in your case. The full debian directory lands

Re: [PATCH] svm: Fix AVIC incomplete IPI emulation

2019-03-08 Thread Oren Twaig
Hi, Any help appreciated.. Thanks, Oren Twaig On 3/4/2019 8:15 PM, Oren Twaig wrote: Hello Suravee, According to AMD's SDM, the target-not-running incomplete ipi exit is only received if any of the destination cpus had the not-running bit set in the avic backing page. However, not

Re: [PATCH 20/20] objtool: Add Direction Flag validation

2019-03-08 Thread Josh Poimboeuf
On Fri, Mar 08, 2019 at 10:33:43PM +0100, Peter Zijlstra wrote: > On Fri, Mar 08, 2019 at 03:16:03PM -0600, Josh Poimboeuf wrote: > > On Thu, Mar 07, 2019 at 12:45:31PM +0100, Peter Zijlstra wrote: > > > Having DF escape is BAD(tm). > > > > > > Suggested-by: Linus Torvalds > > > Signed-off-by:

Re: [PATCH 18/20] objtool: Add UACCESS validation

2019-03-08 Thread Josh Poimboeuf
On Fri, Mar 08, 2019 at 10:31:56PM +0100, Peter Zijlstra wrote: > On Fri, Mar 08, 2019 at 03:02:09PM -0600, Josh Poimboeuf wrote: > > > +static const char *uaccess_safe_builtin[] = { > > > + /* KASAN */ > > > > A short comment would be good here, something describing why a function > > might be

Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-08 Thread Uwe Kleine-König
On Fri, Mar 08, 2019 at 01:23:41PM -0800, Nick Desaulniers wrote: > On Fri, Mar 8, 2019 at 1:18 PM Uwe Kleine-König > wrote: > > > > On Fri, Mar 08, 2019 at 10:38:11AM -0800, Nick Desaulniers wrote: > > > On Fri, Mar 8, 2019 at 12:53 AM Uwe Kleine-König > > > wrote: > > > > > > > > On Thu, Mar

Re: [RFC][Patch v9 2/6] KVM: Enables the kernel to isolate guest free pages

2019-03-08 Thread Alexander Duyck
On Fri, Mar 8, 2019 at 11:39 AM Nitesh Narayan Lal wrote: > > On 3/8/19 2:25 PM, Alexander Duyck wrote: > > On Fri, Mar 8, 2019 at 11:10 AM Nitesh Narayan Lal > > wrote: > >> > >> On 3/8/19 1:06 PM, Alexander Duyck wrote: > >>> On Thu, Mar 7, 2019 at 6:32 PM Michael S. Tsirkin wrote: > On

[PATCH v4 1/1] mm: introduce put_user_page*(), placeholder versions

2019-03-08 Thread john . hubbard
From: John Hubbard Introduces put_user_page(), which simply calls put_page(). This provides a way to update all get_user_pages*() callers, so that they call put_user_page(), instead of put_page(). Also introduces put_user_pages(), and a few dirty/locked variations, as a replacement for

[PATCH v4 0/1] mm: introduce put_user_page*(), placeholder versions

2019-03-08 Thread john . hubbard
From: John Hubbard Hi Andrew and all, Can we please apply this (destined for 5.2) once the time is right? (I see that -mm just got merged into the main tree today.) We seem to have pretty solid consensus on the concept and details of the put_user_pages() approach. Or at least, if we don't,

Re: NULL pointer dereference in nft_set_elem_destroy()

2019-03-08 Thread Dmitrii Tcvetkov
On Fri, 8 Mar 2019 11:50:39 +0100 Florian Westphal wrote: > Dmitrii Tcvetkov wrote: > > After upgrade to 5.0 on XPS 13 9360 I get NULL pointer dereference > > in dmesg (attached). Distro is Arch Linux, kernel is built with > > custom config (attached), but distro kernel[1] reproduces the issue

Re: [PATCH 16/20] objtool: Rewrite alt->skip_orig

2019-03-08 Thread Peter Zijlstra
On Fri, Mar 08, 2019 at 02:15:56PM -0600, Josh Poimboeuf wrote: > On Thu, Mar 07, 2019 at 12:45:27PM +0100, Peter Zijlstra wrote: > > Really skip the original instruction flow, instead of letting it > > continue with NOPs. > > > > Since the alternative code flow already continues after the

Re: [PATCH 20/20] objtool: Add Direction Flag validation

2019-03-08 Thread Peter Zijlstra
On Fri, Mar 08, 2019 at 03:16:03PM -0600, Josh Poimboeuf wrote: > On Thu, Mar 07, 2019 at 12:45:31PM +0100, Peter Zijlstra wrote: > > Having DF escape is BAD(tm). > > > > Suggested-by: Linus Torvalds > > Signed-off-by: Peter Zijlstra (Intel) > > Can you elaborate on why (in the patch

Re: [PATCH] Avoid that check_shl_overflow() triggers a compiler warning when building with W=1

2019-03-08 Thread Rasmus Villemoes
On 08/03/2019 16.53, Leon Romanovsky wrote: > On Fri, Mar 08, 2019 at 09:09:46AM +0100, Rasmus Villemoes wrote: >> On 08/03/2019 08.01, Leon Romanovsky wrote: >>> >>> Mathematical therm for discrete numbers greater or equal to zero is >>> "normal numbers". >> >> Sorry, WHAT? "Normal" is used and

Re: [PATCH 18/20] objtool: Add UACCESS validation

2019-03-08 Thread Peter Zijlstra
On Fri, Mar 08, 2019 at 03:02:09PM -0600, Josh Poimboeuf wrote: > > +static const char *uaccess_safe_builtin[] = { > > + /* KASAN */ > > A short comment would be good here, something describing why a function > might be added to the list. There is; but I'm thinking it might be too short? > >

Re: [PATCH] scsi: gdth: Only call dma_free_coherent when buf is not NULL in ioc_general

2019-03-08 Thread Nathan Chancellor
On Fri, Mar 08, 2019 at 01:14:25PM -0800, Nick Desaulniers wrote: > On Thu, Mar 7, 2019 at 3:19 PM Nathan Chancellor > wrote: > > > > When building with -Wsometimes-uninitialized, Clang warns: > > > > drivers/scsi/gdth.c:3662:6: warning: variable 'paddr' is used > > uninitialized whenever 'if'

[PATCH v3] blkcg: prevent priority inversion problem during sync()

2019-03-08 Thread Andrea Righi
When sync(2) is executed from a high-priority cgroup, the process is forced to wait the completion of the entire outstanding writeback I/O, even the I/O that was originally generated by low-priority cgroups potentially. This may cause massive latencies to random processes (even those running in

Re: [PATCH v3 1/1] mm: introduce put_user_page*(), placeholder versions

2019-03-08 Thread John Hubbard
On 3/8/19 9:57 AM, Jerome Glisse wrote: [snip] > Just a small comments below that would help my life :) > > Reviewed-by: Jérôme Glisse > Thanks for the review! >> --- >> include/linux/mm.h | 24 ++ >> mm/swap.c | 82 ++ > >

[PATCH] kbuild: Speed up install, modules_install and kernelrelease

2019-03-08 Thread Douglas Anderson
As per the description of the old commit 3298b690b21c ("kbuild: Add a cache for generated variables"), calling the C compiler lots of times during the parsing stage of the Makefile can be a little slow. If you happen to have a C compiler whose fork/exec time isn't optimized (perhaps it was linked

Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-08 Thread Nick Desaulniers
On Fri, Mar 8, 2019 at 1:18 PM Uwe Kleine-König wrote: > > On Fri, Mar 08, 2019 at 10:38:11AM -0800, Nick Desaulniers wrote: > > On Fri, Mar 8, 2019 at 12:53 AM Uwe Kleine-König > > wrote: > > > > > > On Thu, Mar 07, 2019 at 03:36:28PM -0700, Nathan Chancellor wrote: > > > > When building with

[PATCH 1/3] genirq/timings: Remove variance computation code

2019-03-08 Thread Daniel Lezcano
The next patch will introduce another approach to compute the next interrupt based on the array suffixes derived algorithm. This one will replace the variance computation code. The patch review will be too complex if we change the code little by little, it is much simpler to remove the variance

[PATCH 0/3] IRQ next prediction and mbed governor

2019-03-08 Thread Daniel Lezcano
The following patchset provides the missing bits to predict the next event on the the current CPU by identifying three categories of wakeup sources, the interrupts from the devices, the timers and the IPI rescheduling. Initially, the interrupt prediction was based on the statistical normal law,

[PATCH 2/3] genirq/timings: Add array suffix computation code

2019-03-08 Thread Daniel Lezcano
The previous variance was discarding values from the timings when they were considered as anomalies as stated by the normal law statistical model. However in the interrupt life, we can have multiple anomalies due to the nature of the device generating the interrupts, and most of the time we can

[PATCH 3/3] cpuidle/drivers/mbed: Add new governor for embedded systems

2019-03-08 Thread Daniel Lezcano
The objective is the same for all the governors: save energy, but at the end the governors menu, ladder and teo aim to improve the performances with an acceptable energy drop for some workloads which are identified for servers and desktops (with the help of a firmware). It is very difficult to do

Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-08 Thread Uwe Kleine-König
On Fri, Mar 08, 2019 at 10:38:11AM -0800, Nick Desaulniers wrote: > On Fri, Mar 8, 2019 at 12:53 AM Uwe Kleine-König > wrote: > > > > On Thu, Mar 07, 2019 at 03:36:28PM -0700, Nathan Chancellor wrote: > > > When building with -Wsometimes-uninitialized, Clang warns: > > > > > >

Re: [PATCH] rcu/tree_plugin: Fix nohz status in stall warning

2019-03-08 Thread Paul E. McKenney
On Fri, Mar 08, 2019 at 11:51:49PM +0530, Neeraj Upadhyay wrote: > Fix stall warning, to show correct nohz marker. > > Signed-off-by: Neeraj Upadhyay Good eyes, thank you! I applied and pushed all three with modified commit logs. Please check to make sure that I didn't mess anything up. If

Re: [PATCH v2] scsi: qla4xxx: Don't call dma_free_coherent when buf is NULL

2019-03-08 Thread Nick Desaulniers
On Thu, Mar 7, 2019 at 3:17 PM Nathan Chancellor wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/scsi/qla4xxx/ql4_os.c:5915:7: warning: variable 'buf_dma' is > used uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > > Don't call

Re: [PATCH 20/20] objtool: Add Direction Flag validation

2019-03-08 Thread Josh Poimboeuf
On Thu, Mar 07, 2019 at 12:45:31PM +0100, Peter Zijlstra wrote: > Having DF escape is BAD(tm). > > Suggested-by: Linus Torvalds > Signed-off-by: Peter Zijlstra (Intel) Can you elaborate on why (in the patch description)? Did this actually find any occurrences? -- Josh

Re: [PATCH] scsi: gdth: Only call dma_free_coherent when buf is not NULL in ioc_general

2019-03-08 Thread Nick Desaulniers
On Thu, Mar 7, 2019 at 3:19 PM Nathan Chancellor wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/scsi/gdth.c:3662:6: warning: variable 'paddr' is used > uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > > Don't attempt to call

Re: [PATCH 1/1] MIPS: Ensure ELF appended dtb is relocated

2019-03-08 Thread Yasha Cherikovsky
Hi Paul, On Fri, 2019-03-08 at 19:02 +, Paul Burton wrote: > Hi Yasha, > > On Fri, Mar 08, 2019 at 02:58:51PM +0200, Yasha Cherikovsky wrote: > > This fixes booting with the combination of CONFIG_RELOCATABLE=y > > and CONFIG_MIPS_ELF_APPENDED_DTB=y. > > > > Sections that appear after the

Re: [PATCH 19/20] objtool: uaccess PUSHF/POPF support

2019-03-08 Thread Josh Poimboeuf
On Thu, Mar 07, 2019 at 12:45:30PM +0100, Peter Zijlstra wrote: > Add PUSHF / POPF state.uaccess restore logic. > > XXX: should possibly be merged with the previous patch such that KASAN > doesn't explode in between. Split for review. Needs more description -- namely, what and why. -- Josh

Re: Debian build polishing

2019-03-08 Thread Enrico Weigelt, metux IT consult
On 08.03.19 18:57, Theodore Ts'o wrote: > On Fri, Mar 08, 2019 at 01:44:19PM +0100, Enrico Weigelt, metux IT consult > wrote: >> One point still puzzling me: once the debian/rules is applied and >> somebody calls `make deb-pkg`, he'll end up w/ unclean tree, as >> now a git-tracked file is

Re: [PATCH] signal: fix building with clang

2019-03-08 Thread Nick Desaulniers
On Thu, Mar 7, 2019 at 4:27 PM Joe Perches wrote: > > On Thu, 2019-03-07 at 16:22 -0800, Nick Desaulniers wrote: > > On Thu, Mar 7, 2019 at 1:45 PM Arnd Bergmann wrote: > > > I'd have to try, but I think you are right. It was probably an > > > overoptimization back in 1997 when the code got

Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties

2019-03-08 Thread Dan Murphy
Pavel On 3/8/19 3:06 PM, Pavel Machek wrote: > + led@1 { + reg = <1>; + led-sources = <1>; + ti,led-mode = ; + label = "keypad"; >>> >>> I guess best variant would be inputX::backlight here, but

Re: [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-03-08 Thread Pavel Machek
On Fri 2019-03-08 13:38:02, Nick Crews wrote: > This patch is meant to be applied on top of the for-next > branch of the platform/chrome repository, as it uses some of > the code staged there. > > The EC is in charge of controlling the keyboard backlight on > the Wilco platform. We expose a

Re: [GIT PULL 2/2] bcm2835-drivers-next-2019-03-04

2019-03-08 Thread Eric Anholt
Florian Fainelli writes: > On 3/4/19 4:02 PM, Eric Anholt wrote: >> The following changes since commit e1dc2b2e1bef7237fd8fc055fe1ec2a6ff001f91: >> >> ARM: bcm283x: Switch V3D over to using the PM driver instead of firmware. >> (2019-02-01 10:34:32 +0100) >> >> are available in the Git

[PATCH] arm64: bcm2835: Add missing dependency on MFD_CORE.

2019-03-08 Thread Eric Anholt
When adding the MFD dependency for power domains and WDT in bcm2835, I added it only on the arm32 side and missed it for arm64. Fixes: 5e6acc3e678e ("bcm2835-pm: Move bcm2835-watchdog's DT probe to an MFD.") Signed-off-by: Eric Anholt Reported-by: Stefan Wahren --- This fix is for the

Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties

2019-03-08 Thread Pavel Machek
> >> + led@1 { > >> + reg = <1>; > >> + led-sources = <1>; > >> + ti,led-mode = ; > >> + label = "keypad"; > > > > I guess best variant would be inputX::backlight here, but that might > > be tricky to implement. > > >

Re: [PATCH v2 1/4] iio:potentiostat:lmp91000: remove unnecessary parentheses

2019-03-08 Thread Tomasz Duszynski
On Fri, Mar 08, 2019 at 04:46:52PM -0300, Anderson Reis wrote: > From: Lucas Oshiro > > Remove unnecessary parentheses on line 116, and solve these checkpatch.pl No need to explicitly point finger at changed lines. This is what context lines are for. > CHECKs: > > - lmp91000.c:116: CHECK:

Re: [PATCH] net: stmmac: Avoid one more sometimes uninitialized Clang warning

2019-03-08 Thread Nick Desaulniers
On Thu, Mar 7, 2019 at 8:02 PM Nathan Chancellor wrote: > > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c:111:2: error: variable > 'ns' is used uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized] >

Re: [PATCH 18/20] objtool: Add UACCESS validation

2019-03-08 Thread Josh Poimboeuf
On Thu, Mar 07, 2019 at 12:45:29PM +0100, Peter Zijlstra wrote: > --- a/tools/objtool/arch/x86/decode.c > +++ b/tools/objtool/arch/x86/decode.c > @@ -369,7 +369,19 @@ int arch_decode_instruction(struct elf * > > case 0x0f: > > - if (op2 >= 0x80 && op2 <= 0x8f) { > +

Re: [PATCH 4.19 00/68] 4.19.28-stable review

2019-03-08 Thread shuah
On 3/8/19 5:49 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.28 release. There are 68 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 5.0 00/46] 5.0.1-stable review

2019-03-08 Thread shuah
On 3/8/19 5:49 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.0.1 release. There are 46 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by

Re: [PATCH v2] ASoC: fsl: sai: Fix underrrun for playback stream start

2019-03-08 Thread Nicolin Chen
On Fri, Mar 08, 2019 at 05:39:30PM +, Daniel Baluta wrote: > @@ -542,6 +544,11 @@ static int fsl_sai_trigger(struct snd_pcm_substream > *substream, int cmd, > case SNDRV_PCM_TRIGGER_START: > case SNDRV_PCM_TRIGGER_RESUME: > case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: > +

Re: [PATCH 4.20 00/76] 4.20.15-stable review

2019-03-08 Thread shuah
On 3/8/19 5:49 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.20.15 release. There are 76 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 0/5] x86/percpu semantics and fixes

2019-03-08 Thread Peter Zijlstra
On Fri, Mar 08, 2019 at 07:35:17PM +, Nadav Amit wrote: > Nice script! I keep asking myself how comparing two binaries can provide > some “number” to indicate how “good” the binary is (at least relatively to > another one) - either during compilation or after. Code size, as you show, > is the

Re: [PATCH v3] scripts/gdb: replace flags (MS_xyz -> SB_xyz)

2019-03-08 Thread Nick Desaulniers
On Fri, Mar 8, 2019 at 4:37 AM Greg KH wrote: > > On Tue, Mar 05, 2019 at 01:47:58PM -0800, Nick Desaulniers wrote: > > On Tue, Mar 5, 2019 at 2:30 AM Kieran Bingham > > wrote: > > > > > > From: Jackie Liu > > > > > > Since commit 1751e8a6cb93 ("Rename superblock flags (MS_xyz -> SB_xyz)"), > >

Re: [PATCH 3/4] Add header file,Kconfig and Makefile

2019-03-08 Thread Enrico Weigelt, metux IT consult
On 08.03.19 13:35, Morris Ku wrote: > This patch add header file, Kconfig and Makefile. > > Signed-off-by: Morris Ku > --- > char/snx/Kconfig | 15 + > char/snx/Makefile |9 + > char/snx/driver_extd.h | 170 ++ > char/snx/snx_common.h | 1157

Re: [PATCH 1/2] net: bonding: fix restricted __be16 degrades to integer

2019-03-08 Thread Jay Vosburgh
Bo YU wrote: >There are some warning when: > >sudo make C=1 CF=-D__CHECK_ENDIAN__ drivers/net/bonding/ > >drivers/net/bonding/bond_main.c:2385:26: warning: restricted __be16 degrades >to integer >drivers/net/bonding/bond_main.c:2391:20: warning: restricted __be16 degrades >to integer >...

REGRESSION: dwc2: gadget: Add scatter-gather mode

2019-03-08 Thread John Stultz
Hey Andrzej, I just wanted to let you know, trying to boot linus/master on the hikey board today, I've been seeing lots of errors on boot (which sometimes crash the board, and sometimes doesn't). See the example below. I've bisected the issue down to 10209abe87f5 ("usb: dwc2: gadget: Add

Re: [PATCH v2] iio: proximity: as3935: fix use-after-free on device remove

2019-03-08 Thread Sven Van Asbroeck
On Fri, Mar 8, 2019 at 3:30 PM Tomasz Duszynski wrote: > > > @@ -368,7 +376,6 @@ static int as3935_probe(struct spi_device *spi) > > > > spi_set_drvdata(spi, indio_dev); > > mutex_init(>lock); > > - INIT_DELAYED_WORK(>work, as3935_event_work); > > Any specific reason for moving

[PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-03-08 Thread Nick Crews
This patch is meant to be applied on top of the for-next branch of the platform/chrome repository, as it uses some of the code staged there. The EC is in charge of controlling the keyboard backlight on the Wilco platform. We expose a standard LED class device at

[GIT PULL] Devicetree for 5.1

2019-03-08 Thread Rob Herring
Linus, Please pull DT updates for 5.1. Rob The following changes since commit 1c7fc5cbc33980acd13d668f1c8f0313d6ae9fd8: Linux 5.0-rc2 (2019-01-14 10:41:12 +1200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git tags/devicetree-for-5.1

Re: [PATCH v7 1/4] can: m_can: Create a m_can platform framework

2019-03-08 Thread Dan Murphy
On 3/8/19 12:06 PM, Wolfgang Grandegger wrote: > > > Am 08.03.19 um 18:52 schrieb Dan Murphy: >> On 3/8/19 11:40 AM, Wolfgang Grandegger wrote: >>> Hello Dan, >>> >>> Am 08.03.19 um 18:25 schrieb Dan Murphy: On 3/8/19 11:08 AM, Wolfgang Grandegger wrote: > Hello, > > Am 08.03.19

[GIT PULL] platform-drivers-x86 for 5.1-1

2019-03-08 Thread Darren Hart
Hi Linus, The wmi mod alias changes collide with a similar series for TEE based devices. I have provided my merge resolution here: git://git.infradead.org/linux-platform-drivers-x86.git pdx86-5.1-1-merge This series includes two previously merged patches from the RC cycle: - 522e4ee6e5

<    1   2   3   4   5   6   7   8   9   10   >