Re: [PATCH 2/2] s390: boot, purgatory: pass $(CLANG_FLAGS) where needed

2019-04-10 Thread Nick Desaulniers
On Wed, Apr 10, 2019 at 1:13 PM Arnd Bergmann wrote: > > The purgatory and boot Makefiles do not inherit the original cflags, > so clang falls back to the default target architecture when building it, > typically this would be x86 when cross-compiling. > > Add $(CLANG_FLAGS) everywhere so we pass

Re: [PATCH v2 2/2] PCI/DPC: Add Error Disconnect Recover (EDR) support

2019-04-10 Thread sathyanarayanan kuppuswamy
Hi , On 4/10/19 11:41 AM, Bjorn Helgaas wrote: On Tue, Mar 19, 2019 at 01:47:29PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: From: Kuppuswamy Sathyanarayanan As per PCI firmware specification v3.2 ECN (https://members.pcisig.com/wg/PCI-SIG/document/12614), when firmware owns

Zdravstvujte Vas interesuyut klientskie bazy dannyh?

2019-04-10 Thread info
Zdravstvujte Vas interesuyut klientskie bazy dannyh?

Re: [PATCH 18/22] watchdog: mt7621_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Joe Perches
On Wed, 2019-04-10 at 12:54 -0700, Guenter Roeck wrote: > A checkpatch rule suggesting that multiple extension lines can be merged > might be useful to help finding such situations. Just a thought. You are welcome to try to write that one. It's likely not a trivial task to make it sensible.

Re: [PATCH v1] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 3:04 PM Mathieu Desnoyers wrote: > > - On Apr 10, 2019, at 5:53 PM, Sinan Kaya ok...@kernel.org wrote: > > > On 4/10/2019 5:45 PM, Kees Cook wrote: > >> On Wed, Apr 10, 2019 at 2:26 PM Sinan Kaya wrote: > >>> > >>> We can't seem to have a kernel with CONFIG_EXPERT set

[PATCH v3] platform/chrome: wilco_ec: Add h1_gpio status to debugfs

2019-04-10 Thread Nick Crews
As part of Chrome OS's FAFT (Fully Automated Firmware Testing) tests, we need to ensure that the H1 chip is properly setting some GPIO lines. The h1_gpio attribute exposes the state of the lines: - ENTRY_TO_FACT_MODE in BIT(0) - SPI_CHROME_SEL in BIT(1) There are two reasons that I am exposing

Re: [PATCH v2 2/4] PCI: Cleanup comments in setup-bus.c to meet kernel coding style guidelines

2019-04-10 Thread Bjorn Helgaas
Hi Nicholas, On Mon, Mar 11, 2019 at 04:23:23PM +, Nicholas Johnson wrote: > Change block comments to accepted style with asterisks on each line. > > Justify block comments to 80-character limit to reduce the number of > lines where possible. Thanks for doing this; I do accept cleanup

Re: [PATCH v1] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 2:54 PM Sinan Kaya wrote: > > On 4/10/2019 5:45 PM, Kees Cook wrote: > > On Wed, Apr 10, 2019 at 2:26 PM Sinan Kaya wrote: > >> > >> We can't seem to have a kernel with CONFIG_EXPERT set but > >> CONFIG_DEBUG_KERNEL unset these days. > >> > >> While some of the features

[PATCH] afs: use correct format characters

2019-04-10 Thread Louis Taylor
When compiling with -Wformat, clang warns: fs/afs/flock.c:632:29: warning: format specifies type 'short' but the argument has type 'unsigned char' [-Wformat] _leave(" = %d [%hd]", ret, fl->fl_type); ~~~ ^~~ fl_type is declared as an unsigned

Re: [PATCH 2/2] x86/pci: Clean up usage of X86_DEV_DMA_OPS

2019-04-10 Thread Derrick, Jonathan
On Wed, 2019-04-10 at 16:45 -0500, Bjorn Helgaas wrote: > [+cc Keith, Jonathan (VMD guys)] > > I'm OK with this from a PCI perspective. It would be nice if > > dma_domain_list > dma_domain_list_lock > add_dma_domain() > del_dma_domain() > set_dma_domain_ops() > > could all be moved

Re: [PATCH v1] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Mathieu Desnoyers
- On Apr 10, 2019, at 5:53 PM, Sinan Kaya ok...@kernel.org wrote: > On 4/10/2019 5:45 PM, Kees Cook wrote: >> On Wed, Apr 10, 2019 at 2:26 PM Sinan Kaya wrote: >>> >>> We can't seem to have a kernel with CONFIG_EXPERT set but >>> CONFIG_DEBUG_KERNEL unset these days. >>> >>> While some of

Re: [PATCH] security: inode: fix a missing check for securityfs_create_file

2019-04-10 Thread James Morris
On Wed, 10 Apr 2019, Al Viro wrote: > Rather bad way to do it - generally, register_filesystem() should be > the last thing done by initialization. Any modular code that > does unregister_filesystem() on failure exit is flat-out broken; > here it's not instantly FUBAR, but it's a bloody bad

Re: [RFC 00/19] clk: imx: Switch the imx6 and imx7 to clk_hw based API

2019-04-10 Thread Stephen Boyd
Quoting Fabio Estevam (2019-03-22 09:24:54) > Hi Abel, > > On Fri, Mar 22, 2019 at 12:37 PM Abel Vesa wrote: > > > > This work is part of the effort of switching the entire imx clock drivers > > towards clk_hw based API. In order to do that, we have to keep the old > > Maybe I missed some

Re: [PATCH 0/1] mm: Remove the SLAB allocator

2019-04-10 Thread David Rientjes
On Wed, 10 Apr 2019, Vlastimil Babka wrote: > On 4/10/19 4:47 AM, Tobin C. Harding wrote: > > Recently a 2 year old bug was found in the SLAB allocator that crashes > > the kernel. This seems to imply that not that many people are using the > > SLAB allocator. > > AFAIK that bug required

Re: [PATCH v1] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Sinan Kaya
On 4/10/2019 5:45 PM, Kees Cook wrote: On Wed, Apr 10, 2019 at 2:26 PM Sinan Kaya wrote: We can't seem to have a kernel with CONFIG_EXPERT set but CONFIG_DEBUG_KERNEL unset these days. While some of the features under the CONFIG_EXPERT require CONFIG_DEBUG_KERNEL, it doesn't apply for all

[PATCH] fpga: dfl: afu: Pass the correct device to dma_mapping_error()

2019-04-10 Thread Scott Wood
dma_mapping_error() was being called on a different device struct than what was passed to map/unmap. Besides rendering the error checking ineffective, it caused a debug splat with CONFIG_DMA_API_DEBUG. Signed-off-by: Scott Wood --- drivers/fpga/dfl-afu-dma-region.c | 2 +- 1 file changed, 1

[PATCH] fpga: dfl: Add lockdep classes for pdata->lock

2019-04-10 Thread Scott Wood
struct dfl_feature_platform_data (and it's mutex) is used by both fme and port devices, and when lockdep is enabled it complains about nesting between these locks. Tell lockdep about the difference so it can track each class separately. Here's the lockdep complaint: [ 409.680668] WARNING:

Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 12:24 PM Matteo Croce wrote: > > On Wed, Apr 10, 2019 at 8:46 PM Kees Cook wrote: > > > > On Mon, Apr 8, 2019 at 3:09 PM Matteo Croce wrote: > > > > > > Use the shared variables for range check, instead of declaring a local one > > > in every source file. > > > > I was

[PATCH v2] platform/chrome: wilco_ec: Add h1_gpio status to debugfs

2019-04-10 Thread Nick Crews
As part of Chrome OS's FAFT (Fully Automated Firmware Testing) tests, we need to ensure that the H1 chip is properly setting some GPIO lines. The h1_gpio attribute exposes the state of the lines: - ENTRY_TO_FACT_MODE in BIT(0) - SPI_CHROME_SEL in BIT(1) There are two reasons that I am exposing

Re: [PATCH] mtd: lpddr_cmds: Mark expected switch fall-through

2019-04-10 Thread Kees Cook
On Fri, Feb 8, 2019 at 10:12 AM Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mtd/lpddr/lpddr_cmds.c: In function ‘chip_ready’: >

Re: [PATCH] mtd: phram: Mark expected switch fall-throughs

2019-04-10 Thread Kees Cook
On Fri, Feb 8, 2019 at 10:17 AM Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mtd/devices/phram.c: In function ‘parse_num64’: >

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-04-10 Thread Kees Cook
On Fri, Feb 8, 2019 at 10:02 AM Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mtd/chips/cfi_util.c: In function ‘cfi_build_cmd’: >

Re: [PATCH v1] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 2:26 PM Sinan Kaya wrote: > > We can't seem to have a kernel with CONFIG_EXPERT set but > CONFIG_DEBUG_KERNEL unset these days. > > While some of the features under the CONFIG_EXPERT require > CONFIG_DEBUG_KERNEL, it doesn't apply for all features. > > The meaning of

Re: [PATCH v3 3/7] clk: Add of_clk_hw_register() API for early clk drivers

2019-04-10 Thread Stephen Boyd
Quoting Jeffrey Hugo (2019-04-10 12:39:16) > On 4/10/2019 10:53 AM, Stephen Boyd wrote: > > Quoting Jeffrey Hugo (2019-04-08 14:46:11) > >> On 4/4/2019 3:53 PM, Stephen Boyd wrote: > >>> In some circumstances drivers register clks early and don't have access > >>> to a struct device because the

Re: [PATCH 2/2] x86/pci: Clean up usage of X86_DEV_DMA_OPS

2019-04-10 Thread Bjorn Helgaas
[+cc Keith, Jonathan (VMD guys)] I'm OK with this from a PCI perspective. It would be nice if dma_domain_list dma_domain_list_lock add_dma_domain() del_dma_domain() set_dma_domain_ops() could all be moved to vmd.c, since they're really only used there. But we don't really have a

Re: linux-next: Fixes tag needs some work in the devicetree tree

2019-04-10 Thread Rob Herring
On Wed, Apr 10, 2019 at 4:28 PM Stephen Rothwell wrote: > > Hi Rob, > > In commit > > 7800990023f4 ("of: use correct function prototype for > of_overlay_fdt_apply()") > > Fixes tag > > Fixes: commit 39a751a4cb7e ("of: change overlay apply input data from > unflattened to FDT") > > has these

Re: [PATCH 12/27] x86/pkru: Provide .*_pkru_ins() functions

2019-04-10 Thread Dave Hansen
On 4/10/19 2:25 PM, Sebastian Andrzej Siewior wrote: >> static inline void write_pkru(u32 pkru) >> { >> if (boot_cpu_has(X86_FEATURE_OSPKE)) >> -__write_pkru(pkru); >> +wrpkru(pkru); > I think if this is a simple > >'s@__write_pkru_ins@wrpkru@g' >

linux-next: Fixes tag needs some work in the devicetree tree

2019-04-10 Thread Stephen Rothwell
Hi Rob, In commit 7800990023f4 ("of: use correct function prototype for of_overlay_fdt_apply()") Fixes tag Fixes: commit 39a751a4cb7e ("of: change overlay apply input data from unflattened to FDT") has these problem(s): - leading word 'commit' unexpected -- Cheers, Stephen Rothwell

Re: [PATCH RESEND 1/1] PCI: Add ATS-disable quirk for AMD Radeon R7 GPUs

2019-04-10 Thread Bjorn Helgaas
On Wed, Apr 10, 2019 at 11:03:20AM +0300, Nikolai Kostrigin wrote: > 10.04.2019 10:26, Nikolai Kostrigin пишет: > > Hello! > > > > 10.04.2019 00:59, Bjorn Helgaas пишет: > >> [+cc Alex] > >> > >> This claims to be a resend, but I don't see a previous posting. > > For some reason, unknown to me, my

[PATCH v1] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Sinan Kaya
We can't seem to have a kernel with CONFIG_EXPERT set but CONFIG_DEBUG_KERNEL unset these days. While some of the features under the CONFIG_EXPERT require CONFIG_DEBUG_KERNEL, it doesn't apply for all features. The meaning of CONFIG_EXPERT and CONFIG_DEBUG_KERNEL has been mixed here. It looks

Re: [PATCH 12/27] x86/pkru: Provide .*_pkru_ins() functions

2019-04-10 Thread Sebastian Andrzej Siewior
On 2019-04-10 18:52:41 [+0200], Borislav Petkov wrote: > On Wed, Apr 10, 2019 at 06:36:15PM +0200, Borislav Petkov wrote: > > Well, this is going in the wrong direction. The proper thing to do would > > be to have: > > > > rdpkru() > > wrpkru() > > > > which only do the inline asm with the

[PATCH] bitops.h: sanitize rotate primitives

2019-04-10 Thread Rasmus Villemoes
The ror32 implementation (word >> shift) | (word << (32 - shift) has undefined behaviour if shift is outside the [1, 31] range. Similarly for the 64 bit variants. Most callers pass a compile-time constant (naturally in that range), but there's an UBSAN report that these may actually be called with

Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

2019-04-10 Thread Gustavo A. R. Silva
Hi all, If no one cares I'll add this to my tree for 5.2. Thanks -- Gustavo On 3/20/19 3:20 PM, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: > > Who can take this? > > Thanks > -- > Gustavo > > On 2/8/19 12:02 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling

Re: [PATCH] mtd: phram: Mark expected switch fall-throughs

2019-04-10 Thread Gustavo A. R. Silva
Hi all, If no one cares I'll add this to my tree for 5.2. Thanks -- Gustavo On 3/20/19 3:19 PM, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: > > Who can take this? > > Thanks > -- > Gustavo > > On 2/8/19 12:09 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling

Re: [PATCH] mtd: lpddr_cmds: Mark expected switch fall-through

2019-04-10 Thread Gustavo A. R. Silva
Hi all, If no one cares I'll add this to my tree for 5.2. Thanks -- Gustavo On 3/20/19 3:17 PM, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: > > Who can take this? > > Thanks > -- > Gustavo > > On 2/8/19 12:12 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling

Re: [PATCH] mtd: cfi_cmdset_0002: Mark expected switch fall-throughs

2019-04-10 Thread Gustavo A. R. Silva
Hi all, If no one cares I'll add this to my tree for 5.2. Thanks -- Gustavo On 3/20/19 3:16 PM, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: > > Who can take this? > > Thanks > -- > Gustavo > > On 2/9/19 2:29 AM, Tokunori Ikegami wrote: >> Reviewed-by: Tokunori Ikegami >> >>>

Re: [PATCH] watchdog: machzwd: Mark expected switch fall-through

2019-04-10 Thread Gustavo A. R. Silva
On 4/10/19 3:35 PM, Guenter Roeck wrote: > On Wed, Apr 10, 2019 at 01:49:05PM -0500, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warnings: >> >>

Greetings From Mrs,Elodie Antoine

2019-04-10 Thread Mrs.Elodie Antoine
-- Greetings From Mrs,Elodie Antoine May be this letter will definitely come to you as a huge surprise, but I implore you to take the time to go through it carefully as the decision you make will go off a long way to determine my future and continued existence. I am Mrs.Elodie Antoine

[PATCH v2 1/2] PCI: Fix issue with "pci=disable_acs_redir" parameter being ignored

2019-04-10 Thread Logan Gunthorpe
In most cases, kmalloc will not be available early in boot when pci_setup() is called. Thus, the kstrdup call that was added to fix the __initdata bug with the disable_acs_redir parameter usually returns NULL. Thus the parameter is discarded and it does not take into effect. To fix this, we store

[PATCH v2 2/2] PCI: Clean up resource_alignment parameter to not require static buffer

2019-04-10 Thread Logan Gunthorpe
Clean up the 'resource_alignment' parameter code to use kstrdup in the initcall routine instead of a static buffer that wastes memory regardless of whether the feature is used. This allows us to drop 'COMMAND_LINE_SIZE' bytes (typically 256-4096 depending on architecture) of static data. This is

[PATCH v2 0/2] Fix disable_acs_redir parameter

2019-04-10 Thread Logan Gunthorpe
Hi Bjorn This is v2 of my patch to fix the disable_acs_redir paramater. Per our discussion I've found a much better way which can be applied to the resource_alignment paramater. Thus, I've included a second patch that removes the static buffer used there. I'd appreciate it if the first patch

linux-next: Signed-off-by missing for commit in the orangefs tree

2019-04-10 Thread Stephen Rothwell
Hi Mike, Commit a9781aff5d95 ("orangefs: add orangefs_revalidate_mapping") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpXAWgmSQoku.pgp Description: OpenPGP digital signature

linux-next: Fixes tag needs some work in the sound-asoc-fixes tree

2019-04-10 Thread Stephen Rothwell
Hi all, In commit 70802487bb91 ("ASoC: pcm: fix error handling when try_module_get() fails.") Fixes tag Fixes: 52034add7 (ASoC: pcm: update module refcount if has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) or (for

Re: [PATCH] ARM: dts: rockchip: Add BT_EN to the power sequence for veyron

2019-04-10 Thread Doug Anderson
Hi, On Tue, Apr 9, 2019 at 4:14 PM Matthias Kaehlcke wrote: > > Add GPIO D5 (BT_ENABLE_L) as reset-GPIO to the power sequence for the > Bluetooth/WiFi module. On devices with a Broadcom module the signal > needs to be asserted to use Bluetooth. > > Note that BT_ENABLE_L is a misnomer in the

[PATCH 5/5] rtc: pcf85363: convert to SPDX identifier

2019-04-10 Thread Alexandre Belloni
Use SPDX-License-Identifier instead of a verbose license text. The original text refers to version 2 so also update MODULE_LICENSE() to "GPL v2" instead of "GPL". Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf85363.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff

[PATCH 4/5] rtc: pcf85363: remove useless forward declaration

2019-04-10 Thread Alexandre Belloni
It is not necessary to forward declare pcf85363_driver as it is not used before being declared. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf85363.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c index

[PATCH 2/5] rtc: pcf85363: set range

2019-04-10 Thread Alexandre Belloni
This is a standard BCD RTC that will fail in 2100. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf85363.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c index 3905c0ad9d83..8d538a253d72 100644 ---

[PATCH 3/5] rtc: pcf85363: remove bogus i2c functionality check

2019-04-10 Thread Alexandre Belloni
regmap is abstracting the i2c functionalities the best it can, there is no need to check. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf85363.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c index

[PATCH 1/5] rtc: pcf85363: remove unused struct pcf85363 member

2019-04-10 Thread Alexandre Belloni
pcf85363->dev is unused, remove it. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf85363.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c index a3988079f60a..3905c0ad9d83 100644 ---

[tip:x86/microcode] x86/microcode: Deprecate MICROCODE_OLD_INTERFACE

2019-04-10 Thread tip-bot for Borislav Petkov
Commit-ID: c02f48e070bde326f55bd94544ca82291f7396e3 Gitweb: https://git.kernel.org/tip/c02f48e070bde326f55bd94544ca82291f7396e3 Author: Borislav Petkov AuthorDate: Fri, 5 Apr 2019 06:28:11 +0200 Committer: Borislav Petkov CommitDate: Wed, 10 Apr 2019 22:43:24 +0200 x86/microcode:

[tip:x86/microcode] x86/microcode: Fix the ancient deprecated microcode loading method

2019-04-10 Thread tip-bot for Borislav Petkov
Commit-ID: 24613a04ad1c0588c10f4b5403ca60a73d164051 Gitweb: https://git.kernel.org/tip/24613a04ad1c0588c10f4b5403ca60a73d164051 Author: Borislav Petkov AuthorDate: Thu, 4 Apr 2019 22:14:07 +0200 Committer: Borislav Petkov CommitDate: Wed, 10 Apr 2019 22:41:24 +0200 x86/microcode: Fix

[tip:x86/microcode] x86/microcode/intel: Refactor Intel microcode blob loading

2019-04-10 Thread tip-bot for Jann Horn
Commit-ID: 7e94a7b659eefedda82cde97229a26f319fb1182 Gitweb: https://git.kernel.org/tip/7e94a7b659eefedda82cde97229a26f319fb1182 Author: Jann Horn AuthorDate: Thu, 4 Apr 2019 13:11:28 +0200 Committer: Borislav Petkov CommitDate: Wed, 10 Apr 2019 22:40:25 +0200 x86/microcode/intel:

Re: [PATCH] cros_ec: Add trace event to trace EC commands

2019-04-10 Thread Ross Zwisler
On Wed, Apr 10, 2019 at 02:24:08PM -0600, Raul E Rangel wrote: > This is useful to see which EC commands are being executed and when. > > To enable: > > echo 'cros_ec:*' >> /sys/kernel/debug/tracing/set_event > > Example: > > /* cros_ec_cmd: version: 0, command: GET_VERSION */ > /*

[tip:core/core] overflow.h: Add comment documenting __ab_c_size()

2019-04-10 Thread tip-bot for Rasmus Villemoes
Commit-ID: 899cbdfa8d147c873fe4e66c38d2cca3c1ac6286 Gitweb: https://git.kernel.org/tip/899cbdfa8d147c873fe4e66c38d2cca3c1ac6286 Author: Rasmus Villemoes AuthorDate: Wed, 10 Apr 2019 22:27:25 +0200 Committer: Borislav Petkov CommitDate: Wed, 10 Apr 2019 22:35:47 +0200 overflow.h: Add

[PATCH 11/11] platform/x86: asus-wmi: Do not disable keyboard backlight on unload

2019-04-10 Thread Yurii Pavlovskyi
The keyboard backlight is disabled when module is unloaded as it is exposed as LED device. Change this behavior to ignore setting 0 brightness when the ledclass device is unloading. Signed-off-by: Yurii Pavlovskyi --- drivers/platform/x86/asus-wmi.c | 4 1 file changed, 4 insertions(+)

Re: [PATCH] watchdog: machzwd: Mark expected switch fall-through

2019-04-10 Thread Guenter Roeck
On Wed, Apr 10, 2019 at 01:49:05PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/watchdog/machzwd.c: In function ‘zf_set_timer’: >

[PATCH 10/11] platform/x86: asus-wmi: Switch fan boost mode

2019-04-10 Thread Yurii Pavlovskyi
The WMI exposes a write-only device ID where three modes can be switched on some laptops (TUF Gaming FX505GM). There is a hotkey combination Fn-F5 that does have a fan icon which is designed to toggle between these 3 modes. Add a SysFS entry that reads the last written value and updates value in

[PATCH 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight

2019-04-10 Thread Yurii Pavlovskyi
The WMI exposes two methods for controlling RGB keyboard backlight which allow to control: * RGB components in range 00 - ff, * Switch between 4 effects, * Switch between 3 effect speed modes, * Separately enable the backlight on boot, in awake state (after driver load), in sleep mode, and

[PATCH 08/11] platform/x86: asus-wmi: Enhance detection of thermal data

2019-04-10 Thread Yurii Pavlovskyi
The obviously wrong value 1 for temperature device ID in this driver is returned by at least some devices, including TUF Gaming series laptops, instead of 0 as expected previously. Observable effect is that a temp1_input in hwmon reads temperature near absolute zero. * Consider 0.1 K as erroneous

[PATCH 07/11] platform/x86: asus-wmi: Organize code into sections

2019-04-10 Thread Yurii Pavlovskyi
The driver has grown (and will more) pretty big which makes it hard to navigate and understand. Add uniform comments to the code and ensure that it is sorted into logical sections. Signed-off-by: Yurii Pavlovskyi --- drivers/platform/x86/asus-wmi.c | 94 - 1 file

[PATCH 06/11] platform/x86: asus-nb-wmi: Add microphone mute key code

2019-04-10 Thread Yurii Pavlovskyi
The microphone mute key that is present on FX505GM laptop and possibly others is missing from sparse keymap. Add the missing code. Also comment on the fan mode switch key that has the same code as the already used key. Signed-off-by: Yurii Pavlovskyi --- drivers/platform/x86/asus-nb-wmi.c | 3

[PATCH 05/11] platform/x86: asus-wmi: Support queued WMI event codes

2019-04-10 Thread Yurii Pavlovskyi
Event codes are expected to be polled from a queue on at least some models. The WMI event codes are pushed into queue based on circular buffer. After INIT method is called ACPI code is allowed to push events into this buffer the INIT method can not be reverted. If the module is unloaded and an

Re: [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-10 Thread Joel Fernandes
On Wed, Apr 10, 2019 at 04:11:12PM -0400, Steven Rostedt wrote: > On Wed, 10 Apr 2019 15:57:08 -0400 > "Joel Fernandes (Google)" wrote: > > > This series hardens the tracepoints in modules by making the array of > > pointers referring to the tracepoints as read-only. This array is needed > >

Re: rseq/arm32: choosing rseq code signature

2019-04-10 Thread Mathieu Desnoyers
- On Apr 9, 2019, at 3:32 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > Hi Will, > > We are about to include the code signature required prior to restartable > sequences abort handlers into glibc, which will make this ABI choice final. > We need architecture maintainer input

Re: [PATCH-tip v3 04/14] locking/rwsem: Implement lock handoff to prevent lock starvation

2019-04-10 Thread Waiman Long
On 04/10/2019 03:38 PM, Peter Zijlstra wrote: > Hurph, I was still looking at v2.. I suppose I'll go stare at this > verison, I don't think you said there were many changes, right? > > This version seems to still suffer that HANDOFF issue I found on v2. It is mainly minor adjustments. I was

[PATCH 04/11] platform/x86: asus-wmi: Add quirk to force DSTS WMI method detection

2019-04-10 Thread Yurii Pavlovskyi
The DSTS method detection fails, as nothing is returned if method is not defined in WMNB. As a result the control of keyboard backlight is not functional for TUF Gaming series laptops (at the time the only functionality of the driver on this model implemented with WMI methods). Patch was tested

[PATCH 03/11] platform/x86: asus-wmi: Increase input buffer size of WMI methods

2019-04-10 Thread Yurii Pavlovskyi
The asus-nb-wmi driver is matched by WMI alias but fails to load on TUF Gaming series laptops producing multiple ACPI errors in kernel log. Patch was tested on TUF Gaming FX505GM and older K54C model. The input buffer for WMI method invocation size is 2 dwords, whereas 3 are expected by this

[PATCH 02/11] platform/x86: asus-wmi: Fix preserving keyboard, backlight intensity on load

2019-04-10 Thread Yurii Pavlovskyi
The error code and return value are mixed up. The intensity is always set to 0 on load as kbd_led_read returns either 0 or negative value. To reproduce set backlight to maximum, reload driver and try to increase it using keyboard hotkey, the intensity will drop as a result. Correct the

[PATCH] cros_ec: Add trace event to trace EC commands

2019-04-10 Thread Raul E Rangel
This is useful to see which EC commands are being executed and when. To enable: echo 'cros_ec:*' >> /sys/kernel/debug/tracing/set_event Example: /* cros_ec_cmd: version: 0, command: GET_VERSION */ /* cros_ec_cmd: version: 0, command: GET_PROTOCOL_INFO */ /* cros_ec_cmd:

[PATCH 01/11] platform/x86: asus-wmi: Fix hwmon device cleanup

2019-04-10 Thread Yurii Pavlovskyi
The asus-wmi driver does not clean up the hwmon device on exit or error. To reproduce the bug, repeat rmmod, insmod to verify that device number /sys/devices/platform/asus-nb-wmi/hwmon/hwmon?? grows every time. Add pointer to the device in module state and call cleanup on error. Signed-off-by:

[PATCH 2/2] s390: boot, purgatory: pass $(CLANG_FLAGS) where needed

2019-04-10 Thread Arnd Bergmann
The purgatory and boot Makefiles do not inherit the original cflags, so clang falls back to the default target architecture when building it, typically this would be x86 when cross-compiling. Add $(CLANG_FLAGS) everywhere so we pass the correct --target=s390x-linux option when cross-compiling.

[PATCH 1/2] s390: only build for new CPUs with clang

2019-04-10 Thread Arnd Bergmann
llvm does does not understand -march=z9-109 and older target specifiers, so disable the respective Kconfig settings and the logic to make the boot code work on old systems when building with clang. Signed-off-by: Arnd Bergmann --- arch/s390/Kconfig | 6 ++ arch/s390/boot/Makefile | 2

[PATCH 00/11] asus-wmi: Support of ASUS TUF Gaming series laptops

2019-04-10 Thread Yurii Pavlovskyi
Hi, I'm new to kernel development, so first I would like to apologize in advance for any mistakes. The support for this laptop series is currently non-existent, as the asus-nb-wmi driver (which is essentially configuration for asus-wmi) fails to load and multiple ACPI errors are logged in dmesg.

Re: [PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-10 Thread Steven Rostedt
On Wed, 10 Apr 2019 15:57:08 -0400 "Joel Fernandes (Google)" wrote: > This series hardens the tracepoints in modules by making the array of > pointers referring to the tracepoints as read-only. This array is needed > during module unloading to verify that the tracepoint is quiescent. > There is

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

2019-04-10 Thread Tony Lindgren
Hi, * Daniel Lezcano [190410 17:02]: > can you ask for an acked-by before pulling a patch in your tree? I certainly do ask and wait for acks where possible :) Note that I have not applied this patch. I just added Keerthy to Cc on this thread so maybe you misread the message earlier. My comment

Re: [PATCH RESEND 2/5] x86/MCE: Handle MCA controls in a per_cpu way

2019-04-10 Thread Borislav Petkov
On Wed, Apr 10, 2019 at 07:41:47PM +, Ghannam, Yazen wrote: > So I'm thinking to add another patch to the set. This will set > mce_bank.init=0 if we read MCA_CTL=0 from the hardware. Ok. > Then we check if mce_bank.init=0 in the set/show functions and give a > message if the bank is not

[PATCH 2/2] mtd: nand: raw: fix build dependency

2019-04-10 Thread Anders Roxell
When enable CONFIG_MTD_NAND_ECC_SW_BCH as a module, the MTD_NAND_ECC_SW_BCH depends on MTD_NAND, but the module controlled by MTD_NAND links against the module controlled by MTD_NAND_ECC_SW_BCH. This leads to the following link failure. aarch64-linux-gnu-ld: drivers/mtd/nand/raw/nand_base.o: in

[PATCH 1/2] mtd: nand: Kconfig: correct the MTD_NAND_ECC_SW_BCH select

2019-04-10 Thread Anders Roxell
Config fragments should not have the prefix 'CONFIG_'. Rework to remove the prefix 'CONFIG_' from 'CONFIG_MTD_NAND_ECC_SW_BCH'. Fixes: 51ef1d0b2095 ("mtd: nand: Clarify Kconfig entry for software BCH ECC algorithm") Signed-off-by: Anders Roxell --- drivers/mtd/devices/Kconfig | 2 +- 1 file

Re: [RFC][PATCH 13/16] sched: Add core wide task selection and scheduling.

2019-04-10 Thread Vineeth Remanan Pillai
From: Vineeth Pillai > Well, I was promised someome else was going to carry all this, also We are interested in this feature and have been actively testing, benchmarking and working on fixes. If there is no v2 effort currently in progress, we are willing to help consolidate all the changes

[PATCH v3 2/3] module: Make srcu_struct ptr array as read-only post init

2019-04-10 Thread Joel Fernandes (Google)
Since commit title ("srcu: Allocate per-CPU data for DEFINE_SRCU() in modules"), modules that call DEFINE_{STATIC,}SRCU will have a new array of srcu_struct pointers which is used by srcu code to initialize and clean up these structures. There is no reason for this array of pointers to be

[PATCH v3 3/3] module: Make __tracepoints_ptrs as read-only

2019-04-10 Thread Joel Fernandes (Google)
This series hardens the tracepoints in modules by making the array of pointers referring to the tracepoints as read-only. This array is needed during module unloading to verify that the tracepoint is quiescent. There is no reason for the array to be to be writable after init, and can cause

[PATCH v3 1/3] module: Prepare for addition of new ro_after_init sections

2019-04-10 Thread Joel Fernandes (Google)
For the purposes of hardening modules by adding sections to ro_after_init sections, prepare for addition of new ro_after_init entries which we do in future patches. Create a table to which new entries could be added later. This makes it less error prone and reduce code duplication. Cc:

Re: [PATCH] iio: adc: ti-ads7950: Fix build error without CONFIG_GPIOLIB

2019-04-10 Thread Justin Chen
On Wed, Apr 10, 2019 at 1:47 AM Yue Haibing wrote: > > From: YueHaibing > > When building with CONFIG_GPIOLIB is not set > gcc warns this: > > drivers/iio/adc/ti-ads7950.c:75:19: error: field chip has incomplete type > struct gpio_chip chip; >^~~~ >

Re: [GIT PULL] Please pull RDMA subsystem changes

2019-04-10 Thread pr-tracker-bot
The pull request you sent on Wed, 10 Apr 2019 18:46:23 +: > git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git tags/for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/582549e3fbe137eb6ce9be591aca25ca36b4 Thank you! -- Deet-doot-dot, I am a

Re: [PATCH 18/22] watchdog: mt7621_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Guenter Roeck
On Wed, Apr 10, 2019 at 11:46:24AM -0700, Joe Perches wrote: > On Wed, 2019-04-10 at 09:27 -0700, Guenter Roeck wrote: > > Introduce local variable 'struct device *dev' and use it instead of > > dereferencing it repeatedly. > > > > The conversion was done automatically with coccinelle using the >

Re: [PATCH] sparc: use struct_size() in kzalloc()

2019-04-10 Thread Gustavo A. R. Silva
Hi Dave, I wonder if you can take this. Thanks -- Gustavo On 1/8/19 10:13 AM, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is finding the > size of a structure that has a zero-sized array at the end, along with memory > for some number of elements

Re: [PULL -- 5.1 REGRESSION] Bluetooth: btusb: request wake pin with NOAUTOEN

2019-04-10 Thread Linus Torvalds
On Wed, Apr 10, 2019 at 7:44 AM Brian Norris wrote: > > I think our key difference here is in how much we trust the device: > knowing the quality of the firmware running on some of these devices, > I wouldn't totally trust that they get it right. No. You claim that IRQ_NOAUTOEN makes any

Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data

2019-04-10 Thread Madhumthia Prabakaran
On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote: > On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote: > > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h > > b/drivers/staging/rtl8723bs/include/drv_types.h > > index bafb2c30e7fb..b0623c936940 100644 >

Re: [PATCH V5 08/12] perf/x86/intel: Add Icelake support

2019-04-10 Thread Peter Zijlstra
On Wed, Apr 10, 2019 at 02:22:21PM -0400, Liang, Kan wrote: > > > That is, are there really bits we want to mask in there? > > > > For instruction event, right, we don't need mask it. > > I will change it. > > > > Actually, we have to mask some bits here, e.g. ARCH_PERFMON_EVENTSEL_INT, >

Re: KASAN: use-after-free Read in path_lookupat

2019-04-10 Thread Linus Torvalds
On Wed, Apr 10, 2019 at 8:11 AM Al Viro wrote: > > Both are in vfs.git#fixes. Which way should that go - directly or > via linux-security.git? Just do it directly. I doubt you can trigger them for securityfs and apparmourfs, since normal users have no way to remove any files from them, so the

Re: [PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-10 Thread Song Liu
Hi Morten, > On Apr 10, 2019, at 4:59 AM, Morten Rasmussen > wrote: > > Hi, > > On Mon, Apr 08, 2019 at 02:45:32PM -0700, Song Liu wrote: >> Servers running latency sensitive workload usually aren't fully loaded for >> various reasons including disaster readiness. The machines running our

Re: [PATCH] zram: pass down the bvec we need to read into in the work struct

2019-04-10 Thread Jerome Glisse
Adding more Cc and stable (i thought this was 5.1 addition). Note that without this patch on arch/kernel where PAGE_SIZE != 4096 userspace could read random memory through a zram block device (thought userspace probably would have no control on the address being read). On Mon, Apr 08, 2019 at

RE: [PATCH RESEND 2/5] x86/MCE: Handle MCA controls in a per_cpu way

2019-04-10 Thread Ghannam, Yazen
> -Original Message- > From: linux-edac-ow...@vger.kernel.org On > Behalf Of Borislav Petkov > Sent: Wednesday, April 10, 2019 12:26 PM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org; > tony.l...@intel.com; x...@kernel.org > Subject: Re: [PATCH

Re: [PATCH v3 3/7] clk: Add of_clk_hw_register() API for early clk drivers

2019-04-10 Thread Jeffrey Hugo
On 4/10/2019 10:53 AM, Stephen Boyd wrote: Quoting Jeffrey Hugo (2019-04-08 14:46:11) On 4/4/2019 3:53 PM, Stephen Boyd wrote: In some circumstances drivers register clks early and don't have access to a struct device because the device model isn't initialized yet. Add an API to let drivers

Re: [PATCH-tip v3 04/14] locking/rwsem: Implement lock handoff to prevent lock starvation

2019-04-10 Thread Peter Zijlstra
Hurph, I was still looking at v2.. I suppose I'll go stare at this verison, I don't think you said there were many changes, right? This version seems to still suffer that HANDOFF issue I found on v2. On Wed, Apr 10, 2019 at 02:42:21PM -0400, Waiman Long wrote: > Because of writer lock

[PATCH] cifs: fix page reference leak with readv/writev

2019-04-10 Thread jglisse
From: Jérôme Glisse CIFS can leak pages reference gotten through GUP (get_user_pages*() through iov_iter_get_pages()). This happen if cifs_send_async_read() or cifs_write_from_iter() calls fail from within __cifs_readv() and __cifs_writev() respectively. This patch move page unreference to

[PATCH v2 08/21] docs: hwmon: w83791d: convert to ReST format

2019-04-10 Thread Mauro Carvalho Chehab
Convert w83791d to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/w83791d | 123 +--- 1 file changed, 71 insertions(+), 52 deletions(-) diff --git a/Documentation/hwmon/w83791d

[PATCH v2 12/21] docs: hwmon: asc7621: convert to ReST format

2019-04-10 Thread Mauro Carvalho Chehab
Convert asc7621 to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/asc7621 | 146 ++-- 1 file changed, 88 insertions(+), 58 deletions(-) diff --git a/Documentation/hwmon/asc7621

[PATCH v2 11/21] docs: hwmon: ibmpowernv: convert to ReST format

2019-04-10 Thread Mauro Carvalho Chehab
Convert ibmpowernv to ReST format, in order to allow it to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/ibmpowernv | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/hwmon/ibmpowernv b/Documentation/hwmon/ibmpowernv index

[PATCH v2 14/21] docs: hwmon: dme1737, vt1211: convert to ReST format

2019-04-10 Thread Mauro Carvalho Chehab
Convert dme1737 and vt1211 to ReST format, in order to allow them to be parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- Documentation/hwmon/dme1737 | 88 ++--- Documentation/hwmon/vt1211 | 84 +-- 2 files changed, 114

<    1   2   3   4   5   6   7   8   9   >