Re: [PATCH] fanotify: Make wait for permission events interruptible

2019-04-29 Thread Orion Poplawski
On 4/15/19 3:59 AM, Jan Kara wrote: > On Thu 21-03-19 16:11:42, Jan Kara wrote: >> Switch waiting for response to fanotify permission events interruptible. >> This allows e.g. the system to be suspended while there are some >> fanotify permission events pending (which is reportedly pretty common

Re: [PATCH v5] signal: trace_signal_deliver when signal_group_exit

2019-04-29 Thread Oleg Nesterov
On 04/25, Zhenliang Wei wrote: > > Reviewed-by: Oleg Nesterov Yes, everything looks good to me > Cc: > Fixes: cf43a757fd4944 ("signal: Restore the stop PTRACE_EVENT_EXIT") > > Signed-off-by: Zhenliang Wei > --- > kernel/signal.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [RFC PATCH] sched/deadline: sched_getattr() returns absolute dl-task information

2019-04-29 Thread Alessio Balsini

[PATCH v4] moduleparam: Save information about built-in modules in separate file

2019-04-29 Thread Alexey Gladkov
Problem: When a kernel module is compiled as a separate module, some important information about the kernel module is available via .modinfo section of the module. In contrast, when the kernel module is compiled into the kernel, that information is not available. Information about built-in

Re: [PATCH] x86/entry/64: randomize kernel stack offset upon syscall

2019-04-29 Thread Andy Lutomirski
> On Apr 29, 2019, at 12:46 AM, Reshetova, Elena > wrote: > > On Apr 26, 2019, at 7:01 AM, Theodore Ts'o wrote: >>> > >> It seems to me >> that we should be using the “fast-erasure” construction for all >> get_random_bytes() >> invocations. Specifically, we should have a per cpu

Re: [PATCH v7 2/4] vfio: ap: register IOMMU VFIO notifier

2019-04-29 Thread Halil Pasic
On Fri, 26 Apr 2019 15:01:26 +0200 Pierre Morel wrote: > @@ -858,7 +887,17 @@ static int vfio_ap_mdev_open(struct mdev_device *mdev) > return ret; > } > > - return 0; > + matrix_mdev->iommu_notifier.notifier_call = vfio_ap_mdev_iommu_notifier; > + events =

Re: [PATCH 21/41] drivers: tty: serial: cpm_uart: fix includes

2019-04-29 Thread Christophe Leroy
Le 27/04/2019 à 14:52, Enrico Weigelt, metux IT consult a écrit : Fixing checkpatch warning: WARNING: Use #include instead of #25: FILE: drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c:25: +#include WARNING: Use #include instead of +#include WARNING: Use

Re: [PATCH 1/1] rcu/sync: simplify the state machine

2019-04-29 Thread Oleg Nesterov
On 04/28, Paul E. McKenney wrote: > > And it still looks good after review, so I have pushed it. Thanks! > I did add > READ_ONCE() and WRITE_ONCE() to unprotected uses of ->gp_state, but > please let me know if I messed anything up. Well, at least WRITE_ONCE()'s look certainly unneeded to me,

[PATCH v4] staging: rtl8723bs: Fix checkpatch.pl warnings

2019-04-29 Thread Vandana BN
This patch resolves coding style brace warning and constant on right warning. WARNING: Comparisons should place the constant on the right side of the test WARNING: braces {} are not necessary for single statement blocks CHECK: Comparison to NULL could be written "!pbuf" Signed-off-by: Vandana BN

Re: [RFC PATCH v2 00/17] Core scheduling v2

2019-04-29 Thread Ingo Molnar
* Li, Aubrey wrote: > > I.e. showing the approximate CPU thread-load figure column would be > > very useful too, where '50%' shows half-loaded, '100%' fully-loaded, > > '200%' over-saturated, etc. - for each row? > > See below, hope this helps. >

[PATCH v2 4/5] arm64: irqflags: Introduce explicit debugging for IRQ priorities

2019-04-29 Thread Julien Thierry
Using IRQ priority masking to enable/disable interrupts is a bit sensitive as it requires to deal with both ICC_PMR_EL1 and PSR.I. Introduce some validity checks to both highlight the states in which functions dealing with IRQ enabling/disabling can (not) be called, and bark a warning when called

[PATCH v2 5/5] arm64: fix kernel stack overflow in kdump capture kernel

2019-04-29 Thread Julien Thierry
From: Wei Li When enabling ARM64_PSEUDO_NMI feature in kdump capture kernel, it will report a kernel stack overflow exception: [0.00] CPU features: detected: IRQ priority masking [0.00] alternatives: patching kernel code [0.00] Insufficient stack space to handle

[PATCH v2 0/5] arm64: IRQ priority masking and Pseudo-NMI fixes

2019-04-29 Thread Julien Thierry
Hi, [Changing the title to make it reflex more the status of the series.] Version one[1] of this series attempted to fix the issue reported by Zenghui[2] when using the function_graph tracer with IRQ priority masking. Since then, I realized that priority masking and the use of Pseudo-NMIs was

[PATCH v2 2/5] arm64: Fix interrupt tracing in the presence of NMIs

2019-04-29 Thread Julien Thierry
In the presence of any form of instrumentation, nmi_enter() should be done before calling any traceable code and any instrumentation code. Currently, nmi_enter() is done in handle_domain_nmi(), which is much too late as instrumentation code might get called before. Move the nmi_enter/exit() calls

[PATCH v2 3/5] arm64: Fix incorrect irqflag restore for priority masking

2019-04-29 Thread Julien Thierry
When using IRQ priority masking to disable interrupts, in order to deal with the PSR.I state, local_irq_save() would convert the I bit into a PMR value (GIC_PRIO_IRQOFF). This resulted in local_irq_restore() potentially modifying the value of PMR in undesired location due to the state of PSR.I

[PATCH v2 1/5] arm64: Do not enable IRQs for ct_user_exit

2019-04-29 Thread Julien Thierry
For el0_dbg and el0_error, DAIF bits get explicitly cleared before calling ct_user_exit. When context tracking is disabled, DAIF gets set (almost) immediately after. When context tracking is enabled, among the first things done is disabling IRQs. What is actually needed is: - PSR.D = 0 so the

Re: RFC: on adding new CLONE_* flags [WAS Re: [PATCH 0/4] clone: add CLONE_PIDFD]

2019-04-29 Thread Serge E. Hallyn
On Tue, Apr 16, 2019 at 08:32:50PM +0200, Enrico Weigelt, metux IT consult wrote: (Sorry for the late reply, I had missed this one) > On 15.04.19 17:50, Serge E. Hallyn wrote: > > Hi, > > >> I'm working on implementing plan9-like fs namespaces, where unprivileged>> > >> processes can change

Re: [PATCH] firmware: arm_sdei: Prohibit probing in '_sdei_handler'

2019-04-29 Thread Will Deacon
On Fri, Apr 26, 2019 at 10:16:36AM +0800, Xiongfeng Wang wrote: > Functions called in '_sdei_handler' are needed to be marked as > 'nokprobe'. Because these functions are called in NMI context and > neither the arch-code's debug infrastructure nor kprobes core supports > this. > > Signed-off-by:

[PATCH] platform/x86: touchscreen_dmi: Add info for 'jumper ezpad 6 pro b' touchscreen

2019-04-29 Thread Hans de Goede
From: Benjamin Renz Add touchscreen platform data for the 'jumper ezpad 6 pro b' touchscreen. Signed-off-by: Benjamin Renz [hdego...@redhat.com: Cleanup commit msg, fix some checkpatch warnings] Signed-off-by: Hans de Goede --- drivers/platform/x86/touchscreen_dmi.c | 26

Re: [PATCH 3/3] thermal: broadcom: Add Stingray thermal driver

2019-04-29 Thread Sudeep Holla
On Mon, Apr 29, 2019 at 08:58:26PM +0530, Srinath Mannam wrote: > Hi David, > > Thank you for notifying.. > > Hi Sudeep, > > I will send a patch to remove ACPI support. > Thanks. -- Regards, Sudeep

Re: [GIT PULL] Please pull RDMA subsystem changes

2019-04-29 Thread Doug Ledford
On Mon, 2019-04-29 at 08:40 +, Jason Gunthorpe wrote: > On Mon, Apr 29, 2019 at 08:09:47AM +0200, Heiko Carstens wrote: > > On Sun, Apr 28, 2019 at 11:52:12AM +, Jason Gunthorpe wrote: > > > Hi Linus, > > > > > > Third rc pull request > > > > > > Nothing particularly special here. There

Re: [RFC PATCH v2 00/17] Core scheduling v2

2019-04-29 Thread Phil Auld
On Mon, Apr 29, 2019 at 09:25:35PM +0800 Li, Aubrey wrote: > On 2019/4/29 14:14, Ingo Molnar wrote: > > > > * Li, Aubrey wrote: > > > >>> I suspect it's pretty low, below 1% for all rows? > >> > >> Hope my this mail box works for this... > >> > >>

Re: [PATCH v3] moduleparam: Save information about built-in modules in separate file

2019-04-29 Thread Alexey Gladkov
On Tue, Apr 30, 2019 at 12:08:44AM +0900, Masahiro Yamada wrote: > > modules.builtin > > +modules.builtin.modinfo > > > > # > > # Top-level generic files > > > Let me repeat the same comments as in v2 > (https://patchwork.kernel.org/patch/10888207/#22595563) > as you ignored them. I miss it.

Re: linux-next: Tree for Apr 29 (drivers/leds/leds-turris-omnia)

2019-04-29 Thread Marek Behun
I am sending patch only adding the I2C dep. Theoretically it is possible that someone uses the same I2C API in their microcontroller on another architecture. On Mon, 29 Apr 2019 17:32:00 +0200 Pavel Machek wrote: > On Mon 2019-04-29 08:03:02, Randy Dunlap wrote: > > On 4/29/19 2:03 AM, Stephen

Re: linux-next: Tree for Apr 29 (drivers/leds/leds-turris-omnia)

2019-04-29 Thread Pavel Machek
On Mon 2019-04-29 08:03:02, Randy Dunlap wrote: > On 4/29/19 2:03 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20190426: > > > > on i386: > > when CONFIG_LEDS_TURRIS_OMNIA=y and CONFIG_I2C=m: > > Probably should also depend on I2C. > > > ld:

Re: [PATCH] irqchip: Remove unneeded select IRQ_DOMAIN

2019-04-29 Thread Marc Zyngier
On 29/04/2019 16:12, Geert Uytterhoeven wrote: > IRQ_DOMAIN_HIERARCHY selects IRQ_DOMAIN, hence there is no need for > drivers to select both. > > Signed-off-by: Geert Uytterhoeven Applied, thanks. M. -- Jazz is not dead. It just smells funny...

[PATCH for 5.2 02/12] rseq/selftests: Add __rseq_exit_point_array section for debuggers

2019-04-29 Thread Mathieu Desnoyers
Knowing all exit points is useful to assist debuggers stepping over the rseq critical sections without requiring them to disassemble the content of the critical section to figure out the exit points. Signed-off-by: Mathieu Desnoyers CC: Thomas Gleixner CC: Joel Fernandes CC: Peter Zijlstra

[PATCH for 5.2 11/12] rseq/selftests: mips: use break instruction for RSEQ_SIG

2019-04-29 Thread Mathieu Desnoyers
Use break as guard instruction for the restartable sequence abort handler. Previously, the chosen signature was simply data, based on the assumption that it could always sit in a literal pool. However, some compilation environments favor disabling literal pool. Therefore, ensure the signature is

[PATCH for 5.2 12/12] rseq/selftests: add -no-integrated-as for clang

2019-04-29 Thread Mathieu Desnoyers
Ongoing work for asm goto support from clang requires the -no-integrated-as compiler flag. This compiler flag is present in the toplevel kernel Makefile, but is not replicated for selftests. Add it specifically for the rseq selftest which requires asm goto. Link: https://reviews.llvm.org/D56571

[PATCH for 5.2 00/12] Restartable Sequences selftests updates

2019-04-29 Thread Mathieu Desnoyers
Those rseq selftests updates are hereby submitted to Shuah Khan, maintainer of kernel selftests, for the next merge window (5.2). They change the per-architecture pre-abort signatures to ensure those are valid trap instructions. The way exit points are presented to debuggers is enhanced,

[PATCH for 5.2 01/12] rseq/selftests: x86: Work-around bogus gcc-8 optimisation

2019-04-29 Thread Mathieu Desnoyers
gcc-8 version 8.1.0, 8.2.0, and 8.3.0 generate broken assembler with asm goto that have a thread-local storage "m" input operand on both x86-32 and x86-64. For instance: __thread int var; static int fct(void) { asm goto ( "jmp %l[testlabel]\n\t" : : [var] "m"

Re: [PATCH 2/4] perf: Add filter_match() as a parameter for pinned/flexible_sched_in()

2019-04-29 Thread Liang, Kan
On 4/29/2019 11:12 AM, Mark Rutland wrote: On Mon, Apr 29, 2019 at 07:44:03AM -0700, kan.li...@linux.intel.com wrote: From: Kan Liang A fast path will be introduced in the following patches to speed up the cgroup events sched in, which only needs a simpler filter_match(). Add

Re: [PATCH v11 0/2] PWM support for HiFive Unleashed

2019-04-29 Thread Uwe Kleine-König
On Mon, Apr 15, 2019 at 11:36:51AM +0530, Yash Shah wrote: > Hi, > > Any comments on this patch series? > Any more changes are needed or it looks good to be merged upstream? In my eyes it would be great if Andreas Schwab was able to resolve the problems he pointed out in this thread. Best

[PATCH for 5.2 05/12] rseq/selftests: s390: use jg instruction for jumps outside of the asm

2019-04-29 Thread Mathieu Desnoyers
The branch target range of the "j" instruction is 64K, which is not enough for the general case. Suggested-by: Martin Schwidefsky Signed-off-by: Mathieu Desnoyers CC: Thomas Gleixner CC: Joel Fernandes CC: Peter Zijlstra CC: Catalin Marinas CC: Dave Watson CC: Will Deacon CC: Shuah Khan

[PATCH for 5.2 09/12] rseq/selftests: aarch64 code signature: handle big-endian environment

2019-04-29 Thread Mathieu Desnoyers
Handle compiling with -mbig-endian on aarch64, which generates binaries with mixed code vs data endianness (little endian code, big endian data). Else mismatch between code endianness for the generated signatures and data endianness for the RSEQ_SIG parameter passed to the rseq registration will

[PATCH for 5.2 03/12] rseq/selftests: Introduce __rseq_cs_ptr_array, rename __rseq_table to __rseq_cs

2019-04-29 Thread Mathieu Desnoyers
The entries within __rseq_table are aligned on 32 bytes due to linux/rseq.h struct rseq_cs uapi requirements, but the start of the __rseq_table section is not guaranteed to be 32-byte aligned. It can cause padding to be added at the start of the section, which makes it hard to use as an array of

[PATCH for 5.2 07/12] rseq/selftests: s390: use trap4 for RSEQ_SIG

2019-04-29 Thread Mathieu Desnoyers
From: Martin Schwidefsky Use trap4 as the guard instruction for the restartable sequence abort handler. Signed-off-by: Martin Schwidefsky Signed-off-by: Mathieu Desnoyers --- tools/testing/selftests/rseq/rseq-s390.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[PATCH for 5.2 08/12] rseq/selftests: arm: use udf instruction for RSEQ_SIG

2019-04-29 Thread Mathieu Desnoyers
Use udf as the guard instruction for the restartable sequence abort handler. Previously, the chosen signature was not a valid instruction, based on the assumption that it could always sit in a literal pool. However, there are compilation environments in which literal pools are not availble, for

[PATCH for 5.2 06/12] rseq/selftests: x86: use ud1 instruction as RSEQ_SIG opcode

2019-04-29 Thread Mathieu Desnoyers
Use ud1 as the guard instruction for the restartable sequence abort handler. Its benefit compared to nopl is to trap execution if the program ends up trying to execute it by mistake, which makes debugging easier. The 4-byte signature per se is unchanged (it is the instruction operand). Only the

Re: [PATCH 1/4] perf: Fix system-wide events miscounting during cgroup monitoring

2019-04-29 Thread Liang, Kan
On 4/29/2019 11:04 AM, Mark Rutland wrote: On Mon, Apr 29, 2019 at 07:44:02AM -0700, kan.li...@linux.intel.com wrote: From: Kan Liang When counting system-wide events and cgroup events simultaneously, the value of system-wide events are miscounting. For example, perf stat -e

[PATCH for 5.2 04/12] rseq/selftests: Use __rseq_handled symbol to coexist with glibc

2019-04-29 Thread Mathieu Desnoyers
In order to integrate rseq into user-space applications, expose a __rseq_handled symbol so many rseq users can be linked into the same application (e.g. librseq and glibc). The __rseq_refcount TLS variable is static to the librseq library. It ensures that rseq syscall registration/unregistration

Re: [PATCH 3/3] thermal: broadcom: Add Stingray thermal driver

2019-04-29 Thread Srinath Mannam
Hi David, Thank you for notifying.. Hi Sudeep, I will send a patch to remove ACPI support. Regards, Srinath. On Mon, Apr 29, 2019 at 8:54 PM Sudeep Holla wrote: > > On Mon, Apr 29, 2019 at 06:07:12PM +0300, David Woodhouse wrote: > > On Mon, 2018-05-28 at 11:11 +0530, Srinath Mannam wrote: >

Re: [PATCH v2] PCI: aardvark: Use LTSSM state to build link training flag

2019-04-29 Thread Remi Pommarel
Hi Lorenzo, Sorry for duplicates I forgot to include everyone. On Thu, Apr 25, 2019 at 04:06:40PM +0100, Lorenzo Pieralisi wrote: > On Thu, Apr 25, 2019 at 04:23:53PM +0200, Remi Pommarel wrote: > > Hi Lorenzo, > > > > On Thu, Apr 25, 2019 at 12:08:30PM +0100, Lorenzo Pieralisi wrote: > > > On

Re: [PATCH 3/3] thermal: broadcom: Add Stingray thermal driver

2019-04-29 Thread Sudeep Holla
On Mon, Apr 29, 2019 at 06:07:12PM +0300, David Woodhouse wrote: > On Mon, 2018-05-28 at 11:11 +0530, Srinath Mannam wrote: > > From: Pramod Kumar > > > > This commit adds stingray thermal driver to monitor six > > thermal zones temperature and trips at critical temperature. > > This matches an

[PATCH] .gitignore: add / prefix/suffix to generated include directories

2019-04-29 Thread Masahiro Yamada
Clarify these directory paths are relative to the top of source tree. Signed-off-by: Masahiro Yamada --- .gitignore | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index a20ac26..e7bb6c6 100644 --- a/.gitignore +++ b/.gitignore @@ -90,10

Re: [PATCH v3 3/3] arm64: dts: qcom: Add Lenovo Miix 630

2019-04-29 Thread Jeffrey Hugo
On Fri, Apr 26, 2019 at 10:42 PM Bjorn Andersson wrote: > > On Mon 15 Apr 09:11 PDT 2019, Jeffrey Hugo wrote: > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi > > b/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi > [..] > > + thermal-zones { > > + battery-thermal

[PATCH] kernel/module: Reschedule while waiting for modules to finish loading

2019-04-29 Thread Prarit Bhargava
Heiko, do you want a Signed-off-by or a Reported-by? Either one works for me. P. 8< On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while loading the s390_trng.ko module. Add a reschedule point to the loop that waits for modules to complete loading. Reported-by: Heiko

RE: [PATCH 2/2] net-next: stmmac: add mdio clause 45 access from mac device for dwmac4

2019-04-29 Thread Ong, Boon Leong
>Subject: [PATCH 2/2] net-next: stmmac: add mdio clause 45 access from mac >device for dwmac4 > >add clause 45 mdio read and write from mac device for dwmac4. > >Signed-off-by: Biao Huang Hi, I would like to point out that there is another C45 implementation proposed here "net: stmmac: enable

Re: [PATCH v3 1/3] dt-bindings: input: add Elan 400 combo keyboard/touchpad over i2c

2019-04-29 Thread Jeffrey Hugo
On Fri, Apr 26, 2019 at 4:49 PM Rob Herring wrote: > > On Thu, Apr 18, 2019 at 11:35:42AM +0200, Benjamin Tissoires wrote: > > On Mon, Apr 15, 2019 at 6:11 PM Jeffrey Hugo > > wrote: > > > > > > The Elan 400 combo keyboard/touchpad over i2c device is a distinct device > > > from the Elan 400

Re: [PATCH v3] moduleparam: Save information about built-in modules in separate file

2019-04-29 Thread Masahiro Yamada
On Mon, Apr 29, 2019 at 6:09 PM Alexey Gladkov wrote: > > Problem: > > When a kernel module is compiled as a separate module, some important > information about the kernel module is available via .modinfo section of > the module. In contrast, when the kernel module is compiled into the > kernel,

Re: [PATCH 2/4] perf: Add filter_match() as a parameter for pinned/flexible_sched_in()

2019-04-29 Thread Mark Rutland
On Mon, Apr 29, 2019 at 07:44:03AM -0700, kan.li...@linux.intel.com wrote: > From: Kan Liang > > A fast path will be introduced in the following patches to speed up the > cgroup events sched in, which only needs a simpler filter_match(). > > Add filter_match() as a parameter for

[PATCH] irqchip: Remove unneeded select IRQ_DOMAIN

2019-04-29 Thread Geert Uytterhoeven
IRQ_DOMAIN_HIERARCHY selects IRQ_DOMAIN, hence there is no need for drivers to select both. Signed-off-by: Geert Uytterhoeven --- drivers/irqchip/Kconfig | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index

Re: [PATCH] driver core: platform: Fix the usage of platform device name(pdev->name)

2019-04-29 Thread Krzysztof Kozlowski
80). One can see the error of missing root device: [ 13.458982] VFS: Cannot open root device "mmcblk0" or unknown-block(0,0): error -6 ... also before there is a warning like: [0.285029] [ cut here ] [0.285507] WARNING: CPU: 0 PID: 1 at /home/krzk/de

Re: [PATCH 1/4] perf: Fix system-wide events miscounting during cgroup monitoring

2019-04-29 Thread Mark Rutland
On Mon, Apr 29, 2019 at 07:44:02AM -0700, kan.li...@linux.intel.com wrote: > From: Kan Liang > > When counting system-wide events and cgroup events simultaneously, the > value of system-wide events are miscounting. For example, > > perf stat -e cycles,instructions -e cycles,instructions -G

Re: [PATCH 3/3] thermal: broadcom: Add Stingray thermal driver

2019-04-29 Thread David Woodhouse
On Mon, 2018-05-28 at 11:11 +0530, Srinath Mannam wrote: > From: Pramod Kumar > > This commit adds stingray thermal driver to monitor six > thermal zones temperature and trips at critical temperature. This matches an ACPI "BRCM0500" device but then calls devm_thermal_zone_of_sensor_register(),

RE: [PATCH RFC V2] staging: kpc2000: use int for wait_for_completion_interruptible

2019-04-29 Thread Matt Sickler
ACK. However, that part isn't the only part of that function that uses "return rv" though. There's another part that does "rv = get_user_pages(...)" and get_user_pages() returns a long. Does this same kind of change need to happen for that case? >-Original Message- >From: Nicholas Mc

Re: linux-next: Tree for Apr 29 (drivers/leds/leds-turris-omnia)

2019-04-29 Thread Randy Dunlap
On 4/29/19 2:03 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190426: > on i386: when CONFIG_LEDS_TURRIS_OMNIA=y and CONFIG_I2C=m: Probably should also depend on I2C. ld: drivers/leds/leds-turris-omnia.o: in function `omnia_leds_remove': leds-turris-omnia.c:(.text+0xb):

[PATCH] platform/x86: pmc_atom: Add Lex 3I380D industrial PC to critclk_systems DMI table

2019-04-29 Thread Hans de Goede
The Lex 3I380D industrial PC has 4 ethernet controllers on board which need pmc_plt_clk0 - 3 to function, add it to the critclk_systems DMI table, so that drivers/clk/x86/clk-pmc-atom.c will mark the clocks as CLK_CRITICAL and they will not get turned off. Fixes: 648e921888ad ("clk: x86: Stop

[PATCH] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()

2019-04-29 Thread Petr Mladek
WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous. The only current user klp_check_stack() writes its own warning when -ENOSYS is returned. Signed-off-by: Petr Mladek Acked-by: Josh Poimboeuf Acked-by: Miroslav Benes Reviewed-by: Kamalesh Babulal ---

Re: [PATCH v1 2/2] perf cs-etm: Don't check cs_etm_queue::prev_packet validity

2019-04-29 Thread Robert Walker
On 28/04/2019 09:32, Leo Yan wrote: Since cs_etm_queue::prev_packet is allocated for all cases, it will never be NULL pointer; now validity checking prev_packet is pointless, remove all of them. Signed-off-by: Leo Yan --- tools/perf/util/cs-etm.c | 6 +- 1 file changed, 1

Re: [PATCH] dmaengine: stm32-dma: fix residue calculation in stm32-dma

2019-04-29 Thread Arnaud Pouliquen
On 4/29/19 7:13 AM, Vinod Koul wrote: > On 26-04-19, 15:41, Arnaud Pouliquen wrote: During residue calculation. the DMA can switch to the next sg. When this race condition occurs, the residue returned value is not valid. Indeed the position in the sg returned by the hardware is

Re: [PATCH] memcg, oom: no oom-kill for __GFP_RETRY_MAYFAIL

2019-04-29 Thread Michal Hocko
On Mon 29-04-19 07:37:08, Shakeel Butt wrote: > On Mon, Apr 29, 2019 at 5:22 AM Michal Hocko wrote: > > > > On Sun 28-04-19 16:56:13, Shakeel Butt wrote: > > > The documentation of __GFP_RETRY_MAYFAIL clearly mentioned that the > > > OOM killer will not be triggered and indeed the page alloc does

[RFC] Disable lockref on arm64

2019-04-29 Thread Jan Glauber
Hi Catalin & Will, I've been looking into performance issues that were reported for several test-cases, for instance an nginx benchmark. It turned out the issue we have on ThunderX2 is the file open-close sequence with small read sizes. If the used files are opened read-only the lockref code

Re: [PATCH v1 1/2] perf cs-etm: Always allocate memory for cs_etm_queue::prev_packet

2019-04-29 Thread Robert Walker
Hi, On 28/04/2019 09:32, Leo Yan wrote: Robert Walker reported a segmentation fault is observed when process CoreSight trace data; this issue can be easily reproduced by the command 'perf report --itrace=i1000i' for decoding tracing data. If neither the 'b' flag (synthesize branches events)

Re: scripts/selinux build error in 4.14 after glibc update

2019-04-29 Thread Greg KH
On Mon, Apr 29, 2019 at 10:47:00AM -0400, Paul Moore wrote: > On Mon, Apr 29, 2019 at 10:09 AM Greg KH wrote: > > On Mon, Apr 29, 2019 at 10:02:29AM -0400, Paul Moore wrote: > > > On Mon, Apr 29, 2019 at 8:40 AM Greg KH > > > wrote: > > > > On Tue, Apr 23, 2019 at 09:43:09AM -0400, Paul Moore

Re: [PATCH v6 07/10] drivers: memory: add DMC driver for Exynos5422

2019-04-29 Thread Lukasz Luba
Hi Krzysztof, On 4/23/19 1:27 PM, Krzysztof Kozlowski wrote: > On Fri, 19 Apr 2019 at 16:19, Lukasz Luba wrote: >> >> This patch adds driver for Exynos5422 Dynamic Memory Controller. >> The driver provides support for dynamic frequency and voltage scaling for >> DMC and DRAM. It supports

Re: [PATCH] Documentation: atomic_t.txt: Explain ordering provided by smp_mb__{before,after}_atomic()

2019-04-29 Thread Paul E. McKenney
On Mon, Apr 29, 2019 at 11:24:30AM +0200, Johan Hovold wrote: > On Tue, Apr 23, 2019 at 06:30:10AM -0700, Paul E. McKenney wrote: > > On Tue, Apr 23, 2019 at 02:32:09PM +0200, Peter Zijlstra wrote: > > > On Sat, Apr 20, 2019 at 01:54:40AM -0700, Paul E. McKenney wrote: > > > > > And lock

Re: [PATCH] PCI: Add link_change error handler and vfio-pci user

2019-04-29 Thread Alex Williamson
On Wed, 24 Apr 2019 12:57:58 -0500 Bjorn Helgaas wrote: > On Tue, Apr 23, 2019 at 04:42:28PM -0600, Alex Williamson wrote: > > The PCIe bandwidth notification service generates logging any time a > > link changes speed or width to a state that is considered downgraded. > > Unfortunately, it

Re: scripts/selinux build error in 4.14 after glibc update

2019-04-29 Thread Paul Moore
On Mon, Apr 29, 2019 at 10:09 AM Greg KH wrote: > On Mon, Apr 29, 2019 at 10:02:29AM -0400, Paul Moore wrote: > > On Mon, Apr 29, 2019 at 8:40 AM Greg KH wrote: > > > On Tue, Apr 23, 2019 at 09:43:09AM -0400, Paul Moore wrote: > > > > On Tue, Apr 23, 2019 at 9:29 AM Sasha Levin wrote: > > > > >

Re: [PATCH -next] lib/vsprintf: Make function pointer_string static

2019-04-29 Thread Steven Rostedt
[ added Joe ] On Mon, 29 Apr 2019 16:30:37 +0200 Petr Mladek wrote: > On Mon 2019-04-29 09:13:20, Steven Rostedt wrote: > > On Mon, 29 Apr 2019 13:08:01 +0200 > > Petr Mladek wrote: > > > > > > Looks like commit "vsprintf: Do not check address of well-known > > > > strings" removed the:

Re: [PATCH 23/26] iommu/dma: Don't depend on CONFIG_DMA_DIRECT_REMAP

2019-04-29 Thread Robin Murphy
On 22/04/2019 18:59, Christoph Hellwig wrote: For entirely dma coherent architectures there is no requirement to ever remap dma coherent allocation. Move all the remap and pool code under IS_ENABLED() checks and drop the Kconfig dependency. Reviewed-by: Robin Murphy Signed-off-by:

[PATCH] tools/power/acpi: exclude tools/* from .gitignore pattern

2019-04-29 Thread Masahiro Yamada
tools/power/acpi/.gitignore has the following entries: acpidbg acpidump ec They are intended to ignore the following build artifacts: tools/power/acpi/acpidbg tools/power/acpi/acpidump tools/power/acpi/ec However, those .gitignore entries are effective not only for the current

Re: [PATCH 0/5] mtd: onenand/samsung: Add device tree support

2019-04-29 Thread Paweł Chmiel
On poniedziałek, 29 kwietnia 2019 10:19:28 CEST Miquel Raynal wrote: > Hi Paweł, > > Paweł Chmiel wrote on Fri, 26 Apr 2019 > 18:42:19 +0200: > > > This patchset adds device tree support to Samsung OneNAND driver. > > It was tested on Samsung Galaxy S and Samsung Galaxy S Fascinate 4G, > > an

Re: [PATCH] kernel: remove the unused device_private_entry_fault export

2019-04-29 Thread Dan Williams
On Mon, Apr 29, 2019 at 4:56 AM Christoph Hellwig wrote: > > This export has been entirely unused since it was added more than 1 1/2 > years ago. > > Signed-off-by: Christoph Hellwig > --- > kernel/memremap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/memremap.c

[PATCH 1/4] perf: Fix system-wide events miscounting during cgroup monitoring

2019-04-29 Thread kan . liang
From: Kan Liang When counting system-wide events and cgroup events simultaneously, the value of system-wide events are miscounting. For example, perf stat -e cycles,instructions -e cycles,instructions -G cgroup1,cgroup1,cgroup2,cgroup2 -a -e cycles,instructions -I 1000 1.096265502

[PATCH 3/4] perf cgroup: Add cgroup ID as a key of RB tree

2019-04-29 Thread kan . liang
From: Kan Liang Current RB tree for pinned/flexible groups doesn't take cgroup into account. All events on a given CPU will be fed to pinned/flexible_sched_in(), which relies on perf_cgroup_match() to filter the events for a specific cgroup. The method has high overhead, especially in frequent

[PATCH 2/4] perf: Add filter_match() as a parameter for pinned/flexible_sched_in()

2019-04-29 Thread kan . liang
From: Kan Liang A fast path will be introduced in the following patches to speed up the cgroup events sched in, which only needs a simpler filter_match(). Add filter_match() as a parameter for pinned/flexible_sched_in(). No functional change. Signed-off-by: Kan Liang ---

[PATCH 0/4] Optimize cgroup context switch

2019-04-29 Thread kan . liang
From: Kan Liang On systems with very high context switch rates between cgroups, there are high overhead using cgroup perf. Current codes have two issues. - System-wide events are mistakenly switched in cgroup context switch. It causes system-wide events miscounting, and brings avoidable

[PATCH 4/4] perf cgroup: Add fast path for cgroup switch

2019-04-29 Thread kan . liang
From: Kan Liang Generic visit_groups_merge() is used in cgroup context switch to sched in cgroup events, which has high overhead especially in frequent context switch with several events and cgroups involved. Because it feeds all events on a given CPU to pinned/flexible_sched_in() regardless the

Re: [PATCH 1/3] livepatch: Convert error about unsupported reliable stacktrace into a warning

2019-04-29 Thread Petr Mladek
On Wed 2019-04-24 10:55:48, Petr Mladek wrote: > The commit d0807da78e11d46f ("livepatch: Remove immediate feature") caused > that any livepatch was refused when reliable stacktraces were not supported > on the given architecture. > > The limitation is too strong. User space processes are safely

Re: [PATCH] memcg, oom: no oom-kill for __GFP_RETRY_MAYFAIL

2019-04-29 Thread Shakeel Butt
On Mon, Apr 29, 2019 at 5:22 AM Michal Hocko wrote: > > On Sun 28-04-19 16:56:13, Shakeel Butt wrote: > > The documentation of __GFP_RETRY_MAYFAIL clearly mentioned that the > > OOM killer will not be triggered and indeed the page alloc does not > > invoke OOM killer for such allocations. However

Re: [PATCH] firmware: ti_sci: Always request response from firmware

2019-04-29 Thread Nishanth Menon
On 09:15-20190429, Andrew F. Davis wrote: > TI-SCI firmware will only respond to messages when the > TI_SCI_FLAG_REQ_ACK_ON_PROCESSED flag is set. Most messages already do > this, set this for the ones that do not. > > This will be enforced in future firmware that better m

[PATCH] platform/x86: ideapad-laptop: Remove no_hw_rfkill_list

2019-04-29 Thread Hans de Goede
When the ideapad-laptop driver was first written it was written for laptops which had a hardware rfkill switch. So when the first ideapad laptops showed up without a hw rfkill switch and it turned out that in this case the ideapad firmware interface would always report the wifi being hardware-

Re: [PATCH v2] tty: serial: 8250: Fix type field in format string

2019-04-29 Thread Greg KH
On Sat, Apr 27, 2019 at 05:19:43PM +0800, Hao Lee wrote: > The dev_dbg statement should print the value of uart.port.mapbase instead > of its address. Besides that, uart.port.irq and uart.port.iotype are all > unsigned types, so using %u is more appropriate. > > Signed-off-by: Hao Lee > --- >

[PATCH] sh: exclude vmlinux.scr from .gitignore pattern

2019-04-29 Thread Masahiro Yamada
arch/sh/boot/.gitignore has the pattern "vmlinux*"; this is effective not only for the current directory, but also for any sub-directories. So, the following files are also considered to be ignored: arch/sh/boot/compressed/vmlinux.scr arch/sh/boot/romimage/vmlinux.scr They are obviously

Re: [PATCH -next] lib/vsprintf: Make function pointer_string static

2019-04-29 Thread Petr Mladek
On Mon 2019-04-29 09:13:20, Steven Rostedt wrote: > On Mon, 29 Apr 2019 13:08:01 +0200 > Petr Mladek wrote: > > > > Looks like commit "vsprintf: Do not check address of well-known > > > strings" removed the: "static noinline_for_stack" > > > > > > Does pointer_string() need that still? > > >

Re: [PATCH v1 1/2] Add polling support to pidfd

2019-04-29 Thread Oleg Nesterov
On 04/29, Joel Fernandes wrote: > > On Mon, Apr 29, 2019 at 10:02:45AM -0400, Joel Fernandes wrote: > > On Sun, Apr 28, 2019 at 06:24:06PM +0200, Oleg Nesterov wrote: > [snip] > > > > > +{ > > > > > + struct pid *pid; > > > > > + > > > > > + lockdep_assert_held(_lock); > > > > > + > > > >

Re: How to debug these general protection fault: 0000 [#1] SMP KASAN PTI issues ?

2019-04-29 Thread Dmitry Vyukov
On Fri, Apr 26, 2019 at 8:40 PM JohnD Oracle wrote: > > Hi > > > I am seeing a number of miss leading information in these reports , and I > don't have an adequate understanding how KASAN > works in order to know to debug it. > > For instance; > > Lets look at this event : > > kasan:

Re: [RFC PATCH v2] i2c-piix4: Add Hygon Dhyana SMBus support

2019-04-29 Thread Jean Delvare
On Sat, 27 Apr 2019 09:07:44 +0800, Pu Wen wrote: > The Hygon Dhyana CPU has the SMBus device with PCI device ID 0x790b, > which is the same as AMD CZ SMBus device. So add Hygon Dhyana support > to the i2c-piix4 driver by using the code path of AMD. > > Signed-off-by: Pu Wen > --- > v1->v2: >

Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

2019-04-29 Thread Esben Haabendal
Andy Shevchenko writes: > On Mon, Apr 29, 2019 at 11:29:05AM +0200, Esben Haabendal wrote: >> Andy Shevchenko writes: >> > On Mon, Apr 29, 2019 at 9:27 AM Esben Haabendal wrote: >> >> Andy Shevchenko writes: >> >> > On Sat, Apr 27, 2019 at 12:01 PM Esben Haabendal >> >> > wrote: >> >> >>

Re: [PATCH v3] moduleparam: Save information about built-in modules in separate file

2019-04-29 Thread Jessica Yu
+++ Alexey Gladkov [29/04/19 11:08 +0200]: Problem: When a kernel module is compiled as a separate module, some important information about the kernel module is available via .modinfo section of the module. In contrast, when the kernel module is compiled into the kernel, that information is

Re: [PATCH v3 2/5] nds32: Use the correct style for SPDX License Identifier

2019-04-29 Thread Nishad Kamdar
On Tue, Apr 16, 2019 at 08:35:38PM +0200, Thomas Gleixner wrote: > On Tue, 16 Apr 2019, Nishad Kamdar wrote: > > > This patch corrects the SPDX License Identifier style > > in the nds32 Hardware Architecture related files. > > > > Suggested-by: Joe Perches > > Signed-off-by: Nishad Kamdar > >

Re: [PATCH v13 04/20] mm, arm64: untag user pointers passed to memory syscalls

2019-04-29 Thread Andrey Konovalov
On Fri, Apr 26, 2019 at 4:17 PM Catalin Marinas wrote: > > On Tue, Apr 02, 2019 at 02:47:34PM +0200, Andrey Konovalov wrote: > > On Fri, Mar 29, 2019 at 11:30 AM Catalin Marinas > > wrote: > > > On Thu, Mar 28, 2019 at 02:19:34PM -0400, Steven Rostedt wrote: > > > > On Thu, 28 Mar 2019 19:10:07

Re: [PATCH 2/2] regulator: vexpress: Switch to SPDX identifier

2019-04-29 Thread Sudeep Holla
On Mon, Apr 29, 2019 at 07:35:42PM +0800, Axel Lin wrote: I prefer to have a line of description, worst case repeat the subject, but don't leave empty. With that: Acked-by: Sudeep Holla -- Regards, Sudeep

Re: [PATCH v1 1/2] Add polling support to pidfd

2019-04-29 Thread Oleg Nesterov
On 04/29, Joel Fernandes wrote: > > However, in your code above, it is avoided because we get: > > Task A (poller) Task B (exiting task being polled) > > poll() called > add_wait_queue() > exit_state is set to non-zero >

[tip:locking/core] locking/lockdep: Remove unnecessary unlikely()

2019-04-29 Thread tip-bot for zhengbin
Commit-ID: d671002be6bdd7f77a771e23bf3e95d1f16775e6 Gitweb: https://git.kernel.org/tip/d671002be6bdd7f77a771e23bf3e95d1f16775e6 Author: zhengbin AuthorDate: Mon, 29 Apr 2019 20:26:31 +0800 Committer: Ingo Molnar CommitDate: Mon, 29 Apr 2019 16:11:01 +0200 locking/lockdep: Remove

Re: [PATCH 1/2] regulator: vexpress: Get rid of struct vexpress_regulator

2019-04-29 Thread Sudeep Holla
Hi Axel, On Mon, Apr 29, 2019 at 07:35:41PM +0800, Axel Lin wrote: > The *regdev and *regmap can be replaced by local variables in probe(). > Only desc of struct vexpress_regulator is really need, so just use > struct regulator_desc directly and remove struct vexpress_regulator. > Looks good,

Re: [PATCH v3 2/2] x86/fault: Decode and print #PF oops in human readable form

2019-04-29 Thread Borislav Petkov
On Mon, Apr 29, 2019 at 03:58:20PM +0200, Dmitry Vyukov wrote: > Ideally, such changes are coordinated with kernel testing for gradual > rollout. Since kernel does not provide an official facility for crash > parsing, the actual output effectively becomes part of public API. Well, printk message

Re: [x86/unwind] 0830cf62f5: BUG:KASAN:stack-out-of-bounds_in_u

2019-04-29 Thread Jann Horn
On Sun, Apr 28, 2019 at 10:30 PM kernel test robot wrote: > FYI, we noticed the following commit (built with gcc-7): > > commit: 0830cf62f5290b2f878faacc2b6f32e77bc2ea12 ("x86/unwind: Add hardcoded > ORC entry for NULL") > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable-rc.git

Re: scripts/selinux build error in 4.14 after glibc update

2019-04-29 Thread Greg KH
On Mon, Apr 29, 2019 at 10:02:29AM -0400, Paul Moore wrote: > On Mon, Apr 29, 2019 at 8:40 AM Greg KH wrote: > > On Tue, Apr 23, 2019 at 09:43:09AM -0400, Paul Moore wrote: > > > On Tue, Apr 23, 2019 at 9:29 AM Sasha Levin wrote: > > > > On Mon, Apr 22, 2019 at 09:59:47PM -0400, Paul Moore

<    1   2   3   4   5   6   7   8   >