Re: [PATCH v3 4/4] staging: vchiq: stop explicitly comparing with zero to catch errors

2019-05-09 Thread Dan Carpenter
On Thu, May 09, 2019 at 04:31:36PM +0200, Nicolas Saenz Julienne wrote: > The vchiq code tends to follow a coding pattern that's not accepted as > per the Linux kernel coding style > > We have this: > if (expression != 0) > > We want this: > if (expression) > > We make an exception

Re: [PATCH v2 12/18] fpga: dfl: afu: add error reporting support.

2019-05-09 Thread Alan Tull
On Mon, Apr 29, 2019 at 4:12 AM Wu Hao wrote: > > Error reporting is one important private feature, it reports error > detected on port and accelerated function unit (AFU). It introduces > several sysfs interfaces to allow userspace to check and clear > errors detected by hardware. > >

Re: [PATCH] EDAC, sb_edac: remove redundant update of tad_base

2019-05-09 Thread Borislav Petkov
On Thu, May 09, 2019 at 03:29:42PM +0100, Colin Ian King wrote: > These are the Coverity static analysis warning/error message > classifications. Tagging them should be useful for several reasons: > > 1. We can classify the types of issues being fixed > 2. We can see how many issues are being

Re: [PATCH v7 6/6] perf-probe: Add user memory access attribute support

2019-05-09 Thread Masami Hiramatsu
On Thu, 9 May 2019 11:17:35 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > --- a/tools/perf/util/probe-event.h > > +++ b/tools/perf/util/probe-event.h > > @@ -37,6 +37,7 @@ struct probe_trace_point { > > struct probe_trace_arg_ref { > > struct probe_trace_arg_ref

[PATCH v4 03/10] livepatch: Add klp-convert tool

2019-05-09 Thread Joe Lawrence
From: Josh Poimboeuf Livepatches may use symbols which are not contained in its own scope, and, because of that, may end up compiled with relocations that will only be resolved during module load. Yet, when the referenced symbols are not exported, solving this relocation requires information on

[PATCH] spi: bcm2835: only split transfers that exceed DLEN if DMA available

2019-05-09 Thread Nicolas Saenz Julienne
There is no use for this when performing non DMA operations. So we bypass the split. Signed-off-by: Nicolas Saenz Julienne --- drivers/spi/spi-bcm2835.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-bcm2835.c

[PATCH v4 05/10] modpost: Integrate klp-convert

2019-05-09 Thread Joe Lawrence
From: Josh Poimboeuf Create cmd_klp_convert and hook it into scripts/Makefile.modpost. cmd_klp_convert invokes klp-convert with the right arguments for the conversion of unresolved symbols inside a livepatch. Signed-off-by: Josh Poimboeuf Signed-off-by: Konstantin Khlebnikov Signed-off-by:

[PATCH v4 04/10] livepatch: Add klp-convert annotation helpers

2019-05-09 Thread Joe Lawrence
From: Josh Poimboeuf Define macros KLP_MODULE_RELOC and KLP_SYMPOS in include/linux/livepatch.h to improve user-friendliness of the livepatch annotation process. Signed-off-by: Josh Poimboeuf Signed-off-by: Joao Moreira Signed-off-by: Joe Lawrence --- include/linux/livepatch.h | 12

[PATCH v4 07/10] livepatch: Add sample livepatch module

2019-05-09 Thread Joe Lawrence
From: Josh Poimboeuf Add a new livepatch sample in samples/livepatch/ to make use of symbols that must be post-processed to enable load-time relocation resolution. As the new sample is to be used as an example, it is annotated with KLP_MODULE_RELOC and with KLP_SYMPOS macros. The livepatch

[PATCH v4 10/10] livepatch/klp-convert: abort on special sections

2019-05-09 Thread Joe Lawrence
To properly convert alternatives, paravirt ops, and static keys, klp-convert needs to implement "klp.arch" sections as supported by d4c3e6e1b193 (“livepatch/x86: apply alternatives and paravirt patches after relocations”). There is some amount of ELF section bookkeeping required for this (ie,

[PATCH v4 09/10] livepatch/selftests: add klp-convert

2019-05-09 Thread Joe Lawrence
Add a simple klp-convert livepatch selftest that exercises various symbol homonym sympos scenarios. Signed-off-by: Joe Lawrence --- lib/livepatch/Makefile| 10 ++ lib/livepatch/test_klp_convert1.c | 106 ++ lib/livepatch/test_klp_convert2.c

[PATCH v4 02/10] kbuild: Support for Symbols.list creation

2019-05-09 Thread Joe Lawrence
From: Joao Moreira For automatic resolution of livepatch relocations, a file called Symbols.list is used. This file maps symbols within every compiled kernel object allowing the identification of symbols whose name is unique, thus relocation can be automatically inferred, or providing

[PATCH v4 08/10] documentation: Update on livepatch elf format

2019-05-09 Thread Joe Lawrence
From: Joao Moreira Add a section to Documentation/livepatch/module-elf-format.txt describing how klp-convert works for fixing relocations. Signed-off-by: Joao Moreira Signed-off-by: Joe Lawrence --- Documentation/livepatch/livepatch.txt | 3 ++

[PATCH v4 00/10] klp-convert livepatch build tooling

2019-05-09 Thread Joe Lawrence
Hi all, Thanks for the feedback to v3, I've incorporated a few more bug fixes and style/spelling nitpicks for the series. v4 is a bit of a resting place to collect loose ends before considering some heavier future work, namely arch-specific special section support. See the TODO section below

Re: [PATCH RFC 4/6] ARM: dts: msm8974: add display support

2019-05-09 Thread Rob Clark
On Thu, May 9, 2019 at 12:12 AM Brian Masney wrote: > > On Wed, May 08, 2019 at 08:00:47PM -0700, Bjorn Andersson wrote: > > On Wed 08 May 19:25 PDT 2019, Rob Clark wrote: > > > > > On Wed, May 8, 2019 at 7:16 PM Brian Masney wrote: > > > > > > > > On Mon, May 06, 2019 at 11:39:02PM -0700, Bjorn

[PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules

2019-05-09 Thread Joe Lawrence
From: Miroslav Benes Currently, livepatch infrastructure in the kernel relies on MODULE_INFO(livepatch, "Y") statement in a livepatch module. Then the kernel module loader knows a module is indeed livepatch module and can behave accordingly. klp-convert, on the other hand relies on LIVEPATCH_*

[PATCH v4 01/10] livepatch: Create and include UAPI headers

2019-05-09 Thread Joe Lawrence
From: Josh Poimboeuf Define klp prefixes in include/uapi/linux/livepatch.h, and use them for replacing hard-coded values in kernel/livepatch/core.c. Update MAINTAINERS. Note: Add defines to uapi as these are also to be used by a newly introduced klp-convert script. Signed-off-by: Josh

Re: [PATCH] driver core: Fix use-after-free and double free on glue directory

2019-05-09 Thread Gaurav Kohli
Hi , Last patch will serialize the addition of child to parent directory, won't it affect performance. Regards Gaurav On 5/4/2019 9:04 PM, Greg KH wrote: On Sat, May 04, 2019 at 10:47:07PM +0800, Muchun Song wrote: Benjamin Herrenschmidt 于2019年5月2日周四 下午2:25写道: The basic idea yes, the

Re: [PATCH v7 1/1] usb: xhci: Add Clear_TT_Buffer

2019-05-09 Thread Alan Stern
On Thu, 9 May 2019, Greg KH wrote: > On Thu, May 09, 2019 at 08:03:15PM +0800, Jim Lin wrote: > > --- a/include/linux/usb.h > > +++ b/include/linux/usb.h > > @@ -625,6 +625,7 @@ struct usb3_lpm_parameters { > > * parent->hub_delay + wHubDelay + tTPTransmissionDelay (40ns) > > * > >

[PATCH v3 3/4] staging: vchiq: make wait events interruptible

2019-05-09 Thread Nicolas Saenz Julienne
The killable version of wait_event() is meant to be used on situations where it should not fail at all costs, but still have the convenience of being able to kill it if really necessary. Wait events in VCHIQ doesn't fit this criteria, as it's mainly used as an interface to V4L2 and ALSA devices.

[PATCH v3 1/4] staging: vchiq_2835_arm: revert "quit using custom down_interruptible()"

2019-05-09 Thread Nicolas Saenz Julienne
The killable version of down() is meant to be used on situations where it should not fail at all costs, but still have the convenience of being able to kill it if really necessary. VCHIQ doesn't fit this criteria, as it's mainly used as an interface to V4L2 and ALSA devices. Fixes: ff5979ad8636

[PATCH v3 2/4] staging: vchiq: revert "switch to wait_for_completion_killable"

2019-05-09 Thread Nicolas Saenz Julienne
The killable version of wait_for_completion() is meant to be used on situations where it should not fail at all costs, but still have the convenience of being able to kill it if really necessary. VCHIQ doesn't fit this criteria, as it's mainly used as an interface to V4L2 and ALSA devices. Fixes:

[PATCH v3 0/4] staging: vchiq: use interruptible waits

2019-05-09 Thread Nicolas Saenz Julienne
Hi, this series tries to address an issue that came up in Raspbian's kernel tree [1] and upstream distros [2][3]. We adopted some changes that moved wait calls from a custom implementation to the more standard killable family of functions. Users complained that all the VCHIQ threads showed up in

[PATCH v3 4/4] staging: vchiq: stop explicitly comparing with zero to catch errors

2019-05-09 Thread Nicolas Saenz Julienne
The vchiq code tends to follow a coding pattern that's not accepted as per the Linux kernel coding style We have this: if (expression != 0) We want this: if (expression) We make an exception if the expression refers to a size, in which case it's accepted for the sake of clarity.

Re: [PATCH v2 4/8] mm/memory_hotplug: Create memory block devices after arch_add_memory()

2019-05-09 Thread Wei Yang
On Tue, May 07, 2019 at 08:38:00PM +0200, David Hildenbrand wrote: >Only memory to be added to the buddy and to be onlined/offlined by >user space using memory block devices needs (and should have!) memory >block devices. > >Factor out creation of memory block devices Create all devices after

Re: [PATCH] EDAC, sb_edac: remove redundant update of tad_base

2019-05-09 Thread Colin Ian King
On 09/05/2019 15:13, Borislav Petkov wrote: > On Wed, May 08, 2019 at 11:42:01PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The variable tad_base is being set to a value that is never read >> and is being over-written on the next iteration of a for-loop. >> This assignment is

Re: [PATCH] fs,xfs: fix missed wakeup on l_flush_wait

2019-05-09 Thread Rik van Riel
On Thu, 2019-05-09 at 07:32 +1000, Dave Chinner wrote: > Hmmm, the first wakeup in xsdc is this one, right: > > /* wake up threads waiting in xfs_log_force() */ > wake_up_all(>ic_force_wait); > > At the end of the iclog iteration loop? That one is under the >

Re: BUG: soft lockup in kvm_vm_ioctl

2019-05-09 Thread Dmitry Vyukov
> > > > Can the KVM maintainers take a look at this? This doesn't have > > > > anything to do > > > > with my commit that syzbot bisected it to. > > > > > > > > +Dmitry, statistics lession: if a crash occurs only 1 in 10 times, as > > > > was the > > > > case here, then often it will happen 0

Re: [PATCH v7 3/6] tracing/probe: Add ustring type for user-space string

2019-05-09 Thread Masami Hiramatsu
On Thu, 9 May 2019 11:15:07 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > Add "ustring" type for fetching user-space string from kprobe event. > > User can specify ustring type at uprobe event, and it is same as > > "string" for uprobe. > > > > Note that probe-event provides

Re: [PATCH v7 2/6] uaccess: Add non-pagefault user-space read functions

2019-05-09 Thread Masami Hiramatsu
Hi Ingo, On Thu, 9 May 2019 11:14:08 +0200 Ingo Molnar wrote: > * Masami Hiramatsu wrote: > > > +static __always_inline long > > +probe_read_common(void *dst, const void __user *src, size_t size) > > +{ > > + long ret; > > + > > + pagefault_disable(); > > + ret =

[PATCH 04/10] PCI/AER: Log messages with pci_dev, not pcie_device

2019-05-09 Thread Bjorn Helgaas
From: Frederick Lawler Log messages with pci_dev, not pcie_device. Factor out common message prefixes with dev_fmt(). Example output change: - aer :00:00.0:pci002: AER enabled with IRQ ... + pcieport :00:00.0: AER: enabled with IRQ ... Link:

[PATCH 07/10] PCI: pciehp: Log messages with pci_dev, not pcie_device

2019-05-09 Thread Bjorn Helgaas
From: Frederick Lawler Log messages with pci_dev, not pcie_device. Factor out common message prefixes with dev_fmt(). Example output change: - pciehp :00:06.0:pcie004: Slot(0) Powering on due to button press + pcieport :00:06.0: pciehp: Slot(0) Powering on due to button press

Re: [PATCH] MAINTAINERS: kbuild: Add pattern for scripts/*vmlinux*

2019-05-09 Thread Masahiro Yamada
On Mon, May 6, 2019 at 9:47 PM Krzysztof Kozlowski wrote: > > scripts/link-vmlinux.sh is part of kbuild so extend the pattern to match > any vmlinux related scripts. > > Signed-off-by: Krzysztof Kozlowski Applied to linux-kbuild. Thanks. > --- > MAINTAINERS | 1 + > 1 file changed, 1

[PATCH 06/10] PCI: pciehp: Replace pciehp_debug module param with dyndbg

2019-05-09 Thread Bjorn Helgaas
From: Frederick Lawler Previously pciehp debug messages were enabled by the pciehp_debug module parameter, e.g., by booting with this kernel command line option: pciehp.pciehp_debug=1 Convert this mechanism to use the generic dynamic debug (dyndbg) feature. After this commit, pciehp debug

RE: arch/x86/kernel/apic/apic.c: calibrate_APIC_clock() soft hangs when PIC is not configured by BIOS before kernel is launched.

2019-05-09 Thread Kirkendall, Garrett
1. Is it correct to probe the 8259 before it is initialized by the kernel? The 8259 will not respond properly to the probe unless it is properly initialized. 2. Should IOAPIC interrupts 0-15 require the legacy PIC be available and initialized by the BIOS? 2. The kernel will not boot if

[PATCH 09/10] PCI: pciehp: Remove pointless PCIE_MODULE_NAME definition

2019-05-09 Thread Bjorn Helgaas
From: Bjorn Helgaas PCIE_MODULE_NAME is only used once and offers no benefit, so remove it. Signed-off-by: Bjorn Helgaas --- drivers/pci/hotplug/pciehp_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pci/hotplug/pciehp_core.c

[PATCH 10/10] PCI: pciehp: Remove pointless MY_NAME definition

2019-05-09 Thread Bjorn Helgaas
From: Bjorn Helgaas MY_NAME is only used once and offers no benefit, so remove it. Signed-off-by: Bjorn Helgaas --- drivers/pci/hotplug/pciehp.h | 2 -- drivers/pci/hotplug/pciehp_hpc.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pci/hotplug/pciehp.h

[PATCH 08/10] PCI: pciehp: Remove unused dbg/err/info/warn() wrappers

2019-05-09 Thread Bjorn Helgaas
From: Frederick Lawler Replace the last uses of dbg() with the equivalent pr_debug(), then remove unused dbg(), err(), info(), and warn() wrappers. Link: https://lore.kernel.org/lkml/20190503035946.23608-9-f...@fredlawl.com Signed-off-by: Frederick Lawler Signed-off-by: Bjorn Helgaas ---

[PATCH 02/10] PCI/PME: Replace dev_printk(KERN_DEBUG) with dev_info()

2019-05-09 Thread Bjorn Helgaas
From: Frederick Lawler Replace dev_printk(KERN_DEBUG) with dev_info() or dev_err() to be more consistent with other logging. These could be converted to dev_dbg(), but that depends on CONFIG_DYNAMIC_DEBUG and DEBUG, and we want most of these messages to *always* be in the dmesg log. Also, use

[PATCH 3.16 05/10] vxlan: Fix big-endian declaration of VNI

2019-05-09 Thread Ben Hutchings
3.16.67-rc1 review patch. If anyone has any objections, please let me know. -- From: Ben Hutchings In this version of the driver, VNIs are consistently kept in host order. However vxlan_fdb_create() erroneously declares its vni parameter as __be32, which sparse warns about.

[PATCH v4 00/10] PCI: Log with pci_dev, not pcie_device

2019-05-09 Thread Bjorn Helgaas
From: Bjorn Helgaas This is a collection of updates to Fred's v2 patches from: https://lore.kernel.org/lkml/20190503035946.23608-1-f...@fredlawl.com and some follow-on discussion. Bjorn Helgaas (3): PCI: pciehp: Remove pciehp_debug uses PCI: pciehp: Remove pointless PCIE_MODULE_NAME

[PATCH 03/10] PCI/DPC: Log messages with pci_dev, not pcie_device

2019-05-09 Thread Bjorn Helgaas
From: Frederick Lawler Log messages with pci_dev, not pcie_device. Factor out common message prefixes with dev_fmt(). Example output change: - dpc :00:01.1:pcie008: DPC error containment capabilities... + pcieport :00:01.1: DPC: error containment capabilities... Link:

[PATCH 05/10] PCI: pciehp: Remove pciehp_debug uses

2019-05-09 Thread Bjorn Helgaas
From: Bjorn Helgaas We're about to convert pciehp to the dyndbg mechanism, which means we can eventually remove pciehp_debug. Replace uses of pciehp_debug with dbg() and ctrl_dbg(), which check pciehp_debug internally. Signed-off-by: Bjorn Helgaas --- drivers/pci/hotplug/pciehp_hpc.c | 13

[PATCH 01/10] PCI/AER: Replace dev_printk(KERN_DEBUG) with dev_info()

2019-05-09 Thread Bjorn Helgaas
From: Frederick Lawler Replace dev_printk(KERN_DEBUG) with dev_info() or dev_err() to be more consistent with other logging. These could be converted to dev_dbg(), but that depends on CONFIG_DYNAMIC_DEBUG and DEBUG, and we want most of these messages to *always* be in the dmesg log. Also

[PATCH next v3] mfd: Use dev_get_drvdata()

2019-05-09 Thread Kefeng Wang
Using dev_get_drvdata directly. Cc: David Brown Cc: Lee Jones Cc: linux-arm-...@vger.kernel.org Signed-off-by: Kefeng Wang --- v3: - fix build issue('dev' undeclared) in tc6393xb_nand_enable() v2: -use dev_get_drvdata() instead of to_ssbi() drivers/mfd/ssbi.c | 6 ++

[PATCH 3.16 04/10] spi: omap-100k: Remove unused definitions

2019-05-09 Thread Ben Hutchings
3.16.67-rc1 review patch. If anyone has any objections, please let me know. -- From: Nick Krause commit 9f5b8b4f56dd194fd33021810636879036d2acdd upstream. Remove unused definition which cause the following warnings drivers/spi/spi-omap-100k.c:73:0: warning: "WRITE" redefined

Re: [PATCH v2 4/9] PCI/LINK: Prefix dmesg logs with PCIe service name

2019-05-09 Thread Bjorn Helgaas
On Thu, May 02, 2019 at 10:59:41PM -0500, Frederick Lawler wrote: > bw_notification.c currently does not have any dmesg logs. As the > service continues to expand in functionality, prefix logs anyways. > > Signed-off-by: Frederick Lawler > --- > drivers/pci/pcie/bw_notification.c | 2 ++ > 1

[PATCH 3.16 07/10] KVM: VMX: Fix x2apic check in vmx_msr_bitmap_mode()

2019-05-09 Thread Ben Hutchings
3.16.67-rc1 review patch. If anyone has any objections, please let me know. -- From: Joerg Roedel The stable backport of upstream commit 904e14fb7cb96 KVM: VMX: make MSR bitmaps per-VCPU has a bug in vmx_msr_bitmap_mode(). It enables the x2apic MSR-bitmap when the

[PATCH 3.16 09/10] timer/debug: Change /proc/timer_stats from 0644 to 0600

2019-05-09 Thread Ben Hutchings
3.16.67-rc1 review patch. If anyone has any objections, please let me know. -- From: Ben Hutchings The timer_stats facility should filter and translate PIDs if opened from a non-initial PID namespace, to avoid leaking information about the wider system. It should also not

[PATCH 3.16 03/10] inet: update the IP ID generation algorithm to higher standards.

2019-05-09 Thread Ben Hutchings
3.16.67-rc1 review patch. If anyone has any objections, please let me know. -- From: Amit Klein Commit 355b98553789 ("netns: provide pure entropy for net_hash_mix()") makes net_hash_mix() return a true 32 bits of entropy. When used in the IP ID generation algorithm, this has

[PATCH 3.16 08/10] fork: record start_time late

2019-05-09 Thread Ben Hutchings
3.16.67-rc1 review patch. If anyone has any objections, please let me know. -- From: David Herrmann commit 7b55851367136b1efd84d98fea81ba57a98304cf upstream. This changes the fork(2) syscall to record the process start_time after initializing the basic task structure but

[PATCH 3.16 01/10] Revert "brcmfmac: assure SSID length from firmware is limited"

2019-05-09 Thread Ben Hutchings
3.16.67-rc1 review patch. If anyone has any objections, please let me know. -- From: Ben Hutchings This reverts commit 9657f3abd17772d3290a3545dfb4811d945e84e1, which was similar to commit 1b5e2423164b3670e8bc9174e4762d297990deff upstream. The function fixed upstream doesn't

[PATCH 3.16 10/10] percpu: stop printing kernel addresses

2019-05-09 Thread Ben Hutchings
3.16.67-rc1 review patch. If anyone has any objections, please let me know. -- From: Matteo Croce commit 00206a69ee32f03e6f40837684dcbe475ea02266 upstream. Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), at boot "ptrval" is printed instead of

[PATCH 3.16 00/10] 3.16.67-rc1 review

2019-05-09 Thread Ben Hutchings
This is the start of the stable review cycle for the 3.16.67 release. There are 10 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat May 11 14:08:16 UTC 2019. Anything

[PATCH 3.16 02/10] brcmfmac: add length checks in scheduled scan result handler

2019-05-09 Thread Ben Hutchings
3.16.67-rc1 review patch. If anyone has any objections, please let me know. -- From: Arend Van Spriel commit 4835f37e3bafc138f8bfa3cbed2920dd56fed283 upstream. Assure the event data buffer is long enough to hold the array of netinfo items and that SSID length does not exceed

[PATCH 3.16 06/10] ipv4: fix a race in update_or_create_fnhe()

2019-05-09 Thread Ben Hutchings
3.16.67-rc1 review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit caa415270c732505240bb60171c44a7838c555e8 upstream. nh_exceptions is effectively used under rcu, but lacks proper barriers. Between kzalloc() and setting of

Re: [PATCH] EDAC, sb_edac: remove redundant update of tad_base

2019-05-09 Thread Borislav Petkov
On Wed, May 08, 2019 at 11:42:01PM +0100, Colin King wrote: > From: Colin Ian King > > The variable tad_base is being set to a value that is never read > and is being over-written on the next iteration of a for-loop. > This assignment is therefore redundant and can be removed. > >

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-09 Thread Andrzej Pietrasiewicz
Hi John, W dniu 08.05.2019 o 04:18, John Stultz pisze: Since commit 772a7a724f69 ("usb: gadget: f_fs: Allow scatter-gather buffers"), I've been seeing trouble with adb transfers in Android on HiKey960, HiKey and now Dragonboard 845c. Sometimes things crash, but often the transfers just stop w/o

Re: [PATCH v2 2/4] mfd: ioc3: Add driver for SGI IOC3 chip

2019-05-09 Thread Thomas Bogendoerfer
On Wed, 8 May 2019 11:23:13 +0100 Lee Jones wrote: > On Tue, 09 Apr 2019, Thomas Bogendoerfer wrote: > > > +static u32 crc8_addr(u64 addr) > > +{ > > + u32 crc = 0; > > + int i; > > + > > + for (i = 0; i < 64; i += 8) > > + crc8_byte(, addr >> i); > > + return crc; > > +} > >

Re: [PATCH v2 9/9] PCI: hotplug: Prefix ctrl_*() dmesg logs with pciehp slot name

2019-05-09 Thread Bjorn Helgaas
On Thu, May 02, 2019 at 10:59:46PM -0500, Frederick Lawler wrote: > Remove current uses of "Slot(%s)" and then prefix ctrl_*() dmesg > with pciehp slot name to include the slot name for all uses of ctrl_*() > wrappers. > > Signed-off-by: Frederick Lawler > --- > drivers/pci/hotplug/pciehp.h

Re: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations

2019-05-09 Thread Masami Hiramatsu
On Thu, 9 May 2019 10:14:31 +0200 Peter Zijlstra wrote: > On Thu, May 09, 2019 at 10:20:30AM +0900, Masami Hiramatsu wrote: > > Hi Josh, > > > > On Wed, 8 May 2019 13:48:48 -0500 > > Josh Poimboeuf wrote: > > > > > On Wed, May 08, 2019 at 05:39:07PM +0200, Peter Zijlstra wrote: > > > > On

Re: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations

2019-05-09 Thread Josh Poimboeuf
On Thu, May 09, 2019 at 10:14:31AM +0200, Peter Zijlstra wrote: > But what I'd love to do is something like the belwo patch, and make all > the trampolines (very much including ftrace) use that. Such that we then > only have 1 copy of this magic (well, 2 because x86_64 also needs an >

ERROR: "uio_unregister_device" [drivers/staging/kpc2000/kpc2000/kpc2000.ko] undefined!

2019-05-09 Thread kbuild test robot
Hi Nathan, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: ef75bd71c5d31dc17ae41ff8bec92630a3037d69 commit: e2a5be107f52cefb9010ccae6f569c3ddaa954cc staging: kpc2000: kpc_spi: Fix build error for {read,write}q

Re: [PATCH] cgroup: never call do_group_exit() with task->frozen bit set

2019-05-09 Thread Oleg Nesterov
On 05/08, Roman Gushchin wrote: > > To resolve this problem, let's move cgroup_leave_frozen(true) call to > just after the fatal label. If the task is going to die, the frozen > bit must be cleared no matter how we get into this point. OK, agreed, better than nothing. but please see my previous

Re: [PATCH v2 00/10] RFC: NVME MDEV

2019-05-09 Thread Keith Busch
On Thu, May 09, 2019 at 02:12:55AM -0700, Stefan Hajnoczi wrote: > On Mon, May 06, 2019 at 12:04:06PM +0300, Maxim Levitsky wrote: > > On top of that, it is expected that newer hardware will support the PASID > > based > > device subdivision, which will allow us to _directly_ pass through the > >

Re: [PATCH v2] modules: Only return -EEXIST for modules that have finished loading

2019-05-09 Thread Jessica Yu
+++ Prarit Bhargava [07/05/19 10:54 -0400]: Heiko, it would still be good to get a test of this patch from you. I tested this here at Red Hat on some System Z machines. Without the modification made here in v2, the systems failed to boot ~10% of the time. After the modification I do not see

Re: [PATCH] Makefile: Don't try to add '-fcatch-undefined-behavior' flag

2019-05-09 Thread Sedat Dilek
On Thu, May 9, 2019 at 1:49 PM Nathan Chancellor wrote: > > This is no longer a valid option in clang, it was removed in 3.5, which > we don't support. > > https://github.com/llvm/llvm-project/commit/cb3f812b6b9fab8f3b41414f24e90222170417b4 > Cool. Can you test with -mglobal-merge (inverted

Re: [PATCH v2] perf: allow non-privileged uprobe for user processes

2019-05-09 Thread Song Liu
Hi Peter, > On May 7, 2019, at 9:15 AM, Song Liu wrote: > > Currently, non-privileged user could only use uprobe with > >kernel.perf_event_paranoid = -1 > > However, setting perf_event_paranoid to -1 leaks other users' processes to > non-privileged uprobes. > > To introduce proper

Re: [RFC PATCH 6/6] sched/dl: Try not to select a too fast core

2019-05-09 Thread Quentin Perret
Hi Luca, On Wednesday 08 May 2019 at 08:26:05 (+0200), luca abeni wrote: > Mainly two reasons: the first one is to try to reduce frequency > switches (I did not perform measurements on the hikey960, I remember > that on other CPUs a frequency switch can take a considerable amount of > time).

Perenco Oil and Gas

2019-05-09 Thread Mrs. Carrie Perrodo
I am Mrs. Carrie Perrodo, Co-Founder of Perenco, an Oil and gas exploration and production, natural gas and LNG trading and transportation, oil refining. I will appreciate if you will allow me to trust you as my humanitarian project manager, The sum of (US$10Million Dollars). Kindly come back

Re: [PATCH] RFC: console: hack up console_lock more v3

2019-05-09 Thread Peter Zijlstra
On Thu, May 09, 2019 at 03:06:09PM +0200, Daniel Vetter wrote: > On Thu, May 9, 2019 at 2:31 PM Peter Zijlstra wrote: > > On Thu, May 09, 2019 at 02:09:03PM +0200, Daniel Vetter wrote: > > > Fix this by creating a prinkt_safe_up() which calls wake_up_process > > > outside of the spinlock. This

[GIT PULL] Please pull RDMA subsystem changes

2019-05-09 Thread Jason Gunthorpe
Hi Linus, These are the proposed RDMA patches for 5.2. There is a small conflict with the mlx5-next (net-next) tree resolved with this hunk: diff --cc drivers/infiniband/hw/mlx5/main.c index 687f99172037be,fae6a6a1fbea12..abac70ad5c7c46 --- a/drivers/infiniband/hw/mlx5/main.c +++

Re: [PATCH] Makefile: Don't try to add '-fcatch-undefined-behavior' flag

2019-05-09 Thread Masahiro Yamada
On Thu, May 9, 2019 at 8:49 PM Nathan Chancellor wrote: > > This is no longer a valid option in clang, it was removed in 3.5, which > we don't support. > > https://github.com/llvm/llvm-project/commit/cb3f812b6b9fab8f3b41414f24e90222170417b4 > > Signed-off-by: Nathan Chancellor > --- > > Let me

Re: arch/x86/kernel/apic/apic.c: calibrate_APIC_clock() soft hangs when PIC is not configured by BIOS before kernel is launched.

2019-05-09 Thread Thomas Gleixner
On Thu, 9 May 2019, Kirkendall, Garrett wrote: > I am trying to boot a UEFI BIOS with minimal legacy hardware support.  > The Linux kernel soft hangs when the PIC is not configured by the BIOS > because it is using IOAPIC.  Hopefully, this provides enough information. > > Soft hang occurs in

[PATCH 0/2] ASoC: ak4458: fail on probe if codec is not present

2019-05-09 Thread Viorel Suman
AK4458 is probed successfully even if AK4458 is not present - this is caused by probe function returning no error on i2c access failure. The patchset fixes this. Viorel Suman (2): ASoC: ak4458: rstn_control - return a non-zero on error only ASoC: ak4458: add return value for ak4458_probe

[PATCH V12 5/5] ARM: dts: imx7ulp-evk: Add backlight support

2019-05-09 Thread Anson Huang
This patch adds i.MX7ULP EVK board MIPI-DSI backlight support. Signed-off-by: Anson Huang --- No change. --- arch/arm/boot/dts/imx7ulp-evk.dts | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/imx7ulp-evk.dts b/arch/arm/boot/dts/imx7ulp-evk.dts index

[PATCH V12 1/5] dt-bindings: pwm: Add i.MX TPM PWM binding

2019-05-09 Thread Anson Huang
Add i.MX TPM(Low Power Timer/Pulse Width Modulation Module) PWM binding. Signed-off-by: Anson Huang Reviewed-by: Rob Herring --- No change. --- .../devicetree/bindings/pwm/imx-tpm-pwm.txt| 22 ++ 1 file changed, 22 insertions(+) create mode 100644

[PATCH 2/2] ASoC: ak4458: add return value for ak4458_probe

2019-05-09 Thread Viorel Suman
AK4458 is probed successfully even if AK4458 is not present - this is caused by probe function returning no error on i2c access failure. Return an error on probe if i2c access has failed. Signed-off-by: Shengjiu Wang Signed-off-by: Viorel Suman --- sound/soc/codecs/ak4458.c | 13 +++--

[PATCH V12 0/5] Add i.MX7ULP EVK PWM backlight support

2019-05-09 Thread Anson Huang
i.MX7ULP EVK board has MIPI-DSI display, its backlight is supplied by TPM PWM module, this patch set enables i.MX7ULP TPM PWM driver support and also add backlight support for MIPI-DSI display. Changes since V11: - ONLY add a function comment in drivers/pwm/pwm-imx-tpm.c Anson Huang (5):

[PATCH V12 3/5] ARM: imx_v6_v7_defconfig: Add TPM PWM support by default

2019-05-09 Thread Anson Huang
Select CONFIG_PWM_IMX_TPM by default to support i.MX7ULP TPM PWM. Signed-off-by: Anson Huang --- No change. --- arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index

[PATCH 1/2] ASoC: ak4458: rstn_control - return a non-zero on error only

2019-05-09 Thread Viorel Suman
snd_soc_component_update_bits() may return 1 if operation was successful and the value of the register changed. Return a non-zero in ak4458_rstn_control for an error only. Signed-off-by: Shengjiu Wang Signed-off-by: Viorel Suman --- sound/soc/codecs/ak4458.c | 3 ++- 1 file changed, 2

[PATCH V12 2/5] pwm: Add i.MX TPM PWM driver support

2019-05-09 Thread Anson Huang
i.MX7ULP has TPM(Low Power Timer/Pulse Width Modulation Module) inside, it can support multiple PWM channels, all the channels share same counter and period setting, but each channel can configure its duty and polarity independently. There are several TPM modules in i.MX7ULP, the number of

[PATCH V12 4/5] ARM: dts: imx7ulp: Add tpm pwm support

2019-05-09 Thread Anson Huang
Add i.MX7ULP EVK board PWM support. Signed-off-by: Anson Huang --- No change. --- arch/arm/boot/dts/imx7ulp.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi index d6b7110..8fb9559 100644 ---

Hello My Beloved One, i need your assistance

2019-05-09 Thread Aisha Gaddafi
Dear Friend, I came across your e-mail contact prior a private search while in need of your assistance. My name is Aisha Gaddafi a single Mother and a Widow with three Children. I am the only biological Daughter of late Libyan President (Late Colonel Muammar Gaddafi). I have investment funds

arch/x86/kernel/apic/apic.c: calibrate_APIC_clock() soft hangs when PIC is not configured by BIOS before kernel is launched.

2019-05-09 Thread Kirkendall, Garrett
Sorry, resending as plain text for linux-kernel@vger.kernel.org I am trying to boot a UEFI BIOS with minimal legacy hardware support.  The Linux kernel soft hangs when the PIC is not configured by the BIOS because it is using IOAPIC.  Hopefully, this provides enough information. Observed under

Re: [PATCH] vsprintf: Do not break early boot with probing addresses

2019-05-09 Thread Andy Shevchenko
On Thu, May 09, 2019 at 02:19:23PM +0200, Petr Mladek wrote: > The commit 3e5903eb9cff70730 ("vsprintf: Prevent crash when dereferencing > invalid pointers") broke boot on several architectures. The common > pattern is that probe_kernel_read() is not working during early > boot because userspace

Re: [PATCH v8 00/16] Add utilization clamping support

2019-05-09 Thread Patrick Bellasi
On 09-May 15:02, Peter Zijlstra wrote: > On Tue, Apr 02, 2019 at 11:41:36AM +0100, Patrick Bellasi wrote: > > Series Organization > > === > > > > The series is organized into these main sections: > > > > - Patches [01-07]: Per task (primary) API > > - Patches [08-09]: Schedutil

RE: [PATCH V11 2/5] pwm: Add i.MX TPM PWM driver support

2019-05-09 Thread Anson Huang
Hi, Uwe > -Original Message- > From: Uwe Kleine-König [mailto:u.kleine-koe...@pengutronix.de] > Sent: Thursday, May 9, 2019 3:20 PM > To: Anson Huang > Cc: thierry.red...@gmail.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; s.ha...@pengutronix.de;

Re: [PATCH v8 04/16] sched/core: uclamp: Add system default clamps

2019-05-09 Thread Patrick Bellasi
On 09-May 13:53, Peter Zijlstra wrote: > On Thu, May 09, 2019 at 10:10:57AM +0100, Patrick Bellasi wrote: > > On 08-May 21:15, Peter Zijlstra wrote: > > > On Wed, May 08, 2019 at 09:07:33PM +0200, Peter Zijlstra wrote: > > > > On Tue, Apr 02, 2019 at 11:41:40AM +0100, Patrick Bellasi wrote: > > >

Re: [PATCH v8 00/16] Add utilization clamping support

2019-05-09 Thread Peter Zijlstra
On Tue, Apr 02, 2019 at 11:41:36AM +0100, Patrick Bellasi wrote: > Series Organization > === > > The series is organized into these main sections: > > - Patches [01-07]: Per task (primary) API > - Patches [08-09]: Schedutil integration for FAIR and RT tasks > - Patches

Re: [PATCH 02/25] tracing: Improve "if" macro code generation

2019-05-09 Thread Steven Rostedt
On Wed, 20 Mar 2019 10:26:17 -0700 Linus Torvalds wrote: > On Wed, Mar 20, 2019 at 4:17 AM David Laight wrote: > > > > > __r = !!(cond); \ > > > > Is that (or maybe just the !!) needed any more?? > > It is, because the 'cond'

Re: [PATCH 3/3] rpmsg: virtio_rpmsg_bus: get buffer size from config space

2019-05-09 Thread xiang xiao
On Thu, May 9, 2019 at 8:36 PM Arnaud Pouliquen wrote: > > Hello Xiang, > > Similar mechanism has been proposed by Loic 2 years ago (link to the > series here https://lkml.org/lkml/2017/3/28/349). > > Did you see them? Regarding history, patches seem just on hold... > Just saw this patchset, so

[GIT PULL] csky perf unwind libdw patch for v5.2-rc1

2019-05-09 Thread guoren
Hi Linus, Another csky perf unwind libdw patch for v5.2-rc1: The following changes since commit 085b7755808aa11f78ab9377257e1dad2e6fa4bb: Linux 5.1-rc6 (2019-04-21 10:45:57 -0700) are available in the git repository at: https://github.com/c-sky/csky-linux.git

Re: [PATCH v4] clk: gcc-qcs404: Add PCIe resets

2019-05-09 Thread Vinod Koul
On 08-05-19, 15:39, Bjorn Andersson wrote: > Enabling PCIe requires several of the PCIe related resets from GCC, so > add them all. Reviewed-by: Vinod Koul -- ~Vinod

Re: [PATCH v8 11/16] sched/fair: uclamp: Add uclamp support to energy_compute()

2019-05-09 Thread Peter Zijlstra
On Tue, Apr 02, 2019 at 11:41:47AM +0100, Patrick Bellasi wrote: > @@ -6484,11 +6494,29 @@ compute_energy(struct task_struct *p, int dst_cpu, > struct perf_domain *pd) >* it will not appear in its pd list and will not be accounted >* by compute_energy(). >

man-pages-5.01 is released

2019-05-09 Thread Michael Kerrisk (man-pages)
Gidday, The Linux man-pages maintainer proudly announces: man-pages-5.01 - man pages for Linux This release resulted from patches, bug reports, reviews, and comments from just over 20 people, with just over 70 commits making changes to around 40 pages. Tarball download:

Re: [PATCH] mm: mmu_gather: remove __tlb_reset_range() for force flush

2019-05-09 Thread Jan Stancek
> > I don't think we can elide the call __tlb_reset_range() entirely, since I > > think we do want to clear the freed_pXX bits to ensure that we walk the > > range with the smallest mapping granule that we have. Otherwise couldn't we > > have a problem if we hit a PMD that had been cleared, but

Re: [PATCH 2/3] rpmsg: virtio_rpmsg_bus: allocate rx/tx buffer separately

2019-05-09 Thread xiang xiao
On Thu, May 9, 2019 at 8:02 PM Arnaud Pouliquen wrote: > > Hello Xiang, > > This patch has the opposite effect on my platform as DMA allocation is > aligned on 4k page. > For instance i declared: > - in RX 6 buffers (of 512 bytes) > - in TX 4 buffers ( of 512 bytes) > Yes,

Re: [PATCH 3/3] rpmsg: virtio_rpmsg_bus: get buffer size from config space

2019-05-09 Thread Arnaud Pouliquen
Hello Xiang, Similar mechanism has been proposed by Loic 2 years ago (link to the series here https://lkml.org/lkml/2017/3/28/349). Did you see them? Regarding history, patches seem just on hold... Main differences (except interesting RX/TX size split) seems that you - don't use the

Re: [PATCH v4 0/3] arm64: dts: qcom: qcs404: Enable PCIe

2019-05-09 Thread Vinod Koul
On 08-05-19, 15:43, Bjorn Andersson wrote: > This series defines the PCIe PHY and controller on QCS404 and enable them for > EVB. This was 1 commit, but per Vinod's request its split up in its individual > pieces. Thanks for doing that, all: Reviewed-by: Vinod Koul -- ~Vinod

<    3   4   5   6   7   8   9   10   >