Re: [Patch v4] staging: rtl8723bs: core: rtw_ap: fix Unneeded variable: "ret". Return "0

2019-05-23 Thread Greg Kroah-Hartman
On Thu, May 23, 2019 at 11:40:09PM +0530, Hariprasad Kelam wrote: > Function "rtw_sta_flush" always returns 0 value. So change > return type of rtw_sta_flush from int to void. Odd line wrapping :( Also your subject line is missing a trailing '"' character :( v5? thanks, greg k-h

Re: [PATCH] staging: fieldbus: anybuss: Remove variables

2019-05-23 Thread Greg KH
On Fri, May 24, 2019 at 11:33:28AM +0530, Nishka Dasgupta wrote: > The local variable cd, used in multiple functions, is immediately passed > to another function call, whose result is returned. As that is the only > use of cd, it can be replaced with its variable. > Issue found with Coccinelle. >

Re: [PATCH 1/2] staging: gdm724x: Remove initialisation

2019-05-23 Thread Greg KH
On Fri, May 24, 2019 at 11:30:25AM +0530, Nishka Dasgupta wrote: > The initial value of return variable ret, -1, is never used and hence > can be removed. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta > --- > drivers/staging/gdm724x/gdm_usb.c | 2 +- > 1 file changed, 1 inser

Re: [PATCH 2/2] staging: gdm724x: Remove variable

2019-05-23 Thread Greg KH
On Fri, May 24, 2019 at 11:30:26AM +0530, Nishka Dasgupta wrote: > The return variable is used only twice (in two different branches), and > both times it is assigned the same constant value. These can therefore > be merged into the same assignment, placed at the point that both > these branches (a

Re: [PATCH] staging: ks7010: Remove initialisation

2019-05-23 Thread Greg KH
On Fri, May 24, 2019 at 11:26:02AM +0530, Nishka Dasgupta wrote: > As the initial value of the return variable result is never used, it can > be removed. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta > --- > drivers/staging/ks7010/ks7010_sdio.c | 2 +- > 1 file changed, 1 ins

Re: [PATCH v2] staging: kpc2000: Add dependency on MFD_CORE to kconfig symbol 'KPC2000'

2019-05-23 Thread Greg Kroah-Hartman
On Fri, May 24, 2019 at 03:02:48AM +, Geordan Neukum wrote: > On Fri, May 24, 2019 at 2:38 AM Geordan Neukum wrote: > > + depends on MFD_CORE > > In order for this to work in menuconfig, this either needs to be a > select or I need to > add a prompt to MFD_CORE. I don't have strong feel

Re: [PATCH] staging/gasket: Fix string split

2019-05-23 Thread Greg KH
On Thu, May 23, 2019 at 05:46:39PM +0200, Tianzheng Li wrote: > This patch removes unnecessary quoted string splits. > > Reported-by: Jie Zhang > Signed-off-by: Tianzheng Li > --- > drivers/staging/gasket/gasket_core.c | 6 ++ > drivers/staging/gasket/gasket_ioctl.c | 3 +-- >

RE: [PATCH V3 RESEND 3/4] defconfig: arm64: enable i.MX8 SCU octop driver

2019-05-23 Thread Peng Fan
Hi Shawn, > -Original Message- > From: Shawn Guo [mailto:shawn...@kernel.org] > Sent: 2019年5月23日 20:53 > To: Peng Fan > Cc: srinivas.kandaga...@linaro.org; robh...@kernel.org; > s.ha...@pengutronix.de; feste...@gmail.com; dl-linux-imx > ; linux-kernel@vger.kernel.org; > linux-arm-ker...@l

[tip:locking/core] locking/lockdep: Don't complain about incorrect name for no validate class

2019-05-23 Thread tip-bot for Sebastian Andrzej Siewior
Commit-ID: 978315462d3ea3cf6cfacd34c563ec1eb02a3aa5 Gitweb: https://git.kernel.org/tip/978315462d3ea3cf6cfacd34c563ec1eb02a3aa5 Author: Sebastian Andrzej Siewior AuthorDate: Fri, 17 May 2019 23:22:34 +0200 Committer: Ingo Molnar CommitDate: Fri, 24 May 2019 08:41:59 +0200 locking/lockd

Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-05-23 Thread Heiko Stuebner
Hi Elaine, Am Donnerstag, 23. Mai 2019, 03:34:37 CEST schrieb elaine.zhang: > hi, Heiko & Enric: > > 在 2019/5/22 下午8:27, Heiko Stuebner 写道: > > Hi Enric, > > > > Am Montag, 20. Mai 2019, 15:38:32 CEST schrieb Enric Balletbo Serra: > >> Hi all, > >> > >> As pointed by [1] and [2] this commit, that

Re: [PATCH] mm: add account_locked_vm utility function

2019-05-23 Thread Alexey Kardashevskiy
On 21/05/2019 01:30, Daniel Jordan wrote: > On Mon, May 20, 2019 at 04:19:34PM +1000, Alexey Kardashevskiy wrote: >> On 04/05/2019 06:16, Daniel Jordan wrote: >>> locked_vm accounting is done roughly the same way in five places, so >>> unify them in a helper. Standardize the debug prints, which

Re: [PATCH v4 0/1] Use HMM for ODP v4

2019-05-23 Thread Christoph Hellwig
On Thu, May 23, 2019 at 04:10:38PM -0300, Jason Gunthorpe wrote: > > On Thu, May 23, 2019 at 02:24:58PM -0400, Jerome Glisse wrote: > > I can not take mmap_sem in range_register, the READ_ONCE is fine and > > they are no race as we do take a reference on the hmm struct thus > > Of course there ar

Re: [PATCH] locking/lockdep: Don't complain about wrong name for no validate class

2019-05-23 Thread Ingo Molnar
* Sebastian Andrzej Siewior wrote: > It is possible to ignore the validation for a certain log be using > lockdep_set_novalidate_class() s/log/lock s/be/by ? > on it. Each invocation will assign a new name to the class it created > for created __lockdep_no_validate__. That means that o

[PATCH V3 RESEND AGAIN 1/2] defconfig: arm64: enable i.MX8 SCU octop driver

2019-05-23 Thread peng . fan
From: Peng Fan Build in CONFIG_NVMEM_IMX_OCOTP_SCU. Cc: Catalin Marinas Cc: Will Deacon Cc: Shawn Guo Cc: Andy Gross Cc: Maxime Ripard Cc: Olof Johansson Cc: Jagan Teki Cc: Bjorn Andersson Cc: Leonard Crestez Cc: Marc Gonzalez Cc: Enric Balletbo i Serra Cc: linux-arm-ker...@lists.infr

[PATCH V3 RESEND AGAIN 2/2] arm64: dts: imx: add i.MX8QXP ocotp support

2019-05-23 Thread peng . fan
From: Peng Fan Add i.MX8QXP ocotp node Cc: Rob Herring Cc: Mark Rutland Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: Anson Huang Cc: Daniel Baluta Cc: devicet...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Reviewed-by:

Re: [PATCH] staging: iio: adis16240: add of_match_table entry

2019-05-23 Thread Alexandru Ardelean
On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro wrote: > > This patch adds of_match_table entry in device driver in order to > enable spi fallback probing. > > Signed-off-by: Rodrigo Ribeiro > Reviewed-by: Marcelo Schmitt > --- > drivers/staging/iio/accel/adis16240.c | 1 + > 1 file changed, 1

Re: [v2, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

2019-05-23 Thread biao huang
Dear All, any comments about this patch? Thanks. On Tue, 2019-05-14 at 11:00 +0800, Biao Huang wrote: > 1. get hash table size in hw feature reigster, and add support > for taller hash table(128/256) in dwmac4. > 2. only clear PR/HMC/PM bits of GMAC_PACKET_FILTER, to avoid > side effect to function

Re: [PATCH] Revert "thermal: rockchip: fix up the tsadc pinctrl setting error"

2019-05-23 Thread Heiko Stuebner
Am Freitag, 24. Mai 2019, 04:20:43 CEST schrieb Eduardo Valentin: > On Wed, May 22, 2019 at 08:34:34AM -0700, Doug Anderson wrote: > > Hi, > > > > On Wed, May 22, 2019 at 7:12 AM Heiko Stuebner wrote: > > > > > > This reverts commit 28694e009e512451ead5519dd801f9869acb1f60. > > > > > > The commit

Re: Please cherrypick 592acbf1682128 to 3.18.y and 4.4.y

2019-05-23 Thread Greg KH
On Fri, May 24, 2019 at 07:54:09AM +0200, Greg KH wrote: > On Thu, May 23, 2019 at 01:49:27PM -0700, Mark Salyzyn wrote: > > Cherry pick security-related fix 592acbf16821288ecdc4192c47e3774a4c48bb64 > > ("ext4: zero out the unused memory region in the extent tree block") to > > 3.18.y and 4.4.y > >

[v4, PATCH 1/3] net: stmmac: update rx tail pointer register to fix rx dma hang issue.

2019-05-23 Thread Biao Huang
Currently we will not update the receive descriptor tail pointer in stmmac_rx_refill. Rx dma will think no available descriptors and stop once received packets exceed DMA_RX_SIZE, so that the rx only test will fail. Update the receive tail pointer in stmmac_rx_refill to add more descriptors to the

[v4, PATCH 0/3] fix some bugs in stmmac

2019-05-23 Thread Biao Huang
changes in v4: since MTL_OPERATION_MODE write back issue has be fixed in the latest driver, remove original patch#3

[v4, PATCH 2/3] net: stmmac: fix csr_clk can't be zero issue

2019-05-23 Thread Biao Huang
The specific clk_csr value can be zero, and stmmac_clk is necessary for MDC clock which can be set dynamically. So, change the condition from plat->clk_csr to plat->stmmac_clk to fix clk_csr can't be zero issue. Fixes: cd7201f477b9 ("stmmac: MDC clock dynamically based on the csr clock input") Si

[v4, PATCH 3/3] net: stmmac: dwmac-mediatek: modify csr_clk value to fix mdio read/write fail

2019-05-23 Thread Biao Huang
1. the frequency of csr clock is 66.5MHz, so the csr_clk value should be 0 other than 5. 2. the csr_clk can be got from device tree, so remove initialization here. Fixes: 9992f37e346b ("stmmac: dwmac-mediatek: add support for mt2712") Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac

[RESEND PATCH] usb: mtu3: fix up undefined reference to usb_debug_root

2019-05-23 Thread Chunfeng Yun
When CONFIG_USB is not set, and CONFIG_USB_GADGET is set, there is an issue: ld: drivers/usb/mtu3/mtu3_debugfs.o: in function 'ssusb_debugfs_create_root': mtu3_debugfs.c:(.text+0xba3): undefined reference to 'usb_debug_root' usb_debug_root is only built when CONFIG_USB is enabled, so here drop it

Re: [PATCH 2/2] auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero()

2019-05-23 Thread Souptick Joarder
On Thu, May 23, 2019 at 6:53 PM Miguel Ojeda wrote: > > On Mon, May 20, 2019 at 5:26 PM Souptick Joarder wrote: > > > > While using mmap, the incorrect value of length and vm_pgoff are > > ignored and this driver go ahead with mapping fbdev.buffer > > to user vma. > > Typos: values*, goes* (same

[PATCH 2/2] PCI: altera: Remove cfgrdX and cfgwrX

2019-05-23 Thread Ley Foon Tan
No longer need cfgrdX and cfgwrX since we have separate defines for TLP_CFG*_DW0 and S10_TLP_CFG*_DW0, so remove them. Signed-off-by: Ley Foon Tan --- drivers/pci/controller/pcie-altera.c | 33 +++- 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/pc

Re: [PATCH 2/2] auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero()

2019-05-23 Thread Souptick Joarder
On Fri, May 24, 2019 at 9:52 AM Miguel Ojeda wrote: > > On Thu, May 23, 2019 at 2:58 PM Miguel Ojeda > wrote: > > > > Taking a quick look now, by the way, why does vm_map_pages_zero() (and > > __vm_map_pages() etc.) get a pointer to an array instead of a pointer > > to the first element? For

[PATCH 0/2] Fix Altera PCIe configuration type handling

2019-05-23 Thread Ley Foon Tan
This fix issue when access config from PCIe switch. Stratix 10 PCIe controller does not support Type 1 to Type 0 conversion as previous version (V1) does. The PCIe controller need to send Type 0 config TLP if the targeting bus matches with the secondary bus number, which is when the TLP is target

[PATCH 1/2] PCI: altera: Fix configuration type based on secondary number

2019-05-23 Thread Ley Foon Tan
This fix issue when access config from PCIe switch. Stratix 10 PCIe controller does not support Type 1 to Type 0 conversion as previous version (V1) does. The PCIe controller need to send Type 0 config TLP if the targeting bus matches with the secondary bus number, which is when the TLP is target

Re: [PATCH V3 2/4] arm64/mm: Hold memory hotplug lock while walking for kernel page table dump

2019-05-23 Thread Anshuman Khandual
On 05/22/2019 10:12 PM, Mark Rutland wrote: > On Thu, May 16, 2019 at 01:05:29PM +0200, Michal Hocko wrote: >> On Thu 16-05-19 11:23:54, Mark Rutland wrote: >>> Hi Michal, >>> >>> On Wed, May 15, 2019 at 06:58:47PM +0200, Michal Hocko wrote: On Tue 14-05-19 14:30:05, Anshuman Khandual wrote

[RFC PATCH v2] powerpc: fix kexec failure on book3s/32

2019-05-23 Thread Christophe Leroy
Fixes: 63b2bc619565 ("powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX") Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/machine_kexec_32.c | 8 arch/powerpc/mm/book3s32/mmu.c | 7 +-- arch/powerpc/mm/mmu_decl.h | 2 ++ 3 files changed, 15 insertions(+), 2 d

Re: [RFC v2 00/11] DVFS in the OPP core

2019-05-23 Thread Rajendra Nayak
On 5/21/2019 11:52 AM, Viresh Kumar wrote: On 20-03-19, 15:19, Rajendra Nayak wrote: This is a v2 of the RFC posted earlier by Stephen Boyd [1] As part of v2 I still follow the same approach of dev_pm_opp_set_rate() API using clk framework to round the frequency passed and making it accept 0

[PATCH] staging: fieldbus: anybuss: Remove variables

2019-05-23 Thread Nishka Dasgupta
The local variable cd, used in multiple functions, is immediately passed to another function call, whose result is returned. As that is the only use of cd, it can be replaced with its variable. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/fieldbus/anybuss/host.

[PATCH 2/2] staging: gdm724x: Remove variable

2019-05-23 Thread Nishka Dasgupta
The return variable is used only twice (in two different branches), and both times it is assigned the same constant value. These can therefore be merged into the same assignment, placed at the point that both these branches (and no other) go to. The return variable itself can be removed. Issue foun

[PATCH 1/2] staging: gdm724x: Remove initialisation

2019-05-23 Thread Nishka Dasgupta
The initial value of return variable ret, -1, is never used and hence can be removed. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/gdm724x/gdm_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers

Re: [v4 PATCH 2/2] mm: vmscan: correct some vmscan counters for

2019-05-23 Thread Yang Shi
On 5/24/19 1:51 PM, Hillf Danton wrote: On Fri, 24 May 2019 09:27:02 +0800 Yang Shi wrote: On 5/23/19 11:51 PM, Hillf Danton wrote: On Thu, 23 May 2019 10:27:38 +0800 Yang Shi wrote: @ -1642,14 +1650,14 @@ static unsigned long isolate_lru_pages(unsigned long nr_to_scan, unsigned lo

[PATCH] staging: ks7010: Remove initialisation

2019-05-23 Thread Nishka Dasgupta
As the initial value of the return variable result is never used, it can be removed. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/dr

Re: [PATCH] ALSA: Use struct_size() helper

2019-05-23 Thread Takashi Iwai
On Thu, 23 May 2019 22:29:17 +0200, Gustavo A. R. Silva wrote: > > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, replace the following form: > > siz

Re: Please cherrypick 592acbf1682128 to 3.18.y and 4.4.y

2019-05-23 Thread Greg KH
On Thu, May 23, 2019 at 01:49:27PM -0700, Mark Salyzyn wrote: > Cherry pick security-related fix 592acbf16821288ecdc4192c47e3774a4c48bb64 > ("ext4: zero out the unused memory region in the extent tree block") to > 3.18.y and 4.4.y > > The cherry-pick is clean and requires no back-porting. Is alrea

Re: [PATCH] staging: mt7621-pci: pci-mt7621: Remove unneeded variable err

2019-05-23 Thread Sergio Paracuellos
Hi Hariprasad, On Thu, May 23, 2019 at 8:35 PM Hariprasad Kelam wrote: > > devm_request_pci_bus_resources function will return -EBUSY/-ENOMEM > in fail case and returns 0 on success. > > So no need to store return value in err variable. > > Signed-off-by: Hariprasad Kelam > --- > drivers/stagi

RE: [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling

2019-05-23 Thread Anson Huang
Hi, Shawn > -Original Message- > From: Shawn Guo [mailto:shawn...@kernel.org] > Sent: Thursday, May 23, 2019 8:41 PM > To: Anson Huang > Cc: s.ha...@pengutronix.de; ker...@pengutronix.de; feste...@gmail.com; > Leonard Crestez ; Abel Vesa > ; viresh.ku...@linaro.org; linux-arm- > ker...@li

Re: [PATCH 4.14 00/77] 4.14.122-stable review

2019-05-23 Thread Greg Kroah-Hartman
On Fri, May 24, 2019 at 09:28:05AM +0900, Nobuhiro Iwamatsu wrote: > Hi. > > 2019年5月24日(金) 4:11 Greg Kroah-Hartman : > > > > This is the start of the stable review cycle for the 4.14.122 release. > > There are 77 patches in this series, all will be posted as a response > > to this one. If anyone

[PATCH] staging: ks7010: Remove initialisation

2019-05-23 Thread Nishka Dasgupta
The initial value of return variable ret is never used, so it can be removed. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/ks7010/ks_hostif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/stagi

Re: [PATCH v1 0/5] Solve postboot supplier cleanup and optimize probe ordering

2019-05-23 Thread Greg Kroah-Hartman
On Thu, May 23, 2019 at 06:01:11PM -0700, Saravana Kannan wrote: > Add a generic "depends-on" property that allows specifying mandatory > functional dependencies between devices. Add device-links after the > devices are created (but before they are probed) by looking at this > "depends-on" property

RE: [PATCH 3/3] arm64: dts: imx8mq: add clock for SNVS RTC node

2019-05-23 Thread Anson Huang
Hi, Shawn > -Original Message- > From: Shawn Guo [mailto:shawn...@kernel.org] > Sent: Thursday, May 23, 2019 9:03 AM > To: Anson Huang > Cc: robh...@kernel.org; mark.rutl...@arm.com; s.ha...@pengutronix.de; > ker...@pengutronix.de; feste...@gmail.com; mturque...@baylibre.com; > sb...@kern

mainline/master boot bisection: v5.2-rc1-172-g4dde821e4296 on meson-g12a-x96-max

2019-05-23 Thread kernelci.org bot
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue the special alps trackpoint do not work.

2019-05-23 Thread Hui Wang
On 2019/5/24 下午1:36, Peter Hutterer wrote: On Fri, May 24, 2019 at 01:25:52PM +0800, Hui Wang wrote: On 2019/5/23 下午2:01, Peter Hutterer wrote: On Wed, May 22, 2019 at 09:40:30AM +0200, Pali Rohár wrote: On Wednesday 22 May 2019 07:30:43 Xiaoxiao Liu wrote: Hi Pali, Ok, and cannot you set

[PATCH RESEND 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling

2019-05-23 Thread Anson . Huang
From: Anson Huang of_node_put() is called after of_match_node() successfully called, then in the following error handling, of_node_put() is called again which is unnecessary, this patch adjusts the location of of_node_put() to avoid such scenario. Signed-off-by: Anson Huang Reviewed-by: Leonard

[PATCH RESEND 2/2] soc: imx: soc-imx8: Correct return value of error handle

2019-05-23 Thread Anson . Huang
From: Anson Huang Current implementation of i.MX8 SoC driver returns -ENODEV for all cases of error during initialization, this is incorrect. This patch fixes them using correct return value according to different errors. Signed-off-by: Anson Huang Reviewed-by: Leonard Crestez --- drivers/soc

Re: [PATCH v1 5/5] driver core: Add sync_state driver/bus callback

2019-05-23 Thread Greg Kroah-Hartman
On Thu, May 23, 2019 at 06:01:16PM -0700, Saravana Kannan wrote: > This sync_state driver/bus callback is called once all the consumers > of a supplier have probed successfully. > > This allows the supplier device's driver/bus to sync the supplier > device's state to the software state with the gu

Re: [PATCH v1 2/5] driver core: Add device links support for pending links to suppliers

2019-05-23 Thread Greg Kroah-Hartman
On Thu, May 23, 2019 at 06:01:13PM -0700, Saravana Kannan wrote: > When consumer devices are added, they might not have a supplier device > to link to despite needing mandatory resources/functionality from one > or more suppliers. Add a waiting_for_suppliers list to track such > consumers and add h

Re: [PATCH V3 2/4] arm64/mm: Hold memory hotplug lock while walking for kernel page table dump

2019-05-23 Thread Anshuman Khandual
On 05/23/2019 02:10 PM, David Hildenbrand wrote: > On 16.05.19 13:16, Michal Hocko wrote: >> On Thu 16-05-19 16:36:12, Anshuman Khandual wrote: >>> On 05/16/2019 03:53 PM, Mark Rutland wrote: Hi Michal, On Wed, May 15, 2019 at 06:58:47PM +0200, Michal Hocko wrote: > On Tue 14-05-

[PATCH RESEND] arm64: dts: imx8mq: add clock for SNVS RTC node

2019-05-23 Thread Anson . Huang
From: Anson Huang i.MX8MQ has clock gate for SNVS module, add clock info to SNVS RTC node for clock management. Signed-off-by: Anson Huang --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64

[PATCH] clocksource: arc_timer: use BIT() instead of _BITUL()

2019-05-23 Thread Masahiro Yamada
This is in-kernel C code, so there is no reason to use _BITUL(). Replace it with equivalent BIT(). I added #include explicitly although it has been included by other headers eventually. Signed-off-by: Masahiro Yamada --- drivers/clocksource/arc_timer.c | 3 ++- 1 file changed, 2 insertions(+)

Re: [v4 PATCH 1/2] mm: vmscan: remove double slab pressure by inc'ing sc->nr_scanned

2019-05-23 Thread Yang Shi
On 5/24/19 12:15 PM, Hillf Danton wrote: On Thu, 23 May 2019 10:27:37 +0800 Yang Shi wrote: The commit 9092c71bb724 ("mm: use sc->priority for slab shrink targets") has broken up the relationship between sc->nr_scanned and slab pressure. The sc->nr_scanned can't double slab pressure anymore.

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue the special alps trackpoint do not work.

2019-05-23 Thread Peter Hutterer
On Fri, May 24, 2019 at 01:25:52PM +0800, Hui Wang wrote: > > On 2019/5/23 下午2:01, Peter Hutterer wrote: > > On Wed, May 22, 2019 at 09:40:30AM +0200, Pali Rohár wrote: > > > On Wednesday 22 May 2019 07:30:43 Xiaoxiao Liu wrote: > > > > Hi Pali, > > > > > > > > Ok, and cannot you set ALPS_DUALPOI

Re: [PATCH] net: ll_temac: Fix compile error

2019-05-23 Thread David Miller
From: Esben Haabendal Date: Fri, 24 May 2019 07:24:42 +0200 > Fixes: 1b3fa5cf859b ("net: ll_temac: Cleanup multicast filter on change") > Signed-off-by: Esben Haabendal Applied.

Re: [PATCH 4.9 00/53] 4.9.179-stable review

2019-05-23 Thread kernelci.org bot
stable-rc/linux-4.9.y boot: 107 boots: 0 failed, 94 passed with 13 offline (v4.9.178-54-gf6bc31d8c3be) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.178-54-gf6bc31d8c3be/ Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/

bpf build error

2019-05-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:e6f6cd0d bpf: sockmap, fix use after free from sleep in ps.. git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=16f116e4a0 kernel config: https://syzkaller.appspot.com/x/.config?x=fc045131472947d7 dashboa

Re: [RFC PATCH 00/11] bpf, trace, dtrace: DTrace BPF program type implementation and sample use

2019-05-23 Thread Kris Van Hees
On Thu, May 23, 2019 at 07:08:51PM -0700, Alexei Starovoitov wrote: > On Thu, May 23, 2019 at 09:57:37PM -0400, Steven Rostedt wrote: > > On Thu, 23 May 2019 17:31:50 -0700 > > Alexei Starovoitov wrote: > > > > > > > > Now from what I'm reading, it seams that the Dtrace layer may be > > > > abst

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue the special alps trackpoint do not work.

2019-05-23 Thread Hui Wang
On 2019/5/23 下午2:01, Peter Hutterer wrote: On Wed, May 22, 2019 at 09:40:30AM +0200, Pali Rohár wrote: On Wednesday 22 May 2019 07:30:43 Xiaoxiao Liu wrote: Hi Pali, Ok, and cannot you set ALPS_DUALPOINT flag based on that alps_check_is_trackpoint() result and then update alps_process_packet

[PATCH] net: ll_temac: Fix compile error

2019-05-23 Thread Esben Haabendal
Fixes: 1b3fa5cf859b ("net: ll_temac: Cleanup multicast filter on change") Signed-off-by: Esben Haabendal --- drivers/net/ethernet/xilinx/ll_temac_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx

Re: [PATCH 2/3] firmware: add offset to request_firmware_into_buf

2019-05-23 Thread Greg Kroah-Hartman
On Thu, May 23, 2019 at 10:01:38PM -0700, Scott Branden wrote: > > On 2019-05-23 9:54 a.m., Greg Kroah-Hartman wrote: > > On Thu, May 23, 2019 at 09:36:02AM -0700, Scott Branden wrote: > > > Hi Greg, > > > > > > On 2019-05-22 10:52 p.m., Greg Kroah-Hartman wrote: > > > > On Wed, May 22, 2019 at 0

Re: [RFC PATCH 00/11] bpf, trace, dtrace: DTrace BPF program type implementation and sample use

2019-05-23 Thread Kris Van Hees
On Thu, May 23, 2019 at 07:02:43PM -0400, Steven Rostedt wrote: > On Thu, 23 May 2019 14:13:31 -0700 > Alexei Starovoitov wrote: > > > > In DTrace, people write scripts based on UAPI-style interfaces and they > > > don't > > > have to concern themselves with e.g. knowing how to get the value of

Re: [PATCH v7 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC.

2019-05-23 Thread Sagar Kadam
On Thu, May 23, 2019 at 7:23 PM Wolfram Sang wrote: > > > > Ok, Great. Do we need to write to him about this patchset? > > Nope. Hint: You can dig in the mail archives studying older patches to > see how things work. I do this as well because things may work > differently per subsystem. > Thanks

Re: [PATCH net 4/4] net/udpgso_bench_tx: audit error queue

2019-05-23 Thread Willem de Bruijn
On Thu, May 23, 2019 at 9:27 PM Fred Klassen wrote: > > Willem, this is only my 2nd patch, and my last one was a one liner. > I’ll try to work through this, but let me know if I am doing a rookie > mistake (learning curve and all). Not at all. The fix makes perfect sense. The test patches 2 and

Re: need company for kernel upgrade

2019-05-23 Thread Theodore Ts'o
On Thu, May 23, 2019 at 09:29:11AM +0200, walter harms wrote: > > No, > the company i am working for has a custom build arm-board. > We bought the kernel from the assembler but found it has > some problems that need fixing. > Basically we want to improve the linux-kernel so it can run > native on

Re: [PATCH 2/3] firmware: add offset to request_firmware_into_buf

2019-05-23 Thread Scott Branden
On 2019-05-23 9:54 a.m., Greg Kroah-Hartman wrote: On Thu, May 23, 2019 at 09:36:02AM -0700, Scott Branden wrote: Hi Greg, On 2019-05-22 10:52 p.m., Greg Kroah-Hartman wrote: On Wed, May 22, 2019 at 07:51:12PM -0700, Scott Branden wrote: Add offset to request_firmware_into_buf to allow for

Re: [PATCH 1/2] net/macb: bindings doc: add sifive fu540-c000 binding

2019-05-23 Thread Yash Shah
On Fri, May 24, 2019 at 2:20 AM Rob Herring wrote: > > On Thu, May 23, 2019 at 6:46 AM Yash Shah wrote: > > > > Add the compatibility string documentation for SiFive FU540-C > > interface. > > On the FU540, this driver also needs to read and write registers in a > > management IP block that m

Re: PSA: Do not use "Reported-By" without reporter's approval

2019-05-23 Thread Theodore Ts'o
On Wed, May 22, 2019 at 03:58:04PM -0400, Konstantin Ryabitsev wrote: > > If the report is public, and lists like vger are public, > > then using a Reported-by: and/or a Link: are simply useful > > history and tracking information. > > I'm perfectly fine with Link:, however Reported-By: usually ha

Re: [PATCH 0/2] net: macb: Add support for SiFive FU540-C000

2019-05-23 Thread Yash Shah
On Thu, May 23, 2019 at 9:58 PM David Miller wrote: > > > Please be consistent in your subsystem prefixes used in your Subject lines. > You use "net: macb:" then "net/macb:" Really, plain "macb: " is sufficient. Sure, Will take care of this in the next revision of this patch. Thanks for your com

Re: [PATCH net 1/4] net/udp_gso: Allow TX timestamp with UDP GSO

2019-05-23 Thread Willem de Bruijn
On Thu, May 23, 2019 at 9:38 PM Fred Klassen wrote: > > > Thanks for the report. > > > > Zerocopy notification reference count is managed in skb_segment. That > > should work. > > > > Support for timestamping with the new GSO feature is indeed an > > oversight. The solution is similar to how TCP a

[PATCH] MIPS: replace MBIT_ULL() with BIT_ULL()

2019-05-23 Thread Masahiro Yamada
Commit 8bd9cb51daac ("locking/atomics, asm-generic: Move some macros from to a new file") moved BIT_ULL() into . It only includes , so there is no longer "include file recursion hell". Signed-off-by: Masahiro Yamada --- arch/mips/include/asm/cpu.h | 125 +--- 1

Re: [PATCH V4 3/4] arm64/mm: Hold memory hotplug lock while walking for kernel page table dump

2019-05-23 Thread Anshuman Khandual
On 05/21/2019 03:44 PM, Michal Hocko wrote: > On Mon 20-05-19 10:48:35, Anshuman Khandual wrote: >> The arm64 page table dump code can race with concurrent modification of the >> kernel page tables. When a leaf entries are modified concurrently, the dump >> code may log stale or inconsistent inf

Re: [PATCH 2/2] net: macb: Add support for SiFive FU540-C000

2019-05-23 Thread Yash Shah
On Thu, May 23, 2019 at 8:24 PM Andrew Lunn wrote: > > > +static int fu540_macb_tx_set_rate(struct clk_hw *hw, unsigned long rate, > > + unsigned long parent_rate) > > +{ > > + rate = fu540_macb_tx_round_rate(hw, rate, &parent_rate); > > + iowrite32(rate != 12

Re: [PATCH 0/2] net: macb: Add support for SiFive FU540-C000

2019-05-23 Thread Yash Shah
Hi Andreas, On Thu, May 23, 2019 at 6:19 PM Andreas Schwab wrote: > > On Mai 23 2019, Yash Shah wrote: > > > On FU540, the management IP block is tightly coupled with the Cadence > > MACB IP block. It manages many of the boundary signals from the MACB IP > > This patchset controls the tx_clk inp

linux-next: Fixes tag needs some work in the cifs tree

2019-05-23 Thread Stephen Rothwell
Hi all, In commit f875253b5fe6 ("fs/cifs/smb2pdu.c: fix buffer free in SMB2_ioctl_free") Fixes tag Fixes: 2c87d6a ("cifs: Allocate memory for all iovs in smb2_ioctl") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) o

Re: [PATCH 2/2] auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero()

2019-05-23 Thread Miguel Ojeda
On Thu, May 23, 2019 at 2:58 PM Miguel Ojeda wrote: > > Taking a quick look now, by the way, why does vm_map_pages_zero() (and > __vm_map_pages() etc.) get a pointer to an array instead of a pointer > to the first element? Also, in __vm_map_pages(), semantically w.r.t. to the comment, shouldn't t

drivers/net//ethernet/hisilicon/hns/hns_dsaf_main.c:2597:1: warning: the frame size of 10976 bytes is larger than 8192 bytes

2019-05-23 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4dde821e4296e156d133b98ddc4c45861935a4fb commit: 81a56f6dcd20325607d6008f4bb560c96f4c821a gcc-plugins: structleak: Generalize to all variable types date: 3 months ago config: s390-allmodconfig (attached as

linux-next: Tree for May 24

2019-05-23 Thread Stephen Rothwell
Hi all, News: there will be no linux-next release on Monday. Changes since 20190523: The input-current tree gained a build failure so I reverted a commit. The drm-fixes tree gained a build failure so I reverted a commit. The v4l-dvb tree gained a conflict against Linus' tree. Non-

Re: [RFC PATCH 00/11] bpf, trace, dtrace: DTrace BPF program type implementation and sample use

2019-05-23 Thread Kris Van Hees
On Thu, May 23, 2019 at 02:13:31PM -0700, Alexei Starovoitov wrote: > On Thu, May 23, 2019 at 01:46:10AM -0400, Kris Van Hees wrote: > > > > I think there is a difference between a solution and a good solution. > > Adding > > a lot of knowledge in the userspace component about how things are >

Re: [PATCH] tracing: silence GCC 9 array bounds warning

2019-05-23 Thread Miguel Ojeda
On Fri, May 24, 2019 at 4:12 AM Steven Rostedt wrote: > > On Thu, 23 May 2019 14:45:35 +0200 > Miguel Ojeda wrote: > > I still prefer the typecast of void *, as that's used a bit more in the > kernel, but since char * is also used (not as much), I'll leave it. But > the parenthesis around iter ar

Re: [PATCH] mm/swap: Fix release_pages() when releasing devmap pages

2019-05-23 Thread Dan Williams
On Thu, May 23, 2019 at 3:37 PM wrote: > > From: Ira Weiny > > Device pages can be more than type MEMORY_DEVICE_PUBLIC. > > Handle all device pages within release_pages() > > This was found via code inspection while determining if release_pages() > and the new put_user_pages() could be interchang

Re: [PATCH 4.19 000/114] 4.19.46-stable review

2019-05-23 Thread kernelci.org bot
stable-rc/linux-4.19.y boot: 125 boots: 0 failed, 112 passed with 13 offline (v4.19.45-115-g071ff9cc9849) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.19.45-115-g071ff9cc9849/ Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4

Re: [PATCH v2] initramfs: Fix a missing-chek bug in dir_add()teven.pr...@arm.com、

2019-05-23 Thread Gen Zhang
On Thu, May 23, 2019 at 08:35:23PM -0700, Andrew Morton wrote: > On Fri, 24 May 2019 11:30:45 +0800 Gen Zhang wrote: > > > In dir_add() and do_name(), de->name and vcollected are allocated by > > kstrdup(). And de->name and vcollected are dereferenced in the following > > codes. However, memory a

[PATCH v2] ASoC: drop COMPILE_TEST for sound/soc/intel/boards/ that use X86_INTEL_LPSS

2019-05-23 Thread Randy Dunlap
From: Randy Dunlap This is a partial revert of 164a263bf8d0, which causes build errors on non-X86 platforms (specifically seen on IA64) when COMPILE_TEST is set/enabled. Fixes these build errors (on ia64): i../sound/soc/intel/boards/bxt_da7219_max98357a.c:19:10: fatal error: asm/cpu_device_id.h

Re: [PATCH v2] initramfs: Fix a missing-chek bug in dir_add()

2019-05-23 Thread Andrew Morton
On Fri, 24 May 2019 11:30:45 +0800 Gen Zhang wrote: > In dir_add() and do_name(), de->name and vcollected are allocated by > kstrdup(). And de->name and vcollected are dereferenced in the following > codes. However, memory allocation functions such as kstrdup() may fail. > Dereferencing this nul

[PATCH 1/2] media: add generic device allocate interface to media-dev-allocator

2019-05-23 Thread Shuah Khan
Media Device Allocator API supports just USB devices. Enhance it adding a genetic device allocate interface to support other media drivers. The new interface takes pointer to struct device instead and creates media device. This interface allows a group of drivers that have a common root device to

[PATCH 0/2] Use Media Dev Allocator to fix vimc dev lifetime bugs

2019-05-23 Thread Shuah Khan
media_device is embedded in struct vimc_device and when vimc is removed vimc_device and the embedded media_device goes with it, while the active stream and vimc_capture continue to access it. Fix the media_device lifetime problem by changing vimc to create shared media_device using Media Device Al

[PATCH v2] initramfs: Fix a missing-chek bug in dir_add()

2019-05-23 Thread Gen Zhang
In dir_add() and do_name(), de->name and vcollected are allocated by kstrdup(). And de->name and vcollected are dereferenced in the following codes. However, memory allocation functions such as kstrdup() may fail. Dereferencing this null pointer may cause the kernel go wrong. Thus we should check

[PATCH 2/2] vimc: fix BUG: unable to handle kernel NULL pointer dereference

2019-05-23 Thread Shuah Khan
If vimc module is removed while streaming is active, vimc_exit runs into NULL pointer dereference error when streaming thread tries to access and lock graph_mutex in the struct media_device. media_device is embedded in struct vimc_device and when vimc is removed vimc_device and the embedded media_

[PATCH] staging: iio: adis16240: add of_match_table entry

2019-05-23 Thread Rodrigo Ribeiro
This patch adds of_match_table entry in device driver in order to enable spi fallback probing. Signed-off-by: Rodrigo Ribeiro Reviewed-by: Marcelo Schmitt --- drivers/staging/iio/accel/adis16240.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/accel/adis16240.c b/drive

[PATCH] ip_sockglue: Fix missing-check bug in ip_ra_control()

2019-05-23 Thread Gen Zhang
In function ip_ra_control(), the pointer new_ra is allocated a memory space via kmalloc(). And it is used in the following codes. However, when there is a memory allocation error, kmalloc() fails. Thus null pointer dereference may happen. And it will cause the kernel to crash. Therefore, we sh

RE: [PATCH v2 09/10] Input: elan_i2c - correct the width/size base value

2019-05-23 Thread 廖崇榮
Hi Benjamin, Thanks so much for all you do for Elan touchpad. For the width_*, I have a question for it. Our antenna sensors fully occupied the whole touchpad PCB. The Gap between 2 sensors are 7.5 mil (0.19mm). That's why we did not minus one trace. Thanks KT -Original Message- From:

RE: [EXT] Re: [PATCH] dt-bindings: thermal: Make cooling-maps property optional

2019-05-23 Thread Andy Tang
> -Original Message- > From: Eduardo Valentin > Sent: 2019年5月24日 10:50 > To: Andy Tang > Cc: rui.zh...@intel.com; robh...@kernel.org; daniel.lezc...@linaro.org; > mark.rutl...@arm.com; linux...@vger.kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [EXT] Re

[PATCH] ipv6_sockglue: Fix a missing-check bug in ip6_ra_control()

2019-05-23 Thread Gen Zhang
In function ip6_ra_control(), the pointer new_ra is allocated a memory space via kmalloc(). And it is used in the following codes. However, when there is a memory allocation error, kmalloc() fails. Thus null pointer dereference may happen. And it will cause the kernel to crash. Therefore, we sh

Re: [PATCH v18 1/3] proc: add /proc//arch_status

2019-05-23 Thread Andrew Morton
On Thu, 25 Apr 2019 22:32:17 +0800 Aubrey Li wrote: > The architecture specific information of the running processes > could be useful to the userland. Add /proc//arch_status > interface support to examine process architecture specific > information externally. I'll give this an Acked-by: Andre

[PATCH] arm64: break while loop if task had been rescheduled

2019-05-23 Thread tengfeif
When task isn't current task, this task's state have chance to be changed during printing this task's backtrace, so it is possible that task's fp and fp+8 have the same vaule, so cannot break the while loop. To fix this issue, we first save the task's state, sp and fp, then we will get the task's

Re: [PATCHv2] kernel/crash: make parse_crashkernel()'s return value more indicant

2019-05-23 Thread Pingfan Liu
Matthias, ping? Any suggestions? Thanks, Pingfan On Thu, May 2, 2019 at 2:22 PM Pingfan Liu wrote: > > On Thu, Apr 25, 2019 at 4:20 PM Pingfan Liu wrote: > > > > On Wed, Apr 24, 2019 at 4:31 PM Matthias Brugger wrote: > > > > > > > > [...] > > > > @@ -139,6 +141,8 @@ static int __init parse_c

Re: [PATCH RFC v8 01/10] namei: obey trailing magic-link DAC permissions

2019-05-23 Thread Aleksa Sarai
On 2019-05-23, Aleksa Sarai wrote: > On 2019-05-22, Andy Lutomirski wrote: > > What are actual examples of uses for this exception? Breaking > > selftests is not, in and of itself, a huge problem. > > Not as far as I know. All of the re-opening users I know of do re-opens > of O_PATH or are re-

  1   2   3   4   5   6   7   8   9   10   >