Re: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-06-18 Thread Colin Ian King
On 19/06/2019 06:13, Martin Blumenstingl wrote: > Hi Colin, > >> Currently the call to device_property_read_u32_array is not error checked >> leading to potential garbage values in the delays array that are then used >> in msleep delays. Add a sanity check to the property fetching. >> >> Addresse

Re: [PATCH] staging: kpc2000: simplify error handling in kp2000_pcie_probe

2019-06-18 Thread Dan Carpenter
On Wed, Jun 19, 2019 at 08:36:07AM +0200, Simon Sandström wrote: > We can get rid of a few iounmaps in the middle of the function by > re-ordering the error handling labels and adding two new labels. > > Signed-off-by: Simon Sandström > --- > > This change has not been tested besides by compilin

Re: [PATCH 5/5] Powerpc/Watchpoint: Fix length calculation for unaligned target

2019-06-18 Thread Ravi Bangoria
On 6/18/19 12:16 PM, Christophe Leroy wrote: >>   +/* Maximum len for DABR is 8 bytes and DAWR is 512 bytes */ >> +static int hw_breakpoint_validate_len(struct arch_hw_breakpoint *hw) >> +{ >> +    u16 length_max = 8; >> +    u16 final_len; > > You should be more consistent in naming. If one is

Re: [PATCH v3 0/6] Enable THP for text section of non-shmem files

2019-06-18 Thread Michal Hocko
[Cc fsdevel and lkml] On Tue 18-06-19 23:24:18, Song Liu wrote: > Changes v2 => v3: > 1. Removed the limitation (cannot write to file with THP) by truncating >whole file during sys_open (see 6/6); > 2. Fixed a VM_BUG_ON_PAGE() in filemap_fault() (see 2/6); > 3. Split function rename to a separ

Re: [PATCH] net: mvpp2: cls: Add pmap to fs dump

2019-06-18 Thread Maxime Chevallier
Hello Nathan, On Tue, 18 Jun 2019 09:09:10 -0700 Nathan Huckleberry wrote: >There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops' >Added a usage consistent with other fops to dump pmap >to userspace. Thanks for sending a fix. Besides the typo preventing your patch from compiling, you should

Re: [PATCH 1/1] udf: Fix incorrect final NOT_ALLOCATED (hole) extent length

2019-06-18 Thread Jan Kara
Hi Steve! On Sun 16-06-19 11:28:46, Steve Magnani wrote: > On 6/4/19 7:31 AM, Steve Magnani wrote: > > > In some cases, using the 'truncate' command to extend a UDF file results > > in a mismatch between the length of the file's extents (specifically, due > > to incorrect length of the final NOT_

[PATCH 0/2] perf thread-stack: Fix thread stack return from kernel for kernel-only case

2019-06-18 Thread Adrian Hunter
Hi Here is one non-urgent fix and a subsequent tidy-up. Adrian Hunter (2): perf thread-stack: Fix thread stack return from kernel for kernel-only case perf thread-stack: Eliminate code duplicating thread_stack__pop_ks() tools/perf/util/thread-stack.c | 48 +

[PATCH 2/2] perf thread-stack: Eliminate code duplicating thread_stack__pop_ks()

2019-06-18 Thread Adrian Hunter
Use new function thread_stack__pop_ks() in place of equivalent code. Signed-off-by: Adrian Hunter --- tools/perf/util/thread-stack.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/tools/perf/util/thread-stack.c b/tools/perf/util/thread-stack.c index f91c0

[PATCH 1/2] perf thread-stack: Fix thread stack return from kernel for kernel-only case

2019-06-18 Thread Adrian Hunter
Commit f08046cb3082 ("perf thread-stack: Represent jmps to the start of a different symbol") had the side-effect of introducing more stack entries before return from kernel space. When user space is also traced, those entries are popped before entry to user space, but when user space is not traced,

linux-next: build failure after merge of the usb tree

2019-06-18 Thread Stephen Rothwell
Hi all, After merging the usb tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from usr/include/linux/usbdevice_fs.hdrtest.c:1: ./usr/include/linux/usbdevice_fs.h:88:2: error: unknown type name 'u8' u8 num_ports; /* Number of ports the device is connected

[net v1] net: stmmac: set IC bit when transmitting frames with HW timestamp

2019-06-18 Thread Voon Weifeng
From: Roland Hii When transmitting certain PTP frames, e.g. SYNC and DELAY_REQ, the PTP daemon, e.g. ptp4l, is polling the driver for the frame transmit hardware timestamp. The polling will most likely timeout if the tx coalesce is enabled due to the Interrupt-on-Completion (IC) bit is not set in

Re: [PATCH] [v2] ipsec: select crypto ciphers for xfrm_algo

2019-06-18 Thread Herbert Xu
On Tue, Jun 18, 2019 at 01:22:13PM +0200, Arnd Bergmann wrote: > kernelci.org reports failed builds on arc because of what looks > like an old missed 'select' statement: > > net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs': > xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash'

Re: [PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework

2019-06-18 Thread Viresh Kumar
On 19-06-19, 00:23, Rafael J. Wysocki wrote: > In patch [3/5] you could point notifiers for both min and max freq to the same > notifier head. Both of your notifiers end up calling cpufreq_update_policy() > anyway. I tried it and the changes in qos.c file look fine. But I don't like at all how c

Re: WARNING in fanotify_handle_event

2019-06-18 Thread Amir Goldstein
On Tue, Jun 18, 2019 at 11:27 PM Amir Goldstein wrote: > > On Tue, Jun 18, 2019 at 8:07 PM syzbot > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:963172d9 Merge branch 'x86-urgent-for-linus' of git://git... > > git tree: upstream > > console outp

Re: [PATCH] ecryptfs: use print_hex_dump_bytes for hexdump

2019-06-18 Thread Tyler Hicks
On 2019-05-17 12:45:15, Sascha Hauer wrote: > The Kernel has nice hexdump facilities, use them rather a homebrew > hexdump function. > > Signed-off-by: Sascha Hauer Thanks! This is much nicer. I've pushed the commit to the eCryptfs next branch. Tyler > --- > fs/ecryptfs/debug.c | 22 +++--

[PATCH] staging: kpc2000: simplify error handling in kp2000_pcie_probe

2019-06-18 Thread Simon Sandström
We can get rid of a few iounmaps in the middle of the function by re-ordering the error handling labels and adding two new labels. Signed-off-by: Simon Sandström --- This change has not been tested besides by compiling. It might be good took take an extra look to make sure that I got everything

Re: [PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported

2019-06-18 Thread Hannes Reinecke
On 6/19/19 5:35 AM, Martin K. Petersen wrote: > > Marcos, > >> WWID composed from VPD data from device, specifically page 0x83. So, >> when a device does not have VPD support, for example USB storage >> devices where VPD is specifically disabled, a read into > device>/device/wwid file will always

Re: [PATCH -next] ecryptfs: remove unnessesary null check in ecryptfs_keyring_auth_tok_for_sig

2019-06-18 Thread Tyler Hicks
On 2019-05-27 21:28:14, YueHaibing wrote: > request_key and ecryptfs_get_encrypted_key never > return a NULL pointer, so no need do a null check. > > Signed-off-by: YueHaibing This change looks good to me. I've pushed it to the eCryptfs next branch. Tyler > --- > fs/ecryptfs/keystore.c | 4 ++

Re: [PATCH 04/25] vfs: Implement parameter value retrieval with fsinfo() [ver #13]

2019-06-18 Thread Miklos Szeredi
On Wed, Jun 19, 2019 at 12:34 AM David Howells wrote: > > Same goes for vfs_parse_sb_flag() btw. It should be moved into each > > filesystem's ->parse_param() and not be a mandatory thing. > > I disagree. Every filesystem *must* be able to accept these standard flags, > even if it then ignores

Re: [PATCH -next] ecryptfs: Make ecryptfs_xattr_handler static

2019-06-18 Thread Tyler Hicks
On 2019-06-14 23:51:17, YueHaibing wrote: > Fix sparse warning: > > fs/ecryptfs/inode.c:1138:28: warning: > symbol 'ecryptfs_xattr_handler' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Thanks for the cleanup! I've pushed this to the eCryptfs n

Re: [PATCH v4 1/3] KVM: x86: add support for user wait instructions

2019-06-18 Thread Xiaoyao Li
On 6/19/2019 2:09 PM, Tao Xu wrote: UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. This patch adds support for user wait instructions in KVM. Availability of the user wait instructions is indicated by the presence of the CPUID feature flag WAITPKG CPUID.0x07.0x0:ECX[5]. User

Re: [PATCH 4/5] Powerpc/hw-breakpoint: Optimize disable path

2019-06-18 Thread Ravi Bangoria
On 6/18/19 12:01 PM, Christophe Leroy wrote: >> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c >> index f002d286..265fac9fb3a4 100644 >> --- a/arch/powerpc/kernel/process.c >> +++ b/arch/powerpc/kernel/process.c >> @@ -793,10 +793,22 @@ static inline int set_dabr(

[net v1] net: stmmac: fixed new system time seconds value calculation

2019-06-18 Thread Voon Weifeng
From: Roland Hii When ADDSUB bit is set, the system time seconds field is calculated as the complement of the seconds part of the update value. For example, if 3.1 seconds need to be subtracted from the system time, this field is calculated as 2^32 - 3 = 4294967296 - 3 = 0x1 - 3

[PATCH v4 0/3] KVM: x86: Enable user wait instructions

2019-06-18 Thread Tao Xu
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. UMONITOR arms address monitoring hardware using an address. A store to an address within the specified address range triggers the monitoring hardware to wake up the processor waiting in umwait. UMWAIT instructs the processor to ente

[PATCH v4 1/3] KVM: x86: add support for user wait instructions

2019-06-18 Thread Tao Xu
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. This patch adds support for user wait instructions in KVM. Availability of the user wait instructions is indicated by the presence of the CPUID feature flag WAITPKG CPUID.0x07.0x0:ECX[5]. User wait instructions may be executed at any

[PATCH v4 3/3] KVM: vmx: handle vm-exit for UMWAIT and TPAUSE

2019-06-18 Thread Tao Xu
As the latest Intel 64 and IA-32 Architectures Software Developer's Manual, UMWAIT and TPAUSE instructions cause a VM exit if the RDTSC exiting and enable user wait and pause VM-execution controls are both 1. This patch is to handle the vm-exit for UMWAIT and TPAUSE as this should never happen. C

[PATCH v4 2/3] KVM: vmx: Emulate MSR IA32_UMWAIT_CONTROL

2019-06-18 Thread Tao Xu
UMWAIT and TPAUSE instructions use IA32_UMWAIT_CONTROL at MSR index E1H to determines the maximum time in TSC-quanta that the processor can reside in either C0.1 or C0.2. This patch emulates MSR IA32_UMWAIT_CONTROL in guest and differentiate IA32_UMWAIT_CONTROL between host and guest. The variable

RE: [PATCH v2 6/6] net: macb: parameter added to cadence ethernet controller DT binding

2019-06-18 Thread Parshuram Raju Thombare
Hi Florian, >Please don't resubmit individual patches as replies to your previous >ones, re-submitting the entire patch series, see this netdev-FAQ section >for details: I will resubmit entire patch series separately. > >> +- serdes-rate External serdes rate.Mandatory for USXGMII mode. > >> +

Re: nouveau: DRM: GPU lockup - switching to software fbcon

2019-06-18 Thread Ilia Mirkin
On Wed, Jun 19, 2019 at 1:48 AM Sergey Senozhatsky wrote: > > On (06/19/19 01:20), Ilia Mirkin wrote: > > On Wed, Jun 19, 2019 at 1:08 AM Sergey Senozhatsky > > wrote: > > > > > > On (06/14/19 11:50), Sergey Senozhatsky wrote: > > > > dmesg > > > > > > > > nouveau :01:00.0: DRM: GPU lockup -

[PATCH v10 12/13] libnvdimm/pfn: Fix fsdax-mode namespace info-block zero-fields

2019-06-18 Thread Dan Williams
At namespace creation time there is the potential for the "expected to be zero" fields of a 'pfn' info-block to be filled with indeterminate data. While the kernel buffer is zeroed on allocation it is immediately overwritten by nd_pfn_validate() filling it with the current contents of the on-media

[PATCH v10 09/13] mm/sparsemem: Support sub-section hotplug

2019-06-18 Thread Dan Williams
The libnvdimm sub-system has suffered a series of hacks and broken workarounds for the memory-hotplug implementation's awkward section-aligned (128MB) granularity. For example the following backtrace is emitted when attempting arch_add_memory() with physical address ranges that intersect 'System RA

[PATCH v10 06/13] mm/hotplug: Kill is_dev_zone() usage in __remove_pages()

2019-06-18 Thread Dan Williams
The zone type check was a leftover from the cleanup that plumbed altmap through the memory hotplug path, i.e. commit da024512a1fa "mm: pass the vmem_altmap to arch_remove_memory and __remove_pages". Cc: Michal Hocko Cc: Logan Gunthorpe Cc: Pavel Tatashin Reviewed-by: David Hildenbrand Reviewed

[PATCH v10 08/13] mm/sparsemem: Prepare for sub-section ranges

2019-06-18 Thread Dan Williams
Prepare the memory hot-{add,remove} paths for handling sub-section ranges by plumbing the starting page frame and number of pages being handled through arch_{add,remove}_memory() to sparse_{add,remove}_one_section(). This is simply plumbing, small cleanups, and some identifier renames. No intended

[PATCH v10 10/13] mm: Document ZONE_DEVICE memory-model implications

2019-06-18 Thread Dan Williams
Explain the general mechanisms of 'ZONE_DEVICE' pages and list the users of 'devm_memremap_pages()'. Cc: Jonathan Corbet Reported-by: Mike Rapoport Signed-off-by: Dan Williams --- Documentation/vm/memory-model.rst | 39 + 1 file changed, 39 insertions(+)

[PATCH v10 13/13] libnvdimm/pfn: Stop padding pmem namespaces to section alignment

2019-06-18 Thread Dan Williams
Now that the mm core supports section-unaligned hotplug of ZONE_DEVICE memory, we no longer need to add padding at pfn/dax device creation time. The kernel will still honor padding established by older kernels. Reported-by: Jeff Moyer Signed-off-by: Dan Williams --- drivers/nvdimm/pfn.h |

[PATCH v10 11/13] mm/devm_memremap_pages: Enable sub-section remap

2019-06-18 Thread Dan Williams
Teach devm_memremap_pages() about the new sub-section capabilities of arch_{add,remove}_memory(). Effectively, just replace all usage of align_start, align_end, and align_size with res->start, res->end, and resource_size(res). The existing sanity check will still make sure that the two separate rem

[PATCH v10 07/13] mm: Kill is_dev_zone() helper

2019-06-18 Thread Dan Williams
Given there are no more usages of is_dev_zone() outside of 'ifdef CONFIG_ZONE_DEVICE' protection, kill off the compilation helper. Cc: Michal Hocko Cc: Logan Gunthorpe Acked-by: David Hildenbrand Reviewed-by: Oscar Salvador Reviewed-by: Pavel Tatashin Reviewed-by: Wei Yang Signed-off-by: Dan

[PATCH v10 04/13] mm/hotplug: Prepare shrink_{zone, pgdat}_span for sub-section removal

2019-06-18 Thread Dan Williams
Sub-section hotplug support reduces the unit of operation of hotplug from section-sized-units (PAGES_PER_SECTION) to sub-section-sized units (PAGES_PER_SUBSECTION). Teach shrink_{zone,pgdat}_span() to consider PAGES_PER_SUBSECTION boundaries as the points where pfn_valid(), not valid_section(), can

[PATCH v10 05/13] mm/sparsemem: Convert kmalloc_section_memmap() to populate_section_memmap()

2019-06-18 Thread Dan Williams
Allow sub-section sized ranges to be added to the memmap. populate_section_memmap() takes an explict pfn range rather than assuming a full section, and those parameters are plumbed all the way through to vmmemap_populate(). There should be no sub-section usage in current deployments. New warnings a

[PATCH v10 02/13] mm/sparsemem: Introduce a SECTION_IS_EARLY flag

2019-06-18 Thread Dan Williams
In preparation for sub-section hotplug, track whether a given section was created during early memory initialization, or later via memory hotplug. This distinction is needed to maintain the coarse expectation that pfn_valid() returns true for any pfn within a given section even if that section has

[PATCH v10 00/13] mm: Sub-section memory hotplug support

2019-06-18 Thread Dan Williams
Changes since v9 [1]: - Fix multiple issues related to the fact that pfn_valid() has traditionally returned true for any pfn in an 'early' (onlined at boot) section regardless of whether that pfn represented 'System RAM'. Teach pfn_valid() to maintain its traditional behavior in the presence

[PATCH v10 03/13] mm/sparsemem: Add helpers track active portions of a section at boot

2019-06-18 Thread Dan Williams
Prepare for hot{plug,remove} of sub-ranges of a section by tracking a sub-section active bitmask, each bit representing a PMD_SIZE span of the architecture's memory hotplug section size. The implications of a partially populated section is that pfn_valid() needs to go beyond a valid_section() chec

[PATCH v10 01/13] mm/sparsemem: Introduce struct mem_section_usage

2019-06-18 Thread Dan Williams
Towards enabling memory hotplug to track partial population of a section, introduce 'struct mem_section_usage'. A pointer to a 'struct mem_section_usage' instance replaces the existing pointer to a 'pageblock_flags' bitmap. Effectively it adds one more 'unsigned long' beyond the 'pageblock_flags'

Re: [RESEND v4 1/4] soc: qcom: geni: Add support for ACPI

2019-06-18 Thread Lee Jones
On Wed, 19 Jun 2019, Andy Gross wrote: > On Mon, Jun 17, 2019 at 01:51:02PM +0100, Lee Jones wrote: > > When booting with ACPI as the active set of configuration tables, > > all; clocks, regulators, pin functions ect are expected to be at > > their ideal values/levels/rates, thus the associated fr

Re: [PATCH 4/5] Powerpc/hw-breakpoint: Optimize disable path

2019-06-18 Thread Ravi Bangoria
On 6/18/19 11:45 AM, Michael Neuling wrote: > On Tue, 2019-06-18 at 09:57 +0530, Ravi Bangoria wrote: >> Directly setting dawr and dawrx with 0 should be enough to >> disable watchpoint. No need to reset individual bits in >> variable and then set in hw. > > This seems like a pointless optimisa

Re: [PATCH] NTB: test: remove a duplicate check

2019-06-18 Thread Dan Carpenter
It's not a huge deal obviously but your commit was a6bed7a54165 ("NTB: Introduce NTB MSI Test Client") but you know that if I had sent a patch called ("NTB: remove a duplicate check") people would have correctly complained because the patch prefix is too vague. What I'm saying is we do this all th

Re: [PATCH] mfd: stmfx: Fix an endian bug in stmfx_irq_handler()

2019-06-18 Thread Lee Jones
On Tue, 18 Jun 2019, Linus Torvalds wrote: > On Tue, Jun 18, 2019 at 1:16 AM Lee Jones wrote: > > > > > Reported-by: Linus Torvalds > > > > Ideally we can get a review too. > > Looks fine to me, but obviously somebody should actually _test_ it too. Amelie, would you be so kind? -- Lee Jones

Re: [PATCH RESEND 1/8] s390: Start fallback of top-down mmap at mm->mmap_base

2019-06-18 Thread Alex Ghiti
Really sorry about that, my connection is weird this morning, I'll retry tomorrow. Sorry again, Alex On 6/19/19 1:42 AM, Alexandre Ghiti wrote: In case of mmap failure in top-down mode, there is no need to go through the whole address space again for the bottom-up fallback: the goal of this f

Re: [RESEND v4 1/4] soc: qcom: geni: Add support for ACPI

2019-06-18 Thread Andy Gross
On Mon, Jun 17, 2019 at 01:51:02PM +0100, Lee Jones wrote: > When booting with ACPI as the active set of configuration tables, > all; clocks, regulators, pin functions ect are expected to be at > their ideal values/levels/rates, thus the associated frameworks > are unavailable. Ensure calls to the

[PATCH V5 3/5] clk: imx: Add API for clk unregister when driver probe fail

2019-06-18 Thread Anson . Huang
From: Anson Huang For i.MX clock drivers probe fail case, clks should be unregistered in the return path, this patch adds a common API for i.MX clock drivers to unregister clocks when fail. Signed-off-by: Anson Huang --- New patch. --- drivers/clk/imx/clk.c | 8 drivers/clk/imx/clk.h

[PATCH V5 4/5] clk: imx: Add support for i.MX8MN clock driver

2019-06-18 Thread Anson . Huang
From: Anson Huang This patch adds i.MX8MN clock driver support. Signed-off-by: Anson Huang --- Changes since V4: - use dev_err instead of pr_err; - unregister clocks when probe failed. --- drivers/clk/imx/Kconfig | 6 + drivers/clk/imx/Makefile | 1 + drivers/clk/i

[PATCH V5 1/5] dt-bindings: imx: Add clock binding doc for i.MX8MN

2019-06-18 Thread Anson . Huang
From: Anson Huang Add the clock binding doc for i.MX8MN. Signed-off-by: Anson Huang Reviewed-by: Maxime Ripard --- No changes. --- .../devicetree/bindings/clock/imx8mn-clock.yaml| 112 +++ include/dt-bindings/clock/imx8mn-clock.h | 215 + 2 files chan

[PATCH V5 5/5] arm64: defconfig: Select CONFIG_CLK_IMX8MN by default

2019-06-18 Thread Anson . Huang
From: Anson Huang Enable CONFIG_CLK_IMX8MN to support i.MX8MN clock driver. Signed-off-by: Anson Huang --- No changes. --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 7a21159..29f7768 100644

[PATCH V5 2/5] clk: imx8mm: Make 1416X/1443X PLL macro definitions common for usage

2019-06-18 Thread Anson . Huang
From: Anson Huang 1416X/1443X PLL are used on i.MX8MM and i.MX8MN and maybe other i.MX8M series SoC later, the macro definitions of these PLLs' initialization should be common for usage. Signed-off-by: Anson Huang --- No changes. --- drivers/clk/imx/clk-imx8mm.c | 17 - drivers

[PATCH RESEND 1/8] s390: Start fallback of top-down mmap at mm->mmap_base

2019-06-18 Thread Alexandre Ghiti
In case of mmap failure in top-down mode, there is no need to go through the whole address space again for the bottom-up fallback: the goal of this fallback is to find, as a last resort, space between the top-down mmap base and the stack, which is the only place not covered by the top-down mmap. S

Re: [PATCH v4 3/6] soc: qcom: geni: Add support for ACPI

2019-06-18 Thread Bjorn Andersson
On Wed 12 Jun 07:26 PDT 2019, Lee Jones wrote: > When booting with ACPI as the active set of configuration tables, > all; clocks, regulators, pin functions ect are expected to be at > their ideal values/levels/rates, thus the associated frameworks > are unavailable. Ensure calls to these APIs are

Re: [PATCH 1/1] scsi: ufs-qcom: Add support for platforms booting ACPI

2019-06-18 Thread Lee Jones
Ard, Martin, On Tue, 18 Jun 2019, Martin K. Petersen wrote: > > New Qualcomm AArch64 based laptops are now available which use UFS > > as their primary data storage medium. These devices are supplied > > with ACPI support out of the box. This patch ensures the Qualcomm > > UFS driver will be bou

[PATCH RESEND 0/8] Fix mmap base in bottom-up mmap

2019-06-18 Thread Alexandre Ghiti
This series fixes the fallback of the top-down mmap: in case of failure, a bottom-up scheme can be tried as a last resort between the top-down mmap base and the stack, hoping for a large unused stack limit. Lots of architectures and even mm code start this fallback at TASK_UNMAPPED_BASE, which is

Re: [PATCH] NTB: test: remove a duplicate check

2019-06-18 Thread Logan Gunthorpe
,, On 2019-06-18 11:32 p.m., Dan Carpenter wrote: > We already verified that the "nm->isr_ctx" allocation succeeded so there > is no need to check again here. > > Fixes: a6bed7a54165 ("NTB: Introduce NTB MSI Test Client") > Signed-off-by: Dan Carpenter Hmm, yup, not sure how that slipped throug

[PATCH RESEND 0/8] Fix mmap base in bottom-up mmap

2019-06-18 Thread Alexandre Ghiti
(Sorry for the previous interrupted series) This series fixes the fallback of the top-down mmap: in case of failure, a bottom-up scheme can be tried as a last resort between the top-down mmap base and the stack, hoping for a large unused stack limit. Lots of architectures and even mm code start

Re: [PATCH RFC 2/3] fonts: Use BUILD_BUG_ON() for checking empty font table

2019-06-18 Thread Takashi Iwai
On Wed, 19 Jun 2019 01:05:58 +0200, Randy Dunlap wrote: > > On 6/18/19 1:34 PM, Takashi Iwai wrote: > > We have a nice macro, and the check of emptiness of the font table can > > be done in a simpler way. > > > > Signed-off-by: Takashi Iwai > > Hi, > > Looks good to me. > Acked-by: Randy Dunla

[PATCH] NTB: test: remove a duplicate check

2019-06-18 Thread Dan Carpenter
We already verified that the "nm->isr_ctx" allocation succeeded so there is no need to check again here. Fixes: a6bed7a54165 ("NTB: Introduce NTB MSI Test Client") Signed-off-by: Dan Carpenter --- Hey Logan, can pick a patch prefix when you're introducing a new module? "[PATCH] NTB/test: Introduc

Re: [PATCH][next] platform/chrome: wilco_ec: fix null pointer dereference on failed kzalloc

2019-06-18 Thread Dan Carpenter
On Tue, Jun 18, 2019 at 04:39:24PM +0100, Colin King wrote: > diff --git a/drivers/platform/chrome/wilco_ec/event.c > b/drivers/platform/chrome/wilco_ec/event.c > index c975b76e6255..e251a989b152 100644 > --- a/drivers/platform/chrome/wilco_ec/event.c > +++ b/drivers/platform/chrome/wilco_ec/event

Re: [PATCHv5 10/20] PCI: mobiveil: Fix the INTx process errors

2019-06-18 Thread Karthikeyan Mitran
On Fri, Jun 14, 2019 at 4:14 PM Lorenzo Pieralisi wrote: > > On Fri, Jun 14, 2019 at 12:38:51PM +0530, Karthikeyan Mitran wrote: > > Hi Lorenzo and Hou Zhiqiang > > PAB_INTP_AMBA_MISC_STAT does have other status in the higher bits, it > > should have been masked before checking for the status > >

Re: [PATCH] mm: mempolicy: handle vma with unmovable pages mapped correctly in mbind

2019-06-18 Thread Michal Hocko
On Tue 18-06-19 14:13:16, Yang Shi wrote: [...] > > > > > Change migrate_page_add() to check if the page is movable or not, if > > > > > it > > > > > is unmovable, just return -EIO. We don't have to check non-LRU > > > > > movable > > > > > pages since just zsmalloc and virtio-baloon support thi

[PATCH 5/8] mm: Start fallback top-down mmap at mm->mmap_base

2019-06-18 Thread Alexandre Ghiti
In case of mmap failure in top-down mode, there is no need to go through the whole address space again for the bottom-up fallback: the goal of this fallback is to find, as a last resort, space between the top-down mmap base and the stack, which is the only place not covered by the top-down mmap. S

Re: [PATCH 4/7] powerpc/ftrace: Additionally nop out the preceding mflr with -mprofile-kernel

2019-06-18 Thread Michael Ellerman
Hi Naveen, Sorry I meant to reply to this earlier .. :/ "Naveen N. Rao" writes: > With -mprofile-kernel, gcc emits 'mflr r0', followed by 'bl _mcount' to > enable function tracing and profiling. So far, with dynamic ftrace, we > used to only patch out the branch to _mcount(). However, mflr is >

[PATCH 4/8] x86, hugetlbpage: Start fallback of top-down mmap at mm->mmap_base

2019-06-18 Thread Alexandre Ghiti
In case of mmap failure in top-down mode, there is no need to go through the whole address space again for the bottom-up fallback: the goal of this fallback is to find, as a last resort, space between the top-down mmap base and the stack, which is the only place not covered by the top-down mmap. S

RE: [PATCH] net: stmmac: add sanity check to device_property_read_u32_array call

2019-06-18 Thread Martin Blumenstingl
Hi Colin, > Currently the call to device_property_read_u32_array is not error checked > leading to potential garbage values in the delays array that are then used > in msleep delays. Add a sanity check to the property fetching. > > Addresses-Coverity: ("Uninitialized scalar variable") > Signed-o

[PATCH 3/8] sparc: Start fallback of top-down mmap at mm->mmap_base

2019-06-18 Thread Alexandre Ghiti
In case of mmap failure in top-down mode, there is no need to go through the whole address space again for the bottom-up fallback: the goal of this fallback is to find, as a last resort, space between the top-down mmap base and the stack, which is the only place not covered by the top-down mmap. S

Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-06-18 Thread Kishon Vijay Abraham I
Hi Lorenzo, On 18/06/19 7:58 PM, Lorenzo Pieralisi wrote: > On Tue, Jun 18, 2019 at 04:21:17PM +0530, Vidya Sagar wrote: > > [...] > >>> 2) It is not related to this patch but I fail to see the reasoning >>> behind the __ in __dw_pci_read_dbi(), there is no no-underscore >>> equivalent s

[PATCH 2/8] sh: Start fallback of top-down mmap at mm->mmap_base

2019-06-18 Thread Alexandre Ghiti
In case of mmap failure in top-down mode, there is no need to go through the whole address space again for the bottom-up fallback: the goal of this fallback is to find, as a last resort, space between the top-down mmap base and the stack, which is the only place not covered by the top-down mmap. S

[PATCH 1/8] s390: Start fallback of top-down mmap at mm->mmap_base

2019-06-18 Thread Alexandre Ghiti
In case of mmap failure in top-down mode, there is no need to go through the whole address space again for the bottom-up fallback: the goal of this fallback is to find, as a last resort, space between the top-down mmap base and the stack, which is the only place not covered by the top-down mmap. S

[PATCH 0/8] Fix mmap base in bottom-up mmap

2019-06-18 Thread Alexandre Ghiti
This series fixes the fallback of the top-down mmap: in case of failure, a bottom-up scheme can be tried as a last resort between the top-down mmap base and the stack, hoping for a large unused stack limit. Lots of architectures and even mm code start this fallback at TASK_UNMAPPED_BASE, which is

Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2019-06-18 Thread Naga Sureshkumar Relli
On Mon, Jan 28, 2019 at 10:27:39AM +0100, Miquel Raynal wrote: Hi Miquel, > Hi Naga, > > Naga Sureshkumar Relli wrote on Mon, 28 Jan 2019 > 06:04:53 +: > > > Hi Boris & Miquel, > > > > Could you please provide your thoughts on this driver to support HW-ECC? > > As I said previously, there

[GIT PULL] ARM: TI SOC updates for v5.3

2019-06-18 Thread Santosh Shilimkar
The following changes since commit cd6c84d8f0cdc911df435bb075ba22ce3c605b07: Linux 5.2-rc2 (2019-05-26 16:49:19 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git tags/drivers_soc_for_5.3 for you to fetch changes up to 4

Re: [PATCH 5.1 000/115] 5.1.12-stable review

2019-06-18 Thread Naresh Kamboju
On Tue, 18 Jun 2019 at 19:05, Greg Kroah-Hartman wrote: > > On Tue, Jun 18, 2019 at 06:04:25PM +0530, Naresh Kamboju wrote: > > On Tue, 18 Jun 2019 at 02:50, Greg Kroah-Hartman > > wrote: > > > > > > This is the start of the stable review cycle for the 5.1.12 release. > > > There are 115 patches

Re: [PATCH v3 -next] firmware: ti_sci: Fix gcc unused-but-set-variable warning

2019-06-18 Thread santosh.shilim...@oracle.com
On 6/17/19 11:41 AM, Suman Anna wrote: On 6/15/19 7:50 AM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_config: drivers/firmware/ti_sci.c:2035:17: warning: variable dev set but not used [-Wunused-but-set-variable] drive

Re: [PATCH] firmware: ti_sci: Use the correct style for SPDX License Identifier

2019-06-18 Thread santosh.shilim...@oracle.com
On 6/14/19 6:57 AM, Nishad Kamdar wrote: This patch corrects the SPDX License Identifier style in header file related to Firmware Drivers for Texas Instruments SCI Protocol. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ st

Re: [PATCH v2 1/1] cpuidle-powernv : forced wakeup for stop states

2019-06-18 Thread Nicholas Piggin
Abhishek Goel's on June 17, 2019 7:56 pm: > Currently, the cpuidle governors determine what idle state a idling CPU > should enter into based on heuristics that depend on the idle history on > that CPU. Given that no predictive heuristic is perfect, there are cases > where the governor predicts a s

[PATCH 0/1] One cleanup patch for FPGA

2019-06-18 Thread Moritz Fischer
Hi Greg, please take this cleanup patch. It's been on the list but somehow fell through the cracks. Thanks, Moritz Enrico Weigelt (1): drivers: fpga: Kconfig: pedantic cleanups drivers/fpga/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.22.0

[PATCH 1/1] drivers: fpga: Kconfig: pedantic cleanups

2019-06-18 Thread Moritz Fischer
From: Enrico Weigelt Formatting of Kconfig files doesn't look so pretty, so just take damp cloth and clean it up. Signed-off-by: Enrico Weigelt Signed-off-by: Moritz Fischer --- drivers/fpga/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/fpga/Kconfig

[PATCH V6 1/3] mm/hotplug: Reorder memblock_[free|remove]() calls in try_remove_memory()

2019-06-18 Thread Anshuman Khandual
Memory hot remove uses get_nid_for_pfn() while tearing down linked sysfs entries between memory block and node. It first checks pfn validity with pfn_valid_within() before fetching nid. With CONFIG_HOLES_IN_ZONE config (arm64 has this enabled) pfn_valid_within() calls pfn_valid(). pfn_valid() is a

[PATCH V6 3/3] arm64/mm: Enable memory hot remove

2019-06-18 Thread Anshuman Khandual
The arch code for hot-remove must tear down portions of the linear map and vmemmap corresponding to memory being removed. In both cases the page tables mapping these regions must be freed, and when sparse vmemmap is in use the memory backing the vmemmap must also be freed. This patch adds a new re

[PATCH V6 2/3] arm64/mm: Hold memory hotplug lock while walking for kernel page table dump

2019-06-18 Thread Anshuman Khandual
The arm64 page table dump code can race with concurrent modification of the kernel page tables. When a leaf entries are modified concurrently, the dump code may log stale or inconsistent information for a VA range, but this is otherwise not harmful. When intermediate levels of table are freed, the

[PATCH V6 0/3] arm64/mm: Enable memory hot remove

2019-06-18 Thread Anshuman Khandual
This series enables memory hot remove on arm64 after fixing a memblock removal ordering problem in generic try_remove_memory() and a possible arm64 platform specific kernel page table race condition. This series is based on linux-next (next-20190613). Concurrent vmalloc() and hot-remove conflict:

Re: linux-next: build failure after merge of the net-next tree

2019-06-18 Thread Masahiro Yamada
On Wed, Jun 19, 2019 at 1:02 PM Masahiro Yamada wrote: > > Hi. > > > On Wed, Jun 19, 2019 at 12:23 PM Stephen Rothwell > wrote: > > > > Hi all, > > > > After merging the net-next tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > In file included from usr/include/

Re: linux-next: build failure after merge of the net-next tree

2019-06-18 Thread Masahiro Yamada
Hi. On Wed, Jun 19, 2019 at 12:23 PM Stephen Rothwell wrote: > > Hi all, > > After merging the net-next tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from usr/include/linux/tc_act/tc_ctinfo.hdrtest.c:1: > ./usr/include/linux/tc_act/tc_ctinfo.h:30:2

Re: [PATCH v9 03/12] mm/hotplug: Prepare shrink_{zone, pgdat}_span for sub-section removal

2019-06-18 Thread Dan Williams
On Mon, Jun 17, 2019 at 6:42 PM Wei Yang wrote: > > On Wed, Jun 05, 2019 at 02:58:04PM -0700, Dan Williams wrote: > >Sub-section hotplug support reduces the unit of operation of hotplug > >from section-sized-units (PAGES_PER_SECTION) to sub-section-sized units > >(PAGES_PER_SUBSECTION). Teach shri

Re: [PATCH] scsi: scsi_sysfs.c: Hide wwid sdev attr if VPD is not supported

2019-06-18 Thread Martin K. Petersen
Marcos, > WWID composed from VPD data from device, specifically page 0x83. So, > when a device does not have VPD support, for example USB storage > devices where VPD is specifically disabled, a read into device>/device/wwid file will always return ENXIO. To avoid this, > change the scsi_sdev_at

linux-next: build failure after merge of the net-next tree

2019-06-18 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from usr/include/linux/tc_act/tc_ctinfo.hdrtest.c:1: ./usr/include/linux/tc_act/tc_ctinfo.h:30:21: error: implicit declaration of function 'BIT' [-Werror=implicit-function-d

Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade

2019-06-18 Thread Martin K. Petersen
Marcos, > Currently, all USB devices skip VPD pages, even when the device > supports them (SPC-3 and later), but some of them support VPD, like > Cruzer Blade. What's your confidence level wrt. all Cruzer Blades handling this correctly? How many devices have you tested this change with? -- Ma

Re: [PATCH v9 02/12] mm/sparsemem: Add helpers track active portions of a section at boot

2019-06-18 Thread Dan Williams
On Mon, Jun 17, 2019 at 3:32 PM Dan Williams wrote: > > On Mon, Jun 17, 2019 at 3:22 PM Wei Yang wrote: > > > > On Wed, Jun 05, 2019 at 02:57:59PM -0700, Dan Williams wrote: > > >Prepare for hot{plug,remove} of sub-ranges of a section by tracking a > > >sub-section active bitmask, each bit repres

Re: [PATCH] scsi: fdomain: fix building pcmcia front-end

2019-06-18 Thread Martin K. Petersen
Arnd, > Move the common support outside of the SCSI_LOWLEVEL section. > Alternatively, we could move all of SCSI_LOWLEVEL_PCMCIA into > SCSI_LOWLEVEL. This would be more sensible, but might cause surprises > for users that have SCSI_LOWLEVEL disabled. It seems messy to me that PCMCIA lives outs

Re: "mm: reparent slab memory on cgroup removal" series triggers SLUB_DEBUG errors

2019-06-18 Thread Roman Gushchin
On Tue, Jun 18, 2019 at 05:43:04PM -0400, Qian Cai wrote: > Booting linux-next on both arm64 and powerpc triggers SLUB_DEBUG errors > below. Reverted the whole series “mm: reparent slab memory on cgroup removal” > [1] fixed the issue. Hi Qian! Thank you for the report! Didn't you try to reprod

Re: [RFC net-next 1/5] net: stmmac: introduce IEEE 802.1Qbv configuration functionalities

2019-06-18 Thread Andrew Lunn
On Wed, Jun 19, 2019 at 05:36:14AM +0800, Voon Weifeng wrote: Hi Voon > +static int est_poll_srwo(void *ioaddr) > +{ > + /* Poll until the EST GCL Control[SRWO] bit clears. > + * Total wait = 12 x 50ms ~= 0.6s. > + */ > + unsigned int retries = 12; > + unsigned int value; >

Re: [RFC PATCH 16/16] xen/grant-table: host_addr fixup in mapping on xenhost_r0

2019-06-18 Thread Ankur Arora
On 6/17/19 3:55 AM, Juergen Gross wrote: On 09.05.19 19:25, Ankur Arora wrote: Xenhost type xenhost_r0 does not support standard GNTTABOP_map_grant_ref semantics (map a gref onto a specified host_addr). That's because since the hypervisor is local (same address space as the caller of GNTTABOP_ma

Re: [RFC PATCH 14/16] xen/blk: gnttab, evtchn, xenbus API changes

2019-06-18 Thread Ankur Arora
On 6/17/19 3:14 AM, Juergen Gross wrote: On 09.05.19 19:25, Ankur Arora wrote: For the most part, we now pass xenhost_t * as a parameter. Co-developed-by: Joao Martins Signed-off-by: Ankur Arora I don't see how this can be a patch on its own. Yes, the reason this was separate was that give

Re: [RFC PATCH 13/16] drivers/xen: gnttab, evtchn, xenbus API changes

2019-06-18 Thread Ankur Arora
On 6/17/19 3:07 AM, Juergen Gross wrote: On 09.05.19 19:25, Ankur Arora wrote: Mechanical changes, now most of these calls take xenhost_t * as parameter. Co-developed-by: Joao Martins Signed-off-by: Ankur Arora ---   drivers/xen/cpu_hotplug.c | 14 ++---   drivers/xen/gntalloc.c   

Re: [PATCH 1/1] scsi: ufs-qcom: Add support for platforms booting ACPI

2019-06-18 Thread Martin K. Petersen
Lee, > New Qualcomm AArch64 based laptops are now available which use UFS > as their primary data storage medium. These devices are supplied > with ACPI support out of the box. This patch ensures the Qualcomm > UFS driver will be bound when the "QCOM24A5" H/W device is > advertised as present.

  1   2   3   4   5   6   7   8   9   10   >