Re: [PATCH 3/5] x86: Kconfig: Remove CONFIG_NODES_SPAN_OTHER_NODES

2019-07-09 Thread Thomas Gleixner
Hoan, On Wed, 10 Jul 2019, Hoan Tran OS wrote: > On 6/25/19 3:45 PM, Thomas Gleixner wrote: > > On Tue, 25 Jun 2019, Hoan Tran OS wrote: > >> @@ -1567,15 +1567,6 @@ config X86_64_ACPI_NUMA > >>---help--- > >> Enable ACPI SRAT based node topology detection. > >> > >> -# Some NUMA nodes

Reminder: 5 open syzbot bugs in lockdep subsystem

2019-07-09 Thread Eric Biggers
[This email was generated by a script. Let me know if you have any suggestions to make it better, or if you want it re-generated with the latest status.] Of the currently open syzbot reports against the upstream kernel, I've manually marked 5 of them as possibly being bugs in the lockdep

Re: [PATCH v2] net/mlx5e: Refactor switch statements to avoid using uninitialized variables

2019-07-09 Thread Nathan Chancellor
On Tue, Jul 09, 2019 at 10:36:57PM -0700, David Miller wrote: > > I applied your simpler addition of the return statement so that I could > get the net-next pull request out tonight, just FYI... Thanks for the heads up, I'll spin up a v3 just focusing on the refactoring. Cheers, Nathan

Re: Coccinelle: Checking the deletion of duplicate of_node_put() calls with SmPL

2019-07-09 Thread Markus Elfring
> But I wonder at the moment why it does not work (as expected) for the original > complete source file. I discovered that a diff hunk (or usable patch?) is generated if the return statement is deleted (or commented out) before the jump label which refers to a potentially unwanted function call

Re: [PATCH v3 0/3] kernel/notifier.c: avoid duplicate registration

2019-07-09 Thread Greg KH
On Wed, Jul 10, 2019 at 11:09:07AM +0800, Xiaoming Ni wrote: > Registering the same notifier to a hook repeatedly can cause the hook > list to form a ring or lose other members of the list. Then don't do that :) Is there any in-kernel users that do do this? If so, please just fix them. thanks,

Re: [PATCH v2 00/11] FPGA DFL updates

2019-07-09 Thread Greg KH
On Wed, Jul 10, 2019 at 01:07:46PM +0800, Wu Hao wrote: > On Fri, Jul 05, 2019 at 08:23:47AM +0800, Wu Hao wrote: > > Hi Greg / Moritz > > > > This is v2 patchset which adds more features to FPGA DFL. This patchset > > is made on top of patch[1] and char-misc-next tree. Documentation patch > >

Re: [PATCH v3 0/3] kernel/notifier.c: avoid duplicate registration

2019-07-09 Thread Vasily Averin
On 7/10/19 6:09 AM, Xiaoming Ni wrote: > Registering the same notifier to a hook repeatedly can cause the hook > list to form a ring or lose other members of the list. I think is not enough to _prevent_ 2nd register attempt, it's enough to detect just attempt and generate warning to mark host in

Re: [GIT PULL] scheduler changes for v5.3

2019-07-09 Thread John Stultz
On Mon, Jul 8, 2019 at 9:33 AM Ingo Molnar wrote: > Please pull the latest sched-core-for-linus git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-core-for-linus > Peter Zijlstra (1): > sched/core: Optimize try_to_wake_up() for local wakeups Hey

Re: [PATCH v2] net/mlx5e: Refactor switch statements to avoid using uninitialized variables

2019-07-09 Thread David Miller
I applied your simpler addition of the return statement so that I could get the net-next pull request out tonight, just FYI...

Re: [GIT PULL] x86/topology changes for v5.3

2019-07-09 Thread Kees Cook
On Tue, Jul 09, 2019 at 10:15:21PM -0700, Linus Torvalds wrote: > On Tue, Jul 9, 2019 at 8:21 PM Linus Torvalds > wrote: > > > > Whee. It looks like it's bisecting to the same thing. Only partway > > done, but it feels very much like my desktop. > > Confirmed. > > With that config, I get this >

[PATCH] platform/x86: hp_accel: Add support for HP ZBook 17 G5

2019-07-09 Thread Kai-Heng Feng
HP ZBook 17 G5 needs a non-standard mapping, x_inverted. Signed-off-by: Kai-Heng Feng --- drivers/platform/x86/hp_accel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c index f61b8a176e20..cfc0e36a7a5e 100644 ---

Re: BUG: MAX_STACK_TRACE_ENTRIES too low! (2)

2019-07-09 Thread Eric Biggers
[Moved most people to Bcc; syzbot added way too many random people to this.] Hi Bart, On Sat, Mar 30, 2019 at 07:17:09PM -0700, Bart Van Assche wrote: > On 3/30/19 2:58 PM, syzbot wrote: > > syzbot has bisected this bug to: > > > > commit 669de8bda87b92ab9a2fc663b3f5743c2ad1ae9f > > Author:

Re: [PATCH v3 30/30] locking/lockdep: Remove irq-safe to irq-unsafe read check

2019-07-09 Thread Boqun Feng
On Fri, Jun 28, 2019 at 05:15:28PM +0800, Yuyang Du wrote: > We have a lockdep warning: > > > WARNING: possible irq lock inversion dependency detected > 5.1.0-rc7+ #141 Not tainted >

Re: [PATCH v2] nvme: fix multipath crash when ANA desactivated

2019-07-09 Thread Marta Rybczynska
- On 9 Jul, 2019, at 23:29, Christoph Hellwig h...@lst.de wrote: > On Sat, Jul 06, 2019 at 01:06:44PM +0300, Max Gurtovoy wrote: >>> + /* check if multipath is enabled and we have the capability */ >>> + if (!multipath) >>> + return 0; >>> + if (!ctrl->subsys ||

Re: [PATCH] sound: soc: codecs: mt6358: change return type of mt6358_codec_init_reg

2019-07-09 Thread Tzung-Bi Shih
On Wed, Jul 10, 2019 at 2:25 AM Hariprasad Kelam wrote: > > As mt6358_codec_init_reg function always returns 0 , change return type > from int to void. > > fixes below issue reported by coccicheck > sound/soc/codecs/mt6358.c:2260:5-8: Unneeded variable: "ret". Return "0" > on line 2289 > >

Re: [PATCH v2 00/11] FPGA DFL updates

2019-07-09 Thread Wu Hao
On Fri, Jul 05, 2019 at 08:23:47AM +0800, Wu Hao wrote: > Hi Greg / Moritz > > This is v2 patchset which adds more features to FPGA DFL. This patchset > is made on top of patch[1] and char-misc-next tree. Documentation patch > for DFL is dropped from this patchset, and will resubmit it later to >

[git pull] m68knommu changes for v5.3

2019-07-09 Thread Greg Ungerer
Hi Linus, Can you please pull the m68knommu git tree, for-next branch. A series of cleanups for the FLAT format binary loader, binfmt_flat, from Christoph. The end goal is to support no-MMU on RISC-V, and the last patch enables that. Regards Greg The following changes since commit

Re: [PATCH v2] net/mlx5e: Refactor switch statements to avoid using uninitialized variables

2019-07-09 Thread Leon Romanovsky
On Tue, Jul 09, 2019 at 09:47:49PM -0700, Nathan Chancellor wrote: > clang warns: > > drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c:251:2: > warning: variable 'rec_seq_sz' is used uninitialized whenever switch > default is taken [-Wsometimes-uninitialized] > default: >

Re: linux-next: build failure after merge of the net-next tree

2019-07-09 Thread Leon Romanovsky
On Wed, Jul 10, 2019 at 02:31:58PM +1000, Stephen Rothwell wrote: > Hi Leon, > > On Tue, 9 Jul 2019 09:43:46 +0300 Leon Romanovsky wrote: > > > > From 56c9e15ec670af580daa8c3ffde9503af3042d67 Mon Sep 17 00:00:00 2001 > > From: Leon Romanovsky > > Date: Sun, 7 Jul 2019 10:43:42 +0300 > > Subject:

Re: [PATCH V12 01/12] PCI: Add #defines for some of PCIe spec r4.0 features

2019-07-09 Thread Vidya Sagar
On 7/9/2019 7:44 PM, Bjorn Helgaas wrote: On Mon, Jul 01, 2019 at 06:09:59PM +0530, Vidya Sagar wrote: Add #defines only for the Data Link Feature and Physical Layer 16.0 GT/s features. Signed-off-by: Vidya Sagar Reviewed-by: Thierry Reding Please include spec references in the commit log,

Re: [PATCH v3 17/30] locking/lockdep: Add read-write type for a lock dependency

2019-07-09 Thread Boqun Feng
On Fri, Jun 28, 2019 at 05:15:15PM +0800, Yuyang Du wrote: > Direct dependencies need to keep track of their read-write lock types. > Two bit fields, which share the distance field, are added to lock_list > struct so the types are stored there. > > With a dependecy lock1 -> lock2, lock_type1 has

Re: [GIT PULL] x86/topology changes for v5.3

2019-07-09 Thread Linus Torvalds
On Tue, Jul 9, 2019 at 8:21 PM Linus Torvalds wrote: > > Whee. It looks like it's bisecting to the same thing. Only partway > done, but it feels very much like my desktop. Confirmed. With that config, I get this c21ac93288f0 (refs/bisect/bad) Merge tag 'v5.2-rc6' into x86/asm, to refresh the

[PATCH] ARM: stm32: use "depends on" instead of "if" after prompt

2019-07-09 Thread Masahiro Yamada
This appeared after the global fixups by commit e32465429490 ("ARM: use "depends on" for SoC configs instead of "if" after prompt"). Fix it now. Signed-off-by: Masahiro Yamada --- arch/arm/mach-stm32/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

RE: [PATCH 09/12] rtw88: Fix misuse of GENMASK macro

2019-07-09 Thread Tony Chuang
> Subject: [PATCH 09/12] rtw88: Fix misuse of GENMASK macro > > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches > --- > drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH 08/12] net: stmmac: Fix misuses of GENMASK macro

2019-07-09 Thread Joe Perches
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- drivers/net/ethernet/stmicro/stmmac/descs.h | 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 10/12] phy: amlogic: G12A: Fix misuse of GENMASK macro

2019-07-09 Thread Joe Perches
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- drivers/phy/amlogic/phy-meson-g12a-usb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c b/drivers/phy/amlogic/phy-meson-g12a-usb2.c index

[PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro

2019-07-09 Thread Joe Perches
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h b/drivers/gpu/drm/aspeed/aspeed_gfx.h index a10358bb61ec..095ea03e5833

[PATCH 05/12] irqchip/gic-v3-its: Fix misuse of GENMASK macro

2019-07-09 Thread Joe Perches
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 35500801dc2b..730fbe0e2a9d 100644 ---

Re: [PATCH v2 05/10] net: hisilicon: HI13X1_GMAX need dreq reset at first

2019-07-09 Thread Jiangfeng Xiao
On 2019/7/9 21:48, Jiangfeng Xiao wrote: > > > On 2019/7/9 17:35, Sergei Shtylyov wrote: >> Hello! >> >> On 09.07.2019 6:31, Jiangfeng Xiao wrote: >> [...] >>> @@ -853,6 +867,15 @@ static int hip04_mac_probe(struct platform_device >>> *pdev) >>> goto init_fail; >>> } >>>

[PATCH 11/12] staging: media: cedrus: Fix misuse of GENMASK macro

2019-07-09 Thread Joe Perches
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- drivers/staging/media/sunxi/cedrus/cedrus_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_regs.h

[PATCH 07/12] net: ethernet: mediatek: Fix misuses of GENMASK macro

2019-07-09 Thread Joe Perches
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 2 +- drivers/net/ethernet/mediatek/mtk_sgmii.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h

[PATCH 06/12] mmc: meson-mx-sdio: Fix misuse of GENMASK macro

2019-07-09 Thread Joe Perches
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- drivers/mmc/host/meson-mx-sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c index 2d736e416775..ba9a63db73da 100644 ---

[PATCH 09/12] rtw88: Fix misuse of GENMASK macro

2019-07-09 Thread Joe Perches
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c b/drivers/net/wireless/realtek/rtw88/rtw8822b.c

[PATCH 04/12] iio: adc: max9611: Fix misuse of GENMASK macro

2019-07-09 Thread Joe Perches
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- drivers/iio/adc/max9611.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c index 917223d5ff5b..0e3c6529fc4c 100644 ---

[PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-09 Thread Joe Perches
These GENMASK uses are inverted argument order and the actual masks produced are incorrect. Fix them. Add checkpatch tests to help avoid more misuses too. Joe Perches (12): checkpatch: Add GENMASK tests clocksource/drivers/npcm: Fix misuse of GENMASK macro drm: aspeed_gfx: Fix misuse of

[PATCH 12/12] ASoC: wcd9335: Fix misuse of GENMASK macro

2019-07-09 Thread Joe Perches
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- sound/soc/codecs/wcd-clsh-v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wcd-clsh-v2.c b/sound/soc/codecs/wcd-clsh-v2.c index c397d713f01a..cc5a9c9b918b 100644 ---

[PATCH 01/12] checkpatch: Add GENMASK tests

2019-07-09 Thread Joe Perches
This macro is easy to misuse as it's odd argument order. If specified with simple decimal values, make sure the arguments are ordered high then low. Also check if any argument is > 32 where instead of GENMASK, GENMASK_ULL should be used. Signed-off-by: Joe Perches --- scripts/checkpatch.pl |

[PATCH 02/12] clocksource/drivers/npcm: Fix misuse of GENMASK macro

2019-07-09 Thread Joe Perches
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches --- drivers/clocksource/timer-npcm7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-npcm7xx.c b/drivers/clocksource/timer-npcm7xx.c index 7a9bb5532d99..8a30da7f083b

[PATCH v3 0/3] Powerpc64/Watchpoint: Few important fixes

2019-07-09 Thread Ravi Bangoria
v2: https://lists.ozlabs.org/pipermail/linuxppc-dev/2019-July/192967.html v2->v3: - Rebase to powerpc/next - PATCH 2/3 is new Ravi Bangoria (3): Powerpc64/Watchpoint: Fix length calculation for unaligned target Powerpc64/Watchpoint: Don't ignore extraneous exceptions

[PATCH v3 2/3] Powerpc64/Watchpoint: Don't ignore extraneous exceptions

2019-07-09 Thread Ravi Bangoria
On Powerpc64, watchpoint match range is double-word granular. On a watchpoint hit, DAR is set to the first byte of overlap between actual access and watched range. And thus it's quite possible that DAR does not point inside user specified range. Ex, say user creates a watchpoint with address range

[PATCH v3 1/3] Powerpc64/Watchpoint: Fix length calculation for unaligned target

2019-07-09 Thread Ravi Bangoria
Watchpoint match range is always doubleword(8 bytes) aligned on powerpc. If the given range is crossing doubleword boundary, we need to increase the length such that next doubleword also get covered. Ex, address len = 6 bytes |=.

[PATCH v3 3/3] Powerpc64/Watchpoint: Rewrite ptrace-hwbreak.c selftest

2019-07-09 Thread Ravi Bangoria
ptrace-hwbreak.c selftest is logically broken. On powerpc, when watchpoint is created with ptrace, signals are generated before executing the instruction and user has to manually singlestep the instruction with watchpoint disabled, which selftest never does and thus it keeps on getting the signal

[PATCH v2] net/mlx5e: Refactor switch statements to avoid using uninitialized variables

2019-07-09 Thread Nathan Chancellor
clang warns: drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c:251:2: warning: variable 'rec_seq_sz' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~ drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c:255:46:

Re: [PATCH] RDMA/siw: Print error code while kthread_create failed

2019-07-09 Thread Leon Romanovsky
On Wed, Jul 10, 2019 at 09:50:09AM +0800, YueHaibing wrote: > In iw_create_tx_threads(), if we failed to create kthread, > we should print the 'rv', this fix gcc warning: > > drivers/infiniband/sw/siw/siw_main.c: In function 'siw_create_tx_threads': > drivers/infiniband/sw/siw/siw_main.c:91:11:

Re: linux-next: build failure after merge of the net-next tree

2019-07-09 Thread Stephen Rothwell
Hi Leon, On Tue, 9 Jul 2019 09:43:46 +0300 Leon Romanovsky wrote: > > From 56c9e15ec670af580daa8c3ffde9503af3042d67 Mon Sep 17 00:00:00 2001 > From: Leon Romanovsky > Date: Sun, 7 Jul 2019 10:43:42 +0300 > Subject: [PATCH] Fixup to build SIW issue > > Signed-off-by: Leon Romanovsky I applied

Question about ARM FASTFPE

2019-07-09 Thread Masahiro Yamada
Hi. I have a question about the following code in arch/arm/Makefile: # Do we have FASTFPE? FASTFPE :=arch/arm/fastfpe ifeq ($(FASTFPE),$(wildcard $(FASTFPE))) FASTFPE_OBJ :=$(FASTFPE)/ endif Since arch/arm/fastfpe does not exist in the upstream tree, I guess this is a hook to compile

Re: linux-next: build failure after merge of the rdma tree

2019-07-09 Thread Stephen Rothwell
Hi all, On Wed, 10 Jul 2019 11:04:43 +1000 Stephen Rothwell wrote: > > On Tue, 9 Jul 2019 12:46:34 + Jason Gunthorpe wrote: > > > > It isn't quite enough to make the header compile stand alone, I'm > > adding this instead. > > > > From 37c1e072276b03b080eb24ff24c39080aeaf49ef Mon Sep 17

Re: [PATCH] net/mlx5e: Return in default case statement in tx_post_resync_params

2019-07-09 Thread Leon Romanovsky
On Tue, Jul 09, 2019 at 04:10:24PM -0700, Nathan Chancellor wrote: > On Tue, Jul 09, 2019 at 03:44:59PM -0700, Nick Desaulniers wrote: > > On Mon, Jul 8, 2019 at 4:13 PM Nathan Chancellor > > wrote: > > > > > > clang warns: > > > > > >

Re: [GIT PULL] Wimplicit-fallthrough patches for 5.3-rc1

2019-07-09 Thread Stephen Rothwell
Hi Gustavo, On Tue, 9 Jul 2019 13:20:10 -0500 "Gustavo A. R. Silva" wrote: > > Makefile: Globally enable fall-through warning (2019-07-08 15:23:22 -0500) There are still a few of these warnings in various builds. My x86_64 allmodconfig build after merging your tree into Linus' tree this

[RESEND PATCH 2/2] clk: imx8mm: rename 'share_count_dcss' to 'share_count_disp'

2019-07-09 Thread Fancy Fang
Rename 'share_count_dcss' to 'share_count_disp', since the DCSS module does not exist on imx8mm platform. So rename it to avoid any unnecessary confusion. Signed-off-by: Fancy Fang --- drivers/clk/imx/clk-imx8mm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[RESEND PATCH 1/2] clk: imx8mm: rename lcdif pixel clock

2019-07-09 Thread Fancy Fang
Rename 'lcdif' pixel clock related names to 'disp' names, since: First, the lcdif pixel clock is not supplied to LCDIF controller directly, but to some LPCG clock in display mix. So rename it to 'disp' pixel clock is more accurate. Second, in the imx8mn CCM specification which is designed after

Re: [PATCH 1/2] dt-bindings: milbeaut-m10v-hdmac: Add Socionext Milbeaut HDMAC bindings

2019-07-09 Thread Jassi Brar
On Tue, Jul 9, 2019 at 9:34 AM Rob Herring wrote: > > On Wed, Jun 12, 2019 at 07:52:37PM -0500, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > Document the devicetree bindings for Socionext Milbeaut HDMAC > > controller. Controller has upto 8 floating channels, that need > > a

Re: [PATCH v7 10/25] arm64: compat: Add vDSO

2019-07-09 Thread John Stultz
On Fri, Jun 21, 2019 at 3:18 AM Vincenzo Frascino wrote: > > Provide the arm64 compat (AArch32) vDSO in kernel/vdso32 in a similar > way to what happens in kernel/vdso. > > The compat vDSO leverages on an adaptation of the arm architecture code > with few changes: > - Use of lib/vdso for

[PATCH v2] gnss: core: added logging statement when kfifo_alloc fails

2019-07-09 Thread Keyur Patel
Added missing logging statement when kfifo_alloc fails, to improve debugging. Signed-off-by: Keyur Patel --- Changes in v2: - fixed braces --- drivers/gnss/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c index

Re: [PATCH] gnss: core: added logging statement when kfifo_alloc fails

2019-07-09 Thread Joe Perches
On Tue, 2019-07-09 at 19:14 -0400, Keyur Patel wrote: > Added missing logging statement when kfifo_alloc fails, to improve > debugging.\ Nack > diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c [] > @@ -256,6 +256,7 @@ struct gnss_device *gnss_allocate_device(struct device > *parent) > >

6 new syscalls without tests (was: [PATCH] vfs: move_mount: reject moving kernel internal mounts)

2019-07-09 Thread Eric Biggers
On Tue, Jul 09, 2019 at 09:54:24PM +0100, Al Viro wrote: > On Tue, Jul 09, 2019 at 12:40:01PM -0700, Eric Biggers wrote: > > On Tue, Jul 02, 2019 at 11:22:59AM -0700, Eric Biggers wrote: > > > > > > Sure, but the new mount syscalls still need tests. Where are the tests? > > > > > > > Still

[PATCH] gnss: core: added logging statement when kfifo_alloc fails

2019-07-09 Thread Keyur Patel
Added missing logging statement when kfifo_alloc fails, to improve debugging. Signed-off-by: Keyur Patel --- drivers/gnss/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c index e6f94501cb28..4377adfa25b4 100644 --- a/drivers/gnss/core.c +++

[PATCH] fixup! kbuild: remove obj and src from the top Makefile

2019-07-09 Thread Masahiro Yamada
Merging today's kbuild tree would break arc, um, parisc. I just noticed it now. I will fix it soon for tomorrow's linux-next. If needed, this might be useful for today's linux-next. Signed-off-by: Masahiro Yamada --- arch/arc/Makefile| 2 +- arch/parisc/Makefile | 12 ++--

[PATCH v3 3/3] kernel/notifier.c: remove blocking_notifier_chain_cond_register()

2019-07-09 Thread Xiaoming Ni
blocking_notifier_chain_cond_register() does not consider system_booting state, which is the only difference between this function and blocking_notifier_cain_register(). This can be a bug and is a piece of duplicate code. Delete blocking_notifier_chain_cond_register() Signed-off-by: Xiaoming Ni

[PATCH v3 1/3] kernel/notifier.c: avoid duplicate registration

2019-07-09 Thread Xiaoming Ni
Registering the same notifier to a hook repeatedly can cause the hook list to form a ring or lose other members of the list. case1: An infinite loop in notifier_chain_register() can cause soft lockup atomic_notifier_chain_register(_notifier_list, );

[PATCH v3 2/3] kernel/notifier.c: remove notifier_chain_cond_register()

2019-07-09 Thread Xiaoming Ni
The only difference between notifier_chain_cond_register() and notifier_chain_register() is the lack of warning hints for duplicate registrations. Consider using notifier_chain_register() instead of notifier_chain_cond_register() to avoid duplicate code Signed-off-by: Xiaoming Ni ---

[PATCH v3 0/3] kernel/notifier.c: avoid duplicate registration

2019-07-09 Thread Xiaoming Ni
Registering the same notifier to a hook repeatedly can cause the hook list to form a ring or lose other members of the list. case1: An infinite loop in notifier_chain_register() can cause soft lockup atomic_notifier_chain_register(_notifier_list, );

Re: [PATCH v2 2/3] ata: make qc_prep return an int

2019-07-09 Thread Jens Axboe
On 7/9/19 4:02 AM, Jiri Slaby wrote: > In case a driver wants to return an error. sata_mv is one of those -- > see the next patch. Not against the change as such, but there seems to be some confusion on int vs enum ata_completion_errors. The latter is probably poorly named if you're going to

[PATCH] input: touchscreen: add delay time to device power on

2019-07-09 Thread crag0715
From: "Crag.Wang" Delay time for MELFAS MIP4 controller is required at power on stage regardless the existence of GPIO consumer lookup from devicetree or ACPI device table. There is an issue if GPIO ce is undefined in the ACPI results no delay time for deive power on, the controller ended up in

Re: kprobes sanity test fails on next-20190708

2019-07-09 Thread Masami Hiramatsu
On Tue, 9 Jul 2019 11:40:45 -0400 Steven Rostedt wrote: > On Tue, 9 Jul 2019 16:37:55 +0100 > Mark Rutland wrote: > > > > I agree. I pushed to my repo in the for-next branch. Care to test that? > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git > > > > I've

[patch] x86/boot: Fix memory leak in default_get_smp_config()

2019-07-09 Thread David Rientjes
When default_get_smp_config() is called with early == 1 and mpf->feature1 is non-zero, mpf is leaked because the return path does not do early_memunmap(). Fix this and share a common exit routine. Fixes: 5997efb96756 ("x86/boot: Use memremap() to map the MPF and MPC data") Reported-by: Cfir

[PATCH 0/3] dynamically alloc AHB memory

2019-07-09 Thread han . xu
From: Han Xu i.MX platforms reserved 256M memory area for FSPI/QSPI AHB memory, it may failed to alloc all of them at once on some platforms. These patches allow the controller alloc AHB as needed. i.MX7D RX FIFO should be 128B rather than 512B. Han Xu (3): spi: spi-nxp-fspi: dynamically

[PATCH 3/3] spi: spi-fsl-qspi: dynamically alloc AHB memory for QSPI

2019-07-09 Thread han . xu
From: Han Xu dynamically alloc AHB memory for QSPI controller. Signed-off-by: Han Xu --- drivers/spi/spi-fsl-qspi.c | 58 +++--- 1 file changed, 42 insertions(+), 16 deletions(-) diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c index

[PATCH 1/3] spi: spi-nxp-fspi: dynamically alloc AHB memory for FSPI

2019-07-09 Thread han . xu
From: Han Xu dynamically alloc AHB memory for FSPI controller Signed-off-by: Han Xu --- drivers/spi/spi-nxp-fspi.c | 39 ++ 1 file changed, 31 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index

[PATCH 2/3] spi: spi-fsl-qspi: change i.MX7D RX FIFO size

2019-07-09 Thread han . xu
From: Han Xu The RX FIFO should be 128 byte rather than 512 byte. It's a typo on reference manual. Signed-off-by: Han Xu --- drivers/spi/spi-fsl-qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-qspi.c b/drivers/spi/spi-fsl-qspi.c index

[PATCH] sound: ppc: snd_ps3: Remove Unneeded variable: "ret"

2019-07-09 Thread Hariprasad Kelam
This patch fixes below issue reported by coccicheck sound/ppc/snd_ps3.c:631:5-8: Unneeded variable: "ret". Return "0" on line 668 We cannot change return type of snd_ps3_pcm_trigger as it is registered with snd_pcm_ops->trigger Signed-off-by: Hariprasad Kelam --- sound/ppc/snd_ps3.c | 3 +-- 1

[PATCH] sound: pci: lx6464es: Remove unneeded variable err

2019-07-09 Thread Hariprasad Kelam
This patch fixes below issue reported by coccicheck sound/pci/lx6464es/lx6464es.c:256:5-8: Unneeded variable: "err". Return "0" on line 258 We cannot change return value as its registered with snd_pcm_ops->close Signed-off-by: Hariprasad Kelam --- sound/pci/lx6464es/lx6464es.c | 3 +-- 1 file

RE: [EXT] Re: [PATCH nvmem 1/1] nvmem: imx: correct the fuse word index

2019-07-09 Thread Andy Duan
From: Andy Duan Sent: Friday, July 5, 2019 3:33 PM > From: Lothar Waßmann Sent: Friday, July 5, 2019 > 3:13 PM > > Hi, > > > > On Fri, 5 Jul 2019 02:46:32 + Andy Duan wrote: > > > From: Andy Duan Sent: Friday, July 5, 2019 12:08 AM > > > > From: Lothar Waßmann Sent: Thursday, > July > > > >

Re: [RFC v2] vhost: introduce mdev based hardware vhost backend

2019-07-09 Thread Jason Wang
On 2019/7/9 下午2:33, Tiwei Bie wrote: On Tue, Jul 09, 2019 at 10:50:38AM +0800, Jason Wang wrote: On 2019/7/8 下午2:16, Tiwei Bie wrote: On Fri, Jul 05, 2019 at 08:49:46AM -0600, Alex Williamson wrote: On Thu, 4 Jul 2019 14:21:34 +0800 Tiwei Bie wrote: On Thu, Jul 04, 2019 at 12:31:48PM

[Patch v2] sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag

2019-07-09 Thread Hariprasad Kelam
Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq handler finished". fixes below issue reported by coccicheck sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Signed-off-by: Hariprasad Kelam --- v1 : add

Re: [linux,dev-5.1 v1] dt-bindings: gpio: aspeed: Add SGPIO support

2019-07-09 Thread Andrew Jeffery
On Thu, 4 Jul 2019, at 05:31, Hongwei Zhang wrote: > Add bindings to support SGPIO on AST2400 or AST2500. > > Signed-off-by: Hongwei Zhang > --- > .../devicetree/bindings/gpio/sgpio-aspeed.txt | 36 > ++ > 1 file changed, 36 insertions(+) > create mode 100644

Re: [PATCH v6 4/4] x86/xen: Add "nopv" support for HVM guest

2019-07-09 Thread Zhenzhong Duan
On 2019/7/9 22:54, Boris Ostrovsky wrote: On 7/9/19 12:20 AM, Zhenzhong Duan wrote: -const __initconst struct hypervisor_x86 x86_hyper_xen_hvm = { +static uint32_t __init xen_platform_hvm(void) +{ +   uint32_t xen_domain = xen_cpuid_base(); +   struct x86_hyper_init *h =

Re: [PATCH RFC] gpio: Add Virtual Aggregator GPIO Driver

2019-07-09 Thread Phil Reid
G'day Geert, On 6/07/2019 00:05, Geert Uytterhoeven wrote: GPIO controllers are exported to userspace using /dev/gpiochip* character devices. Access control to these devices is provided by standard UNIX file system permissions, on an all-or-nothing basis: either a GPIO controller is accessible

Re: [alsa-devel] [PATCH] sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag

2019-07-09 Thread Hariprasad Kelam
On Fri, Jul 05, 2019 at 10:10:06PM +0200, Ladislav Michl wrote: > On Fri, Jul 05, 2019 at 12:40:26AM +0530, Hariprasad Kelam wrote: > > Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq > > handler finished". > > > > fixes below issue reported by coccicheck > > > >

Re: [linux,dev-5.1 v1] dt-bindings: gpio: aspeed: Add SGPIO support

2019-07-09 Thread Andrew Jeffery
On Wed, 10 Jul 2019, at 04:23, Rob Herring wrote: > On Wed, Jul 3, 2019 at 2:01 PM Hongwei Zhang wrote: > > > > Add bindings to support SGPIO on AST2400 or AST2500. > > > > Signed-off-by: Hongwei Zhang > > --- > > .../devicetree/bindings/gpio/sgpio-aspeed.txt | 36 > >

Re: [PATCH v3 00/30] Support recursive-read lock deadlock detection

2019-07-09 Thread Yuyang Du
Ping. Thanks. On Fri, 28 Jun 2019 at 17:15, Yuyang Du wrote: > > Hi Peter and Ingo, > > Historically, the recursive-read lock is not well supported in lockdep. > This patchset attempts to solve this problem sound and complete. > > The bulk of the algorithm is in patch #27. Now that the

[PATCH] RDMA/siw: Print error code while kthread_create failed

2019-07-09 Thread YueHaibing
In iw_create_tx_threads(), if we failed to create kthread, we should print the 'rv', this fix gcc warning: drivers/infiniband/sw/siw/siw_main.c: In function 'siw_create_tx_threads': drivers/infiniband/sw/siw/siw_main.c:91:11: warning: variable 'rv' set but not used [-Wunused-but-set-variable]

[PATCH -next] drm/amdgpu: remove duplicated include from gfx_v9_0.c

2019-07-09 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 5ba332376710..822f45161240 100644 ---

Re: [PATCH 1/2] KEYS: Replace uid/gid/perm permissions checking with an ACL

2019-07-09 Thread Eric Biggers
On Tue, Jul 09, 2019 at 06:16:01PM -0700, Eric Biggers wrote: > On Thu, May 23, 2019 at 04:58:27PM +0100, David Howells wrote: > > Replace the uid/gid/perm permissions checking on a key with an ACL to allow > > the SETATTR and SEARCH permissions to be split. This will also allow a > > greater

Re: next-20190705 - problems generating certs/x509_certificate_list

2019-07-09 Thread Eric Biggers
On Tue, Jul 09, 2019 at 01:17:14PM -0700, Eric Biggers wrote: > On Fri, Jul 05, 2019 at 11:44:18PM -0400, Valdis Klētnieks wrote: > > This worked fine in next-20190618, but in next-20190701 I'm seeing dmesg > > entries at boot: > > > > dmesg | grep -i x.509 > > [8.345699] Loading compiled-in

Re: [PATCH RESEND] mm: show number of vmalloc pages in /proc/meminfo

2019-07-09 Thread Roman Gushchin
On Tue, Jul 09, 2019 at 02:59:42PM +0900, Minchan Kim wrote: > Hi Roman, > > > On Wed, May 15, 2019 at 8:51 AM Roman Gushchin wrote: > > > > Vmalloc() is getting more and more used these days (kernel stacks, > > bpf and percpu allocator are new top users), and the total % > > of memory consumed

RE: [PATCH V4 2/5] clocksource/drivers/sysctr: Add clock-frequency property

2019-07-09 Thread Anson Huang
Hi, Rob > On Mon, Jul 1, 2019 at 3:47 AM wrote: > > > > From: Anson Huang > > 'dt-bindings: timer: ...' for the subject. OK, I made a mistake. > > > > > Systems which use platform driver model for clock driver require the > > clock frequency to be supplied via device tree when system

Re: [PATCH] mm/hmm: Fix bad subpage pointer in try_to_unmap_one

2019-07-09 Thread Ralph Campbell
On 7/9/19 5:28 PM, Andrew Morton wrote: On Tue, 9 Jul 2019 15:35:56 -0700 Ralph Campbell wrote: When migrating a ZONE device private page from device memory to system memory, the subpage pointer is initialized from a swap pte which computes an invalid page pointer. A kernel panic results

linux-next: manual merge of the iomap tree with Linus' tree

2019-07-09 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the iomap tree got a conflict in: fs/iomap.c between commits: 147a60538d91 ("iomap: use bio_release_pages in iomap_dio_bio_end_io") ff896738be38 ("block: return from __bio_try_merge_page if merging occured in the same page") 79d08f89bb1b ("block:

Re: [PATCH] f2fs: allocate memory in batch in build_sit_info()

2019-07-09 Thread Chao Yu
On 2019/7/10 1:23, Jaegeuk Kim wrote: > On 07/09, Chao Yu wrote: >> On 2019-7-9 7:46, Jaegeuk Kim wrote: >>> On 07/04, Chao Yu wrote: build_sit_info() allocate all bitmaps for each segment one by one, it's quite low efficiency, this pach changes to allocate large continuous memory

Re: [PATCH] rcu: Make jiffies_till_sched_qs writable

2019-07-09 Thread Byungchul Park
On Tue, Jul 09, 2019 at 05:41:02AM -0700, Paul E. McKenney wrote: > > Hi Paul, > > > > IMHO, as much as we want to tune the time for fqs to be initiated, we > > can also want to tune the time for the help from scheduler to start. > > I thought only difference between them is a level of urgency. I

[v7 3/3] device-dax: "Hotremove" persistent memory that is used like normal RAM

2019-07-09 Thread Pavel Tatashin
It is now allowed to use persistent memory like a regular RAM, but currently there is no way to remove this memory until machine is rebooted. This work expands the functionality to also allows hotremoving previously hotplugged persistent memory, and recover the device for use for other purposes.

[v7 1/3] device-dax: fix memory and resource leak if hotplug fails

2019-07-09 Thread Pavel Tatashin
When add_memory() function fails, the resource and the memory should be freed. Fixes: c221c0b0308f ("device-dax: "Hotplug" persistent memory for use like normal RAM") Signed-off-by: Pavel Tatashin Reviewed-by: Dave Hansen --- drivers/dax/kmem.c | 5 - 1 file changed, 4 insertions(+), 1

[v7 2/3] mm/hotplug: make remove_memory() interface useable

2019-07-09 Thread Pavel Tatashin
As of right now remove_memory() interface is inherently broken. It tries to remove memory but panics if some memory is not offline. The problem is that it is impossible to ensure that all memory blocks are offline as this function also takes lock_device_hotplug that is required to change memory

[v7 0/3] "Hotremove" persistent memory

2019-07-09 Thread Pavel Tatashin
Changelog: v7 - Added Dan Williams Reviewed-by to the last patch, and small change to dev_err() otput format as was suggested by Dan. v6 - A few minor changes and added reviewed-by's. - Spent time studying lock ordering issue that was reported by Vishal Verma, but that issue already exists in

Re: [PATCH 1/2] KEYS: Replace uid/gid/perm permissions checking with an ACL

2019-07-09 Thread Eric Biggers
On Thu, May 23, 2019 at 04:58:27PM +0100, David Howells wrote: > Replace the uid/gid/perm permissions checking on a key with an ACL to allow > the SETATTR and SEARCH permissions to be split. This will also allow a > greater range of subjects to represented. > This patch broke 'keyctl

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-09 Thread Rashmica Gupta
Woops, looks like my phone doesn't send plain text emails :/ On Tue, Jul 2, 2019 at 6:52 PM Rashmica Gupta wrote: > > On Tue, Jul 2, 2019 at 5:48 PM Oscar Salvador wrote: >> >> On Tue, Jul 02, 2019 at 04:42:34PM +1000, Rashmica Gupta wrote: >> > Hi David, >> > >> > Sorry for the late reply. >>

Re: [GIT PULL] x86/topology changes for v5.3

2019-07-09 Thread Linus Torvalds
On Tue, Jul 9, 2019 at 5:59 PM Linus Torvalds wrote: > > On my laptop (which I am at right now), the hang is different, and > maybe it's similar to your ACPI hang issue. I will try that revert, > and at least see if that solves the laptop side. Nope, that wasn't it. Apparently there are three

RE: [PATCH net-next] Name NICs based on vmbus offer and enable async probe by default

2019-07-09 Thread Haiyang Zhang
> -Original Message- > From: linux-hyperv-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of David Miller > Sent: Tuesday, July 9, 2019 8:30 PM > To: Haiyang Zhang > Cc: sas...@kernel.org; linux-hyp...@vger.kernel.org; > net...@vger.kernel.org; KY Srinivasan ; Stephen >

Re: linux-next: build failure after merge of the rdma tree

2019-07-09 Thread Stephen Rothwell
Hi Jason, On Tue, 9 Jul 2019 12:46:34 + Jason Gunthorpe wrote: > > It isn't quite enough to make the header compile stand alone, I'm > adding this instead. > > From 37c1e072276b03b080eb24ff24c39080aeaf49ef Mon Sep 17 00:00:00 2001 > From: Jason Gunthorpe > Date: Tue, 9 Jul 2019 09:44:47

  1   2   3   4   5   6   7   8   >