[PATCH v2] coccinelle: api: add devm_platform_ioremap_resource script

2019-07-15 Thread Himanshu Jha
Use recently introduced devm_platform_ioremap_resource helper which wraps platform_get_resource() and devm_ioremap_resource() together. This helps produce much cleaner code and remove local `struct resource` declaration. Signed-off-by: Himanshu Jha Signed-off-by: Julia Lawall --- v2: -

linux-next: Tree for Jul 16

2019-07-15 Thread Stephen Rothwell
Hi all, Please do not add v5.4 material to your linux-next included branches until after v5.3-rc1 has been released. Changes since 20190715: The kbuild tree gained a build failure for which I reverted 4 commits. The pm tree lost its build failure. The rdma tree gained a conflict against

Re: [PATCH] mmc: host: sdhci: Fix the incorrect soft reset operation when runtime resuming

2019-07-15 Thread Baolin Wang
Hi Adrian, On Mon, 15 Jul 2019 at 20:39, Adrian Hunter wrote: > > On 15/07/19 2:37 PM, Baolin Wang wrote: > > Hi Adrian, > > > > On Mon, 15 Jul 2019 at 19:20, Adrian Hunter wrote: > >> > >> On 15/07/19 1:58 PM, Baolin Wang wrote: > >>> In sdhci_runtime_resume_host() function, we will always do

Re: [PATCH V5 11/18] clk: tegra210: Add support for Tegra210 clocks

2019-07-15 Thread Dmitry Osipenko
В Mon, 15 Jul 2019 21:37:09 -0700 Sowjanya Komatineni пишет: > On 7/15/19 8:50 PM, Dmitry Osipenko wrote: > > 16.07.2019 6:00, Sowjanya Komatineni пишет: > >> On 7/15/19 5:35 PM, Sowjanya Komatineni wrote: > >>> On 7/14/19 2:41 PM, Dmitry Osipenko wrote: > 13.07.2019 8:54, Sowjanya

[LINUX PATCH v18 1/2] mtd: rawnand: nand_micron: Do not over write driver's read_page()/write_page()

2019-07-15 Thread Naga Sureshkumar Relli
Add check before assigning chip->ecc.read_page() and chip->ecc.write_page() Signed-off-by: Naga Sureshkumar Relli --- Changes in v18 - None --- drivers/mtd/nand/raw/nand_micron.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/nand_micron.c

[LINUX PATCH v18 2/2] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

2019-07-15 Thread Naga Sureshkumar Relli
Add driver for arm pl353 static memory controller nand interface. This controller is used in Xilinx Zynq SoC for interfacing the NAND flash memory. Reviewed-by: Helmut Grohne Signed-off-by: Naga Sureshkumar Relli --- xilinx zynq TRM link:

[PATCH v5 3/4] media: venus: Update to bitrate based clock scaling

2019-07-15 Thread Aniket Masule
Introduced clock scaling using bitrate, preavious calculations consider only the cycles per mb. Also, clock scaling is now triggered before every buffer being queued to the device. This helps in deciding precise clock cycles required. Signed-off-by: Aniket Masule ---

[PATCH v5 4/4] media: venus: Update core selection

2019-07-15 Thread Aniket Masule
Present core assignment is static. Introduced load balancing across the cores. Load on earch core is calculated and core with minimum load is assigned to given instance. Signed-off-by: Aniket Masule --- drivers/media/platform/qcom/venus/helpers.c| 69 +++---

[PATCH v5 2/4] media: venus: Update clock scaling

2019-07-15 Thread Aniket Masule
Current clock scaling calculations are same for vpu4 and previous versions. For vpu4, Clock scaling calculations are updated with cycles/mb. This helps in getting precise clock required. Signed-off-by: Aniket Masule --- drivers/media/platform/qcom/venus/helpers.c | 91

[PATCH v5 1/4] media: venus: Add codec data table

2019-07-15 Thread Aniket Masule
Add vpp cycles for different types of codec. It indicates the cycles required by video hardware to process each macroblock. Add vsp cycles, cycles required by stream processor. Initialize the codec data with core resources. Signed-off-by: Aniket Masule ---

[PATCH v5 0/4] media: venus: Update clock scaling and core selection

2019-07-15 Thread Aniket Masule
In this patch series, clock scaling and core selection methods are updated. Current clock scaling and core selection methods are same for vpu4 and previous versions. Introducing load calculations using vpp cycles, which indicates the cycles required by video hardware to process each macroblock.

[PATCH] remoteproc: qcom: Move glink_ssr notification after stop

2019-07-15 Thread Bjorn Andersson
glink_ssr is used to signal a remote processor "A" about the stopping of another remote processor "B", so that in the event that remote processor B is ever booted again the fifos of the glink channel between A and B is in a known state. But if remote processor A receives this notification before

Re: linux-next: build failure after merge of the kbuild tree

2019-07-15 Thread Masahiro Yamada
Hi Stephen, On Tue, Jul 16, 2019 at 1:31 PM Stephen Rothwell wrote: > > Hi all, > > After merging the kbuild tree, today's linux-next build (x86_64 > allnoconfig) failed like this: > > make[1]: *** No rule to make target 'modules.order', needed by > 'autoksyms_recursive'. Stop. > > Starting

[PATCH] staging: vt6656: change alignment to match parenthesis

2019-07-15 Thread Benjamin Sherman
Change indentation to match parentheses. This complies with the Linux kernel coding style and improves readability. Signed-off-by: Benjamin Sherman --- drivers/staging/vt6656/rxtx.c| 10 +- drivers/staging/vt6656/usbpipe.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-)

Re: [Linux-kernel-mentees] [PATCH v3] PCI: Remove functions not called in include/linux/pci.h

2019-07-15 Thread Lukas Bulwahn
On Mon, 15 Jul 2019, Kelsey Skunberg wrote: > Remove the following uncalled functions from include/linux/pci.h: > > pci_block_cfg_access() > pci_block_cfg_access_in_atomic() > pci_unblock_cfg_access() > > Functions were added in commit fb51ccbf217c ("PCI: Rework

Re: linux-next: build warning after merge of the ntb tree

2019-07-15 Thread Stephen Rothwell
Hi Logan, On Mon, 15 Jul 2019 21:46:42 -0600 Logan Gunthorpe wrote: > > I renamed the ntb.c file to core.c so we could add more files to build > ntb.ko. See [1]. But that was last changed in June, so I assume that some change to the build system has caused this warning to be produced now. --

Re: [PATCH v4 4/4] media: venus: Update core selection

2019-07-15 Thread amasule
On 2019-07-15 21:30, Stanimir Varbanov wrote: Hi, On 7/2/19 5:46 PM, Aniket Masule wrote: Present core assignment is static. Introduced load balancing across the cores. Load on earch core is calculated and core with minimum load is assigned to given instance. Signed-off-by: Aniket Masule ---

Re: [PATCH v4 3/4] media: venus: Update to bitrate based clock scaling

2019-07-15 Thread amasule
Hi, On 2019-07-15 21:28, Stanimir Varbanov wrote: Hi, On 7/2/19 5:46 PM, Aniket Masule wrote: Introduced clock scaling using bitrate, preavious calculations consider only the cycles per mb. Also, clock scaling is now triggered before every buffer being queued to the device. This helps in

Re: [PATCH V5 11/18] clk: tegra210: Add support for Tegra210 clocks

2019-07-15 Thread Sowjanya Komatineni
On 7/15/19 8:50 PM, Dmitry Osipenko wrote: 16.07.2019 6:00, Sowjanya Komatineni пишет: On 7/15/19 5:35 PM, Sowjanya Komatineni wrote: On 7/14/19 2:41 PM, Dmitry Osipenko wrote: 13.07.2019 8:54, Sowjanya Komatineni пишет: On 6/29/19 8:10 AM, Dmitry Osipenko wrote: 28.06.2019 5:12, Sowjanya

Re: [PULL REQUEST] i2c for 5.3

2019-07-15 Thread pr-tracker-bot
The pull request you sent on Mon, 15 Jul 2019 23:37:03 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-5.3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/273cbf61c3ddee9574ef1f4959b9bc6db5b24271 Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] PCI changes for v5.3

2019-07-15 Thread pr-tracker-bot
The pull request you sent on Mon, 15 Jul 2019 14:27:02 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git > tags/pci-v5.3-changes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fb4da215ed92f564f7ca090bb81a199b0d6cab8a Thank you! --

Re: [GIT PULL] power-supply changes for 5.3

2019-07-15 Thread pr-tracker-bot
The pull request you sent on Mon, 15 Jul 2019 21:49:33 +0200: > ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git > tags/for-v5.3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/5fe7b600a116187e10317d83fb56922c4ef6b76d Thank you! --

Re: [GIT PULL] MFD for v5.3

2019-07-15 Thread pr-tracker-bot
The pull request you sent on Mon, 15 Jul 2019 08:48:35 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/mfd-next-5.3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8de262531f5fbb7458463224a7587429800c24bf Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] Please pull RDMA subsystem changes

2019-07-15 Thread pr-tracker-bot
The pull request you sent on Mon, 15 Jul 2019 15:26:22 +: > git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git tags/for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2a3c389a0fde49b241430df806a34276568cfb29 Thank you! -- Deet-doot-dot, I am a

Re: [PATCH 1/2] mm,sparse: Fix deactivate_section for early sections

2019-07-15 Thread Dan Williams
On Mon, Jul 15, 2019 at 1:16 AM Oscar Salvador wrote: > > deactivate_section checks whether a section is early or not > in order to either call free_map_bootmem() or depopulate_section_memmap(). > Being the former for sections added at boot time, and the latter for > sections hotplugged. > > The

linux-next: build failure after merge of the kbuild tree

2019-07-15 Thread Stephen Rothwell
Hi all, After merging the kbuild tree, today's linux-next build (x86_64 allnoconfig) failed like this: make[1]: *** No rule to make target 'modules.order', needed by 'autoksyms_recursive'. Stop. Starting with commit 656c0ac3cb4b ("kbuild: modpost: read modules.order instead of

Re: linux-next: manual merge of the akpm-current tree with the hmm tree

2019-07-15 Thread Dan Williams
On Sat, Jul 6, 2019 at 10:04 PM Andrew Morton wrote: > > On Fri, 5 Jul 2019 12:08:15 + Jason Gunthorpe wrote: > > > On Thu, Jul 04, 2019 at 04:29:55PM -0700, Dan Williams wrote: > > > Guys, Andrew has kicked the subsection patches out of -mm because of > > > the merge conflicts. Can we hold

Re: [PATCH v1 3/3] clk: qcom: rcg: update the DFS macro for RCG

2019-07-15 Thread Taniya Das
Hello Stephen, Thanks for the review. On 7/16/2019 4:14 AM, Stephen Boyd wrote: Quoting Taniya Das (2019-05-12 20:44:46) On 5/10/2019 11:24 PM, Stephen Boyd wrote: diff --git a/drivers/clk/qcom/clk-rcg.h b/drivers/clk/qcom/clk-rcg.h index 5562f38..e40e8f8 100644 ---

Re: [PATCH v1 2/3] clk: qcom: rcg2: Add support for hardware control mode

2019-07-15 Thread Taniya Das
Hello Stephen, Thanks for your review. On 7/16/2019 4:22 AM, Stephen Boyd wrote: Quoting Taniya Das (2019-05-08 11:24:54) diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c index 57dbac9..5bb6d45 100644 --- a/drivers/clk/qcom/clk-rcg2.c +++ b/drivers/clk/qcom/clk-rcg2.c @@

Re: [PATCH v4] PM / wakeup: show wakeup sources stats in sysfs

2019-07-15 Thread Tri Vo
On Tue, Jul 16, 2019 at 11:13 AM Greg Kroah-Hartman wrote: > > On Mon, Jul 15, 2019 at 11:48:27PM +0200, Rafael J. Wysocki wrote: > > On Mon, Jul 15, 2019 at 11:44 PM Tri Vo wrote: > > > > > > Userspace can use wakeup_sources debugfs node to plot history of suspend > > > blocking wakeup sources

Re: [PATCH v2] x86/paravirt: Drop {read,write}_cr8() hooks

2019-07-15 Thread Juergen Gross
On 15.07.19 17:16, Andrew Cooper wrote: There is a lot of infrastructure for functionality which is used exclusively in __{save,restore}_processor_state() on the suspend/resume path. cr8 is an alias of APIC_TASKPRI, and APIC_TASKPRI is saved/restored by lapic_{suspend,resume}(). Saving and

Re: [PATCH] ARM64/irqchip: Make ACPI_IORT depend on PCI again

2019-07-15 Thread Sinan Kaya
On 7/16/2019 12:04 AM, Sasha Levin wrote: > ACPI_IORT lost it's explicit dependency on PCI in c6bb8f89fa6df > ("ARM64/irqchip: Update ACPI_IORT symbol selection logic") where the > author has relied on the general dependency of ACPI on PCI. > > However, that dependency was finally removed in

[PATCH V3] cpufreq: Make cpufreq_generic_init() return void

2019-07-15 Thread Viresh Kumar
It always returns 0 (success) and its return type should really be void. Over that, many drivers have added error handling code based on its return value, which is not required at all. change its return type to void and update all the callers. Signed-off-by: Viresh Kumar --- V2->V3: - Update

[PATCH] ARM64/irqchip: Make ACPI_IORT depend on PCI again

2019-07-15 Thread Sasha Levin
ACPI_IORT lost it's explicit dependency on PCI in c6bb8f89fa6df ("ARM64/irqchip: Update ACPI_IORT symbol selection logic") where the author has relied on the general dependency of ACPI on PCI. However, that dependency was finally removed in 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without

Re: [PATCH v2 1/4] opp: core: add regulators enable and disable

2019-07-15 Thread Chanwoo Choi
Hi Kamil, On 19. 7. 15. 오후 9:04, Kamil Konieczny wrote: > Add enable regulators to dev_pm_opp_set_regulators() and disable > regulators to dev_pm_opp_put_regulators(). This prepares for > converting exynos-bus devfreq driver to use dev_pm_opp_set_rate(). IMHO, it is not proper to mention the

Re: [Linux-kernel-mentees] [PATCH v2] PCI: Remove functions not called in include/linux/pci.h

2019-07-15 Thread Kelsey Skunberg
On Mon, Jul 15, 2019 at 06:37:17PM -0500, Bjorn Helgaas wrote: > On Mon, Jul 15, 2019 at 09:42:47PM +0200, Lukas Bulwahn wrote: > > On Mon, 15 Jul 2019, Kelsey Skunberg wrote: > > > > > Remove the following uncalled functions from include/linux/pci.h: > > > > > > pci_block_cfg_access() >

Re: [Xen-devel] [PATCH 0/2] Remove 32-bit Xen PV guest support

2019-07-15 Thread Juergen Gross
On 15.07.19 19:39, Andrew Cooper wrote: On 15/07/2019 18:28, Andy Lutomirski wrote: On Mon, Jul 15, 2019 at 9:34 AM Andi Kleen wrote: Juergen Gross writes: The long term plan has been to replace Xen PV guests by PVH. The first victim of that plan are now 32-bit PV guests, as those are used

Re: [PATCH v2 2/4] devfreq: exynos-bus: convert to use dev_pm_opp_set_rate()

2019-07-15 Thread Chanwoo Choi
Hi Kamil, Looks good to me. But, this patch has some issue. I added the detailed reviews. I recommend that you make the separate patches as following in order to clarify the role of which apply the dev_pm_opp_* function. First patch, Need to consolidate the following two function into one

Re: [PATCH 1/2] x86/xen: remove 32-bit Xen PV guest support

2019-07-15 Thread Juergen Gross
On 15.07.19 17:44, Boris Ostrovsky wrote: diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile index 084de77a109e..d42737f31304 100644 --- a/arch/x86/xen/Makefile +++ b/arch/x86/xen/Makefile @@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -OBJECT_FILES_NON_STANDARD_xen-asm_$(BITS).o

Re: [PATCH V5 11/18] clk: tegra210: Add support for Tegra210 clocks

2019-07-15 Thread Dmitry Osipenko
16.07.2019 6:00, Sowjanya Komatineni пишет: > > On 7/15/19 5:35 PM, Sowjanya Komatineni wrote: >> >> On 7/14/19 2:41 PM, Dmitry Osipenko wrote: >>> 13.07.2019 8:54, Sowjanya Komatineni пишет: On 6/29/19 8:10 AM, Dmitry Osipenko wrote: > 28.06.2019 5:12, Sowjanya Komatineni пишет: >>

RE: [EXT] Re: [v4,1/2] rtc/fsl: add FTM alarm driver as the wakeup source

2019-07-15 Thread Biwen Li
> Caution: EXT Email > > On 15/07/2019 18:15:19+0800, Biwen Li wrote: > > + device_init_wakeup(>dev, true); > > + rtc->rtc_dev = devm_rtc_device_register(>dev, "ftm-alarm", > > + > _rtc_ops, > > + > THIS_MODULE); > > To be clear, I want you to not use devm_rtc_device_register and use >

Re: linux-next: build warning after merge of the ntb tree

2019-07-15 Thread Logan Gunthorpe
On 2019-07-15 9:03 p.m., Stephen Rothwell wrote: > Hi all, > > After merging the ntb tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > WARNING: could not open /home/sfr/next/next/drivers/ntb/ntb.c: No such file > or directory > > The only thing I could see

[PATCH v4 4/4] numa: introduce numa cling feature

2019-07-15 Thread 王贇
Although we paid so many effort to settle down task on a particular node, there are still chances for a task to leave it's preferred node, that is by wakeup, numa swap migrations or load balance. When we are using cpu cgroup in share way, since all the workloads see all the cpus, it could be

Re: [PATCH V5 11/18] clk: tegra210: Add support for Tegra210 clocks

2019-07-15 Thread Sowjanya Komatineni
On 7/15/19 8:00 PM, Sowjanya Komatineni wrote: On 7/15/19 5:35 PM, Sowjanya Komatineni wrote: On 7/14/19 2:41 PM, Dmitry Osipenko wrote: 13.07.2019 8:54, Sowjanya Komatineni пишет: On 6/29/19 8:10 AM, Dmitry Osipenko wrote: 28.06.2019 5:12, Sowjanya Komatineni пишет: This patch adds

[PATCH v2 2/4] numa: append per-node execution time in cpu.numa_stat

2019-07-15 Thread 王贇
This patch introduced numa execution time information, to imply the numa efficiency. By doing 'cat /sys/fs/cgroup/cpu/CGROUP_PATH/cpu.numa_stat', we see new output line heading with 'exectime', like: exectime 311900 407166 which means the tasks of this cgroup executed 311900 micro seconds on

[PATCH v2 3/4] numa: introduce numa group per task group

2019-07-15 Thread 王贇
By tracing numa page faults, we recognize tasks sharing the same page, and try pack them together into a single numa group. However when two task share lot's of cache pages while not much anonymous pages, since numa balancing do not tracing cache page, they have no chance to join into the same

[PATCH v2 1/4] numa: introduce per-cgroup numa balancing locality statistic

2019-07-15 Thread 王贇
This patch introduced numa locality statistic, which try to imply the numa balancing efficiency per memory cgroup. On numa balancing, we trace the local page accessing ratio of tasks, which we call the locality. By doing 'cat /sys/fs/cgroup/cpu/CGROUP_PATH/cpu.numa_stat', we see output line

[PATCH v2 0/4] per-cgroup numa suite

2019-07-15 Thread 王贇
During our torturing on numa stuff, we found problems like: * missing per-cgroup information about the per-node execution status * missing per-cgroup information about the numa locality That is when we have a cpu cgroup running with bunch of tasks, no good way to tell how it's tasks are

[PATCH] sched/core: fix double fetch in sched_copy_attr()

2019-07-15 Thread JingYi Hou
In sched_copy_attr(), attr->size was fetched twice in get_user() and copy_from_user(). If change it between two fetches may cause security problems or unexpected behaivor. We can apply the same pattern used in perf_copy_attr(). That is, use value fetched first time to overwrite it after second

Re: [GIT PULL] Backlight for v5.3

2019-07-15 Thread Linus Torvalds
On Mon, Jul 15, 2019 at 1:00 AM Lee Jones wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git > backlight-next-5.3 Hmm. No such ref exists. I can see the "backlight-next" branch which has the right commit SHA1, but you normally do a signed tag, and I'd much rather

[PATCH] arm64: dts: imx8mm: Correct SAI3 RXC/TXFS pin's mux option #1

2019-07-15 Thread Anson . Huang
From: Anson Huang According to i.MX8MM reference manual Rev.1, 03/2019: SAI3_RXC pin's mux option #1 should be GPT1_CLK, NOT GPT1_CAPTURE2; SAI3_TXFS pin's mux option #1 should be GPT1_CAPTURE2, NOT GPT1_CLK. Fixes: c1c9d41319c3 ("dt-bindings: imx: Add pinctrl binding doc for imx8mm")

[PATCH v3] coccinelle: semantic code search for missing of_node_put

2019-07-15 Thread Wen Yang
There are functions which increment a reference counter for a device node. These functions belong to a programming interface for the management of information from device trees. The counter must be decremented after the last usage of a device node. We find these functions by using the following

linux-next: build warning after merge of the ntb tree

2019-07-15 Thread Stephen Rothwell
Hi all, After merging the ntb tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: could not open /home/sfr/next/next/drivers/ntb/ntb.c: No such file or directory The only thing I could see that might be relevant is commit 56dce8121e97 ("kbuild: split out

Re: list corruption in deferred_split_scan()

2019-07-15 Thread Yang Shi
On 7/15/19 6:36 PM, Qian Cai wrote: On Jul 15, 2019, at 8:22 PM, Yang Shi wrote: On 7/15/19 2:23 PM, Qian Cai wrote: On Fri, 2019-07-12 at 12:12 -0700, Yang Shi wrote: Another possible lead is that without reverting the those commits below, kdump kernel would always also crash in

Re: [PATCH V5 11/18] clk: tegra210: Add support for Tegra210 clocks

2019-07-15 Thread Sowjanya Komatineni
On 7/15/19 5:35 PM, Sowjanya Komatineni wrote: On 7/14/19 2:41 PM, Dmitry Osipenko wrote: 13.07.2019 8:54, Sowjanya Komatineni пишет: On 6/29/19 8:10 AM, Dmitry Osipenko wrote: 28.06.2019 5:12, Sowjanya Komatineni пишет: This patch adds system suspend and resume support for Tegra210

Re: [PATCH V35 15/29] acpi: Ignore acpi_rsdp kernel param when the kernel has been locked down

2019-07-15 Thread Dave Young
Hi, On 07/15/19 at 12:59pm, Matthew Garrett wrote: > From: Josh Boyer > > This option allows userspace to pass the RSDP address to the kernel, which > makes it possible for a user to modify the workings of hardware . Reject > the option when the kernel is locked down. > > Signed-off-by: Josh

Re: [PATCH AUTOSEL 5.1 013/219] x86/tsc: Use CPUID.0x16 to calculate missing crystal frequency

2019-07-15 Thread Daniel Drake
Hi, On Mon, Jul 15, 2019 at 9:38 PM Sasha Levin wrote: > From: Daniel Drake > > [ Upstream commit 604dc9170f2435d27da5039a3efd757dceadc684 ] In my opinion this is not stable kernel material. It alone does not solve a particular bug. It's part of a larger effort to decrease usage of the 8254

Re: [PATCH] net: sctp: fix warning "NULL check before some freeing functions is not needed"

2019-07-15 Thread Marcelo Ricardo Leitner
On Tue, Jul 16, 2019 at 07:50:02AM +0530, Hariprasad Kelam wrote: > This patch removes NULL checks before calling kfree. > > fixes below issues reported by coccicheck > net/sctp/sm_make_chunk.c:2586:3-8: WARNING: NULL check before some > freeing functions is not needed. >

Re: [PATCH 1/4] numa: introduce per-cgroup numa balancing locality, statistic

2019-07-15 Thread 王贇
Hi Michal, Thx for the comments :-) On 2019/7/15 下午8:10, Michal Koutný wrote: > Hello Yun. > > On Fri, Jul 12, 2019 at 06:10:24PM +0800, 王贇 > wrote: >> Forgive me but I have no idea on how to combined this >> with memory cgroup's locality hierarchical update... >> parent memory cgroup do not

[PATCH] net: sctp: fix warning "NULL check before some freeing functions is not needed"

2019-07-15 Thread Hariprasad Kelam
This patch removes NULL checks before calling kfree. fixes below issues reported by coccicheck net/sctp/sm_make_chunk.c:2586:3-8: WARNING: NULL check before some freeing functions is not needed. net/sctp/sm_make_chunk.c:2652:3-8: WARNING: NULL check before some freeing functions is not needed.

Re: [PATCH] ipvs: remove unnecessary space

2019-07-15 Thread yangxingwu
Pablo v2 has been sent I made the following changes: 1. remove all unnecessary spaces in one go 2. revert bitmap_alloc ( since it's irrelevant to this subject) 3. chenge subject to "net/netfiler:remove unnecessary space" thanks Pablo Neira Ayuso 于2019年7月15日周一 下午4:27写道: > > On Wed, Jul 10,

Re: [PATCH v4] PM / wakeup: show wakeup sources stats in sysfs

2019-07-15 Thread Greg Kroah-Hartman
On Mon, Jul 15, 2019 at 11:48:27PM +0200, Rafael J. Wysocki wrote: > On Mon, Jul 15, 2019 at 11:44 PM Tri Vo wrote: > > > > Userspace can use wakeup_sources debugfs node to plot history of suspend > > blocking wakeup sources over device's boot cycle. This information can > > then be used (1) for

Re: [PATCH v3] PM / wakeup: show wakeup sources stats in sysfs

2019-07-15 Thread Greg KH
On Mon, Jul 15, 2019 at 02:48:13PM -0700, Tri Vo wrote: > > And I am guessing that you actually tested this all out, and it works > > for you? > > Yes, I played around with wakelocks to make sure that wakeup source > stats are added/updated/removed as expected. Great! > > Have you changed

[PATCH v2] net/netfilter: remove unnecessary spaces

2019-07-15 Thread yangxingwu
this patch removes extra spaces Signed-off-by: yangxingwu --- net/netfilter/ipset/ip_set_hash_gen.h | 2 +- net/netfilter/ipset/ip_set_list_set.c | 2 +- net/netfilter/ipvs/ip_vs_core.c| 2 +- net/netfilter/ipvs/ip_vs_mh.c | 4 ++-- net/netfilter/ipvs/ip_vs_proto_tcp.c | 2

RE: [EXT] [PATCH v1] net: fec: optionally reset PHY via a reset-controller

2019-07-15 Thread Andy Duan
From: Sven Van Asbroeck Sent: Tuesday, July 16, 2019 5:05 AM > The current fec driver allows the PHY to be reset via a gpio, specified in the > devicetree. However, some PHYs need to be reset in a more complex way. > > To accommodate such PHYs, allow an optional reset controller in the fec >

Re: [PATCH v3 0/3] kernel/notifier.c: avoid duplicate registration

2019-07-15 Thread Xiaoming Ni
On 2019/7/15 13:38, Vasily Averin wrote: > On 7/14/19 5:45 AM, Xiaoming Ni wrote: >> On 2019/7/12 22:07, gre...@linuxfoundation.org wrote: >>> On Fri, Jul 12, 2019 at 09:11:57PM +0800, Xiaoming Ni wrote: On 2019/7/11 21:57, Vasily Averin wrote: > On 7/11/19 4:55 AM, Nixiaoming wrote:

Re: [PATCH v6 14/14] arm64: dts: Add power controller device node of MT8183

2019-07-15 Thread CK Hu
Hi, Weiyi: On Mon, 2019-07-15 at 17:07 +0800, Weiyi Lu wrote: > On Mon, 2019-07-15 at 16:07 +0800, CK Hu wrote: > > Hi, Weiyi: > > > > On Mon, 2019-07-01 at 16:57 +0800, CK Hu wrote: > > > Hi, Weiyi: > > > > > > On Thu, 2019-06-20 at 10:38 +0800, Weiyi Lu wrote: > > > > Add power controller

Re: list corruption in deferred_split_scan()

2019-07-15 Thread Qian Cai
> On Jul 15, 2019, at 8:22 PM, Yang Shi wrote: > > > > On 7/15/19 2:23 PM, Qian Cai wrote: >> On Fri, 2019-07-12 at 12:12 -0700, Yang Shi wrote: Another possible lead is that without reverting the those commits below, kdump kernel would always also crash in

Re: [PATCH] ipvs: remove unnecessary space

2019-07-15 Thread yangxingwu
ok I will remove all unnecessary spaces and send the v2 patch Thansk Pablo Pablo Neira Ayuso 于2019年7月15日周一 下午4:27写道: > > On Wed, Jul 10, 2019 at 10:06:09AM +0200, Simon Horman wrote: > > On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote: > > > --- > > > net/netfilter/ipvs/ip_vs_mh.c

Re: [PATCH v2] nvmet-file: fix nvmet_file_flush() always returning an error

2019-07-15 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [PATCH v3 2/4] of/platform: Add functional dependency link from DT bindings

2019-07-15 Thread Frank Rowand
On 7/15/19 11:40 AM, Saravana Kannan wrote: > Replying again because the previous email accidentally included HTML. > > Thanks for taking the time to reconsider the wording Frank. Your > intention was clear to me in the first email too. > > A kernel command line option can also completely

Re: [PATCH v1] scsi: ufs: change msleep to usleep_range

2019-07-15 Thread Stanley Chu
Hi Bean, On Mon, 2019-07-15 at 11:21 +, Bean Huo (beanhuo) wrote: > From: Bean Huo > > This patch is to change msleep() to usleep_range() based on > Documentation/timers/timers-howto.txt. It suggests using > usleep_range() for small msec(1ms - 20ms) since msleep() > will often sleep longer

Re: [PATCH v3 6/6] interconnect: Add OPP table support for interconnects

2019-07-15 Thread Saravana Kannan
On Mon, Jul 15, 2019 at 1:16 AM Vincent Guittot wrote: > > On Tue, 9 Jul 2019 at 21:03, Saravana Kannan wrote: > > > > On Tue, Jul 9, 2019 at 12:25 AM Vincent Guittot > > wrote: > > > > > > On Sun, 7 Jul 2019 at 23:48, Saravana Kannan wrote: > > > > > > > > On Thu, Jul 4, 2019 at 12:12 AM

Re: [PATCH v2] x86/paravirt: Drop {read,write}_cr8() hooks

2019-07-15 Thread Nadav Amit
> On Jul 15, 2019, at 4:30 PM, Andrew Cooper wrote: > > On 15/07/2019 19:17, Nadav Amit wrote: >>> On Jul 15, 2019, at 8:16 AM, Andrew Cooper >>> wrote: >>> >>> There is a lot of infrastructure for functionality which is used >>> exclusively in __{save,restore}_processor_state() on the

Re: [PATCH 1/3] nvme: Pass the queue to SQ_SIZE/CQ_SIZE macros

2019-07-15 Thread Benjamin Herrenschmidt
On Tue, 2019-07-16 at 10:46 +1000, Benjamin Herrenschmidt wrote: > # Conflicts: > # drivers/nvme/host/pci.c > --- Oops :-) You can strip that or should I resend ? I'll wait for comments/reviews regardless. Cheers, Ben.

[PATCH 3/3] nvme: Add support for Apple 2018+ models

2019-07-15 Thread Benjamin Herrenschmidt
Based on reverse engineering and original patch by Paul Pawlowski This adds support for Apple weird implementation of NVME in their 2018 or later machines. It accounts for the twice-as-big SQ entries for the IO queues, and the fact that only interrupt vector 0 appears to function properly.

[PATCH 1/3] nvme: Pass the queue to SQ_SIZE/CQ_SIZE macros

2019-07-15 Thread Benjamin Herrenschmidt
This will make it easier to handle variable queue entry sizes later. No functional change. Signed-off-by: Benjamin Herrenschmidt # Conflicts: # drivers/nvme/host/pci.c --- drivers/nvme/host/pci.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff

[PATCH 2/3] nvme: Retrieve the required IO queue entry size from the controller

2019-07-15 Thread Benjamin Herrenschmidt
On PCIe based NVME devices, this will retrieve the IO queue entry size from the controller and use the "required" setting. It should always be 6 (64 bytes) by spec. However some controllers such as Apple's are not properly implementing the spec and require the size to be 7 (128 bytes). This

linux-next: manual merge of the rdma tree with the v4l-dvb-next tree

2019-07-15 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the rdma tree got a conflict in: Documentation/index.rst between commit: 09fdc957ad0d ("docs: leds: add it to the driver-api book") (and others following) from the v4l-dvb-next tree and commit: a3a400da206b ("docs: infiniband: add it to the

Re: [PATCH] mm/hmm: Fix bad subpage pointer in try_to_unmap_one

2019-07-15 Thread Ralph Campbell
On 7/15/19 4:34 PM, John Hubbard wrote: On 7/15/19 3:00 PM, Andrew Morton wrote: On Tue, 9 Jul 2019 18:24:57 -0700 Ralph Campbell wrote: On 7/9/19 5:28 PM, Andrew Morton wrote: On Tue, 9 Jul 2019 15:35:56 -0700 Ralph Campbell wrote: When migrating a ZONE device private page from

Re: [PATCH v2 1/2] dt-bindings: mmc: Document Aspeed SD controller

2019-07-15 Thread Andrew Jeffery
On Tue, 16 Jul 2019, at 07:47, Rob Herring wrote: > On Thu, Jul 11, 2019 at 9:32 PM Andrew Jeffery wrote: > > > > The ASPEED SD/SDIO/eMMC controller exposes two slots implementing the > > SDIO Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit > > data bus if only a single slot

Re: [PATCH V5 11/18] clk: tegra210: Add support for Tegra210 clocks

2019-07-15 Thread Sowjanya Komatineni
On 7/14/19 2:41 PM, Dmitry Osipenko wrote: 13.07.2019 8:54, Sowjanya Komatineni пишет: On 6/29/19 8:10 AM, Dmitry Osipenko wrote: 28.06.2019 5:12, Sowjanya Komatineni пишет: This patch adds system suspend and resume support for Tegra210 clocks. All the CAR controller settings are lost on

Re: [RFC PATCH, x86]: Disable CPA cache flush for selfsnoop targets

2019-07-15 Thread Andi Kleen
On Mon, Jul 15, 2019 at 04:10:36PM -0700, Andy Lutomirski wrote: > On Mon, Jul 15, 2019 at 3:53 PM Andi Kleen wrote: > > > > > I haven't tested on a real kernel with i915. Does i915 really hit > > > this code path? Does it happen more than once or twice at boot? > > > > Yes some workloads

Re: list corruption in deferred_split_scan()

2019-07-15 Thread Yang Shi
On 7/15/19 2:23 PM, Qian Cai wrote: On Fri, 2019-07-12 at 12:12 -0700, Yang Shi wrote: Another possible lead is that without reverting the those commits below, kdump kernel would always also crash in shrink_slab_memcg() at this line, map =

Re: [PATCH v1] clk: Add devm_clk_{prepare,enable,prepare_enable}

2019-07-15 Thread Guenter Roeck
On 7/15/19 8:34 AM, Marc Gonzalez wrote: Provide devm variants for automatic resource release on device removal. probe() error-handling is simpler, and remove is no longer required. Signed-off-by: Marc Gonzalez Again ? https://lore.kernel.org/patchwork/patch/755667/ This must be at least

Re: [PATCH v2] KVM: x86: PMU Event Filter

2019-07-15 Thread Eric Hankland
> I think just disabling guest cpuid might not be enough, since guest > could write to the msr without checking the cpuid. > > Why not just add a bitmap for fixed counter? > e.g. fixed_counter_reject_bitmap > > At the beginning of reprogram_fixed_counter, we could add the check: > > if

[PATCH v2] mm/z3fold.c: Reinitialize zhdr structs after migration

2019-07-15 Thread Henry Burns
z3fold_page_migration() calls memcpy(new_zhdr, zhdr, PAGE_SIZE). However, zhdr contains fields that can't be directly coppied over (ex: list_head, a circular linked list). We only need to initialize the linked lists in new_zhdr, as z3fold_isolate_page() already ensures that these lists are empty

Re: [PATCH v2] x86/paravirt: Drop {read,write}_cr8() hooks

2019-07-15 Thread Andy Lutomirski
On Mon, Jul 15, 2019 at 4:30 PM Andrew Cooper wrote: > > On 15/07/2019 19:17, Nadav Amit wrote: > >> On Jul 15, 2019, at 8:16 AM, Andrew Cooper > >> wrote: > >> > >> There is a lot of infrastructure for functionality which is used > >> exclusively in __{save,restore}_processor_state() on the

Re: [v2 PATCH 0/2] mm: mempolicy: fix mbind()'s inconsistent behavior for unmovable pages

2019-07-15 Thread Yang Shi
On 7/15/19 4:51 PM, Yang Shi wrote: On 7/15/19 3:22 PM, Andrew Morton wrote: On Sat, 22 Jun 2019 08:20:07 +0800 Yang Shi wrote: Changelog v2: * Fixed the inconsistent behavior by not aborting !vma_migratable()    immediately by a separate patch (patch 1/2), and this is also the   

Re: [v2 PATCH 0/2] mm: mempolicy: fix mbind()'s inconsistent behavior for unmovable pages

2019-07-15 Thread Yang Shi
On 7/15/19 3:22 PM, Andrew Morton wrote: On Sat, 22 Jun 2019 08:20:07 +0800 Yang Shi wrote: Changelog v2: * Fixed the inconsistent behavior by not aborting !vma_migratable() immediately by a separate patch (patch 1/2), and this is also the preparation for patch 2/2. For the

Re: [Linux-kernel-mentees] [PATCH v2] PCI: Remove functions not called in include/linux/pci.h

2019-07-15 Thread Bjorn Helgaas
On Mon, Jul 15, 2019 at 09:42:47PM +0200, Lukas Bulwahn wrote: > On Mon, 15 Jul 2019, Kelsey Skunberg wrote: > > > Remove the following uncalled functions from include/linux/pci.h: > > > > pci_block_cfg_access() > > pci_block_cfg_access_in_atomic() > >

Re: [PATCH v2 2/2] interconnect: qcom: Add tagging and wake/sleep support for sdm845

2019-07-15 Thread David Dai
Hi Evan, Thanks for the continued help in reviewing these patches! On 7/11/2019 10:06 AM, Evan Green wrote: Hi Georgi and David, On Tue, Jun 18, 2019 at 2:17 AM Georgi Djakov wrote: From: David Dai Add support for wake and sleep commands by using a tag to indicate whether or not the

Re: [PATCH] mm/hmm: Fix bad subpage pointer in try_to_unmap_one

2019-07-15 Thread John Hubbard
On 7/15/19 3:00 PM, Andrew Morton wrote: > On Tue, 9 Jul 2019 18:24:57 -0700 Ralph Campbell wrote: > >> >> On 7/9/19 5:28 PM, Andrew Morton wrote: >>> On Tue, 9 Jul 2019 15:35:56 -0700 Ralph Campbell >>> wrote: >>> When migrating a ZONE device private page from device memory to system

Re: [PATCH v2] x86/paravirt: Drop {read,write}_cr8() hooks

2019-07-15 Thread Andrew Cooper
On 15/07/2019 19:17, Nadav Amit wrote: >> On Jul 15, 2019, at 8:16 AM, Andrew Cooper wrote: >> >> There is a lot of infrastructure for functionality which is used >> exclusively in __{save,restore}_processor_state() on the suspend/resume >> path. >> >> cr8 is an alias of APIC_TASKPRI, and

Re: [PATCH V35 19/29] Lock down module params that specify hardware parameters (eg. ioport)

2019-07-15 Thread James Morris
On Mon, 15 Jul 2019, Matthew Garrett wrote: > From: David Howells > > Provided an annotation for module parameters that specify hardware > parameters (such as io ports, iomem addresses, irqs, dma channels, fixed > dma buffers and other types). Adding Jessica. > > Suggested-by: Alan Cox >

Re: [PATCH] iio: cros_ec_accel_legacy: Always release lock when returning from _read()

2019-07-15 Thread Gwendal Grignou
Let's use Matthias CL. On Mon, Jul 15, 2019 at 4:17 PM Gwendal Grignou wrote: > > Sorry for the original mistake. I upload a patch at > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1702884. > > On Mon, Jul 15, 2019 at 1:04 PM Matthias Kaehlcke wrote: > > > > Hi

Re: [PATCH V35 26/29] debugfs: Restrict debugfs when the kernel is locked down

2019-07-15 Thread James Morris
On Mon, 15 Jul 2019, Matthew Garrett wrote: > From: David Howells > > Disallow opening of debugfs files that might be used to muck around when > the kernel is locked down as various drivers give raw access to hardware > through debugfs. Given the effort of auditing all 2000 or so files and >

Re: [PATCH] iio: cros_ec_accel_legacy: Always release lock when returning from _read()

2019-07-15 Thread Gwendal Grignou
Sorry for the original mistake. I upload a patch at https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1702884. On Mon, Jul 15, 2019 at 1:04 PM Matthias Kaehlcke wrote: > > Hi Benson, > > On Mon, Jul 15, 2019 at 12:55:57PM -0700, Benson Leung wrote: > > Hi Matthias, > > >

[PATCH v6 2/4] iio: cros_ec_accel_legacy: Fix incorrect channel setting

2019-07-15 Thread Gwendal Grignou
INFO_SCALE is set both for each channel and all channels. iio is using all channel setting, so the error was not user visible. Signed-off-by: Gwendal Grignou --- drivers/iio/accel/cros_ec_accel_legacy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/iio/accel/cros_ec_accel_legacy.c

[PATCH v6 3/4] iio: cros_ec_accel_legacy: Use cros_ec_sensors_core

2019-07-15 Thread Gwendal Grignou
Remove duplicate code in cros-ec-accel-legacy, use cros-ec-sensors-core functions and structures when possible. On glimmer, check the 2 accelerometers are presented and working. Signed-off-by: Gwendal Grignou Acked-by: Jonathan Cameron --- drivers/iio/accel/Kconfig| 4 +-

  1   2   3   4   5   6   7   8   9   10   >