Re: linux-next: Fixes tag needs some work in the sound-asoc tree

2019-07-28 Thread Peter Ujfalusi
Mark, On 26/07/2019 15.11, Mark Brown wrote: > On Fri, Jul 26, 2019 at 09:04:37AM +0300, Peter Ujfalusi wrote: > >> Mark: can you either drop the patch and I'll send a new one with fixed >> SHA1 or can you fix the commit message in place? > > Both of which involve rebasing :( Against my better

Re: [PATCH v2] f2fs: separate NOCoW and pinfile semantics

2019-07-28 Thread Jaegeuk Kim
On 07/23, Chao Yu wrote: > On 2019/7/23 10:36, Jaegeuk Kim wrote: > > On 07/19, Chao Yu wrote: > >> Pinning a file is heavy, because skipping pinned files make GC > >> running with heavy load or no effect. > > > > Pinned file is a part of NOCOW files, so I don't think we can simply drop it > >

Re: WARNING in __mmdrop

2019-07-28 Thread Jason Wang
On 2019/7/26 下午11:03, Jason Gunthorpe wrote: On Fri, Jul 26, 2019 at 10:00:20PM +0800, Jason Wang wrote: The question is, MMU notifier are allowed to be blocked on invalidate_range_start() which could be much slower than synchronize_rcu() to finish. Looking at

[PATCH v2 6/6] pinctrl: aspeed: Add AST2600 pinmux support

2019-07-28 Thread Andrew Jeffery
The AST2600 pinmux is fairly similar to the previous generations of ASPEED BMC SoCs in terms of architecture, though differ in some of the design details. The complexity of the pin expressions is largely reduced (e.g. there are no-longer signals with multiple expressions muxing them to the

[PATCH v2 5/6] pinctrl: aspeed: Add SIG_DESC_CLEAR() helper

2019-07-28 Thread Andrew Jeffery
The complement of SIG_DESC_SET(). Signed-off-by: Andrew Jeffery --- drivers/pinctrl/aspeed/pinmux-aspeed.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/aspeed/pinmux-aspeed.h b/drivers/pinctrl/aspeed/pinmux-aspeed.h index 474820df6263..c59e936a7dde 100644 ---

[PATCH v2 1/6] dt-bindings: pinctrl: aspeed: Document AST2600 pinmux

2019-07-28 Thread Andrew Jeffery
The AST260 differs from the 2400 and 2500 in that it supports multiple groups for a subset of functions. Signed-off-by: Andrew Jeffery --- v2: * Avoid patternProperties for fixed strings * Don't needlessly quote strings --- .../pinctrl/aspeed,ast2600-pinctrl.yaml | 115 ++

[PATCH v2 0/6] pinctrl: aspeed: Add AST2600 pinmux support

2019-07-28 Thread Andrew Jeffery
Hello, This series adds pinmux support for the AST2600. v2 addresses some binding comments from Rob and has some minor cleanups in the g6 driver implementation. v1 can be found here: https://lists.ozlabs.org/pipermail/linux-aspeed/2019-July/001999.html Please review! Andrew Andrew Jeffery

[PATCH v2 3/6] pinctrl: aspeed: Add PIN_DECL_3() helper

2019-07-28 Thread Andrew Jeffery
This case is common in the AST2600, so add to the collection. Signed-off-by: Andrew Jeffery --- drivers/pinctrl/aspeed/pinmux-aspeed.h | 72 ++ 1 file changed, 40 insertions(+), 32 deletions(-) diff --git a/drivers/pinctrl/aspeed/pinmux-aspeed.h

[PATCH v2 2/6] pinctrl: aspeed: Rename pin declaration macros

2019-07-28 Thread Andrew Jeffery
Rename macros as follows: * s/SS_PIN_DECL()/PIN_DECL_1()/ * s/MS_PIN_DECL()/PIN_DECL_2()/ * s/MS_PIN_DECL_()/PIN_DECL_()/ This is in preparation for adding PIN_DECL_3(). We could clean this up with e.g. CPPMAGIC_MAP() from ccan, but that might be a bridge too far given how much of a macro jungle

Re: WARNING in __mmdrop

2019-07-28 Thread Jason Wang
On 2019/7/26 下午9:49, Michael S. Tsirkin wrote: Ok, let me retry if necessary (but I do remember I end up with deadlocks last try). Ok, I play a little with this. And it works so far. Will do more testing tomorrow. One reason could be I switch to use get_user_pages_fast() to

Re: [BUG] infiniband: mlx5: a possible null-pointer dereference in set_roce_addr()

2019-07-28 Thread Leon Romanovsky
On Mon, Jul 29, 2019 at 05:26:30AM +, Parav Pandit wrote: > > > > -Original Message- > > From: linux-kernel-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Parav Pandit > > Sent: Monday, July 29, 2019 10:55 AM > > To: Jia-Ju Bai ; l...@kernel.org; > > dledf...@redhat.com;

[v2] mailbox: imx: add support for imx v1 mu

2019-07-28 Thread Richard Zhu
There is a version1.0 MU on i.MX7ULP platform. One new version ID register is added, and it's offset is 0. TRn registers are defined at the offset 0x20 ~ 0x2C. RRn registers are defined at the offset 0x40 ~ 0x4C. SR/CR registers are defined at 0x60/0x64. Extend this driver to support it.

[v2] mailbox: imx: add support for imx v1 mu

2019-07-28 Thread Richard Zhu
Changes: v1 --> v2: - Use to have the register layout linked on probe, suggested by Oleksij Rempel . - Add the Reviewed-by: Dong Aisheng tag. [v2] mailbox: imx: add support for imx v1 mu --- drivers/mailbox/imx-mailbox.c | 67 --- 1 file changed, 50

Re: [PATCH v2] lkmm/docs: Correct ->prop example with additional rfe link

2019-07-28 Thread Boqun Feng
On Sun, Jul 28, 2019 at 11:35:44AM -0400, Joel Fernandes wrote: [...] > > > > > +load of y (rfe link), P2's smp_store_release() ensures that P2's load > > > > > +of y executes before P2's store to z (second fence), which implies > > > > > that > > > > > +that stores to x and y propagate to P2

Re: [BUG] ALSA: core: seq: a possible double-lock bug in snd_seq_midisynth_remove()

2019-07-28 Thread Takashi Iwai
On Mon, 29 Jul 2019 05:54:07 +0200, Jia-Ju Bai wrote: > > In snd_seq_midisynth_remove(), there is a possible double-lock bug: > snd_seq_midisynth_remove() >     mutex_lock(_mutex); -- line 421 >     snd_seq_delete_kernel_client() --- line 436 >     seq_free_client() -- line 2244 >    

Re: [PATCH V4 net-next 00/10] net: hns3: some code optimizations & bugfixes & features

2019-07-28 Thread Saeed Mahameed
On Mon, 2019-07-29 at 10:53 +0800, Huazhong Tan wrote: > This patch-set includes code optimizations, bugfixes and features for > the HNS3 ethernet controller driver. > > [patch 1/10] checks reset status before setting channel. > > [patch 2/10] adds a NULL pointer checking. > > [patch 3/10]

[PATCH 2/2] uprobe: collapse THP pmd after removing all uprobes

2019-07-28 Thread Song Liu
After all uprobes are removed from the huge page (with PTE pgtable), it is possible to collapse the pmd and benefit from THP again. This patch does the collapse by calling khugepaged_add_pte_mapped_thp(). Signed-off-by: Song Liu --- kernel/events/uprobes.c | 9 + 1 file changed, 9

[PATCH 0/2] khugepaged: collapse pmd for pte-mapped THP

2019-07-28 Thread Song Liu
This set is the newer version of 5/6 and 6/6 of [1]. v9 of 1-4 of the work [2] was recently picked by Andrew. Patch 1 enables khugepaged to handle pte-mapped THP. These THPs are left in such state when khugepaged failed to get exclusive lock of mmap_sem. Patch 2 leverages work in 1 for uprobe on

[PATCH 1/2] khugepaged: enable collapse pmd for pte-mapped THP

2019-07-28 Thread Song Liu
khugepaged needs exclusive mmap_sem to access page table. When it fails to lock mmap_sem, the page will fault in as pte-mapped THP. As the page is already a THP, khugepaged will not handle this pmd again. This patch enables the khugepaged to retry collapse the page table. struct mm_slot (in

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-28 Thread Rashmica Gupta
On Tue, 2019-07-16 at 14:28 +0200, David Hildenbrand wrote: > On 02.07.19 08:42, Rashmica Gupta wrote: > > Hi David, > > > > Sorry for the late reply. > > Hi, > > sorry I was on PTO :) > > > On Wed, 2019-06-26 at 10:28 +0200, David Hildenbrand wrote: > > > On 26.06.19 10:15, Oscar Salvador

RE: [EXT] Re: [PATCH] mailbox: imx: add support for imx v1 mu

2019-07-28 Thread Richard Zhu
> -Original Message- > From: Dong Aisheng > Sent: 2019年7月29日 11:11 > To: Richard Zhu > Cc: jassisinghb...@gmail.com; Oleksij Rempel ; > Aisheng Dong ; open list > ; moderated list:ARM/FREESCALE IMX / MXC > ARM ARCHITECTURE > Subject: Re: [EXT] Re: [PATCH] mailbox: imx: add support for

Re: [PATCH] mmc: sdhci-s3c: Mark expected switch fall-through

2019-07-28 Thread Adrian Hunter
On 29/07/19 3:02 AM, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe': > drivers/mmc/host/sdhci-s3c.c:613:19: warning: this statement may fall

RE: [BUG] infiniband: mlx5: a possible null-pointer dereference in set_roce_addr()

2019-07-28 Thread Parav Pandit
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit > Sent: Monday, July 29, 2019 10:55 AM > To: Jia-Ju Bai ; l...@kernel.org; > dledf...@redhat.com; j...@ziepe.ca > Cc: linux-r...@vger.kernel.org; linux-kernel@vger.kernel.org

RE: [BUG] infiniband: mlx5: a possible null-pointer dereference in set_roce_addr()

2019-07-28 Thread Parav Pandit
Hi Jia, > -Original Message- > From: linux-rdma-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Jia-Ju Bai > Sent: Monday, July 29, 2019 7:47 AM > To: l...@kernel.org; dledf...@redhat.com; j...@ziepe.ca > Cc: linux-r...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject:

Re: [BUG] infiniband: mlx5: a possible null-pointer dereference in set_roce_addr()

2019-07-28 Thread Leon Romanovsky
On Mon, Jul 29, 2019 at 10:16:30AM +0800, Jia-Ju Bai wrote: > In set_roce_addr(), there is an if statement on line 589 to check whether > gid is NULL: >     if (gid) > > When gid is NULL, it is used on line 613: >     return mlx5_core_roce_gid_set(..., gid->raw, ...); > > Thus, a possible

I WANT YOU TO USE THIS DONATION TO HELP THE POOR URGENT.

2019-07-28 Thread Mrs Ivvone Davida Balakiwal
My Sincere Greetings, I am Mrs Ivvone D Balakiwal, I decided to donate what I have to you for investment towards the good work of charity organization, and also to help the motherless and the less privileged ones and to carry out a charitable works in your Country and around the World on my

Re: [PATCH] modpost: check for static EXPORT_SYMBOL* functions

2019-07-28 Thread Stephen Rothwell
Hi Denis, On Sun, 28 Jul 2019 13:09:06 +0300 Denis Efremov wrote: > > Thus, the current implementation adds approx. 1 min for allmodconfig. Just a reminder that some of us (just me?) do well over 100+ builds per day ... if this can be optimised some what that would be good. -- Cheers,

[PATCH v2] MIPS: Kconfig: remove HAVE_LATENCYTOP_SUPPORT

2019-07-28 Thread Fabian Mewes
HAVE_LATENCYTOP_SUPPORT was removed all together in da48d094ce5d7 ("Kconfig: remove HAVE_LATENCYTOP_SUPPORT"). This commit removes a leftover in the MIPS Kconfig. Signed-off-by: Fabian Mewes --- v1..v2: specify commit's summary enclosed in ("") arch/mips/Kconfig |4 1 file changed, 4

linux-next: Tree for Jul 29

2019-07-28 Thread Stephen Rothwell
Hi all, Changes since 20190726: The sh tree gained a conflict against Linus' tree. The tip tree gained a conflict against Linus' tree. I remerged the kspp-gustavo tree later to get some warning fixes. The akpm-current tree lost its build failure. Non-merge commits (relative to Linus' tree):

Re: [PATCH v7] driver core: Fix use-after-free and double free on glue directory

2019-07-28 Thread Prateek Sood
On 7/27/19 8:51 AM, Muchun Song wrote: > There is a race condition between removing glue directory and adding a new > device under the glue dir. It can be reproduced in following test: > > CPU1: CPU2: > > device_add() > get_device_parent() >

[PATCH -tip] locking/rwsem: Check for operations on an uninitialized rwsem

2019-07-28 Thread Davidlohr Bueso
Currently rwsems is the only locking primitive that lacks this debug feature. Add it under CONFIG_DEBUG_RWSEMS and do the magic checking in the locking fastpath (trylock) operation such that we cover all cases. The unlocking part is pretty straightforward. Signed-off-by: Davidlohr Bueso ---

Re: build error

2019-07-28 Thread Bhaskar Chowdhury
Matteo, it's look like gcc is not in your normal PATH. Could you please locate that fellow and realign it ,where is suppose to be. Or if I understood right (I doubt that is why asking) that you might put explicitly the architecture to target build with make also, that might help. Please do

[PATCH 1/4] dt-bindings: net: Add aspeed,ast2600-mdio binding

2019-07-28 Thread Andrew Jeffery
The AST2600 splits out the MDIO bus controller from the MAC into its own IP block and rearranges the register layout. Add a new binding to describe the new hardware. Signed-off-by: Andrew Jeffery --- .../bindings/net/aspeed,ast2600-mdio.yaml | 61 +++ 1 file changed, 61

[PATCH 4/4] net: ftgmac100: Select ASPEED MDIO driver for the AST2600

2019-07-28 Thread Andrew Jeffery
Ensures we can talk to a PHY via MDIO on the AST2600, as the MDIO controller is now separate from the MAC. Signed-off-by: Andrew Jeffery --- drivers/net/ethernet/faraday/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/faraday/Kconfig

[PATCH 2/4] net: phy: Add mdio-aspeed

2019-07-28 Thread Andrew Jeffery
The AST2600 design separates the MDIO controllers from the MAC, which is where they were placed in the AST2400 and AST2500. Further, the register interface is reworked again, so now we have three possible different interface implementations, however this driver only supports the interface provided

[PATCH 3/4] net: ftgmac100: Add support for DT phy-handle property

2019-07-28 Thread Andrew Jeffery
phy-handle is necessary for the AST2600 which separates the MDIO controllers from the MAC. I've tried to minimise the intrusion of supporting the AST2600 to the FTGMAC100 by leaving in place the existing MDIO support for the embedded MDIO interface. The AST2400 and AST2500 continue to be

[PATCH 0/4] net: phy: Add AST2600 MDIO support

2019-07-28 Thread Andrew Jeffery
Hello, This series adds support for the MDIO controllers found in the AST2600. In the AST2500 and earlier the MDIO controller was embedded in the MAC; this has now been separated out and the register interface rearranged (again). Please review! Andrew Andrew Jeffery (4): dt-bindings: net:

Re: [PATCH] tracing: Prevent RCU EQS breakage in preemptirq events

2019-07-28 Thread Andy Lutomirski
On Sun, Jul 28, 2019 at 6:08 PM Eiichi Tsukata wrote: > > If context tracking is enabled, causing page fault in preemptirq > irq_enable or irq_disable events triggers the following RCU EQS warning. > Yuck. > diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c > index

Re: [PATCH] fs: xfs: Fix possible null-pointer dereferences in xchk_da_btree_block_check_sibling()

2019-07-28 Thread Darrick J. Wong
On Mon, Jul 29, 2019 at 11:24:01AM +0800, Jia-Ju Bai wrote: > In xchk_da_btree_block_check_sibling(), there is an if statement on > line 274 to check whether ds->state->altpath.blk[level].bp is NULL: > if (ds->state->altpath.blk[level].bp) > > When ds->state->altpath.blk[level].bp is NULL,

linux-next: build warning after merge of Linus' tree

2019-07-28 Thread Stephen Rothwell
Hi all, After merging the origin tree, today's linux-next build (powerpc allyesconfig) produced this warning: sound/aoa/codecs/onyx.c: In function 'onyx_snd_single_bit_get': sound/aoa/codecs/onyx.c:377:37: warning: 'c' may be used uninitialized in this function [-Wmaybe-uninitialized]

[v6 3/6] extable: Add function to search only kernel exception table

2019-07-28 Thread Santosh Sivaraj
Certain architecture specific operating modes (e.g., in powerpc machine check handler that is unable to access vmalloc memory), the search_exception_tables cannot be called because it also searches the module exception tables if entry is not found in the kernel exception table. Cc: Thomas

[v6 4/6] powerpc/memcpy: Add memcpy_mcsafe for pmem

2019-07-28 Thread Santosh Sivaraj
From: Balbir Singh The pmem infrastructure uses memcpy_mcsafe in the pmem layer so as to convert machine check exceptions into a return value on failure in case a machine check exception is encountered during the memcpy. The return value is the number of bytes remaining to be copied. This patch

[v6 5/6] powerpc/mce: Handle UE event for memcpy_mcsafe

2019-07-28 Thread Santosh Sivaraj
If we take a UE on one of the instructions with a fixup entry, set nip to continue execution at the fixup entry. Stop processing the event further or print it. Based-on-patch-by: Reza Arbab Cc: Reza Arbab Cc: Mahesh Salgaonkar Signed-off-by: Santosh Sivaraj --- arch/powerpc/include/asm/mce.h

[v6 6/6] powerpc: add machine check safe copy_to_user

2019-07-28 Thread Santosh Sivaraj
Use memcpy_mcsafe() implementation to define copy_to_user_mcsafe() Signed-off-by: Santosh Sivaraj --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/uaccess.h | 14 ++ 2 files changed, 15 insertions(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig

[v6 0/6] powerpc: implement machine check safe memcpy

2019-07-28 Thread Santosh Sivaraj
During a memcpy from a pmem device, if a machine check exception is generated we end up in a panic. In case of fsdax read, this should only result in a -EIO. Avoid MCE by implementing memcpy_mcsafe. Before this patch series: ``` bash-4.4# mount -o dax /dev/pmem0 /mnt/pmem/ [ 7621.714094]

[v6 1/6] powerpc/mce: Make machine_check_ue_event() static

2019-07-28 Thread Santosh Sivaraj
From: Reza Arbab The function doesn't get used outside this file, so make it static. Signed-off-by: Reza Arbab Signed-off-by: Santosh Sivaraj Reviewed-by: Nicholas Piggin --- arch/powerpc/kernel/mce.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[v6 2/6] powerpc/mce: Fix MCE handling for huge pages

2019-07-28 Thread Santosh Sivaraj
From: Balbir Singh The current code would fail on huge pages addresses, since the shift would be incorrect. Use the correct page shift value returned by __find_linux_pte() to get the correct physical address. The code is more generic and can handle both regular and compound pages. Fixes:

Re: [RFC] net: phy: read link status twice when phy_check_link_status()

2019-07-28 Thread liuyonglong
On 2019/7/27 2:14, Heiner Kallweit wrote: > On 26.07.2019 11:53, Yonglong Liu wrote: >> According to the datasheet of Marvell phy and Realtek phy, the >> copper link status should read twice, or it may get a fake link >> up status, and cause up->down->up at the first time when link up. >> This

[BUG] ALSA: core: seq: a possible double-lock bug in snd_seq_midisynth_remove()

2019-07-28 Thread Jia-Ju Bai
In snd_seq_midisynth_remove(), there is a possible double-lock bug: snd_seq_midisynth_remove()     mutex_lock(_mutex); -- line 421     snd_seq_delete_kernel_client() --- line 436     seq_free_client() -- line 2244     mutex_lock(_mutex); -- line 294 This bug is found by a static

Re: [PATCH] x86: panic when a kernel stack overflow is detected

2019-07-28 Thread Andy Lutomirski
On Sun, Jul 28, 2019 at 6:59 PM Daniel Axtens wrote: > > Currently, when a kernel stack overflow is detected via VMAP_STACK, > the task is killed with die(). > > This isn't safe, because we don't know how that process has affected > kernel state. In particular, we don't know what locks have been

linux-next: build warning after merge of the akpm-current tree

2019-07-28 Thread Stephen Rothwell
Hi all, After merging the akpm-current tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/infiniband/sw/siw/siw_mem.c: In function 'siw_free_plist': drivers/infiniband/sw/siw/siw_mem.c:66:16: warning: unused variable 'p' [-Wunused-variable] struct page **p =

linux-next: build warning after merge of the akpm-current tree

2019-07-28 Thread Stephen Rothwell
Hi all, After merging the akpm-current tree, today's linux-next build (x86_64 allmodconfig) produced this warning: lib/rbtree_test.c: In function 'check_augmented': lib/rbtree_test.c:220:18: warning: unused variable 'rb' [-Wunused-variable] struct rb_node *rb; ^~ Introduced

[BUG] net: xfrm: possible null-pointer dereferences in xfrm_policy()

2019-07-28 Thread Jia-Ju Bai
In xfrm_policy(), the while loop on lines 3802-3830 ends when dst->xfrm is NULL. Then, dst->xfrm is used on line 3840:     xfrm_state_mtu(dst->xfrm, mtu);     if (x->km.state != XFRM_STATE_VALID...)     aead = x->data; Thus, possible null-pointer dereferences may occur. These bugs are

Re: [PATCH 6/8] PM / OPP: Support adjusting OPP voltages at runtime

2019-07-28 Thread Roger Lu
Dear Stephen Boyd, This patch is derived from [1]. Please kindly shares the suggestion to us. Thanks very much. [1]: https://lore.kernel.org/patchwork/patch/599279/ Dear Viresh, I followed _opp_set_availability() coding style to refine dev_pm_opp_adjust_voltage() from this patch. Is this

[PATCH] Input: applespi - Fix build error

2019-07-28 Thread YueHaibing
If CONFIG_KEYBOARD_APPLESPI=y but CONFIG_LEDS_CLASS=m building fails: drivers/input/keyboard/applespi.o: In function `applespi_probe': applespi.c:(.text+0x1fcd): undefined reference to `devm_led_classdev_register_ext' Wrap it in LEDS_CLASS macro to fix this. Reported-by: Hulk Robot Fixes:

Re: [PATCH] modpost: check for static EXPORT_SYMBOL* functions

2019-07-28 Thread Masahiro Yamada
On Sun, Jul 28, 2019 at 7:09 PM Denis Efremov wrote: > > This patch adds a check to warn about static EXPORT_SYMBOL* functions > during the modpost. In most of the cases, a static symbol marked for > exporting is an odd combination that should be fixed either by deleting > the exporting mark or

[PATCH] fs: xfs: Fix possible null-pointer dereferences in xchk_da_btree_block_check_sibling()

2019-07-28 Thread Jia-Ju Bai
In xchk_da_btree_block_check_sibling(), there is an if statement on line 274 to check whether ds->state->altpath.blk[level].bp is NULL: if (ds->state->altpath.blk[level].bp) When ds->state->altpath.blk[level].bp is NULL, it is used on line 281: xfs_trans_brelse(...,

Re: [EXT] Re: [PATCH] mailbox: imx: add support for imx v1 mu

2019-07-28 Thread Dong Aisheng
On Mon, Jul 29, 2019 at 11:03 AM Richard Zhu wrote: > > Hi Aisheng: > Thanks for your comments. > > > -Original Message- > > From: Dong Aisheng > > Sent: 2019年7月29日 10:35 > > To: Richard Zhu > > Cc: jassisinghb...@gmail.com; Oleksij Rempel ; > > Aisheng Dong ; open list > > ; moderated

[no subject]

2019-07-28 Thread Lin Xiulei
unsubscribe linux-kernel

[PATCH] scsi: mpt3sas: Fix a possible null-pointer dereference in mpt3sas_transport_update_links()

2019-07-28 Thread Jia-Ju Bai
In mpt3sas_transport_update_links(), there is an if statement on line 994 to check whether mpt3sas_phy->phy is NULL: if (mpt3sas_phy->phy) When mpt3sas_phy->phy is NULL, it is used on line 999: dev_printk(KERN_INFO, _phy->phy->dev, ...) Thus, a possible null-pointer dereference may

Re: [PATCH RESEND] autonuma: Fix scan period updating

2019-07-28 Thread Huang, Ying
Srikar Dronamraju writes: > * Huang, Ying [2019-07-26 15:45:39]: > >> Hi, Srikar, >> >> > >> > More Remote + Private page Accesses: >> > Most likely the Private accesses are going to be local accesses. >> > >> > In the unlikely event of the private accesses not being local, we should >> > scan

RE: [EXT] Re: [PATCH] mailbox: imx: add support for imx v1 mu

2019-07-28 Thread Richard Zhu
Hi Aisheng: Thanks for your comments. > -Original Message- > From: Dong Aisheng > Sent: 2019年7月29日 10:35 > To: Richard Zhu > Cc: jassisinghb...@gmail.com; Oleksij Rempel ; > Aisheng Dong ; open list > ; moderated list:ARM/FREESCALE IMX / MXC > ARM ARCHITECTURE > Subject: [EXT] Re:

[PATCH] ath6kl: Fix a possible null-pointer dereference in ath6kl_htc_mbox_create()

2019-07-28 Thread Jia-Ju Bai
In ath6kl_htc_mbox_create(), when kzalloc() on line 2855 fails, target->dev is assigned to NULL, and ath6kl_htc_mbox_cleanup(target) is called on line 2885. In ath6kl_htc_mbox_cleanup(), target->dev is used on line 2895: ath6kl_hif_cleanup_scatter(target->dev->ar); Thus, a null-pointer

Re: [PATCH] iio: tsl2772: Use device-managed API

2019-07-28 Thread Chuhong Yuan
Brian Masney 于2019年7月28日周日 下午4:31写道: > > On Sat, Jul 27, 2019 at 12:57:49PM +0100, Jonathan Cameron wrote: > > On Fri, 26 Jul 2019 20:30:58 +0800 > > Chuhong Yuan wrote: > > > > > Use devm_iio_device_register to simplify > > > the code. > > > > > > Signed-off-by: Chuhong Yuan > > > > Please try

Re: [PATCH v9 19/21] mm: Add generic ptdump

2019-07-28 Thread Anshuman Khandual
On 07/22/2019 09:12 PM, Steven Price wrote: > Add a generic version of page table dumping that architectures can > opt-in to > > Signed-off-by: Steven Price > --- > include/linux/ptdump.h | 19 + > mm/Kconfig.debug | 21 ++ > mm/Makefile| 1 + > mm/ptdump.c

[PATCH V4 net-next 02/10] net: hns3: add a check for get_reset_level

2019-07-28 Thread Huazhong Tan
From: Guangbin Huang For some cases, ops->get_reset_level may not be implemented, so we should check whether it is NULL before calling get_reset_level. Signed-off-by: Guangbin Huang Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- 1 file changed, 1

[PATCH V4 net-next 08/10] net: hns3: add interrupt affinity support for misc interrupt

2019-07-28 Thread Huazhong Tan
From: Yunsheng Lin The misc interrupt is used to schedule the reset and mailbox subtask, and service_task delayed_work is used to do periodic management work each second. This patch sets the above three subtask's affinity using the misc interrupt' affinity. Also this patch setups a affinity

[PATCH V4 net-next 09/10] net: hns3: Add support for using order 1 pages with a 4K buffer

2019-07-28 Thread Huazhong Tan
From: Yunsheng Lin Hardware supports 0.5K, 1K, 2K, 4K RX buffer size, the RX buffer can not be reused because the hns3_page_order return 0 when page size and RX buffer size are both 4096. So this patch changes the hns3_page_order to return 1 when RX buffer is greater than half of the page size

[PATCH V4 net-next 07/10] net: hns3: make hclge_service use delayed workqueue

2019-07-28 Thread Huazhong Tan
From: Yunsheng Lin Use delayed work instead of using timers to trigger the hclge_serive. Simplify the code with one less middle function and in order to support misc irq affinity. Signed-off-by: Yunsheng Lin Reviewed-by: Peng Li Signed-off-by: Huazhong Tan ---

[PATCH V4 net-next 05/10] net: hns3: modify firmware version display format

2019-07-28 Thread Huazhong Tan
From: Yufeng Mo This patch modifies firmware version display format in hclge(vf)_cmd_init() and hns3_get_drvinfo(). Also, adds some optimizations for firmware version display format. Signed-off-by: Yufeng Mo Signed-off-by: Peng Li Signed-off-by: Huazhong Tan ---

[PATCH V4 net-next 04/10] net: hns3: change GFP flag during lock period

2019-07-28 Thread Huazhong Tan
From: Yufeng Mo When allocating memory, the GFP_KERNEL cannot be used during the spin_lock period. This is because it may cause scheduling when holding spin_lock. This patch changes GFP flag to GFP_ATOMIC in this case. Fixes: dd74f815dd41 ("net: hns3: Add support for rule add/delete for flow

[PATCH V4 net-next 06/10] net: hns3: add debug messages to identify eth down cause

2019-07-28 Thread Huazhong Tan
From: Yonglong Liu Some times just see the eth interface have been down/up via dmesg, but can not know why the eth down. So adds some debug messages to identify the cause for this. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan ---

[PATCH V4 net-next 10/10] net: hns3: use dev_info() instead of pr_info()

2019-07-28 Thread Huazhong Tan
dev_info() is more appropriate for printing messages when driver initialization done, so switch to dev_info(). Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4 +++- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 3 ++- 2 files changed,

[PATCH V4 net-next 03/10] net: hns3: remove upgrade reset level when reset fail

2019-07-28 Thread Huazhong Tan
Currently, hclge_reset_err_handle() will assert a global reset when the failing count is smaller than MAX_RESET_FAIL_CNT, which will affect other running functions. So this patch removes this upgrading, and uses re-scheduling reset task to do it. Signed-off-by: Huazhong Tan Reviewed-by:

[PATCH V4 net-next 00/10] net: hns3: some code optimizations & bugfixes & features

2019-07-28 Thread Huazhong Tan
This patch-set includes code optimizations, bugfixes and features for the HNS3 ethernet controller driver. [patch 1/10] checks reset status before setting channel. [patch 2/10] adds a NULL pointer checking. [patch 3/10] removes reset level upgrading when current reset fails. [patch 4/10] fixes

[PATCH V4 net-next 01/10] net: hns3: add reset checking before set channels

2019-07-28 Thread Huazhong Tan
From: Jian Shen hns3_set_channels() should check the resetting status firstly, since the device will reinitialize when resetting. If the reset has not completed, the hns3_set_channels() may access invalid memory. Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan ---

[PATCH] scsi: megaraid: Fix possible null-pointer dereferences in megasas_complete_cmd()

2019-07-28 Thread Jia-Ju Bai
In megasas_complete_cmd(), there is an if statement on line 3411 to check whether cmd->scmd is NULL: if (cmd->scmd) When cmd->scmd is NULL, it is used at some places, such as on line 3286: cmd->scmd->result = alt_status << 16; on line 3295: cmd->scmd->scsi_done(cmd->scmd); on line

[PATCH net] net: ipv6: Fix a bug in ndisc_send_ns when netdev only has a global address

2019-07-28 Thread Su Yanjun
When we send mpls packets and the interface only has a manual global ipv6 address, then the two hosts cant communicate. I find that in ndisc_send_ns it only tries to get a ll address. In my case, the executive path is as below. ip6_output ->ip6_finish_output ->lwtunnel_xmit ->mpls_xmit

Re: [PATCH] mailbox: imx: add support for imx v1 mu

2019-07-28 Thread Dong Aisheng
On Mon, Jul 29, 2019 at 10:36 AM Richard Zhu wrote: > > There is a version1.0 MU on i.MX7ULP platform. > One new version ID register is added, and it's offset is 0. > TRn registers are defined at the offset 0x20 ~ 0x2C. > RRn registers are defined at the offset 0x40 ~ 0x4C. > SR/CR registers are

[PATCH] mailbox: imx: add support for imx v1 mu

2019-07-28 Thread Richard Zhu
There is a version1.0 MU on i.MX7ULP platform. One new version ID register is added, and it's offset is 0. TRn registers are defined at the offset 0x20 ~ 0x2C. RRn registers are defined at the offset 0x40 ~ 0x4C. SR/CR registers are defined at 0x60/0x64. Extend this driver to support it.

[PATCH] target: iscsi: iscsi_target_tpg: Fix a possible null-pointer dereference in iscsit_tpg_add_network_portal()

2019-07-28 Thread Jia-Ju Bai
In iscsit_tpg_add_network_portal(), there is an if statement on line 496 to check whether tpg->tpg_tiqn is NULL: if (tpg->tpg_tiqn) When tpg->tpg_tiqn is NULL, it is used on line 508: pr_debug(..., tpg->tpg_tiqn->tiqn, ...); Thus, a possible null-pointer dereference may occur. To fix

Re: [PATCH v2] kbuild: Fail if gold linker is detected

2019-07-28 Thread Masahiro Yamada
On Tue, Jul 23, 2019 at 5:17 PM Thomas Gleixner wrote: > > On Tue, 23 Jul 2019, Thomas Gleixner wrote: > > On Tue, 23 Jul 2019, Masahiro Yamada wrote: > > > Right. > > > I was able to build with ld.gold > > > > > > So, we can use gold, depending on the kernel configuration. > > > > That's exactly

Re: [PATCH V2] Kbuild: Handle PREEMPT_RT for version string and magic

2019-07-28 Thread Masahiro Yamada
On Mon, Jul 29, 2019 at 3:27 AM Thomas Gleixner wrote: > > Update the build scripts and the version magic to reflect when > CONFIG_PREEMPT_RT is enabled in the same way as CONFIG_PREEMPT is treated. > > The resulting version strings: > > Linux m 5.3.0-rc1+ #100 SMP Fri Jul 26 ... > Linux m

[PATCH] net: sched: Fix a possible null-pointer dereference in dequeue_func()

2019-07-28 Thread Jia-Ju Bai
In dequeue_func(), there is an if statement on line 74 to check whether skb is NULL: if (skb) When skb is NULL, it is used on line 77: prefetch(>end); Thus, a possible null-pointer dereference may occur. To fix this bug, skb->end is used when skb is not NULL. This bug is found by a

Re: [PATCH] iio: adc: sc27xx: Change to polling mode to read data

2019-07-28 Thread Baolin Wang
Hi Jonathan, On Sun, 28 Jul 2019 at 01:27, Jonathan Cameron wrote: > > On Thu, 25 Jul 2019 14:33:50 +0800 > Baolin Wang wrote: > > > From: Freeman Liu > > > > On Spreadtrum platform, the headphone will read one ADC channel multiple > > times to identify the headphone type, and the headphone

[BUG] infiniband: mlx5: a possible null-pointer dereference in set_roce_addr()

2019-07-28 Thread Jia-Ju Bai
In set_roce_addr(), there is an if statement on line 589 to check whether gid is NULL:     if (gid) When gid is NULL, it is used on line 613:     return mlx5_core_roce_gid_set(..., gid->raw, ...); Thus, a possible null-pointer dereference may occur. This bug is found by a static analysis tool

[PATCH] dma: stm32-mdma: Fix a possible null-pointer dereference in stm32_mdma_irq_handler()

2019-07-28 Thread Jia-Ju Bai
In stm32_mdma_irq_handler(), chan is checked on line 1368. When chan is NULL, it is still used on line 1369: dev_err(chan2dev(chan), "MDMA channel not initialized\n"); Thus, a possible null-pointer dereference may occur. To fix this bug, "dev_dbg(mdma2dev(dmadev), ...)" is used instead.

linux-next: manual merge of the tip tree with Linus' tree

2019-07-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tip tree got a conflict in: arch/x86/include/uapi/asm/types.h between commit: d9c525229521 ("treewide: add "WITH Linux-syscall-note" to SPDX tag of uapi headers") from Linus' tree and commit: 701010532164 ("x86/build: Remove unneeded uapi

[PATCH] x86: panic when a kernel stack overflow is detected

2019-07-28 Thread Daniel Axtens
Currently, when a kernel stack overflow is detected via VMAP_STACK, the task is killed with die(). This isn't safe, because we don't know how that process has affected kernel state. In particular, we don't know what locks have been taken. For example, we can hit a case with lkdtm where a thread

Re: [PATCH resend v2] lib: scatterlist: Fix to support no mapped sg

2019-07-28 Thread Zhou Wang
On 2019/7/24 11:54, Zhou Wang wrote: > In function sg_split, the second sg_calculate_split will return -EINVAL > when in_mapped_nents is 0. > > Indeed there is no need to do second sg_calculate_split and sg_split_mapped > when in_mapped_nents is 0, as in_mapped_nents indicates no mapped entry in

[PATCH v2] iio: light: si1145: Use device-managed APIs

2019-07-28 Thread Chuhong Yuan
Use device-managed APIs to simplify the code. The remove functions are redundant now and can be deleted. Signed-off-by: Chuhong Yuan --- Changes in v2: - Split v1 into two patches. - Use devm_iio_trigger_register in probe_trigger, delete redundant remove_trigger. - Return

[PATCH] staging: rtl8723bs: core: Remove unneeded variables sgi_20m,sgi_40m and sgi_80m

2019-07-28 Thread Hariprasad Kelam
htpriv.sgi_* variables are of type u8 ,instead of storing them in local variables ,its better to read value directly from structure. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

RE: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-28 Thread Anson Huang
Hi, Abel/Daniel > On 19-07-27 09:33:10, Daniel Baluta wrote: > > On Sat, Jul 27, 2019 at 9:19 AM Anson Huang > wrote: > > > > > > Hi, Daniel > > > > > > > Subject: Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag > > > > for IMX8MQ_CLK_TMU_ROOT > > > > > > > > Hi all, > > > > > > > >

Re: [PATCH 4.4 stable net] net: tcp: Fix use-after-free in tcp_write_xmit

2019-07-28 Thread maowenan
On 2019/7/27 19:40, Greg KH wrote: > On Sat, Jul 27, 2019 at 07:22:30PM +0800, maowenan wrote: >> >> >> On 2019/7/27 18:44, maowenan wrote: >>> >>> >>> On 2019/7/24 20:13, maowenan wrote: On 2019/7/24 19:05, Greg KH wrote: > On Wed, Jul 24, 2019 at 05:17:15PM +0800, Mao Wenan

Re: [PATCH v2 2/2] extcon: axp288: Use for_each_set_bit() in axp288_extcon_log_rsi()

2019-07-28 Thread Chanwoo Choi
On 19. 7. 26. 오후 9:18, Andy Shevchenko wrote: > This simplifies and standardizes axp288_extcon_log_rsi() > by using for_each_set_bit() library function. > > Signed-off-by: Andy Shevchenko > --- > drivers/extcon/extcon-axp288.c | 13 + > 1 file changed, 5 insertions(+), 8

Re: [PATCH V3 net-next 06/10] net: hns3: add debug messages to identify eth down cause

2019-07-28 Thread tanhuazhong
On 2019/7/28 10:03, David Miller wrote: From: Huazhong Tan Date: Sat, 27 Jul 2019 13:46:08 +0800 From: Yonglong Liu Some times just see the eth interface have been down/up via dmesg, but can not know why the eth down. So adds some debug messages to identify the cause for this.

Re: [PATCH v2 1/2] extcon: axp288: Add missed error check

2019-07-28 Thread Chanwoo Choi
On 19. 7. 26. 오후 9:18, Andy Shevchenko wrote: > It seems from the very beginning the error check has been missed > in axp288_extcon_log_rsi(). Add it here. > > Cc: Ramakrishna Pallala > Signed-off-by: Andy Shevchenko > --- > - added error message (Chanwoo) > drivers/extcon/extcon-axp288.c | 5

[PATCH] tracing: Prevent RCU EQS breakage in preemptirq events

2019-07-28 Thread Eiichi Tsukata
If context tracking is enabled, causing page fault in preemptirq irq_enable or irq_disable events triggers the following RCU EQS warning. Reproducer: // CONFIG_PREEMPTIRQ_EVENTS=y // CONFIG_CONTEXT_TRACKING=y // CONFIG_RCU_EQS_DEBUG=y # echo 1 > events/preemptirq/irq_disable/enable #

Re: [PATCH] ext4: Fix deadlock on page reclaim

2019-07-28 Thread Damien Le Moal
On 2019/07/29 8:42, Dave Chinner wrote: > On Sat, Jul 27, 2019 at 02:59:59AM +, Damien Le Moal wrote: >> On 2019/07/27 7:55, Theodore Y. Ts'o wrote: >>> On Sat, Jul 27, 2019 at 08:44:23AM +1000, Dave Chinner wrote: > > This looks like something that could hit every file systems, so

Re: next/master boot: 254 boots: 16 failed, 231 passed with 4 offline, 1 untried/unknown, 2 conflicts (next-20190726)

2019-07-28 Thread Bjorn Andersson
On Fri 26 Jul 06:48 PDT 2019, Mark Brown wrote: > On Fri, Jul 26, 2019 at 05:18:01AM -0700, kernelci.org bot wrote: > > The past few versions of -next failed to boot on apq8096-db820c: > > > defconfig: > > gcc-8: > > apq8096-db820c: 1 failed lab > > with an RCU stall

  1   2   3   4   >