Re: [PATCH v2] sound: dmasound_atari: Mark expected switch fall-through

On Mon, Jul 29, 2019 at 03:54:54PM -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: m68k): > > sound/oss/dmasound/dmasound_atari.c: warning: this statement may fall > through [-Wimplicit-fallthrough

Re: [PATCH] watchdog: scx200_wdt: Mark expected switch fall-through

On Mon, Jul 29, 2019 at 03:06:02PM -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: i386): > > drivers/watchdog/scx200_wdt.c: In function ‘scx200_wdt_ioctl’: > drivers/watchdog/scx200_wdt.c:188:3: w

Re: [PATCH V36 19/29] Lock down module params that specify hardware parameters (eg. ioport)

On Thu, Jul 18, 2019 at 12:45 PM Matthew Garrett wrote: > > From: David Howells > > Provided an annotation for module parameters that specify hardware > parameters (such as io ports, iomem addresses, irqs, dma channels, fixed > dma buffers and other types). > > Suggested-by: Alan Cox > Signed-of

Re: [RFC PATCH 00/16] KVM RISC-V Support

On 29/07/19 13:56, Anup Patel wrote: > This series adds initial KVM RISC-V support. Currently, we are able to boot > RISC-V 64bit Linux Guests with multiple VCPUs. > > Few key aspects of KVM RISC-V added by this series are: > 1. Minimal possible KVM world-switch which touches only GPRs and few CSR

[PATCH v2] libata: zpodd: Fix small read overflow in zpodd_get_mech_type()

Jeffrin reported a KASAN issue: BUG: KASAN: global-out-of-bounds in ata_exec_internal_sg+0x50f/0xc70 Read of size 16 at addr 91f41f80 by task scsi_eh_1/149 ... The buggy address belongs to the variable: cdb.48319+0x0/0x40

Re: [PATCH V36 23/29] bpf: Restrict bpf when kernel lockdown is in confidentiality mode

On Thu, Jul 18, 2019 at 12:45 PM Matthew Garrett wrote: > bpf_read() and bpf_read_str() could potentially be abused to (eg) allow > private keys in kernel memory to be leaked. Disable them if the kernel > has been locked down in confidentiality mode. > > Suggested-by: Alexei Starovoitov > Signed-

Re: [PATCH 1/2] ARM: dts: meson8b: add the nvmem cell with the board's MAC address

On Mon, Jul 29, 2019 at 9:11 AM Neil Armstrong wrote: > > Hi Martin, > > On 27/07/2019 21:46, Martin Blumenstingl wrote: > > Amlogic's BSP kernel defines that all boards with a MAC address stored > > in the eFuse have it at offset 0x1b4. It is up to the board to > > decide whether to use this MAC

Re: [Linux-kernel-mentees] [PATCH v2 01/11] PCI: Move #define PCI_PM_* lines to drivers/pci/pci.h

[+to Rafael, author of commits mentioned below] On Wed, Jul 24, 2019 at 05:38:38PM -0600, Kelsey Skunberg wrote: > The #define PCI_PM_* lines are only used within drivers/pci/ and they do > not need to be seen by the rest of the kernel. Move #define PCI_* to > drivers/pci/pci.h > > Signed-off-by:

Re: [PATCH v2] driver core: Remove device link creation limitation

On Mon, Jul 29, 2019 at 2:25 PM Rafael J. Wysocki wrote: > > On Mon, Jul 29, 2019 at 10:47 PM Saravana Kannan wrote: > > > > Rafael, > > > > This is the fix you need. Or something link this. > > > > I had asked you to reject DL_FLAG_MANAGED as an input flag if you are > > marking it as internal (

Re: Ingenic pinctrl patchs.

On Sun, Jul 14, 2019 at 8:55 AM Zhou Yanjie wrote: > Add support for Ingenic JZ4760, JZ4760B, X1000, X1000E and X1500. All 6 patches applied. Seems very straight-forward thanks for fixing this! Yours, Linus Walleij

Re: [PATCH v3] sched/core: Don't use dying mm as active_mm of kthreads

On 7/29/19 5:21 PM, Rik van Riel wrote: > On Mon, 2019-07-29 at 17:07 -0400, Waiman Long wrote: >> It was found that a dying mm_struct where the owning task has exited >> can stay on as active_mm of kernel threads as long as no other user >> tasks run on those CPUs that use it as active_mm. This pr

Re: [PATCH v2 QEMU] virtio-balloon: Provide a interface for "bubble hinting"

On Mon, Jul 29, 2019 at 1:49 PM Michael S. Tsirkin wrote: > > On Mon, Jul 29, 2019 at 01:21:32PM -0700, Alexander Duyck wrote: > > On Mon, Jul 29, 2019 at 12:25 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jul 29, 2019 at 09:58:04AM -0700, Alexander Duyck wrote: > > > > On Wed, Jul 24, 2019 a

Re: [PATCH] dt-bindings: pinctrl: aspeed: Strip unnecessary quotes

On Fri, Jul 12, 2019 at 8:17 AM Andrew Jeffery wrote: > Rob pointed out that we didn't need the noise of the quotes in a > separate review[1], so strip them out for consistency and avoid setting > a bad example. > > [1] https://lists.ozlabs.org/pipermail/linux-aspeed/2019-July/002009.html > > Sig

[tip:perf/urgent] libbpf: fix missing __WORDSIZE definition

Commit-ID: 8aa259b10a6a759c50137bbbf225df0c17ca5d27 Gitweb: https://git.kernel.org/tip/8aa259b10a6a759c50137bbbf225df0c17ca5d27 Author: Andrii Nakryiko AuthorDate: Thu, 18 Jul 2019 10:30:21 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 29 Jul 2019 10:18:08 -0300 libbpf: fi

Re: [PATCH -next] pinctrl: aspeed: Make aspeed_pinmux_ips static

On Thu, Jul 11, 2019 at 4:25 PM YueHaibing wrote: > Fix sparse warning: > > drivers/pinctrl/aspeed/pinmux-aspeed.c:8:12: warning: > symbol 'aspeed_pinmux_ips' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Patch applied with Andrew's ACK. Yours

[tip:perf/urgent] perf tools: Fix perf.data documentation units for memory size

Commit-ID: 2e9a06dda10aea81a17c623f08534dac6735434a Gitweb: https://git.kernel.org/tip/2e9a06dda10aea81a17c623f08534dac6735434a Author: Vince Weaver AuthorDate: Thu, 25 Jul 2019 11:57:43 -0400 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 29 Jul 2019 09:03:43 -0300 perf tools: F

[tip:perf/urgent] perf header: Fix use of unitialized value warning

Commit-ID: 20f9781f491360e7459c589705a2e4b1f136bee9 Gitweb: https://git.kernel.org/tip/20f9781f491360e7459c589705a2e4b1f136bee9 Author: Numfor Mbiziwo-Tiapo AuthorDate: Wed, 24 Jul 2019 16:44:58 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 29 Jul 2019 09:03:43 -0300 perf

[tip:perf/urgent] perf header: Fix divide by zero error if f_header.attr_size==0

Commit-ID: 7622236ceb167aa3857395f9bdaf871442aa467e Gitweb: https://git.kernel.org/tip/7622236ceb167aa3857395f9bdaf871442aa467e Author: Vince Weaver AuthorDate: Tue, 23 Jul 2019 11:06:01 -0400 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 29 Jul 2019 09:03:43 -0300 perf header:

Re: [PATCH v2] sched/core: Don't use dying mm as active_mm of kthreads

On 07/29/19 17:06, Waiman Long wrote: > On 7/29/19 4:18 AM, Qais Yousef wrote: > > On 07/27/19 13:10, Waiman Long wrote: > >> It was found that a dying mm_struct where the owning task has exited > >> can stay on as active_mm of kernel threads as long as no other user > >> tasks run on those CPUs th

[tip:perf/urgent] tools headers UAPI: Sync if_link.h with the kernel

Commit-ID: e54599c93dbf487ef80ba2833c5760c22bd20c32 Gitweb: https://git.kernel.org/tip/e54599c93dbf487ef80ba2833c5760c22bd20c32 Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 26 Jul 2019 15:44:41 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 29 Jul 2019 09:03:43 -0300 t

[tip:perf/urgent] tools headers UAPI: Sync sched.h with the kernel

Commit-ID: c093de6bd3c50d3dd597ff9fa5cf7a30acbb3eb7 Gitweb: https://git.kernel.org/tip/c093de6bd3c50d3dd597ff9fa5cf7a30acbb3eb7 Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 26 Jul 2019 15:41:09 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 29 Jul 2019 09:03:43 -0300 t

Re: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool

On 29/07/2019 15:08, Jose Abreu wrote: ... >>> Hi Catalin and Will, >>> >>> Sorry to add you in such a long thread but we are seeing a DMA issue >>> with stmmac driver in an ARM64 platform with IOMMU enabled. >>> >>> The issue seems to be solved when buffers allocation for DMA based >>> transfe

[tip:perf/urgent] tools headers UAPI: Sync usbdevice_fs.h with the kernels to get new ioctl

Commit-ID: 0f58163c9d5702efbc242d144fd038e54b4c6ad0 Gitweb: https://git.kernel.org/tip/0f58163c9d5702efbc242d144fd038e54b4c6ad0 Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 26 Jul 2019 15:31:25 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 29 Jul 2019 09:03:43 -0300 t

[tip:perf/urgent] tools perf beauty: Fix usbdevfs_ioctl table generator to handle _IOC()

Commit-ID: 7ee526152db7a75d7b8713346dac76ffc3662b29 Gitweb: https://git.kernel.org/tip/7ee526152db7a75d7b8713346dac76ffc3662b29 Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 26 Jul 2019 15:29:56 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 29 Jul 2019 09:03:42 -0300 t

[tip:perf/urgent] tools headers UAPI: Update tools's copy of drm.h headers

Commit-ID: 95dc663aa6382fec92674e748682cefeeb2bfc22 Gitweb: https://git.kernel.org/tip/95dc663aa6382fec92674e748682cefeeb2bfc22 Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 26 Jul 2019 15:00:24 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 29 Jul 2019 09:03:42 -0300 t

linux-next: Signed-off-by missing for commit in the coresight tree

Hi all, Commit 7d131e267b7c ("coresight: funnel: Convert pr_warn to dev_warn for obsolete bindings") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpVtqZ4pOMpo.pgp Description: OpenPGP digital signature

[tip:perf/urgent] tools headers UAPI: Update tools's copy of mman.h headers

Commit-ID: b830f94f7303a49d509d5b1bb34ecb2e648b23c4 Gitweb: https://git.kernel.org/tip/b830f94f7303a49d509d5b1bb34ecb2e648b23c4 Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 26 Jul 2019 12:49:00 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 29 Jul 2019 09:02:58 -0300 t

[tip:perf/urgent] tools headers UAPI: Update tools's copy of kvm.h headers

Commit-ID: e0d99c4d24fd8861da724b88ebd18a9fae8a2260 Gitweb: https://git.kernel.org/tip/e0d99c4d24fd8861da724b88ebd18a9fae8a2260 Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 26 Jul 2019 12:43:23 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 26 Jul 2019 12:43:23 -0300 t

[tip:perf/urgent] tools include UAPI: Sync x86's syscalls_64.tbl and generic unistd.h to pick up clone3 and pidfd_open

Commit-ID: 820571af721990e354649368e641313f85a29976 Gitweb: https://git.kernel.org/tip/820571af721990e354649368e641313f85a29976 Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 26 Jul 2019 12:31:28 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 26 Jul 2019 12:31:28 -0300 t

linux-next: Signed-off-by missing for commit in the mlx5-next tree

Hi all, Commit cc1c097b880a ("net/mlx5: fix -Wtype-limits compilation warnings") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgp6mtDmcXy77.pgp Description: OpenPGP digital signature

linux-next: Fixes tag needs some work in the net-next tree

Hi all, In commit 473d924d7d46 ("can: fix ioctl function removal") Fixes tag Fixes: 60649d4e0af ("can: remove obsolete empty ioctl() handler") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11 or

Re: [GIT PULL] perf/urgent fixes

; > perf/x86/intel: Mark expected switch fall-throughs (2019-07-25 15:57:03 > +0200) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > tags/perf-urgent-for-mingo-5.3-20190729 > > for you to fetch changes up

Re: [PATCH v2] driver core: Remove device link creation limitation

On Mon, Jul 29, 2019 at 10:47 PM Saravana Kannan wrote: > > Rafael, > > This is the fix you need. Or something link this. > > I had asked you to reject DL_FLAG_MANAGED as an input flag if you are > marking it as internal (in the comments). But looks like you were also > trying to check for "undefi

Re: [PATCH v3] sched/core: Don't use dying mm as active_mm of kthreads

On Mon, 2019-07-29 at 17:07 -0400, Waiman Long wrote: > It was found that a dying mm_struct where the owning task has exited > can stay on as active_mm of kernel threads as long as no other user > tasks run on those CPUs that use it as active_mm. This prolongs the > life time of dying mm holding up

[PATCH] watchdog device drivers:pc87413_wdt: Rewriting of pc87413_wdt driver to utilize common watchdog interface

There is a potential for the variable swc_base_addr in the call chain of the driver initialization function (init) to be used before initialization. This brought up the need for, by rewriting the driver to use the common watchdog interface, ensuring to have all resources in place. This patch addre

Re: [PATCH v2 3/6] pwm: jz4740: Apply configuration atomically

Hi Uwe, Le mer. 24 juil. 2019 à 2:47, Uwe =?iso-8859-1?q?Kleine-K=F6nig?= a écrit : Hello Paul, On Tue, Jul 23, 2019 at 04:46:40PM -0400, Paul Cercueil wrote: Le lun. 22 juil. 2019 à 15:34, Uwe =?iso-8859-1?q?Kleine-K=F6nig?= a écrit : > On Fri, Jun 07, 2019 at 05:44:07PM +0200, Paul Ce

[PATCH 04/12] tools headers UAPI: Update tools's copy of drm.h headers

From: Arnaldo Carvalho de Melo Picking the changes from: c5d3e39caa45 ("drm/i915: Engine discovery query") a88b6e4cbafd ("drm/i915: Allow specification of parallel execbuf") ee1136908e9b ("drm/i915/execlists: Virtual engine bonding") 6d06779e8672 ("drm/i915: Load balancing across a virtu

[PATCH 07/12] tools headers UAPI: Sync sched.h with the kernel

From: Arnaldo Carvalho de Melo To get the changes in: a509a7cd7974 ("sched/uclamp: Extend sched_setattr() to support utilization clamping") 1d6362fa0cfc ("sched/core: Allow sched_setattr() to use the current policy") 7f192e3cd316 ("fork: add clone3") And silence this perf build warning:

[PATCH 03/12] tools headers UAPI: Update tools's copy of mman.h headers

From: Arnaldo Carvalho de Melo To pick up the changes from: 8aa3c927ec10 ("mm/mmap: move common defines to mman-common.h") 22fcea6f85f2 ("mm: move MAP_SYNC to asm-generic/mman-common.h") 0bf5f9492389 ("mm: fix the MAP_UNINITIALIZED flag") To address the following perf build warnings: W

[GIT PULL] perf/urgent fixes

the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-5.3-20190729 for you to fetch changes up to 8aa259b10a6a759c50137bbbf225df0c17ca5d27: libbpf: fix missing __WORDSIZE definition (2019-07-29 10:18:08 -0300

[PATCH 09/12] perf header: Fix divide by zero error if f_header.attr_size==0

From: Vince Weaver So I have been having lots of trouble with hand-crafted perf.data files causing segfaults and the like, so I have started fuzzing the perf tool. First issue found: If f_header.attr_size is 0 in the perf.data file, then perf will crash with a divide-by-zero error. Committer n

[PATCH 05/12] tools perf beauty: Fix usbdevfs_ioctl table generator to handle _IOC()

From: Arnaldo Carvalho de Melo In addition to _IOW() and _IOR(), to handle this case: #define USBDEVFS_CONNINFO_EX(len) _IOC(_IOC_READ, 'U', 32, len) That will happen in the next sync of this header file. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Luis Cláudio Gonçalves Cc: Namhyung Kim Link:

[PATCH 06/12] tools headers UAPI: Sync usbdevice_fs.h with the kernels to get new ioctl

From: Arnaldo Carvalho de Melo To get the changes in: 6d101f24f1dd ("USB: add usbfs ioctl to retrieve the connection parameters") And address this perf build warning: Warning: Kernel ABI header at 'tools/include/uapi/linux/usbdevice_fs.h' differs from latest version at 'include/uapi/linux

[PATCH 02/12] tools headers UAPI: Update tools's copy of kvm.h headers

From: Arnaldo Carvalho de Melo Picking the changes from: 66bb8a065f5a ("KVM: x86: PMU Event Filter") f087a02941fe ("KVM: nVMX: Stash L1's CR3 in vmcs01.GUEST_CR3 on nested entry w/o EPT") 99adb567632b ("KVM: arm/arm64: Add save/restore support for firmware workaround state") Silencing t

[PATCH 08/12] tools headers UAPI: Sync if_link.h with the kernel

From: Arnaldo Carvalho de Melo To pick the changes in: 07a4ddec3ce9 ("bonding: add an option to specify a delay between peer notifications") And silence this build warning: Kernel ABI header at 'tools/include/uapi/linux/if_link.h' differs from latest version at 'include/uapi/linux/if_lin

Re: [PATCH] mips: avoid explicit UB in assignment of mips_io_port_base

On Mon, Jul 29, 2019 at 02:10:12PM -0700, Nick Desaulniers wrote: > The code in question is modifying a variable declared const through > pointer manipulation. Such code is explicitly undefined behavior, and > is the lone issue preventing malta_defconfig from booting when built > with Clang: > >

[PATCH 01/12] tools include UAPI: Sync x86's syscalls_64.tbl and generic unistd.h to pick up clone3 and pidfd_open

From: Arnaldo Carvalho de Melo 05a70a8ec287 ("unistd: protect clone3 via __ARCH_WANT_SYS_CLONE3") 8f3220a80654 ("arch: wire-up clone3() syscall") 7615d9e1780e ("arch: wire-up pidfd_open()") Silencing the following tools/perf build warnings Warning: Kernel ABI header at 'tools/include/ua

Re: [PATCH 03/14] sched,fair: redefine runnable_load_avg as the sum of task_h_load

On Mon, 2019-07-29 at 22:05 +0200, Peter Zijlstra wrote: > On Mon, Jul 22, 2019 at 01:33:37PM -0400, Rik van Riel wrote: > > @@ -3012,25 +2983,24 @@ static inline int > > throttled_hierarchy(struct cfs_rq *cfs_rq); > > static void update_cfs_group(struct sched_entity *se) > > { > > struct cfs

Re: [PATCH v3] sched/core: Don't use dying mm as active_mm of kthreads

On 7/29/19 5:07 PM, Waiman Long wrote: > It was found that a dying mm_struct where the owning task has exited > can stay on as active_mm of kernel threads as long as no other user > tasks run on those CPUs that use it as active_mm. This prolongs the > life time of dying mm holding up some resources

[PATCH] mips: avoid explicit UB in assignment of mips_io_port_base

The code in question is modifying a variable declared const through pointer manipulation. Such code is explicitly undefined behavior, and is the lone issue preventing malta_defconfig from booting when built with Clang: If an attempt is made to modify an object defined with a const-qualified type

Re: [PATCH] driver core: platform: return -ENXIO for missing GpioInt

On Mon, Jul 29, 2019 at 2:03 PM Brian Norris wrote: > > On Mon, Jul 29, 2019 at 1:54 PM Nathan Chancellor > wrote: > > On Mon, Jul 29, 2019 at 01:49:54PM -0700, Brian Norris wrote: > > > Side note: it might have helped alleviate some of this pain if there > > > were email notifications to the mai

Re: [PATCH] net: wan: sdla: Mark expected switch fall-through

From: "Gustavo A. R. Silva" Date: Mon, 29 Jul 2019 15:01:39 -0500 > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: i386): > > drivers/net/wan/sdla.c: In function ‘sdla_errors’: > drivers/net/wan/sdla.c:414:7: warning: this stateme

Re: [PATCH][V2] drivers: thermal: processor_thermal_device: fix missing bitwise-or operators

On Mon, 2019-07-29 at 13:03 +0100, Colin King wrote: > From: Colin Ian King > > The variable val is having the top 8 bits cleared and then the > variable is being > re-assinged and setting just the top 8 bits. I believe the intention > was bitwise-or > in the top 8 bits. Fix this by replacing t

Re: [RFC PATCH 15/16] RISC-V: KVM: Add SBI v0.1 support

On Mon, 2019-07-29 at 22:08 +0200, Paolo Bonzini wrote: > On 29/07/19 21:51, Atish Patra wrote: > > On Mon, 2019-07-29 at 21:40 +0200, Paolo Bonzini wrote: > > > On 29/07/19 13:57, Anup Patel wrote: > > > > + csr_write(CSR_HSTATUS, vcpu->arch.guest_context.hstatus > > > > | > > > > HSTATUS_S

[PATCH v3] sched/core: Don't use dying mm as active_mm of kthreads

It was found that a dying mm_struct where the owning task has exited can stay on as active_mm of kernel threads as long as no other user tasks run on those CPUs that use it as active_mm. This prolongs the life time of dying mm holding up some resources that cannot be freed on a mostly idle system.

Re: [PATCH v2] sched/core: Don't use dying mm as active_mm of kthreads

On 7/29/19 4:18 AM, Qais Yousef wrote: > On 07/27/19 13:10, Waiman Long wrote: >> It was found that a dying mm_struct where the owning task has exited >> can stay on as active_mm of kernel threads as long as no other user >> tasks run on those CPUs that use it as active_mm. This prolongs the >> lif

Re: [PATCH] driver core: platform: return -ENXIO for missing GpioInt

On Mon, Jul 29, 2019 at 1:54 PM Nathan Chancellor wrote: > On Mon, Jul 29, 2019 at 01:49:54PM -0700, Brian Norris wrote: > > Side note: it might have helped alleviate some of this pain if there > > were email notifications to the mailing list when a patch gets applied. > > I didn't realize (and I'

[PATCH] scsi: wd33c93: Mark expected swich fall-through

Mark switch cases where we are expecting to fall through. This patch fixes the following warning (Building: m68k): drivers/scsi/wd33c93.c: In function ‘round_4’: drivers/scsi/wd33c93.c:1856:11: warning: this statement may fall through [-Wimplicit-fallthrough=] case 2: ++x; ^~~ driv

Re: [PATCH] net: sctp: drop unneeded likely() call around IS_ERR()

From: "Enrico Weigelt, metux IT consult" Date: Mon, 29 Jul 2019 20:55:21 +0200 > From: Enrico Weigelt > > IS_ERR() already calls unlikely(), so this extra unlikely() call > around IS_ERR() is not needed. > > Signed-off-by: Enrico Weigelt Applied.

Re: [PATCH 5.2 083/215] net/ipv4: fib_trie: Avoid cryptic ternary expressions

On Mon, Jul 29, 2019 at 1:57 PM Matthias Kaehlcke wrote: > > On Mon, Jul 29, 2019 at 01:54:22PM -0700, Matthias Kaehlcke wrote: > > Hi Greg, > > > > Toralf just pointed out in another thread that the commit message and > > the content of this patch don't match (https://lkml.org/lkml/2019/7/29/1475

Re: [RFC] net: phy: read link status twice when phy_check_link_status()

On 29.07.2019 05:59, liuyonglong wrote: > > > On 2019/7/27 2:14, Heiner Kallweit wrote: >> On 26.07.2019 11:53, Yonglong Liu wrote: >>> According to the datasheet of Marvell phy and Realtek phy, the >>> copper link status should read twice, or it may get a fake link >>> up status, and cause up->d

Re: [PATCH 5.2 083/215] net/ipv4: fib_trie: Avoid cryptic ternary expressions

On Mon, Jul 29, 2019 at 01:54:22PM -0700, Matthias Kaehlcke wrote: > Hi Greg, > > Toralf just pointed out in another thread that the commit message and > the content of this patch don't match (https://lkml.org/lkml/2019/7/29/1475) > > I did some minor digging, the content of the queued patch is:

Re: [PATCH] driver core: platform: return -ENXIO for missing GpioInt

On Mon, Jul 29, 2019 at 1:50 PM Brian Norris wrote: > > Commit daaef255dc96 ("driver: platform: Support parsing GpioInt 0 in > platform_get_irq()") broke the Embedded Controller driver on most LPC > Chromebooks (i.e., most x86 Chromebooks), because cros_ec_lpc expects > platform_get_irq() to retur

[PATCH v2] Fix annotate.c use of uninitialized value error

Our local MSAN (Memory Sanitizer) build of perf throws a warning that comes from the "dso__disassemble_filename" function in "tools/perf/util/annotate.c" when running perf record. The warning stems from the call to readlink, in which "build_id_path" was being read into "linkname". Since readlink d

[v5 2/2] gpio: aspeed: Add SGPIO driver

Add SGPIO driver support for Aspeed AST2500 SoC. Signed-off-by: Hongwei Zhang --- drivers/gpio/sgpio-aspeed.c | 521 1 file changed, 521 insertions(+) create mode 100644 drivers/gpio/sgpio-aspeed.c diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers/

Re: [PATCH V2 2/4] drivers: qcom: rpmh-rsc: avoid locking in the interrupt handler

Quoting Lina Iyer (2019-07-29 12:01:39) > On Thu, Jul 25 2019 at 09:44 -0600, Doug Anderson wrote: > >On Thu, Jul 25, 2019 at 8:18 AM Lina Iyer wrote: > >> > >> On Wed, Jul 24 2019 at 17:28 -0600, Doug Anderson wrote: > >> > > >> >Jumping in without reading all the context, but I saw this fly by a

[PATCH v2] sound: dmasound_atari: Mark expected switch fall-through

Mark switch cases where we are expecting to fall through. This patch fixes the following warning (Building: m68k): sound/oss/dmasound/dmasound_atari.c: warning: this statement may fall through [-Wimplicit-fallthrough=]: => 1449:24 Notice that, in this particular case, the code comment is modifi

Re: [PATCH] driver core: platform: return -ENXIO for missing GpioInt

On Mon, Jul 29, 2019 at 01:49:54PM -0700, Brian Norris wrote: > Commit daaef255dc96 ("driver: platform: Support parsing GpioInt 0 in > platform_get_irq()") broke the Embedded Controller driver on most LPC > Chromebooks (i.e., most x86 Chromebooks), because cros_ec_lpc expects > platform_get_irq() t

Re: [PATCH 5.2 083/215] net/ipv4: fib_trie: Avoid cryptic ternary expressions

Hi Greg, Toralf just pointed out in another thread that the commit message and the content of this patch don't match (https://lkml.org/lkml/2019/7/29/1475) I did some minor digging, the content of the queued patch is: commit 4df607cc6fe8e46b258ff2a53d0a60ca3008ffc7 Author: Nathan Huckleberry Da

Re: platform/x86/pcengines-apuv2: Missing apu4

On 29.07.2019 10:35, Enrico Weigelt, metux IT consult wrote: On 26.07.19 16:56, Gerhard Wiesinger wrote: Hello, I saw that the apu4 board is completly missing (also on 5.3rc1). Can you please add it. Should be very easy, see below. Still in the pipeline - don't have an apu4 board for testing

Re: sched: Unexpected reschedule of offline CPU#2!

On Mon, Jul 29, 2019 at 12:47:45PM +0200, Peter Zijlstra wrote: > On Mon, Jul 29, 2019 at 12:38:30PM +0200, Thomas Gleixner wrote: > > On Mon, 29 Jul 2019, Peter Zijlstra wrote: > > > On Mon, Jul 29, 2019 at 11:58:24AM +0200, Thomas Gleixner wrote: > > > > On Mon, 29 Jul 2019, Peter Zijlstra wrote:

[PATCH] driver core: platform: return -ENXIO for missing GpioInt

Commit daaef255dc96 ("driver: platform: Support parsing GpioInt 0 in platform_get_irq()") broke the Embedded Controller driver on most LPC Chromebooks (i.e., most x86 Chromebooks), because cros_ec_lpc expects platform_get_irq() to return -ENXIO for non-existent IRQs. Unfortunately, acpi_dev_gpio_ir

Re: [PATCH v4 6/9] leds: multicolor: Introduce a multicolor class definition

Dan, On 7/25/19 8:28 PM, Dan Murphy wrote: > Introduce a multicolor class that groups colored LEDs > within a LED node. > > The framework allows for dynamically setting individual LEDs > or setting brightness levels of LEDs and updating them virtually > simultaneously. > > Signed-off-by: Dan Mur

Re: [PATCH v2 QEMU] virtio-balloon: Provide a interface for "bubble hinting"

On Mon, Jul 29, 2019 at 01:21:32PM -0700, Alexander Duyck wrote: > On Mon, Jul 29, 2019 at 12:25 PM Michael S. Tsirkin wrote: > > > > On Mon, Jul 29, 2019 at 09:58:04AM -0700, Alexander Duyck wrote: > > > On Wed, Jul 24, 2019 at 1:42 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Jul

Re: [PATCH 0/2] Don't use SIGMINSTKSZ when enforcing alternative signal stack size for compat tasks

On 2018-07-25 14:45, Will Deacon wrote: > Hi all, > > The Debian folks have observed a failure in the 32-bit arm glibc testsuite > when running under a 64-bit kernel. They tracked this down to sigaltstack(2) > enforcing the alternative signal stack to be at least SIGMINSTKSZ bytes, > which is high

Re: [PATCH] powerpc: workaround clang codegen bug in dcbz

On Mon, Jul 29, 2019 at 1:47 PM Nathan Chancellor wrote: > > On Mon, Jul 29, 2019 at 01:45:35PM -0700, Nick Desaulniers wrote: > > On Mon, Jul 29, 2019 at 1:32 PM Nathan Chancellor > > wrote: > > > > > > On Mon, Jul 29, 2019 at 01:25:41PM -0700, Nick Desaulniers wrote: > > > > But I'm not sure ho

Re: [PATCH v4 3/9] dt: bindings: Add multicolor class dt bindings documention

Dan, On 7/25/19 8:28 PM, Dan Murphy wrote: > Add DT bindings for the LEDs multicolor class framework. > > Signed-off-by: Dan Murphy > --- > .../bindings/leds/leds-class-multicolor.txt | 96 +++ > 1 file changed, 96 insertions(+) > create mode 100644 > Documentation/devicetre

Re: [PATCH] powerpc: workaround clang codegen bug in dcbz

On Mon, Jul 29, 2019 at 01:45:35PM -0700, Nick Desaulniers wrote: > On Mon, Jul 29, 2019 at 1:32 PM Nathan Chancellor > wrote: > > > > On Mon, Jul 29, 2019 at 01:25:41PM -0700, Nick Desaulniers wrote: > > > But I'm not sure how the inlined code generated would be affected. > > > > For the record:

Re: [PATCH v2] driver core: Remove device link creation limitation

Rafael, This is the fix you need. Or something link this. I had asked you to reject DL_FLAG_MANAGED as an input flag if you are marking it as internal (in the comments). But looks like you were also trying to check for "undefined" bit positions. However, the check isn't correct because DL_MANAGED

Re: [PATCH v4 2/9] documention: leds: Add multicolor class documentation

Dan, Now we will need this in rst format. It doesn't involve much tweaking to the txt, but some details like links to other documents can be enhanced. I've also come across an issue of lack of line break after listed quoted strings but I don't see such occurrence here. There might be still some o

Re: [PATCH] powerpc: workaround clang codegen bug in dcbz

On Mon, Jul 29, 2019 at 1:32 PM Nathan Chancellor wrote: > > On Mon, Jul 29, 2019 at 01:25:41PM -0700, Nick Desaulniers wrote: > > But I'm not sure how the inlined code generated would be affected. > > For the record: > > https://godbolt.org/z/z57VU7 > > This seems consistent with what Michael fou

Re: [PATCH v4 1/9] leds: multicolor: Add sysfs interface definition

Hi Dan, Thank you for the v4. I have a bunch of comments below. Please take a look. On 7/25/19 8:28 PM, Dan Murphy wrote: > Add a documentation of LED Multicolor LED class specific > sysfs attributes. > > Signed-off-by: Dan Murphy > --- > .../ABI/testing/sysfs-class-led-multicolor| 67 +++

Re: [PATCH] x86: drop REG_OUT macro from hweight functions

On Mon, Jul 29, 2019 at 12:04:47PM +0200, Peter Zijlstra wrote: > +#define _ASM_ARG1B __ASM_FORM_RAW(dil) > +#define _ASM_ARG2B __ASM_FORM_RAW(sil) > +#define _ASM_ARG3B __ASM_FORM_RAW(dl) > +#define _ASM_ARG4B __ASM_FORM_RAW(cl) > +#define _ASM_ARG5B __ASM_FORM_RAW(r8b) > +#define _ASM_A

[v6 2/2] gpio: aspeed: Add SGPIO driver

Hello Linus, Thanks for your detailed comments. We just submitted a v6 of sgpio-aspeed.c, it includes the updates based on your initial feedback: 1. fix a bug in aspeed_sgpio_dir_out() 2. some comments clean up. Regards, --Hongwei > From: Linus Walleij > Sent: Sunday, July 28, 2019 7:38 PM >

Re: Kernel patch commit message and content do differ

Hi, On Mon, Jul 29, 2019 at 10:20:25PM +0200, Toralf Förster wrote: > May I ask you to clarify why > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/diff/queue-5.2/net-ipv4-fib_trie-avoid-cryptic-ternary-expressions.patch?id=e1b76013997246a0d14b7443acbb393577d2a1e8 > speaks

Re: [PATCH] Use term cumul-fence instead of fence in ->prop ordering example

On Mon, 29 Jul 2019, Joel Fernandes (Google) wrote: > To reduce ambiguity in the more exotic ->prop ordering example, let us > use the term cumul-fence instead fence for the 2 fences, so that the > implict ->rfe on loads/stores to Y are covered by the description. > > Link: https://lore.kernel.or

Re: [PATCH v2] sched/core: Don't use dying mm as active_mm of kthreads

On 7/29/19 2:58 PM, Michal Hocko wrote: > On Mon 29-07-19 11:27:35, Waiman Long wrote: >> On 7/29/19 5:12 AM, Michal Hocko wrote: >>> On Sat 27-07-19 13:10:47, Waiman Long wrote: It was found that a dying mm_struct where the owning task has exited can stay on as active_mm of kernel thread

Re: [PATCH] ubifs: ubifs_tnc_start_commit: Fix OOB in layout_in_gaps

On Mon, Jul 29, 2019 at 6:51 PM Richard Weinberger wrote: > > - ubifs_assert(c, p < c->gap_lebs + c->lst.idx_lebs); > > + ubifs_assert(c, p < c->lst.idx_lebs); I wonder, doesn't this assert trigger too? -- Thanks, //richard

Re: [PATCH] powerpc: workaround clang codegen bug in dcbz

On Mon, Jul 29, 2019 at 01:25:41PM -0700, Nick Desaulniers wrote: > Commit 6c5875843b87 ("powerpc: slightly improve cache helpers") exposed > what looks like a codegen bug in Clang's handling of `%y` output > template with `Z` constraint. This is resulting in panics during boot > for 32b powerpc bu

[PATCH v2] Makefile: rules for printing kernel architecture and localversion

trivial rule to print out the kernel arch and localversion, so external tools, like distro packagers, can easily get it. v2: add help text Signed-off-by: Enrico Weigelt, metux IT consult --- Makefile | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Makefile b/Makefile index fa0fb

[v6 2/2] gpio: aspeed: Add SGPIO driver

Add SGPIO driver support for Aspeed AST2500 SoC. Signed-off-by: Hongwei Zhang --- drivers/gpio/sgpio-aspeed.c | 521 1 file changed, 521 insertions(+) create mode 100644 drivers/gpio/sgpio-aspeed.c diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers/

Re: [PATCH v2] powerpc: slightly improve cache helpers

On Thu, Jul 25, 2019 at 2:30 PM Nick Desaulniers wrote: > > On Mon, Jul 22, 2019 at 10:58 AM Segher Boessenkool > wrote: > > > > On Mon, Jul 22, 2019 at 10:21:07AM -0700, Nick Desaulniers wrote: > > > On Sun, Jul 21, 2019 at 11:19 PM Segher Boessenkool > > > wrote: > > > > On Sun, Jul 21, 2019 a

Re: [PATCH v2 4/7] ASoC: dt-bindings: Document dl-mask property

On Mon, Jul 29, 2019 at 11:15 PM Nicolin Chen wrote: > > On Sun, Jul 28, 2019 at 10:24:26PM +0300, Daniel Baluta wrote: > > SAI supports up to 8 data lines. This property let the user > > configure how many data lines should be used per transfer > > direction (Tx/Rx). > > This sounds a bit less pe

[PATCH] powerpc: workaround clang codegen bug in dcbz

Commit 6c5875843b87 ("powerpc: slightly improve cache helpers") exposed what looks like a codegen bug in Clang's handling of `%y` output template with `Z` constraint. This is resulting in panics during boot for 32b powerpc builds w/ Clang, as reported by our CI. Add back the original code that wor

Re: [PATCH 03/14] sched,fair: redefine runnable_load_avg as the sum of task_h_load

On Mon, Jul 22, 2019 at 01:33:37PM -0400, Rik van Riel wrote: > @@ -263,8 +258,8 @@ ___update_load_avg(struct sched_avg *sa, unsigned long > load, unsigned long runna > > int __update_load_avg_blocked_se(u64 now, struct sched_entity *se) > { > - if (___update_load_sum(now, &se->avg, 0, 0,

[PATCH] watchdog: scx200_wdt: Mark expected switch fall-through

Mark switch cases where we are expecting to fall through. This patch fixes the following warning (Building: i386): drivers/watchdog/scx200_wdt.c: In function ‘scx200_wdt_ioctl’: drivers/watchdog/scx200_wdt.c:188:3: warning: this statement may fall through [-Wimplicit-fallthrough=] scx200_wdt_

[PATCH] net: wan: sdla: Mark expected switch fall-through

Mark switch cases where we are expecting to fall through. This patch fixes the following warning (Building: i386): drivers/net/wan/sdla.c: In function ‘sdla_errors’: drivers/net/wan/sdla.c:414:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (cmd == SDLA_INFORMATION_W

[PATCH] net/socket: fix GCC8+ Wpacked-not-aligned warnings

In file included from ./include/linux/sctp.h:42, from net/core/skbuff.c:47: ./include/uapi/linux/sctp.h:395:1: warning: alignment 4 of 'struct sctp_paddr_change' is less than 8 [-Wpacked-not-aligned] } __attribute__((packed, aligned(4))); ^ ./include/uapi/linux/sctp.h:728:1: warn

RE: [PATCH net] hv_sock: Fix hang when a connection is closed

> From: Sunil Muthuswamy > Sent: Monday, July 29, 2019 10:21 AM > > --- a/net/vmw_vsock/hyperv_transport.c > > +++ b/net/vmw_vsock/hyperv_transport.c > > @@ -309,9 +309,16 @@ static void hvs_close_connection(struct > vmbus_channel *chan) > > { > > struct sock *sk = get_per_channel_state(chan)

Re: [PATCH v2 QEMU] virtio-balloon: Provide a interface for "bubble hinting"

On Mon, Jul 29, 2019 at 12:25 PM Michael S. Tsirkin wrote: > > On Mon, Jul 29, 2019 at 09:58:04AM -0700, Alexander Duyck wrote: > > On Wed, Jul 24, 2019 at 1:42 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Jul 24, 2019 at 04:29:27PM -0400, Nitesh Narayan Lal wrote: > > > > > > > > On 7/24/19

<    1   2   3   4   5   6   7   8   9   10   >