Re: [PATCH v5 10/11] usb-storage: remove single-use define for debugging

2019-09-06 Thread Jessica Yu
+++ Matthias Maennich [06/09/19 11:32 +0100]: USB_STORAGE was defined as "usb-storage: " and used in a single location as argument to printk. In order to be able to use the name 'USB_STORAGE', drop the definition and use the string directly for the printk call. Reviewed-by: Greg Kroah-Hartman

Re: [PATCH] tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts

2019-09-06 Thread Jan Lübbe
On Thu, 2019-08-29 at 20:09 -0400, Stefan Berger wrote: > From: Stefan Berger > > The tpm_tis_core has to set the TPM_CHIP_FLAG_IRQ before probing for > interrupts since there is no other place in the code that would set > it. Thanks for this patch! I tested it to fix a [ 13.198129] tpm

Re: [PATCH v4] watchdog: qcom: support pre-timeout when the bark irq is available

2019-09-06 Thread Guenter Roeck
On Thu, Sep 05, 2019 at 11:34:03PM +0200, Jorge Ramirez wrote: > On 9/5/19 23:19, Guenter Roeck wrote: > > On Thu, Sep 05, 2019 at 11:00:35PM +0200, Jorge Ramirez-Ortiz wrote: > >> Use the bark interrupt as the pre-timeout notifier whenever this > >> interrupt is available. > >> > >> By default,

[PATCH 03/13] scsi: hisi_sas: Directly return when running I_T_nexus reset if phy disabled

2019-09-06 Thread John Garry
From: Luo Jiaxing At hisi_sas_debug_I_T_nexus_reset(), we call sas_phy_reset() to reset a phy. But if the phy is disabled, sas_phy_reset() will directly return -ENODEV without issue a phy reset request. If so, We can directly return -ENODEV to libsas before issue a phy reset. Signed-off-by:

[PATCH 05/13] scsi: hisi_sas: Retry 3 times TMF IO for SAS disks when init device

2019-09-06 Thread John Garry
From: Xiang Chen When init device for SAS disks, it will send TMF IO to clear disks. At that times TMF IO is broken by some operations such as injecting controller reset from HW RAs event, the TMF IO will be timeout, and at last device will be gone. Print is as followed: hisi_sas_v3_hw

Re: [PATCH 2/3] nfp: Drop unnecessary continue in nfp_net_pf_alloc_vnics

2019-09-06 Thread David Miller
From: zhong jiang Date: Wed, 4 Sep 2019 11:46:23 +0800 > Continue is not needed at the bottom of a loop. > > Signed-off-by: zhong jiang Applied to net-next.

[PATCH 00/13] hisi_sas: Some misc patches

2019-09-06 Thread John Garry
This patchset includes support for some more minor features, a bit of tidying, and a few patches to make the driver a bit more robust. Notables: - BIST phy loopback support - Fix for NCQ tags - Correctly config registers after controller reset Luo Jiaxing (7): scsi: hisi_sas: add debugfs

[PATCH 07/13] scsi: hisi_sas: Assign NCQ tag for all NCQ commands

2019-09-06 Thread John Garry
From: Xiang Chen Currently the NCQ tag is only assigned for FPDMA READ and FPDMA WRITE commands, and for other NCQ commands (such as FPDMA SEND), their NCQ tags are set in the delivery command to 0. So for all the NCQ commands, we also need to assign normal NCQ tag for them, so drop the command

[PATCH 06/13] scsi: hisi_sas: Update all the registers after suspend and resume

2019-09-06 Thread John Garry
From: Xiang Chen After suspend and resume, the HW registers will be set back to their initial value. We use init_reg_v3_hw() to set some registers, but some registers are set via firmware in ACPI "_RST" method, so add reset handler before init_reg_v3_hw(). Signed-off-by: Xiang Chen

[PATCH 13/13] scsi: hisi_sas: Fix the conflict between device gone and host reset

2019-09-06 Thread John Garry
From: Xiang Chen When device gone, it will check whether it is during reset, if not, it will send internal task abort. Before internal task abort returned, reset begins, and it will check whether SAS_PHY_UNUSED is set, if not, it will call hisi_sas_init_device(), but at that time domain_device

[PATCH 12/13] scsi: hisi_sas: Add BIST support for phy loopback

2019-09-06 Thread John Garry
From: Xiang Chen Add BIST (built in self test) support for phy loopback. Through the new debugfs interface, the user can configure loopback mode/linkrate/phy id/code mode before enabling it. And also user can enable/disable BIST function. Signed-off-by: Xiang Chen Signed-off-by: John Garry

[PATCH 02/13] scsi: hisi_sas: Use true/false as input parameter of sas_phy_reset()

2019-09-06 Thread John Garry
From: Luo Jiaxing When calling sas_phy_reset(), we need to specify whether the reset type is hard reset or link reset - use true/false for clarity. Signed-off-by: Luo Jiaxing Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 04/13] scsi: hisi_sas: Remove sleep after issue phy reset if sas_smp_phy_control() fails

2019-09-06 Thread John Garry
From: Luo Jiaxing At expander environment, we delay after issue phy reset to wait for hardware to handle phy reset. But if sas_smp_phy_control() fails, the delay is unnecessary so remove it. Signed-off-by: Luo Jiaxing Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 5

[PATCH 08/13] scsi: hisi_sas: Remove hisi_sas_hw.slot_complete

2019-09-06 Thread John Garry
From: Luo Jiaxing We never call hisi_sas_hw.slot_complete, so remove it. Signed-off-by: Luo Jiaxing Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 2 -- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 1 - drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 1 -

[PATCH 10/13] scsi: hisi_sas: Remove some unused function arguments

2019-09-06 Thread John Garry
From: Luo Jiaxing Some function arguments are unused, so remove them. Also move the timeout print in for wait_cmds_complete_timeout_vX_hw() callsites into that same function. Signed-off-by: Luo Jiaxing Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 4 ++--

[PATCH 09/13] scsi: hisi_sas: Remove redundant work declaration

2019-09-06 Thread John Garry
From: Xiang Chen Remove redundant work declaration in HISI_SAS_DECLARE_RST_WORK_ON_STACK Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h

[PATCH 11/13] scsi: hisi_sas: Add hisi_sas_debugfs_alloc() to centralise allocation

2019-09-06 Thread John Garry
From: Luo Jiaxing We extract the code of memory allocate and construct an new function for it. We think it's convenient for subsequent optimization. Signed-off-by: Luo Jiaxing Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 102 +++--- 1 file

[PATCH 01/13] scsi: hisi_sas: add debugfs auto-trigger for internal abort time out

2019-09-06 Thread John Garry
From: Luo Jiaxing This trigger is add at _hisi_sas_internal_task_abort() Signed-off-by: Luo Jiaxing Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c

[PATCH] memcg, kmem: do not fail __GFP_NOFAIL charges

2019-09-06 Thread Michal Hocko
From: Michal Hocko Thomas has noticed the following NULL ptr dereference when using cgroup v1 kmem limit: BUG: unable to handle kernel NULL pointer dereference at 0008 PGD 0 P4D 0 Oops: [#1] PREEMPT SMP PTI CPU: 3 PID: 16923 Comm: gtk-update-icon Not tainted 4.19.51 #42 Hardware

[RFC 2/2] dt-bindings: mmc: sdhci-msm: Add Bus BW vote supported strings

2019-09-06 Thread Pradeep P V K
Add Bus bandwidth voting supported strings for qcom-sdhci controller. Signed-off-by: Pradeep P V K --- .../devicetree/bindings/mmc/sdhci-msm.txt | 32 ++ 1 file changed, 32 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt

[RFC 1/2] mmc: sdhci-msm: Add support for bus bandwidth voting

2019-09-06 Thread Pradeep P V K
Vote for the MSM bus bandwidth required by SDHC driver based on the clock frequency and bus width of the card. Otherwise,the system clocks may run at minimum clock speed and thus affecting the performance. This change is based on Georgi Djakov [RFC] (https://lkml.org/lkml/2018/10/11/499)

Re: general protection fault in dev_map_hash_update_elem

2019-09-06 Thread Jesper Dangaard Brouer
On Thu, 5 Sep 2019 14:44:37 -0700 Alexei Starovoitov wrote: > On Thu, Sep 5, 2019 at 1:08 PM syzbot > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:6d028043 Add linux-next specific files for 20190830 > > git tree: linux-next > > console output:

[RFC 0/2] Add Support for SDHC bus bandwidth voting

2019-09-06 Thread Pradeep P V K
Vote for the MSM bus bandwidth required by SDHC driver based on the clock speed and bus width of the card. Otherwise, the system clocks may run at minimum clock speed and thus affecting the performance. Adapt to the new ICB framework for bus bandwidth voting. This requires the source/destination

Re: [PATCH v2 3/7] mm: Introduce FAULT_FLAG_INTERRUPTIBLE

2019-09-06 Thread David Hildenbrand
On 06.09.19 14:38, Peter Xu wrote: > On Fri, Sep 06, 2019 at 11:02:22AM +0200, David Hildenbrand wrote: >> On 05.09.19 12:15, Peter Xu wrote: >>> handle_userfaultfd() is currently the only one place in the kernel >>> page fault procedures that can respond to non-fatal userspace signals. >>> It was

Re: [RFC 1/2] mmc: sdhci-msm: Add support for bus bandwidth voting

2019-09-06 Thread ppvk
+Georgi Djakov On 2019-09-06 18:17, Pradeep P V K wrote: Vote for the MSM bus bandwidth required by SDHC driver based on the clock frequency and bus width of the card. Otherwise,the system clocks may run at minimum clock speed and thus affecting the performance. This change is based on Georgi

Re: [PATCH 2/2] vhost: re-introducing metadata acceleration through kernel virtual address

2019-09-06 Thread Jason Wang
On 2019/9/6 上午11:21, Hillf Danton wrote: On Thu, 5 Sep 2019 20:27:36 +0800 From: Jason Wang +static void vhost_set_map_dirty(struct vhost_virtqueue *vq, + struct vhost_map *map, int index) +{ + struct vhost_uaddr *uaddr = >uaddrs[index]; + int i;

Re: [PATCH] x86/microcode: Add an option to reload microcode even if revision is unchanged

2019-09-06 Thread Thomas Gleixner
Raj, On Thu, 5 Sep 2019, Raj, Ashok wrote: > On Thu, Sep 05, 2019 at 11:22:31PM +0200, Thomas Gleixner wrote: > > That's all nice, but what it the general use case for this outside of > > Intel's > > microcode development and testing? > > > > We all know that late microcode loading has severe

Re: [RFC PATCH 2/2] livepatch: Clear relocation targets on a module removal

2019-09-06 Thread Miroslav Benes
> > Now, I don't think that replacing .ko on disk is a good idea. We've > > already discussed it. It would lead to a maintenance/packaging problem, > > because you never know which version of the module is loaded in the > > system. The state space grows rather rapidly there. > > What exactly

[PATCH] phy: xgene: make array serdes_reg static const, makes object smaller

2019-09-06 Thread Colin King
From: Colin Ian King Don't populate the array serdes_reg on the stack but instead make it static const. Makes the object code smaller by 228 bytes. Before: textdata bss dec hex filename 238756232 64 3017175db drivers/phy/phy-xgene.o After: textdata

Re: [RFC PATCH 1/9] sched,cgroup: Add interface for latency-nice

2019-09-06 Thread Parth Shah
On 9/5/19 6:37 PM, Patrick Bellasi wrote: > > On Thu, Sep 05, 2019 at 12:46:37 +0100, Valentin Schneider wrote... > >> On 05/09/2019 12:18, Patrick Bellasi wrote: There's a few things wrong there; I really feel that if we call it nice, it should be like nice. Otherwise we should

mtd raw nand denali.c broken for Intel/Altera Cyclone V

2019-09-06 Thread Tim Sander
Hi I have noticed that there multiple breakages piling up for the denali nand driver on the Intel/Altera Cyclone V. Unfortunately i had no time to track the mainline kernel closely. So the breakage seems to pile up. I am a little disapointed that Intel is not on the lookout that the kernel works

Re: [RFC PATCH v4 0/9] printk: new ringbuffer implementation

2019-09-06 Thread Petr Mladek
On Fri 2019-09-06 11:06:27, Peter Zijlstra wrote: > On Thu, Sep 05, 2019 at 04:31:18PM +0200, Peter Zijlstra wrote: > > So I have something roughly like the below; I'm suggesting you add the > > line with + on: > > > > int early_vprintk(const char *fmt, va_list args) > > { > > char

[PATCH] virtio: add VIRTIO_RING_NO_LEGACY

2019-09-06 Thread Matej Genci
Add macro to disable legacy functions vring_init and vring_size. Signed-off-by: Matej Genci --- include/uapi/linux/virtio_ring.h | 4 1 file changed, 4 insertions(+) diff --git a/include/uapi/linux/virtio_ring.h b/include/uapi/linux/virtio_ring.h index 4c4e24c291a5..496db2f33830 100644

Re: [PATCH 1/3] software node: implement reference properties

2019-09-06 Thread Andy Shevchenko
On Fri, Sep 06, 2019 at 02:17:44PM +0300, Heikki Krogerus wrote: > On Thu, Sep 05, 2019 at 09:38:07PM -0700, Dmitry Torokhov wrote: > > It is possible to store references to software nodes in the same fashion as > > other static properties, so that users do not need to define separate > >

Re: [PATCH 3/3] software node: remove separate handling of references

2019-09-06 Thread Andy Shevchenko
On Thu, Sep 05, 2019 at 09:38:09PM -0700, Dmitry Torokhov wrote: > Now that all users of references have moved to reference properties, > we can remove separate handling of references. This is good one! -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 3/7] mm: Introduce FAULT_FLAG_INTERRUPTIBLE

2019-09-06 Thread Peter Xu
On Fri, Sep 06, 2019 at 11:02:22AM +0200, David Hildenbrand wrote: > On 05.09.19 12:15, Peter Xu wrote: > > handle_userfaultfd() is currently the only one place in the kernel > > page fault procedures that can respond to non-fatal userspace signals. > > It was trying to detect such an allowance by

[PATCHv3-next 3/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to HDMI supply

2019-09-06 Thread Anand Moon
As per schematics HDMI_P5V0 is supplied by P5V0 so add missing link. Cc: Martin Blumenstingl Cc: Jerome Brunet Cc: Neil Armstrong Reviewed-by: Neil Armstrong Reviewed-by: Martin Blumenstingl Signed-off-by: Anand Moon --- Changes from previous Patchv1 - As per Martin's suggestion added the

[PATCHv3-next 1/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to P5V0 regulator

2019-09-06 Thread Anand Moon
As per schematics VDDIO_AO18, VDDIO_AO3V3/VDD3V3 DDR3_1V5/DDR_VDDC: fixed regulator output which is supplied by P5V0. Cc: Martin Blumenstingl Cc: Jerome Brunet Cc: Neil Armstrong Reviewed-by: Neil Armstrong Reviewed-by: Martin Blumenstingl Signed-off-by: Anand Moon --- Changes from

[PATCHv3-next 2/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to VDDIO_AO3V3 regulator

2019-09-06 Thread Anand Moon
As per schematics TFLASH_VDD, TF_IO, VCC3V3 fixed regulator output which is supplied by VDDIO_AO3V3. While here, move the comment name with the signal name in the schematics above the gpio property to make it consistent with other regulators. Cc: Martin Blumenstingl Cc: Jerome Brunet Cc: Neil

[PATCHv3-next 0/3] Odroid c2 missing regulator linking

2019-09-06 Thread Anand Moon
Below small changes help re-configure or fix missing inter linking of regulator node. Re-based on linux-next-20190904 Changes from previous patch's series. Build using Cross Compiler. Added missing Reviewed-by Neil's and Martin. Added few suggestion from martin for rename of node. Dependencies:

[PATCH] net: stmmac: socfpga: re-use the `interface` parameter from platform data

2019-09-06 Thread Alexandru Ardelean
The socfpga sub-driver defines an `interface` field in the `socfpga_dwmac` struct and parses it on init. The shared `stmmac_probe_config_dt()` function also parses this from the device-tree and makes it available on the returned `plat_data` (which is the same data available via `netdev_priv()`).

Re: [RFC PATCH 1/9] sched,cgroup: Add interface for latency-nice

2019-09-06 Thread Parth Shah
On 9/5/19 3:15 PM, Patrick Bellasi wrote: > > On Thu, Sep 05, 2019 at 09:31:27 +0100, Peter Zijlstra wrote... > >> On Fri, Aug 30, 2019 at 10:49:36AM -0700, subhra mazumdar wrote: >>> Add Cgroup interface for latency-nice. Each CPU Cgroup adds a new file >>> "latency-nice" which is shared by

Re: [PATCH 1/3] software node: implement reference properties

2019-09-06 Thread Andy Shevchenko
On Thu, Sep 05, 2019 at 09:38:07PM -0700, Dmitry Torokhov wrote: > It is possible to store references to software nodes in the same fashion as > other static properties, so that users do not need to define separate > structures: > > const struct software_node gpio_bank_b_node = { > .name =

Re: [PATCH v2] swiotlb-xen: Convert to use macro

2019-09-06 Thread Souptick Joarder
On Mon, Sep 2, 2019 at 2:04 PM Souptick Joarder wrote: > > Rather than using static int max_dma_bits, this > can be coverted to use as macro. > > Signed-off-by: Souptick Joarder > Reviewed-by: Juergen Gross If it is still not late, can we get this patch in queue for 5.4 ? > --- >

Re: [PATCH] mm/memory.c: Convert to use vmf_error()

2019-09-06 Thread Souptick Joarder
On Fri, Sep 6, 2019 at 12:29 AM Matthew Wilcox wrote: > > On Fri, Sep 06, 2019 at 12:13:00AM +0530, Souptick Joarder wrote: > > +++ b/mm/memory.c > > @@ -1750,13 +1750,10 @@ static vm_fault_t __vm_insert_mixed(struct > > vm_area_struct *vma, > > } else { > > return

Re: [RFC PATCH 1/9] sched,cgroup: Add interface for latency-nice

2019-09-06 Thread Parth Shah
On 9/5/19 3:41 PM, Patrick Bellasi wrote: > > On Thu, Sep 05, 2019 at 07:15:34 +0100, Parth Shah wrote... > >> On 9/4/19 11:02 PM, Tim Chen wrote: >>> On 8/30/19 10:49 AM, subhra mazumdar wrote: Add Cgroup interface for latency-nice. Each CPU Cgroup adds a new file "latency-nice"

[PATCHv3-next 0/3] Odroid c2 missing regulator linking

2019-09-06 Thread Anand Moon
Below small changes help re-configure or fix missing inter linking of regulator node. Re-based on linux-next-20190904 Changes from previous patch's series. Build using Cross Compiler. Added missing Reviewed-by Neil's and Martin. Added few suggestion from martin for rename of node. Dependencies:

[PATCH] mt76: mt76x0e: make array mt76x0_chan_map static const, makes object smaller

2019-09-06 Thread Colin King
From: Colin Ian King Don't populate the array mt76x0_chan_map on the stack but instead make it static const. Makes the object code smaller by 80 bytes. Before: textdata bss dec hex filename 76851192 0887722ad mediatek/mt76/mt76x0/eeprom.o After: text

RE: [PATCH v2 0/2] char: tpm: add new driver for tpm i2c ptp

2019-09-06 Thread Benoit HOUYERE
Hi Steffen, We have performed test against your simple implementation. For basic test it was ok, however for stress test, your implementation does not take in account NACK and it failed. In PTP document, in chapter7.2.2.1.2 (Register write with address NACK), it indicates : "it's a good

Re: /dev/mem and secure boot

2019-09-06 Thread Greg Kroah-Hartman
On Fri, Sep 06, 2019 at 01:02:21PM +0200, Jean Delvare wrote: > I've been bitten recently by mcelog not working on machines started in > secure boot mode. mcelog tries to read DMI information from /dev/mem > and fails to open it. What do you mean by "secure boot"? Is this matthew's patchset that

Re: [PATCH 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories

2019-09-06 Thread Lukasz Luba
On 9/6/19 1:50 PM, Krzysztof Kozlowski wrote: > On Fri, 6 Sep 2019 at 13:39, Lukasz Luba wrote: >> >> Hi Krzysztof, >> >> On 9/6/19 12:56 PM, Krzysztof Kozlowski wrote: >>> On Fri, 6 Sep 2019 at 12:14, Lukasz Luba wrote: Add description of bindings for Samsung k3qf2f20db LPDDR3

Re: [PATCH 00/18] virtiofs: Fix various races and cleanups round 1

2019-09-06 Thread Vivek Goyal
On Fri, Sep 06, 2019 at 01:52:41PM +0200, Miklos Szeredi wrote: > On Fri, Sep 6, 2019 at 12:36 PM Stefan Hajnoczi wrote: > > > > On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: > > > On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal wrote: > > > > > > > > Hi, > > > > > > > > Michael

Re: [PATCH 18/18] virtiofs: Remove TODO item from virtio_fs_free_devs()

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 03:48:59PM -0400, Vivek Goyal wrote: > virtio_fs_free_devs() is now called from ->kill_sb(). By this time > all device queues have been quiesced. I am assuming that while > ->kill_sb() is in progress, another mount instance will wait for > it to finish (sb->s_umount mutex

[PATCH v4 1/4] arm64: mm: use arm64_dma_phys_limit instead of calling max_zone_dma_phys()

2019-09-06 Thread Nicolas Saenz Julienne
By the time we call zones_sizes_init() arm64_dma_phys_limit already contains the result of max_zone_dma_phys(). We use the variable instead of calling the function directly to save some precious cpu time. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Catalin Marinas ---

[PATCH v4 4/4] mm: refresh ZONE_DMA and ZONE_DMA32 comments in 'enum zone_type'

2019-09-06 Thread Nicolas Saenz Julienne
These zones usage has evolved with time and the comments were outdated. This joins both ZONE_DMA and ZONE_DMA32 explanation and gives up to date examples on how they are used on different architectures. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Christoph Hellwig Reviewed-by: Catalin

[PATCH v4 3/4] arm64: use both ZONE_DMA and ZONE_DMA32

2019-09-06 Thread Nicolas Saenz Julienne
So far all arm64 devices have supported 32 bit DMA masks for their peripherals. This is not true anymore for the Raspberry Pi 4 as most of it's peripherals can only address the first GB of memory on a total of up to 4 GB. This goes against ZONE_DMA32's intent, as it's expected for ZONE_DMA32 to

[PATCH v4 0/4] Raspberry Pi 4 DMA addressing support

2019-09-06 Thread Nicolas Saenz Julienne
Hi all, this series attempts to address some issues we found while bringing up the new Raspberry Pi 4 in arm64 and it's intended to serve as a follow up of these discussions: v3: https://lkml.org/lkml/2019/9/2/589 v2: https://lkml.org/lkml/2019/8/20/767 v1: https://lkml.org/lkml/2019/7/31/922 RFC:

[PATCH] gpio/mpc8xxx: change irq handler from chained to normal

2019-09-06 Thread Hui Song
From: Song Hui more one gpio controller use share one interrupt, make request interrupt to be shared. Signed-off-by: Laurentiu Tudor Signed-off-by: Alex Marginean Signed-off-by: Song Hui --- drivers/gpio/gpio-mpc8xxx.c | 20 +--- 1 file changed, 13 insertions(+), 7

Re: [PATCH 17/18] virtiofs: Remove TODO to quiesce/end_requests

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 03:48:58PM -0400, Vivek Goyal wrote: > We now stop queues and drain all the pending requests from all virtqueues. > So this is not a TODO anymore. > > Got rid of incrementing fc->dev_count as well. It did not seem meaningful > for virtio_fs. > > Signed-off-by: Vivek Goyal

[PATCH] kunit: Fix '--build_dir' option

2019-09-06 Thread SeongJae Park
kunit fails to run with '--build_dir' option because the option is not properly sent to kernel running procedure. This commit fixes the problem. Signed-off-by: SeongJae Park --- tools/testing/kunit/kunit.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v4 2/4] arm64: rename variables used to calculate ZONE_DMA32's size

2019-09-06 Thread Nicolas Saenz Julienne
Let the name indicate that they are used to calculate ZONE_DMA32's size as opposed to ZONE_DMA. Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Catalin Marinas --- arch/arm64/mm/init.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git

Re: [PATCH 16/18] virtiofs: Use virtio_fs_mutex for races w.r.t ->remove and mount path

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 03:48:57PM -0400, Vivek Goyal wrote: > It is possible that a mount is in progress and device is being removed at > the same time. Use virtio_fs_mutex to avoid races. > > This also takes care of bunch of races and removes some TODO items. > > Signed-off-by: Vivek Goyal >

[PATCH v2 6/6] scripts/spdxcheck.py: check if the line number follows the strict rule

2019-09-06 Thread Mauro Carvalho Chehab
There is a very strict rule saying on what line a SPDX header should be. Add an optional pedantic check for it. When the check is enabled, it will verify if the file has the SPDX header "at the first possible line in a file which can contain a comment", as stated at:

Re: [PATCH 15/18] virtiofs: Make virtio_fs object refcounted

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 03:48:56PM -0400, Vivek Goyal wrote: > This object is used both by fuse_connection as well virt device. So make > this object reference counted and that makes it easy to define life cycle > of the object. > > Now deivce can be removed while filesystem is still mounted.

Re: [PATCH 14/18] virtiofs: Add a fuse_iqueue operation to put() reference

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 03:48:55PM -0400, Vivek Goyal wrote: > diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h > index 85e2dcad68c1..04e2c000d63f 100644 > --- a/fs/fuse/fuse_i.h > +++ b/fs/fuse/fuse_i.h > @@ -479,6 +479,11 @@ struct fuse_iqueue_ops { >*/ > void

RE: [RFC PATCH 3/3] Enable ptp_kvm for arm64

2019-09-06 Thread Jianyong Wu (Arm Technology China)
Hi Marc, Very sorry to have missed this comments. > -Original Message- > From: Marc Zyngier > Sent: Thursday, August 29, 2019 6:33 PM > To: Jianyong Wu (Arm Technology China) ; > net...@vger.kernel.org; pbonz...@redhat.com; > sean.j.christopher...@intel.com; richardcoch...@gmail.com;

Re: [PATCH] soundwire: add back ACPI dependency

2019-09-06 Thread Arnd Bergmann
On Fri, Sep 6, 2019 at 12:45 PM Vinod Koul wrote: > On 06-09-19, 12:02, Arnd Bergmann wrote: > > On Fri, Sep 6, 2019 at 6:39 AM Vinod Koul wrote: > > > > > > On 05-09-19, 22:35, Arnd Bergmann wrote: > > > > Soundwire gained a warning for randconfig builds without > > > > CONFIG_ACPI during the

[RFC PATCH v2 06/13] media: mtk-vcodec: abstract firmware interface

2019-09-06 Thread Alexandre Courbot
From: Yunfei Dong MT8183's codec firwmare is run by a different remote processor from MT8173. While the firmware interface is basically the same, the way to invoke it differs. Abstract all firmware calls under a layer that will allow us to handle both firmware types transparently.

[RFC PATCH v2 09/13] media: doc: Add documentation for MM21 video format

2019-09-06 Thread Alexandre Courbot
Add the documentation for the MM21 video format, used by the MT8183 codec and MDP3 image processor. Signed-off-by: Alexandre Courbot --- Documentation/media/uapi/v4l/pixfmt-reserved.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git

[RFC PATCH v2 08/13] media: add Mediatek's MM21 format

2019-09-06 Thread Alexandre Courbot
Add Mediatek's non-compressed 8 bit block video mode. This format is produced by the MT8183 codec and can be converted to a non-proprietary format with the MDP3 component. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 +

Re: [PATCH] Bluetooth: hidp: Fix error checks in hidp_get/set_raw_report

2019-09-06 Thread Dan Carpenter
On Fri, Sep 06, 2019 at 01:40:15PM +0300, Dan Elkouby wrote: > On Fri, Sep 6, 2019 at 1:14 PM Dan Carpenter wrote: > > I think we also need to update update ms_ff_worker() which assumes that > > hid_hw_output_report() returns zero on success. > > Yes, it looks like that's the case. Should I amend

[RFC PATCH v2 12/13] media: mtk-vcodec: vdec: add media device if using stateless api

2019-09-06 Thread Alexandre Courbot
From: Yunfei Dong The stateless API requires a media device for issuing requests. Add one if it turns out we are using it. Signed-off-by: Yunfei Dong [acourbot: refactor, cleanup and split] Co-developed-by: Alexandre Courbot Signed-off-by: Alexandre Courbot ---

[RFC PATCH v2 10/13] media: mtk-vcodec: vdec: support stateless API

2019-09-06 Thread Alexandre Courbot
From: Yunfei Dong Support the stateless codec API that will be used by MT8183. Signed-off-by: Yunfei Dong [acourbot: refactor, cleanup and split] Co-developed-by: Alexandre Courbot Signed-off-by: Alexandre Courbot --- drivers/media/platform/mtk-vcodec/Makefile| 2 +

[RFC PATCH v2 13/13] media: mtk-vcodec: enable MT8183 decoder

2019-09-06 Thread Alexandre Courbot
From: Yunfei Dong Now that all the supporting blocks are present, enable decoder for MT8183. Signed-off-by: Yunfei Dong [acourbot: refactor, cleanup and split] Co-developed-by: Alexandre Courbot Signed-off-by: Alexandre Courbot --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 4

[RFC PATCH v2 11/13] media: mtk-vcodec: vdec: support stateless H.264 decoding

2019-09-06 Thread Alexandre Courbot
From: Yunfei Dong Add the firmware interface allowing to decode H.264 in a stateless manner. Signed-off-by: Yunfei Dong [acourbot: refactor, cleanup and split] Co-developed-by: Alexandre Courbot Signed-off-by: Alexandre Courbot --- .../mtk-vcodec/vdec/vdec_h264_req_if.c| 627

[RFC PATCH v2 07/13] media: mtk-vcodec: add SCP firmware ops

2019-09-06 Thread Alexandre Courbot
From: Yunfei Dong Add support for communicating with the SCP firmware, which will be used by MT8183. Signed-off-by: Yunfei Dong [acourbot: refactor, cleanup and split] Co-developed-by: Alexandre Courbot Signed-off-by: Alexandre Courbot --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 3

[RFC PATCH v2 03/13] media: mtk-vcodec: vdec: clean up vidioc_vdec_s_fmt a bit

2019-09-06 Thread Alexandre Courbot
Check for a potentially NULL pointer that was overlooked and use shorter accessors to the same data. While we are at it, sprinkle a few comments. Signed-off-by: Alexandre Courbot --- .../media/platform/mtk-vcodec/mtk_vcodec_dec.c | 18 ++ 1 file changed, 14 insertions(+), 4

[RFC PATCH v2 05/13] media: mtk-vcodec: vdec: handle firmware version field

2019-09-06 Thread Alexandre Courbot
Firmwares for decoders newer than MT8173 will include an ABI version number in their initialization ack message. Add the capacity to manage it and make initialization fail if the firmware ABI is of a version that we don't support. For MT8173, this ABI version field does not exist ; thus ignore it

[RFC PATCH v2 04/13] media: mtk-vcodec: vdec: move stateful ops into their own file

2019-09-06 Thread Alexandre Courbot
From: Yunfei Dong We are planning to add support for stateless formats to this driver. Part of the driver will be shared between stateful and stateless formats, but a few ops need to be specialized for both. Extract the stateful part of the driver and move it into its own file, accessible

[RFC PATCH v2 00/12] media: mtk-vcodec: support for MT8183 decoder

2019-09-06 Thread Alexandre Courbot
Another spin [1] of the support for the MT8183 stateless decoder taken from the Chrome OS tree. This version is updated to work with the latest revision of the stateless API. It requires the SCP support patchset [2] and thus is not yet suitable for merging, except maybe the first 3 to 6 patches.

[RFC PATCH v2 01/13] media: mtk-vcodec: vdec: fix incorrect pointer dereference

2019-09-06 Thread Alexandre Courbot
From: Yunfei Dong mtk_q_data::fmt is actually a pointer and must be dereferenced as such. This went under the radar because mtk_v4l2_debug() evaluates to nothing unless DEBUG is defined. Signed-off-by: Yunfei Dong [acourbot: split into its own commit] Signed-off-by: Alexandre Courbot ---

[RFC PATCH v2 02/13] media: mtk-vcodec: vdec: set VPI IPI handler in one place

2019-09-06 Thread Alexandre Courbot
Each of the supported decoder formats used to set the same RPC interrupt handler by themselves, even though this could be done by the IF init function itself. Move it to the right place and stop making its symbol public. Signed-off-by: Alexandre Courbot ---

[PATCH] net/mlx4_en: ethtool: make array modes static const, makes object smaller

2019-09-06 Thread Colin King
From: Colin Ian King Don't populate the array modes on the stack but instead make it static const. Makes the object code smaller by 303 bytes. Before: textdata bss dec hex filename 5124050081312 57560e0d8 mellanox/mlx4/en_ethtool.o After: textdata

Re: [PATCH 13/18] virtiofs: Do not access virtqueue in request submission path

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 03:48:54PM -0400, Vivek Goyal wrote: > In request submission path it is possible that virtqueue is already gone > due to driver->remove(). So do not access it in dev_dbg(). Use pr_debug() > instead. > > If virtuqueue is gone, this will result in NULL pointer deference. >

Re: [PATCH 00/18] virtiofs: Fix various races and cleanups round 1

2019-09-06 Thread Miklos Szeredi
On Fri, Sep 6, 2019 at 12:36 PM Stefan Hajnoczi wrote: > > On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: > > On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal wrote: > > > > > > Hi, > > > > > > Michael Tsirkin pointed out issues w.r.t various locking related TODO > > > items and races

Re: [PATCH 12/18] virtiofs: Use virtio_fs_free_devs() in error path

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 03:48:53PM -0400, Vivek Goyal wrote: > We already have an helper to cleanup fuse devices. Use that instead of > duplicating the code. > > Signed-off-by: Vivek Goyal > --- > fs/fuse/virtio_fs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Stefan

Re: [PATCH 11/18] virtiofs: stop and drain queues after sending DESTROY

2019-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 03:48:52PM -0400, Vivek Goyal wrote: > During virtio_kill_sb() we first stop forget queue and drain it and then > call fuse_kill_sb_anon(). This will result in sending DESTROY request to > fuse server. Once finished, stop all the queues and drain one more time > just to be

Re: [PATCH 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories

2019-09-06 Thread Krzysztof Kozlowski
On Fri, 6 Sep 2019 at 13:39, Lukasz Luba wrote: > > Hi Krzysztof, > > On 9/6/19 12:56 PM, Krzysztof Kozlowski wrote: > > On Fri, 6 Sep 2019 at 12:14, Lukasz Luba wrote: > >> > >> Add description of bindings for Samsung k3qf2f20db LPDDR3 memory. > >> Minor fixes in the old documentation. > >> >

Re: [PATCH 1/3] memory: Exynos5422: minor fixes in DMC

2019-09-06 Thread Lukasz Luba
On 9/6/19 12:51 PM, Krzysztof Kozlowski wrote: > On Fri, 6 Sep 2019 at 12:14, Lukasz Luba wrote: >> >> Small fixes captured by static analyzes. > > Explain please what are the errors being fixed. Additionally error > message from tool might be useful. > > Also: > Reported-by: Krzysztof

Re: [PATCH 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories

2019-09-06 Thread Lukasz Luba
Hi Krzysztof, On 9/6/19 12:56 PM, Krzysztof Kozlowski wrote: > On Fri, 6 Sep 2019 at 12:14, Lukasz Luba wrote: >> >> Add description of bindings for Samsung k3qf2f20db LPDDR3 memory. >> Minor fixes in the old documentation. >> >> Signed-off-by: Lukasz Luba >> --- >>

[PATCH] net/ixgbevf: make array api static const, makes object smaller

2019-09-06 Thread Colin King
From: Colin Ian King Don't populate the array api on the stack but instead make it static const. Makes the object code smaller by 58 bytes. Before: textdata bss dec hex filename 829699763 256 92988 16b3c ixgbevf/ixgbevf_main.o After: textdata bss

Re: [PATCH] Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message

2019-09-06 Thread Jiri Kosina
On Fri, 6 Sep 2019, Dan Elkouby wrote: > hidp_send_message was changed to return non-zero values on success, > which some other bits did not expect. This caused spurious errors to be > propagated through the stack, breaking some drivers, such as hid-sony > for the Dualshock 4 in Bluetooth mode. >

[PATCH] net: hns3: make array spec_opcode static const, makes object smaller

2019-09-06 Thread Colin King
From: Colin Ian King Don't populate the array spec_opcode on the stack but instead make it static const. Makes the object code smaller by 48 bytes. Before: textdata bss dec hex filename 69141040 12880821f92 hns3/hns3vf/hclgevf_cmd.o After: textdata

Re: [PATCH 2/3] platform/x86: intel_cht_int33fe: use inline reference properties

2019-09-06 Thread Heikki Krogerus
Hi, On Thu, Sep 05, 2019 at 09:38:08PM -0700, Dmitry Torokhov wrote: > Now that static device properties allow defining reference properties > together with all other types of properties, instead of managing them > separately, let's adjust the driver. > > Signed-off-by: Dmitry Torokhov > --- >

Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver

2019-09-06 Thread Andrew Murray
On Fri, Sep 06, 2019 at 06:58:11PM +0800, Dilip Kota wrote: > Hi Andrew Murray, > > Thanks for the review. Please find my response inline. > > On 9/5/2019 6:45 PM, Andrew Murray wrote: > > On Wed, Sep 04, 2019 at 06:10:31PM +0800, Dilip Kota wrote: > > > Add support to PCIe RC controller on

[PATCH] be2net: make two arrays static const, makes object smaller

2019-09-06 Thread Colin King
From: Colin Ian King Don't populate the arrays on the stack but instead make them static const. Makes the object code smaller by 281 bytes. Before: textdata bss dec hex filename 875535672 0 93225 16c29 benet/be_cmds.o After: textdata bss dec

Re: [PATCH 1/3] software node: implement reference properties

2019-09-06 Thread Heikki Krogerus
On Thu, Sep 05, 2019 at 09:38:07PM -0700, Dmitry Torokhov wrote: > It is possible to store references to software nodes in the same fashion as > other static properties, so that users do not need to define separate > structures: > > const struct software_node gpio_bank_b_node = { > .name =

Re: [PATCH RFC] gpio: Add Virtual Aggregator GPIO Driver

2019-09-06 Thread Geert Uytterhoeven
Hi Bartosz, On Fri, Jul 12, 2019 at 11:27 AM Bartosz Golaszewski wrote: > wt., 9 lip 2019 o 17:59 Geert Uytterhoeven napisał(a): > > On Tue, Jul 9, 2019 at 4:59 PM Bartosz Golaszewski > > wrote: > > > pon., 8 lip 2019 o 12:24 Geert Uytterhoeven > > > napisał(a): > > > > On Mon, Jul 8, 2019

Re: [PATCH] Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message

2019-09-06 Thread Dan Carpenter
On Fri, Sep 06, 2019 at 02:06:44PM +0300, Dan Elkouby wrote: > hidp_send_message was changed to return non-zero values on success, > which some other bits did not expect. This caused spurious errors to be > propagated through the stack, breaking some drivers, such as hid-sony > for the Dualshock 4

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-06 Thread Tetsuo Handa
On 2019/09/06 20:02, Michal Hocko wrote: > On Fri 06-09-19 19:46:10, Tetsuo Handa wrote: >> On 2019/09/05 23:08, Michal Hocko wrote: >>> On Thu 05-09-19 22:39:47, Tetsuo Handa wrote: >>> [...] There is nothing that prevents users from enabling oom_dump_tasks by sysctl. But that

<    1   2   3   4   5   6   7   8   9   >