[PATCH 4.9 17/26] libceph: allow ceph_buffer_put() to receive a NULL ceph_buffer

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit 5c498950f730aa17c5f8a2cdcb903524e4002ed2 ] Signed-off-by: Luis Henriques Reviewed-by: Jeff Layton Signed-off-by: Ilya Dryomov Signed-off-by: Sasha Levin --- include/linux/ceph/buffer.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 4.9 11/26] ravb: Fix use-after-free ravb_tstamp_skb

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit cfef46d692efd852a0da6803f920cc756eea2855 ] When a Tx timestamp is requested, a pointer to the skb is stored in the ravb_tstamp_skb struct. This was done without an skb_get. There exists the possibility that the skb could be freed by ravb_tx_free (when ravb_tx_free is called from

[PATCH 4.9 13/26] IB/mlx4: Fix memory leaks

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit 5c1baaa82cea2c815a5180ded402a7cd455d1810 ] In mlx4_ib_alloc_pv_bufs(), 'tun_qp->tx_ring' is allocated through kcalloc(). However, it is not always deallocated in the following execution if an error occurs, leading to memory leaks. To fix this issue, free 'tun_qp->tx_ring'

[PATCH 4.9 15/26] ceph: fix buffer free while holding i_ceph_lock in fill_inode()

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit af8a85a41734f37b67ba8ce69d56b685bee4ac48 ] Calling ceph_buffer_put() in fill_inode() may result in freeing the i_xattrs.blob buffer while holding the i_ceph_lock. This can be fixed by postponing the call until later, when the lock is released. The following backtrace was

[PATCH 4.4 16/23] libceph: allow ceph_buffer_put() to receive a NULL ceph_buffer

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit 5c498950f730aa17c5f8a2cdcb903524e4002ed2 ] Signed-off-by: Luis Henriques Reviewed-by: Jeff Layton Signed-off-by: Ilya Dryomov Signed-off-by: Sasha Levin --- include/linux/ceph/buffer.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 4.4 06/23] cxgb4: fix a memory leak bug

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit c554336efa9bbc28d6ec14efbee3c7d63c61a34f ] In blocked_fl_write(), 't' is not deallocated if bitmap_parse_user() fails, leading to a memory leak bug. To fix this issue, free t before returning the error. Signed-off-by: Wenwen Wang Signed-off-by: David S. Miller Signed-off-by:

[PATCH 4.4 17/23] spi: bcm2835aux: ensure interrupts are enabled for shared handler

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit bc519d9574618e47a0c788000fb78da95e18d953 ] The BCM2835 AUX SPI has a shared interrupt line (with AUX UART). Downstream fixes this with an AUX irqchip to demux the IRQ sources and a DT change which breaks compatibility with older kernels. The AUX irqchip was already rejected for

[PATCH 4.4 04/23] ibmveth: Convert multicast list size for little-endian system

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit 66cf4710b23ab2adda11155684a2c8826f4fe732 ] The ibm,mac-address-filters property defines the maximum number of addresses the hypervisor's multicast filter list can support. It is encoded as a big-endian integer in the OF device tree, but the virtual ethernet driver does not

[PATCH 4.4 14/23] ceph: fix buffer free while holding i_ceph_lock in __ceph_setxattr()

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit 86968ef21596515958d5f0a40233d02be78ecec0 ] Calling ceph_buffer_put() in __ceph_setxattr() may end up freeing the i_xattrs.prealloc_blob buffer while holding the i_ceph_lock. This can be fixed by postponing the call until later, when the lock is released. The following

[PATCH 4.4 02/23] net: tc35815: Explicitly check NET_IP_ALIGN is not zero in tc35815_rx

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit 125b7e0949d4e72b15c2b1a1590f8cece985a918 ] clang warns: drivers/net/ethernet/toshiba/tc35815.c:1507:30: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand] if (!HAVE_DMA_RXALIGN(lp) && NET_IP_ALIGN)

[PATCH 4.4 01/23] net: tundra: tsi108: use spin_lock_irqsave instead of spin_lock_irq in IRQ context

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit 8c25d0887a8bd0e1ca2074ac0c6dff173787a83b ] As spin_unlock_irq will enable interrupts. Function tsi108_stat_carry is called from interrupt handler tsi108_irq. Interrupts are enabled in interrupt handler. Use spin_lock_irqsave/spin_unlock_irqrestore instead of spin_(un)lock_irq in

[PATCH 4.4 07/23] net: myri10ge: fix memory leaks

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit 20fb7c7a39b5c719e2e619673b5f5729ee7d2306 ] In myri10ge_probe(), myri10ge_alloc_slices() is invoked to allocate slices related structures. Later on, myri10ge_request_irq() is used to get an irq. However, if this process fails, the allocated slices related structures are not

[PATCH 4.4 12/23] Tools: hv: kvp: eliminate may be used uninitialized warning

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit 89eb4d8d25722a0a0194cf7fa47ba602e32a6da7 ] When building hv_kvp_daemon GCC-8.3 complains: hv_kvp_daemon.c: In function ‘kvp_get_ip_info.constprop’: hv_kvp_daemon.c:812:30: warning: ‘ip_buffer’ may be used uninitialized in this function [-Wmaybe-uninitialized] struct

[PATCH 4.4 05/23] gpio: Fix build error of function redefinition

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit 68e03b85474a51ec1921b4d13204782594ef7223 ] when do randbuilding, I got this error: In file included from drivers/hwmon/pmbus/ucd9000.c:19:0: ./include/linux/gpio/driver.h:576:1: error: redefinition of gpiochip_add_pin_range gpiochip_add_pin_range(struct gpio_chip *chip, const

[PATCH 4.4 10/23] wimax/i2400m: fix a memory leak bug

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit 44ef3a03252844a8753479b0cea7f29e4a804bdc ] In i2400m_barker_db_init(), 'options_orig' is allocated through kstrdup() to hold the original command line options. Then, the options are parsed. However, if an error occurs during the parsing process, 'options_orig' is not

[PATCH 4.4 08/23] cx82310_eth: fix a memory leak bug

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit 1eca92eef18719027d394bf1a2d276f43e7cf886 ] In cx82310_bind(), 'dev->partial_data' is allocated through kmalloc(). Then, the execution waits for the firmware to become ready. If the firmware is not ready in time, the execution is terminated. However, the allocated

[PATCH 4.4 13/23] IB/mlx4: Fix memory leaks

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit 5c1baaa82cea2c815a5180ded402a7cd455d1810 ] In mlx4_ib_alloc_pv_bufs(), 'tun_qp->tx_ring' is allocated through kcalloc(). However, it is not always deallocated in the following execution if an error occurs, leading to memory leaks. To fix this issue, free 'tun_qp->tx_ring'

[PATCH 4.4 11/23] ravb: Fix use-after-free ravb_tstamp_skb

2019-09-08 Thread Greg Kroah-Hartman
[ Upstream commit cfef46d692efd852a0da6803f920cc756eea2855 ] When a Tx timestamp is requested, a pointer to the skb is stored in the ravb_tstamp_skb struct. This was done without an skb_get. There exists the possibility that the skb could be freed by ravb_tx_free (when ravb_tx_free is called from

[PATCH 5/5] leds: add /sys/class/leds//current-trigger

2019-09-08 Thread Akinobu Mita
Reading /sys/class/leds//trigger returns all available LED triggers. However, this violates the "one value per file" rule of sysfs. This provides /sys/class/leds//current-trigger which is almost identical to /sys/class/leds//trigger. The only difference is that 'current-trigger' only shows the

[PATCH 4/5] leds: add /sys/class/triggers/ that contains trigger sub-directories

2019-09-08 Thread Akinobu Mita
Reading /sys/class/leds//trigger returns all available LED triggers. However, this violates the "one value per file" rule of sysfs. This provides /sys/class/leds/triggers directory that contains a number of sub-directories, each representing an LED trigger. The name of the sub-directory matches

[PATCH 2/5] leds: make sure leds_class is initialized before triggers are registered

2019-09-08 Thread Akinobu Mita
If the led-class and usb-common modules are built into the kernel, the usb-common module could be initialized earlier than the led-class module. So when the ledtrig_usb_gadget and ledtrig_usb_host LED triggers are registered by usb-common module, the leds_class could not be initialized yet. We

[PATCH 0/5] leds: fix /sys/class/leds//trigger and add new api

2019-09-08 Thread Akinobu Mita
Reading /sys/class/leds//trigger returns all available LED triggers. However, the size of this file is limited to PAGE_SIZE because of the limitation for sysfs attribute. Enabling LED CPU trigger on systems with thousands of CPUs easily hits PAGE_SIZE limit, and makes it impossible to see all

[PATCH 3/5] driver core: class: add function to create /sys/class//foo directory

2019-09-08 Thread Akinobu Mita
This adds a new function class_kobject_create_and_add() that creates a directory in the /sys/class/. This function is required to create the /sys/class/leds/triggers directory that contains all available LED triggers. Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Jacek Anaszewski Cc:

[PATCH 1/5] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-08 Thread Akinobu Mita
Reading /sys/class/leds//trigger returns all available LED triggers. However, the size of this file is limited to PAGE_SIZE because of the limitation for sysfs attribute. Enabling LED CPU trigger on systems with thousands of CPUs easily hits PAGE_SIZE limit, and makes it impossible to see all

Re: general protection fault in cbs_destroy

2019-09-08 Thread syzbot
syzbot has bisected this bug to: commit e0a7683d30e91e30ee6cf96314ae58a0314a095e Author: Leandro Dorileo Date: Mon Apr 8 17:12:18 2019 + net/sched: cbs: fix port_rate miscalculation bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=158f3c0160 start commit: 3b47fd5c

Re: [PATCH v2 11/11] dt-bindings: iio: adc: exynos: Remove old requirement of two register address ranges

2019-09-08 Thread Jonathan Cameron
On Sat, 7 Sep 2019 11:20:07 +0200 Krzysztof Kozlowski wrote: > Commit fafb37cfae6d ("iio: exyno-adc: use syscon for PMU > register access") changed the Exynos ADC driver so the PMU syscon > phandle is required instead of second register address space. The > bindings were not updated so fix

Re: [PATCH v2 10/11] dt-bindings: iio: adc: exynos: Convert Exynos ADC bindings to json-schema

2019-09-08 Thread Jonathan Cameron
On Sat, 7 Sep 2019 11:20:06 +0200 Krzysztof Kozlowski wrote: > Convert Samsung Exynos Analog to Digital Converter bindings to DT schema > format using json-schema. > > This is a direct conversion of existing bindings so it also copies the > existing error in the bindings regarding the

Re: [PATCH v2 3/3] IIO: Ingenic JZ47xx: Add support for JZ4770 SoC ADC.

2019-09-08 Thread Jonathan Cameron
On Sat, 27 Jul 2019 21:59:40 +0200 Artur Rojek wrote: > Add support for the ADC hardware present on Ingenic JZ4770 SoC. > > Signed-off-by: Artur Rojek > Tested-by: Paul Cercueil Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks,

Re: [PATCH v2 2/3] dt-bindings: iio/adc: Add AUX2 channel idx for JZ4770 SoC ADC

2019-09-08 Thread Jonathan Cameron
On Sat, 27 Jul 2019 21:59:39 +0200 Artur Rojek wrote: > Introduce support for AUX2 channel found in ADC hardware present on > Ingenic JZ4770 SoC. > > Signed-off-by: Artur Rojek > Reviewed-by: Rob Herring Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to

Re: [PATCH v2 1/3] dt-bindings: iio/adc: Add a compatible string for JZ4770 SoC ADC

2019-09-08 Thread Jonathan Cameron
On Tue, 03 Sep 2019 21:09:24 +0200 Artur Rojek wrote: > Hi Jonathan, > > Just reminding you of this patch set. > > Artur Hi Artur, Thanks for the reminder. As you'd no doubt concluded, I'd dropped it down the back of the sofa. Unfortunately it's now just missed my last pull for 5.4

Re: [RFC 3/3] dmaengine: Support for requesting channels preferring DMA domain controller

2019-09-08 Thread Vinod Koul
On 06-09-19, 17:18, Peter Ujfalusi wrote: > In case the channel is not requested via the slave API, use the > of_find_dma_domain() to see if a system default DMA controller is > specified. > > Add new function which can be used by clients to request channels by mask > from their DMA domain

Re: [PATCH v5 0/9] Enhance the hv_vmbus driver to support hibernation

2019-09-08 Thread Sasha Levin
On Fri, Sep 06, 2019 at 10:45:31PM +, Dexuan Cui wrote: From: Sasha Levin Sent: Friday, September 6, 2019 1:03 PM On Thu, Sep 05, 2019 at 11:01:14PM +, Dexuan Cui wrote: >This patchset (consisting of 9 patches) was part of the v4 patchset (consisting >of 12 patches): > >The other 3

Re: [RFC 2/3] dmaengine: of_dma: Function to look up the DMA domain of a client

2019-09-08 Thread Vinod Koul
On 06-09-19, 17:18, Peter Ujfalusi wrote: > Find the DMA domain controller of the client device by iterating up in > device tree looking for the closest 'dma-domain-controller' property. > > If the client's node is not provided then check the DT root for the > controller. > > Signed-off-by:

Re: [RFC 1/3] dt-bindings: dma: Add documentation for DMA domains

2019-09-08 Thread Vinod Koul
On 08-09-19, 10:47, Peter Ujfalusi wrote: > > > On 06/09/2019 17.18, Peter Ujfalusi wrote: > > On systems where multiple DMA controllers available, none Slave (for example > > memcpy operation) users can not be described in DT as there is no device > > involved from the DMA controller's point of

Re: [RFC 1/3] dt-bindings: dma: Add documentation for DMA domains

2019-09-08 Thread Vinod Koul
On 06-09-19, 17:18, Peter Ujfalusi wrote: > On systems where multiple DMA controllers available, none Slave (for example On systems with multiple DMA controllers, non Slave... > memcpy operation) users can not be described in DT as there is no device > involved from the DMA controller's point of

[PATCH] ftrace: simplify ftrace hash lookup code

2019-09-08 Thread Changbin Du
Function ftrace_lookup_ip() will check empty hash table. So we don't need extra check outside. Signed-off-by: Changbin Du --- kernel/trace/ftrace.c | 15 --- kernel/trace/trace.h | 6 -- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/kernel/trace/ftrace.c

Re: [Virtio-fs] [PATCH 00/18] virtiofs: Fix various races and cleanups round 1

2019-09-08 Thread piaojun
On 2019/9/6 19:52, Miklos Szeredi wrote: > On Fri, Sep 6, 2019 at 12:36 PM Stefan Hajnoczi wrote: >> >> On Fri, Sep 06, 2019 at 10:15:14AM +0200, Miklos Szeredi wrote: >>> On Thu, Sep 5, 2019 at 9:49 PM Vivek Goyal wrote: Hi, Michael Tsirkin pointed out issues w.r.t

Re: Regression in 5.1.20: Reading long directory fails

2019-09-08 Thread Benjamin Coddington
On 6 Sep 2019, at 16:50, Chuck Lever wrote: On Sep 6, 2019, at 4:47 PM, Jason L Tibbitts III wrote: "JBF" == J Bruce Fields writes: JBF> Those readdir changes were client-side, right? Based on that I'd JBF> been assuming a client bug, but maybe it'd be worth getting a full JBF>

Re: [PATCH] iio: light: cm36651: redundant assignment to variable ret

2019-09-08 Thread Jonathan Cameron
On Sun, 1 Sep 2019 16:27:49 +0100 Colin King wrote: > From: Colin Ian King > > Variable ret is being assigned a value that is never read and > is being re-assigned a little later on. The assignment is redundant > and hence can be removed. > > Addresses-Coverity: ("Ununsed value") >

Re: [PATCH] iio: adc: meson_saradc: Fix memory allocation order

2019-09-08 Thread Jonathan Cameron
On Mon, 2 Sep 2019 21:40:49 +0100 Elie Roudninski wrote: > On Sun, Sep 1, 2019 at 12:29 PM Martin Blumenstingl > wrote: > > > > On Sun, Sep 1, 2019 at 12:45 PM Remi Pommarel wrote: > > > > > > meson_saradc's irq handler uses priv->regmap so make sure that it is > > > allocated before the irq

Re: [PATCH bpf-next] xdp: Fix race in dev_map_hash_update_elem() when replacing element

2019-09-08 Thread Jesper Dangaard Brouer
On Sun, 8 Sep 2019 09:20:16 +0100 Toke Høiland-Jørgensen wrote: > syzbot found a crash in dev_map_hash_update_elem(), when replacing an > element with a new one. Jesper correctly identified the cause of the crash > as a race condition between the initial lookup in the map (which is done >

Re: [Virtio-fs] [PATCH 16/18] virtiofs: Use virtio_fs_mutex for races w.r.t ->remove and mount path

2019-09-08 Thread piaojun
On 2019/9/6 3:48, Vivek Goyal wrote: > It is possible that a mount is in progress and device is being removed at > the same time. Use virtio_fs_mutex to avoid races. > > This also takes care of bunch of races and removes some TODO items. > > Signed-off-by: Vivek Goyal > --- >

Re: [PATCH v3 1/6] bus/ti-pwmss: move TI PWMSS driver from PWM to bus subsystem

2019-09-08 Thread Jonathan Cameron
On Mon, 2 Sep 2019 17:02:45 +0200 Thierry Reding wrote: > On Sun, Sep 01, 2019 at 05:58:22PM -0500, David Lechner wrote: > > The TI PWMSS driver is a simple bus driver for providing power > > power management for the PWM peripherals on TI AM33xx SoCs, namely > > eCAP, eHRPWM and eQEP. The eQEP

Re: [PATCH v3 0/6] counter: new TI eQEP driver

2019-09-08 Thread Jonathan Cameron
On Thu, 5 Sep 2019 07:10:53 -0700 Tony Lindgren wrote: > * William Breathitt Gray [190905 13:38]: > > On Sun, Sep 01, 2019 at 05:58:21PM -0500, David Lechner wrote: > > > This series adds device tree bindings and a new counter driver for the > > > Texas > > > Instruments Enhanced Quadrature

Re: [Virtio-fs] [PATCH 15/18] virtiofs: Make virtio_fs object refcounted

2019-09-08 Thread piaojun
On 2019/9/6 3:48, Vivek Goyal wrote: > This object is used both by fuse_connection as well virt device. So make > this object reference counted and that makes it easy to define life cycle > of the object. > > Now deivce can be removed while filesystem is still mounted. This will > cleanup all

Re: [PATCH 2/2] staging: iio: accel: adis16240: move out of staging

2019-09-08 Thread Jonathan Cameron
On Mon, 2 Sep 2019 13:26:02 + "Ardelean, Alexandru" wrote: > On Sun, 2019-09-01 at 21:59 -0300, Rodrigo Carvalho wrote: > > Move ADIS16240 driver from staging to mainline. > > > > The ADIS16240 is a fully integrated digital shock detection > > and recorder system. > > > Hey, > >

Re: [PATCH 2/2] vhost: re-introducing metadata acceleration through kernel virtual address

2019-09-08 Thread Michael S. Tsirkin
On Thu, Sep 05, 2019 at 08:27:36PM +0800, Jason Wang wrote: > This is a rework on the commit 7f466032dc9e ("vhost: access vq > metadata through kernel virtual address"). > > It was noticed that the copy_to/from_user() friends that was used to > access virtqueue metdata tends to be very expensive

[RFC PATCH untested] vhost: block speculation of translated descriptors

2019-09-08 Thread Michael S. Tsirkin
iovec addresses coming from vhost are assumed to be pre-validated, but in fact can be speculated to a value out of range. Userspace address are later validated with array_index_nospec so we can be sure kernel info does not leak through these addresses, but vhost must also not leak userspace info

Re: Linux 5.3-rc7

2019-09-08 Thread Sasha Levin
On Sat, Sep 07, 2019 at 02:13:22PM -0700, Linus Torvalds wrote: On Sat, Sep 7, 2019 at 1:44 PM Thomas Gleixner wrote: That's what I just replied to Chris. Can you do it right away or should I queue it up? Done. I'd like to bring back a discussion we had last year on ksummit-discuss:

[sparc64] Kernel unaligned access at TPC lzo1x_1_do_compress

2019-09-08 Thread Anatoly Pugachev
Hello! trying to use zram block device, shows the following: # zramctl -f -s 16g # cat /sys/block/zram0/comp_algorithm lzo [lzo-rle] lz4 lz4hc 842 zstd # zramctl NAME ALGORITHM DISKSIZE DATA COMPR TOTAL STREAMS MOUNTPOINT /dev/zram0 lzo-rle16G 10.4M4K 112K 32 # mkfs.xfs

Re: [PATCH 1/2] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-09-08 Thread Jonathan Cameron
On Mon, 2 Sep 2019 14:14:18 -0300 Marcelo Schmitt wrote: > Hi Rodrigo, > > This dt doc looks overal fine IMHO. > I would just add some inline comments about the cpha and cpol > properties. > > On 09/01, Rodrigo Carvalho wrote: > > This patch add device tree binding documentation for ADIS16240.

Re: [PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat

2019-09-08 Thread OGAWA Hirofumi
Greg Kroah-Hartman writes: > On Mon, Sep 02, 2019 at 03:00:17PM -0400, Valdis Klētnieks wrote: >> On Mon, 02 Sep 2019 17:25:24 +0200, Greg Kroah-Hartman said: >> >> > I dug up my old discussion with the current vfat maintainer and he said >> > something to the affect of, "leave the existing

Re: [PATCH] iio: light: bh1750: Move static keyword to the front of declaration

2019-09-08 Thread Jonathan Cameron
On Mon, 2 Sep 2019 13:31:32 +0200 Krzysztof Wilczynski wrote: > Move the static keyword to the front of declaration of > bh1750_chip_info_tbl, and resolve the following compiler > warning that can be seen when building with warnings > enabled (W=1): > > drivers/iio/light/bh1750.c:64:1:

Re: [PATCH V4 1/4] iio: adc: ad7192: Add sysfs ABI documentation

2019-09-08 Thread Jonathan Cameron
On Mon, 2 Sep 2019 16:08:28 +0300 Mircea Caprioru wrote: > Add initial ABI documentation for ad7192 adc sysfs interfaces. > > Signed-off-by: Mircea Caprioru Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to ignore ;) Thanks, Jonathan > --- > Changelog

Re: [PATCH V4 3/4] staging: iio: adc: ad7192: Add system calibration support

2019-09-08 Thread Jonathan Cameron
On Mon, 2 Sep 2019 16:08:30 +0300 Mircea Caprioru wrote: > This patch will add a system calibration attribute for each channel. Using > this option the user will have the ability to calibrate each channel for > zero scale and full scale. It uses the iio_chan_spec_ext_info and IIO_ENUM > to

Re: [PATCH V4 2/4] iio: adc: ad_sigma_delta: Export ad_sd_calibrate

2019-09-08 Thread Jonathan Cameron
On Mon, 2 Sep 2019 16:08:29 +0300 Mircea Caprioru wrote: > This patch exports the ad_sd_calibrate function in order to be able to > call it from outside ad_sigma_delta. > > There are cases where the option to calibrate one channel at a time is > necessary (ex. system calibration for zero scale

Re: [PATCH V4 4/4] dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192

2019-09-08 Thread Jonathan Cameron
On Tue, 3 Sep 2019 18:29:37 +0100 Rob Herring wrote: > On Mon, 2 Sep 2019 16:08:31 +0300, Mircea Caprioru wrote: > > This patch add device tree binding documentation for AD7192 adc in YAML > > format. > > > > Signed-off-by: Mircea Caprioru It seems that I messed up before and didn't actually

Re: [PATCH 0/3] powerpc/ftrace: Enable HAVE_FUNCTION_GRAPH_RET_ADDR_PTR

2019-09-08 Thread Nicholas Piggin
Naveen N. Rao's on September 6, 2019 4:20 am: > Enable HAVE_FUNCTION_GRAPH_RET_ADDR_PTR for more robust stack unwinding > when function graph tracer is in use. Convert powerpc show_stack() to > use ftrace_graph_ret_addr() for better stack unwinding. This series improved my case of a WARN_ON

Re: [PATCH] fat: Delete an unnecessary check before brelse()

2019-09-08 Thread OGAWA Hirofumi
Markus Elfring writes: > From: Markus Elfring > Date: Tue, 3 Sep 2019 14:56:16 +0200 > > The brelse() function tests whether its argument is NULL > and then returns immediately. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > >

Re: [PATCH] fat: fix corruption in fat_alloc_new_dir()

2019-09-08 Thread OGAWA Hirofumi
Jan Stancek writes: > sb_getblk does not guarantee that buffer_head is uptodate. If there is > async read running in parallel for same buffer_head, it can overwrite > just initialized msdos_dir_entry, leading to corruption: > FAT-fs (loop0): error, corrupted directory (invalid entries) >

Re: [PATCH v3 1/2] net: core: Notify on changes to dev->promiscuity.

2019-09-08 Thread Ido Schimmel
On Tue, Sep 03, 2019 at 10:14:12AM +0200, Allan W. Nielsen wrote: > The 09/03/2019 09:13, Ido Schimmel wrote: > > On Mon, Sep 02, 2019 at 07:42:31PM +0200, Allan W. Nielsen wrote: > > With these patches applied I assume I will see the following traffic > > when running tcpdump on one of the

Re: [PATCH] VMCI: Release resource if the work is already queued

2019-09-08 Thread Greg Kroah-Hartman
On Sun, Sep 08, 2019 at 04:04:39AM +, Nadav Amit wrote: > > On Sep 7, 2019, at 9:47 PM, Greg Kroah-Hartman > > wrote: > > > > On Tue, Aug 20, 2019 at 01:26:38PM -0700, Nadav Amit wrote: > >> Francois reported that VMware balloon gets stuck after a balloon reset, > >> when the VMCI doorbell

[PATCH v2 03/11] mmc: mtk-sd: Re-store SDIO IRQs mask at system resume

2019-09-08 Thread Ulf Hansson
In cases when SDIO IRQs have been enabled, runtime suspend is prevented by the driver. However, this still means msdc_runtime_suspend|resume() gets called during system suspend/resume, via pm_runtime_force_suspend|resume(). This means during system suspend/resume, the register context of the

[PATCH v2 07/11] mmc: core: WARN if SDIO IRQs are enabled for non-powered card in suspend

2019-09-08 Thread Ulf Hansson
To make sure SDIO func drivers behaves correctly during system suspend/resume, let add a WARN_ON in case the condition is a non-powered SDIO card and there are some SDIO IRQs still being claimed. Tested-by: Matthias Kaehlcke Reviewed-by: Matthias Kaehlcke Signed-off-by: Ulf Hansson ---

[PATCH v2 04/11] mmc: core: Move code to get pending SDIO IRQs to a function

2019-09-08 Thread Ulf Hansson
From: Matthias Kaehlcke To improve code quality, let's move the code that gets pending SDIO IRQs from process_sdio_pending_irqs() into a dedicated function. Signed-off-by: Matthias Kaehlcke [Ulf: Converted function into static] Tested-by: Matthias Kaehlcke Signed-off-by: Ulf Hansson ---

[PATCH v2 05/11] mmc: core: Clarify sdio_irq_pending flag for MMC_CAP2_SDIO_IRQ_NOTHREAD

2019-09-08 Thread Ulf Hansson
The sdio_irq_pending flag is used to let host drivers indicate that it has signaled an IRQ. If that is the case and we only have a single SDIO func that have claimed an SDIO IRQ, our assumption is that we can avoid reading the SDIO_CCCR_INTx register and just call the SDIO func irq handler

[PATCH v2 01/11] mmc: core: Add helper function to indicate if SDIO IRQs is enabled

2019-09-08 Thread Ulf Hansson
To avoid each host driver supporting SDIO IRQs, from keeping track internally about if SDIO IRQs has been claimed, let's introduce a common helper function, sdio_irq_claimed(). The function returns true if SDIO IRQs are claimed, via using the information about the number of claimed irqs. This is

[PATCH v2 02/11] mmc: dw_mmc: Re-store SDIO IRQs mask at system resume

2019-09-08 Thread Ulf Hansson
In cases when SDIO IRQs have been enabled, runtime suspend is prevented by the driver. However, this still means dw_mci_runtime_suspend|resume() gets called during system suspend/resume, via pm_runtime_force_suspend|resume(). This means during system suspend/resume, the register context of the

[PATCH v2 11/11] mmc: sdhci: Convert to use sdio_irq_claimed()

2019-09-08 Thread Ulf Hansson
Instead of keeping track of whether SDIO IRQs have been enabled via an internal sdhci status flag, avoid the open-coding and convert into using sdio_irq_claimed(). Reviewed-by: Matthias Kaehlcke Signed-off-by: Ulf Hansson --- drivers/mmc/host/sdhci.c | 7 +-- drivers/mmc/host/sdhci.h | 1 -

[PATCH v2 10/11] mmc: sdhci: Drop redundant code for SDIO IRQs

2019-09-08 Thread Ulf Hansson
Nowadays sdhci prevents runtime suspend when SDIO IRQs are enabled. However, some variants such as sdhci-esdhc-imx's, tries to allow runtime suspend while having the SDIO IRQs enabled, but without supporting remote wakeups. This support is a bit questionable, especially if the host device have a

[PATCH v2 06/11] mmc: core: Clarify that the ->ack_sdio_irq() callback is mandatory

2019-09-08 Thread Ulf Hansson
For the MMC_CAP2_SDIO_IRQ_NOTHREAD case and when using sdio_signal_irq(), the ->ack_sdio_irq() is already mandatory, which was not the case for those host drivers that called sdio_run_irqs() directly. As there are no longer any drivers calling sdio_run_irqs(), let's clarify the code by dropping

[PATCH v2 09/11] mmc: sdhci: Drop redundant check in sdhci_ack_sdio_irq()

2019-09-08 Thread Ulf Hansson
The sdhci_ack_sdio_irq() is called only when SDIO IRQs are enabled. Therefore, let's drop the redundant check of the internal SDHCI_SDIO_IRQ_ENABLED flag and just re-enable the IRQs immediately. Reviewed-by: Matthias Kaehlcke Signed-off-by: Ulf Hansson --- drivers/mmc/host/sdhci.c | 3 +-- 1

[PATCH v2 08/11] mmc: core: Fixup processing of SDIO IRQs during system suspend/resume

2019-09-08 Thread Ulf Hansson
System suspend/resume of SDIO cards, with SDIO IRQs enabled and when using MMC_CAP2_SDIO_IRQ_NOTHREAD is unfortunate still suffering from a fragile behaviour. Some problems have been taken care of so far, but more issues remains. For example, calling the ->ack_sdio_irq() callback to let host

[PATCH v2 00/11] mmc: core: PM fixes/improvements for SDIO IRQs

2019-09-08 Thread Ulf Hansson
Changes in v2: - Added reviewed/tested-by tags. - Updated some changelogs. - Renamed sdio_irq_enabled() to sdio_irq_claimed(). - Don't set sdio_irq_pending when resuming SDIO card, but just queue the work. The power management support for SDIO cards have

Re: [Virtio-fs] [PATCH 08/18] virtiofs: Drain all pending requests during ->remove time

2019-09-08 Thread piaojun
On 2019/9/6 3:48, Vivek Goyal wrote: > When device is going away, drain all pending requests. > > Signed-off-by: Vivek Goyal > --- > fs/fuse/virtio_fs.c | 83 - > 1 file changed, 51 insertions(+), 32 deletions(-) > > diff --git

Re: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket

2019-09-08 Thread Prarit Bhargava
On 9/7/19 2:18 PM, Andy Shevchenko wrote: > On Fri, Sep 6, 2019 at 10:47 PM Srinivas Pandruvada > wrote: >> >> On Fri, 2019-09-06 at 07:50 -0700, Srinivas Pandruvada wrote: >>> On Fri, 2019-09-06 at 16:46 +0300, Andy Shevchenko wrote: On Fri, Sep 06, 2019 at 05:39:54AM -0400, Prarit

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

2019-09-08 Thread Okash Khawaja
Sorry, I have only now got round to working on this. It's not complete yet but I have assimilated the feedback and converted subjective phrases, like "I think..." into objective statements or put them in TODO: so that someone else may verify. I have attached it to this email. Next step will be to

Re: [PATCH 3/3] iio: accel: adxl372: Make sure interrupts are disabled

2019-09-08 Thread Jonathan Cameron
On Tue, 3 Sep 2019 12:19:11 +0300 Stefan Popa wrote: > This patch disables the adxl372 interrupts at setup. The interrupts > should be enabled together with the iio buffer. Not doing this, might > cause an unwanted interrupt to trigger without being able to properly > clear it. > >

Re: [PATCH 2/3] iio: accel: adxl372: Fix push to buffers lost samples

2019-09-08 Thread Jonathan Cameron
On Tue, 3 Sep 2019 12:18:33 +0300 Stefan Popa wrote: > One in two sample sets was lost by multiplying fifo_set_size with > sizeof(u16). Also, the double number of available samples were pushed to > the iio buffers. > > Signed-off-by: Stefan Popa Looks right to me. Will pick up once we've

Re: [PATCH 1/3] iio: accel: adxl372: Fix/remove limitation for FIFO samples

2019-09-08 Thread Jonathan Cameron
On Tue, 3 Sep 2019 12:18:07 +0300 Stefan Popa wrote: > Currently, the driver sets the FIFO_SAMPLES register with the number of > sample sets (maximum of 170 for 3 axis data, 256 for 2-axis and 512 for > single axis). However, the FIFO_SAMPLES register should store the number > of samples,

Re: [PATCH 05/11] mmc: core: Clarify sdio_irq_pending flag for MMC_CAP2_SDIO_IRQ_NOTHREAD

2019-09-08 Thread Ulf Hansson
On Fri, 6 Sep 2019 at 23:30, Doug Anderson wrote: > > Hi, > > On Fri, Sep 6, 2019 at 2:20 AM Ulf Hansson wrote: > > > > On Fri, 6 Sep 2019 at 01:47, Doug Anderson wrote: > > > > > > Hi, > > > > > > On Tue, Sep 3, 2019 at 7:22 AM Ulf Hansson wrote: > > > > > > > > In the single SDIO IRQ handler

Re: [tip: irq/core] gpio/ixp4xx: Register the base PA instead of its VA in fwnode

2019-09-08 Thread Marc Zyngier
On Sun, 08 Sep 2019 09:09:47 +0100, Linus Walleij wrote: > > On Fri, Sep 6, 2019 at 12:08 PM tip-bot2 for Marc Zyngier > wrote: > > > The following commit has been merged into the irq/core branch of tip: > > > > Commit-ID: daa19fe5b082779962988a5ba9e38509004db3de > > Gitweb: > >

[PATCH] staging: r8188eu: replace rtw_malloc() with it's definition

2019-09-08 Thread Ivan Safonov
rtw_malloc prevents the use of kmemdup/kzalloc and others. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_ap.c| 4 ++-- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- .../staging/rtl8188eu/include/osdep_service.h | 3 ---

Re: [PATCH 1/2] net: phy: dp83867: Add documentation for SGMII mode type

2019-09-08 Thread Andrew Lunn
On Sun, Sep 08, 2019 at 01:47:19AM +0300, Vitaly Gaiduk wrote: > Hi, Andrew.I’m ready to do this property with such name but is it good > practice to do such long names? :)Also, Trent Piepho wrote about > sgmii-clk and merged all ideas we have “ti,sgmii-ref-clk”.It’s > better, isn’t

next-20190904: build failure in cp210x usb serial, gpio related?

2019-09-08 Thread Pavel Machek
Hi! I'm getting this compiling the -next: CC drivers/net/wireless/intel/iwlwifi/mvm/mac80211.o In file included from drivers/usb/serial/cp210x.c:23: ./include/linux/gpio/driver.h:722:19: error: static declaration of ‘gpiochip_lock_as_irq’ follows non-static declaration 722 |

Re: [PATCH 1/1] edac: Add an API for edac device to report for multiple errors

2019-09-08 Thread Borislav Petkov
On Sun, Sep 08, 2019 at 10:16:02AM +0200, Borislav Petkov wrote: > On Sun, Sep 08, 2019 at 10:58:31AM +0300, Hawa, Hanna wrote: > > > Better use WARN_ON_ONCE() to avoid flooding. > > > > In case of two drivers using this function with wrong error count, only the > > first WARN_ON_ONCE will catch

Re: [PATCH v2] powerpc/lockdep: fix a false positive warning

2019-09-08 Thread Ingo Molnar
* Qian Cai wrote: > I thought about making it a bool in the first place, but since all > other similar helpers (arch_is_kernel_initmem_freed(), > arch_is_kernel_text(), arch_is_kernel_data() etc) could be bool too but > are not, I kept arch_is_bss_hole() just to be “int” for consistent. >

Re: [PATCH] ib_umem: fix type mismatch

2019-09-08 Thread Arnd Bergmann
On Sun, Sep 8, 2019 at 10:10 AM Leon Romanovsky wrote: > On Fri, Sep 06, 2019 at 05:42:37PM +0200, Arnd Bergmann wrote: > > I had slightly different fix in my submission queue, which I think is > better because it leaves length to be size_t. > >

[PATCH bpf-next] xdp: Fix race in dev_map_hash_update_elem() when replacing element

2019-09-08 Thread Toke Høiland-Jørgensen
syzbot found a crash in dev_map_hash_update_elem(), when replacing an element with a new one. Jesper correctly identified the cause of the crash as a race condition between the initial lookup in the map (which is done before taking the lock), and the removal of the old element. Rather than just

Re: [PATCH 1/1] edac: Add an API for edac device to report for multiple errors

2019-09-08 Thread Borislav Petkov
On Sun, Sep 08, 2019 at 10:58:31AM +0300, Hawa, Hanna wrote: > > Better use WARN_ON_ONCE() to avoid flooding. > > In case of two drivers using this function with wrong error count, only the > first WARN_ON_ONCE will catch in this case, and other will miss other wrong > usage of other edac device

Re: [PATCH] ib_umem: fix type mismatch

2019-09-08 Thread Leon Romanovsky
On Fri, Sep 06, 2019 at 05:42:37PM +0200, Arnd Bergmann wrote: > On some 32-bit architectures, size_t is defined as 'int' rather > than 'long', causing a harmless warning: > > drivers/infiniband/core/umem_odp.c:220:7: error: comparison of distinct > pointer types ('typeof (umem_odp->umem.address)

Re: [tip: irq/core] gpio/ixp4xx: Register the base PA instead of its VA in fwnode

2019-09-08 Thread Linus Walleij
On Fri, Sep 6, 2019 at 12:08 PM tip-bot2 for Marc Zyngier wrote: > The following commit has been merged into the irq/core branch of tip: > > Commit-ID: daa19fe5b082779962988a5ba9e38509004db3de > Gitweb: > https://git.kernel.org/tip/daa19fe5b082779962988a5ba9e38509004db3de > Author:

Re: general protection fault in dev_map_hash_update_elem

2019-09-08 Thread Toke Høiland-Jørgensen
Hillf Danton writes: >> syzbot has found a reproducer for the following crash on Sat, 07 Sep 2019 >> 18:59:06 -0700 >> >> HEAD commit:a2c11b03 kcm: use BPF_PROG_RUN >> git tree: bpf-next >> console output: https://syzkaller.appspot.com/x/log.txt?x=13d46ec160 >> kernel config:

Re: [FYI] lm3532: right registration to work with LED-backlight

2019-09-08 Thread Pavel Machek
On Wed 2019-08-28 22:32:57, Jacek Anaszewski wrote: > On 8/28/19 10:53 AM, Pavel Machek wrote: > > Hi! > > > > Eventually, these will be needed. > > > > Best regards, > > Pavel > > > > commit 38d956977a7d6cbdc811676f9b4033da7487e045 >

[GIT PULL] GPIO fixes for v5.3

2019-09-08 Thread Linus Walleij
Hi Linus, some (hopefully last) small GPIO fix for the v5.3 series. Just affecting PCA953x expanders. Details in the tag. Please pull it in! Yours, Linus Walleij The following changes since commit a55aa89aab90fae7c815b0551b07be37db359d76: Linux 5.3-rc6 (2019-08-25 12:01:23 -0700) are

Re: [PATCH 1/1] edac: Add an API for edac device to report for multiple errors

2019-09-08 Thread Hawa, Hanna
On 9/5/2019 12:56 PM, Robert Richter wrote: Hi Hanna, thanks for the update. See below. On 05.09.19 09:37:45, Hanna Hawa wrote: Add an API for edac device to report multiple errors with same type. Signed-off-by: Hanna Hawa --- drivers/edac/edac_device.c | 66

Re: [RFC 1/3] dt-bindings: dma: Add documentation for DMA domains

2019-09-08 Thread Peter Ujfalusi
On 06/09/2019 17.18, Peter Ujfalusi wrote: > On systems where multiple DMA controllers available, none Slave (for example > memcpy operation) users can not be described in DT as there is no device > involved from the DMA controller's point of view, DMA binding is not usable. > However in these

Re: [RFC 3/3] dmaengine: Support for requesting channels preferring DMA domain controller

2019-09-08 Thread Peter Ujfalusi
On 06/09/2019 17.18, Peter Ujfalusi wrote: > In case the channel is not requested via the slave API, use the > of_find_dma_domain() to see if a system default DMA controller is > specified. > > Add new function which can be used by clients to request channels by mask > from their DMA domain

Re: [PATCH] x86/umip: Add emulation for 64-bit processes

2019-09-08 Thread Borislav Petkov
On Sat, Sep 07, 2019 at 02:26:10PM -0700, Ricardo Neri wrote: > > Wine users have encountered a number of 64-bit Windows games that use > > these instructions (particularly sgdt), and were crashing when run on > > UMIP-enabled systems. > > Emulation support for 64-bit processes was not initially

BUG: soft lockup in rt6_probe_deferred

2019-09-08 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:3b47fd5c Merge tag 'nfs-for-5.3-4' of git://git.linux-nfs... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=128438d160 kernel config: https://syzkaller.appspot.com/x/.config?x=b89bb446a3faaba4

<    1   2   3   4   5   6   >