[PATCH v2] leds-bcm6358: Use devm_platform_ioremap_resource() in bcm6358_leds_probe()

2019-09-20 Thread Markus Elfring
From: Markus Elfring Date: Fri, 20 Sep 2019 14:44:06 +0200 Simplify this function implementation by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- v2: Jacek Anaszewski requested to split updates for two modules into

linux-next: manual merge of the thermal tree with Linus' tree

2019-09-20 Thread Mark Brown
Hi all, Today's linux-next merge of the thermal tree got conflicts in: Documentation/driver-api/thermal/index.rst Documentation/driver-api/thermal/sysfs-api.rst Documentation/driver-api/thermal/x86_pkg_temperature_thermal.rst between commit: eaf7b46083a7e34 ("docs: thermal: add it to th

Re: [PATCH] jffs2:freely allocate memory when parameters are invalid

2019-09-20 Thread Al Viro
On Fri, Sep 20, 2019 at 08:21:53PM +0800, Xiaoming Ni wrote: > > > On 2019/9/20 19:43, Al Viro wrote: > > On Fri, Sep 20, 2019 at 02:54:38PM +0800, Xiaoming Ni wrote: > >> Use kzalloc() to allocate memory in jffs2_fill_super(). > >> Freeing memory when jffs2_parse_options() fails will cause > >>

Re: [PATCH v3] dt-bindings: sound: Convert Samsung I2S controller to dt-schema

2019-09-20 Thread Krzysztof Kozlowski
On Fri, Sep 20, 2019 at 02:33:13PM +0200, Marek Szyprowski wrote: > Hi Krzysztof, > >> +examples: > >> + - | > >> +#include > > Does it really work? When I tried, it was failing... If you look up at > > resulting DTS example it is wrong. > > In which way it was wrong? We checked and it was

[PATCH v2] leds-bcm6328: Use devm_platform_ioremap_resource() in bcm6328_leds_probe()

2019-09-20 Thread Markus Elfring
From: Markus Elfring Date: Fri, 20 Sep 2019 14:30:31 +0200 Simplify this function implementation by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- v2: Jacek Anaszewski requested to split updates for two modules in

Re: [PATCH v3] dt-bindings: sound: Convert Samsung I2S controller to dt-schema

2019-09-20 Thread Marek Szyprowski
Hi Krzysztof, On 20.09.2019 14:26, Krzysztof Kozlowski wrote: > On Fri, Sep 20, 2019 at 01:35:40PM +0200, Marek Szyprowski wrote: >> From: Maciej Falkowski >> >> Convert Samsung I2S controller to newer dt-schema format. >> >> Signed-off-by: Maciej Falkowski >> Signed-off-by: Marek Szyprowski >>

Re: [PATCH v3 2/3] leds: Add control of the voltage/current regulator to the LED core

2019-09-20 Thread Jean-Jacques Hiblot
Hi Jacek, On 18/07/2019 19:49, Jacek Anaszewski wrote: On 7/18/19 3:31 PM, Jean-Jacques Hiblot wrote: On 18/07/2019 14:24, Jacek Anaszewski wrote: Hi Jean, Thank you for the updated patch set. I have some more comments below. On 7/17/19 3:59 PM, Jean-Jacques Hiblot wrote:   +static bool _

[PATCH] mm, memcg: assign shrinker_map before kvfree

2019-09-20 Thread Cyrill Gorcunov
Currently there is a small gap between fetching pointer, calling kvfree and assign its value to nil. In current callgraph it is not a problem (since memcg_free_shrinker_maps is running from memcg_alloc_shrinker_maps and mem_cgroup_css_free only) still this looks suspicious and we can easily elimina

Re: [PATCH 1/2] ARM: dts: exynos: split phandle in dmas property

2019-09-20 Thread Krzysztof Kozlowski
On Fri, Sep 20, 2019 at 02:14:30PM +0200, Marek Szyprowski wrote: > From: Maciej Falkowski > > Change representation of phandle array as then > dt-schema counts number of its items properly. > > Signed-off-by: Maciej Falkowski > Signed-off-by: Marek Szyprowski > --- > arch/arm/boot/dts/exynos

Re: [PATCH v3] dt-bindings: sound: Convert Samsung I2S controller to dt-schema

2019-09-20 Thread Sylwester Nawrocki
On 9/20/19 13:35, Marek Szyprowski wrote: > From: Maciej Falkowski > > Convert Samsung I2S controller to newer dt-schema format. > .../devicetree/bindings/sound/samsung-i2s.txt | 84 --- > .../bindings/sound/samsung-i2s.yaml | 135 ++ > 2 files changed, 135 in

Re: [PATCH v6 6/9] leds: multicolor: Introduce a multicolor class definition

2019-09-20 Thread Dan Murphy
Jacek On 9/19/19 4:32 PM, Jacek Anaszewski wrote: Dan, On 9/19/19 3:07 AM, Dan Murphy wrote: Jacek On 9/18/19 4:27 PM, Jacek Anaszewski wrote: Hi Dan, I think Greg's guidance clarified everything nicely - we will avoid sub-dirs in favour of prefixes to *intensity and *max_intensity. Yes I

[PATCH v4 2/3] dt-bindings: leds: document the "power-supply" property

2019-09-20 Thread Jean-Jacques Hiblot
Most of the LEDs are powered by a voltage/current regulator. Describing it in the device-tree makes it possible for the LED core to enable/disable it when needed. Signed-off-by: Jean-Jacques Hiblot --- Documentation/devicetree/bindings/leds/common.txt | 6 ++ 1 file changed, 6 insertions(+)

[PATCH v4 0/3] leds: Add control of the voltage/current regulator to the LED core

2019-09-20 Thread Jean-Jacques Hiblot
This series makes it possible for the LED core to manage the power supply of a LED. It uses the regulator API to disable/enable the power if when the LED is turned on/off. This is especially useful in situations where the LED driver/controller is not supplying the power. Because updating a regulato

[PATCH v4 3/3] leds: Add control of the voltage/current regulator to the LED core

2019-09-20 Thread Jean-Jacques Hiblot
A LED is usually powered by a voltage/current regulator. Let the LED core know about it. This allows the LED core to turn on or off the power supply as needed. Signed-off-by: Jean-Jacques Hiblot --- drivers/leds/led-class.c | 17 +++ drivers/leds/led-core.c | 65

[PATCH v4 1/3] led: make led_set_brightness_sync() use led_set_brightness_nosleep()

2019-09-20 Thread Jean-Jacques Hiblot
Making led_set_brightness_sync() use led_set_brightness_nosleep() has 2 advantages: - works for LED controllers that do not provide brightness_set_blocking() - When the blocking callback is used, it uses the workqueue to update the LED state, removing the need for mutual exclusion between led_s

Re: [PATCH v3] dt-bindings: sound: Convert Samsung I2S controller to dt-schema

2019-09-20 Thread Krzysztof Kozlowski
On Fri, Sep 20, 2019 at 01:35:40PM +0200, Marek Szyprowski wrote: > From: Maciej Falkowski > > Convert Samsung I2S controller to newer dt-schema format. > > Signed-off-by: Maciej Falkowski > Signed-off-by: Marek Szyprowski > --- > v3: > - Removed quotation marks from strings in compatible prop

Re: [PATCH] jffs2:freely allocate memory when parameters are invalid

2019-09-20 Thread Xiaoming Ni
On 2019/9/20 19:43, Al Viro wrote: > On Fri, Sep 20, 2019 at 02:54:38PM +0800, Xiaoming Ni wrote: >> Use kzalloc() to allocate memory in jffs2_fill_super(). >> Freeing memory when jffs2_parse_options() fails will cause >> use-after-free and double-free in jffs2_kill_sb() > > ... so we are not f

[PATCH] pinctl: ti: iodelay: fix error checking on pinctrl_count_index_with_args call

2019-09-20 Thread Colin King
From: Colin Ian King The call to pinctrl_count_index_with_args checks for a -EINVAL return however this function calls pinctrl_get_list_and_count and this can return -ENOENT. Rather than check for a specific error, fix this by checking for any error return to catch the -ENOENT case. Addresses-Co

Re: [RFC patch 04/15] arm64/entry: Use generic syscall entry function

2019-09-20 Thread Catalin Marinas
On Thu, Sep 19, 2019 at 05:03:18PM +0200, Thomas Gleixner wrote: > #ifdef CONFIG_ARM64_ERRATUM_1463225 > @@ -97,19 +97,16 @@ static void el0_svc_common(struct pt_reg > > regs->orig_x0 = regs->regs[0]; > regs->syscallno = scno; > + /* Set default error number */ > + regs->regs

Re: [Patch 00/13] media: am437x-vpfe: overdue maintenance

2019-09-20 Thread Benoit Parrot
Hans Verkuil wrote on Fri [2019-Sep-20 10:25:02 +0200]: > On 9/19/19 10:41 PM, Benoit Parrot wrote: > > This patch series is a collection of patches we have been carrying for a > > while. > > > > A few patches do fix actual bug and v4l2-compliance errors/warnings. > > Other are drivers re-work to

Re: [Patch v2 10/13] media: am437x-vpfe: Remove print_fourcc helper

2019-09-20 Thread Benoit Parrot
Hans Verkuil wrote on Fri [2019-Sep-20 10:21:17 +0200]: > On 9/19/19 10:41 PM, Benoit Parrot wrote: > > print_fourcc helper function was used for debug log to > > convert a pixel format code into its readable form for display > > purposes. But since it used a single static buffer to perform > > th

[PATCH 1/2] ARM: dts: exynos: split phandle in dmas property

2019-09-20 Thread Marek Szyprowski
From: Maciej Falkowski Change representation of phandle array as then dt-schema counts number of its items properly. Signed-off-by: Maciej Falkowski Signed-off-by: Marek Szyprowski --- arch/arm/boot/dts/exynos5250.dtsi | 14 +++--- arch/arm/boot/dts/exynos5410.dtsi | 6 +++--- arch/a

[PATCH 2/2] arm64: dts: exynos: split phandle in dmas property

2019-09-20 Thread Marek Szyprowski
From: Maciej Falkowski Change representation of phandle array as then dt-schema counts number of its items properly. Signed-off-by: Maciej Falkowski Signed-off-by: Marek Szyprowski --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

Re: [Patch v2 08/13] media: am437x-vpfe: Use a per instance format array instead of a static one

2019-09-20 Thread Benoit Parrot
Hans Verkuil wrote on Fri [2019-Sep-20 10:19:21 +0200]: > On 9/19/19 10:41 PM, Benoit Parrot wrote: > > Using a statically defined format array would cause issue when > > multiple vpfe instance would be connected to sub-device of > > different capabilities. We need to use an instance based array >

[PATCH v4 2/2] leds: tlc591xx: use devm_led_classdev_register_ext()

2019-09-20 Thread Jean-Jacques Hiblot
Use devm_led_classdev_register_ext() to pass the fwnode to the LED core. The fwnode can then be used by the firmware core to create meaningful names. Signed-off-by: Jean-Jacques Hiblot --- drivers/leds/leds-tlc591xx.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/dr

[PATCH v4 1/2] leds: tlc591xx: simplify driver by using the managed led API

2019-09-20 Thread Jean-Jacques Hiblot
Use the managed API of the LED class (devm_led_classdev_register() instead of led_classdev_register()). This allows us to remove the code used to track-and-destroy the LED devices Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Tomi Valkeinen --- drivers/leds/leds-tlc591xx.c | 84 ++

RE: [PATCH v2] ethernet: axienet: Use devm_platform_ioremap_resource() in axienet_probe()

2019-09-20 Thread Radhey Shyam Pandey
> -Original Message- > From: Markus Elfring > Sent: Friday, September 20, 2019 5:01 PM > To: net...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; David S. > Miller ; Michal Simek ; > Radhey Shyam Pandey > Cc: LKML ; kernel-janit...@vger.kernel.org > Subject: [PATCH v2] ethernet:

Re: [PATCH 07/32] x86: Use pr_warn instead of pr_warning

2019-09-20 Thread Kefeng Wang
On 2019/9/20 17:28, Robert Richter wrote: > On 20.09.19 14:25:19, Kefeng Wang wrote: >> As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of >> pr_warning"), removing pr_warning so all logging messages use a >> consistent _warn style. Let's do it. >> >> Cc: Ingo Molnar >> Cc: Borisla

[PATCH v4 0/2] leds: tlc591xx: switch to managed LED registration

2019-09-20 Thread Jean-Jacques Hiblot
This subject of this series used to be "leds: tlc591xx: switch to OF and managed API" This mini-series updates the tlc591xx driver to use the managed API. The driver is also modified to pass the initialization data to the LED core layer. The goal is to be able to the generic led-backlight [0] driv

[PATCH v2 2/2] dt-bindings: arm: fsl: Add PHYTEC i.MX6 devicetree bindings

2019-09-20 Thread Stefan Riedmueller
Add devicetree bindings for i.MX6 based phyCORE-i.MX6, phyBOARD-Mira and phyFLEX-i.MX6. Signed-off-by: Stefan Riedmueller --- Changes in v2: - Use seperate description for each board instead of squashing them into the standard board. --- Documentation/devicetree/bindings/arm/fsl.yaml | 37 ++

[PATCH v2 1/2] dt-bindings: arm: fsl: Add PHYTEC i.MX6 UL/ULL devicetree bindings

2019-09-20 Thread Stefan Riedmueller
Add devicetree bindings for i.MX6 UL/ULL based phyCORE-i.MX6 UL/ULL and phyBOARD-Segin. Signed-off-by: Stefan Riedmueller --- Changes in v2: - Use seperate description for each board instead of squashing them into the standard board. --- Documentation/devicetree/bindings/arm/fsl.yaml | 18 ++

[PATCH v3] dt-bindings: sound: Convert Samsung I2S controller to dt-schema

2019-09-20 Thread Marek Szyprowski
From: Maciej Falkowski Convert Samsung I2S controller to newer dt-schema format. Signed-off-by: Maciej Falkowski Signed-off-by: Marek Szyprowski --- v3: - Removed quotation marks from strings in compatible property - Added min/max items to dmas property - Removed unneeded description from dma-

[PATCH] iio: adc: stm32-adc: fix kernel-doc warnings

2019-09-20 Thread Fabrice Gasnier
Fix the following warnings when documentation is built: drivers/iio/adc/stm32-adc-core.c:62: warning: cannot understand function prototype: 'struct stm32_adc_common_regs ' drivers/iio/adc/stm32-adc-core.c:78: warning: cannot understand function prototype: 'struct stm32_adc_priv_cfg ' drivers/iio/

Re: [RFC patch 14/15] workpending: Provide infrastructure for work before entering a guest

2019-09-20 Thread Thomas Gleixner
On Thu, 19 Sep 2019, Paolo Bonzini wrote: > > + /* Any extra architecture specific work */ > > + return arch_exit_to_guestmode_work(kvm, vcpu, ti_work); > > +} > > Perhaps, in virt/kvm/kvm_main.c: > > int kvm_exit_to_guestmode_work(struct kvm *kvm, struct kvm_vcpu *vcpu, >

Re: [PATCH v2 2/5] leds: lm3692x: Don't overwrite return value in error path

2019-09-20 Thread Pavel Machek
On Thu 2019-09-19 22:27:04, Guido Günther wrote: > The driver currently reports successful initialization on every failure > as long as it's able to power off the regulator. Don't check the return > value of regulator_disable to avoid that. > > Signed-off-by: Guido Günther Acked-by: Pavel Machek

Re: [PATCH v2 2/5] leds: lm3692x: Don't overwrite return value in error path

2019-09-20 Thread Dan Murphy
Guido On 9/20/19 12:27 AM, Guido Günther wrote: The driver currently reports successful initialization on every failure as long as it's able to power off the regulator. Don't check the return value of regulator_disable to avoid that. Signed-off-by: Guido Günther --- drivers/leds/leds-lm3692x

Re: [PATCH] jffs2:freely allocate memory when parameters are invalid

2019-09-20 Thread Al Viro
On Fri, Sep 20, 2019 at 02:54:38PM +0800, Xiaoming Ni wrote: > Use kzalloc() to allocate memory in jffs2_fill_super(). > Freeing memory when jffs2_parse_options() fails will cause > use-after-free and double-free in jffs2_kill_sb() ... so we are not freeing it there. What's the problem?

Re: [PATCH] sched/fair: Speed-up energy-aware wake-ups

2019-09-20 Thread Quentin Perret
On Friday 20 Sep 2019 at 16:03:38 (+0530), Pavan Kondeti wrote: > +1. Looks good to me. Cool, thanks. Peter/Ingo, is there anything else I should do ? Should I resend the patch 'properly' (that is, not inline) ? Thanks, Quentin

Re: [PATCH v2] media: vimc: fla: Add virtual flash subdevice

2019-09-20 Thread Hans Verkuil
On 9/15/19 8:44 PM, Lucas A. M. Magalhães wrote: > From: Lucas A. M. Magalhaes > > Add a virtual subdevice to simulate the flash control API. > Those are the supported controls: > v4l2-ctl -d /dev/v4l-subdev6 -L > Flash Controls > >led_mode 0x009c0901 (menu) : min=0 max

[PATCH v2] ethernet: axienet: Use devm_platform_ioremap_resource() in axienet_probe()

2019-09-20 Thread Markus Elfring
From: Markus Elfring Date: Fri, 20 Sep 2019 13:17:01 +0200 Simplify this function implementation by using the wrapper function “devm_platform_ioremap_resource” instead of calling the functions “platform_get_resource” and “devm_ioremap_resource” directly. * Thus reduce also a bit of exception han

Re: [PATCH 4.19 18/79] nl80211: Fix possible Spectre-v1 for CQM RSSI thresholds

2019-09-20 Thread Pavel Machek
Hi! > commit 4b2c5a14cd8005a900075f7dfec87473c6ee66fb upstream. > > commit 1222a1601488 ("nl80211: Fix possible Spectre-v1 for CQM > RSSI thresholds") was incomplete and requires one more fix to > prevent accessing to rssi_thresholds[n] because user can control > rssi_thresholds[i] values to make

Re: [PATCH 1/2] PCI: Add a helper to check Power Resource Requirements _PR3 existence

2019-09-20 Thread Kai-Heng Feng
Hi Bjorn, I didn't find your reply in my mailbox earlier. On Mon, Sep 9, 2019 at 1:41 PM Bjorn Helgaas wrote: > > Maybe: > > PCI: Add pci_pr3_present() to check for Power Resources for D3hot Ok, this is a good title. > > On Tue, Aug 27, 2019 at 09:47:55PM +0800, Kai-Heng Feng wrote: > > A dr

Re: [PATCH 4.19 65/79] net: aquantia: fix out of memory condition on rx side

2019-09-20 Thread Pavel Machek
Hi! > [ Upstream commit be6cef69ba570ebb327eba1ef6438f7af49aaf86 ] > > On embedded environments with hard memory limits it is a normal although > rare case when skb can't be allocated on rx part under high traffic. > > In such OOM cases napi_complete_done() was not called. > So the napi object b

Applied "ASoC: ti: fix SND_SOC_DM365_VOICE_CODEC dependencies" to the asoc tree

2019-09-20 Thread Mark Brown
The patch ASoC: ti: fix SND_SOC_DM365_VOICE_CODEC dependencies has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hour

Spende von 5 Millionen Euro

2019-09-20 Thread Shane Missler
Dies ist eine persönliche Mail, die ich an Sie adressiere. Ich bin SHANE MISSLER aus Florida, USA. Wie Sie bereits wissen, habe ich einen Lotto-Jackpot in Höhe von 451 Mio. USD (330 Mio. GBP) gewonnen und das Geld hat mein Leben und mein Familienleben verändert, aber es wird mein Herz nicht verä

Re: [PATCH v2] media: vimc: Enable set resolution at the scaler src pad

2019-09-20 Thread Hans Verkuil
Hi Pedro, Gabriela, Gabriel, On 9/15/19 11:35 PM, Pedro Terra wrote: > Modify the scaler subdevice to accept setting the resolution of the source > pad (previously the source resolution would always be 3 times the sink for > both dimensions). Now any resolution can be set at src (even smaller ones

Re: [PATCH V1 0/1] tick: broadcast-hrtimer: Fix a race in bc_set_next

2019-09-20 Thread Eugeniu Rosca
+linux-renesas-soc In hope that the issue reported in [1] was seen by other members of Renesas community. [1] https://lkml.org/lkml/2019/9/18/711 On Wed, Sep 18, 2019 at 04:41:37PM +0200, Balasubramani Vivekanandan wrote: > I was investigating a rcu stall warning on ARM64 Renesas Rcar3 > platfor

[PATCH v2] ethernet: lantiq_xrx200: Use devm_platform_ioremap_resource() in xrx200_probe()

2019-09-20 Thread Markus Elfring
From: Markus Elfring Date: Fri, 20 Sep 2019 11:48:33 +0200 Simplify this function implementation by using the wrapper function “devm_platform_ioremap_resource” instead of calling the functions “platform_get_resource” and “devm_ioremap_resource” directly. * Thus reduce also a bit of exception han

[PATCH v2 1/3] platform/x86: eeepc-laptop: Use pr_warn instead of pr_warning

2019-09-20 Thread Kefeng Wang
As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of pr_warning"), removing pr_warning so all logging messages use a consistent _warn style. Let's do it. Cc: Corentin Chary Cc: Darren Hart Cc: Andy Shevchenko Cc: Andy Shevchenko Signed-off-by: Kefeng Wang --- drivers/platform/x86

[PATCH v2 3/3] platform/x86: intel_oaktrail: Use pr_warn instead of pr_warning

2019-09-20 Thread Kefeng Wang
As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of pr_warning"), removing pr_warning so all logging messages use a consistent _warn style. Let's do it. Cc: Corentin Chary Cc: Darren Hart Cc: Andy Shevchenko Cc: Andy Shevchenko Signed-off-by: Kefeng Wang --- drivers/platform/x86

Re: [PATCH] fixed-regulator: dt-bindings: Fixed building error for compatible property

2019-09-20 Thread Mark Brown
On Thu, Sep 19, 2019 at 12:09:04PM +0530, Pragnesh Patel wrote: > Compatible property is not of type 'string', so remove const: > from it. Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches. There's no need to resubmit to f

[PATCH v2 2/3] platform/x86: asus-laptop: Use pr_warn instead of pr_warning

2019-09-20 Thread Kefeng Wang
As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of pr_warning"), removing pr_warning so all logging messages use a consistent _warn style. Let's do it. Cc: Corentin Chary Cc: Darren Hart Cc: Andy Shevchenko Cc: Andy Shevchenko Signed-off-by: Kefeng Wang --- drivers/platform/x86

Re: [PATCH v2 -next] PCI: tegra: Add missing include file

2019-09-20 Thread Andrew Murray
On Fri, Sep 20, 2019 at 06:39:25PM +0800, YueHaibing wrote: > Fix build error without CONFIG_PINCTRL > > drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp: > drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit > declaration of function pinctrl_pm_select_d

Re: [PATCH] spi: atmel: Fix crash when using more than 4 gpio CS

2019-09-20 Thread Mark Brown
On Thu, Sep 19, 2019 at 07:23:50PM +0200, Alexandre Belloni wrote: > On 19/09/2019 17:03:15+0100, Mark Brown wrote: > > This is going to break any system where we use both a GPIO chip select > > and chip select 0. Ideally we'd try to figure out an unused chip select > > to use here... > The poin

[PATCH] mm: slub: print_hex_dump() with DUMP_PREFIX_OFFSET

2019-09-20 Thread Miles Chen
Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), The use DUMP_PREFIX_OFFSET instead of DUMP_PREFIX_ADDRESS with print_hex_dump() can generate more useful messages. In the following example, it's easier get the offset of incorrect poison value with DUMP_PREFIX_OFFSET. Befo

Re: Usecases for the per-task latency-nice attribute

2019-09-20 Thread Parth Shah
On 9/19/19 8:13 PM, Qais Yousef wrote: > On 09/18/19 18:11, Parth Shah wrote: >> Hello everyone, >> >> As per the discussion in LPC2019, new per-task property like latency-nice >> can be useful in certain scenarios. The scheduler can take proper decision >> by knowing latency requirement of a ta

[PATCH v2 -next] PCI: tegra: Add missing include file

2019-09-20 Thread YueHaibing
Fix build error without CONFIG_PINCTRL drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp: drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function pinctrl_pm_select_default_state; did you mean prandom_seed_full_state? [-Werror=implicit

Re: [PATCH V1 0/1] tick: broadcast-hrtimer: Fix a race in bc_set_next

2019-09-20 Thread Eugeniu Rosca
+linux-renesas-soc In hope that the issue reported in [1] was seen by other members of Renesas community. [1] https://lkml.org/lkml/2019/9/18/711 On Wed, Sep 18, 2019 at 04:41:37PM +0200, Balasubramani Vivekanandan wrote: > I was investigating a rcu stall warning on ARM64 Renesas Rcar3 > platfor

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-20 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 08:39:34PM +0200, Andrew Lunn wrote: > > > Well, the _correct_ driver needs to be used for the PHY specific > > > features to be properly controlled. Using the generic driver > > > in this situation will not be guaranteed to work. > > I fully agree about the PHY driver. I'

Re: [PATCH] sched/fair: Speed-up energy-aware wake-ups

2019-09-20 Thread Pavan Kondeti
Hi Quentin, On Fri, Sep 20, 2019 at 11:41:15AM +0200, Quentin Perret wrote: > Hi Pavan, > > On Friday 20 Sep 2019 at 08:32:15 (+0530), Pavan Kondeti wrote: > > Earlier, we are not checking the spare capacity for the prev_cpu. Now that > > the > > continue statement is removed, prev_cpu could als

Re: [PATCH] platform/x86: i2c-multi-instantiate: Derive the device name from parent

2019-09-20 Thread Hans de Goede
Hi, On 9/20/19 12:02 PM, Heikki Krogerus wrote: When naming the new devices, instead of using the ACPI ID in the name as base, using the parent device's name. That makes it possible to support multiple multi-instance i2c devices of the same type in the same system. This fixes an issue seen on s

Re: checkpatch warnings in sched.h

2019-09-20 Thread Dan Carpenter
On Fri, Sep 20, 2019 at 02:34:46AM -0500, Steve French wrote: > Any hints to get rid of the noisy warnings in sched.h that make it > hard to spot real warnings: > > /include/linux/sched.h:609:43: error: bad integer constant expression > /include/linux/sched.h:609:73: error: invalid named zero-widt

Re: "arm64: use asm-generic/dma-mapping.h" introduced a kbuild warning

2019-09-20 Thread Masahiro Yamada
Hi Qian, On Thu, Sep 19, 2019 at 10:06 PM Qian Cai wrote: > > The commit 5489c8e0cf03 ("arm64: use asm-generic/dma-mapping.h") introduced a > kbuild warning, > > scripts/Makefile.asm-generic:25: redundant generic-y found in > arch/arm64/include/asm/Kbuild: dma-mapping.h > > Which tree did you te

Re: [PATCH] rtl8xxxu: prevent leaking urb

2019-09-20 Thread Chris Chiu
On Fri, Sep 20, 2019 at 11:01 AM Navid Emamdoost wrote: > > In rtl8xxxu_submit_int_urb if usb_submit_urb fails the allocated urb > should be released. > > Signed-off-by: Navid Emamdoost Reviewed-by: Chris Chiu > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > +++ b/drivers/net/wi

Re: [RFC 0/2] kvm: Use host timekeeping in guest.

2019-09-20 Thread Thomas Gleixner
On Fri, 20 Sep 2019, Paolo Bonzini wrote: > On 20/09/19 08:27, Suleiman Souhlal wrote: > > To do that, I am changing kvmclock to request to the host to copy > > its timekeeping parameters (mult, base, cycle_last, etc), so that > > the guest timekeeper can use the same values, so that time can > >

Re: INFO: rcu detected stall in sys_exit_group

2019-09-20 Thread Tetsuo Handa
Calling printk() people. On 2019/09/20 16:50, Dmitry Vyukov wrote: >>> How it runs on top of an interrupt? >> >> It is not running on top of an interrupt. Its stack was dumped >> separately. > > I see. Usually the first stack is the traceback of the current stac

Re: KASAN: use-after-free Read in adu_disconnect

2019-09-20 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KASAN: use-after-free Read in adu_release == BUG: KASAN: use-after-free in adu_release+0x4dc/0x590 drivers/usb/misc/adutux.c:322 Read of siz

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

2019-09-20 Thread Okash Khawaja
On Fri, Sep 20, 2019 at 8:46 AM Greg Kroah-Hartman wrote: > > On Wed, Sep 18, 2019 at 01:30:33PM -0700, Gregory Nowak wrote: > > > Extra line between each attribute (before the "What:" line) would be > > > nice. > > > > In a previous post above, you wrote: > > On Mon, Sep 16, 2019 at 04:11:00PM +0

Re: [Patch v2 5/7] media: i2c: ov2659: Add powerdown/reset gpio handling

2019-09-20 Thread Sakari Ailus
Hi Benoit, Thanks for the update. On Thu, Sep 19, 2019 at 03:39:53PM -0500, Benoit Parrot wrote: > On some board it is possible that the sensor 'powerdown' and or 'reset' > pin might be controlled by gpio instead of being tied. > > To implement we add pm_runtime support which will handle the pow

Re: KASAN: use-after-free Read in adu_disconnect

2019-09-20 Thread Andrey Konovalov
On Fri, Sep 20, 2019 at 12:08 PM Dmitry Vyukov wrote: > > On Fri, Sep 20, 2019 at 12:02 PM Johan Hovold wrote: > > > > On Fri, Sep 20, 2019 at 02:20:00AM -0700, syzbot wrote: > > > Hello, > > > > > > syzbot has tested the proposed patch but the reproducer still triggered > > > crash: > > > KASAN:

Re: KASAN: use-after-free Read in adu_disconnect

2019-09-20 Thread Dmitry Vyukov
On Fri, Sep 20, 2019 at 12:02 PM Johan Hovold wrote: > > On Fri, Sep 20, 2019 at 02:20:00AM -0700, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch but the reproducer still triggered > > crash: > > KASAN: use-after-free Read in adu_interrupt_in_callback > > > > ===

[RFC PATCH] lib/ubsan: Don't seralize UBSAN report

2019-09-20 Thread Julien Grall
At the moment, UBSAN report will be serialized using a spin_lock(). On RT-systems, spinlocks are turned to rt_spin_lock and may sleep. This will result to the following splat if the undefined behavior is in a context that can sleep: [ 6951.484876] BUG: sleeping function called from invalid context

[PATCH] KVM: LAPIC: micro-optimize fixed mode ipi delivery

2019-09-20 Thread Wanpeng Li
From: Wanpeng Li After disabling mwait/halt/pause vmexits, RESCHEDULE_VECTOR and CALL_FUNCTION_SINGLE_VECTOR etc IPI is one of the main remaining cause of vmexits observed in product environment which can't be optimized by PV IPIs. This patch is the follow-up on commit 0e6d242eccdb (KVM: LAPIC

Re: KASAN: use-after-free Read in adu_disconnect

2019-09-20 Thread Dmitry Vyukov
On Fri, Sep 20, 2019 at 11:35 AM Johan Hovold wrote: > > On Fri, Sep 20, 2019 at 11:28:22AM +0200, Dmitry Vyukov wrote: > > On Fri, Sep 20, 2019 at 11:21 AM Johan Hovold wrote: > > > > > > On Fri, Sep 20, 2019 at 11:13:14AM +0200, Dmitry Vyukov wrote: > > > > On Fri, Sep 20, 2019 at 11:08 AM Joha

Re: [PATCH v2 1/3] cifs: Add support for root file systems

2019-09-20 Thread Paulo Alcantara
"Paulo Alcantara (SUSE)" writes: > Introduce a new CONFIG_CIFS_ROOT option to handle root file systems > over a SMB share. > > In order to mount the root file system during the init process, make > cifs.ko perform non-blocking socket operations while mounting and > accessing it. > > Signed-off-by

Re: KASAN: use-after-free Read in adu_disconnect

2019-09-20 Thread Johan Hovold
On Fri, Sep 20, 2019 at 02:20:00AM -0700, syzbot wrote: > Hello, > > syzbot has tested the proposed patch but the reproducer still triggered > crash: > KASAN: use-after-free Read in adu_interrupt_in_callback > > == > BUG: KASAN: us

[PATCH] platform/x86: i2c-multi-instantiate: Derive the device name from parent

2019-09-20 Thread Heikki Krogerus
When naming the new devices, instead of using the ACPI ID in the name as base, using the parent device's name. That makes it possible to support multiple multi-instance i2c devices of the same type in the same system. This fixes an issue seen on some Intel Kaby Lake based boards: sysfs: cannot cr

Re: [PATCH v3 1/3] dt-bindings: dmaengine: sf-pdma: add bindins for SiFive PDMA

2019-09-20 Thread Pragnesh Patel
On Fri, Sep 20, 2019 at 2:30 PM Green Wan wrote: > > Add DT bindings document for Platform DMA(PDMA) driver of board, > HiFive Unleashed Rev A00. > > Signed-off-by: Green Wan > --- > .../bindings/dma/sifive,fu540-c000-pdma.yaml | 55 +++ > MAINTAINERS

Re: drivers/platform/x86/asus-wmi.c:464: undefined reference to `battery_hook_unregister'

2019-09-20 Thread Andy Shevchenko
On Fri, Sep 20, 2019 at 11:23:43AM +0800, kbuild test robot wrote: > Hi Kristian, > > FYI, the error/warning still remains. > > tree: > https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 574cc4539762561d96b456dbc0544d8898bd4c6e > commit: 7973353e92e

Re: [PATCH] sched/fair: Speed-up energy-aware wake-ups

2019-09-20 Thread Quentin Perret
Hi Pavan, On Friday 20 Sep 2019 at 08:32:15 (+0530), Pavan Kondeti wrote: > Earlier, we are not checking the spare capacity for the prev_cpu. Now that the > continue statement is removed, prev_cpu could also be the max_spare_cap_cpu. > Actually that makes sense. Because there is no reason why we w

[PATCH] staging: rtl8188eu: remove unnecessary self-assignment

2019-09-20 Thread Connor Kuehl
This is a self-assignment which is redundant. Fix this by removing the self-assignment. Addresses-Coverity: ("Self assignment") Signed-off-by: Connor Kuehl --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8

Re: KASAN: use-after-free Read in adu_disconnect

2019-09-20 Thread Johan Hovold
On Fri, Sep 20, 2019 at 11:28:22AM +0200, Dmitry Vyukov wrote: > On Fri, Sep 20, 2019 at 11:21 AM Johan Hovold wrote: > > > > On Fri, Sep 20, 2019 at 11:13:14AM +0200, Dmitry Vyukov wrote: > > > On Fri, Sep 20, 2019 at 11:08 AM Johan Hovold wrote: > > > > > > > > On Fri, Aug 09, 2019 at 01:24:04P

Re: [PATCH 2/3] mmc: sdhci-of-at91: rework clocks management to support SAM9x60 device

2019-09-20 Thread Eugen.Hristev
On 12.09.2019 23:09, Ludovic Desroches wrote: > > In the SAM9x60 SoC, there are only two clocks instead of three for the > SDHCI device. The base clk is no longer provided, it is generated > internally from the mult clk. > > The values of the base clk and mul in the capabilities registers may

[PATCH v2] platform/x86: pmc_atom: Add Siemens SIMATIC IPC277E to critclk_systems DMI table

2019-09-20 Thread Srikanth Krishnakar
The SIMATIC IPC277E uses the PMC clock for on-board components and gets stuck during boot if the clock is disabled. Therefore, add this device to the critical systems list. Tested on SIMATIC IPC277E. Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL") Reviewed-by: Jan Kiszka

Re: [PATCH 00/32] Kill pr_warning in the whole linux code

2019-09-20 Thread Sergey Senozhatsky
On (09/20/19 14:25), Kefeng Wang wrote: > There are pr_warning and pr_warng to show WARNING level message, > most of the code using pr_warn, number based on next-20190919, Looks good to me. Reviewed-by: Sergey Senozhatsky -ss

Re: [PATCH 07/32] x86: Use pr_warn instead of pr_warning

2019-09-20 Thread Robert Richter
On 20.09.19 14:25:19, Kefeng Wang wrote: > As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of > pr_warning"), removing pr_warning so all logging messages use a > consistent _warn style. Let's do it. > > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: Robert Rich

Re: KASAN: use-after-free Read in adu_disconnect

2019-09-20 Thread Dmitry Vyukov
On Fri, Sep 20, 2019 at 11:21 AM Johan Hovold wrote: > > On Fri, Sep 20, 2019 at 11:13:14AM +0200, Dmitry Vyukov wrote: > > On Fri, Sep 20, 2019 at 11:08 AM Johan Hovold wrote: > > > > > > On Fri, Aug 09, 2019 at 01:24:04PM -0700, syzbot wrote: > > > > syzbot has found a reproducer for the follow

Re: [PATCH v4 2/3] dmaengine: imx-sdma: fix dma freezes

2019-09-20 Thread Lucas Stach
On Fr, 2019-09-20 at 10:53 +0200, Philipp Puschmann wrote: > Hi Jan, > > Am 19.09.19 um 17:19 schrieb Jan Lübbe: > > Hi Philipp, > > > > see below... > > > > On Thu, 2019-09-19 at 16:29 +0200, Philipp Puschmann wrote: > > > For some years and since many kernel versions there are reports that the

[PATCH v7 00/12] implement KASLR for powerpc/fsl_booke/32

2019-09-20 Thread Jason Yan
This series implements KASLR for powerpc/fsl_booke/32, as a security feature that deters exploit attempts relying on knowledge of the location of kernel internals. Since CONFIG_RELOCATABLE has already supported, what we need to do is map or copy kernel to a proper place and relocate. Freescale Boo

[PATCH v7 12/12] powerpc/fsl_booke/32: Document KASLR implementation

2019-09-20 Thread Jason Yan
Add document to explain how we implement KASLR for fsl_booke32. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Nicholas Piggin Cc: Kees Cook --- Documentation/powerpc/kaslr-booke32.rst | 42 +++

[PATCH v7 04/12] powerpc/fsl_booke/32: introduce create_kaslr_tlb_entry() helper

2019-09-20 Thread Jason Yan
Add a new helper create_kaslr_tlb_entry() to create a tlb entry by the virtual and physical address. This is a preparation to support boot kernel at a randomized address. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul M

[PATCH v7 05/12] powerpc/fsl_booke/32: introduce reloc_kernel_entry() helper

2019-09-20 Thread Jason Yan
Add a new helper reloc_kernel_entry() to jump back to the start of the new kernel. After we put the new kernel in a randomized place we can use this new helper to enter the kernel and begin to relocate again. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy

[PATCH v7 02/12] powerpc: move memstart_addr and kernstart_addr to init-common.c

2019-09-20 Thread Jason Yan
These two variables are both defined in init_32.c and init_64.c. Move them to init-common.c and make them __ro_after_init. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Nicholas Piggin Cc: Kees Cook Re

[PATCH v7 03/12] powerpc: introduce kernstart_virt_addr to store the kernel base

2019-09-20 Thread Jason Yan
Now the kernel base is a fixed value - KERNELBASE. To support KASLR, we need a variable to store the kernel base. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Nicholas Piggin Cc: Kees Cook Reviewed-by

[PATCH v7 09/12] powerpc/fsl_booke/kaslr: support nokaslr cmdline parameter

2019-09-20 Thread Jason Yan
One may want to disable kaslr when boot, so provide a cmdline parameter 'nokaslr' to support this. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Nicholas Piggin Cc: Kees Cook Reviewed-by: Diana Craciun

[PATCH v7 08/12] powerpc/fsl_booke/kaslr: clear the original kernel if randomized

2019-09-20 Thread Jason Yan
The original kernel still exists in the memory, clear it now. Signed-off-by: Jason Yan Cc: Diana Craciun Cc: Michael Ellerman Cc: Christophe Leroy Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Nicholas Piggin Cc: Kees Cook Reviewed-by: Christophe Leroy Reviewed-by: Diana Craciun Test

[PATCH v7 10/12] powerpc/fsl_booke/kaslr: dump out kernel offset information on panic

2019-09-20 Thread Jason Yan
When kaslr is enabled, the kernel offset is different for every boot. This brings some difficult to debug the kernel. Dump out the kernel offset when panic so that we can easily debug the kernel. This code is derived from x86/arm64 which has similar functionality. Signed-off-by: Jason Yan Cc: Di

[PATCH v7 11/12] powerpc/fsl_booke/kaslr: export offset in VMCOREINFO ELF notes

2019-09-20 Thread Jason Yan
Like all other architectures such as x86 or arm64, include KASLR offset in VMCOREINFO ELF notes to assist in debugging. After this, we can use crash --kaslr option to parse vmcore generated from a kaslr kernel. Note: The crash tool needs to support --kaslr too. Signed-off-by: Jason Yan Cc: Diana

[PATCH v7 07/12] powerpc/fsl_booke/32: randomize the kernel image offset

2019-09-20 Thread Jason Yan
After we have the basic support of relocate the kernel in some appropriate place, we can start to randomize the offset now. Entropy is derived from the banner and timer, which will change every build and boot. This not so much safe so additionally the bootloader may pass entropy via the /chosen/ka

[PATCH v7 06/12] powerpc/fsl_booke/32: implement KASLR infrastructure

2019-09-20 Thread Jason Yan
This patch add support to boot kernel from places other than KERNELBASE. Since CONFIG_RELOCATABLE has already supported, what we need to do is map or copy kernel to a proper place and relocate. Freescale Book-E parts expect lowmem to be mapped by fixed TLB entries(TLB1). The TLB1 entries are not su

<    3   4   5   6   7   8   9   >