Re: [PATCH] hugetlb: Add nohugepages parameter to prevent hugepages creation

2019-10-11 Thread Guilherme Piccoli
On Fri, Oct 11, 2019 at 8:36 PM Qian Cai wrote: > > Typically, kdump kernel has its own initramfs, and don’t even need to mount a > rootfs, so I can’t see how sysfs/sysctl is relevant here. Thanks for the quick response. Kdump in Ubuntu, for example, rely in mounting the root filesystem. Even in

[PATCH] zswap: allow setting default status, compressor and allocator in Kconfig

2019-10-11 Thread Maciej S. Szmigiero
The compressed cache for swap pages (zswap) currently needs from 1 to 3 extra kernel command line parameters in order to make it work: it has to be enabled by adding a "zswap.enabled=1" command line parameter and if one wants a different compressor or pool allocator than the default lzo / zbud comb

Re: [PATCH] hugetlb: Add nohugepages parameter to prevent hugepages creation

2019-10-11 Thread Qian Cai
> On Oct 11, 2019, at 6:40 PM, Guilherme G. Piccoli > wrote: > > Kdump kernels won't benefit from hugepages - in fact it's quite opposite, > it may be the case hugepages on kdump kernel can lead to OOM if kernel > gets unable to allocate demanded pages due to the fact the preallocated > hugep

Re: [PATCH 3/3] HID: logitech-hidpp: add G920 device validation quirk

2019-10-11 Thread Andrey Smirnov
On Fri, Oct 11, 2019 at 3:33 PM Benjamin Tissoires wrote: > > On Fri, Oct 11, 2019 at 9:39 PM Andrey Smirnov > wrote: > > > > On Fri, Oct 11, 2019 at 7:56 AM Benjamin Tissoires > > wrote: > > > > > > On Mon, Oct 7, 2019 at 7:13 AM Andrey Smirnov > > > wrote: > > > > > > > > G920 device only a

Re: [PATCH v4 00/14] software node: add support for reference properties

2019-10-11 Thread Dmitry Torokhov
merge window is over could you please take a look at the > > series? > > I will. > > It would help to resend the whole series with a CC to linux-acpi, though. Rebased to next-20191011 and sent to linux-acpi and others. Thanks! -- Dmitry

Re: [PATCH 1/3] HID: logitech-hidpp: use devres to manage FF private data

2019-10-11 Thread Dmitry Torokhov
On Sat, Oct 12, 2019 at 12:48:42AM +0200, Benjamin Tissoires wrote: > On Fri, Oct 11, 2019 at 11:34 PM Dmitry Torokhov > wrote: > > > > On Fri, Oct 11, 2019 at 01:35:09PM -0700, Dmitry Torokhov wrote: > > > On Fri, Oct 11, 2019 at 01:33:03PM -0700, Dmitry Torokhov wrote: > > > > On Fri, Oct 11, 20

Re: [PATCH net-next] net: bcmgenet: Generate a random MAC if none is valid

2019-10-11 Thread Scott Branden
On 2019-10-11 4:19 p.m., Florian Fainelli wrote: Instead of having a hard failure and stopping the driver's probe routine, generate a random Ethernet MAC address to keep going. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 15 ++- 1 file

[PATCH net-next] net: bcmgenet: Generate a random MAC if none is valid

2019-10-11 Thread Florian Fainelli
Instead of having a hard failure and stopping the driver's probe routine, generate a random Ethernet MAC address to keep going. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/d

Re: [PATCH v1 3/3] ARM: dts: bcm2711: Enable GENET support for the RPi4

2019-10-11 Thread Stefan Wahren
Am 11.10.19 um 20:48 schrieb matthias@kernel.org: > From: Matthias Brugger > > Enable Gigabit Ethernet support on the Raspberry Pi 4 > Model B. I asked some questions about genet to the RPi guys [1] which are relevant to this patch (missing clocks and interrupt, MAC address assignment) but i

Re: [PATCH v1 3/3] ARM: dts: bcm2711: Enable GENET support for the RPi4

2019-10-11 Thread Florian Fainelli
On 10/11/19 4:09 PM, Stefan Wahren wrote: > Am 11.10.19 um 20:48 schrieb matthias@kernel.org: >> From: Matthias Brugger >> >> Enable Gigabit Ethernet support on the Raspberry Pi 4 >> Model B. > > I asked some questions about genet to the RPi guys [1] which are > relevant to this patch (missin

[PATCH v5 10/14] software node: rename is_array to is_inline

2019-10-11 Thread Dmitry Torokhov
We do not need a special flag to know if we are dealing with an array, as we can get that data from ratio between element length and the data size, however we do need a flag to know whether the data is stored directly inside property_entry or separately. Signed-off-by: Dmitry Torokhov --- driver

[PATCH v5 12/14] software node: implement reference properties

2019-10-11 Thread Dmitry Torokhov
It is possible to store references to software nodes in the same fashion as other static properties, so that users do not need to define separate structures: static const struct software_node gpio_bank_b_node = { .name = "B", }; static const struct property_entry simone_key_enter_props[]

[PATCH v5 06/14] software node: get rid of property_set_pointer()

2019-10-11 Thread Dmitry Torokhov
Instead of explicitly setting values of integer types when copying property entries lets just copy entire value union when processing non-array values. For value arrays we no longer use union of pointers, but rather a single void pointer, which allows us to remove property_set_pointer(). In prope

[PATCH v5 14/14] software node: remove separate handling of references

2019-10-11 Thread Dmitry Torokhov
Now that all users of references have moved to reference properties, we can remove separate handling of references. Signed-off-by: Dmitry Torokhov --- drivers/base/swnode.c| 46 +++- include/linux/property.h | 14 2 files changed, 17 insertion

[PATCH v5 13/14] platform/x86: intel_cht_int33fe: use inline reference properties

2019-10-11 Thread Dmitry Torokhov
Now that static device properties allow defining reference properties together with all other types of properties, instead of managing them separately, let's adjust the driver. Signed-off-by: Dmitry Torokhov --- drivers/platform/x86/intel_cht_int33fe.c | 81 1 file chang

[PATCH v5 07/14] software node: remove property_entry_read_uNN_array functions

2019-10-11 Thread Dmitry Torokhov
There is absolutely no reason to have them as we can handle it all nicely in property_entry_read_int_array(). Signed-off-by: Dmitry Torokhov --- drivers/base/swnode.c | 85 +++ 1 file changed, 14 insertions(+), 71 deletions(-) diff --git a/drivers/base/sw

[PATCH v5 11/14] software node: move small properties inline when copying

2019-10-11 Thread Dmitry Torokhov
When copying/duplicating set of properties, move smaller properties that were stored separately directly inside property entry structures. We can move: - up to 8 bytes from U8 arrays - up to 4 words - up to 2 double words - one U64 value - one or 2 strings. Signed-off-by: Dmitry Torokhov --- dr

[PATCH v5 08/14] software node: unify PROPERTY_ENTRY_XXX macros

2019-10-11 Thread Dmitry Torokhov
We can unify string properties initializer macros with integer initializers. Signed-off-by: Dmitry Torokhov --- include/linux/property.h | 64 +--- 1 file changed, 27 insertions(+), 37 deletions(-) diff --git a/include/linux/property.h b/include/linux/propert

[PATCH v5 02/14] software node: introduce PROPERTY_ENTRY_ARRAY_XXX_LEN()

2019-10-11 Thread Dmitry Torokhov
Sometimes we want to initialize property entry array from a regular pointer, when we can't determine length automatically via ARRAY_SIZE. Let's introduce PROPERTY_ENTRY_ARRAY_XXX_LEN macros that take explicit "len" argument. Signed-off-by: Dmitry Torokhov --- include/linux/property.h | 45 ++

[PATCH v5 00/14] software node: add support for reference properties

2019-10-11 Thread Dmitry Torokhov
nline when copying property entries; patch #12 implements PROPERTY_ENTRY_REF() and friends; patch #13 converts the user of references to the property syntax, and patch #14 removes the remains of references as entities that are managed separately. Changes in v5: - rebased onto next-20191011 Changes in v

[PATCH v5 04/14] software node: mark internal macros with double underscores

2019-10-11 Thread Dmitry Torokhov
Let's mark PROPERTY_ENTRY_* macros that are internal with double leading underscores so users are not tempted to use them. Signed-off-by: Dmitry Torokhov --- include/linux/property.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/include/linux/property

[PATCH v5 05/14] software node: clean up property_copy_string_array()

2019-10-11 Thread Dmitry Torokhov
Because property_copy_string_array() stores the newly allocated pointer in the destination property, we have an awkward code in property_entry_copy_data() where we fetch the new pointer from dst. Let's change property_copy_string_array() to return pointer and rely on the common path in property_en

[PATCH v5 09/14] software node: simplify property_entry_read_string_array()

2019-10-11 Thread Dmitry Torokhov
There is no need to treat string arrays and single strings separately, we can go exclusively by the element length in relation to data type size. Signed-off-by: Dmitry Torokhov --- drivers/base/swnode.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/dr

[PATCH v5 01/14] software node: remove DEV_PROP_MAX

2019-10-11 Thread Dmitry Torokhov
This definition is not used anywhere, let's remove it. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Signed-off-by: Dmitry Torokhov --- include/linux/property.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/property.h b/include/linux/property.h index 9b3d4ca3a73

[PATCH v5 03/14] efi/apple-properties: use PROPERTY_ENTRY_U8_ARRAY_LEN

2019-10-11 Thread Dmitry Torokhov
Let's switch to using PROPERTY_ENTRY_U8_ARRAY_LEN() to initialize property entries. Also, when dumping data, rely on local variables instead of poking into the property entry structure directly. Signed-off-by: Dmitry Torokhov --- drivers/firmware/efi/apple-properties.c | 18 -- 1

Re: [PATCH 1/3] HID: logitech-hidpp: use devres to manage FF private data

2019-10-11 Thread Benjamin Tissoires
On Fri, Oct 11, 2019 at 11:34 PM Dmitry Torokhov wrote: > > On Fri, Oct 11, 2019 at 01:35:09PM -0700, Dmitry Torokhov wrote: > > On Fri, Oct 11, 2019 at 01:33:03PM -0700, Dmitry Torokhov wrote: > > > On Fri, Oct 11, 2019 at 09:25:52PM +0200, Benjamin Tissoires wrote: > > > > On Fri, Oct 11, 2019 a

Re: [PATCH 3/3] arm64: configs: unset CPU_BIG_ENDIAN

2019-10-11 Thread Arnd Bergmann
On Fri, Oct 11, 2019 at 12:33 PM Russell King - ARM Linux admin wrote: > > On Fri, Oct 11, 2019 at 11:27:48AM +0100, Will Deacon wrote: > > Does anybody use BIG_ENDIAN? If we're not even building it then maybe we > > should get rid of it altogether on arm64. I don't know of any supported > > users

[PATCH] hugetlb: Add nohugepages parameter to prevent hugepages creation

2019-10-11 Thread Guilherme G. Piccoli
Currently there are 2 ways for setting HugeTLB hugepages in kernel; either users pass parameters on kernel command-line or they can write to sysfs files (which is effectively the sysctl way). Kdump kernels won't benefit from hugepages - in fact it's quite opposite, it may be the case hugepages on

[RFC] asm-generic/tlb: stub out pmd_free_tlb() if __PAGETABLE_PMD_FOLDED

2019-10-11 Thread Vineet Gupta
This is inine with similar patches for nopud [1] and nop4d [2] cases. However I'm not really sure I understand clearly how the nopmd code is supposed to work (for a 2 tier paging system) - hence the RFC. Consider free_pmd_range() simplified/annotated below free_pmd_range ... pmd

Re: [PATCH 1/3] HID: logitech-hidpp: use devres to manage FF private data

2019-10-11 Thread Benjamin Tissoires
On Fri, Oct 11, 2019 at 10:33 PM Dmitry Torokhov wrote: > > On Fri, Oct 11, 2019 at 09:25:52PM +0200, Benjamin Tissoires wrote: > > On Fri, Oct 11, 2019 at 8:26 PM Dmitry Torokhov > > wrote: > > > > > > On Fri, Oct 11, 2019 at 04:52:04PM +0200, Benjamin Tissoires wrote: > > > > Hi Andrey, > > > >

Re: [PATCH 3/3] HID: logitech-hidpp: add G920 device validation quirk

2019-10-11 Thread Benjamin Tissoires
On Fri, Oct 11, 2019 at 9:39 PM Andrey Smirnov wrote: > > On Fri, Oct 11, 2019 at 7:56 AM Benjamin Tissoires > wrote: > > > > On Mon, Oct 7, 2019 at 7:13 AM Andrey Smirnov > > wrote: > > > > > > G920 device only advertises REPORT_ID_HIDPP_LONG and > > > REPORT_ID_HIDPP_VERY_LONG in its HID repo

Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warnings of lines should not end with open parenthesis

2019-10-11 Thread Joe Perches
On Fri, 2019-10-11 at 23:23 +0200, Julia Lawall wrote: > On Fri, 11 Oct 2019, Jules Irenge wrote: > > Fix warning of lines should not end with open parenthesis. > > Issue detected by checkpatch tool. [] > > diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c > > b/drivers/st

Re: [PATCH] tracefs: Do not allocate and free proxy_ops for lockdown

2019-10-11 Thread Steven Rostedt
On Fri, 11 Oct 2019 23:46:20 +0200 Florian Weimer wrote: > * Steven Rostedt: > > > Once locked down is set, can it ever be undone without rebooting? > > I think this is the original intent with such patches, yes. But then > reality interferes and people add some escape hatch, so that it's >

Re: [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword

2019-10-11 Thread Miguel Ojeda
On Sat, Oct 12, 2019 at 12:08 AM Kees Cook wrote: > > On Fri, Oct 11, 2019 at 08:01:42PM +0200, Miguel Ojeda wrote: > > Hi Linus, > > > > On Fri, Oct 11, 2019 at 6:30 PM Linus Torvalds > > wrote: > > > > > > On Sat, Oct 5, 2019 at 9:46 AM Joe Perches wrote: > > > > > > > > Add 'fallthrough' pseu

Re: [PATCH 2/4] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use

2019-10-11 Thread Miguel Ojeda
On Thu, Oct 10, 2019 at 10:37 PM Kees Cook wrote: > > On Sat, Oct 05, 2019 at 07:17:36PM +0200, Miguel Ojeda wrote: > > Hi Joe, > > > > On Sat, Oct 5, 2019 at 6:46 PM Joe Perches wrote: > > > > > > Reserve the pseudo keyword 'fallthrough' for the ability to convert the > > > various case block /*

Re: [PATCH v1] drivers/base/memory.c: Don't access uninitialized memmaps in soft_offline_page_store()

2019-10-11 Thread Andrew Morton
On Thu, 10 Oct 2019 16:12:00 +0200 David Hildenbrand wrote: > Uninitialized memmaps contain garbage and in the worst case trigger kernel > BUGs, especially with CONFIG_PAGE_POISONING. They should not get > touched. > > Right now, when trying to soft-offline a PFN that resides on a memory > block

Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-11 Thread Aleksa Sarai
On 2019-10-11, Michael Kerrisk wrote: > Why CLONE3_CLEAR_SIGHAND rather than just CLONE_CLEAR_SIGHAND? There are no more flag bits left for the classic clone()/clone2() (the last one was used up by CLONE_PIDFD) -- thus this flag is clone3()-only. -- Aleksa Sarai Senior Software Engineer (Contai

Re: [PATCH] binder: prevent transactions to context manager from its own process.

2019-10-11 Thread Jann Horn
On Fri, Oct 11, 2019 at 11:59 PM Jann Horn wrote: > (I think you could also let A receive a handle > to itself and then transact with itself, but I haven't tested that.) Ignore this sentence, that's obviously wrong because same-binder_proc nodes will always show up as a binder, not a handle.

Re: [PATCH] binder: prevent transactions to context manager from its own process.

2019-10-11 Thread Jann Horn
On Mon, Jul 15, 2019 at 9:18 PM Hridya Valsaraju wrote: > Currently, a transaction to context manager from its own process > is prevented by checking if its binder_proc struct is the same as > that of the sender. However, this would not catch cases where the > process opens the binder device again

Re: [PATCH v2 1/1] mm/vmalloc: remove preempt_disable/enable when do preloading

2019-10-11 Thread Daniel Wagner
On 10/11/19 8:15 PM, Sebastian Andrzej Siewior wrote: On 2019-10-11 00:33:18 [+0200], Uladzislau Rezki (Sony) wrote: Get rid of preempt_disable() and preempt_enable() when the preload is done for splitting purpose. The reason is that calling spin_lock() with disabled preemtion is forbidden in

Re: [PATCH linux-kselftest/test v2] lib/list-test: add a test for the 'list' doubly linked list

2019-10-11 Thread Andrew Morton
On Fri, 11 Oct 2019 14:37:25 -0700 David Gow wrote: > On Fri, Oct 11, 2019 at 2:05 PM Andrew Morton > wrote: > > > > > > > > Given that everything runs at late_initcall time, shouldn't everything > > be __init, __initdata etc so all the code and data doesn't hang around > > for ever? > > > >

Re: [PATCH] Input: synaptics-rmi4 - Avoid processing unknown IRQs

2019-10-11 Thread Andrew Duggan
Hi Evan, On 10/8/19 3:36 PM, Evan Green wrote: > rmi_process_interrupt_requests() calls handle_nested_irq() for > each interrupt status bit it finds. If the irq domain mapping for > this bit had not yet been set up, then it ends up calling > handle_nested_irq(0), which causes a NULL pointer derefe

Re: [PATCH] tracefs: Do not allocate and free proxy_ops for lockdown

2019-10-11 Thread Florian Weimer
* Steven Rostedt: > Once locked down is set, can it ever be undone without rebooting? I think this is the original intent with such patches, yes. But then reality interferes and people add some escape hatch, so that it's possible again to load arbitrary kernel modules. And for servers, you can'

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-10-11 Thread Vijay Khemka
On 10/10/19, 8:11 PM, "Benjamin Herrenschmidt" wrote: On Thu, 2019-10-10 at 19:15 +, Vijay Khemka wrote: > Any news on this ? AST2400 has no HW checksum logic in HW, AST2500 > should work for IPV4 fine, we should only selectively disable it for > IPV6. >

Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warning of Logical continuations should be on the previous line

2019-10-11 Thread Julia Lawall
On Fri, 11 Oct 2019, Jules Irenge wrote: > Fix warning of logical continuations should be on the previous line. > Issue detected by checkpatch tool. There seem to be several changes mixed together in this patch. Don't have a subject line that is identical to a line in the log message. The sub

Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND

2019-10-11 Thread Michael Kerrisk
Hello Christian, Why CLONE3_CLEAR_SIGHAND rather than just CLONE_CLEAR_SIGHAND? Thanks, Michael

Re: [PATCH linux-kselftest/test v2] lib/list-test: add a test for the 'list' doubly linked list

2019-10-11 Thread David Gow
On Fri, Oct 11, 2019 at 2:05 PM Andrew Morton wrote: > > > > Given that everything runs at late_initcall time, shouldn't everything > be __init, __initdata etc so all the code and data doesn't hang around > for ever? > That's an interesting point. We haven't done this for KUnit tests to date, an

Re: [GIT PULL] Please pull NFS Client bugfixes for 5.4-rc3

2019-10-11 Thread pr-tracker-bot
The pull request you sent on Fri, 11 Oct 2019 21:14:20 +: > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-5.4-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH 1/3] HID: logitech-hidpp: use devres to manage FF private data

2019-10-11 Thread Dmitry Torokhov
On Fri, Oct 11, 2019 at 01:35:09PM -0700, Dmitry Torokhov wrote: > On Fri, Oct 11, 2019 at 01:33:03PM -0700, Dmitry Torokhov wrote: > > On Fri, Oct 11, 2019 at 09:25:52PM +0200, Benjamin Tissoires wrote: > > > On Fri, Oct 11, 2019 at 8:26 PM Dmitry Torokhov > > > wrote: > > > > > > > > On Fri, Oct

Re: [PATCH] mm: annotate refault stalls from swap_readpage

2019-10-11 Thread Andrew Morton
On Thu, 10 Oct 2019 15:17:47 -0400 Johannes Weiner wrote: > On Thu, Oct 10, 2019 at 08:21:34AM -0700, Minchan Kim wrote: > > From: Minchan Kim > > > > If block device supports rw_page operation, it doesn't submit bio > > so annotation in submit_bio for refault stall doesn't work. > > It happens

memory offline infinite loop after soft offline

2019-10-11 Thread Qian Cai
# /opt/ltp/runtest/bin/move_pages12 move_pages12.c:263: INFO: Free RAM 258988928 kB move_pages12.c:281: INFO: Increasing 2048kB hugepages pool on node 0 to 4 move_pages12.c:291: INFO: Increasing 2048kB hugepages pool on node 8 to 4 move_pages12.c:207: INFO: Allocating and freeing 4 hugepages on nod

[PATCH] staging: vc04_services: fix warning of Logical continuations should be on the previous line

2019-10-11 Thread Jules Irenge
Fix warning of logical continuations should be on the previous line. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- .../bcm2835-camera/bcm2835-camera.c | 41 --- 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/drivers/staging/vc04_ser

Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warnings of lines should not end with open parenthesis

2019-10-11 Thread Julia Lawall
On Fri, 11 Oct 2019, Jules Irenge wrote: > Fix warning of lines should not end with open parenthesis. > Issue detected by checkpatch tool. > > Signed-off-by: Jules Irenge > --- > .../bcm2835-camera/bcm2835-camera.c | 38 --- > 1 file changed, 16 insertions(+), 22 del

man-pages-5.03 is released

2019-10-11 Thread Michael Kerrisk (man-pages)
Gidday, The Linux man-pages maintainer proudly announces: man-pages-5.03 - man pages for Linux This release resulted from patches, bug reports, reviews, and comments from 45 people, with over 200 commits making changes to around 80 pages. Tarball download: http://www.kernel.org/doc/man-

[PATCH] staging: vc04_services: fix warnings of lines should not end with open parenthesis

2019-10-11 Thread Jules Irenge
Fix warning of lines should not end with open parenthesis. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- .../bcm2835-camera/bcm2835-camera.c | 38 --- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2

[GIT PULL] Please pull NFS Client bugfixes for 5.4-rc3

2019-10-11 Thread Schumaker, Anna
Hi Linus, The following changes since commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c: Linux 5.4-rc1 (2019-09-30 10:35:40 -0700) are available in the Git repository at: git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-5.4-2 for you to fetch changes up to af84537dbd1b39505d1

Re: [PATCH] tracefs: Do not allocate and free proxy_ops for lockdown

2019-10-11 Thread Steven Rostedt
On Fri, 11 Oct 2019 14:00:50 -0700 Linus Torvalds wrote: > On Fri, Oct 11, 2019 at 1:55 PM Steven Rostedt wrote: > > > > I guess I can keep it this way. Thoughts? > > That looks fine to me. I'm still not sure you actually need to do all > this, but it doesn't look _wrong_. Yep, I sent this b

Re: [PATCH 1/3] HID: logitech-hidpp: use devres to manage FF private data

2019-10-11 Thread Dmitry Torokhov
On Fri, Oct 11, 2019 at 02:02:30PM -0700, Andrey Smirnov wrote: > On Fri, Oct 11, 2019 at 1:33 PM Dmitry Torokhov > wrote: > > > > On Fri, Oct 11, 2019 at 09:25:52PM +0200, Benjamin Tissoires wrote: > > > On Fri, Oct 11, 2019 at 8:26 PM Dmitry Torokhov > > > wrote: > > > > > > > > On Fri, Oct 11,

Re: [PATCH] tracefs: Do not allocate and free proxy_ops for lockdown

2019-10-11 Thread Steven Rostedt
On Fri, 11 Oct 2019 13:46:11 -0700 Linus Torvalds wrote: > On Fri, Oct 11, 2019 at 1:25 PM Steven Rostedt wrote: > > > > OK, so I tried this approach, and there's a bit more than just a "few" > > extra cases that use tracing_open_generic(). > > Yeah, that's more than I would have expected. >

Re: [PATCH] KVM: fix overflow of zero page refcount with ksm running

2019-10-11 Thread kbuild test robot
Hi Zhuang, Thank you for the patch! Yet something to improve: [auto build test ERROR on kvm/linux-next] [cannot apply to v5.4-rc2 next-20191011] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

Re: [PATCH linux-kselftest/test v2] lib/list-test: add a test for the 'list' doubly linked list

2019-10-11 Thread Andrew Morton
On Thu, 10 Oct 2019 11:56:31 -0700 David Gow wrote: > Add a KUnit test for the kernel doubly linked list implementation in > include/linux/list.h > > Each test case (list_test_x) is focused on testing the behaviour of the > list function/macro 'x'. None of the tests pass invalid lists to these >

Re: [PATCH linux-kselftest/test v2] lib/list-test: add a test for the 'list' doubly linked list

2019-10-11 Thread Andrew Morton
On Thu, 10 Oct 2019 11:56:31 -0700 David Gow wrote: > Add a KUnit test for the kernel doubly linked list implementation in > include/linux/list.h > > Each test case (list_test_x) is focused on testing the behaviour of the > list function/macro 'x'. None of the tests pass invalid lists to these >

Re: [PATCH 0/3] net: phy: switch to using fwnode_gpiod_get_index

2019-10-11 Thread David Miller
From: Dmitry Torokhov Date: Fri, 11 Oct 2019 13:42:42 -0700 > I see that the patches are marked as "Not applicable" in the netdev > patchwork. Does this mean that you decided against pulling this > immutable branch, or you dropped them because of kbuild complaints (that > happened because it coul

Re: [Patch v7 0/4] Create and consolidate trusted keys subsystem

2019-10-11 Thread Jerry Snitselaar
On Fri Oct 11 19, Jarkko Sakkinen wrote: On Mon, Oct 07, 2019 at 10:55:31AM +0530, Sumit Garg wrote: This patch-set does restructuring of trusted keys code to create and consolidate trusted keys subsystem. Also, patch #2 replaces tpm1_buf code used in security/keys/trusted.c and crypto/asymmert

Re: [PATCH 1/3] HID: logitech-hidpp: use devres to manage FF private data

2019-10-11 Thread Andrey Smirnov
On Fri, Oct 11, 2019 at 1:33 PM Dmitry Torokhov wrote: > > On Fri, Oct 11, 2019 at 09:25:52PM +0200, Benjamin Tissoires wrote: > > On Fri, Oct 11, 2019 at 8:26 PM Dmitry Torokhov > > wrote: > > > > > > On Fri, Oct 11, 2019 at 04:52:04PM +0200, Benjamin Tissoires wrote: > > > > Hi Andrey, > > > >

Re: [PATCH] tracefs: Do not allocate and free proxy_ops for lockdown

2019-10-11 Thread Linus Torvalds
On Fri, Oct 11, 2019 at 1:55 PM Steven Rostedt wrote: > > I guess I can keep it this way. Thoughts? That looks fine to me. I'm still not sure you actually need to do all this, but it doesn't look _wrong_. That said, I still do think that if things are locked down from the very get-go, tracefs_cr

Re: [PATCH] KVM: fix overflow of zero page refcount with ksm running

2019-10-11 Thread kbuild test robot
Hi Zhuang, Thank you for the patch! Yet something to improve: [auto build test ERROR on kvm/linux-next] [cannot apply to v5.4-rc2 next-20191011] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

Re: [PATCH] tracefs: Do not allocate and free proxy_ops for lockdown

2019-10-11 Thread Steven Rostedt
On Fri, 11 Oct 2019 16:25:18 -0400 Steven Rostedt wrote: > > Here's the diffstat: > > fs/tracefs/inode.c | 42 > kernel/trace/ftrace.c | 29 +- > kernel/trace/trace.c| 73 > ++-

Re: [PATCH 1/3] HID: logitech-hidpp: use devres to manage FF private data

2019-10-11 Thread Andrey Smirnov
On Fri, Oct 11, 2019 at 12:26 PM Benjamin Tissoires wrote: > > On Fri, Oct 11, 2019 at 8:26 PM Dmitry Torokhov > wrote: > > > > On Fri, Oct 11, 2019 at 04:52:04PM +0200, Benjamin Tissoires wrote: > > > Hi Andrey, > > > > > > On Mon, Oct 7, 2019 at 7:13 AM Andrey Smirnov > > > wrote: > > > > > >

[PATCH v2 0/3] PCI: pciehp: Do not turn off slot if presence comes up after link

2019-10-11 Thread Stuart Hayes
In older PCIe specs, PDS (presence detect) would come up when the "in-band" presence detect pin connected, and would be up before DLLLA (link active). In PCIe 4.0 (as an ECN) and in PCIe 5.0, there is a new bit to show if in-band presence detection can be disabled for the slot, and another bit tha

[PATCH v2 2/3] PCI: pciehp: Wait for PDS if in-band presence is disabled

2019-10-11 Thread Stuart Hayes
From: Alexandru Gagniuc When inband presence is disabled, PDS may come up at any time, or not at all. PDS being low may indicate that the card is still mating, and we could expect contact bounce to bring down the link as well. It is reasonable to assume that most cards will mate in a hotplug slo

[PATCH v2 3/3] PCI: pciehp: Add dmi table for in-band presence disabled

2019-10-11 Thread Stuart Hayes
Some systems have in-band presence detection disabled for hot-plug PCI slots, but do not report this in the slot capabilities 2 (SLTCAP2) register. On these systems, presence detect can become active well after the link is reported to be active, which can cause the slots to be disabled after a devi

[PATCH v2 1/3] PCI: pciehp: Add support for disabling in-band presence

2019-10-11 Thread Stuart Hayes
From: Alexandru Gagniuc The presence detect state (PDS) is normally a logical or of in-band and out-of-band presence. As of PCIe 4.0, there is the option to disable in-band presence so that the PDS bit always reflects the state of the out-of-band presence. The recommendation of the PCIe spec is

[PATCH] media: i2c: adv7842: make array cri static and const, makes object smaller

2019-10-11 Thread Christophe JAILLET
Don't populate the array 'cri' on the stack but instead make it static and const. Makes the object code smaller by 165 bytes. Turn the 2nd parameter of 'log_infoframe()' const accordingly. Before: textdata bss dec hex filename 98533 20024 256 118813 1d01d drivers/med

Re: [PATCH] tracefs: Do not allocate and free proxy_ops for lockdown

2019-10-11 Thread Linus Torvalds
On Fri, Oct 11, 2019 at 1:25 PM Steven Rostedt wrote: > > OK, so I tried this approach, and there's a bit more than just a "few" > extra cases that use tracing_open_generic(). Yeah, that's more than I would have expected. That said, you also did what I consider a somewhat over-done conversion.

Re: [PATCH 0/3] net: phy: switch to using fwnode_gpiod_get_index

2019-10-11 Thread Dmitry Torokhov
Hi David, On Fri, Oct 04, 2019 at 04:13:53PM -0700, Dmitry Torokhov wrote: > This series switches phy drivers form using fwnode_get_named_gpiod() and > gpiod_get_from_of_node() that are scheduled to be removed in favor > of fwnode_gpiod_get_index() that behaves more like standard > gpiod_get_index

Re: [PATCH v5 0/7] hugetlb_cgroup: Add hugetlb_cgroup reservation limits

2019-10-11 Thread Mina Almasry
On Fri, Oct 11, 2019 at 12:10 PM Mina Almasry wrote: > > On Mon, Sep 23, 2019 at 10:47 AM Mike Kravetz wrote: > > > > On 9/19/19 3:24 PM, Mina Almasry wrote: > > > Patch series implements hugetlb_cgroup reservation usage and limits, which > > > track hugetlb reservations rather than hugetlb memor

Re: [PATCH v12 12/16] leds: lp55xx: Add multicolor framework support to lp55xx

2019-10-11 Thread Jacek Anaszewski
Dan, On 10/11/19 3:06 PM, Dan Murphy wrote: > Add multicolor framework support for the lp55xx family. > > Signed-off-by: Dan Murphy > --- > drivers/leds/Kconfig | 1 + > drivers/leds/leds-lp55xx-common.c | 176 +++--- > drivers/leds/leds-lp55xx-com

Re: [PATCH 1/3] HID: logitech-hidpp: use devres to manage FF private data

2019-10-11 Thread Dmitry Torokhov
On Fri, Oct 11, 2019 at 01:33:03PM -0700, Dmitry Torokhov wrote: > On Fri, Oct 11, 2019 at 09:25:52PM +0200, Benjamin Tissoires wrote: > > On Fri, Oct 11, 2019 at 8:26 PM Dmitry Torokhov > > wrote: > > > > > > On Fri, Oct 11, 2019 at 04:52:04PM +0200, Benjamin Tissoires wrote: > > > > Hi Andrey, >

Re: [PATCH 1/3] HID: logitech-hidpp: use devres to manage FF private data

2019-10-11 Thread Dmitry Torokhov
On Fri, Oct 11, 2019 at 09:25:52PM +0200, Benjamin Tissoires wrote: > On Fri, Oct 11, 2019 at 8:26 PM Dmitry Torokhov > wrote: > > > > On Fri, Oct 11, 2019 at 04:52:04PM +0200, Benjamin Tissoires wrote: > > > Hi Andrey, > > > > > > On Mon, Oct 7, 2019 at 7:13 AM Andrey Smirnov > > > wrote: > > >

Re: [PATCH v5 1/9] Documentation: Introduce EPT based Subpage Protection

2019-10-11 Thread Jim Mattson
On Tue, Sep 17, 2019 at 1:52 AM Yang Weijiang wrote: > > Co-developed-by: yi.z.zh...@linux.intel.com > Signed-off-by: yi.z.zh...@linux.intel.com > Signed-off-by: Yang Weijiang > --- > Documentation/virtual/kvm/spp_kvm.txt | 178 ++ > 1 file changed, 178 insertions(+) > c

Re: [PATCH] tracefs: Do not allocate and free proxy_ops for lockdown

2019-10-11 Thread Steven Rostedt
On Fri, 11 Oct 2019 11:20:30 -0700 Linus Torvalds wrote: > So from a quick glance, just making tracing_open_generic() do the > lockdown testing will take care of most cases. Add a few other cases > to fill up the whole set, and your'e done. > > Willing to do that instead? OK, so I tried this a

Re: [PATCH v3 6/6] perf cs-etm: Synchronize instruction sample with the thread stack

2019-10-11 Thread Mathieu Poirier
On Sat, Oct 05, 2019 at 05:16:14PM +0800, Leo Yan wrote: > The synthesized flow use 'tidq->packet' for instruction samples; on the > other hand, 'tidp->prev_packet' is used to generate the thread stack and > the branch samples, this results in the instruction samples using one > packet ahead than t

Re: [PATCH v3 1/6] perf cs-etm: Fix unsigned variable comparison to zero

2019-10-11 Thread Mathieu Poirier
On Sat, Oct 05, 2019 at 05:16:09PM +0800, Leo Yan wrote: > If the u64 variable 'offset' is a negative integer, comparison it with > bigger than zero is always going to be true because it is unsigned. > Fix this by using s64 type for variable 'offset'. > > Signed-off-by: Leo Yan > --- > tools/per

Re: [PATCH v12 08/16] dt: bindings: lp55xx: Update binding for Multicolor Framework

2019-10-11 Thread Jacek Anaszewski
Dan, On 10/11/19 3:06 PM, Dan Murphy wrote: > Update the DT binding to include the properties to use the > multicolor framework for the devices that use the LP55xx > framework. > > Signed-off-by: Dan Murphy > CC: Tony Lindgren > CC: "Benoît Cousson" > CC: Linus Walleij > CC: Shawn Guo > CC:

[PATCH 65/69] libperf: Introduce perf_evlist__exit()

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add the perf_evlist__exit() function, so far it's not exported and added only for internal use for perf and libperf. USe it to release cpus/threads and pollfd array. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Michael Petlan Cc: Namhyung Kim Cc: Peter Zijlstra Link:

[PATCH 64/69] libperf: Move the pollfd allocation from tools/perf to libperf

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa It's needed in libperf only, so move it to the perf_evlist__mmap_ops() function. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Michael Petlan Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lore.kernel.org/lkml/20191007125344.14268-24-jo...@kernel.org Signed-off-by: A

[PATCH 63/69] libperf: Centralize map refcnt setting

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Currently when a new map is mmapped we set its refcnt to 2 in the perf_evlist_mmap_ops::mmap callback. Every mmap gets its refcnt set to 2 when it's first mmaped: - 1 for the current user, which will be taken out by a call to perf_evlist__munmap_filtered(), where we find o

[PATCH 47/69] libperf: Adopt perf_mmap__unmap() function from tools/perf

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Move perf_mmap__unmap() from tools/perf to libperf, to internal header internal/mmap.h. It will be used in the following patches. And rename the existing perf's function to mmap__munmap(). Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Michael Petlan Cc: Namhyung Kim Cc:

[PATCH 62/69] perf evlist: Switch to libperf's mmap interface

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Switch to the libperf mmap interface by calling directly perf_evlist__mmap_ops() and removing perf's evlist__mmap_per_* functions. By switching to libperf perf_evlist__mmap() we need to operate over 'struct perf_mmap' in evlist__add_pollfd, so make the related changes there. Sig

[PATCH 68/69] perf tools: Propagate CFLAGS to libperf

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Andi reported that 'make DEBUG=1' does not propagate to the libbperf code. It's true also for the other flags. Changing the code to propagate the global build flags to libperf compilation. Reported-by: Andi Kleen Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Michael Petl

[PATCH 67/69] libperf: Adopt perf_evlist__filter_pollfd() from tools/perf

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Introduce the perf_evlist__filter_pollfd function and export it in the perf/evlist.h header, so that libperf users can check if the descriptor is still alive. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Michael Petlan Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://

[PATCH 66/69] libperf: Introduce perf_evlist__purge()

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add a static perf_evlist__purge() function to purge evsels from a evlist. Add also perf_evlist__for_each_entry_safe() which is used by perf_evlist__purge(). Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Michael Petlan Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://l

[PATCH 69/69] perf diff: Report noisy for cycles diff

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jin Yao This patch prints the stddev and hist for the cycles diff of program block. It can help us to understand if the cycles is noisy or not. This patch is inspired by Andi Kleen's patch: https://lwn.net/Articles/600471/ We create new option '--cycles-hist'. Example: perf record

[PATCH 59/69] perf tools: Introduce perf_evlist__mmap_cb_idx()

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add perf_evlist__mmap_cb_idx function to call auxtrace_mmap_params__set_idx() on each new index during perf_evlist__mmap_ops call. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Michael Petlan Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lore.kernel.org/lkml/2019100

[PATCH 60/69] perf evlist: Introduce perf_evlist__mmap_cb_get()

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add the perf_evlist__mmap_cb_get() function to return 'struct perf_mmap' object during perf_evlist__mmap_ops() call. The array of 'struct mmap' is allocated via evlist__alloc_mmap(), in this callback we simply returns pointer to the base object. Signed-off-by: Jiri Olsa Cc: Ale

[PATCH 61/69] perf evlist: Introduce perf_evlist__mmap_cb_mmap()

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add the perf_evlist__mmap_cb_mmap() function to call perf specific mmap__mmap() function during perf_evlist__mmap_ops() call. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Michael Petlan Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lore.kernel.org/lkml/201910071253

[PATCH 57/69] libperf: Add perf_evlist_mmap_ops::get callback

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add the perf_evlist_mmap_ops::get callback to be called in mmap_per_evsel() to get/allocate the 'struct perf_mmap' object. Add the libperf's perf_evlist__mmap_cb_get() function as libperf's get callback. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Michael Petlan Cc: N

[PATCH 58/69] libperf: Introduce perf_evlist_mmap_ops::mmap callback

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add the perf_evlist_mmap_ops::mmap callback to be called in mmap_per_evsel() to actually mmap the map. Add libperf's perf_evlist__mmap_cb_mmap() function as libperf's mmap callback. New mmaped map gets refcount set to 2 in mmap__mmap(), we follow that in mmap callback. We will m

[PATCH 56/69] libperf: Introduce perf_evlist_mmap_ops::idx callback

2019-10-11 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Add the perf_evlist_mmap_ops::idx callback to be called in mmap_per_cpu() and mmap_per_thread() with current cpu and thread indexes. It's used by current aux code, so perf will use this callback to set the aux index. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Michael

<    1   2   3   4   5   6   7   8   9   >