Re: [PATCH v3 2/3] nsproxy: attach to namespaces via pidfds

2020-05-04 Thread Christian Brauner
On Mon, May 04, 2020 at 12:09:46PM -0500, Eric W. Biederman wrote: > Christian Brauner writes: > > > On Mon, May 04, 2020 at 11:25:07AM -0500, Eric W. Biederman wrote: > >> > >> I am not thrilled about treating nstype as a flags fields when it is not > >> currently. It was my hope when I design

[PATCH v6 1/5] soc: qcom: rpmh-rsc: Correctly ignore CPU_CLUSTER_PM notifications

2020-05-04 Thread Douglas Anderson
Our switch statement doesn't have entries for CPU_CLUSTER_PM_ENTER, CPU_CLUSTER_PM_ENTER_FAILED, and CPU_CLUSTER_PM_EXIT and doesn't have a default. This means that we'll try to do a flush in those cases but we won't necessarily be the last CPU down. That's not so ideal since our (lack of) lockin

Re: [PATCH] staging: gasket: Check the return value of gasket_get_bar_index()

2020-05-04 Thread Richard Yeh
On Fri, May 01, 2020 at 05:51:18PM +0200, Oscar Carter wrote: > Check the return value of gasket_get_bar_index function as it can return > a negative one (-EINVAL). If this happens, a negative index is used in > the "gasket_dev->bar_data" array. > > Addresses-Coverity-ID: 1438542 ("Negative array

[GIT PULL] flexible-array member convertion patches for 5.7-rc5

2020-05-04 Thread Gustavo A. R. Silva
The following changes since commit 0e698dfa282211e414076f9dc7e83c1c288314fd: Linux 5.7-rc4 (2020-05-03 14:56:04 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git tags/flexible-array-member-5.7-rc5 for you to fetch changes up t

Re: [PATCH RESEND net-next] net: dsa: felix: allow the device to be disabled

2020-05-04 Thread Florian Fainelli
On 5/4/2020 9:52 AM, Michael Walle wrote: > If there is no specific configuration of the felix switch in the device > tree, but only the default configuration (ie. given by the SoCs dtsi > file), the probe fails because no CPU port has been set. On the other > hand you cannot set a default CPU p

Re: [PATCH 09/24] rcu/tree: cache specified number of objects

2020-05-04 Thread Uladzislau Rezki
On Mon, May 04, 2020 at 08:24:37AM -0700, Paul E. McKenney wrote: > On Mon, May 04, 2020 at 02:43:23PM +0200, Uladzislau Rezki wrote: > > On Fri, May 01, 2020 at 02:27:49PM -0700, Paul E. McKenney wrote: > > > On Tue, Apr 28, 2020 at 10:58:48PM +0200, Uladzislau Rezki (Sony) wrote: > > > > Cache so

Re: [PATCH RESEND net-next] net: dsa: felix: allow the device to be disabled

2020-05-04 Thread Vladimir Oltean
On Mon, 4 May 2020 at 19:55, Michael Walle wrote: > > If there is no specific configuration of the felix switch in the device > tree, but only the default configuration (ie. given by the SoCs dtsi > file), the probe fails because no CPU port has been set. On the other > hand you cannot set a defau

[GIT PULL] gcc-plugins fixes for v5.7-rc5

2020-05-04 Thread Kees Cook
Hi Linus, Please pull these gcc-plugins fixes for v5.7-rc5. These are some more clean-ups for using the plugins under GCC 10. Thanks! -Kees The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) are available in the Git reposit

Re: [PATCH] docs: dt: fix broken links due to txt->yaml renames

2020-05-04 Thread Sam Ravnborg
Hi Mauro. On Mon, May 04, 2020 at 11:30:20AM +0200, Mauro Carvalho Chehab wrote: > There are some new broken doc links due to yaml renames > at DT. Developers should really run: > > ./scripts/documentation-file-ref-check > > in order to solve those issues while submitting patches. Would lo

Re: [PATCH net-next 1/3] net: phy: add concept of shared storage for PHYs

2020-05-04 Thread Florian Fainelli
On 5/4/2020 9:38 AM, Michael Walle wrote: > There are packages which contain multiple PHY devices, eg. a quad PHY > transceiver. Provide functions to allocate and free shared storage. > > Usually, a quad PHY contains global registers, which don't belong to any > PHY. Provide convenience functio

Re: [PATCH v3 0/5] RCU dyntick nesting counter cleanups for rcu -dev

2020-05-04 Thread Paul E. McKenney
On Mon, May 04, 2020 at 10:15:32AM -0700, Paul E. McKenney wrote: > On Mon, May 04, 2020 at 08:05:00AM -0400, Joel Fernandes (Google) wrote: > > These patches clean up the usage of dynticks nesting counters simplifying > > the > > code, while preserving the usecases. > > > > It is a much needed s

Re: [PATCH] percpu: Sync vmalloc mappings in pcpu_alloc() and free_percpu()

2020-05-04 Thread Steven Rostedt
On Mon, 4 May 2020 17:12:36 +0200 Joerg Roedel wrote: > On Thu, Apr 30, 2020 at 10:39:19PM -0400, Steven Rostedt wrote: > > What's so damn special about alloc_percpu()? It's definitely not a fast > > path. And it's not used often. > > Okay, I fixed it in the percpu code. It is definitly not a

Re: [PATCHv2 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2020-05-04 Thread David Miller
From: Joyce Ooi Date: Mon, 4 May 2020 16:25:49 +0800 > The return from tx_buffer call in tse_start_xmit is > inapropriately ignored. tse_buffer calls should return > 0 for success or NETDEV_TX_BUSY. tse_start_xmit should > return not report a successful transmit when the tse_buffer > call retu

[rcu:rcu/next] BUILD SUCCESS 829960d8a31ef6f025276341b6bc13be4800be4a

2020-05-04 Thread kbuild test robot
randconfig-g001-20200503 i386 randconfig-h002-20200504 i386 randconfig-h001-20200504 i386 randconfig-h003-20200504 x86_64 randconfig-h002-20200504 x86_64 randconfig-h003-20200504 x86_64 randconfig-h001

Re: [PATCH v3 0/5] RCU dyntick nesting counter cleanups for rcu -dev

2020-05-04 Thread Joel Fernandes
On Mon, May 4, 2020 at 1:15 PM Paul E. McKenney wrote: > > On Mon, May 04, 2020 at 08:05:00AM -0400, Joel Fernandes (Google) wrote: > > These patches clean up the usage of dynticks nesting counters simplifying > > the > > code, while preserving the usecases. > > > > It is a much needed simplifica

Re: [PATCH v2] riscv: force __cpu_up_ variables to put in data section

2020-05-04 Thread Atish Patra
On Mon, May 4, 2020 at 12:50 AM Andreas Schwab wrote: > > On Mai 04 2020, Anup Patel wrote: > > > Slightly improved text: > > > > This issue happens on random booting of multiple harts, which means > > it will manifest for BBL and OpenSBI v0.6 (or older version). In OpenSBI > > v0.7 (or higher ver

Re: [PATCH RFC 2/2] tracing/block: add request operation and flags into trace events

2020-05-04 Thread Steven Rostedt
On Mon, 04 May 2020 18:16:21 +0300 Konstantin Khlebnikov wrote: > +/* Request operations, see enum req_opf */ > + > +TRACE_DEFINE_ENUM(REQ_OP_READ); > +TRACE_DEFINE_ENUM(REQ_OP_WRITE); > +TRACE_DEFINE_ENUM(REQ_OP_FLUSH); > +TRACE_DEFINE_ENUM(REQ_OP_DISCARD); > +TRACE_DEFINE_ENUM(REQ_OP_SECURE_ERA

Re: [PATCH v2 2/2] Documentation/vmcoreinfo: Add documentation for 'KERNELPACMASK'

2020-05-04 Thread Will Deacon
On Mon, Apr 27, 2020 at 11:55:02AM +0530, Amit Daniel Kachhap wrote: > Add documentation for KERNELPACMASK variable being added to the vmcoreinfo. > > It indicates the PAC bits mask information of signed kernel pointers if > Armv8.3-A Pointer Authentication feature is present. > > Cc: Catalin Mar

Re: [PATCH v11 01/12] add support for Clang's Shadow Call Stack (SCS)

2020-05-04 Thread Sami Tolvanen
On Mon, May 04, 2020 at 05:52:28PM +0100, Will Deacon wrote: > On Mon, Apr 27, 2020 at 01:45:46PM -0700, Sami Tolvanen wrote: > > I agree that allocating from a kmem_cache isn't ideal for safety. It's a > > compromise to reduce memory overhead. > > Do you think it would be a problem if we always a

Re: [PATCH v2] stmmac: fix pointer check after utilization in stmmac_interrupt

2020-05-04 Thread David Miller
From: Maxim Petrov Date: Mon, 4 May 2020 09:26:43 +0300 > The paranoidal pointer check in IRQ handler looks very strange - it > really protects us only against bogus drivers which request IRQ line > with null pointer dev_id. However, the code fragment is incorrect > because the dev pointer is use

[PATCH] igb: Report speed and duplex as unknown when device is runtime suspended

2020-05-04 Thread Kai-Heng Feng
igb device gets runtime suspended when there's no link partner. We can't get correct speed under that state: $ cat /sys/class/net/enp3s0/speed 1000 In addition to that, an error can also be spotted in dmesg: [ 385.991957] igb :03:00.0 enp3s0: PCIe link lost Since device can only be runtime s

Re: [PATCH 1/6] dt-bindings: phy: meson8b-usb2: Convert to json-schema

2020-05-04 Thread Joe Perches
On Mon, 2020-05-04 at 12:55 +0200, hex dump wrote: > On Sat, May 2, 2020 at 1:48 PM Martin Blumenstingl > wrote: > > Now that we have the DT validation in place, let's convert the device > > tree bindings for the Amlogic Meson8, Meson8b, Meson8m2 and GXBB USB2 > > PHY over to a YAML schema. > > >

Re: [PATCH] mtd: set mtd partition panic write flag

2020-05-04 Thread Miquel Raynal
Hi Kamal, Kamal Dasu wrote on Mon, 4 May 2020 11:20:16 -0400: > On Sat, May 2, 2020 at 2:08 PM Miquel Raynal > wrote: > > > > Hi Kamal, > > > > Miquel Raynal wrote on Thu, 9 Jan 2020 > > 18:28:07 +0100: > > > > > Hi Kamal, > > > > > > Kamal Dasu wrote on Thu, 9 Jan 2020 10:25:59 > > > -050

Re: [PATCH net] net: dsa: Do not make user port errors fatal

2020-05-04 Thread David Miller
From: Florian Fainelli Date: Sun, 3 May 2020 20:50:57 -0700 > Prior to 1d27732f411d ("net: dsa: setup and teardown ports"), we would > not treat failures to set-up an user port as fatal, but after this > commit we would, which is a regression for some systems where interfaces > may be declared i

[PATCH 11/11] x86/uv: Remove the unused _uv_cpu_blade_processor_id macro

2020-05-04 Thread Christoph Hellwig
No users anywhere in the kernel tree. Signed-off-by: Christoph Hellwig --- arch/x86/include/asm/uv/uv_hub.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/include/asm/uv/uv_hub.h b/arch/x86/include/asm/uv/uv_hub.h index 9eabd7e52fd15..60ca0afdeaf9f 100644 --- a/arch/x86/include/asm/

[PATCH 06/11] x86/uv: Mark is_uv_hubless static

2020-05-04 Thread Christoph Hellwig
is_uv_hubless is only used in x2apic_uv_x.c. Signed-off-by: Christoph Hellwig --- arch/x86/include/asm/uv/uv.h | 2 -- arch/x86/kernel/apic/x2apic_uv_x.c | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h index

[PATCH 07/11] x86/uv: Mark uv_min_hub_revision_id static

2020-05-04 Thread Christoph Hellwig
This variable is only used inside x2apic_uv_x and not even declared in a header. Signed-off-by: Christoph Hellwig --- arch/x86/kernel/apic/x2apic_uv_x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/kernel/apic/x2apic_uv_x.c b/arch/x86/kernel/apic/x2apic_uv_x.c

[PATCH 05/11] x86/uv: Remove the UV*_HUB_IS_SUPPORTED macros

2020-05-04 Thread Christoph Hellwig
All of the macros are always defined to one. Remove them and the dead code keyed off them. Signed-off-by: Christoph Hellwig --- arch/x86/include/asm/uv/uv_hub.h | 19 --- arch/x86/include/asm/uv/uv_mmrs.h | 7 --- 2 files changed, 26 deletions(-) diff --git a/arch/x86/inc

[PATCH 10/11] x86/uv: Unexport uv_apicid_hibits

2020-05-04 Thread Christoph Hellwig
This variable is not used by modular code. Signed-off-by: Christoph Hellwig --- arch/x86/kernel/apic/x2apic_uv_x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kernel/apic/x2apic_uv_x.c b/arch/x86/kernel/apic/x2apic_uv_x.c index 8cf0e24cf8835..10339ad02033a 100644 --- a/arch/x86/

[PATCH 09/11] x86/uv: Remove _uv_hub_info_check

2020-05-04 Thread Christoph Hellwig
Neither this functions not the helpers used to implement it are used anywhere in the kernel tree. Signed-off-by: Christoph Hellwig --- arch/x86/include/asm/uv/uv_hub.h | 14 -- arch/x86/kernel/apic/x2apic_uv_x.c | 6 -- 2 files changed, 20 deletions(-) diff --git a/arch/x86/i

Re: [PATCH] docs: dt: fix broken links due to txt->yaml renames

2020-05-04 Thread Joe Perches
On Mon, 2020-05-04 at 11:30 +0200, Mauro Carvalho Chehab wrote: > There are some new broken doc links due to yaml renames > at DT. Developers should really run: > > ./scripts/documentation-file-ref-check > > in order to solve those issues while submitting patches. > This tool can even fix m

[PATCH 08/11] x86/uv: Simplify uv_send_IPI_one

2020-05-04 Thread Christoph Hellwig
Merge two helpers only used by uv_send_IPI_one into the main function. Signed-off-by: Christoph Hellwig --- arch/x86/include/asm/uv/uv_hub.h | 20 arch/x86/kernel/apic/x2apic_uv_x.c | 19 ++- 2 files changed, 14 insertions(+), 25 deletions(-) diff --git a/

[PATCH 04/11] x86/uv: Unexport symbols only used by x2apic_uv_x.c

2020-05-04 Thread Christoph Hellwig
uv_bios_set_legacy_vga_target, uv_bios_freq_base, uv_bios_get_sn_info, uv_type, system_serial_number and sn_region_size are only used in x2apic_uv_x.c, which can't be modular. Signed-off-by: Christoph Hellwig --- arch/x86/platform/uv/bios_uv.c | 6 -- 1 file changed, 6 deletions(-) diff --g

[PATCH] scsi: esas2r: reduce the risk of a possible buffer-overflow vulnerability caused by DMA failures/attacks in esas2r_process_vda_ioctl()

2020-05-04 Thread Jia-Ju Bai
The function esas2r_read_vda() uses a DMA value "vi": struct atto_ioctl_vda *vi = (struct atto_ioctl_vda *)a->vda_buffer; Then esas2r_read_vda() calls esas2r_process_vda_ioctl() with vi: esas2r_process_vda_ioctl(a, vi, rq, &sgc); In esas2r_process_vda_ioctl(), the DMA

[PATCH 03/11] x86/uv: Unexport sn_coherency_id

2020-05-04 Thread Christoph Hellwig
sn_coherency_id is only used by x2apic_uv_x.c, and uv_sysfs.c, both of which can't be modular. Signed-off-by: Christoph Hellwig --- arch/x86/platform/uv/bios_uv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/platform/uv/bios_uv.c b/arch/x86/platform/uv/bios_uv.c index ca287554e234

Re: [PATCH v2] RDMA/rxe: check for error

2020-05-04 Thread Jason Gunthorpe
On Sun, Apr 26, 2020 at 12:35:45AM +0100, Sudip Mukherjee wrote: > The commit 'ff23dfa13457' modified rxe_create_mmap_info() to return > error code and also NULL but missed fixing codes which called > rxe_create_mmap_info(). Modify rxe_create_mmap_info() to only return > errorcode and fix error che

Re: [PATCH v4 0/7] KVM: VMX: Tscdeadline timer emulation fastpath

2020-05-04 Thread Paolo Bonzini
On 28/04/20 08:23, Wanpeng Li wrote: > IPI and Timer cause the main vmexits in cloud environment observation, > after single target IPI fastpath, let's optimize tscdeadline timer > latency by introducing tscdeadline timer emulation fastpath, it will > skip various KVM related checks when possibl

[PATCH 02/11] x86/uv: Remove the uv_partition_coherence_id macro

2020-05-04 Thread Christoph Hellwig
uv_partition_coherence_id is only used once. Just open code it in the only user. Signed-off-by: Christoph Hellwig --- arch/x86/include/asm/uv/bios.h | 1 - arch/x86/platform/uv/uv_sysfs.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/include/asm/uv/bios.h b/arc

Re: net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Markus Elfring
> Markus is not really providing any value to the community. The opinions can vary also around my contributions. > Just search for his recent mail history -- it's all silly commit message > nitpicking of little value. I dare to point questionable implementation (and/or wording) details out. >

Re: net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Markus Elfring
> Markus is not really providing any value to the community. The opinions can vary also around my contributions. > Just search for his recent mail history -- it's all silly commit message > nitpicking of little value. I dare to point questionable implementation (and/or wording) details out. >

[PATCH 01/11] x86/uv: Mark uv_bios_call and uv_bios_call_irqsave static

2020-05-04 Thread Christoph Hellwig
Both functions are only used inside of bios_uv.c. Signed-off-by: Christoph Hellwig --- arch/x86/include/asm/uv/bios.h | 6 -- arch/x86/platform/uv/bios_uv.c | 9 - 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/arch/x86/include/asm/uv/bios.h b/arch/x86/include/asm/uv

[RFC PATCH 60/61] fscache: Document the new netfs API

2020-05-04 Thread David Howells
Document the netfs parts of the rewritten caching API. Signed-off-by: David Howells --- Documentation/filesystems/caching/netfs-api.txt | 488 ++- 1 file changed, 372 insertions(+), 116 deletions(-) diff --git a/Documentation/filesystems/caching/netfs-api.txt b/Documentat

Re: [PATCH] dt-bindings: power: Convert bq27xxx dt to yaml

2020-05-04 Thread Dan Murphy
Andrew On 5/4/20 12:08 PM, Andrew F. Davis wrote: On 5/4/20 12:44 PM, Dan Murphy wrote: Adding Andrew in manually. On 5/4/20 11:41 AM, Dan Murphy wrote: Convert the bq27xxx.txt to yaml format CC: Pali Rohár CC: Andrew F. Davis" Signed-off-by: Dan Murphy ---   .../bindings/power/supply/bq

[RFC PATCH 61/61] fscache: Document the rewritten cache backend API

2020-05-04 Thread David Howells
Document the rewritten cache backend API. Signed-off-by: David Howells --- Documentation/filesystems/caching/backend-api.txt | 172 ++--- 1 file changed, 148 insertions(+), 24 deletions(-) diff --git a/Documentation/filesystems/caching/backend-api.txt b/Documentation/filesyst

[PATCH v3] xhci: Prevent runtime suspend on Etron EJ168

2020-05-04 Thread Kai-Heng Feng
Etron EJ168 USB 3.0 Host Controller stops working after S3, if it was runtime suspended previously: [ 370.080359] pci :02:00.0: can't change power state from D3cold to D0 (config space inaccessible) [ 370.080477] xhci_hcd :04:00.0: can't change power state from D3cold to D0 (config spac

[RFC PATCH 59/61] fscache: Remove the obsolete API bits from the documentation

2020-05-04 Thread David Howells
Remove the obsolete API bits from the documentation preparatory to writing up the new API. Signed-off-by: David Howells --- Documentation/filesystems/caching/backend-api.txt | 424 Documentation/filesystems/caching/netfs-api.txt | 554 + Documentation/fi

x86/uv cleanups

2020-05-04 Thread Christoph Hellwig
Hi x86 maintainers, this series removes various exports and sniplets of dead code from the x86/uv code. Diffstat: 8 files changed, 21 insertions(+), 111 deletions(-)

Re: [PATCH v2 1/2] arm64/crash_core: Export KERNELPACMASK in vmcoreinfo

2020-05-04 Thread Will Deacon
On Mon, Apr 27, 2020 at 11:55:01AM +0530, Amit Daniel Kachhap wrote: > Recently arm64 linux kernel added support for Armv8.3-A Pointer > Authentication feature. If this feature is enabled in the kernel and the > hardware supports address authentication then the return addresses are > signed and sto

Re: [PATCH v3 0/5] RCU dyntick nesting counter cleanups for rcu -dev

2020-05-04 Thread Paul E. McKenney
On Mon, May 04, 2020 at 08:05:00AM -0400, Joel Fernandes (Google) wrote: > These patches clean up the usage of dynticks nesting counters simplifying the > code, while preserving the usecases. > > It is a much needed simplification, makes the code less confusing, and > prevents > future bugs such

[RFC PATCH 56/61] afs: Copy local writes to the cache when writing to the server

2020-05-04 Thread David Howells
When writing to the server from afs_writepage() or afs_writepages(), copy the data to the cache object too. Signed-off-by: David Howells --- fs/afs/write.c | 124 ++-- 1 file changed, 119 insertions(+), 5 deletions(-) diff --git a/fs/afs/wri

[RFC PATCH 58/61] fscache: Rewrite the main document

2020-05-04 Thread David Howells
Rewrite the main document to reflect the new API. Signed-off-by: David Howells --- Documentation/filesystems/caching/fscache.txt | 51 - 1 file changed, 17 insertions(+), 34 deletions(-) diff --git a/Documentation/filesystems/caching/fscache.txt b/Documentation/files

[RFC PATCH 55/61] afs: Use new fscache I/O API

2020-05-04 Thread David Howells
Make AFS use the new fscache I/O API to read and write from the cache. afs_readpage() now calls fscache_read_helper() once to try and create a block around the page to be read. afs_readpages() now calls fscache_read_helper() multiple times until its list is exhausted or an error occurs. afs_pref

[RFC PATCH 57/61] afs: Invoke fscache_resize_cookie() when handling ATTR_SIZE for setattr

2020-05-04 Thread David Howells
Invoke fscache_resize_cookie() to adjust the size of the backing cache object when setattr is called with ATTR_SIZE. This discards any data that then lies beyond the revised EOF and frees up space. Signed-off-by: David Howells --- fs/afs/inode.c | 10 -- 1 file changed, 8 insertions(

[RFC PATCH 54/61] afs: Wait on PG_fscache before modifying/releasing a page

2020-05-04 Thread David Howells
PG_fscache is going to be used to indicate that a page is being written to the cache, and that the page should not be modified or released until it's finished. Make afs_invalidatepage() and afs_releasepage() wait for it. Signed-off-by: David Howells --- fs/afs/file.c | 13 + fs/

[PATCH] staging: vt6656: Use const for read only data

2020-05-04 Thread Oscar Carter
Use const for the arrays that are used as "read only". Also, modify the prototype of vnt_control_out_blocks() function to use a pointer to a const type. The vnt_vt3184_al2230 array can't be converted to const as it's modified later. Then in the vnt_vt3184_init() function use two types of pointers

[RFC PATCH 49/61] afs: Don't truncate iter during data fetch

2020-05-04 Thread David Howells
Don't truncate the iterator to correspond to the actual data size when fetching the data from the server - rather, pass the length we want to read to rxrpc. This will allow the clear-after-read code in future to simply clear the remaining iterator capacity rather than having to reinitialise the it

[RFC PATCH 50/61] afs: Set up the iov_iter before calling afs_extract_data()

2020-05-04 Thread David Howells
afs_extract_data sets up a temporary iov_iter and passes it to AF_RXRPC each time it is called to describe the remaining buffer to be filled. Instead: (1) Put an iterator in the afs_call struct. (2) Set the iterator for each marshalling stage to load data into the appropriate places. A n

Re: [PATCH v1 1/3] printk: honor the max_reason field in kmsg_dumper

2020-05-04 Thread Steven Rostedt
On Sat, 2 May 2020 10:35:53 -0400 Pavel Tatashin wrote: > kmsg_dump() allows to dump kmesg buffer for various system events: oops, > panic, reboot, etc. It provides an interface to register a callback call > for clients, and in that callback interface there is a field "max_reason" > which gets i

[RFC PATCH 52/61] afs: Interpose struct fscache_io_request into struct afs_read

2020-05-04 Thread David Howells
Embed an fscache_io_request struct into struct afs_read and remove some of the redundant members from the latter. Change all references to those removed members to use the fscache ones instead. Signed-off-by: David Howells --- fs/afs/dir.c | 38 -- f

[RFC PATCH 53/61] afs: Note the amount transferred in fetch-data delivery

2020-05-04 Thread David Howells
Note the amount of data transferred in the fscache request op structure in the delivery/decode routines for the various FetchData operations. Also, we need to exclude the excess from this value and then we need to use this in directory read rather than actual_len. Signed-off-by: David Howells --

[RFC PATCH 51/61] afs: Use ITER_MAPPING for writing

2020-05-04 Thread David Howells
Use a single ITER_MAPPING iterator to describe the portion of a file to be transmitted to the server rather than generating a series of small ITER_BVEC iterators on the fly. This will make it easier to implement AIO in afs. In theory we could maybe use one giant ITER_BVEC, but that means potentia

[RFC PATCH 47/61] afs: Remove afs_zero_fid as it's not used

2020-05-04 Thread David Howells
Remove afs_zero_fid as it's not used. Signed-off-by: David Howells --- fs/afs/yfsclient.c |2 -- 1 file changed, 2 deletions(-) diff --git a/fs/afs/yfsclient.c b/fs/afs/yfsclient.c index b5b45c57e1b1..7f419f8bb943 100644 --- a/fs/afs/yfsclient.c +++ b/fs/afs/yfsclient.c @@ -15,8 +15,6 @@

[RFC PATCH 48/61] afs: Move key to afs_read struct

2020-05-04 Thread David Howells
Stash the key used to authenticate read operations in the afs_read struct. This will be necessary to reissue the operation against the server if a read from the cache fails in upcoming cache changes. Signed-off-by: David Howells --- fs/afs/dir.c |3 ++- fs/afs/file.c | 16 +++

Re: [PATCH] firmware: arm_sdei: remove unused interfaces

2020-05-04 Thread James Morse
Hi Christoph, (CC: +Xiongfeng) Thanks for the reminder - I was just searching for who was using this. On 04/05/2020 17:42, Christoph Hellwig wrote: > The export symbols to register/unregister and enable/disable events > aren't ever used outside of arm_sdei.c, so mark them static. Xiongfeng, you

Re: [PATCH] firmware: arm_sdei: Drop check for /firmware/ node and always register driver

2020-05-04 Thread James Morse
Hi Sudeep, (CC: +Will and +Catalin) On 22/04/2020 13:28, Sudeep Holla wrote: > As with most of the drivers, let us register this driver unconditionally > by dropping the checks for presence of firmware nodes(DT) or entries(ACPI). > > Further, as mentioned in the commit acafce48b07b ("firmware: a

[RFC PATCH 46/61] cachefiles: Shape write requests

2020-05-04 Thread David Howells
In cachefiles_shape_extent(), shape a write request to always write to the cache. The assumption is made that the caller has read the entire cache granule beforehand if necessary. Possibly this should be amended so that writes will only take place to granules that are marked present and granules

[RFC PATCH 43/61] fscache: Implement "will_modify" parameter on fscache_use_cookie()

2020-05-04 Thread David Howells
Implement the "will_modify" parameter passed to fscache_use_cookie(). Setting this to true will henceforth cause the affected object to be marked as dirty on disk, subject to conflict resolution in the event that power failure or a crash occurs or the filesystem operates in disconnected mode. The

[RFC PATCH 45/61] fscache: Remove the update operation

2020-05-04 Thread David Howells
Remove the cache-side of the object update operation as it doesn't serialise with other setattr, O_TRUNC and write operations. Signed-off-by: David Howells --- fs/cachefiles/interface.c | 59 - fs/fscache/internal.h |1 - fs/fscache/obj.

[RFC PATCH 44/61] fscache: Provide resize operation

2020-05-04 Thread David Howells
Provide a cache operation to resize an object. This is intended to be run synchronously rather than being deferred as it really needs to run inside the inode lock on the netfs inode from ->setattr() to correctly order with respect to other truncates and writes. Signed-off-by: David Howells ---

[RFC PATCH 42/61] fscache, cachefiles: Rewrite invalidation

2020-05-04 Thread David Howells
Rewrite the cache object invalidation code in fscache and cachefiles. The following changes are made to fscache: (1) Invalidation is now ignored or allowed to proceed depending on the 'stage' a non-index cookie is in with respect to the backing object. (2) If invalidation is proceeds, it

[RFC PATCH 39/61] fscache: Display cache-specific data in /proc/fs/fscache/objects

2020-05-04 Thread David Howells
Allow the cache to add information in /proc/fs/fscache/objects instead of displaying cookie key and aux data - which can be seen in the cookies file. Signed-off-by: David Howells --- fs/cachefiles/content-map.c | 41 + fs/cachefiles/interface.c |

[RFC PATCH 38/61] fscache: Add read helper

2020-05-04 Thread David Howells
Add a helper function, fscache_read_helper(), to do the work of shaping read requests, attempting to read from the cache, issuing or reissuing requests to the filesystem to pass to the server and writing back to the filesystem. The filesystem passes in a prepared request descriptor with the fscach

[RFC PATCH 41/61] fscache: New stats

2020-05-04 Thread David Howells
Create some new stat counters appropriate to the new routines and display them in /proc/fs/fscache/stats. Signed-off-by: David Howells --- fs/fscache/dispatcher.c |6 + fs/fscache/internal.h| 25 + fs/fscache/io.c |2 ++ fs/fscache/read_helper.c |

[RFC PATCH 40/61] fscache: Remove more obsolete stats

2020-05-04 Thread David Howells
Remove some more stats that have become obsolete. Signed-off-by: David Howells --- fs/fscache/internal.h | 18 ++ fs/fscache/obj.c |6 +++--- fs/fscache/stats.c| 50 + 3 files changed, 14 insertions(+), 60 deletion

[RFC PATCH 37/61] cachefiles: Add I/O tracepoints

2020-05-04 Thread David Howells
--- fs/cachefiles/interface.c | 16 +++-- fs/cachefiles/io.c|2 + include/trace/events/cachefiles.h | 123 + 3 files changed, 136 insertions(+), 5 deletions(-) diff --git a/fs/cachefiles/interface.c b/fs/cachefiles/interface.c

[RFC PATCH 36/61] cachefiles: Implement read and write parts of new I/O API

2020-05-04 Thread David Howells
Implement writing into the cache and reading back from the cache inside cachefiles using asynchronous direct I/O from the specified iterator. The size and position of the request should be aligned to the reported dio_block_size. Errors and completion are reported by callback. Signed-off-by: Davi

Re: [PATCH v3 2/3] nsproxy: attach to namespaces via pidfds

2020-05-04 Thread Eric W. Biederman
Christian Brauner writes: > On Mon, May 04, 2020 at 11:25:07AM -0500, Eric W. Biederman wrote: >> >> I am not thrilled about treating nstype as a flags fields when it is not >> currently. It was my hope when I designed the interface that not >> treating nstype as a flags field would save us fro

[RFC PATCH 33/61] cachefiles: Implement a content-present indicator and bitmap

2020-05-04 Thread David Howells
Implement a content indicator that indicates the presence or absence of content and a bitmap that indicates which blocks of granular content are present in a granular file. This is added to the xattr that stores the netfs coherency data, along with the file size and the file zero point (the point

[RFC PATCH 35/61] cachefiles: Round the cachefile size up to DIO block size

2020-05-04 Thread David Howells
Round the size of a cachefile up to DIO block size so that we can always read back the last partial page of a file using direct I/O. Signed-off-by: David Howells --- fs/cachefiles/interface.c | 13 + 1 file changed, 13 insertions(+) diff --git a/fs/cachefiles/interface.c b/fs/cac

[RFC PATCH 32/61] cachefiles: Merge object->backer into object->dentry

2020-05-04 Thread David Howells
Merge the object->backer pointer into the object->dentry pointer and assume that data objects are always going to be just regular files. object->dentry can then more easily be overridden later by invalidation without having two different things to update the xattrs on. object->old maintains a poi

[RFC PATCH 30/61] cachefiles: Split cachefiles_drop_object() up a bit

2020-05-04 Thread David Howells
Split cachefiles_drop_object() up a bit to make it easier to modify later. Signed-off-by: David Howells --- fs/cachefiles/interface.c | 58 ++--- 1 file changed, 39 insertions(+), 19 deletions(-) diff --git a/fs/cachefiles/interface.c b/fs/cachefiles/i

[RFC PATCH 34/61] cachefiles: Implement extent shaper

2020-05-04 Thread David Howells
Implement the function that shapes extents to map onto the granules in a cache file. When setting to fetch data from the server to be cached, the extent will be expanded to align with granule size and cut down so that it doesn't cross the boundary between a non-present extent and a present extent.

[RFC PATCH 31/61] cachefiles: Implement new fscache I/O backend API

2020-05-04 Thread David Howells
Implement the new fscache I/O backend API in cachefiles. The cachefiles_object struct carries a non-accounted file to the cachefiles object (so that it doesn't cause ENFILE). Signed-off-by: David Howells --- fs/cachefiles/Makefile|1 + fs/cachefiles/interface.c |3 ++ fs/cachefiles

[RFC PATCH 29/61] cachefiles: trace: Log coherency checks

2020-05-04 Thread David Howells
Add a cachefiles tracepoint that logs the result of coherency management when the coherency data on a file in the cache is checked or committed. Signed-off-by: David Howells --- fs/cachefiles/xattr.c | 45 ++ include/trace/events/cachefiles.h | 56 +++

[RFC PATCH 28/61] cachefiles: Remove some redundant checks on unsigned values

2020-05-04 Thread David Howells
Remove some redundant checks for unsigned values being >= 0. Signed-off-by: David Howells --- fs/cachefiles/bind.c |6 ++ fs/cachefiles/daemon.c |6 +++--- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/fs/cachefiles/bind.c b/fs/cachefiles/bind.c index 4c59e1ef4500

[RFC PATCH 26/61] fscache, cachefiles: Fix disabled histogram warnings

2020-05-04 Thread David Howells
Fix variable unused warnings due to disabled histogram stuff. Signed-off-by: David Howells --- fs/cachefiles/internal.h |7 +-- fs/fscache/internal.h|6 -- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h inde

[RFC PATCH 22/61] fscache: Replace the object management state machine

2020-05-04 Thread David Howells
Replace the object management state machine with something a lot simpler. The entire process of setting up or tearing down a cookie is done in one go, and the dispatcher either punts it to a worker thread, or if all the worker threads are all busy, does it in the current thread. fscache_enable_coo

[RFC PATCH 27/61] fscache: Recast assertion in terms of cookie not being an index

2020-05-04 Thread David Howells
Recast assertion in terms of cookie not being an index rather than being a datafile. Signed-off-by: David Howells --- fs/fscache/cookie.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fscache/cookie.c b/fs/fscache/cookie.c index 284017fe4a5d..f02ed34beb0c 100644 ---

[RFC PATCH 25/61] fscache: Keep track of size of a file last set independently on the server

2020-05-04 Thread David Howells
Keep track of the size of a file that we're caching as last set independently on the server by another client. As long as this does not change, we can make the assumption that anything over that boundary, if not represented in the local cache, will not be represented on the server either and can b

[RFC PATCH 23/61] fscache: Rewrite the I/O API based on iov_iter

2020-05-04 Thread David Howells
Rewrite the fscache I/O API by introducing a number of new routines based on a number of principles: (1) The cache provides *only* write-to-cache and read-from-cache calls for transferring data to/from the cache. (2) The bufferage for I/O to/from the cache is supplied with an iov_iter.

[RFC PATCH 24/61] fscache: Remove fscache_wait_on_invalidate()

2020-05-04 Thread David Howells
Remove fscache_wait_on_invalidate() as the invalidation wait is now built into the I/O path. Signed-off-by: David Howells --- fs/fscache/cookie.c | 14 -- include/linux/fscache.h | 17 - 2 files changed, 31 deletions(-) diff --git a/fs/fscache/cookie.c b/fs/

[RFC PATCH 18/61] fscache: Temporarily disable fscache_invalidate()

2020-05-04 Thread David Howells
Temporarily disable the fscache side of fscache_invalidate() so that the operation managing code can be removed. Signed-off-by: David Howells --- fs/cachefiles/interface.c |9 ++--- fs/fscache/cookie.c |4 +- fs/fscache/object.c | 78 +--

[RFC PATCH 20/61] cachefiles: Remove tree of active files and use S_CACHE_FILE inode flag

2020-05-04 Thread David Howells
Remove the tree of active dentries from the cachefiles_cache struct and instead set a flag, S_CACHE_FILE, on the backing inode to indicate that this file is in use by the kernel so as to ward off other kernel users. This simplifies the code a lot and also prevents two overlain caches from fighting

[RFC PATCH 21/61] fscache: Provide a simple thread pool for running ops asynchronously

2020-05-04 Thread David Howells
Provide a simple thread pool that can be used to run cookie management operations in the background and a dispatcher infrastructure to punt operations to the pool if threads are available or to just run the operation in the calling thread if not. A future patch will replace all the object state ma

[RFC PATCH 17/61] fscache: Remove old I/O tracepoints

2020-05-04 Thread David Howells
Remove now-unused fscache tracepoints that have been obsoleted by the removal of the old I/O code. Signed-off-by: David Howells --- fs/fscache/object.c|1 include/trace/events/fscache.h | 195 2 files changed, 196 deletions(-) diff --g

[RFC PATCH 19/61] fscache: Remove the I/O operation manager

2020-05-04 Thread David Howells
Remove the fscache I/O operation manager. Getting operation-operation interactions and object-operation interactions correct has proven really difficult; furthermore, the operations are being replaced with kiocb-driven stuff on the cache front. Signed-off-by: David Howells --- fs/cachefiles/na

[RFC PATCH 16/61] fscache: Remove obsolete stats

2020-05-04 Thread David Howells
Remove a bunch of now-unused fscache stats counters that were obsoleted by the removal of the old I/O routines. Signed-off-by: David Howells --- fs/fscache/internal.h | 61 --- fs/fscache/stats.c| 129 - 2 files changed,

System fails to exit s2idle by a keystroke on my laptop

2020-05-04 Thread Chris Chiu
Hi, I have an Intel X5-Z8350 laptop which used to work fine on s2idle enter/exit with kernel 5.3. After upgrading to kernel 5.4 and later, the system can still exit s2idle by power button. However, if I try to wake it up from a keystroke, the system will freeze and then no longer respond even t

[RFC PATCH 15/61] fscache: Remove fscache_attr_changed()

2020-05-04 Thread David Howells
Remove fscache_attr_changed() as it's unused. Signed-off-by: David Howells --- fs/cachefiles/interface.c | 13 ++--- fs/fscache/Makefile |3 - fs/fscache/page.c | 98 - include/linux/fscache-cache.h |4 -- include/lin

[RFC PATCH 14/61] fscache: Remove fscache_check_consistency()

2020-05-04 Thread David Howells
Remove fscache_check_consistency() as that allows the netfs to pry into the inner working of the cache - and what's in the cookie should be taken as consistent with the disk (possibly lazily). Signed-off-by: David Howells --- fs/cachefiles/interface.c | 26 - fs/fscache/cookie

<    4   5   6   7   8   9   10   11   12   13   >