[patch V4 part 2 04/18] x86/entry/common: Protect against instrumentation

2020-05-05 Thread Thomas Gleixner
Mark the various syscall entries with noinstr to protect them against instrumentation and add the noinstr_begin()/end() annotations to mark the parts of the functions which are safe to call out into instrumentable code. Signed-off-by: Thomas Gleixner --- arch/x86/entry/common.c | 135

[patch V4 part 2 03/18] x86/entry: Mark enter_from_user_mode() noinstr

2020-05-05 Thread Thomas Gleixner
Both the callers in the low level ASM code and __context_tracking_exit() which is invoked from enter_from_user_mode() via user_exit_irqoff() are marked NOKPROBE. Allowing enter_from_user_mode() to be probed is inconsistent at best. Aside of that while function tracing per se is safe the function

[patch V4 part 1 35/36] x86: Replace ist_enter() with nmi_enter()

2020-05-05 Thread Thomas Gleixner
From: Peter Zijlstra A few exceptions (like #DB and #BP) can happen at any location in the code, this then means that tracers should treat events from these exceptions as NMI-like. The interrupted context could be holding locks with interrupts disabled for instance. Similarly, #MC is an actual

[patch V4 part 2 08/18] lib/smp_processor_id: Move it into noinstr section

2020-05-05 Thread Thomas Gleixner
That code is already not traceable. Move it into the noinstr section so the objtool section validation does not trigger. Annotate the warning code as "safe". While it might be not under all circumstances, getting the information out is important enough. Should this ever trigger from the

[patch V4 part 2 00/18] x86/entry: Entry/exception code rework, syscall and KVM changes

2020-05-05 Thread Thomas Gleixner
Folks! This is the second part of the rework series. Part 1 can be found here: https://lore.kernel.org/r/20200505131602.633487...@linutronix.de The series has a total of 138 patches and is split into 5 parts. The base for this series is:

[patch V4 part 1 36/36] rcu: Make RCU IRQ enter/exit functions rely on in_nmi()

2020-05-05 Thread Thomas Gleixner
From: Paul E. McKenney The rcu_nmi_enter_common() and rcu_nmi_exit_common() functions take an "irq" parameter that indicates whether these functions are invoked from an irq handler (irq==true) or an NMI handler (irq==false). However, recent changes have applied notrace to a few critical

[patch V4 part 1 30/36] lockdep: Always inline lockdep_{off,on}()

2020-05-05 Thread Thomas Gleixner
From: Peter Zijlstra These functions are called {early,late} in nmi_{enter,exit} and should not be traced or probed. They are also puny, so 'inline' them. Reported-by: Steven Rostedt Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Thomas Gleixner --- include/linux/lockdep.h | 23

[patch V4 part 1 26/36] printk: Prepare for nested printk_nmi_enter()

2020-05-05 Thread Thomas Gleixner
From: Petr Mladek There is plenty of space in the printk_context variable. Reserve one byte there for the NMI context to be on the safe side. It should never overflow. The BUG_ON(in_nmi() == NMI_MASK) in nmi_enter() will trigger much earlier. Signed-off-by: Petr Mladek Signed-off-by: Peter

[patch V4 part 1 29/36] x86/mce: Send #MC singal from task work

2020-05-05 Thread Thomas Gleixner
From: Peter Zijlstra Convert #MC over to using task_work_add(); it will run the same code slightly later, on the return to user path of the same exception. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Thomas Gleixner Reviewed-by: Frederic Weisbecker ---

[patch V4 part 1 33/36] x86,tracing: Robustify ftrace_nmi_enter()

2020-05-05 Thread Thomas Gleixner
From: Peter Zijlstra ftrace_nmi_enter() trace_hwlat_callback() trace_clock_local() sched_clock() paravirt_sched_clock() native_sched_clock() All must not be traced or kprobed, it will be called from do_debug() before the kprobe handler.

[patch V4 part 1 34/36] sched,rcu,tracing: Avoid tracing before in_nmi() is correct

2020-05-05 Thread Thomas Gleixner
From: Peter Zijlstra If a tracer is invoked before in_nmi() becomes true, the tracer can no longer detect it is called from NMI context and behave correctly. Therefore change nmi_{enter,exit}() to use __preempt_count_{add,sub}() as the normal preempt_count_{add,sub}() have a (desired) function

[patch V4 part 1 23/36] bug: Annotate WARN/BUG/stackfail as noinstr safe

2020-05-05 Thread Thomas Gleixner
Warnings, bugs and stack protection fails from noinstr sections, e.g. low level and early entry code, are likely to be fatal. Mark them as "safe" to be invoked from noinstr protected code to avoid annotating all usage sites. Getting the information out is important. Signed-off-by: Thomas

[patch V4 part 1 32/36] sh/ftrace: Move arch_ftrace_nmi_{enter,exit} into nmi exception

2020-05-05 Thread Thomas Gleixner
From: Peter Zijlstra SuperH is the last remaining user of arch_ftrace_nmi_{enter,exit}(), remove it from the generic code and into the SuperH code. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Thomas Gleixner Cc: Rich Felker Cc: Yoshinori Sato ---

[patch V4 part 1 22/36] tracing: Provide lockdep less trace_hardirqs_on/off() variants

2020-05-05 Thread Thomas Gleixner
trace_hardirqs_on/off() is only partially safe vs. RCU idle. The tracer core itself is safe, but the resulting tracepoints can be utilized by e.g. BPF which is unsafe. Provide variants which do not contain the lockdep invocation so the lockdep and tracer invocations can be split at the call site

Re: [net-next PATCH v3 3/5] phylink: Introduce phylink_fwnode_phy_connect()

2020-05-05 Thread Andy Shevchenko
On Tue, May 5, 2020 at 4:29 PM Calvin Johnson wrote: > > Define phylink_fwnode_phy_connect() to connect phy specified by > a fwnode to a phylink instance. ... > + int ret = 0; Redundant assignment. > + if ((IS_ERR(phy_fwnode)) && pl->cfg_link_an_mode == MLO_AN_PHY) No Lisp,

[patch V4 part 1 13/36] x86/kvm: Restrict ASYNC_PF to user space

2020-05-05 Thread Thomas Gleixner
The async page fault injection into kernel space creates more problems than it solves. The host has absolutely no knowledge about the state of the guest if the fault happens in CPL0. The only restriction for the host is interrupt disabled state. If interrupts are enabled in the guest then the

[patch V4 part 1 18/36] samples/kprobes: Add __kprobes and NOKPROBE_SYMBOL() for handlers.

2020-05-05 Thread Thomas Gleixner
From: Masami Hiramatsu Add __kprobes and NOKPROBE_SYMBOL() for sample kprobe handlers. Signed-off-by: Masami Hiramatsu Signed-off-by: Thomas Gleixner Link: https://lkml.kernel.org/r/158523421177.24735.16273975317343670204.stgit@devnote2 --- samples/kprobes/kprobe_example.c|6 --

[patch V4 part 1 10/36] x86/entry: Remove the unused LOCKDEP_SYSEXIT cruft

2020-05-05 Thread Thomas Gleixner
No users left since two years due to commit 21d375b6b34f ("x86/entry/64: Remove the SYSCALL64 fast path") Signed-off-by: Thomas Gleixner --- arch/x86/entry/thunk_64.S |5 - arch/x86/include/asm/irqflags.h | 24 2 files changed, 29 deletions(-) ---

Re: [PATCH] omapfb: don't annotate dss_conv_list as __initdata

2020-05-05 Thread Marco Elver
On Tue, 5 May 2020 at 16:04, Arnd Bergmann wrote: > > With the kcsan changes, __read_once_size() is not inlined, but > clang can decide to emit a version that hardcodes the address, which > in turn triggers a warning for dss_conv_list being __initdata but > __read_once_size() not being __init: >

[PATCH] arm64: disable patchable function entry on big-endian clang builds

2020-05-05 Thread Arnd Bergmann
Clang only supports the patchable_function_entry attribute on little-endian arm64 builds, but not on big-endian: include/linux/kasan-checks.h:16:8: error: unknown attribute 'patchable_function_entry' ignored [-Werror,-Wunknown-attributes] Disable that configuration with another dependency.

[PATCH] ARM: use ARM unwinder for gcov

2020-05-05 Thread Arnd Bergmann
Using gcov on ARM fails when the frame pointer unwinder is used: arm-linux-gnueabi-ld: kernel/softirq.o:(.ARM.exidx+0x120): undefined reference to `__aeabi_unwind_cpp_pr0' arm-linux-gnueabi-ld: init/main.o:(.ARM.exidx+0x98): undefined reference to `__aeabi_unwind_cpp_pr0' arm-linux-gnueabi-ld:

Re: [PATCH] i2c: drivers: Remove superfluous error message

2020-05-05 Thread Wolfram Sang
On Mon, May 04, 2020 at 05:14:06PM +0530, Aishwarya Ramakrishnan wrote: > The function platform_get_irq can log an error by itself. > This omit a redundant message for exception handling in the > calling function. > > Suggested by Coccinelle. > > Signed-off-by: Aishwarya Ramakrishnan Sorry, I

Re: [PATCH] KVM: Fix a warning in __kvm_gfn_to_hva_cache_init()

2020-05-05 Thread Peter Xu
On Mon, May 04, 2020 at 06:39:29PM -0700, Sean Christopherson wrote: > On Mon, May 04, 2020 at 03:05:26PM -0400, Peter Xu wrote: > > GCC 10.0.1 gives me this warning when building KVM: > > > > warning: ‘nr_pages_avail’ may be used uninitialized in this function > > [-Wmaybe-uninitialized] > >

[PATCH] kcsan: fix section mismatch for __write_once_size/blacklisted_initcalls

2020-05-05 Thread Arnd Bergmann
Moving __write_once_size out of line causes a section mismatch warning with clang in one instance: WARNING: modpost: vmlinux.o(.text+0x8dc): Section mismatch in reference from the function __write_once_size() to the variable .init.data:blacklisted_initcalls The function __write_once_size()

[PATCH] clk: Unlink clock if failed to prepare or enable

2020-05-05 Thread Marc Zyngier
On failing to prepare or enable a clock, remove the core structure from the list it has been inserted as it is about to be freed. This otherwise leads to random crashes when subsequent clocks get registered, during which parsing of the clock tree becomes adventurous. Observed with QEMU's RPi-3

[PATCH] pinctrl: mediatek: add pinctrl-mtk-common-v2 module license

2020-05-05 Thread Arnd Bergmann
Kbuild warns when this file is built as a loadable module: WARNING: modpost: missing MODULE_LICENSE() in drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.o see include/linux/module.h for more information Add the missing license/author/description tags. Fixes: 8174a8512e3e ("pinctrl: mediatek:

Re: [PATCH] bitops: avoid clang shift-count-overflow warnings

2020-05-05 Thread Andy Shevchenko
On Tue, May 5, 2020 at 4:58 PM Arnd Bergmann wrote: > > Clang normally does not warn about certain issues in inline functions when > it only happens in an eliminated code path. However if something else > goes wrong, it does tend to complain about the definition of hweight_long() > on 32-bit

[PATCH] sysctl: fix unused function warning

2020-05-05 Thread Arnd Bergmann
The newly added bpf_stats_handler function has the wrong #ifdef check around it, leading to an unused-function warning when CONFIG_SYSCTL is disabled: kernel/sysctl.c:205:12: error: unused function 'bpf_stats_handler' [-Werror,-Wunused-function] static int bpf_stats_handler(struct ctl_table

[PATCH] firmware: arm_scmi: fix psci dependency

2020-05-05 Thread Arnd Bergmann
When CONFIG_ARM_PSCI_FW is disabled but CONFIG_HAVE_ARM_SMCCC is enabled, arm-scmi runs into a link failure: arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/smc.o: in function `smc_send_message': smc.c:(.text+0x200): undefined reference to `arm_smccc_1_1_get_conduit' Use an inline helper to

[PATCH] MAINTAINERS: Add missing header files to BLOCK LAYER section

2020-05-05 Thread Geert Uytterhoeven
The various header files are part of the Block Layer. Add them to the corresponding section in the MAINTAINERS file, so scripts/get_maintainer.pl will pick them up. Signed-off-by: Geert Uytterhoeven --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS

Re: [PATCH] drm/amdgpu: allocate large structures dynamically

2020-05-05 Thread Christian König
Am 05.05.20 um 16:01 schrieb Arnd Bergmann: After the structure was padded to 1024 bytes, it is no longer suitable for being a local variable, as the function surpasses the warning limit for 32-bit architectures: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:587:5: error: stack frame size of 1072

Re: [PATCH 4.19 28/37] dmaengine: dmatest: Fix iteration non-stop logic

2020-05-05 Thread Andy Shevchenko
On Tue, May 5, 2020 at 4:37 PM Pavel Machek wrote: > On Tue 2020-05-05 16:19:11, Andy Shevchenko wrote: > > On Tue, May 5, 2020 at 3:58 PM Pavel Machek wrote: > > > On Tue 2020-05-05 15:51:16, Andy Shevchenko wrote: > > > > On Tue, May 5, 2020 at 3:37 PM Pavel Machek wrote: > > > > > > So, to

Re: [PATCH v3 1/3] media: rkvdec: Fix .buf_prepare

2020-05-05 Thread Tomasz Figa
On Tue, May 5, 2020 at 3:59 PM Ezequiel Garcia wrote: > > On Tue, 2020-05-05 at 15:56 +0200, Tomasz Figa wrote: > > Hi Ezequiel, > > > > On Tue, May 5, 2020 at 3:41 PM Ezequiel Garcia > > wrote: > > > The driver should only set the payload on .buf_prepare > > > if the buffer is CAPTURE type, or

Re: [PATCH] iommu: Relax ACS requirement for RCiEP devices.

2020-05-05 Thread Alex Williamson
On Mon, 4 May 2020 23:11:07 -0700 "Raj, Ashok" wrote: > Hi Alex > > + Joerg, accidently missed in the Cc. > > On Mon, May 04, 2020 at 11:19:36PM -0600, Alex Williamson wrote: > > On Mon, 4 May 2020 21:42:16 -0700 > > Ashok Raj wrote: > > > > > PCIe Spec recommends we can relax ACS

Re: [PATCH] [net-next] dsa: sja1105: dynamically allocate stats structure

2020-05-05 Thread Andrew Lunn
> - rc = sja1105_port_status_get(priv, , port); > + rc = sja1105_port_status_get(priv, status, port); > if (rc < 0) { > dev_err(ds->dev, "Failed to read port %d counters: %d\n", > port, rc); > - return; > + goto out;; Hi

[PATCH v4 0/3] nsproxy: attach to multiple namespaces

2020-05-05 Thread Christian Brauner
This is v4. /* v4 */ There are no major changes. There's a fix for the nstype == 0 case Eric spotted when porting setns() to struct nsset in the first patch. I've also added a few lines to the second patch that we want the ability to attach to subsets of namespaces with pidfds. I also mentioned

[PATCH v4 1/3] nsproxy: add struct nsset

2020-05-05 Thread Christian Brauner
Add a simple struct nsset. It holds all necessary pieces to switch to a new set of namespaces without leaving a task in a half-switched state which we will make use of in the next patch. This patch switches the existing setns logic over without causing a change in setns() behavior. This brings

[PATCH v4 2/3] nsproxy: attach to namespaces via pidfds

2020-05-05 Thread Christian Brauner
For quite a while we have been thinking about using pidfds to attach to namespaces. This patchset has existed for about a year already but we've wanted to wait to see how the general api would be received and adopted. Now that more and more programs in userspace have started using pidfds for

[PATCH v4 3/3] selftests/pidfd: add pidfd setns tests

2020-05-05 Thread Christian Brauner
This is basically a test-suite for setns() and as of now contains: - test that we can't pass garbage flags - test that we can't attach to the namespaces of task that has already exited - test that we can incrementally setns into all namespaces of a target task using a pidfd - test that we can

[PATCH] omapfb: don't annotate dss_conv_list as __initdata

2020-05-05 Thread Arnd Bergmann
With the kcsan changes, __read_once_size() is not inlined, but clang can decide to emit a version that hardcodes the address, which in turn triggers a warning for dss_conv_list being __initdata but __read_once_size() not being __init: WARNING: modpost: vmlinux.o(.text+0x6e4d7a): Section mismatch

Re: [PATCH v2 1/1] fs/splice: add missing callback for inaccessible pages

2020-05-05 Thread Christian Borntraeger
On 05.05.20 16:01, Christian Borntraeger wrote: > > > On 05.05.20 15:55, Ulrich Weigand wrote: >> On Tue, May 05, 2020 at 05:34:45AM -0700, Dave Hansen wrote: >>> On 5/4/20 6:41 AM, Ulrich Weigand wrote: You're right that there is no mechanism to prevent new references, but that's

[PATCH 00/11] mediatek: add support for MediaTek Ethernet MAC

2020-05-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds support for the Ethernet Controller present on MediaTeK SoCs from the MT8* family. The first two patches add binding documents for the PERICFG syscon and for the MAC itself. Patches 3/11 & 4/11 do some cleanup of the mediatek ethernet drivers directory.

[PATCH 01/11] dt-bindings: add a binding document for MediaTek PERICFG controller

2020-05-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds a binding document for the PERICFG controller present on MediaTek SoCs. For now the only variant supported is 'mt8516-pericfg'. Signed-off-by: Bartosz Golaszewski --- .../arm/mediatek/mediatek,pericfg.yaml| 34 +++ 1 file changed, 34

[PATCH 07/11] ARM64: dts: mediatek: add pericfg syscon to mt8516.dtsi

2020-05-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds support for the PERICFG register range as a syscon. This will soon be used by the MediaTek Ethernet MAC driver for NIC configuration. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 5 + 1 file changed, 5 insertions(+)

[PATCH 05/11] net: core: provide devm_register_netdev()

2020-05-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Provide devm_register_netdev() - a device resource managed variant of register_netdev(). This new helper will only work for net_device structs that have a parent device assigned and are devres managed too. Signed-off-by: Bartosz Golaszewski ---

[PATCH 11/11] ARM64: dts: mediatek: enable ethernet on pumpkin boards

2020-05-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add remaining properties to the ethernet node and enable it. Signed-off-by: Bartosz Golaszewski --- .../boot/dts/mediatek/pumpkin-common.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi

[PATCH 03/11] net: ethernet: mediatek: rename Kconfig prompt

2020-05-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski We'll soon by adding a second MediaTek Ethernet driver so modify the Kconfig prompt. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mediatek/Kconfig

[PATCH 04/11] net: ethernet: mediatek: remove unnecessary spaces from Makefile

2020-05-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The Makefile formatting in the kernel tree usually doesn't use tabs, so remove them before we add a second driver. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 10/11] ARM64: dts: mediatek: add ethernet pins for pumpkin boards

2020-05-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Setup the pin control for the Ethernet MAC. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi

[PATCH 08/11] ARM64: dts: mediatek: add the ethernet node to mt8516.dtsi

2020-05-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add the Ethernet MAC node to mt8516.dtsi. This defines parameters common to all the boards based on this SoC. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 12 1 file changed, 12 insertions(+) diff --git

[PATCH v2] block: Make request_queue.rpm_status an enum

2020-05-05 Thread Geert Uytterhoeven
request_queue.rpm_status is assigned values of the rpm_status enum only, so reflect that in its type. Signed-off-by: Geert Uytterhoeven Acked-by: Rafael J. Wysocki --- Perhaps this was done to avoid the need to #include ? Let's see what kbuild has to report about this... v2: - Add Acked-by.

[PATCH 02/11] dt-bindings: new: add yaml bindings for MediaTek Ethernet MAC

2020-05-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds yaml DT bindings for the MediaTek Ethernet MAC present on the mt8* family of SoCs. Signed-off-by: Bartosz Golaszewski --- .../bindings/net/mediatek,eth-mac.yaml| 80 +++ 1 file changed, 80 insertions(+) create mode 100644

[PATCH 09/11] ARM64: dts: mediatek: add an alias for ethernet0 for pumpkin boards

2020-05-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add the ethernet0 alias for ethernet so that u-boot can find this node and fill in the MAC address. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-05 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds the driver for the MediaTek Ethernet MAC used on the MT8* SoC family. For now we only support full-duplex. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/Kconfig |6 + drivers/net/ethernet/mediatek/Makefile |1 +

Re: [PATCH 4/4 v2] firmware: stratix10-svc: Slightly simplify code

2020-05-05 Thread Richard Gong
Hi, On 5/2/20 3:49 AM, Christophe JAILLET wrote: Le 01/05/2020 à 18:55, Richard Gong a écrit : Hi, On 5/1/20 10:48 AM, Christophe JAILLET wrote: Le 01/05/2020 à 17:40, Richard Gong a écrit : Hi, On 4/29/20 1:52 AM, Christophe JAILLET wrote: Replace 'devm_kmalloc_array(... | __GFP_ZERO)'

Re: [PATCH v2 1/1] fs/splice: add missing callback for inaccessible pages

2020-05-05 Thread Christian Borntraeger
On 05.05.20 15:55, Ulrich Weigand wrote: > On Tue, May 05, 2020 at 05:34:45AM -0700, Dave Hansen wrote: >> On 5/4/20 6:41 AM, Ulrich Weigand wrote: >>> You're right that there is no mechanism to prevent new references, >>> but that's really never been the goal either. We're simply trying >>>

Re: [PATCH] bitops: avoid clang shift-count-overflow warnings

2020-05-05 Thread Christian Brauner
On Tue, May 05, 2020 at 03:54:57PM +0200, Arnd Bergmann wrote: > Clang normally does not warn about certain issues in inline functions when > it only happens in an eliminated code path. However if something else > goes wrong, it does tend to complain about the definition of hweight_long() > on

Re: [PATCH v5 5/5] drivers/tty/serial: add LiteUART driver

2020-05-05 Thread Andy Shevchenko
On Mon, May 4, 2020 at 4:44 PM Mateusz Holenko wrote: > On Tue, Apr 28, 2020 at 5:50 PM Andy Shevchenko > wrote: > > On Sat, Apr 25, 2020 at 2:45 PM Mateusz Holenko > > wrote: ... > > > Signed-off-by: Filip Kokosinski > > > Signed-off-by: Mateusz Holenko > > > > Co-developed-by? > > Most

[PATCH] mtd: lpddr: fix excessive stack usage with clang

2020-05-05 Thread Arnd Bergmann
Building lpddr2_nvm with clang can result in a giant stack usage in one function: drivers/mtd/lpddr/lpddr2_nvm.c:399:12: error: stack frame size of 1144 bytes in function 'lpddr2_nvm_probe' [-Werror,-Wframe-larger-than=] The problem is that clang decides to build a copy of the mtd_info

Re: [PATCH v1] dt-bindings: net: nxp,tja11xx: rework validation support

2020-05-05 Thread Andrew Lunn
On Tue, May 05, 2020 at 12:42:15PM +0200, Oleksij Rempel wrote: > To properly identify this node, we need to use ethernet-phy-id0180.dc80. > And add missing required properties. > > Signed-off-by: Oleksij Rempel > --- > .../devicetree/bindings/net/nxp,tja11xx.yaml | 55 --- > 1

Re: [PATCH v2 1/1] fs/splice: add missing callback for inaccessible pages

2020-05-05 Thread Christian Borntraeger
On 05.05.20 14:34, Dave Hansen wrote:[...] >> I'm not sure what exactly the requirements for your use case are; if those >> are significantly differently, maybe we can work together to find an >> approach that works for both? > > I'm actually trying to figure out what to do with AMD's SEV.

[PATCH] drm/amdgpu: allocate large structures dynamically

2020-05-05 Thread Arnd Bergmann
After the structure was padded to 1024 bytes, it is no longer suitable for being a local variable, as the function surpasses the warning limit for 32-bit architectures: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:587:5: error: stack frame size of 1072 bytes in function 'amdgpu_ras_feature_enable'

[PATCH] fpga: zynqmp: fix modular build

2020-05-05 Thread Arnd Bergmann
Two symbols need to be exported to allow the zynqmp-fpga module to get loaded dynamically: ERROR: modpost: "zynqmp_pm_fpga_load" [drivers/fpga/zynqmp-fpga.ko] undefined! ERROR: modpost: "zynqmp_pm_fpga_get_status" [drivers/fpga/zynqmp-fpga.ko] undefined! To ensure this is done correctly, also

Re: [PATCH v2] PCI/ASPM: Enable ASPM for root complex <-> bridge <-> bridge case

2020-05-05 Thread Kai-Heng Feng
> On May 5, 2020, at 21:38, Bjorn Helgaas wrote: > > On Tue, May 05, 2020 at 08:27:59PM +0800, Kai-Heng Feng wrote: >> The TI PCIe-to-PCI bridge prevents the Intel SoC from entering power >> state deeper than PC3 due to disabled ASPM, consumes lots of unnecessary >> power. On Windows ASPM L1

HELLO

2020-05-05 Thread Mrs Suzara Maling Wan
i am Mrs Suzara Maling Wan from (Philippine) but based in West Africa Country since eight years as a business woman dealing with gold exportation, I have a dream and desire of building an orphanage home in your country, and i have a deposit fund to the project, but presently my health condition we

[PATCH] crypto: curve25519-hacl64 - Disable fortify-source for clang-10

2020-05-05 Thread Arnd Bergmann
clang-10 produces a warning about excessive stack usage, as well as rather unoptimized object code when CONFIG_FORTIFY_SOURCE is set: lib/crypto/curve25519-hacl64.c:759:6: error: stack frame size of 2400 bytes in function 'curve25519_generic' [-Werror,-Wframe-larger-than=] Jason Donenfeld

Re: [PATCH v3 1/3] media: rkvdec: Fix .buf_prepare

2020-05-05 Thread Ezequiel Garcia
On Tue, 2020-05-05 at 15:56 +0200, Tomasz Figa wrote: > Hi Ezequiel, > > On Tue, May 5, 2020 at 3:41 PM Ezequiel Garcia wrote: > > The driver should only set the payload on .buf_prepare > > if the buffer is CAPTURE type, or if an OUTPUT buffer > > has a zeroed payload. > > Thanks for the patch.

[PATCH] [net-next] dsa: sja1105: dynamically allocate stats structure

2020-05-05 Thread Arnd Bergmann
The addition of sja1105_port_status_ether structure into the statistics causes the frame size to go over the warning limit: drivers/net/dsa/sja1105/sja1105_ethtool.c:421:6: error: stack frame size of 1104 bytes in function 'sja1105_get_ethtool_stats' [-Werror,-Wframe-larger-than=] Use dynamic

[PATCH v2 3/3] arm64: perf_event: Fix time_offset for arch timer

2020-05-05 Thread Leo Yan
'userpg->time_offset' is assigned to the negative 'now', 'now' if the value of sched clock and this value cannot reflect the time offset for arch timer's raw counter prior to sched clock's registration. To fix this issue, this patch invokes arch_timer_get_epoch_offset() to read time offset prior

Re: [PATCH v2 1/1] fs/splice: add missing callback for inaccessible pages

2020-05-05 Thread Ulrich Weigand
On Tue, May 05, 2020 at 05:34:45AM -0700, Dave Hansen wrote: > On 5/4/20 6:41 AM, Ulrich Weigand wrote: > > You're right that there is no mechanism to prevent new references, > > but that's really never been the goal either. We're simply trying > > to ensure that no I/O is ever done on a page

Re: [PATCH v3 1/3] media: rkvdec: Fix .buf_prepare

2020-05-05 Thread Tomasz Figa
Hi Ezequiel, On Tue, May 5, 2020 at 3:41 PM Ezequiel Garcia wrote: > > The driver should only set the payload on .buf_prepare > if the buffer is CAPTURE type, or if an OUTPUT buffer > has a zeroed payload. Thanks for the patch. Just one question below. Where does the requirement to set OUTPUT

[PATCH v2 2/3] clocksource/drivers/arm_arch_timer: Handle time offset prior to epoch

2020-05-05 Thread Leo Yan
Since arch timer can be enabled at any time during boot, this patch changes to invoke variant sched_clock_register_epoch() so it can retrieve time offset prior to epoch (in nanosecond). Arch timer driver doesn't directly use this time offset, but it needs to pass this value to Perf framework to

[PATCH] bitops: avoid clang shift-count-overflow warnings

2020-05-05 Thread Arnd Bergmann
Clang normally does not warn about certain issues in inline functions when it only happens in an eliminated code path. However if something else goes wrong, it does tend to complain about the definition of hweight_long() on 32-bit targets: include/linux/bitops.h:75:41: error: shift count >= width

[PATCH v2 1/3] time/sched_clock: Add new variant sched_clock_register_epoch()

2020-05-05 Thread Leo Yan
Except the sched clock's raw counter is used by sched clock itself, it also can be used by other purposes in the same system, e.g. the raw counter can be injected into hardware tracing data (like Arm's SPE) and Perf tool can capture trace data and extract the raw counter from it which finally can

[PATCH v2 0/3] arm64: perf_event: Fix time offset prior to epoch

2020-05-05 Thread Leo Yan
This patch set is to fix time offset prior to epoch for Arm arch timer. This series is mainly following on suggestions on LKML [1]. To acheive the accurate time offset for a clock source prior to epoch, patch 01 adds a new variant sched_clock_register_epoch() which allows to output an extra

[PATCH] crypto: blake2b - Fix clang optimization for ARMv7-M

2020-05-05 Thread Arnd Bergmann
When building for ARMv7-M, clang-9 or higher tries to unroll some loops, which ends up confusing the register allocator to the point of generating rather bad code and using more than the warning limit for stack frames: warning: stack frame size of 1200 bytes in function 'blake2b_compress'

Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup

2020-05-05 Thread Shakeel Butt
On Mon, May 4, 2020 at 11:30 PM Dave Chinner wrote: > > On Tue, Apr 28, 2020 at 10:27:32PM -0400, Johannes Weiner wrote: > > On Wed, Apr 29, 2020 at 07:47:34AM +1000, Dave Chinner wrote: > > > On Tue, Apr 28, 2020 at 12:13:46PM -0400, Dan Schatzberg wrote: > > > > This patch series does some > >

[PATCH v2] fs: jfs: fix a possible data race in txBegin()

2020-05-05 Thread Jia-Ju Bai
The functions txBegin() and txLazyCommit() can be concurrently executed in the following call contexts: Thread1: jfs_write_inode() jfs_commit_inode() txBegin() Thread2: jfs_lazycommit() txLazyCommit() In txBegin(): tblk->next = tblk->last = tblk->xflag = tblk->flag =

[PATCH v2] fs: jfs: fix a possible data race in metapage_writepage()

2020-05-05 Thread Jia-Ju Bai
The functions metapage_writepage() and lmPostGC() can be concurrently executed in the following call contexts: Thread1: metapage_writepage() Thread2: lbmIODone() lmPostGC() In metapage_writepage(): if (mp->log && !(mp->log->cflag & logGC_PAGEOUT)) In lmPostGC():

Re: [PATCH v5 0/4] Introduce the for_each_set_clump macro

2020-05-05 Thread Andy Shevchenko
On Mon, May 4, 2020 at 5:41 PM William Breathitt Gray wrote: > On Mon, May 04, 2020 at 02:41:09PM +0300, Andy Shevchenko wrote: > > On Sun, May 03, 2020 at 04:38:36AM +0530, Syed Nayyar Waris wrote: ... > > Looking into the last patches where we have examples I still do not see a > > benefit of

Re: [PATCH v2 1/2] init/kconfig: Add LD_VERSION Kconfig

2020-05-05 Thread Michael Ellerman
Will Deacon writes: > On Mon, May 04, 2020 at 09:11:12AM +0200, Geert Uytterhoeven wrote: >> On Mon, Mar 30, 2020 at 1:42 PM Amit Daniel Kachhap >> wrote: >> > This option can be used in Kconfig files to compare the ld version >> > and enable/disable incompatible config options if required. >> >

Re: [PATCH 3/3] platform/x86: Intel PMT Telemetry capability driver

2020-05-05 Thread Andy Shevchenko
On Tue, May 5, 2020 at 5:32 AM David E. Box wrote: ... > Register mappings are not provided by the driver. Instead, a GUID is read > from a header for each endpoint. The GUID identifies the device and is to > be used with an XML, provided by the vendor, to discover the available set > of

Re: fs: jfs: fix a possible data race in txBegin()

2020-05-05 Thread Jia-Ju Bai
On 2020/5/5 21:23, Dave Kleikamp wrote: On 5/5/20 12:12 AM, Markus Elfring wrote: I am not sure how to add the tag "Fixes"... How helpful do you find the available software documentation?

Re: [PATCH v2 2/2] usb: xhci: Load Raspberry Pi 4 VL805's firmware

2020-05-05 Thread Nicolas Saenz Julienne
On Tue, 2020-05-05 at 15:39 +0200, Matthias Brugger wrote: > > On 05/05/2020 14:53, Nicolas Saenz Julienne wrote: > > Hi Matthias, > > > > On Tue, 2020-05-05 at 14:15 +0200, Matthias Brugger wrote: > > > On 30/04/2020 15:04, Nicolas Saenz Julienne wrote: > > > > When needed, RPi4's co-processor

Re: [PATCH 3/4 v2] firmware: stratix10-svc: Fix some error handling paths in 'stratix10_svc_drv_probe()'

2020-05-05 Thread Richard Gong
Hi, Similarly we need add error handling for controller and chans, something like below: @@ -997,13 +997,17 @@ static int stratix10_svc_drv_probe(struct platform_device *pdev) /* allocate service controller and supporting channel */ controller = devm_kzalloc(dev,

Re: KASAN: slab-out-of-bounds Write in betop_probe

2020-05-05 Thread Dmitry Vyukov
,On Tue, May 5, 2020 at 3:23 PM Oliver Neukum wrote: > > Am Montag, den 10.02.2020, 17:16 -0800 schrieb syzbot: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:e5cd56e9 usb: gadget: add raw-gadget interface > > git tree: https://github.com/google/kasan.git

[PATCH trivial] CIFS: Spelling s/EACCESS/EACCES/

2020-05-05 Thread Geert Uytterhoeven
As per POSIX, the correct spelling is EACCES: include/uapi/asm-generic/errno-base.h:#define EACCES 13 /* Permission denied */ Fixes: b8f7442bc46e48fb ("CIFS: refactor cifs_get_inode_info()") Signed-off-by: Geert Uytterhoeven --- fs/cifs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH trivial v2 resend] scif: Spelling s/EACCESS/EACCES/

2020-05-05 Thread Geert Uytterhoeven
As per POSIX, the correct spelling is EACCES: include/uapi/asm-generic/errno-base.h:#define EACCES 13 /* Permission denied */ Signed-off-by: Geert Uytterhoeven --- v2: - Add POSIX reference. --- include/linux/scif.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v3 2/3] media: uapi: Add VP9 stateless decoder controls

2020-05-05 Thread Ezequiel Garcia
From: Boris Brezillon Add the VP9 stateless decoder controls plus the documentation that goes with it. Signed-off-by: Boris Brezillon Signed-off-by: Ezequiel Garcia --- .../userspace-api/media/v4l/biblio.rst| 10 + .../media/v4l/ext-ctrls-codec.rst | 581

[PATCH v3 3/3] media: rkvdec: Add the VP9 backend

2020-05-05 Thread Ezequiel Garcia
From: Boris Brezillon The Rockchip VDEC supports VP9 profile 0 up to 4096x2304@30fps. Add a backend for this new format. Signed-off-by: Boris Brezillon Signed-off-by: Ezequiel Garcia --- drivers/staging/media/rkvdec/Makefile |2 +- drivers/staging/media/rkvdec/rkvdec-vp9.c | 1577

[PATCH v3 0/3] media: rkvdec: Add a VP9 backend

2020-05-05 Thread Ezequiel Garcia
Third iteration of the VP9 stateless codec uAPI, plus support for Rockchip VDEC. This series addresses an issue I found while testing, not sure how it slipped before! See patch 1. Keep in mind the same issue should likely be fixed on Hantro and Cedrus. We can create a helper for it as a

Re: [PATCH] sched/fair: Fix nohz.next_balance update

2020-05-05 Thread Peng Liu
On Mon, May 04, 2020 at 05:17:11PM +0200, Vincent Guittot wrote: > On Sun, 3 May 2020 at 10:34, Peng Liu wrote: > > > > commit c5afb6a87f23 ("sched/fair: Fix nohz.next_balance update") > > During idle load balance, this_cpu(ilb) do load balance for the other > > idle CPUs, also gather the

[PATCH v3 1/3] media: rkvdec: Fix .buf_prepare

2020-05-05 Thread Ezequiel Garcia
The driver should only set the payload on .buf_prepare if the buffer is CAPTURE type, or if an OUTPUT buffer has a zeroed payload. Fix it. Fixes: cd33c830448ba ("media: rkvdec: Add the rkvdec driver") Signed-off-by: Ezequiel Garcia --- drivers/staging/media/rkvdec/rkvdec.c | 10 +- 1

[PATCH] coresight: cti: remove incorrect NULL return check

2020-05-05 Thread Calvin Johnson
fwnode_find_reference() doesn't return NULL and hence that check should be avoided. Signed-off-by: Calvin Johnson --- drivers/hwtracing/coresight/coresight-cti-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 2/2] usb: xhci: Load Raspberry Pi 4 VL805's firmware

2020-05-05 Thread Matthias Brugger
On 05/05/2020 14:53, Nicolas Saenz Julienne wrote: > Hi Matthias, > > On Tue, 2020-05-05 at 14:15 +0200, Matthias Brugger wrote: >> >> On 30/04/2020 15:04, Nicolas Saenz Julienne wrote: >>> When needed, RPi4's co-processor (called VideoCore) has to be instructed >>> to load VL805's firmware

Re: [PATCH v2] PCI/ASPM: Enable ASPM for root complex <-> bridge <-> bridge case

2020-05-05 Thread Bjorn Helgaas
On Tue, May 05, 2020 at 08:27:59PM +0800, Kai-Heng Feng wrote: > The TI PCIe-to-PCI bridge prevents the Intel SoC from entering power > state deeper than PC3 due to disabled ASPM, consumes lots of unnecessary > power. On Windows ASPM L1 is enabled on the device and its upstream > bridge, so it can

Re: perf build error with gcc 10 on arm and aarch64

2020-05-05 Thread Leo Yan
On Tue, May 05, 2020 at 04:11:14PM +0300, Thomas Backlund wrote: > Den 05-05-2020 kl. 07:10, skrev Leo Yan: > > > > Hi Thomas, > > > > [ + Mathieu/Mike/Suzuki ] > > > > On Mon, May 04, 2020 at 10:22:27PM +0300, Thomas Backlund wrote: > > > This is building perf from kernel-5.6.10 on armv7hl and

Re: [PATCH 1/1] selftests/bpf: add cls_redirect classifier

2020-05-05 Thread Daniel Borkmann
On 5/5/20 1:48 AM, Alexei Starovoitov wrote: On Sat, May 02, 2020 at 01:48:51AM +0200, Daniel Borkmann wrote: On 4/27/20 11:45 AM, Lorenz Bauer wrote: On Sun, 26 Apr 2020 at 18:33, Alexei Starovoitov wrote: [...] +/* Linux packet pointers are either aligned to NET_IP_ALIGN (aka 2 bytes), +

[PATCH] perf cs-etm: Move defined of traceid_list

2020-05-05 Thread Leo Yan
The variable 'traceid_list' is defined in the header file cs-etm.h, if multiple C files include cs-etm.h the compiler might complaint for multiple definition of 'traceid_list'. To fix multiple definition error, move the definition of 'traceid_list' into cs-etm.c. Fixes: cd8bfd8c973e ("perf

Re: [PATCH 4.19 28/37] dmaengine: dmatest: Fix iteration non-stop logic

2020-05-05 Thread Pavel Machek
On Tue 2020-05-05 16:19:11, Andy Shevchenko wrote: > On Tue, May 5, 2020 at 3:58 PM Pavel Machek wrote: > > On Tue 2020-05-05 15:51:16, Andy Shevchenko wrote: > > > On Tue, May 5, 2020 at 3:37 PM Pavel Machek wrote: > > > > > So, to the point, the conditional of checking the thread to be > > >

<    6   7   8   9   10   11   12   13   14   15   >